labofsahil/github-event-dataset-2012 huggingface dataset:
instead of: 

```json
{
  "carrier":"Orange Internet Móvil",
  "apn":"orangeworld",
  "user":"orange",
  "password":"orange",
  "authtype":"1","
  type":["default"],
  "voicemail":"242",
  "enableStrict7BitEncodingForSms":true
}
```

I thought you suggested to use:
```json

{
  "carrier":"Orange Internet Móvil",
  "apn":"orangeworld",
  "user":"orange",
  "password":"orange",
  "authtype":"1","
  type":["default"]
},
{
  "voicemail":"242",
  "enableStrict7BitEncodingForSms":true
  type":["operatorvariant"]
}
```

… which would make sense, imho, especially if that allows to avoid modifying the JS code in `operator_variant.js`. One of the main point of this JSON database is to avoid having to share a JS library, that’s why I’d prefer to keep a compact / trivial code for retrieving all properties from the JSON files.
Oh, I think it won't affect the result.
@vingtetun This was taken from the banner code in window_manager.js. I see that now that code is in system_banner.js, so maybe I should just be using that, although adding in the "Report" button makes that more complicated.
I don't know if this is expected, 
display SIM PIN Dialog whenever the user unlocks the lockscreen?
But how about an user who disables the lockscreen? Never see it until an application has telephony permission is opened?
Oops.  Thanks for noticing that!  I'll update this file and the one below.
Then it’s too early to land this. We cann’t rely on such an attribute.
There is no strong reason for that, just for not using span again:
https://github.com/basiclines/gaia/commit/fc0d72fa839714fbe4b2ec1c65bee4775698e1e5
I think that the value will be uniformity.
Ok, I'll refine it.
you're right- removed.
It can also be <code>target = this.anchor.children[0].firstElementChild;</code>
I placed all the song elements in <code>this.anchor</code>, that might be easier for reviewers to read.
This also used in line 839, see <code>songElements[this.currentIndex].firstElementChild</code> 
But I am fine with <code>querySelector</code>.
Sure, let's do it, apparently in gecko getElementById is faster:

http://jsperf.com/getelementbyid-vs-queryselector/11
Agreed. And in the context of the Kudu service, there is very little concern about disclosure since only the owner can access it in the first place.
That would make more sense to me. And sounds good.  

--  
Nicholas Weaver
EMC Corporation


On Tuesday, September 4, 2012 at 3:49 PM, Mehdi ABAAKOUK wrote:

> In lib/project_razor/model/debian.rb:
> > @@ -156,10 +153,6 @@ def fsm_tree > :mk_call => :postinstall, > :boot_call => :postinstall, > :preseed_end => :postinstall, > - :source_fix => :postinstall,  
> Sorry, I want to say these states are not used in the debian model (perhaps due to a spelling mistake).
> With or without my changes apt_get* are still calling back but without a matching state for each action.
> The source_fix state doesn't have a sens because it change things related to ubuntu so I have removed it from the debian model.  
> Perhaps I can clean the patch by keeping the apt_get* state, and just correct the fsm tree to have the same spelling than the postinstall script
> And remove only the source_fix stuff.  
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/puppetlabs/Razor/pull/186/files#r1527618).  
>  
>  
>
add

    - feel free to "ping" the team by adding a short comment to your pull request if it's been more than a week with no reply
同様に「」ではなく ``
さいごが：の場合は、「。」じゃなくて「：」にしよう。
@jcredding - No, haven't gotten that far yet :)

On Fri, Aug 17, 2012 at 12:03 PM, Collin Redding
<notifications@github.com>wrote:

> In README.md:
>
> > @@ -18,7 +18,79 @@ Or install it yourself as:
> >
> >  ## Usage
> >
> > -TODO: Write usage instructions here
> > +Create a command object:
> > +
> > +```ruby
> > +cmd = Scmd.new("echo hi")
> > +
> > +cmd.to_s    #=> "echo hi"
> > +cmd.inspect #=>
>
> Does the inspect return nothing / empty string? Curious if that's what you
> are trying to convey.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/teaminsight/scmd/pull/1/files#r1404734>.
>
>
Haha, no idea, will fix
Rewrite as 
```python
print("Saved '%s'" % savename)
```
That's what the implementation in the base Aggregator trait is for; if you have a semi-group, don't use MonoidAggregator.
Please move this into Browser.js to be more in ine with other Leaflet code
That is, instead of submitting the form using an onchange event. But I guess this works - just more complicated (IMHO) than the JS based solution.
doesn't it make sense to add limit(1) automatically to the whereclause?
I've copied this "not" from svn.py, I think it should be removed in both places.
Weird that they're stored as Base64 values? Why?
jQuery’s .live() has been deprecated as of version 1.7.
There's a README in this directory. Make sure you add the source of the swipe library.
would be nice to remove this if/when we change Pasteup (cc @ahume)
I've give som try to this and the results obtained via chmod are somehow strange. I thus dig into the documentation and found that it is Linux only to be able to work on permission on socket (see note in http://linux.die.net/man/7/unix).
I propose to use:
```C
    /* Set file mode: will not fully work on most system, the group
     * permission is not changed on some Linux and *BSD won't do the
     * chmod. */
    ret = fchmod(this->socket, S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP);
```
It seems consistent with other part of the decoding engine. Doing this.
We need to work on the content of the UDP packet. The Packet has already been successfully decoded as UDP and thus we can use p->payload.
n, nto, time, timeto
belongs to user 
the owner should appear in the view
uninstiall -> uninstall
I find `let { promise, resolve, reject } = defer();` much better, but I don't mind this either.
can we move this to the `window/utils.js` ?
Seems like this set of paths is going to be the common case. Is it worth making it the default if `paths` isn't specified at all?
OMG!  Monster regexp!  @fmarier, look what you've done!
Every time an email/password is staged, save off the staged email and password to use on completion.
good point.  probably type, too, right?  removed compare on type as well.
nit: blank before the opening bracket.
Is this the right name for this error anymore? It changed from having a message about not being a directory to being about the path existing but not as a directory.
OK.  I can see why that would be attractive, but it isn't a good strategy.  By ignoring all the methods other than the tiny number this object is setting up other code - and other developers - for failure tomorrow.  People reasonably expect that invoking a method on scope will cause some effect, and this breaks that assumption.  That can lead to nasty problems - consider, for example, someone walking up a tree of scopes until they hit the top.  That will infloop with this code.

The two approaches I can see that are reasonable here would be:
* create a new scope object, detached from everything, and pass it instead.
* have different code paths to evaluate and import Ruby things.
For the test starting on 494, the description says "the range matches", but the time is stubbed as 22:30 and the range starts at 23:00, so how does it match?
Indeed, that should be the case. 1.8.7 doesn't return `x`, but 1.9.3 does. Hmmm.

```
ruby 1.8.7 (2012-06-29 patchlevel 370) [i686-darwin12.2.0]
.F.......

1)
Array#delete returns the last element in the array for which object is equal under #== FAILED
Expected 3
to be identical to #<MockObject:0x10f78b3a0 @name="delete", @null=nil>
```

Should we check 1.8.7 or not?
The thought was that no colors should be hardcoded, as suggested in #5247.

I guess the borders should inherit from the default borders.
As long as the character count doesn't go over 80, you can keep them on the same line.
the same in the rest of the block
If the min is 5.3.3 why not remove the 5.3 too?
Uhm `~1.3.0`? Why less than 1.5?
You need to be running ejabberd. Will amend README.
I think it should be safe to remove our gofreerange.com account, as we now have cabinet office addresses.  Would you be able to check that we've been added to the govuk-exceptions list please, David?
don't reinstantiate `classes()` all the time
`$doctrine` is not used in this method.
Hah, you would've liked my original version better. it had "accept" on each node type :)

But yes: I'm trying to not add APIs the real DOM doesn't have. In real DOM, the only way to dispatch is via "switch" on nodeType. I'd like to reach a point eventually where code written against the html5lib trees "just works" with dart:html and vice versa.
what's going on here? does _get_cases_by_status not reliably return the same kind of container type? (or sometimes case objects vs. case ids?). anyway, if this snippet is necessary, don't repeat it three times. make an inline def/closure that wraps the call and cleans up the return value
That's really odd. We should look into this more tomorrow. I'm interested to debug why those don't work.
also check for variables that have been unset?
easyblock spec should be the first line, e-Core is the "official" name of the software package I believe, so:

easyblock='Binary'

name='e-Core'
version='1.5.2'
I'm not happy with this part of the code. There should be a way of configuring the endpoint address through configuration. Maybe this is OK to leave in for the baseline?
There's one parenthesis too many on this line.
In the future, just go ahead and uncapitalize all filenames and references. You probably recall how weird Heroku got with filename capitalization stuff last time we deployed.
They are eventually used on the leaderboard page to show a user's first name and last initial, which was a privacy/legal requirement and is standard on most Facebook apps.
The other MPL 2.0 boilerplates have this trailing period; please restore it.
The /b to test for bedrock pages on stage
Put this back in. This is not related to this problem. We'll talk about this today.
Actually mp4 is a container, which can contain aac (which faad decodes), but also pretty much everything including audio and video. Which is why it makes sense to have it supported by gstreamer.
dont bump versions of projects that are not yours, that's not related to the commit and it's up to the author(s) to decide
I don't like this. 
The only reason you'd want to delete an event is if it was accidentally added wrong. For example, if you click the wrong duplicate button and immediately realise your mistake then you might want to delete it. 

What about instead that we don't actually create copy of the event but instead that the event_duplicate page, doesn't do ANY writes but just takes, the original instance and pre-populates the add_event form with that.
How about: "The following values have no corresponding Zotero field"
why use the session here?
I'll merge if you make this ending comma a period.
Oh, didn't even notice that :p
In that case I will change it a bit so it will set sprinting to false if you have less than 3 hunger icons
Why is this introduced here, but not in any other pom.xml?
What OS/filesystem do you have?
Please, keep in mind, that logo is changing depending on version (Community or Enterprise), and it's much easier and covinient to override a style, than a template, right?
and above too, I guess? ;-)
ok
To Alex: I'm really not sure if we need these alerts at all.
can come back to the 8 sections above and add icons to icon-class in bootstrap. i'll make note
Wheres the opening <ul>?
`vidscraper.videos.Video(url)` won't actually load the URL.
Yeah, this was the result of a merge conflict where I accidentally chose the wrong version... this was not intentionally, and you're totally right.
Are you asking for the `LoginId` model object be documented more clearly, or just thinking out loud as you go through the review?
I tested this and it does not render properly.
Are we worried about sending out group IDs of groups that have their visibility set to private?
Why did you hide all the validator documentation?
Should have validator for principal_id
We should **never** silently drop results just because we couldn't find a corresponding java element. This has to be investigated, but AFAIK the element is used only for displaying the match under the 'logical' enclosing entity. It is nice to be precise (and report it against the innermost element), but anything (including the project itself, worst case) might work. We can:

* look up repeatedly, from the innermost symbol, through the owner chain, the first Java Element we can find
* a totally different approach: java elements are handle only: they are more or less *paths*, and they need not exist in the workspace. We can try to create a JavaElement for the symbol, *without* looking it up in the existing structure.
I was thinking about just making the registry creation include the default check and then the api to add new checks would be:

```ruby
#app config from a client
OKComputer::Registry.register("new custom check", CustomCheck.new)
```
Might be tempted to suggest using goto error handler or something here just to clean this up a bit. But I'll think it through.
please increase this.. i keep pressing the monument rather than unselecting/selecting the checkbox
I know but it was just to be consistant :) What should we do @willdurand  ?
Is it possible to use several SASL Mechanisms in same session?
Code from a separate PR, not mine. Using `FontHelpers.TryGetFontFamilyFromStack(Constants.DEFAULT_EDITOR_FONT_FAMILY);` and `Constants.DEFAULT_EDITOR_FONT_SIZE;` as the null behaviour is acceptable.
Not a big deal to inject it though as it can be refactored out just as easily. I'll throw that in asap.
The mac scripts assume that ``brackets-shell`` is the current directory. Can we update this to match?
the actual method name is `Imagick:: setColorspace`
The explicit `NSValue *` return type on the literal here should be unnecessary.
The whole expression should be in parentheses: https://github.com/github/objective-c-conventions#expressions
`activeSubscribables` needs to stay synchronized from the check up to and including when the new subscribable is added. Otherwise, you'll have a race condition between two threads checking and adding subscribables.
Not strictly speaking. You can have scripts that are just doing routing stuff, for example. In this case, 'command' isn't really accurate. It's more the things it will hear and respond to, ie URLs with png, jpg, gif.
your guess is exact. In fact normally it should be the width of the display (`blit_buffer:getWidth()`).
In `renderUtf8Text`, where the blit_buffer is an input param,  this info is retrieved directly from that object; but since in current function there is no need of blit_buffer, I thought better to use as input param directly the maximum width that is considered valid; and remove blit_buffer as input param.
Change to Bob Martin ;)
Why is this commented out?  If it's not used / needed anymore it should be removed
Ah I see, sure.
Also, you might mention that they only need to set this once. That is, we won't overwrite it if they don't send it to us when updating the user.
In other words, the API should look almost exactly like `Fetch`, except with a few extra parameters needed for a clone. :)
forget what i posted, you're right. 

On 15.12.2012, at 19:51, Eric89GXL <notifications@github.com> wrote:

> In mne/fiff/tests/test_raw.py:
> 
> > @@ -597,6 +597,20 @@ def test_raw_index_as_time():
> >      t1 = raw.index_as_time([100], False)[0]
> >      t2 = raw.index_as_time([100], True)[0]
> >      assert_true((t2 - t1) == t0)
> > +    # ensure we can go back and forth
> > +    t3 = raw.index_as_time(raw.time_as_index([0], True), True)
> > +    assert_array_almost_equal(t3, [0.0], 2)
> > +    t3 = raw.index_as_time(raw.time_as_index(raw.info['sfreq'], True), True)
> > +    assert_array_almost_equal(t3, [raw.info['sfreq']], 2)
> > +    t3 = raw.index_as_time(raw.time_as_index(raw.info['sfreq'], False), False)
> > +    assert_array_almost_equal(t3, [raw.info['sfreq']], 2)
> > +    i0 = raw.time_as_index(raw.index_as_time([0], True), True)
> > +    assert_true(i0[0] == 0)
> > +    i1 = raw.time_as_index(raw.index_as_time([100], True), True)
> These are the relevant sorts of tests. They would have failed before...
> 
> —
> Reply to this email directly or view it on GitHub.
>
remove, otherwise it opens an additional empty figure (pl.figure() is called in plot function below)
avoid global seed.

rng = np.random.RandomState(0)
a = rng.randn(...)
Please add the license.
For update, I was expecting to see an optional key of `private_key` being a boolean, where true indicates a request to regenerate a key. I'd also like to have the resource support setting a new public key if provided.
Should there be double spaces between fields?
Also, maybe explain that cron's month/dayofweek fields are zero-based vs the minute, hour and date.
By changing these to kwargs, they are no longer required, so we should probably check that they are set before using them.
can someone tell me what i would need to write here?
You should break the line after the first word that crosses the 72 character.
Yeah I tend to agree on second thought.
I didn't figure it would go over, but I thought I would at least try :)
Used list to concatenate string.

>Again, it seems as though the terms should be extracted from the sympy expression and then converted to the desired string.

This is not a sympy expression, it is a LPolyElement.
Working and fixed to this. Thank you.
Там комбобокс. Первое поле - пустое. Оно и есть 0. Тоесть никакой
блогсервис не выбран
Sí, creo que un margen inferior debería alcanzar. (O un padding inferior para `body`)
Ah, no me di cuenta.

Sí, si no te jode, por favor.
add to admin.css ?
#yourVersion {white-space: nowrap}
Could you add a little more description to this comment? I'm worried this will live on in the code for years and nobody will know what you meant. ;)
Shouldn't it be `if (locateDate > onlineDate && onlineDate != 0)`? We want to refresh the image if it is hosted on a third-party server which does not support `Last-Modified`.
would be nice if we could pre-bake this in the closure above before `return function` so we're not doing it per value
Looks fine to me, it does a rename at the end of the try:.
Why not hold a reference to the future and use it to send the cancelation? All this isCancelled calls looks very primitive way of dealign with cancellations, pre-JDK5 style and we're coding to JDK6.

You seemed quite worried about writing a few extra lines to deal with CacheJoinInfo externalizer, surprised that you're happy with all this this on the other hand which really does smell of boiler plate code.

Wrt jboss-marshalling, maybe the library needs to behave more nicely with interruptions. I don't see why it should not do so.
All this seems copy/paste from onEntryEviction(). Does it really make sense? Remember that there's no cache.expire() operation per se...
OK, I'll rename it to "havingHeaderWithGivenName"
Order of operations would be clearer with some extra parentheses here.
I've no problem with having two variables containing the same content if it eases readability. If this variable is *always* the same as ```j_unique``` then simply doing:

```
self._client_point_index_map = self.j_unique
```

Would be an improvement in my eyes.

If its not always (that is, throughout its lifetime) equal, then:

```
self._client_point_index_map = self.j_unique.copy()
```

The only reason for me picking up on this nit is because the line ```np.delete(np.arange(self.old_shape[0]), duplicates))``` was not instantly clear to me what it was doing, so having the two different lines was making me wonder if they were doing something subtlety different.
Behavior of `len` is well-defined and documented for numpy arrays, so I still believe it's the better way due to improved readability.
This change makes this docstring inconsistent with almost all others I am aware of. My feeling is that "Valid call signatures" should be reverted to "Call signature".
since it's in the pylab examples, I thought to leave it with the plt interface.
Hey @trumans please see pull 160 before you work further on this
l'ensemble du code d'un projet ...
That style of setting a handler function on a foreign object is not good practice anyway, so I wouldn't refer to that coding style in Layer.Grid anyway...
Do we really want to cast everything to 32-bit integer values? Our thrift schema includes longs and shorts, shouldn't we support them as such with our wrapper API? Otherwise, is there some way to deprecate the long and short fields in our schema?
The fire features should be integers; but 0 defaults to java.lang.Long.  This precondition, then, doesn't work as expected, and will often throw an error without due cause.
w

On Tue, 2012-04-03 at 01:24 -0700, Harshit Syal wrote:
> > +		float64_t *Xsv2=SG_MALLOC(float64_t,x_d*x_d);
> > +		cblas_dgemm(CblasColMajor,CblasTrans,CblasNoTrans,x_d,x_d,size_sv,1.0,Xsv,size_sv,Xsv,size_sv,0.0,Xsv2,x_d);		
> > +		float64_t *sum=SG_CALLOC(float64_t,x_d);
> > +		
> > +		for(int32_t j=0;j<x_d;j++)
> > +		{	
> > +			for(int32_t i=0;i<size_sv;i++)
> > +				sum[j]+=Xsv[i+j*size_sv];
> > +		}
> > +		float64_t *Xsv2sum=SG_MALLOC(float64_t,(x_d+1)*(x_d+1));
> > +	
> > +		for (int32_t i=0; i<x_d; i++)
> > +	    	{
> > +	        	 for (int32_t j=0; j<x_d; j++)
> > +	        		 Xsv2sum[j*(x_d+1)+i]=Xsv2[j*x_d+i];
> > +			 Xsv2sum[x_d*(x_d+1)+i]=sum[i];
> 
> I dont knw what's the problem here, in my editor it is perfectly fine.

which editor are you using?

have a look at

README.developer

we use tabsize 4.

Soeren
This should be a `null` comparison, to allow `0` values.
i would prefer require_once __DIR__ . '/..'; - no braces and spaces around . (which is fine here but not on following lines)
80 characters or something approximate.
Can this exit while holding the lsm tree lock?
This is true, I can't find any technical requirement to have both. I'll change that.
Changed in e676010c1a3fbe746fb4ca9730385dc93aaf29d5.
No, I think cfengine_version should be exactly as you showed here: <edition>-<version>.
changes, starting from here
use r here
Removing all callbacks for the event isn't appropriate here.  The other events aren't necessarily `once` callbacks.  Pull request will failing test case incoming.
Wont this crash Easysoft's 2.3.0 gateway?
I'd throw an InvalidArgumentException here.
Maybe put the if/blocktrans/endif on the same line to avoid useless empty lines in the final mail ? (one line in the template = one carriage return)
you should add a branch alias in ``liip/monitor`` to avoid the unbound constraint
Indeed. Have added this todo back in, and will address in a future commit.
I expect this to be false, but the iterator says it has more values.  It continues to produce the same value forever.
Why would there be no horoscope at this point?
"Data"? :-)

Please move this out of the blocktrans arguments.
You don't have to do this. It should find tasks automatically. It does not?
Double space before `value`.
Of course you can. Read git documentation/tutorials how to do it.
Not really happy with 'arith' just couldn't come up with anything better at the time.
The *concepts* of [Mocks](http://xunitpatterns.com/Mock%20Object.html) and [Stubs](http://xunitpatterns.com/Test%20Stub.html) aren't related to particular frameworks. Here's a free overview: http://msdn.microsoft.com/en-us/magazine/cc163358.aspx

In this particular test, the `passedParameter`/`decorated` combo essentially acts as a Mock (or, to be really pedantic, a Spy). However, the main point is that the test seems to be concerned only with internals, but not the desired outcome of the method call.

I don't think *another* test is required. Since the Invoke method is a Query, we should care only about the returned value. However, while testing for the returned value, we may make a statement about the interaction or data flow between the decorated method and the externally visible method.

It would make sense to say something like: *If* the passed parameter is the expected value, the decorated method will return a particular value, and we can then check if that value is somehow related to the returned value of the Invoke method.

However, in the end, the only thing we really care about for a Query is that the returned value is as expected.
Тоже отдельный сеттер для фидсов
Hm, right. I'll change this.
So you just edited your comment to add that :warning: ? Pfft.
Ruby converts this to an integer without the quotes which would be 1 instead of 001. Quoting it does the trick.
@guilhermeblanco got the PHP code, it is part of the Symfony CS.
Avoid long lines this makes review harder than it should be.. github doesn't wrap so I need to side-scroll to see the text. Keep lines at around 80 preferably (max 120).
only if you annotate it with `@Before`, no? I wanted to avoid invoking the setup if the test returns immediately due to missing native lib.
bye bye configuration

hello convention
`rt_id` is always undefined here it seems. Should probably be defined before, and the checks should be skipped.
Yes, merged them and cleaned that up a bit.
Also, I'm a bit afraid of clashing URLs (like "/foo/bar" vs. "/foo_bar"). Maybe it will never be a concern for anyone, but I'd like to find a solution just in case. It might be *really* confusing if that ever happens to anyone.

Plus, I'd use normalizePath instead of using RegExp directly.
Since you didn't Timecop this test, it will pass unless you run it on tuesday.  You may just want to freeze it to a friday.
Should there also be a test case where you pass in an invalid (un-parseable) integer and verify that an error is fired?
small change: move /2 up to 
epsilon = _get_epsilon(x, 3, epsilon, n) / 2
if I understand correctly, then the outer dot_fun could be np.dot. 
maybe not, depends on how nan_dot handles a*nan with a !=0
are there general shape requirements for endog? Does it need some basic conversion code? asarray, atleast_2d ?
наверное, надо оставить keep и писать что он deprecated и будет удален в версии 1.23
You bet
1px.gif
I agree.  Done.
Copying and pasting the missing column of data from the top left into the bottom right is exactly what I meant! :)
As per the discussion in #38, I hadn't realized that "usually" wasn't exactly accurate...  :)
hard_edge should not be a parameter.  It is queried from each component's SBProfile, not something the user can specify.
Done and pushed... I won't be offended if you edit for style / taste :)
I think there is still value in these, because then assert will give this __FILE__ and __LINE__ rather than something buried in a boost .h file.  So it might be more helpful for someone trying to figure out where the error is.
If LRS isn't accepting those valid ISO8601 time strings, we need to fix on LRS, not in TinCanJS, particularly not at the cost of timezone and millisecond info. Also, TinCanTests has a test for this format, and it's passing... so I don't think it's true the LRS doesn't like it... might have been some other confusion in testing
You don't need to precompile both
:domations
Allows you to redirect input to the command you are sudoing, rather that forcing /dev/null, the -n assumes passwordless sudo is enabled
I probably agree with this. The Map being returned by a list() method is amusing, but in a REST world it makes sense.
One observation is that Location has an id field, and a name field (note the inconsistency with enitty.getDisplayName).
It would be possible for location to use the same pattern as entity, and not use the integer keys?
But I have no strong feelings here.
ok je vais changer ca
redirect_to  inside scope :locale
Looks like there was a studder here...
it would be great if your library could provide a PublisherInterface for the typehint instead of typehinting the implementation.
Couldn't you just add in:

    ini.general ||= {};
NIT: Not sure if this was Eclipse-magic, but we probably don't need author names in files.
This allows to change the RowAction for every row, change the title or smth. 
And the closure doesnt have access to the actual action that is being rendered so you have to pass it.
Cred ca cel mai OK ar fi sa creezi un dictionar in care pui ca si cheie ce e inainte de = si ca si valoare pathul. Apoi iei din dictionar dupa cheie si pui in Config.
I think nowhere.
I was unable to reproduce the problem manually so im a bit clueless as well here. Meanwhile i have moved the jenkins to a publicly accessible server with a clean install from scratch. So i would kindly ask to revert that "fix" and then we can take another look at it. I am sorry for having caused trouble on this but i strongly believe that using CI will pay off for the project.
(jenkins: test this please)
This needs to be in a node attribute :)

Add this to attributes/default.rb:

```ruby
default["cinder"]["api"]["signing_dir"] = "/tmp/keystone-sign-cinder"
```

and then above, do this:

directory node["cinder"]["api"]["signing_dir"] do
One thing you could do is change ```@@default_params``` to ```@default_params``` above in ```init_default_params``` and change it to ```self.class.instance_varaible_get("@default_params")``` in this method.

I really would prefer this to not go in with class variables.  Does this have unit tests?  If so I can refactor it to use ```define_method``` or we could pair on it.
Результаты исправленного теста будут?
Yep, unfortunately it won't work without them.
Давайте site & token брать из параметров ну или хотя бы в константу вверх скрипта вынесите
Not really. The expiration date is part of the digital signature of the token, so you can't just update the expiration without updating the token as well.
Shouldn't  we change the log to use jboss-logging ?
No, I haven’t tested on pre 5.4.3, but the fixing [commit](https://github.com/facebook/xhprof/commit/a6bae51236677d95cb329d5b20806465c0260394) says it is for 5.4

The latest release is 0.9.2 and it does not contain the modifications
judging from the number of 'return False' in this function, there are 4 different ways to fail, and the actual test case is just going to say 'failed'.
it *might* work to return a tuple of (False, msg="reason"), but you'd also have to adjust the code that gets it to unpack the tuple.
that part was removed
again, s/preaproval/preapproval
I was coming around to that conclusion about UPDATEs.  I didn't change that code.  I'm also not sure why we'd want to save data to a table in user_**load**.  I guess it would have the effect of transferring data from the legacy table to the new one. I'll just change it back to the way it was when I forked it?
I think `scharr` is appropriate since the Kroon paper uses that name.
This doesn't refer to the previous sentence about boolean features, does it?
If not, I'd just start a new sentence with "One of the main applications..." or something like that.
@bdholt1 could you maybe do this later on? the input validation in tree seems a bit non-trivial.
improper docstring. Put a real one or don't
pep8 (sorry ;)
you should add an interface instead of typehinting the abstract class
Checked UniversalClassLoader's code again, will do an update for psr-0.
We need to check what other platforms do. I would think we should throw an exception or whatever so the app stops. Same when Run() is called.
Please update the jira issue or create a new one to track this and post a link here
we don't must change options object;
`````javascript
$.extend(true, {}, options, this.$element.data())
`````
I removed the cacheName attribute from any of the Download requests.  The user can now specify this in the cache schema.
Should this file be here? Not sure but I think @qmx is using a different method or that same method in a different place
Make a copy of the annotation. That's what I've done for Validator. It is just a marker. We might as well have our own.
For backward compatibility you are going to need a ICsvParameters::hasEscape flag which you test before calling queryEscape.
I'm not sure how useful it would be.  You would ensure a row was allocated before entering the spinblock.  You would then need to use a different row builder to assign to it.  I suspect it isn't worth it - unless the spinlock is really time critical.
I think this would look better if you had legacy check explicitly , rather than check !foundEclAgentLog
A3?
I might have to release it, or use another strategy here to release when needed.
Hmm yeah 400 is not right here, it's not bad parameters etc.

I think this should be either 502 or 503, ref http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
I'm changing my mind on this. We should use `cache_db` instead because otherwise our users are kicked out every time we restart/flush memcached.
hmm so this will return the exact same error code as the middleware returned?

This could be *very* confusing in some cases, e.g. the latest bugs we have been seeing are things like / not getting encoded properly, so the mware can't parse the URL and returns a 404 (it would normally return 200 and an empty set)

Why do this instead of always returning 502? http://en.wikipedia.org/wiki/List_of_HTTP_status_codes#502

What is happening is we're getting an unexpected result from the server we're proxying for...
There are some state events triggered when this method is called, and those fail. Therefore we set this manually.
Tip pour les utilisateurs de GNU/Linux (testé sous Arch/Ubuntu Gnome-shell) : appuyez sur CAPS-LOCK puis sur la touche accentuée. Et voila !
I don't like this - if anyone has any better ideas on how to do this, that would be awesome.
Nope it's not true, take a look at content/loader.Loader it defines setters for this properties.
You're quite right - I hadn't read the code through and worked out you were using it in a "producer->consumer" `POST`. 

While I'm not in favour of push models (with the exception of PubSubHubBub, where the only push is a "I've got new content" message) you're quite right that a new variable is the only way to have the domain visible from the app side in this context.

I think it's time for `DOI_BASE_URL` to die then - it's essentially the same thing AFAIK.
It's not required that this CSS be redeclared at every size. Remove it from the mixin and apply it to the base `.well` class instead.
Adding an error report based on passwordfailed$(usergroup_user_index) would be great
Wouldn't this assertion fail the test in a case where we got an exception?  I thought the test should be marked as "Skipped" and not "Failed"
in this case.
yes, here we test read() method,  #readFully() may be tested separately.
This might make more sense as `next != nil` (since it makes clearer what we're actually checking for), even though lists shouldn't have `nil` values in practice.
Why don't we just do:

```ruby
setting.value = YAML.parse(setting.value.to_s)
```
I've tried plone.batching in my dev environment but it breaks the "standard_view" template from plone.app.collection because it uses the oldstyle CMFPlone batch_macros ... so this has to be changed there too, before merging thisone.
Place holder for the documentation on the options. The options themselves are used

-Josh

On Aug 6, 2012, at 12:52, jlee-r7 <reply@reply.github.com> wrote:

>> @@ -65,6 +67,10 @@ class Core
>>        "-w" => [ true,  "Specify connect timeout."                       ],
>>        "-z" => [ false, "Just try to connect, then return."              ])
>> 
>> +    @@alias_opts = Rex::Parser::Arguments.new(
> 
> Unused?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rapid7/metasploit-framework/pull/637/files#r1313930
The default is 20.  So you don't have to specify it.
There's a `\x0c` character here, and a few other places. Does the GPL allow us to strip these out do you think? It's irritating me.
```OptString``` is what it sounds like, a String.  ```OptEnum``` is an enumeration, i.e., it has a set list of values that make sense.  Using an ```OptEnum``` allows the user to tab-complete correct options and gives the module a guarantee that it won't be garbage, whereas ```OptString``` allows the user to give you anything.
Is it possible to simply always return the full probabilities?  It doesn't look like it's very expensive to compute, and would simplify the usage pattern.
You probably should omit the `$`, because it isn't used anywhere else
What do you guys think about "minimera"?
That seems useful, given that I recall someone mentioning at some point a desire to rename `agi_` to `czm_` for built-in uniforms.
Yes, my intent is to use this for any binary data, regardless of what it's for.  In the terrain branch this function is used to pull binary heightmap data in BIL format.

More broadly, my intent was to make loadFoo functions that all work in a relatively consistent manner, e.g. `loadImage`, `loadArrayBuffer`, and `loadText` and `loadJson` which are still in the CzmlProcessor/ExternalDocument branch for now.
I know the Eclipse formatter sucks and removes them, but can we break these up across lines, or extract locals?  I also see you fixed a quality divide-by-zero error here, but does it even make sense for any of the radii to be zero anyway?
That could work too
Probably could just use a FrameLayout for this wrapper since we are only laying out a single view.
The view we wrap will handle the Titanium layout behavior for the children of the TiUIView.
Is there a strong reason to pass the applicationCache explicitly rather than looking it up in the constructor? I don't mind doing it this way. I'm just trying to understand why. In the other cases, we've used query inside the constructor.
The `"lp64"` one is for BLAS, see the `_set_blas_variables` function.
Let's make that "Reverse page background color"
Hmm ... whats the benefit for either from your perspective? I just ran it with pretty_backtrace and without (see below), top one here is pretty_backtrace, bottom one is existing code. 

Beyond a slightly different backtrace, I notice the code snippets are missing. pretty_backtrace says something about other things parsing this - is this why you want it?

    Error: #<RuntimeError: foo>
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_case.rb:75
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_case.rb:50
    Error: /Users/ken/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/1.8/benchmark.rb:308
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_case.rb:38
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_suite.rb:56
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_suite.rb:52
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_suite.rb:52
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_suite.rb:87
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/cli.rb:51
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/cli.rb:36
    Error: /Users/ken/Development/puppet-acceptance/systest.rb:21

    Error: #<RuntimeError: foo>
    Error: /Users/ken/Development/puppet/acceptance/tests/modules/search/by_keyword.rb:6:in `run_test'
    Error: /Users/ken/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/1.8/benchmark.rb:308:in `eval'
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_case.rb:41:in `run_test'
    Error: /Users/ken/.rvm/rubies/ruby-1.8.7-p358/lib/ruby/1.8/benchmark.rb:308:in `realtime'
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_case.rb:38:in `run_test'
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_suite.rb:56:in `run'
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_suite.rb:52:in `each'
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_suite.rb:52:in `run'
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/test_suite.rb:87:in `run_and_raise_on_failure'
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/cli.rb:51:in `run_suite'
    Error: /Users/ken/Development/puppet-acceptance/lib/puppet_acceptance/cli.rb:36:in `execute!'
    Error: ./systest.rb:21
Because I suck
If there is additional implementation information that gives insight into what the module is touching/changing in the user's system or gives overview insight into how the module is programmed or whatever, then yes! I wasn't quite sure, digging through the code, what else should go in this section (without me just copy/pasting code right and left).
Same here. Rely on a flavor instead.
No necesitamos el `.rvmrc` ;)
change js file name to flashlight.js
This is already fixed in master.
Does that mean that if a user un-check and re-check "Use Project Settings", it lose its previous configuration?
Ouch. You're right. Idiot me.
This code was not removed, but just move, because the compiler couldn't "see" reCountedPayload inside the static ifs.
ditto, n is returned updated, so the assignment is non-optional.
Got it. Thank you for your kind explanation.
Should be in config file
general note: I wonder if we should rename dispatch to "observeChanges" or maybe "notifyChanges"? That would make it more obvious what's going on, IMO. Also, we might want to tweak the watcher APIs to use the "observe" api like JS does.

Obviously, none of this needs to happen in this pull request though :)
When is `folderCount != folders.size()`?  I'd much rather this be computed by the data structure rather than kept as independent state.
A DBA once told me to always use "count(1)" instead of "count(*)" because of performance. I do not know if he's right, but I usually play it safe - just in case. ;-)
Old code, but I would now write this as

if (matchesConstantValue(index, 1))
Ok, you win :)
No need for this parameter. See comment in server file.
Why? I dont see any noticeable advantage in doing so and it goes against what all the other languages are doing.
true.. but I think for now, this is actually wired to kinda work (since @ this point cmdb_hash actually retrieves the node object from Chef ). Might be worth while keeping this in place.
Oops, thanks, yes that's wrong, merge issue. 

Corrected...
Could you add ``true`` as third arg here?
yes, using an interface for this would be much better, we don't want to limit that to phpcr-odm routes. we already have the RouteObjectInterface, maybe we can just add to that one. if somebody does not want/need getContent he can still return null.

and getName() is of course the good name, getPath is phpcr-odm specific.
This doesn't sem to be used in the class
This `else` clause is quite distant from the original `if`, which makes the condition hard to read. Since this is an exceptional "bailout" case, I would reverse the sense of the `if` and then use `continue` rather than having to indent the main body of the code an extra level.
If we don't want to put this in the HTML because it won't validate, we could append this attribute in JS. We could test for the feature and only append the attribute if it is available. From [1], some sample code for that test looks like: 

```javascript
if (document.createElement("input").webkitSpeech === undefined) {
	alert("Speech input is not supported in your browser.");
}
```

[1] http://www.sitepoint.com/html5-speech-input-fields/#fbid=qE-33Ap30Ku
To be honest I'm confused about how to handle these events. I couldn't find any examples of that event being used anywhere, and in that particular function, it isn't actually true that this is "pre_password_change" so I removed it.

Assuming the events are worth having, I'm guessing I should add an event with a new name for that method?
Review this line - doesn't look right.
As this is a view can't you just use `cache("...") do` rather than that `Rails.cache.fetch` thing?
I don't think this is needed, since we don't have any buttons on our notifications. Did you have any issues that required you to add it?
This title should have the same grade of importance as |ProgrammersReferenceGuideofZendFramework2|
If you are formatting the example then indent this with 4 spaces
Also does anyone think I should change this bundle name? The declaration is kind of specific to red-hat style configuration, I suppose the same pattern could be used and other things could just use different key values on the interface arrays. Not sure need feedback ...
Typo DATETIME
This should be a relative path (i.e. require("../")). This way, the script can be run from anywhere.
@christianv This controller is used for both create and update operations. The common behavior they share is saving a record.
I think you'll probably still need this, no?

/cc @paulspringett
Oh yes. I will modify later.
Le 8 août 2012 09:03, "Lukas Kahwe Smith" <notifications@github.com> a
écrit :

> In app/config/config.yml:
>
> > @@ -59,3 +59,12 @@ knp_menu:
> >  symfony_cmf_menu:
> >      use_sonata_admin: false
> >      menu_basepath: /cms
> > +
> > +lunetics_locale:
> > +  guessing_order:
>
> indenting is inconsistent with the rest of the file here
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony-cmf/symfony-cmf-standard/pull/5/files#r1329751>.
>
>
this is cool, where else should we be using this?
This is the inverse of "test_mgmt".
In general I think we should stick to whether things are enabled versus whether they are disabled, since its easier to write those into the "enabled" property or if statements.
No, I had them in there for debugging. Removed.
Wouldn't better name be then *EmbeddedSetField*? Or are they not unique? Sets are often not ordered, while lists are? No? Yes?
This is wrong, converters allow converting existing attributes. The checking if instanceof Request one line below is the only relevant check here.
added the function that was ncesary to show corpuses on a users profile, it just takes in the array of corpus connections from a user, and creates littel corpus masks out of each one
The `Alloc` effect says that the result is mutable, which is not the case. This seems to be wrong in the `flatMap` case too. Otherwise the changes look all good to me.
Please rename this file to log._js
I need to think about that in the morning :)
@liuggio TODO
what happens if the questionnaire object doesn't exist? you should use the django shortcut: 
    from django.shortcuts import get_object_or_404
    quest = get_object_or_404(Questionnaire, pk=questionnaire_id)

That way if a questionnaire for id doesn't exist, django will raise a 404 error (and auto render your 404 template)
Dans le new, utilise build sur le corresponding_pharse directement.
obviously we want to make building queries as easy as possible-- however it benefits the dev to get immediate feedback (fail fast) if you're passing something patently wrong
I think this should be a div as we are using the check here only for presentation purposes but not for semantic purposes, as the main semantics of the block are provided by the roles listbox and option. thus I have the following counterproposal:

```
<li role="option">
  <div>
     <span>Twitter</span>
     <input type=checkbox role="presentation">
 </div>
</li>
That would be precise but a bit a long name, i think.
I was trying to use another argument than CS issue :)
I just need that for myself. Yes, this is default option. I gonna remove this comment.
From the GCC man-page:

```

       -funroll-loops
           Unroll loops whose number of iterations can be determined at
           compile time or upon entry to the loop.  -funroll-loops implies
           -frerun-cse-after-loop.  This option makes code larger, and may or
           may not make it run faster.

       -funroll-all-loops
           Unroll all loops, even if their number of iterations is uncertain
           when the loop is entered.  This usually makes programs run more
           slowly.  -funroll-all-loops implies the same options as
           -funroll-loops,
```
Do we also need to do the same thing to horizontal layouts?
I don't think this should be transfered to the client.
can you add ``default: true`` and make sure the catchall queue is not already defined. we can have only one queue with the default flag. For now you are only testing that the default is set once.
Код лучше читается если тело функции имеет отступ как в остальных твоих функциях.
Twig ignores the linebreak here when I end with an if statement. Any idea how to force a new line / rewrite?
Not intentional, has been removed.