labofsahil/github-event-dataset-2012 huggingface dataset:
We disable device orientation in v1 for calendar. That said I would cache
one value for each rotation. Looking up clientWidth may or may not be
expensive.
lint error here :(
Ignore that last statement, its a fairly nasty hack for media db to know if the callback has been 'not' been fired (although I think its possible, Its definitely cleaner for the video app to handle)
var removeIcon = thumbAction.querySelector('button#' + IMG_DELETE_ID);

button is not needed because of it is an identifier

var removeIcon = thumbAction.querySelector('#' + IMG_DELETE_ID);
every function need a name like this.
Yeah, the use of PX was just a stop-gap to make things work, and started before the rems stuff was proposed.  I'm generally hoping that much of the CSS styling can just be copied and pasted from elsewhere once the actual graphic design gets nailed down and made available.  (Or if we use LESS/SASS, mixed-in, etc.)
A subheader must be outside the main `header` for visual design needs is for what we were using the `aria-level`
Where is this code in JS?
I think a transition on margin-top will force some reflows. What happens if you change the translateY property instead?
Do you want only ... or ..." ?
I appreciate the idea of keeping this simple, by stuffing teams and users on a comma separated list, but can we add some validation? Like on model save:

    if len(self.teams.split(",")) != Team.objects.filter(slug__in=self.teams.split(',')):
        raise ImproperlyConfigured("Teams not found")

Just to be sure people don't save invalid teams & usernames there and then wonder why it's not working.
Agreed, but when would it be output, and to where? Is there an existing mechanism for such a thing?

Unsure if I agree re: rate-limiting, if it's going somewhere harmless. If it ends up in a log-file, it'll be a lot more likely to get someone's attention if it's emitted every time the Config::Server class is instantiated haha.
Ok,

I messed around with optparse#order! and it is not reliable.

Mine is a monkey patch. But does exactly what is needed. optparse order! would make the dynamically loaded (based on user) optparse object have to manually parse ARGV. This looks to me to introduce complexity and possible issues with behavior change in the gem. We just need this one split. I will change to a method from a lambda.
I think the formatter should apply to the fallback case of `"example at #{location}"`, too.
Change this to "HBase".
This is for the situation where the POD parser chooses Latin-1 (ISO8859-1) but the POD source was actually WinLatin-1 (CP1252) which is like standard Latin-1 but with some controls characters replaced with smart quote and em-dash characters.  These characters are quite common in the POD files on CPAN which contain non-ASCII bytes but don't declare an encoding.  The POD parser will guess Latin-1 and render those characters as control characters.

Remember this code will only execute if the POD omits an =encoding - at which point we and the POD parser are guessing.
Did you mean bottom left here? From code it seems that only latitude is inverted, but longitude is still from left to right.
Yeah, I tried that, but in that case the tests fail with this: `failed to locate @import file url("foo.css").styl` — there could be things like `url(foo.css)`, `url("foo.css")` etc. in `path`. Also, there is a possibility of things like `"foo.css?fdb322"` (or anything similar), so the regex would be more complex there.

However, yes, my fix would work only for my case, but for make it work for all possible cases the code should be more complex. So, I'd propose take this patch (as it is simple and won't break anything) and create an issue for more proper and complex check here.
Or just add a ```archiver = 'whatever'```?
True, this is ugly.
I think all links should have a confimation message, and so openDirect should be used in code sparingly, if at all.
Good point - we should validate this.  We are just wondering how we should react? 

We could return a 404, however wouldn't the user anyway get a 404?
I don't see build.bat or build.sh in the source tree..
Yeah, looks like the whole section should be rewritten.
I think I found it.  In the other tests there is a line here like: `output = Formatador.parse(output)`.  That will convert stuff like "bold" into their codes.
давай в модель это?
one more question. Does it increase repositories size 2x? As i understand we keep bare repo and normal one
will revisit this later - we use these in other places so need to agree with designers etc
I guess pyflakes only look at current file :-) so it is true that ConverterNotebook is not use is this one.
Nosetest is here for that. Still I think it only validate all test on my computer, and only my laptop, so I'm  forgive-full !
Goodbye old readme.
what do you think about queuing these messages until the page is unfrozen.
It is add-on code, but here we are in case of system modules. They should only use `require(sdk/panel)`, right?
=> resource://gre/modules/promise.js
@seanmonstar - if I apply the following diff, IE8 acts as expected:
```
diff --git a/resources/static/include_js/include.js b/resources/static/include_js/include.js
index 979bca2..013f05f 100644
--- a/resources/static/include_js/include.js
+++ b/resources/static/include_js/include.js
@@ -997,9 +997,12 @@
           var state = document.readyState;
           // 'interactive' is the same as DOMContentLoaded,
           // but not all browsers use it, sadly.
-          if (['loaded', 'complete', 'interactive'].indexOf(state) > -1) {
-            document.detachEvent('onreadystatechange', ready);
-            callback();
+          var events = ['loaded', 'complete', 'interactive'];
+          for(var i = 0, eventName; eventName = events[i]; ++i) {
+            if(eventName === state) {
+              document.detachEvent('onreadystatechange', ready);
+              callback();
+            }
           }
         });
       }
```
this eval sucks, I agree.  Because the script that generates the messages.json file is in svn next to our translation files, and because it generates JS and not JSON, I thought we would fix this in a subsequent pass.

I also think we should move scripts that read from SVN and generate our json should live in our repository...  That we are free to change how we consume stuff without requiring coordination with external teams.
None that I know of. This is too much of an edge case and too much of an inconvenience (messes up blocklisting, stats, etc.) for it to be a priority.
Agreed. Although I would imagine no one complains about the behaviour because its rare to use spaces in Linux paths I would presume :-).
Why is '(idx)' in the spec description string?
@dbussink updated. I'm having a problem when running the tests. Do you know how to run mspec in 1.8 mode? Thanks.

```
$ bin/mspec spec/ruby/library/socket/socket/socketpair_spec.rb 
rubinius 2.0.0rc1 (1.9.3 b66bb353 2012-11-02 JI) [x86_64-apple-darwin12.2.0]
...F

1)
Socket#socketpair raises Errno::EPROTONOSUPPORT if socket type is not a String or Integer FAILED
Expected Errno::EPROTONOSUPPORT but no exception was raised
           { } in Object#__script__ at spec/ruby/library/socket/shared/socketpair.rb:26
```
shouldn't that check for the existence of options.where ? Or maybe smth like `options.where||{}` would help?
Do network timeouts generate an error on line 349 that end on this channel? If not those should be handled here.
pls write a couple of lines about this "edge list format"
`' + exports..`
I would like to use template with underscore. because generated manifest.json has ugly indent style. please check the pseudo code below.

```
var template = _.template(grunt.file.read(path.join(this.sourceRoot(), 'app/manifest.action.json')));
items.push(template({'title':mf.name}));
```
@macnibblet Yoda conditioning is a valid and recommended way to prevent accidental assignment.
it is a different method, line 4 is for mass asign, line 13 is for geters and seters
return?!
This isn't quite what I meant when I said read from stdin. Stdin traditionally points to 'standard in'. This means when you run the program, it gives you a prompt that you can type in until you send the EOF character (control + D). Then, it reads in the text you sent. Or, you can pipe something in ("cat text.txt  | python De-Censor.py). You can still read from it as if it was a file (has all the same functions and such), but it doesn't actually real from a file on disk.
This is more flexible than reading from a hardcoded file.

Also, for future reference, it is bad practice to point the sys.stdin variable somewhere other than standard in.
Please see below for comment about strip size.
please add a docblock for the  searchAction providing info about this exception
Could use some vertical whitespace in this function.
Seems a bit weird to pass the Ember object as a parameter (shadowing a global) but then use a different, non-shadowed global in the following lines (`Em`).
Per review about linebreak after opening brace. Like other style changes, this applies in multiple places.

`model: { complete: false },`

->

```
model: {
    complete: false
},
```
This is true. I realized that after I pushed the code. Some unit test might be helpfull here
this is wrong. XML attributes are not booleans but strings. And ``"false" == true`` so putting ``view="false"`` in the XML would still mark it as a view.
This conditional is unnecessary now.
Not sure why we should refresh the properties here
is this generated? if yes, please add USE=doc and doxygen to DEPEND
Annotations shouldn't be mixed in with keywords.
No need for `| 0` I don't think.
Per-specs, "indexOf" should work on sparse arrays, so that means:

    [,,,].indexOf(undefined)

Should return "-1". The "in" check is there to verify the existence of a numeric property at the current index. Otherwise, reading from a non-existing property in the object would yield "undefined" and this function would in turn return "0", which is incorrect.
The parameters here are swapped and the right order would be ```new SiteCatalyst($js_file_location, $account, $api_version);```
it's used now :D
Fix indentation please
Capitalize `If`.
The nils came from the way we were constructing the arrays - now it's purely a single sql query for each one, so they shouldn't have stale records in them. And calling compact before paginating means you're fetching all the records, so that's not ideal.
How about... `bitmode: 4` (alternatively 8)
should be: $tab_selected_text_color; (see the patch)
I think this would be clearer if we rearranged the way the question is asked. Maybe something like:

    Assume this original conditional statement is true:
      Original conditional statement: blah
    Logically, can you deduce whether this second statement must be true?
      Second statement: blah

Or some such. Right now it seems a bit confusing to figure out what's being asked.
try to use consistent hash syntax. `=>` is 1.8 and `:` is 1.9. We prefer 1.9.
Comma splicing:

> phpBB is an open source project that any developer can contribute to

Or even better:

> phpBB is an open source project, meaning that any developer can contribute to it
Spelling here and below: `perl -pe 's/asyncronous/asynchronous/g'`
Oops. Thank you sir.
и тут GUARDа нет
Won't this add the same file over and over again every time it's updated? Should `@file_paths_on_disk` be a `Set`?
I've done it this way because the css selectors differ from each SearchResultList to another, and to make sure each result correspond to the page tested.
In the previous code the returned item was always SeachResultItem, which would have been ok if the CSS selectors would not differ on each result page.
I think the addition of `APP` is ok for now. For the future usage we have to think about how we can download e.g jsshell-mac.zip binaries from the FTP server.
Principals module has to be pushed way up to the top because the global admin user is managed by the principals API. the config aggregator needs to use it to seed the administrator. This forms a cross dependency between principals, and config-aggregator, assuming the principals API would need to use the config data at some point.

If this ordering ends up with problems, we could consider splitting the "ConfigAPI" from the "Administrative Interface", where the admin interface could take user management with it. That should resolve the cross dependency.
I added `log().error()`
Makes a lot more sense to not have this here!
I added a `moduleId.substring(0, 4)` equals check to make sure only oae modules are shown.
Also added `filterLibs` to make sure only API, Model and REST javascript files are read.
I don't think it helps to use the wiki syntax outside of scaladoc comments.
Why is needed? The option name is a bit scary :)
Again, 100% style, but I prefer indenting this line to line up with the line above. (I prefer how it was before.)
leaving this decision to you guys :)
*standard* is not (already) the right word, but this syntax is supported by several IDEs, including PHPStorm and the latest NetBeans. 
Besides it's part of PHPDocumentor 2 (see the [array type documentation](http://www.phpdoc.org/docs/latest/for-users/types.html#arrays)).
Terug naar main map omdat in de big je vast loopt omdat character te breed is en soms niet hoog genoeg komt met springen dus kan beter blijven testen met de oude totdat de bugs eruit zijn.
false => FALSE (all occurences)
да, спасибо, я пару дней назад тоже размышлял над алгоримтической сложностью этого алгоритма и придумал свое решение, которое исключает вообще повторные циклы использования рандома.
        NSInteger l=[_DNA count], i=0;
        NSMutableArray * indexArray = [NSMutableArray array], * sortedArray = [NSMutableArray array];
        for (i=0; i<l; i++) {
            [sortedArray addObject:[NSNumber numberWithInteger:i]];
        }
        
        for (i=0; i<n; i++) {
            int pos = arc4random()%l;
            indexArray[i]=sortedArray[pos];
            [sortedArray removeObjectAtIndex:pos];
            l--;
            
        }
так можно долго искать индекс нетронутого изменениями нуклеотида, рациональней было бы делать выборку из априори подходящих
Работает :)
Объекты массива корректно сравниваются таким способом.
Есть метод isNotEqualTo, примените его. А зачем вам cellDNAString? Вы всё равно не будете менять значение передаваемого cell, так зачем тогда нагромождать код? Сравнивайте сразу две ДНК поячеечно.
в моей версии равновероятность не теряется, а в вашей — вдвое увеличивается вероятность одного из элементов (следующего после заменяемого)
Pretty sure you mean `RACSequence` here.
Ah I see, didn't know. It might not be documented anywhere, since `-sendNext:` explicitly says values can be `nil`, and `-sendError:` doesn't.
I like it.
Let's let @joshaber do the heavy lifting and see how it pans out.
This should have `None` as the Commands.
I don't know, they were there so I've maintained them.
Here are a couple examples from competitors on how they handle it:

KM.init("this is your key", :log_dir => '/var/logs/kissmetrics/')
Intercom.api_key = "my-super-crazy-api-key"
`int` here as well and below
I liked you better down here
13 is the epoch selected..

On 28.10.2012, at 08:56, Alexandre Gramfort <notifications@github.com> wrote:

> In examples/preprocessing/plot_ica_from_epochs.py:
> 
> >  # A distinct cardiac component should be visible at index 24
> > -epochs_ica = ica.pick_sources_epochs(epochs, include=None, exclude=[24],
> > +ica.plot_sources_epochs(epochs, idx=13, n_components=25)
> idx=13 do not mache the 24 above
> 
> —
> Reply to this email directly or view it on GitHub.
>
Description should briefly explain that a DOMElement can be used
So this is weird because playdoh uses the [django-session-csrf](https://github.com/mozilla/django-session-csrf#differences-from-django) module for CSRF protection, and it seems that the CSRF token is empty in a view unless this `anonymous_csrf` decorator is used... Therefore it appears I have to use it on views like this one, which are only accessed via GET requests, but which initiate POST requests... Does that make sense? I'm not even sure if I'm using it the right way myself, so let me know if this is confusing. :)
When referencing a specific file, please use the notation:

```rst
:file:`whisper-info.py`
```

Full pathnames as applicable.
Use parens with `floor`, this is hard to read otherwise.
Ah, duh.  Well `joinPath` uses `</>` anyway.
You don't need to autoload `colors`. It's loaded by `promptinit`.
Yep, fair enough. My first instinct is always to go with a generator/comprehension, I guess from writing a lot of functional stuff.

This is much clearer I think:

```python
slugs = ["/".join(parts[:i])
         for i,_ in enumerate(parts, start=1)]
```

Or as a loop:

```python
slugs = []
for i,_ in enumerate(parts, start=1):
    slugs.append("/".join(parts[:1])
```
removed. this is now implemented as a ProducerRequest message to the connection actor.
please comment in the code or change it - it works - it's just not pretty
They are reserved to the [implementation](http://tinyurl.com/yf3e973) -- compiler, library, etc..
`= false`
[...] etc.).
Rather than add this parameter to everything, what about just setting the cacheable mode on the publisherApi object itself?
So what's the point of making this change? We could just leave the requires "naked" in the file, no?
Same here : 

You have to use the dialog like this : 

```
                {% set alert_message %}
                    {% trans 'prod::thesaurusTab:dlg:Acceptation en cours.' %}
                {% endset %}

                var alert = p4.Dialog.Create({
                    size : 'Alert',
                    closeOnEscape : true,
                    closeButton:true,
                });

                alert.setContent("{{ alert_message | e }}");
```
CodeStyle : missing blank line
alignement + camelCase (dest_file)
Or perhaps even setMapFile(new File(new File(dir), s).getPath());
I don't usually do this. I guess it's a matter of taste? :)
is this really how we do this?? Ugh nose you suck. No annotations???
I doubt it. This field would be serialized across the network and I don't think that would be a good idea. It is part of init command framework as commands arrive to target execution Infinispan node
Exactly! Cheers
I guess you mean expire operations instead of eviction operations?
Yes, in the strict sense: the CH SPI is getting more complex, so now you need to register a ConsistentHashFactory instead.

A custom ConsistentHashFactory can either return an instance of DefaultConsistentHash or a custom ConsistentHash implementation. The new DefaultConsistentHash should be flexible for most cases, but for instance we have a ReplicatedConsistentHashFactory and a ReplicatedConsistentHash that are much simpler.

BTW, we don't have a topology-aware ConsistentHashFactory yet - that will have to wait until the next alpha...
You don't need to use ``DIRECTORY_SEPARATOR`` when building a path for ``file_get_contents``. As of PHP 5.3, ``/`` is accepted on Windows too, and it makes things more readable. Using ``DIRECTORY_SEPARATOR`` is needed only when you need to compare paths as strings.
We should probably clarify here what's in the comment below: that the data is not "pre-stacked".

It might also be nice for *y* to be either a 2d array of MxN, *or* a variable number of *y* arguments (which would be stacked implicitly here).
This seems quite a useful docstring? Is it out of date?
PEP 8 references PEP 257 for docstring conventions. This breaks the [multi-line docstrings](http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings) convention.
This brings about a different question - should we create a <code>adv_select_random_version()</code> method? I grow weary of having to maintain the hard-coded version number in these tests.

For now though this looks great. I'll take the question to the group.
The code below says launch the video app, but your comment above says launch the gallery app. Which is it?
Ну да, не заметил что $this->instance->setServerParams()  а не $this->setServerParams(),
Think of it as new instance of a "class". In fact if you look closely you'll note that settings from backend (specific to the interface) are passed to multi file plugin.
I'd mention why there's this random 1 in the vector.
The changes to this query make the trend statistic fields nullable, to handle the case where a singular matrix is detected. Otherwise, that period will be dropped and there will be a hole in the trends timeseries that we build later on.
Oh, ok, we talk about almost same thing. I will put gte instead of gt.
@jsloane we should probably remove `ftp` from this regex.
Make calls to the methods as defined, in this case getGS() instead of getGs() --no matter PHP function names are case-insensitive--.
Can we combine this with `webfont.FontWatchRunner.prototype.computeStyleString_` somehow so that we don't have so much duplicated style information? They're both doing essentially the same thing, I think.
Sorry, I didn't get it at first, yes, indeed, it's something my particular system requires. Here is what's probably a better fix.

Otoh, I think the comments in the issues made it quite clear that it's definitely something that may interest several people.
Таже беда:

```ruby
@values.map.to_json(:only => [:id, :name])
```
The assignment to ``$a`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
I'm not sure whether it's a good decision to use clang's includes by default. I think most of the users use clang_complete with gcc and want to use its includes.
Missing JavaDoc?
bitte mit 0 statt O, um 1337-er zu sein.
The reason for removing the ".js" is? I think Backbone.js is the complete product name.
Normalization produces an error
Add a comment explaining what this is for, please.
AUTO_INCREMENT=1;
This won't work if the predicate `pred` doesn't return `true` but some other truthy value. But this can be fixed by just leaving out the `map`:
~~~clojure
(not (empty? (filter pred a-seq)))
~~~
Why this magic number?
RuntimeException?
you could delete this
Will this line be used later?
(Maybe it makes more sense to provide an example that requires a block? Like a timestamp?)
.show() always sets display: block, unless that value was stored with .hide(). So in that case it works as all elements' default value for display is block.
Be careful. Computing sizes in one of the most non-cross-browser-compatibile thing there is. :-) This is why jQuery provides so many different methods do that. Maybe you should use one of them, like [outerWidth](http://api.jquery.com/outerWidth/)?
I suggest you to read [FAQ](http://api.met.no/faq.html#times).
var users = [];
for (var user in onlineUsers) {
    if (onlineUsers.hasOwnProperty(user)) {
        users.push(user);
    }
}
users.sort(function (user1, user) {
    if (user1.username.toLowerCase() < user2.username.toLowerCase()) return -1;
    if (user1.username.toUpperCase() > user2.username.toUpperCase()) return 1;
    return 0;
}
```
Why global variable for this? And why written as a constant if it is not a constant?
I'll check. If it doesn't, do I leave it like it is?
This bit should probably go in `ENV.setup_build_whatsit`. Since that is called at the right time.
I think you're confusing /* */ and /** */. This block has actual properties.
getcaster can not null
It make sense. I wondered why they used `providerKey` in the token.
don't need the comment here!
Change this to from "jQuery's implementation of deferreds, ... , offers" to "jQuery's deferreds, ... , offer"
removed, specs say your right!
I thought of that, but no - it comes out to exactly 1024 points if there are no points in water.
Yes, this is within _request_body, I'm pretty sure we'll always have at least an empty string there.
The style for ui labels should ideally only be defined once. I suggest to either add your selector to the according declaration in ui.css or to add to the selectors there a more generic class name for ui labels.
Would that be possible? To me it looks like we wouldn't have made it that far, did you add that because the last active-tab message is stored and may be outdated? Still would be a value here AFAICS.
do you remove the import logging lib on production env in python apps?
shouldn't this be called 'logpopul' so it doesn't get mixed up with the original popul. Sounds like a messy change if anyone uses anes96.
still redundant renaming, settle on one name
No I didn't update the docs after I generalized.
@GromNaN What are you talking about ? ``getNbResults`` and ``getSlice`` ? They are not applying the same criteria
I can't recall, but these cases might be covered by the existing general demo spec, which tries to visit each page in the sitemap. So, it might be sufficient to just add these two empty-asset pages to the sitemap, and avoid adding new tests we have to maintain.
And yet another "enable" variable. Already 3 variables to reflect this object's enable/disable state.
Agreed. I think using a more distinct selector would be better. Like @$("form##{gridFilter.get('name')}") so it's scoped under the form or something similar. But I was also thinking I might take it a step further and let each filter view take care of this. So the view itself would have a getValue function that would handle it's own scope. That way for something like dates that might have more than one field we could still call getValue and it would be smart enough to give us exactly what we're looking for to pass to the query.
I think all of our other normally-capitalized things are lowercase when they are a variable.  e.g. psf, ccd_noise, poisson_flux, etc.   This was a compromise between what I had in the config: `e_power` and what you had here: `E_power_function`.  I wanted to make them match up, so I went with a compromise `e_power_function`.
tab.  There are others too.  I'll let you grep for the rest.
3ead2ae looks good
So it's my understanding that Github flavored Markdown (which is not real markdown, but whatevs) renders blocks in three backticks as code regardless of indention level. But the four-space thing does look nicer and works more places. You can't tell it explicitly what kind of code it is (for highlighting purposes) though, can you?
Will fix. I think I also caught this in the PEP8 fixes branch.
Please adjust coding style so it fits (see the if just below), also I think using is_dir() might make more sense.
I will rewrite int to size_t.
An error code of "0" - that looks weird.
After reading a bit about the predicate system Pyramid provides, the following comes to mind regarding your proposal:
  - Should we use view- or route-predicates 1:1?
  - Should we just use the lowlevel mechanics and refactor the innards of ``valid_content_type`` to be more inline with the predicate system, i.e. make a Predicate object from the bit of the content type matching code?

Regarding the former, i question if it would fit the purpose, as i read about the builtin mechanism of evaluating view- or route-predicates is about determining whether the routing logic should continue route matching or not. So there would be no way for cornice to "intercept" at a specific step to provide a valuable response code (415), right?

Regarding the latter, i would +1 on streamlining the matching code into a Predicate-like interface very similar to ``class ContentTypePredicate`` at [View and Route Predicates](http://docs.pylonsproject.org/projects/pyramid/en/latest/narr/hooks.html#view-and-route-predicates). Is it this you wanted to direct me to?
_abandon_socket
Actually, since we're using icon fonts, my proposed use for text won't work. Instead, the line could be like this:
    <a href="https://twitter.com/SolitaOy" rel="external" class="twitter"><i class="icon-twitter"></i> <span>twitter</span></a>

And then add to SCSS:

    span {
        @include image-replacement;
    }

...or some other way to hide the text :)
Why not just have this simulated block be the else-clause of `self.service.splunk_version >= (5,):`?
Fair enough - I got the impression it was a string. Thanks :)
Probably. It's quite the same code than for the combo's select event: https://github.com/camptocamp/cgxp/blob/master/core/src/script/CGXP/plugins/FullTextSearch.js#L211
Extra blank line!!!!!!
Rather then commenting this out (necessary on debian systems), maybe add a only_if to the link resource below.
Success means not fail.
PEP8 issue: test_home_page.py:13:1: E302 expected 2 blank lines, found 1
漏れてました。次回のタイミングで追記します。
I've changed it to do `return Decimal('0.00')` which is the most logical thing to do given that `MoneyField` is backed by the python `Decimal` type.
`qid` is fine to me, as it's the same name as in the file format...
I contacted @wslihgt , but unfortunately he responded that he didn't have expertise in this area, nor the time the dedicate to reviewing the code.  He did however volunteer to recommend others, which I asked him to do.
I don't see any use case. It seems contradictory with the previous comment. Looks like a [YAGNI](http://en.wikipedia.org/wiki/You_ain't_gonna_need_it) case to me.
Having weapons automatically assume that they always do damage doesn't quite make sense to me...

What if some dev made a curing staff that is held differently (aka weapon) but when he cracks it over your head...it heals you :P.

That isn't damage...should probably change this to getAmount(); (same for rangedweapons....healing arrows xD).
Ok, forgot they relaxed the constraints.  Looks fine then.  :shipit:
Should not print linkage if it is D linkage.
Well, since it's only called when printing, I assumed that there wasn't an issue -- `path + 2` is printed, while `path` can be safely freed later on. But if Valgrind complains, I'm probably missing something.

Now that I think about it, the code could just be inlined in the `print_path` function, since it's not very important to normalize binary files' names anyway.
You may want to use something like
`SC.get '/resolve' {url},
 (..) ~>`
these changes were already merged in in a different commit.
I don't completely agree here. The lib provides set of chain nodes, adapters and so BUT It does not say anything about how it can be build or used.

So why it can provide this Safe chain node. And the people should decide how to use it
In this case I was not careful. Do you have a solution?
I don't think integration tests cover this. They could, but aren't now.

I think it's more a case of personal taste/experiences. Usually I use Cucumber because it's way easier to communicate with my clients [specification by examples]. I know that our case is slightly different because our clients [us] already know [most of times] exactly what [we] want. So, since we're not using Cucumber, I think I might have brought this style to the integration tests.

Notice that the integration tests resemble the user navigation and generally only cover positive straightforward scenarios. That's because that's the way we tend to think about our requirements: "As an instructor I want to create courses tasks". You see, we don't mind about the internals, e.g. permission checks, where to redirect to, etc., so I usually test this kind of thing at the functional/controller layer. And this isn't, by no means, a rule. I write tests, no matter what kind, for code that seems brittle.

And one more thing, I usually mix acceptance, integration and functional tests because the latter are **way** faster. Specially when you're dealing with Javascript.

Just to clear things up, I'm not trying to convince you that we should be writing acceptance tests, using cucumber, etc. I just want to expose you a little about my background so you can understand why I'm doing this way. Like I said in the beginning, there's a strong personal touch here, but I know it's a collaborative project, so I think I can change [a bit] my style if needed (I mean, really, reeeally needed :wink2:)

About the `minitest/spec`, I do prefer the spec syntax. I haven't used it here because I was having a hard time to make it work in the integration test (can't remember the exact reason, fixtures I think), so I kept the flow. Now that we don't have more fixtures, I'll be happy to change it.

Please let me know your thoughts.

:heart: wicz
I don't understand this change. Why forcing the user to declare JAVA_HOME if the property works fine?
Project Pier Arbitrary File Upload Vulnerability
Argh, I don’t mind code being refactored, but not when it removes functionality, and hasn't been tested properly. He seems to have a bit of a focus on clean code over useful features :(

I'm busy this week so won't be able to fight for the output. At least I've done what I set out to do - work out how to contribute to msf, and learn some ruby whilst I'm at it. 

Cheers for all the feedback, I think we should have persevered with your Pull request! 



-----Original Message-----
From: Loic Jaquemet [mailto:reply@reply.github.com] 
Sent: 24 June 2012 17:23
To: Meatballs1
Subject: Re: [metasploit-framework] Gpp passwords (#519)

> +			return nil
> +		end
> +	end
> +
> +	def parse_xml(xmlfile)
> +		mxml = xmlfile[:xml]
> +		mxml.elements.to_a("//Properties").each do |node|
> +			epassword = node.attributes['cpassword']
> +			next if epassword.to_s.empty?
> +			pass = decrypt(epassword)
> +
> +			user = node.attributes['runAs'] if node.attributes['runAs']
> +			user = node.attributes['accountName'] if node.attributes['accountName']
> +			user = node.attributes['username'] if  node.attributes['username']
> +			user = node.attributes['userName'] if  node.attributes['userName']
> +			user = node.attributes['newName'] if  node.attributes['newName']

I don't like that one-code-fits-all approach.
a) There is value i knowing that a user/password comes from local users or tasks or another type. 
b) Date attributes['changed'] is important. I do have test cases where old policies where still present for the same local user but old password. The only discriminator is the date of the policy/changed attribute. This is regression from #513



---
Reply to this email directly or view it on GitHub:
https://github.com/rapid7/metasploit-framework/pull/519/files#r1039078

-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2012.0.2178 / Virus Database: 2437/5090 - Release Date: 06/24/12
A block matrix might be a cleaner way to construct `A` :

```python
xs = src[:, :1]  # slice out column vector
ys = src[:, 1:]  # slice out column vector
aa = np.ones_like(xs)
zz = np.zeros_like(xs)
#             a0, a1,  b0, b1
A = np.bmat([[xs, aa, -ys, zz],
             [ys, zz,  xs, aa]])
```
Changed in all cases.
Is `isNaN` fast?  Probably just test some bits?  CC @shunter
Should be:
since: { android: "2.1", iphone: "2.0", ipad: "2.0" }
Need an empty line above the code example, or Markdown doesn't format it correctly.
Should read:

> Determines whether the paging control is displayed on the top (true) or bottom (false) of the view.
Not quite true. When an app resumes from the background, the URL for the launch is updated, and many of the other settings from launch may be updated (or should be preserved across sessions). Removing the URL when going into background is safe, but perhaps unwise.

What this ticket is really complaining about is the fact that the URL does not get updated properly during the "resume" event. This is specifically why we added the "resumed" event, because that is when the URL is updated. This PR may not even be necessary. See [TIMOB-2486](https://jira.appcelerator.org/browse/TIMOB-2486).
This should be:

    logger.log(__('The value of %s is %s', key.cyan, tiapp[key].cyan) + '\n');

Not sure if you needed to cast the key and tiapp[key] to strings.
In this case, I needed it to be an Array because of the use of `map()`.  I do think it's worth making those arrays if we are using them as arrays.  Also, I think it's better to expect 1 type for any variable at a time.  For:
```javascript
keysAmounts = (keysAmounts instanceof Array) ? keysAmounts;
```

We're saying that we can expect it to be either an object or Array. 

We should probably come to a consensus.
@briancavalier This pull request is getting long in the tooth. If there are no more objections, can you merge and fix remaining nits as you see fit?
The current version on my master says "after" instead of "in response to". If either of you want, I'll issue a separate pull request for that.
I thought you'd removed the copy of this static list directly into the ISO and were building this dynamically...
Он нужен этот `scale`, без `preferedSize`? Я как пользователь не хочу указывать две натройки для одной фичи.
just define this on line 86
$expectedEncodedCode = md5($salt = '', $code = 'code');
Fixed. Sorry.
Looks like for current dmd even private `store` has to be `Scoped_store`...
For 'at', run1, run2, and run3, replace all four declarators with "immutable".
I've added this as optimization for parameterless methods.
Howso?

I stuff changes between versions, you need to take that into account in the eaysblock, unless you want to discard support for (really) old versions.
because not all elements of that array are constant (domainProvider.getDomainInterface())
is this really only a warning?
do you see ofAlignVert and ofAlignHorz being used outside ofRectangle ? 
otherwise maybe OF_RECT_V_ALIGN_IGNORE etc ?
cf @arturoc 's comment above, how about:

`string& rootReference = dataPathRoot();
rootReference = Poco::Path(newRoot);`

much easier to read in any case.
I think the following is still in need of sanitization:

- fd_from_date
- fd_to_date
- fn_days_back
- fv_address_type
I think I understand: `btn` is a button, and you're using a custom attribute on it to store some state of yours. You should document that, it's not obvious at first sight.

Also, I think XUL elements have a data field that you can set/get directly as a javascript property (or maybe is it `value`?) and it would make your life easier I believe.
Well I like to enable use cases if they don't have a cost, but if you really want I make it abstract.
No need for the ```@links ||= ```.
yea, ha! added the test i was planning to have.
you cannot create it against 2.0 as the 2.0 branch of the bundle does not have a registry
change to footnote
Поставлю 40
The PrepareCommand is sent with Total Order properties and the Commit / Rollback Commands are sent with OOB flags (only ensures reliability). Otherwise, the Commit / Rollback Command send by the sequencer (node who sequences the messages) will be total ordered and it will get an extra delay delivering these commands.
"Expcted non-null context!"
If you get rid of the `self` vars, the `import_cases` method will need to return summary data about what it did, which `import_data` will be responsible to integrate with similar summary data returned from `import_suites`, and then return the integrated summary data to the external caller.
not, sorry. At this moment I do not understand the problem, I'll wait to see something concrete.

But I'm sure that is later than  fa656e7ed644818ffd4d2b812fef579016b6bedd
@jone: You think too much :-) - I changed it ;-)
Am I misreading this, or can we just use `result.length = result.length * 2` here?
MINOR: Missing write_header and write_footer parameter comments.
Ok, yes, looks like it was fixed here: https://github.com/OpenMRS/openmrs-module-hl7query/pull/32/files
right, but if you know the cachedConsumers field is null, why go through this code at all?
I refactored this area a bit. I will set the fetch-size and max-rows property (to 1),  only if the data-source is passed into the class and a fresh JDBC-template is instantiated. Otherwise I added documentation mentioning that this property is important when using Oracle for persistence and users should pass in a corresponding JdbcTemplate instance. However, I am not changing their passed in JdbcTemplate instance.

However, a warning-level message is now logged if the fetchSize is >1 (in afterPropertiesSet).
It's not only used in HttpURLConnectionCientHandler, it's also used when we're using the straight Jersey pipeline. Jersey needs these to be Integers in ClientConfig.
Actually, that's NOT the one you want. You want [bootstrap-sass](https://github.com/thomas-mcdonald/bootstrap-sass/)
parallel arrays? :sob:
lol. I think the Mad Scientist who came up with the idea should own it (take responsibility) . but feel free to add my name at the end if u want. open source should be about how cool the project is not about whose name is on it :)
I won't force a change at this point - shall I log this somewhere upstream to track it?
Can you respect the CS (4 space)?
You're missing a `/`.
`resources`
And yes, in this case, make id transient since it's useless data.
> First, every time a new module is released, we notify all child process**es**

What does "a new module is released" mean? Did you mean "when a new module is compiled"?

> This is a waste of resource**s** if we consider that the child modules tell~~s~~ us explicitly ~~on~~ which modules they are waiting on.

> Therefore, the code could be modified to store exactly on which modules each child process is depending on so they can be released just when their dependencies are definitely available.

I'd rephrase it a bit:

"Therefore, the code could be modified to store **a mapping from each child process to the list of modules it is waiting for so that when a new module is compiled, only those children which depend on it are notified**.
No this should be the actual method we use, so if we want like lower case alpha numeric we can do AlphabetGenerator.generateAlphabet(
				AlphabetGenerator.Types.LOWER_CASE,
				AlphabetGenerator.Types.NUMBERS)
This thing ensures that the alphabet always has a consistent ordering(abc...123... as opposed to 123...abc...) and its easy to add new classes of characters. Have any better suggestions for names?
explicit V(const T&)
очень нелогично, что он изменяет переданный указатель, а не возвращает наружу
Adjusted. See the commit below.
Moved below.
this is also a good moment to do some code clean up by moving this to setUp()
I didn't want to seem particular, but maybe go for uniformity.
The underlying HttpRequest ought to be '._request'
XSS attack.  What if the user clicks a link like this:

    <a href="http://www.evil.com?allowed');alert('btw I can remotely execute code in your app');//">p0wned</a>
I think updateCover is best since that what it is called on the webplatform side.
name could be more descriptive like "checkUserAuthorization", or checkUserisSelfOrAdministrator
It produces skeleton file like `title: You're editing the object "{{ YourModel.title }}"`, but after [this commit](https://github.com/cedriclombardot/AdmingeneratorGeneratorBundle/commit/a19708cb335b619e6bdffc35ebe0b8585cf44128) the title is now wrapped in `{% trans %} {% endtrans %}` tags... which causes error `A message inside a trans tag must be a simple text in "Admingenerated/candgoAdminBundle/Resources/views/RecintoEdit/index.html.twig"` becouse it puts `{{ YourModel.title }}` inside the trans tag.

These changes pass the `{{ YourModel.title }}` variable as an argument for trans function (but they only work with new echo_trans).
Empty comment block