labofsahil/github-event-dataset-2012 huggingface dataset:
The use of List:
The _frame array was a fixed size struct allocator, now we have malloc/free for each node, and two additional pointers (one unused) per item + the malloc overhead.
Granted we have better *asymptotic* performance on insertion. But we have weaker performance on iteration and removal. Do we have better real performance on insertion? With max 16 entries? Doubtful considering the pointer walking.
More code and more fragmentation too.

Messy unused entry:
You call it messy, and this is the debatable point.
What do you think the general allocator does for freed small objects? It keeps a pool of "messy unused entries".
Common::MemoryPool (which it is a simplified case in fact) too.
No reason for this conditional here.
When called by the Popup and the Blank Forms Report it creates it's own window box, when called by appointment report it opens a new window (or Tab).  So yes that would be outside the frame I believe.   The old version called a restore session that echoed directly.  we just wrapped it in HTML so it would re routed..

I'm not clear it's needed at all, myself so any suggestions on how to do this better are good by me.  It seems to work this way, but that's not always the final story :-)
I tried to replace the main list with a priority queue, but got stumped at replacing `interesting()` as we need to look through the whole list to figure out if there's anything interesting left in there. I don't suppose it's a good idea to take the flags into consideration for the comparison function, as they change, so we'd have to pop until the list gets empty. Hopefully this will turn out to be more efficient overall.

I'll see how the priority queue fares.
It's so difficult naming variables that are holding cumulative values :(

On 1 January 2012 13:30, Luca Deltodesco <
reply@reply.github.com
> wrote:

> cumProb. nice name :P
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/deltaluca/flappy/commit/4933ea7ad47999e03cc02579e622532bdd114e7e#commitcomment-830265
>
I'm looking ahead in the commits because I saw this being wrong in the first one and I wondered if you fixed it later. And you did. Whew!

Now I can go back and read them more closely.
NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO
Yum! Yum!...
I'll think of a way to do that. I also want this to be usable outside of PyCUDA (but probably without the caching).
I also would like to fix some more issues for 1.2.9. But I feel that I will introduce some regression issues. I try to stop myself and to be patient ;-)
Would be fine if we had one release every month.
Requesting a null state is sometimes convenient, is there a reason to disallow this? Prior to your change, requesting a null state caused the current state to end without the user having to create their own "null" state object.
thx u <3
![awwww yeah](http://alltheragefaces.com/img/faces/large/fuck-yeah-aww-yeah-l.png)
Suggestions for improvements are always welcome.

At the moment all the logic for constructing the userDefinedBoost configuration resides with Ding.
Not exactly.
dtNavMeshQuery is already thread safe (at instance level) - no locking needed. There's copy per instance.

dtNavMesh has to be write-locked (exclusive) on load/unload _and_ read-lock (shared) on findpath.
Readers-writer lock allows multiple readers to enter the critical section simultaneously, but when writer comes, it has to be there alone.
Thus the name, multiple-readerS and single writer.

PS: I don't know if I'm really back to the usual or not (yet) :(
My bad. I didn't realize there was a spec suite. I'm going to be hacking on yet another region type soon, and I'll aim to bring in specs with that.
My idea here was that you would define your own kind of types and objects inside your "client". the scheduler would just do the magic check looking at the object id and see if you have one of those already running, and if what does the mask say..
aha, ok
you don't care about "Intel Mac OS X"?
Seems good to me - feel free to make the change.
hummm its this line
<!-- LUN file to be used by legacy USB manager.
<bool name="config_usesLegacyUsbDeviceManager">false</bool>	
The existence of this file will be used to determine in the legacy USB manager should be started. -->
<string name="config_legacyUmsLunFile">/sys/devices/platform/usb_mass_storage/lun0/file</string> as per http://review.cyanogenmod.com/#patch,sidebyside,11502,2,core/res/res/values/config.xml
Do you file it or do I?
The most of these permissions are invalid because I removed them with the new Skill system ;)

These are the only ones which still remaining:

MyWolf.use: true
MyWolf.leash: true
MyWolf.stop: true
MyWolf.call: true
MyWolf.setname: true
MyWolf.release: true
bool MMapManager::unloadMap(uint32 mapId, int32 x, int32 y)
just search this line in this file ...
Sorry. I should've thought of that.
I know you didn't write this ( I think I did )

I think it is more meaningful to have the args in this way: forward source -> destination

source is public ip, port, publicport
destination is VM: privatePort

maybe the name forwardPublicIpProtocolPortToVmPrivatePort or something nicer
So what about we drop this path as well? If RHEL 4 doesn't even ship with our target python version, I can't say we really should bother about it.
Could you add documentation for this commit? I'm very interested in using preload :)
Here no work for me
it is, u just need sql file  from forum ;)
Dette er en line note
Thanks!
I was about to merge this into dev2.0 but it seems that Daniel Savard has been working on the same lines:
https://github.com/nicolas-raoul/Anki-Android/commit/1c4455c21265ee17e0795c62f5d88e2003e964f9
If I understood well I just need to replace a line in enableActivityAnimation but I am going to work now ;-)
and by convention we put the constant first and the variable second to make dead sure we don't do unintentional assignments instead of comparison :-)
对于如此庞大的一个list，调用复制构造函数真的很浪费时间
Ясно - ще оправя тези неща при първа възможност.
乃终于有面对史前坑一跃而下的勇气了……（这玩意是不是一年木更新了？）我看看。。。
Hum, good point...
Adding emit would require adding smth like emit_broadcast too and that doesn't look very good to me. That would require Pool also to know about message, which breaks a Single Responsibility principle I think. I want to keep Pool as low level as possible. And substituting pool object is very easy anyway, so you can do anything you want to without actually modifying the original one (Open-Closed principle).

As for rooms of course I'd like to see your implementation :)
@shawnbot / @tmcw there's a regression in the anyscale example. If you do a two fingered swipe up or down in Safari on Mac OS Lion then the momentum scrolling gets interrupted as new tiles appear. It should continue to scroll smoothly.

This happens at the time of writing on 
http://prag.ma/code/modestmaps-js/examples/anyscale/

If you check out and test this version where I last fixed the issue, hopefully you can tell the difference (I admit it's a subtle one!) :)
https://github.com/stamen/modestmaps-js/commit/f59147036f06586feab82e0b8f39f5979c4888ea

The fix there was to add a new div that is dedicated to receiving mousewheel events. Not sure if that breaks other recent additions but it should be safe (and might also be useful for listening for clicks/drags on the map without having tiles get in the way?). It might need adjusting to always be on top of the other layers, not sure.
It isn't referenced in the code that I removed.
It looks like this guy got fat to actually listen. https://github.com/twitter/bootstrap/pull/2012 

Cheers.
I've never seen this in a PHP library/framework before. This does not mean, that it doesn't exists, but it feels not very common to me. So why this way?
Fix Ping.
Sad to see you go in private, good luck.
Critical updates, good progress.
There aren't any spawned in udb.
You seem to be suggesting that every single checkboxset field will get the chosen.js treatment, but that is only the case if the ChecktboxSetField_Select template is used.  I'd suggest applying another class, eg, "chosenjs", with the `CheckboxSetField_Select` template or simialr, and then applying this javascript to that class.

If a random developer chucks a vanilla CheckboxSetField into their getCMSFields, I believe it will break at the moment.
First of all, I cleaned up some Accessor stuff.

Then I created a controller called NewspaperRecordController.  You can see what it does by going to mhsbake/newspaperrecords.  Essentially, it is an alias for NewspaperReelController.  That is, it uses the NewspaperReels model.  However, it has it's own index and view ctp files (add and edit are yet to come).  This allows us to expand these index and view files to show additional data.

The trick was to modify the NewspaperReels model so that it returns all data for a given record.  I had to tweak the $belongsTo array and add Newspaper to it (Andy, please take a look at what I did).  The benefit of this is that everything necessary to populate the Newspaper Records page (or to populate a single record view) is done with one query (I don't count the 'count' query).

The add and edit functions will be a little tricky, as we need to make sure each table is updated correctly.  Also, everything we do here will need to be paralleled in Archives.  If someone else does Archives, please look at the changes made specifically in this commit.
cheers william
asda sd asd as dasd
it is fixed on the pull request ;)
I was pretty surprised, but it's definitely happening. When testing imports
of http://blip.tv/amherstmedia I hit this issue nearly every time. It could
be how my MySQL server is configured, but I haven't done anything to
configure it so presumably its a problem with the default configuration.

My guess is that if two workers update the value around the same time, they
both increment it to the same value and MySQL doesn't recognize them as a
conflict.  Django 1.4's select_for_update() might resolve this, but that's
for a future release.

-p
--
Paul Swartz
This message sent from a mobile device
I can look again, but where is:


>        if (totalsize!=(offset_t)-1) 
>            attr->setPropInt64("@size", totalsize);
>        if (useableCheckSum)
>            attr->setPropInt64("@checkSum", checkSum);

committed and if not, what is the point as unlockProperties clears attr..
I assume you mean Kalman, not Miracle.   Kalman is the main doer of this thing.
Needs to be new JsonWriter(writer, new char[0], "", JsonWriter.DROP_ROOT_MODE)
I believe this was supposed to be 2012, not 2011.
I'm curious why it never behaved as an octal escape previously...
Classes like worker do not have single responsibility because they aggregate other things. Database/broker connection is something that is centralized, inherently. So the best place to open channels I could find was in the worker. Worker instantiates its dependencies, those dependencies need separate channels (error handling happens on the channel level in AMQP).

Single responsibility principle here is a red herring. API-wise, worker does one thing (processes messages by orchestrating VMs, using travis-build classes and so on).
But yeah, everything seems to have been accepted correctly. I don't think the merge would have been possible if it was a formatting of anything other than HEAD :)
Yes, shouldn't link, image and others also in html5 have the enclosing? like `<img src />` or `<link />`
Ah ha! That makes it much cleaner. Thanks!

-John

Quoting Alec Goebel  
<reply@reply.github.com>:

> # Homework 3
>
> | **Part**  | **Points** |
> |-----------|------------|
> | base      |          0.75 |
> | advanced  |          0 |
> | for the lulz and alternate solutions    |          0.25 |
> | **Total** |          1 |
>
> Blockhead waiting...cute.  Overall, well done.  Your code and output  
> looks clean, albeit with a lot of extra spaces.  If you used string  
> concatenation instead of commas, you would have less spaces.
>
> ```python
>>>> print "a", "b"
> a b
>>>> print "a" + "b"
> ab
> ```
>
> Only other thing is you are doing your `raw_input` in a way I did  
> not expect.  Trailing commas at the end of print lines work, I use  
> them all the time, and are a great way to make your code cleaner.   
> That said, for this program I was looking for this:
>
> ```python
> prompt = n + ":"
> # ...
> print "PrissyBot: In what year were you born?"
> o = int(raw_input(prompt))
>
> # a simpler example
> n = int(raw_input("Enter a number: "))
> ```
>
> Anyways, for making me shake my head, I give you the  
> [facepalm](http://youtu.be/EAxGfmvQVZw) award
>
> ![award image](http://avatar.identi.ca/1765-96-20090311100848.jpeg)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jwsander/CS112-Spring2012/commit/9b7404b2dca164a54f9683e2264af40d3244a290#commitcomment-945284
>
This commit is from February 14, 2011. I must have had a reason for doing this but I must admit I don't remember. I also hate commenting tests.

The recently merged pull request introduced an API change in `precision_recall_fscore_support`. We could make this function private: it's more of an helper function than a function that should be exposed. If some people want to keep it public, I can try to fix that. @ogrisel?
Need more tests and time for more elegant solution. I am working on it. @Raynos thx for suggestions
with this awk statement the Makfile is broken
This Patch works for me
diff --git a/yaffmap_uci/Makefile b/yaffmap_uci/Makefile
index 1912340..09c5af5 100644
--- a/yaffmap_uci/Makefile
+++ b/yaffmap_uci/Makefile
@@ -1,9 +1,8 @@
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=yaffmap_uci
-PKG_RELEASE:=$(shell LC_ALL=C git show --format=%ai --name-only --git-dir=$(CURDIR) \ 
-       $( git rev-parse HEAD ) | awk '$1~/^[0-9]/{gsub(":","-",$2);printf "%s_%s",$1,$2}' )
-
+PKG_RELEASE:=$(shell LC_ALL=C git show --format=%ai --name-only | LC_ALL=C git show --format=%ai --name-only \
+       | head -n1 | sed -e 's/-/_/g' -e 's/:/_/g' -e 's/ /_/g' -e 's/+//g')
 PKG_BUILD_DIR := $(BUILD_DIR)/$(PKG_NAME)
 
 include $(INCLUDE_DIR)/package.mk
i'd probably just make these arrays directly accessible as constants (or methods, i don't care that much). doing it this way restricts the iterator you can use and the extra level of indirection is a bit confusing
Try something like this:
https://gist.github.com/1685835

On Thu, Jan 26, 2012 at 6:24 PM, Mateo Murphy <
reply@reply.github.com
> wrote:

> I can contribute something, once I figure out a working solution...
> haven't had luck with foreman and upstart so far
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/collectiveidea/delayed_job/commit/46533d64383bdec9ac0463c9d5e8a64f03f54d2c#commitcomment-906295
>
I'm curious about this commit. If you disable fsync, could it not corrupt your file system on a crash?
Probably I have found a solution about this issue. 
I think that the problem is the presences of old cookies in any new WebView call.

Try to use this code snippet in TwitterDialog.java:

    private void setUpWebView() {
        mWebView = new WebView(getContext());
        
        // START MY NEW CODE
        CookieSyncManager.createInstance(getContext()); 
        CookieManager cookieManager = CookieManager.getInstance();
        cookieManager.removeAllCookie();
        // END MY NEW CODE

        mWebView.setVerticalScrollBarEnabled(false);
        mWebView.setHorizontalScrollBarEnabled(false);
        mWebView.setWebViewClient(new TwitterWebViewClient());
        mWebView.getSettings().setJavaScriptEnabled(true);
        mWebView.loadUrl(mUrl);
        mWebView.setLayoutParams(FILL);
        
        mContent.addView(mWebView);
    }
You're just excited because not everything will block on me anymore. :sparkles: :+1:
This fails for me. Running Python 2.6.1, I get a `TypeError`:


    In [13]: bill = openstates.bill_detail( 'ca', '20092010', 'AB 667')
    ERROR: An unexpected error occurred while tokenizing input
    The following traceback may be corrupted or invalid
    The error message is: ('EOF in multi-line statement', (59, 0))
    ---------------------------------------------------------------------------
    TypeError                                 Traceback (most recent call last)
    /Users/camico/code/python/php/<ipython-input-13-4c638147bc6f> in <module>()
    ----> 1 bill = openstates.bill_detail( 'ca', '20092010', 'AB 667')

    /Users/camico/code/python/php/lib/python2.6/site-packages/sunlight/services/openstates.pyc in bill_detail(self, state, session, bill_id, chamber)
         57             lss.append(chamber)
         58         lss.append(bill_id)
    ---> 59         return self.get(lss)
         60 
         61     def legislators(self, **kwargs):

    /Users/camico/code/python/php/lib/python2.6/site-packages/sunlight/service.pyc in get(self, top_level_object, **kwargs)
         57         try:
         58             r = urlopen(url)
    ---> 59             return_data = r.read().decode(encoding='UTF-8')
         60             return self._decode_response(return_data)
         61         except HTTPError as e:

    TypeError: decode() takes no keyword arguments
i got the culprit!
Done in d1ac3f0405 and 75a464ba32.
Probably a better way to do this, most likely a placeholder.
Hi,

The Computer Guys is inviting you to join Facebook.

Once you join, you'll be able to connect with the The Computer Guys Page, along with people you care about and other things that interest you.

Thanks,
The Computer Guys

To sign up for Facebook, follow the link below:
http://www.facebook.com/p.php?i=1363206074&k=AQB0WBOdCpefbLWcyFdU9ZAdegile49ekoQgvrDrdKLjNdXnZpI1m5JH2kO29zQc5W1EA_SLKrcH1rVl&r&oid=154595704566248

You are receiving this email from The Computer Guys. The Computer Guys has sent you this message through Facebook. If you no longer want to receive messages through Facebook, click the link below.
http://www.facebook.com/o.php?k=09386b&u=100003480622249&mid=5ad3f16G5af3dff054a9Gb3b02G7c
 Facebook, Inc. Attention: Department 415 P.O Box 10005 Palo Alto CA 94303
@mbrochh Glad to help! Thank you so much for sharing your awesome code! The README alone helped me get the perfect setup on my WebFaction account. :)

I'm looking forward to seeing the code when it is ready for prime time.

Have a great day!

Cheers,
Micky
Thanks for contributing!!!

We have no time to continue withe the project within some months (fortunately, we have TONS of work)
Also fix your other derpy on line 97 and actually call the updateScreen() method
Drat.  I think I need 'force' push the old reference to unroll this
@neillturner Sorry for the confusion.  @geemus comment above is exactly what I am looking for, let us know if you have any questions.
I checked that into my `agentDisconnect` branch a little while ago.
I agree that a single word would be best.  pending?
I think you meant `$factory` instead of `$value`.

Might be worth a test case.
Your implementation should adhere to the principals of the interface. Callers probably would expect a `null`, not an exception based on the interface definition. Same goes for the other override methods.
It's probably appropriate to discard the context because you can't use a hash to access the paths in the context anyway.
Isn't this `.../akka-cluster-experimental...` ?
so we throw a match error if other party sends Connect without origin?
why would that be better?
factor 5 % is reasonable for a 100 node cluster, but not for 1000 node cluster
Oh Thanks! While it is unlikely that this method gets called twice, it is  
better to play safe, indeed.
Ok, so it was just bitrot?
Pondered it, shifted it around at the back of my head, and I still lean towards making it explicit that a `throw` is happening here. I’ve added one sentence above, WDYT?
I'd swap the ordering of limit and offset so that it matches the other functions
@davidread 

Why are we returning the user here? from what I can see this is a private function, am I missing something
+1 on RST
You've asserted this twice.
Ya, I suppose that's pretty terse even for me :)

I'll expand (r) and (rr) throughout the module.
comment says tuples, but these are lists. ;)
How about:

```ruby
@files = Dir.new(@path).reject { |fn| fn.start_with? '.' }.map { |filename|
  ...
}
```
Will be done in a very, very close future
This is wrong. the dts here is used for other things
Just an idea to prevent from the buffered packet. We should send streamchange also when a new stream was created, means completely parsed and added to the streams in demuxer. This can't be done with the demux packet.
Ah right, that's also a good approach. I'll go with that

On 10 October 2012 14:54, Sascha Montellese <notifications@github.com>wrote:

> In xbmc/video/VideoDatabase.cpp:
>
> > @@ -2730,13 +2730,14 @@ void CVideoDatabase::DeleteMovie(const CStdString& strFilenameAndPath, bool bKee
> >        m_pDS->exec(strSQL.c_str());
> >      }
> >
> > +    if (!bKeepId)
>
> Well the chance for a failed CommitTransaction() is very very small so IMO
> this change is acceptable but can you add a comment like
>
> //TODO: move this below CommitTransaction() once UPnP doesn't really on this anymore
>
> so we don't forget why it is there and that it would ideally be placed
> differently.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/1582/files#r1806780>.
>
>
Doel je hierbij op de FreeBSD ?
I think it's missing an assertion here
Revers the order of files
Fixed, thanks!  (and had a swing at fixing the travis error too)

On Sun, Sep 2, 2012 at 5:57 PM, Alexander Altman
<notifications@github.com>wrote:

> In src/Control/Lens/TH.hs:
>
> > +isoRules
> > +  = singletonRequired .~ True
> > +  $ singletonAndField .~ True
> > +  $ defaultRules
> > +
> > +-- | Build lenses with a sensible default configuration.
> > +--
> > +-- > makeLenses = makeLensesWith lensRules
> > +makeLenses :: Name -> Q [Dec]
> > +makeLenses = makeLensesWith lensRules
> > +
> > +-- | Build lenses and traversals with a sensible default configuration.
> > +--
> > +-- > makeTraversals = makeLensesWith traversalRules
> > +makeTraversals :: Name -> Q [Dec]
> > +makeTraversals = makeLensesWith lensRules
>
> Shouldn't this be traversalRules here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ekmett/lens/pull/30/files#r1513946>.
>
>
Please use the setter (and getter below) here as well.
this switch over handle.constructor.name is stupid anyway
I realized that your change limits the number of components in the composite buffer to 2.  Because the number of components are very small, I think it might be OK.
What is this TODO about ?
As above: this should be wrapped in an #if or #ifdef.
Why do you such high limits for a mock test? Also why is the apikey needed in tests?
@jeremy, as a part of the changes that i've made, the hash keys for fixture classes are no longer expected to be 'table_names' but 'fixture/names', and they are stored as strings (see `set_fixture_class`). 

`fixture_table_names` were not the actual table names, they were fixture names provided when calling `set_fixture_class` or `fixtures`.  They were parsed to guess the class name or the file name. I have made them convert to strings on input, so the only way to get a non-string in `fixture_table_names` is to call `fixture_table_names=` with non-strings directly, but this is not a documented API.  This is why i think that the defensiveness here is not well justified :).

By the way, i propose to deprecate `fixture_table_names` in favor of `fixture_set_names` (another time).
This can be simplified with `options.fetch`
Should we be removing defaults?  I realize they're unused, but that's the only questionable bit here, otherwise, GREAT WORK!
Yeah, whoever was clearly doing what I'm doing with this patch except...painfully.
varargs can also match when fewer arguments are provided.

```scala
scala> def foo(a: Any*) = a; foo()
foo: (a: Any*)Seq[Any]
res13: Seq[Any] = List()
```
+1 for doing the change suggested by @smichr.
defaultdict supplies a default item, so

```
dd = defaultdict(int)
dd[2] += 1

vs

d = dict()
if 2 not in d:
    d[2] = 0
d[2] += 1
```
Agreed. Actually that test is unnecessary.

But I am not able to come up with a function that when sampled, has end points which are complex, but has points between it which are not complex. This does not take care of it.  I added it when I noticed a couple of other bugs.

I will remove the test.
Somehow the TreeMap disagrees and nullpointers in the DeepEquals, EqualsUtil.equals(d_som, other.d_som) does pass however but is of course different.
but i didnt change in my new branch
Pending discussion of points below, this method might not even be needed (only called once, and that code should be in the model where a validation can probably do this work).  If it is needed here, a better implementation might be ````object.is_a?(Numeric)````.
dragStart, dragMove, and dragEnd are not global in scope and, therefore, unrecognized here.
What is the String in this map?  I'm thinking it might be the subType, which seems weird to me that we are aggregating all replicants across all subTypes?
use :dbcommand: rather than :program: for database commands. :func: annotates shell helpers.

so: 

- `clone` is a database command
- `copydb` is a database command
- `db.copyDatabase()` is a shell helper. 
- `db.cloneDatabase()` is a shell helper.
or are you worried about md5 collisions?
pep8 nit: extra line with whitespace
Thanks didn't  know that ;) I'll make the change, it's nicer that way.
Should be wrapped in /* */ as per coding guidelines.
This would break BC for all mods and everything that uses SQL caching. We'd also have to rewrite the way the cache is interacted with to separate the two since the service works by catching calls to the service and checking if the method exists in the drivers, then calling the appropriate driver (there would be collisions).

I don't think the latter would be an issue, but I don't think we should break BC just so we can rename these to be a little less redundant.
Ah okay, so if the name of subsilver2 is `phpbb/subsilver2`, the parent string here should be `phpbb/subsilver2`.
nit: newline above this
Hm, probably there should be one return statement in function:
```cpp
bool ImageTexture::load(const Image& image) {
    bool needsLoading = !image.isNull();
    if (needsLoading) {
        // ...
        // no return statement
    }

    return needsLoading;
}```
Because each return statement generate much code with destructor calls.
@caridy Just to clarify, this is not a "mojito build" feature -- that code is triggered by constructMojitoClientRuntime(). Others can comment, but by the time ac.deploy addon is run, all the yui modules urls have already been set (with correct base, comboBase) -- all that is done in mojito-loader. If those custom values are set in application.json, that would work. See line 640 - it would definitely be better if this was retrieve from config.
Should comboBase be appConfig.staticHandling.prefix + '/combo~' ?
this is not longer supported.
Maybe it is dirty hack, but it works.
And im newbie also :P
Yes, it,s a mistake. Sorry for that. Will fix it soon.

On Wed, Apr 18, 2012 at 2:25 PM, nathanleiby <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,45 @@
> > +/*
> > + * Screener application, by John Stoecker using Sencha Touch 2.0
>
> Do you know why this screener (Sencha Touch 2) code is being included
> again in the pull request? Is this a mistake?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Raxa/Raxa-JSS/pull/18/files#r700014
>



-- 
Vikas Singh
Senior Undergraduate
Department of Computer Engineering
Institute of Technology
Banaras Hindu University
Varanasi
Ph: +91 9838438152
Can you use the more standard key=value style, instead of : (colon)
不用描述类型，你的默认值会表示出这个含义的。
To and From.

I would put this section before the Properties section.
I made an issue gh-832 for this
Should say ``n elements``, not ``x elements``
Mismatch between number of %s patterns and input arguments (missing path_in or path_in_full).
Either way, i removed the unloading bit. Not having it doesn't seem to affect any of our existing tests.
Thanks Simon & Alex of convincing me to change this. You were right, it does look better now...
This function should return some values to be checke by its caller, not set things on self.
I think my editor done some indent errors sorry for that.
Can you remove Flask-Admin from hgapp? We don't use it anywhere.
If you want meaningful errors, just define a version of the helper that throws an exception in `manipulation.js` then:

```js
jQuery._executeDOMScript = function() {
    throw "ajax implementation needed";
};
```

Then, and only then, override it in `ajax.js`.

Duckpunching of jQuery.ajax is not an issue here. You can do far more damage with ajax prefilters, that will effectively bypass any explicit option. We're talking actual alternative implementations to `ajax.js` ones that would *not* have `$.ajax()` defined (obviously so that the implementor doesn't have to be backward compatible) or even another lib (like using a 3rd party for the ajax calls). That's where the hook is necessary.

Documenting is moot as long as the hook version that just throws is in manipulation.js and has proper comments: that way it is in versions of jQuery build without `ajax.js` and thus can actually be overriden. You cannot override something that doesn't exist in the first place which would be the case if you build a version of jQuery without `ajax.js` in.
Do you really want to fall through this? Trying to wrap my head around this since we're also in a `!== "loading"` situation now.
On a side note, this change doesn't bother me at all.
It seems this query can be optimized as

```sql
SELECT parent_id, MAX(lmc_id), MAX(lmc_fval) ... GROUP BY parent_id
```
Do you see how in plpython we can create internal functions like this and *not* expose them at the SQL layer?  This is a significant benefit from a programming perspective and is one of the advantages of using plpython as our implementation language instead of plpgsql.  It is also *much* faster to call a function directly instead of having to go through an SPI function call.
File jiras for unresolved issues/improvements and refer to the jira number in the comment.
I think I'd rather omit these print statements.  If we want to report which compilers are being used, we should do that separately from option setting.  The compiler command line and link flags show up in the output, anyways.
I'm not sure because they are very specific on what we are going to test. I've added more tests to test warnings and errors.
`mecab_support?` is called in the class context of the Hyperestraier class.
How many external formulas are there? Pretty much all of the xcode_version checks in built-in formulas are to decide if they should depend on autotools. I think we should clean those up to do a more specific check first.
This result should probably be cached.
Is the empty array necessary here?  If so seems like a bug in the higher level command logic.
Il faut retirer cette ligne (et celle qui est dans MADMIN.class.php), je vais les retourner dans Ginger.
I think this should use the new redis config utility functions.
Думаю, пора подвести итог.

1. Терминология. Всё-таки тема про git, и здесь существует своя устоявшаяся терминология. Аргументы командной строки, официальная документация, другие места нашей книги — всё опирается на эту терминологию.

2. Слияние коммитов. Я и не знал, что это допустимо, забавная возможность. Хотя, конечно, строго говоря, слияние все равно происходит не с коммитом (ибо он неизменяемый), а с головой, пусть остаётся текущая формулировка.

3. Исправленная версия уже не допускает двойного трактования — можем на этом и остановиться.
По семантике вопросов нет, дальше можно только пытаться выразить ту же мысль более лаконично:
> Так как ветка, которую мы слили, указывала на коммит, являющийся прямым родителем коммита, на котором мы сейчас находимся
> Так как мы слили master с веткой, указывающей на потомка текущего коммита



Что касается теории графов, то в git, на мой взгляд, удобнее закрыть глаза на реализацию и думать об абстрактном графе, ориентированном в противоположном направлении (аналогично воображаемому направлению тока, противоположному физическому движению электронов).
Capitals for RPM, SRPM, and DRPM.
Please specify the source of the warning in the log message, e.g. `Socket Handler: The session id is not set ...`
timestamp1 and 2 are passed into the diff3 function as titles for the diff output.  It was done this way for a reason.
Is that okay using `org.glassfish:javax.faces` dependency directly?
@senny you can probably change this to `page1.reference.should equal(page2.reference)`
Woops.  I can't believe that's rule 1, but my mistake.  It was a proxy for how I was structuring my thought.  Removed.
Yeah I can see it now. Shame, but I can't see any other way yet either.
If it doesn't accept ints, you should convert it!
Since 'toggle' is a verb, this is confusing classname. It would seem to refer to a state, but it actually refers to the button itself.
refactored Params and usage of encode/decode URI component
Would be good to add a comment here explaining what this `if` means for unit test execution (similar to the comment in HTMLCodeHints/unittests.js)
It is a actually a scale parameter.
Why do we add to `dcpu.cycle` in the op cases if we do it here?
well actually now it is like that. ;) I gave the name to slovenian language ``Slovenščina``and to english language ``English``
Why image is not in `li`?
Not good values!
I don't think you need an `if` block here at all. `remove` can't fail if the class isn't defined.
Not doing anything with this, but I figured it might be useful. I can take it out
why _container vs. media (underscore and no underscore)?  You should pick a style and stick with it.
If no draggable has been run yet, it won't. Since both this and our plugin-list code create iframe covers, this checks to see if the element `.butter-iframe-fix` already exists before creating it.
one line this Fn:

    return Math.max( Math.min( value || 0, max ), min );
cool, everything I've mentioned about the classList stuff can be ignored then
Need we include a shim for `classList`?
Why `cgi-bin`, not `cgi-ssl` here? According to docs, it should be cgi-ssl and it works for me that way...
http://tech.dibs.dk/dibs_api/payment_functions/authcgi/
Style (commas should be followed by a space)
I'm not too familiar with HAML syntax - are these lines commented out now?  If so let's just delete them.
How about:

```Julia
abstract AbstractList{T}

type EmptyList{T} <: AbstractList{T}
end

type List{T} <: AbstractList{T}
    first::ListNode{T}
    last::ListNode{T}
end
 ```

Then you can use dispatch instead of `isa`.
so just remove the line completely?
if profiling is not enabled in application.rb, the module will not add any filter to a controller, see https://github.com/Katello/katello/pull/177/files#L4R4. I think this is ok, what about you?
`{string}`
oh neat. didn't know how expensive stat's were
Hmmm, could not find any... Or do you want me to create one there?
Look into using an HTML reset button. It reduces the size of your code.
Actually I wrote that before reading @eteq's comment just above it.  Looks like a plan (though I'm still not sure about setting an upper memory-limit; maybe just a warning that lots of memory will be used)
I forget--is `table.meta` assumed to be a dict?  If so you can just do `table.meta.update(set.attrs)`..
This isn't appearing in the sphinx documentation.  I think you need to add something like what I have below to the class docstring

```
Attributes
----------
ptype
```
This function was confusing because the comment and return spec mention buckets, but there are no buckets in the input spec or anywhere within the actual code. Maybe change input spec `list()` to `[{riak_object:bucket(), pos_integer()}]`, and rename `I` to `B` or `Bucket` in the list comprehension? Also, the word bucket is used a lot in this/related modules. Is that the right generic term? For search, these are actually schema definitions, not buckets, right? Does this matter? And is `riak_object:bucket()` still the right type?
I don't think checking the number of bytes currently available is correct. "reply" is a stream-like object, and it is very possible that no bytes are available, but they will come in later (or, in case of a HTTP response without Content-Length header, when the total length isn't even known in advance). 

We should restrict the number of bytes read, not the number of bytes available.
Recovery is never a nice process, if things are broken enough you always get to a level where you have to look at hexdumps of the raw file to salvage anything. At least you still get delimited keys/values here. 

Is it any prettier for leveldb, for example?
Hardcoded App folder?
Hmm, if remove the 'on' my test case fails. So I am not sure what it does. I copied this from the `testDefaultToLoginRedirect()` function. There too if i remove the 'on' the test case fails.
Sorry these are probably not meeting spec standards, but I figured it was a start.
I'm a bit uncomfortable about this feature; It's interesting that it gives us the execution context regarding the roles in use, but at the same time it starts to drive us to a situation where we don't know what could happen because it's not explicit which roles we're using or not - for example, if we go out of a "self.using" context manager block, we're no longer using that specific role -. Also, this makes us tightly coupled to the context.

An alternative would be to define explicit behaviour for each role that can have different behaviours depending on the situation - for example, some roles can provision differently depending if it's Ubuntu or Debian, but they're not coupled to the context to be able to do so -.

But let me know what you think, maybe you can convince me it's worth doing so. :-)
I've tried to fix this in a more recent commit but there seems to be some problems with this exception raising in that the notebook raises a unicode type exception here while the console
raises the exception I expect:

Notebook
UnicodeDecodeError Traceback (most recent call last)
/Users/jonathantaylor/ipython/IPython/core/interactiveshell.pyc in run_code(self, code_obj)
2722 self.CustomTB(etype,value,tb)
2723 except:
-> 2724 self.showtraceback()
2725 else:
2726 outflag = 0

/Users/jonathantaylor/ipython/IPython/core/interactiveshell.pyc in showtraceback(self, exc_tuple, filename, tb_offset, exception_only)
1713 value, tb, tb_offset=tb_offset)
1714 
-> 1715 self._showtraceback(etype, value, stb)
1716 if self.call_pdb:
1717 # drop into debugger

/Users/jonathantaylor/ipython/IPython/zmq/zmqshell.pyc in showtraceback(self, etype, evalue, stb)
505 u'traceback' : stb,
506 u'ename' : unicode(etype.name_),
--> 507 u'evalue' : unicode(evalue)
508 }
509

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 132: ordinal not in range(128)'

Console
RMagicError Traceback (most recent call last)
in ()
----> 1 get_ipython().magic(u'R library(nosuchlibrary)')

/Users/jonathantaylor/ipython/IPython/core/interactiveshell.pyc in magic(self, arg_s)
2129 magic_name, _, magic_arg_s = arg_s.partition(' ')
2130 magic_name = magic_name.lstrip(prefilter.ESC_MAGIC)
-> 2131 return self.run_line_magic(magic_name, magic_arg_s)
2132 
2133 #-------------------------------------------------------------------------

/Users/jonathantaylor/ipython/IPython/core/interactiveshell.pyc in run_line_magic(self, magic_name, line)
2055 args.append(sys._getframe(stack_depth).f_locals)
2056 with self.builtin_trap:
-> 2057 result = fn(*args)
2058 return result
2059

/Users/jonathantaylor/ipython/IPython/extensions/rmagic.pyc in R(self, line, cell)

/Users/jonathantaylor/ipython/IPython/core/magic.pyc in (f, *a, **k)
188 # but it's overkill for just that one bit of state.
189 def magic_deco(arg):
--> 190 call = lambda f, *a, **k: f(*a, **k)
191 
192 if callable(arg):

/Users/jonathantaylor/ipython/IPython/extensions/rmagic.pyc in R(self, line, cell)
330 if line_mode:
331 for line in code.split(';'):
--> 332 text_result, result = self.eval(line)
333 text_output += text_result
334 if text_result:

/Users/jonathantaylor/ipython/IPython/extensions/rmagic.pyc in eval(self, line)
107 except (ri.RRuntimeError, ValueError) as exception:
108 raise RMagicError(unicode_to_str('parsing and evaluating line "%s". R traceback: "%s"\n' %
--> 109 (line, str_to_unicode(exception.message, 'utf-8'))))
110 text_output = self.flush()
111 ri.set_writeconsole(old_writeconsole)

RMagicError: parsing and evaluating line "library(nosuchlibrary)". R traceback: "Error in library(nosuchlibrary) : 
there is no package called ‘nosuchlibrary’
"
Note that we only have the module author's word for it that names in `__all__` actually exist - we should make sure that it doesn't blow up if one of the names is wrong. This gets called by wildcard searching and tab completion, I think.
One of the goals of this is to avoid the unlimited iteration through containers of containers.  There are two approaches to this:

1. only iterate through top-level containers (e.g. `return (5, np.array(...))`)
2. allow some configurable depth, which can limit this.

I went with 1., which means that containers should not automatically trigger nested canning (now there's a mixed metaphor).

What this means is that it is now easy to manufacture a case that this new serialization cannot handle:

```python
In [17]: view.apply_sync(lambda x: x, lambda y:y)
Out[17]: <function <lambda>>

In [18]: view.apply_sync(lambda x: x, [lambda y:y])
---------------------------------------------------------------------------
PicklingError                             Traceback (most recent call last)
...
PicklingError: Can't pickle <type 'function'>: attribute lookup __builtin__.function failed
```

The first worked, because can_sequence was called on:

    args = (lambda x:x,)

and the lambda was canned. The second failed, because it was called on:

    args = ( [ lambda x:x ], )

and the inner list was left untouched.

If we want to allow this kind of thing, then we need to expose a limited depth somehow, and I would probably set the default depth limit to 2, where the current behavior would be equivalent to setting it to 1.

Since that is more complex, I would rather have this limited case first, and only add the complexity of limited depth if people are encountering problems in real use cases, rather than contrived ones.
I see you have made this a class but in the main html template, it is still the toolbar id.  Is this right?
Indeed, and I checked getoutputerror, which now guarantees it will return a tuple of strings (apparently it used to return *either* a tuple of strings or None).  That makes this code a good deal simpler.
My only question is: is SYSTEMROOT *guaranteed* to always be available on windows, or should this do a check like we do for PYTHONPATH just above?
"In each case, embed can be specified explicitly with the `embed` kwarg."
`tornado.escape` is only available here because importing `web` and `websocket` imports `escape`, whereas doing just `import tornado` does not. We should be explicit and either `import tornado.escape` or `from tornado.escape import url_escape`
try immutablelist.builder
Would it be better to add `created_by` to the search criteria before loading children rather than filtering after the fact?
d677c99
Oh, I forgot to use this parameter to overwrite the key if `$column` is set to something other than `id`. But I wonder whether that feature would ever be used. And, more importantly, why should it be?
OK .. I'm changing this.
What is  {{ }} signify here? 

I remember we used it for exists check?
By pulling the documentation out of the ModelView documentation, you aren't in the ModelView context anymore -- it's not hard to use SearchForm without ModelView. This should be described here (first).

The integration with ModelView belongs somewhere else.
Presumably to act as a default initial selection, but it should probably have some kind of text label to that effect (e.g. "select"). It can (perhaps should) also have selected and disabled attributes.
Since this is a static page you could just use `mozorg.util.page` and get rid of views.py completely.
It's probably worth having a comment above this that explains what it's trying to enforce. e.g.:

    # Enforces at least one digit and at least one alpha character.

Also, it's good to declare this string as raw with an r before the '. In this case \d doesn't escape into anything, so it remains as \d which is correct. It's still a good convention to use.
I just read about `IGNORE`--that's super helpful.
__whimboo__ wrote:
> ... Also there shouldn't be the need to call test.get() because the property will always be available.

This is not true. There is at least one case when `test[time_end]` throws.
The file should be in the temporary folder. So why do we have the 'not' in here?
"against" instead of "againt".
Could  you please leave me out of this discussion?  

Thanks.  


Am Montag, 19. November 2012 um 20:07 schrieb Seth Falcon:

> In src/chef_wm_base.erl:
> > end > catch > X:Y -> > error_logger:error_report({X, Y, erlang:get_stacktrace()}) > end. > > +create_500_response(Req, State) -> > + %% sanitize response body > + Msg = <<"internal service error">>, > + Json = chef_json:encode({[{<<"error">>, [Msg]}]}), > + Req1 = wrq:set_resp_header("Content-Type", > + "application/json", Req), > + Req2 = add_version_header(Req1, State), > + wrq:set_resp_body(Json, Req2). > + > +add_version_header(Req, #base_state{version_info = Version}) ->  
>  
> might as well rename helper function to add_api_info_header
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/opscode/chef_wm/pull/38/files#r2171198).
"Send reminders" is too vague. Don't worry, I'll come up with something much longer that I think will make it clearer what is going on.

Attempt 1: notify_last_page_editor_to_update_contents_of_page
Attempt 2: ask_last_page_editor_to_update_pages_that_have_not_been_updated_in_a_year

Any preferences?
Can you make sure that the packages are following the examples set in other files?
Im pretty sure i split these two up, because they were overriding username and password.
This shouldn't be needed, since phpunit.xml already has that set as a bootstrap.
Перед ```return;``` має бути один рядок відступу
should be `Prepends` and should end with a dot.
Why do we need a define. if version_check is really that expensive, then it could be set into a private static inside a class in constructor..
the same formatting could be used for the 2 arrays.
Why not `contains` ? And `notContains`.
I disagree with the naming. 
1. The word `meta` alone makes no sense here. I guess you mean metadata.
2. The method is missing the `Bag` suffix to be in line with `getFlashBag`

So the method name should be `getMetadataBag` and the class must also be renamed accordingly.
Yep thats what I also suggested but apparently wasn't clear to @hason
There is no security issue when using this configuration setting. The only thing is that it is not as flexible as the new way.
It is good idea not to change the code like that. This was correct code that complies with PEP8 and these changes only pollute git history.
Is this an error?  I thought we'd agreed to treat images with missing alpha as fully opaque, except for the special case when nchannels == 4, and alpha_channel == -1.
I can doctor up the "public" documentation before committing as well.  Don't sweat this too much as a precondition for passing the review.  But internal documentation (why a particular section of code does a tricky thing) is part of the review.
Hmmm. This is really a "download and plot" function. I've no problems with it as it is though, at the end of the day, the script is there to help sysadmins/packagers to download the data they want to distribute with a deployment of cartopy, and that is what is does.
If you're gonna do that, use world.getMaxHeight() - 1 and don't forget to change lines 130,131,143,144
That does make more sense.  Moved to cms.base.js
(unexpected space before comma)
тогда только String sectionLink
move this to a non inline function
Please change the identifiers as per https://wiki.mozilla.org/L10n:B2G/Developers#Changing_strings_after_the_string-freeze