labofsahil/github-event-dataset-2012 huggingface dataset:
You are right, and I thought about it. The problem is that the actor also needs the list of threads, so a solution would be to get the thread list back from ScalaDebugTarget. But I'm not sure it is  such a good idea.
You can even remove the `(_)`, the expected type is a function type, so the compiler will figure out what you mean. :)
I think this is a relevant test. Should not be skipped.
I see the following two recommendations different from the previous ones, so I would move them out of the list. 

Apart from that, the first sentence "Updating to a new maintenance release is a process requiring little effort from the first GA forward" is a bit risky since people always complain that's not the case (for a variety of reasons). It might be safer to just not say anything or just refer to the points above by saying that updating to a maintenance release is an smaller cost than updating to a minor or major release because there are no new features or public API changes.
It's better to leave the click handler on the element rather than the iterated ones.
@slebedev что то я не понимаю, где там сказано, про то что А не может замениться на А ? То что в итоге А фактически остается А, то повезло, этому элементу, я понял этот пункт так и ни как иначе. 
Если в требованиях не указано, что элемент должен после изменения поменять свое текущее значение обязательно, то это является модификацией требований, а это не приветствуется в любой разработке приложений. :)
Добавил на автомате. Это что-то меняет?
Yup, definitely fix other people's code as you go. We follow the boyscout rule, always leave the area cleaner then when you got there :-)
My bad! ((
The problem with this solution is that the order of the gettext string parts and the '$count' variable is fixed, which may not work with all languages, with sprintf the translator is free to change the word order. In fact, ideally the whole 'Delete all %d entries this table' should be contained in a single gettext. 

There is a good introduction in how to 'Creating localizable web applications' in the Mozilla developer network.
https://developer.mozilla.org/en-US/docs/Web_Localizability/Creating_localizable_web_applications
It'd be cool to post this directly to the mailing list rather than to some obscure email address
Could/should this line be inside the `if` above?
Do you want to capture the message here before you exit?
s/expression/operator
Either this `else` block will never run or we get an `IndexError` 4 lines before.
if duration is not None and duration > 0.:
Are you accepting POST requests to this views?
I think it's wrong doing this because the session can get flushed and this gets persisted to the DB
yes. I probably was not quite sure at the time how to change the debug levels.
This will cause the if condition to be evaluated twice, right? Not sure there's any way around that though..
I completely agree - I wasn't even really thinking about the word - I've replaced all the different throw/throws/thrown with the proper form of "dispatch".
`create_migration('add_clearance_to_users.rb', config)` needs a class method called `next_migration_number` to create the timestamp in the file name
Just checked and we don't use this step in the project. Will remove.
a = sorted(q.iteritems()
Для конкретно таких вещей лучше `std::find_if` использовать, он параллелиться может и все такое. Но это так, мелочь на будущее.
Я тебе и в прошлый раз писал, что это необязательные строки, мягко скажем.
Es cierto, pero lo hice rápido porque sigo sin estar conforme con ese estilo. Hoy quiero hacer un pequeño arreglo con el NavBar, si encuentro el lugar correcto lo acomodo
I'd probably have this be .winner? just to show that the method is a boolean that you can make a decision on
Readability nit: please add spaces after commas.
This is the line that will probably break, throwing ClassCastException
I've added notes about all of this
It seems you don't use `error`. Why you don't just pass nil?
Oletetaan, että `a-seq` = `[nil]` ja `b-seq`=`[]`.  Nyt ensimmäinen testi epäonnistuu, sillä `a-seq` ei ole tyhjä. Toinenkin testi epäonnistuu, sillä:
~~~clojure
(not= (first [nil]) (first []))
;=> (not= nil nil)
;=> false
~~~
Just came across the dev thread suggesting this. I'll check the motivations and reply if necessary.
the hard part is scrolling it to see what it actually does...
yeah, i don't agree with this one either, and agree with both of you, change committed.
The inplace (what you're suggesting) is probably less expensive.  I'll experiment with that.
PEP8: spaces around binary operators like '+' and '/'
Done, thanks for spotting that! :)
A lot of these onsuccess and onerror callbacks are just doing console log output but aren't making sure or giving indication to the caller that you've successfully or unsucessfully completed the function call made. For example, this function tries to enable data, but if it fails, how would the caller know that the data enable failed? 

A possible mitigation to ensure that the caller gets a boolean back to know that the operation was successful or not and validate it in the respective python test using it. Or you could just validate it in each function respectively making sure that "was this operation completed successfully?"
same here https://github.com/zacc/moztrap-tests/blob/68bec9950e23e5d41d98ec084cf1ed4de885512f/tests/test_homepage.py#L75
More work needed here. There is standard way, how the exceptions should look like and it would be nice to have it.
@apex13 since we don't support IE5.0 nor IE5.5 [1], can we remove `cursor: hand`?

[1] http://www.quirksmode.org/css/cursor.html#note
@bp323 Can we define `getStyleUrl` and `getAllowThemechangerValue` in the right order of execution. They are currently defined after they are used.
Yeah good point, that's a best practice we should be enforcing.
I'm a bit confused, how do you mean selecting twice? can you step me through the situation? ie. 'click approved reports' then.. ?
This is a thread that isn't owned by a connection. That is bad for a couple of reasons:
1) It means there is no obvious way to output error/logging information (i.e we don't have a session handle available).
2) It is a new scope in Wired Tiger - up until now the connection has been the highest level object.

It would be possible to do this work within eviction threads. It's not necessarily zero work, and co-ordinating between the eviction threads to pick one to do the cache pool management (or implementing management that could be run by all eviction threads) is non-trivial (at least conceptually, if not code-wise).
yessir http://jsperf.com/concat-vs-push-apply
will this go into a busy loop on error?
The assignment to ``$result`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
this isnt yet supported. disable the button and put a comment with the jira id
This sentence needs a little punctuation work. How about:

...code—for example, your entire update loop—and then
Please don't use a singleton. Use dependency injection by injecting the cache in the extension instead
@technoweenie standby, fixing.
bravo! :)
Re-added by commit 755c5ac99dac9d5ab4f94fe204f02f44d02121da.
do you know why clearAttributes doesn't handle this, or is it because those things begin with `$` or `_`?
I think this method could/should be renamed, it's really close the already existing `finalize()` method and could cause confusion.
Accordion look good. Yes, I have to provide link back to odpiralnicasi.com somewhere.
Ehm. You should not copy-paste my example literary. Please read how you should define documents. My code above is not valid MongoEngine document with fields. You have to assign instances of field classes to attributes, not fields classes themselves.
I don't understand. What we are speaking now about? `url` tags knows how to populate template context by itself. You use `with` tag only to rename or set other values to the template context variable names `form.html` expects.
Please read the regex there and explain it to me. Not just use it. Try to understand it.
Aaa. This is a function? You are crazy? Do class-based views!
Yes, this is not needed, I will remove it.
you mean ```>``` selector in jquery? :)
I don't see how that's possible. `"\\="` and `"\x5c\x3d"` are equivalent.
should adjust the comment accordingly ;)
I don't get the intent of all this rewriteAccessAccept stuff.. The rewriteAccessAccept is a pf::radius core extension hook, it is not related to the pf::SNMP subsystem. None of these will ever be called. It can probably all be safely removed.
Okay, that makes sense. Can you add a comment above that target so its clear what's going on?
Yes. I think the same, too. It should be using `<ARGV[1]>`
it needs to be merged
This is not a real promise, so I would personally not call this `resolvedPromise`.
Also, watch out for localization issues. That's the real reason to use the lib, some languages / locales do weird things. At least if you're using the standard library, you end up being broken the same way everyone else is.
yes! I don't actually know his first name, only that he is schisamore
We usually prefer anonymous namespaces to the static keyword, is this an ngx convention?
I always forget to remove these, too. I hope we don’t get sued by __MyCompanyName__. :-)
is c always 1.06 or should this be an option ?
I am glad.
The un-commenting of these scheduled tasks does not seem related to 3130.
Again, not your fault, but there is no such constructor for SBConvolve anymore.  Nor a 1-argument one that isn't a list.  In fact, I recommend just using the list constructor.  I don't think there are any efficiency gains from the other versions, so it would be simpler to just use the one.  (And probably check that the list isn't empty here, rather than rely on whatever is done in the c++ layer.
This is really the displayFormat right?

Isn't the VoucherCodeFormat always alpha numeric?
not sure what happened here. reverting my changes.
What do you think about using a regexp like this?
http://stackoverflow.com/questions/8484945/regular-expression-for-matching-latex
I don't think this should be commented out. Can you check changes to this this file again please?
Should it be useable as soon as start() returns?
Do we need to wait for SERVICE_UP before continuing with rest of test?
If you look at the other examples in this guide, you'll notice that I don't use spaces after opening braces.
Theoretically, you should have 0 collisions at this point.
This set to `false` should check if `approved` has some value. Something like

```ruby
  self.approved = false if self.approved.nil?
```

Anyway, this kind of initialization should be in the `:default` option of the column
This one is no longer needed, as I've added them as part of PR 196.
That's the latest under the sample messaging app, I just updated the docs to reflect it since it was confusing when I was trying it out.
Please use .presence instead:

    <%= post.title.presence || post.translations.detect{|t| t.title?}.title # also unsafe if none found
global.pzpTLSServerPort should give you this value.
`->beforeNormalization()` would allow to change the keys names (if that's what you are looking for)
Why are those not commented?   This may/may not fuck up the values.
In redmine_gollum plugin I used a dedicated model for settings and patched the redmine project settings page to include a partial view: https://github.com/gugod/redmine-gollum/tree/master/lib 
So that a user can go to project's settings and setup plugin's settings.
There's were requests to add easy API for that: http://www.redmine.org/issues/8332 http://www.redmine.org/issues/3686
Your liks should use references like the other sections. This will make sure the line length are more consistent. and easier to read the raw .md files.
Что делает эта строка?
А здесь -- Long.valueOf
Пустую строку в конструкторе не нужно передавать.
This doesn't look right to me. CMake should be taking care of that for you if you just say

```
target_link_libraries(${PROJECT_NAME}
  graphdb
  graphrender
)
```
Please disregard this file :)
It looks like the `connection` and `request` objects never get released?
if this function is meant to be only internal it should be prefixed by an _ so _enet_cd
```python
mask = [x in labels and y in labels for x, y in  zip(y_pred, y_true)]
y_pred, y_true = y_pred[mask], y_true[mask]
y_pred, y_true = label_to_ind[y_pred], label_to_ind[y_true]
```
No need to put this in a val, just call it inline.
@vickybiswas can you make sure these are properly prepared?
I believe QObject::connect will take ownership.
Sort of unrelated, but do you think we should use `=== undefined` instead of a `typeof` check @steves ?
It's a temporary placeholder. I don't want to remove or totally disable the
code; but I don't want to pollute the interface that people will really use.

Of course, eventually, we want to check everything - scala source deps,
java deps, jar deps, and anything else that could produce Java bytecodes.
But this is a first cut. As it stands, running only scala dep checkns, this
provides useful information, which is why I pushed it. Once the code to
extract the necessary information from java targets and jars is ready, then
I'm planning to remove the "check_all_deps" option entirely - if you want
to check if all deps are declared, you should be told about *all*
undeclared deps.

How about, as an interim measure, give the flag a name that makes it clear
that it's a temporary debugging aid? "debug_dep_checker"?

     -Mark



On Tue, Nov 6, 2012 at 6:59 PM, Benjy Weinberger
<notifications@github.com>wrote:

> In src/python/twitter/pants/tasks/scala_compile.py:
>
> > @@ -71,6 +72,18 @@ def setup_parser(cls, option_group, args, mkflag):
> >                              action="callback", callback=mkflag.set_bool,
> >                              help="[True] Enable color in logging.")
> >
> > +    option_group.add_option(mkflag("check_missing_deps"), mkflag("check_missing_deps", negate=True),
> > +                            dest="scala_check_missing_deps",
> > +                            action="callback", callback=mkflag.set_bool,
> > +                            default=False,
> > +                            help="[%default] Check for undeclared dependencies in scala code")
> > +
> > +    option_group.add_option(mkflag("check_all_deps"), mkflag("check_all_deps", negate=True),
>
> Can we boil this down to one flag? This is really confusing. Surely we do
> want to check java/jar deps as well as scala deps?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/foursquare/twitter-commons/pull/3/files#r2050348>.
>
>



-- 
Mark Craig Chu-Carroll
*** Software Engineer@foursquare, Software Tools/Programming Language/Math
Geek
*** Email: markcc@foursquare.com <markcc@gmail.com>; Twitter: @MarkCC
*** Blog: http://scientopia.org/blogs/goodmath
If I only allocate maxRows then this logic will get invoked with almost every subsequent row I add.
use

    return matchesTypeCode(type, type_dictionary)

instead (like function below)
Well, without this line empty slug is not filled with needed value (when updatable=false), so it seems to be needed
optimize doesn't exist anymore.  it seemed incorrect to expose that and that it might lead to abuse or confusion in terms of lookup.
You'll want to remove this file; couldn't figure out how to exclude it from the pull request.  Sorry!
this line is from the original file.
we should keep a way to observer exceptions on the chrome side for things like exceptions in content scripts.
this one should be on ``run``. You may want to change the additional repo if you run it twice
OK, I understand, I will get used to that.
おっしゃる通りだと思います。
Eclipse reformatted the file when I edited it. Rather than fight with it, I left the reformat in.
the test needs to be parameterized. please implement the data using a data provider so that we iterate through data for the test. for instance, with time, time zone and other values we want to iterate through in our test to make it more robust and complete. What you have here will only test one static data set. If you parameterize it you can just add data to the data provider and test the entire data set. Also when the dataset changes you can make the change in one place rather than multiple places.
i will leave that to a later time .. but i have added the above link to make it easier for people to find out ..
Yea, I just think rel to describe "this div contains videos" seems wrong,
whereas using rel to describe "this elements title is a tooltip" seems more
ok? *shrug*

On Wed, Dec 19, 2012 at 5:25 PM, Eugene Fang <notifications@github.com>wrote:

> In static/javascript/tba.js:
>
> > @@ -103,6 +103,9 @@ $(function() {
> >  	
> >  	// Tooltips
> >  	$("[rel=tooltip]").tooltip();
> > +	
> > +	// Fitvids
> > +	$("[rel=fitvids]").fitVids();
>
> i guess class makes more sense. I just copied tooltips.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gregmarra/the-blue-alliance/pull/365/files#r2473051>.
>
>
Is there any reason you used + vs array_merge here?
Yep that's much nicer!
for(var i in x)
http://www.w3schools.com/js/js_loop_for_in.asp
As far as I can tell with 30 seconds of googling and test-compiling toy code, -fopenmp on an openmp-less OS X system does no harm (using the standard GCC compilers). No idea how it interacts with windows compilers of course. But I'm no openmp guru.
If possible, can we move this to CONTRIBUTORS.txt instead?  That way, we do not need to add an extra license file to the Debian packaging.
Good point.

Was being super cautious about coercing whatever the value is -- which could be anything that's valid in a Django ORM lookup! -- into a string.
In general practice, if you access an instance variable more than once, like you are doing here with `this._materialComponents`, you should assign it to a local variable and use that instead; this will increase performance (and in my opinion also makes the code more readable).  This entire constructor could probably benefit from extracting locals in this way.
Why not cache a local anonymous object and re-use it?  Wouldn't that improve performance?
From what we talked about, it looks like you want to do this in a separate 'if' block because you are relying on logic from the super class that deals with height/width.  If that is the case, can we move this whole block into the 'else' statement above to make this more clear.  

Also a comment on why you are doing this would be nice.
D'oh. This one slipped by the radar.
don't want to change the .project file
This sounds good.  Do we have a color that we tend to always use for
answers?  Is that making its way into the style guide?  Happy to change
this to pink.  Thanks Ben!


On Fri, Mar 2, 2012 at 9:36 PM, Ben Eater <
reply@reply.github.com
> wrote:

> > +     <div class="problems">
> > +
> > +             <div id="markup">
> > +                     <div class="vars">
> > +                             <var id="WHOLESALE">randRange(85,
> 160).toFixed(2)</var>
> > +                             <var
> id="MARKUP_RATE">randRange(1,11)*5+30</var>
> > +                             <var
> id="TOTAL_MARKUP">roundTo(2,(MARKUP_RATE/100)*WHOLESALE).toFixed(2)</var>
> > +                     </div>
> > +                     <div class="question spin">
> > +                             <p><var>person(1)</var>'s Furniture Store
> buys a <var>furniture(1)</var> at a wholesale price of
> $<var>WHOLESALE</var>.  If the markup rate at <var>person(1)</var>'s
> Furniture Store is <var>MARKUP_RATE</var>%, what is the total markup for
> the <var>furniture</var> in dollars?
> > +                     </div>
> > +                     <p class="solution"
> data-forms="dollar"><var>TOTAL_MARKUP</var></p>
> > +                     <div class="hints">
> > +                             <div>
> > +                                     <p>Remember that a markup rate is
> a percentage of the wholesale price that a store adds to get a selling or
> retail price. The amount of markup can be found with the following
> equation: </p>
> > +                                     <p><span class="hint_blue">markup
> rate</span> <code>\times</code> <span class="hint_green">wholesale
> price</span> <code>=</code> <span class="hint_orange">amount of
> markup</span></p>
>
> nit: here and throughout, we've gotten a fair number of reports that
> `hint_orange` is hard to read on some lower-quality screens since it's so
> light, so I've been using it less and less (except for some graphical
> elements). I'd suggest changing it to `hint_pink` or something throughout.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Khan/khan-exercises/pull/15264/files#r514560
>



-- 
Maureen Suhendra
Khan Academy
716.703.8383
Hm, it seems that type qualifiers and storage classes / function attributes are frequently mixed in dlang.org docs.
Am I understanding it right that in @shoo example const/shared are type qualifiers and should be stringified and nothrow is storage class? Using http://dlang.org/declaration.html as a reference currently.
I'd guess this entire sequence could be expressed as one `static assert`.
Yes. Pushed the wrong branch. Fixed.
mmm.. I normally don't have the sdk in my path, but I guess I'll. Should we add a check early on whether  'dart' is defined? Or will this script fail by default with a reasonable error?
mmh, yeah you are right, i've just added some code to set it to 1 or w/h depending on the target
the call to ```application().cgiAdaptorURL()``` is returning "http://**null**/cgi-bin/WebObjects" for me which eventually causes line 860 below to throw a ```java.net.UnknownHostException```.
Let's use the awesome Rails functions like `link_to` instead of dry `a` elements
It's much cleaner to use [TearDown] with JsConfig.Reset  instead of "finally".
Let's put CypherQuery in it's own file. No particular value having it here. Diffing looks horrible for one, shorter files are easier to work with in future
yep, dev box setup wiki is updated with how to set it up.
pear always generates them in `.tgz`
Line too long.

And we might consider having our readme and release notes files only 79chars wide?
Poor docs. Removed.
$order kann nur akzeptiert werden, wenn er aktuell offeriert ist.
This should be an APIProperty.
We could. Yet, I like the idea of providing convenience options. Users that look at the API docs will directly understand what ```observeElement ``` is and how to use it, no need to go the handler doc.
@croby Sounds good to me - could you open a jira for this?
I've set the state of the jira ticket to "Pending Merge" again since the functional review was good.
Все, теперь студией не соберется и будет требовать Qt 4.8, не раньше.
Правда, под вендой оно и так не работало, а насчет требования 4.8 — сам думай, надо оно тебе или нет.
Why do we need the `s3d-aural-text` AND a `title` here?
Aren't we normally supposed to be using the "W" versions of the Windows functions? From everything I hear, the "A" versions should be avoided like the plague. Or does it really not matter in this case?
Agreed. I'll rename that.
(been a long week)
/** 
	 * Constructs a DefaultLockRegistry with the default
	 * mask 0xFF with 256 locks.
	 */
Do we want to pull these empty sections out?  If someone clones this and adds these parts I think we want them to have blanks to fill in.  If we have a template for README.rdoc we should stick to it - even if empty.
Strange, since you wrote the first two lines in the handle method and also the third before I renamed it from metrics to nmetrics… :)


On 07. 09. 12, at 22:17, Mitar <notifications@github.com> wrote:

> In django_datastream/management/commands/dummydatastream.py:
> 
> >      )
> >      help = "Regularly inserts dummy datapoints into metrics."
> >  
> >      def handle(self, *args, **options):
> >          verbose = int(options.get('verbosity'))
> >          interval = options.get('interval')
> > +        nmetrics = options.get('nmetrics')
> > +        types = options.get('types')
> > +
> > +        if nmetrics is None and types is None:
> > +            nmetrics = 3
> > +
> > +        if types and check_types.match(types):
> > +            types = split_types.findall(types)
> > +            if nmetrics is not None and len(types) != nmetrics:
> > +                raise base.CommandError('Number of metric types does not mach number of metrics.')
> I use " for user displayed strings.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
forward to 404 if threre is no JenkinsGroupRun with the id
Since this variable is shared by many threads, do you know if the mapper is a thread safe class? If not can you double check?
move download button to the right of entity name display and reinstate entity icon (eventually to be a type icon)
This looks like something i wouldve done :)
@orrc can make the necessary change, wasn't aware you could autopopulate items.
yeah, that's a typo
Why do we need those general methods?
no, no es necesario.
se podría establecer pero no va a existir siempre, y no tengo ganas de hacerlo, y por las funcionalidades que le pusimos al sistema, no son necesarias.
it's "missing Synapse username OR password", if we want to be picky!
Are you sure? They aren't referenced in the code anywhere.
That's not equivalent.

    var foo = 'false';
    alert((!!foo).toString())

will alert 'true'.
why not say it's read-only with fixed 'auto' value ?
I have deleted it. Originally, I wanted to write something like "and this is  the source of evil", but I don’t know whether this is an idiom or not.

-----Original Message-----
From: nermin [mailto:reply@reply.github.com] 
Sent: Donnerstag, 28. Juni 2012 03:20
To: Gruntz Dominik
Subject: Re: [scalapuzzlers.github.com] Puzzler 20: Puzzler on currying and default arguments (#37)

> +<pre class""prettyprint lang-scala">
> +scala> def invert3 = invert(3) _
> +invert3: (Int, Int) => Unit
> +</pre>
> +This function object has an <tt>apply</tt> method (inherited from <tt>Function2[T1, T2, R]</tt>) with the following signature:
> +<pre class""prettyprint lang-scala">
> +  def apply(v1: T1, v2: T2): R
> +</pre>
> +In partucular, this method defines <em>no</em> default values for its arguments!
> +As a consequence, <tt>invert3(v1 = 2)</tt> leads to a compile time error (as there are not enough actual arguments for method <tt>apply</tt>).
> +</p>
> +<p>
> +The argument names <tt>v1</tt> and <tt>v2</tt> are the names as they are defined in the <tt>apply</tt>-method of <tt>Function2[T1, T2, R]</tt>.
> +The argument names of <tt>apply</tt>-method of <em>every</em> 
> +function with two arguments are named <tt>v1</tt> and <tt>v2</tt>, in 
> +particular these names are by no means related to the argument names of method <tt>invert3</tt>. Method <tt>invert3</tt> has by chance aruments with the same names, but unfortunately in a different order, and this is really painful.

Somehow I feel "and this is really painful" is not necessary here. This sentence would be IMHO just fine without it.

---
Reply to this email directly or view it on GitHub:
https://github.com/scalapuzzlers/scalapuzzlers.github.com/pull/37/files#r1065125
Should we move this class into the TCP/IP Module? Looks like it may be useful in a couple of places.
This should not be needed. The Servlet Protocol will add to the appalication.xml if it exist
BoA and Chase both scan checks. It is a good point though.