labofsahil/github-event-dataset-2012 huggingface dataset:
Searching numbers need to be compared to the string counterparts of integer values. Implement the JavaScript patch code from Full Sail Mobile for Android to allow using the barcode scanner from Comic Buddy Android for search and form input.
sdgfsdfgsfgh
Why's this file named `jquery2.js`? It doesn't really describe the file.
how about "conv.cid"
Yeah it can be handy for some things. I rarely use it though. I normally store the return variable from my function, that way if I use it multiple times in my template the I don't have to run the whole function again.

Example:

    public function example()
    {
        if ($this->_example)
            return $this->_example;

        // Do some heavy lifting here

        return $this->_example = $my_return_data;
    }
No other mods there. BLN is the same a no BLD, BLX, Touch_wake....
Would you mind looking at an example ncdf data file (perhaps using R ncdf library) to confirm why we transpose the matrix for >1 assay, but apparently not just for 1 assay (though I assume that matrix(bdc, nrow = length(designElements) achieves the same) ?
@endJunction @wenqing @TomFischer Isn't it useless to have a constructor in a interface class because we cannot force derived classes to have it? Originally this class has a pure virtual function create()  to provide interface to create a linear system assuming something like the following way of usage. 

```
enum LinearSystemType
{
   Lis,
   Pardiso
}

ISystemOfLinearEquations* createLinearSystem(LinearSystemType type)
{
     switch (type) {
      case Lis: return LisLinearSystem();
      ...
    }
}

void main()
{
    ISystemOfLinearEquations* sys = createLinearSystem(LinearSystemType::Lis);
    sys->create(100); // dim=100
}
```

Alternative way could be checking interface of constructor with template
```
template <T>
T* createLinearSystem(int dim, RowMajorSparsity* sp=nullptr)
{
    return new T(dim, sp);
}
void main()
{
    ISystemOfLinearEquations* sys = createLinearSystem<LisLinearSysten>(100);
}
```
How do you think?
If it these events can be triggered in a widget by user, then I think it's reasonable to add them that widget
These changes are not related to this commit's intention. Please do them in other commits.
Please revise this description
You should also copy over time_created, otherwise the comments will all look like they were posted very recently.
A recent update fixed this, F keys work regardless of IsActionBarOpen now.
Ah, yes - indeed!
We have to double-check that stats isn't use in a strict way then.
that was a new `"` syntax for me
Yep, that looks neater (though I made sure it can never be called). Done.
I have not tried scaladoccing this, but the failure for that one had a different cause (something with a builder)
isn't this breaking the scaladoc again? we have a script for doing this, or isn't that needed any more?
./scripts/fix-protobuf.sh
What part of it? I'm not sure it's worth reusing.
no, by not having two cases for different stateData but only one which has a match where the differences are
Will the scala compiler save us from the multiple getOrElse on the same variable? Probably not important but I think it looks kind of bad.
This has a tiny bit of smell to it
I don't know. We use Echo at a lot of places. I will remove display of it in this section of the docs. It doesn't add any value to show the actor impl here.
Not sure if we use this much now.  We could repurpose it for get_account, I think.  An internal Hash of User.id's to Card.ids and Card.trunk_ids of the Set::RIght::Account cards would go a long way and not need clearing.
This and jquery.jstree.js are part of a Json example I'm playing with.  These are third party resources that we would add in the appropriate way to get them loaded rather than jus dropping files here.  Don't merge these upstream.
"from" seems like new language for us.  not obvious whether it's finding or newing or...
Don't put a space between the text and ::
1 space + :: => no : displayed, and the next content is monospace
no space + :: => 1 : displayed, and the next content is monospace.
Personally, I'd have the following to start the method:

if (OperationMap.Count == 0)
 return;

That way you don't have to indent the complete logic in that method.
Is there a corresponding unittest to make sure the owner_type and owner_id are set correctly?
neither of the two above is used?
I believe this is fixed, comment again if you see something that looks wrong still.
Wouldn't normally mention this but to fall in line with the code above can you change this to:
```ruby
  args << "--style-measure #{options.fetch(:max_width)}" if options.has_key?(:max_width)
```
Can you explain more about why there are discrepancies? Because of different default shells on different machines?
it should not take into account only this should it ?
an artifact of a more barbaric age
Ya, I have a fix for that and a really corner-corner case it my tree. I can't push because it isn't fast-forward.. trying to figure it out.
-Ian
----- Original Message -----
From: "Sam Tobin-Hochstadt" <reply@reply.github.com>
To: "ianj" <ianj@ccs.neu.edu>
Sent: Monday, March 12, 2012 2:06:12 PM GMT -05:00 US/Canada Eastern
Subject: Re: [racket] Added the ability to disambiguate between citations using autobib. (#85)

> -                                        (if with-specific?
> -                                            (auto-bib-specific bib-entry)
> -                                            ""))
> -                                  `(autobib ,(auto-bib-key bib-entry))))))
> +       ;; (list which key) should be mapped to the bibliography element.
> +       (define s (resolve-get part ri `(,which ,key)))
> +       (cons (make-link-element #f
> +                                (list (or s "???")
> +                                      (if with-specific?
> +                                          (auto-bib-specific bib-entry)
> +                                          ""))
> +                                `(autobib ,(auto-bib-key bib-entry)))
> +             (cond [(and disambiguation
> +                         (or (pair? (cdr disambiguation))
> +                             (and (null? (cdr disambiguation))
> +                                  ))) ;; should be a list of bib-entries with same author/date

What are these `)))` doing on a new line?

--- 
Reply to this email directly or view it on GitHub:
https://github.com/plt/racket/pull/85/files#r547223
When we get MessageCanaryInit, before transitioning workers we drop the handle on the previous zygote. At that stage prev_zygote will be None so this should be safe.

This line is basically here when current_zygote is in canary and we still serve using prev_zygote. In all other cases we do not care about prev_zygote in here. I'll add a check on current_zygote.canary before checking for prev_zygote to make it explicit.
Changing this to commodity from p breaks the build. Specifically, it breaks the initialization of commodity_(p) in the line that follows . It's straightforward to fix, so I'm fixing it in my merge effort.
This is just to clarify my comments regarding transports I made on the other PR.

I think each and every RemoteTransport implementation should be completely standalone, with it's own configuration section etc, and then when you specify which transports to use you specify the FCQN of those transports.

This has the advantage of keeping code clean and it's easy to add and remove things as fit. (Right now removing the Udp transport puts the Tcp transport at risk as it is in the same bucket). Also, users could decide to have their own tcp-based transports, there might be a netty-based one and an Akka IO based one so I do not think that "transports.tcp" is an appropriate config section name.

Does that make sense?

Cheers!
√
It would be great to move stylistic things like renaming variables into their own PRs, to keep things more atomic and testable.
This entire method is in SPACES
Sorry, bad habits..
you would prefer something like this ?

$flag =  parse_ini_file(jApp::configPath('mainconfig.ini.php');
 if ( $flag === false) ) {
        $config = parse_ini_file(jApp::configPath('defaultconfig.ini.php'));
        trigger_error("the config file var/config/defaultconfig.ini.php is deprecated and will be removed in the next major release", E_USER_DEPRECATED);
 }
The usual C convention; anything that's nonzero means true.
This line is a bit long -- keep them limited to 100 characters
'Those' or 'the',  instead of 'these'.
By this, I mean that avatar_url would need to be modified to handle all cases automatically.
Very nice ! :)  :heart:
No need to `|| nil`.
Yes. No "stack level too deep", but it's not getting called at all. Just add some raise in method definition and you will see.
Ah, ok. I didn't see that this output is from parser.
next time you're in the 'hood, please rechristen these vals
it's like calling your kids junior 1, 2 and 3 -- who does that anymore these days
Shouldn't this be in scala.annotation?
I already did: http://code.google.com/p/sympy/issues/detail?id=3459
Yes...if it's cheap to compute you might as well not store it and just write:

```

Th = [g for g in t if sdm_monomial_divides(sdm_LM(g), sdm_LM(h))]
if not Th:
    break
g = min(Th, key=lambda g: sdm_ecart(g))
if sdm_ecart(g) > etc...
```
yes, I missed that too.
The tree is scanned only once, so no. And it would be wrong anyway, since "atoms" can be contained in other atoms, cf. `cos(cos(x)).atoms(cos)`.
the autoexpansion of the 2-arg mul on the right  is the source of the failure;

```
>>> factor(6*x - 10).args
(2, 3*x - 5)
```
so perhaps that last assertion could be `assert expr.args[1] == 3*x - 5`
On Mon, Apr 30, 2012 at 8:57 PM, Tom Bachmann
<reply@reply.github.com>
wrote:
>> @@ -320,6 +353,10 @@ def fdiff(self, argindex=1):
>>
>>      @classmethod
>>      def eval(cls, arg):
>> +        if hasattr(arg, '_eval_Abs'):
>> +            obj = arg._eval_Abs()

my first impression is that it seems ok...rather than adding an
_eval_Abs to Expr, it was only added to conjugate and sign. Should it
be in Expr? (My head's not into this enough to have the big picture to
answer that question at the moment.)
This is the first time that 'block' appears. I think a module docstring introducing terminology would be appropriate. It took me a minute to figure this out. Also, 'n-character string' is a little misleading since the elements of it are integers. How about:


```
The restricted growth string (or restricted growth function) is a list of pointers, [p_1, p_2, ..., p_i, ...] that give the index of the block to which element i belongs.
```
Why isn't it `rm_id(lambda x: x==1 or isinstance(x, MatExpr) and x.is_Identity)` or something like that? Or something based on `typed`.
On Thu, Mar 22, 2012 at 2:02 PM, Alexey U. Gudchenko <
reply@reply.github.com
> wrote:

> > @@ -824,7 +837,6 @@ def primitive(self):
> >              c = terms.pop(0)
> >          else:
> >              c = None
> > -        terms.sort(key=hash)
>
>
> Tests reports are [there](https://github.com/goodok/sympy/pull/2/),
> after second comment.
>
> In particular:
> http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY-vMQDA
>
> Failures classified as:
>
> in tests:
> 1. my new tests which tests the order presereved.
>
> 2. Hided (I think) bug in the Order class, with logarithms.
>
> 3. obviously, tests which are based with testings the `.args` order at
> the result expression.
>
> 4. written in the form with order dependency. E.g. Mathematically
> `solve` function must return the sets, not ordered list.
>
> Note also, I replaced output to sets in some cases previously, for tests
> related with `solve`-like functions,
>
> Also: "sift" and "as_coeff_add" but may be they are belong to 3.
>

Order (other than that the first arg should be the coeff) doesn't matter
for sift and as_coeff_add. BUT, a set cannot be used for these unless terms
are unique.


> 5. Unknown:
>
> split_surds -  I don't know about it.
> cse - may be related with 4. that is lists in output incorrect, must be
> set.
>
>
It's a case of 4; it doesn't matter what the order is; `to_eliminate`
should be sorted before beginning the dummy assignment at

```
    for i, subtree in enumerate(to_eliminate):
```
I'm guilty of this alot. I think that it makes sense to have one extra space if it aligns very similar code. It highlights the structural relationship between neighboring lines. I think the major gripe that I have with PEP8 is that it's complete context insensitive. Others might disagree but I'm for the previous spacing.
Looks like this diff has been whitespace-damaged while it looked ok in my editor... Thanks for pointing this out.
`if ($this->_currentIndex>=$pagination->getPageSize()) {` no need to call the getter.
buf->data?
No, I mean the default Hibernate 2nd-Level cache for entities.
Just need to clarify the behavior from a client's perspective:

If a client trips `escalations:*` but doesn't trip `escalations:foo`, will the `foo` escalation get triggered? Or does it depend on the value of  `escalations:foo` when `escalations:*` is tripped?
actually, I think they can, it just gets truncated.
https://github.com/mongodb/docs/blob/master/meta.style-guide.rst#punctuation
Yeah, you're right.  Would you suggest a "wiki.getFileContent(file)" type of method?  I see we use a "wiki.pageExists" function -- where is that defined?

I'm aware that this bug requires file content loading:
https://bugzilla.mozilla.org/show_bug.cgi?id=770727

That was my initial thought in adding it...oh, and Sheppy too.
Taking a quick peek at this... should this be `request.POST.get('title')` without the subscript? Seems odd that this would be a list/array
Literally right before you came onto IRC:
```
[16:28:35] <ikd|away> MichaelC: is cache not purged following extension enabling?
[16:28:47] <ikd|away> or is it an issue with the container not being purged with the cache
[16:28:53] <-> You are now known as imkingdavid
[16:29:34] <imkingdavid> because if I enable an extension and it defines services, its services aren't available until I remove the cached version of the container
[16:30:00] <-- Dhruv1 (~Dhruv@182.68.167.145) has quit (Quit: Leaving.)
[16:31:10] <imkingdavid> hmm well, extension_manager::enable_step() does appear to destroy the extensions cache but not the rest
[16:31:28] <imkingdavid> would it be bad to purge cache entirely every time an extension is installed?
[16:31:52] <TheMarc> it's not like you'd do that every 5 minutes
[16:32:41] <imkingdavid> true
[16:32:42] <bantu> imkingdavid: no
[16:33:06] <imkingdavid> okay i'll change the manager methods to run purge() instead of just destroy()
[16:35:27] <imkingdavid> good, that works :)
[16:35:28] --> nx- (~pie@pool-72-76-239-18.nwrknj.fios.verizon.net) has joined #phpBB-dev
```
No need to capitalize Login Sessions.
If the server was already running, is return value false?
This comment does not match the language string used below.
This should probably write to the property instead of a local variable.
Isn't query for user_posts in users table enough? It seems to be less expensive than querying posts table in this way.
File was deleted. Bad checkin.
This means we write two log lines for success. Is that necessary?
Should we have the logger by the checkType?
this proliferation of bindings worries me :/
This perf test is not properly designed and implemented. You shouldn't use `cvGetTickCount` at all, you should use constructs like `TEST_CYCLE()`, and you *must* use `PERF_TEST_P` instead of `INSTANTIATE_TEST_CASE_P`. The reason is that your test can't be analyzed with OpenCV scripts.

To find more about all of this, you should read http://opencv.willowgarage.com/wiki/ValueParameterizedPerfTests (this page describes how you should design your perf test) and http://opencv.willowgarage.com/wiki/AnalyzePerfTestsLogs (this page describes how you should analyze performance).

For examples you can study these files:
- http://code.opencv.org/projects/opencv/repository/revisions/2.4/entry/modules/imgproc/perf/perf_houghLines.cpp
- http://code.opencv.org/projects/opencv/repository/revisions/master/entry/modules/gpu/perf/perf_imgproc.cpp
@madanpiyush Only the > 60.00 part has been removed, because a persons BMI can be greater than 60.

But on second thought, validation is important, and it is unlikely to have such high BMI's, so to get the best of both, we could raise the limit to something like 100 maybe?
Fixed - moved to the classes themselves.


On Wed, Dec 5, 2012 at 4:34 PM, John Hugg <notifications@github.com> wrote:

> In examples/json/src/json/JSONClient.java:
>
> > +
> > +        /**
> > +         * Generates a random login
> > +         * @return Login containing login credentials
> > +         */
> > +        public LoginRecord createLoginRecord()
> > +        {
> > +            // Generate a "random" set of data for this login.  The assumption is
> > +            // that each site that logs in with this user name will want to store different data
> > +            // associated with that login.  We don't know the schema of this data ahead of time so we'll
> > +            // store it in a json field.
> > +            Gson gson = new Gson();
> > +            SiteBase site = null;
> > +
> > +            switch (random.nextInt(2)) {
> > +            case 0:  AmazonSite asite = new AmazonSite();
>
> This random data generator loop is pretty onerous. Perhaps the classes
> themselves could generate random data, like AmazonSite would have a method
> to generate a random JSON doc for itself. That would allow this to get more
> complex without making this nested switch stuff explode.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/VoltDB/voltdb/pull/269/files#r2327490>.
>
>



-- 
*John Piekos*
*Volt**DB**, Inc.  *
Vice President, Engineering
email:  jpiekos@voltdb.com
office: +1.978.528.0576
mobile: +1.508.517.3218
web:    www.voltdb.com
Not part of the zip, that's the `stop` function. The events `close` and `end` trigger it.
Using a single backslash that isn't followed up by a special character is an anti-pattern. ``r'\_'`` or ``'\\_'`` please.
Можно обойтись без копипаста, если унести `createNodePrefix ()` как статический метод класса `LevelNode` и использовать `this.__base()` в `createId()`
I won't say this doc comment block is useless - but it is quite ambiguous and rather confusing (to me) - not very helpful.
Contributor names in the AUTHORS file need to be sorted by last name.
Make this `'production'`.
All variables should be declared together. But in this case, I don't think we need the variable at all.
I'm pretty sure these do the same thing
Iterating using a simple for-loop is much fast..
`(rtrim, "$1")` ==> `( rtrim, "$1" )`
Hmm, that is an oversight indeed. Can a PL/pgSQL function find out its own schema name? In PL/Python we do that.
It would need to go back.
It would only be required on platforms that don't have a background context
such as Android, and and TextureCollection wouldn't need to be thread safe
as the GL calls are all done on the main thread in that case.
Indent this please. And what exactly does this accomplish? looks like a weird way to make the brain never start a power?
Instead of this, why not name the groups "password-cleartext" and "password-encrypted"?
A head-only formula should use

```
head 'https://github.com/JuliaLang/julia.git'
```

and not define a version.

However, we aren't really accepting new head-only formula at this time. Is there a stable release we can point to in addition to the git head?
This is **not** printed for CLT people in any case, since they always have `/usr/bin/cc` and `/usr/bin/make` unless their system is completely broken.

@mistydemeo I have pushed an improved version wich tires harder to find Xcode and then prints a warning in case neither CLT nor Xcode is found. I have tested that in both situation and with different settings of `xcode-selelct`.
Indeed. We need this info in order to commit the change.
Actually, it does not work for you because you are using a cutting edge scikit-learn (the commit 40328ed685be70d0ebdabecd65c6d85c5b55e85c fixes a bug in scikit-learn pipeline). I will fix this.
It was mostly the enquire_link stuff that was duplicated, moved that out into its own functions.
extra space before closing paren
please document the properties of the environment object
Hier hast du meinen Hinweis wahrscheinlich falsch verstanden:
In der lang Datei sollten die keys schon den Addon-Präfix (also hier "debug_") haben, z. B. debug_name.
Wenn du die Übersetzung dann jedoch über das Addon-Objekt abfragst, kannst du "debug_" weglassen, es wird automatisch hinzugefügt, also zum Beispiel `$this->i18n('name')`. Letztlich ergibt das dann `rex_i18n::msg('debug_name')`.
Auch in der package.yml kann man den Präfix weglassen.
Gotcha. Perhaps it'd be cleaner to just fix existing subreddits?
Yeah I agree, that's a much better idea. I just couldn't think of a better way to do it at the time.
It's in the ``default-directory`` variable.
Yeah, I think you're right. This approach is simpler. Simpler wins!
Let's re-write this.  "JUnit is a unit testing framework for Java, created by Erich Gamma and Kent Beck."
Can i add a link to a chapter to JSR 133 specification?
This would help understanding the point.
Occasionally, package-scoped classes become public in later releases. I personally feel that the `@since` tag should specify when the class was available publicly. Of course, @dsaff should make the final call.

Note that I don't see any JavaDoc generated for non-public classes, so adding `@since` tags to non-public classes only affects people who browse the source.
"Use of undefined value in string or concatenation" warnings as a feature request? I can imagine implementing a few as bugs but I can hardly imagine any use for them in production code.
Well hello indeed.
If `newItems` is false, this check will fail anyway.
General comment: do you think "popup" or "popUp" is more common usage?  I know Flex used the latter but it feels like web people might fall more toward the former...
* lineAfter is unused
* lineBefore is assigned but never read, so I think it can be removed also
I see. No need for a new bug. I'll fix it.
Oops, this actually crashes now -- it looks like someone made _extractAllSelectors() private.  I'm fine with changing it to public again though.
There's no need to get treeAPI or to create a Deferred object until after you have verified that the file is within the project.
We need to figure out the best way to do this. Ideally it would be updated by commit hook whenever a change to master is pushed. I still have an open task to figure this out.
Quick note: I think this might need the same logic as in SidebarView._updateProjectTitle() to deal with the root-folder case where projecName == "".
That wasn't supposed to be committed. Removed.
Can remove this `return`
The chi2 gets ridiculous (even when all parameters are fixed).

But I have an idea that maybe pruning is guilty.
The right procedure is the following:

a) Load Cinv and CinvD  data vector.
b) Invert Cinv to get C.
c) Multiply C with Cinv D to get D.
d) Modify C
e) Prune C, D
f) Invert Pruned C to get Pruned Cinv.

Basically, after I modify C, Cinv D should not be used any more. Is this 
the case?

anže



On Fri, 31 Aug 2012, dkirkby wrote:

>> +	  //std::cout << i1 <<" " <<i2 << " " <<ll1 <<" " <<ll2 <<" " <<sep1 <<" " <<sep2 <<" " <<z1 <<" " <<z2 <<std::endl;
>> +	  double C(getCovariance(i1,i2));
>> +	  //std::cout << C <<" -> ";
>> +	  // this recipe is from chi2.
>> +	  // magic constants are set by the requirement that for
>> +	  // a certain cov, you should add something that is "large"
>> +	  // but at the same time does not make numerical errors unbearable
>> +	  //C += double(0.0001);
>> +	  //C += (ll1-0.02)*(ll2-0.02)*0.01;
>> +	  //C += pow((ll1-0.02)*(ll2-0.02),2.0) *10.0;
>> +	  //std::cout << C << std::endl;
>> +
>> +
>> +	  ///debugging
>> +	  assert(i1==i2); // this assert passes.
>> +	  C+=0.0001;
>
> Ok, I missed that. So how does it fail?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/deepzot/baofit/pull/1/files#r1509979
reason you're using `[]`-notation instead of `.`-notation?
not sure. it's been removed.
invalid JSON - trailing comma -- please use jsonlint.com to verify file before submitting
Changed fb['id'] to fb.get('id'). Also applied this style to all other fb variables.
can i do it with custom save fucntion? Otherwise I currently have no idea, how to implement this...
Does listening for the `close` event not work? I'd rather ensure a decoupled strategy.
store reference to dialogs.length
This is a bit confusing. It looks like only audio and video elements are the things that won't be strings here. I don't think that's right.

/me checks

Yeah, just a little bit above, there's an if block that makes sure target is a string. So, you probably want to grab the element to do that node check here.
Instead of another `if` statement, why not just put this on like 382, after  a `media` object _certainly_ exists?
store reference to rootElement please
Right, just saw this logic somewhere else and thought it was the way to go. will do
This is really odd because the cucumber test is passing on my local repo. Not sure what is happening.
I've added a getter:
```attr_accessor :pending_modified_values```
It wasn't clear for me the difference btw `attr_accesor` and `attr_accessible`

Someone has the same doubt:

http://stackoverflow.com/questions/3136420/difference-between-attr-accessor-and-attr-accessible
Using standard static factory for loggers here can simplify this code and its usage.

    protected final Logger logger = LoggerFactory.getLogger(getClass());

IMO there is only a very limited scope when its sane to passing in a Logger object to another object to use.
Is this valid for non-air projects?
Please fix the indentation here to have to spaces
Not a good comment
Prevailing style is to add the slash at the point of reference (see uses of `$(USR)` elsewhere in this file.)
what you should set is ``_route_params``
Normally events don't begin with the 'Event' prefix.
On 12/04/2012 02:32, Timothy Guan-tin Chien wrote:
>> +
>> +  navigator.mozApps.mgmt.addEventListener('install', function (ev) {
>> +    var newapp = event.application;
>> +    installedApps[newapp.origin] = newapp;
>> +
>> +    open(newapp.origin);
>> +  });
>> +
>> +  navigator.mozApps.mgmt.addEventListener('uninstall', function (ev) {
>> +    var newapp = event.application;
>> +    delete installedApps[newapp.origin];
>> +
>> +    close(newapp.origin);
>> +  });
>> +
>> +  */
> I prefer leave it so we don't have to write it when addEventListener is fixed.

Dead code is evil. You can open an issue with this code in it if you 
afraid of loosing it but this code is normally exactly the same as the 
one from your workaround without the onInstall/onuninstall saved 
callbacks hack. And If someone add something to your workaround I doubt 
it will add it to the dead code too.
You should run the ``composer validate`` command. This is invalid. It should be ``require``, not ``required``
Don't change migrations that are already in master, that will just make things messy for everyone. Create a new migration that makes the changes you want. So like:

```ruby
drop_table :lists_videos
create_table :listings do |t|
  ...
end
```
The RPC port has nothing to do with the p2p protocol, so this doesn't belong in protocol.h.

Should go at the top of bitcoinrpc.cpp, in my humble opinion.
"== condition" will also work as we're expecting integer here. We could even do ($namespaceVersion < 1) condition. But as doFetch($id) is supposed to return false, it should be ok as well. And if it's not case for some cache driver, then it should be fixed there.
Kan je dit niet in de constructor van KernelLoader doen? Dan moet je dit niet meer doen in de verschillende classes.
Наоборот. Были табы
Yes, I also one can want to show the value of a dict, or a list, or an object property....
`.toJSON().input` == `.get_text()`in this case, and it won't work if cell has only `\n`and ` ` inside (and obviously it is considered empty).
Let's make this test do something to demonstrate that it's running in the virtualenv - like printing `sys.path`. Then we can get rid of the redundant `test_virtualenv_pypy` and `test_virtualenv_python3`.
No, not quite. I'm suggesting that this should be:

```
return format(self(), format_spec)
```

e.g. if the function returns a float, you should be able to use format strings for a float - this will prevent that. Perhaps an example will help:

```
In [2]: def f():
   ...:     return 0.25
   ...: 

In [3]: format(f(), '.1%')
Out[3]: '25.0%'

In [4]: format(LazyEvaluate(f), '.1%')    # Should be exactly the same as above.
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-4-ddef084b2a15> in <module>()
----> 1 format(LazyEvaluate(f), '.1%')

/home/thomas/Code/virtualenvs/ipy-trunk/local/lib/python2.7/site-packages/IPython/core/prompts.pyc in __format__(self, format_spec)
    105 
    106     def __format__(self, format_spec):
--> 107         return format(unicode(self()), format_spec)
    108 
    109 def multiple_replace(dict, text):

ValueError: Unknown format code '%' for object of type 'unicode'
```
@jverkoey pull-request updated
Fair enough, but if GIT_OLD_ERRORS is defined there are conflicting constants, eg:
	GIT_EEXISTS = -23,
	GIT_EEXISTS = -4,
	GIT_ENOMEM = -4,
`git_transport` is an internal structure that the user has no concern with. Something like "existing connections won't the updated".
It will work for highest numbers thanks for (ls -v) option - I've checked that
Ok, so this guy is starting to bother me since it isn't a class. And I'm seeing the impacts of that throughout the app. If we make an `Anita::Activity` class, then we can do a little copying from `ActiveRecord` which will clean things up nicely. For example, I would be nice to have an `Activity` object track it errors and do any data normalization so we don't have to worry about that any where else.

If we go that route, then in `Anita::Web` we can do this:

```ruby

get "/activities/new" do
  @activity = Anita::Activity.new # An empty activity object which we can now access in the view
  haml(:new_activity)
end

post "/activities/new" do
  @activity = Anita::Activity.new(params)
  if @activity.save
    redirect("/activities/#{description}")
  else	
    haml(:new_activity) # And now you can access @activity.errors and @activity.{<Attribute Name>} which is NICE!!!
end
```
This seems like it's repeated a LOT. Is there any way we can rework the button templates to reuse more code from the base version?
Condition is unnecessary, as you already confirmed this is true when the first condition failed.
Honestly I am confused by this too o_O
What's this line for? I don't see deepcopy being used in the changes.
317 - 326 are tab prefixed with tabs interspersed in the params
Is this shortcut really necessary? 
I don't mind typing `self.config.logger.debug(....)` every time.
!_.some(_.pluck(json.validation.messages, 'fatal'))
I'd rather the value being "put" be provided in the payload of the PUT request than in the URI. Eg. the request should be something like:

PUT /db/data/autoindex/node/enabled
true
you have there more times header of table, is it intention?
:) Looks like this needs some attention.
The rects are valid already. In any case, the limit rect gets overridden by the only code that calls the dragging code.
I would say :

Alternatively, $labelPath can be a PHP callable
taking an element from the ObjectChoiceList as 
parameter and returning a string.

But then $labelPath should be documented as a mixed parameter ?
I did see it later, it seems GH requires page refreshes in order to see added comments. The minimum Twig version for Symfony is 1.8 anyway, so I used `iterable` now.
Good idea. I'll wrap things up on something and I'll revert + add the mentioned comment.
I didn't want to add dependencies, but if it's optional it could be ok.
Thanks for pointing it out, I haven't paid attention.
log here http://demo.talkpress.de/trunk/wp-admin/ with demo/demo check how it is done : 
- if the screen is < 900px it collapse auto (like we do for the responsive part expect it's done with js)
- if you click on collapse it saves the preference

check `$('#collapse-menu').on('click.collapse-menu' ` in file http://demo.talkpress.de/trunk/wp-admin/js/common.js
I see: "BottomUp"
public methods should be defined before private ones
Just revert this change.
Good point. :) -- Fixing...
And finally, why don't you use `[NSRegularExpression  stringByReplacingMatchesInString:options:range:withTemplate:]`? Whole string replacement would be just one method call.
Indentation off here. I would format as in 121..125.
I'm always uneasy with using only a `count` assertion. I'd like to add something more specific like

    invitation_names = Invitation.all.map(&:name)
    invitation_names.should include(event_creator.name)
    ...
这一段之前已经讨论过了，不应该存在，包括那张示例图片
Archive action doesn't run if its ttl is greater than Delete one.
Hmm, I numbered the cases as 1,2,3 and 4 and for some reason it shows up as 1,1,1 and 2.

Chris top down as you go, the cases are numbered 1,2,3,4. Don't be confused by the numbering, for some reason github overrides my numbering.
OTB add the brackets
Ah désolé j'avais dumper la base de prod en local.
Ca devrait être une conf locale, enfin que l'on puisse surchargé localement, ce serait pratique
Remove it :trollface: and so line 125. Great work, thanks for this PR :)
I wonder if the type conversion functions should be a utility bundled with `inferify`, so it will be possible to use it out of the box for scenarios where you want to infer the type and convert.
I renamed this because it is not osgi only any more. I added ee, naming, jmx, web to this configuration.
How about restoring subsystems-osgi-only and adding subsystems-osgi, which also contains the subsystems osgi can integrate with?
This functionality is inherently questionable it should not leak into server generally. It would be ok to make this private to EmbeddedStandAloneServerFactory where it is used
looks to me that the indentation is a bit broken,

can you use the strict mode and lint again? @kaze commented you need to define it for the linter to detect this problems.

Thanks!
Can you change this parameter to something |resizeActivityFrame|. This will make it easier to read, especially when you use the negation form (!) for testing it.
`currentEvents: {}`?
Do we really need to repeat the sender in the notification body now that we know how to get back title & body in the system message handler?
The fix has not landed yet. I'm fighting a test failure on android.
Already saw the comment above about doing a final implementation, here we are just missing the l10n for 'Unknown carrier'
Nice, this is all a good test!  Another thing I would add would be that they can't click the link again after it has been used once, but once you add that (and logout abvoe) then this is good togo!
Back to older version? Is that deliberate?
And change this to .Count after making the other change below.
This doesn't seem to be set by default, so when I tried running Kudu.Web clean, it blew up with a null ref. We should make sure that it runs as is with no modifications.
Scripts should be moved into index.jade, not layout.jade
Currently, if someone tries to use a color symbol that's not in the `VT100_COLORS` hash (or if they fat finger it) this'll happily insert the symbol as a color code directly in the string...which is going to make for some wonky output.

I don't think it should raise an error here in that case (raising an error in a formatter could potentially halt the spec run), but maybe it can:

* Print a warning
* Use white instead
I'll have to clear that all up later.  Thanks for the clarifications.

Sent from my iPhone

On Jul 18, 2012, at 5:44 AM, TomyLobo<reply@reply.github.com> wrote:

>> @@ -175,10 +184,20 @@ private void loadFlags(ProtectedRegion region) {
>>                 }
>>             }
>>         } catch (SQLException ex) {
>> -            logger.warning(
>> -                    "Unable to load flags for region "
>> -                    + region.getId().toLowerCase() + ": " + ex.getMessage()
>> -            );
>> +            logger.warning(
>> +                    "SQL Error: Unable to load flags for region "
>> +                            + region.getId().toLowerCase() + ": " + ex.getMessage()
>> +                    );
> 
> looks like you messed up the indentation up there
> we use 4 spaces per indentation
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sk89q/worldguard/pull/214/files#r1186343
This is an *extremely* tiny point, but this creates an `Array` unnecessarily. You can probably get the same result by doing `Set.new << @left << @right`.

If you do decide you don't care about the unnecessary object creation, a slightly more idiomatic way to write what you've done here is: `Set[ @left, @right ]`. It still creates an `Array` object (because it splats the arguments when passed in), but it basically passes that to `Set.new` the same as your code.
mmm ... if you return a `ErrTicketClaimed` error I think testing on `TicketStatusClaimed` makes more sense
MyPVR, PVR or TV can be used... same result and same window.
I will use only PVR. (more readable than only TV)
Instead of copying the code we should really refactor it. Maybe create a BaseClient that contains all that code except the Solr or ElasticSearch specific methods!
One approach we could use is to take the prefix which is the size of the shorter list, and do plus on that, and then take the suffix which is the part in the longer one that has no corresponding part on the other side, and append that to the end of the result of adding the prefix.

This has the property that it doesn't require a zero on T, but logically works exactly like the plus in Monoid[IndexedSeq[T]].

I think slice is the method you want.  Something like:
```scala
  val prefix = math.min(left.size, right.size)
  val leftp = left.slice(0, prefix)
  val rightp = right.slice(0, prefix)
  val prefix = leftp.view.zip(rightp).map { tup => semi.plus(tup._1, tup._2) }.toIndexedSeq
  val suffix = if(left.size != prefix) { left.slice(prefix, left.size) } else right.slice(prefix, right.size)
  prefix ++ suffix
```
Something like that behaves like the IndexedSeq Monoid but without the zero, right?
Again provide a concrete example of what can go wrong.
The idea here was to try to utf8_decode $pod. Your patch will just assume no encoding if =encoding is missing?
If we add new rules like this, they need to be put into our extra 2.0 CSS file -- otherwise none of the legacy templates will work.
For creating threads? It always gave me mysql errors before.
doesn't compile otherwise
what is a broken enh? probably needs a better name.
обсудили :) @event - не нужно
I think here `self.emulate_size[-1]` can assign to a new variant, eg, unit.
Will use BooleanParam
Should be `} else (...) {`
why don't use it and factorize dump method  (removing duplicate code) between both dumper classes ?
You are right, it does not. I guess I got confused because sqlite reuses pks so you can't really test if an object exists. I'll fix it
Use `expect` instead of `lambda`. Move expectations out of block.
This shouldn't be an instance variable (call it 'tmphash' not '@tmphash')

Also, you might want to consider adding comments here to describe why you are setting "@timestamp" to something else.

Finally, event.to_hash returns literally the event hash used internal to the event, so changing it will change the event itself; probably something we don't want..

It might be better to say:

tmphash = event.to_hash.merge({ "@timestamp" => .event.ruby_timestamp })

This results in a copy of the event hash with @timestamp changed and doesn't modify the event itself. Also it's only one line (not that I"m counting)
It's little confusing to call function `setPBMode` in definition but export it as `setMode`, makes it little harder to follow the code when reading it. Could you please stick to either name unless there is good reason. If there is such reason please comment just before function definition so that reader is aware.
"the property from the second argument overrides that from the first"
Also if you're ok with previous suggestion I would rather move try / catch  into main itself so it will end up like:

```js
function main() {
  try {
    let { command, options } = getOptions();
    commands[command] || commands.help(options)
  } catch (error) {
    if (error instanceof CfxError) {
      // Stacktrace isn't usefull in case of custom cfx exceptions,
      // prints custom message instead
      console.log(e);
    }
    else {
      console.error("Unknown internal error in cfx.js:");
      console.exception(e);
    }
    system.exit(system.E_FORCE);
  }
}
```
This has the same outcome as the first branch in the if-else statement, it would make the entire flow clearer. Secondly, can we get some {}s? I suggest:

```
         if (record.cert || "secondary" === info.type) {
           self.close("email_chosen", info);
         }
         else if ("transition_no_password" === info.state) {
           self.close("transition_no_password", info);
         } 
         else {
           self.close("primary_user", info);       
         }

```
Wow, neat.
It's good that this is consistent with how the existing code is written, but it's a DRY violation to have these constants in two files.

Consider exporting these constants off of `BrowserID.Modules.Authenticate`.
Better to use `assert False, "Should have gotten a SystemExit"`, so a test failure shows up as a failure, not an error (test runners distinguish those two things).

Better to still to use the `pytest.raises` context manager instead of try/except for this:

```
with pytest.raises(SystemExit) as excinfo:
    call_create_perftest_project()
```

and then you can also make the output assertion.
'setup' please
That's still not valid according to the spec: http://www.w3.org/TR/html-markup/syntax.html#syntax-elements since span is a non-void element.
+1 @ednapiranha, camelCase for localVars. Underscores are generally used ONLY_IN_CONSTANTS and for _privateThings.
some browsers don't like < -9999px.
blank line needed before the license header.
same here and for the whole method
please double-check this logic. better docs will help
prefer "-part-" (k.e., extra '-' after "part")
Additionally, to my comment below. These two lines should be either removed or also rewritten - depends whether we actually need to run these tasks at all.
I think the opening bracket should be on the same line according to standards :

if (!isset($this->attributes['step'])
              || 'any' !== $this->attributes['step']) {
Senza `MVC` (credo)
AutoCatalogAssignment.first
Does this not re-use the existing `AxisAlignedBB`s in `h`? `h` is set to 0 in `a()`, and then when a new bounding box is added it either adds it if all of the bounding boxes are in-use, or re-uses one if not.
return something like false? rather than not returning anything? just saying
Fail 1: I use :concurrently_index instead of :concurrent_index
1. '<?php' has a space after it, '?>' before
2. What about symmetry, like mentioned in the code standards?

Am I missing something?
W1ndwaker, that's not an ENUM value. Dredhorse: Formcause
Ideally I'd like one source file that can be used for both methods. I'd be OK if that were a compile time switch.

In the long (medium) term I'd like to ask LevelDB to include the WiredTiger benchmark implementation in their package. That is why I'm pushing back a bit on having these Symas specific changes enabled default.
Pick one: unicorn or thin
I don't think so, I don't see a good reason to support both and, as you said: `too many options for no *real good reason* is never good`
Move this to module level so that you don't recompile each time the validator is called -- that's no different from using a raw regex string. We should also establish a convention for naming regex strings. I've been using the `_re` suffix in other places.
protected methods should be defined after public ones according to the Symfony2 CS
`if current_user` feels like it should read `if logged_in`. Check if clearance gives you a helper for this.
sounds good ill try and pull this down and have a look soonish as well
Epic-good find. That's a lot of duplicate code!
This line terrifies me (because I did not know `top` and `self` were valid globals).
Also consider using -1 here too.
trailing of whitespaces.
line 52 should come here (avoiding the previous loop)
Yep - Swarbhanu.


On 8/3/12 2:58 PM, "Dave Foster"
<reply+p-1304542-ae27b9a29bc45e63337cada15b5f3d72ceb12b92-1181645@reply.git
hub.com> wrote:

>>  
>>  
>>          log.debug('Creating new CDM data product with a stream
>>definition')
>> -        dp_obj =
>>IonObject(RT.DataProduct,name=data_product_name,description='ctd stream
>>test')
>> -        try:
>> -            ctd_parsed_data_product_id =
>>self.dataproductclient.create_data_product(dp_obj, ctd_stream_def_id)
>> -        except Exception as ex:
>> -            self.fail("failed to create new data product: %s" %ex)
>> +
>> +        craft = CoverageCraft
>
>Ah I see, class methods.  Still looks a bit funny, but I guess it's fine.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/ooici/coi-services/pull/221/files#r1304542
Agreed, I'll add those in after this is merged.
GStreamer is completely asynchronous: feeding is non-blocking.
Ha crap my bad.
maybe consider adding a index on host_id ?
is this a left over?
I think if you pass data=True to _query above you can remove this line.
There's more to be done here validation wise. The big thing I'd want to test here is not the count, but that the "right" app was installed. We've had bugs in the past where the name got mangled characters on return with UTF-8 characters.

I'd consider at least checking here that the name of the app is correct off of a reliable source we have control over (the one on mozqa.com for example).
It's part of how json_spec works. I'll add a comment.
Semi-colons in this code block
Please match the style of the other `td` elements. No need for the classes.
You are absolutely right. What do you suggest?
hi folks, 
+1 as well
I thought git was a place to comment code and not feature and this is a very good one.
I had only be able to test this week and so far my test where good but I totally missed that in the mockup I saw:
treemenu should not be removed and it was clearly not in the requirements, I strongly hope Anton or Juri you didn't remove other parts of the UI!
если не меняешь, то константная ссылка
I think it is ok to have an empty text field, but should not pass validation if it's missing one.
Steve i s right: msOra*b*leSpatialGetPaging should be: msOra*c*leSpatialGetPaging
This method isn't clicking anything.
I think it paid off in Harmattan, especially in cases where the classes are potentially used by third parties and/or end up in the documentation. It's more consistent when all classes are documented the same way and even though it's "obvious", it never hurts to have a written description of a class, especially since this is the home screen base project which will be used from UX implementations.
a note for diff
Haha, ok. done.
I think the only meaningful abstraction here would be to swallow the exception after logging it. Anything beyond that is mostly reinventing throw/catch with different syntax.
Indent needed
OK so this line is not necessary once you've documented it. Pull request waiting on that.
Thanks, but the namespace error is in the free-agent/bitter package. I've resolved it.
single line as well here.
doing 

```
var parameters = {
   'created': created
}
```

is probably cleaner.
Please use the validator here once it's merged in.
A couple things:

a) I don't think invalidating the principal cache should be exposed as a public util method, but rather buried in an "internal" module method
b) I think we should invalidate the cache after, race conditions under regular operation can cause stale data in this case
This default function should log an error if there is one.