labofsahil/github-event-dataset-2012 huggingface dataset:
That's fine, although doesn't the Gemfile.lock file do this already?
The #now method doesn't really belong in the flux capacitor. The Flux Capacitor makes time travel possible, but it doesn't know what right now actually is.
I'm not really sure why this is a new function... is there any reason not to do something like this?

```ruby
gems.each do |name|
  known = Bundler.load.dependencies.find{|d| d.name == name }
  raise GemNotFound, "Could not find gem '#{name}'" unless known
end
```
musql innodb and postgres have transaction queries.
is there no other way?!
object**s**
please change to:

`set(this, 'selection', Ember.A([selection]))`
we now have no difference between fullscreen and embedded handlebars, this simplifies teh task of editing them when they are 99% the same, differing only in the fullscreen/small size icons
trying to make the time stamp in datum look nicer, btu they are still pretty ugbly until we can format them better (my hope is to use a "2 seconds ago, 3 days ago, type of timestamp
not necessary for directory resource
Yes, you should only modify the pom if you are adding a new package that needs to be run under full profile. As there are already existing packages for most full profile functionality this does not have to be changed very often.
```java
ModelNode node = SaslPolicyResource.FORWARD_SECRECY.parseAndSetParameter(readStringAttributeElement(reader, "value"), policy, reader);
```

and all others for policy parsing
Given that ref is no longer jndi reference but rather a service dependency/name, probably docs should be modified a bit...
since we don't have browscap's limitations as far as parsing goes - what is this supposed to be validating against?
Not sure this is good. Classes should be managed from their respective classes but that's OKfor now.
I made sure it was fully isolated from the test of the unit tests in calendar so it should be a straight copy/paste
all right, all right, I move it up one line :)
Agree, this is a near-prefect arrow pattern :P
this has nothing to do with that bug I think.
It sound reasonable to reuse the getphoneDetails. Is that part of logic suitable for message list, @borjasalguero ?
You are right.. :( But I can't think on another solution. Ideas?
I'm not sure if I should be using the absolute path here for `Janky::GitHub` but I went ahead and did that since the `ChatService Notifier` uses that already.
It's the api itself that returns the redirect. Octokit returns the actual URI string. See #160 for my solution without automatic redirect followign.
I do want to combine the status values. Otherwise we would override the
original (possibly nonzero) status value. That would reintroduce the bug I
originally fixed in #569.

Instead of a bitwise or, a simple addition would work just as well, but we
would have to clamp the result between 0 and 255.
We'll definitely merge the rest of the documentation stuff you wrote up (it's really great) but I'm hoping @dchelimsky can weigh in on the DRb options first.  @dchelimsky -- if you get the chance, it'd be nice to get a description of how to use these options, if for no other reason than to provide a "here's how to use them guide" for me so if/when I refactor any code involving the DRb stuff I can verify I haven't broken it.  If it's feasible to turn that into a cuke we can do that as well.
~~~
2セクションに渡って、オプションモデルプロパイダとして振る舞うシンプルな CGI スクリプトを用いた例を説明します。
~~~

~~~
2 セクションに渡って、オプションモデルプロパイダとして振る舞うシンプルな CGI スクリプトを用いた例を説明します。
~~~
Again add a comment explaining what this is, a use case, etc.
Yes, that's true. But this message is shown only if something fails. And in that case I wouldn't confuse user any more :)
Even when it is not meant for binding?
Good catch, the default should be True.
You may want to point to `Attributes-of-Changes` instead?  Or both?  Or maybe just the "concepts" page itself?
Is this needed by anything, and if it is, is it a direct dependency?
Use setFilterWildcard, Luke
destory, or destroy?
Moved this here as we don't want the delta reset *every* click, just successful ones.
BUILD_UNIX_SOCKET
Okay, but `re.search('\.rst$', f)` is probably better understood as `f.endswith('.rst')`.
You did not delete the now-obsolete `manage.properties` and its locale variants. I guess better would be to run

    for p in core/src/main/resources/jenkins/model/Jenkins/manage*.properties
    do
        n=`basename $p`
        b=${n##manage}
        git mv $p core/src/main/resources/jenkins/management/Messages$b
    done

so that the diff will show clean renames, and then use the corresponding new keys.
Parece que seu editor mudou o enconding do arquivo. Você pode arrumar antes de eu fazer o merge?
* Also what is the expected behavior if you have host and hosts set?
Would it be worth making @container be event.sprintf-able?

Basically:

```event[event.sprintf(@container)] = kv_keys```

This would let you dynamically name your container if desired.
It is preferable to use structured logging instead of string logging -

`@logger.debug("processing", :metric => metric, :value => value)`

`@logger.debug("Sending carbon message", :message => message, :host => @host, :port => @port)`
I"m fine this, but I think we should just import node's `path` module. I have being using it intensively for linker too.
I don't think we can degrade to secondary. That is a horrible UX.

Sometimes I'm asked for my gmail password by google.

Then, I'm asked to create a password.

Then, I'm asked for my gmail password by google a bunch.

(second network issue or whatever) Then I'm prompted with a different screen where I try my gmail password and it doesn't work.

Also, by collecting a password up front in our new flows, is that even technically possible?
I dont think it should be a stand alone page since your API key is tied to your profile. You cannot have an API key without a profile
The daily idle doesn't fire at the same time every day, so it's probably best to just store when it was first computed and do a diff of the current time and if it's greater than 7 days, recompute.
> * Have you tested that we correctly handle the TabGroup name across windows? Each window has its own set of groups

Not tested before, but a quick test shows something: only the registering window's TabGroup title is restored.
Because I don't iterate through all the windows. :)

But I don't sure about the need of removeObserver. And related: how to take care Private Browsing...?
Just personal preference, but does this need to be 8 functions? I get annoyed when I have to jump up and down all the time in a file to understand a stack trace...  

I mean I don't think it's worth worrying about - just sayin
What value does this have in the Ruby DSL?
Please rename the app var to `solr_jmx_port`.  That sounds better and is the name used in the rest of the code.
You've mixed single and double quotes all the way through. The rest of BS uses single quotes so you should stick to that. Also to stick with BS's style, you should remove semicolons, spaces inside parentheses, unnecessary braces, etc.
After a bit of testing it seems I do, the `HashSet` is storing some information that the `HashMap` should not have until some more processing has been done (e.g. line 106 and 109), though perhaps I am overlooking something I can do to circumvent that...
This was space at the top of the new stats dashboard.  I'll show you this shortly, it is not quite ready.
Hmm, this file used to be in use with `make`, did you rename it?
all `@group` must use underscore `_`
Why this? The argument is $proxyPassword see line 670
Well... the currently best choice in DCPU-16 for graphical applications, must be CLI's. And the closest you get to GUI's from a CLI is TUI's. And box drawing characters are completely vital in TUI-based applications.
Did you test this? I believe the actual change should be what I left in the comments, "[Gmail]/Sent Mail"
The login auth thread is supposed to send the response, not the current thread.

    while (thread.isAlive()) {}
   
spins the current thread until the other one is done.  If you have to do it that way, then you should use loginAuth.join(), which means wait until that other thread is dead.

However, waiting on this thread defeats the whole purpose of doing the login auth in another thread.
This part is fine, but the rf/gf/bf aren't really necessary - you can just modify and reuse the r,g,b variables.  Especially in the else case.
didn't see that... just edited with vim and had put a tab there. fixed now
clearly state that ALL files below here are world-readable
This factory and separate settings for Services should be removed afaik and as we talked about earlier this week, and it should be simplified to just inject repository instead.
however, since there is a desire for supporting interpreters that aren't as awesome as V8 (looking at you IE), there's no reason to be lazy about it.
"... >>>are<<< added to..."
I could not revert this change. The github editor keeps replacing the '-' character.
I remember that our original version of MMM in Platypus had something like this, but John and I deliberately left it out of [our fork of] Kookaburra because it seemed a little baroque. Do you have a [sanitized] use case where this makes more sense than maintaining an alternate view of the mental model?
Can do, if that improves readability a bit.
`authenticate` is supposed to return `None` no matter what? It's not supposed to return `user` if one was found?
As far as kwargs i think its chill if you override other things
jQuery or $? I like to use jQuery for everything, because $ can be anything, jQuery is always jQuery.
This is more versatile than an enumerable. You might want to run something on an attempt before returning the string.

I can change the example to have an enumerable that returns the item at the attempt index instead, if you think this is the way is going to be used mostly.
    
    alternate_names = ["#{name} from #{location}", "#{name} from #{city} in #{location}"]

    def resolve_slug_confict(attempts)
        alternate_names[attempts]
    end
Seems like at least in test_transforms we use: BatchTransformMarketAwareTestCase

What should we decide on?
Done updated this and moved the auto_ptr to a boost::shared_ptr
Also, did you mention that xgraphics had a utility method for this? Is it not exposed? Is this copy pasta?
Should be `\Redis|\Predis\Client`.
should this be "Step 3: Comment out Step 2"?
Technically, prism:title is not part of the spec. PRISM uses dc.title, but maybe we want to keep this to be compatible with pages that don't strictly follow the spec.
I hate this way of calling methods to "document" parameters. To make me hate it even more, you could scope it with a {}-block.
Should we add something here to delete tokens that have expired? If there is an expired token it will currently sit in the database forever since it won't get hit by the query.
Yeah, the Polling thread was one of the things I was not sure where it'd make more sense. I was just sure that it didn't need to be in the ``Bot`` class. 

I think it is easier if the thread stays in the ``Trade`` class only because if the thread needs to be stopped, the user can call (a non-existent) StopTrade or Cancel on the ``Trade`` object itself. Stopping the Trade thread via ``TradeManager`` would be a bit more complex especially if we added more threads later (like sharing a single ``TradeManager`` instance across multiple bots).
Really, we should probably have all the same information in the failure event as in the success event, except the failure should also include a useful representation of the cause of the failure. You'll notice the old log statements did output information from the WorkItem; I think we should include that information in the event.
The name of the branch doesn't matter, it's that we need to convert it to a commit hash from it's alias.

Since commit hashes don't contain dashes, the overall bug that i'm trying to fix is solved.
The best practice is to return a dictionnary, it will be automaticaly printed :)
Why is this using the JSON DTO as its input?
Aca andaria como trompada hacer logger info o debug en vez de print, para que sea limpito :)
Think this can be simplified to `limited-result-set`
I would split this out into 2 separate statements for clarity sake:

```
app.server.get(/api\/config, function(req, res, next) {});
app.server.get(/api\/config/:tenantid, function(req, res, next) {});
```
Minor: for .. in
Another syntax nitpick: I think we explicitly surround all keys of a hash with single quotes.
Shouldn't this be happening in the oae-util/lib/redis file ?
If principalId **does** turn up in the results, do you end up with `limit - 1` results?
That is too bad. ;( Give me some time, I'll try to separate the tokenizing logic from the scanner.
Ok, I get what you're saying for the enums. For the subtypes, should that be a split on "-" before the for loop so all mobtypes can use it? And with Zombies alone, are you wanting something more like this?:
```java
String [] subClasses = subClass.split("\\-");
if("VILLAGER".equals(subClasses[0].toUpperCase())){
    z.setVillager(true);
} else if("BABY".equals(subClasses[0].toUpperCase())){
    z.setBaby(true);
}
if(subClasses.length > 1 && !subClasses[0].equalsIgnoreCase(subClasses[1])){
    if("VILLAGER".equals(subClasses[1].toUpperCase())){
        z.setVillager(true);
    } else if("BABY".equals(subClasses[1].toUpperCase())){
        z.setBaby(true);
    }
}
```
@toin0u It's not needed, the `Geocoded` class will do the job for you. 
https://github.com/willdurand/Geocoder/blob/master/src/Geocoder/Result/Geocoded.php#L211
Might want to split this out into two functions.
Dit kan gewoon `else` zijn, niet `else if`. Als de if namelijk `false` is dan is de `else if` in dit geval altijd true.

Hier is een tip:

```
!(a && b) == (!a || !b)
!(a || b)  == (!a && !b)
```
fwiw: `ig.game.spawnEntity(EntityHealthBar, this.pos.x, (this.pos.y-5) );` returned de nieuwe healthBar entity
Пересчитайте проценты в позиции. Хотя в условии и сказано, что массив DNA содержит 100 элементов, это не означает, что в принципе массив не может содержать другое количество элементов. Также неплохо было бы фильтровать значение процентов на диапазон 0..100
Изменяется не строго Х процентов. Нет проверки, что новые значения не совпадают со старыми.
Каждого созданного объекта, вы хотели сказать? В смысле, клетка=объект-полседовательность ДНК?
Категорию лучше разместить в отдельном файле
Mmmm, pasta
bytes, not characters.
Servers doesn't list dataretrievers, it lists Diamond servers.  And they are hostnames or IP addresses, separated by commas or semicolons.
Same thing here, it doesn't make sense at all.  Also you use hunt.name and then check for 'Start a Hunt'.  That means your tests are directly tied to the factory which is a bad idea.
This can use literal syntax, and should use the `keyForSubscribable` block defined above.
Usually q is my temporary-variable name of choice (because it's pretty easy to hit), but at this point, it was `q` before I touched the code. It stands for Query.
list = params['list'] != 'false'
@ben I'm still uneasy with this... I can't help but wonder, *"what would the user do with a 2Gb blob, in memory"*? Given that this is copied, this would mean that 4Gb of RAM are required to handle *that* blob. That doesn't scale well.

I'm in favor of killing this method and let the user handle the retrieval of the `Blob` content from the streamed version below. This would mean that the `Blob` type wouldn't expose a `Content`property anymore.

@dahlbyk, @xpaulbettsx, @tclem, @phkelley, @jamill , @spraints, @gorbach Thoughts?
`#`重复了……
@cspurk Indeed, I will correct.
On Thu, Sep 6, 2012 at 11:21 AM, Julien Richard-Foy <
notifications@github.com> wrote:

> In framework/src/play/src/main/scala/play/api/libs/json/Util.scala:
>
> >        )
> >
> >      def join[A >: A1](implicit witness1: <:<[A, A1], witness2: <:<[A, A2], fu: ContravariantFunctor[M]): M[A] =
> >        apply[A]( (a: A) => (a: A1, a: A2) )(fu)
> >
> > -    def tupled(implicit v:Variant[M]): M[(A1, A2)] = v match {
> > -      case fu: Functor[M] => apply{ (a1: A1, a2: A2) => (a1, a2) }(fu)
> > -      case fu: ContravariantFunctor[M] => apply[(A1, A2)]{ (a: (A1, A2)) => (a._1, a._2) }(fu)
> > -      case fu: InvariantFunctor[M] => apply[(A1, A2)]({ (a1: A1, a2: A2) => (a1, a2) }, { (a: (A1, A2)) => (a._1, a._2) })(fu)
> > -    }
> > +    def tupled(implicit v:Variant[M]): M[(A1, A2)] =
> > +      // SO UGLY UGLY UGLY workaround for unchecked type erasure warning... no cleaner way found...
>
> Isn’t it possible to pull the tupled method into Variant[M[_]]?
>

What do you mean exactly? any idea is welcome :)
We tried many syntaxes and always warning or errors :D

Pascal


>  —
> Reply to this email directly or view it on GitHub<https://github.com/playframework/Play20/pull/440/files#r1542359>.
>
>
`or @build_gem.downcase == 'true'`
By **maxing out at a positional value of 100**, I mean current clock skins have been designed to that limit, and it would be silly to change that.
Doesn't a vertex need children edges?
Maybe remove "NOTE" and "now"? Do people need to know that they weren't in JSON before?

Instead of "NOTE", how about making it a subheading?
Why is this Unsupported?
This can be replaced by strcpy
You changed all line endings
I recommend not keeping this in your codebases -- if you really do have some pending specs, you can keep -- but try and keep them clean (and no commented out code either).
Isn't this a bit restrictive? One quite commonly wants to be able to pass `group_level` , `reduce`, `limit`, `reverse` and other similar kwargs to the views.
use $request->request->get
Unfortunately are accessors not always cheap and in this case it has to instantiate a new wrapper object for the underlying native MapController.
I have no real experience in Java performance, but from what I read object instantiation is even here not a cheap thing.
Dependencies for Google diff-match-patch, PIL
I'm confused about the discard code. It sets the instance's state to DELTED then calls db.instance_destroy. Does the instance still have a row in the instances table? Does db.instance_get raise InstanceNotFound if the instance's state is DELETED?

If you can, please verify that the instance has the right vm_state.

You could also add a check for the terminated_at time. Something like ```start_time = now(); ... ; assert terminated_at >= start_time```
Whats this comment mean exactly?
Ehkä en lähde tappelemaan näistä pisteistä. Tämä ratkaisuni oli jo  alun perin kamalaa kuraa.
Is this method the same as the parent? If so, why add it? It's a private method not used at all in the class, so seems a bit pointless.

If not and what you're trying to do is override parent's implementation, this method should not be private (neither in the parent) and should be marked with @Override.
ohh yes, I read it 3 times and didn't see the typo :)
Ah, ok. I wrote these changes a little while back so its like I'm coming to it new! 

Again this is half baked, but the intention was to have the savefig manager the figures dpi rather than passing it through, that way, the savefig method can re-set it after calling the backend.
Exactly as efiring says: these files are neither necessary nor relevant but they are helpful for folks like me who use Pydev (Pydev creates a .project and .pydevproject file for each "project").  Sorry, I must admit that I'm still very much a newbie when it comes to pull requests; I had assumed that only my first commit  (the GTK3 example code) would be part of the pull request, not my additions to .gitignore.  But, a efiring says, these additions to .gitignore should be entirely harmless for folks who don't use PyDev and will be useful for those who do use PyDev.
Wow. Brilliant. I didn't know this existed!
In which situation would that happen? If code directly make use of the MozMill API and doesn't use the create method? As mentioned on IRC the API is busted and needs to be changed. So I can do such a setting here, but I have to find out how to get access to the profile_args via a runner instance.
I'd suggest sticking this in a separate pull request
Все cnfhst тесты работают :-)
The logic here is somehow messed up. The default value will never ever be used if doesArgumentExist(...) evaluates to true. Something needs to be done about the default, I'm not sure what  though.
Why not create a Headers object? So you could get/set headers in it and pass that to the request
And so you could use that to get the header info instead of all those methods in the response class
Do: `return PSU::mail( ... );` for all of these methods whose last line is `PSU::mail`
So this special case is no longer necessary and it works with PHP 5.4 server out of the box? Or was this also a merge error?
That's the right thing to do for now -- as we've discussed previously, longer term this logic should move under a "config" cursor type and use normal config parsing, so dump becomes straightforward.
This seems like it would be usefull in a debug context, do we really need it to be in an info block?
Since this variable is only ever used inside the while loop, would it be possible to move this declaration inside of the code block to line 697? Due to the way Flash works, there is no performance cost in moving it there.

I realize Adam has a tendency to put all his variable declarations outside of code blocks, but I find it to be "dirty". I feel the variable should only be defined in the general area or the code block in which it is used.
I prefer to start with "early exit checks", i.e.:
if(!parameters.containsKey(PARAM_ACTION)) {
  return;
}

so the entire page doesn't get filled with indentation. I count 40 spaces before db.checkIn().
lol thanks, I had to dig deep on ways to call him old because I had resolved not to give them names.
But there is no options.path check's at the get portion of the code ?
Though true about the `raw` option, maybe get rid of it for JSON auto-magicness :wink2:
so /scriptorder will accept "traverse", "recurse", "specified" (defaulting to "scriptorder.txt") or the filename for the specified ordering?
增加一些非正常输入测试。
It seems I was tried too hard to optimize this. This code will reduce number of groups where not isolated tests should spread through.

I gonna fix this soon.
For consistency with the rest of the specs, would you mind changing this to

```ruby
subject.keyword.should == 'Delivers'
```
correct, but I was thinking about my next PR
Pretty sure es-* should automatically map to es.
you can merge contact lines with copyright (again, see my example), otherwise as each new person contributes this is just going to continue to grow
there are about 120 documets created for one location per one day. (first 3 days then it's reduced) so on average 60
So  60docs * 9 days * 160 nodes ==  a lot!
No from_email.
No space before `:`. (nodewatcher has a bit different code style.)
`0px` is redundant. `0` is better. It does not matter which unit it is, when it is 0.
Why change here?
Added the check here, because at this point Application is already created and starts visuals, also this class is the first to load visual elements. Thought this will be logical..
Ah, right. I had forgotten that `space` was conditionally defined there.
This will produce `return !0` instead of the optimal `return!0`. Same with `throw`, `void`, etc. and other unary symbol ops that aren't also binary ops.
This can be moved into an instance method on the Fedex rate request tests to avoid adding a fixture. Something like this would work:

```
  def successful_rate_request
    "......"
   end
```

Where the ...... is the request below.
That doesn't mean that you shouldn't use a better way, damnit.
why not?:

```c++
class achievement_emerald_void: public AchievementCriteriaScript
{
    public:
        achievement_emerald_void() : AchievementCriteriaScript("achievement_emerald_void") { }

        bool OnCheck(Player* /*player*/, Unit* target)
        {
            return target && target->GetAI()->GetData(DATA_EMERALD_VOID);
        }
};
```
I feel like I'm nit picking on this issue a bit, but looking at 508, I suspect we could run into a NameError on form_user if the form was invalid for some reason. I'm thinking since we only ever have a form_user if the form is valid and doesn't return None for form_user, that we could move that whole branch (508 -517) over inside the is_valid() block and just use "if form_user"
This seems to be fixed in the latest master as I couldn't reproduce it myself.
I've removed it from sources and if in the future people will bump into issues then a simple report with a use case should help me identify / fix the problem.
there are some pylint/pep8/pyflakes issues, among which you should fix the
followings:

R0914: 66,4:Iaspei.store: Too many local variables (16/15)
eqcatalogue/importers/__init__.py:5:71: W292 no newline at end of file
eqcatalogue/importers/iaspei.py:130:9: E303 too many blank lines (2)

Adding shortcuts to __init__.py is fine to hide the internal structure of
the library but I would add an __all__ variable to help for damage control
when an user imports *. Please, add it.

2012/9/18 Giuseppe Vallarelli <notifications@github.com>

> In tests/test_homogeniser.py:
>
> > @@ -17,7 +17,7 @@
> >  import unittest
> >  from os import path
> >  from eqcatalogue.homogeniser import Homogeniser
> > -from tests.test_regression import _load_catalog
> > +from tests.test_utils import _load_catalog
> >  from tests.test_utils import in_data_dir
>
> OK.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gem/oq-eqcatalogue-tool/pull/18/files#r1626459>.
>
>
Do we have something which could provide a good example at this level? Maybe the override of ID column names into __id_ ?
fire, ready aim?
I think that after moving this method into another class in the `Internal` namespace there will be no need for such comment
Aside, these functions will get called a lot, right? Maybe put them in a header file so they are eligible for inlining.
You're multiplying by sb->GetRadius() in the previous line and dividing by it in this line... that seems unnecessary.
OLS or linear models don't know about ANOVA and contrasts either, they just see the ``exog``, only when using formulas we might get the information about the contrast or dummy coding of categorical variables.

at edit: Yes, that's what I mean, maintained assumption is: coefficient of reference category == 0 and no constant effect.

I'm just illustrating that there is no direct link between rank and has_constant. Whether those are "commonly" used models is a different issue.
It's up to you if prefer it that way, but in my opinion parentheses are needless in cases like that.
This whole method can be simplified to `!!locale && supported_locales.include?(convert_locale(locale))`, because `convert_locale` method converts `locale` into a symbol and returns intact locales that do not need to be converted.
The return message is only send then mandatory or immediate is true in basic_publish, so maybe it`s better to throw the MessageReturnException instead of ignoring the return when the callback is not set?
Some weird whitespacing? :)
As you see, they are not. Please never use tabs in the code. And we will not have a discussion about this now. ;-) This is a code style for this project. (This is the problem when multiple people are working on the project, code style has to be consistent.)
Since this is a public repo... sandbox URLs will resolve to prod (for those not on VPN).  Would demo2 be better here?
I would like to see this method removed.
This should be `fields` rather than `size`, right?
This function should be declared in the OS module.
Fair enough, I was leaving it so that it would be reasonably extensible in case someone wanted to modify the option so that it would force a plus at the start for positives (e.g. "+£200")... but maybe that's just overthinking it, if someone wants to do that then they can code it I guess :).

Not sure if we can do it in one line though, as we need to still do `formatted.tr!("-", "")` if the number is negative, as doing that one-liner will get "-£-200".  I'll reduce the three nested if's to one anyway though.
1. no need for `to_f`
2. the default delta should be fine, right, no need to specify `0.00001` ?
Can you remove one?
This (double [3]){0,0,0} approach seems to fail with certain compilers.
Does the method below is used in some place?
Can you change this example? I HATE `? true : false` as people do that when they could just return the comparison to get a boolean.

Could this be: 

    return ($a == 5) ? 'yay' : 'nope';
Is it okay if I do this on Tuesday? I would test it then against 0.1.4.
Должны поддерживаться все форматы для целых чисел. Например, "o", "10x".
Боюсь, тебе придётся это решение объяснить подробнее. Что ты хочешь получить и как это решается.
Я рассказывал на лекции про double checked. Эта реализация - неправильная.
`Y.Plugin.Base` is not just an `EventTarget`, but also a subclass of `Base`. We can use that to declare a `collapsed` attribute which keeps the collapsed state and fires a change event.
sorry .. small nit. Inline comments should use <code>#</code>
s/ """update the details of the app"""/# update the details of the app/
Remove "\"
I imagine you could use a regular expression and count the matches.
I said I don't like PCD? Can't remember that. I might have said I don't like RBMs ;) But PCD is way better than CD!
Please add just a small description of 'y'.
I think that you code this as:
<pre>
train = rng.permutation(train)
test = rng.permutation(test)
</pre>
@glouppe @pprett you will notice that its no longer passing the pointer to the data, but rather the ndarray.  This is because np.argsort only accepts an ndarray, and so we would need to convert back to one anyway if we pass in the pointers.
Could you improve this test by catching the warning and checking that it was raised with the expected message content?
Agree - I'll fix that
when you wam restart you start in practice from a slightly larger alpha and your best bet is that the good features are the same. It's true that some features can disappear and reappear along a path but does it really need to appear there? How about maintaining this list in the path function and be able to pass and
active_set_init to fit like coef_init that would be this?
Typo: leaves
всі подібні запити мають бути в репозиторіях
I can change that, but it’s the same convention as in auth-mode (the name) vs. auth_mode (the type).
I think snow and rain are the same thing, but snow is shown instead client-side for cold biomes.
@9rnsr , just from pure curiosity, why is it Tfunction and not TOCfunction?
IIRC token.value is of type enum TOC and there is only TOCfunction.

I am newbie, be kind please! *grins*
It is one of the possible types though. Will it hurt to leave it in there?
This if else could be merged with the following one as there are testing the same condition.  Better yet would be to supply the extra ip_address, and password args directly to builder.run() instead of to the ctor.

Doesn't need to be done in this patch or could be done at merge time.
Isn't "V8" supposed to be "Ti"?
Done.
A noter que pour une étude spécifique,  il peut y avoir plusieurs versions de facture (à demander au trésorier pourquoi).
This line can be removed. Thanks.
Oh wait... I could code using my phone :p https://play.google.com/store/apps/details?id=com.aide.ui&feature=search_result#?t=W251bGwsMSwxLDEsImNvbS5haWRlLnVpIl0.
omg ...
/facepalm
/kick [target=self]
why do we add this now? just to be more consistent?
Gavin wrote:

>The heap sort is now less distinctive - it is less likely to overlap the table insertion with any down-stream activities.
>
>I'm not too concerned about the change for hthor - although I would be for roxie.
next is initialised to null in the constructor
Ah, makes more sense (avoid when in range), even so, I agree it needs the U all the time. Constants' default type is ```signed int``` if it fits the signed range, and that can confuse the compiler later on.
There doesn't seem to be a way to set the hooks without at the same time fetching them.

Roxie might want this for the case where it is using cached dali info
Looks like this WHOLE file can use some autoformatting... the coding standards are just wrong here.
This too. If statement embedded.
I agree.  Got carried away there for some reason.  Fixed in 8dc5636a2583f970f4db6f4b4f0b8a71a6ada557.
You mean the report? Fair enough.
An extra word got in: s/a //
The redirect_uri should be built up using url_for instead of configured in. In the Canvas controller it's:

```
:redirect_uri => url_for(:only_path => false, :controller => 'canvasOauth2', :action => "handle_callback")
```
@yuhunglin Good question on definition of week. That's a design question so let's talk to them today about this. I assume it will be "this calendar week" but let's confirm. This shouldn't  block current merge though.
@ctweney Can you change this to the following:

```javascript
parseInt(calcentral.Api.Util.getURLParameter('dept'), 10)
```

We almost never use `Number`, `String` nor `Object` (only when type checking)

Since we know it's going to be an integer, it's better to use parseInt.
`Number('0x99')` ftw ^^
Some Java folks still use ant. :-)
No, every object is passed as reference in python.
(some objects are immutable, but it's another thing)
I'd put the ```int()``` at the point where ```fport``` is assigned. I'd also rename it ```FUSEKI_PORT``` or similar.
Agree, the entire structure is in need of a mixin, but we dont have one yet, maybe a future PR
Please only references to the specific technique
default should be mysql
Ah, nevermind. I see that it fails without your code. Nice!
Rather than use a factory, we should use a producer method.
I, of course, like wikipedia too.

In a book, paper, or any authoritative writing, wikipedia should never be cited.  Instead, the original source should be.  Here, I don't think factorial needs to be referenced at all.  It's like referencing logarithm.  It makes us look like we and/or our users need references to high school math.
I added it. If the polyline doesn't cross the IDL, it isn't broken up into segments. If there are no segments, then run through the positions.
"providing a crisper images" should either be "providing crisper images" or "providing a crisper image"
Can simplify the API a little more. Pass not the formatter type, but the payload type. Then do this:

```C#
    Type genericFormatterType = typeof(ODataFormatter<>);
    Type formatterType = genericFormatterType.MakeGenericType(new Type[] { payloadType} );
    ConstructorInfo ctor = formatterType.GetConstructor(new Type[] { typeof(IClientMessageFormatter) });
```

etc.

This way, when creating the attribute, you can say, for example:

    [ODataBehavior(typeof(ServiceBusRegion))]

without all the extra repeated "ODataFormatter"s in there.
You don't really need the {} 3rd arg.
I think all globalPoint properties should be deprecated already, using the following format.
      - name: globalPoint
        deprecated:
            since: "1.8.0"

As discussed with stramer in IRC, I will ensure that globalPoint is included in the TableViewRow API too.
Слишком много аргументов - подумай как уменьшить их число
The constructor should come before the toString method.
Here, I think we have the same situation as above. But, I'm converting to grunt file API.

One observation/story: while porting I thought about the fact that pathnames on *nix have forward slashes `/`, but on windows they have backslashes `\`, and I started porting every string pathname to its path.join() correspondent. But, it makes the code really illegible. And I thought: well, the right thing would be the `fs.*` functions to actually treat that, not "me". Searching the Internet I found some answers telling not to bother about the slashes differences  \[[1](http://stackoverflow.com/questions/9756567/do-you-need-to-use-path-join-in-node-js)\]. But, I went thru their code and confirmed. The fs.* functions treat that for us. So, I will remove path.join() from whatever it's possible. It gets much better.
as of 2.6.5 or so, its possible to set $name as the default value for a parameter

that may allow you to remove lines 29-31
ok. looking forward to see some diffs
with additions < deletions
:dancer:
you need to add the curly braces
the interfaces don't require an implementation imho. i mean the interfaces do what interfaces do without an implementation .. plus this sounds like a circular dependency. however phpcr-odm requires a phpcr implementation.
Just do `Index+= 2` and return here rather than falling through. Fewer instructions get executed that way, and it's just plain weird IMHO to do `++index` twice in a row if you don't need to.
Making this non-final means that it's possible for registered commands to get lost. You need to define under what circumstances this processor is released, and when commands should register with a new one.
I asssume this is just the default version?
à déplacer de projet
This restriction is connected to https://github.com/imagin/FOSRestBundle/commit/ccfd53bf8a632db8f790eb754a9e099f682d0d0a . This follows from the behaviour of FOSRest routes generator - all arguments of a controller method which aren't instances of Request or QueryFetcherInterface will be added as a route parameters. I had to somehow mark DTObjects to not be involved into route.
Yeah, I forgot to comment about that. I had no idea about where to put them.

Sent from my iPhone

On 8 juil. 2012, at 19:58, Christophe Coevoet<reply@reply.github.com> wrote:

>> @@ -0,0 +1,32 @@
>> +<?php
>> +/*
>> + * This file is part of the FOSRestBundle package.
>> + *
>> + * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
>> + *
>> + * For the full copyright and license information, please view the LICENSE
>> + * file that was distributed with this source code.
>> + */
>> +
>> +namespace FOS\RestBundle\EventListener\AllowedMethodsLoader;
> 
> the EventListener namespace should only contain the listeners. This has nothing to do in a subnamespace of EventListener
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/FriendsOfSymfony/FOSRestBundle/pull/250/files#r1119461
Should this be "Next, take a look at, and examine"?
This code is wrong. $_activeTokens is a static member, and yet you're initializing it inside the constructor, discarding whatever data it might have had. It should be either a regular private class member, or you should change the initialization routine to initialize it only once.
This title sounds better, i change it and remove the numbers
`secureTransfer` should be renamed. It does not indicated if the transfer will be secure, but only if there was no security protocol downgrade, i.e. http->http OK, https->https OK, http->https OK, but https->http NOT OK.
Using a normal Dictionary results in this C# code:

    Knockout.BindingHandlers["fadeVisible"] = new InlineBindingHandler<Observable<bool>>( ...
 
coming out as:

    ko.bindingHandlers.set_item('fadeVisible', { ...

which is invalid for Knockout.
It should be:

    ko.bindingHandlers['fadeVisible'] = { ...
JSON would know if it's an array
On 8 Dec 2012, at 15:09, Kenneth Hoste wrote:

> In easybuild/easyconfigs/c/Cufflinks/Cufflinks-2.0.2_ax_bam.patch:
> 
> > @@ -0,0 +1,11 @@
> > +--- ax_bam.m4.orig	2011-06-03 04:19:46.000000000 +0200
> > ++++ ax_bam.m4	2012-12-07 10:24:50.364706117 +0100
> > +@@ -189,7 +189,7 @@
> > + 			AC_MSG_NOTICE([Your bam libraries seem too old (version $_version).])
> > + 		fi
> > + 	else
> > +-		BAM_LIB="-lbam"
> > ++		BAM_LIB="${EBROOTSAMTOOLS}/lib/libbam.a"
> 
> I agree with @JensTimmerman, it this really needed? I don't see why it would fail.
> 
> Maybe because there's no .so provided by SamTools? If so, then that should be fixed instead, I think.
> 

Actually, I think that was the case. If this was the case, I don't know how this could/should be changed. Cufflinks also has an --with-bam-libdir option for configure, so hopefully the "-lbam" would be correctly expanded.

> —
> Reply to this email directly or view it on GitHub.
> 
> 

Cedric Laczny,
PhD Student
 
UNIVERSITÉ DU LUXEMBOURG
 
LUXEMBOURG CENTRE FOR SYSTEMS BIOMEDICINE
Campus Belval | House of Biomedicine
7, avenue des Hauts-Fourneaux
L-4362 Esch-sur-Alzette
T +352 46 66 44 6398
F +352 46 66 44 6949
cedric.laczny@uni.lu     http://lcsb.uni.lu
 

-----
This message is confidential and may contain privileged information. It is intended for the named recipient only. If you receive it in error please notify me and permanently delete the original message and any copies.
-----
quick_floor returns int, but inthash<> wants unsigned values (it only cares about the bits).  It would be equivalent to leave pi[] unsigned but then cast/convert each of the four values put into it.  The way I did it -- make pi[] the right type to hold the quick_floor results, but cast the pointer for the hash -- required only one cast. Do you think the other way is much more clear?
How about throwing an exception if an empty array is passed, it does not make sense to me at least?
This line is causing issues which I don't understand:

```
import matplotlib.pyplot as plt
plt.scatter(range(10), range(10))
plt.show()
```

 Commenting it out fixes the problem, but I don't feel comfortable with that approach, I would like to understand the problem. Any ideas?
All but `GetCommandLineW`, `CommandLineToArgvW`, and `IsDebuggerPresent`.
I wholeheartedly agree.  The only same way to manage these files is with separate blocks per platform, even if that means duplication.  The only version(Posix) blocks I think are acceptable are ones containing declarations of functions required to be in that header... and even then I've found instances where some specific required function wasn't declared on some platform.
Seems to me like, in general, we should not try to cast once we've determined it's not assignable...

...change...
````java
	@SuppressWarnings("unchecked")
	protected <V> V getHeaderIfAvailable(Map<String, Object> headers, String name, Class<V> type) {
		Object value = headers.get(name);
		if (value == null) {
			return null;
		}
		if (!type.isAssignableFrom(value.getClass())) {
			if (logger.isWarnEnabled()) {
				logger.warn("skipping header '" + name + "' since it is not of expected type [" + type + "]");
			}
		}
		return (V) value;
	}
````

...to...

````java

	@SuppressWarnings("unchecked")
	protected <V> V getHeaderIfAvailable(Map<String, Object> headers, String name, Class<V> type) {
		Object value = headers.get(name);
		if (value == null) {
			return null;
		}
		if (!type.isAssignableFrom(value.getClass())) {
			if (logger.isWarnEnabled()) {
				logger.warn("skipping header '" + name + "' since it is not of expected type [" + type + "], it is [" +
						value.getClass() + "]");
			}
			return null;
		}
		else {
			return (V) value;
		}
	}
````

Won't we always get a CCE here?
Well, that is not wrapped in an SPCA.

A quick check of sublasses of AbstractPollingInboundChannelAdapterParser point to classes ending with MessageSource - the method is called 'parseSource' after all :-)

````
protected BeanMetadataElement parseSource(Element element, ParserContext parserContext) {

   BeanDefinitionBuilder builder = BeanDefinitionBuilder.rootBeanDefinition(RedisStoreInboundChannelAdapter.class);
...
````
Don't even ask ;-) Will fix that later today.
If the change to EventManager in DoctrineModule is merged, this section of the config is no longer needed. The EventManager doesn't need an ```opts``` array injected into it.
Do we want the `.rpesc` file as part of the repo?
Ahh, yes, you're right. This was an oversight. I'll correct it with another commit.
i don't think path will work here. but can you maybe try?
The original string seems really wordy though.  How about:

> GoogleAuthenticatorRails must be loaded before ApplicationController is defined; otherwise it will not be activated.  One solution is to require it before gems with a dependency on ApplicationController are loaded.

My comment about moving it into `#initialize` still stands though.
Can you add the command to install the vendor ?
Can you remove this line? no need to instantiate a new variable here.
I think that this comments are not needed right?
sure its done on an install for us with vmware/vagrant but i did not notice it done on a cloud server when i set it up. Maybe some more verbiage around when this is needed?
@ed- the pagination is added :)
you could use:
```python
 for message, displayed in message.iteritems()
```
this would simplify the if a little. This is a minor enhancement, not sure if it really needed.
Yeah, we will remove it shortly :)
.get's default argument is already None.
This is nice anticipation of possibilities any error happen.
Since we've defined "Defensive Purpose", I think it makes sense to use it here instead of leaving open what "defensively" might mean here. Although I just realized this in now a circular loop. :(
My intent was to have (a) and (c) included under "defensively"...
Make sure we run stuff on the right filter. If not, we're adding a note for the user that she/he should fix stuff.
It's always private.
what do you mean if i plan to throw them myself?

the idea was, not to have the person object in every requirement and so tons of redundant person objects but only a reference - can it be like this in OpenEngSB??
This was actually intended. Case 2 & 3 are deny cases. When undefined is returned, we expect our switch case to default at [#L6R301](#L6R301). I guess we could pass in a -1 for result since CURLE_OK is 0.
This is probably the most breaking change in my commits.
Yeah, I have experience charging (and not charging). Wrote about it here - http://civic.io/2012/01/30/practical-hackathons-free-is-not-always-better/.

Also, presented on this subject at SWSX last year. This isn't meant to be a hard and fast rule, but rather a suggestion that people use their judgement. Charging a small fee is really pretty hassle free - any good registration system (Eventbrite, TicketLeap) will make this easy.
Same remark as #137
~~~clojure
(if (= (mod n divisor) 0)
  true
  false)
~~~

would be the idiomatic way of aligning the code