labofsahil/github-event-dataset-2012 huggingface dataset:
Were you running into problems with this? I had thought ActiveRecord's insert_fixture wipes out existing data
How does this differ with jquery.mobile.structure.css?
use to_i?
I agree as well. Some confusion around this may come form the fact that an 'unknown cache' is of type mystery and that a cache of type unknown looks the same...
I'll try to produce some icon for Unknown caches to make them different as Mysterys
aaaaaaaatestAAAAAAAAAAAAAAAAA
Also, if anyone has any suggestions on how to make this less weird; it would be appreciated. When Write is called, you pass in the stream that you want to write to. The objective was to not have to tear down and rebuild the frame reader/write for the future reconnect scenario. Thus you pass in the stream that you want to write on. However, with the buffered reader/writer you are deferring the write to a future async operation so we are just grabbing the stream that will be written to in the future. Feels a little dirty; so any input/thoughts would be appreciated. 

NOTE: Given the larger buffer sizes (i.e., 1MB byte array); recreating repeatedly if you are having intermittent connectivity issues wont be GC friendly.
If you declare `val serialVersionUID: Long`, you'll get `serialVersionUID` as a variable instance.
However, `serialVersionUID` must be static as you already know.

In scala, you can use `scala.SerivalVersionUID` annotation to specify it.
http://www.scala-lang.org/api/current/scala/SerialVersionUID.html

Note that, in case you want to declare static fields other than serivalVersionUID,
you can create a companion object where you can declare static fields of the companion class.
Lorenzo,
regarding your question; I just don't know if native typeof is as reliable as the mootools wrapper. I used this typeOf because I thought it's there for purpose and I'm sure it'll work and have no side-effects...
для русского например здесь http://ctan.org/tex-archive/language/hyphenation/ruhyphen
другие языки http://ctan.org/tex-archive/language/hyphenation
Ha, I don't think anyone actually uses HMMer to do DNA stuff, but ok, I don't mind the colour change ;-)
Tabs & Spaces mixed
Err, yeah, too late for that. You'll probably have noticed the pull request (tedium) and branch (CP). Although I don't get why you brought back the old applescript stuff, there's no reason for it (except maybe debug purposes?).
I would write the code much shorter here:

(let ((trajectory (merge-trajectories (ik->trajectory (lazy-car (get-ik ...)))
                                                              (ik->trajectory (lazy-car (get-ik ...))))))
  (execute-arm-trajectory))

I feel like that's better readable, in particular because the function calls are much more self-explanatory than some abbreviated variable names.
This seems to be the only event that is camelCased.  It's trivial, but should we fix it?
it is possible for you to add a different language like german? it's not important that the grammar is correct, i can help you! 

many thanks!
Well something went wrong here in the diff. Have you change the indenting or something like that?

I will assume you have added the hibernate-ogm-mongodb module and nothing else
Doh, this one will be in them all lol
If we did that, would we need to add getPosition(Node) to GraphDisplay so that NodeItem can look up coordinates for its svg representation?
Spelling Mistake 

UPDATE `quest_template` SET `EndText` = 'Steal perfume package from Crown Chemical Co. outside Stormwind' WHERE `Id` = 24656; -- Alliance

Stormind Should be Stomwind

Correct Update to replace line 98

UPDATE `quest_template` SET `EndText` = 'Steal perfume package from Crown Chemical Co. outside Stormind' WHERE `Id` = 24656; -- Alliance
I dislike assignments inside conditions, so I would disagree.
It also means that lastStatsCycles has an uninitialised value  if memTraceLevel >= 2 which won't have any ill effects, but it a bit messy.
You are not supposed to commit the softlinks. Unless you are _sure_ you will _always_ want that enabled on _all_ machines, I guess.
header.inc.phpで$_GET['a']を見てゴニョゴニョ・・とかはどうでしょう？(特定アクション向けの処理を入れるとすっきりしないファイルかもですが)
Pero para modificarlo, es el server el que debe dar el ejecutable :S
Fixed: 67c174b8b7ea2ac0ea5a20c697c2a512b4ae9412

It turns out the extra space I was seeing was caused by another plugin.
You're might correct: I haven't seen a java spec/javadoc that assures it works on all platforms.
The rest of droolsjbpm uses "UTF-8" when referring to it and it's the official name: http://en.wikipedia.org/wiki/UTF-8 so it's probably just easier to change it
Good call - I thought that was only in the BBQ plugin -- didn't realize it was in core
Ossum. Thank you sir.
Thanks, Carlo.  Karel has reviewed and pushed this upstream: https://github.com/shrinkwrap/resolver/commit/3b731f2086ea8cddbba76aaeb069ba3126e6d807
Error still exist:

frameworks/base/core/java/provider/ContactsContract.java:112: duplicate class: android.provider.ContactsContract
public final class ContactsContract {
             ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
make: *** [out/target/common/obj/JAVA_LIBRARIES/framework_intermediates/classes-full-debug.jar] Błąd 41
Framework loader class
WHY was this done? I'm reverting this now. We need this..
Sorry to hear that but also greatly honoured for the hard work you did with this code. Thanks a lot for every single line you fixed up !!!

Hope to meet you again as I learned a bunch of things in this two months :)

All best wishes for your projects and life !
Haha, this will always segfault actually. Or, excuse me, throw a NullPointerException. Mostly because fileMap currently has no elements with key 0, 1, or 2, since those are reserved stream names that haven't been handled yet. The correct way to do this is to iterate through the fileMap using the enumeration properties. A for(0 to size) loop won't work because there's no guarantee a certain index exists at this point.
I didn't think of `service elasticsearch status`, nice catch.
Are you using the latest version of project ? Remember about adding Item class to project.
General comment: I think we also need test cases for when channel has no name (null), just to ensure that there is no NPE based on failed log message
You would think .count() would be cached, but in my experience it is not.  (This may have been fixed in recent-Django; it is a little silly, I think, though it's in line with the semantics "you get a new query exactly when you add any new conditions to a QuerySet by calling a new function on it.")

Also, beware that executing it does not execute the query; it executes a simpler query that just returns the count, a single integer.  (It's a "SELECT COUNT(*)" query, if you know SQL.)

"ordered":  Ooh, shiny; I didn't actually know about that.  I assume this logic wants "ordered by start-time", though?  The "ordered" field appears to just indicate any sort of ordering; could be by ID, which for a typical program means roughly by time except for that one time block that we forgot to add and added later, causing results that are wrong in subtle and annoying-to-track-down ways.
idem, pas d'url en dur..
its just your 6 patches applied to an untouched cm7 source:

MIUI-like Battery Bar (1/4)  https://github.com/Spitemare/android_frameworks_base/commit/62cf4957dc7929200f700
MIUI-like Battery Bar (2/4) https://github.com/Spitemare/android_packages_apps_CMParts/commit/549c207edb338e748f8ea7fd38
MIUI-like Battery Bar (3/4) https://github.com/Spitemare/android_vendor_tmobile_themes_Androidian/commit/135d3ac6257e5e7d
MIUI-like Battery Bar (4/4) https://github.com/Spitemare/android_vendor_tmobile_themes_Cyanbread/commit/22cf80f8fb84a86476f393a

MIUI-like Battery Bar Colors (1/2) https://github.com/Spitemare/android_frameworks_base/commit/3d888347f66c6c90f18689b5fe886610cf0e
MIUI-like Battery Bar Colors (2/2) https://github.com/Spitemare/android_packages_apps_CMParts/commit/8ffc0cf20afc8efef75564965bfd497
Seria a "legenda" do fieldset, mas eu não quero.
The .travis.yml file is the only thing needed by Travis CI. Automating the steps from checking out the project to running the test suite is needed by CI.
A side effect of the submodules is allowing reproducible builds of PHPUnit_Selenium against particular versions of PHPUnit and its components.
Fixed now and specs pass :) Thanks!
yes it was patched from Sony Ericsson original sources from incremental patch for 2.6.32
you can find it from a website like this http://ring.maffin.ad.jp/archives/linux/kernel.org/kernel/v2.6/longterm/v2.6.32/incr/
Adds mark all read button to email app. Base branch is current ics-mr1-release.
When is it going to appear in the app store?
Its because your git account is still tied to the xebia developers group..
I shall remove it.....

Thanks & Regards,
Sunil

On Mon, Jan 2, 2012 at 5:57 PM, vashishthask <
reply@reply.github.com
> wrote:

> Not sure why I got this email
>
> Kind regards,
> -ShriKant
>
> Sent from Samsung Mobile
>
>  Iwein Fuld <reply@reply.github.com> wrote:
>
> ewwwwwwwww! this is wrong on so many levels...
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/xebia/REST-benchmark-reference-implementation/commit/8ccd94b6340a348ec7e425e17af9a2afe875c974#commitcomment-831024
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/xebia/REST-benchmark-reference-implementation/commit/8ccd94b6340a348ec7e425e17af9a2afe875c974#commitcomment-831207
>
`var _this = this;`
Or can we add a wait_for_ip_address options ?
You may be able to simplify by including/using the Fog::Deprecation stuff here: https://github.com/fog/fog/blob/master/lib/fog/core/deprecation.rb
Let's use log instead of say or show. thanks
Ah, thanks! As I say, it's my first go at OJS dev stuff, so all advice
appreciated.

That's fine re copyright/credit.

As I say, I'll try to fix ASAP.

Best,

M
On 2 Nov 2012 19:48, "Alec Smecher" <notifications@github.com> wrote:

> In templates/about/index.tpl:
>
> > @@ -32,7 +32,7 @@
> >  	{if $currentJournal->getLocalizedSetting('reviewPolicy') != ''}<li>&#187; <a href="{url op="editorialPolicies" anchor="peerReviewProcess"}">{translate key="about.peerReviewProcess"}</a></li>{/if}
> >  	{if $currentJournal->getLocalizedSetting('pubFreqPolicy') != ''}<li>&#187; <a href="{url op="editorialPolicies" anchor="publicationFrequency"}">{translate key="about.publicationFrequency"}</a></li>{/if}
> >  	{if $currentJournal->getSetting('publishingMode') == $smarty.const.PUBLISHING_MODE_OPEN && $currentJournal->getLocalizedSetting('openAccessPolicy') != ''}<li>&#187; <a href="{url op="editorialPolicies" anchor="openAccessPolicy"}">{translate key="about.openAccessPolicy"}</a></li>{/if}
> > -	{if $journalSettings.enableLockss && $currentJournal->getLocalizedSetting('lockssLicense') != ''}<li>&#187; <a href="{url op="editorialPolicies" anchor="archiving"}">{translate key="about.archiving"}</a></li>{/if}
> > +	{if $journalSettings.enableLockss || $journalSettings.enableClockss && $currentJournal->getLocalizedSetting('lockssLicense') != ''} <li>&#187; <a href="{url op="editorialPolicies" anchor="archiving"}">{translate key="about.archiving"}</a></li>{/if}
>
> Don't apologize! Thanks for the contribution; this is quite a clean pull
> request and we appreciate the effort.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pkp/ojs/pull/49/files#r2020480>.
>
>
Make sure IE < 10 still uses `XDomainRequest`.
Shouldn't there be another constant for "service" too?
this is always going to be on the page?  That seems weird.
Ah, gotcha. I definitely would have liked it to be much simpler than what it is now, but as much as I have found, it seems like there needs to be a little bit of conversion between AD's epoch's and JodaTime's (which is Java's really) before we can construct the right instance.

Once the code has the correct timestamp in `long`, it is then able to create the `DateTime`. That `long` value is based on Java's epoch which is accepted by JodaTime. If the library had a native way of calculating this all, it would have been great!
since you cache it unconditionally I assumed that it would be heavy, but in fact it’s just an Object, i.e. really lightweight, so I think it could well be a `def`.
What is the purpose of this trait?
I think it should go, and move the awesome documentation to ClusterNodeMetricsCollector
why toString twice?
if you just echo the string in the EchoActor, you could also do

    expectMsg("pong")
    lastSender must be(testActor)
OK, clearly a few days of playing around with Kivy have not been enough to understand its widget model, since I don't understand how you could move all that logic to Dropdown.open without turning it into a true toggle.  Can you please help me out?
btable = np.loadtxt(fbtab) ? Correct?
Sorry, I don't know what I'm smoking.

I think in order to avoid the while loop we can replace `sigma = mean_sig/snr` with `sigma = mean_sig / snr / scipy.stats.rice(snr).std()`. The only problem is that scipy.stats.rice wiggs out if snr == 0 or > 37.5 so we need to do something like:

```
if snr > 37.5:
    scale = 1
elif snr == 0:
    scale = np.sqrt((4 - np.pi)/2)
else:
    scale = scipy.stats.rice(snr).std()

sigma = mean_sig / snr / scale
```

I'm kinda tiered so someone else should have a second look at that and make sure it makes sense.
Don't you just love dictionaries :)
Shouldn't this be configurable ? Can we run those test on "production" or some sandbox zookeeper ?
should mark before reply in case reply throws an exception I think
We prefer job security code style.
эту колонку убери. И проверь запрос. Мы должны отображать только активный валидные склады
Sure. Also, can we put the testing modules that aren't actually tests in a different namespace? `mrjob.testing`?
there's a dot over the comma here that isn't right.
These default values are overridden with the values passed in `style` parameter. If you define just an item in `style`, you will lose these values. I think you are overthinking this feature.
This can be dangerous. Just to be paranoid, the `PWD` variable can contain any value (nobody restricts it to be a path), and the `cwd` is limited to 512 bytes. I will be happier with `strncpy(cwd, pwd, sizeof(cwd) - 1)` instead of the raw `memcpy`, or even a simper version `strncpy(cwd, getenv("PWD"), sizeof(cwd) - 1)`. The `- 1` is to ensure that the string is null-terminated.
How about renaming the function to version_tuple and changing the first variable to OtpRelease?
Also, Description should probably be called Type or What instead.
This will create multitudes of new detectors when there is a collision.
I'd split this method up in 2 parts,

1) the part which gets-or-creates the failure detector
2) the part which calls heartbeat on it
Alright, then I'll undo those changes.
Is there a performance impact associated with doing wcslen() all the time? We always know the length of string, right?
TYPO: should be *configurations*
This seems to be a bugfix of sth else, therefore it should be in a separate commit in separate pull request.
also deprecated http://www.day.com/maven/jsr170/javadocs/jcr-2.0/javax/jcr/Repository.html#LEVEL_1_SUPPORTED
не копируются картинки. надо cp ../../examples/* ../../../../bin/examples/
Should not we deprecate this method. It seems to be public.
```ruby
if entries.nil? || (value['__content__'].blank?)
```
"defaults to <p>" incorrectly implies that the value of `:wrapper_tag` should include the brackets.
I think the general convention is to use `&&`. Also, `unless` is more clear above than `if not`.
Hm, it occurred to me now that this can cause an issue with naming conventions: before it was `Fixtures::FIleTest` class in `fixtures/file_test.rb` file, and now it will be `FixtureSet::FileTest` in `fixture_set_test.rb`.  The same above with `FixtureSet::File`.  @rafaelfranca can you advise please?  Should i maybe use `fixture_set/file.rb` and  `fixture_set/file_test.rb`?
Ctor synthesis depends on `parents1` and `body`, which the namer doesn't know about. Also I wouldn't say that the primary ctor is derived from its template in the same sense that a getter is derived from a val, so including the logic into `addDerivedTrees` would be questionable. What do you think?
@retronym said he'd take a stab at SI-6331 (for teh record)
Was the intention to guard access to "valid" with EventHandler.this? If so, you're missing a synchronized here. Instead of using synchronized, maybe we want an AtomicBoolean? (In general, I agree with @loganj that we should minimize locking to avoid the possibility of surprising deadlocks and performance hits.)
This is the core of the issue and is an extension of the debate we went over in the `rules` PR. 

I can't have auto-evaluation occur all the time. We often but do not always want this. Sometimes I want to work on trees and not have them move around on me. For example many of the tests in this module work assuming that `Add(1, 2, 3)` is not the same as `Add(3, 2, 1)`.

I've tried hard to make unify friendlier than rules. This is accomplished with the `construct` function.  As a result `unify` plays fairly nicely with traditional Exprs.
ok...if you could look over 1567 that would be great. The last commit is a lot of whitespace related things so you might want to view each commit separately. There are some serious corrections that are there along with the addition of some missing methods.
I would prefer the 'garbage in - garbage out' methodology, however if you think that restricting the input is preferable I will do it.
You probably mean that it returns numerical values instead of symbolic values for the points and weights. Good point --- the symbolic values can only be calculated for some very low orders anyway. I'll add it to the docstring.
milliseconds.
そうでもない
I appreciate that you are updating the tutorial so i will leave you to it :)
/hiddne/hidden/
I think "don't add any magic that can't be disabled" is enough of a principle for me. Updated to remove the magic.
Can you please add [some #pragma mark sections](https://github.com/github/objective-c-conventions#documentation-and-organization) to this implementation?
не все 
+ index, add включает 2 экшена
если - то исключает
Pass the entire XHR object here maybe?
As far as I remember we are not supposed to allow a multipart to be a child of another multipart.
Not sure if we really need this information in this document
That is not the case. I know it sucks how the function works, but you can call it multiple times. https://github.com/phpbb/phpbb3/blob/develop/phpBB/includes/functions_content.php#L1077
Yes, this is difficult to read and should be rewritten somehow.
Add this to docblock.
Because this isusing quotation marks ", you can just put the variable into the string like this:
`'U_APPROVE_ACTION'    => append_sid("{$phpbb_root_path}mcp.$phpEx", "i=queue&amp;p=$post_id&amp;f=$forum_id{$back_to_post}"),`
If the previous block occurs when sizeof($attachments) == 1, this will only occur when sizeof($attachments) > 1.
As is done on lines 875-882, this shold check for the $this->user object and use lang if it is available.
documented in 9722593
Updated luvit-traceroute code to use dns module.
Linia asta sigur nu crapă, start e mereu < len(allUsers)?
Yeah, the resource store has its internal `_yuiUseSync()`.  Might be useful to break that out to utils.js or something like that.
Do you really mean `potions[0]`?
Line above
Move inside the namespace declaration
for all todos, there should ideally be an issue in JIRA, for better visibility of things that need to be fixed. Can hyperlink to issue in the code.
Looks like ``dims`` is being used after this line.
Also, there are ``return`` statements above this line that have no ``free(dims)`` (=> memory leak?).
On Mon, Sep 10, 2012 at 10:36 PM, Matthew Rocklin
<notifications@github.com>wrote:

> In theano/tensor/io.py:
>
> > +        return (type(self) == type(other) and self._info == other._info)
> > +
> > +    def __hash__(self):
> > +        return hash(self._info)
> > +
> > +    def make_node(self):
> > +        return gof.Apply(self, [], [theano.Variable(Generic()),
> > +                                    tensor(self.dtype,
> > +                                           broadcastable=self.broadcastable)])
> > +    def perform(self, node, inp, out):
> > +
> > +        data = numpy.empty(self.shape, dtype=self.dtype)
> > +        request = comm.Irecv(data, self.source, self.tag)
> > +
> > +        out[0][0] = request
> > +        out[1][0] = data
>
> Hrm, I could pull out the tag field for this. Is the 5 an input
> technically? Is it listed in make_node (perhaps as a constant)?
>
That sounds promising, yes. What is the tag exactly? If a given tag
uniquely identifies the return value within any graph that might be
compiled, then it will do.
If there's a match, does it have to go through the rest of the columns?
You're correct. I changed it.
jeżu
Warum muss das hier so stehen?
Well I have not been able to check it with the latest version yet, but at least on version 3.0.6 this does not happen! If reserved but not yet active task is revoked, no check against revoked list is made when task becomes active. Instead it executes normally.

Also, as the set of reserved tasks includes active tasks as well, terminate works as expected (e.g. terminates active tasks)
Please remove this "ornament".
the check is added, with massify.
looks like a copy and paste typo from the session cookie docs
Is it correct? It seems if you return here you're not considering the indexes created for this table anymore.
Support for partial teletext lines.
Case in point, at least that one I can test.
On Dec 11, 2012 8:44 PM, "bootstraponline" <notifications@github.com> wrote:

> In lib/gollum/frontend/app.rb:
>
> > @@ -142,25 +142,55 @@ def wiki_new
> >        end
> >      end
> >
> > +    post '/rename/*' do
> > +      wikip     = wiki_page(params[:splat].first)
> > +      return if wikip.nil?
> > +      wiki      = wikip.wiki
> > +      page      = wiki.paged(wikip.name, wikip.path, exact = true)
>
> return if page.nil? - the page might not exist
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/github/gollum/pull/598/files#r2387981>.
>
>
Why is this better than just exploding on the token? When would this actually be needed in practice?
`flat_css_dict` лучше не использовать. Сейчас в этом файле есть закешированный результат выполнения этой функции: https://github.com/hayaku/hayaku/blob/dbea73afd0e35f21d9d26438f154ddfe3c2fdf1d/core/templates.py#L14
Сделано так потому что flat_css_dict при каждом запуске читал файл css-dict.txt. На тот случай если пользователь его поменял. Когда весь код переехал в директорию core, оказалось что пути у файлов теряются и читать больше не получится. По этому ALL_CSS_DICT создаётся при загрузке sublime-text, когда пути ещёе не нарушены.
Вот эту строку надо исправить.
Все остальные замечания - к сведению. Они сами исправятся с течением времени.
just write the classnames here, there are only a few.
This is a terrible error message that provides no actionable information for the user.
Good point. The comment does not give an answer to this question. So here it is: This macro is only used to allow the usual `funcPtr(arg1, ..., argN)` syntax for a funcPtr of type FunctionHandle. Search for "BOOST_PP_REPEAT" in files AnyType_*.hpp.
please…
why an ivar in the header?
it is private and should be in impl IMO
since the other clauses completely cover the expected return values of equery, this is not needed. Better to crash with bad match closer to the source.
Ligne peut être a supprimer non?
Do we have a ticket for this somewhere? Either in our repo or in Basho's? The `value = ''` followed immediately by `value = 'None'` with little context is a bit of a WAT and I can see this easily being re-factored out by accident by people who don't know the full story?
The ``this`` reference contains keys passed from the parent component and they represent the current container's context. The ``ComponentHelper`` class only takes this context and uses it to render the component. It doesn't modify properties.
same thing as above ...
This file showed its guts to the world and exposed some globals. Just enclosed over with a self executing function to protect from that.
Again we can probably just break from the loop when we hit the newline.
Could you reduce code duplication inside this function by deferring to a helper function which can deal with multiple types? I realise this may be tricky to do in C unless you were using `void` pointers instead of typed pointers.
I changed this to be consistent with the rest of the tutorial, but I wonder if both the text and the code should be changed to `http://localhost:6543/edit_page/FrontPage` so that the edit page URL has the same {action}/{subject} form as the add page URL.
This will kill the ability to having a computed value as a BOMO's primaryKey value. We should make sure to take this functionality out of any other places. While I can't find any specifically, the way that `_mapIdentities` takes in a BOMO and then evals `id = record.get('id')` suggests this functionality to still exist.

Shopify's theme editing, and specifically the `Asset` model, currently relies on this functionality. @nciagra and I have agreed on removing this functionality from Batman; however this please not that this will be a breaking change for Shopify 2. *Sorry non-Shopify readers for the slightly off topic comment.*
+1 math. Might CONSTANT this though
I agree and come to the same conclusion. Having a Menu object that isn't backed by an HTML or native menu would make the implementation complex and it's not useful. Also, having separate insert functions makes adding menus more verbose.

Removing that comment.

-----Original Message-----
From: Narciso Jaramillo [mailto:reply@reply.github.com] 
Sent: Friday, May 18, 2012 9:29 AM
To: Ty Voliter
Subject: Re: [brackets] Menu API Proposal (for review only) (#911)

> +     * @param {string} menuItemId
> +     * @return {MenuItem}
> +     */
> +    function  getMenuItem(id)
> +
> +    /**
> +     * @param {!string} text displayed in menu 
> +     * @param {!string} id
> +     * @param {?Object.<relativeId: string, relativePos: string>} position 
> +     *      relative position can be: "first", "last", "after", or "before". relativeID is required for "before" and "after"
> +     * 
> +     * @return {Menu}
> +     */
> +    function createMenu(text, id, relativeMenuID)
> +
> +    // Separate creation from insertion

I'm not sure we should separate creation from insertion, as when we get to native menus it might be tricky to manage menu objects that don't actually live in a menu. It's been awhile since I've done Windows native menu stuff, and I've never done Cocoa, so maybe this isn't an issue, but I could imagine that depending on the API there might be no actual "object" representing a menu that you can get a handle to; or if there is, we'd have to then potentially deal with maintaining the lifetime of that object relative to the JS proxy object. It's probably safer to treat the JS proxy objects as loosely bound--i.e., they're just descriptors rather than actual handles to some underlying menu object. You could still do that with creation and insertion separated, but then you have to have a notion of whether this object actually refers to a real menu item or one that hasn't been created yet.

Anyway, a long-winded comment to basically say "let's not separate the two until we know we need to" :)

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/911/files#r846232
alignment issue with equal signs
Typo: missing "with"
No need to explicitly say this -- just leave off the `@param` line entirely.
Or, alternatively, since you're already passing the `functionName` into `_getOffsets()` anyway, perhaps you could change that to `_getOffsetsForFunction()` and have it do the filtering instead, so you don't have to cons up a new list of docEntries.
of course it fails. If you use VALUE_NONE, it means that the option does not accept any value
stylistically, i'd prefer if this was indented the same amount as the code, and also if you just had { ...  } or something instead of repeating the same 5 lines twice.
Have you not read installation documentation for push server? Or have you not listened at class? I showed this and explained.
This is not good. You have to retrieve URL from urls.py. Not having this defined again here. Then if user changes urls.py, they will have to remember to change settings file too? DRY!
I'm using 1.9.3 all the time and don't have any problems.
Can you give example with some stacktrace when this fails?
remind me when you review the AWS S3 stuff that we have to add more info here...
It looks like you can get away with both this variable and the declaration of mediaContainer in the function parameters.
Why does this need the anonymous function execution? Does `popcorn` fall out of scope somehow?
Do we need an empty function event for some reason?
Mind storing `Math.pow( 10, accuracy - 1 )` in a variable so we don't have to do it twice here
Please change this to "Open Sans", "Helvetica Neue", sans-serif
We can, but the closure compiler will raise
```ERROR - variable console is undeclared```
Very good. I wasn't sure what the preference would be on this.
Should it be `"`command -v python` /usr/bin/python /usr/bin/python2"` ?

I thought some users may use `/usr/local/bin/python` and more to instead of
linux distribution provided python.

2012/12/30 Saúl Ibarra Corretgé <notifications@github.com>

> `command -v python`
Can we remove this code?
probably shouldn't be calling `.get` on the Option
let's stop smushing stuff into one line.  look at rails code; they don't do this.
Like this (not tested)
```javascript
  $(".confirm").click(function() {
      bootbox.confirm("Deseja mesmo remover?", function(result) {
 	 if (result) {
           location.href = this.href;
 	 }
    });
});
```
And add the "confirm" class to the link.
I agree about the inconsistency, but at least, I would suggest to solve it as a separate BZ.
Yes. Original line was failing when params[:organization] is nil, I had an issue in tests. I left the change for code not to raise any errors. Using unless and adding #nil? at the end felt like an overhead. Results are the same.
You can change this to something like:

Pool.index.import cp_pools

This allows the model to worry about all the configuration and what not, let the model do the work :)
Instead made noticeArray a property of the notices object.  Putting noticeArray in the KT namespace caused jammit to crash.
I don't know if I'd call it a convention. A convention to me is more of a stylistic choice rather than something that could actually cause problems.
I'm not sure that the info/list is appropriate here.  Basically history lists a bunch of jobs.  history_tasks --job_id=1  lists the tasks for those jobs.  So its not that history_tasks is giving you just a little more information, its giving you completely different information.
Yeah, probably not a catch I would find in the merge.
Licenses missing.
This is *not* JSON, just pointing that out :wink:
It's only arbitrary ASCII formats though, so I put it at the end of the ASCII section. I should rename to ``Arbitrary ASCII formats``.
I think this close parenthesis is in the wrong place?
what happens if we put larger number to the begin field?
Maybe add some tests for service_up/3?
I'm aware you used it, I'm saying I don't know why you did. It affects the markup of all our forms and is something Zach and Max should decide. `simple_form` is nice, but let's let them decide if they want it before we start adding more dependencies. Just use the basic Rails form stuff for now.
Indent this properly
Is there a reason this is no longer needed?
Currently pwalletMain->RegisterWithHub(phub) is called from init.cpp, and I kinda like that design.  That said, I did go ahead and make the callback virtual functions protected.
need to change above documentation comment
We finally decided to split it. See 91de801

The issue was that we had to use the container to access configuration when the modules were dynamically registered in FederatedLogin on PreAppStart. Apparently when using `DynamicModuleUtility.RegisterModule` HttpModule.Init is being called in the context of PreAppStart and since we had the Bootstrapper setting up the container on PostAppStart it failed with `ArgumentNullException`
Then you're building the discussion incorrectly. It should have all its values defined before you save it..
oops, ta.
Lots of niggly style stuff here, it's all working OK anyway... :)

I prefer

```
unless ['acknowledgement', 'test'].include?(notification_type)
```

rather than multiple ==, as it only names the subject once, but it's a matter of taste I guess.
This project is public, I prefer that the test doesn't refer to things being managed by websys since external teams won't have access to websys.
I'm also not sure that magenta is the right place to put this dependency.  I'd rather you made bucket be a mandatory field in the json or loadable from a config file at deploy time or something than insist on the default in an open source project matching an internal code.
Travis test is failing on python 3, `walk` can't be imported on python 3.
Is is apparently directly in `os` now.
correct, I will add support here now.
I am wanting to do this, but I don't see how to register a listener.
This line is missing a ) symbol.
Use a protocol-relative URL so that it works over http and https.
`src="//maps.googleapis.com"`
I think you misunderstood James; he wants you to remove the needless views module and function.
"By apply diffs automaticaly" doesn't make sense to me.
`model+id` will be unique in the index. There will/can be duplicate ids. That seems ok, right?
I don't understand what this method is for or how it is supposed to be different from `get_detail_url`. It splits on the first "/" and then prepends a "/" - but since `get_detail_url` returns a path like `/api/v1/environment/4/`, the net impact of that is... nothing at all.
Correction: This really *needs* to be ``if (trigger_id) {``. Otherwise, when you select an empty option "-------" (or on page-load), ``trigger_id`` is undefined, which != "" and causes this block to be executed anyway. In JS, ``"" != undefined`` resolves as ``true``.
unused code (old open devtools experiment)
Should be "login silly" not "login **in** silly".
`is_string` may be simpler and faster
The second assertion was already present but is identical on the test that follows so the diff makes it look like the original second insertion belongs to the next test. I'm not sure why it was already there but I had no need to remove it and assumed that it was already present for a reason.
but not with https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Security/Core/Util/ClassUtils.php (only static methods without preventing the instantiation) or https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Security/Core/Util/StringUtils.php (final private constructor)
Please no! We need know the parent data class in the form subscribers.
@stof correct my fail but i like the idea from @stloyd
Yes, that what I fixed in the PR ^^
missing ``public`` keyword (same for next methods)
@bschussek did you get my comment before posting ?
I have a bit of an aversion to randomization in test suites. It seems slightly cleaner to me to use sequencing. Example of something similar I've done in other apps:

```ruby
  config.before(:each) do
    unless ENV['TDDIUM']
      GC.disable
    end
  end

  RESERVED_IVARS =  %w(@loaded_fixtures @test_passed @fixture_cache @method_name @_assertion_wrapped @_result)
  last_gc_run = Time.now

  config.after(:each) do
    (instance_variables - RESERVED_IVARS).each do |ivar|
      instance_variable_set(ivar, nil)
    end

    unless ENV['TDDIUM']
      if Time.now - last_gc_run > 1.0
        GC.enable
        GC.start
        last_gc_run = Time.now
      end
    end
  end
```
这个是开始写注释的时候写的，后来修改相应参数的时候就没改注释了。
The comment still seems broken relative to what the code is doing.

`dx` is the one being replaced here
that seems sane to me. let's do that.
worst case it should be n * 3 * 3
this should probably not be a pointer, since it makes no sense to have a Service with no ServiceInfo
Rooooh! :p
Should be "span" tags
I would like to keep this as much as close to content/tree(list), thus renaming ShowHidden to IgnoreVisibility.
Is this called mouseUp because there's already a `clickDelegate` which is used for handling clicks on the table headers? If that's the case, wouldn't it be better to use the same clickDelegate, and just call a method on that one instead of having to specify two separate delegates?
This means if you :reload again the state will be RUNNING. The only way this should be set to false is via the constructor, which gets invoked after a process restart.
how the hell did this end up here :)
If I leave out setting this  property, a classpath's jboss-ejb-client.properties IS picked up, at least for me. It seems that it somehow merges the information from property file with the information from runtime. If I for example change the port number in the provided jboss-ejb-client.properties to 8447, it tries to create an ejb receiver for both port 4447 and 8447 and I get an error in the log: 
Could not register a EJB receiver for connection to 127.0.0.1:8447: java.lang.RuntimeException: Operation failed with status WAITING

The test still passes because it will work with the 4447 port, but definitely it picks up the property file somehow.. am I doing something wrong, or is this a bug?
python 2.5 is so ancient  :(
smores2?
Remove R baseline result for DT.
You don't need to escape your own content.
Nit: gjslint will complain about the trailing comma.
ture -> true
On 19/06/2012 17:49, Timothy Guan-tin Chien wrote:
>> @@ -279,171 +279,215 @@
>>   
>>   // document.mozL10n
> I remembered that we are not going to move `mozL10n` to platform but rather have it work as a shared library for Gaia?

If we can move it that would be much better.
Yes, I moved them to `connectivity.js`, as what I comment there, we don't want it be lazy-loaded until wifi panel is clicked.
lol, will do it than ;)
Right, will give a better explanation.

Thanks!
the method name says it all
jajaj Neither for you nor for me, ret -> total
Can't this be defined in terms of SiteUrls? Like:

```csharp
public string SiteUrl
{
    get {   return SiteUrls[0]; }
}
```
Yeah, I was actually a bit surprised that `subject` wasn't already implemented in terms of `let` given how similar they are.
replace this with ```x.getInt(i)``` which does this same logic internally, but avoids the toString if the internal data is already an int (also note, strings are REALLY expensive compared to Ints, so for performance, you should avoid them).
Why do you need this? Just use `timeit` or `profile` instead.
Shouldn't that be something like that?  

     Delay = (int)TimeSpan.FromMinutes(DelayInMinutes).TotalMilliseconds,

It seems to me that the additional multiplication is not really that useful.
The prevailing style is to have a `do_test_blah`, and call that from multiple `test_blah_foo`s, rather than calling between `test_blah_foo`s.
What if `mode=="incremental"`?

Also, the error message could be made more useful (including the current mode/method). As an aside, the config error stuff doesn't report locations (which is a defect), so keep that in mind when wording the message..
`_(this)`
I will commit such change later, also.
It seems that I just removed it automatically.
The CRS class is available, for now I took the approach of sticking with DefaultGeographicCRS.WGS84 explicitly describing that we were checking with equals ignores metadata (and offering the examples of CRS.decode("CRS:84") and CRS.decode("EPSG:4326",true) <-- more explicit about the axis order)

Here is what that looks like:

    /**
     * Transforms the envelope from its current crs to {@link DefaultGeographicCRS#WGS84}. If the
     * specified envelope is already in WGS84, then it is returned unchanged.
     * <p>
     * The method {@link CRS#equalsIgnoreMetadata(Object, Object)} is used to compare the numeric values
     * and axis order (so {@code CRS.decode("CRS.84")} or {@code CRS.decode("4326",true)} 
     * provide an appropriate match).
     * @param envelope
     *            The envelope to transform.
     * @param crs
     *            The CRS the envelope is currently in.
     * @return The envelope transformed to be in {@link DefaultGeographicCRS#WGS84}.
     * @throws TransformException
     *             If at least one coordinate can't be transformed.
     */
If possible please move `require('tabs')` to the imports at the top. If not please submit a followup bug and put a comment pointing to it (this won't be compatible with ES.next modules).
Shouldn't `opts` be `options`? We reference the old `options` variable elsewhere in this function.
Good cleanup of dup variables.
that's cool; not sure if you need to credit noodletalk here though, unless that's useful in terms of documentation or something. If you want to give Edna credit, feel free to add that to the readme file!
Where does `PopupNotifications` come from?
(Use 3rd person declarative)
It seemed neater, fewer LOC.  Everything appears to run via the accessor, so `@root` being lazy looked ok to me.
This needs to be converted to the YARD `@yields` syntax
Don't know why I put the second argument (true) in there. This should be removed!
oh, and 'features'
let's use • instead of *
just because unicode is hawt
True, new coding standard :)
should cover $cAlias too
Why do this only in the last group?
Really throws Exception?
Il me semble qu'il y a une légère erreur de français dans cette phrase: 

    Il dispose de structures de données et haut niveau
you should remove this useless ``if`` entirely
Hmm, ok, but what not just method calls then?
-> `if ( localStorage.getItem( KEY ) ) {`
Eh, sorry that's how we do it in Haiku :-p
Hi beberlei,

Could you change to QuoteStrategy#getColumnName when you rabase the patch ?
mv S=.. also into pkg_setup
fix indentation (no tabs)
Definitely requires review. How often are events or headers larger than 64k? (Used 1000 instead of 1024, since I don't know what the table service uses).
Ah (thanks for clarifying)! Cool. :-)
can't answer your question, but var_export(assoc) was:

    array ( 
        'jsonrpc' => '2.0', 
        'id' => '31d7be69-9910-4036-b616-abf7b346a26d', 
        'result' => NULL, 
    )
Minor nitpick: It's usually better to put these decorative arrows in the CSS with an :after rule.

.share_twitter:after { content: " »"; }
I just made one https://bugzilla.mozilla.org/show_bug.cgi?id=761791
Seems like this should match the regex in:

https://hg.mozilla.org/qa/mozmill-automation/file/4d69652a6bfe/testrun_release.py#l143

pattern = re.compile(r'(?P<version>(?:\d+\.)+[^#\s]+)(?:#(?P<build_number>\d+))?')

IIRC, we did a fair amount of work here to make this everything from a #. version number through the equals without differentiating.

What you've done is good as far as it goes, but the next time we hit another special char we'll run into problems. The mistake here is relying on \w, which is very restrictive (alphanumeric + underscore).
https://webmademovies.lighthouseapp.com/projects/63272-popcornjs/tickets/1102-update-youtube-unit-tests
Should probably just set their state in the declaration.
I'm going to have to fix this part tomorrow

In the mean time the `start_replay` still works.
I think we can make this (and the others above and below it) a new style translation string, like link_to ts('Orphan Work'), {:controller => 'orphans', :action => 'new', :work_id => @work.id}
oh forgot to add the comment. Here you go. http://stackoverflow.com/questions/1447287/format-floats-with-standard-json-module
This one is no longer broken.
I'll sweep my code to make sure this is consistent.
That is pre-existing code just indented a new level. It's safe for the time being because in hosted there can only ever be one non-derived (base) pool, but it might need updating if we do some of the new models upcoming. I'm actually not sure what that would have to become to accommodate those but we'll have to deal with that in the future. I'll add a big warning there for now?
Comment on original line 2 (new line 3)
It seems a little weird that the authorization function also knows how to authenticate the client. We might want to move that up front a bit, and annotate the request explicitly with the client identity, rather than using ssl-client-cert. But it could be unnecessary complexity right now.
Seriously, he will die
Can we add some logging if this variable is true?
This only creates 10 comments.
With the new init.js files, do we still need a globally exposed serverTenant ?
Although it's not required to have semi-colons after function declarations I think it's still good-practice to add them.

<sub>Also, If we ever had parentheses after a declaration without semi-colons it might accidentally execute the function.</sub>
Formatting here and elsewhere
It's for all Scala projects, so ti can't be in `ScalaProject`. But `ScalaPlugin` is a better place.
Why not using a regex, so that the naming match is precise. WDYT?
Done, but now I need a reviewer... https://github.com/scala-ide/scala-ide-play2/pull/27  :)
Mark, let's talk about this feature some more. I think there might be a misunderstanding about it.
Something happened with my pom.xml when I fetched from voxelbox/voxelguest. It should be the same file though. No idea what happened.
we usually trail the dot '.' elsewhere in the app e.g.

	cats = campaignConfig.defaultCategories.
	concat
I don't like this method name.

I would expect
   <% this.WriteAssetTags("jquery") %> 
    => jquery

Not require jquery and then write all the tags.
The change here handles three things - the lowercase "last ditch" that used to be below, the ucfirst "last, last ditch" that was added after that to pick up drivers with a library() call, and now the loading of an extension for a driver library from the main libs dir. Example - Session is now in libraries/Session/Session.php, this would allow an extension as libraries/MY_Session.php. The point is for extensions of the old Session library to be applied to the new Session driver after an upgrade without requiring relocation (drop-in replacement). The flexibility would apply to any driver library.

I'll check the indentation, but I know github is funny about it sometimes - the same tabs result in a different spacing in the diffs here. I suspect you mean L921 above, which is a classic example of that.

I agree that the case-sensitive variation is not needed on Windows, so the second addition is superfluous there. In the case of extension not found, that would skip an extra file_exists() test on that platform.
My English is not very good and I'm not sure I could handle well with the documentation. I would be grateful if someone assist me with writing the text.
В Вашем случае, чтобы не писать дважды генератор, лучше использовать do while.
Окей Подправлю!
percent == 0 вполне нормальная ситуация и, как мне кажется, должна нормально обрабатываться.
Но по идее, мы не должны давать возможность в main вызывать метод createDNA.
Плюс, если я все таки напишу, что-то вроде 
        Cell *cellObj1 = [[Cell alloc] init];
        [cellObj1 createDNA:20];
это создаст всего лишь еще один массив на 20 элементов. Но при этом переменная DNALength не изменится и будет по прежнему равна 100.
Ключевое значение тут имеет версия компилятора, а не ОС. Однако, какой компилятор использует XCode я не знаю, поэтому условие отличия ОС в данном случае обоснованно влечет за собой возможность отличия версии компилятора. Не более того. 
Да, вариант с объявлением переменной внутри for возможен, и мне было сложно удержаться от его использования. Я выбрал переносимость, при этом расход памяти, быстродействие, скорость компиляции никак не пострадали. Считаю такое решение скорее достоинством чем недостатком.
Добавил конструкцию
Не вижу проверки на X>=0,X<=100. Х - проценты, помните ведь?
Зачем выполнять написанный ниже код, если mutatePercent == 0 ?
This line is very long ( > 80char). Could you split it into several line with the correct indentation ?
удали плиз закомменченный код