labofsahil/github-event-dataset-2012 huggingface dataset:
These should really be rewritten to do `print_lpad` and `print_rpad` and then call `print_to_string` the way other things do. Making all these intermediate strings is a shitty way to do it. We've generally committed to doing things that way, which I think is good, but then we will want to make sure that `print_to_string` is as fast as humanly possible.
*Pouce en l'air!

2012/2/13 Olivier Hoarau <
reply@reply.github.com
>

> J'aime :D
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Olwaro/Web-loto/commit/8c2bd8b6562d927f639b78ea2afe238d63d0d183#commitcomment-961307
>



-- 
Ludovic LEFEBVRE.
Elve 1re anne ENSC.
@Th0ar @logicmd 雏形不是不需要审核吗
Testing. Just seeing what this does.
Should be up near line 1 with other django imports.
Yeah, didn't want to take the time to figure out what was causing the Request class to be "reset". Good enough for now.
I knew it! All seeds are 42 :D.
Good catch on this bug!  I'm afraid this only shifts the problem, though -- rules set up with $router->request() rather than $router->METHOD() won't be pulled from the cache this way.  I'll race you to the fix ;-)
Ah... Singleton's value was [elem] and now it's just elem, which breaks nonempty(); Singleton is a sequence, even if it's a 1-element sequence, so its value should be an array.

I'm pushing a fix which should be ready by the time you read this.
`debug_settings.py` defines `STATIC_DOC_ROOT`, and the `README` describes that `debug_settings.py` should be used during development. Although I did made an error in the documentation that might have caused your problem: I have now fixed this in 4b4582255f29baa89721b40262baf7a98e4f68bc
Hi, Good work.
Can you implement character ban ?
эта константа логически — часть класса, поэтому лучше сделать полем ArrayList.
lots of new lines there mate
Seems like an extra :A in app/controllers/services_controller.rb
So here instead of a string, it would be a Separator.
I was getting mount failures on NFSv3 - mount would return a filehandle, FSINFO with the same filehandle will fail
That is much better :)
it scares me that we're putting this in `ie.css` because we'll probably forget about it
Nice! Maybe we should switch to lein...
Apologies for jumping in too late, but I think the changes to the line above break the prior logic of the code.

As I understand it, the logic is follows:

1.   apply the property from 'override', if defined there;
1.   if neither 'base' nor 'override' had the property, populate from the 'default'.

The line above should contain instead:

```
if ( def != null && ( result.getGroupId() == null || result.getGroupId() < 0 ) )
```
wohoo.. maybe this will fix #103
FYI this commit requires my rewriter.coffee changes, seen here: https://github.com/jashkenas/coffee-script/pull/2017
Why? This task is useful, no?
erhserhserhsdhfhdfhh
No backtrace still unfortunately.
не очень поянтно, зачем фикстуры в стандартных тестах добавились (мы ведь будем работать с RSpec)
See the notes in Pivotal I added to "Add option to disable user profile".


Martin Lucas-Smith **           www.lucas-smith.co.uk
Cambridge          **


On Thu, 23 Feb 2012, Andrew France wrote:

> Can I ask what the reason for that is?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cyclestreets/toolkit/commit/08795172fbfd8ad3c9bb5839766ba37952ea687d#commitcomment-1002138
>
startsida -
I think you can add !important to your external stylesheet and override the inline styles?
节操掉了一地。。。。
嗯，我也在想办法，Linux 只能用 so 文件？
Nope, I haven't tested with Python yet.
My editor deletes trailing white spaces automatically, this is the only change.
f!!! man Adrian is going to paradise for sure!

who would debug and fix such thing for windows? i guess this is the case where it becomes a matter of honror :p

great work man
Indeed that's a mistake, too many thing at the same time. Thanks.
https://github.com/GobTrans/gobtrans-api/commit/9130463f47add7bad6c457f14f2cb66c36f47903
Plz wrap long lines like this one.
"Probably" worries me. Do we need to add a method/exception to the server to allow you to detect pyramids? (Sorry if you get this twice; looks like the comment got lost)
Do not double single quotes on unformatted strings
String formattedstring = String.format("this text shall have single quotes doubled that''s it like this %s","''");
String plainstring = "This string isn't formatted. It must use single quotes as-is!";
Bump - you don't have a messaging option on your user so I thought I'd comment here again to see if you're still interested - as we're officially entering milestone 2 - persistence :-)

We actually have items in our issue tracking system now - including some assigned to this milestone at https://github.com/MovingBlocks/Terasology/issues?milestone=3&state=open - there's even a specific one for persisting the player's start location, hint hint :D

https://github.com/MovingBlocks/Terasology/issues/78

Drop by the forums sometime and let me know! http://board.movingblocks.net/index.php
Interesting as I use an answer logging table on another system but is removed from the OpenSource version. I'm working on developing version 2 of Simply Poll so I can leave this answer logging in if you feel it will be useful.

Thanks for the suggestion.
(result * multiplier) -- spacing
Either wrap logging calls with if(log.isInfoEnabled()) or use the formatting variants to avoid unnecessary string expansion
There really should be a reloadPoperties() function instead of calling queryProperties() for its hidden side-effects.
Don't know how the interpreter accepted this. Weird.
Shouldn't this be a empty action since the logging is already done be NSB before OnCriticalError is called?
I really dont want to have to record a video and post it to try to prove this is wrong...
[Err] UPDATE `quest_template` SET `CompleteEmote`=14 WHERE `entry`=1246;
Kandera for dev i tell you she needs to be one!!
Should probably be {'a': {'b': {'c': 1, 'd': 2}}, **'d': 3**}.
Let me add that I also appreciate this clarification.
Thanks Eddie, that looks good. 

The only thing I would like to change are your else blocks, they should be on the same line as the closing } from the if (http://docs.jquery.com/JQuery_Core_Style_Guidelines#Blocks)
Can you please add this to: http://scikit-learn.org/dev/developers/utilities.html#developers-utils
Please put a description of what you did into the first line of your commit message. It makes things easier for other people reading your commits.
@normann Yay, wanted to do that as well, thanks! This should read removeComponentByType() though, to match getComponentByType().
These minor correction cause NullPointerExceptions because you did not changed sockchannel in line 101.

Making such changes without a refactoring tool is risky...
You use a simple text editor, don't you? 

I'd suggest not to change case-sensitivity. Currently there should not be any variables with upper letters in it.
This needs to be reapplied to 'fault_in_pages_readable' instead of 'fault_in_pages_writeable' ; will do this later.
Howdy,

Our project was awarded Rubymine License Keys to all contributors of wepay-rails from Jetbrains. Are you interested?

Thanks,

Adam
setg VERBOSE true
...
>> framework.datastore['VERBOSE']
=> "true"

you mean that we have to add a else condition in the following way?

else
        verbose = "false"
end

so with this we set verbse if it is set to true with setg, otherwise it is always false and we dont print the status information ...
Why's this file named `slider.js`? It's code is for tabs.
Hmm... we still use blogs_posts_comments_path here. Let's make ../:id/comments to other items as well.
Зойчем выпилили получение постформы?
Енто необходимо для досок с оэкаки (iichan.ru/o, 0chan.ru/d), ибо там постформы нема.
В самом конце doChanges идет аякс-запрос на получение.
and hover boards!
Shouldn't `id=$searchID` be removed here, too?
Hey thanks for detailed explanation, I generally don't see the alert. 
I think the best way for sublime to handle this, is to provide some type of preference to dismiss the alert for selected plug-ins or something like that.

Regards!
That shouldn't be too hard to switch, I mostly used the css width which ends up being used instead of size.
Looks like some diffs from a merge conflict got checked in. See activity_tags.py.
Yes, I think so, too. This is also something which we still might add later on. I originally thought JAX-RS would benefit from that due to the discussions about constraints on setter parameters, but they also changed to annotating getters.
hey hey.. dit rewrite ook alle assets. Wel getest? :P
He he! Thought that you would notice!
Jo, aby bylo vidět, že se pracuje s EntityManagerem. To, že to je schované uvnitř jiné metody ničemu nepomáhá, viz definice createQueryBuilder v Doctrine\ORM\EntityRepository :

return $this->_em->createQueryBuilder()

nicméně v praxi je samozřejmě lepší psát to druhé.
Looks like this modification was included in the pull request by accident. (I think there's another bug entry somewhere that includes requests for this kind of option.)
Why don't we have a computed ```serialVersionUID``` here instead of ```1L``` ?
In fact, based on `TicketRegistry`'s docs:

>@return collection of tickets currently stored in the registry. Tickets might or might not be valid i.e. expired.

So getKeysNoDuplicateCheck() might be the better option, if needed really.  We could also expose an option that allows the deployer to determine this behavior.
Not to be even more of a pain, but what you're describing sounds like we need a shared injected instance.  Am I hearing you wrong?
I don't like the module or class variable approach because they are static, and don't allow you to delay initialization (without a lot of messy code).  Testing a singleton is also a lot easier then testing a static.

The `__new__` method would work, but it does make it less obvious that you're actually getting a singleton, and not a new instance.  Maybe it's my java background that makes me like the explicit `get_instance()`

It's important to restrict this class to a single instance because it's important for objects which call `add()` with a parent.  If there were more then a single instance, the parent could be in a different instance.

I plan on doing a lot more work to this event logging module in 0.6.  I'd like to make it more like standard logging where you can just get an event recorder from a string, and the parent relationship is derived from that string.  I think that should greatly reduce the code in this module and make the event logging more readable as well.  I create #142 for this issue.
Yeah, but it should be fine now right?
After discussing with Roland, this will be changed to just disallow the Router to run on the BalancingDispatcher (ticket #2136), so the doc is valid again.
s"..."
Lazy load caches.  We are almost reduced to only the Card.cache anyway.
nested def* considered harmful - what exactly are you trying to do here?
Thanks @tobes, a link to the built page would be great.

I tried pulling in something about the toolkit using something like

    .. autoattribute: ckan.lib.toolkit.toolkit.contents

But that wouldn't pull out the docstrings of the relevant functions anyway.
That, or split them up into two renderers, but I prefer passing it in and keeping a single cumulative state across the entire display.
Perhaps more of a mention of it's responsibilities rather than restating it's class name.
Do you mean "A forced unbind"?
Should be val not vars.

Also not sure this class should be public.
One major drawback of doing it that way is that we have to (re)move this code out of the function then:
..
  CStdString strPath2(strPath);

  if (URIUtils::IsStack(strPath))
    strPath2 = XFILE::CStackDirectory::GetFirstStackedFile(strPath);

  CURL url(strPath2);
...
Is that really what we want since it forces us to add the code for each call to it?
I think I see the point of @MustOverride but in general a method must reflect a valid contract at the level of abstraction of the class. If the method is a helper it should be named differently. get{Append}MemorySize() ?
@dlsniper if you do a benchmark calling ``getSource`` several times for the same template, you are not reflecting the real use of the loader. The Twig_Environement will never load the same template twice as it check first if the compiled class exists.
@Fustrate what is `none` supposed to mean? There is no such thing in PHP (just as `is_empty`) ...
Ok, but isn't `USE_VARS` redundant? Wouldn't you assume that the existence of `this.vars` implies you want to use `this.vars` in the first place?
This is the initial `make` call. At that point, `web/` does not exist (or is erased if it does).
I added code to remove `meta/` if it exists.

On the other hand, if `web/meta/` doesn't exist, something is seriously wrong.
We should get notified.
(Obviously, that is true after the garden/plugs pull.)
This header should not be copied into the framework.
For clarity, this block should be set on initialization (not when the style is changed), and can read from `weakSelf.activityIndicatorStyle` instead of closing over the argument.
And we don't need to check `frame_len_` there since `offset_` is definitely at the frame end or after it (see line 777)
Set AVIOContext options. This is added because there were no previous AVIOContext options.
TYPO: missing . on end of "etc"
Isn't this missing a few types? What happens for bit lengths bigger than 64? (forgive me if this should be apparent!)
getEscapeHtmlAttrHelper isn't in any of these view helpers
огромный метод, разбить на несколько
лучше добавить префикс QtCore/
should be p.user, not p.  If you'll commit that update I'll go ahead and merge.  Thanks for this btw
Same here.

```ruby
if entry
  get_entry_value(entry, name, options)
else
  save_block_result_to_cache(name, options) { |name| yield name }
end
```
I think a newline here would increase readability, on first glance I thought you had messed up the indentation.
Comments. All public methods should be documented. In the cache method is not the proper place to document they. Remove the `Conditional caching` section from the `cache` method and explain each method.
You could use `assert_nil` for these two.
cc @jeremyevans
wouldn’t help, as discussed earlier: they will stay the same numbers, meaning a comment is the best that can be done, and then I’d prefer to have them in-line so people don’t need to go chasing them
beeing -> being
for what measure of 'all'? any method that calls shift can be considered a cps method ...
\*cough\* @ness01 \*cough\*
I've added the comma to the compute_known_facts function
Having a comma before "but" feels more natural to me and is supported by Google searches, but again, feel free to disregard.
why not do this?

```python
def kinetic_energy(frame, *args):
```

Then the user doesn't have to put anything in a list as an extra step. They call:

```python
ke = kinetic_energy(N, particle1, body2)

 And if the user happens to have particles and bodies stored is some sort of sequence they can simply use this notation when calling:

```python
bodies = (particle1, body2)
ke = kinetic_energy(N, *bodies)
```

This seems like less overhead and simpler and it also avoides having to error check for a list with is problematic because there is nothing wrong with supplying other types of sequences like a tuple.
I will change this to !=.  Thanks for noticing It is on its way out apparently.
Please remove debugging code.
as a matter of fact, this line is no longer necessary because all chunk options have been evaluated before, including `cache.extra`
From 1.2.9 to 1.3.3-dev the patch solves the problem. Nice work!
This message is iOS 5 and above only. If run on an iOS 4.3 device, this will crash horribly. Are we only targeting 5.0 and above now?
Don't make this closure here.
The parameters section is strictly intended as an in-order list of the accepted parameters.  Given that this is an ``(*args, **kwargs)`` function, it might be better to format this instead as a list of allowed *combinations* (and omit the parameters section). e.g.,
```
... created on its own.

The following pairs of keywords are accepted.  All keywords must be a `~astropy.coordinates.Angle`, `str`, `float`, or `int`.

* (`ra`, `dec`) : A right ascension and declination value.  Result is an `ICRSCoordinates` object.
* (`l`, `b`) : Galactic longitude and latitude.  Result is a `GalacticCoordinates` object.
* (`az`, `el`) : An azimuth and elevation.  Result is an `HorizontalCoordinates` object.

The `units` keyword (An `~astropy.units.Unit`, `str`, or `tuple`) must be provided for each angle. If the unit value can be determined from the Angle objects directly, `unit` does not need to be specified.  If `unit` is a single value, it is applied to both of the given angles. If one angle requires a unit and the other does not, use `None` as a placeholder.

```

You should also definitely include an "Examples" section here, particularly to show how `unit` works.
nit: you don't need else if if returns :)
``distance value`` is not redundant here because only the values in the distance field are multiplied
the foo section.
replica set name
Should be refactored into a function.
After reading the ticket again, I don't see why this change should be made.
Requirement for ascraeus is php 5.3.2, therefore this won't work.

https://www.phpbb.com/community/viewtopic.php?f=14&t=2152375
Drop "If the topic no longer exist". This was copy pasted from elsewhere and does not make sense here.
html tags should be lowercase.
Should be marked `@deprecated - Use generate_template_pagination` rather then outright removed. Deleting this function will break backward compatibility.
This change looks unrelated too.
@dhruvgoel92 one is on split_words one on split_*key*words, so be careful!
Multiple sentences in docblocks need to be separated by periods.
we don't use @ api
You saw that this function returns a reference?
What requires checking?
Oops yeah.
What if audio should actually be playing at this point? Is that handled elsewhere?
Maybe even use version here, too - so that name and actual package do not get out of sync on the next update
Mistake: remove this from Registration! This code was just for testing. it should only be in Screener.
Can be vars -- @nathanleiby , best practice for this? Should we always use var when we have a local variable?
Better to name this column provider_id rather than provider, as it's only the id that gets stored here
This line should be presevered
Explain or remove commented code block.
Don't we need the same kind of patch below when bd.scale() <= 12 but still bd.precision() > 38 due to excess trailing zeroes?
You need to add *additional* check for d.model.type==DeviceType.blade_server.id, and only compute chassis_price if it's true
Never commit unresolved conflict!
Maybe put each MenuItem on separate line?
Why not a single ``if user and IloHost...`` statement?
Code style:

```js
    return Q.all(promise)
        .then(...)
```
`/tests\.js$/`
What about DateField and TimeField?
kidding back.
I'm very concerned about the cost of an additional `setTimeout` for every animation tick. But if we're going to incur it, why not move the `fxNow ||` that precedes calls to `createFxNow` inside of that function instead of creating a new one?
I added detailed query plans for both versions. You can study at http://jira.madlib.net/browse/MADLIB-619.
I don't get why this is LEFT OUTER JOIN.  Both of arg and state are assumed to be 1 row?
It's fairly easy to add proper collation support, so I think we should do it. Otherwise, the same issue remains to exist, even if its surface may have reduced.
I don't see you put NULL elements in the array, as you designed it like array[2n] = value[n] and array[2n+1] = isnull[n].
You need to give these dispatch uids. Otherwise if this code executes multiple times, then it registers multiple times. Since the code executes at module import time, that's possible.

https://docs.djangoproject.com/en/dev/topics/signals/#preventing-duplicate-signals
`&raquo;` definitely needs to go through gettext, in RTL languages they'll probably want to switch it for `&laquo;` at least. This one is tougher but I guess better to err on the side of localizability.

In this case, we might want to add localizer comments, though, so folks have some idea what the context is. E.g.

```jinja
{# L10n: Symbol for "all" date range. #}
{{ date_range_button(None, _('&infin;')) }}
```
Specifying /usr/local wouldn't work for users who install into non-default prefixes.
We now have a policy of never using an unseeded random generator. We do:
<pre>
rng = np.random.RandomState(0)
data = rng.randint(0, 10, shape)
<pre>
> So I can define {DAV:}unbind in my getACL method?

>> If you override 'getSupportedPrivileges' you can create custom structures.

> Which is not needed because the default already has representations for finer permissions than just read-only and read-write?

The default structure marks '{DAV}unbind' as abstract, and contained within '{DAV:}write. It's better to make sure that '{DAV:}unbind' is not marked as abstract. It will work correctly anyway, but it's a violation of the RFC.

>> Not saying my code is awesome, that statement referred to the RFC ;)

> You know it is :-D

When you work on the same codebase for 5 years, I only see problems and things I wish I'd have done better. I'd definitely be interested in some constructive criticism from an external person such as yourself. It's hard to stay objective about this stuff.
'Ready to get learning?!' will be used as the subject when a new user registers. 'Greetings from P2PU. Ready to get learning?' will be used when an existing user need to reconfirm their email (if they changed their email address). I think 'Greetings from P2PU. Ready to get learning?' should indicate that, maybe it should read something like: 'Greetings from P2PU. Please confirm your email address?'
Should we perhaps just pass in an instance of FakeRedis instead of a string? Especially if we want to share a FakeRedis between different bits of a Vumi test?
yes this is confusing...you are using one statement var in  the first line and then a new one ...a mixing is really bad
hrm. this is odd. Given that the body of the `if` is setting `l.domain_override`, the existing behavior may be correct, but I'm not sure where `link` is defined.
No need for a semicolon in the `onclick`.
I would suggest moving this into a private method named something like load_defaults or something clear. You can then move the comment to the method's summary.
invalid signal
Any particular reason to choose 30 here? It seems like we could handle at least 100, since MAX_PATH on Windows is 260.
Can we use `java.util.concurrent.TimeUnit` do do these convertions? Maybe we can even get rid of the methods completely?
Can you take over, David? I will be leaving for a week and I have a pile of stuff to do. I may get back to it after I come back if it's still not done.
maybe `allowEventCreation` or something
Well, it might at least be wise to limit the number of partions we query at a given point in time - maybe forEachLimit to ensure we're not using up a whole bunch of db pool items at once?
On second thought, do you need to check if it's an object at all if you're checking if it's an array?
Why do you need !important here? What's the overriding rule?

Using a more specific selector is usually a better solution than !important as far as future development and maintenance.
Would be helpful to show the default here too ``e.g. C:\Program Files (x86)\Brackets``
Yes, that sounds like the best solution.
Haha, well, if it performed well we would love to use it. Floats and margins make me nauseous.
Nice to allow enter keys to create new lines.
again same question here as above in the bar
not a big deal but i still prefer get_id here, for the reasons i mentioned earlier. i also think it's just better to be consistent and pretty sure we use get_id almost everywhere else.
These should be formatted with a continuation indent of 8 spaces.
Adressed in 9ab5d382. Thanks for the hint.
OK. I'll add calls to marktr in dedicated useless methods in my enums.
implement -> Implement
Indeed! Thank you.
Mind adding a comment here to explain what this file is used for
Does IE still need this?
5px is too much here, take it down to 1 or 2 px. This will solve your problems of the buttons getting cut off
Is there an instance where this might not pass? It looks like compiledLayout would be undefined in the return statement at the end of this function if this happened.
Nuke the derp.
Remove the "Check console compatability" comment above and replace it with this comment
应该是清理 cycle ?
I forgot to mention, SELINUX must be disabled (or permissive) currently. So selinux is not the cause.
It's not in converge-ui and the above works in IE8
I wasn't able to entirely test the fix to 1091 via a unit test due to how our current framework is setup. Reason being is we can't modify the KeepAlive server value in run time via JS. Therefore I wrote a small test to test when a user attempts to set the KeepAlive to a negative value.
This hunk is not relevant to the NUL byte support.
maybe the `1` should be left off here, since that's the default anyway?  Then people will know that they can do this to get the "simplest" conversion factor...
`from X import *` allowed / wise in astropy library code?
Having the unit be a property means that it can't be used with equivalencies.  What if the user wants to convert `nm` to `Hz` using a spectral equivalency?
The `dl` is only in private functions (at least that's what I intended), mostly out of laziness :)  I'll go ahead and adjust them all to `download`
This is the % the queue is filled.
Right, my mistake. I changed this in my ultraprune branch, however.
1) bitcoin.org is vendor-neutral, and shouldn't contain any Bitcoin-Qt specific stuff any more than specific wiki/forums/etc
2) For automated updates, this should point to a branch-specific file such as latest-0.6.txt or similar; another line (or file?) can be used to recommend upgrading across branches
Why is this only done when `$options['modelKey']` is not set?
And items.itemAt(j) or items.get(j)
please add the Doctrine license header
On 8/11/12 12:57 PM, Jesse Reynolds wrote:
> In lib/flapjack/api.rb:
>
>> @@ -1,388 +0,0 @@
>
> It's a pity we're losing history here, i guess because 'git mv' was not
> used?
>

git mv only preserves history if you mv without changing, which is 
impossible to do without breaking builds. You can use --follow in git 
log, but that's not ideal either.
So does this mean that the base implementation doesn't have a data publisher?  I guess that makes sense.
Jeez Russ, great points as always. I've encountered this problem in the past; now I remember why we cannot export a function that returns a `git_tree_entry`.

We need to work around this. Put your thinking cap, @arrbee... How about pooling the memory for the tree entries instead of making them depend on the trees?
This is where `@constructs` can go and then public interfaces can be documented.
No spaces between the equals and its operands
Nit: Remove this blank line to get a 4 line block for each test.
Right. I guess OSX and Red Hat.
I could for consistency. I was kind of on the fence about it because that view really handles all of the steps. Let me know what you think after you read through the view changes.
<purism>if not all implementors need to implement this, it should just be ``pass``.</purism>
I'd be surprised if this works in all environments. I'd use argparse or something similar
This should probably be "GRAPHICS_DECODERS_TGA_H".
use `Class<?>` here. Otherwise somebody might accidentally pass a parameterized type, and that'll never work in comparison against `getDeclaringClass()`.
It should return ``null``, not ``false`` IMO
What about renaming to `addLogger`?
add a private constructor?
`method_exists` seems good enough to me.
There seems to be a `}` too much in the regex, doesn't it?
意味なくないっすか??
I know. I was being lazy! Will fix that.
Actually yes, the problem is that HTML_safe + not_HTML_safe => not_HTML_safe even though the not_HTML_safe string is empty string.

Adding empty string to HTML safe string discards the HTML safe flag.
And to answer your other question, Dan, the asterisk was there in the text versions of the email. I'm not crazy about it, and considered removing, but I assume someone along the way must have requested it. The good news is now that we have a partial if we do remove it we only have to do it once :)
This comment taught me nothing.
quotation url yade nare
hatta age space nadasht
They are significant in that we may have to use them later on, for things such as upgrades. We also will need to do some code signing to get a better UAC prompt than we have right now. I've been planning on looking into that but just haven't gotten to it yet.
good catch on the requires

It seemed simpler just because there are no optional params, and for the distributor one, i would have to name 'distributor_id'  'id'  which would seem weird.  

For the unit_search one, it might make sense for consistency, but it would be more code for something
Would you mind reverting this change. Done in #104.
You actually don't want the variants here, just the flags. Variants themselves are almost never referred to in code, they only modify flags. So you should just do getAllFlags and create a node for each.
maybe a little more info that it's now no longer necessary and will be the default. So people don't freak out too much when they read this :D
We still should only add hosts if they have VMs in the case where we are filtering. So really the only needed change was to line 133: `if roles and vms:`
Non-leaf Routes can have `route` properties too.
Yes, I think it's an improvement.
But why not make drop_handler a list, drop_handlers and have two default drop handlers:

def _tab_drop_handler(self, event):
    if (isinstance(event.mimeData(), PyMimeData) 
        and isinstance(event.mimeData().instance(), TabDragObject)):
        # etc

def _local_file_drop_handler(self, event):
   if event.mimeData().hasUrls():
          for url in event.mimeData().urls():
                file_path = url.toLocalFile()
                if file_path.endswith(tuple(self.editor_area.file_drop_extensions)):
                      # etc

In this way, you make it completely customizable.
Good point, I'll change the setContextID method to check for a security manager and avoid unnecessary use of a privileged action to set the context.
BTW, I added constructors to ModelNode so now you can just say "new ModelNode(false)"
I think this interface should be named ResourceDefinitionBuilder. The distinction between ResourceDefinition and Resource is easy for people to get confused so we should be anal about the names.
This makes me pretty tempted to say stick with the "attribute of ModelType.LIST with elements of complex ModelType.OBJECT" approach. If you remove a metric in the middle, say #2, then restart the server, the resource name for metric-3 will become metric-2.
这个是log4j需要配置咧appender，就是一个log器，他负责输出你需要咧log，比如有个是sout，就是一个appender，输出到控制台，另外一个是file，就是纪录文件，你还可以自定义其他类型咧appender。
root就是最顶层咧总配置，比如level是info，他咧appender就全部打info咧日志哦。即使顶层配置。


--  
zhoudi
已使用 Sparrow (http://www.sparrowmailapp.com/?sig)


在 2012年11月21日星期三，下午7:58，longhengyu 写道：

> In grails-app/conf/Config.groovy:
> > @@ -71,11 +73,17 @@ environments { > > // log4j configuration > log4j = { > - // Example of changing the log pattern for the default console appender: > - // > - //appenders { > - // console name:'stdout', layout:pattern(conversionPattern: '%c{2} %m%n') > - //} > + > + appenders {  
> appenders , root 这个是哪样？
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/longhengyu/dream/pull/4/files#r2192877).  
>  
>  
>
didn't see that you're using "icon" later; can you find back the icon object from the app object ?
It is now :D
I know, but as I told at the beginning of the PR, this is onworking feature an we'll need debug traces for Brazil testing next week. The final version of this app will have all debug lines removed ... so this is really temporal for testing since this is difficult to test and all traces will be welcome ;)
I added a comment and removed the var window part to clarify this.
The "worker thread" code adds some helpers to web workers and loads a few pieces
of code that also run the normal browser context. I am aliasing the global context of the worker to "window"
so I can use the same code in both places. 

An alternative would also be to never refer to window and only to 'this' from the global context in code that is shared.
You don't need this test and the one below for src. So you could just delete this one.

Note that gjslint will really not like this line the way you have written it.
Oh men, thank you for this :D
Today, it's crashing with the same assert as the clock app (https://bugzilla.mozilla.org/show_bug.cgi?id=775576), so I added a note to that bug
That's what happens when you copy from Firefox WebDeveloper to your editor and don't double check :D 

...fixing
I think there is no need to r? that since it will be part of the BB and so it will be reviewed there, correct?
Please do that then, thanks.
Rewrite this into a `forEach` loop.
**Disable power saving when charging** I don't know if UX needs this...ping @jcarpenter, @lco
This function might be moot anyways.  The previous UX spec called for object menus accessed by long press on an item to mask everything but the item being acted upon and position the menu nearby as the desired fancy option.  At least in https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Object_Menu there is now only the fallback option listed where the entire background gets masked and the menu just hangs out from the bottom.
why not `itervalues` -- are there concurrency issues?
Not really. Coco optimizes this as a serie of assignment.
```
coco -bci
 Element::<<<
   preprend: ->


Element.prototype.prepend = function(){};
```
So, we're deleting these instructions because we always want students to install homebrew, even if they don't need it cause they already have git? Is that a good idea? I can see arguments going either way.
This part should be reverted.
Is there any reason why the parameter cannot be a ``ScalaCompilationUnit``? Does this limitation make it not working with tests contained in jar files?
Likely should be done through osgi dependency #6
Lines 35-42 could be a lot cleaner ...
`
 user_highscores << {
  :track_id => track_id,
  :time => run.time,
  :rank => index + 1
}
`
Of course the style´s place is not in here. I just left it hoping that it soon get´s replaced by real starting lights :wink:
So we should remember to also remove the styles!
right right. ok, hmm well that should be ok I guess, a bit leaky but oh well
This method seems to be the same as for the Cassandra version (except for the actual call to HBase) - consider extracting this into the DBInterface to reduce code duplication.
just do `post.path = [path[1], path[3]]`
no need to pass some `info` around
Need to tie these three to specific versions of the library.
Indeed, but I was wondering whether you can see something that might.
Nah, this is a bit weird. You can do it like this:

```php
$url = '/projects/' . $this->project_id . '/errors';
```
should use a r"" string here due to your '\' in there
Looks like the best example is in `SourceStampsConnectorComponent.getSourceStamps` - it strings together a `getSourceStampIds` operation and some `getSourceStamp` operations using Deferreds.
It's easier to break stuff with mutable values, so I prefer to stick to `forEach` that doesn't mutate array, pure functions etc. Performance lose is not that big compared to the count of decreased bugs.
Extra space after `**`
you should use the ``$processHost`` variable here too
This piece should rather go into [lib/gitlab/markdown.rb](https://github.com/gitlabhq/gitlabhq/blob/master/lib/gitlab/markdown.rb)
It's a javascript, `image_tag` will not work here.
These are the installation instructions for stable.
Why is this not baseline*4?
Careful. You aren't escaping the value here, which makes this component vulnerable to HTML injection.

Recommend HTML escaping the value here. Or displaying a prominent notice in the documentation. Preferably the former, since "secure by default" is a good idea.
I left this for now because I wasn't sure about the side-effects the change could cause.
I totally agree with you and I don't think there is a better place for this. We are missing something for bug 743359. We just need to factors out this `main` method out of cuddlefish. We should not try to get rid of it. It just need to find another place.
Please see my comment in this bug.
Can you just tell me if I should hold this during this discussion or can I go ahead and land this ?
no.  this is a bug in my port.  I will fix it.
Yep. I'll merge an updated version of this pull request tomorrow.
yikes.  no.  I'll fix that
Also, the `+`s here (and in the following lines) are redundant - Python has implicit string concatenation. If two string literals immediately follow each other in the source with nothing but whitespace intervening, they are implicitly concatenated into a single string. Very nice for attractively spreading string literals across multiple source lines.
No need to make any pull request. Just push to "fixes" branch of yours. Und??
will it work at templatefooter?if yes then just leave it.
I think we do not need the session right?
I think having an example of the uglified version is helpful - maybe it doesn't need to be a full 1.5 pageviews.  Wiki's a good idea for that.

RE: the wrapping table, I'm on the fence about how intrusive to get with the <body> contents (also it's been enough of a pain getting the rest of it parsing correctly).  I guess I feel like there's a difference between changing the syntax of the CSS and HTML attributes to effectively communicate design intent and changing the content of the design itself.

I'm trying to think of use cases where having that table could cause problems.  One would be if people wrote css targeting their table like 'body > table'.  Actually anything that targeted 'table' without any qualifiers would also hit the wrapping table, and could potentially cause issues.

The more I think this through, the more I think the wrapping table is best left as a best practice for the user, and not something we want to be inserting magically.
Got it, thanks.  I'd prefer to rely on `$PATH`.  Do you think an acceptable solution is to simply make this call `ifconfig` instead of `/sbin/ifconfig`?
Blindly calling and catching `NoMethodError` can mask problems if the called method has an bug that causes it to throw a NoMethodError. This had been a bug in puppet that got fixed recently.
Again, no, this statement applies to 10.7 only, and not 10.8.
Is there a reason a subclass other than `ApplicationController` is needed?
I'll investigate during the weekend. I'm super busy this week. :-(
This is your javascript to get calls/index.js.erb every 5 seconds. That file renders javascript, so we can just execute it (with getScript).
do you really need both a HashSet and a HashMap ?
wouldn't `0 == key.indexOf(allowed.split('%')[0])` work here? (maybe missing something)
Indeed, I know. That one wasn't finished actually. I'm cleaning up by
tonight and after that I'll start sending PR's per component once they are
done. I'm still struggling with Github a bit (I'm a svn afficionado myself).



On Tue, Jun 19, 2012 at 9:23 AM, Maks <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,825 @@
> > +<?xml version="1.0" encoding="utf-8"?>
> > +<section xmlns="http://docbook.org/ns/docbook" version="5.0"
> xml:id="zend.auth.adapter.ldap"><title>LDAP Authentication</title>
> > +
> > +
> > +    <section
> xml:id="zend.auth.adapter.ldap.introduction"><title>Introduction</title>
> > +
> > +
> > +        <para>
> > +            <classname>Zend_Auth_Adapter_Ldap</classname> supports web
> application authentication
>
> Remember change underscores for slashes
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/1511/files#r1007888
>



-- 

Jonas Mariën
King Foo bvba
Mobile +32478364970
www.king-foo.be
jonas@king-foo.be
Right on. I'd be glad to have this inside the framework. :) And it would be nice to have it included in the Skeleton's helper_map too.
Did when merged.
As discussed, a getter and setter were added.
well, if you don't want to support your KnpZendCacheBundle anymore, you should probably update your other bundles providing a Zend_Cache integration (KnpLastTweetsBundle for instance) so that they provide a Doctrine Cache integration too (and Liip already has the bundle for Doctrine Common Cache)
Oh that flows way better, thank you!.
Changed to Reset. And, this button is now available on all search pages.
I think it would help performance to pull arguments.length into an argLen variable.
Regular expressions are probably a more Python way of doing this:

```
> python
>>> import re
>>> r = re.compile(r'\((.+)\)')
>>> mat = r.search("blah blah blah")
>>> if mat:
...     print mat.group(1)
... 
>>> mat = r.search("blah blah (foo)")
>>> if mat:
...     print mat.group(1)
... 
foo
```

http://docs.python.org/2/library/re.html
Can we verify that this is actually required?  I'd expect a test to fail if I were to remove this behaviour.
I'm pretty sure it was correct the first time as "dataType: 'json'"
Is this reverse necessary? Is coll guaranteed to be something we can reverse in constant time?
Mmm Because you don't have a container yet.
Import order should be alphabetical.
break description into lines
"its source"

Close the """ on the next line.
Missed this one. Order of import statements. Sorry.
Comments in this file would be good - to explain in more details...
Let's check this before the `IS_USERINFO_CHAR() ...` check above because it's cheaper.
I wanted to keep `.htaccess` and `web.config`. But maybe I should write:

    /composer.lock
    /libs/*
    !.htaccess
    !web.config
nitpick, this is a boolean value, default should be `False`
This has to be more than 80 chars, right? Wrap:

```python
from django.http import (HttpResponseRedirect, HttpResponseForbidden,
                         HttpResponseNotFound)
```
This needs some l10n.
What why? On every save set the ircname to the username?
Yes,  i thought so. it should not be specific to any user. Will work on it. Thanks@AlinT @m8ttyB
it's optional in html5 - but maybe for compatibility
I got started on the boolean flow control because of your code style, I thought that was your preference. I'll run with the "more than one variable" and "needs explicit parens" rules to decide if it should be a block. If there is an official WM / Phoenix code style doc you should write that up.
Coordiante is a typo.
For now, yes, they're useful (as above).
need this commented out?
New annotation to handle the constraint semantics.
Change 'es' to 'fa' and 'he' to 'iw'
I removed this query since it doesn't seems to do anything...
check if its an object! if the page is deleted and trash emptied, this will cause errors.
I guess in java interfaces default modifier is public. However, as a code-style, it may be better to make it public explicitly. 
I can change that in no time :)
As the above article pointed out, XDomainRequest doesn't allow setting custom request headers. But it is the only available option to do CORS requests in IE8 & 9.  In IE10, they finally start to use standard XMLHttpRequest. 

To support FH auth tokens in IE8&9, we have to find a different way of doing it.
Similar comment to one I made a little farther down--can we maybe make the "latest-version" text be a link to some upgrade URL that is returned by the server?  That'd give us a way to expose them to CHANGELOG info, etc.
You can remove this comment since the code is no longer needed.
we don't use `then` in Refinery :)
I think when I first went through the docs that parameter had a name and type but no description, looking in the function I didn't see it used anywhere, so I guess that parameter doesn't do anything.
Should this be a {code: ,msg: } object ?
isTenantAdmin and isGlobalAdmin is not documented here ;)
The doc might need to be updated. It is not looking at requests anymore
You don't use this local anywhere (I think it's better to remove it than to call it from `sameName` ;-))
The data parameter is set to the current time in subscription_handle_post(), not in the frontend. I think we should remove the data parameter from subscription_handle_post(), too. Either now or it should be deprecated. As the parameter isn't documented in the event documentation I assume it should be safe to remove it now.
Please remove changes in this file they don't relate to the PR.
Look at the lines below, that'st the style used in page.js, it'd be nice to keep it consistent.
Do you mean getCountryNameFromCountryCode method? I copied the way FreeGeoIpProvider dir but maybe you're right.
It doesn't seem likely you need this either. Try removing it.
У вас все так. Но категорию лучше описать в отдельном файле (так, как вы поступили с классом Cell, например).
зачем улсожнять себе жизнь с ручным управлением памяти, не проще strong ?
А чем вас не устроит такой вариант: 

1) Заполнить массив индексов в соответствии с длинной массива ДНК. 
2) В цикле случайным образом выбирать элемент полученного массива, извлекать из этого элемента индекс, и производить замену по этому индексу в нашей ДНК. 
3) удалить использованный элемент во вспомогательном массиве, чтобы использованный индекс нам больше не попался. 

Цикл делать столько, сколько нужно изменить элементов. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Ну и что, в свойстве так же создается переменная.
Он отсеется в assert
ок, добавим азотистое основание "Х", тогда @"ATGC" станет @"ATGCX", а у вас validBases=[[NSArray alloc] initWithObjects: @"A", @"T", @"G", @"C", nil ]; превратится в validBases=[[NSArray alloc] initWithObjects: @"A", @"T", @"G", @"C", @"X", nil ]; В итоге, грубо говоря, каждый объект класса NitroBase хранит в итоге лишь NSString c буквой. Поправте меня, если я вас не правильно понял.
Да, с учётом того, что тут действительно NSMutableSet, а цикл do {} while() как раз анализирует количество индексов во множестве, метод прекрасно справляется со своими задачами. Ну, если быть точным, не совсем прекрасно - опять же, при мутации 100 процентов совсем неизвестно, сколько итераций пройдет цикл до заполнения, ведь если выпадает число, которое уже есть во множестве, оно туда, естественно, не попадает. Чем больше индексов во множестве, тем сильнее возрастает вероятность "попадания" на то число, что уже присутствует в множестве.
Ah... yeah. Balls. I'll fix it.
Thanks for the clarification, Chris. 

No, the purpose of `Given`s is not to assert truths, it's to set the context in which the system is being automated. 

When I read `Given CUCUMBER_JS_HOME environment variable has been set to the cucumber-js install dir`, I understand "consider the CUCUMBER_JS_HOME variable to be set", not "let's be sure the variable has been set before running the current feature".

There should be no implicit requirements before running feature; scenarios should be both independent and self-contained. The rule of scenario independence is not respected with this environment variable: what if you suddenly need a scenario testing the absence of that variable? You could not run the two scenarios in the same Cucumber run. That wouldn't be that great, right?

Getting Cucumber's install path should not be too complicated; I'll come back with a suggestion soon.
This also was never called.
Other issue. In attention-screen we could have this 'light' library for retrieving the contact with a high percentage of success, but as we have done the effort in call log of including the 'phonenumberlib' for threading the calls without contact properly, maybe it should be a good option to use the more accurate method as we are doing in SMS App.
It has to terminate early, which isn't possible with `map`.
I understand but I don't really like the export shell var containing a password in clear text thing :/
I think the error is $cur value set to false, it has to be a resource [link](http://php.net/manual/en/function.pg-num-rows.php) .