labofsahil/github-event-dataset-2012 huggingface dataset:
Intentionally incompatible yes, I _MIGHT_ have been able to make it compatible at some point, but avoided it. The savegame-versioning is actually already in place. Basically any persist-function in any of the classes should query the version-number when loading. There might be one or two issues when adding/removing classes that I haven't tested yet, but that should be handle-able. And FWIW, I use a full uint32 for versioning, so there should be lots of leeway for versioning anyhow. (The original engine used 4 bytes, that's why I kept with it)
I'm not sure if this intermediate rescue is necessary, since being part of the bundle won't issue any `LoadError` anytime soon.
я мав на увазі getBatchActions. це не функціонал аплоада.
I think the main point is the statelessness of any component. The loader can be used for multiple resources.

I try to renew this patch with a special message ID ```__HEADER__``` within the messages loaded.

Adding a static function to the POFileLoader (and Dumper) we can add header support without breaking the general symfony structure I guess.

I'm not sure whether that could break TransChoice as the header is just a string (in this pull array)

What do you think?
It would be better to throw an exception when `locale != 'en'`. This would make this class consistent with the other stubs.
Can you remove this `@api` tag?
This is just another step towards making the web profiler useable for other projects using HttpKernel. So, I agree with you that this is not that interesting as is.
This seems wrong. If there is a scheme requirement, you will always detect it as missmatching here
it's not done in the PR
is `trim` not enouth?
missing ``public`` keyword on all methods
These lines are moved to a static method for PoFileDumper to use.
I don't know if we use a length of method to determine when to extract private methods.

To me, it's more that I ask "Does this thing have one responsibility to which I can give a clear, easily-readable name?". If so, usually I'll do it to support the newspaper principle, e.g. Can I read this from top-to-bottom like a newspaper?

If the name of the private method is clear, it should be "trustworthy". Rather, you should be able to just go "ok, this method is constructing errors (or whatever). If I want to know more about that, I'll go down to that method and check out the details."

I'm not an expert, so I welcome more input from those more experienced than myself.
I thought this was necessary to address a bug of some sort.

Memory foggy, but be sure you test in the browser including creating an event, then editing it and making sure the number is right on page load.
I can't find a good way to test this. The access token is no longer sent as a param, so can't capture in `FakeYammer`.

It's also not in the headers for some reason.
Indent inside the p block and put the closing tag on a newline.

Rule we've used has been, if the opening tag is on a newline, put the closer on a newline.
I don't think ```iter(self._geoms)``` is necessarily a generator. It will depend on ```self._geoms```. The requirement was self imposed to make sure the interface is consistent, i.e. you always get a generator. It should probably be altered to always return an iterator object so as not to limit implementation so tightly.
per
haps
use
a ```\``` ?
:
)
do we need to keep track of `cur_pos` at all?  since we're walking from the front/back can't we just keep a `count` of how many we've popped?

also, in the same walk of the list, once `count` is 0 we can exit the loop, allowing us to just write out whatever string was left null-terminated in its entirety (without the need to "reconstitute")

(same for walking from the front in the block above, in reverse)
Oh its true, missed `p.wait()`, sorry about that, I guess we have to keep the code.
@Sunight `_resultData`感觉应该放数据模型才对啊，虽然现在还没什么Model。cell这种`V`层面的东西最好别用来做数据传递的wrapper，那应该是`M`做的事
actual it still use the jndi to make a dependencies to the datasource

``` ServiceBuilder<?> databaseBuilder = serviceTarget.addService(databaseServiceName, databaseCallbackHandler);
        String connectionManager = DatabaseResourceDefinition.REF.resolveModelAttribute(context, database).asString();
        databaseBuilder.addDependency(DatabaseConnectionManagerService.BASE_SERVICE_NAME.append(connectionManager), ConnectionManager.class, databaseCallbackHandler.getConnectionManagerInjector());
```
I'm going to move this block down right above --initial-host-config so the output of -h remains alphabetical.
either "WebSocket which completely breaks" or "WebSockets which completely break"
Why is anonymous? Probably It would be interesting to have it as regular method that we can start/stop when we need.
Sorry for coming late to this, but this line makes the app thinking it is not in an activity when it is. I think what you want is making _launchedAsInlineActivity public and check it before adding the activities listener.
Still need the self for the `removeNotification` call after the transition, but see my follow up, it looks better anyway.
`alarmList`
Remove the outer if at L117. `this.alarms.childNodes.length` will be zero if there is no child node.

However, the better approach would be `this.alarms.innerHTML = '';` which removes everything at once.
Intentional bug fix from older commit ( I borked db upgrade )
The convention is to use self instead of that
If we cannot implement the functionality, I'd say we should outright break it by removing it. It makes it clear that it won't work and some porting is required.
I think this context should flow from the DI container and passed through the context.
https://github.com/projectkudu/kudu/issues/249
Ok but please, just PR useful code for your fix here. It's better to read, review, and comment it.

To fix phpdoc (which is always a good idea) could be done in another PR (by you if you want).
It would be much better to invoke bash remotely and feed the content of the template on stdin, rather than creating a temporary file and executing it.

If you do want to go down that path there are a couple of issues here:

1. You need to account for embedded `"` characters in the script as part of your "echo" to create the file.
2. You probably should use `cat` to copy data to the file, and send to stdin, rather than constructing an echo statement.
3. You don't really need to chmod the file to executable if you are asking bash to execute it directly.
4. It might make more sense to let the `#!` line in the file determine the interpreter by running in, rather than asking bash to interpret it.
any reason to prefer capital over lower-case?
What about:

```ruby
def initialize(relation = self.class.relation)
  @relation = relation
  # ...
```
Would be nice but doesn't work:

Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should == expected' if you don't care about
object identity in this example.

thats the error message that rspec gives when using ```equal``` - we could use ```eq``` but thats worse than ```==``` ;-)
Don't use `APPSCALE_HOME` here. Instead, use `/etc/appscale/my_private_ip`.
Is there a reason this is here? I don't think it should be necessary. Do you have a case where you got an `AttributeError`?
Is there a particular reason you have a special command that presents a chooser rather than just using something to the same effect as openDirect with presentAction?
This change (which was to work around a bug in IE7) ended up having an impact on the Brackets source code, which assumed this class would be applied to the root note. That's fixed in https://github.com/adobe/brackets/pull/1003.
I ran into a situation where data was empty and request.write caused an exception somewhere deep in the code.
Yeap, it is stranger.
It should use "unsigned int" instead.
But cocos2d-iphone use "float" here.
btw, this catch block should probably be simply removed here and moved to the command again. The handling of the errors during the loading of the json file cannot be handled by the ConfigValidator as it does not know the context in which it is used
Good catch. I've corrected it to be "completion" as that is the actual command name.

SEE: https://github.com/composer/composer/pull/698/files#L0R176
An array of required packages
Ok, so `Composer\Repository\RepositoryManager::getLocalRepositories` is responsible for only returning instances implementing `WritableRepositoryInterface`. In the method's docbloc it says `@return  array[RepositoryInterface]`, maybe this should be changed then, too.
I fixed this in the latest commit. There might be a better way to do it, but I just called into the log4j lib and set the root logger level to FATAL.  I'm not certain the tools.logging wrapper has a method to accomplish the same task without importing org.apache.log4j.
or "Contact asking for your attention" ?
You sure we still need these? They are front healthcheck urls as properties. Probably unused.
This is to allow calling the different build_* functions interactively 
passing them the package name (typically for testing):
in a build_* function, I call package_info on the input package 
argument. Adding this test allow to exit early and returns the object, 
without reloading it.
It is similar to the test in devtools::as.package, so that one does not 
have to worry of the type of the argument (character or already 
package_info).

I always use ``is``, as it calls inherits for S3 objects anyway, and I 
think I had an issue someday with ``inherits`` and somebody from the R 
team told me to use ``is`` :). It is also easier to just use one function.

 From ?inherits:
```
The analogue of ‘inherits’ for formal classes is ‘is’. The two
      functions behave consistently objects with one exception: S4
      classes can have conditional inheritance, with an explicit test.
      In this case, ‘is’ will test the condition, but ‘inherits’ ignores
      all conditional superclasses.
```

and the definition of is (in R-2.15.0):

```R
is
function (object, class2)
{
     cl <- class(object)
     S3Case <- length(cl) > 1L
     if (S3Case)
         cl <- cl[[1L]]
     if (missing(class2))
         return(extends(cl))
     class1Def <- getClassDef(cl)
     if (is.null(class1Def))
         return(inherits(object, class2))
     if (is.character(class2))
         class2Def <- getClassDef(class2, .classDefEnv(class1Def))
     else {
         class2Def <- class2
         class2 <- class2Def@className
     }
     S3Case <- S3Case || (is.object(object) && !isS4(object))
     S3Case <- S3Case && (is.null(class2Def) || class2 %in% 
.BasicClasses ||
         extends(class2Def, "oldClass"))
     if (S3Case)
         return(inherits(object, class2))
     if (.identC(cl, class2) || .identC(class2, "ANY"))
         return(TRUE)
     ext <- possibleExtends(cl, class2, class1Def, class2Def)
     if (is.logical(ext))
         ext
     else if (ext@simple)
         TRUE
     else ext@test(object)
}
```

-- 
Renaud Gaujoux
Computational Biology - University of Cape Town
South Africa


On 20/06/2012 15:35, hadley wickham wrote:
>> @@ -6,6 +6,9 @@
>>   #' @keywords internal
>>   #' @importFrom devtools as.package
>>   package_info<- function(package, base_path = NULL, examples = NULL) {
>> +	
>> +  if( is(package, "package_info") ) return(package)
> Why is this needed?  Also, for S3 object, you should use `inherits`, not `is`
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/27/files#r1017548
ok, plz fix :)
Why format it?
I thought `x-deafult` was a special entry that was not documented on MDN, so I suggested to document it. But `m-cfx` is fine as well.
This change looks unnecessary and inconsistent. Lose the trailing space too or leave it alone?
I would rename `getChildList` to just `keys`.
ah much better!
this comment has grammar problems
Well, we directly use it below in the filename and it also gets dumped to the console. Do we really need it?
OK, using this : error.logoNotFound=No country specific logo found.\nPlease consult your administrator for this issue.
Not relevant to 1.9 changes... but...
I might not be understanding this code correctly, but this seems wrong... it seems like it should be:

   if obj.send(method) > highest

And if that's accurate, then we should probably use a variable to avoid calling "obj.send(method)" three times.

If I'm misunderstanding the intent of the code and "obj.gid" is correct, then perhaps this code could use some commenting.
That should probably be "secure"
This does not need to use a QueuedConnection. Please just remove this parameter.
Decided to go the "don't do this" way. The service initializer and abstract service factory have to be manually added by the user right now. That's really the only clean way I can come up with right now.
No need to prefix with "\"
Yeah still, the API documentation is for him as a developer of the component, and should not be required to be known to the user of the component.
s/filter/validator/. Also, not sure if there is a "plugins" property in validator chains.

This file probably should not be in this commit, actually, as it's part of another PR.
This `array_reverse` does not guarantee that order of supertypes is correct. Some stronger check (better if coming from the definitions themselves) is needed.
I'd argue with @Freeaqingme here, that it should likely be ```($params !== null)```.
All those params must be also added to: `parameters.yml.test`
Was genau ist an der Lösung besser als an $data["passwordRepeat"] == $data["password"]?
The reason I don't like using global helper is they are included in every template, even though you only need them in some. This is not a problem with a simple todo app, but it can cause some subtle bugs in big apps.

If you really want to dry up one line of code, you could use a vanilla function instead, and just feed that one to the template. By having to declare everything that is available in the template, you make sure there's no magic going on and it's easy to see what's being made available in the template.
Yes it's done
Create the query as a variable and pass it to method call.
Mention version dependency
Whitespace out here
Fixed.  It was a tab character.
change this.message to `var message` and call the error constructor `new Error.call(this, message)` this way a stack will be created when the error is created.
trailing of whitespaces
Oops i missed that. But this causes an extra profile.save() which hurts performance.
@kellyredding - for the sentence "Assert provides a Assert::View::Base object to provide common helpers and default runner callback handlers for building views with." I don't think you want the trailing "with".
Moved comment into this thread.

Please let me know the way to reproduce it. I don't think that your change is strange. I want to fix vim if it's a bug.
I'm understanding `localrc#load` don't treat wildcard. It take just real name. So I wonder why you are talking about wildignore.
I say it should still return no!
we should remove the DOI prefix there
Note that this will be relative to the application base-uri. In sylfide, we have used a pattern for configuring the base-uri, and resolving all links against it. It is probably required to live behind the varnish wall.
maybe we should introduce base-counters here?
IIRC, the ID field should be nullable when the values are being auto-generated. Switching to a `long` therefore doesn't exhibit the same semantics.
The builder right now will be updated to reflect any deps that a detect might have, in the future we'll be using AMD style modules. So don't worry about it now.

Also I would probably combine the above statement too.

```js
if (!document.querySelectorAll) { 
return false; }
```
Rather than [redeclare/duplicate](https://github.com/flevour/Carbon/blob/b9acb81b0abac6fd6cea4111da984b53a21ad80f/Carbon/Carbon.php#L130) those values, maybe it would be better to move those values to a shared property?
You could (but certainly wouldn't want to) write it this way:

```coffeescript
id += "_cardComponent#{+(title1 isnt title2)}"
```

Wrap your mind around that. ;)
Unnecessary change?
Also, I think we should put this inside the template (and hide it, if it isn't needed)
https://github.com/thoughtbot/appraisal#under-the-hood
So there shouldn't be anything marked as favourite because every test is run with a fresh profile. Unless the favourites are associated with a logged in account. In which case using a unique user for each test would be the preferred solution, but without an API to create users this is unfortunately not easy. At very least, any test that marks a favourite should unmark it so the state is restored. Of course, if the test fails then the state would be unpredictable.
Minor point, but the indentation below this line makes it really hard to follow what the code is doing.
s/cosmicshame.puppetlabs.lan/your.puppetdb.server
I don't think this change is necessary. The previous <= 1 was taking into account the scenario where only the row key has come back. This either needs to be `<= 1` or `< 2`.
ignoring the logical fallacy, you're welcome to hack on zeromq stuff, just not in a remote branch of slanger at this point.
House style is to use use simple quote characters ' instead of fancy HTML right and left quotes.
Please use 'h2' instead of 'h1' for titles inside a blog post (here and below).
errorrs may be possible yes. in this case, you'll get an (invisible) JS error and the link will be left blue. not the end of the world...
should 'be equal to the associated mi_plan consortium name if it has not yet been set' do
These "border lines" need to have a length higher or equal to the longest line in the table that would be generated, so you'll have to update them as well. Also, it would be nice if there was no empty line at EOF. :)

Otherwise, thanks - good catch!
х - процентный показатель, и в задании это сказано. Учтите это в реализации метода mutate.
md5sum -> sha1hash?
makes sense....
When using assertions, the expected result is the first parameter and the computed value is the second parameter. These should be swapped.
The `interval` calculation could be pulled out into a temporary, since it's used for the start time as well.

Are these `NSTimeInterval` casts necessary?
omg all the blocks

Needs moar `dispatch_block_t`.
This should be:

```
Commands:
  None

URLs:
  GET /hubot/say?message=<message>[&room=<room>&type=<type]
```
Thanks a lot for your answer. Indeed, that makes sense.

However, I'm afraid this check could hide that something may have went wrong earlier (a wrongly written test for instance). Could you think of a way to let the user know about this not expected state?
because it is in __init__.py.. before everything we imported here was visible as "sample.os" etc., which is not very nice.
`test_read_source_spaces()` already has 

    src = read_source_spaces(fname, add_geom=True)

so I considered it redundant to repeat it here.
id: 'sample_json' ??
name: 'json' ??

Please use representative name and id.
I think MailSession should be a bean. You will need to create it from a factory (@ Configuration) so that you can set it up with GPs. This private method can be removed then.
From an earlier comment

It works the same way as a params array in C#. It let's you call 

    serialize(a, b, c, d)

instead of having to explicitly box them in an array.
Sorry, need to change my eclipse settings. Should i create a pull request with original imports ?
Oh, I see, that's covered by the locales file automatically. Neat!
Name this `#able_to_store_created_at?` instead.
Does JSONLint provide much benefit over this approach? If yes, should it be used in the script? If no, maybe remove this line?
OK, I guess then if we would want to fix this, the proper approach would be to first remove hardcoded sizes where they are not needed - in the admin UI (this means chaning XWiki.XWikiPrefernences class definition), and in other places in XE.
Is there any reason not to change atoms() to free_symbols? or at least change it to `if not p.has(var)` which will return more quickly on average, I believe, since it doesn't have to traverse the whole expression tree.
I wonder if a slightly more elegant check here would be `if (svg.createSVGPoint)`?
Creo que acá sería suficiente con poner success: callback
Rather create a small new function InsertRecord in the model for this.
This is not used anywhere. Please remove.
hehe, i think i was kinda tired when i wrote this :P
81 posts?! Really! :)

That will take a while to run. Since there is a spec testing the same thing (and creating object in memory only), could you remove this scenario?
Commands with nesting < or > 0 affect the "immediacy" of execution. For example: "begin" has a nesting value of 1, therefore all subsequent commands will be queued. Rollback and commit have a nesting of -1. When the current nesting value is 0, the command buffer is sent to the server for immediate execution
GridFile.delete(boolean sync) I leave untouched. Removing the force sync there would make the method obsolete.
IMHO if somebody has async cache for metadata and its needed that some operations are executed with force sync, then a workaround could be using an additional GridFS instance, where the metadata cache is forced sync. e.g.
Cache<String, GridFile.Metadata> metadata...
new GridFilesystem(..., metadata.withFlags(FORCE...), ...)
so there is no need to offer some(or all) writing operations additional as sync ones.

bela, WDYT? Removing the force sync there and mark method deprecated?
It still returns false. You need to somehow mark it to be added to typeHints. I'll add more precise javadoc.

No doubts about the rest of suggestions.
Ok, let me know when your changes are in and I'll handle the PR.
I've fixed that.
Why "foo"?
box model shouln't be translated...
I know this isn't essential for the working of the example, but I think a basemap (OSM) would add value to it.
-1 This is idea so bad on so many levels.

1. A class file is causing side effects
2. It will not protect against bad configured server
3. There are much better ways of protecting these files, placing them outside the public-web root or restricting access using the server configuration.

If the file is accessed directly and will throw an fatal error, the production server is not configured properly.
display_errors should always disabled in production.
Doesn't need to be an absolute URL, just img/group_icon.png should be enough. Also, this image can probably be a shared one.
@bp323 We shouldn't be modifying this line
@nicolaasmatthijs I'm in favor of removing the extra post as well and talked to Carl about this. Per conversation on IRC:

[16:10] PhysX: thecarlhall: would this be a hard fix to do on the backend side? the UX can solve this by doing a POST to the top level node after saving that data but it would still be an extra POST
[16:10] thecarlhall: PhysX, it would take a lot weirder semantics for the server to do it
This should replace the @deprecated methods above. This interface now contains all the information normally extracted from the SlingHttpServletRequest
Good point, it was really just testing that the correct `visitXXX()` function would be called. I have since moved the function into the JsonSerializationTest, as the function is in the abstract `GenericSerializationVisitor`, so we can only test it in one of the concrete classes. 

One more thing. I noticed that one of the functions in there is called `visitDouble()` where the PHP internal type is actually called `float`. Should we rename the function (in a seperate PR of course). Or add a wrapper `visitFloat()` that just calls the other one?
When compiling the three SCSS locations (cms, framework, framework/admin), I don't see any changes to what's already committed.
I think there is no such a need. 
If anything, sooner UpdateDelay.
Why was the first family removed?
I wanted to keep with the style of the code since this pattern is used to define how `alternatives` should behave (initial call with args to set, subsequent calls w/o args to get).
Did you really want to add this file?
https://bugzilla.mozilla.org/show_bug.cgi?id=733097
I understand your frustration, but I'd say that's a reason to fix and improve the test framework, not a reason to give up on testing. We haven't had a change like this which can really only be tested functionally in a while, so this is just going to take a while longer to work out.
- The assignment to ``$path`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
- Are you sure the method ``lock`` can be called on ``$this->store`` (of type ``object<Symfony\Component...l\HttpCache\Store>|null``)? Please also check line 200.
I think that similar method to `createRequest()` would be enough, and more clear than this additional param =)
Worth at least a comment to document the format.
s/userinfo/orgranizations
`stef` ;)
I don't think this is acceptable as `collection.model` can be a factory function rather than a model constructor.
https://github.com/ruby/ruby/blob/ruby_1_9_3/lib/monitor.rb - are we looking at same files? I think I'm skipping a step here..
Maybe a docstring to explain what the method is doing ?
thinking a little more about it I think I will settle this case, let's go with your option even if it runs more times than needed (a query for `backgroundPosition` on an element that has no keyword based components will still enter on the conditional).
At least the code is easier to understand, even if it doesn't reflect the strict cases I was trying to apply this on.
Don't use `href="#"` because it could change hash/anchor content which we could be using for something else. `target` is probably also not needed.
No! Check how settings should be imported.
Please read about sets in MongoDB.
I read it, just didn't think missing meant that it was actually missing from django. :D
Comma after *prosimo*.
I dont see reason why not. It's like method save() for registration.
I can move it if you like, but where ?
Tabs? Spaces?
Can we make this dynamic like STATIC_DIR etc.?
There's actually an opcode called 'Message'.
<GameMessageDescriptor Index="371" Name="Message" Size="36" NetworkIds="47">
Automated alignment
On Aug 16, 2012 8:33 AM, "Wesley Overdijk" <notifications@github.com> wrote:

> In src/AssetManager/Resolver/MapResolver.php:
>
> > @@ -30,7 +30,7 @@ public function __construct($map = array())
> >       *
> >       * Maps should be arrays or Traversable objects with name => path pairs
> >       *
> > -     * @param  array|Traversable $map
> > +     * @param  array|Traversable                  $map
>
> Why did you indent $map so far
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/RWOverdijk/AssetManager/pull/17/files#r1390014>.
>
>
I'm guessing your modified approach will work, and it looks better in general. Can't say this is my favorite area of the code, nor is it something I use at this point, so as long as the tests keep passing I'll defer :neutral_face:
This is done before modifying TortoiseProc.cpp, and the function is copied from a website.
I think this line should be removed, since we are not including the visualization scripts.
The tests are still installed with the package, and I'm adding the benchmark back too.
s/HBase/Base/
M or m for the word 'mineral'?
Brace on the same line in object literals.
Yea, I think it was OK here, because it's not a switch. Anything else would just be confusing. Having an active icon would make a lot of sense though.
Ditto for connection_.
But you know when you're in cockpit view, because you can see the cockpit.    

Not in all cases (eg. EYE),

but in general i think you're right.
You apparently misunderstood me. We don't need the equality test here as the operation after is a simple (inexpensive) assignment.
I would simplify to: if (savePath.isEmpty())

The patch is all good otherwise.
many of the following are usually lazy cached attributes instead of being calculated immediately.
derivative of loglikelihood  (too be explicit)
"Computes the variance-covariance of marginal effects by the delta method."  as below?
Maybe I should read the documentation before I make assumptions.
I ran 'rake' on this branch and it failed, and I believe the following patch will fix it.

-  require "twitter-text/#{name}"
+  require File.join(File.dirname(__FILE__), "twitter-text", name)

If this look ok, can you update the pull request?
I am not really fan of manually done forms. This should be done automatically from the Django form object. Not that you have to keep in sync fields in template with fields in the form all the time.
*I* care
yes :-1:
The default repository has no name?
Generally you don't name CSS classes after "where they are" but "what they are". 

e.g. `footer`, not `bottom`, and `aside` or `sidebar`, not `leftside`
If I'm not mistaken, `config` is not defined here.
For "`EntitiesSafe.invokeXxxx` which catches and propagates the exceptions", I don't think that's quite right. "Safe" would imply handling the exception rather than propagating as unchecked. We could have a blocking `invokeEffectorList` version though, that threw unchecked exceptions. But handling/propagating InterruptedException - gur.
Removed postProcessor, and instead am extending+overriding factory method. Have pushed commit to this branch.
Actually, PyDev is shipped with unpacked jar files, so, that should not be needed.
Good catch. https://github.com/heavywater/chef-graphite/pull/7 should address this.
Need to keep 'fedora' here as it is a separate platform_family.
Consider using `FileUtils. mkdir_p(File.join(install_dir, "embedded"))` which should work across *nix and windows platforms.  You wouldn't need the platform check then either.
Realizado ajuste de labls e tempo verbal.
In theory, yes. In practice, not really. read isn't a method that ever gets called externally in any scenario I've seen.
Probably better to explicitly draw it in a rectangle, rather than position it. That way it'll resize the pixmap and we won;t accidentally draw something huge.
I grouped the related items on a line together.  I wanted to avoid it getting too big as that would start to obscure the important code for the method.

I'll space out the =>'s (they're this way because that's how irb outputs them.....)
от первого аргумента в виде `{}` можно избавиться, будут мёржиться два объекта: базовый с фолбеком `this.__base() || {}` и новый про bemjson.js
`;` - `&#10029;`
String.isEmpty
Его addAll работает от Collection<String> т е ему надо уже лист, а у меня String... Я пока не знаю как строить Collection<String> от String...
@yuhunglin I'm wondering whether this is actually going to work when minified.
Isn't $rootScope going to be changed to something like `a`?

That's why we needed the

```javascript
DashboardController.$inject = ['$rootScope', '$scope', '$http'];
```
these constants are used for each service's configurations, different services will have different configuration instance, so that they won't get confused about the names of the variables.
Exactly my point; it's much neater and does exactly the same
most likely this should be a dependent class in the Base object
I don't think you want to `return this;` here. It doesn't make sense to me and you're not using it.

I actually don't see the benefit of `setFilterParams()` and `getFilterParams()`. I think it's much clearer to just use `this.set('filterParams', filterParams);` and `this.get('filterParams', {});` directly as it's pretty standard Ember and just a one liner so you're not saving any code.
``CordovaInterface`` replaced ``PhonegapActivity``
Could you elaborate (here in the documentation) what might break?
Эти два элемента лучше заменить на полноценные блоки… Хотя, для промежуточной версии может и лучше достраивать.
This makes some editors (e.g. emacs) enable python highlighting mode.
pep8: `0.5 * alpha`
I like the code efficiency and maintainability of this.  Before making this change, however, we should be sure that `predict_proba` doesn't have a significantly larger computational cost than simply finding the mode.
We have a special module to handle compatibility issues with old versions of scipy, numpy and python:

  https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/utils/fixes.py

You can add you own version of `sp_linalg.lsqr` there along with a backport or some workaround and use that version instead of scipy's in your code. That makes it possible to track all compatibility related code in a single module.
тоді фікстури LoadWallpapersData не спрацює, там прописані теги
Oops:)
You're right.  I had old .so files from when I first ran

```
python build.py
python setup.py develop
```

All the python files are automagically updated with my edits, but I have to remember to repeat *both* of those steps when the .pyx files are updated.  So what's the etiquette here... do I push a fix on top of this commit or do you?
Not sure what error you are referring to.
no souci c'est un message qui ne servait a rien... j'ai simplifi
Le 5 mars 2012 03:16, "Cyril Lacte" <
reply@reply.github.com>
a crit :

> > @@ -76,7 +17,4 @@
> >      <li><h3>&{'registration.step2.ticketing.unsigned'}</h3></li>
> >  </ol>
> >  #{/if}
> > -#{else}
>
> Oh, c'est normal que cette partie ait t supprime? J'avoue ne pas voir
> les consquences sur le site dploy, mais c'est bizarre que ce soit un
> "else connected" qui soit supprim.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cexbrayat/linkit/pull/116/files#r516378
>
This being a Native* class, use QString rather than std::string.  Also use the utf8 functions rather than latin or ascii.
Problème résolu, cf la vue du bugtrackers ;)
no worries, your format is fine. Just misunderstood initially as I wasn't expecting an exclusion from the range.
I asked Gavin about this the other day... Are we changing the copyright of the headers? Normally, I change them as I change files, so the copyright is renewed only for the files modified on that year. But there could be a different strategy here...

Also, the license text is outdated, that might be a wider issue, that we need to change all at once.
I had asked Stuart to use --process for process clusters, but I'll look at the implementation to see how he's using it.
It was, until we reverted the flag to render trees to be disabled by default. :) (Recall: that was due to the fact that it makes it next to impossible for child views to hint to the layout for purposes of adding CSS, scripts, etc.)
逗號前也不用空白
servicename. its the name used accross the board for now.
@raydavis It looks like $linkInput is being redefined here. Did you mean to remove the first version?
I am not sure how this is a reference.
Do you want instead:

````
names = name.split(/[\x5c\x2f]+/)
````

to just deal with the spots where it might be `join()`ed with one or the other and just be done?
Maybe would be a good idea return "Appears" if the server is SSH Tectia and "Vulnerable" if it's a tested version... just thinking in the information when there is a patch available :) But at the moment it's good :)
Modules should not print backtraces.  Please add an ```elog``` for that.
The trailing comma & space should go away.
I just had javascript:void(0) because it seemed when i had the href="#anything" it reloaded the page.
odd - have you run the data as a regular Zotero w/o Scaffold? We'd
want to make absolutely sure this imports correctly.

On Fri, Mar 9, 2012 at 1:11 PM, Aurimas Vinckevicius
<reply@reply.github.com>
wrote:
>> @@ -888,26 +892,24 @@ var testCases = [
>>                               ],
>>                               "seeAlso": [],
>>                               "attachments": [],
>> -                             "title": "FranUlmer.com -- Home Page",
>> -                             "publicationTitle": "Election 2002 Web Archive",
>
> Seems to be something odd going on with Scaffold. Test passes in Scaffold as it is here, but if you go to Edit Import and then run doImport, all fields show up as before.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zotero/translators/pull/184/files#r540829



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
They are only the same for interpolated types.  Look at CzmlBoolean/CzmlString/CzmlVerticalOrigin etc... For types where they are basically the same, I didn't implement one in terms of the other because they are small functions and I figured why add the extra method call.
Also this looks like it was added to what's now the wrong part of CHANGES.md.  It should be moved to the b11 section.
Removing the clones throughout will cleanup this line.
Oh, that's a good point.  It's probably better to do the clone rather than adding a w.
That sounds right.  Some of this may have been changes I made.  I erred on the site of truncating every time an expression was assigned to something that was an int in the Components code, but I think you're right that adding or subtracting integers stored as doubles always stay integral.
IMHO, these methods don't belong here. This is a validation process, therefore, only validation logic should be here. I would be happy to discuss this further in a meeting via skype.
This could be changed to:

> = simple_form_for User.new, :url => user_sessions_path do |f|

Like I did in user_sessions#new and then you have all the f.input :email, etc. goodness to work with.
I doesn't matter if you search via IMDB, the score and correct movie ALWAYS need to be used, As it will also check for ignored word etc.
Think of ways to extra this to separate entities.
This test fails for me with
```
Failures:

  1) Aeolus::Ext::BundlerExt#system_require non-strict mode should load the libraries using env var list
     Failure/Error: RSpec.constants.include?(:Mocks).should be_true
       expected false to be true
     # ./spec/aeolus/ext/bundler_ext_spec.rb:84

Finished in 0.26766 seconds
9 examples, 1 failure

Failed examples:

rspec ./spec/aeolus/ext/bundler_ext_spec.rb:81 # Aeolus::Ext::BundlerExt#system_require non-strict mode should load the libraries using env var list
```
It appears this is because ruby 1.8.x (fedora/rhel) return strings from the constants method (fwiw, this also returns a deprecation warning on the method). Not sure off the top of my head what the cleanest way is to make this work for both ruby 1.8 and 1.9.  OTOH, I suppose we could just say this version of bundler_ext runs only on 1.9.x.  Not sure if this works for katello though, since rhel is still 1.8. Aeolus couldn't use it until at least our 2.0 release, as that will be on ruby 1.9, I believe. 

```
* Rspec is deprecated.
* RSpec is the new top-level module in RSpec-2
```
For checking against out of bounds on an array?

if (array.length > 0) {
  // do stuff with array[0]
} else {
  // log error and do other stuff since array[0] doesn't exist
}
Separate path.join into three components
One last thing before it gets approved :)
Convert if-else into one line itinerary operator, but keep the comment. Thanks!
Não entendi qual é a dessa classe. Pra que uma classe abstrata que tem nada dentro??
O teste tambem fica mais direto quando vc testa o conteudo de uma variavel, metodo ou classe com algo estatico, tipo um numero ao inves de outra variavel. Tipo, quando voce faz como fez aki e testa a igualdade de um getter com outro metodo, nao fica tao indicativo. Tipo, um caso ideal seria, quando vc inicializasse com o valor x a chamasse o metodo y, o resultado deve ser z.
@cprice-puppet we could fix this now if you like ... just for my information - was the goal of your pretty backtrace to expose full paths only? I presume otherwise the formatting should be exactly the same - or is there other concerns from an IDE perspective? Sorry - I just don't know the full story here.
We've standardized on the convention of:

    #! /usr/bin/env ruby -S rspec

Because ruby will replace itself with the shebang executable if the line doesn't contain the substring "ruby"
Ah yes, that is more correct and future proof.
Уберу это когда подключу через sass
тут 4
Why is this private and not protected? Shouldn't `$model` be `$modelName` for clarity??
Rails 3.x
And this should of course then match `format`'s:

How about we change these to something more like

> sformat's current implementation is scheduled for replacement in January 2013. It will then be replaced $(LREF xformat)'s implementation. This will be seemless for most code, but it will make it so that the only argument that can be a format string is the first one, so any code which uses multiple format strings will break. Please change your calls to format accordingly.
Yes, the names are better now. I find it very important to have good names for the elemens of a program, bad names can it make so hard to understand a code base. So thanks for your feedback :) I feel we're on a good way with the model. I'll push the changes later today.
oops! fixed and pushed


On Mon, Nov 12, 2012 at 10:08 PM, Eric Bidelman <notifications@github.com>wrote:

> In database/tutorials.yaml:
>
> > @@ -637,7 +637,7 @@ tags:
> >  title: Getting Started With the Track Element
> >  url: /tutorials/track/basics/
> >  author_id: dutton
> > -publication_date: 2012-02-08
> > +publication_date: 2012-11-07
>
> This needs to stay the same. Add an "update_date" instead.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/html5rocks/www.html5rocks.com/pull/219/files#r2102922>.
>
>
It might be clearer to make this comment two sentences:

"Invoke a remote synchronous EJB method. The remote method uses asynchronous calls internally, to parallelize it's workload."
nit: just send in a null exception. (same below)
Don't see why. Except for it being untested, of course. But so is much of anything on PPC.
The type for ``$context`` is probably not what is wanted here, but it reflects how it is being used at the moment, and needs to be fixed manually.
my laziness to re-indent is superseded by my editor quick format.

The real addition was on lines 32 and 42
I see 2 problems with this line:
1. Using the whole array to find an object. This will not work when $data is a deeply nested array (represents object with relations). Why not use primary key instead?
2. This should be skipped if $data represents new entities (to be persisted), e.g. when primary key is null.

What do you think?
``ImportResult`` should be in double backticks
s/ommit/omit
The overload signatures are merges.
http://dlang.org/phobos/std_stdio.html#readln
````

                        /*
                         * INT-2636 Unspecified annotation attributes should not
                         * override the default values supplied by explicit configuration.
-                        * Note that we cannot detect explicit setting of the annotation
-                        * attribute to -1 so this could break any application so configured.
-                        * This only applies if the gateway's default attribute is set and
-                        * an @Gateway wants to override that to infinity.
-                        * Since we are explicitly excluding override by -1 here,
-                        * the work-around would be to set the value to some other number < 0.
+                        * There is a small risk that someone has used Long.MIN_VALUE explicitly
+                        * to indicate an indefinite timeout on a gateway method and that will
+                        * no longer work as expected; they will need to use, say, -1 instead.
                         */
-                       if (requestTimeout == null || gatewayAnnotation.requestTimeout() != -1) {
+                       if (requestTimeout == null || gatewayAnnotation.requestTimeout() != Long.MIN_VALUE) {
                                requestTimeout = gatewayAnnotation.requestTimeout();
                        }
-                       if (replyTimeout == null || gatewayAnnotation.replyTimeout() != -1) {
+                       if (replyTimeout == null || gatewayAnnotation.replyTimeout() != Long.MIN_VALUE) {
                                replyTimeout = gatewayAnnotation.replyTimeout();
                        }
````
No. That is exactly what I wanted.
Just read the comment in AbstractPollingEndpoint which does suggest this subclass option being public:

    Consider refactoring now to subclass {@link AbstractTransactionSynchronizingPollingEndpoint} to make 3.0 migration easier.

I guess we need to consider that tradeoff.
@jcookems can you add new issue for tables to align with that change?
revert these changes once the given PRs are merged
Interesting, this exists?
Lines above.... if the change do not change anything it shouldn't be done :)
on the other hand, you should check, whether it contains required (only required) properties
Nitpick, but I'd use:
``` "#{variant_options(inventory_unit.variant)}"``` here. Mostly because I hate string concatenation though.
허거덕 이렇게 할 수 있었군요.
What is needed information?
this needs a precondition and comment to describe the changeset
@sensorario the variable will always be set as there is a default filter above
Extract Synapse client and preview generation to a presenter (perhaps via an interface)
why on if create_new_instance(). If there's an existing instance, it should return the used volume
I am really not sure why is this needed? It looks like like identity function. `convert` does nothing, and you just call parent `dehydrate`?
> I kept the old code so that if we wanted to reinstate the delay, it would be easier. Should I remove it?

Yes. One of the advantages when using VCS is the history of code; you can go back and look at the state of the code at any point in time.
Remove this line, it's leftover gunk from a long time ago.
minor CS issue here, can you move the namespace to a use statement here (it doesn't cause errors if an imported namespace does not exist).
of course not, changing it to ssize_t like the rest
Dear me, what a horrible error :)
I think you need an "if" after "saved".
The encoding issue can be fixed by:
temp = Integer.toString(wcc.getTempCelcius()) + (char) 0x00B0 + "C";
This method should have an upper boundary, maybe when it hits the cookbooks directory or something. Just seems like a bad thing waiting to happen otherwise.
nitpick: unnecessary braces for one-line conditional
This property is not on the scale eventing in iOS.
setProperty is deprecated and its description is "use setPropertyAndFire  instead"
you should add these describes back
Let's remove this message and open a github issue instead.
This one fails too when not using stubs. Returns `NULL`. I am removing this test too. This data type is not what you think it is. There is no such thing as an inserted value for it.
Ympäröivä `if` on tarpeeton. Lausekkeella `(= 0 (mod n divisor))` on  jo haluttu totuusarvo.
Why is this called webkitEvent? I'd expect this to be called `event` (or something more generic).
No reason. As above, this has already been blogged, so I'm not sure how I feel about updating.