labofsahil/github-event-dataset-2012 huggingface dataset:
Передавать параметр как константную ссылку, а в методе если нужна переменная fileName - завести.
на вики тогда четко задокументировать, чем эти подходы отличаются. можно отдельную страницу сделать про сквадрачивание. туда же можно будет приложить код старого подхода, если кто захочет, возьмет его оттуда и доделает. тут он не нужен
There's a lot of commits, can we squash?
Since it is the style of the others test leave it this way.

Thanks to clarify.
Good place to use heredoc syntax.

```ruby
A::D.warn <<-WARNING, caller
...
WARNING
```
I think that should be 

def initialize(configuration, root = ::Rails.root)
  @configuration, @root = configuration, root
end
The convention `schema.rb` uses is to use the new ruby hash syntax with string keys.

ie:

`add_index "pizzas", ["awesome"], name: "index_just_kiddings_on_awesome", type: :fulltext`

Without symbolizing the keys, we would need to either make the schema inconsistent, or make a breaking change to the API of the format we expect the hash to be.

``add_index "pizzas", ["awesome"], name: "index_just_kiddings_on_awesome", :type => :fulltext`

which seemed wrong.
`<` is syntax sugar for `Class.new` :)
That's fine :)
Here is an example of why I care: this behavior is awful, and it cannot be fixed if these cases cannot be distinguished.
```
scala> class Foo[T](val x: T)
defined class Foo

scala> new Foo
res0: Foo[Unit] = Foo@6b285262

scala> new Foo()
res1: Foo[Unit] = Foo@7519d715

scala> new Foo(())
res2: Foo[Unit] = Foo@34bd86d4
```
Sure I did, but it seems that it tries to compile java files with scalac, while here we need javac.
with `the` payload of the given class type T removed

Updated implementation of attachments never allows multiple payloads for the same T.
what is ret? is it useful to have it returned? sorry I'm not sure what imshow returns.
`n = n or len(dics)`
And again, you gotta add the tests here too.
Are you allowed in python to grow a list you are iterating over?
Was this used in this file?
Yep, only change here is, move the code from init() to processLogs().
That's not correct since rules that's below has higher priority.
I understand the cost is minimal here, but I think it's more important we keep consistency with other parts of the framework. As people are adopting PHP 5.3, it's more natural and better for people to use anonymous functions than create_function().
Hm, looks like I have a general problem with checkstyle.. I've activated checkstyle and it's using the Sun Checks (global) by default. What can I do? :)

Current configuration: http://tinypic.com/r/33lfmv8/6
Done herp derp.
Assuming you mean the localisation file. I don't think so, our main motivation for using that file was to avoid having long form labels in the views. And I don't think we're ever going to localise the app.
how does that work? Routable interface with a `toRoutePararameters` method?
It looks like the underlying query within these objects isn't threadsafe - based on a quick code inspection, I can see it keeps mutable state in the instance whilst it executes the query. We could possibly do some work to clone the objects before using them, thereby allowing us to factory them once, and then re-use.
unless you write many bytes of data per-second, the journal directory.
No idea why. I also have no idea why template inheritance works by style name instead of directory name (but stores path in database).

I think it would make sense to use directory name for style name. Maybe close this PR for now and make RFC about removing style name completely?
Also add docblock?
Please add a doc block for the parameters
See above block of code
Info blocks being what?

Wiki page provides no additional documentation for this event at all.
Because you are writting to a parameter in an object. It could be 
something that is lost when the object is destroyed just what happens 
when you override a DOM object (I'm not referring to the window object 
or the document object. I'm referring to a Node that can be removed from 
the document itself). I have absolutely no information about the old 
method you are referring to. Anyway (unless there's a really good reason 
for not to upgrade) if it's an old method, if should be changed so that 
is follows the new method.
Yeah, np, not a blocker for merging this PR.

LGTM, +1
s/ndoe/node
Pls add line-breaks.
Мне просто не нравится когда что-то нагружают левой логикой(формирования статистики за день), когда этого можно избежать
Yeah formatting here too D:
Dit zou opzich opgelost kunnen worden, maar deze test is wellicht iets te triviaal om de moeite hiervoor te doen.
Sure, this was left from my futile attempt to make permissions.
Probably want to use a generic name here.

Should this be "app.yaml.example"?

There are no files in pykeg/src/, don't see a good reason to start now. Absent a better location I'd say move it to pykeg/ (alongside the sample wsgi file).
IIRC cdebootstrap is used in the Debian installer since quite some while.
I don't know whether it is easier to maintain, but I guess at least the dependency on Perl can be avoided.

And I'm not sure if it can be used in our case, see <http://packages.debian.org/sid/cdebootstrap>:

> This is implementation is different from debootstrap. It features a different package selection. The package selection is done according to the flavour.
please remove this file from pull request
is it required to have a success handler? can we just remove it if we're planning to do nothing?
use === rather than == by default
(checks equality and Type equality)
图例也要支持文字的格式化，用以支持那种内容过长之类的场景，让用户的格式化函数截取之后再显示。
I think @nouiz and/or @jaberg should review this section (starting from "Software for Directly Programming a GPU"). I don't know enough about GPU programming myself.
Apparently deque is already written in C, so there would be some overhead from going through the Python layer for the call, but the data structure itself is probably pretty fast.
user specified path for settings
(this is solution that conforms to brunch plugin convention variable names etc.)
I like the other way better :p
Notice that esotic signatures like  _store_cmap(self, asset, (mean, stddev)) have been removed in Python 3 so I would say that the Pythonic way now is  to use a signature like  _store_cmap(self, asset, mean_stddev) and then split.
no need to wrap the second statement in parens

strict equality please `===`
We've renamed the internal/private header files to avoid name conflicts with standard C headers (particularly <string.h>), a problem which was affecting GCC builds
1. Why using "state.hessian.inverse()" instead of "inverse_of_hessian"? 
2. I think we actually prefer to expose the stepsize instead of hard-coded. Do you have difficulty in doing it?
This error message is unlike all other error messages we have. We do not use "you" in error messages.
node_modules is a symbolic link, so we will want to handle it differently. Stat doesn't perform that well on Windows so it doesn't always see that.
Are we OK license wise using this?
Example values for these two would be sweet.
funfactory.helpers has `urlparams` which does this sort of thing.
This should be localizable.
Good point, closer to the command-line arg.
It looks like the build system is not parallel-safe. The `make` and `make install` steps will need to be separated out.
Which header file should I look at to example the OpenCL version on my machine?
could you use a more explicit name? largest_component or largest_connected_component
Le dépot est public donc pour les vrais mot de passe, il vaut mieux les mettres autre part.
Not everything understands the encoding header, and I prefer Python source files to be in plain ASCII. I can change if back if you want me to, though.
I'd rather we use the distributor scoped scratchpad since this is only information relevant to this distributor. That call is get_scratchpad()
Lower to debug.
http://pylint-messages.wikidot.com/messages:c0103

it's symbol names that do not match a regex.  Its very very chatty at the moment, so I disabled it.  Probably something that should be done eventually, but probably not in a first sweep of pylint changes.
i don't see how this would work without my suggestion above
do these parameters need to be global variables?? Ii don't think so!
s/install/update/
Totally not your fault since I didn't give you the actual story to this feature, but can you update all adMob id references to be:
publisherId instead of admobid?
What are `successCallback` and `failureCallback` for? Are these something automatic in PhoneGap?
attrName isn't initialized for the case of showing hints for attribute name and it is intentional (by design) to indicate attribute name hinting. attrName is always initialized for attribute value hinting and it can be an empty string or any value before the cursor.
This will change with the pull request to enable highlighting from inline editors.
Fair. If we decide to show an error dialog though for this case, we should externalize it.
I saw the same thing NJ did. Can't repro anymore after the fix.
In the case of a file (as opposed to a folder), we can exit this loop after we find the first item because we know there will be at most 1. So, it might be worth adding an isFolder parameter to this function.
Why ``undefined``?
These functions are used in the jsinfer branch for an extension of the analysis.
in the utils there is a function called `escapeXpathString`, which is designed for this purpose. Whether this poses an XSS vulnerability is something else; I don't think so.
OK. I see.

On 6/6/12 5:29 PM, "Florian Schoppmann"
<reply+p-941035-ce6311c06e0f799b7106a0c81c2b85736eb5b123-1236654@reply.gith
ub.com> wrote:

>> -92.3	126	0	11.8	97	97	542	990	18	21	102	35	589	166
>> -65.3	123	0	10.2	97	87	526	948	113	76	124	50	572	158
>> -127.2	150	0	10.0	109	98	531	964	9	24	87	38	559	153
>> -83.1	177	1	8.7	58	56	638	974	24	349	76	28	382	254
>> -56.6	133	0	10.4	51	47	599	1024	7	40	99	27	425	225
>> -82.6	149	1	8.8	61	54	515	953	36	165	86	35	395	251
>> -115.1	145	1	10.4	82	74	560	981	96	126	88	31	488	228
>> -88.0	148	0	12.2	72	66	601	998	9	19	84	20	590	144
>> -54.2	141	0	10.9	56	54	523	968	4	2	107	37	489	170
>> -82.3	162	1	9.9	75	70	522	996	40	208	73	27	496	224
>> -103.0	136	0	12.1	95	96	574	1012	29	36	111	37	622	162
>> -45.5	139	1	8.8	46	41	480	968	19	49	135	53	457	249
>> -50.8	126	0	10.4	106	97	599	989	40	24	78	25	593	171
>> -84.9	130	0	12.1	90	91	623	1049	3	22	113	40	588	160
>> -\.
>> +) VALUES
>
>AFAIK, copy is PostgreSQL/psql only, but INSERT is plain SQL.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/fschopp/madlib/pull/5/files#r941035
>
This would be a good place to use a `HashSet<string>` for `types` instead of a `List<string>`. Every time you call `List<T>.Contains` you'll perform an O(n) operation. `HashSet<T>.Contains` is an O(1) operation. If `Clips` has a large number of objects, this could lead to much better performance.
The `pager.facets` has many `facet`.
The `facet` has many `item` (ex `Badge`)
The `item` has attribute `visible`

So to determine if we have to render the specific `facet` we have to check if there is one `item` with `visible = True`
There is no difference if it is compiled or not. Somebody put `*.mo` into `.gitignore` file. Please remove that entry from `.gitignore` and you will not have problems.
Hardcoded to

    kwargs.setdefault('default', GENDER_CHOICES[1])

not sure if this is ok.
What means *class name*? Class name of class LanguageField is LanguageField? You mean field name? No, is should be *language*, as all are fields, so adding `_field` does not give you any additional information.
This feels brittle because of the reliance on node.id; could this be changed to node.parentNode.replaceChild( node.cloneNode( true ), node );
Filed: https://webmademovies.lighthouseapp.com/projects/65733-popcorn-maker/tickets/2233-manifest-item-units-should-be-unit
Non webm?
I think after seeing all the mistakes that happened to my poor mac from NOT using a virtualenv (back when I didn't know any better) we should remove the '(if that's your thing)' and instead link through to a page saying how to set up a new virtual env (http://www.virtualenv.org/en/latest/#installation seems good but equally as it's a four stage process we could just include it).

pip install virtualenv                     # installs virtualenv, skip if already have it
cd gameon
$ virtualenv venv                            # create a virtual env in the folder `venv`
$ source venv/bin/activate
can operations ever be null?
Will that patch allow pdf.js be minified?
ngx_close_connection中并不删除事件本身
Let's remove this println
You should see RDFGraphQuery as a module that brings some _functions_ to execute SPARQL queries over an RDF graph. This reflects the fact that a graph is supposed to be immutable in this model.

SPARQLEngine is already the typeclass for things (aka. stores) that support SPARQL queries. It defines the _methods_ that a typeclass instance must support.

I'm not sure of the intent of this modification.
Well, this line is a little magic for me, but from list of DECL_FLEX it looks like it should also accept nil so DECL_NIL
@mvidner can you point me to some documentation to verify it? ( at least it is strange for me why only select have it here, but almost all function handle nil list )
This is not required. Please remove
I was actually thinking a tree of types would be the way to go. Let's say I wanted to dump to HTML for documentation; I wouldn't want to have to rewrite this function. But this may be a "take it as it is, we'll refactor it later" situation.
Just noting that this appears to be a new convention to the way i18n strings in views have been defined.  Previously all strings were defined at the point of usage.  If this provides, which it appears to do in some ways, a cleaner and more organized way of defining a set of i18n strings for a view then the convention may be worth an email to katello-devel.
Is this missing a copyright notice?
Hmmmmm should we take out these links for now then?
On 26/04/2012 19:43, Etienne Segonzac wrote:
>> @@ -193,7 +193,7 @@ function dumpn(str)
>>           prefix += min + ":" + sec.toFixed(3) + " | ";
>>       }
>>   
>> -    dump(prefix + str + "\n");
>> +    dumpn(prefix + str + "\n");
> out of curiosity what does `dumpn` do?

dump with an additional \n
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/andreasgal/gaia/pull/1277/files#r740361
You need to add more ``=``s here to fully underline the title, otherswise sphinx freaks out (you should see the warning if you do ``python setup.py build_sphinx``)
We should investigate whether we want to use @eteq's web-fetching code that lives in `astropy/utils/data.py` instead.  I suspect there are some features here that are missing from that, but there's also a little bit of redundancy between these two, and ultimately they should be merged.  I don't know if we should let that hold up this PR, though -- maybe just file an issue that we're aware of the possible redundancy there.
I tend to agree.

The cost of changing messages is n * m, where n is the number of changed
messages and m the number of translations. Please handle accordingly.

Fixing messages for significant imrpovements in clarity and
user-friendlyless is good, but please stop this "fixing spaces".

Luke-jr cleaned up the mess (lost translations) last time, but I can
understand that he gets annoyed.
Also need cs_vNodes on that line.
Its to guess if we have another getblocks to go after this one. 
Its MAX_BLOCK_SIZE = 1000000 / default -maxsendbuffer = 10000000 = 10 / 2 = 5
See https://github.com/TheBlueMatt/bitcoin/blob/669a5d4c9e49fb3027ec7110664faa42615698bc/src/main.cpp#L2798
Does `$query['parent']` have the field name prefixed with model alias? If not it should be prefixed.
So use `$this->alias`
There was already an empty line after the closing p there... so I added one before too.... maybe remove both empty lines now ?
Thanks !
Are we really talking about a "warning message"? ;)
I don't have time to search it, but there was a commit related to this on
symfony within the last month :)

Anyway, that should not be the point here.


On Tue, Jul 31, 2012 at 9:02 PM, Benjamin Eberlei <
reply@reply.github.com
> wrote:

> > @@ -79,7 +81,11 @@ public function __construct(Reader $reader,
> $cacheDir, $debug = false)
> >       */
> >      public function getClassAnnotations(\ReflectionClass $class)
> >      {
> > -        $key = $class->getName();
> > +        if (!isset($this->classNameHashes[$class->name])) {
>
> link?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/doctrine/common/pull/169/files#r1276547
>
Yes I know about that in PHP 5.4 and I really tried hard to define all, sorry skipping this one.
Ah, good suggestion! Much clearer. And adding the nil check to users_include? will reduce a lot of duplication.

Cheers for the review Craig. =)
Actually, package.skeleton really makes the code noisy. I'll be removing it.
Also, it's not really related to debugging, so if we need this function, it should be in openpy, with a more descriptive name.
As an improvement maybe we should force all locks to be used through MachineUtils this would help os prevent lock leaking that was happening before in some cases. 

Also we could probably solve the lock/unlock not immediately visible by keep doing api calls until the state is the expected one (assuming all api calls will make a ws request to the vbox web service, if the api caches the results locally this would be pointless). 

andrea, wdyt?
Assuming you make the change above you'll need to search for all instances where this function is called and change it to use something like:

```javascript
Marky.createSimpleToolbar('#read-message .editor-tools', '#id_message', {privateMessaging: true});
```
Should we not make a timestamp from `utc_now()` instead? ...or does it not matter?
Can we then just delete all these lines?
This so ugly and it's not your fault. 
8 unnamed parameters. Your only chance to remember how to do that correctly is to go back and re-read the schema.sql :(
And same again, this is how this setting looked in 1.7. Reinstated for backwards compat and deprecated.
In views I find more readable to use `foreach() :`. In this case for instance the closing brackets might be overlooked
Agree that comments and logging would be good.  I'm not sure what we could meaningfully do in an error situation, though, given that we've already deleted the cookbook version at this point, as well as (potentially) some number of checksums.  The horses have kind of left the barn at that point.

Now, if sqerl had transactions....
Here's I think what we discussed on the phone:


    customize_for_modification_maybe('GET', Auth, Req, State) ->
        {authorized, Req, State};
    customize_for_modification_maybe(_Method, Auth, Req, State) ->
        case application:get_env(oc_chef_wm, custom_acls_always_for_modification) of
            {ok, true} ->
                {Auth, Req, State};
            {ok, false} ->
                {authorized, Req, State};
            _Else ->
                {Auth, Req, State}
        end.
Please split these up into separate test cases.  There's no reason to have then in one method, as they're clearly separate.  E.g. testCGTriangularFin, testCGRectangularFin etc.  The test case name should also explain what the test contains, it's hard to deduce from the numbers themselves.
At the moment, it doesn't work :-)
I must find some time to think about how to implement this, but the idea is to build a string with the array returned by "toArray", and I'm not sure if we must let the backward compatibility as now, implement another function or the two things, so I must spend some time thinking how to make this.
If you have any idea about the better way to make this... :-)
@stof Thanks for the feedback, I've pushed the changes!
As the `token`-column is a primary key and thus unique, a COUNT()-operation isn't necessary. It is indeed correct that the "LIMIT 1" isn't necessary too, but as far as I know it is a good hint for the query optimizer on DBMS side. It become a (good?) practice for me to LIMIT my queries this way when expecting exactly 1 or 0 results.

The empty()-check on PHP side seems more robust, as it would return a boolean value even if the result is (boolean)"false" because of a database-error or something like that. Not a hard argument at all, but this might just be a question of taste.

Nevertheless, I think this is a very academic discussion about a few CPU cycles for a "development-only" feature. Probably it isn't covered by any reasonable measurement accuracy ;-)
I think it makes much more sense than having a request context (that should not be used) in a RequestMatcher. Don't you agree?
Please move this line under the definition of $readOnly.
I think you can also changed `$type` to `$method`
looking at the code, it seems to me that not supporting form type extensions is true also for unregistered parents, right ? If yes, the comment may be better placed in the phpdoc of the resolveType method.
Is it really needed here ? Calling this method already requires the Config component anyway (because of the typehint)
Ok. What are the naming conventions for tests?

1. `is choicegroup/is selectedchoice`
2. `is choice_group/is selected_choice`
3. `is choiceGroup/is selectedChoice`
I'm obviously missing something, but 
SELECT 1 FROM sf_profiler_data WHERE token = :token == SELECT COUNT(token) FROM sf_profiler_data WHERE token = :token
, because token is a PK. Both of them will return either array() or array(1). So the !empty($tokenExists) line has to stay either way.
@stof  there seems to be not 2.2.3 tag on doctrine/common ? May be you could submit a PR with the fix ?
I would simplify this code by reducing the number of type checks and conditionals:

```php
if ('single_text' === ...) {
    // ...
}

if (is_array($widget)) {
    if (0 < count(array_diff(array_keys($widget), self::$allowedParts))) {
        // throw exception
    }
    if (0 < count(array_diff($widget, self::$allowedPartWidgets))) {
        // throw exception
    }

    return array_merge(array(
        'year' => 'choice',
        'month' => 'choice',
        'day' => 'choice',
    ), $widget);
}

if (!in_array($widget, self::$allowedSingleWidgets, true))) {
    // throw exception
}

return array(
    'year' => $widget,
    'month' => $widget,
    'day' => $widget,
);
```

IMO this makes it a lot more obvious what is happening.
I believe this should be `User.stubs(find_by_email: user)` to return the `user` when you call the stubbed method. Surprised this passes without it.
Since this is only calling `to_query`, I would merge it in with the previous method.
Is Boost::Sequence concept equivalent to (SGI) stl::Sequence one ?
Good catch, thanks!

As for the condensed version, that's what I would have done if it didn't mean calling `strip()` twice.
Check CXBMCRenderManager::NotifyDisplayFlip(). This method is called right after glxSwapBuffers. The displayed render buffer is set to current render buffer -1 and the texture sitting at this index is released for reuse. For waevex2 we need to set this to current render buffer -2.
what will make it easier (Is it a styling issue or something else ?)
What do you think about collapsing these two lines in one?

histogram[ (c==max) ? bins-1 : (int) ((c-min) * ratio) ]++;
So after getting to test this out, it does appear that wrapping with a TFramedTransport before calling openKerberosTransport() breaks the sasl negotiation loop.  So we'll need to conditionally wrap with a TFramedTransport after that, like I described above.
I guess I have a couple arguments for keeping the action within the hash. First, if we just iterate over the key/value pairs and shove them in the resource, action will already be implicitly allowed to be defined and would need a check then to disallow it. The other point is that if containers should be controllable via attributes then their creation / destruction / freezing / etc would likely be expected to be controllable from that point as well. And I guess checking for the action key is a pointless endeavor since it would just default to the default_action, in this case :create anyway.
Ah - true. The singleton service has access to the operation context from it's own start(...) method, which can then be used to start/stop the delegate service.
This should probably just be Object.class.
This and similar changes in the ejb3 subsystem tell me that this refactor is changing APIs that other subsystems may depend on. What about subsystems we don't know about, not in the AS7 code base?

A quick look makes me think that the ConnectorServices usage is just some constants. Perhaps a deprecated org.jboss.as.connector.ConnectorServices that extends org.jboss.as.connector.util.ConnectorServices?  I don't know about the other classes.
When I read it I assumed the change required a change to the test code you see which would be OK but would need rationale. If you are positive the test works either way, don't worry about changing it back.
@kborchers I missed this; can you update that separately?
Is that a byte saver?
Options should be alphabetically ordered, then a line break, then callbacks, also alphabetically ordered.
There's a verb missing in this sentence.
nit: leave this empty line please (two empty lines before each section)
`array.some()` is the prefect function for this kind of operation, but this works too.
You may want to declare those next to where there are used. For example ssid and user are useless if the password is not set. Also that's a good way of having dead variables :)
Not really volontary. I have likely forgot to make a valid pull request for it :/

But this change is legitimate!... for the homescreen..
Hi Alberto ;-) Since "WindowManager.getAppFrame(origin)" could return "null", I would recommend to include another control in the if:

if (frame && ('setVisible' in frame)) { ...

Using "in" on a null object causes a TypeError. See the WebConsole at http://jsbin.com/uxayug/2/edit
This is so, good. Please add it to the dialer. The poor little button is waiting with nothing plugged on it... so sad.
expand those rules. Also you may want to use camelCase since this is not very readable :)
`<input />`, the end tag is forbidden (but I guess HTML5 spec tolerate that)
Not the right icon :)
We cannot create it with CSS sadly. CSS will make a shadow on the box that contains the image, not the content itself. That's the main reason why this code use canvas.
The problem with this test is the lack of synchronization, so it can fail even when things are working properly. After each advance-cluster-time call, there's no guarantee that the tick tuple will be emitted, processed, and the resulting messages caught by your consumer before you do your assertion. 

One way to solve this would be to use a global semaphore and use that to synchronize your assertions with the consumer actually receiving metrics tuples. The backtype.storm.utils.RegisteredGlobalState class can be useful for this.
No;  there is a test case for it in the deployment_tests to be safe.
I think it might make sense to talk briefly about how Pulp served repositories can be over HTTP or HTTPS. I agree that we don't want to list every little detail, but that seems like a pretty key one to add in the quick start guide so people go "Oh cool, it supports that."
this raises a compilation error
@mbj @dkubb I was wondering how to determine which gateway should be used. Repository name is not really something we can rely on as people can call their repositories however they want. Any ideas?
We don't query over columns, we query over the key space. Columns here dictate which get returned from the row.
Move to helper function.
I changed all of the "g_" and "z_" prefixes throughout the code to be "git_" and "zen_" instead.
Well, as it already check the session login status. It should works every time. But OK will add a piece of code to handle it.
changed the way its work now, stack string is now normalized based on browser mode type.
And I'd split these up into individual things. (buildbot will automatically wrap the description between any to list elements).
Why ignore nonconformant code? It can possibly cause a latent bug.
I've started building a small library for dealing with SSL in PHP that we can use for this... Currently the primary feature is building an up-to-date CA bundle from the Mozilla source tree.

If you wouldn't mind, take a minute to try out and review [Sslurp](https://github.com/EvanDotPro/Sslurp). I'll add it to Packagist so we can include it in composer.
It seems to be that all this code is duplicated in the ChannelReader
another way would be a factory method which turns the array based version into an object.
You must do it when, as fast I just including network/constants.hpp I got some error I cannot solve:

2>C:\cpp-netlib\branch\boost/network/constants.hpp(150): error C2065: 'unsupported_tag' : undeclared identifier
2>          C:\cpp-netlib\branch\boost/network/constants.hpp(153) : see reference to class template instantiation 'boost::network::constants<Tag>' being compiled
2>C:\cpp-netlib\branch\boost/network/constants.hpp(150): error C2974: 'boost::mpl::if_' : invalid template argument for 'T3', type expected
2>          C:\boost\include\boost/mpl/if.hpp(56) : see declaration of 'boost::mpl::if_'
2>C:\cpp-netlib\branch\boost/network/constants.hpp(151): error C3203: 'if_' : unspecialized class template can't be used as a template argument for template parameter 'T3', expected a real type
2>C:\cpp-netlib\branch\boost/network/constants.hpp(151): error C2955: 'boost::mpl::if_' : use of class template requires template argument list
2>          C:\boost\include\boost/mpl/if.hpp(56) : see declaration of 'boost::mpl::if_'
2>C:\cpp-netlib\branch\boost/network/constants.hpp(152): error C2143: syntax error : missing ',' before '>'

The file is unmodified (constants.hpp) and is a week old.
We might also use

```ruby
lang = 'coffeescript' if ['coffee', 'cs'].include? lang
```
maybe just: event[field].gsub!(...)
Here it is white on blue, will take a look.
Couldn't we just use `Object.freeze` instead of this `lamba` method? Object.freeze has some chances to be already known by code reader. lamda doesn't. Object.freeze has a name with a clear meaning. lambda doesn't.

    exports.Sandbox = Object.freeze(Sandbox);

And I don't see the ultimate value of freezing Sandbox as we aren't using `this` in its implementation?
typo: `requires` is duplicated
It looks like this will have already been taken care of in https://github.com/mozilla/browserid/pull/2797/files#L33R73
I like that once our front end tests work with production resources on ephemeral instances, this will just work.
Why not a single line? It should be less than 80 characters.
Thanks for noting this!

If You would like to use `Logger.log`, `Logger.warn`, etc.  then I propose to use (a forked/copied) [`log4moz`][1].
But I'm really OK with `var { what, you, want, to, use } = Components.utils.import("resource://myExt/myModule.jsm", {});`



[1]: https://wiki.mozilla.org/Labs/JS_Modules#Logging
would this be the place to handle the infamous brackets issues with people needing to write [nt:unstructured].[jcr:uuid]? the qom / querybuilder should never allow to put the brackets, its an sql2 specific escaping rule.
Here's a trick for cleaning up this spec:

```ruby
    lambda { 1.+(2, 3) }.should raise_error(ArgumentError) { |e|
      e.inspect.should == "#<ArgumentError: method '+': given 2, expected 1>"
    }
```
Ah ok. In general, if it has been acknowledged as a bug in MRI, what we do is guard it with a ruby_bug guard. Also see section 3. Bugs here:
http://rubyspec.org/guards/

Basically it is guarded and marked with the first version where it is fixed. In this case probably 2.0 then. Also we use a reference to the issue in MRI so people can find the discussion on the issue there.
This has absolutely no impact on performance, only for convenience, so feel free to remove it ;-)
Hehe, maybe we should've left that part out of the commits. But turning off the built-in queue in sequelize and just relying on the one in node-mysql increased performance for us.
unless im totally reading this wrong, wouldn't this imply that `this.timeout()` is no longer possible in the test cases?
i'd remove this, I wouldn't expect anyone to quote an option, we can just pass it through `{ only: 'string' }` or `{ only: /stuff/ }`
Yes - will fix shortly. Nice catch!

On Tuesday, July 3, 2012, Ben Scholzen wrote:

> > @@ -25,8 +25,7 @@
> >      Zend\Filter,
> >      Zend\Filter\Exception as FilterException,
> >      Zend\Loader,
> > -    Zend\Translator,
> > -    Zend\Translator\Adapter as AdapterTranslator,
> > +    Zend\I18n\Translator,
>
> Shouldn't it be ```Zend\I18n\Translator\Translator```?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/1725/files#r1095697
>


-- 
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
Always returns HydratorInterface
Shouldn't it be "'Invalid URI passed as string" (proper upper-casing?)
Add a comma after last element in array (allows re-ordering or adding new items with minimal changeset in the VCS).
Tabbing is off; should be indented properly.
OK thanks for the info - I use Zend Studio 9,  Is the formatter shipped with Studio 9 completely up-to-date o?
Aye aye, sir!
missing empty line between 19 and 20
I meant this should be on the same line as the closing brace above. :-) Try running your patch through Lithium QA.
The class is used for creating custom game modes, this enum defines the minecraft ones which are used as a backing for sending to the client. So, when I create a custom game mode, lets just say EndGameMode, I need to specify a VanillaGameMode (Survival). That way, when I assign a player to EndGameMode which doesn't exist in Vanilla minecraft, the client thinks its in survival. VanillaGameMode is an enum because the Vanilla game modes can't be changed, whereas GameMode is a class to allow for extensibility.
for breadcrumb translation
@samiluukkonen Tässä voisi kenties olla hyvä jos ois tarkistus, että $rivitunnus > 0.
the indentation of the docblock is wrong.
typo? :)
What about the String case (i.e. when being returned from Solr?)
Please use """ for docstrings :-)
2 empty lines before this.
Not very clear why this should be stateful.
True, I wasn't aware of the 'fragment' option. Much better now ;)
The less HTML we can wrap in `{% trans %}` the better, so I'd put the `{% trans %}` inside the `<p>`.
Remove Extra Space
Hmm, I think I did. It's not exact but similar, and not exposed. It was at https://github.com/BurntSushi/xgbutil/blob/master/xgraphics/convert.go

I think mine was based on the one in image/draw package.
should we or shouldnt we include pagination?
I might expect that we might need to do validation here to ensure that teardown cleanup operated as expected, as there have been bugs where uninstall failed for some reason.
I think it's reasonable to wait for the element we're going to interact with.
I believe he added the exception handling to deal with the client name uniqueness issue. I used factories to get around this which keeps the exception handling out of the tests. 

On Oct 6, 2012, at 21:56, Zach Moazeni <notifications@github.com> wrote:

> In spec/functional/time_tracking_spec.rb:
> 
> > +      begin
> > +        user = harvest.users.create(
> > +          "email"      => "frank@example.com",
> > +          "first_name" => "Frank",
> > +          "last_name"  => "Doe",
> > +          "password"   => "secure"
> > +        )
> > +      rescue Harvest::BadRequest
> > +        user = harvest.users.all.detect {|u| u.email == "frank@example.com"}
> > +      end
> > +
> > +      client = harvest.clients.find_or_create_by_name("Kim's Tux Shop")
> > +
> > +      begin
> > +        project = harvest.projects.create("name" => "Other User Tracking Project", "client_id" => client.id)
> > +      rescue Harvest::BadRequest
> Same here. Not liking the exception handling in the tests.
> 
> —
> Reply to this email directly or view it on GitHub.
>
This should just be gcsb
Could you post the code you want to have there? Or shall we create our own Hamcrest matcher for http status/response? (I've never done that but I suppose it is possible and hopefully not too painful.)
underscore_variables please, not studlyCaps.  And try to wrap lines at 80 characters.  (The codebase isn't consistent on the latter, but it's worth trying.)
I see, if that were the case we could do a separate end-point for users as well, right?
I'm wondering if the source file creation couldn't be externalized. Maybe in two traits? So that you can decide which one to mix-in. I'm sure you been thinking about this, but I'd like to make sure we really need both methods in ``InteractiveCompilationUnit``.
Ah, of course :-)
I have both `migrate` and `remigrate` aliases because:

* `remigrate` is useful to run after you've just written a migration, but slower without benefit when you're just catching up to other peoples' migrations
* `migrate` is useful because it always prepares the test database, which generally doesn't happen until you run `rake`
Fair enough, I just like being able to fold both clauses separately in TextMate. :)
FilenameProperty is set twice? Is that related?
Проценты сравниваются с количеством элементов, т.е. функция работает некорректно при DNA size отличном от 100.
use init with (X, active set) is a simple way to have a sparse row matrix.
Empty lines _could_ be removed (nitpick, lol). :-P
This looks like a bad merge...
why not log some info about the source?  first few bytes of node id, or second hash?  You want to know by looking at the logs if the same node(s) keep sending you probes with HTL out of bounds or if it is always random ones.  Same goes for log if htl > MAX_HTL
Shouldn't be dot syntax.
The dashes should be aligned between arguments in TomDoc style.
Ser bra ut, men kan vi endre navn til `parliament_issues` for å være konsekvente og unngå å blande med våre egne issues?
Moet die 200 niet dynamisch worden?
why ???
Can you make this more explicit? i.e. "has a default iv of 31".
this need to be indented
I would also add a tip linking to the Config component for the ConfigCache as the ContainerBuilder takes care of providing all resources to pass them to the ConfigCache (not sure if it is already documented though)
s/Mai/May
It's discussed here: https://github.com/symfony/symfony/issues/4183

And, if you look in the Symfony core code, you will see it everywhere. The main rule is "Imitate the existing Symfony2 code."
在植入（添加？）新的缓存条目时，如果想使访问源服务器的次数最少，可以使用<link id="proxy_cache_lock"/>指令。
I'll hold off commenting on this class until I know if it is residue, or will be replaced or how it is supposed to be used.
и так сойдет
В конце концов, сделай галку «Do not show this anymore». QDialog вроде
что-то такое умеет.
А если бы ты сделал `gotEntity (const LeechCraft::Entity&);`, то не пришлось бы втягивать `structures.h`, можно было бы обойтись forward declaration.
¿Esto está declarado dos veces?
I currently don't have access to my ARM board so I can't check this right now, but I think it was related to initializer symbols for type info instances. You could try to comment this change and then run the test suite, the check in outdata should detect this.
if (!is_array($user_info) && !$user_info['is_guest'])
cool use of fill!
same as for the autopilot, you might want to pull "Company" out of the template 

try not to have to re-write a string in the text more than once just in case you feel like changing it down the road. You also avoid introducing typos.

For example, you could define a "BIZ_NAME" somewhere in the setup of the test and keep using that instead of re-defining Qdoba.
You should better format your message string server side
Please add a new line at the end of files
Might be better to do:

```ruby
if Chef::Config[:solo] and node["graphite"]["encrypted_data_bag"]
```

so that Chef solo users can still use the cookbook but need to use the graphite password, not databags...
Does this setting make any difference for non-clustered caches? Didn't we already maintain consistency for concurrent updates in local caches?
I don't really like the name of the setting, it implies that if disabled we won't support concurrent updates at all - in fact we do, we just don't guarantee consistency. The user might get a deadlock he issues a put from two owners at the same time (there are no issues if only one of the put command originators is a put) - but again, "supportsConcurrentUpdates" seems overly broad.
```segments``` is the full list of segments we need to push. ```entriesBySegment.keySet()``` is the set of segments for which we have found some cache entries to send up to now. When we are sending the last chunk we need to send one for all segments, even if it's just an empty one.
why cloning it ?
Do we know by any chance if that's the exact long press time it takes to get the +?
The difference is that the language as is places the onus on a significantly smaller number of individuals (library developers), and as such requires significantly less actual total work.
Yeah, definitely needs some docs around this. My plan was to have the Ruby API always use meters and do the back-end conversion for the API as the SOAP API only accepts integer values.
CSS classes should have -'es, ids should have _'s
Is checking for a string necessary here? it should always come through as a Boolean and shortened to `{if !message.read}`
SGVector all over the place ;)
could you please turn w into an SGVector here such that

```SGVector<float64_t> w = SGVector<float64_t>()```

 is the default argument? then you can check if

```w.vlen == 0```

 below otherwise just do 

```w=m_w ```
Please don't communicate this stuff via code comments, its going to look very out of context when looking at the source (rather than the specific commit)
Right.. leave it as is.

Personally I'd like to get rid of all the needless download options. Leave the options for filtering reports by approved/verified/date but just always include location, lat/long, category and description, etc. Especially for XML where the primary purpose is to be able to import this to another install, your almost always going to want all the information you can get.. but anyway. Thats a thought for another iteration..
I know I'll need (at least) that many for the details page and it was easier to copy and paste that than type them manually each time and didn't think to remove them before making this.
Are you sure the method ``unlock`` can be called on ``$this->store`` (of type ``object<Symfony\Component...l\HttpCache\Store>|null``)? Please also check line 71.
What's the reason of this change ? I look at code and can't find in what case this `Response` is overwritten. It seems like it's always `null` in acutal code.
This effectively turns `update` with no options into `add`, which is not desirable.
Ok, my fault. Thanks for the patch.
I wonder about that since we've not done that elsewhere. Not saying it's not a good idea but it should be consistent and part of the standard. Having a few scattered throughout the source code in methods that do not actually throw the exception seems confusing.
i'm not a regex expert, but how does this regex check if it are 2 or 3 components?
Does github actually run this file?
I think this should say "closures" not "closure"
Thanks for the review. Added the change.
And you were adding all content from the package here. Deployment was failing.
we should use that funky bash substitution syntax to  get the dirname, dirname has some x-platform issues, and no need for all the /dev/nulls
Just style things: this line and line 51 needs a space after `if` and no parens.
O no, no no no. Never create URL manually!
Hard-coded URL.
`noOfColumns` -> `numberOfColumns`
It is not irrelevant. It could happen that two different requests of two different channels have same `http_if_none_match` and `http_if_modified_since`. But they are completely unrelated. And so when you would be removing one from the list, you could remove too much.
And there where is called.
this looks better? http://pastebin.com/Zqx03Uyf
-1 indicates special static fields like thread locals and context local fields. We will eventually need to handle there I guess.
werde ich bei meinem Menü auch noch so machen. Ist schöner als String Vergleich. Thx!
pf::SNMP::constants instead ?
Note: For once, I have no criticism about the comment :)
We also need 'License :: OSI Approved :: BSD License'
This does need clarification. I adding the following to the source:


            # In order to support typical use cases, end the "file" name with
            # a slash, so that os.path.dirname(__file__) reports the correct
            # directory.
Would you mind if I modify this to look for a `src/rpm/RPM/pretrans` file and slurp in the contents?

I'm a fan of having these guys not inside the build (or SPEC) but external.....
I think it's a good practice to add editor-specific files that are not related to the project into your own [global git ignore file](http://robots.thoughtbot.com/post/18739402579/global-gitignore) instead of `.gitignore`. That's, for example, how my `~/.gitexclude` looks like:

```
*~
.*.swp
*.pyc
.rvmrc
.classpath
.project
.pydevproject
.settings/
.idea/
.redcar/
.DS_Store
```
That allows to keep `.gitignore` clean regardless of what editor every particular developer uses. Plus you do it once and benefit from it in the future projects.
Ugh, ignore this. That's what I get for doing a code review at 2AM
Same question as previous parsing out of the props.  Couldn't this be done at construction time?
I wonder if using the id is a good choice here?  Particularly for a filter, this means there could be a form on the page with the same id.  Does scoping this via @$ completely resolve those issues?
You're right.  Not sure why I thought it did.  I guess if we care, we could put `##@cond`..`##@endcond` around it, but it's probably not that important.
Just checking (and I see this from below and from a quick test), but the use of the `.view()` method here is unnecessary?  I don't think it needs to change in test scripts, but I'm also just slightly keen to know if there's something I'm missing...
Does this mean that we re-initialize the rng for each stamp?  I wonder, is that dangerous if setting from the Boost microsecond counter as our RNGs do?
Minor point "a BaseDeviate" -> "any BaseDeviate" so as not to imply that only the base class per se is allowed, but rather anything derived from it is allowed.
Another option here (not necessarily for this fix, which is fine, but for a possible future improvement) is to make methods for RealGalaxy that return the original image and original PSF as GSObjects rather than using the internal attributes, which are SBProfiles.  So
```
def getOriginalImage(self):
    return galsim.GSObject(self.original_image)
```
then the regular draw commands would work for this return value, and you wouldn't need all this extra boilerplate here.
why is this time.sleep still in here?  I know not in this change, just noticed
You deleted my code!
IDE configured to always use 4 spaces, and never to automatically auto-format code to replace tabs with spaces.

I don't think the git patch+merge could cause this. You might as well accept responsibility when you were modifying the code :-)
you can refer to constants in annotations:  `@SetFromFlag(defaultVal=Integer.MAX_VALUE)`
Are dashes always ok in groupId? I have a vague memory that different cloud providers are quite sensitive about this...
On Mon, 24 Sep 2012, Hannes Magnusson wrote:

> > @@ -54,9 +54,9 @@ $m = mongo("phpunit");
> >  # Saving files to GridFS
> >  ######################################
> >  [Saved file] New file id:file0
> > -error message: Could not store file: E11000 duplicate key error index: phpunit.fs.files.$filename_1  dup key: { : "/tmp/GridFS_test.txt" }
> > +error message: Could not store file: %s:%d: E11000 duplicate key error index: phpunit.fs.files.$filename_1  dup key: { : "/tmp/GridFS_test.txt" }
> 
> What is the %s:%d? servername:port?
> If not, then it looks wrong

It's servername:port indeed.

cheers,
Derick
-- 
{
  website: [ "http://mongodb.org", "http://derickrethans.nl" ],
  twitter: [ "@derickr", "@mongodb" ]
}
Good point, I'll fix that. The reason was that I had just copied and pasted it from what it used to do.
Nope, logout isn't guaranteed complete until the callback is finished.

Sometimes I miss passing in callbacks.