labofsahil/github-event-dataset-2012 huggingface dataset:
why are you forwarding port 3306, you don't have mysql-server inside the VM
Do you need "-E" option ?
You mean make it `L<https://gist.github.com>` ?
I think this code is not executed.
( they are just a garbage code which was used before)

I want to clean them up and make the relationship between Visual and Normal mode robust.
I mean the shared "motion" should be coded somewhere else...
NSString+XVimOperation.m is the place where I intended to make code for this. (Should it be NSTextStorage category or totally other things? )

Sorry I have been very busy for my main job and can't have time to code for XVim much...
Again. Copy paste. Sorry
This goes back to what we were discussing before as a "sensor". The GPS is a sensor in this regard. I admit that it's not always clear where to draw the line between sensor and estimator, but to me this one seems firmly on the sense side.

I'm not quite sure how the airspeed module got so borked, this was what it should have resembled: http://reviews.openpilot.org/browse/~br=revo%402fkenz%402fpathfollowing/OpenPilot/flight/Modules/Airspeed/revolution

It still needs fixing, though, because all the ifdefs make for terrible code.
I would think 4 would be the requirement, this might need changing
is this reset required given that you are then overriding the background below?
I don't think the URL needs to be marked up for i18n
Is the following section supposed to be a table?
The point of `fit_predict` is to not repeat twice the same calculation. You need to rename the current `fit` method to `_fit` and do something like:

```python
def fit(self, X, y):
    return self._fit(X, y)

def fit_predict(self, X, y):
    self._fit(X, y)
    return self.labels_
```
Please tell me what is 'w' in english words :)
changed - thx
"rolout" should be "rollout"
Actually some care is needed around using ToString().

So we want to convert non string litteral (IsString() == true) args using ToString() when a string is expected, but we don't want to call ToString on strings.  

This is the behaviour that we see from the chrome js console.  So far i've had ToString() return a null pointer on string literals so that stopped me from using ToString on all args.  If it works for you though you could do that.

This comment also applies to the other use further down
Actually, lets return it as an array, if someone wants to turn it into a string the client should do that themselves.
This is already cached [in the `View` class][1]. Just call `getMeasuredWidth()` when you need it.

 [1]: https://github.com/android/platform_frameworks_base/blob/master/core/java/android/view/View.java#L8589-8591
True. I just pulled that source from a BSD implementation (and forgot to attribute it... oops...) and wasn't thinking about thread safety.
This should probably become the definition in CBasedTypeInfo.  Would remove several duplicated copies of the same code.
I like throwing more meaningful errors, though I'd have said "will not create empty superfile". But that's not critical.
It probably represents a leak of a few items per query deploy / call to reload. I'll see if I can work out how to fix.
It does not need to implement IHqlDataset unless CHqlDictionary below also does.

If CHqlDictionary doesn't implement any other interfaces then dictionaries could use CHqlParameter instead.
Well 'renamePhysical' is hangover from previous code, so would be good if all these exceptions were consistent with "rename" or something.
Well as it was, it would have defaulted to an infinite timeout, vs the intended 3 minute timeout..

However, searching through the code base, nothing calls startSession().
I think it does session registration through registerClientProcess() only.
Can't this be a default argument?
For boolean tests, use `ok_(ooid)` or `ok_(not ooid)`
please use 3 lines like the others.
So, what are you suggesting exactly?
Fair enough - it was a minor improvement and there are other issues that are far more important.

I'd far prefer you wrote unit tests than neaten your code.
Is this sleep needed btw? If you want something like that in your code you can do:
```php
sleep(1);
return false;
```
Please consider moving these lines to its own *ecmd.c file.
`if (empty($uri['user']))` is enough, isset is useless here.
Yes, this will be changing. Code will follow soon.
@christianv If we're no longer using this filter technique, should the corresponding filter(s) be removed from the controller?
have a look at the section on quoting just before that. The rule that quotes should only be used when variable interpretation is required should actually supersede the rule on quoting resource titles. This rule should probably be modified to note that it refers specifically to strings or strings combined with variables.
@bodepd, Thaks for pointing this problem.

In fact I'm a little confused about this dependency, I would prefer to enforce it in the ```keystone::client::authtoken``` define (in keystone module) but as this is a define, if i write it like this :

    define keystone::client::authtoken(
    [...]) {
    
      $auth_uri = "${auth_protocol}://${auth_host}:${auth_port}"
      $fragment_title    = regsubst($name, '/', '_', 'G')
    
      concat::fragment { "${fragment_title}_authtoken":
        target  => $name,
        content => template('keystone/client/authtoken.conf.erb'),
        order   => $order,
      }
    
      class { 'keystone::python': }
    }

there will be a problem if keystone::client::authtoken is defined more than once, am I right ?

I'm looking forward to your opinion on this problem. Thanks !
Please avoid the use of more than 100 columns lines in the description field.
Honestly, this is more "guess_master" than "find_master"...
In this loop, you only use `nrows = 2 * halfRows` and `ncols = 2 * halfCols`, so a redefinition may make it easier to read.
I'm afraid it's my vim, not github ;)
I did update default_error_message - i'm not sure what else should be changed?
I disagree:


    1.9.3p125 :002 > require 'curb'
     => true
    1.9.3p125 :003 > require 'uri'
     => true
    1.9.3p125 :004 > curl = Curl::Easy.new
     => #<Curl::Easy>
    1.9.3p125 :005 > u = URI.join('http://stability.zekjur.net/', 'foo')
     => #<URI::HTTP:0x00000002385570 URL:http://stability.zekjur.net/foo>
    1.9.3p125 :006 > curl.url = u
     => #<URI::HTTP:0x00000002385570 URL:http://stability.zekjur.net/foo>
    1.9.3p125 :007 > curl.http_get
    TypeError: can't convert nil into String
        from /home/michael/.rvm/gems/ruby-1.9.3-p125/gems/curb-0.8.0/lib/curl/easy.rb:38:in `add'
        from /home/michael/.rvm/gems/ruby-1.9.3-p125/gems/curb-0.8.0/lib/curl/easy.rb:38:in `perform'
        from (irb):7:in `http_get'
        from (irb):7
        from /usr/bin/irb1.9.1:12:in `<main>'
    1.9.3p125 :008 > u = "#{URI.join('http://stability.zekjur.net/', 'foo')}"
     => "http://stability.zekjur.net/foo"
    1.9.3p125 :010 > curl.url = u
     => "http://stability.zekjur.net/foo"
    1.9.3p125 :011 > curl.http_get
     => true
If we store a separate array of non-undefined glyphs, this linear search goes away.
Also, `Material.fromId` should be moved to be immediately after the `Material` constructor, since it is a constructor function.
This code is duplicate with `destroy` above.  Why not have a `_destroyVertexArrays` function?
Need unit tests to verify this all works.
I think that there should be some sort of Exception related to security in the SPI. If there is not, then users would not have a way to specify that they want to handle an exception related to security when declaring an error route. 
This way there is no coupling to any specific Security Provider implementation, so the concrete Security Provider could be anything. 
But I'm always interested to hear of different solutions :)
This is b/c natively, Android dialogs are persistent, while on iOS, they're not.
According to docs in PR #2368 the default value for this is true. In which case the code should be 
`[self initializeProperty:@"wrap" defaultValue:NUMBOOL(YES)];`
Since we generate these "provider" classes when packaging the application
do we need to worry about compatibility?
As of right now the tab.backgroundColor does not work on IOS
It's important that they are separate because the normal matrix is sometimes computed differently. They are also used as distinct objects throughout the GPU pipeline, despite often being identical.
use titleize
Agreed. I like the idea. I'll make it an issue so that we can remember it.
You can also directly connect to the sizeUpdated signal instead of going through an extra slot.
This needs to be in the promise-chaining section (if they are indeed to stay separate). Otherwise the footnote makes no sense.

Which makes me doubt whether promise-chaining should be separated. It really is more natural if all the points under that heading are nested underneath a single bullet point, as they are in the current document.
I agree with @jtopjian. The resource title seems to convoluted. I think that enforcing `${name} ` to be unique is a good idea.
Because this causes an error when you apply this module straight up. There is nowhere these resources are being declared virtual in this module
с целью отделить настройки core от настроек уишек
не знаю, о чем ты, но если ты знаешь неймспейс лучше, предлагай
3 — это классно, но тогда нужно документировать это поведение (чувак обновил jQuery и виджет вдруг перестал использовать его пропатченный, а стал подгружать свой).
Yep, pretty much what I had in mind @parndt.
> This initialization isn't needed.

Is there any cost to having it?  I like the clarity of its presence.
You add names, you add your name to the authors list.
Then you're not on the latest master. There's a bug in 2.060 which makes it so that enums are false for `isIntegral` and `isString` and similar templates in std.traits, but that's not the case anymore. Your example compiles just fine on my machine.
All it takes is having what you're looking to destroy be returned from a function (e.g. the object that had ownership of it is handing it off to you). If you force `ref`, then that would have to be assigned to a variable instead of just fed directly to `destroy`/`destruct`. Regardless, requiring `ref` restricts it to lvalues when there's no reason _not_ to work with rvalues`.

And I still want to know why this function is being created at all. This is what `destroy` is for.
Redundant `static`?
Also, really redundant such notes are for [ElementType](http://dlang.org/phobos/std_range.html#ElementType) and [hasLength](http://dlang.org/phobos/std_range.html#hasLength). But as I said I'm for standard note text. Maybe old notes can be removed.
What about `Jasmine::Dependencies.rails_3_asset_pipeline?` call a few lines below?
ok my comment was interpreted as markdown, there is a ` in there:
BASE_DIR=` cd $(dirname $0) && pwd `
I wanted to. but the package: issue prevents it. basically imports will be broken because packages directory is under the root... I'll try supplying package root and update the instructions
run-tool it is.
Need to close this block with a }
Should that `0` be some named value like `Activity.RESULT_OK`? Magic numbers…
nit: you could separate these function definitions with newlines, and possibly add a one-liner that explains what the functions do
You should be able to update embedded values...

You might need to do something like `'$set'`
this is useless (and error-prone as it is likely to be forgotten if the default value is modified)
Consider: Moving the serialization/deserialization code into helper methods on the Util class. That will make the feature more unit-testable.
Same comment, there are still ids in the po files that haven't updated.
you can @Inject the TransactionTable as a field in  TotalOrderValidator.
Then you can fetch a LocalTransaction from the transactionTable by using the Transaction object held within the SingleThreadValidation (previous comment)
this should be updated as Assetic now uses the Symfony component directly
Can we just use `$('html').scrollTop()` for all browsers, or does that not work in Webkit/FF?
Not sure I follow. If I define the function only in the `AsmX86` and `AsmX86_64` version paths, it'll only show up in docs when building on those archs.
... well despite any evidence I don't see any reason we can't... actual usage just says "near the top"... guess we can sacrifice a line...
Yeah. Another way of fixing this would be to catch DuplicateKeyException and do update instead (compensation behavior). Anyway, may be another JIRA ;)
I don't know groovy very well; can you explain more why "out" is special?
This calculation is incorrect - you should only decrement by the used elapsed time on each iteration, not the entire delta (now - startTime) each time.
I'd say ". . . then for the cases where the reply consumer uses MessageSelector (e.g., named reply destination) it will be expecting the JMSCorrelationId be equal to the Message ID of the request Message"

Do you agree?
The queryFilter should only be added if it is not null. See the corresponding line in  addOptionalQueryEntitiesOptions
MSDN links can change. Is there an FWLink that can take users to the same place? Or someplace on the Windows Azure dev portal that links to the REST apis? (I hope there is)
Mainly used to get the addres and port of any endpoints defined for the current role instance - if you have more than one endpoint, or if you have multiple instances, this is the only way you can set up listeners
I think the entire class could be stripped if we don't provide additional code... What do you think?
It looks like a copy/paste error here. A "corrected" issue is one that is referenced from SCM comments in a failed build, and are posted on the next successful build.
can you add `` around the class name ?
This block should be sorted alphabetically.
ARC prompted me to add the __bridge keyword in. Hopefully this won't mess things up for non-ARC projects.
SHould we use the double quote here? ``ldaps://ldap.example.com:636``
Is this a FIXME that this commit should address?
There's nothing to indicate if polling is additive, or if the client should wipe out its existing buffer every time a poll is done.  The later is how KML works, but the former could be useful in a variety of situations.
Something like this perhaps?

```js
getThreadComments: function(identifier, permalink) {
    window.fos.queryParams = {
        permalink: encodeURIComponent(permalink)
    }

    FOS_COMMENT.get(
        'url',
        window.fos.queryParams,
        function() {}
    );
}
```

Now you can manipulate `window.fos.queryParams` with the `fos_comment_before_load_thread` event.
maybe inline error into the table, like unauth
I'd like to get Dave's response to this change.  How important is it that it opens in a new tab in the callback? Does it warrant introducing this native code for the workaround.  This applies to Chrome and IE, so if this were replaced with the standard Window.open, we would need to be ok with it popping up in a new window for the majority of users.
Ah nope, this was an earlier implementation leak, oops.
There is no reason to require dev-master in DoctrineBundle as it would mean that we cannot release the bundle (as a dev-master requirement is not reliable in time)
what about making the service private ?
I'd go with `notEnoughMoneyToBuildDroidText``
The `get` and `post` handlers have different third argument. It is a minor difference in this case, but I would still like to keep this explicit for now. When it comes time to adding more verbs, I'll be able to refactor :)
Rather that inserting specific text here, define a new file (e.g., ``personal_microbiome/text_blocks.py``) with variables containing each chunk of text, for example:

```
alpha_rarefaction_description = """Alpha rarefaction: alpha rarefaction measures..."""
```

You could then do the following:

```
from personal_microbiome.text_blocks import alpha_rarefaction_description
...
output_f.write(alpha_rarefaction_description)
output_f.write('<hr>')
```

That way the PIs can work on filling in that text and not worry about conflicting with your code changes.
I would rather do:

`if (ts === null || ts === undefined)`
I don't think so..
It's scary to me only because I don't know how `syncdb` will react and don't want to muck with the database during a game.
I agree. This was changed because there already is a `rowCount` that does a *slightly* different thing.
I see now! The other `rowCount` isn't _really_ a counting variable, and so shouldn't be called that. I can't quite tell what's going on in that code up there, so I'm not sure what the better name is.
What's the advantage of using Pathname here? And using it conditionally only?
What did you think about my previous suggestion of changing this to `image_gravatar` or  `image_use_gravatar` to group it better with the other image related fields?
I'll consider including some of the methods, but actually I don't see anything wrong with extending classes like this. It's a very common practice in JavaScript and Ruby (unlike some other languages). E.g. all those thousands of jQuery plugins are done as jQuery object prototype extensions.
There are calls in jlib, that could be used here to fetch physical RAM and use as basis here.
but they are based parsing /proc/meminfo, not sure portable
Looks like 'sysinfo' is portable method to use.
oups nice find
This name conflicts with the class name `TiUIScrollView`; they should be distinct to avoid confusion. We need to evaluate all API points in the module API for correctness and consistency, as this may be the only opportunity we get to name them (changing names will break the API)
change to unless user.location.present? or you cold use the if depending on the order
I like these method renames, I think the new names are a bit more intuitive.
Ok, i will revisit it
IMPROVEMENT IDEA: Is it possible to have the same format as I gave in the description? Arabic numerals aligned left, roman numerals aligned right. It is not mandatory at the moment.
could you use compress there?
I can't help but feel like this should be done another way (modding the API to take two ID's is too complex, and IMO, wrong, considering what an event module (aka singleton class) is intended for).

I know Gord suggested this at some point, but if this is what you want, a much better way is to make this module into an EventEmitter (or similarly named) Class instead. I.e.

    var EventEmitter = require('event_emitter');
    function WebView() {}
    WebView.prototype = EventEmitter.prototype; // this may be incorrect lol, I never do this in JS.
    var w = new WebView();
    w.on('Destroyed', function () {});

That way, you can have one EventEmitter instance for this codebase (in general, if you prefer), and one EventEmitter instance for each WebView.

@jeffheifetz you mentioned that native needs to fire back into global. If this is the case, native should (easily) be using the very same public API that is used to create/destroy webviews. I.e This is what would be expected:

    // might have a namespace (like webplatform.require...)
    require('webview/factory').get('webview-id-that-native-has').emit('Destroyed');

As for needing to listen (globally) for all events, that is not something to be implemented, unless in a debug situation (and goes against evented programming), IMO.
null вместо fnSucc поставить, вестимо?
А дальше

	_findSync: function(fn, data) {
		fn(this(data));
	},
туда попадает null, и чего?
@nukulb this should be pretty easy to do. As long as were ok with the confusing error msg that will show for our internal devs. I.e webworks-1.0.0.7 is not compatible with the framework, please upgrade to webworks-1.0.0.7. Until we properly version webworks.js and don't base it off the scm build number, we will see this problem.

----- Original Message -----
From: Nukul Bhasin [mailto:reply@reply.github.com]
Sent: Wednesday, June 13, 2012 05:50 AM
To: James Keshavarzi
Subject: Re: [BB10-WebWorks-Framework] Implemented webworks.js client/framework compatiblity mechanism [hash] (#63)

> @@ -19,8 +19,24 @@ var Whitelist = require("../policy/whitelist").Whitelist,
>  
>  module.exports = {
>      get: function (request, succ, fail) {
> -        var featureIds = whitelist.getFeaturesForUrl(request.origin);
> -        succ(featureIds);
> +        var frameworkHash = require("../webworks-version"),
> +            webworksJsHash,
> +            featureIds,
> +            errorMsg = "The webworks.js javascript library being used is incompatible with the WebWorks runtime. " + 

@kwallis - do we have decision on the exact string?
Few things I suggest we change are-
1. it should say webworks-xxx.js - basically something to suggest the version number.
2. Then also tell them where to get the webworks-xxx.js file i.e Framework/clientFiles/webworks-xxx.js

---
Reply to this email directly or view it on GitHub:
https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/63/files#r974814

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
else: raise error?
Taken from existing demo, I can fix this though, is there anything else from the old demo that we should fix that you know of off-hand?
I think this is the only withstanding issue.  How about just  "the hackathon platforms listed in the submissions section" and linking to the relevant section.