labofsahil/github-event-dataset-2012 huggingface dataset:
suggestion: When a variable contains a jQuery object I find it easier to keep track of that by naming the variable with a `$` prefix. e.g.

```javascript
var $pointer_list = $('.profiles-li-item');
```

I believe this is in the Mozilla suggested style guide as well, but I'm not 100% sure on that. It's not something I'd r- for, but just something I've found useful.
This header is only for testing purposes and should not be included - otherwise it will force every begin node run POST to respond with 'summary only'.
Did you test this line? Did it really work? Is it really persistent and is it according to the w3c's spec?
Thank God! I will make the change soon.
Yes, generally it is best to have your operators in order from left to right based on what is required to evaluate as boolean. i.e. a boolean check should be to the left of comparisons, which should in turn be to the left of function calls, etc.

That mostly just applies to || statements, though, because then the first true one is used and the rest is ignored. In && statements, order doesn't really matter because everything is checked anyway.

And in the end, it's not going to be a major performance hit to not order them like this, but in general that's a good way to do it.
They are for different cases; combining this would make the query and php code much more complicated to deal with the two cases and two different errors depending on each case.
Additionally since you are changing the signature, you might want to use this opportunity to get rid of global variables, and pass them in as parameters.
The problem here is that this is subsilver2 and there's really no sort of ajax in subsilver2.  So either I create an ajax.js for subsilver2 or just remove all subsilver2 edits.  Question is do we want to pursue this at all with subsilver2 especially with its imminent retirement?  core.js is not even being included in the footer like it is with prosilver.
It gets prefixed with the table name so phpbb_user_notifications_it I think
There is no throwing of 404 in http. Please read the http rfc and find the correct terminology to use for referring to returning a response.
all json RPC function names are in this format.
I'm concerned about the pureI here and then enumPure in toLabeledDoc, but if you've played with it and it's working fine then it's cool.

What do you think about also having something like:
  
<pre><code>labeledBodyI' :: HttpReq AppSessionData -> Iter L DC (Labeled l (Document l))</code></pre>

that uses the foldForm directly as in toLabeledDoc.
:thumbsup: I can roll with that. Removed the checks, tests are still passing.
Вообще-то download, а лучше export
rowid may not be an integer so you can't use getInt()
In addition whilst its not clear in the 3.0 code we should no longer be using JRequest but :

$app = JFactory::getAppliction();
$rowid = $app->input->get('rowid', '', 'string')

this is the case in the 3.1 code base (joomla3 branch) and as such when I merge in changes from 3.0 to 3.1 it would be good to have everything using $app->input
why checking in example CSS?
And if you absolutely need it, all CSS belongs in /src/resources/css
Should I create a new account with less privileges and POST it ?
or
We can add it now & then remove once we finalize working login page, from where we will get username & password (from the textfields)
The patient list view is shared between "Pharmacy Order" and "Show Unassigned Patients". For modularity and maintainability, please abstract it to a shared view file, instead of copy-pasting the code here.
1. Bad class name (and elsewhere through file).
 2. Could do with tests for the invalid parameter combinations - to make sure they raise an error.
Should be
// UNION Specialization
template<>
inline
bool UnionSetOperatorSetOperator::TupleSet::needToInsert(const TableTuple& tuple) {
bool result = this->m_tuples.find(tuple) == this->m_tuples.end();
if (result) {
m_tuples.insert(tuple);

}
return result;

}
Lies: not the TestTPCCSuite, not running the described configurations -- though it SHOULD be running more configurations. See comment below.
fields = [ (from, to), (from2, to2), (from3, to3) ]
On Thu, Aug 2, 2012 at 5:39 PM, Łukasz Langa
<reply@reply.github.com>
wrote:
>>
>>
>>  SAVE_PRIORITY = 200
>> +HISTORY_PAGE_SIZE = 25
>
> This would be a nice setting for settings.py.

No. It would be a nice setting for user preferences, but there is no
easy way to do that now, so a sane default value is good.
Putting it in setttings.py would only add another meaningless option.


-- 
Radomir Dopieralski, http://sheep.art.pl
This is most likely an artifact of previous work, but I'll note that getters of members should have the same structure as the members themselves, i.e. a getter for iso_vector_ should have the form iso_vector(). Citation: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Names
Btw, any thoughts on transaction handling there? Also what about cleaning up connection.queries (or are those only filled for DEBUG)
actually, the use statement is even already there :)
You can rewrite this as a static_cast rather than casting it on a separate line in the loop.
Picking some nits, but explicit is better than implicit. Single character variable names should DIAF :-)
If you changed the space with a comma, this string could be easily copy-pasted and used in `grunt custom:<paste>`. What do you think?
Then put the helper in `manipulation.js` where it belongs.
Maybe these would make more sense to actually be put inside Inventory.cs?
An explicit version is unnecessary.
Yeah I got it working in both cases.
Why change this? Or the ones below?
I can't edit it with the online editor of github. My request fall into a "404 error: this is not the web page you are looking for." And I'm tired of these problems.
Regarding storing them as strings, see the comment above. In short, yes.

I will remove the static. It may have been a bit too extreme with regards to persisting across passes on my part. That said, even with multiple javac calls in the same process, it shouldn't be a problem as the contents of the set are checked in the final pass. The build will fail if the set still contains elements that have not been handled in the last pass of one of the javac calls.
Is this not what `--continuation-indentation=4` would do?
@dsaff 
because it is named class according the pull i forked from
Yeah I'd like to change it. Do you want to do it in this pull request or another one?
Good catch. It is now.
A true "unit" test does not touch the filesystem. Not a huge deal, but a good habit to start getting into IMO.

One way to fix this would be to use cStringIO instead of tempfiles and refactoring to separate the fetching of the config data from the logic that parses that config data.
Comment here ``only used when running in-browser`` or something similar.
In later calls the Y maps to the hue or the opacity instead. When I break out the parameters I'll add clarifying comments.
What's the purpose of this condition? It seems to execute the same code in either case.
Good call. Added at the end

From: Jason San Jose [mailto:notifications@github.com]
Sent: Thursday, August 23, 2012 12:43 PM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Plugin localization example and documentation (#1424)


In src/extensions/disabled/LocalizationExample/README.md:

> +<h1 class="dialog-title">{{SAVE_CHANGES}}</h1>

> +yields

> +<h1 class="dialog-title">{{Save Changes}}</h1>

> +

> +Mustache recognizes this syntax and can substite the appropriate string. Mustache is run when Brackets launches during module load. Code in brackets.js loads the appropriate strings.js file using i18n, loads html content from a file as a text, runs Mustache on the text using strings.js for the data lookup, and then inserts the result into the DOM. Core brackets code that depends on the DOM should listen for the “htmlContentLoadComplete” before inspecting or manipulating the dome

> +

> +## Localization Guidelines

> +Multiple strings keys in strings.js should not be concatenated together since word order often varies between languages

> +

> +## Limitations

> +Brackets does not support localizing keyboard shortcuts yet

> +

> +

> +## Localization Support for Brackets Plugins

> +

> +Localization in plugins works very similarly to how localization works for core Brackets module. The i18n require module is used to dynamically load a string.js file for the appropriate locale. JavaString can then reference strings via property name from the loaded string module and mustache can be used on on html fragments to insert localized text.

We should mention the use case where an extension may want to access both the core Brackets strings module and their own strings module. Either separately or together.

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1424/files#r1448417>.
Our coding style is to use double quotes for stings
i think it's useful to have around for now. especially with all the talk of lots of round-trip ajax sucking in india.
Is this an indentation problem ?
Also for sizes, do Facebook has all sizes you are allowing above?
Pika na koncu.
Also don't add new features in the middle of some other commit. If you are just fixing the CSS file structure, then just fix that. And if you want to add another class, do another commit for that.
All of these classe ps and methods, actually :)

Do you have a readme outlining the command structure and switches?
can you create a reference to dialog.rootElement
when are some of these properties provided? When I tried locally to get this to popup number and sqlState were always undefined.
Can you explain why you prefer them over url==""?
accroding -> corresponding
Nit: no dash between ExecuteScript and method.
Ship it :-)
It's possible that this magic convergence number may need to be modified or something.  It looks good on our data, but... :)
Let's add a comment here describing each these two column families.
Снова запятая
i agree calling it dyndns would be confusing; but i have to say i don't like putting rfc numbers in option names. It's the best idea so far, though :)
Problem is our translators use Zanata. Does the web ui show context as well? I have not checked.
import test_record is not used
seems like default behavior of sync should be notify=>true
Addressed in 84e9b07. Merging
style change here no self closing ifs.
I don't think this is related to this test. Also, maybe it is better to test object's behavior here, using `is_anonymous()` method.
Also need to update the link on the website that points to the download of the latest stable version.  If there's a way in PyPI to have a permalink that always gets the latest version, that would be even better (I don't know if there is).
Sesame (at least right now, and I believe this has been stable for at least ~5 years) by default simultaneously searches NED, Simbad, and Vizier and returns all of them.  This can be problematic because most extragalactic objects appear both on NED and Simbad, and many Galactic objects appear in both Simbad and Vizier... but a few cursory checks show that they do *not* necessarily give the same coordinates (try any Messier or NGC galaxy, or an HD star).

If I'm interpreting correctly (although @adrn can correct me if not), the code currently uses your option A between those three, but requiring only one query (sesame returns all three at once).  So it also includes an implicit preference-order imposed by sesame (which be default is Simbad, NED, Vizier, I think).

I don't like Option B because I think then we should always return a list of coordinates (even if there's just one), and as you say, that sort of spoils the "convinience" factor here.

One easy solution (lets call it option C) might just be to disallow the "all" option and thus just force users to pick which they want.  I slightly favor a preference-ordered list (option D, allowing *only* NED, Simad, and Vizier, because that's the only thing this searches right now)  because that lets you check all three catalogs in one web request instead of forcing the user to try all three if their first favorite doesn't show up.  @adrn, what do you think?
isn't this function missing a `return` at the end?
This assumes the old paths which I don't think it should.
More spaces need around the operators.
s/hurd/herd
Oh wow, textbook dyslexic character displacement.
Because `(($this->authenticatedUser->getUserId() != $this->id || BackendAuthentication::isAllowedAction('index')) || $this->authenticatedUser->isGod())` will return a boolean.
I think this should be called `save_pkg_description` and live in `package.r`
I copied this function directly from the inside of `base::loadNamespace()` in R 2.15.1. I don't know if it's correct for other versions of R.
I recommend sending it to psplink to find the maximum... just something like:

```
#include <limits.h>

// ...

int result, y;
for (y = 1; y < INT_MAX; y++) {
    pt.year = y;
    result = sceRtcCheckValid(&pt);
    if (result != 0) {
        printf("Max year: %d, struct year: %d, result: %08x", y, pt.year, result);
        break;
    }
}
```

That said probably doesn't matter, heh.  I did this to find some of the limits for mutexes like max lock count and such (left out of tests since it's slow.)

-[Unknown]
We've been using integer milliseconds for timeouts, so lets be consistent, and make both of these traits `Integer`.
```
if(x == true){
   return true
} else
  return false
}
```

I think `return x` is enough
OK, let's take this to the mailing list. I'll make a post about it.
severe formatting issues.
p.s. it may be the case that this parser is unnecessary.. you should try removing it and see if it parses ok without.
right now this is the only place we list acceptable url Paramaters. for the urlParams object. We could directly access the prams from thumbnail.php but then we would have to repeat the logic that translates /widht/123 to ?width=123
Quite frankly, the CMakefile is already noisy enough. Let's drop these compat lines and stick to the standards.
Sure will change these to use php_url
If the `block` is empty, you should remove it altogether.
Instead of using `0` just remove this parameter. That way we will pickup the default value of 100ms which should be enough. If not lets make it a real number >10 because a delay of 0ms is not possible.
If you want to reduce duplication in these tests a bit, you could create another convenience method on the testcase that instantiates the filter, calls its `filter` method, and returns the result. But it doesn't bother me this way either.
probably not the optimal way to disable a test, but it is amusing.
handled this by changing the form to contain a EmailField to validate
OK, let's keep it as it is. For the tutorial purpose, it's enough. Later, if someone wants to contribute to the code, they will fork their repository clone anyway.
Minor, but prefer `%%` for line comments
well, you could use ``getDeprecationCount`` for the private method :)
would `setUpBeforeClass`, `tearDownAfterClass` be ok ?
use ``if`` as the previous ``if`` returns
I think it does. If we'd dispatch an event with all values after the foreach, you no longer know which data triggered the event, so if a field would change because of the event, it will result in an endless loop.
This should be indented same as `UIAlertView` few lines above.
Seems like `invitee` isn't necessary here. Could be `invitee@example.com' instead?
Would be good to make sure the following does as expected.  I think it'll probably load `one.json` into registry two, but would not expect that.

```
variants.loadFile('one.json', function (err) {})
variants.setCurrentRegistry('two')
variants.loadFile('two.json', function (err) {})
```
Memory leak as above
Please do send fixes in small commits as soon as you've made them - this is ideal for two reasons:
1) It keeps us up to date, and lets me try out your code
2) It is much easier to read a short diff which does exactly one thing rather than a big lump of unrelated changes.

Before we merge to master, we can always squash all the small fixes and missteps together using an interactive rebase.
This was a merge fail.
это гит. Закоментированный код толко тогда когда это действительно нужно
I usually prefer `cd test && node *-test.js`. This way, you don't need to "register" the test within the index.
Indeed, it is. Fixing that
I should add a test to check if the file already exist
I think this method should be in the test class, not in the provider class
i added these two lines for gretchen so that she would know that when she comes back to the import screen its finished, and ready to do another import. personaly i dont want to wipe the import page, i woudl rather leave it in the last state it was in incase they want ot redo the import
Can we be a bit more specific about the exception we're expecting? I'm not thrilled about a test that will pass if anything in dh.execute fails for any reason (you could stick an "assert False" in the execute method and this test would pass).
You need to also take in to consideration borders
Hm.. this was squashed from the other branch?
Suggestion:
A better here is to utilize `#screen` element, write your stylesheet as follows,
```
#screen.starting-ftu #statusbar, #screen.starting-ftu #lockscreen {...}
#screen.running-ftu #statusbar, #screen.running-ftu #lockscreen {...}
```

Then you can have an one line code here(or two, at most).
nit: single quotes instead doubles
That call to blur needs to happen immediatly, we can't wait for this 5seconds timeout to fire.
It allows to hide the keyboard when being on an app with a keyboard and opening an attention screen.
How are you going to translate those buttons? Please use a simple checkbox for now and if UX is not happy bring them to me and @fabi1cazenave
great! I wanted to propose something like this, but since the deadline for V1 is this week I didn't even try :).
Oh you keep all those rules, can we remove those that are not used.
There are 3 rotations (hour, minute, second) save in this.rotation object. Each are updated each time a setTransform is called. 
If i recreate a rotation object with a var it will not updated the child it will append a new one.
Thanks for your reminder. I'll refine it.
I'd say there are two different possibilities here :
- either you remove all the `withAnimation` stuff; I think logic in the code [line 729](https://github.com/benfrancis/gaia/blob/e6c22c94d937c5b008c7e458fb3185372a9e7621/apps/homescreen/js/grid.js#L729) is quite strange as well
- or you really want to not be invasive, and you just change `withAnimation` to `true` [line 875](https://github.com/benfrancis/gaia/blob/e6c22c94d937c5b008c7e458fb3185372a9e7621/apps/homescreen/js/grid.js#L875) and not change anythint else here
The problem here is with the markup, as there is an element inside a link, and removeChild from the link doesn't work.
We should fix the markup in this case
The repoName is unique to the test, but the repoName is derived from the test.

For example
ProjectWithTestProject that mangles the repository expects it to be located under a folder named "ProjectWithTest3ads2"
does that mean that in validators.js, I should also change isUUID to take (str, baton) the way isPort does? or should I just change this line here to function(value, baton, callback) and change the call to validators.isUUID to be validators.isUUID(value)
We should probably change this validator name to `isV1UUID` or make it take an options object with the `version` attribute which defaults to v1. This way it will be more future proof.
@jessicabarbalho Wasssssssup? :stuck_out_tongue_closed_eyes:
Ok I would like to play the mediator in between both of you: 

I can see Dave's point. SQL != evil. When written correctly there is nothing bad about it. After all it is a language that has been in use and developed for at least a decade now. 

But like Tom says - it is important to know exactly what one is doing.

so personally I don't think it is ugly, but it might be safer when using another abstraction layer. Dominik used a gem (http://erniemiller.org/projects/metawhere/) that adds a little more functionallity. It doesn't need to be this one, but maybe someone (@tombu) is really capable of rewriting it. 

Anyways - me personally - I have those weird anomalies that I sometimes like things like C++, SQL just because they are weird, confusing, but fast - very fast.
back_url is always begin http:// , so !$this->request->data['back_url'][0] == '/' is always true.
Please document all new functions.
The current feedback isn't very informative to the user. I recommend something like:

    > talk remove talk -p 2
    This will remove the following talk:

        Talk Id: 2
        Talk Title: some title
        Talk Speaker: some speaker

    Would you like to continue [Y/n]? Y
    Talk #2 removed
The settings file actually already has a constant defined for the root path called `PROJECT_ROOT`, so I could probably just use that to fix this.
No, the source should *NEVER* talk in more then one channel at a time. It should only be broadcast to the default channel because every player will see it anyways because every ChatComponent is in the default channel.
If those are the options you are dealing with, please make it either static or refactor the test so it keeps running.
I think the only way to improve coverage without major pain is by extracting these things and testing them in isolation.
`self.portal_ip = params.get("portal_ip") or utils.system_output("hostname")`
It doesn't change any codes, but has diff in github.
Is it because the file format is different from codes we used.
We use utf-8 format for all files, and use "\n" to break line.
umask is wrong in mkdir, php already applies the umask on to the 0777. It should only be done by hand when you chmod()
Good idea. Should we check for a space instead of `::` or in addition to it?
Indeed, I should ifdef that as well.
Thinking about it, I'll also rename the ifdefs (EMS_LED_BLUE -> EMS_LED_TX, EMS_LED_GREEN -> EMS_LED_RX_OK, EMS_LED_RED -> EMS_LED_RX_FAULT) as the color is an implementation detail of the hardware.
I believe this one could be anchored at the end with \s$, right?
I'm doing a couple of things here. 

* In Ophan, adding cookie weight to Ophan perf data (nearly all of it is JS accessible).

* In frontend, including a whitelist of cookies. If there's a cookie that doesn't match, then we log it back to diagnostics. There are about 25 so far, mostly OAS and Omniture (not all set at once), and then a bunch of R2 ones which we're working with a few third-parties to get them to set *only* on www.
We could also do:

```ruby
remote = `git remote -v`
repo_url = case remote 
           when /(https:\/\/github.com\/[^\/()\s]+\/[^\/()\s]+)/
           when /(git@github.com:[^\/()\s]+\/[^\/()\s]+)/
             $1
           else
             ""
           end
raise "\n## Octopress could not push to #{repo_url}"
```
I'm not convinced that pretending that it's `enable` is a good idea, I think we should use our own `reasonCode`.
Those last two `.coverage_data` and `cover_html` were added to `dev` in PR-2272 and should not be removed. But if it's a hassle to rebase again, don't worry; they'll eventually get added back in some other PR.
I already delete app.properties from repo, but of course keep it in my local working folder.
Is it correct?
Thanks
Specs pass for me now.
I'd suggest naming the function toggleRecord, since it can also disable recording which is not intuitive with this name.
Could we break this line up into multiple lines? (e.g: a paragraph split by newlines). 
On smaller screens this forces horizontal scrolling, which sucks :P
We need to be sticklers about that.  There are a couple of questions: (1) is this snippet small enough to not be copyrightable?  Many projects consider the threshold as 10 lines or less.  (2) who wrote it originally?  If I did, we have my permission :).
these three could probably be replaced with `/^[A-Z][a-z]?/` or similar
According to your latest changes this parameter is not needed now
Remove the white space in the braces
Yes. I delegate the task of saving the file to the callers of this method. It is cleaner than the current code where it mixes DB operations with Blob Storage ones.
transactionCompleted bool is not necessary since the only way transactionCompleted = true is that an exception is being thrown
The naming seems inconsistent - should be LayerCloned, not SurfaceCloned?
use a constant for the keyCode:

```js

var ENTER_KEY = 13;

...

if ( e.$.keyCode === ENTER_KEY ) {
```
would be cool for faster development, i might fill a pull request...

i also filled one for crossroads.js -> https://github.com/meteor/meteor/pull/237
@harjis functions.inc on aina incluudattu jo parametrit.inc:ssä, eli tässä turha.
@anti debugit jääny
MIssing space between `//` and first letter of comment
Yes, I was too cautious ...
It might be worth putting all this auth code in it's own module that gets included into `ApplicationController`. It helps with code clarity and maintainability as you move forward. It also makes it easier to switch auth providers in the future.
Mozno: tieto skratky (infoboard.video.Video -> infoboard.Video, atd) by som vyhodil, tento subor nechal prazdny a vsade kde sa tie triedy pouzivaju ich volal plnym menom. Toto je vec vkusu, ale hentak som to vidaval castejsie a pride mi to celkom rozumne (priam niektore kniznice presli zo skratkoveho na plnomenovy styl). Ale kebyze nesuhlasis, ok.
The build process produces a tarball, I don't want to make assumptions on how it's named.

It's not listed in the sources when the build starts, but it's part of the sources that or unpacked, or is generated at build time (I believe it's the latter, but I'd have to check).
why not using the HttpUtils class from the Security component which already contains exactly this logic ?
IMO it's just a coincidence that they put it that way to the example.
yea i'd merge as is. Everything else can be added later
This function should be perhaps named as "restmap" or "arcgismap" as it can process any valid ArcGIS Mapserver with REST protocol. For WMS servers we'll need to do another template and maybe call it wmsmap or wmsimage. Here is example urllib call for sample WMS function
GetMap:

========================================
basemap_url = "\
http://geonetwork3.fao.org/ows/14097?\
request=GetMap&\
service=WMS&\
version=1.1.1&\
layers=country_bnd&\
format=image/svg%2Bxml&\
bgcolor=0xFFFFFF&\
transparent=TRUE&\
srs=EPSG:4326&\
bbox=-180,-137.464503042596,180,137.464503042596&\
width=986&\
height=753\
"
========================================
Lining this up with the `.filter` or even `.objects` would probably be easier to read/prettier.
I think this should be inside an `if not created:` block. If it was created, the post_save signal would have just been sent.
Can this be `'personal_message': self.message`
I would kill the specification of builds for all the ondemand jobs because it can cover all of them.
Looks like this comment (and the ones below) are outdated.
not really required
Are you sure ids are always the same? you might need to go by name here
yes, fixed.  I have a better understanding for the reason behind this now.  Thanks!
Could you make this silent with `git fsck --no-progress` ?
This now says `\times` instead of `+`
please remove this change.
The previous 3 lines show how a connector can set (or update) the extra properties when supplied with a Document that is to be stored. Basically, the connector 

1. obtains all of the properties from the document, 
1. creates an `ExtraProperties` object using the `extraPropertiesFor` method define on the `Connector` base class and which takes a boolean second parameter that says whether the properties are to be updated (versus stored/overwritten), 
1. excludes by name any of the properties that should not be treated as "external" properties
1. calls `save()` on the `ExtraProperties` instance (this is done on line 404 below).
All these version numbers don't belong here (don't you get tired of typing the version numbers over and over?).
It's came from https://github.com/ether/etherpad-lite/pull/1208
? finally ?
Note: The intro block corresponds to the gray background section (color section with robots on web hosting plan pages) before the 'main' content area, for instance where alex robot drawings are on the web hosting plan pages.
> we should better go with 64KB, which I think is a better size

Out of interest, what is this based on?
Also, I'll leave this up to you because I'm really not a QtSql person, but:

Using QSqlTableModel for this is unnecessary. QSqlQuery can do SELECT, iterate results, and you can get the field numbers for efficient iteration with query.record().indexOf("field"). It might be cleaner code, and you won't leave the results in memory forever (which I believe these models will do).
If no run prefix values are found, inform the user that none of their run prefix values are valid.
If callback is optional it should be specified in the doc.
Date.now() returns milliseconds, Amazon takes the seconds since epoch
None of these tests are actually getting the revisions for the file.
This is a bit of a problem, as the logger hasn't been initialised here (it only happens in OAE.init). Initialisation of OAE and starting up the tenant servers is currently quite intertwined, so I'm hesitant to split them out as part of this patch. How do you want me to proceed ?
This should be a 401. Also, the code shouldn't be wrapped in quotes.
This looks like dead-code, unless you rely on some side-effect of that method.
Is using ``reply`` bad practice?
I can understand this might speed things up for you, but there is a reason the scans are interleaved. We don't want any one queue (I treat EPG as just another scan q), being locked out by the others.

So yes this means that one EPG scan will be run only every 40s, however for most people this is fine. I'm open to suggestions to provide a configuration option to bypass this, but not just yet, so can you revert this change for the purposes of the PR?
i'd just combine this line with second
Ack on the Initialize.  

Ack on configuration.  Expanded the reference to the Config library documentation so that it points out that your can do three ways.


On Nov 17, 2012, at 4:10 PM, Andrey Andreev wrote:

> In user_guide_src/source/libraries/javascript.rst:
> 
> >  
> > -Set these variables in your view
> > ---------------------------------
> > +Load the library
> > +----------------
> > +Initialize the Javascript class in your controller constructor, for example:
> Please don't tell people where to initialize a library when it is not an absolute must - it's their choice.
> 
> Also, your version of the doc states that the developers need to set a configuration, but you're not showing them how to pass it to the library.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Да, в этом случае пожалуй вы правы.
Очень хорошо, что вы обратили внимание на проверку совпадения нового и старого нуклеотида, но рассмотрим вашу проверку. При условии, что oldDNA действительно хранит копию "старого" ДНК.
![[oldDNA objectAtIndex:numCell] isEqual: [self.dna objectAtIndex:numCell]] - это проверка "если элементы не равны", то есть: если "не равны" - мутировать. Отрицание стоит убрать.
|| (или) заменить на &&(и) ОБА условия должны выполняться для успешной мутации.
[oldDNA objectAtIndex:numCell]!=newCell  - тут все верно.
В коде есть еще warning-и, но наверно не стоит отмечать каждый комментарием, т.к. в данном случае это пустая трата времени. Я не знаю как их исправить, поэтому таким образом вы чистоты кода не добьётесь. Если бы знал, наверно лекции Hexlet по Objective C уже были бы мне не нужны. Вы же мне никаких советов не даёте, так что в результате ничего не меняется.

Несколько не логично оставлять комментарии и вообще делать что-то "просто так", без причины. Но раз у вас есть свободное время... как хотите.
In my opinion, this would be better: "Vous avez assigné un ou plusieurs étudiants ayant un nombre de crédits de grâce inférieur à celui déjà utilisé par le groupe %{group} pour ce devoir."
We should never resample down as the resampling algorithm used doesn't apply low-pass filtering for performance (aliasing). An if (rate <= 32000) check is better.
Is there an "official" redis URI definition?
test_eig -> test_det
With the above comment, we can simply delete this copy.
Stefan, that sounds logical to me. Keep that one in mind, let's test this to make sure it'll handle the situations we want. If the feature sticks we'll refactor later
One more, looks like we still have a dependency on portlet.core that we don't want.
"build in" needs to be "built in"
But the weird semantics of this scheduler is to guarantee that it never yields control while executing a scheduled block.
It's not quite the same though, since errors or completion are sent immediately.
Definitely. In addition, there's a problem anytime one loops through urlHistory. See #3654. That's why in the PR discussion I'm advocating entirely avoiding another place where we loop through urlHistory.
it's better to find EEG using channel type (see mne.fiff.pick_types function)

you can have EOG channels named EEG XXX
no space is needed after Parser
Where did this import come from?  If any StringUtils is used, use the spring or apache commons ones
When would component.version not exist, but component.version_guid exist?
doesn't fail mean it failed? why the if?
Can we list the people that have given LGTMs also?
This looks like it's all repeated from the `bin/git-reflow` file. Can you DRY it up a bit?
Sure thing, i updated the PR.
Thank you, I will fix this! English is not my primary language and I struggle alot with writing english... If you found other grammar issues please mention me.
``You can check by filename`` should be placed in a comment in the code block for consistency IMO
同样的语序调整，交给你了。
I hate it when I nitpick on my own updates :-)
Ты предлагаешь вынести в него все методы, в которых не вызывается ни одного
метода класса или не используется член?
Пиздец. Ты еще и копирайты читаешь. Я в шоке!
It isn't the license the bothered me, but like the rest of it it looked like it could have even been accidental insertion via over zealous usage of StyleCop and Resharper - I've had this *exact* thing happen before where accidental copyrights were added.

That being said, you will more than likely rub people the wrong way with that explanation.
This change would allow AppJS (or other host, such as an Android or iOS wrapper app) to prepend a script block that defines `allowSave()` to the top of the TiddlyWiki HTML file (it turns out that browsers are quite happy to handle a script tag even if it's before the doctype).

In other words, when loading up a TiddlyWiki, AppJS would load the file from the file system, and then prepend the script block before passing the resulting modified HTML file to the embedded browser. When it comes to saving, TW would ignore the extra script, because it retrieves the unmodified version of the HTML file from the AppJS file APIs, and then make its modifications.

I'm not familiar with the AppJS code, and so this approach might not apply; it came up when I was exploring iOS wrapper app techniques.
Please use multiline alignment
You should not instantiate `phraseanet.core` service outside controllers
I think this would be clearer with a more specific name: perhaps `confirmation_user`.
http://docs.oracle.com/javase/1.4.2/docs/api/java/io/File.html#separatorChar
Why would you need a reader? This is a logging sink right, why do you need to synchronize on reads?
Nit: ```// Save``` instead of ```//Save```
I realize this might be a pain, but since we have a graph package, could we somehow retrofit this to use a Graph instance and be in the graph package?

Alternatively, we could wrap a Matrix as a Graph and implement it that way?
new context?
We should probably put this in the middleware the builds the context
Since self.update_db is still in there, I pulled it into the class.
why are these two methods in the `try` block? Just put the constructor (alone) in there.
I gave it a try and it doesn't appear to.  It also can't handle the -lib command properly, it just spits out --help stuff. 
I made a new pull using gdmd: https://github.com/jacob-carlborg/orange/pull/22
Ok, but on the first line (after the title) of `whats_new.rst` says:

```
This page just covers the highlights -- for the full story, see the
`CHANGELOG <http://matplotlib.org/_static/CHANGELOG>`_
```

I've added a section for what's new in matplotlib-XXX, since I don't know if it'll be in 1.2.1 or 1.3, if we never end up cutting 1.2.1
Here I don't think the backslash looks __too__ bad. I think the only way to deal with it is to do the following:

```python
dims = self._text2path.mathtext_parser.parse(s, dpi, prop)
return dims[0:3]  # return width, height, descent
```
Wow, getting into what this actually does isn't easy. gsave is ```q``` and grestore is ```Q```, this corresponds to the PDF specification (section 4.4):

```
There is no way to enlarge the current clipping path or to set a new clipping path
without reference to the current one. However, since the clipping path is part of
the graphics state, its effect can be localized to specific graphics objects by en-
closing the modification of the clipping path and the painting of those objects
between a pair of q and Q operators (see Section 4.3.1, “Graphics State Stack”).
Execution of the Q operator causes the clipping path to revert to the value that
was saved by the q operator, before the clipping path was modified.
```

So I wonder what effect removing this local clipping path functionality has? @mdboom : would you mind providing some extra detail?
Could this possibly be reworded? Something like "The database should either be owned by the user, or the user needs to be GRANTed permissions on the database." Only in our case, our databases are not owned by the users :)
return self::$i ?: self::$i = new self(); ?
[use exists](https://github.com/onPHP/onphp-framework/blob/master/core/Form/PlainForm.class.php#L39)
pls avoid one line if requests
this section needs changing
that's actually one arg that's getting destructured in the first case.
This is just in the doc. Dan removes it in another pull request he's working on.
An empty tag is more readable as `<Import-Package/>`
I've added the snippet of code (copied/pasted from the other branch of logic) which reads the default template values. That is now at line 248 below. As another refactoring step I'm going to add code which reads all of the search template from JCR into an object at the top of this method so that this duplicate logic is not needed.
please use SG_SPRINT in the example instead of printf (not to confuse with SG_PRINT - the additional S is the static variant
I have done all the modifications, should I send a new pull request ?
The two 'input' rules are waaay to global
The reason I changed it was because the 2.4 documentation advises you to create a new class whereas in SilverStripe 3.0 you are adding a function to a existing class.
I will modify this to the following 

To extend the options available in the panel you can define your own fields via an Extension class
See previous comment re: `$.fn.css`, maps.
Ack, fixed.
Won't this return holding the spinlock?
And there's no need for an else clause, this is an absolute action, it returns.
Hardcoded number?
these two names are misleading - send_notifications also sends emails
Filed k88hudson/webmaker-nav#75
Why did you skip 0.3.15?

Next update we can probably move to 0.4.0
You may also want to push down the method to `InputTest`, since it is the only `SplunkTestCase` subclass that is actually using this method.
I added an intro line to this list to vagueify up the fact that we aren't providing a complete list.
That attribute shouldn't be called email: it doesn't contain an email address, it's the hash of the address..
Cant believe I actually did that :)
It's the logout button, we have to trigger BrowserID's (navigator object) logout method ot tell it that the user is logging out. Otherwise, the user is logged in again on page refresh.
Are you running this in virtualenv? Have you installed all the things from requirements.txt? Which Python version you have?
Again, elements are uniquely determined by ID. We do not want to have IDs of users as IDs of page elements. It could break things. (Are you sure IDs of users are valid IDs of page elements?)
formatting did this. would be nice if i could revert to previous commit somehow?
We should keep the tasks-title class (since it has some css associated to it) and probably just the 'Task Discussion' text for the header (it probably does not matter to much if it is called Task Discussion or Comment so I am choosing the newest name. The UI for challenges was designed more recently).
I see, then the assertion could be made stronger e.g. the result is assignable from `TypeWithIncompatibleAndCompatibleConstructor`.
How do you know that *in this case* the method doesn't return `null`?

Previously, this scenario didn't work at all, so would you say that the existing tests guarantee that it works?
It would be an API breaking change. External callers were calling deauthenticateMac and they should still be calling deauthenticateMac.

All switches implementation should be updated. Their existing deauthenticateMac converted to deauthenticateMacDefault (I think that's the way you called it).
I propose "filename" instead of "file"  since file is a builtin. and we're talking about the file name here
I think I explained this over Skype, but for completeness I'll comment here too.  I'm expanding all redirects here because the JavaScript version shouldn't have to expand the paths itself.  Plus, it turns out the Ruby version wasn't doing redirects for the calendar data, which was fine for CLDR v0.7 but not for v21.
I put it in the shared directory because core_ext only contains objects from the original Cldr. What do you think?
为HTTP服务器编译<link doc="http/ngx_http_ssl_module.xml">HTTPS协议支持</link>的模块。该模块不是默认编译的。它需要OpenSSL库才能编译和运行。
cache divs.length, e.g. `for (var i = 0, ii = divs.length; i < ii; ++i)`
@bdemers well, if we keep this future read will fail, then this metadata will be deleted and recreated....

And if we are on a disk full situation it many not be a great idea to rename files....
> I like this resolution to the problem, as the sequential seeding had vaguely worried me.

I can add your diminished disquietude to the docs if you like.  :)
OK.  Requires an extra indent for everything, but I guess that's fine.
> In galsim/shear.py:
> 
> >  class Shear(object):
> > +    """
> > +    @brief A class to represent shears in a variety of ways.
> Can remove this @brief. Might be worth grepping for more of these.
> 

There are a bunch, in multiple files.  Given their prevalence and the number of documentation-focused pull requests we have going on, I would suggest that we wait until they are all merged in, and then one person can go through and remove all of them directly on mater.
what does nextState2 stand for? Unguessable by the name...
same comment about map here.
how about making this a static method e.g.

Entities.waitForServiceUp(Entity entity)
can you hunt down the rpm and yum names?
(and drop the port -- just replace with a comment in the header of the class that user on os x will have to do one-time setup to deploy on mac)
Again this look strange to include in the test file. It needs a FIXME and some explanation.
Right, je voulais faire simple
je ne pense pas que les 2 soient incompatibles, plutot cause a effet.
I would name this either "ping_time" or "ping_ms".
That doesn't feel like a warning to me?
This is an explicit action the user takes; pass in an option. When that option exists I expect informational messages about it, not warnings?
what the user gets ? a json '"ok"' or a string ? 

can't we have a structured json response so it's future proof

{'result': 'ok'}
default values for these ones should not be ``null`` as this would lead to issues if the same key appears in both of them
On 28/02/2012 13:13, Ben Francis wrote:
>>
>> -<div id="video-controls">
>> -<span class="button" onclick="Camera.toggleCamera()">switch</span>
>> -<span class="button">capture</span>
>> -</div>
>> +<video id="viewfinder" autoplay>  </video>
> On Tue, Feb 28, 2012 at 8:17 AM, vingtetun<
> reply@reply.github.com
>> wrote:
>>> -<div id="video-controls">
>>> -<span class="button" onclick="Camera.toggleCamera()">switch</span>
>>> -<span class="button">capture</span>
>>> -</div>
>>> +<video id="viewfinder" autoplay>  </video>
>> 'video' was a bad name, 'viewfinder' sounds a bad name too. What about
>> 'display'?
>>
> Seems like an OK name to me http://en.wikipedia.org/wiki/Viewfinder
>
> "display" is very generic

Sounds good for good english speaker :)

But I won't argue too much about that.
I think getClient was added after @arturo-c started on this task.
Just add the PASSBLOB pass_flag to these objects.
why using a ``sundown`` subnamespace for a single class ? It is already named ``SundownParser``
Массив boolean -- это совершенно нечитаемая штука.
Ты удалил файл PerformanceTest, но не добавил import - так не скомпилируется.
The controller should definitely deal with the merged User model (which is created especially for the client API) rather than the Oracle data accessor (which is a read-only source of date for the User). We'll fix this in a follow-up pull request today.
maybe we should send the error back up to the socket, too?  meh.
I don't understand why this needs to be an interface
do we have a issue if we use a list of tuple?
Indeed that makes sense, I haven't looked at this in a while and forgot about the routing requirements. As far as I can see the patch looks good then.
You could not require "thincloud-test" in the helper and manually load the components you want.
Me thinks you forgot BlockAction here...
Yeah, I think this was tabs again.  Let me know if you continue to see weird whitespace.
If this sleep is necessary for some reason then it needs a comment explaining why, otherwise it should be removed. 

Presumably it was added because you had a problem with pg_ctl returning before the database was started.  This can be solved better by passing the "-w" flag to pg_ctl.  See "pg_ctl -?" for details.
Personally, I can see how this import statement is appealing.  But I know there are constituencies that don't like to see it, so normally list each import.
If the orientation is 90 or  -90 then the device is in landscape mode and as such it's height is gonna be the maximum width of an image we are displaying. If the information is not available or the device is in portrait default to width.
Why do you need the Minecraft launcher for this part of the program anyways?
I had some issues previously where when I ran in release mode, unless I had called copy on the block object, the objc runtime would throw an error on retrieval of the block. Might want to check this.
Ok, dans ce cas là le signaler aussi dans models/DocEtude.java pour centraliser tout au niveau des objets
"Better" error message?  Paula likes it, anyway.  And here begins the label swapperoo.
Is this question still pending? (i.e. should it really be merged with the question in master ?)
Only directories will be added to the inotify watch.  It will be up to the client that calls CFile::monitorDirectory to determine if the file/directory that changed was the one of interest.
It doesn't under MSVC2008 anyway.
wuid declaration was removed, so it may be referring to a global object. Is this intended?
I had the same thought when I did this, but I needed something that you could register at any time and it'd only unload in the end (so it doesn't need to be loaded twice, if required), even though I haven't implemented it that way. Also, I remember having problems making SharedObject implement CInterface (thus allowing Owned pointers).
Actually, I think it's correct as is. The col field refers to fields in the row initializers, and they can't have any attributes in except payload, which has been moved to the front.
What is the actual difference here?

Is it just a change of line break characters?
@maartenkling 
i think this comment was unintended right?
I think delete is fine.
I tried bust I must have missed some. sorry. Do you put them back?