labofsahil/github-event-dataset-2012 huggingface dataset:
Good point, got that fixed now:
https://github.com/perdjurner/cfwheels/commit/8bf21528aa16aaea561b10a43269f2205f1cb4a5

Don't know how to write tests for this though since I'd have to read
cookies on the next request.
I've done some manual testing obviously to make sure it works.

On Thu, Jan 19, 2012 at 5:26 PM, tony petruzzi
<reply@reply.github.com>
wrote:
> AFAIK the httpOnly attrirbute is only supported by ACF9. ACF8 and Railo (curretnly) do not support the attribute. this is the issue for railo:
>
> https://issues.jboss.org/browse/RAILO-1339
>
> and a link to the discussion:
>
> http://groups.google.com/group/railo/browse_thread/thread/43ec0d55cc76a088?pli=1
>
> there is also code in the discussion for supporting this in ACF8. AFIAK we aren't dropping ACF8 support until 2.0.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cfwheels/cfwheels/commit/2289bcf1dc359eda3d391891712c405070a53012#commitcomment-882620
I've tried to reproduce the crash this morning but couldn't. Good that you threw this back to me. Reject my patch for the moment. If I stumble on this again I'll look at it more in depth.
yeah for heroku :/
It's not part of this change, but the error message should be printing the custom_uuid here. It would be good to store this in a variable to avoid this kind of problem.
we do not need main(). Please, create methods like load(...) {loadTokensConfig; loadProcessors;} You can call it from main or unit tests for example.
this looks like a bad rebase
oh yeah, funderar dock p att byta till fortran... men det orkar jag nog
inte frresten, har du hrt med sgs?

On Fri, Jan 27, 2012 at 8:27 PM, Linus Oleander <
reply@reply.github.com
> wrote:

> Looking good
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/weierstrass/ODF983/commit/94456b69d89dd3c2632eecdee8569e22e592dfa7#commitcomment-909392
>
Does that code help?
@dmeadows013 your vendor repo got changed some how...either by you or something else.
rm -rf vendor/cm; repo sync;
No, it does not. ;-)
Nice, I just discovered Polycode this morning and was looking for this. Polycode looks awesome.
wtf? это меня глючит или в коммите реально нет того, с чем конфликтует?
Conflicts:
	`scripts/northrend/ulduar/ulduar/assembly_of_iron.cpp`
	`scripts/northrend/ulduar/ulduar/instance_ulduar.cpp`
	`scripts/northrend/ulduar/ulduar/ulduar.h`
I assumed you had bound TAB to auto-complete instead of smart-tab. Auto-complete works well enough with yas. You to need to get used to the dropdown a bit been using it for 2 months now in all my projects. Configuring it for all modes is a bit of a pain though.
thanks @Vincent-Michael for pointing about issue in MoveJump
I would suggest using $_SERVER['REQUEST_TIME'] instead of time().
Glad to see you are keeping to update this really useful gem, I'm a Rails newbie but I will start using Rails seriously I will definitely need this, I just want to tell you **THANK YOU** ;) (sorry for using this space for that)
Yeah. Got that. Reviewed the code after posting. It works awesome. So glad I found your post. 

On Jan 25, 2012, at 9:32 AM, Travis Northcutt <reply@reply.github.com> wrote:

> No, you'd still need to set the trigger to manual, like so:
> 
> ```
> $('.popup-marker').popover({
>        html: true,
>        trigger: 'manual'
>    }).click(function(e) {
>        $(this).popover('toggle');
>        e.preventDefault();
>    });
> ```
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/tnorthcutt/bootstrap/commit/eaadadd692b4f3358489b70578bc59012a6c345e#commitcomment-900568
I'm fine with isXWikiLDAPAuthenticator
I don't like that fix. If it is possible to get the geocode from the waypoint at this place (or at this time), then it should also be possible at the place (or time) where the geocode member is set initially, so the geocode member would be correct everywhere in this activity.
I think this should be `ISendMessages : IBindEndpoints, IConnectEndpoints`. Same reason as above.
si compilar compile antes de subirlo pero ya tenia el commit echo
Balloon ID is going to need to be a string I'm afraid
Er? I commit this before i think.I will commit this in a minute.
that's from gnome-panel?
Major formatting problems with this comment :-)
I guess we need `mask` here to avoid receiving an async exception before closing all connections.
`length` on all these array methods should be `>>> 0` if it's going for ES5 compliance.
Sure will.
be careful, by changing the signature of the function (const int&), the method doesn't overload QDialog::done(int).
change parameter to "int"
Copyright wieder auf 2012 setzen
At the moment the only one is EntityDamagebyEntityEvent however you cant make a listener for this. You have to listen toEntityDamage and then cast it.
why do they start with uppercase ?
but even so a (null instanceof Value) would just return false
How about making `decrypt_image` return `@rows` and removing this line?
.svn isn't a file extension - unless you meant .svn-base
So today I tested warden on my freshly compiled core, using the default config on worldserver, except that i activated it and set FailedAction to Kick, turned Emuhacker on and was able to fly and speedhack at will for like 2 mins until it finally disconnected me, which leads me to think the sensitivity of the default config is not that high, so what config would you say is the best for fastest detection and action taking?, thanks.
Not an AD fan, so I totally missed the reference.
That's strange, you create and set subMap but never use it afterwards.
Thanks for the commit Jonathan. I'm going to rework one thing just to simplify it a bit though. I'll add this to the previous line:

```ruby
data[:params] = opts[:params] || {}
```
@lrowe 

> The overlays open inside the toolbar iframe

I actually kinda like the way that the iframe inserts it into a modal overlay in the parent frame because then things like TinyMCE can reflect the theme's styling regime.
Hi Madhu,
  The certificates are available on the UIDAI Developer portal.
  The file named as "uidai_prod_stage.cer" is the certificate
  put on the Developer portal as Production certificate and the
  "uidai_auth_stage.cer" is the one put there as Staging certificate.

  Either way, there are just 2 things that you need to try with.
warm regards,
subbu
   
On Fri, Jan 06, 2012 at 05:39:28AM -0800, madhu402 wrote:
> Hi Subbu
> 	Only private key i have added the below certificate for the sample but
> its is giving response error code 569 plz have look if i am wrong plz
> let me know or if you have certificates thorough which you have tested
> on system please let me know
> 
> This certificates are downloded from the below link:
> ----------------------------------------------------
> https://developer.uidai.gov.in/site/auth_cert_details
> 
> #ifdef SERVER_PRODUCTION
> 
> #define UIDAI_PUBLIC_CERTIFICATE "/src/uidai_prod_stage.cer"
> #define AUA_PRIVATE_CERTIFICATE "/src/public.p12"
> #else
> #define UIDAI_PUBLIC_CERTIFICATE "/src/uidai_auth_stage.cer"
> #define AUA_PRIVATE_CERTIFICATE "/src/public.p12"
> 
> The below 2 certificates are created by using the below link:
> -----------------------------------------------------------------
> http://www.ipsec-howto.org/x595.html
> 
> 
> #define TEMP_STORE_CERTIFICATE "/src/cancert.pem" // Data of x509 tag
> #define TEMP_STORE_KEY_CERTIFICATE "/src/cakey.pem" // Private Key PEM
> File
> 
> 
> Thanking you 
> Madhu
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/GeoAmida/AadhaarAuth1.5/commit/0136df6f8dcc7acb4df948fb982aac4771fd4ee9#commitcomment-843669
i need compiled extractors for windows
i see it: http://www.wowhead.com/spell=39096#used-by-npc
Mechano-Lord Capacitus :D
well, no. the spell has TARGET_DEST_CASTER type, its summoned at caster's position
Woah, that one is old. o_O
Static Reflection cannot have a ReflectionClass, because the class does not exist.

Staticreflection is only necessary during code generation, at runtime the "RuntimeReflectionService" is used.
But CAS offset is 16MB, whereas the absolute pointer might be anywhere between 0-ish and several GBs... I'm guessing it's more likely to fail than not...
Agreed that a Lock object is better.
I just pulled this down and it works for me. If you want to send the pull request officially, go for it, otherwise, I'll just merge the branch I have where I tried the code.
Great, cheers! :)
Вынес в коре сам.
will be corrected in the next push
@GreenLightning
Thanks for catching that. It should be fixed now :)
SHA: 15732f38afa95420747d7aa4dc33d9e128a77f56
Shouldn't Fall.wav be put in the res folder?
可是我剛剛試過，沒加的話看不到highlight。
no, it is definitely a bug, but I am not sure if there is a more generic way to write the path than the one I suggested.  The one I suggested does work.
no they're not, they need offset by 0x300. its a todo.
I wasn't 100% sure if we have some filters that would require the rate information to be available. But now after thinking it a bit more there is no other filters that depend on the rate. Also there are some other methods we need to expose from the TimeStretchFilter - like the notifys it is going to receive from the video renderer thru IAVSyncClock interface. 

I'll remove the SetRate from IAudioSink interface and create a new one for the timestretching needs.
Did you re-run CMake?
I somehow liked the old README better.
Thanks -- this high-level routine makes it a lot easier to figure out what's going on.
I couldn't get around this one. Consensus on tcsh seems to be that you can't redirect stderr to a variable. Otherwise I would have.

We can talk about whether my solution is acceptable. Originally, I wanted to create and destroy this temporary file entirely inside of the loop. BUT, the glue shell prompts users for deletion confirmation, even when you type `rm -rf`.

```shell

y:~: mkdir Dummy
y:~: cd Dummy
y:~/Dummy: touch stupidfile.txt
y:~/Dummy: ll
total 12
drwxr-xr-x   2 briandk  osl         2048 Jan  6 10:22 .
drwxr-xr-x  11 briandk  osl         4096 Jan  6 10:22 ..
-rw-r--r--   1 briandk  osl            0 Jan  6 10:22 stupidfile.txt
y:~/Dummy: rm -rf stupidfile.txt
rm: remove stupidfile.txt (yes/no)? yes
```
you could with get height and get left i think i still have not gotten to
test this out we ran out of time at school

On Wed, Jan 25, 2012 at 10:09 PM, MichaelStevens <
reply@reply.github.com
> wrote:

> How can this work? If we get a rectangle we can't get the two different
> sizes of the sides.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/erhs-53-hackers/VisionTech/commit/6ca04764da6f9afef20ade26fc8183a124090f62#commitcomment-902911
>
round принимает аргумент, насколько округлять 
например 
before_save do
    factor = 2
    self.price = price.round(factor)
end
Awesome. Thank you. I love clarity.
To set a check box you could use
```<input type="checkbox" name="cache" value="Use Cache" checked> ```

If ```conf``` was a check box control, you could test ```document.forms.Superfecta.conf.checked```
Probably because I didn't set develop to push back up. I can push it up?
thanks for your input. 

Out of curiosity... Do you import straight from Image because of older versions of PIL?
Only the line ordering is different.
2012/03/05
You want a concatenated string here.
The $('form') submit is enough to capture any of the options.

Instead of using click events on each option, you can use $('select').val() to find out which one was clicked on.
Are you just duplicating the comments that getDamageCodeDtos should have?
ça fait quoi ça ici? :p
I believe I was referencing my first draft of it and working on a new js file with Wendy and that's just what we named it to differentiate the two. My apologies,
Amanda 

Sent from my iPhone

On 2012-02-20, at 3:39 PM, Thomas J Bradley<reply@reply.github.com> wrote:

> Why's this file named `jquery2.js`? It doesn't really describe the file.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/amandamarochko/mtm1526-homework-4/commit/1b02edba5703d054943bea74745187852c3e241e#commitcomment-987259
I don't think it changed anything except made the logout call happen 2 seconds later. Maybe that changed something "under the covers"
Was niet echt mijn bedoeling om die te veranderen, maar bij mij op de computers heten de mappen anders. Ben ze vergeten achter terug te veranderen.
Row 136: Could be "länk" or "länka" depending on context.
Row 175-176: Dunno at the moment.
No need for this file any more
'# factorNames -- renamed (used to be called 'ef');' can go
I mentioned trying to localize these tests to use  `--find-link`s,  but I consent that it's not fair to have it required for this pull, especially considering that I'm running into bugs related to using `--find-links`, `file://` urls and `-U`.  I'm working on pulls for that stuff now.
turned private 27ef7b0 for now

but should the number of such function grow, it would probably be nicer to have some kind of 'BackendInspector' object.
WDYM?
The protocol identifier "akka" supposed to be a constant.
Ah buggah, yes, I fixed it for the cause case but not the (my) no_cause case.

When you gonna push? :)
why this schedule and latch?
I think all this can be written with one awaitCond
great catch, fixed
Did you need FixedRateTask after the scheduler fix?
Unfortunately, this will cause SSL certificate verification to fail on all Python versions < 2.7.3.  The endpoint we use MUST match the commonName in the SSL certificate since the Python ssl module is unable to find the subjectAlt fields in the certificate.
Yes, this is IMO the correct cross platform way.
The thing is, the syntax cannot be used for class with EventDispatcher, because the syntax writting is using our own properties. Default values are in properties, not in the __init__(). It's even faster. So even if it speed-up for that case, i would avoid you to do it on others classes.

For benchmark, you're right, it simply not benchmarking others classes.
It's ok.  The effort is appreciated.  I'll keep these requests open for the time being.  However, I probably won't work on these until after 0.92 final is out, which will be this weekend.
try to avoid adding unnecessary commits it makes reviewing more work - stuff like tis is good but should be done as pull requests on their own
table group is a deceiving name too so it feels right to stick with it plus anything better you can think of?

On your main point I really think it would help clarify things a great deal as I don't like the old tables dual purpose I think that pulling the two things apart helps bring clarity to the situation.  As far as the revisioning goes could we not just leave the old 'dead' table and start a fresh new table?  Maybe that is just a cop out and the revisioning is extremely important and needs to be maintained.

I could live with the old table but it just feels like keeping things confused and keeps that capacity thing hanging around - the public/private thing seems like it should be part of the organisation not the join
Fixed the missing blank after gettext and joined them with the rest of the Pulp imports.
so... you tested setup?  :)
ALSA issues are hidden if you have CPU ponies, these issues are showing up on CPU limited or embedded (arm) platforms.
isn't this check unnecessary, given the fact that g_langInfo.GetAudioLanguage will always return a 3char code if not empty?
date_removed необязательно проверять. За тебя это делает менеджер модели.
lets move all of the tests into a ./tests directory

If you want to be fancy, you can make a Makefile in the main directory that runs all of the tests when you type "make test"

The Make target will look something like this:

UNIT2=YELPCODE="$(shell pwd)" unit2

test:
$(UNIT2) discover -v -s tests -t .
Ahhhh. Got it.
So this is definitely confusing.
What happens when the PR page needs 3 pages?
这个文件是干嘛的？
So every RESPAWN_CHECK_INTERVAL, you check if it's GT LIMIT, and then reset it to 0. So it will only stop respawning if they fail more than LIMIT times within the CHECK_INTERVAL. Might be worth a comment/docstring or put the numbers in the error log ;

  log.error("Respawn count limit reached. Too many failures! %d within %ds" , self.zygote_respawn_count, self. RESPAWN_CHECK_INTERVAL)
nvm, I saw the special case added after that
然后默认的False是模拟4.2.4以前的行为(嘛, 虽然我就没用过这个快捷键, 所以仅仅是猜得吧...)
They're still handled, because plugs cannot go recursive yet. That requires a bit more scout camp hackering.
For some reason, github.app refused to commit anything after I upgraded the specta xcodeproj. :\ I'll reverse it using the website now.
> Add a target/action for **a** particular event
Depending on how long it takes to solve constraints, there might be more overhead in dispatching to queues than just doing the work serially. I haven't tested the performance of this, though.
The convention I've used in other places in the code is g_strcmp0 (value, "value") == 0
Duplicate. Same goes for EventEmitter, you can just use events.EventEmitter below.
String comparisons for partitioned numbers like this scare me.  I usually use the utilities in RubyGems to compare version numbers, but I doubt we want to do that here.
Would it be useful to add automatic caching/memoization to RDD functions that return scalar values, such as `count()` or` stddev()`?  The memoization code itself could probably be implemented as a generic higher-order function that wraps the method definitions, similar to a memoizing decorator in Python.
Jak řekneš "metody navíc" ? Vždy když něco takového čtu, tak je použito tohle slovo.
Tado metoda by mela byt imo v driveru.
Done. I understand your concerns, but to maximize out-of-the box compatibility I prefer to set default output type to uncompressed NIFTI. I did the same for AFNI in another PR.
Argh.  You're right.  The XXX was shorthand to me to ask what should be done here.  The allocations are potentially large, and should probably be reported.  Ditto for the allocations in _compiled_base.

I'll fix this, but wait for guidance on npysort.c
Do we really trust clients enough not to verify arguments?
When can this happen? How can a string length be negative? And can `size_t` ever be smaller than `int`?
я бы оставил.
yep, just came from master
http://bfts.rubyforge.org/minitest/MiniTest/Assertions.html#method-i-assert

You would seem to be right, the message would go second.
There's an extra space on all indentation here.
It is possible to use only one method, because the second is only called from the first, but i think this would be less readable.  However, i cannot default the last argument to `nil`, because the problem is not with the last argument but with the last 3 arguments.  If somebody is unfortunately calling this method (which is mostly used internally), then the person expects it currently to take 4 arguments, of which the last one defaults to `true`.
How about changing the backend to a new class that includes the fallbacks, and then returning back to the default in an `ensure` block?
If I understand correctly, this doesn't change the original behavior of `synthetics`, but just adds logging to certain methods. Right?
Maybe put this inside "with nogil:"
Is this still the ABCD formalism? I do not know how to use column matrices as ray transfer matrices. I will need some time to check this out in the reference that you have provided.
I'm not a fan of the warnings.  I would just remove them.
...or, after importing operator,

```
key=operator.itemgetter(1)
```
comma after exponentials
This looked better before.  Now it looks like "Number divided by zoo".
"a string" ?
perhaps (based on the deprecation comment) this could be

```
elif hasattr(pattern, '_has_matcher'):
 ...
else:
  raise 'non-Basic args without a _has_matcher method are not supported'
```
```
    x, y, z = symbols('x y z')
```
Should be:
```
Manual installation
-------------------
```
Instead of your:
```
Manual installation
------------
```
Is it to save a function call?
This function didn't what?
These assertions fail and I don't know why.
Have we captured the associated deployment work to get real values into the relevant environments?
I would mention here that only app developer and app tokens (as of the time of the writing) can be queried.  If it changes, we can update it then.
@ctalkington I have node 0.6 and 0.8 cloned into separate folders. Then just do a `make install` in the version folder I want to switch to.
Hier nur $editprofileForm übergeben
I'm not sure how to parse this.  "had becone" ?
еще раз нет. новые гет пареметры не делаем. наверное можно `debug=profile` или куку `profile`
ну и соответственно `get_cookie_or_url_param_value` переделать во чтото типа `enable_debug_mode_by_cookie_or_url_param`
пнятно излагаю?
actually what is probably better is to remove the specific table information from the db connector config
this title should be "rename a database" to reflect actual useage.
do we need to put system.indexes content here or  can we just list indexes using the common notation?
why is role="navigation" only used here in this block of links? why not put in on #tool-menus
The HTML output from EJS, yeah.

I don't want to run bleach on EJS source, because it's not HTML and bleach mucks up all kinds of things in EJS. (eg. `if (foo && bar)` becomes `if (foo &amp;&amp; bar)`)

But, I do want to treat the final output of kumascript as HTML and sanitize it. That way, kumascript output is treated to the same restrictions as human-entered HTML in a document. That helps protect us from some things like accidental XSS holes introduced via templates.
Query formatting + use the `_sql()` function.
I also am not at all convinced that this rewrites all page links (e.g. to index.php) to be absolute.
Join on groups is not needed.
Unless there is a reason to have this public, I'd make it private or get rid of it altogether.
Use $user->lang() instead of $user->lang[] so don't have to use sprintf, and you can condense this by 3 lines if you do so, I think.
Poți muta linia asta deasupra liniei cu from django.db, te rog? :)
Aici nu ar trebui numărate Activities (vezi mai jos, am zis să nu le salvăm în db) ci Message din baza de date. Filtrul va fi asemănător.
`_event`
After years of google code style, this looks a bit weird to me :-/
I think checks here should be explicit module names, contained in a CONSTANT somewhere :)
theres no reason at all to be worrying about putting or not putting the postgres jar into the lib directories,  its only the oracle one we have to worry about because its not publically released into the maven central repo (pretty lame IMO).
I see now where the Stacking game interfered. That's very strange, why are they both called skidrow? Are you sure you have the right path for stacking?
i remember talking about this before on owin online meetings and google groups that if it throws an exception it should fail coz nothing can be done about it. But there might be a situation when the app wants to perform clean ups. So I have brought it up in google groups for the exact behavior https://groups.google.com/forum/?fromgroups=#!topic/net-http-abstractions/mcYghGOO8TA
nitpicking style: remove unnecessary whitespace
Ideal would be if it wasn't one time only that the encounter was submitted. What if a doctor partially fills out an OPD visit but doesn't submit a diagnosis? We still want the data to be saved.

One approach might be to create the outpatient encounter as soon as one begins, and each time a new form is filled out, and "onBlur" (when focus moves away from) form, it causes an EDIT/UPDATE to occur on the existing outpatient observation (if it exists) or else a new one to be created. This would enable user to fill out any or all of the fields in examination tab, and update them too. 

Possible?
Don't bump the version number in a pull request
Now I understand the comment. So keep it :) Same for above.
:( я не специально
тяжело в учении, эх.
There is a largish block comment about a dozen lines up from here that really applies to this one line but seems by its (dis)placement to be trying and failing to describe all the new code in this block.

If the top-level while loop in this function was promoted to the for loop it is clumsily simulating (i.e. moving it++ from the bottom of the loop), "continue;" could be used in the if's above instead of the "else" we are in now and instead of falling through HERE to process the non-existent indexes on an export table, and possibly in other cases. I think that less nesting would make the code easier to follow.
( new line and rest of line
Для чего здесь `process.exit(0)`?
This commit does the latter, uses join and puts them at the back of the queue. I guess in the case where many dbs are very active this will give them a chance to settle down.
This merits more investigation/discussion.  I worry that this is something else that won't be fully resolved until we complete upcoming discussions.
The tests do their own transaction management, since the schema editor backend itself uses transactions and we need to check everything is working right. Not sure what improvement TransactionTestCase would give, they already run really fast.
create_path says 303, not 201?
Good catch.  This does not appear to throw this exception anymore.
This piece of code appears in very source file and is used by all the three functions.  If any of the args is NaN, I want the functions return NaN directly, which can't be done by function. 

So if this is not a serious problem. Could I just keep it?
Okay. i moved the cache to a per world base.
the instance_id which i am using here is unique in the whole item_instance table.
I assume ws4py depends on rather low level access to the socket which first was owned by CherryPy, so it should be possible to make CherryPy hand over a socket/fd for use by GStreamer as well. The place to implement this is probably as a CherryPy plugin.
What happened to the hanging indent stuff we talked about? Should probably be:

```
uri_schemes_by_backend = {backend: backend.uri_schemes.get()
                          for backend in backends}
```
or
```
uri_schemes_by_backend = {
    backend: backend.uri_schemes.get() for backend in backends}
```
*Sigh*, committed wrong code branch;  lemme fix this
The Clang build, as given by `brew --config`.
You want `ENV.cc` here.
Pointless test, just omit it if it's not feasible to test the software directly.
Yes, this should be pushed to upstream.
`+=` operator is a little shorter for this:

`path += "/Contents/Developer`
We have similar constants for vumi messages, which we use in the Transport class. This is the ESME client, which is supposed to be decoupled and reusable (although we need to clean up a few things before that's completely true), so it has its own set of session status values which just happens to be a subset of the vumi message equivalents.
I'll explain the option. I included it because without it, we end up with a URL something like "https://localhost/pulp/repos/repos/pulp/pulp/". While I understand the reason for it looking that way, it does looks ridiculous. :)
Nothing happens until the clock is advanced anyway, so this assertion would still pass even if the max traces were 10.  Maybe advance the clock 1, to show the only thing being tested is whether the max buffer has been reached?
`return_value` != `return_Value`.  When running it through the debugger, `trace_id`=1, and  `span_id`=2, but `parent_span_id` is a `MagicMock` object.  Tests still pass because calling `hex_str` on a MagicMock object works and returns `'0000000000000001'`.
We use these notations in many other files. After we'll update the documentation generation process and see that only one is needed we can update it everywhere.
We do, and it fails, but with a NullPointerException instead of an IllegalStateException.
指摘事項１
`assertTrue("timeSpent > 0", AbstractTimeWatcherTest.timeSpent > 0)`?
Option `C` feels friendliest to me, then `A` if for some reason you'd need scoping
You should also check for WebSQL.
I realized that all of these new tests depend on a change to 'brackets-scenario', so I merged that earlier today.  It seems a little weird that these tests in the public repo can only be run if you have access to content in the private 'brackets-scenario' repo.  I filed #1053 on that issue so we can think about it later.
I'll check with Yoko. Presuming the user's locale is fr-FR, the i18n plugin would look for the following folders in order fr-FR, fr, then root.

On mac, brackets.app.language only returns the language code. Mac treats country codes separately for date/time/number formatting preferences. I could change this behavior if it makes sense.
@GarthDB you are welcome to fix it, otherwise I will. Does "shift down 2px" sound about right?
I pushed changes to clarify this. Now there are "menu section constants" defined in Menus.js. AddMenuItem() can use these constants with the relativeID and use the position LAST or FIRST to control where in the section the new MenuItem is inserted. I added comments to the constants area and AddMenuItem to describe this. I haven't done the implementation for this so I left a todo in the code.

-----Original Message-----
From: Narciso Jaramillo [mailto:reply@reply.github.com] 
Sent: Wednesday, May 23, 2012 11:07 AM
To: Ty Voliter
Subject: Re: [brackets] Menu, MenuItem, key bindings, and Command API (review only) (#927)

> +
> +    /**
> +     * Adds a new menu item with the specified id and display text. The insertion position is
> +     * specified via the relativeID and position arguments which describe a position 
> +     * relative to another MenuItem or MenuGroup. 
> +     *
> +     * Note, keyBindings are bound to Command objects not MenuItems. The provided keyBindings
> +     *      will be bound to the supplied Command object rather than the MenuItem.
> +     * 
> +     * @param {!string} name - display text for menu item. "---" creates a menu divider
> +     * @param {!string} id
> +     * @param {?(string | Command)} command - the command the menu will execute.
> +     * @param {?(string | Array.<{key: string, platform: string)}>}  keyBindings - register one
> +     *      one or more key bindings to associate with the supplied command.
> +     * @param {?string} relativeID - id of menuItem or menuItemGroup the new menuItem 
> +     *      will be positioned relative to.

How are menu item groups defined and positioned? I don't see any API functions for them here.


---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/927/files#r869787
You're definitely right... I'll need to go in and fix that.
Looks like a tab instead of 4 spaces -> do a find & replace in this file.
I think we should move this to User document or manager? So that all code for creating users is in one place and not that we have API for creating users but we then do it manually somewhere.
To `auth_models.User.objects.create_user(username=username, email=fb['email'])`.
Trust me, we do.
This actually won't work in IE9, we need to at least add a .woff version, see:
https://webmademovies.lighthouseapp.com/projects/65733/tickets/1534-font-face-needs-to-include-woff-and-possibly-other-versions
Wenn phpdoc, dann am besten gleich richtig, also normale Groß-/Kleinschreibung und inklusive aller Parameter. Ich weiß nicht, was sonst bei doxygen rauskommt, wenn die Parameter im phpdoc nicht mit den wirklichen übereinstimmen.
Woops! I will remove this.
Moved it all over to the next line
`FS.readFileSync(PATH.join(path, '.tstcfg'))`
We should probably document this alias or remove it. Functions like `setPanicHandler` do not use aliases, the rationale being that the type is only used once in the public interface. Perhaps that's a good idea here too.
`lua_isnil` maybe?
Stefan, you suggested what I think is nice syntax. But I pushed a changed version that acknowledged the excellent review comments from three of you. For authors, I still left you first, Harlan, because you started this train rolling.
`Foreman::Environment.delete` returns `true` or `false` this will fail
I think this after block can be removed.
The `Rails.env` is used to load `:prodution` or `:development` or `:test` group, it should be used only once. 
In the case you are describing I would prefer:
```ruby
if defined?(Bundler)
  Bundler.require(:default, Rails.env)
  
  # require backend engines only if in katello/cfse mode
  Bundler.require(:foreman, :pulp, :candlepin) if Katello::BootUtil.katello? 
end
```
but it's not that important, I leave it up to you ...
Make this `IList<ParameterDescriptor>`
I would recommend using createElement, setAttribute, and appendChild instead of string concatenation, however if the code ends up being big, ugly, or slow because of doing it this way, string concatenation is fine.

An advantage of using appendChild etc is that the elements will appear incrementally in the page. This might be a slight perceptual speedup, and it might look nice too.
Also assert that the correct `temp_url_sig` and `temp_url_expires` values are in the request headers.
This appears to be missing a description - that is, it should probably be something like:
```
unit : UnitBase
    The newly-generated unit object.
```
I don't have a strong preference, and I can see @eteq's reasoning behind this. I don't think it really matters too much unless it's a class users are going to make use of extensively. I don't think arrays are a justification for using the plural form.
This time prediction stuff is very cool.  Perhaps it should be moved into its own module (and abstracted) so that it can be used by the other services that we implement in the future?  We'll certainly want to do the same with them.  (Or maybe the services are too different to make that work...)  Again, that might not be something to hold up this PR, but we may want to create a new issue for.
'metadata will'
Actually, using the correct locale, this word ("Tokyo") is valid `alnum`, isn't it?

There should be a case verifying such cases by switching to the correct locale.
If the CheckDiskSpae check is moved to FindBlockPos (ACK on that), I don't think we need it here anymore at all.
I do wonder why strlen is still used in the line above this, though. I guess the consistency argument doesn't hold either :-)
I would use ellipsis, as it is the key expreses the same thing everywhere else in the framaework
Please keep the model alias in the error message. Also `assoc` should be `Association `.
FYI I would personally have used something this:

```
var layersConfig = (function browse(node, config) {
    for (var i=0, len=node.length; i<len; i++) {
        var child = node[i];
        if (child.children) {
            browse(child.children, config);
        } else {
            config[child.name] = child;
        }
        return config;
})(Ext.apply(this.themes.local, this.themes.external), {});
```

(Untested)
I'd write a comment, see that another participant gets a notification about the comment. then delete the comment, and make sure that it is no longer in the participant's notifications.
This won't have the desired effect. You would need to fully qualify the name with `traitsui.handler.Handler`. However, I'm not opposed to importing from `traitsui` in this file. I *am* opposed to having an explicit `traitsui` dependency on an Enaml api file, where the cost will be paid even if the user doesn't use that functionality.
On 8/11/12 1:23 PM, Jesse Reynolds wrote:

> What about: git mv commit edit edit commit ?

Seems clunky to me that there is non-obvious data loss there if you miss 
that first commit; if Git can't preserve that information then mv isn't 
really a safe operation.
this is a method on tempfile.  Ensures the file is closed and deleted.

http://www.ruby-doc.org/stdlib-1.9.3/libdoc/tempfile/rdoc/Tempfile.html#method-i-close-21
Don't know how I feel about top level attributes.  You have protected them using the JS module pattern though.  The alternative would be to create a class that has all of this logic.  @Carreau what do you think about this?
Thanks, I made this change, though it isn't true that it eliminates the flicker.  Actually eliminating flicker will require changing how clear_output works in a more complicated way (don't resize height until *after* new content is drawn), because as it is now, it's still resizing to zero immediately before drawing the image, which takes more than zero time (though it is very quick).
will fix it tomorrow.
@markhuot Do you think it would make sense to check for the existence of a getter method for a certain attribute instead? Obviously, these can be used to simulate the existence of attributes.
There is a problem, I think. I believe when the function calls `git_tree_free` on `tree2` then `entry` pointer is no longer valid memory. It happens to work but it will not work consistently. Unfortunately, there is no way to return the `git_tree_entry` pointer without either leaking `tree2` or returning a pointer to memory that has been freed. I know this because I actually wrote the same function myself at one point and then ended up writing instead:

```c
GIT_EXTERN(int) git_tree_resolve_path(
       git_tree **container_tree,
       int *position,
       git_tree *root_tree,
       const char *path);
```

which returns the tree and index in the tree of the path item. Where is this code? Well, it's in a submodule overhaul branch that I haven't got in a very good state to push yet, but I can push just this tree function.

This is all actually very similar to the existing `git_tree_get_subtree` which might or might not quite work for you. In my case, it didn't quite work as I needed, so I wrote the above function and then reimplemented `git_tree_get_subtree` in terms of it.
I thought about that, but engagement has been pretty clear that they want it to happen inline in the page. What happens if there's an error on the form? We have to redirect back and have we that annoying problem with forms.

I'm open to it though if we can make it work.
This was copied the firefox base template in the dev branch, and in that one some are hard-coded, some use php_url and some are url('named.view'). Since the landing branch doesn't have all the rest of the mozorg pages I switched to php_url for most but didn't switch over the hardcoded ones (wasn't sure why they were hardcoded, so I left them alone). But I can make them all php_urls easily enough.

At the very least we should never hardcode a locale, and something like href="/mobile/" would still let the regular locale detection redirect appropriately.
Why not change this to checkboxes?
I pulled the wording from the bug itself.
Plus you can't assume the incoming arg is a hash unless we are forcing Hash params.  Another reason to go ahead and enforce it.
($user->getUsername() != $this->getUser()
Exceptions are used for critical errors, this is not the case here. The method has 2 possible outcomes:
- returning the pattern when it can find one,
- returning `null` when it can't - this is an expected outcome not a critical error.
see fabpot/Twig#774
Ok I reverted last commit and did what you said.
If it's ok for you, I'll make the tests pass again and update the changelog.

Now let's hope that users won't use the constructors directly for proxies...
``null === $lifetime``
I sent you an email. Private messages have been removed from github.
I guess stolyd meant why you don't simply inline the methods? And I agree.
It's only used once anyway.
please follow the coding standards:

- ``break`` is dead code so it should be removed
- the ``return`` statement should be on its own line
IMO they should accept a Request object so it is not dependent on RequestContext anymore.
An alternative would be to leave it as before and use `RequestMatcherInterface extends UrlMatcherInterface` as an empty marker interface for UrlMatchers that also accept a Request in `match()`. So `matchRequest()` would be removed from it.
Fixed all above.
(after next push)
What was wrong with defaultProfilePhotoID?
Can you try setting this to 2L?
I'd use jQuery validator plugin for validations (already used in some modules), then you do not have to show/hide the error and the errors are dynamically added (the view template is cleaner). It basically makes writing validations pretty easy without handling keyup or similar events.

How to use it (example for validating repository alias):

- add a new validator method via jQuery.validator.addMethod() (which returns true/false depending whether the value is valid or not, with error message when it's not valid) (see e.g. https://github.com/webyast/webyast/blob/master/plugins/software/app/views/repositories/new.html.erb#L35)
- add a class to the input field to bind the validator method to it (https://github.com/webyast/webyast/blob/master/plugins/software/app/views/repositories/new.html.erb#L160)
- in document.ready() activate the validation for the form (https://github.com/webyast/webyast/blob/master/plugins/software/app/views/repositories/new.html.erb#L160 contains more options, just simple $('#myForm').validate() should be sufficient)

... and that's it!
When you and I tried it when we originally wrote it that didn't work.
Generally the === is used over the == in JS

http://stackoverflow.com/questions/359494/javascript-vs-does-it-matter-which-equal-operator-i-use
These changes?
изначально все хранилось в переменной класса @pixels_per_day, надо бы во всем проекте пробежаться и заменить на set и get
What if we store a string containing a JSON serialization of our parameters in the second string ?
Better to break before the parenthesis, but this is still compliant.
What do you think about:

```js
registry.defineNode()
    .outputs('variant.' + flagName)
    .given('variants-request-context')
    .with(function (context) {
      return variants.getFlagValue(flagName, context.get())
    }
```

If it happens within request scope (which is should) then it will be cached automatically for the duration of the request.
Hash required: {{#1.2.0+}}

The markup mirrors handlebars/mustache block expressions.
Images should have titles too, for screen readers and SEO

![AWS Marketplace Setting](/images/aws-marketplace-settings.png)
I'm pretty nervous about symlinks *across repositories*.  Among other issues, it creates version dependencies between the repositories that are only resolvable when we happen issue new tags (and even then, only implicitly). 

It might make sense to extract the "testing" code out into a separate repository.  See, e.g. [this StackOverflow question](http://stackoverflow.com/questions/2896944/component-based-web-project-directory-layout-with-git-and-symlinks)

... while I don't relish the thought of dealing with an increasing number of submodules, I think cross-repository symlinks will come back to bite us.
Hi Ben, I think you are correct about #2, I will remove that part of the tests.  

But when I tried to use a test for Object(v) === v, I ran into problems with Dates and RegExp.  So rather than add code to check for v instanceof RegExp and v instanceof Date,  I will not change to use Object(v) === v.
Missing a 'g' here :)
I copied/paste the 1.1 XSD without reformatting it to simplify diff if needed.

I'll format it correctly
Does this https://issues.jboss.org/browse/AS7-4057 feature intend to allow _individual jars within a deployment_ to be able to have their own logging profiles (ultimately a LogContext)? Or is it expected to allow _each (sub) deployment_ to be able to specify a logging profile of its own? The code above can lead to problems with a (sub) deployment like this:

        myapp.war
          |
          |--- WEB-INF/lib
          |          |
          |          |------- foo-library.jar 
          |          |           |
          |          |           |----- MANIFEST.MF (Logging-Profile: foo)
          |          |
          |          |------- bar-library.jar
          |          |           |
          |          |           |------ MANIFEST.MF (Logging-Profile: bar)
          
         


The code will end up trying to register 2 different profiles (foo and bar) to the same deployment unit classloader and will fail. I guess the goal was to allow the logging profile to be configured per (sub) deployment level. If that's true then we should be working on the "deployment root" instead of each of the resource roots in that deployment, to find the MANIFEST.MF file.
Actually, there's a bunch of whitespace inconsistencies here. I'll hand merge some of this and also provide a monkeypatch for File.write until a backports release supports it.
And a last `free` here, before returning from the function.
Or whatever that don't break the 80 lines limit but the current is broken :)
I agree we need a class name here, I just say that “toggle” is not a good name, and I suggest to use “switch” instead. That might be something you want to check with a native English speaker.
https://gist.github.com/2905079 (untested)

Let's update `ContactDataManager` with this. It will do everything asked with much simpler code (do you know why?)
This function is much clearer now, and I like what you've done with the class names.  (I could swear that I used "opening" and "closing" here, too... I don't know when that changed.)

The reason the code used to check e.propertyName is that I found that the listener would get called twice if two different CSS properties were being transitioned.  So if you're changing the transform and the opacity, it might be called twice.  Maybe that was a bug that has gone away, but you should be sure about that before landing this.
In order to have your code ready for being responsive you could add `font-size: 10px;` as in `settings.css`.
I think UX will want you to use the term "memory card" instead of sd card.

Here are some similar strings from gallery; maybe some of them will be helpful for your app

nocard-title = No memory card found
nocard-text  = Insert a memory card.

pluggedin-title = Gallery cannot be used while phone is plugged in
pluggedin-text  = Unplug the phone to browse pictures.

memorycardfull = Cannot edit photos: memory card is full.
nit:

      navigator.mozSettings.getLock().set({
        'ril.data.enabled': !enabled
      });
Are we going to have parent always? Will this work when the contacts app will be invoqued without the dialer?
Can you remove this line then https://github.com/mozilla-b2g/gaia/blob/master/build/preferences.js#L171 <- I added this over the weekend because it was broken on linux.
`this.show(origin)`
I don't think you need this one line function
thanks to you
Remove references to spanish, prefered english here :)
@jlebar: http://www.w3.org/TR/vibration/#widl-Vibration-vibrate-void-unsigned-longArray-pattern

"Odd entries represent vibration time in milliseconds, even entries still periods in milliseconds between the vibrations."
I think you can use pr["head"]["ref"] instead of "label"
this(kuduSettings: null) is clearer.
I can't pull down update. But did you fix the error where it is no longer printing the optparse on the illegal option error:

```
aeromachina:Razor lynxbat$ razor -nc
invalid option: -c
```
fixed in 090173b
As I already mentioned some days ago the noun 'record' is a little confusing here. What about something like 'recordedPositions'?
The newline separate json protocol was simple to start, but it would be nice to avoid json serialization cost for large bodies of code and generated html. The json structure could contain a content-length of bytes to data bytes that follow.
If you remove these changes and push to github, then I can merge this PR. I could also make the changes myself, but I'd like to give you credit in the commit log. If you'd rather not bother, just let me know.
oops, var isn't needed... that isn't supposed to be global
Agreed - sounds good to me.
`ents` is a bad name for this variable. Just call it `entities`.
Correct, but no one should be writing `=== false`. Most of our boolean functions only guarantee that they return a truthy value.
done. you're fucking stupid bro
For authentication in the Zendesk API, you must append "/token" to the end of the user email if you are authenticating with an API token rather than a user password.
Do we need a separate 'childI' var here? It seems like we could just use 'i' and increment it here (yes, using separate 'lineNum', and 'childI' vars is more explicit, but since the old code just used 'i', it seems like it may be best to stick with that).
Yep, there's a bunch of them I left in but commented out.  I intend to remove them as the code stabilizes,  Otherwise, they're convenient when things go wrong and troubleshooting/debugging is needed.