labofsahil/github-event-dataset-2012 huggingface dataset:
[Style guide](http://codeigniter.com/user_guide/general/styleguide.html) says that `&&` should be used instead of `AND`. However, after 77bd21b15305412b63c8f448787d5b275efd07e2, you'll only need to have the `! empty($get)` check here.

Also, please change the file permissions back to 644. :)
This is not consistent with the output of the --parenComplete option. One of the two should be changed so that an editor's parsing/display code can be the same for both options.
Хитро.)
Старайтесь не использовать "магических чисел". 3 == (NUKE_LEN - 1).
всегда приятно наблюдать дискуссии под моим кодом, но с float в цикле while (именно с таким условием проверки, где есть только одна возможность выхода (с проверкой на равенство нулю)) я бы не шутил. а с int вполне реально
Если честно, то я не понял в чем здесь проблема - строчкой выше прошел super init значит обьект создан, память выделена, можно уже с ним работать. 
Ты же в своем коде написал [self DNA] но, насколько я понял синтаксис obj-c, то это идентично self.DNA
Этот метод можно реализовать немного проще используя [NSArray componentsJoinedByString:]:

``` objective-c
-(NSString *) description {
    return [self.DNA componentsJoinedByString:@""];
}
```
I have to add wfsUrl, layer, and commonAttr here, so will I need to do this here or somewhere else?
MUST NOT
We should read in the error message in the response and display it in `mErrorText`. Or display a dialog if it's a parse or connection error.
这里异常处理，我的意见是如果他注册监听:exception,我们就通知handler，否则就直接抛出异常。
glad you immideatly see the gains ;-)

On 25.12.2012, at 23:36, Eric89GXL <notifications@github.com> wrote:

> In examples/preprocessing/plot_ecg_artifacts_from_ica.py:
> 
> > @@ -41,7 +41,7 @@
> >  # between 0 and 1 to select n_components by a percentage of
> >  # explained variance.
> >  
> > -ica = ICA(n_components=0.90, max_n_components=100, noise_cov=None,
> > +ica = ICA(n_ica_components=0.90, n_pca_components=100, noise_cov=None,
> This does seem more explicit to me. Nice.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Nice! I'll remove those, then.
please add a docstring
Ahh, alrgiht. Didn't realize None already had a meaning... nevermind!
;-)


On Tue, Nov 27, 2012 at 3:06 PM, Martin Luessi <notifications@github.com>wrote:

> In examples/connectivity/plot_mne_inverse_coherence_epochs.py:
>
> > +# License: BSD (3-clause)
> > +
> > +print __doc__
> > +
> > +import numpy as np
> > +import pylab as pl
> > +import mne
> > +from mne.datasets import sample
> > +from mne.fiff import Raw, pick_types
> > +from mne.minimum_norm import apply_inverse, apply_inverse_epochs,\
> > +                             read_inverse_operator
> > +from mne.connectivity import seed_target_indices, spectral_connectivity
> > +
> > +
> > +data_path = sample.data_path('..')
> > +fname_inv = data_path + '/MEG/sample/sample_audvis-meg-oct-6-meg-inv.fif'
>
> +1 having these forward slashes is a nice trick to probe if there are any
> windows users out there ;-)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/177/files#r2235413>.
>
>
I'd prefer a pick argument that if None takes the data channels. I don't like this keep_only_data_channels sorry...
This method name must match your @should annotation.  "@should delete item from database".  So either make the annotation "@should purge ActiveListItem" and the method.

See the eclipse plugin to have eclipse generate your method stub for you from the @should anntoation:
https://wiki.openmrs.org/display/docs/Unit+Testing+With+at-should+Annotation
There is already a fun head for chef_user above :)
Not sure how to make generator indent this and subsequent lines.
This should be `// .. your code here`
调整语序：
    浏览器既没有在<literal>modern_browser</literal>中列出，又没有出现在<link id="ancient_browser"/>中列出时，如配置特殊值<literal>unlisted</literal>，那么浏览器将被认定为新式的浏览器，否则认定为旧式的浏览器。
<header>Referer</header>请求头为指定值时，内嵌变量<var>$invalid_referer</var>被设置为空字符串。
与服务器通信的时候，如果出现错误，请求会被分发给下一个服务器，直到所有可用的服务器都被尝试过。
`mkdir_p`?
why not case class instead of all the boilerplate?
Actually... to be honest, I can't think of a really good way around this.  Let's take this offline; I'll send you a personal message.
Also, at the top, you can include this line:

```
from sympy.abc import x, y, z
```
Сигналы в интерфейсах делаются как protected-функции, а не паблик.
Entendido, ahora tiene más sentido el comentario (mi pregunta estaba desubicada porque no sabía que había métodos alternativos de recorrer índices). Y estoy de acuerdo, en este momento no debería ser un problema.
No estoy mirando el código, pero creo que no porque en un momento lo
limpio, creo que cuando optionKey es nulo


On Tue, Dec 4, 2012 at 12:02 PM, Alpha <notifications@github.com> wrote:

> In source/CommonJobs/CommonJobs.Domain/MyMenu/MenuOrder.cs:
>
> >              string placeKey = null;
> >              string optionKey = null;
> >
> > -            placeKey = GetPlaceOrDefault(employeeMenu.DefaultPlaceKey, placeKey);
> > +            defaultPlaceKey = placeKey = GetPlaceOrDefault(employeeMenu.DefaultPlaceKey, placeKey);
>
> Tiene sentido, el tema es que actualmente van a tener siempre el mismo
> valor, ¿no?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/234/files#r2307145>.
>
>
Nah, both Chameleon and Mako depend on it even today.
Does this actually work?  It looks like you are passing 2 arguments to click (the checkbox and the remove system button).  I don't see how this could work.
ps_map, bc_map not used
And spoil all the fun? :P
Don't know what happened here lol
Done. Issue #1385 is tagged low_hanging_fruit.
otherwise than what?
`Please enable [...]`
Thanks @mrbkap, I will address this in an upcoming pull
Hi Maurice, Yes, I will do that.

From: Maurice Manning <notifications@github.com<mailto:notifications@github.com>>
Reply-To: ooici/ion-definitions <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Friday, October 12, 2012 2:28 PM
To: ooici/ion-definitions <ion-definitions@noreply.github.com<mailto:ion-definitions@noreply.github.com>>
Cc: Swarbhanu Chatterjee <SChatterjee@asascience.com<mailto:SChatterjee@asascience.com>>
Subject: Re: [ion-definitions] UNS code changes (#219)


In res/config/associations.yml:

> @@ -101,7 +101,7 @@ AssociationDefinitions:
>      range: [StreamDefinition]
>      docstring: DEPRECATE
>    - predicate: hasNotification
> -    domain: [ActorIdentity]
> +    domain: [ActorIdentity, UserInfo]
>      range: [NotificationRequest]


Please check with Michael, Stephen or Tim that this is the correct link. It seems to me we dont want both ( a link to ActorIdentity and a link to UserInfo).

—
Reply to this email directly or view it on GitHub<https://github.com/ooici/ion-definitions/pull/219/files#r1832408>.
theoretically this is just an {Object} right?
should be onTileLoaded (capital L) to be consistent
Why do I need to rename the files? I changed them to be more descriptive about what they actually do.

The example runs for me as is:

`~/Code/goliath/examples/grape $ ruby server.rb -vs -e production
[24258:INFO] 2012-05-09 10:04:17 :: Starting server on 0.0.0.0:9000 in production mode. Watch out for stones.
`
This is causing libraries to always search, even when there is no search query.
@apex13 can we remove the last `,`?
Thanks Zach.

I updated the PR with commit 3c045c7.
Também vale o comentário anterior sobre as configurações serem mantidas no arquivo .ini
Borked indentation.
"The col element is a void element. A col element must have a start tag but must not have an end tag."
The tag does not close, so, don't close the tag. This is not xHTML this is HTML5
WN requested *all* figures, within a 2 column art-connections, have a fixed
with that mimicked a 2 column figure behavior.


On Thu, Nov 15, 2012 at 9:52 AM, Philip Schatz <notifications@github.com>wrote:

> In css/ccap-biology.less:
>
> > @@ -361,9 +361,11 @@ div.section .titlepage .abstract {
> >
> >    .solution { display:none; } //hide solution in this feature
> >
> > -}
> > -
> > +  &.span-all {
> > +    img { min-width: (2 * @column);}
>
> Why is there a min-width on images?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Connexions/oer.exports/pull/29/files#r2140161>.
>
>
the description is the same - so now this all is just simplified.
AHA! Darum!  ;)
PFFFT
We could just add a special case for `raw`. If an object has one key, `{ raw: ... }` then do a get, otherwise store it. Abit hacky I know, though not much we can do with only 1 function to work with.
Sama juttu `count`:n kanssa. `(empty? (filter (complement pred) a-seq))` sen sijaan on näppärä ja nopea.
I don't agee :)
Não estou contente com isto, mas não sei em que ficheiro hei-de definir isto. Any ideas?
I think what Colin is suggesting it that duplicating the same code (reading the configuration and populating the context)  in 2 class files isn't very nice as we're liable to introduce bugs down the road as they diverge. This code should be common and called from both locations.
"La base de modificaciones" doesn't match what's 3 lines above it.
Is this a downpayment for JSON? Did we verify it works?
i think this depends on the version of sinatra vs ruby 1.9?
OK, just one side comment, I would only mark fields as invalid, not also as valid. So just adding invalid class or removing it. To simplify things. Because sometimes Python will do also additional checks and field could still be invalid. (Like invalid hostname in e-mail.)
You cannot override data from Facebook, if user has already configured data. That is the idea why we are checking "is None" in original code.

So if gender is already set, then we assume that user wants that configuration. Even if on Facebook has maybe different value. Yes, concretely for gender this is a bit less common (for name and other things could be more). But still.
Ok, i went manually through code from master branch and fixed all changes that were made by editor.
Aha, seems that they are also confused. Sometimes they use `token`, sometimes `auth`. I think `auth` is correct one.
You merged this wrong. It is `post_published` now.
`jQuery.grep` is not safe with domlists (IE 6/7). You should use `makeArray` or `merge` as in L741. (not your fault, just munged code),
I think I'll change it to next_free_filename() so they're ordered and  it matches how we generate other filenames like this.
nah we don't like locks. Instead there are concurrent collections in c#; http://msdn.microsoft.com/en-us/library/dd287108.aspx
or even custom implementations; http://www.deanchalk.me.uk/post/Task-Parallel-Concurrent-List-Implementation.aspx
If this works, I'm surprised, it's a bit of a hack. the link should be to a logout view, which can redirect to the welcome page.
DRY! **DRY!**
This version should be set to that of the source's data. Please set if possible to GOA release's
This is removing an error. This file doesn't exist.
please read the comment ;-)
dont think so, easier to create a new one

On Nov 13, 2012, at 11:43 AM, shilobar <notifications@github.com> wrote:

> In changelog.txt:
> 
> > @@ -5,6 +5,9 @@ match the actual issue resolution (i.e. a bug might not be a bug). Please
> >  refer to the particular case on JIRA using the issue tracking number to learn
> >  more about each case.
> >  
> > +
> I think you mean remove the "test" commit (for changelog.txt) rom my pull request? Is there a way I can do that in the web interface?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

-------------------------
Best Regards,

Strong Liu <stliu at hibernate.org>
http://about.me/stliu/bio
I think you mean remove the "test" commit (for changelog.txt) rom my pull request? Is there a way I can do that in the web interface?
This violates the spirit of strict mode. We don't allow `{a: a, a: b}` because of duplicate keys, why should it be allowed in a destructuring parameter?

On a side note, I would never want anybody writing destructuring parameters with implicit braces. It's ambiguous with a series of destructuring parameters. I'd prefer it be disallowed. Implicit object notation should be used sparingly.
you're right, I am going to fix and clean up the empty lines
This test doesn't really check that a click occurred. Please add an event listener into the page and then check that the event fired with the expected co-ordinates.
[PigStorage in 11](https://github.com/apache/pig/blob/trunk/src/org/apache/pig/builtin/PigStorage.java#L174) can take second argument (first argument is the column separator) and supports options like "-schema" (stores schema along with the data, i.e. PigStorageWithSchema()).
Fixed in the avdl and corresponding methods that write the records in the Kiji*TableDatabase classes.
Это тоже лучше сделать методом класса. То же касается и сервера
I realized later, that it'll be better to name method as saveContextAsync...
Aha.  This is where you were running into `this` changing into something unexpected?
This change causes the publication import to fail if you import a bibtex file by going to:

site/publications and click "Add" => "Import Publications"
I can see this would work. Would implementing this with a refcount make this easier to read?
I think the refcount could be initialised at two and decremented using atomic operations, that way we don't need the critical sections. The call that decrements the refcount to zero gets to delete the fetch.
I do not understand this line. Why is there minus sign?
This was a shameless copy of the bash version. I agree with you on this one.

Maybe removing the `describe` case and the `--exact-match` in this case is a better way to go. What do you think?
Actually, you fixed 1.9.1 but broke everything else. I'll fix this.
I think it would be a better API if tag would accept a user object instead of e-mail address.
Ditto previous comment.  Misleading/incorrect documentation.
OMG this pull request just made my day! ^^
I do agree, but under the current config workings there must be only one size set, not two.  Despite the sizes being optional, at `__init__` the profile will in fact throw up an Exception if one of each size are not specified, because it runs `_parse_sizes()` first on the `sigma1`, `fwhm1` etc. and then on the `sigma2`, `fwhm2`.  This is somewhat hidden behaviour though, and so not ideal.

What we would probably need is a new group, currently just for the `DoubleGaussian` and which we've not yet defined, perhaps a `group=two_sizes`?  Or we need to let the config stuff know that the `DoubleGaussian` gets special treatment, although this goes rather against the spirit / whole point of this attempted config rewrite!
Hmmm, maybe this should stay on the model.  Disregard previous comment.
Is it also on purpose that you delete this file?
if we fail once, the task comes back in throttled mode.  so it sleeps between each message send
You can also use the more concise `MutableMap.of("period", new TimeDuration(0, 0, 0, 500));`

One day hopefully we can use immutable maps, and easily search for uses of MutableMap to just prefix with "Im".
add link to http://library.linode.com/web-servers/nginx/configuration/basic in javadoc
@raphink FIXED
Use `SportsPresentation::PlayupTypes.grab_last_id` instead of this regex.
Let's not do this - since these values are coming from a data it just really feels wrong. What about line.join('\n') and doing white-space:pre on the tooltip?
I always ship the documentation in the source. Why would you not ship it ?
I'll try to be on irc today if you want to talk about it.
put  a "\the" before these.
I would like to stick as near as possible to the LicenseTemplate because that eases possible refactoring.
This is the bootloader. I have not touched anything in there so i didnt add PhoenixPilot as well. I think we should have the bootloader refactored because its basically the same for all F4 targets.
Please use `${::lsbdistcodename}`
Если в классе и родителе есть одноименные приватные поля, брать собственное?
Вместо такого надо сделать класс (ParallelSortOptions, например) и возвращать его из readArguments.
You can leave this one out. I have a fix in PR #234.
Typo s/pricacy/privacy
Because there it will achieve <=50% error rate.
I prefer `RuntimeError`.
I would rather avoid single letter variable names but this is outside of the scope of this PR. I don't want this to hold back the merge.
test to see if eshelf is valid
why not make clone_list a list of the id_strings of cloned forms and then in the template display clone if the forms id_string is not in clone_list?
There's `LinkDeclaration::toCBuffer` which is where I partially stole this code from (I left out the 'extern' strings). But I'm not sure if I can extract a `LinkDeclaration` from within a `FuncDeclaration`.
Can you break this sentence up and wrap at the 80-character column?
"lazy" is explicitly. I think that if I do not need, do not write is good.
Cannot found documentation for it
C'est quelque chose q'on peut être amener à demander ailleurs dans l'appli, il vaut donc mieux le déplacer dans dans la classe Etude.
```java
public DocEtude getFacture() {
    ...
}
```
Why is `*warn-on-reflection*` hard coded in `freemarker-clj.shim-test`?
I couldn't see a simple way to do this in bash with std. tools, most solutions seemed to involve ifconfig -a and sed/awking - which looked messy.
It's a pity, would be nice to get rid of 'localthor' and make automatic.
@pschwartz - any ideas ?
Is this public necessary?
Worth special casing end == cur, since the matchLen = 1 won't be valid then.
We can make it less conservative once we improve the fragmentation behaviour. I'll be opening separate issues for that shortly.
Oh, forgot about that. I was just going through some old e-mails. :-)
If we want to make this look more like the old site, we could stick the date here.
Change this to:

```python
@mock.patch('requests.get')
def test_products_list(self, rget):
    ...

```
If an exception gets thrown in the chain that initializes "in", the FileInputStream will go unclosed.

For example, SnappyInputStream will throw an exception if the file has a bad header. In this case, "in" will still be null and the FileInputStream will go unclosed.
I would just really say that console.log is also available in content scripts, explaining that it's loaded for each tab etc feels like making it more complicated.
Even if I already did the changes in this request I'm thinking I will split the code to have a separate pull request for that, also to makes this one more clear.
What should be consider local? For my purpose, I just need `resource` and `data` scheme, but it's not enough if we want reuse this function across modules. For instance, l10n unit test uses `jar`. But `jar` could be used also for remote uri as far as I know, so probably we should have: `resource`, `data`, `file` and if it's `jar` checks if the `path` starts with one of the local scheme.
How it sounds to you? Should we add `chrome` as well?
Thanks for xfailing this.
Is that really wise?  We could hang forever waiting on the target process.  Even if that is desirable, is this an interruptible wait - can you break out of the run?  Might be better to block for a long but sane amount of time or so...
Can you add the MPL2 license block here pls
Don't you need os.path.dirname(openmdao.main.__file__) instead of just openmdao.main.__file__?
As I noted in the comments, probably
```
[NULL,filename] = fileparts(tempname());
clear NULL;
```
would be better. I suspect that the ```tempname``` utility in Matlab is wrapping Java UUID code, because it produces strings like ```tp3269c81a_fa39_420b_9822_7fb678dfecc3```.

One can call the UUID code directly however, as follows:
```
import java.util.UUID;
jUUID       = java.util.UUID.randomUUID;
UUID        = char(jUUID.toString);
```
(This runs in Matlab R2007b)

I agree that the possibility of rng collisions should not be discounted. I suggest uncommenting the ```fileparts(tempname())``` part as an easy fix.
Creates a <code>ServiceTimeoutException</code> instance with default parameters.
Too much whitespace. Two lines is sufficient here.
Yes. It's a very introductory talk, but proved to be a real eye-oppener to whoever is not familiar with binary repository concept.
80 columns, please
blog plugin? :)
I'm not crazy about the name `coord_tf`. Maybe `coord_trans` or `coords_rmap` or `reverse_map`?
That doesn't work for float types.
Not sure why the extra space, but it shouldn't be there.
Actually, I'm not sure about this change now, `cursor` is accessed through a closure so I believe we wanted the original `++cursor;`.

Perhaps `return cursor++;` is best.
Same comment as `_up` above.
I ran into that too.  Try:
```javascript
expect(function () {
    return new CentralBodySurface({
        imageryLayerCollection : new ImageryLayerCollection()
    })
}).toThrow();
````
I wonder if we should remove an existing registration and add a new one instead to ensure its shape is exactly what we need?
InvalidServiceNames
It's sort of implied by saying the supported video formats depend on the browser. FWIW, Arthur helped me write that sentence, so he has effectively signed off on it. Unless you feel strongly that it needs clarification, Arthur and I are cool with it.
this baby gotta go bye bye
deleteRow is also supported on Android
arg.. forgot to add that file to the commit.
Updating in the next commit
Rewrite to be concise.
`Pressing the **home button** is another kind of interruption. The app fires the `pause` and `paused` events before going into background. When app is reopened....`
Where are all the semicolons when objects, functions, and arrays are assigned to variables?
I made a change to move this behavior up in the chain and outside of the platform module itself.  In general I am kinda torn on issues like this since to the overhead required of maintaining this is very low versus adding complexity in the chain and making the flow and order of operations more difficult to follow.  At the end of the day, I think the change makes sense but it's food for thought regarding what exactly are we getting in return.
Аналогично с первым.
How about _videoDom.on.canPlay.add(_onCanPlay) instead? It's more terse.
Check if is running on OSX Lion+
The style of bracing that we use in Phobos is to have braces on their own line (any place in Phobos which does otherwise is generally because it slipped past in the review phase or because it's older code).
What's the blocker?
"This can be very useful for extracting and shrinking (and potentially using) a range in a single line" would be better English. "This can be very useful to" is not correct. But I'd probably go with something like "This makes it easier to pop elements from a range and then pass it to another function within a single expression, whereas $(D popFrontN) would require multiple statements."
`randomUUID` does the opposite. It specifically pops first, and it doesn't pop after grabbing `front` unless it's about to grab it again. There's no real way to guarantee whether `popFront` has been called since `front` was last accessed. We'd need all random access generators to have a function which was equivalent to the recently discussed `consumeFront` (returns `front` and pops it at the same time) and _not_ have `front` at all.

The defensive programming way to go about it is to always call `popFront` before using the random number generator. The way that's explicitly trying to play nice would be to pop after, and the combination of the two would of course be to call before _and_ after. I don't know how expensive it is to call `popFront` though. If it's not relatively cheap, calling it more than you need to is problematic.

My general inclination is to go the defensive route, though it looks like in this case, I did both.
But yes, it's strange. Filled issue [Issue 8902 - Unexpected "duplicate union initialization for X" error](http://d.puremagic.com/issues/show_bug.cgi?id=8902).
Might be a space/tab thing. I see this line indented 7 spaces instead of 4.
Perhaps check "${elemInfo.loopItems} is Iterable"? That will give the null check as well as the Iterable check.
I thought we inherited that guideline (prefer single to double quote) from the JavaScript style guide? It makes it easier to build HTML strings.
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Strings#Strings

I disagree on the triple quotes though. Multiline strings are the perfect use case for triple quotes. That's why we have that feature :)
このことはリモートデータの扱いにおいては明らかで、同期的なリモートの呼び出しはユーザーエクスペリエンスを完璧に壊してしまいます。
In what situation will this occur?
RemoteConnectorRegistration; as a model object as Serializable
transformResult
same as above, I use this 3 times in the session declaration
This should be /usr/bin/env ruby, Sensu 0.9.8 has a switch at /etc/default/sensu for the embedded ruby.
This needs to be in source control
my preference is to use the automatic scoping for localizations on forms - t('.add') would scope this automatically
alexcole said in person that it was supposed to be hours, but he changed it
to number of classes because that was easier.  If you want to fix it, go
for it, if not, don't.

On Wed, Oct 31, 2012 at 8:38 PM, Jordan Moldow <notifications@github.com>wrote:

> In esp/esp/program/controllers/lottery.py:
>
> > @@ -178,6 +188,11 @@ def initialize(self):
> >              for (student_id,section_id) in interest_regs:
> >                  self.ranks[self.student_indices[student_id],self.section_indices[section_id]] = ESPUser.getRankInClass(student_id,self.parent_classes[self.section_indices[section_id]])
> >
> > +        # Set student utility weights. Counts number of classes that students selected. Used only for computing the overall_utility stat
> > +        for i in range(self.num_students):
> > +            self.student_utility_weights[i]+= sum(self.interest[i, :])
> > +            self.student_utility_weights[i]+= sum([sum(self.priority[priority_level][i,:]) for priority_level in range(self.priority_limit)])
>
> And you still need to address the issue of these calculations not taking
> class length into account.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/learning-unlimited/ESP-Website/pull/427/files#r2000371>.
>
>
It is necessary because it also includes other types except classes, example: ArrayCollection<Foo\Bar> or array<Foo>
И будет пипец, а не API. И два хука на одно и то же. Очень удобно!
Блин, просто добавь один сраный параметр.
Defining the array length at creation time is a performance optimization. Do you have any reasons/evidences for changing that?
I don't see how to do it :( I mean, in remote context, you only have is a reference to GlobalTransaction. I need somehow to translate a GlobalTransaction to a LocalTransaction. Am I missing something?
Technically this is not true. There is no support for arbitrary PID or process names in this branch.

That said I will keep the fallacy alive, as I expect to bring this to production soon, and do not want the change in behaviour to be deemed breaking... cheeky much?
Removed with commit 8b689fe

Admittedly, certain concepts were originally drawn from the JDBC Adapters - and with that I used the property **deletePerRow**. Thus, a minor question I still have - Should that be better named either **deletePerObject** (default = false) or **batchDelete** (default=true) in order to align it better with the JPA universe?
Well, it did became that more complex as it handles much more.
Imagine the complexity level if we did it the other way by introducing message correlation thread etc. . .
And yes I agree it does read better now especially with " while (!theOneIWant. . ) " not sure why Sonar complains.
It's redundant & inherited property: `DelayHandler ` extends `AbstractMessageHandler`.
And also in this case 'order' is about how handlers are added into `AbstractDispatcher#handlers`
This is an interesting perspective, what about orderby and other properties?
Damnit, I hate when someone goes through and introduces whitespace-only diffs. Makes it impossible to tell what's genuinely new and what isn't, sigh.
Can you remove this? This should come from config like the rest or be provided inline when used, we dont want hardcoded values on providers.
Constant string. Use `prop`.
I can move this URL up to the code52.org site - it'll actually be hosted on the gh-pages branch in this repo.
`(!completed)` -> `!completed`
It's more succinct to use `attr_reader`:

```ruby
self.class.class_eval { attr_reader cattr }
```

BTW, naming it `cattr` is a bit misleading.  These are still instance attributes, not class attributes.
Why not if 'short_path' in request.REQUEST ? Looks cleaner. (speed?)
Фигурные скобки (`{` и `}`) теперь везде используются одинаково (consistency).
We use to put a verb after the command namespace:

    geocoder:geocode


On Mon, Sep 17, 2012 at 8:20 PM, Markus Bachmann
<notifications@github.com>wrote:

> In Command/GeocodeCommand.php:
>
> > + * @author Markus Bachmann <markus.bachmann@bachi.biz>
> > + */
> > +class GeocodeCommand extends ContainerAwareCommand
> > +{
> > +    /**
> > +     * {@inheritDoc}
> > +     */
> > +    protected function configure()
> > +    {
> > +        $this
> > +            ->setName('geocoder:geocode')
> > +            ->setDescription('Geocoder an address or a ip address')
> > +            ->addArgument('address', InputArgument::REQUIRED, 'The address')
> > +            ->addOption('provider', null, InputOption::VALUE_OPTIONAL)
> > +            ->setHelp(<<<HELP
> > +The <info>geocoder:geocoder</info> command geocode the given
>
> Where?
> Sorry i don't see it :(
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/willdurand/BazingaGeocoderBundle/pull/16/files#r1621451>.
>
>
Can probably remove this bit and make it implement in the main class instead...
Why are you changing these lines? They are fine as is.
Yeah. I definitely see extracting a Method Object out of this code in the future.
Added polyline styling for all a pi's.
django_reverse will do this for us.
will make nullable.  Also, if someone specifically sets it to false, I will have it un-globallyOptOut at the third party.
Good save :)
Shouldn't close happen in `finally`? Otherwise it can leak open file handles..
Does this imply that we can't use `UTF-8` (in all caps)? I use that in jswbxml, but I can fix it.
ok I will correct (They say Indian people have worst accent in whole world  :)
### Project Token

Hmmh, I thought only the organization token must be copied from the server and the project token for new projects would be either deduced by the agent by default (Maven artifact id) or must be provided by the user (Freestyle)? I might have figured that wrong from the other agents (Jenkins/TeamCity), which state the project token would be _Unique identifier of the White Source project to update. If omitted, default naming convention will apply_ (see e.g. http://docs.whitesourcesoftware.com/display/serviceDocs/Jenkins+plugin).

It's obviously trivial to remove this generated default, will do once confirmed.

#### Automatic Project Creation

Is this misconception of mine eventually the reason for the pending issue that I've been only able to update existing projects so far, but haven't managed to create new ones automatically via the agent? That would be an easy solution indeed (though being unable to override this manually would contradict the user docs and might be a bug still accordingly) ...

----
### Organization Token vs. API Key

As an aside, I just realized that you have renamed the former _Organization Token_ to _API Key_ - good move, that's much more common and less prone to confusion indeed, I'll follow suit and rename it here as well (this change is going to be part of the Maven functionality commit due sometime this week).
Change "the applications" to "an application's"
Should be removed, not for public consumption. This may change in the future (custom tabgroups)
Added an example under descriptions.  Got Arthur's feedback and he said it was fine if we left it in description since it was a small example.
Comment before annotation.
Cached value in memory shouldn't be encryption. Too much security is bad!
Nejak tuto line nechapu, k cemu to je?
Where is `confirmBox` declared?
This may put the z ordering of the invocation list above the dialogs.
i will try it
There's also a simpler solution:

~~~clojure
(if x
  true
  false
~~~