labofsahil/github-event-dataset-2012 huggingface dataset:
@DDuarte I'm using ReadValue in some unknown values here https://github.com/Fredi/WowPacketParser/commit/9f535fb98b7e6de1719397120281ec03bcd4f2db#L0R109
I just don't have a clever way to name them. "Unk uint32/64 xx" ? Or should I use ClientVersion.AddedInVersion there to name them accordingly?
Hmm. I did that before commenting and it didn't work. Maybe I messed up while installing the local version of the gem.

Anyway, are you going to release a new version once you sort out the these pull requests?
You got the power!
Hey, sorry it looks like I got overconfident and messed up with the autoreleasepool. I was reading up on how to do it right, I'll send you a new pull request as soon as I do this.
What is this commit supposed to do?
The .gitignore file should perhaps itself be ignored?
Ah merde je crois que j'ai oubli de faire un Git add ^^

Le 30 janvier 2012 18:11, Arthur <
reply@reply.github.com
> a crit :

> @lucas95 : WTF ??? Lucas t'as fait que supprimer le code de lecture ...
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/cczerty/Robotique-MJC-2011/commit/693f9e0d4e2c231ea3e13ac3ce6ebc43ff3a73b3#commitcomment-914852
>
Sure, that was me being lazy, thanks :) Anyway, we'll get rid of the part with reflection, as @shuya-inc pointed out I there was a clean solution :)
What irb issue are you seeing? This is what I get:

```ruby
>> Foo = Class.new(StandardError)
=> Foo
```

Which seems sane to me. In fact, the output of the class ... seems weirder to me. While I know returning `nil` is what a bare class definition does, it still strikes me with a bit of WAT?

```ruby
>> class Bar < StandardError; end
=> nil
```
Version 0.11 of authenticate uses the new conduit packages, which causes the build of twitter-enumerator
to fail with

    [2 of 5] Compiling Web.Twitter.Enumerator.Monad ( Web/Twitter/Enumerator/Monad.hs, dist/build/Web/Twitter/Enumerator/Monad.o )

    Web/Twitter/Enumerator/Monad.hs:69:30:
        Couldn't match expected type `http-conduit-1.0.0:Network.HTTP.Conduit.Request.Request
                                        IO'
                    with actual type `Request IO'
        In the third argument of `signOAuth', namely `req'
        In the second argument of `($)', namely `signOAuth oa cred req'
        In the expression: liftIO $ signOAuth oa cred req
Yes, if you think it fits best there, please do move it there.

-- 
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>

**
Blog: http://iocanel.blogspot.com
**
Apache Karaf <http://karaf.apache.org/> Committer & PMC
Apache Camel <http://camel.apache.org/> Committer
Apache ServiceMix <http://servicemix.apache.org/>  Committer
Apache Gora <http://incubator.apache.org/gora/> Committer
Apache DirectMemory <http://incubator.apache.org/directmemory/> Committer
*
setNumClients() and getNumClients() in `SyncAdapter` need to convert the `AtomicInteger` into a String so it can be stored in `Account`. I think this defeats the purpose of the atomic integer. 

Would it be better to make setNumClients() and getNumClients() synchronized in SyncAdapter (like getAccountGUID() and getClientName()) instead?
Thanks for the quick review!
Oops, my fault then :P
<tt>android.os.Build.MODEL</tt> will give you a unique string.

Combine this with preprocessing to get <tt>@MOZ_APP_DISPLAYNAME@</tt> (but being careful not to require new strings), and you could get something like

<pre>
#filter substitution

package org.mozilla.gecko.sync.setup;

public class ClientName {
  public static final String PRODUCT_NAME = "@MOZ_APP_DISPLAYNAME@";
  public static String getClientName() {
    return PRODUCT_NAME + "/ " + android.os.Build.MODEL;
  }
}
</pre>

in a file named <tt>ClientName.java.in</tt> in some directory somewhere.

For now I'll settle for using <tt>android.os.Build.MODEL</tt> to avoid fussing with preprocessing.
This line could lead diff cruft  (in this case, it has 2 trailing white spaces)
Yep I saw the changes, the trouble is your example code only works when the solver has finished, using the SolutionDirector change from inside the change event also gets an empty working memory.

Any idea a simple change I could do to my commit to get the correct working memory ?


> Hi David,
> 
> Thanks for sharing this change. Even though I don't want to change the BestSolutionEvent API like this (as it leaks the solver's "working" WorkingMemory), it does give me a very good insight on what you want to do.
> 
> Furthermore, I 've recently specced out that the user provides a bestSolution and the workingMemory is a clone of that. So that means the bestSolution is never in the WorkingMemory. See the changes here:
> https://github.com/droolsjbpm/drools-planner/commit/5690541a567e5db36c6f2f5a66fda4f9c99d4086#diff-6
> 
> Next improvement in this will be to split up the SolutionDirector into SolutionDirectorFactory (holds RuleBase) and SolutionDirector (holds WorkingMemory) so the user can use the same SolutionDirectorFactory to create it's own, isolated SolutionDirector.
> That would mean you'd have to take the bestSolution and set it on your SolutionDirector (instead of sharing a WorkingMemory with the Solver). Can you live with that? It might be a small performance hit (but premature optimization is the root of all evil because not doing it would hinder multi-threaded solving in the future).
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/davidglassborow/drools-planner/commit/781f8e8dbe6792215f46c8a4ef3070bbc3e2678a#commitcomment-954072
Bof, Good and clear answer for me.
I'm awesome, I can write classes without touching my keyboard!
pls join the irc channel and ill explain.
its a bit hard here to discuss
naaa...I forked the wrong version...
Add which ArchiveType was passed
oki. im try :)
Sure, though the importnat change was done. Send a pull request?
PARDISO, iterative solvers or some AMG methods expects a double array. I think at this point we do not need the functionality from std::vector (for example dynamic resizing, flexible insertion).
A not An
this addition should not be part of the pull request
Would this replace `Y.Parallel`?
We can extend it from BCommonProperties.icon
I guess this is not correct yet?
The problem was that Viper was trying to interpret the 2D array returned by Dat.data as a vector field. I've solved this in cb3b40f by reshaping the array, so it's no longer necessary to plot using the original numpy array, and the one returned by the data accessor is used instead.
I agree, I had some reason in mind when writing it, but it's better without negation
add JAVA API
After all the postStop of the children have been _called_, or after all the postStop _finished_?
def seenSame: Boolean =
      if (seen.isEmpty) false
      else {
        val seenHead = seen.head
        seen.values.forall(_ == seenHead)
      }

    !hasUnreachable && allMembersInSeen && seenSame
yup, checked that after commenting.
Which is when I don't want the log file to be bloated :-)
may layman’s understanding suggests that an open latch does not permit flow; this means that in this case here the `if` is inverted
Is there a reason why you need to special case this? Again, it seems like it would be fine to use the "python 3" version above in 2.x as well.
Ok, then the code is broken.  The other is just transclusions and links, then.
When is this method called? Actually, since I am away and cannot test is right now, I am worried this might conflict to the point of this whole thing (eg. if it is called for the dummy group, too).
Please advise
item could be a null pointer here according to above.
In the distributed cache you can ask for something to be put on the classpath so that you don't need to do that in the backend
Sorry, it is shame that that code went into the repository.

Aynur Abdurazik, SAIC
Ocean Biology Processing Group
NASA/GSFC Code 616  (Mail Stop 616.2)
Greenbelt, MD 20771
Phone: (301) 286-4072







On Mar 12, 2012, at 10:42 AM, Norman Fomferra wrote:

@@ -519,6 +519,19 @@ protected Stx computeStxImpl(int level, ProgressMonitor pm) {
        return Stx.create(this, level, binCount, min, max, pm);
    }

+    public void scalePixels(){

Please remove this useless code snippet.

---
Reply to this email directly or view it on GitHub:
https://github.com/bcdev/beam/pull/2/files#r546017

--
To UNSUBSCRIBE: Send an e-mail to
seadas_dev-request@seawifs.gsfc.nasa.gov
with the subject, "unsubscribe"
Minor change: use == instead of equals.
If something is not needed then it should be deleted.
glt_mice -> gc_mi
Extra space? :)
IDK if ppc page size must be power of two or (also) multiple of 4KB, in ARM it's multiple of 4KB
We don't have a normal env setting for /run, otherwise it'd be nice to getenv(RUNDIR).
well, you still need to translate failures of `transport.localAddressForRemote(addr)` into a None
Is this method safe to be called on another thread?
I'd rather see this implemented using a module strategy where the _runtimeLoad method is hidden inside a function body instead of being exposed forever on the enyo object.
Oh yes that would make sense.
@stof It might be so for something else but for the purpose of the benchmark I jump from ~0.05 to ~0.30 so I guess it's CPU cycles in favor of memory.
Perhaps a more... Informative method of registering touches would be appropriate.  As much as I love NSLog for internal testing, it's not a very good thing to have laying around.
Eliminate the colors!  You made this class overly complicated.  All of the buttons types you made can be produced on demand by the programmer by providing a `TUIViewDrawRect` block.  While I do love the tweaks and changes you made to the class, adding the various options that you did created complexity which you either have to deal with, or gut.
Well I would like to keep the 2.x syntax. I use the file when testing manually.
確かに :thumbsup:
"Failed to ping", or "failed to respond to ping" ?

I'm guessing it's the latter?
Ok, I see- thanks @kpatnode! Just wanted to point you to how we handle PyNAST in QIIME as an example to work from. @wasade, I think this would benefit most from your review as you're most familiar with tax2tree.
Actually, default behavior is handled on Python side and is unchanged.
все комменты по стайлгайду должны быть на английском
The only problem I can see is that it won't return the sanitized version of `text` in case `sanitize: true` is given.
Remove all these `==== Examples` headers.
Why check for the key?
I think you can just extend `Mutex_m`, [like in here](https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/http/filter_parameters.rb#L24).
Just removing or changing to `Array()`?
The trick is that the symbols are already duplicated when they are encountered in ValDefs, so it's not the LabelDef's parameter symbols I'm after, but their equivalents after the ValDef duplication. That's why I only give the names and let the typer find them.
Hmm, I should stop for tonight. Will re-read my own comments later:(
I don't think that including the `ActionView::Helpers::NumberHelper` in a model just for a simple `number_to_percentage` call is a good idea. Can you do this without using that?
"und in beliebiger Präzision verfügbar sind"
Now that I have reviewed the rest, I do not see a persuasive reason to use `not self.args`, besides the fact that it **may** cut the recursion early in some rare cases like `Tuple()`.
True, this pattern for constructing a list is used throughout the functions `orbit()` and `orbit_transversal()`. I'm aware that it's a bit of a hack, however I believe that changing it so that the list is copied every time or something similar will drastically slow things down - and these functions are used rather frequently in permutation group algorithms. See the discussion here: http://stackoverflow.com/questions/3752618/python-adding-element-to-list-while-iterating , but keep in mind that this is exactly the intended behaviour of the orbit function: when new elements are appended to the orbit, they also have to be iterated over, and then the new elements that come from _them_ have to be iterated over, and so on. There is no danger of entering an infinite loop, since new elements are appended only after they are known not to have been used (using the list/set `used`, see the code), and the set of used elements is bounded from above by the degree of the permutation group. What else could possibly go wrong with it? I cannot point right now to another example where this is done though :(
Doctests are run with setup.py tests, so this is unnecessary.
spelling ^^
I think this should have a better name (like commutative_diagrams, but feel free to pick)
These lines need to be wrapped.
I think currently good solution is to add a subheader to the section saying "Read more" and then provide a list of links.

```
Section
----------

Some text.

### Read more

To learn more about XXX please refer to the following:

- [Link1 about something](http://example.com/).
- [Link2 about something](http://example.com/).
- [Link3 about something](http://example.com/).
```
Yes, I think so. Connection becomes active in the moment it's used so it's definitely not active when we're specifying it :)
DO YOU THINK YOU HAVE ENOUGH COVERAGE? :)
I think I removed all the css files in the stylesheets directory! So, whats my best option to restore it?
I used the same URL as the one [here](http://book.cakephp.org/2.0/en/getting-started.html#conclusion). Also, once CakePHP 3.0 is released, I will expect 2.0's book to link to 2.0's API.
ahh I see... maybe a is_callable check with a meaningfull exception would ease debugging?
File.size is calculated by File.stat and binmode is IO method. 
These modules are not directly related. 

In this case binmode can be used before params[:body].read, and only if responds
k,v -> name, time?
Fixed all newline styles.
If the underlying SQL queries are not being called any more, they should also get removed.
sentences that begin with `this` give me the heebie jeebies
That's [bug 759361](https://bugzilla.mozilla.org/show_bug.cgi?id=759361) mentioned in the comment.
why isn't this and get_absolute_edit_url being handled in reports/urls.py instead?
it's a hack so ohai only runs once. before(:all) might work.
ANONYMOUS seems to be the default. Why check in else if?
I, nor others in the RFC you opened about this, agree with you that comments should be on their own lines, especially in cases such as this.

I would rather remove the comments than put them on their own lines and nearly triple the amount of space they take up.
As per coding guidlines the line should be
`if (request_var('backtopost', 0))`
Note the space between if and (. You do not need to check if it is == "1" all you need to do is make sure it is true, so no equality condition really needs to be met.
The reason the delay doesn't get passed as an argument is because this is the only way it's used.
If you have a better idea for a function name don't hesitate so post it. Huge function names like list_for_each_entry_safe() are probably not what we should go for (this is an example, don't mention the coding guidelines ;) ).
<blockquote>Just the anchor should suffice</blockquote>
Agree. 

But change from paragraph to another, need to add CSS for font size.
user_posts really does not imply anything and cannot be trusted. For example it is not necessarily resynchronised when deleting large amounts of posts. Anyway you are right that the query can be simplified since we only need to know if at least 1 row exists and not how many posts the user really has. However I would always run this query, regardless of what user_posts contains.
Missing global, fixed locally
That's correct. Additionally I should change the avatar type array to reflect the new avatar types that are saved in the database.
I would prefer an explicit list of files here instead of just deleting everything with a filename longer than 3 characters.
We should take this out I think.
I think this should either be an error or not. It shouldn't depend on DEBUG flag if something is considered wrong. How do we handle this for incorrect input to other tags?
`$files_added`?
What can be in this array?
Is there a reason this is an async.parallel that is doing the same thing twice?
Oops.. sorry, I merged in GothAck's commit by accident... I'm a Git noob
这部分以后会实现
I think this should be `@method rpc`.
It's not strictly necessary.  The first argument of the callback is an error object, and by using `cb(null)` I'm say "really really there's no error".  A matter of style I guess.  I can remove it.
Удаленный баннер != баннер с истекшим количесвом показов
To avoid problems with both validators and browsers, always use ``&amp;`` in place of & when writing URLs in HTML
a few issues with spacing/tabbing. Can likely fix easily by running jsbeautify
I tried it, and 29 tests (on 36) in tests_pfunc fail, saying the compute map is 0.
Why should the compute_map of the updated shared variable be 1, anyway?
Raising a KeyError or something might be better
Don't write your own validation, intead catch the exception!
Why do you hate the word "formula"?
"interrogated"?
This looks very scary to me.

If you load a model with foreign keys temporarily to the app-cache, and the foreign keys are to existing models, then the existing models will also get altered. When the state is restored, the existing models will remain altered. In general, there can be side-effects beyond the app-cache when loading/altering models, and it will be really hard to tell what those side-effects are.

To me it seems it could be better to start with an empty app-cache when using temporary model state, and then just reload (as separate model classes) the models into the app-cache. It might be possible to do this by something like:
def  load_schema_models():
     class Model1(models.Model):
        ...
    # returns nothing, just introduces the models
 
The idea is that each time you call this, the models are recreated. I am not sure at all this works, but as the app-cache is emptied, there is nothing to return from there. So, this _might_ work :)

The downside (assuming this works at all) is that you will not be able to import those models, you will need to get them from the temporary app-cache by get_model().
Is there something not clear about this code?
I added that there because there are conflicting defaults right now that can leave someone open to the lazy choice.

By defaulting to verify-host being on, if I don't have a CA bundle on my system, the first run gives an error -- especially if I don't use Guzzle\Http\Client, but go to the CurlHandle instead. Then I'm likely to just turn off CURLOPT_SSL_VERIFYPEER instead of looking around for the right path to the bundled CA cert, if I even know that Guzzle bundles one.

I would prefer to see the safest possible error-free paths of execution used as defaults. If someone knows enough to care that the CA bundle that came with their system isn't being used, they will also know enough to override the defaults to use it.

I believe the reason that 90% of the PHP examples out there that suggest setting CURLOPT_SSL_VERIFYPEER to false is that people don't know know why it fails or how to fix it. Google CURLOPT_SSL_VERIFYPEER -- I think you'll agree afterwards that a default to the included CA bundle is a good idea.
This isn't really ambiguous though (under the assumption that it builds successfully).
I understand the intent, but jQuery.each is an order of magnitude slower than a for.. in loop. Is the loss in perf worth the gain in bytes?
Is the only functionality of this paragraph to further explain the previous paragraph? Perhaps "Intuitively" -> "For special/trivial cases"
There is no `examples`. It needs a captial "E".
I had this (working) code but the "Dir" is probably not needed.

```
    if ARGV.include? '--examples'
      prefix.install Dir['Examples']
    end
```
I'd leave this function as is (since most of the places where it's use care about whether we have tools in /usr/bin) and add a check for the Xcode version when the (CLT) string is generated.
We prefer `https://` urls for accessing Github repositories.
Yes, `cancel` is safe to call on an already called deferred -- it is documented to have no effect.
This will throw an exception is `msg['content']` is `None` or an empty string, both of which we've seen in production. I've handled this in an ad-hoc way in various places, but it's probably time for a little utility function in `vumi.utils`.

I usually go for something ugly like this: `((text or '').split() + [''])[0]`
It could, but I'd like to warn on anything that imports this, not just things that create instances.
why is this function declared like this ? why not make it part of the prototype ?
Are these strings so that they survive across passes?
At this point I'd suggest to go for cksum, too.
I don't think wildcard imports are used in the JUnit code. Please expand.
yes exactly.
I did because for me it is more readable instead of counting how many zeros are there.
Elsewhere we have 10000.
In general, what we try to do is to override one of the validateX methods in BlockJUnit4ClassRunner, and check up front that all the reflective calls we're planning to make should work.  That allows us to immediately alert a user that their test is bound to fail.
Surely this is a mistake? (`NAME_DESCENDING` removed and `JVM` undocumented?)
Does this function need to be templated? It appears the template type is not used, so a `void*` might just do the trick. Alternatively the template type could be used to send the type size to `op_fetch_data_char`.
So are we officially retconning multiple storage adapters?
I don't think this tests anything useful.
Sure, makes sense -- or #2221 could be an opportunity to clean it up too.
Also, while you're editing this code could we add an ```@type {KeyMap}```?
Your CodeMirror changes have been merged in, so this test here is no longer needed. Would you mind removing it?
Looks like we usually use the Unicode ellipsis char (`\u2026`) for ellipses (right now this looks inconsistent with "Open Folder..." below it).
InlineColorEditor.load method does not take the second argument. So we need to remove pos here.
This should probably be re-enabled to prevent browser freezes.
Yes. It helps us see which test failed when we get an intermittent error, whereas the default mode isn't helpful at all.
This makes the footer more flexible.
not used any more ?
ok, I think, I`ve done that properly now...
Can you please copy exactly as it is? It is much easier to debug when I can see everything together. Especially with "strange bugs".
Don't use `auto_id`, check what is in main repository.
That's why we have code review. ;-)
this looks like it doens't exist either
this call should be after all the tests right?
I'm assuming it'll gt rid of this new lint error too:

```
Error: The “frameborder” attribute on the “iframe” element is obsolete. Use CSS instead.
From line 56, column 15; to line 56, column 164
```
All of this is really just an out-dent.
does that mean it get's returned as plain text as opposed to an object?
All of the indentation after this line is off by 2 spaces.

Increase it all by 2
I'd rather see a url.length == 0 or !url check
We also need to make a Case 7, for the 2-point shot.
This alias can be removed.
And maybe I should change my HipChat alias to @nabcos as well to not alert someone from github to our discussions =)
It may be a bit cleaner if we return a `map<i64, bool>` rather than just a list, although not necessary
For things like this:
https://github.com/bblfish/Play20/blob/b17fe02a8d420a29b610658e98533176f89158de/framework/src/webid/src/main/scala/org/w3/readwriteweb/play/RWW_Action.scala#L39
```
def result[Obj](code: Int, writer: BlockingWriter[Obj,_])(obj: Obj) = {
    SimpleResult(
      header = ResponseHeader(200, Map("Content-Type" -> writer.syntax.mimeTypes.head)),  //todo
      body = toEnum(writer)(obj)
    )
  }
```
indentation needs fix in above two lines
Should be
        if isa(B, Vector); X = reshape(X, (n,)); end
This is what we used in Spacewalk/Satellite. If we are unsure, we should contact legals.
Do we want to perform any action if it's not defined?
I know this wasn't your fault (and i didn't fix it either), but could we change this  from  'finished' to reference  PulpTaskStatus::Status::FINISHED  ?
If there is not an easy way of determining if foreman support is installed, I vote to extend the "ping" command to also return an array of backend which are enabled: ["candlepin", "pulp", "foreman"] so clients would be able to query this.
BTW whats that line supposed to do ??
may be you meant

```ruby
return org.id if allowed_organizations.include?org
```
what if you want to change it later ?
I think this factories file needs to be wrapped in a ```FactoryGirl.define``` block
the `{` should be on the same line as the if, but more importantly.. what is this context=>context? :)
No, I replaced functionality of it with the assembly locator. And resolving hub types now takes place inside `ReflectedHubDescriptorProvider`
This should be 3.0.3
No more manifest.webapp either :)
Changing `#view-num` is acceptable. Let me move on to other changes ...
Good point.  I'm not sure that `get_converter` even belongs in a getting started/interactive use example like this -- it's use case is a little more advanced than that.
It says "get_extra_build_options" here, but in ``xml/setup_package.py`` you have `get_build_options`.  Is one of these a typo?
This should probably be resolved before the PR is merged.
Nope -- with that explanation, it makes sense.
+1 for `coord`
Because they delete the instance temporary directory. In other words, there's no place to put the file any more.
kao，我好像还忘记了_i这茬事儿，我还得研究下怎么自动识别出来一个字段的类型。现在去掉了_i是gon功能不全的。。。啊。。。
拉哥，对不知道的人来说，两个方法的区别是啥？
我不看里面的代码完全不知道该用哪个？
I refactored this a little, so it's more obvious what's happening. I hope :)
Ok but why do we need a function returning a Listing object? Do you have a use case in mind for this? If it's just to check for whether or not one exists, you should be using the `exists?` call. http://apidock.com/rails/ActiveRecord/Base/exists%3F/class
This one should also be changed I think (accordingly to what was proposed for fr). For example "WFS GetFeature" is something the user doesn't need to know about. We should probably have @eleu translate the french messages to german.
I'm not comfortable with the explanation "string that matches the regular expression". Where this string is being written to?
Let's aim for minimal diffs; this is an unnecessary and unrelated change that doesn't actually modify functionality/usefulness.
Is that useful at this point?
there's already a suitable try-except below this, I think this should be just wrapped into that one (make it have to `except ...:` clauses)
This is not quite right, as the module could contain a `/__init.__.pyc ` file or similar.  Also the `/` might be `\` in Windows.
I just pasted in tooltip.js and it did a pretty decent job in
formatting it.  I think a few things were off, but its default style
is close to ours.

On Wed, May 9, 2012 at 8:59 PM, Jason Grout
<reply@reply.github.com>
wrote:
>> +    };
>> +
>> +    Completer.prototype.finish_completing =function (content) {
>> +        // let's build a function that wrap all that stuff into what is needed
>> +        // for the new completer:
>> +        var matched_text = content.matched_text;
>> +        var matches = content.matches;
>> +
>> +        var cur = this.editor.getCursor();
>> +        var results = CodeMirror.contextHint(this.editor);
>> +
>> +        // append the introspection result, in order, at at the beginning of
>> +        // the table and compute the replacement range from current cursor
>> +        // positon and matched_text length.
>> +        for(var i= matches.length-1; i>=0 ;--i)
>> +        {
>
> Do you happen to have a favorite javascript "beautifier" tool, like indent is for C?  For example, http://jsbeautifier.org/.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1711/files#r799727



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
(I mean *might* - I haven't checked that. I just thought I'd clarify because sometimes people take my speculation as concrete instructions)
I'll look into it. Need to find out how virtualenv works on windows.
@iocanel thoughts?
only changed import order
It is a minor optimization / simplification, but since you are just looking for reference prefixes to match (i.e. since your glob is just a name followed by a "/*"), you could probably just call `git_reference_foreach()` and check if the reference matches the prefix in your callback instead of calling `git_reference_foreach_glob()`.

This avoids the need to allocate the `glob` buffer, eliminates one extra layer of function callbacks (since the glob version just calls `git_reference_foreach()` with it's own callback that calls through to yours), and uses a prefix check which should be cheaper than fnmatch.

I realize there is no particular reason to optimize this, so it's not critical, but I thought I would mention it.
Where have you moved this line to? To the top of the module? Where the other import statements are? That should work and I don't see a reason why it fails. I would need some code to give a qualified answer.
So with this dataURL the NetUtils.asyncFetch() call will throw an exception? If yes, that should be the test in this file. But reading back the content should be part of the controller/screenshot test.
tell me about the license header removal.
I guess this was for debugging and should be removed. ;)
If think I would write:
<pre>
aCursor.execute(sql, parameters)
return aCursor.fetch_all()
</pre>
Same result but doesn't use ``db.execute``, doesn't create an unneeded generator, and is as easy to understand. Also, you might use that opportunity to do some PEP8 good and use ``cursor`` instead of ``aCursor``.
Might in the next iteration.. right now cloc doesn't seem to detect properly and Github thinks it's 100% Javascript
you need to check if `request.LANG` is in `locales`
Upon running `composer install`
> eede6abb9b49fa6632f9776c857c703d8d8268e0 is gone (history was rewritten?), recovered by checking out 3e53f0a9f802dc1f34a722109df0b0d2679671a8
Since AGOS is really just using its own timing code, yes.
а чим не підійшов стандартний definition?
``` Then /^поле "(?P<field>(?:[^"]|\\")*)" должно содержать "(?P<value>(?:[^"]|\\")*)"$/```
that does not help and this is not needed as all the comments from this PR will be part of the merge commit.
This option is new in 2.1 so it should not be mentioned as renamed but created.
I only use the sorted array when throwing an exception. What is correct though is that sort() on an empty array should not have any performance impact.
thanks for pointing me to this comment @stloyd (I've made the same later on). I don't see why Sf should enforce such CS ?
@lyrixx ``spaceless`` removes spaces between tags, not between a tag and some text
Alright, I was unsure about that point. Fixed.
1. This property is static, because it's better to use one database connection for all tests instead of creating a new database connection for each test
http://www.phpunit.de/manual/current/en/fixtures.html#fixtures.sharing-fixture

2. I think its better to use a real database connection for a functional testcase. If you look at [MongoDbProfilerStorageTest](https://github.com/Baachi/symfony/blob/1864dbed7d4411846b1eda810805046c6ecc7c03/src/Symfony/Component/HttpKernel/Tests/Profiler/MongoDbProfilerStorageTest.php) it use also a real database connection instead of mocking the ```Mongo``` class.
no clue .. but those two files were created when i run the unit tests
Defaulting to "really" false, now.
There are a large number of Components that us it :) Templating, Translator, Config, Console, DepencyInjection Routing, Security.

Use this regex ```@(return|param)\s+[\w\d]+\[\]``` to search there usage.
as discussed this we be a separate job later this week so that all instances of this comparison are fixed
We should probably choose between || and "or" :peach:
FWIW, I like the idea of keeping the `gauge`, `set`, etc methods on the aggregator. Then they can submit without any knowledge of the constants and whatnot. But no biggie. Might be worth running the statsd perf tests too and make sure the extra function call doesn't make too much of a difference:

https://github.com/DataDog/dd-agent/blob/master/tests/performance/dogstatsd_performance.py
No. ```lib/cartopy/examples```.
I agree, but the Reader was being instantiated by an earlier test (I think) causing the test to fail. As it now stands it verifies that the reader is not created again. @pelson - Is this a blocker?
The reason for extracting it here was to allow me to override this method in the test. Otherwise I had some trouble stubbing out the call to render.
Interesting that it works for the default case. I'm intrigued and will have to test it out.

Not too concerned about special treasures (or Mint etc) for the reasons you state.
That's what firstLookup does -> at the point ChainGetMany is created (lazy eval aside), firstLookup has that MagicObject that corresponds to the intermediate lookup val.  Is that what you meant?
I have tested that 
```python
pydot.Dot.__init__(self, *argsl, **argsd)
```
is working (a very old way, this is how `pydot` is doing it).

Yours is wrong, but you have a point, it is better in that way:

```python
super(KitchenDot, self).__init__(*argsl, **argsd)
```
Appears to be a copy/paste from _get_change_password_form
Oops!  

Yeah, I was playing with underlining the `metavar`s, but I decided not to.  Will fix shortly.
@mecathcart im pretty sure this blur was yours see notes here about why not to do that
Having a second look at all the rollback handlers they appear to all be at least partially broke. I've filed a JIRA to get this fixed https://issues.jboss.org/browse/AS7-5724.
If possible, please make this work like this:


                            <resources>
                                <resource>
                                    <directory>${jboss.home}</directory>
                                    <excludes>
                                        <exclude>modules/</exclude>
                                        <exclude>bundles/</exclude>
                                    </excludes>
                                </resource>
                            </resources>

We don't want to copy the modules and bundles.

This will require adding getters/setters for properties modulePath and bundlePath to EmbeddedContainerConfiguration, and then passing those values in to EmbeddedServerFactory.create(...)

Adding those config properties is also good because it allows this container to be consistent with the other containers, which let the user configure alternate/additional locations from which modules and bundles can be loaded.
@RudyLu I thought you are reviewing the code?
This background color is too dirty for now. I don't think it should land. Also last time it would reducing performance. Let's not do that until we have a valid design for the search page to understand how it looks.
I didn't detect problems with URIs but I can add it as well
Can you add a new case inside the exisiting code and explain in a one line comment what is the reason for this case (like it is done for the other cases).
On 14/06/2012 14:15, Dominic Kuo wrote:
>> @@ -283,10 +337,14 @@ var PlayerView = {
>>       if (seekTime)
>>         this.audio.currentTime = seekTime;
>>   
>> -    var endTime =
>> -      Math.floor(this.audio.buffered.end(this.audio.buffered.length - 1));
>> -    var startTime = Math.floor(this.audio.startTime);
>> -    var currentTime = Math.floor(this.audio.currentTime);
>> +    // c for conversion
>> +    // mp3 returns in microseconds
>> +    // ogg returns in seconds
>> +    var c = (this.playingFormat === '.mp3') ? 1000000 : 1;
> This may be a bug cause mp3 shows wrong duration in gecko's native audio player.

fwiw, there is an issue with duration and offline-cache 
(https://bugzilla.mozilla.org/show_bug.cgi?id=740124)
> (Audio tag with default style)
> I will keep this approach and find out it's a bug or not.
> Added a comment on this, too.
>
> By the way, use c to replace conversion is because I don't want my line to separate
> due to the gjslint will warn a line more 80 characters :P
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla-b2g/gaia/pull/1688/files#r983923
If you want to make the `new` activity handled as `inline` disposition, then you should change this line and the manifest.
in fact, not only text but email, number, etc

You are totally right, I'll do it using a dataset and I'll look for those ones.
not sure if this needs some indentation after an '='
this is wrong :p
nah... we would have ignored them too :-)
Right, I'll do that as soon as I finish the conversion. Some pending specs started to pass unexpectedly, so I need to figure out why before I push them ;)
Missing a ' on the toField symbol.

Also I find this explanation confusing. Non-nulls are Options and nulls are None, right?
Won't the label already knows how to bring the correct value?
If special parameters are needed for specific OS definitions like this, I'd prefer to see them in guest-os.cfg.sample,  However, see my comment below, b/c I'm not sure this new parameter is necessary.
move that up, something like:

```coffeescript
if type is 'apost''
  el.href = Redirect...
  return true
value = ...
```
There are media query mixins for different screen sizes built into the front end toolkit, so to make this compatible with the rest of the GOV.UK frontend I suggest using those or things will go out of sync
Do you really want to inherit from Exception? I think it's much more normal to inherit from StandardError. See: http://rubylearning.com/images/exception.jpg
whoops, yeah - typo.  Fixed
Hi zhouqt, invalid value(negative testing) also is test scenario, so we shouldn't block them in our codes. thanks.
No need to use `get` here since you just set the key explicitly above
It isn't clear that `'codebase'` is meant to represent the name of a particular codebase.
Does ``block.tagName == "CODE"`` need to be included here?  According to that article 

> This causes incorrect display of whitespace in elements that ought to preserve formatting

Since ``code`` is a span element that does not preserve formatting is this necessary?
Can you change the wording to something like `Send the SIGKILL signal instead of SIGTERM when killing child processes managed by the process runner`?

Otherwise, LGTM
It seems that szFilePathA is not needed, can we pass NULL to unzGetCurrentFileInfo()?
How about add a line space before "return zeye"?
Thanks. I think this is the best compromise between modularity and saving space in flash memory.
will it be loaded automatically?
We are not making a sidebar in sponsor.html.
filename can contain any byte, so it's not a string but a byte array. Can't use snprinft and friends
shouldn't this be checked for NULL return?
I totally agree about the use of ```tempfile```. I haven't done it yet because an (admittedly very brief) glimpse at the file ```tests/test_simple.py``` seemed to suggest that things are handled "in-tree" there, so I thought I wouldn't break with that tradition for the time being. But that's of course not a very good argument, and I'm more than happy to convert my tests to using the ```tempfile``` module.
Woah, big mistake I've made. It will work only with one abort in a row. Have to get rid of this NullPointerException threat.

When previousBuild is not the first one and it was aborted with no test case result (prev == null) and will check if the one before it was the same it will throw NPE at prev = prev.getPreviousResult();

I feel so ashamed.

Thank you.
make sure you really need marked_for_destruction?
It will break for loops as it would loop over these undefined array entries.
Shouldn't we say `returned value` instead of `return value`?
I think we should change URL.prototype.scheme getter so that it never throws and returns `null` on scheme instead.
Why the calls to both internalWatch and internalRequest - which can call internalWatch with an empty options block?  can internalWatch return before internalRequest?
I'm surprised we don't use ngettext.  I would have expected us to be counting thingamabobbers like email accounts and identities etc.  True, it shouldn't be hard to implement if we ever need it.
@benadida - Is the intent here to cause stored emails to be deleted if the user is not authenticated?
try:
  import usb
except:
  pass
No, that's why I removed it. https://alpha.app.net/mark/post/344844#344803
You should update the documentation accordingly if you remove this parameter.
As far as I know, no. Why? If you want to move that to the constructor, it means copying code since constructors of specialized Criterions do different things.

Note that I just moved the code from Criterion to AbstractCriterion, without refactoring anything else than the PS handling. Let's not pollute this PR with an even bigger refactoring that may take place in the future.
This is probably better handled with `method_missing`, since that also indicates the problem.
Yes, just so.  Our policy over the last year has been to upgrade older Ruby where possible, so that you can write code that works nicely on the most recent version we support, and "at least works" on older versions.  That seems to be the most robust and effective way to keep things working, and so far hasn't had too high a support cost - certainly, much less than having to limit ourselves to Ruby 1.8.5 syntax ever did.

That is the same reason this line changed overall - 1.9 changed to return symbols rather than strings from `methods`, and rather than convert backward we upgraded older Rubies to also return symbols from the same core method.
This test needs to make some sort of assertion about the return value of `@provider.latest`. Without that it is just an assertion that no exceptions are thrown.
This should be "more than one parameter" (singular)
I've separated out the specs to show the difference between 1.8.7 and 1.9.
Can we use `content_tag` helper here?
Why is this an extension message anyway?  Why not just use a plain old IPython display_data message?
Remove from pull req.
Most likely not, `ArrayBasedDirectedGraph` seems to work fine without them, I do it just to be explicit - can be removed if you'd like.
It would help to name future something that indicates that it is the 'unbounded time' future, as opposed to the future generated by 'within'.
You can just move report creation by commit to another task (which will add `process_report` task to the queue in the end) or to the `webhooks.views.handler` view.
yes ! thx
Class with only static methods should mark as "abstract" no ?
It's about coding formatting. Anyway since there are a lot of files with this format I suggest don't change this now and do it a mass change later.
done now i am thinking how to do it so that travis puts the yc on that folder
Actually looks like I can make it prompt the user using $WarningPreference - will give that a try
As of right now, the growth system is not even implemented yet. I think @Afforess is working on that, and he can decide how modifiable he wants it to be.
Look at the update-db.sh sample and follow its pattern on introductory comments.
->

```js
if ( this.$items.length == 0 ) {
    return false;
}
```

idiomatic.js:
- Space
- Braces
- Never ever use == if you don't have to, use === instead
Ok, check out be07654d. I've defined all the referenced classes - I've not defined NewsArticle because it's only referenced via the join, not as explicit ruby.
not sure we want to use mkvirtualenv here.
This LOC is locally part of the previous block. Remove the line space previous to this line and add one after.
Might wanna add?

    if (!$class->isInstantiable()) { error }
Single hash.
The convention you recommend encourages users to build there own URLs and the user can only do this by extracting information based on the structure of the URL.

An an XML representation of a collection of tasks is still a valid resource. This quickstart is a contrived and very simple example that builds on the helloworld-rs and tasks quickstarts and the user needs to see the stepping stones from those quickstarts. to tthe current one. In a real application there would be other ways of discovering resource URLs for tasks.
Freaking Sublime Text 2 doesn't know how to indent.
This is a good change, but it should be a separate commit with other pure-style fixes. Try to stick to the task at hand in a commit unless you're explicitly doing style cleanup.

`git add -p` can help add chunks of a file to a commit. Or `git add <file>` instead of `git commit -am`, which commits all changed files at once.
I would use `from pages.log_in_or_create_account import LogInOrCreateAccountPage`. In a later patch we can actually move this import to the `click_log_in_or_create_account`, which will return the page object.
I think this is not working.

Could it happen that scheduling this on the next tick, a new `data` event fires before our `_fetchHeader` call?
This will break the header. ;/
Introduction of a magic number (see L468)
from installMysql import mysql_exec
mysql_exec("\. {0}".format(get_create_db_path()), True)
This script is not used from the command line but from Jenkins. So it should exist in the appropriate workspace. It will work because we don't clean it up.
Also, missing a space after the starting `-` ...
The `GRAY` is pretty dark and makes it kind of hard to read some of the measurements. Perhaps this would look better?:
outerShape: `{ fill: BLUE, stroke: BLUE, "fill-opacity": 0.5 }`
innerShape: `{ fill: "#f8f8f8", stroke: BLUE }`

(`#f8f8f8` is the background color...maybe we should add a constant to math.js in case Jason decides to change it again...)
Strictly speaking, this null check isn't required per the contract of the ContentMapper interface, which says that Node should never be null. Plus, the place where it's called will never pass in a null Node reference.
Just for the record; the comments I added were not intended as a reminder to refactor, because for now this seems to be the best place to locate those language dependent strings. Its only that I didn't notice the globals until I ran a code analysis (zerobrane) on the file, and the globals caught me by surprise. Hence the added comments to make it more explicit.

Then again, if you use ml's named-placeholders, then updating say to hold either a string or a table of strings per key is a trivial exercise
Add a space after `page:`.
Actually that is something I've used for debugging, to know where stuff came from.  The numbers in the comments are only to distinguish them from each other, not to reflect the recursion level.  Soon i'll make it switch on/off because the code looks nicer without them.  :)
Why do you update this line?
or ``'%s%s%s' % (my, other, tuple)`` of course ;)
I found what happend.
When I search for last changed attribute I save 'prev_attribute'.
But it is next atribute in fact, because I make reverse_each iteration.

I fix this soon.
I added the name field to the db on master, can you revert this change?
Being explicit here is a matter of documentation too.
Left some `print`s in here :P
The borrowed documentation doesn't record why a 204 would be sent.
The return value of this function needs to be documented
How would you do it otherwise? As far as I understand, the me feed adjustments you did always return the current tenant server you're on. When you're on a tenant admin UI on the global tenant server, you'll still need to check the URL as the me feed is always going to give you the global tenant server.
Should start with `verify`. Should also have some documentation.
Oh, hmm. Yeah, that's right, I moved them. Look in ObjectGenerator, not Static.
@jdlrobson i focused the change on the select element rather than on the h2 element because the h2 element seemed to be fine, e.g. on the about page the “About” lined up okay with the back button <

taking a closer look at the select element it is probably better to adjust the margin on it, so margin-top: 0 and margin-left: 0 ( if necessary ).

will you take care of the change?
The data was provided in a CSV and it contains the state name for readability.