labofsahil/github-event-dataset-2012 huggingface dataset:
I'm pretty sure this on it's own is insecure? See http://wiki.nginx.org/Pitfalls#Passing_Uncontrolled_Requests_to_PHP

Perhaps a few comments and a try_files in this block will suffice?
I am not aware either..
Extending the `mailer` service (and accessing it) will still have the original mailer created and passed to your custom closure. By the time it reaches your closure, it's already marked as created and will cause us to flush messages.

I can add an additional test to cover that, if you think it's necessary.

Or by "tweak", do you mean replace the service definition so it wouldn't be created with that transport in the first place?
Instead of doing that, they could override `swiftmailer.spooltransport`
The doc uses absolute links everywhere. I'm not sure relative links will work properly.
Sorry. I have my eclipse style set for work with some apache projects that dictate this style.  I'll change it.
Cute.  Interesting idea at http://stackoverflow.com/questions/4877931/how-to-return-an-empty-activerecord-relation  to just add a "none" scope to ActiveRecord:

    class ActiveRecord::Base
     def self.none
       where(arel_table[:id].eq(nil).and(arel_table[:id].not_eq(nil)))
     end
    end
I'm not really sure on that part. Given that it is so much more client driven, what it is doing is probably much more obvious. Though I guess understanding the internals might still be useful.
What is happening with the name `UserResourceScan`?
Sorry, how do I download this? I want to play around with it too please!
Not a requirement.  If this is a walkthrough of a particular install, this is fine, but you can put log files anywhere you want.
maybe provide both this and a fictional example.
in retrospect this is an i.e.
you'll see the change in my diff, but "Log onto" isn't what you mean.
- s/will cause/causes/

- blank line at the beginning of the file. Intentional?
me gusta refactor.
in any case, we should exempt these urls from the url prefixer? (I forget how to do this)
We won't have the same Special: url's as MindTouch. For now we'll just have "/{locale}/profiles/{username}" and we'll have to add the rest as we go.
Kind of hard to understand.

maybe: "use current_x if the size has been set and fall back on 80 (Gravatar default) if not
Is a new sub-directory required? What are the benefits? Can we upload to `files/` directly? Maybe using a ".part" suffix is enough.
`$undelivered_user[$row['user_id']]` is an array of unary values and is only used for counting, so `$undelivered_user[$row['user_id']]` should really be turned into a counter instead. This line should probably be `$undelivered_user[$row['user_id']]++`.
Yes, outside. Each link is its own list item, so adding things inside the Board index list item doesn't make sense.
Use upper case for constants.
Why is there an l_ prefix here?
No inline assignments, please. Same below.
`not new_answer` or `new_answer is None`
Yep, for simple cases like yours it's a good practice to use multiple return statements, but in case you have local objects - please use only one.
And in class name too!
Ah, OK. I wonder if that should be changed in stdenv-updates... @edolstra?
plain Confusion is appealing in its simplicity I know
I don't know how OpenMRS responds with attributes -- sometimes with resources, if you don't post it, then retrieve it, you get a null back. Sometimes, you get a "" back.
Make into a real ```.. note:``` / ```.. note::``` (I can never remember which)
Should there be a double ':' here?
This should be in the 3rd-party section alongside `matplotlib.pyplot`. Similarly for `mock` and `numpy`.

The `datetime` and `contextlib` imports should be moved to sit with `os` and `warnings`.
Have you tested this function with this exact code? AFAIK you need to put ``global hashlib`` as otherwise the Python compiler will believe it's a local variable, and it will crash on this line (at least that's the behavior I get with a simple toy example -- I didn't try this specific function).
Well, idx.stop might also be a numpy.int32 or uint64, while we are at it.
I can have a look at it now, but maybe we should make it a ticket, I'm not sure.
Our coding guidelines require braces for all control structures. Since this is product code, the change is worth making where braces are omitted in this function.
No, really, this "extends Pair<Object,Object> was not one of my better ideas. It's not adding anything here. Please take it back out.
I guess that's because of an array of structures, well after checking further I found that it was wrong anyway simply just because value in m_amount isn't right for some spells, aura's amount seems to inherit its value from "mother spell" as well for example blood worms talent:
```
BasePoints = 2 to 5
Targets (1, 0) (TARGET_SELF, NO_TARGET)
Aura Id 231 (SPELL_AURA_PROC_TRIGGER_SPELL_WITH_VALUE), value = 2, misc = 7252 (7252), miscB = 0, periodic = 0
```
BasePoints 2 to 5, but in value we get 2, that doesn't sound right or I am completely wrong and retarded? :D And I feel like making an excuse about me being bad at what I am trying to do, stop making me feel ashamed, you, evil jackpoz :(

So yeah, ```
spellInfo->EffectBasePoints[0] = GetSpellProto()->EffectBasePoints[0]; ``` right?
tell what exactly is wrong with it ?
Newlines in an exception message? Really?
I think this work can still be part of 0.3.0 since we haven't released it yet and it's solving the same problem.
Luigi, the code you are scrutinizing has already been reviewed and merged. This branch is just concerned with refactoring and extending existing functionality. I agree with you that it's nice to stick to conventions, so if you'd like to suggest an alternative implementation, feel free to submit a pull request.
Hooray, CoffeeScript can do this for us automatically!
* 毎回setDay:1で1日のdateCompsを取得していますが、この処理をセルの描画の度に行う必要がありますか？
There were some places that didn't make sense. Although I'm sort of too tired at the moment to remember. I'll get back to you when I'm not a sleep deprived mess.
What about "else?"
This function was removed.
Regarding IEEE 754 compliance, from the postgres documentation:
{quote}
 Note: In most implementations of the “not-a-number” concept, NaN is not considered equal to any other numeric value (including NaN). In order to allow numeric values to be sorted and used in tree-based indexes, PostgreSQL treats NaN values as equal, and greater than all non-NaN values. 
{quote}
I think I would actually prefer a manual dict, mapping the class names to classes, since you already have a manual mapping for the decoder you might as well clean it up to a single dict that defines supported classes.
This also does s/:llvm/:clang/, is that intentional? Or do we want both?
This is liable to break if the prefix contains spaces. Doing it like this avoids any shell quoting issues:

```rb
args = %W[DESTDIR=#{prefix} USRDIR=#{prefix}]
system "make", "build_all", *args
system "make", "install_olsrd", *args
```
Is this necessary? Also, you can use `Dir.mkdir`. These are Ruby files after all.
There are mixed {% blocktrans %} and {% if %} tags, the {% if %} should be outside {% blocktrans %}. Anyway I don't think it is necessary to change anything here - the activation is called after registration, so once user gets here, the registration has been enabled.
Ok - I have an idea.  I'll just do it this way, and we can re-design the tests for Java 7 if it's a problem.  I might be mis-conceiving the order of things.  Give me a few minutes and I"ll update the tests.
Processing?
Probably unnecessary. Static injections!
A general wrapper will be in the next version :)
make -j8大约就是只可以只编译不安装就能在编译目录使用。我维护的两个服务器都是这样。
Check for error here
Braces not needed here.
For my information, did you make this change by hand, or automatically by running ant?
Then it's fine. I remembered Dreamweaver has space before the colon in all Japanese labels in UI, but we can go without it for Brackets. Thanks anyway.
This param is added twice.
!= should be !==
The [diffing cheat sheet](https://zerowing.corp.adobe.com/display/brackets/Working+with+Git+and+GitHub#WorkingwithGitandGitHub-Diffingchanges) works wonders... :-)
name needs to be escaped before adding to HTML (or add after the fact via jQuery)
The result wouldn't be very useful then, though... you're right.
The first element here should reflect the error condition back to the user. I've made sure a more reasonable atom is also returned (in reality, the way that I'm returning is a little bit braindead and we sometimes return an extra atom-- I won't change it now (it touches quite a lot of code and shouldn't be causing a /problem/ right now) but on a future pass we might want to return "real" tuples rather than the hardcoded approach.)

       return std::make_pair(status.ok(), ATOM_OK);

...now the atom will also match the status.
Could just do `kwargs.get('render_as') or 'view'`
As you can see at: https://github.com/jjCavalleri/ezoe/blob/e5ee7a36ca3efd41c81dfde33db469f7296091dc/design/standard/javascript/plugins/fullscreen/editor_plugin_src.js
You have broken the alignment, be sure to never use tabs as per our Coding Standards.
a while ago we needed to: 37173bf67fc93514a16b52763f8facfe531d5583

not sure if this is needed or not anymore, i'll check it out.
I don't think it is. 

This re-emphasis what I think is the real problem: who is supposed to take care or the current extent between the MapContext, MapTransform and MapControl? Only one should be responsible for it. It seems like a grey area right now...
I thought about defining the method in `Repoistory` but I ended up copying the implementation of `Repository#tags` & `Repository#ref_names`:

https://github.com/libgit2/rugged/blob/development/ext/rugged/rugged_tag.c#L201
https://github.com/libgit2/rugged/blob/development/ext/rugged/rugged_reference.c#L90

Do you think all these methods should be defined on `Repository` or just `Repository#remotes`?
Aa, right. Is this ok: {% with next|default:'/'|default:redirect_to as next_url %} I tested this line of code, and it works.
Start with upper case.
this is interpolating a variable into an empty string. It should be:

```ruby
'title' => title
```
I did the same thing here, which works in FF and Chrome: http://secretrobotron.github.com/crunch/
Ok, I put it in line 117 where the overflow gets set
why ignore the stylesheet?
space between 'if' and '('
`allow_ambiguous_match` I think is clearer, but in any case, this param could use a description in the method-level comment.
why do we need to remove these 'return' ?
Since this doesn't seem to rely on DAC for accessing anything (maybe the ca certs?), it might make sense to just drop all supplemental groups regardless of the groups in /etc/groups:
  setgroups(0, NULL);
FWIW, http://screencast.com/t/rtsdXnkjr

it does show the exception content on UI.
alloced -> allocated
I don't like that "juggle" is shadowed here.
Let's change all the println to proper logging statements
I think its a logical necessity that a serializer  have a syntax (In fact we have made that the case by placing the Syntax into the type of a Writer) and that this syntax have a name that is useful in communication. After all serialisations are meant to be deserialised by following a grammar (and in the world of human engineering these have names) Here I have not directly tied it to a mime type, but to the Syntax class which makes things a lot more flexible. 

Initially I thought one could do this with case classes but it is when programming the example shown above that I got stuck. I don't think typeclasses will be useful there, as I need to pass any type of Writer to the function (( sadly all we have are blocking ones )), and I can't know on receipt of the writer what its typeclass is (I think)

Seperating the mime type and the writer leads to very ugly code too, quite fragile ones too. In Play2.0 it's a bit of a mess there as I argued in a recent mail to their list https://groups.google.com/forum/?fromgroups#!searchin/play-framework/henry$20story/play-framework/XtPGZ22VZ08/P_fWwPn2uhQJ

There the two are separated, which just feels weird given that any serialiser or parser MUST know the syntax that it is parsing. Who else would know? And in that case why move that information elsewhere.... That's what led me to that change.
yum upgrade should be run, because yum update does not take packages obsoletes in calculation
You are missing remove_index in the tear down method.
What is this for? Support of systemd tomcat restart?
Ah thank you for this explanation.
Well, I was trying to replace them slowly when I encounter them. This ways is low cost, but if you want I stop.
Yes, a future patch there will also be:

 * firefox.sh (runs unit tests on firefox)
 * b2g-desktop.sh (runs tests on b2g desktop)

Thats my reasoning for breaking this out into three scripts vs just one larger one.
maybe mozl10n can contains the direction of the language? This will make things easier for applications.
I don't really like getDisplayedApp as a name, maybe this is because the singleton is called WindowManager. just my 2 cents.
Fixing signed/unsigned comparison warnings is a good opportunity to see if there's illogical/insecure stuff. But in this case, I'm not sure what was the intended behavior.
Has been fix in commit d83b790
As mentioned before: partOf is just one possible way to specify parent/child relations. It should not be hardcoded in the library. createphp needs to treat all rdf names as arbitrary strings, since they can be different in every application based on the semantic signification of the data. 

The clean way to do this is to look at the collection definition in the parent type. There, a "rev" attribute is specified, which may be partOf, or something completely different. And this is what you look for in the received data.

I realize that this is a bit of a chicken and egg problem, so maybe we have to duplicate this information to the child type, but hardcoding "partOf" just isn't a proper way to implement this
Hm, that reminds me that fixCR is being called on html, which is probably not ideal.  It might be best if you get the original output back, and transform the two together.  It also suggests that fixCR should be called *before* fixConsole.
Ah, ok. Will rerun now.
maybe switch to Optional.absent() and instead of find(.., null) switch to tryFind()

can get rid of a number of nulls this way
On an initialized and uptodate submodule, i get:
```
D:\mgv\src>git ls-tree HEAD | grep libgit2
160000 commit 111ee3fe2d4c6de6729b94235c709986b4079c4b  libgit2
```

Is attr == 0160000 sufficient?
The SHA1 (111ee in this case) refers to a commit in the submodule.
What happens in the scenario when one of these two flags is specified, but there isn't anything in the working copy that matches these criteria -- no ignored files to include, no untracked files to include... does `commit_untracked` fail in that case, or is there such a thing as an empty commit? it seems like we would not want to get an error code here and `goto cleanup` if the answer is that there are no items in either of these categories.
I haven't included the dash there, because in that case `rhel63-base.img` would not be found.
`_('Sign me up »')`
doh, missed that.
In the two smartphone-size responsive layout breakpoints, this button has dark text on the blue background.
I got tired of waiting for essearch to do 3 search page requests. I only care about the first page anyhow, so I made it configurable.
This validation error is making assumptions that aren't justified based on the fact that `Exception` is being caught - how do you know its a missing key that's the problem? If you were catching `KeyError` that would make sense, but if you're catching `Exception` all the error message can legitimately say is "unknown error: "
s/Postgres/HBase
So I finally did it. For some reason I couldn't make it work when I tried yesterday, and could today. I suppose I missed something somewhere.
Ah see, told you I was under the influence of pain killers ;) Will fix this up
Nice!  One thing is that we probably want to create a new Request object here from the random track, not just start playing it.  That's because people will want to be able to go the site and see which track is playing, vote on it etc.. 

Also, please use English for variable names. :)
These @params should be removed.
According to the first reply to the bug report by felipe@php.net, it is not actually a bug, so it probably won't be altered. I think it is the result of a difference in implementation of symlinks between windows and *nix.

An extra "if-windows" check might be appropriate here, though
Cloning the inner dispatcher is a bad idea IMO. How far would you want to go ? Cloning all listeners registered in the dispatcher too (which cannot work as they are not all objects btw) ?

If the user really want to mess things by keeping a reference to the dispatcher from their form type, we would simply not support that case (and anyway, I never saw a need to keep keep a reference to the dispatcher inside a form type). And even if you clone everything, one could argue that using Reflection allows to change everything in the class...
does this work with all Doctrine projects ? The validator is not used only by the ORM currently
ok i can revert the term
suggest and require-dev aren't really mutually exclusive
why cant we do: `$this->handle($exception)`
do you really need this magic method ?
I thought I had just added the line and not removed. I added the 100x100 because when I started out that image size was going to be used in other place as well, but then I didn't. It could very simply be reverted and just resize for that one instance.
I understand the bug you're referring to and what creates the difference between the comparison and the assignment. 

I'd prefer to have the variable on the left side of the comparaison and the value being compared to on the right side as I think this makes much more sense for readability.

The `=` instead of `==` isn't difficult to catch if you happen to make the mistake.
If you use an instance variable here, you can get rid of the argument here. (Aside: it reads strangely to say `log_in_guest(guest)`.)

Meaning, I believe you can use the `@guest` instance variable in the `log_in_guest` method.
Seems too general. Any private message would pass.
要低调哈，我也是高手啊~~~
That's my understanding. If anything, it is generated on compile from the main one in the gwt source folder.
Where does this 0.3 come from?
how about

    switch(message.rawCommand) {
      case '331':
      case '332':
      case '353':
      case '366':
        client.emit('raw', message);
        break;
      default:
        if (message.rawCommand.match(/^\d+$/)) {
          ...
no point in scheduling using once with a function that is created every invoke.  Instead, you want to not pass callbacks in a closure but have something like Ember.run.once(this, 'flushCallbacks') and schedule flush when callbacks are added.
These are our new functions that make the save and sync status bars change.
this needs to be put back, probably just a copy paste error
isAlias()
add `XXX` note here and paste the bugzilla bug url.
Can you add parens () around the operations in moz-calc?
There are some issues with "bild" use in code. Etienne has fixed some issues in new Pull.
these parameters are URLs and application ids that might be changing. if we hardcode them on the code it will be harder to change them and difficult to deploy.
Also, is this showing the contacts details after the alert (as it is not returning)?
This wont work, you should use `/shared/js/l10n.js`
nit: the naming sounds odd
I don't think this cuke, as written, provides much value.  All it really demonstrates is that the configured URI parser can be accessed later, but it doesn't show that VCR actually uses it.  It's also a bit weird that you wrap the check of the parser in `VCR.use_cassette` since the parser value will be the same regardless of if a cassette is in use.  I also don't think it will be a common case for users to write their own URI class as you've done here--it'll be far more common for users to use `Addressable::URI`.

Instead, here's what I'd like to see in the cuke...if we can come up with an example localhost URI that parses OK with `Addressable::URI` but fails to parse with `URI`, then it'd be cool to have a pair of scenarios where one demonstrates that VCR w/ default configuration fails when making an HTTP request to that URI, and the other scenario demonstrates that you can fix the problem by setting the config to `Addressable::URI`.  The trick is coming up with an example that demonstrates that.  The underscore-in-domain issue won't work here (since we want to make a request to a localhost server we control).  Can you think of something in the path or query string that `Addressable::URI` parses but stdlib `URI` doesn't?
These two translations are now in english, why?
What does `˜˜` mean?
I don't think I can move it without changing a bunch of things, since every time I add a single element to `CMSInstance`, I call multiple update operations on `CMSCountsTable` (an update operation per row).
"Queue" will pick up this event now.
No need for this crap. Assume non-IE HTML5.
Can you revert this change? The file was changed and you changed it back.
It worked the last 30 times I tested it, yep.
Stepping in 0.01 block spaces can miss block intercepts.  The original version doesn't miss any (well assuming it was actually working).
should change heading to h2
you didn't implement the index view. why not?
This will start working, once `slave` or `slavename` is passed to `.getLock` of `Real*Lock`, instead of a `SlaveBuilder`.
It should be ``isVerbose`` IMO
Here's a gallery with a "back" link: http://www.guardian.co.uk/world/gallery/2011/oct/03/meredith-kercher-murder-timeline-in-pictures
Nit: We don't use `aArg` convention, so `rawTab` or `tabElement` would be more appropriate.
How is this different to:

```javascript
let result = promise.next(function task(value) {
  return value + 10
});
```
@benadida - how is a primary only account handled currently if there is no way to reach the IdP?  If a user is trying to sign in to Persona using an address that was at one point associated with an IdP, that IdP is *not* in the cache of IdP auth/verify URLs, and that IdP is unavailable currently, what happens - does address_info return "secondary" or "primary" as the result?  

It looks like from the lib/wsapi/address_info.js and lib/primary.js, IF primary.checkSupport cannot get URLS and the email is known, it automatically returns secondary.  How is this case different?
Whoops, fixing.
nit: missing new line.
Because if for any reason it fails (dir is locked by some process or whatever), I don't think we should bug the user. It's really not such a big deal, just an empty dir left over. On windows it's quite easy to have filesystem locks since the OS handles that very differently than *nix, having a terminal open in a directory locks it for example.
The way I have always handled this in the past, and has worked well, is to make a commit immediately before creating the annotated tag.  I update the version identifier and the CHANGELOG (if a CHANGELOG is present), commit that, then tag the tree with the exact version I just updated in the code and in the CHANGELOG.

This has worked well for me and can be automated, especially if the version identifier is in a separate file that contains _only_ the version identifier and nothing else since you don't need to use sed or anything.  Just a simple "echo 1.2.3 > VERSION", commit, tag, package, publish, rinse, repeat.
I don't know.. I just followed existing spec descriptions like this: https://github.com/rubinius/rubinius/pull/1816/files#L2R1010. I don't think '(idx)' is necessary. If it's ok to do so, I'll happily remove it from all descriptions.
This should be UITableCellView, right?
+1, the `buildPrivatePub` function should not be exposed.
Should be `(%s).evalf()`.
Not possible, as this trick is needed to "mock" out the call_user_func call
in Zend\Soap\Client. Inside Zend\Soap\Client::_doRequest, a call is made
as call_user_func(array($client,'SoapClient::__doRequest')...). There is
absolutely no way I can mock this out from PHPUnit. I am forced to resort
to defining call_user_func inside the namespace in order to intercept the
call and make sure the base method is called when NTLM authentication is
not used.

Jessie


On Tue, Dec 11, 2012 at 3:10 PM, Maks <notifications@github.com> wrote:

> In tests/ZendTest/Soap/Client/DotNetTest.php:
>
> > @@ -0,0 +1,262 @@
> > +<?php
> > +/**
> > + * Zend Framework (http://framework.zend.com/)
> > + *
> > + * @link      http://github.com/zendframework/zf2 for the canonical source repository
> > + * @copyright Copyright (c) 2005-2012 Zend Technologies USA Inc. (http://www.zend.com)
> > + * @license   http://framework.zend.com/license/new-bsd New BSD License
> > + * @package   Zend_Soap
> > + */
> > +
> > +// @codingStandardsIgnoreStart
> > +
> > +namespace Zend\Soap
>
> Use different files for different namespaces
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendframework/zf2/pull/3202/files#r2383929>.
>
>
Surround classnames with the <classname></classname> docbook tags -- this should be done throughout.
Awesome, thanks for the feedback guys!
This should be outside of this ```if``` block and wrapped in an ```if (isset($routeMatchParams[ModuleRouteListener::MODULE_NAMESPACE]))``` block of its own.
This should be imported, or a DB component exception used.
I'd argue we're still doing input data checking at this point -- we don't want to do the merge unless we have a ServiceConfiguration. That said, I'm re-working it slightly now.
Ah, thanks. I actually remembered reading about that, but I couldn't get it to work with `String.prototype.match`.
yeah, nice! 

Updated.
Why not just "/stats"
Well I just found that it works like that so i decide to update the docblock but it's not a direct consequence of this PR. The BC break must have happened in a previous PR.
Since this is commented out, can you remove it?
didn't we have the discussion about naming of classes before? IMHO ``ForceLanguage``
I guess one thing you could do to fail fast is:

if EXPORT_CACHE_ID != "default':
  assert(EXPORT_CACHE_ID in settings.CACHES)
I just pasted the explanation why it should be on same line. =)
Not trying to be impolite, sorry if it meant like that.
So should I leave this as it is?
Why do you need to do this here? You shouldn't have to do this.
escalus_users:get_server
Arquillian and JBoss AS connectors are now in Maven central so you can remove the repository definition
default_start and default_end require generating a datetime for the current moment, but default_interval is just a string from the set ('minutes', 'hours', 'days', 'weeks', 'months', 'years').

Think it should be changed?
Put these declarations on 3 lines? (One var is OK, but will make it much easier to read.) jQuery doesn't have a utility to do this?
Can you link to the particular channel here? Dunno how `irc://` links work...
We could wrap these 3 ifs in a if ( debug ) and then check for each case only if debug is true
++count === expects
Removed. This was designed to prevent the names of tags in the left column from bumping against the checkboxes for tags in the right column. The list items containing the tags have right-side margins, so this is unnecessary.
I'll submit another patch for this... I've noticed that for whatever reason... as is... I'm not actually getting the quotes around the uri... so its trying to treat it as table names etc, and likewise fails
:my_reports relies on :my_hosts, which now has the Admin check internally.
This is actually incorrect for real Unix shells. It will do this:

```bash
echo hello &2>/dev/null
hello
[1] 55419
[1]  + done
```

because it is interpreted as `echo hello &` (the `&` backgrounds the process), with STDERR redirected to /dev/null (`2> /dev/null`). What about this instead?

```ruby
def bit_bucket
  if unix?
    unix_bit_bucket # a method that returns "2> /dev/null"
  elsif cygwin?
    cygwin_bit_bucket # "&2>/dev/null"
  else
    "2>NUL"
  end
end
```

This would keep the `unix?` test the same, but add a different check for cygwin.
Should be ```webpage```
A lot of unnecessary (and unwanted) import reorg here...
Should have explicit @Produces/@Consumes on each method, with proper versioning syntax.
nit: Same thing with escaping html, `<` should be `&lt;` since this is just text inside a `<div>`. I know.. I know... it's a crazy way to do javascript...
seems like you don't need this constant at all. just checkin with ```window.getComputedStyle ``` should do the trick?
added in my master branch (8eeebc3359d2533f45335517c4657ef092d2541a)
On Thursday 20 December 2012 01:56:28 Mark Bessey wrote:
> I removed the "onyx-affirmative" and "onyx-negative" classes from these
> buttons during the UI cleanup, to make them less obtrusive. 

ah. ok. I thought we had forgotten to apply color there as we did in other 
instances. Sorry about the blunder.

> I think saving
> colored buttons for exceptional situations (like deleting your files)
> works better.

Indeed, I now have seen the color and label change when 'delete file' is 
selected. It's much better.

Thanks for the explanations.

All the best



-- 
 https://github.com/dod38fr/   -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/  -o-   irc: dod at irc.debian.org
This one should definitely be private if not accessed from outside of the class
Note those two lines below.

```javascript
      fnPage = re_badFilename.test(fn) || /\./.test(fn),
      dirPage = (dir.length < 3 && re_noLetters.test(fn)) || re_justDigits.test(dir);
```

All rules has been integrated. no one removal.
Please try to reuse some abstract implementation of BeanDefinitionParser
Okay, I'm curious then what kind of debug logging we should aim for, as this will probably come up more in the future if we don't figure it out.

I can agree that there would be too many log statements particularly if there is a large number of participants.  Would you also say that the "Participant 11 added to 245" is unnecessary?  

If so, what part of the tournament creation should we log?  Perhaps one logging statement per match with the participants in it?
Or perhaps just one logging statement for the tournament, saying it was successful, with the match and participant count?
Because I hate hard-coded strings :), and this one was repeated in a ton of places.  In some files we had a variable for it but we were inconsistent.  In any case, I put this change in an isolated commit so that if I am outvoted it will be easy to change it back.
FWIW, it is still an issue. Had it this morning.
Having that information would be valuable. Ideally we'd be able to pass in an object with more information about what really happened. It's a bit painful to have to split the string to get information now.
Incorrect order
Couldn't we just use the GT tenant for this, instead of always creating a second tenant?
Is there a reason why we'd want to exclude a user having a login id from the same provider ?
Fixed. We require that absolute paths are used now.
Because I cannot pass itself (``this``), what would be the good value. The ``getDebugTarget()`` method is overridden to return ``this``.
I don't know of such a conversion (I was also thinking there should be one). But I meant there's no need to create a new anonymous class in this case. Call it nitpicking :)
看这个实现：https://github.com/sofish/validator.js/blob/ec7d36b063de3ccb8f0a19393bcbadb9c09efda1/validator.js#L159
titles or title ?
same thing here. 1 PR = 1 feature
Oh, so you added that. But this *definitely* does not belong in mrjob.
Два разных шаблона имеет смысл отделить друг от друга пустой строкой
Uppercase OR.
And what happens if `realpath()` exists, but returns FALSE due to it not having exec permissions?
Fair – I was just going for consistency with the previous code, but I suppose that ***is*** a separate issue. Will change!
Next time make sure to sanity-check your pull requests before sending. Removes some review burden and unnecessary back-and-forth :) Thanks!
Согласен.. Есть идеи куда?)
В симфони можно было это прямо в схеме отразить, задав список возможных параметров для поля, а вот как с рельсами быть я пока не думал.. Но вообще надо бы
I kind of agree. As you can see from the implementation, it's really just a convenience thing. I could see dropping it but making the `canExecute` property publicly writeable. But that only sorta solves the original problem of the difference between `canExecute` the property and `-canExecute:`.
Why did you stop exposing the `GitErrorCode` as a strongly typed property? We actually reference that in GHfW. Am I supposed to reach into `Data["libgit2.code"]` instead? That makes the code uglier and feels more fragile.
I removed the classes that were used only for the AutoCompleteWidget.

Marc Schröder wrote:

> > @@ -260,6 +269,43 @@ def export_xml_resources(modeladmin, request, queryset):
> >          return response
> >  export_xml_resources.short_description = "Export description to XML selected published resources"
> >
> > +from django import forms
> > +
> > +class MetadataForm(forms.ModelForm):
>
> Which of these custom model forms are actually still required? All occurrences of `AutoCompleteSelectMultipleWidget(lookup_class=...)`which are already registered in `related_mixin.py` should not be required anymore, right?
>
> The one form where I imagine it is required is LicenceForm, due to the OneToMayWidget for membershipInfo... but the others?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/metashare/META-SHARE/pull/188/files#r794973
fid sounds like a better name. fread sounds like a C function call to me :)
for consistency with other examples use pylab as pl
Message: Status code is not as expected.
`else if finishedCallback`
2 things here: 

Firstly I considered using Criteria builder but then realised this is something only available from an entity manager - which we aren't using.  If there is a session factory equivalent then it might be worth looking at.

Secondly deviating too far away from the original code adds risk of regression due to the fact that there are no tests for this method.
In the LiquiBase web says modifyColumn is deprecated, and better use modifyDataType. http://www.liquibase.org/manual/modify_column

Furthermore previous changeset (20121007-test_order_laterality) uses modifyDataType so I assumed that's the way to go, I tested with mySQL and it worked fine.
*ago* alone doesn't make sense in lots of languages. Please include all the parts of the sentence.
First of all, this isn't a note nor a section. It is a sidebare article, maybe a `.. note::` is better.

Secondly, you can use configuration blocks/code blocks/what you want inside notes/sidebar articles, the Rst isn't limited on the syntax.
the `var` bit is not part of PSR-2, is it?
拒绝指定的网络地址访问。
统一为旧式
@kellyredding - minor spelling, addtion => addition
The writing of macros to reduce boilerplate would be a good idea.
For now, I guess we could just go ahead and merge this.
see the "Testing Actor Systems" section of the Akka Documentation at http://doc.akka.io

sounds ok?
I agree `enqueueAllFirst` is not really necessary, since `unstashAll` is no longer atomic. Removed in a recent commit.
TLD? Should be com.arcbees
No there isn't, it's getting a bit crazy to get it working on all win platforms.... but I'm trying :)
`(-> content keys first ...)` doesn't make sense to me.  The first key of a map?  There is no "first" since maps have no order.  It's just returning a random key.  The fact that it's always been the same key for you, is just an implementation detail, not something you should rely on.
I think it is safe to call `notifyDataSetChanged()` without a `try`/`catch` block.
Yes, it is :-/
It didn't show up because it was commented.
NGHUTPR
You aren't going to need this, yet.
is key used somewhere ?
Correct, I'll copy this to match the production code at https://github.com/jbossas/jboss-modules/pull/22/files#L1R56
Seems like something which should be discussed and decided up on the conventions repo?
I think it is best to break after the ``|``. I'll change l. 70 to be consistent.
`fig` isn't used anywhere? Is that why you didn't do the usual `fig, ax = plt.subplots()` here?
Update here looks fine - no additional work to merge
changing this messes up correct drawing for all the other things that inherit from PaintFieldObjects, and they will be inverted
I kinda think this should just be `Convert`. Here's why. You're not converting an object to a `Type`, you're converting it to an object of another type. Yeah yeah, semantics. Also, since everything is an object, the "Object" part is redundant.
the big change here was to handle all the data cleaning in `forma-seq-prep`
Hrm, we can probably remove the respond-to logic; we won't ever be regressing to an older version of RightAgent, hence the method should always be around.
ops, this content should not be removed. By the way, this paragraph needs no change. My client has wrongly removed spaces around commas...
I think this line should be:
``s23SiteMenuContainer.on('click', '.icon-sakai-help', function(ev) {``

(because ``icon-sakai-help`` is in a trimpath template and potentially not in the DOM when this is ran).

Can you try changing the line to this and see if it fixes your problem.
Can you add correct spacing the the 2 lines above?
Precaution. I've seen deactivations throughout the code base clear "reference" collections, and generally saw it as a best practice to clear references and resources (though, I haven't researched that fact).

Again, saw it as a consistency measure, I have no problems removing it if you know that this code is useless.
a lib unittest permite que vc faça::

  self.assertIn('_id', info)
I currently cannot see if you did this:
Any method that returns a new object (like evaluate) which is SG_REFed needs to specify this in the modular interface to prevent memory leaks. Like for example %newobject create_merged_copy(CFeatures* other); in Features.i
I would still prefer to keep it simple, and remove this section. Its not about making "the one tutorial to rule them all", but rather to point out the specifics for SilverStripe. If you find a relatively authoritative source (e.g. nginx wiki), we can link to SSL setup instructions instead.
Why the change here?
TBH if this is failing we should probably fix the user model, not the test.. password should allow every character possible.
"else if" -> "elseif"
also - new line after the }
Yeah. The problem is debugging. I have a file here, `last_plugin.log`, but what I really wish is for Game Maker to have useful debug output when executing a file. Anyway, yes, I think we should do something like:

    p = instance_create(Plugin, 0, 0); // or is it 0, 0, Plugin ??
    with (p) { execute_file(prefix + file); }

That would give it its own scope... sort of. Perhaps we should do `execute_file(prefix + file, p)` so it gets the Plugin object as its first parameter, which it can then use?
Macht der Formatter diese blöden Abstände?
I think we need a comma after optimized.

Or, how about:

Use a benchmark to verify that changes to the algorithm are indeed improvements, and not regressions.
Do we need DBUnit?
Technically, .empty checks for nil, so the code could be simplified to:

```
  images.reject{|i| i.empty?}.flatten
```
"Although, with really long blocks, it may be straining too much to continue the same var statement."

I don't think it's a problem with modern editor since we can easily go to the variable declaration.
Ehm, why you loop over number of panels and then access the indexed one? Why you just simply don't loop over panels themselves?

And appendTo moves the panel to new column? Or it duplicates it?
This would probably better and `id`? There will be only one on the page. And `notifications_count` for example?
Write as a TODO comment, when you do such comments. :-)
Aaa. Nice. So in fact POST does not return the object but location. Then you can just ignore this and leave to push to send you data. :-) So even to the author. :-)
Move it to proper subdirectory. Rename to `email_address_confirmation.txt`.
"linket" -> "linked"
Constant string.

But we will not use that backend later. :-) You probably had problems with that when you tried to cancel tasks. :-)
Then you could check in other files. :-)
Hm, `user` is added by Django and is current user? OK, then maybe `object` is good. :-)
No, we have imports structured in sections. So first are system modules imported. Then Django. Then other libraries (like tweepy), then ours.
Wrap this into multiple lines.
AAAAGGHHH. I just died.
I'll close this PR and let you redo a cleaner one.
Could you add (on this, and the line below) strict checks?
All of these options should be passed to initialize in the options has, rather than being passed to each invocation of the API methods (purchase, authorize, etc.).

You can also use the ```requires!``` helper to check to make sure all the required options are being passed.
On line 96: setWaterFallKnockbackTimer(BG_DS_WATERFALL_KNOCKBACK_TIMER);
Is activated the timer to perform first knockBack
This inherit from a...

should be

These inherit from a...
Don't think we should enforce a query. Instead, base implementation could use the `ObjectRepository` in a non-abstract method (class still being abstract) and then subclasses override it just for performance. That means the `authenticate()` method would be surely fatter.
I know it produces an array of objects. But an array is just an array.
It seems `node` has no `mktemp` interface. We'll need to `exec 'mktemp' ...`. This fails in the case that the file already exists, and even if we test for that and try again, the test and file creation are not atomic. What it really needs is an `mktemp`.
Should this be named something else to be consistent with the other backup methods?
Maybe this could go in the stats module, rather than here?
Awesome, `{resolve: onResolve, reject: onReject}` solves it then.
Why not make in a `Number` here? Where this ends up you do `this._target_line = Number(data.lines[0]);`, is that the only purpose? Also, why does it need to go into an array in `resource_display_broker.js`?
Note that this is called config() to distinguish it from options() which returns a RewriteOptions*. So this is needed to get the downcast version.
Ideally we'd be able to have these variables read from a configuration, similar to how data is read. Not in scope for this PR, though.
Sorry that one is my fault, it should be `1.0.0.alpha` since `AbsoluteRenamer` didn't go 1.0 ;)
``xtol=1e-4`` is the default, so I guess you mean 1e-3.  Bandwidth should be range 0-1, but it can be small for large sample size. Therefore I think relative tolerance (xtol) should be used.

``fmin_bfgs`` is indeed faster in most cases, so making this configurable would help.
done in by pr-408-comments branch.
I'm not opposed to this change, but I don't really follow the comment.  I assume you mean the resque-retry plugin.  In what situation would the same worker try to be unregistered twice?
Now I added logo link, removed default search bar, so now we only have header search bar. But I have trouble with CSS, if i try to use my own class search results are covered by header, but if I use class that is already created in css file I used "main" positioning is ok. I can't figure out what is the problem, since I am not very skilled in CSS, so any hint would be helpful.
acclocated? o.O
As I mentioned in Texas, I think this would be clearer using private inheritance.

Then for any methods of SBInterpolated image that you want to have available for CorrelatedNoise (my suggestion for the class name, rather than an SB name), you can just write:
```
using SBInterpolatedImage::draw;
using SBInterpolatedImage::applyShear;
```
etc.

This would then remove the implication that CorrelatedNoise _is an_ SBProfile.  Instead it means that it _is implemented using_ SBProfile (specifically SBInterpolatedImage).
indenting fixed.
off?
I hadn't realised, but yes, the template stuff doesn't impact the pool, it could be separate.  Good observation.

Let's see how it ends up getting used, I'm not averse to splitting up the classes -- OTOH I could see templates becoming more closely integrated with the pool perhaps.
The constructor needs to take <? extends T> to get any benefit from this.

The benefit is that an end-user developer one can more easily pass in an EntityFactory instance with one of these things without having to sometimes cast their instance to <T>, whatever T was declared as...
this looks like an acidental revert too
Yes, for sure. It should be part of some core or common "package"/"module". Taking the NPM discussion into account, there should probably be some framework as basis for webinos modules. Maybe we can use such a framework for providing access to per-module storage, e.g.:

```javascript
var webinos = require("webinos")(__dirname);
var nfc = new webinos.Module("nfc");
var storage = nfc.getStorage(); // Returns some `webinos.file.FileSystem` (*nix: `~/.webinos/<module>/`)
```

This is just a very short example. If agreeing on such functionality, we should definitely think about how to provide it, because it will be very fundamental.
As I metioned in #18.

`textViewDidChangeSelection: ` is used to enter visual mode whenever some text are selected (Not entering visual mode if we are searching text), maybe the selection is caused by user's mouse.

`textView:willChangeSelectionFromCharacterRanges:toCharacterRanges:`
is mostly used to make sure the caret is never placed at the newline character in normal mode. The editor's selection range will remain unchange until we return the validated selection range. I've disable it for now because, when I try to call the original version of this method, Xcode crashes.

actuallly there is one more method to hook if we were to support visual mode / selection nicely.
That is `selectionRangeForProposedRange:granularity:` of the textview.
This method is called when the user press down his mouse to try to select some text. In this method, we can track the initial character that is clicked by the user. 
For example, if the user presses at char 10 and drag to char 5. The selection will be range of {5, 6}, and the caret is at char 5 right now. If we don't hook `selectionRangeForProposedRange:granularity:`, there's no way we will know whether the caret is at char 5 or char 10.
you sure it's supposed to be "!wantspod"?  Wouldn't it only need this if it wanted a pod?
Revert this.  I sort-of-fixed it so it creates some plasma, based on how much welder fuel there was.  (It's plasma since the "Trace gas" handling is terrible.)
There's a trailing whitespace here, please try to avoid them :-)
Нужно сделать метод isPrimitiveOrWrapper и в каждой программме вызывать его.
Почему именно к этому месту такой вопрос? Не оборачивать же программу целиком в try-catch?
Не процитируешь ли?
nextLine может возвращать null
@raydavis Hrmm, I might follow up on this and merge the if-else chain with some OR logic.
The list style changes here, and the index repeats.
We've typically tried to avoid using _ as a variable name as it clashes with gettext.
Ok well you can use is_editable() on the back of find_element() and if that throws an element not found then you can return False.
I often reenable that code for my testing, so I'd rather not remove the code. Would your rather I change it to an "#ifdef 0" and removed the double slashes?
Yes, we can use "use" here.
Спасибо, буду знать.
Really minor comment: I'd rename `ar` to `labels` (which is what `morphology.label` uses).  (You use `labels` in the code already, but I think these should actually be `relabeled`).
By this you mean normalize each vector to have a norm of 1? Users coming from computational
linguistics backgrounds might find this phrasing hard to grasp.
``node_id`` seems to be discarded, so maybe just leave it out?
ふざけんな！書きなおせ！
Ditto. This re-formats some code and adds a new option. This should just be the new option.
WAT !!!!