labofsahil/github-event-dataset-2012 huggingface dataset:
well... I wasn't able to reproduce my GMP issues...



Le 6 mars 2012  11:06, Jacques-Olivier Lachaud a crit :

>> @@ -70,7 +70,7 @@ inline
>> DGtal::PointVector<dim, TComponent>::PointVector()
>> {
>>   for ( Dimension i = 0; i < dim; ++i )
>> -    myArray[ i ] = 0;
>> +    myArray[ i ] = NumberTraits<TComponent>::zero();
> 
> myArray[ i ] = NumberTraits<TComponent>::ZERO; // faster ?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/DGtal-team/DGtal/pull/293/files#r522346

----------------
David Coeurjolly - Directeur de recherche CNRS
CNRS, LIRIS-UMR 5205
Universit de Lyon
Batiment Nautibus
43 boulevard du 11 novembre 1918, 69622 Villeurbanne cedex, France
Tel : (+33) [0]4.72.44.82.40  Fax : (+33) [0]4.72.43.15.36
http://liris.cnrs.fr/david.coeurjolly
Probably want to make sure this is sanitized
What errors are you trying to swallow here?  It looks very strange that you aren't checking the return value of endGagging.  Are you sure this is correct?
You could make the change for an enum here, this way we could easily keep them in order
commented code was removed
Should avoid the call if newPages < oldPages. 

Should possibly handle it  separately.
if ```(numRows-end)``` is bigger than ```n```, you may have overlapping ranges.

I think it's safer to do take the ```min(n, (numRows-end))```.
Change it to:

```python
    'git': {
        'github.com': ('https://github.com/%(repo)s/blob/%(revision)s/'
                       '%(file)s#L%(line)s')
    }
```
to pass our uber strict pep8 checkers.
Can you explain what you did differently here?  It seems that the function name changed and you used the short handed for-loop format.
Не обязательно приватным методам больше отступов делать)
By the way, we also can decide to make another choice than the redis-py for something, the important being to keep limpyd as ***opinionated***, imho.
OpenVZ defined the name "beancounters" for its resource usage and limits: http://wiki.openvz.org/UBC
So this would probably be the name that people would be looking for when they search for a monitoring solution for it.
"ubc" might be another choice.
Also if you did validation as with `contentScriptFile` https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/content/loader.js#L31-44
that would have ensured that read takes only local uris.
The problem with sync XHR was that it spins an event loop and loads the data asynchronously under the hood. This allows other events to fire and JS to run before the call to xhr.send() returns. Sometimes that is ok but it wasn't in early startup. It's also something that is probably pretty unexpected so I'd lean towards avoiding using sync XHRs in general. It's also possible that sync-XHR is going away for us in the future anyway: https://bugzilla.mozilla.org/show_bug.cgi?id=721336
Don't you get the artist attribute in the <similarartists> element with this line?
  `<similarartists artist="kid606" streamable="1">`

What I obtained on my code (see pull request #26)  for the example on  spec/fixtures/artist_get_similar.xml was `["kid606", {"name" => "Venetian Snares " ... }` so I had to ignore the string "kid606" by selecting only those elements which were`a Hash `response.xml['similarartists']['artist'].select{|o|o.is_a? Hash}`
These 2 lines are missing a "p" in "prefix".
Need the license.
no space after the &
Thoughts on adding a cookbook resource attr and pulling this into a separate cookbook? (See #129)
I added this as a skiptest for now with a comment of what @imsplitbit said in the TODO
I'll just remove all defers for now and update them tomorrow after the
tests run again.

On Wed, Feb 29, 2012 at 02:04, Simon Kornblith <
reply@reply.github.com
> wrote:

> > @@ -125,6 +126,7 @@ var testCases = [
> >       {
> >               "type": "web",
> >               "url": "
> http://www.washingtonmonthly.com/magazine/mayjune_2011/features/the_information_sage029137.php?page=1
> ",
> > +             "defer": true,
>
> So after thinking about this, my feeling is that for tests that passed
> today, we should leave defer out and add it later if necessary. It's much
> easier to see that defer is necessary and add it than it is to see that
> it's unnecessary and take it out.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zotero/translators/pull/137/files#r500338
>
Not sure if it's possible, but it would be nice if we could link to the "Android Heavyweight and Lightweight Windows" section.
I tried this previously (and just verified again) and the required module cannot be seen inside other required modules
Activity Indicator is a normal view now but it's a little special because by default it's hidden. So we need to handle a special case that we call activityIndicator.show() before the window is completely opened (note: window.open() is async). For example, in app.js, we have something like:
var win = xxx;
var activityIndicator = xxx;
win.add(activityIndicator);
win.open();
activityIndicator.show();
I believe Vishal removed this from the docs on another PR.
This _technically_ could have been done before the gesture detector in the first check for `MotionEvent.ACTION_UP` because we don't currently support multi touch gestures with Android. Soon as we introduce a multitouch gesture handler, like scalegesturedetector for `pinch`, though, it could throw off the `pointersDown` state unless this multi tap events are done after both the basic gesture detector and a future scale gesture detector.
I didn't know that. Thanks. Will correct in next update.
Double addition. desiredWidth already has `offsetH` added.
Also, why do you put braces on these `if` statements ?
Explain what parent_key and field_type are, and what they are used for.
Undefined vars at top.
refactor to use before_filter
Mercurial should also be added here.
You're not checking for `empty` and `popFront`. Shouldn't you use `isInputRange` here?
All these || exit's are ok, but an alternative is to just do #!/bin/bash -e at the top of the file.  You'll want to comment that, though, if you do it!
haha, true. just made it hard to see if other things are over 80 col because how github stretches the viewport . a flaw in github pull request review :)
or expect(!ifComp.shouldShow(null));
Do you mean just line 29 can be reduced or the whole snippet?
If just line 29 then this is a nice idea.
Well it is an extension, but I don't mind removing it.
I included this because compass doesn't have it yet. It's on the repo, but hasn't been pushed to an official version yet:

https://github.com/chriseppstein/compass/blob/master/frameworks/compass/stylesheets/compass/css3/_user-interface.scss
Maybe we make this a bunch of links that link to the filtering?
What's with this whole section of commented code?
I only use it for stuff that's used in a toolchain. Mostly.
"Default Max Timout is 3s" -> 10s
Personally, i also don't like it KingCrunh. However, this is a standard in many languages, including C, C++, Java, C# and others. I ended up giving up my personal preference and adopting the standard. Most languages use a style based on K&R.
This and below can just be of the format `$(window).bind('resize.contentauthoring.sakai', updateHeight);`
So per field it checks if the value is an array (date, pre-rendered in foreach loop) or a string (normal facets) and assigns proper variables.

This is the part I like the least, because it's not super clean. Any suggestions welcome.
IMHO its almost impossible for us to control all possible scenarios where the stored Message is corrupted outside of SI, therefore I wouldn't do anything at this point. At least not until we start encountering such scenarios so we can get an idea of the impact.
tricky, but I guess this is not strictly "deprecated".... we'll be marking it as *final* in 3.0 correct?
This doesn't look right - exists was set in the old version. Don't think this if should be here at all anymore.
This needs #13
wfrwre
@nilnilnil # is fine, it makes the regex more readable when it is matching literal slashes (instead of escaping them) :)
@apex13 Maybe we can use the confirm method on RoR - see the second example in http://guides.rubyonrails.org/getting_started.html#listing-all-posts

`<td><%= link_to 'Destroy', post, :confirm => 'Are you sure?',
                                     :method => :delete %></td>`
Тут дело не в стандартном механизме. Два пакета, подключающие jQuery подключат его только один раз.
@willyaranda When recovering messages from the registerUA response, we need to check the payload. This is different with the notification message. I suggest that the array list only contains payloads
Why not? :D

No actually, I made this change for a good reason, but I don't remember why :p
So if we can't match three elements at a time, we match two at a time.  What if there are 6 elements but it's 3 sets of two?  I believe \s will match newlines, too.
@tarjei the post is asynchronous. And currently, if you use this event to disable the form, you break the submission
no global variable. If you want to let events modify some stuff, you can create the event object explicitly and passing it to trigger instead of passing an event name
whoops \
Should id be transient too since we can just set that up server side? Or should we explicitly pass it along regardless?
Yep, the tests should complain.. bad test coverage in this point I suppose :)
If you grab the latest node sdk bits (from dev branch) you'll see these three are already exposed through the azure module. Instead of reaching into node_modules, do this instead:

```javascript
var azure = require('azure');
var ServiceClient = azure.ServiceClient;
var WebResource = azure.WebResource;
var Constants = azure.Constants;
```
Maybe "%s is listed more than once in catch list" or something.  I don't like the normal wording much either.  I hate coming up with error messages.
primarily default defined by DeployableContainer, but can also be overwritten by arquillian.xml or the use of @OverProtocol on @Deployment level
I think this would make more sense in the `Attempting to get autoconfiguration...` line.
I think we should remove the ucfirst then
Could we use a Maven Artifact here instead, to avoid having to re-download for each mvn clean ? e.g. http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.glassfish.main.distributions%22
+1

Didn't notice that was what he was doing based on the code.  (complex for loop is complex ;) )
Hmm gotcha. Right, the webviews is not an array. Just leave it @jkeshavarzi.
There are several places with emtpy spaces at the end of statement, you may want to remove those to remove statements from diff.
Added separate function getUniqueEventId()
This is how we do onRequest as well. Maybe its better to conform for now, and open an issue if we prefer the other architecture.
Please take a look at what we did in the packager [https://github.com/blackberry-webworks/BB10-Webworks-Packager/blob/next/configure]
As mentioned, when we run configure we run it with source configure, but this causes an error on the CI server. So this does not appear to be an option for you currently.

We can either write up some maven scripts to execute this code (like we do in the packager for SCM and CI builds) or we can find the correct way to call configure, one that works on all platforms and doesnt break the CI server. If you decide on the latter as a solution, please make sure to test the configure script locally on windows and mac and on the CI server.

I would almost prefer to have some maven scripts for this. The less manual steps during SCM build prep the better.
Tracked in issue blackberry / BB10-WebWorks-Framework#132
The basic dao should throw the duplicate exception, not wrap it in an illegal arg.