labofsahil/github-event-dataset-2012 huggingface dataset:
Now that all of the images have been processed, call `updateBreakpoint()` once so that it can resolve the `$.Deferred` mentioned above so all of the registered images will have a chance to set their `src` the first time.
We only want to stop the event if we actually scrolled. If we didn't scroll, that means that we hit the top or the bottom of the scroll area, and we need to let the scroll event bubble up so that the main browser gets to handle the scrolling (e.g. if there's a scrollbar on the main browser as well).
It seems like we'd be going back towards more confusion by allowing pages to be looked up by *either* their original or destination path. Letting these get mixed up will make things hard to follow.
Just committed a fix for this.
filePath can definitely be used.

I was wondering the same about the crash but kept it as is.

I can add .isNull() checks.

There aren't any other setters.
There's a test that tries to create 5 tenants (all invalid ones). Not checking for err and doing the timeout regardless makes the tests take another 5 seconds.
``s/j/J``
i was thinking the same thing but wasnt so sure if it really has no value outside oft the fullstack CMF
If pulled in after #155, dvb_charset argument can be used to handle these cases. No pl_workaround argument needed.
"b" should, according to documentation, have no effect on POSIX systems. So not sure this should be necessary.
Наличие спецификатора static здесь не оправданно (вы не пользуетесь тем, что mutateIndexArray и dnaIndexArray сохраняют свои значения между вызовами метода mutate).
Why the changes to .gitignore?
From a user's point of view, there is strictly no reason to be confronted to these mysterious XML files. So I deliberately chose to hide them from the downloads list.
maybe throw an error catching statement here

```js
if (wait && typeof wait !== "number") throw new Error("wait parameter must be a number");
```
spaces before and after the function brackets... e.g. function () {
I tested this right now and *defacto* **any module** you try to install fail if params has not default to ''
感想ありがとうございます。ぜひ飛び込んでください。
A few super minor nitpicks 

First the third argument to the assertions is a description which is helpful when addressing a broken test.

```javascript
equal( "foo", "foo", "the foos are equal" )
```

becomes

```javascript
equal( "foo", "foo", "the foos are equal" )
```

Second, I would check the exact value of the id in the second case.

```javascript
var slider = $("#empty-string-val-slider"),
       label = $("[for=empty-string-val-slider]");
ok(label.attr("id"), "the-actual-value", "the label id matches the slider id" );
```

Last I *think* the `slider` vars are actually the labels right?
`finite-double?` 跟`finite-float?`实现完全一样？ 如果确实一样的话是不是合并成一个函数直接叫`finite?`好一点？
I like this this suggestion and if you are ok with my previous comment, will return the value of the argument after the for loop (no names matched)
I would just write:

`assert_true(epochs_ts.ch_names == epochs.ch_names)`
right, sorry for that!
is there a reference we could cite?
coherence (coherency is different)
The default matcher tests equals() AFAIK. So basically you can do: this:
Assert.assertThat(myVar, Is.is("expected value"))
sure, I'll try and do that today
Does this assert fail?
``dispatch``, not ``throw``
I don't recommend this because it requries not only the components, but the complete Symfony2 core Framework including Twig, the Doctrine-, Monolog-, Propel-, Swiftmailer- and Twig Bridges and the Framework-, Security-, Twig- and WebProfiler Bundles.
Sorry, it was a typo. Fixed!
The above 2 lines should be removed and you should add a file comment:

    // src/Acme/TestBundle/Tests/Form/Type/TestedTypeTest.php
did tests not catch it?
yeah, this is not crucial.
you should probably name this sports, not sport since it references an array

If you do want to just find one of them, you can either:

```
Sport.find_by_name(input)
Sport.where(name: input).first
```
The `==` by default checks memory address. You need to implement this method so that it checks certain attributes instead.
Can we look at this again?
CS : we use ``$this->`` instead of ``self::`` in non-static method in PHPUnit files
It probably doesn't make sense to keep the validity test, since the validation is gone.
The last parameter should be target. 

So we need to change the comments but no code.

```js
* // Example
 * var item = cc.MenuItemImage.create('normal.png', 'selected.png', 'run', gameScene)
 * //create a dom menu item with normal and selected state, when clicked it will run the run function from gameScene object
 *
 * var item = cc.MenuItemImage.create('normal.png', 'selected.png', 'disabled.png', gameScene.run, gameScene)
 * //same as above, but pass in the actual function and disabled image
```
I agree with Glyn here, please create a new test instead of changing this one.
Why are we doing the exact same thing. the vol_enabled above is the same as must_have_vol.
This can use `@(relativeFilePath)`.
Ideally, we don't have spaces between the kwarg name and it value. (there are a couple of instances of that in this file).
Could you make these two `if`s blocks, please?
That does not work. I ran python setup.py develop and there's no executable/script on the command line called gaiatest.
The conversion to OsmosisRuntimeExceptions should happen in the task itself, not in the helper class (as someone might use that helper class in an unrelated context).
OK

On Wed, Sep 5, 2012 at 6:59 PM, Richard Rodger <notifications@github.com>wrote:

> In lib/parambulator.js:
>
> > @@ -61,12 +61,32 @@ var quantrule = function( foundok, rulename ) {
> >      }
> >      else return cb();
> >    }
> > -}
> > +};
> > +
> > +var lenrule = function( islenok ) {
> > +  return function(ctxt,cb) {
> > +    var conditionallength = ctxt.rule.spec
> > +    var value = ctxt.point
> > +
> > +    if( !noval(value) ) {
>
> noval is not correct here - the API semantics require the test to be
> _.isUndefined at the top level
> please follow the conventions of the other rules - we may factor out this
> top level test itself (will require thought however)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rjrodger/parambulator/pull/9/files#r1534712>.
>
>



-- 

*malex*
I've opportunistically changed SearchConstants to SolrSearchConstants where I can. It looks like all the Sparse-related search classes can go away in later refactoring and so things like SearchConstants may go away entirely.
Yeah `getFromAsString()` is returning a string representation of the FROM clause.  The alternative would be that we drop those methods in favour of `Database::sqlFromClauseToString($from)`.  The advantage of that approach is that the array to string conversion could be made to be database-specific.  You can still make it database-specific by overriding `Database::sqlQueryToString()`, but there's more copy & paste involved in that approach.
Meaning we keep using the DOMDocument class as opposed to the XPath one, yes? at least for the first iteration....
We weren't freeing the in-memory page on error, that is, failed/partially created in-memory pages would leak memory.   This is a dangerous change -- I wanted you to be aware I made it.
Thank you. :)

In fact, I have been tempted to "fix" every single place where Adam has done just so in all the code. It would be worth it just for the peace of mind. ;)
() can be ommitted
Are you sure ``456`` has the correct type as "integer" is not a sub-type of "string"?
Are you sure that the property "schemes" exists?
That's exactly what Ilya said though. :P
To avoid the costly `count`:

~~~clojure
(empty? (filter (complement pred) a-seq))
~~~
Missed this one, too, fixing now.
Amy, I just noticed we are turning warnings and notices in a few places.  Can you revert those cases and I'll work out how to fix them.  Thanks.
``` js

this.method = method.toUpperCase();
this.url = url;

// ...

xhr.open(this.method, url, // ...
```
I tend to prefix references to DOM nodes with $, but I shouldn't do that in xtag. I'm gonna remove it.
My real problem here is that `this doesn't give me access to querySelector(), which is a bit strange. I should investigate that first.
I think probably the default should be random, at least that seems to be what most clients do this days. The old standard port seems to be blocked in many places now.
The above code was really helpful on getting started! The implementation I posted needed to alternate between normal document wrapping and list wrapping before joining.
Nitpicking on wording (sorry). Instead of: 
> transforms it into a method call against [StringContext]

Why not say:
> transforms it into a method call on an instance of [StringContext]

Otherwise it sounds (to me) like `StringContext` is an object, but maybe that's just me ;)
this class is change all((but i did't yours) this is a copy of from brendy
Why only for puppet v3? would it be safe to assume we can set the default regardless?
Now is OK.
I never got to iterators in python. I can see now what I was missing all this time :)
Pycharm became very unhappy when I removed it, so I left it :)
Add a comment same as above.
i try this:

            if (!$('#email_info')) {
                $('#id_email').after(message_info);
            }

but doesnt work. Isn't ! for not equal?
ohhh, I totally forgot
Yes, just add TODO.
Sorry about that. Will do.
remove these extra spaces
Hmm... thinking of it, it would just make my Di config more complex if you remove the type hints also there :P I'm merging as it is now.
but we can be here with "not self.pk", so that's unnecessary double-write
It does not need to use test harness any longer. test5164 was rewritten to use mocked static Mailer.descriptor method.
Back indent this to the left margin
Yes, we can specify all dependency version info in parent pom.xml within dependencyManagement section. Also, if each sub module pom.xml contains parent section, we can leave off the sub module's groupId and version elements.
it looks like you're not super concerned with the formatting for this spec, so you probably want to use a regex instead of a very specific string
Please like this:
$this
    ->getMockBuilder(...)
   ->doSomething();
No, you can use the regular expression, but you will need to use your own method to open the appropriate page and extract the HTML source for matching (you can use the BIDPOM test as an example). Hopefully we can find a better way to do this in the future. It is already being discussed.
Pass in the relationship-auto-index (which should probably be stored in a varaible in RestIndexManager
what about the indentation of the equal sign?
Remove the word "virtual"
Looks like it would make sense to make `local_url_types` an outer scope variable (or constant, actually).
`return value == null ? default_value : value;` would suffice, but this is fine.
Interesting. Maybe open a TBI issue so it won't get forgotten.
Looks like this snuck in from the KSS branch
Ah, ok good. I knew I introduced these failures but wasn't sure where. Will fix.
Hmm yes, I guess I was just trying to be explicit.
From what I understood, 'static' points to the static directory on the filesystem. The filesystem files that are in the static directory do not change and could potentially be served by the web server separate from the application.

But I will note that this is silly, because it's not clear where this file lives. What happens when I put a 'conf.js' file in the static directory?

In the end it doesn't matter. If this is what flask needs, so be it.
This is a silly python newbie question...
I've gotten used to the ```from . import _galsim``` syntax, but this doesn't have a space between the . and the import.  Does that do anything differently?  If so, what?
I thought we were getting rid of the @brief's.  Can we just put this on the next line by itself to be an implicit "brief"?
Done.  (I took both suggestions, using halo_pos for the position of the lens in NFWHalo.)
Thanks for humoring me.  :)
| DOT
plurial -> plural
Please initialize in constructor (like , m_signal a few lines above)
Not really a fan of 'End of file' and 'Location', but that just my personal preference.
Hm... it seems more logical that day wouldn't even be defined, rather than being `nil`.
This forward declaration doesn't seem to be necessary - or am I missing something?
Just saw that now.. Fixing in few seconds...
Why is rename a different dbcmd, can it be another action type in the Info cmd?
It is generic, if you have dependency.json format as in webinos it can
scale well.

On Wed, Oct 10, 2012 at 3:44 PM, Dieter Blomme <notifications@github.com>wrote:

> In node_modules/webinos/README.md:
>
> > @@ -1 +1 @@
> > -webinos module
>
> I would prepend the name with webinos- because it is as far as i can see
> only usable within webinos (or am i wrong :) )
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/webinos/Webinos-Platform/pull/197/files#r1807335>.
>
>
Right. That changes the default behavior of just ignoring the symbol. There are users who currently parse strings like "$1.25 ARS" and expect the resulting currency to be "ARS", but your change will result in "USD". We need to have them "opt-in" to your new assumption by explicitly passing an indicator.
I think that if a unknown value for encoding is given, I would rather have it fail, than to give a default encoding, which might not be at all compatible with what was requested.
Copy the be syndicate line to the setup client proc.
But the DP vent was BUILT for cycling airlocks. If you tell it to suck, it sucks and pushes to waste, if you tell it to pump, it pumps from Distro.

Besides, having built a vent with no pump whatsoever, how is the airlock meant to pump to empty itself?
Not sure I follow what you mean. Is this something that should be done first? If so, could you explain some more what you would like done?
Well, I could have the php ajax handler send back a lot more post information on success, and then create and inject the markup that you use to represent posts normally. There might be some problems with drag and drop depending on how you're binding events, but I'll have a look.
I kind of don't like adding pending specs because it more or less means the spec never gets completed.  How far is this from completion?  What happens if we just change line 29 to user.reset_password("sometoken", "secret", "secret") ?
В каком смысле сработает? Какой смысл руками проверять что это 100% правильный паттерн?
Здесь закрывается System.in. Это плохо.
It's enough to say that an idiom is "potentially unreliable", and that the cost of not using it is extremely small - here the cost is just the appearance of an extra "var" token. You might like to do a survey on all the debuggers that might be in common use - not just Firebug, but also Chrome dev tools, IE8/9, node inspector and some others you might think of - it will be expensive for you to mount this survey, and even if you universally discover that each one of them is not confused by the multi-line idiom, it still wouldn't alter the basic economics that course of action A involves little cost and provably zero risk, and course of action B involves small benefit and a potential risk that may be large, and would always be expensive to measure (and keep measuring).
I hope you will finish "arguing the toss" about this stylistic issue, anvk :)
I thought about that, but it seems it is hard to construct a mock object this way because WebResource.Builder is finalized, as a result, we cannot extend a mock class from the Builder...
Good question! How do I delete pages??
Also blows up if the client doesn't exist.
for the first part of the sentence:
the formular is ``exp(score)/\sum exp(score)`` originally, right? There is one score per class. In the binary case, it is just assumed that one of the responses is 0, therefore you get the ``exp(0)=1``

To calculate ``exp(score)/\sum exp(score)``, you can divide numerator and denumerator by ``exp(score_max)``, i.e. subtract the max over the scores from each row.
@glouppe done
@mblondel I based this on http://scikit-learn.org/dev/modules/generated/sklearn.decomposition.MiniBatchDictionaryLearning.html
but this then creates a hard dependency on the CoreBundle
line 25 will throw exception and this code won't ever execute.
This is for testing. Prio one for testing is that we have a reliable ZK cluster. Sometimes ZK just doesn't start... and you know that. This was something that proved to increase stability of starting the ZK cluster.
It is a sub-activity under map activity and  has characteristics of an activity as well as a helper. I will change it if you think it makes any difference.
why the regress here? IMO the previous version with `[::-1]` is simpler (and about 10x faster)
pourquoi un override est-il nécessaire?  ceci brise le pattern appliqué à travers les autres collections observable ou l'implémentation de l'interface InternalObservableCollection dicte comment faire la copie.
been ... been
Having to specify all these params here that are irrelevant is an indication that this class was not intended to do that.

I still think it doesn't belong in Blackberry, but since you're intent on keeping it there, having it static like before is cleaner. The Blackberry instance serves not purpose.
This is a bit dangerous because it allows an user to set values of all parameters which are accessible for mass-assignment by altering parameters. Something like this would be safer:

```
@signature = Signature.new
@signature.citizen_id = params[:message][:citizen_id]
@signature.idea_id = params[:message][:idea_id]
# etc.
@signature.save!
```
Why a try catch here? Seems out of place given the style of the rest of the code.
What happens if a workunit is executed by multiple eclagent instances (e.g. if it is scheduled?)  I assume we don't cope with that at the moment.
True, fixed. Also the typos.
Why is a table with no fields NOT a  constant ?
No, there were no exiting callers to either getNetText or getMaskText
you don't need this. Composer is already installed on travis
I think that should be `/static/`.
The reason for creating a "query" route was so I could pass arbitrary get value pairs without needing to define a route for every combination. 

I would argue against  this level of checking in the router by saying it query params should be tested and validated as required in the business logic
It bothers me that the name of this bundle is not similar to the one above (rudder_common_report). Could we not rename it to rudder_common_reports_generic?
![not my fault](https://f.cloud.github.com/assets/1153034/19480/ca2dad5c-491c-11e2-8829-3ef3b01cb907.gif)
that's Honest Driven Development
Alignment is off here ;)
@yuhunglin just fyi, we're not really including Underscore.js - we're using http://lodash.com/ which is a drop-in replacement for Underscore.js
Does this need to be /_/typeahead?
Why is this being assigned to an instance variable, and why is this line even here? The return value of this method is not used anywhere.
So, if there is only one port per instance this "ports" loop isn't needed right? If the "ports" loop isn't needed avoid it would do the core more readable :)
checks now for the attr.
Didn't we move this to templates/search_ajax.html?
Is DeveloperError the right thing to throw from this method, considering that an ISO 8601 string often comes from user input and attempting to parse an invalid one does not usually reflect an error on the part of the developer?
Any other ideas for testing this other than looking into private data?  I'm OK with doing this sparingly, but doing it less is more.
Check if it can be reused from base.
2nd sentence discusses a single event, so should change first sentence to:

"_An alert-based interruption_ ... results in _a_ \`pause\` event being fired."
A space after the indicator would be great :)
FYI you should merge the current master branch in. I just modified this description in TIMOB-8275 which was merged in yesterday afternoon. There may be conflicts.
oh sorry, i thought 7 said for too.  you're right! :)
Sure, no prob dude!
those tests were accidentally disabled, and they needed to be re-enabled. Would you prefer a second pull request for it?
Yeah because it's still RegExp based, the order of the named parameters do matter, but they're still independent of themselves. Yes if they were fully independent, order wouldn't matter either. That though would require a much more through matching strategy.
не очень удачный способ сообщать об ошибке
Again, replace all instances of `D_PARAM` with `D`.
Please remove the comma. There should only be a comma before but if the part that follows is an independent clause (i.e. could be a sentence on its own). You keep using commas with dependent clauses, which is incorrect.
If I look at the directory in Eclipse, it seems the the contents of the sharedir are missing (there were warnings about some commands being skipped due to the two errors). If you log in, you can't run composer, because midgard throws errors since it treis to run on a half-complete config. If I try to switch midgard_engine to "off", it triggers the bug @piotras fixed recently, i.e. php throws a fatal error whenever it starts up, unless I remove the extension, in which case the installer will throw an exception. It would be good if we could switch puppet to install php-midgard from git until the next release is cut.
Why? Might break future versions?
Also, you should use backticks to enclose references to classes e.g. `BeanProvider`
見出しをレベルを3つ以内に抑える文書構造にしておくとよいです。 (参考: 巷の書籍)
I don't think we want to be merging in the svn directory info.
Toss out this `with` comment.
I can't tell exactly but I think my "clarifying" example has made it sound like this class implements a delay itself.

The `ForceDrop` middleware drops connection either:

1. immediately in the trip down the middleware chain (if `:force_drop` declared) -- the request does not get to anything past it
2. Immediately in the trip up the middleware chain (if `:force_drop_after) -- in this case, the app and all middlewares below this one have finished.

This middleware doesn't itself implement a delay (in the example test rig, the `ForceDelay` middleware does). I wanted an example of where `:force_drop_after` made sense -- here it's simulating an endpoint that would sit for N seconds doing nothing and then hang up cold. An example where it's injected into an app might be to simulate a successful write to the DB but a failure in follow-on handling / client acknowledgement.

Does that make more sense? Or have I answered a totally different question than yours?
yep, this is just for user to understand where they need to add options

u right all this options already defined by knpMenuBundle
Perhaps "Then I should see that 5 patients are registered"?
I'm not entirely sure what the English punctuation rule is, if I were to apply Polish punctuation rules it would be along the lines of :
"Next, take a look at, and examine, the 'firewalls' " or "Next, take a look at - and examine - the 'firewalls' "

If you are confident the comma should be there I will not argue otherwise.
Don't think that print is meant to go in.
This second `getFile()` can be replaced by the `file` variable you specified above
Код населенного пункта
Ya estás lanzando una ParserException adentro del Factory que está adentro del Parser
там багато чого можна заюзати тільки якщо воно стоїть https://github.com/fre5h/CommonContexts/blob/8db91b0cbe518ddfec3f4695e1f5b25ec4ed0693/composer.json#L40
Probably should check for `userid` before using it here
Reference for the choice of 65001?
null will be returned when the query execution doesn't give any result. Since null is returned, no message will be sent to the channel of the <i>inbound-channel-adapter</i>
Since we are not going to backport this issue, shouldn't we only make changes to the 2.2 XSD?
I can do it. Everything else looked fine to me.
We should use double quotes here http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
This will cause the parameter in the `foreman_proxy` class to be unset since it accepts `$foreman_proxy::params::package_source` as the default parameter. Is that okay?
Процесс работы, описанный выше, можно
This file should list the minimum versions that are known to work, so this line should read: gem "code ray", "1.0.7.rc1" so that bundler doesn't pick a newer version if one is released.
This method is an actual change
I wonder if we are ever going to run into performance problems here.  For example, if someone doesn't want any metadata - or just a subset of it - they still pay for querying and processing all of it.  Have you experimented or timed this?  Is it a worthwhile optimization for now or later?  Given that this is a converter, I'm less concerned, but there will still be many users that want to convert from Shapefiles to CZML on the fly.
Sorry to be super syntax nazi.. can you remove space after URI? Thanks dude.
This is better error raising since both ValueError and TypeError possible to occur.
Split this in two methods? one for incontainer and one for client ?
irc://freenode.net/mantisbt-help
Yay no more warnings!
Gotcha, so Less expects that.
See above comments on the similar code block.
I agreed.  Let's use CamelCase for IDs and all-lower-case-with-dashes for
classes.

-Tito

On Tue, Apr 3, 2012 at 10:28 PM, Jeffrey Mayfield <
reply@reply.github.com
> wrote:

> > @@ -221,9 +221,10 @@ td { vertical-align: top; }
> >  /* Layout Build
> >     ------------*/
> >
> > -#Container {
> > +#container {
>
> This is unnecessary due to #PageContainer replacing #Container in the
> current build due to integrating script-based ad takeover support. I think
> it's a good idea to sick with CamelCase for element ID's and dashes for
> classes. What are your thoughts on that?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/jmayfield/GrindMedia-Frontend-Boilerplate/pull/2/files#r643323
>
I think, we need to refactor authentication. E.g. other adapters: Twitter has the twitterTemplate, XMPP has the xmpp-connection namespace element...

Maybe we should just directly expose the **AwsCredentials** interface  

* http://docs.amazonwebservices.com/AWSJavaSDK/latest/javadoc/com/amazonaws/auth/AWSCredentials.html - Therefore users pass-in AwsCredentials via a "credentials-ref" attribute

Otherwise users may have to pass the same information multiple times across adapter
what does this path evaluate to?
@pagey the hash won't expose to the developer, although they still has a way to get it.
The original hash function is using same algorithm as String.hashCode() in java, just changed a multiplier number: 31 is in java.
Now use qHash instead of.  Good to know qHash  :)
If you find yourself adding docs to explain a shift in the test, it's a sure sign that you need a new `test_` method.  A solid rule-of-thumb is to test use one `assert*` method per test (see [Verify One Condition per Test]).  Of course, that's meant to be broken.  Some times you need more than one assertion to verify the condition.  Try to keep it limited, though.  Too many assertions is generally a sign of either 1) testing too much in one test method, or 2) code that is too complex.

http://xunitpatterns.com/Principles%20of%20Test%20Automation.html#Verify One Condition per Test
Just a personal preference...I think it's clear to read "loopDelay > 0" instead of "0 < loopDelay".