labofsahil/github-event-dataset-2012 huggingface dataset:
Sure, please do that. I only noticed this in all lists. I only know that the flag for loading offline logs is otherwise only set at 1 place in the code. That seems like "overoptimization" to me. But @blafoo might be able to comment on that, as it is a consequence of the refactored loading from cache and database.
I'm a bit concerned in the direction this commits has taken, I've left inline comments for the above code, please review them and get back to me to discuss the general plan further. thx :)
This seems like a logical refactoring to me.  However, we might want to go further and allow the provisioning of actions that don't reload the entire GridField.  See my comments on 1b42b2afa784bce3c3ef79c46972559ce754fd34.
This was a demo for Andy of using git!
This is a demo of a comment!
Don't use #content_partners ID see my other note.
I think the jars were corrupted during upload. I did it over the 3G.
Lesson learned, don't publish large gems with unstable connection.
You just open up your repo and edit it. Once you're done, hit "Commit changes" to save it. Then go to the "Pull request" tab to update your pull request.
https://github.com/ProjectSkyfire/SkyFireEMU/tree/calendar_dont_use

solinoron's  patch didn't have a huge chuck of this stuff... 
this was worked on by us at SkyFireEMU and Trillium(old).

+1 for you guys getting it working, because i had gotten stuck. 
but because some does not like our project doesn't mean 
acknowledgements shouldn't be made to those that have since worked on it.

i just added that above at the init patch for it, instead of every place needed.
no love lost, just nothing gained. ;)
Still want to find a better way to kill people, but haven't hit on anything yet. Just feels awkward to make people paw through their discards every turn.
This change looks good to me.  Still trying to nail down another possible desync issue.  Not sure if it is a problem with my code or not.
I thought we agreed that magic sprinkles are unnecessary
src\server\game\Entities\Object\Object.h:532 in GridObject<class Creature>::RemoveFromGrid ASSERTION FAILED:
  IsInGrid(
https://github.com/TrinityCore/TrinityCore/issues/4850#issuecomment-3596098
It would have been ok just to leave it as odt if you had wanted! :-)
We don't reference these properties anywhere in the code, so I just killed them.
Sure - I was partly trying to be descriptive, because "Atom dataset producer" sounds a bit generic.
Thank god, that sound raped my ears several time in disposals when cargo decided to flush everything on the belt.
uint32 affspell = 77606;

Should be

uint32 affspell = 0;

Don't do Drugs...
It seems like `canView` is used before it was actually defined. (`var`)

There are multiple ways of fixing the `function within a loop` error:
http://stackoverflow.com/questions/3037598/how-to-get-around-the-jslint-error-dont-make-functions-within-a-loop
http://www.jshint.com/options/ (look for loopfunc)
Благодаря этой строчке работали медиа файлы в проекте по склейке адресов. Не надо так просто выкидывать такие вещи.
Hey Jasper,

Do non-broken clients cause this exception to be generated? I think we do distinguish "connection reset by peer" from EOF in the normal socket situation, I would expect that this would be analogous for SSL. Just trying to understand the motivation here.
This whole loop isn't necessary.  Just do: paircopy(&fake->packet->vps, request->packet->vps)

Some attributes are allowed to be in the list twice!
I have a good feeling about this :)

I edited dhd_linux.c to use the name "bcm4319_wlan" for my device (since my kernel expects the name bcm4329_wlan), and I was greeted with this message:

<4>[274, WifiService] [  158.667888] dhd_module_init: platform_driver_register timeout
if (...) {
} else {

}

სტილი დაიცავით. ზოგგან ისე წერია if/else ზოგგან ასე. ფიგურული ფრჩხილები გამოიყენეთ უფრო მეტი სიცხადისთვის.
I don't quite remember the meta files, but shouldn't it also contain the list of images, etc?
BC when using command "./bin/vendors install --reinstall"
I'm actually preferring the current proposal than to constantly check at runtime. Just wanted to make sure we're agreeing the limitation is acceptable.

My reason is not so much for the additional decorator, but for the need to check for trace enabled/disabled each time a _tracef_ is invoked.
Sheesh, Phil. You're only [19 days late](https://github.com/resolve/refinerycms-inquiries/commit/aff7a5e1c6637920ec173360e0a99d7383eaa217).
`Object.keys` [1] is afaik an ECMAScript 5 function and not supported by all the browsers that we currently support (e.g. Firefox 3.6+).
When I merge this in, I'll add the code from [2] to core.js + reformat it a bit (using brackets)

[1] https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Object/keys
[2] https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Object/keys#section_6
so these dont work? as long as express-resource is doing the app.get call for them before the others the route match precedence should be fine
I see. I've taken interest in this because I wanted to do this myself, but every time I was about to do this I tried to fix dynamic libraries at the same time. I can't see any reason why this wouldn't work.
As with the usual CMD SRC [...] DST pattern (e.g. rsync, cp, scp, etc) it links all the leading arguments into the final one.  In this case, it is making symlinks called 'assets' and 'last_assets' in the 'public' dir.   I suspect if we have a problem it is a mismatch between -serverside and what we did in nginx.conf to add support for this, rather than with this command.
Thanks for adding that, can you make our frameworks/base and settings read+write.  When I moved them from my github it revoked the permissions.
Oops!  fixes #29, not #30.
While, this is useful to get this feature mentioned here, it is way too long. I propose to move this text to the `What's new` section and keep a description here that is at most two sentences.

> Support for method level validation (parameters and return values) enable "programming by contact" ... blah blah
holds all of the switches for every array
need confirm on this... not 100% sure :P
summoning @Chameleo
yes, i know this problem, but i don't know yet how i can make it better. i will thinking about it.
mit meinen zusätzlichen Änderungen dürften es noch ein paar mehr sein ;)

es sind ja jetzt so schon 348 MB, soviel ich weiß ^^
"dmd" would mean the whole distro. I changed things to use the csv summaries. Still not perfect because queries are run multiple times.
I think this is more confusing than the shift version but appears to do the same thing.  Is there some difference between the two I might be missing?
The beanstalk API is not particularly consistent in this regard, but I would say that name is more canonical as all of the API calls accept Name, but only a few accept both ID and name.  Also, most API calls that return environment info, return name, but not ID.

I will update to take name only and change the identity for the class as well.
I'll open a ticket for this change.
I only see it useful for error reporting. It’s a performance penalty, so wouldn’t count all `\n`’s when it isn’t necessary.
casting is bad.  If something isn't exposed on the interface, we should look at why it isn't
Yes, and it would save quite some lines & effort to put the implementation inside that trait, with just an abstract `def system: ActorSystem` in which the two objects would differ.
See comment above. Not possible due to visibility and concurrent access.
clients.exists(_.fsm == sender)
we usually put such imports at the top-level, unless lexical scope really matters (for implicits) or they are "unusual"
This is for the test conductor sockets that are used only for the test conductor commands.
style, in this case the if is not a guard of the case, and I would write it as

    case Send(msg, senderOption, recipient) =>
      if (!buffering) sendMessage(msg, recipient, senderOption) else stash()
From a change point of view, I think I would include that with the refactor the finally moves to the +*account model for class User stuff.
This should be an array:
```php
/** @var array Installed locales */
'installed_locales' => array(
  'en',
  'ru',
  'in',
  'uk,,
  'md',
  'ro',
  // etc
),
```
Sorry - maybe I didn't follow and Freesurfer's code are for the orientation of the data in the data block (and thence can be fixed to any given output orientation by the affine).   In that case, we have no constraints on that for nifti, other than the nifti constraints that the first 3 axes should be spatial.   The nibabel.orientations.io_orientations code can work out what the closest orientation of the data block is.
Did you run this doctest? It doesn't look like doctest :) corpus = ... statement is incorrect (take a look at standard Python console output to get an idea how multiline statements look like in doctests). It is also better to write 

```
>>> len(tag_set)
1234
```

instead of `print len(tag_set)` (because print is unnecessary here and the syntax changes in Python 3.x)  - and don't forget to include the output values to check.
lib/helpers.py is really for helping with template rendering rather than being general purpose functions.
I'm also keen to not pull extra bits of ckan like plugins in if we can avoid doing this

could the plugins stuff live elsewhere?
Because it is easier to work with Python data structures (dictionary in this case) as it is with a self defined (or better SOLR defined) string data structure.

Search now transforms this pythonic dictionary into this awkward string. Just a refactoring measure.

To fixed filter names: I dunno. It was there in the first place, so I took them. I think the SOLR server need them in order function properly. As far as I know, when they are not given the search will not accept the filters' values.
yeah 1.4 schema is part of 1.8 so should stay as is imho
Should be `subscription_show()` I think (although I'm guilty of deviating from the logic/action/ naming conventions myself as well)
This feels like progress :)
Same as above about idempotency.
Couldn't you use

    @content_length = @env['CONTENT_LENGTH']
    @content_length = @content_length.to_i - @boundary_size unless @content_length.nil?

Using `if` together with assignment is very confusing.
Which timestamp? I think the old one, but I want to be sure first
It's the simplest, but down the line it should be in NRV and I have an idea on how to do it. Lemme know when you have time, we'll chat about it ;)
Смотри, что я думаю, сегодня завтра выйдет yii 1.1.13 и там появился mkdir https://github.com/yiisoft/yii/blob/master/framework/utils/CFileHelper.php может потом переработать с использованием этого метода?
это ты намудрил со строкой. Правильным путем является форматирование строки. Т.е. "%s?scanned_code=%s" % (a, b)
This seems……… odd. Any reason we aren't just calling `performSelector:`? (I know you didn't write this stuff originally ;))
I noticed that after posting the comment. I changed the code in json_test.go to use httptest and removed the copied code. You should do the same.
Wrap/unwrap are is usefull for addons development, so why node_internals.h is the better place for this?
What's the motivation for using a new queue? Underscore prefixed variable names make baby Jesus cry, by the way.
There's another case that would be broken by that approach:

```javascript
ee.on('removeListener', function(name, fn) {
  if (name == 'foo' && fn == foo1) ee.removeListener('foo', foo2);
});
```

I guess I should add a test case for that. :-)
"upsampleProjectScaleCenterTranslate". :)
http://www.python.org/dev/peps/pep-0008/#programming-recommendations
> beware of writing if x when you really mean if x is not None
Numpy's is possessive, not plural, that's why I changed the wording. Maybe "In older versions of numpy..."
а кто ее потом удалит? чего бы просто по значению не вернуть?
а чего тут пробелы стали?
заменить на qMax
3.10 и двоеточие сюда
скобки вокруг тела условного оператора
We can also bring it back in master with the deprecation :)
Can't we just let it raise if required? Perhaps the `puts` message could include it does not work on Ruby 2.0 to help users.
Why hardcode to `Rails.queue`?  If the queue is an ivar, set in the constructor, then subclasses could change the queue depending on their needs (e.g. they need to deliver synchronously or not).
Shows what you know! Interpolated string literals cause 42% fewer TooLittleInterpolationExceptions!
Yes, thanks for the catch!  Added a test as well.
I had some problems to make it working with the Dict class, and I found __new__ easier to implement (I don't remember exactly but I think I saw a class elsewhere in the sympy code doing something similar).
I don't have a very strong opinion on the question, however I would prefer keeping the warnings. If something is to be plotted it is expected to be real in the same way that calling `float` on something is presuming that the something is real. `float` raises an error if this is not the case. I would like it if `plot` does something similar. (anyway, what I like is not a strong technical argument ;)

There is also the minor point of helping with tests
Is it a good idea to allow instantiation of this class? Why not just make `__new__` raise some sort of exception, making it clear that one of the derived classes has to be used? Or in fact make `__new__` have the interface you wanted first (with name and identity options), but *return* a derived class.
On 07.04.2012 09:36, Christopher Smith wrote:
> send 0 for u (3rd parameter) since it is not needed

Done.
Oh. My bad :-) I guess now the fingerprints will have to be unique (using the method from your boolequals branch)
That's a nice idea. Done.
Spaces here for pep8
include definitions for O and K, ok?
Yes, right, forgot that, my bad.
@qiangxue Yes, thanks, it'll be better. Done here: https://github.com/yiisoft/yii/pull/929
Well usually you create your bundle class and create id's for all the presenters that are supposed to be in the bundle, this is a really piece of work to keep up-to-date. 

The injector only has one line per bundle with an AsyncProvider.

My implementation generates all the bundles that are necessary with out the need for the developer to worry about things like indexes and bundles sizes. Maybe my bad cause I mixed this with the ClientGinjector generation issue but I really see it as one problem.
ups, should be fixed now
These values have become the defulat log values 0 and 0 now . you can remove lines 51-52
Not sure this is the right place? It was overly aggressive in disallowing slashes in slugs, even when I did "This page -> Add child page" and tried to save the child page: http://screencast.com/t/TvLEomdu9
You mean one function get_valid_drivers and one function get_all_drivers?
lowercase odbc, pdo
Should probably not be public.
Perhaps a Cancel button would be a good idea. Also, on the Enable and Purge pages. Basically, just a button that takes them back to the extensions list page.
will want to get `errno` here, it returns `-1` on error.
These are not actual modifiers, right? Nu reprezintă artefacte sau vrăji și nu schimbă comportamentul codului. Poate n-ar trebui suprascrisă metoda get_modifiers din App. Anyway, unul e cu - altul e cu _ :-/
Is there a particular reason you recommend targeting 1.9+? Is there a common idiom for falling back to other libraries in Ruby? In python, I might do something like this, looking for different json parsers:

    try:
        # The faster implementation, not always available
        import simplejson as json
    except ImportError:
        # The implementation that is built-in but slower
        import json

Would you advise against doing a similar test for checking for `SecureRandom.uuid`?
Since all this state is getting passed around as a DOM id, we have to filter out some characters. Here I am filtering out { and } (lsq = left squiggly, rsq =right squiggly). This particular bit will become unnecessary in an upcoming merge where most state gets pulled out of ids and attached to layer objects using jquery's data() method.
please remove all code starting with src/screener from this pull request, since it's unrelated to Bmi Calculator
It turns out, we dont need round off at all. Using numberfield now.
tabbing issues here: make sure to run jsbeautifier.org on all files to catch things like this
> Dang! If only you received a commission for every PEP8 non-compliance, you'd be able to retire early as a happy man :) 

Yes I could retire, but not as a happy man... I'd be too bitter & twisted about all the PEP8 contraventions still taking place. :-P
Should this be a `require_once` or `require` instead?

I know that the parent file will only be included once because of autoloading, just that in some way if that file doesn't exist it isn't a Warning but a Fatal Error.
Good catch!

I'll make a new PR to fix this.
use - instead of None
Unnecessary coupling to parser class? I prefer eliminating this constructor and just having the Node-based constructor would be better.  Query-engines only need to know about nodes right? - not parsers.
Typo in last sentence.
link to "The test database" in topics/testing/overview?
That's non-greedy, right? If not, I would just use `[^\)]`.
Please provide a description, or at least `s/neeed/needed/`. =)
No, I'd disagree. Perhaps my choice of terminology was poor, but saying two settings are equivalent involves some insight into the meaning of the settings. The ajaxSetup method doesn't *know* anything about the meaning of the settings it's operating on, and I would argue that it shouldn't grow that knowledge now. On the other hand, jQuery.ajax *does* know the meaning of the settings its working with because it must to do its job. (It needs to know what kind of request to send, for example.)

In all honesty, if we were aliasing more than this one parameter, I'd be more in favor of extracting the aliasing into a different function before plugging it into ajaxSetup, but given that we're only hitting this one parameter I'm not sure the readability justifies the added bytes.

Interested in hearing other thoughts around these ideas, however.
It's a good intention, but should be in another pull request. Please separate the bug fix from the code size changes.
Do we care empty  or NULL array?
The issue here is that the transition state contains pointers within the transition-state array, but no bounds-checking is currently performed. Probably not the only such place in MADlib, and there is MADLIB-499 anyway. But yes, some input validation should be added for now.
also need to change the int on the right-hand side.
I think i would prefer to have just 1 event namiConnectionError (or whatever, see the comments above about the name of the events) reporting an error reason (like timeout, end, close, generic error, etc) instead of 4 or 5 different type of connection errors (so you can handle them with 1 listener)
Just timestamping the first one was at least enough to make the time position query report correctly after a seek that isn't immediate, but takes some seconds due to e.g. network delays.
We have `nostdout do … end` in utils.rb.
These options should probably be simply "without-gnutls", "with-pcre", etc. As soon we will be able to simplify it to `depends_on 'gnutls' => :recommended` or `depends_on 'pcre' => :optional` and the options will be auto-generated.
I know `man cmake` gives usage as "cmake [options] <path-to-source>", but does it actually matter in practice?
the current master doest this

```
try:
    from traitsui.api import View, Item, VSplit, HSplit, Group
except ImportError:
    try:
        from traits.ui.api import View, Item, VSplit, HSplit, Group
    except ImportError:
        from enthought.traits.ui.api import View, Item, VSplit, HSplit, Group
```

is that ok with you?
code de debug ....
Du coup, tu n'utilises pas personnage.posx,personnage.posy en retour...
the ``update`` parameter is not documented
status=200 ist der default... wann sollte man den manuell setzen wollen?
On Monday, September 17, 2012 at 2:47 PM, swankjesse wrote:
> In core/src/main/java/dagger/internal/RuntimeLinker.java
> 
> 

It's an addiction.  I understand.
要不你包养一章呗。
It does not harm the build, but it's a legacy of previous development, so i will remove it. I will check entire xml. Thx.

Maven has an elegant solution not to use Java main -surefire plugin for unit testing.

Just for your infromation, this is useful if having several junit dependencies (inherited) with different versions -no longer our case. This is the way to tell the surefire-plugin to distinguish between versions 3.8/4/4.7+ and select one in the classpath.
http://maven.apache.org/plugins/maven-surefire-plugin/examples/providers.html
You might be able to reduce code duplication here with a helper function as well. Maybe printing to text and binary file could even be handled by a single helper function?
Yeah, the actions below only need to be taken if the node is not already in the DOM. This can only happen if the node has already been removed, which means a hide has to have taken place. If this is the first time this dataChange is firing, that is to say upon binding instantiation, the node is already in the DOM, so we can save the work below. The placeholder node never starts in the DOM, so the check is unnecessary.
Hey, this idea is way better. 

https://github.com/ruby/ruby/blob/trunk/string.c#L1173-1179
It does now: see line 66.
The game is probably not going to work with IE <= 8, but ok.
finalize for the failure case makes sense. I think an empty result set can be an expected result in this case, so I'll leave that one alone.
This is mysterious enough that it'd be good to have some sort of explanation or background here -- even if it's just a link to the site that said this is how to do it...
Is this ``=`` intentional?
These being global worries me.
Don't think this method is used or necessary?
參考一下 titto
後來我覺得 sidebar 的寬度要寫死固定, main 才用彈性的 span
*This class defines document type for link posts.*
LimitedDateTimeField now takes limiting dates arguments. Not sure if this is ok...
same as above mentioned for loop
An older version of zoink exists that uses order, and from there, calculates the z index itself.

Me and Kate decided it would be better to pass in the zindex for them, so multiple plugins that use zindex would always work together.

No order ever was passed to the zoink though, so it never would of worked.

We can safly not pass in order, but I figured there was no harm passing it it. Might be nice to have order. but pretty harmless either way.
This should be a const, not a member variable. Probably `DRAGGING_CLASS` near the top of the file.
*shrugs* remove one of these newlines if you feel like it.
I think this line comment is not actually part of the diff, because he's already updated it, if I understand you.

https://github.com/mozilla/butter/pull/674/files#L1R117
If z-index has to be implemented plugin-side, this requires strict standardization between all plugins that use it. It might be better to store and set z-index globally from butter, and pass that value into `order`.
define variable `ANNOT_MIN_SIZE` = 10 one line and use it instead of literal
No *, put a path here.
I wonder if this is worth patching glib for, in case other components have a similar problem (now, or in the future). It also strikes me that this may be an issue that upstream might want to know about, so it might be nice to send a bugreport to them?
Is it possible to use the Thrift isSetParent_id (or whatever it is called) here instead? As mentioned the id !=0 is fine as a hack, but if possible we should figure out the correct solution.
Shouldn't this be in a config and not hardcoded?
This print statement should go away.
Can you read default from katello.conf?
Still it feels wrong should be changed. Isn't that what's the ticket title says anyway..
Either make it really thread-safe or don't pretend.
After thinking about this some more, I agree with @eteq that it should stay, and be called `w`.  I think it would be best to turn it into an attribute (using `@property`) for cases where w is not a function of z though.
I agree, I think this method should be removed
Class is called `GalacticCoordinates` (with s), not `GalacticCoordinate`
(same change in line 586)
算了，这个项目不太好，都以及N久没更新了。
BUG不止一处，功能也不齐全。。。
这个类的封装非常奇怪：
相信绝大部分的人只要有个Http::post Http::get就足够了，结果既有geturl也有get，既可以静态方法调用又可以实例化以后用，非常让人困惑的代码，用的人不仔细看过很容易用错。

而且这么复杂似乎只是解决了多次请求不能复用链接的问题。成本和产出相比太大了。
This makes perfect sense.  I will try to make this update this weekend.
What is i in this case? const pair& or a copy?
You don't have to include the `.id` part when doing this stuff. Just `listing_path(@listing)` works fine and is cleaner.
Oops, yea that was a typo, fixed to use info2 the second time.
@gavinandresen During normal IBD it will be < checkpoint too. As a follow-up, we should probably disable accepting things to the mempool during IBD altogether...
oh, thats true

    $this->Controller = new MobileComponentTestController(new CakeRequest(null, false), new CakeResponse());
    $this->Controller->constructClasses();
    $this->Controller->startupProcess();

triggers it.
nope, there are 44 assignment in conditional in Cake source.

`Squiz.PHP.DisallowComparisonAssignment` should be added to ruleset.
Line break missing
Still gtk.ICON_SIZE_MENU vs a hardcoded 16. Hardcoded is bad.
This is a place where you could use that helper you made earlier. Also, I think the helper should probably be moved into application_helper.
These scenario titles might be more clear as: `Create public subgroup where all group members can invite`
If these are integers, they should be converted to such
Should `its website` be a link?
Why are these guys commented out?
It's not necessary as moveToPageAtIndex immediately sets it to -1. But it wouldn't hurt.
Does this do a === check? Since you specifically wanted to use parseInt to make sure its a number, I think the test should check this.
Remove dead code under this!
Agreed. :skull::fire:
There needs to be a ``not is_list`` check for the first half of this condition, I think. Also on line 185 and 201.
Extra "requires".
Oops, I missed this URL before. Should be relative `../img/...`
Sounds good. Add session id or some other identifier to the loadFile and fileData events -- we may load more than one file in the future.
since you don't actually need the value, just whether something was found or not, why not just do:

```
select 1 from priorityjobs where uuid=%(uuid)s
```
`int(11) unsigned`
I think you can still use hull.github.com/sidekiq/pro, yes?
Ah...From a user's standpoint, I can see that it might be confusing to access stats for Retries and Scheduled from a different API object. However, I'm not convinced that `retry_size` is great b/c it begs the question, why isn't the method for stats `processed` => `processed_size`. The naming just seems inconsistent.

If we wanted to include this, I would think the following might be clearer:

```Ruby
stats.scheduled
stats.retries
```

What do you think?
Thanks!  I've fixed this in this commit: https://github.com/bhouston/three.js/commit/67fdeb97b935925df82b3a265ff4d383bf981337
You want org.neo4j.helpers.collection.CombiningIterable.
Hi Todd,

The db/development_structure.sql is unnecessary. Sorry, we didn't catch it
creep in to the pull request. Should i delete the file through another pull
request (with fixes)?


On Thu, Dec 27, 2012 at 3:10 AM, Todd Sedano <notifications@github.com>wrote:

> In db/development_structure.sql:
>
> > +--
> > +-- Name: index_suggestions_on_user_id; Type: INDEX; Schema: public; Owner: -; Tablespace:
> > +--
> > +
> > +CREATE INDEX index_suggestions_on_user_id ON suggestions USING btree (user_id);
> > +
> > +
> > +--
> > +-- Name: index_teams_on_course_id; Type: INDEX; Schema: public; Owner: -; Tablespace:
> > +--
> > +
> > +CREATE INDEX index_teams_on_course_id ON teams USING btree (course_id);
> > +
> > +
> > +--
> > +-- Name: index_teams_people_on_person_id; Type: INDEX; Schema: public; Owner: -; Ta
>
> Is this file necessary in source control? How is this file updated? When
> is it used? Why do you prefer this over schema.rb?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/professor/cmusv/pull/151/files#r2506211>.
>
>
In my command I used regular expressions and it will help me to find the right situation to make changes! but unfortunately  you just replaced an obvious situation.  
about changing hamzeh I will make an option for user to choose what he/she wants ;-)
@pborreli  no. ``&&`` stops executing conditions as soon as one of them returns ``false``. It is the same for ``||`` when the left condition returns ``true``.

@schmittjoh this does not change much IMO as Linux systems will call the ``isSigchildEnabled`` in the constructor to set the default value of the ``enhanceSigchildCompatibility`` anyway and the logic is done only the first time the Process is used and then cached. So the only difference in cost is a method call reading a property vs reading a property.
Maybe #2876 should be reconsidered.
Should you extend `SplFileInfo` (which adds support for relative paths ?)
you need to skip this test when intl is not available as the stub will break otherwise
there is a trailing `/` that should be removed.
It seems like the SQL Time type is more accurately represented by a duration because time can also be negative. Unless I am missing something, the current Connector/J driver does not support negative Time. It will throw a SQLException if you try to getTime with a negative time value in the database because it uses java.sql.Time to represent SQL Time.

Is this behavior we want to mimic? Or are we actually interested in negative Time values?
does this mean the error messages will only report on lines with the beginning of a definition? makes it seem like there's no need to attach the position to any other node.
why is this being declared static here?
Hi John,

I did it when I spotted this comment here:

        | VBD_insert (id, disk) ->
            (* NB this is also used to "refresh" ie signal a qemu that
it should
               re-open a device, useful for when a physical CDROM is
inserted into
               the host. *)

Which reminded me that "cdrommon" will detect a physical CD insertion
and call "xe host-notify" which
calls into "Xapi_xenops.vbd_insert". I think this is supposed to work
by re-writing the xenstore key with
the same value which triggers the watch and causes qemu to attempt to
open the device.

I couldn't see how this could have worked before, so I figured it must
have been broken :)

I think the asserts in Xapi_vbd.insert still prevent you from doing
the wrong thing-- it's just the xenopsd
interface which has been loosened.

Does that seem sensible?


On Wed, Jul 4, 2012 at 3:44 PM, John Else
<reply@reply.github.com>
wrote:
>> -                     let vm_state = B.VM.get_state (VM_DB.read_exn (VBD_DB.vm_of id)) in
>> -                     let vbd_state = B.VBD.get_state (VBD_DB.vm_of id) vbd_t in
>> -                     if vm_state.Vm.power_state = Running
>> -                     then
>> -                             if vbd_state.Vbd.media_present && vbd_t.Vbd.backend <> Some disk
>> -                             then raise (Media_present)
>> -                             else B.VBD.insert t (VBD_DB.vm_of id) vbd_t disk;
>> -                     VBD_DB.write id { vbd_t with Vbd.backend = Some disk };
>> -                     VBD_DB.signal id
>> +                     let power = (B.VM.get_state (VM_DB.read_exn (fst id))).Vm.power_state in
>> +                     begin match power with
>> +                             | Running _ | Paused ->
>> +                                     B.VBD.insert t (VBD_DB.vm_of id) vbd_t disk;
>> +                                     VBD_DB.signal id
>> +                             | _ -> raise (Bad_power_state(power, Running))
>> +                     end
>
> Why do we no longer check that the VBD is empty before attempting to do VBD.insert? Similarly for VBD.eject, we are no longer checking that the VBD is not empty.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/xen-org/xen-api/pull/726/files#r1100506



-- 
Dave Scott
Typo here. Is this file everything, or just an example?
For example here. In the main class, define
typedef Vector::Coordinate Coordinate;  (which is necessarily a type with arithmetical operations like "int")
and replace this by
      Coordinate x2 = q[0];
Seems like you haven't updated from our trunk for a while. There is a conflict on this change. I'll resolve it manually, but in the future it would be a goof idea to update frequently.
you can just do `yield if block_given?`, will save on having to pass the actual block.
Hier brauch ich ein paar Erläuterungen, sind aber warscheinlich Standard-Einstellungssachen
Do we want a space after this comma?
Actually I'm not sure about this. We definitely need Doc in this thread.
What is that, we should use more meaningful variable names.
There's an extra space here between "context" and "to".
Use the variable you defined above here
The default="jboss.server.log.dir" shouldn't be there.
If you want this to be commented out you need to preceed it with an opening comment tag, which is missing here.
I used layerX is because I just want to get the x position of my target elements. For clientX or pageX, I have to do some calculation like clientX - style.left, I am afraid that it might get wrong result if one of the value of clientX and style.left is not correct.

I also found that Music app didn't apply the shim for apps but still got the correct result, so maybe after bug 823619 is resolved, let's see if we have to change the seeking of Music.
There is a lot of nesting here. What about using some early return?
As you see, something weird is happening to this. Some like:

```javascript
if (window.matchMedia("(orientation: portrait)"))
  console-log('is portrait');
if (window.matchMedia("(orientation: landscape)"))
  console-log('is landscape');
```

return something like:

```
is portrait
is landscape
```

This does not make sense. I take the commentary as non-blocking but, as you said, we should open a bug for this.
I guess the hash of Settings is not set to those values when bluetooth messages are received. So it makes me hesitant/.
Can it be multiples costcontrol applications? If not it's a bit weird to use an activity here since other webapps will be able to hook up your code. Is it what you want?
I have always think this is a broken way to express a function:

      NotificationHelper.send(title, body, iconURL,
                                                  onclick);

(if it does not fit with the shorter name of notiClick)
It's totally my bad without doing **further** test I think :/
Nit: s/installen/installed
In addition to fixing your isMatched() function, please also fix my bug in enumerate by applyng this patch to shared/js/mediadb.js:

diff --git a/shared/js/mediadb.js b/shared/js/mediadb.js
index f2fe37d..8d3af7b 100644
--- a/shared/js/mediadb.js
+++ b/shared/js/mediadb.js
@@ -746,7 +746,12 @@ var MediaDB = (function() {
 
         var cursor = cursorRequest.result;
         if (cursor) {
-          callback(cursor.value);
+          try {
+            callback(cursor.value);
+          }
+          catch(e) {
+            console.warn('MediaDB.enumerate(): callback threw', e);
+          }
           cursor.continue();
         }
         else {

Let's just merge that fix as part of this pull request, if it is okay with you.
You have `{user}` here, but `{name}` in GELAM. This obviously doesn't work right. :)
I found some examples of things to put in the path or query that `Addressable::URI` can parse but `URI`, however I ran into the problem that Webrick internally uses `URI` to parse the requests and so it will crash before the response can be served.

I can think of two other opions:
  - Write out a cassette yml file so no request is made and then I can make the URLs whatever I want and know that only VCR will be handling them.
  - Set the parser in the example to a custom one that is more restrictive thn `URI` and assert that it will fail when requesting a valid uri.

The second still has the problem that its not a very realistic test but in some ways it is simpler. Do you think there are any problems with taking the first approach?
What happens when the assumption fails: It MAy cause a gap in time-series databases:

Example with 1 minute check_interval results:

10 h 0 m 59s
10 h 2 m 01s
10 h 2 m 59s
10 h 3 m 59s
10 h 4 m 59s

Notice that there is a gap, so graphite and RRDtool which use absolute time, will not display a point.
It's in the vnext branch.
You mean for the scenario where there is a setting with the same name? I suppose that if someone goes out of their way to override the folder, then we should probably honor it. Though these are fully qualified paths, right? So it would be hard for someone to come up with it reliably from outside Kudu.
I like this docstring format :)

With argument this should be like:
```
"""Bla bla bla.

Args:
    bla: int. Bla bla bla bla.

Returns: Bla bla.
"""
Right?
All calls to `info` need to be wrapped in calls to `compiler.askOption( () => `. That's because the compiler is not thread-safe and runs on its own thread, so any work that might trigger mutation (such as forcing a lazy type in this case) needs to be performed inside an ask (this is the same idea as `asyncExec` in SWT, where some things need to be performed on the UI thread.
hostname, tags は UI じゃないので「」ではなく "" にしない？
tag は「」じゃなくて ** のほうが原文どおり
Nice.  I figured there was a cleaner way to do this, just wasn't sure what
the syntax was.  Thanks!

On Tue, Sep 11, 2012 at 9:29 PM, P. Oscar Boykin
<notifications@github.com>wrote:

> In src/main/scala/com/twitter/scalding/FieldConversions.scala:
>
> > +  def apply[T](f: Traversable[Field[_ <: T]]) = new RichFields[T](f)
> > +
> > +}
> > +
> > +sealed abstract class Field[T] {
> > +  def id  : Comparable[_]
> > +  def ord : Ordering[T]
> > +  def mf  : Option[Manifest[T]]
> > +}
> > +
> > +case class IntField[T](index: Int)(implicit ordval : Ordering[T], mfval : Option[Manifest[T]]) extends Field[T] {
> > +  def id  = index
> > +  def ord = ordval
> > +  def mf  = mfval
> > +}
> > +case class StringField[T](name: String)(implicit ordval : Ordering[T], mfval : Option[Manifest[T]]) extends Field[T] {
>
> if you want to make this class more compact, you can do:
>
> StringFieldT(implicit override val ord : Ordering[T], override val mf :
> Option[Manifest[T]]) extends Field[T]
>
> I think.... Not a big deal, just FYI.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/scalding/pull/175/files#r1583432>.
>
>
The problem with the find was that search all of /op/local is horribly slow.
This function assumes that needle and haystack are numpy arrays.   Must the have the same dtype to qualify?  or will type coercion be allowed?   

Also, I assume that you must have
     
     needle.shape[1:] == haystack.shape[1:]

right?
That's not what I'm saying. You are saying that we use environment variables to start Java apps. This is incorrect. We use shell commands to start Java apps. This returns the environment variables that Java apps need to run.
There should be a check here that `howMany > 0` correct?
From my understanding of the API, there is no way that you would get a "success" key unless you are authenticated.  That is why I first check for "success" and then check for authentication error only if we made it past that check.  

It could work either way.  It does seem more logical to check auth before checking for other error messages.
spellcheck: unknwon
Could this just be a lambda? Or even have `class MyEndpoint(base.Endpoint): def get(...): return defer.succeed(9999)`?
More test coverage. Awesome!!
Yes we can. There should be no `make install` @gjtorikian
why not simply ``$this->contents = $match[0];`` ?
extra braces around the isset call
same here about the order of the check
hmm, got confused too :)
Err the above comment was meant for the other thread on top changing the github-protocols
They're stored as Base64 values. :)
On Jun 7, 2012 10:55 AM, "Maxwell Salzberg" <
reply@reply.github.com>
wrote:

> > @@ -10,4 +10,6 @@
> >    <Link rel="http://schemas.google.com/g/2010#updates-from"
> type="application/atom+xml" href="<%=@person.public_url%>.atom"/>
> >
> >    <Link rel="diaspora-public-key" type = 'RSA'
> href="<%=Base64.strict_encode64(@person.exported_key)%>"/>
> > +  <Link rel="scrypto-encryption-key" type='text/html' href="<%=
> @person.key_ring.encryption %>">
>
> most likely need to base64 these bad boys.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/diaspora/diaspora/pull/3312/files#r945503
>
{コールバックが本来のイベント名を第一引数として取得する`"all"`を利用していない限りは)
ROS wiki page is still missing, please add some basic documentation there. The header will be filled out as soon as the pull request is in ipa320.
if current_user.score_private
what is this ;  ???? :D
That's the only cases I could see from the code. However, if the `selection` is not an instance of `nsISelectionPrivate` it means we can't call the `addSelectionListener` method, so whatever `selection` will be, it's nothing we're interested in, and we can handle (`instanceof` behaves like `QueryInterface`, where returns `false` instead of raising an exception in case the object doesn't support the given interface).
Maybe @warner can tell us why python code was ignoring floats ?
how would you feel about a slightly more descriptive sanity check?

`throw new Error('client.json file doesn't exist in ' + path.join(json_dir, l));`
Heh, very true, I will make `run_metrics` the default behavior.
This would fail if called directly because xpi.filename is not set. Why not just make 'build' the default with the filename value from dev?
This code is not done by me.
This fails for symbols:

err: /Stage[main]/Users::Builder::Account/Darwinuser[cltbld]/ensure: change from absent to present failed: Could not set 'present on ensure: undefined method `intern' for :home:Symbol at /etc/puppet/environments/dmitchell/env/modules/users/manifests/builder/account.pp:45
This doesn't seem to be related to the systemd work. Is this just a mistake that it got included?
Isn't this the very same code as in lines 61 and 67?

Why we'd have to connect an object's signal to a slot of the _same_ object is also beyond me, but that "logic" was there before ;).
I think if it's going to return anything by default it should be a double. That supports @alindeman's example without adding methods like `new`, etc.
```
irb(main):002:0> nil << 'hello world'
NoMethodError: undefined method `<<' for nil:NilClass
	from (irb):2
	from /Users/taavo/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/railties-3.2.8/lib/rails/commands/console.rb:47:in `start'
	from /Users/taavo/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/railties-3.2.8/lib/rails/commands/console.rb:8:in `start'
	from /Users/taavo/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/railties-3.2.8/lib/rails/commands.rb:41:in `<top (required)>'
	from script/rails:35:in `require'
	from script/rails:35:in `<main>'
irb(main):003:0> true << 'hello world'
NoMethodError: undefined method `<<' for true:TrueClass
	from (irb):3
	from /Users/taavo/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/railties-3.2.8/lib/rails/commands/console.rb:47:in `start'
	from /Users/taavo/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/railties-3.2.8/lib/rails/commands/console.rb:8:in `start'
	from /Users/taavo/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/railties-3.2.8/lib/rails/commands.rb:41:in `<top (required)>'
	from script/rails:35:in `require'
	from script/rails:35:in `<main>'
irb(main):001:0> nil.to_s << 'hello world'
=> "hello world"
irb(main):004:0> true.to_s << 'hello world'
=> "truehello world"
```

A bunch of tests return nil or true in that block. This code was to keep us from bombing out. If there's a better solution than the to_s, I'm down.
You'll need to add a check for whether the use cancelled the event.

So perhaps change these lines to:

```js
var e // put this up the top with the other variables for consistency

this.$element.trigger(e = $.Event('show')
if (e.isDefaultPrevented()) return
```

You should then do the same for the hide event.
s/correspond/corresponds/
`che la configurazione sia abilitata`
I guess that the iniital ScrollingStyle is talking about the subcomponent in general and not should be changed.
Since these options are also used to provide the various checkboxes, shouldn't it remove the "special" options (use_hidden_element, uncheck_value, label_attributes) from the $options array?
Indent this with 4 spaces
s/TableGatway/TableGateway/
The reason for failing with no settings._yml_ it that the user should be aware of updating his settings.json file. But i'm not really happy with this solution as i think etherpad should run out of the box, without a settings file required
@albertosaurus I'm fixing it today. Sorry for delay.
Use a constant for 13:

```js
let ENTER_KEY = 13

...

if ( event.keyCode is ENTER_KEY ) {
```
Wasn't that annoying to do that 4 times?  Next check-in, move them all to a function and just call the function 4 times :)

Otherwise, looks good.
Corrected in [21e15721b875a0b98570f6e53b20b480b3d992df].
Just a heads up, I know this isnt ready to be merged yet

The reason I took out all the scripts listed in the head, they are included dynamically once the page has loaded, this is so during dev we can pick and choose what tests to run, and inside CI we can switch a flag and do tests.html?production to test the actual pouch.js etc
you have an extra ``i`` in the variable name btw
They use `or` in a completely different context, for control-flow logic. It would be bad to change the meaning of `or` in the spec to mean this type or the other type, for example `MyRecord or Other` doesn't feel correct.
The default return value when doing `.get` on a dict is None, so you don't need to specify it.
rebuilds is perhaps overloaded, recreates might be better?
Add "display=mobile" in the query params of the /oauth/authorize url to force it to display the mobile oauth flow.
Cut down on whitespace issues

Leaves a print statement
TODO: or FIXME:
Using habitat makes `lib/configuration.js` such a thin wrapper that I'm tempted to do away with it and use habitat directly in any files currently requiring configuration.
Yeah, I think the line is okay.


craft = CoverageCraft
        sdom, tdom = craft.create_domains()
        sdom = sdom.dump()
....
And so on..

- Swarbhanu.


On 8/3/12 2:46 PM, "Dave Foster"
<reply+p-1304407-13d6a3c569cc07c860d61dbf83c8ad040b8a9f8d-1181645@reply.git
hub.com> wrote:

>>  
>>  
>>          log.debug('Creating new CDM data product with a stream
>>definition')
>> -        dp_obj =
>>IonObject(RT.DataProduct,name=data_product_name,description='ctd stream
>>test')
>> -        try:
>> -            ctd_parsed_data_product_id =
>>self.dataproductclient.create_data_product(dp_obj, ctd_stream_def_id)
>> -        except Exception as ex:
>> -            self.fail("failed to create new data product: %s" %ex)
>> +
>> +        craft = CoverageCraft
>
>Same, `CoverageCraft()`
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/ooici/coi-services/pull/221/files#r1304407
I definitely would like to. Do you think people will remember to call `__send` if they're using it in the ruby-sense, though?
message??
why move all of this code into the controller?
@hosts and @title imho do not belong here
Move that 3 into a settings variable which can default to 3.
Isn't this a change in behavior?
Should this be something like COOK-1009 just to make sure we catch cases like that?
addition is commutative: changing the order should not change the results. There was a long discussion on `NDData` and `Spectrum1D` about this, where people were complaining that you shouldn't give preference to either one. That's why I suggested SI - I think that can be documented just as well as picking the unit on the left.
Link is going to the wrong place
It's primary use is to add new modules, it might be worth mentioning that.
These two debug statements are probably big enough to wrap in isDebugEnabled, or omit altogether.
Coding-standards (CS) : please add spaces around the ``=`` sign.
ты уже нанял 100 китайцев, которые проверят, что ты правильно вывел? нужны автоматические тесты.