labofsahil/github-event-dataset-2012 huggingface dataset:
In the assembly-guvnor-jboss-as-7_0.xml there's a web.xml filtering entry to get rid of the resteasy line in web.xml. 5.4.0 used CXF and did not have to do that.
Can you confirm that the REST stuff doesn't blow up at deployment in 5.5.0-SNAPSHOT without that line?
It is only used for the binding framework:

https://github.com/elabs/serenade.js/blob/master/src/serenade.coffee#L45

It could be completely removed in my opinion and wouldn't make any difference honestly.
Please don't continue C&P for new ports. It's time to rewrite the file and use macros to duplicate the code.
i suppose adding a deflecting:
ifdef(`conf_BUTTONS_INPUT', `dnl
Need to insert a barrier here.
I'm really not actually sure how to do multi-layered hair games like this.
Not sure I understand what this method does?
or let me just move it flow.h
how come? it checks for all three conditions
Is this here for testing, or do you think we should include a more advanced blocks example in the default layout? I might prefer simply making the `{! blocks/members !}` sidebar block into one with a fallback (e.g., `{! blocks/index?id=sidebar-[id]&fallback=members !}`).
Because here its still referenced !!!
typo: 'safety'
fantastic prose.
None.  I think I was initially thinking different metric methods might not have a metric summary but that can be handled through the MetricMethod interface.  I'm going to hold off on making this change until you're ready to discuss exponential scaling, I think all of the metric data could be computed when the data is received.
The code inside onceDailyObserver is indented 1 space too much.
@hkenney  `Kernel` is misspelled
使用完记得释放资源，f.close()
ah consequence of to many deletes ;-)
This not have sense. DecoratorInterface\xxx
Great example of why we don't want to automate this!
You are right, my mistake, Its more complex.

Anyway, If it were me, I would do it like this:
```diff
diff --git a/architecture-examples/emberjs/css/app.css b/architecture-examples/emberjs/css/app.css
index 74b02a2..e1babc8 100644
--- a/architecture-examples/emberjs/css/app.css
+++ b/architecture-examples/emberjs/css/app.css
@@ -3,9 +3,3 @@
 .hidden {
   display: none
 }
-
-.all-selected #filters li.all-filter a,
-.active-selected #filters li.active-filter a,
-.completed-selected #filters li.completed-filter a {
-  font-weight: bold;
-}
\ No newline at end of file
diff --git a/architecture-examples/emberjs/index.html b/architecture-examples/emberjs/index.html
index 1af33a2..10b116f 100755
--- a/architecture-examples/emberjs/index.html
+++ b/architecture-examples/emberjs/index.html
@@ -33,13 +33,13 @@
 	</script>
 	<script id="filtersTemplate" type="text/x-handlebars">
 		<ul id="filters">
-			<li class="all-filter">
-				<a {{action showAll href=true}}>All </a>
+			<li {{action filterClicked target="view" on="click"}}>
+				<a {{action showAll href=true}}>All</a>
 			</li>
-			<li class="active-filter">
-				<a {{action showActive href=true}}>Active</a>
+			<li {{action filterClicked target="view" on="click"}}>
+				<a {{action showActive href=true on="click"}}>Active</a>
 			</li>
-			<li class="completed-filter">
+			<li {{action filterClicked target="view" on="click"}}>
 				<a {{action showCompleted href=true}}>Completed</a>
 			</li>
 		</ul>
diff --git a/architecture-examples/emberjs/js/views/application.js b/architecture-examples/emberjs/js/views/application.js
index 6e8db4a..4088f84 100644
--- a/architecture-examples/emberjs/js/views/application.js
+++ b/architecture-examples/emberjs/js/views/application.js
@@ -58,12 +58,10 @@
 			}),
 			filtersView: Ember.View.create({
 				templateName: 'filtersTemplate',
-				classNameBindings: 'routerClassName'.w(),
-				currentFilterBinding: 'Todos.entriesController.filterBy',
-				routerClassName: function() {
-					var currentFilter = this.get('currentFilter');
-					return (currentFilter.length ? currentFilter : 'all') + '-selected';
-				}.property( 'currentFilter' )
+				filterClicked: function( event ) {
+					$( '#filters .selected' ).removeClass( 'selected' );
+					$( event.target ).addClass('selected');
+				}
 			}),
 			clearBtnView: Ember.View.create({
 				entriesBinding: 'controller.namespace.entriesController',
```
These 7 lines seem pretty complex... can they be refactored?

It may make sense to remove the use of `log_device` in this class entirely.  Then the logger creation/setup could be handled elsewhere... but I haven't entirely thought through that yet.  :smile:
The C++ constructor notation is preferred: std::string(PHYFS_getUserDir())
I'd reset the Hydration modes here eventually. Otherwise rename the method to `addCustomHydrationModes`
here i am not sure if i should set cascade all
> 1) eZ\Publish\Core\REST\Server\Tests\Output\ValueObjectVisitor\LocationTest::testVisit
> eZ\Publish\API\Repository\Exceptions\PropertyNotFoundException: Property 'location' not found
> on class 'eZ\Publish\Core\Repository\Values\Content\Location'

Same as TrashItemTest, $location needs to RestLocation now.
do you agree with me that we should still get rid of this warning? ;-)
It seems you have mixed tabs with spaces. Please use only spaces.
add version here (see issue #257)
I was waiting for your fancy one-liners to fix all that ;) 

Serious question though: how do I prevent the output when nothing really has changed? now it prints 2 empty lines which is rather ugly?
more copy paste friendly:
"\n".join(["module load %s/%s" % (module['name'],module['version']) for module in mods])
If I change this to "The Steps required to implement xyz" would that work, also, note, that the user will have to action one step only which is adding the security domain to the standalone.xml, other than that, all implemented in the example code, thoughts.
I just noticed this, but I think this needs to be:

````javascript
if (currentActor.draw) {
  currentActor.draw(canvas_context, currentActor.get());
}
````

Since this is only drawing `Kapi.CanvasActor`s, or at least anything with a `draw` method.
I could only get it to work with the nesting. Let's go over this IRL!
Sure, that won't be a problem.
Right, I forgot about that.  I changed to absolute imports which I assume should be OK for this package.

I recall there was some discussion about numpy legacy support for Python 2.4, so unless I hear otherwise I'll assume this package should support back to 2.4 as well.
Sure, I can update it.

tbh, I think I have a better idea about keeping the blurb DRY, although it would initially be a bit of a pip. Basically, the reason I had to repeat the entire blurb here is the standard blurb partial has the li tags inside it, which means you can't add anything (eg bookmark information, history information) after the standard information without duplicating the whole thing. I think we should take the li tags out of that and just put them around the render anywhere we call the blurb. (Bonus: blurbs wouldn't always have to be contained in a ul or ol.)
I'll look into refactoring this block. I'll move the @title into the title helper and the hosts into the model.
nit: Space
I don't get it yet. Why would you have methods here that modify other classes' properties? ([KISS](https://en.wikipedia.org/wiki/KISS_principle))
Should one of this white color definitions be removed?
You could simply do the calculation here, rather than defining all the `<var>`s above, like this:

    line([6 + (0 - 6)* cos(TILT) - (0 - 2)* sin(TILT), 2 + (0 - 6) * sin(TILT) + (0 - 2) * cos(TILT)],
         [6 + (10 - 6)* cos(TILT) - (0 - 2)* sin(TILT), 2 + (10 - 6) * sin(TILT) + (0 - 2) * cos(TILT)],
         {arrows: "->"});
I tried strokeWidth in something else and it didn't work. I can try it again and see if it's working better now, though.
Copypaste :)
mmmmmmmmmmmmmmmmmmmmmmmmmManagement
Thanks, I will make the change
I'm carrying across micro-optimisations from writing userscripts in javascript. Probably isn't even faster in Java...
Is there any possibility to refactoring the existing `render_settings_template`? I'm nervous about having two implementations of the same function.
Indenting here is a little buggy.
надо дать название enumу и хранить enum
Sorry I was probably drunk and commenting on the wrong commit (I was at a conference...)
It'd be nicer if this was done with `inject`, so that the manipulators could just take a list and return a new list, rather than having them maniupulate the sitemap's page list directly. Something like:

`@pages = @page_list_manipulators.inject([], &:manipulate_page_list)`
We should remove <code>set_review_rating</code> method since it's not used anywhere else in our tests.
And could you please explain the need for this and how it should be used by external users
That's probably true, and I should probably add some tests for this too.
Agreed on all recent changes.

2012/3/26 Peter Berkenbosch <
reply@reply.github.com
>

> >        dialogs:
> >          show:
> >            save: Opslaan
> >            cancel: Annuleren
> >        continue_editing:
> > -        save_and_continue_editing: Sla op en ga verder met bewerken
> > +        save_and_continue_editing: Opslaan en verdergaan met bewerken
>
> Should be:
> Opslaan en verder gaan met bewerken
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/resolve/refinerycms/pull/1483/files#r601899
>
I went down this route before, but the problem is that when `PrincipalsAPI` creates a user, it is in an anonymous context. Exposing this method and allowing anonymous to associate id's would be dangerous. Also, it forms cross-dependencies.

I can't remember why I exposed it, but it is well tested. I'd prefer to keep it rather than have to expose it at a later date and rewrite the unit tests.
Please keep our require conventions into account here

1. 3rd party modules
2. Other OAE modules
3. Current OAE module
Shouldn't the above constants be put in the companion object?
음... 그게 귀신이 곡할 노릇인데요... POST를 명시하면 모든 요청에 실패합니다...
파라미터가 제대로 안 넘어가요. 일부러 제거한 상태입니다...;;;
I think this could be made consistent:

     :attack_files => cmd_opts[:attack_files]

(plural => plural)
CI is the one that adds multiple="multiple" when using multi_select().  All I did was change the check for it to be the same as what CI outputs.  Originally it was only checking to see if the word "multiple" existed anywhere in the 4th parameter, which prevented people from being able to use the string "multiple" anywhere else like assigning it in an ID or classname.

if you did
echo multi_select('my-select', $options, $selected_value, 'id="multiple-choice"');
CI wouldn't output the multiple="multiple" in the element, which caused it to not work.
I think for readability now that this is a multi-dim array its ok to change it to a foreach. The speed different is infintessimal and thanks to all the other speed improvements you've made we can probably afford to lose this 0.000001 second change in the 3.0 branch. :)
На 0 делить нельзя
тоже верно, но в масштабе такой задачи это сильно не нагружает) За замечание, спасибо! В дальнейшем буду учитывать
Could you elaborate on this? AFAICT cookies are used and nothing is persisted on server side. I.e. if a user clears cookies in the current browser, prefs are lost. Same if a user switches PC/browser profile/browser. To me preferences should survive all of this, though. In any case, I'm OK with the cookie approach for the time being if you'll open a ticket for persistent preferences :)
Fixed. This is how window states should be restored:

*restored* - Size & position should be remembered on any monitor.

*maximized* - Should be remembered for any monitor. Also, switching back to "restored" size should remember previous size & position.

*minimized* - It seems like we didn't want to open Brackets into a minimized state, so it should use state from previous startup.
para montar os redirects utilize também $this->url ao inves de escrever o path na mão.
Knope, nuked it.
I'll pull them both out for clarity and so they get truncated in the same way.
Why does the `GalleryActivity` have to do this? It's probably easier to have the `MediaFragment` do it or just default it to `View.GONE` in the layout.
If this is going to take an argument, it should accept an array of multiple versions given the method name.
Should be != for clarity
'sall good, it should be fixed now.
you don't need the \ between ()
I too included socket.io in my branch but put it in js/lib/socket.io. Not sure where it should properly live but that seemed like the best place since things like underscore.js are in there.
We should strive to wrap just user's code using this execution context, not more, not less. That why the earlier implementation was better. The only thing is that parser(rh) is executing user's code. So it should be Iteratee.flatten(Future(parser(rh))(play.api.libs.concurrent.Execution.defaultContext)).map ...
Is this really the best way to create primary keys?
Actually I just mimicked what had already been done just below in the "and avatar_updated_at column" context part. Plus I don't see Timecop being used anywhere else and I am not sure I understand your multi gemfile thing to add timecop support :)
Yes will fix this.
But it's not plus or minus. that's my issue with it.

Plus: 3 + 3 == 6
Map concat: scala> Map("foo" -> "bar") ++ Map("foo" -> "baz") == Map(foo -> baz)

So it shouldn't be called plus, because it doesn't have plus semantics.
Override unhandled instead
Пробел на конце не нужен.
Yo no tengo problema en empezar con el nivel 1, lo que no quiero es que se
salten niveles como en este caso

2012/4/4 Alpha <
reply@reply.github.com
>

> > @@ -0,0 +1,17 @@
> > +# Retrospectiva
> > +
> > +### Andrés:
>
> Cuando yo hablaba de saltar los títulos me refería a tener que comenzar en
> el segundo nivel. Para ser sincero, no recuerdo exactamente por qué era,
> aunque recuerdo que estaba relacionado con el renderizado.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/52/files#r644522
>
oh oh. no new line
Much cleaner (or certainly more clojuresque).
meh, just for first run convenience---test driving
Maybe using aliases in sub classes would make this easier?
I guess I'm confused of what kind of items are expected to be returned.  With strip() all white space before and after the item (which is split based on commas) is removed but with replace() all white space is removed including within the items.

I just want to point out the difference, which you may already know.
You shouldn't really check this at all, as `count` is a relatively expensive operation. If `n >= (count coll)` you just return the whole coll.
If you allow providing a cache configuration, you should at least check that it meets minimum requirements for it to be useful (eg. it has to be DIST).
Isn't StringPropertyReplacer already doing such checks? Looks like it should be the responsibility of StringPropertyReplacer anyway
If you're going to add a shift, would it make sense to use that shift in the lines above too? or is that too invasive?  (same below)
Should this be a main bullet, or a sub-bullet for the PEP8 bullet?
The `bins` argument to `np.histogram` takes either the number of bins or an array of bin edges.

I just played around a little, and I don't think it's possible for `np.histogram` to return a zero-length array of bin edges. It raises an exception if one tries to set `bins=0`

 In fact, the only way I can get it to return anything less than a length-2 array is by explicitly passing only one bin edge. This will obviously result in some strange behavior, but that's a pretty edge case. If `np.histogram` doesn't raise an exception for that, I don't think we should, either.
Umm....where's the lock function in this python file? Shouldn't we have an equivalent def lock(self) function making the relevant call over to JS for lock()?
I think this field does belong in here.
Also it should be neither public nor static
Oh. I see, I'll try to solve this.
This was all whitespace...
@bp323 Just like the other items in this list which make Ajax calls, we have to make it synchronous in order to make it work.
Ideally we would be using callbacks/deferreds, but this isn't the case now.
It would probably be better to handle this in a separe ticket / PR.

e.g. picasaweb, videolectures.net, flickr.com, slideshare.net
@bp323 yes, I don't need the country - we only need the language.
This test seems to be a bit fragile, as it relies on the relation count (while blocks). Is there a way to write it without checking the relation count?
why not just \Newscoop\Event\GenericEvent class?
What do you mean ? This is the explicit way to test a boolean
You don't need this added here, as it's not used anywhere else in this class.
Also, should I remove comments like this one from the javadoc?
If you mean code standards, I have no problem adopting Symfony's.
Haha no problem. The code is mostly copied and pasted from the `remove` unit test anyway, so you were partly right. The only difference is the error assertions ("no nodes matched that" vs. "you crazy, that index doesn't even exist")
"finally" => "Finally"
No, at runtime they behave exactly the same. As a matter of fact they are even stored the same way. The only different is if they're defined at runtime (define) or at compile time (const) the latter being a tiny bit faster with opcode cacheing. (I read that Drupal saw an overall performance increase of 1% but they have far more constants than we do).

the more important point is that this is more consistent with how we define class constants.
if it isn't used, remove it.
I think there are other tests above that address the fact that array items exist at a certain index, so I think I'd be inclined to remove this one.
Yes, missing a carriage return. Fixed.
<code>If the link above does not work, you can copy-paste it directly into your browser. </code>
This okay?
You are doing query string passing of variables here?

GET request should never change anything in the database. Please update to POST.
Ehm, this is without `<p>` at the beginning?
I've checked compatibility tables and IE supported this selector since IE7, other major browsers supported it even longer, so I think there shouldn't be any problems.
Use `self.error_messages`.
`f` is before `r`.
Sometimes, we would like to call this  function with non-existent tables. For example, 'madlib.table_in_future' does not exist. But we would like to get the schema name, which is 'madlib'. The solution of letting the system resolve the name and determine the schema will not work.

If users specify the full name, our old function works well. But if users omit the schema name, the old function may return incorrect result. Is there any way for me to look up the search path? Then, I can return the correct result.
Consistency.

Enough said.
You should load these as resources, not from Files. So use EventAnnotator.class.getResource("/word_freq.lst"), which will look in "src/main/resources" while compiling, or in the proper location in the Jar file when we package things up.
Yes, it was not doing it at all beforehand (so, for example, a change in ACL IDs was not causing the object to be marked as dirty).
hmm.. that might surprise many users. How much memory do you save? The full json is already parsed and loaded into memory. only savings you is avoiding tuple wrapping of arrays?
okies!
Really, please get rid of this `~` shortcut. It hinders readability.
That's what I was thinking too ;-). I just feel uncomfortable with the note under `TISCreateInputSourceList`'s docs w.r.t to 120Kb usage...
show a view lines of sample data to see format, 
What's endog in this case?
If we have the different kernel forms, then it's simple to add. But I agree that that's for later.
Note that George already implemented batching/blocking, with large speedups. 

About FFT, there then needs to be a solution for evaluating at certain points or non-equidistant grids.
So, just hardcode search box and Google. So you can remove this.
For reference, here is an example `jetpack.yml`: https://git.squareup.com/square/risky-business/blob/3245775e3c7f9c58dea0673ac3358830ce2c546c/config/jetpack.yml
all the loggers should be
````java
private static final Logger LOG = ...
````
maybe a full stop?
The idea for the confirm link is to have it redirect to the video, but acknowledge that the video has been watched.
It might also be possible to embed the video in our site, so you can have a donate button right below the video. Perhaps in the next iteration?

If you had an explicit confirm link (like press here to confirm that you've read this email), I have serious doubts that it would be effective at all.
Changed it (not truncating anymore)
requires a few more words of explanation for what value is (e.g. how is the value "drupal" a schema, and what other values could one provide?
Are you sure codes are numbers? I thought they also could look like "E10000" or something?
nao pode pular linha depois da assinatura do método por covencao. sun..oracle.etc.
faça como o ```new SqlStatementWrapper()``` acima
pular linha a cada ```java .with(''  '')```
Fixed, and cleaned up the code as well.
I'm trying to speed up tests by removing all DB activity.  Without `create`, this test is much faster.

I'm trying to move to a point where all 'unit' tests don't require the DB at all.  Anything that does becomes an 'integration' test.  Not there yet though.
This is what makes the "jump" or link button in the audiocontrols work. When the user clicks it, it goes back to whatever page the current song is currently playing. This takes a few steps:

1) viewmanager looks for a viewpage who's playlistInterface() contains the currently playing track
2) viewmanager alternatively calls isBeingPlayed() on the stack of view pages
3) once it finds the view page that is being played, it shows it and calls jumpToCurrentTrack to scroll the view to the playing track

Basically if you look at how other views implement it, it basically needs to proxy this call to the proper playlist interface that is being used by this view. e.g. see DynamicWidget.

Also make sure to implement ::playlistInterface() and isBeingPlayed()
I think we want to keep this, I would propose instead you add a Path w/o any filter to the schedule only in the case of passThru=1.
Okay we can do in phase II, btw it starts soon.
jshint / jslint directive, they dont really makes sense if not everyone is using them, will take out
I use this in tests, I didn't want to override $_SERVER
More natural to use a Scala set in this class?
mutations2 for NOCLONE.  Remember!
Закрывать System.in нельзя.
Тут правильнее собирать пары методов.
@christianv +1 again on the sloppy-editing fix + minification find.
Should add an assert on HTTP result code - make sure it's a 200.
Okay, nevermind then, I'll land the commit and update it. I happen to have Apache running on port 82 (and no PHP on nginx), but as a reference for others, that shouldn't be there, while the short timeout is still useful.
and I should have made the previous comment down here.  I really prefer how ReviewBoard handles excerpts... it lets you select the region explicitly, and you can also expand things in context.
maybe but we will need for each category a name and a value. in a tuple we can store both and we use it like the locators when we need to access the values https://github.com/mozilla/marketplace-tests/pull/6/files#L6R57
Thanks, I'll remove the TODO.
Works w/o it, a few other changes as well https://gist.github.com/45e1beaa29c8a6ef8476
I'm going to remove this one.....maybe it's more of a project specific function.
Maybe keep the comment after the magic number?
sp/ Independent
you'll need to add docstrings.
It would seem simpler if we created some root folder for whatever we need to do in TEMP, and when we're done we'd delete the entire thing.
Leaving it out of this repo may be an option, but I would need to have another library repo so that the GroupNode class is available to multiple modules that (will eventually) make use of it.  Would you recommend two libraries (cloaking-device and drupal-cloak or something) or simply namespacing things within the cloaking-device library?
This should be closer to where it's used.
I thought about that, but have decided against because I didn't know (possibly *still* don't know) what would the final scope be.

I feared I had to do asynchronous calls (ie. descend here, ascend there), so a context object wouldn't fit.

I do think it's a good idea to have such an object, but I'd delay its implementation until I have a better picture of what it'll look like when all actions are in transactions. (ie, I don't want to restrict myself just now).
should it at least log here?
Same comment than here:
https://github.com/mozilla/addon-sdk/pull/347/files#r518701
This image overlap `cfx xpi` header and looks bad.
isn't prob_estimates a array you pass in? And I assume it's passed in by Java code so it's already allocated. Why you have another prob_estimates and allocate a new space to it? Did you still get the correct value in Java code? Am I missing something here?
Question: I thought we are not doing assertions on the pages themselves, only in tests, am I mistaken?
@shacker is there no way we can use `ng-switch` here instead?
If I'm not mistaken, with both `ng-hide` and `ng-show` it will still render the content, that seems a bit overload in this case.
wdyt?
@shacker @yuhunglin Totally, thanks for the suggestion & giving me feedback like this.
I'll make the commit soon.
The 2D interpolation here could be replaced with the warp function.
I think it makes more sense to make this into two lines of adding to the instance rather than crossing over two lines:
```ruby
@missing = "#{model_class} has a db column named #{@column} "
@missing << "of scale #{matched_column.scale}, not #{@options[:scale]}."
```

Seems to be easier to understand whats going on and follows the pattern of what we do elsewhere.
Cool, I'll scope them inside `checkLater` since they're not needed outside that scope
Can we get rid of these temporary Cartesian4s?
Fixed in 932627d2
Other than the possibility of putting in a `remove` function later on (not sure how easy that is since all image information other than pixel values is lost when the atlas is resized), this `update` function seems ok to me.
If it is used elsewhere (and I wouldn't be surprised if I did), then go ahead and make an issue, and we'll do it everywhere as you suggest.  This pull request already has enough files.
for the private methods?
Property is useful to indicate that it is an accessor method instead of simply a method that takes no arguments and returns a value (such as autorelease). That and synthesize is useful.
that event should be handled in onBackPressed.
text-align center? on the whole header??
@briancavalier Would you prefer:

1. then may be called multiple times on the same promise.
    1. `onFulfilled` callbacks must execute in the order of their originating calls to `then`.
    1. `onRejected` callbacks must execute in the order of their originating calls to `then`.

I prefer the predicated version myself because it avoids confusion about the relationship of multiple `onFulfilled`s to the one specific promise.

Side note: is it worth noting or clarifying that the defaulted `onFulfilled` behavior when that callback is omitted still happens in the order of its originating call to `then()`?
I did this refactor in a branch and then dropped it, so this is good!
This line and below `(x - h)`
Error messages should use `sprintf`.
Forget it, didn't see that it was already discussed above.
I haven't encountered issues running it this way (this is from the edits Mystcraft makes) and I think I did this because adding the nulls caused problems.  I'd need to check to be sure.
You really want to `return` here? I think you mean `continue`.
was this supposed to be an exported resource?
Allocate earlier so rows don't leak on exception?  Does this throw an exception if it fails?
I think you need to pull from master?
This JS code in a haml template makes me queasy. If we're going to drop the `require_tree` then we shouldn't need to place this outside of the `pharmacy.js` file.
You can see a diff without whitespaces with ?w=0 at the url.
You should probably change the XmlSerializer::objectSerialize method to take $xmlWriter as a parameter; that would be a performance improvement. Right now we create an XmlWriter for each object we serialize, which doesn't look right.
What's `AbstractMysqlAdapter`?
you should chain it with the previous calls.

And the default value should be ``false`` for BC.
Et dans quel cas ton `exists` est-il à `false` ?



Le 7 mars 2012 à 12:17, Fabien BROSSIER<reply@reply.github.com> a écrit :

>> +        holonymsForCanada.add("Québec");
>> +        EXPECTED_HOLONYMS.put("Canada", holonymsForCanada);
>> +    }
>> +    
>> +    private static Word subject;
>> +        
>> +    @Test
>> +    public void allHolonymsExist() {
>> +        for (String subjectStr : EXPECTED_HOLONYMS.keySet()) {
>> +            subject = Word.find(subjectStr);
>> +            
>> +            for (String expHol : EXPECTED_HOLONYMS.get(subjectStr)) {
>> +                boolean exists = false;
>> +                for (Word actHol : subject.getHolonyms()) {
>> +                    if (actHol.equals(Word.find(expHol))) {
>> +                        exists = true;
> 
> Je ne comprends pas, c'est justement le but recherché.
> Il faut que tous les assertTrue soient validés pour que le test soit validé, et si un seul assertTrue échoue le test échoue.
> C'est justement ce qu'on veut il me semble...
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/MattiSG/SemWiktionary/pull/13/files#r527924
I don't quite like this module name (see my comment about `NullPointerError` below). Some ideas: `core.error`, `core.segfault`, ...
Why mongo-converter and not mongodb-converter - seems inconsistent with factory and template.
Please remove the commented-out code here.
I think we still need a default-delay, for those cases where the message doesn't have the header. Otherwise the delay = 0.
I'm not 100% sure what is better. Will ask around :-)
Did you really need to remove this comment?
Not that I can remember off the top of my head.  I actually wrote this a couple of months ago.  Do you have a specific reason to use one or the other?
the list of optional dependencies should include :
- ptex
- glut
- glew (Linux / Windows)
- OpenMP
- OpenCL
- CUDA
- OpenGL
Quote examples should have been left in the windows/install-web page
The URL is not stored in mongo, should be generated ... or stored :s
Does the tests have a unit test for getting a deployment while upgrading it? The response will be totally different if the deployment is not in upgrade state.
*can not be d in* -> *cannot be in* ?
Tiny thing - but make sure you're indenting your HTML correctly with 4 spaces.
Do you definitely need to add ``orders`` to the context?  I would have thought they would already be there from the super call on line 164.
> So the interceptor ordering is just a recommendation in this case, right? I guess that's fair enough.

yes though in Java EE the order will be defined by the salient number and we will effectively be the last unless the user add its own purposely behind.
I think I forgot we had the helper methods for the urls, I agree we should try to use only one convention, and as you suggested   take advantage of the side effect that we can use the semantic named routes.

If you agree I can change it not to use the helper methods.
No. `peek` will execute next enumerator item, so it is not wise to do in cases when next item is going to execute some hard calculation. But we want to use `lazyness` of enumerators. So calling `peek` and then `next` will execute our code twice (or we can cache somehow each enumerator execution, so each iteration will be executet only once, but it looks quite awkward).

"since calling next? multiple times without consuming next_time will lose values"

Ehm. But how could it happen? We use `next?` in a loop soooooo how can we call it without executing block (where we call next_item)
I find multiple inheritance confusing. I say inherit from `CountVectorizer` only and make the `TfidfTransformer` a member. This class's `transform` can't be used on a sparse matrix like `TfidfTransformer`'s, so it violates the [LSP](https://en.wikipedia.org/wiki/Liskov_substitution_principle).
I don’t think `data-icon` attributes make any sense for presentation purposes.
Shouldn't there be code in `to_xml_node` to handle redacted relations like for nodes and ways?
Yes, definitely I need to take a look at some more examples of TreeWalkers to see how to use them.
getLandscape is a property accessor on mobile web. I'll add isLandscape and isPortrait for mobileweb. Fortunately we actually have a pending PR on it, so it's easy to make changes now.
We don't have these either. 

But explicitly referencing them is different from the pattern we use in h5bp. We have commits and discussion to back up our decision there and I'm confident our technique is correct.

Regardless of how they're included, we do need the actual image assets, which you could deliver if you like :)
This is in the type. Is this what you mean?
And besides, I'm not using the ambiguous relative import syntax, but the explicit relative import syntax. Yes I know pep8 explicitly discourages it too, but I think readability should trump here.
What about something like this then? Just seems like this code can be cleaned up a bit in my opinion.

    rawImages.forEach(function (img) {
        var lang = "default",
            file;
        if (img.text && img.text["@"] && img.text["@"]["xml:lang"]) {
            lang = img.text["@"]["xml:lang"];
            file = sanitize(img.text["#"]).trim();
        } else {
            file = sanitize(img).trim();
        }
        
        if (!widgetConfig[key]["image"][lang]) {
            widgetConfig[key]["image"][lang] = [];
        }
            
        widgetConfig[key]["image"][lang].push(file);
    });
So, which file in the packager would I have to modify to do this simplification?  config-parser.js?
Is there a reason we do this instead of just requiring the overlayWebView? It creates a new dependency from the framework to the webplatform that we never change this event.
this seems like the wrong place to do this
At this point you have already made a XHR request, why wait for making a request to check blackberry?
The first logic that happens  in the webworks.js should be checking this and firing the webworksready event.
No the contextmenu is contained in the plugins folder, and not directly in lib. If you want to move it to plugins go ahead, I just don't like it in lib.
(if (and (divides? 4 year)
            (or (not (divides? 100 year))
                 (and (divides? 100 year)
                         (divides? 400 year))))
  true
  false))

Nyt on parempi :)