labofsahil/github-event-dataset-2012 huggingface dataset:
If instead we'd like to have a way to conceptually refer to broader pipeline concepts such as Scene-Linear, etc, OpenColorIO provide a set of enums for many of these concepts.  OIIO could wrap these enums inside src/include/color.h for use in places such as here.   OIIO_SCENE_LINEAR, etc
Oh I see, you're using it as an equality check.  That makes more sense now.
I don't know... performance?  I just ported the existing behaviour.
you don't need true here, just for {
Let's test the context variable open_menu_trees here.  If it contains the id's for the two pages we put in the cookie then we know the unquoting worked.

Something like this.

self.assertEquals(response.context["open_menu_trees"], [1,2])
If you wanted to call parent class constructor, I have doubt that this would work because usualy you do it with `super`

```python
super(pydot.Dot, self).__init__(*argsl, **argsd)
```
This is weird - it says it's replacing `"mkdir -p"`, but it should be replacing `mkDirCmd`.
https://github.com/edwinb/Idris-dev/blob/master/src/Pkg/Package.hs#L109
In Ember (and most of JS), we treat `undefined` as not existing, so I'm ok with this. Also, in the odd case that you don't want to cache anything, you can return `undefined` from your property which seems like a small bonus to me.
Remove this step, and rewrite so you don't have to use it.
This method is unused, and should be deleted.
With the change above, this should remain

final String driverName = node.asString();
Unnecessary parens around the option.
может не +1, а +4 т.к. троеточие ?
I assume to -> subject ?
Remove it altogether or state the reason of comment out.
Just curious, why is the month 1 ahead and not the day? Aren't both retrieved in the same way?
We need to change the indentifier so that our l10n infrastructure notices the change and notifies the localizers.  See https://wiki.mozilla.org/L10n:B2G/Developers#Changing_strings_after_the_string-freeze.

(For instance, if the Spanish translation already has the `deleteThreads-confirmation` string, by adding the `2`, the localizers will see that a new string, called `deleteThreads-confirmation2` has to be translated.)
We will need the `shared/style/confirm.css` right?
Hmmm probably this is the misunderstanding. We had two types of IDs:
- `ts_` for `pending` messages
- `id_` for messages from Gecko
As currently we are removing everything related with indexedDB, there is no need to follow with `ts_` prefix.
After talking with Ayman final conclusion:
       + If we click 'Confirm' we will try again to send it
       + If we click 'Cancel' we have to keep message in Thread with '!' icon and, if user tap on message with error, we are going to show again the dialog of page 13 of Wireframes (same as when there is a sending error, this behaviour it's explained in page 6 of Wireframes, annotation 07). If we achieve to send the message we should update message in thread (removing 'error' icon) and sorting properly.
I've removed it because 'Edit mode' is not gonna be the same... I would like to have a 'clean' start point of code this friday for building new functionality on it.
I've added this CSS Query ;)
same below

if you don't agree with me or try to save some time this can be done in a follow up
No need for dead codes or if you have a specific reasons to keep it, add a comment explaining why.
That's a good point @arcturus , we can reduce the search frequency while typing.
Currently there are 400+ contact data in my phone and search speed pretty fast and it could catch up with my typing speed. (Except typing first number, it is apparently much slower than other situation),  and maybe it is good idea to let UX guys try the live search and  wait for their feedback.
please keep the `data-l10n-id` attribute
No no, I'm sad for #4529, but not for the test!
That's what I was trying to say with my broken english ;)
The problem is that background-size property as far as i know has not been landed yet in the shorthand syntax, only as a separated property.
Did you mean that @vingtetun ?
Reference the Bugzilla bug before this line
Better yet. If you can stub out a class in deployment/engine.py that refs our example but maybe just raises not implemented exceptions, but that'd be extra credit.
Similar to my previous comment (below): you need to make sure everything that is returned from `MakeBoxes` is a valid box structure (basically consisting of `...Box` function calls, lists, and strings. In this case, you want something like `RowBox[List["BaseForm","[",RowBox[List["12",",",RowBox[List["-","3"]]]],"]"]]`. You could construct that "manually", but I have see whether there is a way to apply the default behavior for function calls without using your definition of `MakeBoxes` for `BaseForm` again.
because you want true equality here
We should store all class/identifiers somewhere for easier management.
ダブルバッククォート（noqueue）
I'll fix this but typically when you contribute to a project you should use the documentation style that they've used in the rest of the lib, this looks really weird otherwise
Exactly, I wrote this to always append `,ca`. Basically it just narrows down the number of results returned by the geocoder and makes it a smidge faster. :) Cool?
Removed all profiling
Add Args and Returns sections.
用这个：path.dirname(p)
Should this method belong in model.py?
When would we use global instances? (especially of views?) The router would be creating/destroying views and would keep track of state without needing to expose anything.
It's not necessary for Fedora, and just exists on Rhel, so we may remove it from codes. thanks.
Ah, a typo ;( s/a/an/. thanks.
fail*e*d
you should use a single if for it, using ``&&``
Do we need special function and static variable to do simple comparing ? IMO it's a bit an overkill...
it is like that because the normalize method normalizes RC to uppercase, since it's an acronym, while beta etc are normalized to lowercase.
would this be better to try and just monkey patch in the cucumber load, rather than in the main app itself? thoughts  /cc @sarahmei @denniscollective @stevenh512 ?
Why is it here? Their modules should set this includePaths by themself
давай может генерить private_key всегда а в форме сделать check_box для поля? Тогда без доп аттрибута будет. к тому же is_private костыльное какое-то название  :(
Oof, yeah - that was a pretty big oversight. Should investigate to see whether the first condition is necessary at all, actually.
Is there a reason why it might not work? It can certainly be tested on a production server before deploying.
is 'match' the best name? I'm torn between feeling like it's not, but on the other hand grok uses it.
an extra `deactive` was firing right at the start of this test, which messed up the order tracked in this test..  so I changed the test to only care about the order in which windows that the test opens are opened, and not the order in which all windows are opened.  This way the test can run unaffected by other tests.
In fact I hoped that we won't have to normalize these properties with new cfx and would just pass `options`. Unfortunately these other options are needed by code that creates new loaders so they have to be exposed in some way and I really did not want to have yet another pseudo module for that (specially since I'll have to teach CFX how to handle it). I could though do following:

```js
loader = module.Loader({
   baseURI: baseURI,
   prefixURI: prefixURI,
   main: { id: options.main, uri: ...},
   version:  options.metadata[options.name].version,
   ...
   manifest: options.manifest,
});
```

I just hesitated to do that as I was not sure if some other properties have being used by some random modules.
maybe something like:

... with the web content itself (note: page JS can not interact with content scripts) ?
Well, that code behaves differently! Following will be broken. If we change call order we will have to update this.

```js
once('foo', foo)
off('foo', foo)
```
Capitol!
move header content to an include file?
can we init a criteria somewhere else than into the constructor?
Yes, I think you're right. Will modify the text.
In the sense that this test - which is extremely intimate with the parse tree from the YAML engine - can't run on the default 1.9 YAML engine, yes.

I don't think we should force the older engine, though.  This is just one test on the output structure, and is not critical to the success of the operation.  It really belongs more in the world of integration or acceptance tests than unit tests, I think.

The Psych engine does get a whole bunch of other testing around this work, though.  So, I think this is the right decision: a small risk if we don't test with Syck at all, but since we do...
This should include a message detailing what went wrong, and what needs to change to fix it.
We have no standard on Yoda conditioning. If you feel comfortable writing it, fine, use it.  This is not a blocker for inclusion of a PR.  Further, don't rewrite a standard conditional to a yoda conditional unless you're refactoring the code, and likewise, don't rewrite a yoda conditional to standard conditional unless you're the primary lead on the component (the one who spends the majority of their time in it).

I think these are fair rules.  And I, personally, feel like yoda conditionals slow down my reading of code, especially in non-simple conditionals.

With IDE's, github code review and unit tests, the focus should be on readability (write once then read and debug over 1000s of times).
Is posible use typehinting here?
`include` is considered a "language construct" not a control structure. So I think we're ok there to treat it as a function, as that is how it is being used in this form.
Why not using aliases as you already started anyway?
To drop all the items when the craftingwindow is closed
Does this blank line is isnecessary?
I thought that we might want these two things independently rather than opt in for both of them at once.
Since this is now the 3rd appearance of this identical code, you should put it in a function so you don't have maintain 4 different instances of it.
I think these DateTime.parse still doesn't quite have the precision that we need, the json output doesn't look quite right.
@harjis Onko tässä hanskattu se, että kassalipaan takana nämä tilit eivät ole pakollisia?
Nää queryt ei oo ihan samoja samoja (wheret ainki eroo vähäse). Query on kylläkin kopsattu tuolta pdf printtauksen puoleltal tulosta_vahvistamattomista_ostoriveista.inc line 423 alkaen. Tuon filun voi tietty rewriteä ja yhdistellä noita queryjä.
Line space before
If we were to do that then I guess Document would extend SuperMappedclass. Speaking of which I need to modify SuperMapperclass as that still has "nodeTyp = 'nt:unstructured'.
Use the full header.
#
# VSC-tools is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with VSC-tools. If not, see <http://www.gnu.org/licenses/>.
I'm not sure we should check _pre auth_ here... more "usefull" IMO would be just to depent on _post auth_, same way as "remember me" token.
You should only need to add this line of the source file contains non-ASCII characters. If you're not adding such characters, there's no need to add this like.
why the tmp variable?
Also, fwiw, the attribute is `input_type`, not `type`. But this is just a special `TextInput`, so no reason to be tricksy.
Need a double-colon to turn the next line into a code block.
Should og with log.log(Level.SEVERE, "text", e); to preserve exception. Also, who and why interrupts us, and why is return the correct answer ;)
Do we need this local variable? The view code refers directly to `@member` (most of the time, at least). Conversely, do we need the instance variable if we have the local variable?
Make it sealed, too
There is an XSS vulnerability here. `$_SERVER['PHP_SELF']` can be modified, for example calling:

    /foo.php%22%3e%3cscript%3ealert%28%27foo%27%29%3b%3c%2fscript%3e%3ca%20href%3d%22

Will set it to:

    /foo.php"><script>alert('foo');</script><a href="

This can have disastrous effects. Please use `$_SERVER['SCRIPT_NAME']` instead.
Yes, for now. The point is that the framework should be flexible and support and PHP class. However, the filter and operation need to match, so that both support the same class.
I don't really see why.
From the point of view that **{}** only denotes grouping/hierarchy, the only difference is whether the content of the group is 'plain' values or key-value pairs.

Another compelling argument is extensibility; ie to be able to go from

    foo {
         bar
         baz
    }

to 

    foo {
        bar = rab
        baz = bab
    }

Without having to explain to the (non-programmer) user that he has to switch from **[** to **{**, or even worse from **= {** to **{** as it is now.
что этот метод изменяет в классе?
This is a global iterate (which is genuinely horrible) - are you computing some kind of global sequence number? Take a look at the percentile ranking in the FieldAggregates for ideas on that
parse_response_as_json?
Thanks! It actually came because of I forgot to remove :smile:. Feel free to fix :heart:.
would it be simplier just to use double quotes instead of \' ?
_logout_locator = (By.CSS_SELECTOR, 'li[class="nomenu logout"]')
this sentence does not seem to make sense. "It acts like a dict of BrowserID well-known files" sounds better.
Name constants should be static const arrays like `LEICA_DESCRIPTION`.
Do you really need this because, damn, this is racy as all getout.  If you need debugging info or stats, they should probably come directly from the *internals* of the transport, I would guess, which means this is still not part of the (external) API.
Continuing on from here will guarantee an unpredictable and error-prone entry into the rest endpoints. We could respond with an error here (e.g., HTTP 500). But I don't think we should continue the chain.
The userids array should be uniqified
Is there a point where we need to return the deleted tenants? If not, I'd leave it out for now.
Would be good to add "(free for academic use)" after "commercial version".
> In DynamicRouter.php:
> 
> > @@ -131,9 +131,9 @@ public function generate($name, $parameters = array(), $absolute = false)
> >          if ($name instanceof SymfonyRoute) {
> >              $route = $name;
> 
> in this case we would still need to check if the locale is right or if we need the alternative route.

covering this now as well.
not quite happy with the method name ``getBestLocaleRoute``
A nitpick, but could you remove that space between the delimiter and the 'i' flag?
@dchill42 can you clarify that. I have added the $secure and $httponly params, is this ok or should those be removed?
Isn't `$type` always going to be 'text/html' here? Is that correct? (same on line 737)
Здесь у вас недочет: 

arc4random()%3

может вернуть только три значения — 0, 1 и 2.
В этой ситуации while будет отрабатывать до тех пор, пока количеством элементов в нем не будет равно проценту от  всех элементов DNA, т.е. через (int)round([DNA count] * percent / 100) итераций.
По условию, hammingDistance должен быть равен числу несовпадающих ячеек. Эта реализация выдаёт наоборот число совпадающих (проверка на совпадение).
Метод init - это конструктор класса, он инициализирует основные переменные класса, с него начинается создание объекта класса. Пэтому его желательно написать в первую очередь, а уже потом все остальные методы.
Use the materials counter, not a fixed value.
I think we should have a check to make sure the user is the owner of the offer.
Acho que vale a pena criar um partial para o form, que é utilizado tanto em new quanto edit.
I guess removing this check with continue *outside of if (infile.key == "id")* will cause segfault when trying to write powers[negative number].something. You have added fprintf("skipping") to if (infile.key == "id"), so you will skip only vector resizing, while still trying to write other properties to invalid vector index.
This line is slipped thought my codereview before commit, should be removed.
Isn't that a tabulation here ? ;-)
You should change `stream` to be `id` instead of `id<RACStream>` since all other cases where a stream of the same type was required have been typed with just `id`.
And override the equality operators like you did in GitObject?
I would need to be able to be able to compare two notes instance which would target the same blob.
Hmm, you might consider checking if the shake name is a number, and if it is assuming it's an ID so you can skip the extra API request. Looks like there are some shakes, such as [420](http://mlkshk.com/420), that are named with numbers, but since you can still refer to them by ID number, that should be okay.
or make it private until it's useful in other files/places
this really suggests that projs_all is a convenient variable in the Epochs object but not really an attribute of the measurement info.
If you move `projs_all` to a `_projs_all` attribute in Epochs than I can live with it.

besides this and my previous remarks I am relatively happy with this PR especially as the tests are good and fast to run.

What maybe bothers me now that we can combine Raw is that we could have done it by combining Raw first and keep Epochs untouched. Now unless I've missed something we have 2 ways to do the same thing which is not always a good decision.
Is there a command to use to test this? I've been doing "make test-doc" and "nosetests" when I make changes, but it would be good to know what other testing options are...
I like the feature for combining labels and the ability to save them directly, so a Label class makes sense IMO.
On Thu, Apr 12, 2012 at 4:51 PM, Julien Richard-Foy <
reply@reply.github.com
> wrote:

> > +   *
> > +   * JsArray(JsString("value"), JsNumber(123), JsBoolean(true))
> > +   * ====> Json.arr( "value", 123, true )
> > +   *
> > +   * There is an implicit conversion from any Type to JsValueWrapper
> which is an empty trait that
> > +   * shouldn't end into unexpected implicit conversions
> > +   *
> > +   */
> > +  trait JsValueWrapper
> > +
> > +  private case class JsValueWrapperImpl(field: JsValue) extends
> JsValueWrapper
> > +
> > +  implicit def toJsFieldJsValueWrapper[T](field: T)(implicit
> w:Writes[T]): JsValueWrapper = JsValueWrapperImpl(w.writes(field))
> > +
> > +  def obj(fields: (String, JsValueWrapper) *): JsObject = JsObject(
> fields.map( f => (f._1, f._2.asInstanceOf[JsValueWrapperImpl].field)))
> > +  def arr(fields: JsValueWrapper *): JsArray =
> JsArray(fields.map(_.asInstanceOf[JsValueWrapperImpl].field))
>
> I suggest you to remove `trait JsValueWrapper` and then to rename
> `JsValueWrapperImpl` to `JsValueWrapper`, so youll be able to get rid of
> those `asInstanceOf[JsValueWrapper]`
>
>
No this is the main idea of this implementation actually :D (discussed
several times with Sadek)
We want to have an implicit conversion to trait JsValueWrapper which can't
do anything, has no method. In this way, we don't fear the compiler will
resolve an unwanted conversion.


> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/playframework/Play20/pull/231/files#r676609
>
Hallo Johann,
      ich melde mich mal auf Deutsch (geht halt doch schneller  ;-) ).
      Ich habe noch nicht so viel mit git gearbeitet und jetzt hat er
      mir das .gitignore in den commit eingebaut.
      Wenn ich den commit zurücknehmen will, erhalte ich die Meldung:
      error: The following untracked working tree files would be
      overwritten by merge:
          .gitignore
      Please move or remove them before you can merge.
      Wie kann ich das lösen?
      Viele Grüße
      Stefan
        Mit freundlichen Grüßen
        Stefan Klein
        
            ________________________________________
             Büro für Softwaredesign und Entwicklung
             Dipl. Geogr. Stefan Klein
          
        
             Im Grund 10
             68723 Plankstadt
             Tel. : +49 6202 18568
             Fax  : +49 6202 26109
          
         EMail: stefan.klein@buero-sde.de
             WWW  : http://www.buero-sde.de
      
      Am 20.12.12 00:38, schrieb Johann Werner:
    
      In
Frameworks/Ajax/ERJQueryMobile/Sources/er/jquerymobile/components/ERQMHeaderBar.java:
      > @@ -1,10 +1,10 @@
>  package er.jquerymobile.components;
>  
> -import org.apache.log4j.Logger;
> +import org.apache.log4j.*;

      Please don't use asterisk imports.
      
        —
        Reply to this email directly or view
          it on GitHub.
You don't need to use exports.salsita here since the require() function lets the caller decide on the namespace to use.
1.9 hash syntax ftw!
Use the `::` shorthand here (remove this line and the line before and put an extra colon at the end of the sentence)
Please keep the sentence explaining you can extend the autoloader as it is still true
Please specify the location of the file with a comment, as discribed here: https://github.com/symfony/symfony-docs/pull/1531
Did you write these tests? Did you run them/do they pass? Or were they somehow auto generated?
I couldn't find anything. It looks like it's only available on QUnit.done() event handler, but that only fires after every test finishes executing. It does result in weird reports, but for some reason only in IE. Firefox and Chrome are reporting progress fine.
how about sorting the keys (desc) and doing first match, or easier, sort them asc and keep the current code (last match).

    proxies = {
      '/some/': 'http://localhost:8000',
      '/some/sub/proxy': 'http://localhost:9999'
    }

    /some/index.html -> http://localhost:8000/index.html
    /some/sub/proxy/index.html -> http://localhost:9999/index.html
It is bad practice to assign a new value to a formal parameter of the method.

It is better to use Collections.emptyList() to get an empty list since it consumes less memory and is faster.
К самому ядру эта и следующая функция едва ли имеют какое отношение. Я бы вынес это в отдельный файл типа util.
Пробел перед открывающей скобкой нужен (и двумя строками выше тоже).
Чо-то пробелов перед открывающей кавычкой многовато.
有 border 的 block => `.box`
沒 border 的 block => `.block`
Cool...yeh I had the code in another project so I didn't want to attempt to change in case I broke it ;)
I also do plan on cleaning it up so that there's no more implicit verbs, but if the verb is NULL it defaults to a GET.
please use translate keys
Makes sense... i did it in a similar way to previous comment. Undone.
@campbeb That it did not stay the same with your changes is no wonder, as you only changed the +1 side, not the -1 side of the equation (if I understood you correctly) That you change has fixed the zoom out problem in mf 0.3 is good news (I assume mf 0.2.4 just did not allow to zoom in that much). It will be easy to adapt the fix even if the +1/-1 one would have to stay for adapting mf and google.
I'm also a bit confused by this now. Judging by the previous code in the factory
```java
if ((conditionForWayCachesOrWayPoints || destination != null) {
                     items.add(navApp);
}
```

this is surely meant to be
```
return geopoint != null
```
, right?
wondering if you've seen this? ^^ :-)
The doc comment is wrong ;)
Completely missed this comment.  I will update this PR to be PEP8 compliant, but then address the remaining PEP8 issues in mplot3d separately.  In other words, I don't want to introduce new code with bad style.  Fixes forthcoming.
docstring is different to signature.
Fail. Should be `2e7531a201b5b8650dcd43681a832ebd`. This has an interesting side effect, though: it spins the upgrader into some strange loop. It starts the upgrade which dumps the `schema_signature` at some point from which there is not patch. The upgrader should crash and say the upgrade is not possible; however, instead viscously and continuously calls the upgrader, which responds with:

```
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Connection: close
Content-Encoding: gzip
Content-Type: text/html; charset=UTF-8
Date: Sun, 22 Jul 2012 03:41:17 GMT
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Pragma: no-cache
Server: nginx
Status: 200 OK
Transfer-Encoding: Identity

Upgrade osTicket to 1.7-DPR4
```

What do you think? Strange, eh?
Can we move the id to a data attribute ?
I can change the name to ``threeDotsWidths``, this is probably less generic, but that is what the object contains.
Or would you suggest another name?
This interface is not necessary, no?
please drop that comment
Yeah, I remember discussing this with Olli (which is probably why we have the same impl), but I don't see anything in the spec that would result in this behavior. Seems like DOM needs to have something more complex for getting a list of interested observers for a given record.
Trivial typo, `Temlate` -> `Template`
could this end up looping if for some reason there is an issue starting the app. and if so, is it really an issue? it shouldn't freeze the browser.
this is assigned the same way each of these three functions. If possible, it might be better to reduce code duplication by assigning this template variable once outside of the function? Just a thought
Spaces around the braces!
Are you sure ``$method`` has the correct type as ``*`` is not a sub-type of ``string``? Please also check line 66.
Previous version didn't work so well if this.textMesh was null :(
If you want to get the max channel number from a bud maybe this is equivalent 
````ruby
circuts = @bud.circuits.where("channel < ?", 32) 
circus.max{ |a, b| a.channel <=> b.channel } 
````
Если верить комментарию, то стандартное название такого метода init()

Далее, следует предположить, что "запускать" вы будете не только этот контроллер, но и еще какой-то. Вы будете дублировать данные? В ООП есть принцип наследования
There is still java code in the project, is removing the find's for java correct?
So it is consensus to keep the $?
Ditto here, it wasn't clear at a glance that the same function should cause all tests to pass. Maybe move curryMe2 up to the top and put all the expectations together?
Does this need to be public?

If so, the documentation needs to be improved to explain why you would use this method. And give more details about the parameters.

You might also consider a slight rename: `matchesInputName`.
Re-ordered.
You have problems with conflict with imported module? :-)
This is needed? send_update does not know how to serialize dates?

Anyway, does not this double-json-serialize then this value?
*Sign in* or *login*? We use login everywhere.
Groan, this is strange. This toggle effect on click. I was really confused. I would just show those links statically above the map. You do not need any effects.
Use jQuery `.each` to iterate over self.comments.
BTW, do we really need this short wrapper function? Why if you would simply give `validateCheckbox` as a callback?
Move `{` to the end of previous line. Please see how we are doing this elsewhere.
Typo: "sort .None" -> "sort. None"
'applicationSlug' and 'downloadUrl'
and is also not present on my copy of this branch...
Why _synchronized_ ?

I don't say it's wrong, but I'm not sure I understand your reasons. I have some ideas ;) but it would be better if you could comment about it in the code.
Please don't change version numbers unless Jenkins is running - it triggers automatic updates when it does work ;-)

Wanting to update the major version number for all these anyway, considering they're not compatible with the previous versions...
set_overlay_position(), which is public, calls this directly. Moving the checks there instead (and removing `else`).
Double class selector should be avoided
This function should be private ?
:: requires thinking, missing comma ?
Because in a few months I won't remember what ``c`` in ``c_step` stands for. I could call it concentrate.

(I just liked refine better because I didn't figure out what concentration means). 
And the code needs docstrings.
Is this a convention? I was thinking of changing the argument to event and then having a `censored` attribute that is the opposite of event, because this would make a lot more sense to me. But if censoring where 0 indicates censored is a convention then I won't change it.
I think I would just call it data, or endog :)

I don't like the ``t`` and ``e`` abbreviation for train and evaluation much. It took me a long time to figure out what it's supposed stand for.
把 -c这一行嵌入进来。
OK, will do!
I delete that line with my last commit. It was here by my mistake
If you make updates, I'd make this comment as a ```{# this style of comment #}``` so that django removes it from the output before it goes to the user. I like commenting stuff, but right now this makes the rendered output for the parent item look like 
```
    <!--we don't need to display the icon for every child-->
    <div class="pull-left icon">
```
...which is a bit funny?
Again, don't commit temps
In fact, better to not do System.exit here I think.
If you call a method that says it will "callHelpCommand", you wouldn't expect it to exit the JVM. Perhaps better to propagate the exception (which makes for nested exception handling in main, which will be a bit unpleasant...)
Any reason to keep the implementation of this deprecated method the same, rather than just delegating to the new (better) `assertContentEventuallyContainsText`?
Ok, I'm done reviewing. By the way, I think you're going to have a hard time merging this, unfortunately, because it conflicts with a patch that Shailen submitted. If you can't figure it out, I can help out.
Not since this morning. I was able to rebase the v3 from the master after your pull request. You can check it out.
I published the 3.0 also this morning.
Yes, but those post-logout actions should be in the logout callback instead of as a second event on the logout link. Also, I was more thinking of preventing a link from activating on click until the logout process is complete (see my comment below about changing the onlogout callback).
This._onCall should be always true here right?
Okay, I think I know what the problem is. Should have a fix shortly.
I won't bother fixing the doxygen _groups_ until we have a name since that should be fixed in all of them in parallel.
after fixing this to have s/aeocli/aeolus, I tried to run the (only) test, and got:

```
The /^I run "(.*)"$/ step definition is deprecated. Please use the `backticks` version
When I run "aeolus provider list"                              # aruba-0.5.0/lib/aruba/cucumber.rb:51


```
good catch.  We are not using self.id for anything in this method.
А положи этот класс в другой пакет (разный с самим ShardingProxy). И не будет работать.
http://docs.oracle.com/javase/tutorial/java/data/characters.html
Этого файла в pull request быть не должно.
Надо вынести в отдельный метод.
Т.е. поддеживаются названия файлов, начинающиеся с дефиса, у которых есть точка в названии? (расширение - это штука необязательная)
А как же опция -i?
Классы типа BufferedReader умеют это делать. Не имеет смысл это реализовывать самому.
Надо использовать версию конструктора, которая Throwable cause принимает.
Done: http://issues.fluidproject.org/browse/FLUID-4817
Doesn't seem like there is a reason to dup the uri? Since we end up overriding the original anyway..
Yeah, Selection lifetime == Inspector lifetime. The highlighter is not "in charge" of the Selection.
Please add spaces around >
ok, you have to log in to both the sandbox, and then your paypal *account* within the sandbox. If you aren't logged in to developer.paypal.com in advance, then the redirect from pressing the pre-approval button will send you to a page that says you need to go to developer.paypal.com to log in.
pep8 says there is no newline at end of file.
What do you think about images with a single channel in the 3rd dimension? I remember coming across a check for that in one of @ahojnnes's old PRs. I'm not sure that's something we'd want to encourage, but I'm curious how others feel.
Reference is noted in the docs:

```
366     .. [2] Ji Zhu, Hui Zou, Saharon Rosset, Trevor Hastie.                      
367            "Multi-class AdaBoost" 2009
```
typo: clustring -> clustering
Yes, I saw that; my editor remove it I don't know why...
Do not use unnamed function prototype.
What is this class for? It doesn't seem to serve any purpose
Récupérer les conditions générales d'utilisation (CGU) d'une databox
No newline added at the end of the file. Please update and resend.
This is not threadsafe.
Same goes for the indexCapacity variable.
I think you're prob. right, they are always ordered..
we should get rid of @num and same some space and efficiency if so, but separate task/commit.
It would be preferrable I think, to give the environment, rather than rely on the generated dali config file.. @richardkchapman  ?
Am not convinced it should be scanning for "ldapSecurity" like this..
But if the spill file was created in N different spills you may allocated N times too much space, or do the keys just contain the initial deduped rows?
If so I'll think some more.
The above 3 lines should be outside the ForEach loop.
This will only work if `root.count('/') < 2`.
E.g.

```python
>>> one, two = "a/b/c".split("/", 2)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: too many values to unpack
```
Agree.  435e853678313a43aa4770f9324961c9df8e57cd
I think you should add something like that to each file : 

```
/*
 * This file is part of the RabbiyMqBundle package.
 *
 * (c) Alvaro Videla <blablabla@blablabla>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
```

so that we know who authored the Bundle in first place.

And while refactoring, one should keep the original `@author` phpDoc tags while 
adding his or her, if necessary.
I expect we will eventually want topological sorting.  Also that pushes user-visible features/changes down into the DB layer in a way that will probably result in a lot of DB API changes.  So I'm mildly opposed to the idea.
Did you meant `content scripts` instead of `scripts`?
Its not the space per se 'model' just doesn't exist.

In regards to the intention - looks like HP-UX has an lsdev command as well, and that is returning an undesirable response is this correct? Or does this work fine on IBM hardware for HP-UX or something strange like that?

If its an AIX versus HP-UX problem then we should probably check on operatingsystem instead of model. I'm just trying to understand the combinations required for success here, while trying to avoid breaking it for another platform.
Should not be modified either
a simple assignment like this can be converted into an `attr_writer`
"Creates a <code>ServiceTimeoutException</code> with specified cause."
you allow for multiple birthdays here, but only ever allow for creation of a single birthday -- is merging all these dates into one setter/getter such a good idea, because of problems like that?
vprint_status
I think a space on both sides of `x` (here and below) is more readable, but it's *really* not that important.
They'll use PolylineCollection.add like billboards. I'll change doc.
`expand` is a strange name for this static function (but not the prototype version).  Perhaps naming both `union` is better?
We mean `@memberof WebMercatorProjection`
Will users ever construct these directly?  If so, why?  Or will they use `PolylineCollection.add` like billboards?  If these are not user-constructible, the doc should be `@internalConstructor`.
you wrote ``.., but I am not sure if we should provide so much configuration. '' my answer to this is Why not? If I have the ``pick a color'' setting, then any object in context (selected or on focus) should adapt to changes to the color setting. For example, if I have the mark wheels location, then I can select a its color, or if I have a wheel already in place, then I can select it and if I want to change change its color I can do that too.  What I am explaining is so common in UIs, then I am not sure why it needs further discussion, but if u want to have a meeting, then sure, when do u want to have it?
if u want to, we can have a design session in which we could try finding a better way to do this. U can share your desktop via skype and we can do pair programming.
http://blog.mirakui.com/entry/20100703/1278165723 によると vendor/bundle にインストールするのがお作法のようです。

このあたりは個々人の好みだったりするのでしょうか？
Same as comment above - Modify KS-Nook if applicable.
Very minor nit: Method summaries should use declarative verbs ("Creates," "Updates").
JIRA isue filed [TIMOB-8882](https://jira.appcelerator.org/browse/TIMOB-8882)
`Document` is a type of `Node`.
It looks like each of these do 3 query calls for the same element -- 1) here, 2) in the if check, and 3) in restoreContent or filterImage. Maybe do:
  var threshold = query('#threshold');
  if (threshold....) {
    restoreContent(threshold);
  ...
This should be escaped.
Right that needs to be clarified. Suggestions welcome
We'll get much better output, especially when assertions fail, if we use the testing framework's assertion functions. With unittest subclasses, there's self.assertTrue, self.assertFalse, self.assertEqual, etc. When using nose, there is ok_, eq_, and other assertion functions available from the nose.tools module.
жесть, Дима
я хотел разрешить `reject`, но его можно, конечно, вручную вписать
Hm... on the second look I see a way to re-adjust  this peice of code better.
Now <a href="http://d.puremagic.com/test-results/pull-history.ghtml?projectid=3&pullid=591">auto-tester result</a> for this pull is all red by this error.
I think you should comment out this line and insert alternative test `assert(s1[s1.opDollar .. s1.opDollar].empty);`
Yay, boolean to integer promotion rules…
Sorry, I don't understand what you mean. Do you mean calling `walkLength` where that's possible?
Sorry, where do you mean?  I added an if block so that it is possible to set a world to null here, which is why this is now indented.  I was careful to stick to spaces.
Done your suggestion of moving to the top of the file.
Based on https://github.com/hpcugent/easybuild-easyconfigs/pull/52/files#r2357131, what you actually want is probably:

```
self.cfg.update('makeopts', 'VELVET_DIR=%s' % get_software_root('Velvet'))
super(EB_Oases, self).build_step()
```

And then simply specify Velvet as build dependency. You should verify that Oases really doesn't require Velvet as runtime though (e.g. Velvet libraries).
Maybe rename discoverClasses to something easier to understand; discoverModelClassesInBundle?
why do you need the monitoring flag? does horizon not handle the case of an empty array?
you could fix the Code Style (CS) in this line to match the other lines. seems to be a typo.
Intentional; to indicate something that is not classroom space i.e. outdoor.
On 10/29/2012 10:03 PM, Jordan Moldow wrote:
>
> In esp/public/media/scripts/ajaxschedulingmodule/ESP/Util.js:
>
> > @@ -1,3 +1,15 @@
> > +ESP.ResourceIcons={
> > +    	'Computer lab':'!',
> > +	'LCD projector':'"',
> > +	'Sound system':'#',
> > +	'Kitchen':'$',
> > +	'!Classroom space':'%',/*outdoor*/
>
> Is the exclamation mark a typo, or is that there on purpose?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/learning-unlimited/ESP-Website/pull/425/files#r1974504>. 
>
>
you could validate the locale as well: DocumentManager::getLocaleChooserStrategy()->getDefaultLocalesOrder()
nm, I had a brain fart and didn't realize it was a reference tag.
again, if all you're doing is incrementing a counter, just increment it, no need for a method
Function has been removed in previous commit.
Extra `<` here
Ok! Right now S is just the covariance of lhs, it is exactly the case (x-mu)' S^-1 (x-mu) in 

http://en.wikipedia.org/wiki/Mahalanobis_distance

being mu and S the mean and covariance of lhs and x is a point of rhs. I will change it then 
so S and mu are computed over both lhs and rhs if lhs != rhs. In case lhs == rhs, should it
be like it is right now?
This is a question I have - Since the adapter was only introduced with 2.2 M1 -- Rather than deprecating, should I better just delete the  methods?
Don't you see my suggested code above?

i.e. don't try to cast (just return null) when skipping an invalid value.

What's the point of logging a warning if we then simply fail to cast and throw a CCE??
> We only merge pull requests if all tests are passing

Sadly this is not always true. We can keep it in though, because it's a good rule! :)
^ e.g. `2011` (arbitrary year - when we started services maybe), `5`th section, `1`st page subsection
So, if you are using this in a form, makes much more sense to have it in `UsersController`. API methods should be used only by client libraries, imo.
bah ... typo.. should be core, fixing
Had to add META-INF/services file in order for the plugin to be detected
lololo its wrong
use alternative syntax in views to be consistent with the rest, also single quotes for string and this should probably be a sub view
I don't have a preference either way - I'll prefix these since profile store/application data store are already prefixed
un pti retour a la ligne?
should change to https://
name r 'region' or something ?
Couldn't this be automated?
add another parameter to this function ``PersonalID_list`` which allows the users to specify the personal IDs that they want to generate data for. Have this default in the function definition to ``None`` in which case the script will generate output for all individuals. This easily allows the user of the script to do a test run where they only run on a few individuals.

This would look like the following:

```
def create_personal_results(mapping_fp, distance_matrix_fp, collated_dir_fp, output_fp, prefs_fp,PersonalID_list=None)
```

and then:

```
if PersonalID_list == None:
    PersonalID_list  = create_PersonalID_list(map_as_list)
else:
    PersonalID_list  = PersonalID_list
```
Ajax frameworks tend to add a few custom headers like `X-Requested-By` automatically. Prototype [reportedly](http://www.tsheffler.com/blog/?p=428) also adds `X-Prototype-Version`. Since we don't have any restrictions on request headers coming from non-browsers, I think it makes sense to have the same permissiveness for browser requests.
I think it needs to be ACTION_SAVE_IMAGE.
square brackets denote an optional property, but these explicitly state mandatory
Yeah, we've found out this already. Sorry I missed it, it's hard to concentrate when the holidays are so close. Maxim will send then updated fix on Jan 2.
до переменных?
Holy moly, that's a lot of code. I'm becoming less of a fan of gradients.
Needed to add the dashes (-) before content_type and object_id in order for the javascript to find it correctly.
The .jar file does not belong to the /Library/LaunchDaemons, which is a directory for launchd job configuration files.

A better place for the .jar would be in /Library/Application Support/Jenkins or something like that. If Jenkins can automatically re-install the .jar if it is missing, maybe even /Library/Caches/org.jenkins-ci
Personally, I would want to see this refactored to the Idea model at some point.
Idea.at[:idea][:image], Idea.at[:lakiluonnos][:image] or something...
Yes, it belongs to this onemenu template, has it's to have an other project disposition when we have a menu on the left.
Ok, I've got this working and have pushed the changes to my repo. I've 
decided to use GlassFish-3.1.2, since the coordinates for this 
distribution have changed since 3.1.1 and the older distributions.
On 12-03-2012 14:43, Aslak Knutsen wrote:
>> +<scope>test</scope>
>> +</dependency>
>> +
>> +</dependencies>
>> +
>> +<build>
>> +<plugins>
>> +<plugin>
>> +<artifactId>maven-antrun-plugin</artifactId>
>> +<executions>
>> +<execution>
>> +<id>setup-glassfish</id>
>> +<phase>process-test-classes</phase>
>> +<configuration>
>> +<target>
>> +<get src="http://download.java.net/glassfish/${version.glassfish}/release/glassfish-${version.glassfish}.zip" dest="${project.build.directory}" usetimestamp="true"/>
> Could we use a Maven Artifact here instead, to avoid having to re-download for each mvn clean ? e.g. http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.glassfish.main.distributions%22
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/arquillian/arquillian-container-glassfish/pull/17/files#r544454
My fault for this.  This shouldn't be here as it is not part of the API spec.  Was using it for tests
remove TODO if not needed.

We won't ever care for tabs so why this is relevant?
Lauseke (< 12 age 20) palauttaa jo sellaisenaan booleanin.
前一个我觉得还是加上好, 毕竟是同一个词, 读者读到都会这么想一遍"他们是同一个词", 高亮不会影响到什么.
后面一个我没看文义, 应该用括号里的中文的, 我等下改过来..
我觉得高亮主要是为了关键词更醒目, 当然也不能造成歧义, 是否真的是代码是其次. 
另外对于表示 Typeclass 的 Ord, Int 等等, 还有数字, 他们是否标记我也没做具体区分, 只是尽量往更规则靠拢了.