labofsahil/github-event-dataset-2012 huggingface dataset:
Тут происходит поиск символа ';', а не сопоставление с шаблоном. Лучше использовать функцию поиска http://docs.python.org/release/2.6.7/library/stdtypes.html#str.find
Makefile can be used for normal cleanup also, and who knows if we need to??
Apart from that, we planned to go for installation program, so at that we will need it.
what say ?
issue et description sont déjà dans form!
Fixed in 0064765, next version will include it.
Looks like it'd work, but I still think it's be simpler to do everything in a single getter method

so instead of doing

	[self createSafariAndLaunch:NO]
	[Safari isRunning]

or

	[self createSafariAndLaunch:YES]
	[Safari ...whatever]

you'd do:

	[[self getSafariAndLaunch:NO] isRunning]

or

	[[self getSafariAndLaunch:YES ..whatever]

The `(SafariApplication *)getSafariAndLaunch:(BOOL)launchSafari` method would look something like:

	-(SafariApplication *)getSafariAndLaunch:(BOOL)launchSafari {
		if(launchSafari || QSAppIsRunning(@"com.apple.Safari")) {
			if(!Safari) {
				Safari = [SBApplication do the stuff]
			}
		}
		return Safari;
	}

If not and you want to stick with this, I think the name of the `create...` method is a bit confusing. It's only going to *create* Safari once.
Fixed in 18e8bca
This is a debugging line. Should be removed, or updated to the proper display.
Hi Shay,

May I suggest using 2.3 version of assembly plugin, which is the latest one ?

HTH
David.
That works for me! Thanks so much.
Что делает этот блок кода?
Почему он именно здесь, а не в `this.link()`?
Well, I left the fog (as a library) untouched. No file setup is implemented, only mock data extractor and injector. Storing the data is the responsibility of the application using fog.
I added the file store/reload to the bin/fog application because that might prove to be useful.
1) Doh!
2) Good point!
"but it only work" seems to be an unfinished sentence.
So my wrapper around console.log is pretty much an empty function when the console object is not available. I realized that it is in fact available in IE8 and IE9 (I don't suppose we care about older versions than that!), but it really has to be "turned on".
Not documented, and isn't it a bit weird to have mutability mied with immutability?
Not used in this impl but needed in real FDs.
why val here?
I don't understan that comment. We don't expose convergence in any other place (except in the internal `SeenChanged` event. When there are unreachable it's never convergence.

By the way, can you change `seenBy` and `getSeenBy` to `private[akka]`. That should only be internal api.
moved this to Model from view (on type - pointer set)
card.refresh does a new db call, so this would kill the caching system :) I think we might want to hack deeper.  anyway.  not for this release.  I'll make a ticket.
This was adapted from the chunk_helper and made to work with new API.
"priliminary" => "preliminary"
From my experience it common to need both. Actually, I would say that most common is to ask to know where the b0s are. Maybe a better name is b0_indices and nonb0_indices. But, I strongly believe that those are both useful for understanding the data.
In this line and line 62 above, I didn't see the point of creating a list that would then be turned into a set. Passing a simple iterator to the set() works just fine as well.
hmm, looks to me like there are problems here:

1. *roles+*right+*default never gets saved
2. if there are multiple roles with any of these permissions, they will get overwritten (add_item avoids that)

my vote would be not to use the new api on old migrations except where necessary.
I think the simplest solution for now is to have the SCN client manage this and decouple getNextTimestamp to the NRV exchange. The client would do the batching and then call NRV once it reaches the batchsize or a timeout. We could then generalize the mechanism and apply it to NRV later if we need.
Should we really print the full stack trace here? This can spam and fill the log pretty quickly!!!
Is there a reason why true is changed to false?
My suggested changes aught to have worked the same. Pos show total written,
len giving total written plus what is left.

But we should at some point support open/read/write to get the response
data to the post which might complicate things.
Why not simply file_put_contents?
Please fix the indent here :)  Feel free to --amend your commit, since it's the last one and not yet merged.
Oh wait, there aren't any.  The MiAttempt Javascript model gives its virtual readonly attributes the following options:

{
    ....
    readOnly: true,
    persist: false
}
Because the default role is now :php:class, so they're equivalent. I think I was just confirming so.
oh, hrm. good point. `@cond.wait(0)` is a no-op, i *think*.
Eliminate any use of $Id$. We have stopped using this. Also get rid of the blank line above it then.
метод со строчной буквы должен начинаться
Ah yes of course. Is there a Rails helper to return the public images path? I searched without much luck, images_path was suggested years ago but that now returns /assets.
the environment variable `$PGHOME` is not set on my box -- Ubuntu 12.04 LTS.   I would guess same would be the case with in many other environments.  

So, I think pointing people to official postgre docs to get accurate information is a better idea?
:+1: like `other`
yes that's true, the commit I made only replaced previously present non-breaking spaces with normals spaces: 

f00b33e17334c92485f83313a82399d6e30aafe1 cleanup, replace non-breaking spaces with spaces
Could add the deprecation horizon, like with `RecordIdentifier`, right?
So, you probably don't need the "pull" part in a regexp match group. You could probably just match on "pull" and then write "pull" in the replacement text. e.g.:

    update = re.sub(r'pull #?(\d+)',
        r'<a href="%s/pull/\1">pull \1</a>' % project.repo_url, update,
One last question: Why did the bug only appear when compiling against the package object as a class files, but not as a source file?
I didn't test this out, but [from what](http://stackoverflow.com/questions/2701932/accessing-rails-flashnotice-in-a-model?rq=1)] [I could find](http://stackoverflow.com/questions/1996199/rails-flashnotice-in-my-model) the `flash` object is not accessible from a model object.

I've never seen a model object mess with the response side stuff before, but if you are ok with it I can go ahead and try to make the change.
It's the job of `__mul__` (`compose`, in fact) to discard identity morphisms, in this case.  As for `__eq__`, I believe I did some explanation in the docstring of `Morphism` (paragraphs 3 and 4).  Do you think I should add something more?
insert word References?
When $childRecord is an array, changes to it will not be kept. This is the main difficulty of implementing this feature.
if this were a property, we could check the generated iVar here to see if this value had been generated yet. If it has, return it. If not, generate it, set it on the ivar, then return it.
Last time I did that I right click on the project and enabled style for the project. I remember fighting with it a bit. I'll double check.
FYI- I am testing an alt approach that may be a nice balance between detect + performance.
Style: explicit check against `nil`
A fixed git is bad for portability and second, this has already been found out, so why not use it here again.
`EV_ERROR` declared in <sys/events.h> is overwritten by ev.h, I'm using it's original value there. Probably better add constant or define for it?
I agree--I think the best approach is probably to use a circular buffer to implement 
fixed size queues (similar to what the current implementation does for the mark stack. 




On Nov 8, 2012, at 12:25 PM, Kevin Sweeney <notifications@github.com> wrote:

> In gc.c:
> 
> > @@ -1650,6 +1670,45 @@ struct mark_tbl_arg {
> >  }
> >  
> >  void
> > +gc_mark_defer(rb_objspace_t *objspace, VALUE ptr, int lev) {
> > +    mark_queue_node_t* node =
> > +	(mark_queue_node_t*) malloc(sizeof(mark_queue_node_t));
> We need to think about refactoring this - a tiny malloc on every node overshadows any possible gains from parallelism
> 
> —
> Reply to this email directly or view it on GitHub.
>
Probably don't need but they ensure the elements will never be too close together at least.
Is this println intended for production code?
forgot semicolon :) did you run through jshint?
Any other element you can use here besides paragraph element? Just the anchor should suffice (although it might want some CSS changes); I'm not a huge fan of the use of the paragraph element here, as it isn't a paragraph (or even a block of text).
I can see how you might need this for implementation, but why is it part of the log interface?
> .data() tries to change return value to best variable type (ie. data-refresh="30" should return integer)

That is what is wrong with it :-)


On 20 Apr 2012, at 09:14, Senky
<reply@reply.github.com>
wrote:

> .data() tries to change return value to best variable type (ie. data-refresh="30" should return integer)
tbh, this really isn't needed since default is on the list case. An empty value will trigger the default case. Anyway, not necessarily something that needs to be changed, imo, but just wanted to point it out.
Here you don't cast `$user_id` but a couple of lines lower you [do](https://github.com/phpbb/phpbb3/pull/1100/files#L13R1792). Should be handled consistently.
No need for the global as you create a new instance of that object in the test.
Please add a newline before this, same for previous docblock
This was lost in the merges. See https://github.com/phpbb/phpbb3/pull/551/files.
done in a7dfc81
I cannot make them /* */ in the past ;) The lines are **deleted**
Fine the way this is done. Might be useful for us to also add a function IterIO.Http that has type HttpReq s -> s' -> HttpReq s'. What do you think?
ply and p1 and !ply:checkLimit...
wtf is p1 btw?
Note that not all instances have IDs -- only those that come from the top-level "spec" in application.json will. It might be better to use instance.instanceID instead.
Note for posterity:  this probably doesn't do what was intended.  This is saying that *all* lang bundles found in a shared mojit are really the "default" language and not the language they otherwise specify.  (For example, it's saying that lang/Foo_de.js in a shared mojit is really english, not german.)
The comment is saying what the code is doing, and so isn't very useful.  I prefer to -not- have these kinds of comments.  (Comments that answer "why?" are much better than those that answer "what?".)
If you think so, I'm fine with that.
If a dependency is missing you get ```<HybridHeightFactory(delta='level_height', orography='surface_altitude', sigma=None)>``` which looks good. I'd find an explicit call to ```repr(coord.name())``` more readable than using backquotes, but that's personal preference.
Any value, in fact, I can let it not initialized, but I don't like this. I add a comment.
Didn't you just tell me I should get rid of ARRAY_INDEX wherever I saw it, and now you add code to support for it. That's one way to keep the merges interesting.
I followed th documentation at http://south.readthedocs.org/en/latest/tutorial/part3.html#data-migrations
Is there a different documentation I should be following instead?
I doubt that "form=form" is more readable than just "form"
The point is to synchronize the values displayed in the gui with the values on 
the device. Since the global settings aren't part of the preset, they aren't 
automatically transmitted to the host at startup.

E.g., with the code as is, the USB/RP Mix is reported as 50 in the GUI.
Commenting out the call to request the parameter, the value is initially 
reported as 0.

I just noticed that there are REQUEST/RECEIVE_GLOBAL_PARAMETERS commands, but the
RECEIVE command doesn't apply the received parameters to the gui. I've made the
changes to do a REQUEST/RECEIVE at initialization and it seems to work. Please
review.
agree - revising
You could put that on two lines, it would increase readability IMHO.
I'm not sure if it's right way. `Fabricate` behaviour can change in the feature and take some shortcuts regarding firing callbacks and we don't control that. I'd rather use `Notice.create` here.
True. I only thought about auto-flattring when I wrote this. I'll probably change this to a list of timestamps.
You could also cast it via a double negation ``!!async``
Seems useful to me.
We recently changed the style guide on this one:

`( ":hidden" ),` => `(":hidden"),`

If a single arg is a string, no padding :)
I don't like the inference from `documentMode` to `column-count`, especially with a strict equality check. See [L720-L741](https://github.com/bsorbo/jquery/blob/51dd5db496cdb996fe2f5dc4bae611e024fefaeb/test/unit/css.js#L720-L741) for a better way.
This is one of those places where we make the exception, ie. `[0]` is ok
Pretty sure we don't need this anymore. This is a requirement of the past.
pretty sure this is wrong, the `[0]` should come after the split not before it, otherwise you're cutting `val` down to just the first character
can we overwrite the `EXTRA_DEFS` from the command line without a patch?
Preferred style is

```rb
system "make", "CFLAGS=#{ENV.cflags}"
```
Need to clean out the boilerplate comments.
This should change back to ```path('templates'),```
eigentlich schon.. ich kuck nochmal..
Caps Lock FTW!
I don't think it's common Ruby style to have newlines immediately after method definitions?
Connection calls not wrapped in a `use_cassette` statement go through, if they are, they either use a cassette or error.
" a project's ", not " a projects' "
fixed: 792b33a
Please simplify and or comment these lines :)
Use the name each instead of f.
This looks like it will always fetch `page=2`

Query strings are a lot less scary if you use the `qs` parameter: https://github.com/mikeal/request/#requestoptions-callback

```
request.get({
  url: url,
  qs: {foo: 'bar'}
}, function(err, resp, json) {...})
```
For my defense I would say it has been 4 years since I last did python. But you're right ;)
Let's not switch off iOS on production.
Change name to ``_onDocumentSaved``
So in the original case (cursor _after_ the closing quote), what do we return now?  Do we return generic info with the tag name but providing no attr name/value since the cursor isn't "in" any of the tag's attributes?
Is Sublime's statusbar the same height as ours? Text jsut seems a little tight.
I tried this out and KeyMap.translateKeyboardEvent() and using it wouldn't change this code since translateKeyboardEvent() maps non key commands (including esc and return) into their character equivalents which is the same as the keyCode. Essentially KeyMap.translateKeyboardEvent() === e.keyCode when their are no modifier keys pressed. Were you thinking of future proofing this code in case it did handle modifier keys (btw, find and find in files would need to be updated too)
Should we also translate it to について?
eine frühe Version von Brackets
Aha, interesting.  It seems more sensitive to the cursor position than quoted values, which is why I wasn't seeing it -- I'll file a bug on that.  But you're right, we can still merge the if's since appending the empty string isn't going to cause any harm.
It happens any time prefs can't be loaded. This could be the first launch, or any time the user has trashed prefs.
Is this `console.log()` call intentional?
I think it'd be good to add docs to _getMenuItemForCommand(), (a) to make it clear that it returns a DOM node and not the MenuItem object as you might think, and (b) to make it clear that it might return null.
How about calling `LiveDevelopment.init()` in `_onReady()` instead of in a timeout like this. Having a timeout here feels a bit odd to me.
Why not delete it?
Please fix the URL to this repository.
agree. hard set it because _if_ the bucky client can't keep up the server will perform better with the queue having less items naturally.
Indentation.

Should this be `IllegalArgumentException`? It's always legal to invoke the method, but not with these specific arguments.
Those are tests I planned to put in the mode controller, or a mode partial
value spec, and/or I can also add one here.


On Mon, Dec 3, 2012 at 8:41 AM, François Terrier
<notifications@github.com>wrote:

> In test/integration/org/chai/kevin/value/RefreshValueServiceSpec.groovy:
>
> > +	def "test refresh mode refreshes all fields"() {
> > +		when:
> > +		def refreshed = new Date()
> > +		setupLocationTree()
> > +		def period = newPeriod()
> > +		def mode = newMode("1", CODE(2))
> > +		def partialValue = newModePartialValue(mode, period, Location.findByCode(BURERA), DataLocationType.findByCode(DISTRICT_HOSPITAL_GROUP), 0, v("1"))
> > +		
> > +		then:
> > +		ModePartialValue.count() == 1
> > +		
> > +		when:
> > +		refreshValueService.refreshCalculation(mode, new TestProgress());
> > +
> > +		then:
> > +		ModePartialValue.count() == 8
>
> what about the ModeMap in those partial values? does it contain the
> expected stuff?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/fterrier/kevin/pull/267/files#r2289604>.
>
>
Right, but the auth token is not bound to the repo. The auth token is bound to the user account. It's why github makes you add some git config values during set up.
Could you explain this change to me please?
What if sites framework is not installed/used?
I don't understand what you're doing here. You're disabling implicit waits (I believe BIDPOM already has them disabled), and then finally your disabling implicit waits again...?
I like the idea of this but the execution scares me a little, I think it might be flaky and/or a maintenance hassle.

In the one place it's being used you could just check the visibility of the same element this is, but without having to jump through all of the logic to get there which may throw a ElementNotFoundException at any point.
Why not include this via the text plugin as a DOM fragment?  It's a pretty large chunk of HTML to have in code.
How does lint not catch this?!?!?!
Don't bother keeping this around.
use no underscores or underscores, but not both
The parameters passed into the two functions `createElement` and `getContext` above need some spacing around them.
this is a googleFonts module, so setting  `googleFonts = true` adds a list of fonts
I :heart: you for doing this
s/Timecode/timecode/ (lowercase)
what's happening here? the same viewer can open different PDF files... no sure how it will work
yeah i don't really like the current implementation. but i cba to redo it either at this stage. so reversing the iteration would seem to be the best option for now.
Should be uppercase `Response`.
Did we chat about having the monitor handle this server-side end-point?  So that there is only one thread running which can server STOP + PING responses?
参数中某位置只包含一个‘?’，则'?'后表示文件的版本
Nesouhlasím. Jak v češtině, tak angličtině, se běžně používají obě varianty.
This isn't actually correct, though. I don't want to be tied to Django from svn trunk, I want to be tied to Django 1.4, but it hasn't been released, yet.

The first line in base.txt is commented out, but covers the Django dependency. I was hoping that Django 1.4 would be released by now. They were hoping to release it last week at PyCon 2012, but I think hit a few issues. They're up to rc2 now, I think. Should be released pretty soon.

Given that, I think I want to just wait on this until they've done a release.
It is C++ so instead of bool return value I would expect that you use exception if something go wrong ( BTW this force you to have correct error handling, which is not your case now ).
fixed in 6817c28 42c2ceb https://github.com/theforeman/foreman/pull/185
Just checking - is ~> intentional?
Maybe: link below to schedule a vacation segment?
Explain what this is for? Do we even need it in a sample this basic?
Same comment about this code style applies (it's above).
private?internal?public?
When I build the docs, it gives me a warning here because it thinks `` :doc: is an option string`` - the easiest solution is to just move the "see" part to the second line (before ``:doc:``)
Taking in an array as the parameter restricts the usage of this function as it requires the user to compile up an array even there's only one string intended to be converted.
you don't need to call from the payload_class. You can just call before_perform with only the metadata attribute
Yes, that's a linuxism. That's it's best to add a build flag for BSD-ish systems. Make is not smart enough to auto-detect such details about the system.
So is this making the compiler or strict, or less...?
Either keep it on the same line, or use 4 or 8 spaces as indent.
This logic doesn't look right to me-- won't the message box pop up always with this change?

Should be something like:

    fServer = GetBoolArg("-server");
    #if defined(WIN32) && defined(QT_GUI)
    ... messageBox(ignoring....)
    fServer = false;
    #endif
Should this be `crit`?
Fix this formatting. ```<% if(showWaadSelector) { %>```
Hey, not my code :) sure, fixing it.
Would it be interesting to store the LagartoDOMBuilder into a ThreadLocal?
Everything is recreated based on the input ... so, I don't think that keeping the LagartoDOMBuilder will actually be of any help.

```java
	public Document parse(CharBuffer content) {
		initialize(content);
		return doParse();
	}

	protected void initialize(CharBuffer input) {
		this.input = input;
		this.lexer = new Lexer(new CharBufferReader(input));
		this.tag = new ParsedTag(input);

		this.buffering = false;
		this.buffTextStart = 0;
		this.buffTextEnd = 0;
		this.lastText = null;
		this.lastToken = Token.UNKNOWN;
	}

	protected Document doParse() {
		DOMBuilderTagVisitor domBuilderTagVisitor = createDOMDomBuilderTagVisitor();

		parse(domBuilderTagVisitor);

		return domBuilderTagVisitor.getDocument();
	}
```
Looking at the MS docs, it looks like this should build against all TFS client versions. Which versions have you built?
Maybe this should be an `option`?  (see `zzz.r`)
Can you recommit without the change in this line ? I can't merge only half of the code changes.
what do you think of something like  
```
def ...( ..., extractor = None)
...
if fd.endswith('.zip') and not extractor:
    extractor = extractor_zip
else if not extractor:
    extractor = extractor_tar
```
you're, seems
I like the idea of each widget having its own css file.  Can you put a blank line between each css class?
So we want a non-ascii str objects to render prompts impossible to draw?
done (i think)!
use guava hashCode/equals
This could be split into `./test/unit/compress/test/issue420.js` and `./test/unit/compress/expected/issue420.js`.
I'd like to keep the CSS served via Apache only. I'm going to try to find a way to declare a "dev" LESS variable so that all LESS files have access to that.
... if we keep adding inline JS blocks, mozilla.org will never be able to comply with CSP. Please don't do it :-/
Yeah, I was mixing the two sorting thing in my head, sorry.
same as others.
yeah they do, the difference is just in a query parameter for the search query
This is much nicer. w00t!
Which case is it? I'm kinda interested in more details.
Throwing an `ArgumentException` would completely defeat the purpose of that extension method for the use case it was intended for. Instead of the following code:

    int id = _verifier.ParseAndVerify<SomeController>(uri, x => x.SomeAction(Arg.OfType<int>())).id;

you would have to write code like this:

	int id;
	try
	{
		id = _verifier.ParseAndVerify<SomeController>(uri, x => x.SomeAction(Arg.OfType<int>())).id;
	}
	catch(ArgumentException ex)
	{
		var message = new HttpResponseMessage(HttpStatusCode.BadRequest);
		message.Content = new StringContent(ex.Message);
		throw new HttpResponseException(message);
	}

---

Maybe, our discussion comes from the fact that `ParseAndVerify` does too much? It actually does three things:
1. It provides a shortcut to calling the two methods `TryParse` and `Verify`.
2. If unsuccessful, hooks into the request / response flow.
3. returns the `HttpContextAction` as a `dynamic` for easier usage.

It could be a good idea to add a `TryParseAndVerify` to `ResourceLinkVerifier` (but not to any of the interfaces this class implements). This would basically contain points 1. and 3. Instead of throwing any exception it would return `false` in case of an error and return the `dynamic` as an out parameter.

It now would be debatable if an extension method for point 2 is still needed or if that is so trivial that it could simply be created by the user of the library.
Jo, předpokládáme. Potom v tý funkci může bejt nějakej switch na další kontexty, který budem potřebovat, ale zatím nic jinýho nemáme a s tímhle hodláme nahrát minimálně celej ten první kurz.

Želvička je includovaná z Lukášova kódu pomocí script tagu v recorder.html. Ta pak definuje globálně objekt turtle.
This doesn't follow the [PyroCMS coding standards](http://docs.pyrocms.com/2.1/manual/developers/contributing/coding-standards) please fix.
These 2 blank lines must be removed.
You should add `Content-Disposition` too (sth like I did [here](https://github.com/symfony/symfony/pull/2606/files#L0R103)) and maybe add a way to change the filename and the disposition.
Not sure it should be added with `x-sendfile` and `Range` though...
IMO it would be better to use integers, here and below, and also it would be more consistent with rest of Sf2 code.
I guess I will leave it for now
SegmentComputerFunctor -> SegmentComputerFunctors
Sorry, just one comment here -- can you make R the first argument, to match all the other IBA convention of results first, then read-only arguments?  Thanks.
I've left this as it was as you've fixed in 126. happy to change it if you would prefer.
Could be made a lot faster by cutting out this object creation, since Bukkit offers a way to access Blocks over world directly with ```World.getBlockAt(int, int, int)```, I would recommend using that.
The new version with min() makes more sense.
This needs to be done in the Runnable that runs following line 580. A Service.stop() implementation should never block the thread that invokes it (same for Service.start()) and the discoveryOption.cleanUp() impls are liable to do blocking IO.

The thread that's created "DomainModelControllerService ExecutorService Shutdown Thread" should be renamed to a more general "DomainModelControllerService Shutdown Thread". The StopContext.asynchronous() and complete() API is used for shifting blocking work onto another thread and then notifying MSC when all such work is done.
IMO, we should just log a WARN about it and skip injection on those fields, instead of the failing the deployment.
If you didn't mind, you could fix this specific issue and then raise a 
Jira for fixing them all in that manner but against 5.x?

On 2012-09-10T13:48:08 BST, Michael wrote:
> In qa/tests/src/org/jboss/jbossts/qa/Utils/CrashRecoveryDelays.java:
>
> >      private static void awaitReplayCompletion(int seconds) throws InterruptedException
> >      {
> > -        Thread.sleep(seconds * 1000);
> > +        Thread.sleep(getDelayFactor() * seconds * 1000);
> Possibly. But it is a coarse grained solution and the risk is we delay
> every test for the sake of making a handful of badly written tests
> pass. What do others think. Mike
> … <#>
> In qa/tests/src/org/jboss/jbossts/qa/Utils/CrashRecoveryDelays.java: >
> private static void awaitReplayCompletion(int seconds) throws
> InterruptedException > { > - Thread.sleep(seconds * 1000); > +
> Thread.sleep(getDelayFactor() * seconds * 1000); is it worth a search
> and replace for s/Thread.sleep/org.jboss.narayana.qa.Delays.sleep/g
> Then implement the sleep function in Delays to do a
> Thread.sleep(getDelayFactor() WDYT? — Reply to this email directly or
> view it on GitHub
> <https://github.com/jbosstm/narayana/pull/91/files#r1564602>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jbosstm/narayana/pull/91/files#r1565600>.
>
technically, you don't need this call if you have the next one
@zhoudi 主要是这个class的定义，其它的还不得完成，而且和UI有关，不太影响大局。
Я хотел сделать id, но потом подумал, что это несущественные данные, ради которых не стоит заводить лишнюю связь.
Ок, сделаю, если это не будет сильным замедлением для запроса выборки комментариев.
One of the chnages in the new mediadb is that it automatically creates a date index, so you don't have to list that here.  I think it is harmless to do so, however.
I need to pass an empty string when the field is null, so I cannot do the first suggestion, but totally agree with using a var instead contact.adr[i]. I'll fix it :)
All this mirror thing is cool for performance in your *specific* case but I think this should not land as a BB as if. A platform issue needs to be opened so the platform code will be fixed instead of relying on hack with hard to optimize effect.

Can you please open a platform issue describing the problem or remove the hack from this building block?
`cm_getContactData(options, callback)` (comma position)
self please
I killed the callback it used to do xhr logic in addition to parsing. hmm maybe I should just remove the credit its kinda confusing. I think I am going to use the js parser Fallen is working on anyway.
I think we don't need to wait for localized to assign the variable
className sound way better, I just thought that there is a reason why someone didn't use any before in this part of the project.
OK, cool then this is fine.
I think no, we can get this merged first.
Because 20ms is not visible by human eye -- anymore than that would.
Are we looking at the same files?

Doing a `grep -ir "ObjectSerializer" .` in `libphonenumber` yields nothing outside `demo.html`...
Docstrings or test failure explanations would be nice.
I couldn't figure out a way to easily implement this. There is no concept of notification groups in the manager side and this used to ask the count from the manager. However, I can't even remember what the use of this has ever been (even though I'm responsible for the API :S). Any ideas of what those users of this API are?
Ist bereits behoben
I think this is just to ensure that the final newline is present in the PEM file, yes?  It seems to me that when you control the input like this, that shouldn't be necessary - but it could certainly do with a comment, so that future maintainers can tell what and why this behaves like that.

(Also, can you pipe to stdin instead of using the temporary file?)
function(c)? ಠ_ಠ
looks like you messed up the indentation up there
we use 4 spaces per indentation
why is this hash in here?
I think this should be a lazy val since it gets called in the contains method.
Same issue as above: suppose you had a Tap that can produce a set of lines of text, and you want to automatically break them.  That's how cascading works now.  It just so happens that 95% of the time, you use Hfs.
Don't initialize the client until you actually use it - move this after the for statement.
Replace 8080 with Nginx::START_PORT
Instead, try "Name of the application to construct an error application for".
Follow proper Python naming conventions for this function name. Also, add an args section and a more descriptive explanation. Consider merging this method with the __ version.
Why not `$this->source->delete($key) && $this->cache->delete($key)` ?
Remove semi-colons please.  I know its a religious issue but for various reasons Obvious have decided to settle on no-semis as our official style.
What is your idea for what might go under "apps"? It seems that we would/should only have one app for a given project.
Could we get rid of this format change?
But if game developers update to new version of cocos2d-x, they will replace all of these projects. 
No one will use libExtension.vcxproj without v2.0.* . Do you think so ? Maybe I am wrong, if so ,please correct me. Thanks.
It is not for template inheritance, but downgrade some diagnostics about nonconformant code from errors to warnings. With the gcc in ubuntu 12.04, I got some errors as below:

../../extensions/CCBReader/CCBAnimationManager.cpp: In member function ‘void cocos2d::extension::CCBAnimationManager::runAnimations(int, float)’:
../../extensions/CCBReader/CCBAnimationManager.cpp:473:53: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
I think this also needs to get put into its own issue, and probably needs some more label-ish stuff to make it obvious what's going on. This isn't just for EC2 ;)
Could probably put the fields_count line before this one and then not use +1 on this line.
Rename this file to `udp_sender.c`.  Then we can also have `udp_recver.c` and `tun_recver.c`.
No this is the sourcepage. And I was wrong, it belongs in subdomains/prepage. savesimpleUpdate.php should be in subdomains/www/php - so what you did was write and it is in the right place. Let's keep it just in case.
I didn't want the rest of the application to count on bootstrap.pl to include these two modules, so they are included here. Maybe these lines should move to the inside of ```get_site_info```?
Para o teste pelo Selenium deve ser via script sim, pois a chamada automática funciona para testes via zope browser que são escritos todos dentro da class TestSetup(unittest.TestCase), (tenho quase certeza disto, pois escrevi o teste de forma que a função fosse chamada automaticamente e não funcionou).
O que ocorre também é que todos os arquivos iniciados com test_* são executados pelo ./bin/test .
psst....Regexp, not array. But same description applies.
I don't really understand this section, are you saying that all modules are expected to listen to the observer service to hear when to unload? Not using something nicer like waiting for an event from @loader/unload.
if you cannot reach BigTent, then I think it should behave like an absent IdP, and that means back to secondary. But if you *can* reach BigTent and Google itself is down, I think it's okay for us to say that you can't log in with your google email at that point in time. Falling back to secondary then would likely make things really odd (and would seriously complicate BigTent to the point of making things a bit too brittle.)

(As for other corner cases... yes I'm sure we'll see a bunch :)
nit: no need for a blank after the function name. It's no a noname one.
__whimboo__ wrote:
> Oh wow, a major version change. Do you know on which gecko branch this version is based on?

Regarding to [`application.ini.in`][1] and [`sbBuildInfo.mk.in`][2] it is based on Gecko 1.9.2.

	[Gecko]
	MinVersion=1.9.2
	MaxVersion=1.9.2.*



[1]: http://publicsvn.songbirdnest.com/client/trunk/app/application.ini.in
[2]: http://publicsvn.songbirdnest.com/client/trunk/build/sbBuildInfo.mk.in
yup, just need to remove all h1 tags.
Maybe `setParentSchema()` is a good name then, as you set a parent schema :)
It would be nice if there were a test that verified that we don't downcase now. It would have to be more of an integration test, get something from facter and load it in puppet so it goes through normal code path and verifty it comes out the same case on the other end
@vrthra It seems problematic to do this each time such as if puppet is installing multiple packages. Each `pkg refresh` invocation will cause the system to refresh catalogs from all publishers in the image. Are there typically many publishers? I would imagine a sysadmin would configure their systems to refresh catalogs periodically, e.g. once per day, using some other mechanism, e.g. exec resource with a schedule. But perhaps not? I don't know. Can you check with Ben and Stefan about this? I'd be keen to get their perspective
@stschulte Definitely, thanks for pointing that out.
We should probably make specialized `InvaderBullet` and `TankBullet` classes to avoid leaking data like this.
How about we change the syntax to:

```python
@interact(controls = dict(n = ContinuousSlider(), p = ContinuousSlider()))
def f(**kwargs):
   print n + p
```

which would be the exact same as:

```python
@interact
def f(n = ContinuousSlider(), p = ContinuousSlider()):
    print n + p
```
isn't this obsolete ?
I would just take this out completely
Agree. In that case, I'd still add a comment like `// str.trim() that works in IE8` - the regex is ugly and needs time to parse
You have a weird inversion of semantic specificity going on here. #container as an ID but .devhq_header as a class? `container` is just about the most generic name I can think of, and `devhq_header` seems pretty specific.
Please do not use y2internal
You should test for the existence of $node->tuv->seg.
Pubblicheresti la modifica:

```
<?php
return array(
    'modules' => array(
        'Application',
    ),
    'module_listener_options' => array( 
        'config_glob_paths'    => array(
            'config/autoload/{,*.}{global,local}.php',
        ),
        'config_cache_enabled' => false,
        'cache_dir'            => 'data/cache',
        'module_paths' => array(
            './module',
            './vendor',
        ),
    ),
    'service_manager' => array(
        'use_defaults' => true,
        'factories'    => array(
        ),
    ),
);
```
What is the difference with the original code?
bump -_-
we want to set this in the Listener please
```java
player.getCurrentItem().getMaterial == VanillaMaterials.BUCKET
```
Probably would have been better :P
-> `if ( items.length ) {`
Since timezone.now is the future please just import now() and do now = datetime.today on 1.3
This doesn't parse well.  I suggest going back to the original and just changing "I've" to "We've".  Otherwise I'd rather see the entire document changed to passive voice.
There are built-in date formats, or you could customize your own instead of providing a string to `strftime` -- I left [this note](https://github.com/SSundseth/haxxor-news/pull/1#discussion_r986700) for Stefan.
In case of updateLocation and some others your right, but in the case of create, remove, swap, ... it is an (un)assignment affecting content.
Cut and paste fail :) I'll update that.
I must correct myself, ``keys()`` in Python 3 does not return an iterator, but a so-called [dictionary view](http://docs.python.org/dev/glossary.html#term-view) (which is a new entity in py3k). However, what is said about those being a possible source of errors later in the code is still true. Besides not being copyable, those views also are not indexable [#fn1]_; i.o.w like iterators, they do not behave like lists.

Like tpievila, I too like to vote for removing ``list()`` here. My thinking is this: we here, at the source of some data, cannot possibly imagine in which circumstances this data will be used by other parts of a program. Therefore we should keep the data here in its native type, and leave it to the other code to handle it properly. If some code e.g. needs to index that data and failed because of the TypeError, that code is to be refactored to cast the data into a suitable format, and this change should be kept local.

I'm aware that Alexis announced an eclipse about this for now; am just thinking aloud ;) Comments welcome.

.. [#fn1] Fed the return value of ``keys()`` into ``PrettyTable()`` as column headers, and got ``TypeError: 'KeysView' object does not support indexing``
![](http://i0.kym-cdn.com/photos/images/newsfeed/000/173/576/Wat8.jpg)
same comment as above?!?
shouldn't it be ``<`` instead of ``<=`` ?
`połączenie kont`
Same here, it's default value of Buzz.
red.ht/jbeap-6-docs :-)

On 28 Mar 2012, at 18:40, sgilda wrote:

>> @@ -201,26 +201,41 @@ The README for each quickstart will specify which configuration is required to r
>> 
>> Review the README file in the root folder of the quickstart for specific details on how to build and run the example. In most cases you do the following:
>> 
>> +1. The command used to build the quickstart depends on the individual quickstart, the server version, and how you configured Maven.
>> +    * If you are running JBoss AS 7, it uses community artifacts available in the Maven central repository, so command line arguments are not usually required. 
>> +    * If you are running JBoss Enterprise Application Platform 6 and did not configure the Maven user settings described in [Configure Maven for JBoss Enterprise Application Platform 6](#eap6mavenconfig) above, you need to specify command line arguments. 
>> +2. The command also depends on whether you are deploying an EAR or a WAR.
>> +    * For a WAR, you can build and deploy the archive as one step or as two separate steps. See [Build and Deploy the Quickstart EAR or WAR in One Step](#buildanddeploy1step) and [Build and Deploy the Quickstart EAR or WAR in Two Steps](#buildanddeploy2steps) below for details.
>> +    * For an EAR, the build and deploy must be done in one step. See [Build and Deploy the Quickstart EAR or WAR in One Step](#buildanddeploy1step) below for details.
>> +3. If you want to redeploy a quickstart that uses a database, you should undeploy it first. This ensures the database is cleaned up correctly before the redeploy.
>> +4. See the README file in each individual quickstart folder for specific details and information on how to run and access the example.
>> +5. You can also start the JBoss Application Server and deploy the quickstarts using Eclipse. See the [Getting Started Developing Applications Guide](https://docs.jboss.org/author/display/AS71/Getting+Started+Developing+Applications+Guide "Getting Started Developing Applications Guide") for more information.
> 
> I don't have a link to the Getting Started there yet. Do we even know what the general link will be yet?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/167/files#r616471
koelncampus.com, please
right, there's many way we could optimize, but need to measure first
Do we want some fallbacks here? Maybe even just Lucida and Verdana like below on line 65?
Should be for _any_ type of track being added, regardless of origin (cue, plugin, etc)
Some more whitespace nits.

Extra newlines, and function named() {}) should be function named() {} )
"POST if"
1)  `textContent.indexOf(" p.") != -1` is sufficient for the if statement

2) you should leave the number of pages as a number without the "p" suffix
You’re welcome (I’m still called Roland, though ;-) )
If you try this, and base.shutdown is called immediately then it is not good to have it here. If base.shutdown is not called immediately after the server starts, then it should be fine.

I do not know how Jetty handles server.start() and that is why I can not give a specific answer before I try it out. And I wanted to avoid creating a test service based on this (I suppose you have some better way of testing it).
"add and remove forums and categories" would be better
req and res should have backticks
I'd use double quotes for these three. :)
I thought I added it already... Will double check
Shouldn't this also be calling on_push for each item?
почему он с маленькой буквы?
что здесь?? ааа...
давай разделим это на три функции.
`this` => `thus`
So do you have any questions/suggestions/ideas how I should proceed in order to get this merged?
I think we might need to tell people in the readme what lessc is. But you were going to have to add some more stuff to the readme anyway, so.
The docstring/comments should specify which fields are optional.
One thing worth mentioning: one of the reasons why this version just uses a bare atom is that the previous version used core.memoize (built on core.cache), and the performance difference between that and just using an atom was pretty huge. The atom-version is around 3x faster.

Normally, that's not a huge deal...but this code gets called *all* the time, thousands of times per catalog...so it ended up being a genuine hotspot during profiling. @nicklewis and I didn't investigate too much, but I believe much of the slowness was due to:

* use of protocols and/or multimethods inside of core.memoize
* use of LRU, which requires a fair amount of bookkeeping on each access (when, given patterns of access on this data, doesn't buy us much)

So I think the real alternative here, given that this is performance-critical code, is to use something simple and fast like an atom.

For other stuff, though, certainly using something like core.cache makes total sense (and in fact we should already be looping that library in via dependency now, IIRC).
This could read better as:

```ruby
if size && Refinery::Images.user_image_sizes.keys.exclude?(size)
```
What are `two` and `three`? No love for `four`? :)
The telemetry URL should be consistent with the rest endpoint (/api/user/id/password).
It could, I just wanted the code to explicitly reflect that the only people who can create tenant admins are:
 * a tenant admin for this tenant OR
 * a global admin

I know the isAdmin code does essentially that thing, but I found it mentally clearer.
I can change it if you want to
Should we be using # or : here ?
Should we allow for a global admin password to be changed as well ?
Why the check for range position? Could you add a comment
Yes, create a List<String> so all mob types can use it. For each one, .toUpperCase() it before it goes into the list too. The enums should just be a new enum, say, MCZombieSubtype { VILLAGER, BABY } which won't map to a bukkit enum, but will still be an enum. (If you'd like, you can also explore how to use an EnumSet here too, EnumSets are useful for things like this).

Anyways, that way you're never doing raw string checking, which is usually a bad idea. Strings should seldom if ever be used as a programmatic construct, unless they are being tightly controlled. Then, in the documentation, you can do StringUtils.Join(MCZombieSubtype.values(), ", "), which will always be up to date with all the possibilities.
стиль елементів прописаний в соната не ```xxlarge```, а ```input_xxlarge```. уважніше будь
That PR renames matchRequest() back to just match().  Presumably then this method would get renamed as well.
in this case we would still need to check if the locale is right or if we need the alternative route.
Please format this class correctly, at least fix indentations for us.
related to this issue : https://github.com/EllisLab/CodeIgniter/issues/1674#issuecomment-7466467
А как правильно нужно было сделать? обращаться к prorerty напрямую: [_DNA insertObject:[self randomCharacter] atIndex:i]; ?
почему -1?
при создании копии массива там 4 элемента
один удаляется (который совпадает с текущим)
и еще -1
получается 2 элемета, соответственно random() % countAtg никогда не вернет значение "2", и в мутации будут учавствовать только 2 символа с индексом 0 и 1
почему бы сразу не исключить текущий вариант из перебора? тогда не понадобится этот цикл
Formatted source a bit.
The `unlink()` function *should* be a permanent delete. We'll need a new `moveToTrash()` function for the non-permanent delete.
I realize you left these specs out because they are in conductor, but it is pretty cumbersome to have to go to another project to look at the examples of how to use this.  Perhaps you could just copy them in for now, and we can add a task for next sprint (unless someone can squeeze it in during this one) to split this out into a gem, so it can be shared asap.  That sound reasonable?
Is the `762` height vs `800` intentional? (I presume so, but thought I would ask just in case). :-)
I guess this should read `ChannelListDetails`. :)
test_eigvals
No need to check status_code, a PluginError will be raised on error anyway.
Exceeds 80 characters.
Should explain the feature from a user point of view, not about implementation details to use --depth.
typo: proximag --> proximal
167fafe5a49ed785b76f1893078bbac09295368d seems to be the source of the problem (bisected it)
you don't want the HIS in lower case?
Ok, I will move the circle-graph code to a function in mne.viz. Some parameters of the function should be 'con' , 'node_names', 'node_colors', 'node_plot_order', 'textcolor', 'bgcolor', 'colormap', 'colorbar', 'indices' (in case 'con' was computed using 'indices').

We should try to make the plot code independent from labels, as the nodes could be constructed differently (e.g. sensor space). Also defining the order in the example is quite illustrative, so I think we should have it there.
again please remove this line it's not needed and use body directly.
Took me like 30m sec to get what you implying so you mean i should just call:
<pre><code>referenceMap.put("isInstallationStarted", true);</code></pre>