labofsahil/github-event-dataset-2012 huggingface dataset:
Absolutely, we should not bother them until we have something reasonable.
I'm just more hesitant to patching our builtin ffmpeg than I used to be. We
need to get stuff upstream.

Note however. It may very be that we need to fully restart the ffmpeg
demuxer on a pmt change after open. The lib really doesn't like the idea of
removed streams. If that is the case we should have the demuxer start
returning EOF until all packets are flushed, then restart it.
On Nov 11, 2012 7:59 PM, "Rainer Hochecker" <notifications@github.com>
wrote:

> In lib/ffmpeg/libavformat/mpegts.c:
>
> > @@ -1542,6 +1579,9 @@ static void pmt_cb(MpegTSFilter *filter, const uint8_t *section, int section_len
> >          p = desc_list_end;
> >      }
> >
> > +    ts->cur_programid = h->id;
> > +    ts->new_pmt = 1;
>
> I don't claim that I have full understood this all. But it's not a bad
> idea playing around with the bits before asking the ffmpeg devs.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/1757/files#r2093008>.
>
>
`except ... as ... ` doesn't work in Python 2.5.
I'm really glad to finally have good tests for this function.
Bez takich proszę. Backtick nie działa z postgresem.
Am I reading this right as the maximum size of a bin is 1.5Mb?
__services__.keys()
indeed, sorry (even if it is true for ``Given`` too)
Geralmente arquivos de configuração de editores a gente mantém no `.gitignore` da própria máquina (senão teríamos que colocar de todos os editores existentes), então seria melhor tirar essa referência ao RubyMine daqui e tu rodar um comando ai para não adicionar em nenhum projeto seu mais:
```sh
echo "# RubyMine\n.idea" >> ~/.gitignore
```
What exactly does this do? How does `$tags[$_rit+2]` look like?
Looks like github.com is giving a different tab length than in Xcode. It's okay then.
I realized that bug today, and was working on a patch to fix it.... I'll get that in there.
oh! je vais cheker ca.
Whitespace only difference?
You can use `assert_nil` here.
Yeah, I'll put an API doc link. we should use more of those.
@carlosantoniodasilva you're right, thanks! :smiley:
Any news?
Anything else I can do to push it forward?
Well, no idea, I have this same config :D
Why `ClassSymbol`? Pickles can contain type symbols, right?
One will be a ModuleClassSymbol. (And have the MODULE flag set.)
Please use mapWithIndex, which is more efficient and clearer.
This should be a devWarning, I wonder how I missed it.
`assert all(len(line) == _w for line in data)`
The Wester test is factor(6x-10) = 2(3x-5). Any reason we can't just do `assert factor(6*x - 10) == 2*(3*x - 5)` for the entire H4 test?
`ode_sympy` should be `ode_system`
Wont this loose the second and third expression here:

`(u, u**2. (u,0,10))` for a parametric line

`(u, u**2, u**3. (u,0,10))` for a 3d parametric line
I preferred it the other way. I think it was clearer to see the tabular form of the data. I don't see what is gained by removing the regular spacing.
should be `from sympy.core ...`
"If you use C shell or tcsh you can"
self.data_blocks = [data.attrib['block'] for data in Data]
Should be "This is useful [...]"
Wait, why not just define the method `job_template` on Repository using plain old Ruby?
Достаточно добавить одну строку - //= require jquery.ui.datepicker
If you need the credit to be a number before validation, instead of ````before_save```` you'll probably want ````before_validation````
Should really declare the pk with the domain first, then the pair, then the id
Actually the wording here is fine, if it's ok with you it's ok with me.
Which operating systems have pids exceeding 32 bits?
The doc block isn't mine, ya know....
Should I do it regardless?
I don't have a problem with that either.
'ACTIVE_ERROR' is a code already used in the old login code. I will be reworking all errors to proper codes so they can be translated before I finish.
Please double check this, are you sure you don't need to prefix it here?
`$row` contains the user or group data. The user or group data is the row of the user's or group's entry in the user or groups table.
well its "location name" and "location URL" so i guess only the comma after url is needed?
Actually this should really not be in the bootstrap. The test bootstrap should be as minimal as possible. Ideally nothing but class loading is done here. We most definitely should not be instantiating some global event dispatcher during tests. It adds all kinds of hidden subdependencies between tests which is a really bad idea.
In the scheme of things I think this is unlikely to be a performance issue - especially considering that this comes before a IO over top to a database that writes to disk - which takes basically forever. We obviously don't want to be gratuitous about this, but as you point out - specifying the policy on one place is probably worth it at this point. We can always go back and optimize if it becomes an issue.
Ясно, тоест sql заявката връща времена в UTC, докато class методите се грижат да ги превърнат в localtime. Звучи смислено :).
made me think of blah.js.swp (vi swap files). do these get ignored?
В bootsrap есть класс, который позвоялет скрывать элемент. Нужно добавлять класс, а не юзать css
same issue as below
4000 is a "magic number". Why 4000? First, it should be captured in a constant, e.g. WAIT_TIME = 4000; Second, if this wait time is commonly used, it should be placed in Util or a shared area so many tests can access the same var.
On Wed, Jul 11, 2012 at 11:58 AM, lamblin
<reply@reply.github.com>
wrote:
>> @@ -3136,6 +3136,39 @@ def local_cut_useless_reduce(node):
>>              return [summed]
>>
>>
>> +@register_canonicalize
>
> Maybe we should also apply it in the "specialize" phase, if some CAReduce operations are introduced by later optimizations.
I hesitate - that sounds like an admission that all boundaries between
canonicalization and specialization have crumbled.
I think it should be OK to make this a real error in the current release, since there was no conection of Op.connection_pattern before.
Your code do not have an set_instead_of_inc option. So this branch will fail. Also, you can only when when x have 2 dims. Can you add this check?
You've fictionalized this comment -- fix or drop it.
don't use ``models.``, use ``db.`` everywhere
I will leave it for Kamil to fix, because another pull request of the same file.
should we use str() or unicode() ?
Like typedefs I guess. Does this then assume you know the exact size at compile time? Hmm...
This isn't true any more. The get_absolute_url() is non-DRY as it uses reverse()...
after reading this all the way through - I do think some very brief intro to the concept of URL routing is needed around here somewhere.
I'm not sure it's useful to implement _set_container in the base class, as the path seems different depending on stream.
Sorry, misread the diff again, you're referring to the bottom line. It's not needed here, but I wanted to ensure that model was available to all operations, as that's something that the SQLite backend has proved is useful (for example, if renaming a table involved making a new one, copying data over, and deleting it from the old one on some backend), and this is the level of API it's really hard to change once it's public.

We also might need the model for things like the database router, the tablespace, or some other DB option.
NULL values need to be allowed here, for both `gsim` and `number_of_ground_motion_fields`. Otherwise, this will break the hazard_calculation profiles for the other calculators.
It's really just a case of emphasis although I concede that so many headers in such a small file would indeed look a tad whack
This would be getHeadOfCue( 0 )->toInternalNode()->child( 0 )->toTextNode() because the TextNode is the first child of the italic node. Alternatively you can do italicNode->child( 0 )->toTextNode() because you've already retrieved the italicNode.
In JaCoCo API and EclEmma we consistently use the term "ratio" instead of "rate". I think this is the correct term and we should use it here in the configuration API as well as in the internal implementation.
TIL about indirect eval.
Why did you do this change?
And why do you care only depvar?  Is this same argument for numcategories, indepvar, too?

I agree the error message is not friendly, but this could solve part of the problem, I guess, so I'm fine with the unpleasant error message rather than adding a hack to check the type.
In the existing file, we already use tabs in the beginning for each line in plda's code. 

I agree it is nice to convert all these tabs to spaces. But I think we should do it in a separate thread. 

For these newly introduced tabs, I already changed to spaces.
It works, but for SQLer '<>' is the standard non-equal operator.
I don't see that anyone the accounts-qq packages reads Meteor.accounts.qq._options. Can we get rid of this function?
Can't use `riak/CURRENT` as this will break as soon as a new version is released causing panic and terror to flood the issue tracker.
"./autogen.sh" should work.
Inconsistent whitespacing here
Tu devrais supprimer ce code commenté
Yea my intent was to handle the unique checks and not effect rest of the errata saves. Good to know that call if safe. I'll trim this out.
Cool, I'll get on that. Thanks!
a better description would help a lot when debugging
You're adding 3 lines to save 3 characters. Seems like a waste to me.
maybe move the check before the current_value line, so current_value is filled for nothing => avoid possible mistakes
+1, but:

* didn't we decide against handler wrappers?
* these issues don't need to be resolved in this PR
oh noes, this namespace is already used to admin app stuff, would definitely be bad :)  maybe /info/ or /redir/:appid ?
I don't have a number pad on my keyboards. Would the num pad work? If not, we should file an issue and add a TODO.
Should these have prototype.parentClass and prototype.constructor set too?  (I'm not actually sure I understand what function .constructor serves, but parentClass at least seems useful).
Why not also apply the adjustment to the horizontal scroll position? I know it's not nearly  as common, but you've already collected all of the info you need to do it.
It's a little wordy, but since it's a tooltip, I'm ok with it. I'll make the change.
I left it out for now. It does not seem particularly obvious that getNativeBracketsDirectoryPath here actually points to the test/ path.
Try adding the following here, which effectively invalidates our cached Cinv.d, so that updates to C are correctly propagated to a new Cinv.d:

getData(*begin());
I think this is ok for now, but we eventually might need to clean up high-frequency/core services like this not to save large documents multiple times.
I usually like putting pass on a new line
These should be # comments rather than string constants.
It's a scale parameter. Unfortunately, for the Pareto distribution the order is scale, shape, whereas for other distributions it is shape and scale. Annoying. Maybe we should override the order.
Yes, that's an extra comma.  But are you sure you can't do it without ddply?  It may be that I don't understand your data structure.
It's not the good I18N.
用一個就好了
Forgot to remove it. I was testing something.
You can register and login? I cannot :/. For starters it raises "settings.DATABASES is improperly configured. Please supply the ENGINE value. Check settings documentation for more details." error again
I really do not understand why is this necessary. Is there really not any other way? It really seems strange to me that we need to define such function ourselves.
Decide. Or the links are green and there is no doted line bellow. Or links are gray and we use dotted line.
Why did this just get blocked out?
You can just delete this comment entirely if the "google" global isn't being used
Don't need prefixes on border-radius or box-shadow
I'd add some braces in here, even though it's single-line.
unset 与 set 对应。
Maybe I'm missing something but this looks exactly the same as the equivalent for folders.
除了gcc，clang、icc等编译器需要类似选项么？
don't know much about windows - but should we be splitting on `seperator` here?
I find this difficult to work through. If we I remove this method, then I end up with two traits for Sesame and Jena such as 

```
trait JenaSPARQLPure extends SPARQL {
  type Query = JenaQuery
  type SelectQuery = JenaQuery
  type ConstructQuery = JenaQuery
  type AskQuery = JenaQuery
  type Answers = ResultSet
  type Answer = QuerySolution
}

trait JenaSPARQL extends SPARQL {
  type Query = JenaQuery
  type SelectQuery = JenaQuery
  type ConstructQuery = JenaQuery
  type AskQuery = JenaQuery
  type Answers = scala.Iterable[Answer]
  type Answer = Row[Jena]
}
```

The JenaPure Answers type built with `Row[Rdf]` is presumably what we want across Jena and Sesame, so that methods know how to get values out of those. But if we do things as above we then get a split of implementations using those two traits. One of them returning, as most people are usually interested in the `Iterables[Row[Jena]]` the other returning the underlying objects - while there are any.

The solution could be to add add to `SPARQLOperations` something like 

```
  def Rows(solutions: Sparql#Solutions): scala.Iterable[Row[Rdf]]
```

Perhaps that is the way to go if that could be imported implicitly into the classes using it (which is something I had thought of at one time). I'd need to check if this is possible. Well I made a commit to see what that would look like here: https://github.com/bblfish/banana-rdf/commit/7b78682d0a2fd4a0a47787d16a3feca1d50b7ce8 Not all tests pass, because I did not want to work much more on that before getting some feedback.
This command is never actually called.
Can't we just say 0x00 in C# and then  the system automatically increments it? or is this for readability?
Yes it should be  'data-pa..., 25'
In regards to "productId" - was that already done somewhere else?  From observation, and what can be seen in just this file, the convention has tended to be underscore notation for expressing IDs. I.E. "product_id"
True, added back. But that does not solve that foreman problem.
I don't think these url patterns need named since they all point to different views.
What about


    regexp_decimal = Regexp.escape(decimal_mark)
    regexp_format  = if formatted =~ /#{regexp_decimal}/
          /(\d)(?=(?:\d{3})+(?:#{regexp_decimal}))/
        else
          /(\d)(?=(?:\d{3})+(?:[^\d]{1}|$))/
        end

    formatted.gsub!(regexp_format, "\\1#{thousands_separator_value}")

?
We can just leave out the observable stuff for .net 3.5.
I feel as though HeartbeatsPerKeepAlive is too wordy =/, as for the uint piece, I can't think of a reason not to.
I've been changing this file, but in the process those changes weren't needed so I reverted back. Just that single whitespace stayed removed at the top:)
Trailing whitespace was added here. Please remote it.
if (!LockScreen.locked || detail.type !== 'desktop-notification')
        return;
On 26/03/2012 22:16, Ben Francis wrote:
>> @@ -2,7 +2,7 @@
>>   <html>
>>     <body style="background: black;">
>>       <script>
>> -      document.location = 'apps/homescreen/';
>> +      document.location = 'http://homescreen.gaiamobile.org/';
> Because homescreen should be loaded from homescreen.gaiamobile.org not gaiamobile.org - permissions granted to homescreen.gaiamobile.org don't apply to gaiamobile.org as far as I know because it's a different origin.

I mean, I'm not against this change but this page is used only for 
compatibility with the web browser and online demo. Why do we need to 
change it?
on **a** cosmological model?
Don't do this, set it in the controller. With this you can post comments as any user you want.
I would think so. I presume that's what happens on youtube and the likes.
I'd be pretty pissed off if I deleted my acct and the service essentially
kept all my videos with no way to now delete them.

I guess we should take a call on how to do that, but we can leave off the
destroy dependence for now.

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Mon, Nov 19, 2012 at 2:14 PM, Luke Steensen <notifications@github.com>wrote:

> In app/models/user.rb:
>
> >  class User < ActiveRecord::Base
> > +  attr_accessible :name, :email, :first, :last, :created_at, :provider
> > +  #@user.viewed_videos will produce videos VIEWED by user
> > +  #@user.videos will produce videos UPLOADED by user
> > +  has_many :videos, :dependent => :destroy
>
> Bad idea, someone deleteing their account automatically takes all their
> videos with them?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/11/files#r2172076>.
>
>
Shouldn't this be !defined(USE_IPV6) || !USE_IPV6 ?
4 spaces would be misleading as it would look like it was within the logic of the preceeding line.
you are right. I was wrong and over-enthusiastic to get rid of NULL.

How should I proceed, withdraw and retry?
On 27.05.2012, at 04:22, Jonathan Wakely wrote:

>> @@ -5340,7 +5340,7 @@
>> 
>> \pnum
>> \enternote This constructor allows creation of an \textit{empty}
>> -\tcode{shared_ptr} instance with a non-NULL stored pointer. \exitnote
>> +\tcode{shared_ptr} instance with a non-nullptr stored pointer. \exitnote
> 
> I'm not sure I agree with this change, shared_ptr *never* stores `nullptr` because you cannot have `shared_ptr<nullptr_t>` so it doesn't really make sense to say this constructor allows an instance to not store nullptr. I would suggest "non-null" (in lowercase) or "empty `shared_ptr` instance with a stored pointer that is not equal to `nullptr`"
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cplusplus/draft/pull/16/files#r886020

-- 
Prof. Peter Sommerlad

Institut für Software: Bessere Software - Einfach, Schneller!
HSR Hochschule für Technik Rapperswil
Oberseestr 10, Postfach 1475, CH-8640 Rapperswil

http://ifs.hsr.ch http://cute-test.com http://linticator.com http://includator.com
tel:+41 55 222 49 84 == mobile:+41 79 432 23 32
fax:+41 55 222 46 29 == mailto:peter.sommerlad@hsr.ch
I think this should probably say "Update your position" instead of just "Update position"
Haha oh man you should not ever touch params in the abilities... 
.. I think you missed my suggestion.

can :create, Discussion do |discussion|  
      user.group_ids.include? discussion.group.id
end

or even
can :create, Discussion, group_id: user.group_ids
>
> I'd like to understand why we're doing "class << self" rather than the
> previous self.x method names

I needed a class << self block in there to be able to use alias_method 
for #bootstrap, a class method, and with that already there it seemed 
odd to have both types of syntax for declaring class methods in place.

It's largely about mimicking inheritance for resque and thin pikelets, 
which have to be referenced with class methods rather than instance methods.
On Thu, May 31, 2012 at 8:19 PM, Brian E. Granger
<reply@reply.github.com>
wrote:
> OK, I buy that argument, can we change the rest of them to this format then?

Quick note: let's check that sphinx can handle files with spaces in
them.  We'll very soon want to include the notebooks in the built
docs, and I'm not sure sphinx is happy with spaces.  In my recent
experiments with Latex I had to rename a notebook that had a space in
it b/c LaTeX barfed all over the spaces.

So before we create notebooks that can't be converted, let's make sure
that the downstream tools will be able to handle them.
might want to also add a typesafer

   @SuppressWarnings("unchecked")
   @Override
   RestContext<VCloudDirectorClient, VCloudDirectorAsyncClient> getProviderSpecificContext();
This is now included in PR #952.
+1 for putting it in it's own CSS file! By convention, we keep all CSS properties listed in alphabetical order. It is almost alphabetical, but I see some exceptions in this file :-)
done: http://cl.ly/image/1Y0n2b3H2a1d I'll ammend the patch
So, the reST way to structure this would be:

    The KB article should have the following wiki syntax structure::

        =Category 1=

        ==Reply 1==

    ...

I'm not sure it matters much, though, since we're not doing documentation extraction. But ... figured I'd mention it in case it was interesting to know.
I'm glad you fixed these and explained the whole logging thing to me. It's been something I have been meaning to ask about for months now.
That was stray debugging, removed.
you could do `%(locale)s`
Can an email be sent if the `to` isn't set? Looks like `msg.deliver` would fire w/ `msg.cc` or `msg.bcc` but w/o `msg.to`
I don't think you need this thead.  Use th for the first column's cells instead.
success_message = "Password successfully updated.  Now you can log in with your new password."
Is there reason why it goes to cout and not cerr? I think that for CLI it is common to write problems on STDERR. And one more question comes to my mind, is possible to get from libzypp some kind of reasons? If so, then it would be nice to write it to user, so he can get idea what can be wrong (e.g. unknown locale? ).
Could you give a brief use-case of this stuff?
хм. я навпаки звідси хочу зайву інфу про знижку забрати. а ти ще на квиток звязок додав. без цього ніяк?
@bschussek what was the reason to bubble the error for complex forms ? People complained about this regularly because they don't understand why the error appears at the root
you don't need the extra braces around each condition
The example in `Before` and `After` will probably confuse people that use the `else` part of the condition. So it should make clear that one must check `isBound` before falsely adding flash messages about an invalid form (that is not even bound).
the component requires ``symfony/config``
Instead of using a ``$code`` variable, I would use ``return 1`` here and ``return 0`` at the end
well, the classes will not be a big issue as the prefix will not match other classes. But the function file is indeed an issue, as it will be loaded on each request without a way to remove it if you know you will have intl (for people keeping the function_exists check in their app/autoload.php, the difference will only be a require_once)
`public` should not be specified in ifs
It's part of the class once the mixin has been added. I do need to
instantiate the right class though.

Sent from my iPhone

On Dec 6, 2012, at 4:34 PM, Adarsh Pandit <notifications@github.com> wrote:

In spec/models/group_private_messenger_spec.rb:

> +
> +    help_out_text = UserPrivateMessenger.new(invitation, sender).get_help_out_text
> +
> +    help_out_text.should == "out #{invitation.event.owner.name}"
> +  end
> +
> +  it 'return me out when the recipient is the owner' do
> +    invitation = build_stubbed(:invitation)
> +    sender = build_stubbed(:user)
> +    invitation.invitee = invitation.event.owner
> +
> +    help_out_text =  UserPrivateMessenger.new(invitation, sender).get_help_out_text
> +
> +    help_out_text.should == 'me out'
> +  end
> +end

Here's another strike against use of the module: we're testing it inside
group_private_messenger_spec.rb which seems to cross county lines.

—
Reply to this email directly or view it on
GitHub<https://github.com/yammer/sched.do/pull/238/files#r2343635>.
We should name this logger with __name__
sorry, i misread. =)
Remove this check.  TTL can be null.
This stuff is implementation details - let's keep it out of the abstract ImageCache class and put it in ImageCacheImpl.
Put this on the super class (CRS).
most likely, the IDE's diff showed just the 2 line change..
1. changed netbeans.version property to RELEASE72
2. added module scala-maven
Is casting to a list here necessary? ```assign_plugins``` already casts the placeholder argument to a list; so it could be removed from here and left to the internals of ```assign_plugins``` to do the necessary work to massage a placeholder queryset into a data format it wants.
this whole if,if,if,if logic here should be wrapped at the very least into if,else if, else if, else. but probably should just be two nested if/else checks.
why comment those lines out instead of removing them? And why remove them in the first place?
Side effect of the SQL query : modified time of subtags synonyms is not updated. Don't know if it matters much...
oups... milles excuses... c'est corrigé.
Logging configuration should have these defaults and not hard coded values.
There's no need to test completely custom functionality here. Custom widgets don't have a built-in concept of destroy, so there's no point in testing that a custom destroy does what a normal destroy does.
Depends on whether I can figure out the right query (that performs good enough). I noticed the CleanupAction could be improved now that we have the "ping" system - in that we can reset runs as soon as we know the client stopped pinging. That involves a bit of querying back and forth though, so not sure I can do it soon. For now I left Cleanup as it always has been: reset runs that have timed out.

Either way its not a regression, merely a suggested improvement that is not done yet. So we can merge without this.
о_О ок, посмотрю
если не будет, то оно подставит вместо, например white2, то что у него в куке style_selected
I guess we don't need this debug lines ;)
Excuse me. I did not understand you. Can you explain me again? Thx.
Is this comment blocking? If not let's keep the current design (I am 16 hrs away from heading to the airport).

Thanks.
if you use `<script defer>` then you don't need to wait for `load` event.
here it can be added a sentence with numFriendsProposed = response.data.length
That level of nesting is pretty crazy!
I don't know why but it is not the same if I change the reference to shared.
@basiclines , can you review this?
If we’re not relying on `:target`, there’s no point in using an `<a>` element instead of a `<button>` one, is it?
On the goddamn rug.
This function is unncessary. Just use the Values class which already does this. "new Values(obj1, obj2, obj3)". Values implements List.
pos should be the same whether or not we use fill-line. It's only used to determine where the line starts.

How about something like:
(let* ((pos (ferl-position-at-line line))
       (beg (if fill-line pos                 (ferl-first-char-on-line-at pos)))
       (end (if fill-line (line-end-position) (ferl-last-char-on-line-at pos))))
Err... actually, now that I think about it, there are probably some cases where we might want to both load the history from the DOM *and* load the cached history, e.g. when a user is building on an existing published hack.

Hmm, might have to noodle on this a bit more.
this is reversing the order of the plus, right?

So, if the + is not commutative, this will break, won't it?
This scheme works, don't know if it's absolutely necessary. My Scala skills are still 'under construction', so it might be superfluous to have it here.
I'm not a very big fan of doing this import here. Why not just call ```CascadingUtils.kryoFor``` when you need this?
haha yay! I will get some other people to run it tomorrow, though I am using it constantly on a staging app and have had no probs yet... so maybe your just crazy... sorry! :-)
Since we have actual sockets now and this was just a hack with the "stream", I axed that file.
I think just `if (features[i].geometries || features[i].geometry)` will be enough. It will coerce to false if not present or null and to true otherwise.
These statuses should be stored in a static array or variable so that they can easily be recalled and code reuseable. Hardcoding statuses as a string everywhere when needed is bad practice and is just plain bad for maintainability.
Return error or throw exception instead of terminating program
Instead I've created a pi_util method that can be called direct from hook_nodeapi, as it doesn't need to save the node there - I think set_node_title is called from other modules too, so can't change it directly without checkig all of it.
K, also, on your later PR, you remove the entire setTransform override.

Using transform live seems a lot safer.
You said this maybe is supposed to be removed?
`db` and not `data`?
On Sun, Sep 9, 2012 at 7:53 PM, Tom Prince <notifications@github.com> wrote:

> In master/buildbot/test/unit/test_steps_shell.py:
>
> > +        self.setupStep(
> > +                shell.ShellCommand(workdir='build', command="echo hello",
> > +                decodeRC={1:WARNINGS}))
> > +        self.expectCommands(
> > +            ExpectShell(workdir='build', command='echo hello',
> > +                         usePTY="slave-config")
> > +            + rc
> > +        )
> > +        self.expectOutcome(result=results, status_text=["'echo", "hello'"]+extra_text)
> > +        return self.runStep()
> > +
> > +    def test_run_decodeRC_defaults(self):
> > +        return  self.test_run_decodeRC(2, FAILURE,extra_text=["failed"])
> > +
> > +    def test_run_decodeRC_defaults_0_is_failure(self):
> > +        return  self.test_run_decodeRC(0, FAILURE,extra_text=["failed"])
>
> This doesn't appear to test the rc==1 case.
>
rc==1 is the default test done by test_run_decodeRC:

def test_run_decodeRC(self, rc=1, results=WARNINGS, extra_text = ["warnings"]):


It would also be nice if there where some of results directly, since that
> is a public interface, and isn't tested by this code (just the fake
> implementation is). These tests would want to look like the ones in
> buildbot.test.interfaces.
>
I would have been happy to modify your tests for successfulRC, but I did
not find them ;-)

no offense, I'd like to start working on more fundamental stuff. This PR
has been much more time than expected.

Pierre
I don't know django at all, but
https://docs.djangoproject.com/en/dev/topics/db/models/#automatic-primary-key-fields
and
https://docs.djangoproject.com/en/dev/topics/db/models/#one-to-one-relationships
suggest they aren't necessary for 1-1 relationships.
This comment is out of date: try/finally can be used in generarotrs. (See http://docs.python.org/whatsnew/2.5.html#pep-342-new-generator-features)
Yep, my bad. Wasn’t intentionally.
Hmm, that's not done in the header already?
I have created the static setters I need now, will probably PR for more in the future
Change "QVariant::fromValue" to "qVariantFromValue"
Replace GITLAB_OPTS with Gitlab.config
These should not be function local statics.
Hmmm, I like the API I gave above for percpu that doesn't involve integrating the variable name into thename of the macro.  I know I told you this contrarily before, but I think we only need the percpu_get function that returns the address, and takes as argument the variable name.  It seems weird to me now to see the name of the variable as part of the macro.

We want to get the naming for this right as it will be used everywhere.
Use `impersonate` instead.
I changed that to my homepage. If you are against that, let me know I will change it back to yours.
We could add support for <meta name="robots" content="noindex">, just after line 171.  If the robots meta tag is present and one of its values is noindex, then we would just not index it.
Good point! I mistakenly remembered that it had to return `true / false`  meant weather `a` must come after `b`. But I guess true / false is normalized to 1 / 0 which is why it works.
Please stick to either `let` or `var` with in the module,  mixing both can be very confusing.
I am quite OK with taking this code out if we no longer plan on using implicit timeouts. I was being cautious and giving us space to add it back in using configuration. Less code is better code.
completeTransition was refactored to usedAsPrimary and that work is mid-flight.
did you mean to use the new var 'current' instead of 'controller.getCurrent()' here?
Or better do it here if dir has not been defined.
So I wouldn't show the file picker here. In case of invalid paths we should just show the popup and reset the path to the last known directory or fallback to the profile folder.
For this one, it the other way of calling IE for browser version less than 10. 
I got updated the calling with the one call version less or equal to 9 only.
Err, right. I did that _before_ creating `validate_options` method.
There isn't a good reason to pass the IO here, rather than the content of the file - the code doesn't stream input or anything, so there is no memory saving or anything.  Better, instead, to read the content outside this method, then pass it through.
It would be nice to use a better way of getting that message out, like our logging system.
Is that include lexically scoped, or did that just alter the environment of every test?
Fixed in https://github.com/puppetlabs/puppet/pull/627
wglMakeCurrent should not be called implicitly by GLWT. There's glwtMakeCurrent for that. This is a well thought design decision.
s/iterations/iteration
Changed the array with keys instead of positional. I added also the support of Traversable.
CS. The ) { should be on their own line.
yes, and it is set by human,  
I think in order to check if it is today, I will compare it to DateTime.now.in_time_zone 'Jerusalem'.to_date?
Nice thing about keeping it in the stack frame is that it just gets allocated inherently.  Simpler code overall, and we don't introduce any overhead to reallocate, etc. Plus if someone is shipping you more than, e.g. 16k of data then there's probably something very wrong (or you have a ridiculous amount of attributes).

I don't think the overhead would be much but I don't think the extra complexity really warrants it when we're talking about a fairly well defined response with a size limit we can pretty reasonably cap.
-> `Soma.js TodoMVC app`

+ A short intro about the framework.
I know. There was one sugestiin that it should be treated diferently. My open question was: should I twrow an exception when error occurs?
then it is fine
@piotras: shall i merge as-is here or do you want to change something after my comment?
This is unnecessary -- `belongs_to :user` will provide a `user` method that does exactly this.
Could we strip "VISIBILITY_" or is there some reason to have it there?
(in user code we will end up with Visibility:: VISIBILITY_VISIBLE with this)
At the moment our project does not ship with a default rake task to start the migration process. The users already have to read the documentation to get the necessary things wired up correctly. I also think we should separate log output. A file is good for informative stuff, the stdout is good for errors and important stuff because you notice it instantly.
Nvm, leave this as is for now.
Something has gone wrong with the indent here.
Np, I can release BOMs in ten mins so it's easy :-D

On 20 Mar 2012, at 14:49, Jonathan Fuerth wrote:

>> +
>> +    <properties>
>> +
>> +    <!-- Explicitly declaring the source encoding eliminates the following 
>> +      message: -->
>> +    <!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered 
>> +      resources, i.e. build is platform dependent! -->
>> +        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>> +    </properties>
>> +
>> +    <dependencyManagement>
>> +      <dependencies>
>> +        <dependency>
>> +          <groupId>org.jboss.bom</groupId>
>> +          <artifactId>jboss-javaee-6.0-with-errai</artifactId>
>> +          <version>1.0.0-SNAPSHOT</version>
> 
> The only problem is, Errai is now on 2.0.Beta3. The version in the BOM is 2.0.Beta2, and there's a critical bug fix in Beta3. We will send another BOM pull request.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/100/files#r580016
Not (void*), just (void). :-)
http://en.wikipedia.org/wiki/Magic_number_(programming)
Rather than individual `privacy` and `notes` methods, we need something like the `update` method in controllers/group.js that will update all fields at once.
update needs an underscore preceding it.
It was added in 596a82c2880a861e06abca3cc549580574a8c885 but not used at that point.
Maybe the problem wasn't yours then. It may be the owner that does not 
care about that, then.

On 08-11-2012 14:07, maiiku wrote:
>
> In jquery.sceditor.js:
>
> > @@ -3458,4 +3469,4 @@
> >  			(new $.sceditor(this, options));
> >  		});
> >  	};
> > -})(jQuery, window, document);
> > +})(jQuery, window, document);
> > \ No newline at end of file
> Was there an empty line on the end of this file before? I don't recall 
> removing it...
> … <#>
> On Thu, Nov 8, 2012 at 2:58 PM, brunoais <notifications@github.com> 
> wrote: In jquery.sceditor.js: > @@ -3458,4 +3469,4 @@ > (new 
> $.sceditor(this, options)); > }); > }; > -})(jQuery, window, 
> document); > +})(jQuery, window, document); > \ No newline at end of 
> file I think you should make this new empty Line at the end of the 
> file... — Reply to this email directly or view it on 
> GitHub<https://github.com/samclarke/SCEditor/pull/34/files#r2069464>.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/samclarke/SCEditor/pull/34/files#r2069571>.
>
fixed, although I'm not sure I get how template hosts/console works, what should the Console object look like? If it's a Excon response like it is when it comes from OpenStack through Fog, I don't think it has any of the parameters used in hosts/console
While your fix on this file is ok in it self. I will express my reluctancy towards having this file at all. It should be up to a developer which files he would like to ignore. Instead use the global setting for git.

Exception of course if the application itself creates files that should not be included.
这句话可以删掉。
I'll switch this to use real UUIDs.
By now I suspect that the `Rn` statements are markers for the recursion level
Did you intend to leave this todo ?
I would expect the session to start if you call forceStart, so what is these workarounds trying to avoid?
Why not introduce a extra session interface where handler instead takes care of these things, so you can do whatever you would like to.
yeah - i feel like some of this should be brought back to the django maintainers. Some of the ways they chose to do things are just annoying as a library consumer.
фиг прочтешь :)
documentControllerAlias gets passed through to here, but not used?
Proxies can target paths that are ignored on their own.
No, sadly not. But I would pop into #python on freenode and ask there.
I can't imagine that using LI unintiailized is really something we want to support. either you use it from LauncherModel, or you provide a path when you construct it, and there shouldn't be any problem, I'd think
2 rainbows, right after each other.
I'd like to see us try to dynamically determine the list of tables present in the database. I think you can do that by getting database metadata from an open connection to the database.
Fixed as part of making sure that configs can be merged with `extend`
Should record the optional ones.
Good catch. Yeah, this should have been implemented.
Couldn't you pass `linksTo` as a constructor argument to `TerminationListenerActor`? Then, inside `act` you could just do the linking:
```scala
  self.trapExit = true
  linksTo foreach (link(_))
  loopWhile(!stopped) {
    ...
  }
```
Honestly, I don't see why it was useful in the first place. My guess is that this was needed in the past, but our codebase evolved and it's now completely useless. 

Look at ``SemanticHighlightingReconciliation.createSemanticDecorationManagers``, when a ``ImplicitHighlightingPresenter`` instance is created we already check for the above condition.
Why not inlining the conditions? i.e.,  ``sym.isMutable && !sym.isLazy``?

(And, if you asked me, it is a bit odd that a lazy val can have the mutable flag set. Though, there must be a reason...)
I've just pushed an amended version that uses the modification stamp of the document instead of comparing the contents.
Done. I finally decided to remove the recalculation code. It was introducing some unneeded complexity right now. We can always add it later if people demands it :)
Note the reassignment of the outfile variable within the body of the try statement.  I believe that the following pattern leaks:

with open('myresource') as outfile:
    outfile = open('anotherresource')

If I ruled the world the outfile variable would not be reassigned within the block, but this would require a much messier change.
Please don't tell people where to initialize a library when it is not an absolute must - it's their choice.

Also, your version of the doc states that the developers *need* to set a configuration, but you're not showing them how to pass it to the library.
Let's stick with the foreach, it makes things nice and readable.

When that other commit is in and the test is written I'll be happy to merge this.
Строки надо сравнивать методом isEqualToString, операторы == и != сравнивают объекты на совпадение, а не на равенство. В данном случае оно может работать, но чаще всего это приводит к трудноулавливаемым ошибкам
I disagree. I tend (now) to create all internal methods myself (like what was done in this file), and export them "publicly". The one liner is hard to fight for in this case (not including the other methods), but it could go either way, IMO.
... and should be fine as we depend on Python >= 2.6


On Sat, Dec 15, 2012 at 5:23 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> I will do so ;-)
>
> Meanwhile I hacked toward a more failsafe serialization routine that
> certainly get's the types right (apart from callables).
>
> ``` Python
> import json
>
> def _serialize(dict_, outer_sep=';', inner_sep=':'):
>     """Aux function"""
>
>     s = []
>     for k, v in dict_.items():
>         if callable(v):
>             v = v.__name__
>         for cls in (np.random.RandomState, Covariance):
>             if isinstance(v, cls):
>                 v = cls.__name__
>
>         s.append(k + inner_sep + json.dumps(v))
>
>     return outer_sep.join(s)
>
> def _deserialize2(str_, outer_sep=';', inner_sep=':'):
>     out = {}
>     for mapping in str_.split(outer_sep):
>         k, v = mapping.split(inner_sep)
>         vv = json.loads(v)
>         out[k] = vv if not isinstance(vv, unicode) else str(vv)
>
>     return out
>
> ```
>
> Wdyt?
>
>
>
> On Sat, Dec 15, 2012 at 5:19 PM, Alexandre Gramfort <
> notifications@github.com> wrote:
>
>> In mne/preprocessing/ica.py:
>>
>> >      max_n_components : int
>> >          The number of PCA dimensions computed.
>> >      verbose : bool, str, int, or None
>> >          See above.
>> > -    mixing_matrix : None | ndarray
>>
>> Feel free to merge fix some cosmits and merge upstream
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/dengemann/mne-python/pull/3/files#r2428528>.
>>
>>
>
>
label_ts = list(label_ts) does the same
this will only work if raw was constructed with preload=True, your function should check for that
Ok. forget this idea. Iterated /= on axis 1 should be the same as /= on the entire data.
Use mocks instead of extending BaseContextSentiveTest
Or, use Cacheable. :-)
OpenMRS convention is to never do wildcard imports.
Maybe instead of not worrying about them, we leave that to a future section? Maybe Networking 301/302?
Same as for `QueryStringBindable`
`return . Just` :P?
You should replace `;` with `.`
I wanted it to be Symfony or FormComponent. I guess it should be like that.
This alignment makes no sense. It fits nicely on one line.
Clean!

Is this user-level API?
Style issue: no space
Normally commands derived from built-in command classes don't have ``__init__``s. I don't know whether this is something to do with the Boost side of things, or if it's a mistake on Sublime's part, but it will work without it.
Would love to see this separated into a conditional rather than returning both every time, but it does work.
I'm a little puzzled by this section. Don't all arguments have names by definition? Unless passed as **kwargs or a list or something like that?
In my mind this is ok.
What does this return now?  We should update the javadoc to reflect it.

Also, unrelated, it would be _awesome_ to remove the requirement that all string options have to have a character variant as well.
This is unnecessary.  The guest should be allowed to do this as the service status must always remain a source of truth as to what the service is up to on the guest at any time, even if its about to be deleted, so we can see this in the management API and to keep the code simple. If the REST API status needs to stay in the DELETED state regardless of what the guest says then the task status along with the code for the Instance.status property can be used to accomplish that.
Marker can of course be None, but at this point there should be at least the default limit passed to the guest agent since we're pagination on these classes is compulsory.

That said, it's probably smarter if I make q.limit think about itself first before just assuming I can add 1 to it.
Btw, what's the scope for usage of self? IOW, which configuration classes should be using it? So far you seem to have applied it to cache store ones. This is important for future configuration implementers.
extra space before the ``=``, no need for the braces around the check, and you should use ``===``
but what about the fallback line here at the end? should we not append any locale parameter here?
Should mention what the default behavior is.
It's not syntactically correct JS, no, but it doesn't really matter because these are just regex tests, and all I'm checking here is that this is flagged when it's preceded by an opening bracket (or word border in the case of the other two tests).

I could change the pattern to "var x = somefunction(%s);", I guess.
Line is too long. Also, we use double quotes for strings in the validator.
Fair enough. That's fine then.
Yeah, it's definitely a good idea to move `*request*` and his friend into their own namespace despite it all being super simple. It's easier to think about that way.
Ну я немного поторопил событие, но ай да ладно :-)
Since the combo is not really below the text, I would make this "below the map"
It's true that it won't work but the WMTS of Vienna hasn't a valid capabilities than is can't directly work !

I think that the best is just removing this example...
Vendor should be translated as well.
please move this function to mathematics/Math.h
For what is this if you don't override anything?
Looks like this was my old code, I appreciate you fixing this. :)
('_') - snowman is watching you from the ощшт
Dot notation is nicer when possible.
Are you sure ``$context`` has the correct type as ``*`` is not a sub-type of ``resource``? I found this a couple of more times on lines: 208, 214, 220, 226.
这个try catch只要捕获require(package.json)那里就够了。
all the comments for the similar code above apply here
wohl schon...
Yeah, mistyped this one.
indeed i should have
that doesn't really matter as @braddunbar replaced these lines with a more efficient version of his patch anyway
несмотря на то, что папка содержит "много" объектов, ее имя желательно в единственном числе
Not showing up in my editor...not sure if there is a tab somewhere[I have show hidden chars on..]
jenkins says there is some white space here.
We'd have to rename them to something like JLogLoggerFormattedtext etc., but lets do that in a later pull.
You're right of course : your implementation is more robust. 

I think I'd just like to try and see how it would fare with the simple&dumb one :) (sometimes we can have good surprises !) Let's keep it as it is, fine for me. You change the name and merge the PR ?
That’s what I’m not getting :) Then why bother?
This could be a one-liner (flat is better than nested, yada yada), but maybe that's a personal style nit?
Is this meant to be in this checkin?
`timelineActionClass` is not yet injected too
This is not really needed. As we will run task very often (on minute basis) there is no need for command. For horoscope, which runs only once per day, it is necessary so you can test.
Translatable string?
Write all arguments in callback function which function gets so that possible later developers will know what is available.