Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=97486

Reviewed by Ojan Vafai.

More work for bug 96804.  This is just a refactoring.

No new tests, behavior should be the same as before.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalHeight):
* rendering/RenderFlowThread.h:
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
(WebCore):
* rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Added a missing "if VALUE_PROFILER" around an access to ArrayProfile record.
https://bugs.webkit.org/show_bug.cgi?id=97496.

Reviewed by Filip Pizlo.

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium][Mac] Remove loadFont from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97360

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/chromium/CrossProcessFontLoading.mm:

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WK2] TestRunner does not support overridePreference with value "0"
https://bugs.webkit.org/show_bug.cgi?id=97457

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24
Reviewed by Alexey Proskuryakov.

Tools:

testRunner.overridePreference() was marked as taking a boolean
in argument in testRunner.idl even though the test cases are
passing strings to it. The current code works if the test
case wants to enable a setting and therefore passes "1" string.
However, if the test wants to disable a setting and passes "0"
string, the current code also evaluates this to true causing
certain test cases to fail.

The argument to testRunner.overridePreference() is now of string
type and a function has been added to convert the string passed
by the test to a boolean value.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::toBool):
(WTR):
(WTR::TestRunner::overridePreference):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Unskip fast/regions/css-regions-disabled.html test case for
WebKit2 now that WebKitTestRunner actually supports overriding
a boolean preference with "0" value (to disable it).

* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/mac-wk2/Skipped:
* platform/qt-5.0-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Skip flaky http/tests/security/cookies/xmlhttprequest.html test on Windows.
https://bugs.webkit.org/show_bug.cgi?id=95803

* platform/win/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JSArray::putByIndex asserts with readonly property on prototype
https://bugs.webkit.org/show_bug.cgi?id=97435
<rdar://problem/12357084>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore: 

Boy, there were some problems:
        
- putDirectIndex() should know that it can set the index quickly even if it's a hole and we're
  in SlowPut mode, since that's the whole point of PutDirect.
        
- We should have a fast path for putByIndex().
        
- The LiteralParser should not use push(), since that may throw if we're having a bad time.

* interpreter/Interpreter.cpp:
(JSC::eval):
* runtime/JSObject.h:
(JSC::JSObject::putByIndexInline):
(JSObject):
(JSC::JSObject::putDirectIndex):
* runtime/LiteralParser.cpp:
(JSC::::parse):

LayoutTests: 

* fast/js/concat-while-having-a-bad-time.html: Added.
* fast/js/concat-while-having-a-bad-time-expected.txt: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/concat-while-having-a-bad-time.js: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove String::operator+=()
https://bugs.webkit.org/show_bug.cgi?id=96172

Reviewed by Benjamin Poulain.

Source/WebCore:

Replace the last usage with String::append() in Gtk.

* platform/gtk/GtkInputMethodFilter.cpp:
(WebCore::GtkInputMethodFilter::handleCommit):

Source/WTF:

* wtf/Platform.h:
* wtf/text/WTFString.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129433 268f45cc-cd09-0410-ab3c-d52691b4dbfc