labofsahil/github-event-dataset-2012 huggingface dataset:
"As a result, alice ttlg, 852 Prospect�s archivist, has been looking for a more sustainable home for the archive, finding one in AO3."

Smart quotes were on here, an thus the apostrophe is not displaying properly in the possessive. Also, we might want to double check that Open Doors wants this sentence phrased this way. It's confusingly phrased, and I'm not sure it's grammatically correct.

Accessibility-wise, we should also ask them to tweak this link text for this: "You can read the rest of the announcement <a href="http://archiveofourown.org/admin_posts/215">here</a>" -- "here" is non-descriptive and inaccessible. If they're attached to this phrasing, the link should surround "read the rest of the announcement here." Similarly, making "contact <a href="http://archiveofourown.org/support">Support</a>" into "<a href="http://archiveofourown.org/support">contact Support</a>" would be even better.
You can do this with an each
Unfortunately there is no standard convention within Zotero. I would think that minutes is most common, but I don't really know if it matters. It should probably include a units label in case we want to be smarter about formatting this in the future.
I think this should be an ``||``, no?
Is there a good reason to do this instead of having the functions in the module file. I can see this tripping a lot of people up, because the global namespace is usually located in the module file.
That was me. It's because I see the ERROR lines and the magenta lines as the same color.
I would recommend choosing your INCLUSIVE and LESS_THAN variables first, and then generating REL and FREL out of those, instead of the other way around.
Hi, we added the .summary-header not so long ago because of something weird that was going that Daniel spotted. Here's the commit - 30a26e840f0b17fd3cc41e08dbe1836c2abc5013 - daniel pinged me about it and showed me on his screen, although i couldn't reproduce on mine - we should check we haven't made this an issue again.
Travis is what we call a "Continuous Integration" server, and what that does is simply install, build, and run our tests every time someone pushes to master (in the main repo), or submits a pull request. You don't need to run it locally at all -- just run `rake` to run all the tests locally. :)
value引数で指定した値のある配列の最後のインデックスを取得します。配列中に存在しない場合-1を返します。ネイティブの *lastIndexOf* 関数がある場合はそれを使用します。*fromIndex* を与えると、そのインデックスから探索をします。
typedef. очень длинный тип дублируется
the class name needs to match the file name .. i am not sure if we want to go with ``SQLQuery`` or ``SqlQuery``
It does but the error is confusing. This customizes the error.   


On Sunday, September 2, 2012 at 3:51 PM, Fabio Kreusch wrote:

> In lib/crypt_keeper/provider/mysql_aes.rb:
> > @@ -0,0 +1,40 @@ > +require 'crypt_keeper/log_subscriber/mysql_aes' > + > +module CryptKeeper > + module Provider > + class MysqlAes > + attr_accessor :key > + > + # Public: Initializes the encryptor > + # > + # options - A hash, :key is required > + def initialize(options = {}) > + @key = options.fetch(:key) do > + raise ArgumentError, "Missing :key"  
> I think fetch already raises, doesn't it?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/jmazzi/crypt_keeper/pull/7/files#r1513672).  
>  
>  
>
Please use string.format() instead of the older "%" style.
I don't think we put the whole file into memory first. Whether we should write in chunks or directly to the file. Doesn't let us urllib2 do that?
just "ext"
Do you know of any technical reason we're using the singleton stdlib for our Configs?  In my experience using the singleton library always seems like a good idea at first but usually ends badly.  When we start having to create clones of classes it makes me think we could get by with using a Ruby class with modules or even inheritance.

I know we were using Singleton before this patchset but if others agree it might be a decent time to rip it out.  I'll ask others to weigh in.
Cool... I waffled on that as I was writing it so I'm happy to change it.
Why did you remove so many names for the terminal in other languages?
Small gramar change: Should be:

U moet een nieuw wachtwoord instellen omdat de wachtwoord versleuteling van Refinery is verbeterd, hiermee wordt uw wachtwoord nog veiliger opgeslagen.'
Not in a point release
You can add your email to the composer.json, too, if you want to. I just was unsure if you would agree with that.
This is not a common pattern in the codebase. We can probably get rid of it.
We'll need to verify whether or not the user is allowed to see the content first (`getContent`). This will take care of the content id validation as well, so no need to repeat that here.
If the user provides an object without `tenantOverride` set, it will not get a default. Is the logic intended to do this? In similar cases, I've done this:

```javascript
options = options || {};
options.tenantOverride = options.tenantOverride || true;
// etc...
```
The `sort` variable pops up here again.
It's in the commit message [SHA-34dc46d002887367f9cf0c6f8aafc54067f80872](https://github.com/dotta/scala-ide/commit/34dc46d002887367f9cf0c6f8aafc54067f80872), but I agree, a comment wouldn't be a bad idea :) Will do

And I plan to extract my own ``Traverser`` class which should better convey the intent of this code.
I don't see the '@Test'. Am I missing something?
Add a space right before " Size", so the concatenation will have a space.
how do you envision being able to use https://github.com/symfony/Routing/blob/master/Matcher/RedirectableUrlMatcher.php ? shouldnt we be using composition here instead?
I was aware of this problem. Embarrassing really.
Could you remove this check? And open a new issue for that.

Le 12 nov. 2012 à 13:57, Jason Bouffard <notifications@github.com> a écrit :

> In src/Geocoder/Provider/GoogleMapsBusinessProvider.php:
> 
> > +    }
> > +
> > +    /**
> > +     * {@inheritDoc}
> > +     */
> > +    public function getName()
> > +    {
> > +        return 'google_maps_business';
> > +    }
> > +
> > +    /**
> > +     * {@inheritDoc}
> > +     */
> > +    public function getGeocodedData($address)
> > +    {
> > +        if ($this->getAdapter() instanceof GuzzleHttpAdapter) {
> If you look at the GuzzleHttpAdapter it's pretty straight forward. So either there is something we can configure on the Guzzle\Http\Client in GuzzleHttpAdapter or this is something that's happening deeper in Guzzle.
> 
> —
> Reply to this email directly or view it on GitHub.
>
k, pushing change.
Easy flip. Hehe
`CI_Email` doesn't have a parent class - this would probably trigger a fatal error.
Also, use tabs for indentation instead of spaces. See the [coding style guidelines](http://codeigniter.com/user_guide/general/styleguide.html#whitespace) for more info.
здесь тоже не правильно! Ты вставляешь случайный элемент масива arrayChars, когда по заданию ты должен вставить элемент, который не совпадает с текущим. То есть, если в этом месте был геном "G", то на его месте должно быть либо "A" либо "C" либо "T", но ни в коем случае "G"!
Я и говорю, что нет :)
Вы меня не понимаете. Я вам говорю про геттер, который возвращает NSMutableArray. Я же вроде бы комментарий именно к этой строке и оставил.
Ключевой момент здесь const. Глобальные переменные плохи тем что их можно случайно затереть из любого участка кода, и найти этот участок кода потом будет сложно. При использовании const эта проблема снимается, а ближайший аналог конструкции скорее #define DNALENGTH 100.
Метод типа initWithLenght сознательно не использовался, поскольку он предполагает возможность изменения переменной во время выполнения, то есть потенциально наоборот повышает вероятность ошибки принимая во внимание постановку задачи.
Yeah, you right, you can’t call private methods of the original class from the category.

Judging by what these methods are doing, it is probably a good idea to make them Class methods.
This shouldn't really be here. You should fake it in your test. The reason is that FileError will be there in cordova.js
Do we need to filter out system users -- like the 'search_indexer' user account?  And perhaps the  'admin' user?

Alternatively, we can add a precondition that the user must be an admin user?
You are still duplicating self._data
@julienrf  yes, I could change the return type to `ExecutionContextExecutor`
Maybe the wording can be better, but they are disabled because Windows will not display ANSI colours unless there Windows has an ANSI driver installed. It's not a problem for Console as it detects this, but anything you might invoke that does emit ANSI sequences is going to cause ANSI characters to be displayed. I think there needs to be some reference to this somewhere because it's a very common problem.
Is it necessary to formulate this a bit clearer, like "If the request is a HTTP POST request" or "If the HTTP method is POST"? Can we expect that any and all of our readers know well enough about POST, GET etc.? Should we link the word POST to [Wikipedia](http://en.wikipedia.org/wiki/POST_(HTTP)) or the [HTTP specification](http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.5)?
Hyperlinks should be at the end of a file. Place this hyperlink under the new section, or place the new section above this hyperlink
Can this be changed to not include the double-slash prefix?
Can we visually distinguish book titles (quotes)? This one in particular is confusing.
We can't make `content` metadata. It's the actual data; it's not meta.

Apart from the philosophical point of view (which I agree isn't as important as tech), reading files should be an obvious operation. (Writing to files is obviously not as simple.) If reading files is just accessing it on the disk (which in btrfs, with its COW system, is really really cheap), this is awesome!
What if `$this->tabs` is empty after checking visibility? This should be done before line 122, right?
Попробуй тоже ActionIcon выставлять.
Good thinking on using variables, but you actually don't need them here.  Ruby methods always return the value of the last statement executed by the method.  So you could just write "echo" here and get the same result.
provideS
This whole method is called from the menu item creation. When we check every file for being valid by really opening it in the mapdatabase, couldn't this lead to long delays before the menu item becomes visible? (I haven't tested this myself)
The next 9 lines and the 9 lines after them should be extracted to a method, as they are identical (just using other services, callbacks and connections).
This mutex is used only to lock on changing the log handler. The log handler itself should have it's own mechanism to handle thread-safe logging (as boost::log do for example). So here we shouldn't lock (I think) when only calling the handler, just let it manage thread safety. The implementation will be able to make the good choices for efficiency itself, like using some kind of concurrent log record stack (one of the configuration of boost::log does that for example). I think it's a problem that should be solved by the logging implementation, not by the log user, that is cppnetlib.
Am I more clear about the intention for this mutex?
This is a pretty minor class that I only barely use for some stuff.  If we think we need more instances of integer based matrices then we can do that when we need it, but right now i'd _really_ like to avoid the multi type mess.
Can you push this summation code into a more general function, like in common.Statistics?  Calling the sum of a vector seems like a common use case.
This method are ignored if IgnoreAttribute flag is true
Hmmm... I think if we are returning ips we should return all the ips not just the one private. And go with either {'ips': []} or {'addresses': [{'ip': ''}]}
```python
dict()
```

what's wrong with ```{}```? Works just fine everywhere else in your changes.
This change was needed in my previous attempt were the state transfer transaction did have modifications. But I gave up on that approach so this should be rolled back too.
@galderz, the bug in the old configuration is the reason why tests use the generic TM lookup class instead of the JBoss-specific one. Even with the new configuration, if one configures a custom TM lookup for the default cache, it will be inherited by all caches so it can be called concurrently.

I think this signals a potential problem everywhere the configuration allows the user to provide an instance of an object (e.g. the ConsistentHashFactory). The custom class may want to hold some cache-specific state, but it can't because all the caches actually use the same instance.
-  using GCR.wire dependencies VS the conventional command.init(..) is slower because of the reflection. This is not critical for performance, as this code is not invoked on the critical path (e.g. put).
Why use CopyOnWriteArrayList? this collection is very expensive on additions(which we do a lot of) and cheap on reads.
Also, why  do we need a concurrent collection here? is it *concurrently* modified by multiple threads? If it is only for thread visibility, then we should use an ArrayList (or even linked list) and make it volatile..
With such a small loop, performance isn't really a big concern, and readability becomes the leading decision aid. For me the ```numpy.min``` approach provides a certain amount of clarity as to what is being done, where the ```min( min(m) for m in n )``` needs to be read twice to be sure you haven't missed anything.

As minor as it sounds, IMHO ```numpy.min``` would be preferable.

Cheers,
Because it's not necessary for setUp, and if it was you'd want it to be atomic. You're starting it in setUp but waiting for it in the test. Also, if the launch failed for some reason then the tearDown would not be run.
It works on keyboard or other webelements?
In what case would one use multiple tile managers? With multiple maps? Are there cases where it makes sense to have multiple tile managers sharing the same map?
Move the js to a js file!
you're right !
But why you don't use a namespace for clean the events. (Like this : https://github.com/Genosite/bootstrap-tour/commit/a854586175477aedf0bea3e7e44040e0836848ff)
What is `missing-struct` here? A timeseries?
Should the selector be modified so we can avoid `.find`?
Awesome comment! :+1:
Yes please :)!
I don't know if we want to issue a pull request to the vanity maintainers, but if we do we probably don't want to add pry as a gem.  The other option is to create a separate fork and use that for the pull request.  For now I'd say leave it as-is.
Nope: that is, both work (`refute` is a valid MiniTest assertion - just the opposite of `assert`).

It does seem to be a problem at my end, though. Something weird with `bundler` and different versions of `rake`. I think I have it sorted it. Thanks.
I want to add specific support for browsers other than firefox
We are in the process of updating a lot of the guidelines, should be available in the next few days.
i would probably set this regex up as a cached var above, since you reuse it a few times. and makes it easier for us to adjust in one place vs. n places.
Code Style (CS)
- Имя переменной с маленькой буквы
- более осмысленное название переменной
You don't have to have the closing parenthesis on a line by itself. Fine to put it at the end of the previous one.
The only logic added here if to override or add if doesn't exist the Connection header . i have tested this using WireShark to capture the packets
`alt="More accessibility please."`
stream = templ.generate(**self.resume) - needs double asterisk for dictionary key reference
I don't think that's cleaner... the if might look cleaner, but the overall code is less simple to understand.
this line looks redundant now
In my tests, the timeout was fast (~1s) by default. There are options for it if you think it should be set.
I change to this simple one...
User-exposed strings should be in `"`.
No need for this. You hide information what exactly failed with this. Just leave it to blow. In this way it will be eaiser to see why exactly it failed.
Sorry, cannot help you here. Write to GitHub, try all possible buttons, maybe there is some refresh button. I remember a commit range page.
No, I think you've chosen correctly, @jonmeredith.
split des asserts qui ne sont pas reliés ensemble.
Definitely I prefer to use Constructor Injection here and throw away the  `RandomNumericSequenceLimitGenerator ` class.

What would be a rule of thumb for similar situations though? I make this question in general because the code in the `UriGenerator` class also requests a specimen from the context..
What behavior is expected by passing ```false``` here?
If you look in Shopify in `forward.html.erb` you can see how we pass in any additional credentials right in the options hash, instead of the block body.
Oops!

Perhaps move `status` up into the assignment with the rest of them
`#pikachu{}` / `tuple()`
Please remove ``Bundle`` from the class name
Ah, I wasn't sure and didn't find a good source while googling.  Will update.
better to create these files under 'System.getProperty("test.build.data")/TestRawBytesStorage'
If you don't care how this was called it should be a stub. Also, having a specific number of times when a stub would suffice makes this brittle.
cleanup() will never return if SD card is not installed on the test phone. Maybe I should fix cleanup() instead of skip it.
As above: "or alike" is a slap in the face of readers.
Thank you for implementing this method!
Building => build
It seems this is the only private member? Is there any reason for that?
Why the hell this line...?
It's got to have some packages since it's used by [Foresight Linux](http://www.foresightlinux.org/), a [rolling release](http://en.wikipedia.org/wiki/Foresight_Linux) distribution, just like Arch Linux, with the advantage of QA.

I have never cared about every package under the sun, only the most popular ones and the easy ability to build the odd package that's not there.

Personally, I have not used Arch Linux since I have bought a Mac. Unfortunately, the Mac OS X package managers are atrocious, that includes, Fink, MacPorts, and Homebrew.

I would like to see Pacman or Conary (needs porting) take over in the Mac Community.
for large commented out areas, I prefer the # at the first column because that is automatically handled by spyder, eclipse and idle
the check for valid method should be before the call to super. Or better, it can be dropped if the check is made in the super method
Thanks for the feedback. I'll take care of that shortly. Also, I've got a
little script that runs through of the options to confirm that everything
is working g correctly. After I complete that, I'll add it in as a test.

Any more feedback will be very much appreciated.
 On Aug 16, 2012 4:20 AM, "Josef Perktold" <notifications@github.com> wrote:

> In statsmodels/graphics/gofplots.py:
>
> > @@ -6,11 +6,221 @@
> >  from . import utils
> >
> >
> > -__all__ = ['qqplot']
> > +__all__ = ['qqplot', 'prob_plot']
> > +
> > +
> > +class prob_plot:
>
> Yes, subclassing object is not written down as standard, but it is. and
> capitalized names for classes (pep-8) "ProbabilityPlot" "ProbPlot" ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/statsmodels/statsmodels/pull/412/files#r1391565>.
>
>
I don't mind either way, I was just wondering if that was because of something else missing in `buffer-browserify`. However, it may be safer to stick to node's API since the purpose of this module is to apply the exact same way on node and in the browser..
Yeah, I think @KL-7 is right, there's no reason why unicode_data_attrs shouldn't just be a constant that you can call `.new` on.  Making it a class variable isn't wrong necessarily, but, in addition to inheritance issues, it doesn't allow you to access the struct outside of the `UnicodeData` class.  If you used a constant name like `CodePoint` instead, you could access it outside by using `TwitterCldr::Shared::UnicodeData::CodePoint`.
changed it in my fork
I'm worried about future support of this configuration. It feels a bit messy as is, and this is a public project now.

I agree with holding out for another use case before refactoring, but we don't have to merge this immediately: we can keep running off a branch for the near future.
Please cleanup this file. Most of section/parameters are useless in this context
Yes, blocks work like methods on a class. In this case the login.html class extends master.html. We call the super function to call the super class's css block method.
Should we just stuff the grid filters up front or force people to put then in a "filters" container?
So - this seems to be allowing any interpolant.  The problem here is that when Barney and I discussed the effects of using different interpolants on the simulated power spectrum, we intended that for the case of non-gridded points, we would set up the input grid imposing some criterion that the simulated power spectrum should be correct to some tolerance given the grid spacing.  Imposing that criterion requires us to know the FT of the interpolant.  So we thought that we should simply require a linear interpolant, or at least issue warnings that accuracy is only guaranteed for linear... I guess this could be up for discussion in #248.  But I do think it's a little dangerous for now to allow any interpolant without a warning / comment that this functionality is still being tested / refined.
No.  That first psf should be lowercase.  It refers to the psf field in the configuration file, which is lowercase.  Maybe change to "the psf field" rather than just "psf" to be clear.
I would suggest pulling this code out into a single free function that each one call, since it is identical for each class, so it's kind of bad form to keep multiple copies of the same thing.  So:
```
template <typename D, typename T>
static void ApplyDeviateToImage(D& dev, ImageView<T>& data) 
{
     // Typedef for image row iterable
    typedef typename ImageView<T>::iterator ImIter;

    for (int y = data.getYMin(); y <= data.getYMax(); y++) {  // iterate over y
        ImIter ee = data.rowEnd(y);
        for (ImIter it = data.rowBegin(y); it != ee; ++it) { *it += dev(); }
    }
}
```
Then in each RNG class, you would just have:
```
template <typename T>
void applyTo(ImageView<T>& data) { ApplyDeviateToImage(*this,data); }
```
Then if we ever decide to change the way we want to loop over the image for some reason, there is only one place we would need to change the code.
`_bd`
This is just thinking aloud: in future, I think we might want to add a little machinery to allow additional `kwargs` to the power functions... This would be nice, and not too hard to do I think.  But one for the future.
yup ok. i see what's going on.  

btw, rekelvinate still calls run.delay instead of kelvinate.delay, but you probably were already aware of that.
-1 could be extracted as EOF constant to avoid magic number (even though it is pretty obvious here)
It looks like the delete route isn't protected by a filter -- dangerous

There should be a check owner OR Site admin filter that is applied to destroy

Furthermore, admins should be able to access any route, so check_owner should allow admins to see it
Can make these final and use `checkNotNull(catalog, "catalog")`
@brentmc79 Why must we verify that id is called twice on customer?
fyi, you can use \` to indicate inline code too: `this is my code`
can you also add these lines in there:

```
## generic files to ignore
*~
*.lock
*.DS_Store
*.swp
*.out

# rails specific
*.sqlite3
config/database.yml
log/*
tmp/*

# java specific
*.class

# python specific
*.pyc

# xcode/iphone specific
build/*
*.pbxuser
*.mode2v3
*.mode1v3
*.perspective
*.perspectivev3
*~.nib

# akka specific
logs/*

# sbt specific
project/boot
lib_managed/*
project/build/target
project/build/lib_managed
project/build/src_managed
project/plugins/lib_managed
project/plugins/target
project/plugins/src_managed
project/plugins/project

core/lib_managed
core/target
pubsub/lib_managed
pubsub/target

# eclipse specific
.metadata
jrebel.lic

*.iml
*.ipr
*.iws

target
.idea
.settings
.classpath
.project
.ensime*
*.sublime-*
.cache
```
Not sure I see the infinite loop: You would be calling `updateWithApiData` on a sub-resource that was sideloaded, not on the same instance, right? I.e within, say, `lunch.updateWithApiData`, you'd call `burger.updateWithApiData` (assuming lunch sideloads burger).

Also: we do call `beginPropertyChanges`/`endPropertyChanges` pairs whenever we create resources, the nesting is the expected behavior and well supported by Ember. These are also called on the sub resources.
Make this 'Is product discountable?'
You should make sure that timezone information from input timestamp is transferred to output.
adding something to .gitignore means that it won't be added to the repo.  It doesn't remove it if it's already present and it doesn't affect pulls.
Maybe we could document the parameters? The methods in this file are already quite verbose and complex, and it'd be nice to have at-a-glance what-to-pass-in and what format is expected.
yes, all the apts and pips would be installs, and the (slightly outdated) code would already exist so everything would run really quickly.
I agree with @philsturgeon. Let's keep examples as focused on the issue at hand. The provided examples are only excerpts intended to briefly illustrate the containing section.
Oh yeah, great catch, model_for is required
Да. Посчитал, что так будет немного лучше.
Неправильно кидать NPE
Какой-то лишний комментарий.
В блоке catch надо понимать, с каким именно extension проблема.
Надо писать, какой именно ключ не поддерживается.
この行は消してはならないはずです。
I think you should use a silex prodiver. Or at least register function into pimple.
Happy to do that.
locator name has been changed (`notification`) so this is failing
So it's still not clear. It mentions body class, which I would typically expect to mean `<body class="value">`. Even if that were the case, this is implementation specific and should not be exposed to the test. If this is supposed to return true if you are on the correct page then the property should really be called `is_the_current_page` or similar.
Googled around a bit and [django-taggit](https://github.com/alex/django-taggit) seems to do this sort of stuff. Perhaps we can look at using that.
BTW: we could also use @larsmans ArrayBuilder from the utils package.

2012/9/13 Andreas Mueller <notifications@github.com>

> In sklearn/tree/_tree.pyx:
>
> > @@ -321,18 +318,46 @@ cdef class Tree:
> >              return
> >
> >          if capacity < 0:
> > -            capacity = 2 * self.capacity
> > +            if self.capacity <= 0:
>
> is this the same as self.capacity = max(3, 2 * self.capacity)?
> To sure what the role of the capacity argument is, though. Maybe a short
> comment for slow people like me ;)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/1144/files#r1597016>.
>
>



-- 
Peter Prettenhofer
if you don't want to do this now just remove this option and we're good no?
Not sure about the name 'footbar' as it is not very descriptive - maybe map-view-switcher or similar would be more meaningful?
it would probably be good to give a little context here beyond `_DEBUG` since this is an abnormal exit. `fprintf(stderr, "exiting; no message received for %d seconds (limit %d seconds)\n"....)`
makes it a lot easier if you do each PR on a separate branch and not your master branch
This will allow things like
    @a+b
It would be better to have:
    e = parsePrimaryExp();
    if (token.value == TOKlparen)
        e = new CallExp(loc, e, parseArguments());
Can we do without the validation? `Elastica_Client` already has defaults, so I think we can simply allow `url` as an option (as you've done below) and leave `host` and `port` available. I'm in favor of removing the defaults, Elastica specifies those already and `9000` was actually incorrect (`9200` is the default port for ES).

@richardmiller: Removing the default port would be a small BC break, but I doubt many users are relying on the bundle's default. Would you be alright with removing this for the 2.0 and master branches?
For the future please refrain from making changes to the empty lines format, it will never end if people start adding and removing empty lines back and forth to suit their personal preference.

Don't need to revert this.
Fix wording of error message. Suggested error message: "Unsupported event name"
As a general comment (no action required), I'd like to revisit how the factory works for retrieving non-NativeObject interfaces. Some of the code has already changed in a pending patch and therefore, merging will be complex.
OAuthは登録時に一度しかやってなくて、それ以降は全てtwitterにログインしてなくてもoauth出来るように、内部でキー生成をして使ってるから、before_filterはちょっと違うかも
+1 for whitespace between the main description and @param
Ok, I took this as an indicator that the files might have been found and in fact may exist, but for some reason the git command didn't exit properly.
init() doesn't seem to shrink a hash table.  Could that be a problem?  Would it be a problem in the else code?
You're not using normalTrans.  So I'm not sure how this works.  Either luck or your test cases don't actually use the values from LEFT.
I see there is some code below similar to that, but I don't think the logical is quite correct.  E.g., I'm not sure you can break out if (i == htPos)
All these massive variable names makes the code break 80 characters in lots of places. This ain't java :)
That's not the problem. The problem is that it's harder to read. There are many many reasons about why code should not be wider than 80 characters.
nope https://github.com/telefonicaid/OpenWebDevice/pull/15/files
Thanks for the notice, I wasn't aware of this issue. Should be fixed now.
Again – this is from the test case I copied.
Nit: I think this sentence English should be improved

>Creates at lease one succeed predicate
serviceName, or storageAccountName?
can whatever you're making a note to remove be removed now?
@ctweney  can do
I will probably do that eventually but for right now I'm not 100% sure that this is going to be our interface anyway. We will probably actually end up with `Discussion.search` which works like this:

```ruby
@course.discussions.search(:archived => true, :category => "review")
```

I want to hold off refactoring until I know what the right logic will be for this.
Good point. Right now I have a custom ZkClient wrapper to handle session failures, etc. I guess I could support passing in an existing ZK instance, but at least if I have my own instance I can control setting my own custom watches, etc. I'll keep it in mind though.
Or keep similar to Harris test?
I was a little unsure about them as well.  I ended up leaving them in there as an indication that the image tiles were not Cesium specific.  I don't mind if you want to remove them though.
Probably want to explain things in a little more detail here.  Most people won't know what `EventSource` is or the fact that the entire point of this method is to provide asynchronous-ness  You are missing param documentation, which should explain the callback functions in more detail.
The reason count is passed as an argument and assigned the return value is because I needed to pass the integer "by reference". I couldn't think of another way to do it without creating a temporary object with a count property. The reason for that is to properly rename sub-materials of the same type or sub-materials with the same uniform name.
it shouldn't even be there. _vaf isn't used.
没必要将key_function和mouse_function分开吧，按键设定只是保存一个按键（无论是键盘的还是鼠标的）到一个功能的映射而已。
please reconsider this for people who don't have ALL their files indexed. some would even like to perform an export PM_APP={path_to_pm_app}
This should be:

    logger.error(__('Invalid value for analytics %s', args[1]) + '\n');
cp != mv
Please put the private section at the end of the file, not before the public section.
Please indent the text. Same for other comments.
Ok, I've added a commit that sets both hiera and hiera-puppet to nil.
I don't see this file in this commit.
Note: This appears to be an api change.
Done! Much less code. No longer need the keys to symbols either.
Лучше не возвращать деферреды, если это не обосновано. Есть же [промис](http://api.jquery.com/deferred.promise/)-интерфейс, который прячет стейт.
yep, that was a question in the PR :)

Not sure, if it's worth an interface, adding it to basetransport would be an option. But then we have to update all the implementation to just do nothing at this method.

I'm open to anything.
is the str() necessary?
Please don't use PascalCase for variables. Types should be PascalCased, and variables should be camelcased.
@jabley I think it should be a mailing list - as HRMC will also need to process the error. 

So one that has the exiting HMRC email

sysadmin@hmrc.gov.uk

and one for a tariff alerts group?
The main becomes crowded.
This will be better to have this pre-load code in an external file (something like "AssetsLoader")
Either choose a descriptive name, or include a javadoc dis-ambiguating.
maybe remove auto generated TODO
consider vImageConvert_ARGB8888toRGB888() and vImagePermuteChannels_ARGB8888() - much faster than doing this manually
Should this still not be `PlateAcquisitionAnnotationLink`?
Could these extra classes potentially be popped out into their own files?
I think it just boils down to having a clean, robust API that:
* is intuitive, and
* eliminates as much boilerplate code from the User's perspective
It seems that `ListItem*` must be `ListItem` here.
This doesn't seem to get used anywhere.
Changelog entry removed ;)
Sorry for my mistake.
Hmm...good question. I think it just slipped through on accident.
no clue .. ask @everzet  :)
Git brother watches you, I've seen the previous comment ;)
You're right, this should be in `toolchainopts`.

However, I'm not going to change it now, because then I'd have to retest everything that has libpng as a dependency to make 100% sure it all still works. `--with-pic` in a configure option for the libpng `configure` script, which is probably not exactly the same as just adding `-fPIC` to `CFLAGS` (which is what toolchain does).

Opened an issue to figure this out, see #17.
Confirmed: onsite has not changed.
Great! Can you test to make sure the functionality doesn't appear in onsite, and then let me know if you think I should merge it to mit-current?
need to remove this...
I've heard reports of this method of assigning not working in Trimpath -- that you actually need to redeclare the `var` in order for it to work. Would be worth looking into, to ensure we don't cause a bug here
Should use single quotes here
I know ```select``` isn't an API property but I think lots of people use to select features programmatically. GeoExt is one [example](https://github.com/geoext/geoext/blob/master/lib/GeoExt/widgets/grid/FeatureSelectionModel.js#L298). So in the case where a feature is programmatically selected the ```xy``` value sent in ```beforefeatureselected``` and ```featureselected``` will be garbage, which is a problem I think.

I'd suggest reading the ```xy``` value from the feature handler in ```overFeature``` and in ```clickFeature``` instead of ```select```. In this way we can have ```undefined``` values for ```xy``` when features are selected programmatically.
We'd need to define clean semantics for them.

- thread must be enregistered
- top and bottom are pretty confusing (top is the smallest address)
- probably one function which returns both would be better

So if you can come up with a nice API we can definitely add this functionality though
I don't see any reason why it would need to be a prefixed extern(C) function.
It also  isn't my invention: 
```InstantiationAwareBeanPostProcessorAdapter```, ```WebMvcConfigurerAdapter```, ```TransactionSynchronizationAdapter``` etc.
It is just strategy, which is used in my ```FilteredBeanFactoryDecorator``` for full compatibility with ```BeanFactory```
not necessary since executor must be replaced for start to suceed
Ha! You change it to a subclass and then tell me to fix the docs :-)

No problem; will do.
I guess your latest suggestion overrides this
Yup. When we do a cancel we always want the role to recycle.
extra space after the '!'
Вариант:
В объект ``TableGateway`` возможности(features) должны внедряться через конструктор. Конструктор может получать возможности в 3 различных формах: отдельным Feature объектом, объектом FeatureSet или массивом Feature объектов.
But the problem is that Windows are NOT and I did not find any better solution :-(

CeylonDocToolTest(line 157)
assertFileExists(destDir, "class_CaseSensitive.html");                   OK
assertFileNotExists(destDir, "class_caseSensitive.html");              FAIL
You don't think we need to worry about explaining the 32/64 split?
Sure, makes sense I'll remove the slashes
We're going to have to support polygons crossing the IDL sooner or later.  I guess the question is if shapefiles allow it?  And if so, is it important enough that we should do it now?
It will just work, we can mention them if you think it's necessary but those are standard eclipse files so they should be familiar to anyone that's looking to develop with eclipse.
the device orientation can be UIDeviceOrientationFaceUp or UIDeviceOrientationFaceDown when the device is parallel to horizon which is not handled here and may lead to some ui issues on landscape + face up mode
"to be fulfilled by" -> "guaranteed to"
SPELLNG is spelt wrong.
@wireframe added tests
@bpierre : I totally aggree with you on the `h1` thing.

What kind of operation would you like the `lesintegristes_page_title` function to perform?
I'm thinking something like this (could be extended as needed):
```php
function lesintegristes_page_title($page_title, $paged) {
  $page_title = $page_title;
  if($paged) $page_title .= " (page $paged)";
  return $page_title;
}
```
My concern is that you would have to call the it this way : `lesintegristes_page_title("My original title", $paged)`.
But I don't think this is a big issue, what are your thought?

@kaneel : 

![](http://i.imgur.com/0sQ9h.gif)
I think it would be better to just replace this entirely by using LibPhoneNumber. I just need some direction on what the preferred way to integrate that library would be. I don't want to waste time investing in an integration strategy that isn't desirable to the project.
"...convert string representations of colors...into the corresponding ... representations..."
what does this thing do / why isn't there any code
I meant that `TiMessenger.sendBlockingMessage` isn't the only thing that throws this exception, the general description doesn't really convey the purpose of the method, i.e...

"Sets an exception to be thrown to the code that is blocking on getResult(), and releases the lock."
That ".csl" extension shouldn't be there.
I do not like HTML here. I think it would be much better to create new template file, include it in `/lessphp/`, for example `/lessphp/error_tpl.html` and then load its contents and append it to `$template->_tpldata['.'][0]['TRANSLATION_INFO']`. Like:

```
$template->_tpldata['.'][0]['TRANSLATION_INFO'] .= sprintf( file_get_contents($less_path . 'error_tpl.html'), $ex->getMessage());
```
It is not enough, because `.sn-im-cbClear` is included 2 times - in `.sn-im-title` and `.sn-im-buttons`. If I do not filter it by `.sn-im-title`, all clears are trigerred 2 times.
And moved again to lib/ui/dialog
Good catch James
I don't think this header is being used anymore
Eventually on the demo/test project I would like to see an explanation of what happens so that when the user runs up the project to see it working, it tells him what it's doing so he understands, and I don't have to explain to them in JabbR. Hah.
Without stubbing, you actually find this test is wrong. The true parse returns `'01-01-2000'"`