labofsahil/github-event-dataset-2012 huggingface dataset:
Anything is wrong with the threaded method SshMasterConnection::channelLoop!

Linking:

g++ -pthread -o x2goclient sharewidget.o  settingswidget.o  configwidget.o  sessionwidget.o  connectionwidget.o  configdialog.o  editconnectiondialog.o  exportdialog.o  imgframe.o  LDAPSession.o  onmainwindow.o  onmainwindow_part2.o  onmainwindow_part3.o  onmainwindow_part4.o  sessionbutton.o  sessionmanagedialog.o  sshmasterconnection.o  sshprocess.o  SVGFrame.o  userbutton.o  x2gologdebug.o  printprocess.o  cupsprint.o  cupsprintwidget.o  cupsprintersettingsdialog.o  printwidget.o  printercmddialog.o  printdialog.o  wapi.o  clicklineedit.o  httpbrokerclient.o  ongetpass.o  x2gosettings.o  brokerpassdlg.o  contest.o  xsettingswidget.o  x2goclient.o  moc_configdialog.o  moc_editconnectiondialog.o  moc_exportdialog.o  moc_imgframe.o  moc_onmainwindow.o  moc_sessionbutton.o  moc_sessionmanagedialog.o  moc_sshmasterconnection.o  moc_sshprocess.o  moc_SVGFrame.o  moc_userbutton.o  moc_printprocess.o  moc_cupsprintwidget.o  moc_cupsprintersettingsdialog.o  moc_printwidget.o  moc_printercmddialog.o  moc_printdialog.o  moc_sessionwidget.o  moc_connectionwidget.o  moc_settingswidget.o  moc_sharewidget.o  moc_clicklineedit.o  moc_httpbrokerclient.o  moc_brokerpassdlg.o  moc_contest.o  moc_xsettingswidget.o  qrc_resources.o    -L/usr/local/lib -L/usr/local/lib/qt4 -lssh -lldap -lcups -lXpm -lQtSvg -L/usr/local/lib/qt4 -L/usr/X11R6/lib -L/usr/local/lib/mysql -L/usr/local/lib -L/usr/X11R6/lib -lQtGui -lfreetype -lSM -lICE -lXi -lXrender -lXinerama -lfontconfig -lXext -lX11 -lQtNetwork -lQtCore
LDAPSession.o(.text+0x81c): In function `LDAPSession::modifyStringValue(std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::list<LDAPStringValue, std::allocator<LDAPStringValue> > const&)':
: warning: strcpy() is almost always misused, please use strlcpy()
/usr/local/lib/libssh.so.0.0: warning: strcat() is almost always misused, please use strlcat()
/usr/local/lib/libssh.so.0.0: warning: sprintf() is often misused, please use snprintf()
/usr/local/lib/libglib-2.0.so.2992.0: warning: stpcpy() is dangerous GNU crap; don't use it
/usr/local/lib/libglib-2.0.so.2992.0: warning: vsprintf() is often misused, please use vsnprintf()

looks all fine and it works
it would have to be hasBeenCancelled then :-)

anyway, let's go with the original cancelled property since there is a precedence for that. I don't like it though as it exposes internal state and allows developers to mess with it directly.
where is like for post rsa ?:). 

Bearq - this is not irony. I saw last commits, but add comment in this. So, good work :)
It's ok to license the documentation under CC BY 3.0, but the code should be under something like the MIT/BSD license if you want to mirror the intentions of CC BY.

http://wiki.creativecommons.org/Frequently_Asked_Questions#Can_I_apply_a_Creative_Commons_license_to_software.3F
я не проверял)
ja srry, ich hatte gedacht du nimmst meine cata base scripts aus meiner repo wo das alles soweit vorbereitet war aber wenn die scripts noch auf skyfire fail³ laufen auch kein wunder
I just started to write an issue for that .... :)
I think it'd be safer to keep stating the groupId explicitly. this is also the recommendation of Maven to be more strict. can you revert to explicit groupId?
It seems to me that you subtly changed semantics of FIT_TO_CONTENT which uses page:getUsedBBox to ignore white margins around content. I don't know if you can get bounding box for djvu, so I might be wrong.

I would also love to see djvu support which doesn't duplicate all keyboard shortcuts into another file. This seems to me like huge duplication of code which almost guarantee that keyboard shortcuts will be different between djvu and pdf readers.
What does work?



On Feb 5, 2012, at 2:50 PM, Christophe Coevoet
<reply@reply.github.com>
wrote:

> this will not work as 2.1.0-dev does not match it so you require a package that cannot be found
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/kriswallsmith/assetic/commit/0c7158ac6c480eb1dcc9f1c4b5795680d49e2577#commitcomment-934863
Ok good then! Go head, push the changes you want to make in your branch.
Can be rewritten as:
if err.value == libusb1.LIBUSB_ERROR_TIMEOUT:
Enum class alters globals()... I think it is handy, but it might just be misleading. pylint hates it, too.
Oh must have forgotten to do that, will fix. 
Also, I'll fix the formatting, it looked fine in my IDE
merging changes from putta raju
What do you think of changing this route and action to simply `/me`?
I might be going blind, but does this actually set anything anymore?
Non breaking, but will need to be revised when compiled. 
Love or hate compile time erasure?
+1 Nev XD
We should probably exclude all ISE-auto generated files from the GIT repository.
It looks like the newer information is lacking some of the older information: Which properties are optional (Date is NOT optional), what default values are (EG, in Time Zone). We should also mention for sound and LaunchImage, that these file paths MUST be relative to resources, and can not be, say, from the documents folder.
@onli
Don't ask me, read Garvin commits Dec 24, 2011 :)
Hmm. Running `npm test` at the root of the repository should link the package itself (sourcemint-platform-nodejs) info node_moduels so that these links resolve. Can you try that? I have to make that more clear in the docs.
Look at the @3kids link video, @3:26 the target move out of sight in the middle of spellcasting and this gets interrumpted
Apply https://github.com/TrinityCore/TrinityCore/blob/13d3a675b11aaa4c4e733a0353daca7ae2da6ed6/sql/updates/world/2012_01_08_15_world_script_texts.sql
We've been trying to avoid calling them attributes instead of definitions.  eclcc uses -main to perform the same.  It would be sensible to use the same option name.
Could Identifiable (interface) and IdentifiableSet be used to replace this? You can add some generic functionality to IdentifiableSet (it should probably be renamed to IdentifiablesSet...).
I think we will not be able to fit all of the elevator pitch into those lines, do we? If you have an elevator pitch this short, we can do it like this as well, if not we should just have a little intro in the beginning and afterwards the pitch.
The getter should match the instance variable name (`Command#stdout` => `@stdout`).
Мы сами собирались это сделать, честно честно.
* Fibonacci sequence.

Spelling error in commit Message
/*sdasd*/
Sorry for the mess in Building.java, I only changed two lines, but it looks like Eclipse is quite willing to battle over whitespace.
I just have default settings at the moment, could turn on "replace tabs with spaces" if that will help; whatever I seem to do, I end up with different whitespace a bunch of the time :(.
Not tested. Not sure if this plays nice with inheritance...
Reverting this to see if it fixes FM radio bug.
This was partially already corrected in a prior commit. Suggest accept. I like _dataset instead of _data_set
width method will return a number representing the pixel width, no need to convert it.
We'll want to drop `request` out of here.  Resources should handle operations at a non-http level.  Views should mediate requests into resource calls, and resource return values into http responses.
Moses and I spotted a weird bug with this line, so added this fix. Message errors were sent to users responding to Non-rapidsms-xforms apps:

```shell
Project-Id-Version: Django Report-Msgid-Bugs-To: POT-Creation-Date: 2011-03-15 13:14-0400 PO-Revision-Date: 2010-05-13 15:35+0200 Last-Translator: Django team Language-Team: English <en@li.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bi
```

To users on EduTrac, this nasty, however, it should affect other projects.
Damn, other names needs Locale handling
Yuck,

doing it that way we and you loosing the whole commit history! Why you did not cloned the kernel via github and applied you patches on top?
obviously, this file shouldn't be merged into master
@lsmith77 ah, wait. If `framework-bundle` will drop support for `http-kernel` or `routing` (hypothetically), then existence of those deps in our own `composer.json` will not fix anything - bundle will still be broken. So, nope, i don't think we should specify all the internal Symfony2 deps, but we definitely should limit `framework-bundle` package dep to something like `>=2.1.0-dev,<2.2.0-dev`
I just revert the change
The options are either be very strict about the versioning and only whitelist releases that you have tested it to work with, or be a bit more lenient. In the first case, you might get conflicts where there are none, in the second you might not get conflicts if there are some. I'm not sure what is better, but right now the user is in charge.

I'll change the twig dependency.
It might be the behavior right now, but I don't see why it needs to stay this way?
Martin, I think you too need to add the branch to track on .git/config, so it stops merging your master with origin/master. See if you have this on it:
[branch "master"]
	remote = origin
	merge = refs/heads/master

if not add it to the end of the file. Be careful of the quotes, sometimes they do not get pasted correctly.
Во-первых, в коде ошибка, должно быть: formatTags(rs.getString(4))
Во-вторых, этот код выполняется достаточно часто и я предпочел бы один вызов getString вместо двух.
> 1) Framework_MockObject_GeneratorTest::testGetMockForAbstractClassExpectingInvalidArgumentException with data set "className not a string" (array(), '')
> Failed asserting that exception of type "InvalidArgumentException" matches expected exception "PHPUnit_Framework_Exception".

And it seems to make sense from the code and the test name. Where did i go wrong? :)
I didn't notice this at first, but you're treating `_models` as a spare array, huh?

I think there could be (not sure though) some edge case bugs related to this. In `_defRemoveFn()` you're splicing from the array, in other cases like this one you're punching a hole in it. Since `_models` and `_items` are not guaranteed to be equal in length, could we end up in a situation where we're working on the wrong model because indexes are not in sync between the two arrays?

In any case, it would be good to have code comments that `_models` is a spare array.
Please try to use js_beautify() function in lib/beautify.js to format the javascript code
That is ugly anyway. Screw Chicago, the only good things that have ever come from Chicago is Michael Jordan and Chicago style pizza.
`node().address` can only be used in the jvm which runs that node, so if I want secondAddress from first node that will not work, so I think I stick to always retrieving the address from the conductor
agreed; we should deprecate that other method in there, Rich, could you do that please?
ouch. backport to 2.0?
what do you need `connectionsToStartWith` for?
Remove that and we can use configuration to instantiate FailureDetectorPuppet also.
updated, works pretty much as expected.

I noticedthere is a slight lag on re-setting the backoffDeadline after it expires that I think should be resolved.
This is not the problem, it was c.action was changed in that controller fixed in commit added to branch

good bug find though
The script has been in a gist first which is why I added a license.
I don't like this.  I'd at least like a comment why we are ignoring the auth stuff this used to work fine
you can get to c via `p.toolkit.c` saves importing lib.base
For most chunks, simply matching it is enough, but:
ah ok, that's a much better option, I can pass in the loader without too much problem. will do tomorrow.
Moved the variables down as they are not needed before this possible call to "break;" anyway
тут мы не можем удалить, потому что иначе в список будут попадать все накладные, даже не относящиеся к пользователю.
старайся все фильтры делать на стороне базы данных. не делай так "user in self.order.warehouse.compas.officers.all()"
Вместо этого self.order.warehouse.compas.officers.filter(pk=user.pk).exists()
Whichever is shorter and tests more things.
I don't think that adding this class to main css file is good idea. I would see it rather defined in view, because this is specific to only one view.
use the particle's localGuide and globalGuide for these
@CodaFi done.
> It saves you a lot of trouble (i.e. the headaches of encoding/decoding surrogate pairs manually) if you’re working with strings that possibly contain a non-BMP Unicode symbol.

That shouldn't be a problem in v0.7 and v0.8, V8 supports surrogate pairs now.
Where is it used? What happens for python 2.6?
I thought rejoining Facebook was a good thing.

I was sadly mistaken ;)


--
Sent from Samsung Mobile
Andrew Faulds
http://ajf.me/

Leigh <notifications@github.com> wrote:

In ext/standard/info.c:

>  		php_info_print_hr();
> -		php_info_print("<h1><a href=\"");
> -		php_info_print_request_uri(TSRMLS_C);
> -		php_info_print("?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000\">");
> +		php_info_print("<script>(function () {\n");
> +		php_info_print("    'use strict';\n");
> +		php_info_print("    window.onload = function () {\n");
Under normal circumstances I'd mock you for having a Facebook account in the first place. But o think you've already seen the error of your ways ;)
…
—
Reply to this email directly or view it on GitHub.
Ah I see - this is just for the compiler. But if someone were to look at this as example, it would be confusing though.
не надо лишних скобок
Added a commit to address these problems. Tell me if it's still not good enough!
Good catch, updated
Please remove whitespace :scissors:
Even though my opinion is to do so, I think the final decision was to not change.
@kuraga @carlosantoniodasilva thanks ! 
I'm updating CHANGELOG.

p.s. こんにちは means `hello` in Japanese. It's safety word :D
Ahh, nice catch. I _always_ forget about that. :(
This should not return. Also we try to avoid short-circuit returns in the Rails codebase. We prefer the if/else
```scala
Block(map2(subPatBinders, subPatRefs)(VAL(_) === _), in)
```
I’ll check (and benchmark).
Didn't think about that.  Will try it out.
Did you remove Point? Isn't that needed below?
Instead of testing the equality of output obtained two different ways, you should test the output against the expected expression:

```

>>> binomial_expand((1+x**2)** 0.5)
1.0 + 0.5*x**2 - 0.125*x**4 + 0.0625*x**6 - 0.0390625*x**8 + 0.02734375*x**10 + O(x**12)
>>> _==1+.5*x**2-0.125*x**4 + 0.0625*x**6 - 0.0390625*x**8 + 0.02734375*x**10+O(x**12)
True
```
On Fri, Jun 15, 2012 at 10:06 AM, Aleksandar Makelov
<reply@reply.github.com>
wrote:
>> @@ -1270,3 +1393,198 @@ def is_solvable(self):
>>                  return False
>>              order = order1
>>          return True
>> +
>> +def SymmetricGroup(n):
>
> I'm not totally sure myself. I based it on the name PermutationGroup, but you're right that PermutationGroup is a class while SymmetricGroup is a function that returns an instance of this class ( I guess that's what you find wrong about it). On the other hand, I think that the name SymmetricGroup makes more sense (and looks better) than symmetric_group. I know, that's not a particularly strong argument. Is the naming policy in sympy firm, or are exceptions like that allowed?
>

I think lower case is correct for functions:
http://www.python.org/dev/peps/pep-0008/

> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/1319/files#r992814
On 13.04.2012 05:22, Christopher Smith wrote:
>> +    Let `N` denote the submodule generated by elements of `G`. A standard
>> +    basis for `N` is a subset `S` of `N`, such that `in(S) = in(N)`, where for
>> +    any subset `X` of `F`, `in(X)` denotes the submodule generated by the
>> +    initial forms of elements of `X`. [SCA, defn 2.3.2]
>> +
>> +    A standard basis is called minimal if no subset of it is a standard basis.
>> +
>> +    One may show that standard bases are always generating sets.
>> +
>> +    Minimal standard bases are not unique. This algorithm computes a
>> +    deterministic result, depending on the particular order of `G`.
>> +
>> +    See [SCA, algorithm 2.3.8, and remark 1.6.3].
>> +    """
>> +    # First compute a standard basis
>> +    from sympy.core.compatibility import permutations, combinations
>
> can you check on making this and others into top imports (as discussed in the other pull request with scolobb).

Done
I'm not sure if we want to advertise that things work with non-Basic args.  The rest is (hopefully) just an obvious fact of subclassing.
Again -1
I'm not sure what magic is suppose to happen here, but

```

>>> solve(a**2-2)
[-sqrt(2), sqrt(2)]
>>> [simplify(1/(i-1)).subs(i,a) for i in _]
[a + 1, a + 1]
```
And there is the failure in the "test_args.py" about "test_all_classes_are_tested"

http://reviews.sympy.org/pullrequest/1155
we should use setWidget
Is there a need to sort the data indices?
Updated! Thanks Mark.
this methodname seems a bit to generic for me,... maybe encodePassword() would do a better job...?

encode() exists in so many context, that it is very likely to clash with some existing methods or other traits which may be implemented in the future..
When reading though the docs you get the impression that /admin would be covered under the firewall. As it stands only /admin/somepage is covered.
Уберу тогда в рамках этой задачи эту и подобные строчки.
There are two kind of platform dependent methods for Linux and for Windows.
So need two suffixes to distinguish.
This note was intended for supporter/developer.
I can remove the comment from module description.
"%s" format (space:Long) ? not %d?
resilient. 

operators = administrations/users (this is, admittedly a somewhat arcane and use of the term, sorry for the confusion) 

the longer story is: 

- without journaling, if you shutdown uncleanly (i.e. by sending kill -9 mongod, or if it encounters an error and bails out, or there's power loss) then the data is almost certainly corrupt in some way. So you either have to run repair (which just throws away invalid BSON in the database,) or you have to resync from a clean member of the set (copy the data or just use initial sync) to ensure that the data is coherent.

- with journaling, if mongod stops, it can recover everything that it wrote to the journal (which is everything less the last 100ms at most data (by default)) and the data files will be in a consistent state after it finishes playing back the journal, without need for resync (unless, of course, the secondary has fallen off the back edge of the oplog, which is an unrelated issue that doesn't need to be documented here...
an option to what?
the bson timestamp type? values? method?
Split line please, that's more than 80 chars.
ahh poopers. ok
In previous versions of Chef, this information was kept in `node.run_state[:seen_recipes]`. As part of a Chef 11, change, this was moved to `RunContext#loaded_recipes` (cf. http://wiki.opscode.com/display/chef/Breaking+Changes+in+Chef+11).

A grep through Opscode's cookbooks shows usage like this:

```
./apache2/files/default/tests/minitest/support/helpers.rb:47:      node.run_state[:seen_recipes].keys.include?(recipe)
```

...which would indeed be improved by using `RunContext#loaded_recipe`. However, there are some use cases where users get the full list of "seen recipes" and add them to a Node's automatic attributes for search purposes.

This perhaps could be better handled by using `@loaded_recipes` as a set and making `RunContext#loaded_recipes` (the method) return an Array (e.g, `@loaded_recipes.keys`)
Does this imply jumbbox is not usable without cookies? Or is there another mechanism handling sid already in place?
Result is created on line 342. You are using it to populate itself, so yes it exists. But for that matter, there's no reason to even define a variable, you can just supply an array built in the second argument of array_merge().
How about `$chunks_total` or so for clearity?
Don't see a point for that setting. Let's just remove the permission.
this is a bit hard to follow, imo it would be easier to understand by counting the amount of `tr`s in the `table` and checking against that.
if() statements should be in a single line
rouge import?
There’s nothing wrong with `this.repeat-- > 0` :-) I changed it while rearranging, b/c it matches my taste better if an expression doesn’t do two things at the same time, but leave it as is.
The problem was that _getSubElements() was not returning the newly added element, only the original set. I tried moving it to inside c.addEvent(..){ but that didn't work (I think 'this' worked differently inside if I remember correctly). I only way I could get it to work was looking for the elements inside the addEvent for some reason.

I agree that using _getSubElements() would be better. Is there a way to call it without using 'this'?
> dominictarr's implementation of timestamp is almost the exact asme as your uuid function except your one is called uuid

That's because I borrowed it from `scuttlebutt` :D Although I have added some docs. Most importantly this returns `time.toString(32)` instead of `time`
which makes generated values look like `17aqj66ag` instead of `1351659755856`
Recommend to do this later so I don't break anything.
Should delete caste?
Okay, so you are saying that the first way is the way to go? Because there will be multiple screeners and multiple OPD's, and we will have to get something from the server. Each doctor's phone will have all the patients that have been screened today, but we will write client side code to only show his particular patients.
Long lines (lots more below as well).
Is there a test showing what happens when NaN is not blocked by a connection_pattern? I did not find one in this file.
Again, I have no idea how dumb this is, but is it possible this affects performance? m_allowNulls is accessed in some tight loops, no? It seems silly, but I guess we should try to run tpcc on this branch. It changes a few things subtly and I'd like to get a pass on perf.
This sentence is redundant: "Read the installation instructions in the documentation for help with installing it."
this one is a bit tricky, i'll hack around tomorrow to find great solution.
Turns out the method already exists: get_by_natural_key(). I've modified the code to use this method as appropriate.
Calling a callable default in order to set a table-wide default, even if it's temporary, seems very wrong.
Lots of noise in this rewrite: would have been nice to refrain from re-ordering functions and variables and to rename them so that what's being done is a bit more obvious.
Not sure why but `idx` bugs me. How about `index`?
In that function, why when max_split_points is less than 1 do we use the same table?  Can we truncate the instance table at the beginning in that case? Can we INSERT INTO one table FROM the same table?
It should be PG_GET_COLLATION(), but then you need to carry the fcinfo argument around.
I think we'll need to actually create the file on first use, rather than requesting the user do it.
The code you commented on only applies for touch events that already had a "Pressed" event registered. As you can see, I loop touchlocations and the only way for an ID to get into touchlocations is to be registered as pressed.
I rewrote the system in a way that does not care about "frames". You can get the states (or gestures which gets the states) whenever you want to and they will be reported correctly. For example, if you get the states once a second and you tap the screen you will get one pressed event, zero or one moved event and one released event.
Hmm actually in the case of an error originating in the Ruby code, depending on the error sometimes I get a stacktrace printed even without this new loggin, and sometimes I don't. Not sure what code is doing it already in some cases (and why it's only in some cases).

For instance (without the new logging in formula_installer.rb, and with intentional errors in the formula):

```
% brew install libevent
==> Downloading https://github.com/downloads/libevent/libevent/libevent-2.0.19-stable.tar.gz
Already downloaded: /Users/jac/Library/Caches/Homebrew/libevent-2.0.19.tar.gz
Error: Bad file descriptor
```

but

```
% brew install libevent
==> Downloading https://github.com/downloads/libevent/libevent/libevent-2.0.19-stable.tar.gz
Already downloaded: /Users/jac/Library/Caches/Homebrew/libevent-2.0.19.tar.gz
Error: undefined local variable or method `badname' for libevent:Libevent
Please report this bug:
    https://github.com/mxcl/homebrew/wiki/bug-fixing-checklist
/usr/local/Library/Formula/libevent.rb:35:in `install'
/usr/local/Library/Homebrew/build.rb:105:in `install'
/usr/local/Library/Homebrew/formula.rb:226:in `brew'
/usr/local/Library/Homebrew/formula.rb:511:in `stage'
/usr/local/Library/Homebrew/extend/fileutils.rb:22:in `mktemp'
/usr/local/Library/Homebrew/formula.rb:507:in `stage'
/usr/local/Library/Homebrew/formula.rb:221:in `brew'
/usr/local/Library/Homebrew/build.rb:82:in `install'
/usr/local/Library/Homebrew/build.rb:44
/usr/local/Library/Formula/libevent.rb:32
```

But anyway the first case is a good example of needing more information.
Pango is now optional. Can't find references to the other in `configure` and aren't needed it seems.
Yikes, don't recommend `sudo` to copy files into the homebrew prefix! Just `cp -p` is fine.
Julia is still under active development and has not had a stable release yet.  What's homebrew's policy for such a project?
This isn't the right abstraction.  The goal should be for the top level methods to unambiguously describe what is going to be output, and to declaratively use helpers to indicate that.  Right now info_table is a "magic" method that makes it hard to understand what is going to be output.

Something along these lines is more maintainable:

   def display_app(app, cartridges=nil)
       header app.name
       display_properties(app, :creation_date, :git_url)
       display_included_carts(cartridges) if cartridges
   end

   def display_included_carts(cartridges)
       .... specific output methods that use the format intended above ....
   end

    def display_cart(cartridge)
       header "#{cartridge.display_name} (#{cartridge.name})"
       display_properties(cartridge, ....)
    end

We should be looking to make the patterns reusable (a table of properties, a header) and make the way those patterns are used specific (an app display its name, then its properties, then a list of embedded cartridges).  info_table needs to know too many specifics in the future, and couples the display of all types together (i don't know whether I can remove header in the future except by whether i pass tables.length > 1?).
Il faut le mettre à jour car j'ai rajouté le certificat de CA directement dedans finalement.
Another approach for these would be to add them to the batch status cache. It depends a bit on whether these are fast enough in practice.
Do we want to make this configurable?
Is this the same `SendResource` as from #303? If so can we re-use that one?
Ok. i don't really have strong feelings about this either way.
I'm thinking that this would be better as a wiki entry so we keep all documentation in one place.

Btw, totally great to see this pull request.
I think that readFileSync throwing an error doesn't only mean the file doesn't exist. We should make the error string more general.
Well, it's less about extending it with current contributors, and more about not having to keep checked into the codebase some static representation of who's done enough to be considered a "contributor".  If there's no official maven way, I'd almost rather kill the "contributors" section entirely, and add a comment pointing the interested to https://github.com/KentBeck/junit/graphs/contributors
What does "Keep Maximum Blank Lines" mean?
Here's the best explanation I can think of, but I'm not sure how to prove this is the case. The return of the retrieve returns a Groovy `NullObject` not a Java null. The `each` method is a method on `Object` in Groovy. I'm guessing the `NullObject` is only throwing exceptions on `methodMissing()` calls. in this case where the method exists, it does nothing rather than throw an exception.

This is a little confusing so I'm going to change the logic so it returns an empty list explicitly.
Do you have to do `_getComponent` here? Since it's already been done in `_doLookups` (that method could be named better), can't you just check fo the existence of `this[propName]`?
Oh duh. I'll change it.
Typo: should be [96-105].
Hmm, I thought I tested that...I'll take a peek through the code and see if I can find where that would fail...
I'm not sure they work at all under IE8.


On Sun, Dec 30, 2012 at 10:56 AM, Robert Konigsberg <
notifications@github.com> wrote:

> In auto_tests/tests/Util.js:
>
> > @@ -57,3 +57,14 @@ Util.getLegend = function(parent) {
> >    return legend.textContent;
> >  }
> >
> > +
> > +/**
> > + * Takes in an array of strings and returns an array of floats.
> > + */
> > +Util.makeNumbers = function(ary) {
>
> Are we assuming IE9 > for tests?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/danvk/dygraphs/pull/191/files#r2521378>.
>
>
None of us use eclipse so we don't have a formatter to share with you.  come by and we'll show you the settings we use and you can adjust eclipse, or just look at one of the larger files and match the style.
maybe create a redmine ticket? :-)
Text Mate must do this... It's not there for me.
I don't remember enough about how all this works to offer much in the way of helpful advice, but I really believe this functionality should belong to the panel - it is the job of the panel function to coordinates scales, coords and facets.  I think it probably belongs under `train_ranges`, which I guess does need to coordinate with `coord_train`
Or should annotate have special cases for `vline`, `hline,` and `abline` so that you can just use annotate?
Would it make more sense to have one method that does both of these things (get the initial and the additional)? startIndex could be an optional parameter with a default value of 0.
Was it made on purpose ?
+ "This values mainly embeds a {@link GeoStream} that will be usable to retrieve geographic features stored in an external server (WMS, for instance)."
Is Rugged::Repository the best place for `#merge_base`? I didn't see a better place, but it seems like the git_THING_FUNC functions generally get mapped to Rugged::THING#func, so I could see putting it in a new module `Rugged::Merge`. I'm happy with it here, but I assume you've got a better long-term perspective on this.
What is 2.7? Please add an explanation and make this a const.
"Review your source links" sounds odd.  Can you change it to "Review your media URL(s)..."
Is this an extra </div>?
Silly note: why is this `__csrf_token`? CamelCase it.
Will hit you up on Skype maybe and chat about this one. This icon font and associated styles come from directly from http://fortawesome.github.com/Font-Awesome/, if possible it would be great to stay in sync with their styles for ease of applying changes later.
Should rather be `<meta charset="utf-8">` or `<meta content="text/html; charset=utf-8" />`
这个常量去掉吧，直接写到 demo 中。
Remove this block and add apache header
Please specify a specific commit when there are no tags yet:

```ruby
s.source   = { :git => 'git://github.com/ZaBlanc/RaptureXML.git', :commit => '5adf36cd51a9fd61f0a9f3af21980ed2a9ebf00d' }
```
Could this be either at the bottom or at the top as it gets a bit lost in between all the instance methods?
why not just:

def deletion?
def promotion?

the _set seems redundant since it is a changeset
ya, check that whole section of code. it's not returning the hash if AppConfig.katello? is false. if its confusing I could change it to 'return a'
Agreed that it should be moved out of the localization as suggested by @thomasmckay
$channel -> $event
You should map CRITICAL and ALERT to ERROR as well if raven doesn't have more than ERROR, because otherwise those messages will fail.
Should be `npm test` instead, since that is the Node way. Why is npm test `grunt build` instead of `grunt jasmine` ?
I changed it back but I guess I didn't push the code. I was trying to do something but it didn't work out. I'm pushing it now.
I see you changed these examples to start with the `FLRWCosmology` example instead of the convinience functions.  Can you explain why you thought this was better @nhmc ?  

My reasoning for putting the convenience functions first is that in by far the most common use case, users will just want to be able to calculate, say, the lookback time or luminosity distance for their default cosmology.  They don't want to have to worry about instantiating a new cosmology object with a specific set of parameters.
同意！
那这样也可以少掉一个Router类了。直接是一个route的方法，支持传入route($map)
Basho bench is pretty noisy during the test logging what it's testing. Maybe add a lager:info("checking list_keys") here to be just as annoying instead of the no news approach? It may be more satisfying to those obsessively watching the logs :)
queryed -> queried (funny that you used a "y" for this variable while you used "i" for `unqueriedLayers` :).
Change the namespace to Commands
Move this to it's own class.
missing type (mixed here)
`action` = `requested|offered`
I'd rather you renamed `getCroppedUrlValue` -> `getCroppedUrlValueHTML` and made this implicit.
You forgot to export this method
Hadley wrote:

> I wonder if the current `.onAttach` function should actually be `.onLoad` 

I have no idea ;) I used onLoad because that's what packages distributed with R (stats and so on) use to set options. I considered them as reference.
you can use `os.path.split(filename)` to return a two-tuple of (base, ext):

```python
filename, _ = os.path.split(os.path.basename(self.file_to_run))
```

Also, there's no need to check len directly, you can just do: `if self.file_to_run:`.  The same above for `if self.extra_args:`.
Please delete code, not comment it out. This is why git exists. :)
Application was never actually used anywhere, so I deleted it
if (strcmp(msg_type, "buddies_status_change") == 0) { // Code style
Nope. This triggers the install of Java if you don't already have it, and displays the Java version (or "prompting to install Java" if it needs installing).

Eric Shepherd
Sent from my iPad

On Jul 1, 2012, at 1:25 PM, Marshall Culpepper <reply@reply.github.com> wrote:

> Looks like this might be left over debugging code..
1. border attribute is obsolete http://www.w3.org/TR/2010/WD-html-markup-20101019/img.html#img.attrs.border
2. Missing alt attribute
That is fine. Just making sure it wasn't by accident.
That one job should be removed according to Josh on IRC.
I would move this to be a decorator on the method instead. I think Erik would disagree but at least it will make the indentation less crazy.
not appropriate because failure is not a problem here.  In this class we've got several filesystem storage hierarchies. The error is only when we can't find a crash in any of them.   If you have a filing cabinet and you look for a file but you don't know what drawer it will be in, you don't have to report that you failed on any given drawer.
I have no idea what is better.  it's just a name for unique identification, not a symbol used for network lookup.
While you are it, please remove this empty line so that the function definition is immediately below the `*/` so that the doc parser can recognizet that they are related.
这个空格应该要有的，干嘛去掉。。
Why the choice of base62'ing the timestamp?  Is it a tweetbot requirement?
Typo: ContainsErrors -> NotValid
You should remove these 2 lines
What about using stdout by default here instead of throwing an exception?
Ok. I had that before but changed it after [this](https://github.com/symfony/symfony/pull/5032#issuecomment-7691634) comment.

I tried to stay here close with how it is implemented for the propel model type. This service for this type resides in an entirely different bundle (PropelBundle: https://github.com/propelorm/PropelBundle/blob/master/Resources/config/propel.xml). It's the same for the Doctrine Bundle. There the service for the entity type is registered in the doctrine bundle, not the bridge bundle.

I could register my types (or at least the translation type) in the bridge bundle, but then, why not register all types directly in the bridge bundles instead of the other bundles?
This should be `ExecutionContextInterface` not `ExecutionContext` =)
typo? src/java/com/twitter/common/commons/BUILD does not exist
Agreed. I made diffState() throw UnsupportedOperationException. Let me know if Scala has its own kind of such exception.
Noted. In the future I'll use `sign`.
They don't do http status codes? Lame
odd that the tests still worked though
Why not set the default for mutator here in the function definition?
If you'll do one more rebase anyway, I'd put spaces to around that `} else {` too to match the code style used elsewhere in the framework.
Although 'thie' has a nice ring... . we'll go with your change
Yes. Missed this annotation, seems like it works properly with. Should this be merged than?
You can do def.validateAndSet(operation, targetOperation) and catch failures earlier.
I think we should do something similar here with line number like what we did with the file name. As per the javadoc of stacktraceElement.getLineNumber(), a negative return value indicates that the appropriate information isn't available. So we should probably check the return value here and skip setting the line number if the value is negative. That'll prevent output like this one:

        "stack-trace" => [
                        {
                            "file-name" => "Object.java",
                            "line-number" => -2,

the -2 in there isn't useful to the admin who's issuing that command, IMO.
This line works in python 2.7, but not python 2.4. Centos5 users still have to use python 2.4 in almost all cases.

Is there no common syntax between python 3 and 2.4 here?

Maybe it's worth having two separate setuptools command modules, one for python < 3 and one for python > 3? Maybe 'pyfpm2' and 'pyfpm3' ?
woot, thanks for the details :)
Hmm, where does super() go here? I don't see any super class in the definition of Range. Looks though as if the original code had it too.
@longhengyu 注释和单元测试需要写一下
вот это зря. Во-первых там разметка которую надо экранировать (а иначе HTML ломается и оно вылезает перед шапкой сайта), а во вторых там разметка которой не должно быть в og:description.

Предлагаю для старых html'ных топиков не показывать og:description совсем
it seems the `found` will only be changed in onsuccess callback, right? if so, this checking will always be true here.
I guess you may want a transition to the fb_link frame at some point. Using |hidden| will prevent you to do that (because this is basically a display: none) , you may want to use something different.
Why do you need that? The lockscreen will always be portrait.
Maybe not checkSet, but I plan on moving the benchmark stuff at some point.
we can gain better performance if frequently used DOM elements are cached in module variables
For consistency purpose I'd set an image background in css like the other ones.
roger roger, need some sleep, you are right again.

Thx!
Got it! Anyhow, it will go in the next PR where I am merging this code with the contact info one. Thanks!
Yap, it's better to use className to change the style, not from JavaScript modifying the display property.
I used "invisible" class and add to classList to hide the nosongs div.
I actually think this dispatchEvent(new Event()) is a really nice idiom.

Are you objecting to the use of the CustomEvent constructor instead of the old createEvent/initEvent pair or are you objecting to the nesting of the one inside the other?

I know, I'll define the event detail object on a separate line, and that will make the create and dispatch code nicer...
Do you want a `es.refresh()` here after you've indexed?
Note the typo here kept libs from being recognized as such, but since there were none linked in any of the frameworks, it didn't present an issue until now.
explicit check for `0 ===` so that boolean is not implied.
Here is it.
It was mentioned mentioned two times, so I removed dup and sorted list to minimize chance of this happening again (considering list will stay sorted from now on=))
I replaced the methods named by color with methods named by what they're being used for, and tied them all into the config settings. I didn't think it would make sense to leave the methods named by color if the color it returned was going to be configurable.
I would probably just call `#freeze` on the object without the test. If it is already frozen it's a noop and quickly exists anyway.
please use dashes or underscores instead of spaces in the atoms
That one is ok, because the value is milliseconds.
But to the overwrite again ...my commit was wrong. new one pushed ;)
Again, I think you want this potentially in Source.  Suppose you want to store Cascading serialized (sequence-files) in Redis for instance.
My main concern is that it checks for empty args after a dash option, and then removes the option too. It assumes more about the structure of the input than I'd like it too at this part of the code. I would prefer the maven plugin to validate the input and remove the option itself.

I also just tried sending something via zinc client with an empty scala-extra option, `Seq(..., "-scala-extra", "", ...)`, and there were no problems for me. I'm wondering if you're seeing something different on your OS and setup. If so, can you send me more details. It may be that Nailgun itself is the place to patch this.
Add a comment in describing what this is.
You forgot to remove `typeof`. Also, to cast everything to boolean, you can just do `!!(this.min && this.max)`
"Set a default factory, if the node is new, and no factory given in the URL."
Add some whitespace so the property values align vertically please.
You mean "android/*/*/.DS_Store" is redundant of "*.DS_Store", right?
I agree. Just remove it.
Not entirely, (e.g., Win32 has no concept of signals), however I have a guarded #define in both win32/socket.h and unix/socket.h
New button to allow copying of an item in the equipment database.
Why is this creating a new instance, rather than just using 'self'?
Well, MySQL only gives you 768 bytes, which is 256 unicode characters, in an index.  Because there's an index over `name` and `class_name`, this is as big as we can make it.

The fix, which I don't want to mix in right now, and which applies to a bunch of other tables, is to do the key hashing in userland, and key on that.  It brings a risk of hash collision, but we're all used to ignoring that risk by now, right?
Oh, I see what you were saying: all I need is a generic getter/setter.

On Tue, Sep 4, 2012 at 8:51 PM, minggo <notifications@github.com> wrote:

> In extensions/GUI/CCControlExtension/CCControlSlider.h:
>
> > @@ -55,6 +55,11 @@ class CCControlSlider: public CCControl
> >      virtual void setMinimumValue(float val);
> >      CC_SYNTHESIZE_READONLY(float, m_maximumValue, MaximumValue);
> >      virtual void setMaximumValue(float val);
> > +    CC_SYNTHESIZE(float, m_minimumAllowedValue, MinimumAllowedValue);
> > +    virtual void setMinimumAllowedValue(float val);
> > +    CC_SYNTHESIZE(float, m_maximumAllowedValue, MaximumAllowedValue);
> > +    virtual void setMaximumAllowedValue(float val);
> > +
>
> Oh, CC_SYNTHESIZE already declares set function.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cocos2d/cocos2d-x/pull/1279/files#r1529943>.
>
>
I've read this line 10 times and I still can't figure out what the hell it does :(
riyad@3a119c29cc9c631d895eea0b686d62840d409643 is probably what you should be doing
Bonus points for Ruby.
could move to detect module?
Typo? Allocing pem * pointer size here (uint8_t*).
as commented on commit, hasUpdates has been removed from UpdateCenter so this notice will never render
These will need corresponding JRuby versions if that's to be supported ever.

For example [here's what I normally do](https://github.com/refinery/refinerycms/blob/master/Gemfile#L14-L30)
I don't see when `uri` is not going to be defined?
Let's check with someone on mobile team.
if we don't want to block the merge on this (technically not a regression), let's open an issue to track?
Thankfully, the comment is wrong, and we actually clear this *before* compilation, not after.  You should fix the comment.

Clearing after is what led to use using two different versions of this data to render the catalog historically, FWIW, and the inconsistency that brought to the table.
This code does not look like it's going to handle errors elegantly.  If `user` evaluates to false then it's either `nil` or `FalseClasse`, neither of which has the method `errors`.

I'm also not sure about the ordering here - we fetch the default group, then create a user model from the provided attributes, then add the user to the group, then check the user for errors.  It seems like it's out of order, but I'm not sure which parts are actually making changes via the AWS API and which are just creating things in memory.

I also don't really understand what the inject_attribute_to_fog_model method is doing.  It appears to be modifying some rendered JSON to put the default group name into it.  Why is that useful?
Looks like this changes behavior on 1.8? Is that intended?
Done and done - thanks Nick.
Please reflect all this imports as `use` statements at the top of the file.
I think the test is wrong. We still want the route match change; we simply want to _not_ set the status code, unless we have an HTTP response.
Why this need to be silence?
You can add the commit to this PR.
Good point, but since it's merged already I will address this in later PRs
this code is broken. First, ``$readmeFilename`` is undefined. Second, you should not be setting the readme but the config.
Telefono numeris:
That's fine. I just wanted to mention it in case you had forgotten :)
This should actually be items.get('length')
Again, var for local vars, as a recommendation.
XD Damm... more of them!
@piotras it is simply that your change here does not change anything except the message displayed in the suggestion. It has absolutely no impact over what is installed.
why default is ``''``? it would seem more natural to me to have ``None`` as default.
Change to the logic for falling back to a proxy in the _resolveHostMeta function. Now works with Google Apps domains that returns an unexpected document with no providers in it.
We use the org.jboss.spec APIs not the ones from Sun. Please take a look at other quickstarts such as kitchensink for examples of how to declare and manage dependencies.
As mentioned above, it is from http://inspirit.github.com/jsfeat/js/compatibility.js which itself also says 

    /**
    * this code is from all around the web :)
    * if u want to put some credits u are welcome!
    */

Found very close things 4-5 different places, e.g the original inspiration for this change at http://www.html5rocks.com/en/tutorials/canvas/performance/ 

I'll add the credit and the updates you mentioned. :)
Since PHP is fully blocking with sockets it's quite safe, since it's not possible to send more requests through the same connection, so the response will always be corresponding to request previously sent.
No timezone data? Weird. Is that how Django/whatever expects date strings?
Nah, the DB stores them in lowercase because request.locale and django.utils.translation.get_language return lowercase versions.
Fair enough. I don't think it's PEP8, but I'll defer to you here.
Can you revert this, then? I think readability wins here.
I did not know about the fragment argument either. Good points
There seems to be a lot of repeated code in these tests, some helper methods could cut down a lot of this repeated code.
Yes. Returning to the main backpack is preferable to popping open the issuer frame in a second tab or window, which is what Persona would do by default. But an even better fix will be coming in another pull request shortly (that gets rid of that TODO).