Make it easier to append a literal to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=94273

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-17
Reviewed by Kentaro Hara.

Source/WebCore: 

Use StringBuilder::appendLiteral() in MarkupAccumulator instead of computing every
value individually.

* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendXMLDeclaration):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendCDATASection):

Source/WTF: 

* wtf/text/StringBuilder.h:
(WTF::StringBuilder::appendLiteral): Add the method StringBuilder::appendLiteral() for efficiently
adding a string literal to the StringBuilder.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-08-17  Nate Chapin  <japhet@chromium.org>

        Add missing CR in bug identifiers in TextExpectations

        * platform/chromium/TestExpectations:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Delete some dead code in RenderBox::computePercentageLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=94262

Reviewed by Tony Chang.

I'm pretty sure this is dead code. None of the layout tests hit this code,
including the ones added in the original patch http://trac.webkit.org/changeset/10983.
I spent a good while and could not concoct a test that hits this code.

The test-cases added in that file, as well as the test-cases I came up with that should
go through this codepath, instead go through computePositionedLogicalHeight and never
hit computePercentageLogicalHeight.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix vsyncTick drought when vsync throttling is disabled
https://bugs.webkit.org/show_bug.cgi?id=94012

Patch by Brian Anderson <brianderson@chromium.org> on 2012-08-17
Reviewed by James Robinson.

CCFrameRateController made an assumption that every vsyncTick results
in a call to didBeginFrame, which is not necessarily true and causes
the CCFrameRateController to stop ticking when vsync is disabled. We
move the manual ticks out of didBeginFrame and manually tick in the
proper place.

CCFrameRateControllerTest updated with use cases that should tick
without a didBeginFrame and will fail without this patch.

* platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Introduce a will-be-removed-from-tree notification in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=94271

Reviewed by Abhishek Arya.

Following bug 93874, we have an insertion notification. This change adds the
matching removal notification (willBeRemovedFromTree).

Refactoring covered by existing tests.

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Removed the code from here and moved it below.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):
* rendering/RenderObject.h:
This is the base function that should be called by every instance.

* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::willBeRemovedFromTree):
* rendering/RenderListItem.h:
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::willBeRemovedFromTree):
* rendering/RenderQuote.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::willBeRemovedFromTree):
* rendering/RenderRegion.h:
Overriden functions.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125940 268f45cc-cd09-0410-ab3c-d52691b4dbfc