labofsahil/github-event-dataset-2012 huggingface dataset:
also, if  you look above, there is already a licence header :s
however: i would not fork this version, cause im still refactoring some parts. i want to make materials and packs be loaded / unloaded at will. also make the materials accessable for other plugins, so they can rely on spoutMaterials for their custom materials. This should basicaly make SpoutMaterials an widely usable plugin. People just have to create an instance of the (under construction) SmpManager and then load the smp files for their plugin and voila, they can add their custom functions to the materials.
Hi Michelle! We went to different high school together right? I knew it!
I think it was related to merging conflict that I had to fix, and I'm seeing a similar problem with https://github.com/nanliu/puppetlabs-f5/commit/7c7b7685ed6a514df2302acd694a9b02edc9c3be. I'll go through ticket 12325 again and see what I did wrong and if I can preserve your commits properly.
You are setting the affinity of the calling thread twice, but never of the rcv or cmd thread.
BROGRAMMER?
There isn't an additional member variable. I dropped _isFirstActing  and _currentValue and renamed _interpolatedValue to _value.
It seems like something in your editor is making welocally-places-tag.class.php think its being entirely overwritten, it would be cool if we could figure out what was going on so that didn't continue.
If I remember correctly, I recently noticed that 0.19.0.RC3 wrote its pid file as "{pid}\n" instead of "{pid}". Could it possibly be related to clintons test harness failure?
Verificar este trecho de código. Parece que esta perdido.
yay, awesome!!!
err is not set
inject(0) {|sum,n| sum+=n} won't do? :)
looking at this, `isActive()` might not be the best name.
`.activationNeeded()` ?
Heh.

More accurately, it assumes that deletions will be reflected in the `deleted` member, and that if `deleted` is `true`, the rest of the record can be ignored. If `FormHistoryRecord`s can never be deleted (and we need to fix that…), then that half of the conditional will just never apply.

Good spot!
Just wanted to give you an update. I rebuilt clean with the current
tree to make sure that I didn't have any stale files. Ethernet still
works for me. I haven't checked the patches again yet.

On Fri, Jan 13, 2012 at 11:36 AM, Frank Hunleth
<fhunleth@troodon-software.com> wrote:
> Ugh. There must be something subtly different with the patches that I
> didn't see. I'll double check this weekend. Thanks for helping debug
> this.
>
> On Fri, Jan 13, 2012 at 11:10 AM, Mark Jackson
> <reply@reply.github.com>
> wrote:
>> No ... it's still not working.
>>
>> I can't ping with commit f9614a157d23ed5d10e5b148e723c70ba611a84d.
>> But ping works with commit 10ef7e71118146fd91cbb5fa01f6a3b704b75897
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/fhunleth/buildroot-beaglebone/commit/f9614a157d23ed5d10e5b148e723c70ba611a84d#commitcomment-865241
>
>
>
> --
> Frank Hunleth
> Troodon Software LLC
> 240.397.8766 | fhunleth@troodon-software.com
> http://troodon-software.com/



-- 
Frank Hunleth
Troodon Software LLC
240.397.8766 | fhunleth@troodon-software.com
http://troodon-software.com/
On Tue, Jan 17, 2012 at 10:52:27AM -0800, Alastair Porter wrote:
> It looks like unittest2 is a separate package, not part of the standard library. Is that correct? (http://pypi.python.org/pypi/unittest2)
> It would be nice if we could automatically pull in this dependency using something in setup.py. Alternatively, issue #33 appears to have a fix that doesn't require extra packaging.

The way I see it, the people wanting to run the test suite are probably
able to install unittest2 if needed: if they are total beginners in
Python development they would have either the latest Python installed,
meaning that there's no need for unittest2 in the first place, or are
using a platform offering tight package integration such as a Linux
distribution, which means that the dependencies are much easier to
handle (assuming that mbngs will be packaged by the major distributions
out there, which seems likely given that it is a dependency of beets).
For instance, as soon as my package gets uploaded to Debian, a simple
apt-get build-dep python-musicbrainzngs will suffice to install
everything needed to build the package, including unittest2.

If they are no beginners, I think they can handle installing unittest on
their own.

For me, there is a few problems with the approach used in #33. The first
is that the semantics of the test have changed ( >= != == ). For the
second, I'm not so sure, but I seem to recall some warnings about
equality tests and floats in my CS classes. And finally, the test output
will be a little more obscure in case of a failure.

Cheers,

Simon
SG, do we still need to do this if we're not using the .navbar-fixed-top in the page.tpl.php?
Not yet. Do you know which API calls this affects.

I see, for example, that we would need this for "GET /repos/:user/:repo/commits/:sha" call. I think this API call should be represented by Repo.commit(self, sha) method (similar to Repo.issue(self, id_)).

I can implement Repo.commit tomorrow. Are there other GET calls that you know of that are affected by this change?
Same here:

java.lang.AssertionError
	at vanilla.java.affinity.impl.VanillaCpuLayout.<init>(VanillaCpuLayout.java:49)
	at vanilla.java.affinity.impl.VanillaCpuLayout.fromCpuInfo(VanillaCpuLayout.java:120)
	at vanilla.java.affinity.impl.VanillaCpuLayoutTest.testFromCpuInfoOthers(VanillaCpuLayoutTest.java:93)
This can't possibly work. You don't even have ```cid``` here...
GitHub for Mac apparently uses autocorrect by default and messed up my commit message. Yay.
You can skip the reflexive pronoun with authenticate. This way the text is more gender neutral.
I'm curious about the heat changes, as I have seen the printer sticking consistently on some papers when printing horizontal lines, although this didn't seem to happen with the paper that was shipped with the printer. Can you elaborate why you were considering making the thermal changes?
I hope this is not your real Serial key?
And the downside for creating on-demand windows in iOS would be memory issues? I have using the re-use Detail window model fine with iPhone, and didn't notice too many issues on Android, but I will try this out.

Thanks for the help. My latest update includes these Master/Detail like templates integrated with a tab view, just want to make sure I am following best practices. And then throw in replicating a similar structure in iPad with a SplitView, things get a little more interesting.
I think that is just a merge gone wrong - i had started on a (accidentally) stale checkout that predated Fog::Core::JSON
We can create a general init function in a base list item widget so that we don't have to define it in most list items.
I'm going to make that change and then pull this in.
I think the diff is misleading here; I didn't touch that code.  In any case it's not a bad suggestion.
To further explain the behavior based on @leleuj 's comment:

* The usage of `DEFAULT_OPAQUE_USERNAME_ATTRIBUTE` is automatically determined when username attribute is set on the service. If the value received matches `DEFAULT_OPAQUE_USERNAME_ATTRIBUTE` the service is automatically marked as anonymous. Therefor, the line `registeredService.isAnonymousAccess()` will take effect. 

* If the username attribute is set to null through code perhaps, or is set to be `DEFAULT_USERNAME_ATTRIBUTE`, then the principal's id is returned. The above code is incorrect in that it should really be:
`registeredService.getUsernameAttribute.equals(RegisteredService.DEFAULT_USERNAME_ATTRIBUTE)`

* if the service is set to ignore attributes, or the username attribute exists in the allowed attributes for the service, the corresponding value will be used.

* otherwise, principal id is returned as the username attribute with an additional warning.
yep, and it will be deregistered through supervisor later.
I understand that this way of writing out explicit `immutable.Seq` makes it clear, but it's not very concise, an alternative would be that we always have `import scala.collection.immutable.Seq` in all files where `Seq` is used.
Starting to feel the need for scalastyle
why pass sender in Message and not use forward?
I'd strongly suggest you Let It Crash(tm) and have postRestart and preRestart set up the connection.
Also if there was support for unsigned integers in Java :-)
again, not worth it
Please reformat this so that there is one package per line. That way, future diffs will be smaller and more easily reveal what changed.
Actually, if you want to do it perfect, then split it into commits: The first one doesn't change anything except formatting. The second then does the rewrap. This can be achieved with a rebase, and I would offer to tell you on IRC how to do it step-by-step, or do it for you.
The other option is to make the stepper callable, ie have stepper.__call__ instead of stepper.step, what do you think of that?
Is member is the same as public? Could we just use public here?
Ah, is the guy responsible for the search?
Might be reasonable to speak to him.
Having these strings here means people need to edit the core code if they want to change them, before they could just override a template file. Maybe not a big deal
Ok, I think a clarification on ho `alias_native` works is needed:

`alias_native :ruby_method_name, :javascript_method_name`

hence writing

```ruby
alias_native :sort!, :sort
```

is the same as this:
```ruby
def sort!
  `#{self}.sort()`
end
```
It does look like I'm trying to express some potentially in appropriate emoticon, doesn't it? I'll try something new.
I think this the the actual magic needed for load to work.  I think it was only in the CardConroller allowing some stuff to work.
(let's trim out unused methods)
Just so you dont forget to f.close, we use with statements for these things:

with open(filename, 'w') as f:
<indented block that uses f>
I'll make it `mrjob run <blah>` instead of `mrjob blah` for now.
and recursively
lets just call this cast instead of ascribe throughout
Hay que quitar este metodo que esta conectado
Where we had just a pattern, we have a pattern and a count of the parenthesis groups in the expression.  All of the expressions are reworked to match the same, but to be more minimal in the groups so we get exactly the ones we need.
Ca me paraît plus simple. Mais c'est subjectif.
We can still give them a name, especially since they're flipped for horizontal and vertical scrollers.
Please add `@property(nonatomic, readonly, strong) TUIViewController *visibleViewController;`!
I would rather this override the `view` property to simply change its type to a `TUITableView`. Having two properties for the same thing is one of the annoying things about `UITableViewController`.
Not a question
Instead of sniffing for IE, you can use the IE-specific [`document.documentMode`](http://msdn.microsoft.com/en-us/library/ie/cc196988\(v=vs.85\).aspx) property.
Initially I loaded the context in the **cli** module instead of the **pluginmanager** module. We can delete this line.
What does this else test for?  ``defaults`` cannot be None, due to the definition of _get_argspec, so I assume zero?  Either way, should be explicitly written as

```python
if defaults == 0:
```

or

```python
if defaults is None:
...
else:
...
```
warning: control reaches end of non-void function
if the short SHA is sent in the ENV variable, this is still a problem right? I 'd suggest to remove the ENV check for the full version.
We need to document those methods
Not sure I follow what do you mean
About rethrowing. I don't think an unlucky macro user should pay for the fact that our heuristics failed.
As mentioned in the commit message, we decided to abandon navigation between mirrors in 2.10.0.

For example, one of the idea was to have `reflectMethod(name: String)` directly on `InstanceMirror` instead of having to look up a method symbol first and then call `reflectMethod(meth: MethodSymbol)`. This is convenient, but has far-reaching consistency implications, so we decided to avoid this responsibility in the first release.

In this spirit, I believe we should drop `TemplateMirror.companion` and have people go through the regular process (acquire a `companion` from the underlying symbol, do `reflectModule` or `reflectClass` on the result).
yes, TypeRef(Bippy).typeSymbol == ObjectClass

the "normalization" I'm doing here is something that doesn't happen in subtyping because Prod is not a subtype of AnyRef
however, during instanceof tests (which is really what this method models) these types are indistinguishable

in other words, I'm collapsing Object, AnyRef and AnyVal to Any, because that's the resolution we have left once we start comparing 
types at runtime using isInstanceOf (of course I also need to take into account isPrimitiveValueClass)
temporary string based on what? it's weird that a filename is passed in (should this just be name)? and a max len is given, not exactly sure how to call this method.
Does this return a tuple? I don't think it should.
I wonder why `"A"` and `"S"` is used, rather than `"alternating"` and `"symmetric"`.  I'm not really familiar with this code, so it's not criticism, but rather curiosity.
I'm not sure what this hash does here, but if it is a comment, I don't really understand why it is added.  I do still get a `TypeError` (in `master`) and so I'd think that leaving this example as it was would have been fine.
If n is odd, say 5, the you add s to 0 and 1, t to 2 and s to 3 and 4;
but if n is even, say 6, then you add s to 0, 1, 2; t to 3; s to 4 and 5.
no need for this. You should put it in Request.prototype with an initial value of null.
removed that addition again as it is more confusing than help understanding.
He ment that the expression-message pair is itself separated with #
Not the most elegant piece of code I have ever written, but this works. Thanks, @blampe.
Is the resulting assertion error going to be clear enough? Like, will it be obvious that assert_in is being triggered from assert_raises_and_contains?
`use ($roles)` is missing.
Style: should line up with the first argument.
Can JoSQL handle the opposite of `downstreamVsn is null` as `downstreamVsn is not null`?
This default should not exist.  My comment below says to get rid of it altogether, but I wanted to just make a comment that this default shouldn't exist.
delete this bullet.
Aw, man, we're going with currentOP, not currentOp?
this needs a corresponding update to the test_profile_edit test in apps/devmo/tests/test_views.py (line 180) since we now have 2 `#profile-head .edit .button` elements
`conf` before `utils`. See http://mozweb.readthedocs.org/en/latest/coding.html#import-statements
Well the result on memberlist.php is cached and also there shouldn't be too many rows in that table anyway
This is a candidate for testing. This regexp should be moved into its own function and tests written against it and various data sets it's supposed to be applied to. This could be done in a later PR.
Is unique_id available to the installer?
And what is $custom_html?
From what I recall names were not supposed to be mutable, what exactly happened?
<script type="text/javascript" src="/boards/x30//styles/prosilver/template/forum_fn.js?assets_version=3"></script> - extra slash.
Leaking into global scope here.
The plugin system will still have to convert values to the correct type before passing them in, so you're passing in the type information twice.
Is this private or smth?
No risk of '$' in type name ??
Maybe have helper method:
  Appendable appendJavaType(Appendable out, Class<?> baseType, Class<?> typeParams);

I.e. appendJavaType(code, Iterable.class, targetType).append(" data\n");
Won't `logLevelOrder[0]` now always be `debug`, since we're always using config.json?
Missing XML comment that describes the intended usage
Not sure that the `ITextResource` and `DefaultTextResource` (or what ever it ends up being called) should be stored in the `ViewEngines` folder. It's not view engine specific and could be used for other stuff. Maybe something like a `Nancy.Localization` namespace might be a better fit?
@johnstoecker  would this be possible to fix now? When I browsed this code earlier, I didn't see any problem with fetching and saving these during startup instead of here. Would be nice to put all "OpenMRS setup" in one place, rather than doing anything dynamically (like fetching drug concept)
We need to finalize what we should use here, tehsil vs. area vs. county
This shows N+1 values being divided by N. I think this is inconsistent with the implementation.
The original is more consistent.
在外面设置属性。避免冗余代码
Correct the indentation problem for this whole file. This problem may only exist in this file that was changed long time ago by vim. Thanks.
It should be 
if(flag == 1 and line.find(end) > -1):
The link should lead to a search for models, not for the group.
Whats the # NOQA comment reference?
I suspect that fewer developers will run Coverity than compile on Ubuntu 12.4. I'd rather silence the compiler warning.
Well, create_index_name already shortens names so they fit within whatever the limit is set to in the features. Plus, I don't want this module to depend on creation (as that's going away eventually), so that's why it's not used. Precise matching of names with the old code is not important, as anything which changes indexes/constraints does a search for them by columns and type first.
I don't think additional reading is required -- test without fix is failing. I guess the lists are not needed.
Maybe the same Q like last one, why not, just want to know for the future commits?
There's a space missing after the colon ;)
The line wrap and backslash above is not needed.
Please, change the attribute from classical to classical_bcr
[Agreed](https://github.com/jckarter/clay/pull/352).
On Sun, Apr 1, 2012 at 3:44 PM, agemogolk <reply+p-631168->
>  Not convinced by the pipe idea you suggested for handling variadic
> inputs to infix operators. I guess the issue is the evaluation of
> operand expressions prior to passing the infix chain into infixOperator.
> One solution could be to pass through the unmodified section of the AST
> and handle in that in the library. However that seems impractical.
>
> I'm still concerned about compile times and that the
> infix-/prefix-Operator setup is going to balloon into a full blown term
> re-writing thing. Exposing/modifying  AST should probably be done from a
> single point __AST__ or whatever.

I had been thinking that an __AST__ operator and `eval` support for
ASTs is ultimately the right way to go with this. But as you said,
some cute potential uses of variadic arguments are probably not worth
the effort; it's really just an accident of the desugaring that they
happen to work.

> So I'm wondering whether it would be better to move operator handling
> back into the parser, use top level symbol definitions for custom
> operators and use the afore mentioned Pratt parser to sort it out.  You
> would still get the user defined ops/prec/assoc just tabulate operator
> specs during parsing as well as processing symbol as usual i.e. define
> (**)[LEFT,1000] or define (**, LEFT, 1000) or whatever.
>
> Or do you think the current approach can be sufficiently extended
> without getting messy?

Aside from the variadic arguments issue, are there any other
outstanding issues with your current implementation? It seems like
we're closing on a usable interface based on the current low-level
interface.

-Joe
Why stable?  It looks like IMMUTABLE.
@haying: Small typo on the comment. That should be Newton method.
I'm not sure -- if someone calling _encodeString has a null value, is that a bug or a feature? If they want to have an empty string encoded they should probably make it an empty string explicitly. I could argue that keeping it null makes it easier to reason about if debugging code using this. Or we could just throw an error in case it's not a string...
Should test date_end, too.
Just use `system "./bootstrap"` here (is this needed for the stable build, or just HEAD?)
commenté supprimé?
Is MtechUssdResponse something that should be exported here?
Should we maybe use http://twistedmatrix.com/documents/12.0.0/api/twisted.trial.unittest.TestCase.html#mktemp? I think that gets created in _trial_temp somewhere.
I prefer

Remove RedditContentObject methods by URL. from cache.
Is that really a concern that one moderator will be able to see the deleted account of another moderator?
See above comments on getClassesAnnotatedWith()
It was done with a script, and I thought I'd fixed all of the duplicates, but obviously not. Fixed now.
Yeah. I am having problems adjusting to junit-way of things. I have left back my C and ASM - Background with great pleasure and now work as a JavaEE - developer in agile teams where its really important to leave code easy to read and easy to understand. Just ignore my comments if I critizise anything that is common practise. Its just my advice and its not based on any junit-code-base-knowledge.
These comments don't apply to anything. Delete?
Are you 100% sure this generates two separate edits?  (Not sure if it needs to for the test to be useful, but it seems like that's the code's intent).  Looking at CM's History.addChange(), it seems like adjacent edits that are close together in time would get merged into a single change record.
If this was ```this._command.execute()```, then you wouldn't need to swap handlers when the command changes.

Also, do we need to support swapping commands on the fly at this point?  It looks like getMenuItem() isn't a public API, so extensions wouldn't be able to use this method to override an existing piece of Brackets UI...  I can't think of other use cases that we have right now.
The test, as is right now, expects indeed an empty list. 

I thought you wanted me to pass `test</p>` as the `hintLineAfter` argument, in which case the IP would be positioned between `title=""` and `>test</p>`, and that is covered already in a different test.

What would you want to do with this test?
``{function($.Event)}``?
Now that the following logic is simple, it would be cleaner to replace the whole `if` statement with:

```javascript
CommandManager.get(Commands.FILE_LIVE_FILE_PREVIEW).setChecked(status === LiveDevelopment.STATUS_ACTIVE);
```
Whoops. Thanks. Fixed.
menuID and menuItemID aren't real types... I think it should say "string" and then in prose document what the string means.
Typo: froEach -> forEach
spelling error in "Seqnuence"
-S is synchronize (local to remote)
--needed is install/update only if it's out of date or not installed already
@Seldaek done.
Can you please add docstrings to this, to describe constructor input?

Also, the bullet list in this class doc will probably not format correctly in the generated sphinx docs. (See http://sphinx-doc.org/rest.html#lists-and-quote-like-blocks.) If I remember correctly, the best way to construct bullet lists is like this:

<pre>
This is the text leading up the bullet list, with a an empty line between:

* This is the first item.
* This is the second item,
  which spans multiple lines.
  Note the alignment/indentation of the second and third lines.
* Item number 3.
</pre>
Would it be better to use string type values like "yes" or "true"? This would make the check later look nicer.
Use `rugged_str_new2` instead of `rb_str_new2` and add `rb_utf8_encoding()` as a second parameter.
Another unneeded semi-colon.
oh wait. offsetHeight
I saw that, but why? Doesn't look like it has a side-effect.
Can we remove this comma?
True. This is how it's done in our test files inside butter right now. I think <script></script> is correct, no?
not sure which you're referring to. If you're using interpolation, having a trinary with empty string is not necessary. nil will to_s to "".
Twisted doesn't have log levels.  It has a mechanism for logging messages, and a mechanism for logging exceptions.
You don't need another pull request, just commit and push to the same branch of your repo and this pull request will be updated by GitHub =).
Mmmhhh... I could be ok for allow to report a message for unlogged user, but I've never seen a forum that allow unlogged users to add messages in a forum. Plus I'm pretty sure this will lead to TONS of spam.
This is usually written as:
if type(value) != type([]]:
In general, I'm not a huge fan of putting all of this in the JS.  Would it be possible to do this in HAML and insert it as part of the page's render?
I think you're reading that wrong.  KTEnvironment.systems_readable(org)  returns a list of environments that the user can read systems in.  SystemGroup.systems_readable(org)  returns a list of system groups the user can read systems in.  These do not return a list of systems.   To do that you'd do something like  System.readable(org).where(:kt_environment->:id).  

These are scopes, and so they are intending to return a list of objects of that model.
finish this line?
This is totally useless. The argument is typehinted
The original code is good, no need the `if else` here.

Should be

    if (!this.conn) {
      console.debug("No mozMobileConnection :(");
      return;
    }

`conn` could be `NULL` (available but disabled) or `undefined` (unavailable)

What we really need to insure is the `this.hideKeypad()` on L22.
Right, so the version number in master after the release should be '0.2.dev'
I don't think the current `parse_angle` code meets the standard that it will interpret any unambiguous string that "a human could interpret".  The latter would include any sort of typos and a huge range of other oddities that will currently fail in parse_angle().  This is too vague, and I think it would be much more helpful to have a detailed section (appendix) that provides a fully-enumerated list of all formats that are accepted.
Yeah, I'd prefer to wait on additional stuff if you don't mind. I was trying to minimize the amount of changes before release, but I do think we should eventually add a separate section to the docs for developers of this library.
I really wouldn't delete bdb database files yourself. Use the dbenv methods to do so.
Oh duh! Right. My bad I was reading the wrong line. But it would be good to
match an https URL as well :)
On Jun 27, 2012 4:55 PM, "David Fowler" <
reply@reply.github.com>
wrote:

> > +            return TaskAsyncHelper.FromResult(new
> ContentProviderResult()
> > +                                                  {
> > +                                                      Content =
> string.Format("<iframe src=\"https://embed.spotify.com/?uri=spotify:{0}\"
> width=\"300\" height=\"380\" frameborder=\"0\"
> allowtransparency=\"true\"></iframe>", spotifyUri),
> > +                                                      Title =
> string.Format("spotify:track:{0}", spotifyUri)
> > +                                                  });
> > +        }
> > +
> > +        private string ExtractSpotifyUri(string requestUrl)
> > +        {
> > +            return requestUrl.Remove(0, 1).Replace('/', ':');
> > +        }
> > +
> > +        public override bool IsValidContent(Uri uri)
> > +        {
> > +            return uri.AbsoluteUri.StartsWith("http://open.spotify.com/",
> StringComparison.CurrentCultureIgnoreCase);
> > +        }
>
> Doesn't matter if the link itself is https or not, it's more about the
> embedded content
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/davidfowl/JabbR/pull/521/files#r1063624
>
I have no idea what day of week is 2011-01-01.
Please add comments with "cal" command output.

>>> cal Jan 2011
I believe its more efficient to use <code>i.data IS NOT NULL</code> instead of using the prepared statements.
Can a error be thrown with something else than bad JS in a script tag ?
Why is this _msg instead of msg?
Could the user have `__file__` in the user namespace before for any reason? If so, removing it could break other things. One way to approach this is to save the previous value, and put it back in the finally clause.

I see we were already deleting it before this. Pull requests are sometimes a prompt to think more carefully about things like this.
is this really nullable?
@philsturgeon Would not be happy about this. :)

return "show columns FROM {$table}";
It is now updated to like what you said : check this pull request 
https://github.com/laravel/laravel/pull/1273
`giterr_clear()` here please
No, git will always put correctness first over optimization. So we will check if the file is binary, even if it means loading the whole thing in memory (but if you _have_ a streaming API, then obviously you should only load the first 4K to make that determination. And use the `-diff` gitattribute, of course. Git doesn't do the streaming thing now, but it should). The size of the file never impacts the decision on whether it's binary. But once we know it's binary, then we can avoid loading it if we haven't already.

We do a similar thing with filters. We used to fail to run filters for the large-file streaming code paths, but that's wrong. You can't stream in the face of filters (well, you can, but it's tricky), so now we do the correct thing, and avoid the optimization if we have to.

In practice I doubt it comes up much, because large files _are_ going to be binary. So it's important to be optimistic about making sure the optimizations work in the common cases, but fail to slow-but-correct if we have to.
We have a method for wrapping callables into a Task (Tasks.callable) that may be confused with this. The former is designed for non-blocking, fast computation. We could can call this AsyncCallableTask to disambiguate the tasks and their purposes.
We don't use gettext on mozilla.org (unfortunately) but our own custom format because that's how all the l10n is currently setup. Using the underscore _ is fine, but the trans block can't be used.

We'll most likely need to build something with similar functionality. I'm not happy with that, but it's really the only sane way to move to bedrock for now (can't completely replace the current l10n system). I'd recommend removing the trans block and adding a comment with a TODO of hooking in our system here. This won't be localized yet, right?
Ditto re: explicitly creating the forum.
I have no idea what I was talking about here, so I nixed it.
Actually, that's wrong.  I catch the KeyError specifically, and then also catch ObjectDoesNotExist
I actually just copied that code from the UI. Will fix and use uppercase.
Rm these lines because it's tested in the test above.
After the mv, I think you need the Z suffix here too: ``zcat /tmp/landfill-`date +%Y-%m-%d`.sql.gz.Z``
You can use:

```ruby
x, y = conn.multi do
  conn.get('x')
  conn.get('y')
end
```

and avoid all the future complexity while still pipelining commands.
Why not use the CroogoHtmlHelper for the bradcrumb?
Refactor this duplicated code into a protected method or a global `$_default` attribute
Why this? Seems like it would end up leaking erlang terms, which I would like to avoid in any data going out to users.
Really nice. I love the method name change here!
@pborreli Is used in the other validation methods to sort the options, so I just follow the `standard`.
what is this hardcoded Sensio stuff ?
the comparison should be strict
How do you return the reference to the service "security.secure_random" then, that the bcrypt encoder needs i its constructor?
Symfony\Component\Security\Core\Encoder\EncoderFactory->createEncoder($config) only allows a plain array with no references to the DI container to be passed in $config['arguments'].
you have extra lines at the beginning and the end of the class
Yeah, this is clunky. I think the method name shouldn't be runtime-centric, since things other than runtime could determine whether or not this view can be rendered (i.e. job state?).

As for the event/job part sometimes the payload contains events and sometimes it contains jobs, which is unfortunate. So we'll either see data.event or data.job in this method, but not both.
`it an` reads oddly. What about `it 'requires an event to have suggestions'`?
4 ta kar nemikone
agar neghdar ham bedi px mikhad !
Can you always assume that if status isn't OPEN or UP then it's an error? What if they add new statuses in future versions? Is there an explicit status value for errors?
Minor stylistic note: for functions, we put the opening brace on the next lie.
this is for couchdbkit's change from 0.5.x->0.6.0 on changes feed listener. i detect the version and choose accordingly.
It isn't so much that I mind defaultApplication or the problem this pull request is solving.  I just think it would be cool if the View checked its Namespace first to see if it was an Application and used it. So an instance of MyApp.FooView would prefer MyApp.rootElement.
One more :-(

you should put a "var" in front of this variable, otherwise it will end up being global.
I really don't know what I was thinking here. Allowing the param at all seems silly if it can only have a "true" value.

Something like this would make some sense:

assert reloaded || !this.reloaded : "Once a process is reloaded, always reloaded!";

But I don't see what the point of that is either. The only uses of this are to set the value to "true".

If this class has snuck out and become visible to extensions, removing the param might break them, but I don't really care; no extension has any business calling this method.
That's a great idea ! thanks Tom, I'm trying this way.
I kind of like the `aria` option, since it provides a dedicated object that can be used for any numer of aria related options without cluttering the option set itself. For example, for some complex widgets there may be various sub parts that each need independent configurable roles, names, descriptions, relationships etc. The `aria` option could be used for other things as well, e.g. whether to use activedescendants or a roving tabindex, specific strings for live regions, aria-controls values,  and so on. It's something that can be useful future widgets. Having said that, in this particular case a `role` option would suffice: leaving it empty would mean no activedescendant is used.
@jzaefferer, sure, I read the comment. I was saying that Jenkins would have a problem, not me. Are you saying that installing `grunt-cli` on the Jenkins box will take care of both Grunt 0.4 and Grunt 0.3? That's good to know. 

However, what about the case for `npm test`? Is it not good to install `grunt-cli` so that `npm test` will work out of the box? Not that I feel strongly about it, but I'm curious what your opinion is.
That's fine. We're doing a big cleanup of dialog right now anyway, so this will definitely get fixed.
This fails the linter because it has unused parameters.
So because `_on` is like an event thing, we put spaces after its `(` ?
Please remove the unused line
AFAIK (please someone correct me if I'm wrong), we don't have secure storage, and don't know what's the best place to store this information.

Someone with access to the physical device could get the access_token and perform the operations the apps is allowed to do (as far as I remember we ask for permisions for posting into the wall?).

Also we could have an XSS attack in the contacts app (what if a contact has a surname like 'alert(&quot;BAD&quot;)' ... we didn't pass the security review for contacts yet, but I'm afraid this would need to be taken into account as well.

Pinging @AntonioMA for some security insights about this.

Not saying that is not the solution, maybe is the only one, just raising that could be a security problem.
My test case is external images just like the mail I forwarded to you. Here is a trick in jQuery : http://css-tricks.com/snippets/jquery/get-an-images-native-width/ . It looks like image size would be accessible after img src set.
The default case is the little arrow showing since we do not know if there is a contact available yet :)
L69-L74
You need to generate this in order to not break DEBUG=1 / GAIA_DOMAIN=foo.org. Also why do you need to send this information?
this should be `===`
pmode -> newMode
Since the popup is dynamically sized everything is looking good to me.
Where can I test the specific persona test case?
Actually, thinking about this some more...it might be good to add a test for that: have a test that finds all the public instance methods of `HTTPInteractionList` (that were defined directly on it, and not on an ancestor), and assert that `NullList` has all of them as well.
Rundeck のリソースモデルフォーマットが生成できる限り、あやゆるソースからリソースモデルデータを取ってきて  Rundeck に取り込むよう設定することが可能です。
↓
Rundeck のリソースモデルドキュメントフォーマットに変換すれば、様々なソースから Rundeck にリソースモデルデータを取り込むことができます。
Roll this into the assert
I think logging it is enough unless different reasons for failure mean different execution paths.
Who(which) is calling > this action ( third person) > take an 's'
I guess :-\

@+
Philippe
Le 20/08/2012 17:55, Marcos García a écrit :
> >  				// Uncomment this and change MYOBJECT to your own tag if you
> > -		        // want this action call a trigger.
> > +		        // want this action calls a trigger.

-- 
Atoo.Net <http://www.atoo-net.com> 	Philippe GRAND
265 rue de la vallée
45160 Olivet
02 38 63 90 20
philippe.grand@atoo-net.com
I can't accept that...
Makes it more readable since the line is already split once.
Just a style issue here.

I think

    } else if (tMaxY < tMaxZ) {
    /// code
    } else {
    /// other code
    }
    

is better
Is this really all the dependences? Do any of the gems have sub-dependences?

On Tue, Nov 6, 2012 at 2:05 PM, Brandon Holt <notifications@github.com>wrote:

> In README.md:
>
> > @@ -8,11 +8,11 @@ However, there are several dependencies:
> >  - Ruby version >= 1.9
> >  - Rubygems (should have come with the latest Ruby installations)
> >  - gems:
> > -  - grit (git integration)
> > -  - sequel (database output)
> > -  - sqlite3 (note: this also requires sqlite3 itself to be installed)
> > -  - open4
> > -  - awesome_print
> > +  - `grit` (git integration)
> > +  - `sequel` (database output)
> > +  - `sqlite3` (note: this also requires sqlite3 itself to be installed)
> > +  - `open4`
> > +  - `awesome_print`
> >
> >  To "install", `experiments.rb` simply needs to be on your RUBYPATH, so you can either add this directory to your RUBYPATH, or symlink the file into an existing directory set aside for Ruby libraries on your system.
> >
>
> I think we should add some more instrutions for how to install (i.e. check
> out from github, etc).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bholt/experiments/pull/4/files#r2049083>.
>
>
This should be:
self.updateSourceProperty('got_revision', revision)
Why `arguments.length is 2`? The second parameter shouldn’t be mixed with options IMHO. See [https://github.com/chaplinjs/chaplin/issues/249#issuecomment-10295785].

```
match 'url', {controller: 'c', action: 'a'}, {some: 'options'}
```
I agree, it was a copy-paste from the keypad code.
I can write it in another possibly less efficient way:

```coffeescript
delete @[index + @length] for index in [1..deleteCount]
```
I will provide an example soon.
Don't touch this file, revert changes
SCFree(sm) on it's own line
The `resolve`, `reject` is compatible with `Q` `resolve`, `reject` so I'd like to keep them. Also in general I follow a convention of calling functions with verbs and adjectives if they wrap things to produce new things.

P.S.: Technically promise is what's defined by a [spec](http://wiki.commonjs.org/wiki/Promises/A), if object has `then` with different semantics it's not a promise.
this doesn't do what we intend.  if you kill SIGSTOP the dependent process, then 'connect' is never raised and the timeout is 120s.  I think what we want is a guaranteed maximum time for the check as perceived by the application.
@seanmonstar - exactly why we have code reviews.  Nice catch.  Updating.
I'm not sure exactly what to do here, feel free to add a commit to this branch or leave a comment with exact syntax of how to properly clean this up. Otherwise, we'll remove it to avoid Chrome issues.
because it will increment after ``===``
Also, adding new tests for your change/feature, in the same vein as the ones affected, would be greatly appreciated!
`MessageExpectation` is related to the thing we're building. The reason `stub` and `should_receive` return MessageExpectation is so we can chain the other declaration methods e.g. `obj.should_receive(:message).with(stuff).and_return(other_stuff)`. End users don't assign the `MessageExpectation` to a variable.

`stub_const` is going to either return or yield something related to thing we're replacing, not building. It can't, by definition, be consistent with `should_receive` or `stub`.
we don't do _private methods in bootstrap
That's legit and I thought about doing that as well. 

I decided to use `'disabled'`, when you set the state of the button, because I felt it was more clear than using `true`.

E.G.
`$('#some-btn').button('complete', 'disabled');`

vs.

`$('#some-btn').button('complete', true);`

---
That said, using true would make for a more clean comparison :)
Why this class is preffixed with Abstract without to be an abstract class?
* The is_string() check handles the $location undefined condition, raising a notice, but returning a boolean correctly and not failing
* I agree that in the case of an invalid $map the error becomes less useful, though the error would show that the "file" provided is clearly unexpected and not a file. At any rate, this would only be hit if the function has unexpected input of neither string or array. It's there for consistency and in case the code gets refactored and the exception is overlooked.

I just had a more thorough look at the file. I'll add a few more changes in another commit.
Now it's Zend\Cache\Storage\StorageInterface as CacheStorage ;)
Got it. Is it ok to put it under standards? I remember I saw this few places else in ZF2
FYI: In shell scripts I usually like to put the `then` on the same line as the `if` to conserve vertical space, as in

    if [ ... ]; then
Auf euren Servern ist m.M.n. eine neuere Version als 5.3.10 (bei Rotex besteht das Problem nicht).
Das Problem tritt hier auf unserem Entwicklungsserver (i42, 5.3.3-7) auf.
Warum hast Du das geändert?
I'm not seeing the need for a Runnable either.

We can simply suspend the client until they pass the login screen no?
Portal creation has to occur after the fire is placed so that the fire can be extinguished by the portal creation sequence when the portal is proper but can't be generated due to a conflict with an already existing portal.
ah, scratch that. had a brain fart, these are not equivalent
Not sure what the standard is here.
Use `sprintf` to build these type of strings
CS issue (and for next methods too)
This shouldn't be part of the view. It should be in a controller. Also, why are you doing it here anyway?
Looping through `self.videos` is a simple approach but is technically inefficient. `videos` is a deferred property. The contents are loaded only when you access it for the first time (per request). It creates a rather large query: `SELECT * FROM video WHERE id IN (SELECT * FROM playlist_video WHERE playlist_id == ?)` and then instantiates ALL video objects in the list.

You are not using the remaining video objects, so there's no need to load them. You just need to find the first video where `playlist_video.seq` is +/- 1 from the current video. There's probably an SQLAlchemy pattern for this already.
Don't catch Exception, but use the exact type.
Can there be more than one hit? If so, you will only use the last one.
Sorry for that, only tested it on OS X before merging as well. Fixed in master.
isn't it used by old-style login only?
I had to change the test because it returns 1 un-vouched result and because it's only returning 1 it loads the profile page of that user. So i created another un-vouched user so i didn't have to fully change the asserts
Scott based this fix on 1367 the pull# is 240. We'll have to rebase/ cherrypick and then update this pull
This docstring is confusing to me. Perhaps it might be better written as:

Returns `maybe_iter` if it is an iterable, otherwise it returns a single element iterable containing `maybe_iter`.  Passing a type or list of types in the `unless` keyword forces the latter behavior for things which might otherwise be iterable.
yes, the FW version is easier to maintain, so please do send that, thanks a
lot.
I had a quick look and it looks great. One small nit:
The "target" is a regular expression, so you should escape periods and make
it as restrictive as possible, something like this (untested):
```^https?://www\.juricaf\.org/(arret|recherche)/```
let me know if that's not clear.


On Mon, Oct 1, 2012 at 6:03 AM, Guillaume Adreani
<notifications@github.com>wrote:

> In Juricaf.js:
>
> > +				return "multiple";
> > +			}
> > +		}
> > +	}
> > +}
> > +
> > +function scrape(doc) {
> > +var newItem = new Zotero.Item("case");
> > +
> > +var title = ZU.xpathText(doc,'//meta[@name="title"][1]\/@content');
> > +newItem.title = title;
> > +
> > +var docketNumber = ZU.xpathText(doc,'//meta[@name="docketNumber"][1]\/@content');
> > +newItem.docketNumber = docketNumber;
> > +
> > +var rights = ZU.xpathText(doc,'//meta[@name="DC.accessRights"][1]\/@content');
>
> Thank you Aurimas and Sebastian for your comments.
> Maybe for Juricaf's translator, you will prefer the version developed with
> the framework : https://gist.github.com/3811206
> If you are agree, I will cancel this pull request and I send the new
> version.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zotero/translators/pull/473/files#r1727662>.
>
>



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
This seem like something that should be done on xbmc startup, not on every file start.
Also, shouldn't system_name be not null as well?
This is just done to avoid .getVAR, right?
really minor: might consider making the color random.  Wouldn't change the math, just make it more interesting to see more colors ;-)
Compile error - works if you change it to QuickFIX~~.Fields~~.GapFillFlag
I will do this, if you ask me so kinldy.

But why don't you like a debug (!= info) message for this so important settings ? It can help a lot (while debugging).
что этот метод изменяет?
Попытка 2. Плохо передавать по значению, так как теряется переопределенный виртуальный operator().
очень часто повторяется конструкция call_stack.top()
нужно что-то с этим сделать. Например, сохранить ссылку на него. Однако надо быть аккуратным с сохранением ссылок, так как они могут стать некорректными при ресайзе stack (он кажется на основе vectorа реализован)
Again, drop the EAP label I think
I think I'm just going to leave this in with a default value of true, and remove the docs about it.
I don't thing we're talking about two orthogonal things, necessarily.   I think we're saying that it might be useful sometime in the future if there were an implementation of the core.cache interface built using ehcache, so that we could toggle it on if we found a compelling reason to do so.

Why would it be cool?  Well, basically for all of the reasons that ehcache is cool.  The two that come to mind first for me are: 1) persisting the cache to disk and 2) distributed cache.  Populating our cache at startup is fairly expensive; it's not inconceivable that there could be a non-trivial performance gain to be had by populating it directly from disk in the future.  And we're likely nowhere near a world where distributed memory cache is very valuable for us right now, but it could be a scalability option somewhere down the line.

As far as adding new dependencies--it's hard for me to see that as a huge issue for us right now.  We're bundling everything, so it's not really visible or problematic for our end users,  unless we were concerned about disk space... but our database disk usage is always going to dwarf everything else.

In any case, this isn't something that we're actually giving any real consideration to right now.  It's just something that I (and perhaps @daniel-pittman ) think would be cool to keep an eye open for as we move forward.
This should be `TestHomepage` I think!
Uses validator for logged in user now. Removed the additional checks below.
It would be good to start adding `log().trace(...)` logging for requests/responses sent to to external services.