labofsahil/github-event-dataset-2012 huggingface dataset:
Fullscreen comment editor & much improved HTML sanitization.

* Implemented a 2 column full page comment editor  for working on big posts/comments.
* Image viewer now uses a custom SnuOwnd context for HTML sanitization (Fixes raw HTML showing in many cases).
* Updated SnuOwnd for wikis.
* Fixed some cases in `saveComments` where a WebKit bug could cause an entire `window` object to leak when a page refreshes. (This bug *might* have actually been fixed in Chrome Canary as recently as today)
Added some instructions for installing the app

Users are asking how to install the app
General updates

Converting to git flow of working on forked project and sending updates via pull request.

This is the first request that has several fixes, main one is for the ControllerFactory that was throwing an internal error when js files were requested.
[TIMOB-7273] 1_8_X Hide search screen only if searchHidden is set

Duplicate of PR #1211 for the 1_8_X branch

While doing a functional review of this please also retest the bug reported in TIMOB-5289

http://jira.appcelerator.org/browse/TIMOB-5289
One small fix for disabled="disabled" and an additional styling

cheers ;-)
Commit to change readme file to add minecraft and mojang
Test Fixes

portal/permission/documentsandmedia
Updated installation instructions, see #74

I updated the installation instructions as recommended in https://github.com/doctrine/mongodb-odm/issues/257
Fixed bug on AbstractFactory

created_users_roles option launch an InvalidTypeException when is configured on security.yml:
Invalid type for path. Expected scalar, but got array.
Time and date time fields

Modified the css setting from datepicker-css to ui-css everywhere to include ui-slider
Added some css to the admin to format the time-picker

Signed-off-by: Saurabh Shukla <saurabh@yapapaya.com>
readme more markdown compliant

Hello Ulrich,

j'ai assisté à ton quickie à Devoxx et j'ai enfin sauté le pas ! Du coup j'ai bricolé un peu avec markdown au passage et je te propose un readme + md compliant :-)

à bientôt,
Tanguy (du Jug)
fix MvcSample migtations
Template hook should .....

[URLs are not replacing for FMS ➽](http://phpbbsocialnetwork.com/viewtopic.php?f=44&t=4281&p=18457#p18453)
associated with #111, #106 and #84.

**Two ways:**

1. replace template hook functions for replace HREF in HTML code
2. Find some way how to solve correctly calling template hook for each parts for ```$template->assign_display```
OAEWDGT-146 reccommend Ruby 1.9.3

https://jira.sakaiproject.org/browse/OAEWDGT-146
OAEWDGT-113 - Show reviews tab on first click

Jira: https://jira.sakaiproject.org/browse/OAEWDGT-113
Added Titanium example
Jellybean

Serbian translation; both cyrilic and latin script
Added support for a few more wysiwyg plugins.

Wyvern, WB Markitup, and Wygwam.
Make help.github.com clickable

In the Install and Launch section is a good advice. Learn more from
GitHub. Instead of a clickable link a instruction is given. This
is confusing.

In this commit the instruction is changed into a bulleted link.
OTOH this is the default behavior, isn't it?
(Thanks! There might be a few more of these.)
On overall, you really quickly found your way in the compiler source code, congrats for that. I'll be glad to merge your contribution once you'll have a final version.
@jcoglan I don't think so. A lot of things assume there is only one `.travis.yml`, both in the code and around documentation, blog posts, understanding of travis existing users have, etc. Faye seems to be an edge case when you have two projects in one repository and they happen to use different runtimes and you want to test against multiple versions of each. Maybe it's a good idea to separate them into two repositories. Finally, with multiple `.travis.yml` files I am not sure how future features like testing of pull requests and artifacts should work: we won't be able to tell what file to use, what "subproject" has changed and so on.
Added ticket #18614 to track this one.
You could upload that code on GitHub then link to your commits (since it _is_ supposed to be open-sourced as I recall Mr. Smucker saying). I know you can [append `?author=mduan` to filter commits authored in Git](https://github.com/jquery/jquery/commits/master?author=jeresig), but since we used git-svn it doesn't seem to work on https://github.com/divad12/web-search-experiment/commits/master
I'd use >= 1 or > 0
there are no kittens in this thread

![kitten](http://dl.dropbox.com/u/336578/work.4681879.2.flat%2C550x550%2C075%2Cf.sad-kitten.jpg)
thanks for answering my questions to self, oh, and cleaning up my mess
Does this file only get run on Unix? `ln -s` won't be on Windows, of course.
Since you can commit to master, you could just fix the vulnerability :) 
Also, Rails is open source - you get it for free, why not make it better for free as well?
I've just tested it with nl_collapse_empty_body=false.
It looks very stupid, but if ember needs it that way its ok. :)
Yeah, my friend. But just was using the spree version 0.70.3. It was the problem, about the file. 

Now, I'm using 1.0.0.rc1 and it's working fine, about add a product with utf-8 caracters. But, I have a new error now. When I create a new product, the application get an error:

"NoMethodError in Spree/admin/products#edit

Showing /usr/lib/ruby/gems/1.9.1/gems/spree_core-1.0.0.rc1/app/views/spree/admin/shared/_product_tabs.html.erb where line #5 raised:

undefined method `price' for nil:NilClass"

I'm trying to understand to fix this now.
To be explicit I would mention `CMAKE_INSTALL_PREFIX` in the commit title itself.

Regarding line 76, if I`QtTesting_INSTALL_DIR` is passed it should be sufficient and there is no need to pass `QtTesting_DIR`

Finally, the name of the topic seems off. I am assuming this just a *throw-away* topic made for cherry-picking and this would never be merged directly. If it's the case `msvc-compilation-missing-export-macro` is not the best name.
Here's where things stand: with the forked version, I can generate xlsx files. Unfortunately they appear to be invalid. I don't have an actual copy of Excel handy, but Google docs complains that the files are invalid when uploaded. Numbers will open them but does not show any string data, only numeric.

We're using Ruby 1.9.2-p136 on this project. 

https://www.dropbox.com/s/2rxezcde2935i6r/by_quantity.xlsx is one of the files if you want to have a look. Any ideas on what to try next/how to diagnose?
I think we want to have NOWAIT too (game engines would appreciate that, since they do not black at all and have to have a constant frame rate).
missing " s"
So far, the only substantive change is the addition of this line:

    inv_param.prec_precondition = cuda_prec_sloppy;

Should we revert it?  By the way, this probably isn't what you meant by "undo everything", but in general it's a very bad idea to "rewrite history" once you've pushed (by using "git reset", "git rebase", amending a commit you've already pushed, etc.).  Otherwise, other people working in the same repo can get very confused.  Of course, it's totally kosher to just push a new commit that undoes some previous changes.

P.S. - Welcome aboard!
This branch is never taken, because *swap_chars()* always returns zero or greater.
Same reason as under [check test above](https://github.com/sbp/scalable/commit/01d8d97a6d34b309699d4ad0e64f195219f34776#commitcomment-861598).
Missing space after 'if' and after two '//'. Daniel had fixed this before google submission in 616a2599bc130a2dbc45ed97a9717d928033d628.
This was a backwards incompatible change that broke functionality for any of us who maintain our own deform widget templates (i.e I maintain deform_jinja2 with both twitter bootstrap and uniform templates)... Was there an announcement somewhere that I missed about the breakage?   I want to make sure I don't get caught off guard again.
Por cada commit -a toca tabla ... acordate lo que te dije del git status, git add y git rm.
r+ works for me
Такая мысль бегала но уже давно. Делается без проблем за 30 секунд - класс наследуемый от соотв. мувментгенераторов (см. Idle). Но добавить в них пока совершенно нечего - так что пусть остается как есть. Будет что добавить - тогда и сделаем. Вообще IMHO полезная фича этой переработки - почти полная совместимость со старыми генераторами и мотионмастером...
ЗЫ зато как можно над мобами издеваться... я сегодня на одного аж все приоритеты/эффекты сразу понавесил. Глаз радовался как отрабатывает, не то что вечные зависоны со старым стеком...
another one here, btw
Can your give me the link to get the 2.6.0 BD? Thanks in advance ^^
Naios: We may want to look at this later on. Increasing distance can cause lag later on.
Please leave them as internal values. If *_get_width/height returns 0 you should fail and not use some default value. See below for more comments on this.
Versteh nicht ganz was du meinst
blech X-P
+1 good idea
Then please move all, or write which You didnt move.
If somebody has better solution then let him implement it, until then scripts shouldnt be held by not fixed spells in core.
If you're talking about Context.js, I think the real problem is that it was missing a dependency on Snap.
Yep, I see the difference between `find_by` and `find_by_*`. I simply want shortcut for `Model.where(...).first`
Ok, so given this thread:
https://github.com/defunkt/resque/issues/368

is sidekiq acting as it should on Heroku? I'm still seeing stale workers upon restart/scaling down.
You could use the 'meeplib.delete_message' functionality...
у меня для твоего приложения используется другой гемсет - поэтому добавь и его в гитигнор, чтобы у меня не было конфликтов
Numpy has a clip function that is very useful.  Just do:

    np.clip(dot_prod, -1, 1)
ping @fesplugas this sorts the templates
Columns should not default to NULL unless there is a reason (and supporting code) to distinguish between an empty value and a null value.  Suggest using "NOT NULL DEFAULT ''" for almost all varchars.
Жесть. Ты уже не в agi, тебе это включать нельзя
`Yii::app()->session[$key][] = $id; // ?`
There should be better way how to do this work. 
When I try start this test (*)
"""
class async(test.test):
    version = 2
    def run_once(self, machine):
        # Designate a label for the server side tests.

        server = hosts.create_host(machine)
        server_at = autotest.Autotest(server)
        job = server.run_async("sleep 1 && echo maslo && sleep 3 && echo sadlo")
        print job.wait_for()
"""
(*) from server part  then wait_for makes dead lock. Because AsyncJob.wait_for()
try to wait for end of process. But this process never end because this wait for 
ssh command which wait for "& read;".  
  And when I try to call job.kill_func() before AsyncJob.wait_for()  then test fail because 
AsyncJob.wait_for() call kill_func after process ends. This is a little deadlock.

If I try change last line of test to print job.wait_for(10). Then it works but it send bad result
to results "line 0: kill: (xxxxx) - No such process". This is no mistake but it doesn't look good.
Yea we finished our exams n stuff so its time to program
Ok, I guess it's better I do a full review and let you put in the following text on the docstring, after the steps description:

    NTttcp is not a freely redistributable binary, so you *must* download it
    from microsoft and be in agreement with its EULA. See @see tag for a
    complete download link and also documentation on how to integrate it to
    your autotest setup.

    @see: http://msdn.microsoft.com/en-us/windows/hardware/gg463264
    @see: http://download.microsoft.com/download/f/1/e/f1e1ac7f-e632-48ea-83ac-56b016318735/NT%20Testing%20TCP%20Tool.msi
    @see: https://github.com/autotest/autotest/wiki/KVMAutotest-Networking
increase this to 200, and I'll merge it in.
Great! This is very nice!

I have a question, though: how am I supposed to declare methods in, e.g., `SmallInt`? Example: the overrided `gCollect()` methods in the garbage-collector.
CollectionStats:View is the new permission...

`acl.action_allowed(request, 'CollectionStats', 'View')`
yeah it's a hard problem but at the same time something that could be very useful. I'm glad to see you don't bypass this point.

Can the discussion with @cloudhead be on a new issue? to show to everyone this point, I think it's very interesting
do we need a migration to add this to the `applications` table?
For improved compatibility, I'd suggest the following (successfully tested on earlier systems) :

    #if ( MAC_OS_X_VERSION_MAX_ALLOWED < 1070 && !defined(NSWindowCollectionBehaviorFullScreenPrimary) )
    enum {
        NSWindowCollectionBehaviorFullScreenPrimary = (1 << 7)
    };
    #endif
	
    //Enable FullScreen Support if we are on Lion 10.7.x
    [mainWindow setCollectionBehavior:NSWindowCollectionBehaviorFullScreenPrimary];```

On 10.7, the behavior is honored by delegate methods (which will never be called on systems < 10.7)
I actually fixed it.  You actually exposed some bad tests (and also forgot to include textchange in a place we use the publisher :P) :)
`parseBoolean` never throws a `NumberFormatException`.
it's been a while since i last touched this code but i think what you're suggesting would work and then `target` in `ko.exportSymbol` could just be `ko` without needing to check for `koExports`.  i tend to like this better since then there's only ever one check done for `koExports`.

typically i would have picked up on this kind of optimization so hopefully i'm not forgetting some reason why it wouldn't work.
Is there no .tar.bz2 any more?
I believe you've switched findtime and bantime (this line and next).  findtime should be shorter than bantime.  In the example given in the original issue 19, findtime is 1 day (86400) while bantime is 1 week (604800) ... they are switched here.
Interested to find out what the thinking was that led to this revert.
This broke IE.
This introduces a regression for all the applets that have a popup menu. They all fail to load with the following error:

 - "TypeError: Applet.AppletPopupMenu is not a constructor"
Is it possible that, if you have multiple carousels on the page, the loop option only works for the first carousel?
Thanks - I'll pull it right away.
исправь на 

```ruby
match 'categories/:category_id/custom_fields(.:format)', :to => 'custom_fields#index', :as => :category_custom_fields, :via => :get
```
Vasago try new change.
Yeah, sure. Those slept in accidentally.
Notice: sql.h, .c++ files aren't developed yet. My first  toughts was to try to create some semantics and auto-generation of sql (queries) commands contructs from the mysqlns components. I fear my ideas are useless and worthless - but - it may be usefull if I decide to fully master SQL !! ( ironic joke! )
![FUCK YEAH](http://3.bp.blogspot.com/_PFvSMY-AaRQ/TQIkeBk578I/AAAAAAAAAds/5tdeTecebi4/s640/Success-Kid-FUCK-YEAH.jpg)
I don't see either of these folders in the report, are they really there?
This line can simply return `$value`. It's a bad mistake in the documentation and I'm about to correct it but `getParameterPoolValue` can return either a string or an array.
Why define this as _appendView? it doesn't need to be a member, it could just be function defined in the outer function scope.

Making private functions inaccessible inside a closure vs using an underscore allows minifiers to munge the name.
ну, на сколько я вижу желающий только я один, но всёже хотелось это дополнение увидеть в вашем гениальном исполнении  rsa
Don't you need to substract start?
Somebody I know had problems with tests, that test JMX functionality.
cursing?
Well, this whole paragraph is removed... (because of the previous comment) - it makes no sense to have "Advantage" without the previous paragraph...
but no newline at end of file? lern2textfile bro
Nice... :)
Regarding digest authentication: I'm afraid I don't have a need for that at the moment...
Code review nazi on patrol!

On Fri, Feb 3, 2012 at 2:31 PM, colinmccann <
reply@reply.github.com
> wrote:

> check
>
> On Fri, Feb 3, 2012 at 2:25 PM, Matt Zukowski <
> reply@reply.github.com
> > wrote:
>
> > <br />, not <br>
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> >
> https://github.com/colinmccann/EvoRoom3/commit/5552e8f5af5193fb8a050bacbf76cf63d4d203ff#commitcomment-931497
> >
>
>
>
> --
> Colin
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/colinmccann/EvoRoom3/commit/5552e8f5af5193fb8a050bacbf76cf63d4d203ff#commitcomment-931518
>
Yep. "el" is the jQuery object for the element. You can't rely on the attribute being "data-role" 100% of the time, you have to use the jqmData function.
I think that the LessCompiler, JavascriptCompiler, and CoffeescriptCompiler should be separate tasks in compile. Due to the parallel execution of SBT, the JavascriptCompiler task should depend on the LessCompiler and the CoffeescriptCompiler. Those two tasks should output to the taskTempDirectory in Compile, and the JavascriptCompiler task should copy the js sources in app/assets to the taskTempDirectory in compile. Any sources in the resourcesManaged in Compile should be watched for changes, and only those assets that changed would be moved over.
@bartvde could this iteration possibly fail when people manipulate Object.prototype? I guess we should check hasOwnProperty here, right? This might result in nonsense-SLDs written by the format. How do we deal with iterations over object members elsewhere?
Sweet. Maybe we can defer cleaning this up until issue #11 is tackled.
Yep,  I'll just do away with the nesting used with group_resources and clone_resources.
-  It is important to get things right the fist time. Especially when yo…
+ It is important to get things right the first time. Especially when yo…
This isn't going to solve the issue.

References of ActiveTiles themselves need to be soft.
Add add_node() to JS
Oops - no, blame lies with revert b77faf2a15f9c46ab59c5219210998176600687c being too wide in scope.
@joneslee85 Will check it out ASAP. A lot of work as usual, but it's for good :)
I'm sorry, but I like a line of padding between package separators.
Remove this line. Try to avoid commented code in source files. That's what version control systems are for.
elif sys.version_info[0] >= 3: correctly lets 2.7 run
Nay, why would you accept this pull request when that script could have been done in SAI?

-- Brian
The lines that you remove are not really necessary?
Hi Madhu,
  If you look at the file uid_auth.c and uid_auth.h, there are
  #defines that tell you which is the certificate file that is
  picked up. Kindly go through the function sign_file() to see
  which is the certificate file that is read for digital signature.
  There is no hard-coding of any certificate.

  Note that there is a #ifdef for SERVER_PRODUCTION that determines
  the certificate that is used during compilation.
warm regards,
subbu

On Thu, Jan 05, 2012 at 09:12:19PM -0800, madhu402 wrote:
> Hi subbu
>  I am able to generate the xml file.But i would like to know other then
> generating the private key we need to modify anything before generating
> the xml file. when i posted the same query to aadhar group i came to
> know that in your application key info contains details of Staging
> certificate.
> 
> <X509SubjectName>CN=Public AUA,OU=Public,O=Public
> AUA,L=Bangalore,ST=KA,C=IN</X509SubjectName>
> </X509Data>
> 
> 
> Is it possible that you are embedding the staging certificate in Auth
> XML (due to which auth server considers digital certificate used for
> signing to be valid),  but embedding the signature generated using your
> own self-signed certificate (due to which auth server fails to verify
> signature)?
> 
> Thanking you 
> Madhu
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/GeoAmida/AadhaarAuth1.5/commit/0136df6f8dcc7acb4df948fb982aac4771fd4ee9#commitcomment-842777
Small typo in sql name "2011_01_08_16_world_misc.sql" -> "2012_01_08_16_world_misc.sql".

"the channelers should cast paralyze only once" Correct and if you take a look at channeler's script you will see:

```c++ 

if (me->HasUnitState(UNIT_STAT_CASTING))
    return;
```
It means that if npc is casting or channeling spell it will return so the npc is not spaming spell every 200ms.

"this spell should use its basepoints to find the correct target" - http://old.wowhead.com/spell=41083 the problem is that without FilterTargets every player near Ritual Channelers gets paralyzed. If you know a better way to fix this share your code :]

"the sacrificed target get an 3 sec aura from teleport spell, it is enough time to teleport this player, spawn channels and cast paralyze" Yes and this is how it's done in script.
Thank you, someone remembers to fix Naxx a bit :)
epic one.
thx to all who works on this.
why has spell 34400 summon effect?
Should we mention -Wp and -Wa here ?
The returned value is a float, and corresponds to something like "The total duration of all queries.".
Es sollte genügen, wenn du in der package.yml des Plugins das hinzufügst:

```yaml
name: 'translate:setup'
```

(Ziel ist es doch, dem Xform-Menüpunkt eine Subpage hinzuzufügen, oder?)
Ooops, misunderstood. It’s not about performance, just a habit. Can change if needed.
There is a PR updating it
88747, is the correct trained spell, that also produces triggers Fungal Growth, 
which the other spell does not.
also something, with this is off..cant use 78777, 
the spell should only allow limit of three 'shrooms to be out at one time, 
(fail with both)
for a duration of 20 secs, 
78777 allows multiple uses, and all to detonate.

since only three should be out,
 with the 88747 spell it only detonates 3 ...
so you may spawn as many as you want but only the correct amount will detonate.
and birth slowing fungal growth, its still WiP. i think theres still something missing from this cocktail.
вот этот метод мне кажется странным:
- искать по имени... а если кто-то на select повесит такой обработчик?
- изменять id? а если там уже установлен id и используется для других целей. навредишь...
- насколько бы удобно было бы использовать класс для этого?
Le 14/02/2012 19:03, OlivierB a écrit :
> datetime est un objet
> ->http://www.php.net/manual/fr/datetime.format.php
> je vais tester ca !
>
> La taille des colonnes pour les articles ne se fait pas correctement
> J'ai mis une fonction qui permet de couper un texte dans fonctions.php (ca peut etre pratique !)
>
> ya toujours une erreur sur le fichier test.sql
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/OlivierB/Polyjoule_siteWeb/commit/dde2b7a3c991211e429fdf26951f9fb049fe1aec#commitcomment-965712
http://fr.php.net/manual/fr/function.time.php

Avec le type datetime ça met que des 0
Ok you said you were not going to do this. I am not so sure that your approach is better. You have traded one complication for another. Remember thsi conversation? 

[2/1/12 9:06:53 AM] Andrey Podoprosvetov: ok we have button for example:
<button>Next</button>
[2/1/12 9:07:02 AM] Andrey Podoprosvetov: I add to this button action
[2/1/12 9:07:25 AM] Andrey Podoprosvetov: <button onClick="show_step('step2')">Next</button>
[2/1/12 9:07:44 AM] Andrey Podoprosvetov: when we click on this button
[2/1/12 9:07:57 AM] Andrey Podoprosvetov: I change attribute OnClick to
[2/1/12 9:08:13 AM] Andrey Podoprosvetov: onClick="show_step('step3')"
[2/1/12 9:08:16 AM] Andrey Podoprosvetov: etc.
[2/1/12 9:08:51 AM] Andrey Podoprosvetov: no need always use append()
[2/1/12 9:10:11 AM] claytantor23: yeah, but then you need a seperated next and back button for every step
[2/1/12 9:10:46 AM] claytantor23: so if there are 16 steps there are 32 buttons, and if you want to add a new stepp you need to add two more buttons
[2/1/12 9:11:08 AM] claytantor23: am I wrong?
[2/1/12 9:11:24 AM] Andrey Podoprosvetov: no
[2/1/12 9:11:33 AM] Andrey Podoprosvetov: need only two buttons
[2/1/12 9:11:39 AM] Andrey Podoprosvetov: next and back
[2/1/12 9:11:44 AM] Andrey Podoprosvetov: for exaple now spep 2
[2/1/12 9:12:04 AM] claytantor23: so how does the onClick="show_step('step3')" get asigned when you go from step two to step three>
[2/1/12 9:12:45 AM] Andrey Podoprosvetov: ok, we click to button next
[2/1/12 9:13:06 AM] Andrey Podoprosvetov: we see block for example with 3 step
[2/1/12 9:13:47 AM] claytantor23: can you add a simple code example as a comment in the ticket before starting on how you would make a case with 3 steps and two buttons?
[2/1/12 9:13:53 AM] Andrey Podoprosvetov: I use Jquery function $('selector').attr('onClick','step4')
Something that comes up a lot is that I need to perform a change in reverse order, so that `region.a` and `region.b` point to the correct locations.  So I start with that snippet a lot.

Also, `self.view.sel()` points to the same object even when you add and remove regions to it.  Not the case here, but again that's why I often use that bit of code.
By the way -- with 80 bit reals on the x87, the behaviour on AMD is different to Intel! AMD converts signalling to quiet, Intel does not (or maybe the other way round, I don't remember). So it's not even as predictable as an SSE/x87 difference.
Hi riwan, happy to take a look and get this patched.  How are you planning
on using the app?
On Jan 16, 2012 3:23 PM, "Rizwan Zia" <
reply@reply.github.com>
wrote:

> I think it was removed in commit
> (c69ec15e967b6f00c5b6e05d476de5fbb5a398a5) though I am not sure
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/zackster/CompassionPit--Node-/commit/2b4407cbf5586d6ecab5ed6feeb32d156788b8f2#commitcomment-872545
>
Can't check it completely, because I am at work, but isn't the difference, that yours applies to freq between low and high, and mine to freq below low and above high. Or do I miss something. Anyway, great idea and many thanks for this. 



byeonggon <reply@reply.github.com> schrieb:

>Unfortunately, Your commit has something wrong. See this
>https://github.com/byeonggon/lynx-nexus-s/commit/286eb6da2cd0ad10854ecbf862fb669c90b4db6f
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/DerTeufel/samsung-kernel-aries/commit/923fcd92cc40c1ba5e93c419f3edd9fcb7a69303#commitcomment-1052625

-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit Kaiten Mail gesendet.
You like that? :)

On Wed, Feb 29, 2012 at 3:10 PM, Zach Holman
<reply@reply.github.com>
wrote:
> you motherfucker
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bmizerany/sinatra-activerecord/commit/c4228cf12760ce370863cc37983236039cc40af4#commitcomment-1028701
@lsmith77 i've thought about it too and it looks like we really should :-)
great stuff .. one thing i am not sure yet is how/if we can separate the cmf specific stuff out of this bundle .. maybe we shouldn't bother.
This seems like a new requirement. Does that mean that existing SAP installations with the current SAPDatabase resource agent are going to stop working? If so, then the update may break existing deployments.
Doesn't this become the title of the page, thus causing issues in title rendering?
ça doit être possible d'enlever toute la partie "module" du début qui sert à rien, et d'inclure le résultant tel quel dans ton script.
That's indeed interesting. I'm wondering what the pro's/con's of either alternative are.
with latest Android SDK (r14), resource key need to be checked by `switch` in library project.

http://android-developers.blogspot.com/2011/10/changes-to-library-projects-in-android.html
The texture object uses the GL_TEXTURE_EXTERNAL_OES texture target, which is defined by the
http://www.khronos.org/registry/gles/extensions/OES/OES_EGL_image_external.txt
 GL_OES_EGL_image_external</a> OpenGL ES extension.  This limits how the texture may be used.
 Each time the texture is bound it must be bound to the GL_TEXTURE_EXTERNAL_OES target rather than
 the GL_TEXTURE_2D target.  Additionally, any OpenGL ES 2.0 shader that samples from the texture
 must declare its use of this extension using, for example, an "#extension GL_OES_EGL_image_external : require" directive.
Such shaders must also access the texture using the samplerExternalOES GLSL sampler type.
I think the first pull went wrong? Or was it reverted?
Could the argument `$false` be described any better? If it's a deprecated argument, then it should be formally coded as such with `_deprecated_argument()`.
Awesome. Line numbers displayed in the messages!
Вова предлагает передавать `done` только вместо функции `function(err) { throw err }`, при этом в перво
This particular code is `lib/fog/core/mock.rb` not `bin/fog` :) and it's the actual Fog::Mock.reset that already existed. I just refactored a little bit to extract how to find the mocked service list...
Sorry, my assumption was tags had to be split by commas.  I'm sure a little more regex could allow that, but the real issue here is that tags.clear was getting called on every save so we had to find a way to only create a tag if needed and not go about it by destroying the whole list each and every time. 


This will create the list of tags
 <code>self.tags = @keywords.split(/\s*,\s*/).map do |name|</code>

This will find or create tags, removing the need for tag.clear
 <code>Tag.find_or_create_by_name(name.tr ' ','-') </code>

Also now you can make collection of words with out rapping them in quotes. for example
<code>This is foo bar, tag1, tag2</code>

gets you the same as  <code>"This is foo bar"  tag1 tag2 </code>

In my opinion commas are better then quotes.
Isn't jQuery just using their standard accessor/mutator pattern for `promise()`, effectively the method does what `getPromise()` and `setPromise()` would be doing?
+1, the vast majority of assemblies in NuGet are signed and I think it's a good idea. Json.NET decided to go with signed assemblies: http://json.codeplex.com/workitem/22205
Yes, I think it's the idea and I plan to do these UI updates *but* in the next pull request (this one is for removing services management part from the CAS server).
Before working on the management UI, I will open a thread on the cas dev mailing list as this issue deserves a shared discussion.
For syntactic sugar: the python `@property` decorator creates a read only property by default. I'd rather use that.
ok, then it should be `setReceiveTimeout(timeout: FiniteDuration)`, which is actually rather convenient from scala also
and it should have some docs about null == clear
That's a good question - the integrating point "withCircuitBreaker" is written synchronously.  Here's the sig of the mailbox queue:

```scala
trait MessageQueue {
  def enqueue(receiver: ActorRef, handle: Envelope): Unit

  def dequeue(): Envelope

  def numberOfMessages: Int

  def hasMessages: Boolean

  def cleanUp(owner: ActorContext, deadLetters: MessageQueue): Unit
}
```

So beyond enqueue and cleanUp it's a synchronous interface.  I'm thinking a circuit breaker is not needed on the cleanUp method since it happens before disposal.

I'll need to think a bit on a different signature to support injecting success&error callbacks for enqueue.  Of course, am open to suggestions.
`Iterator from 0` ?
There’s nothing being inferred, and Unit is not actually an object when used as a return type. `{}` is an empty block, which is precisely what I mean (in this case I’d actually prefer `def suspend() {}`)
good point, I'll change to scheduleOnce and adjust the delays
this might need some !!! or caps or … ;-)
We don't need to create a new message for each send
IMHO it's just as wrong as tell(msg) uses the wrong sender reference. But I think it should be removed when the actor dsl is done.
Also, there has been 0 complains regarding this and much more regarding the missing sender of tell...
yes, I think so, now that you mention it
userstamp doesn't handle that?
unindent I think
If this is not ready for .7, we can remove it, I really would like to have it in though.
Looks like a list of organizations that the user is authorized to edit. Could be better named and better docstring
Oops.  Looks like I changed my mind here but didn't apply to all.
Fixed.
And everyone made fun of me for this defaults dictionary. HAH! (nicely done btw)
Convention in Pulp is underscores between words: type_id.
a. not right
b. not used
drop the == 1, it's a bool after all. I think some compilers may even warn about this.
Ok. then we leave it as is now and remove them in one sweep.
I'm pretty sure that GetProtcol() returns the protocol without the :// .... ? So shouldn't it just be == "smb" ?
А что конкретно не так в этих правилах? ` Options +FollowSymLinks` сомнительная необходимость (поговаривают что это не безопасно), но правило было в изначальном варианте и возможно для чего-то требуется по этому я его оставил. `IndexIgnore */*` заменен на более правильный в контексте его использования `Options -indexes`
тут же добавлено. удаляю свой коммент
I assume you misspelled all 3 of our handles on purpose? :)
please close this request, doing another one. Thanks
trait_ok? puts the fetch with the ok?, and only does the fetch with new on :create.
Instinct: Way too much use of Future callbacks in the code, which feels weird since this is supposed to be an actor based remoting. Also, it is unclear if all things that are closed over and called in said callbacks are threadsafe.
I use it because it shows proper nesting - operation order makes more sense with it. But I can remove them too. :+1:
A ternary statement on what? There are several conditions here, although I agree they're duplicative.
You can do this immediately after the call to `uv_check_init()`.
```javascript
if (this._line_buffer.indexOf('\n') !== -1) {
```
put this in constants
My point is that there are tabs in the file instead of spaces :)
ок. считается, что так читается лучше?
J'ai déclaré un nouveau mixin.
Could we just import `Boss` and use shorter links?
please use '/* */' instead of '//'
Are you sure we should mutate `options`?  Maybe `options.fetch(:serialized, true)` instead.
Although the tests have similar assertions, the description is quite different. Perhaps we could use something like:

    "backtrace should filter all lines in a backtrace removing prefixes"

wdyt?
u r right! I remove the test
Add the +debugger+ gem to your Gemfile.
Well this make sense. I'll ask to someone merge it. Thanks.
cant remember :s It's working perfect
Yes. I'll fix that and push now.
We need to move these methods away from `Symbol`, so that we can reliably override them only in reflective universe.
are not "much better" integrated, but are simply integrated, unlike manifests which are not
shouldn't `spree/money` have this `require 'money'` instead as the core doesn't really care how Spree::Money works?
ah, good point to bring up: for fileio.h I only put function documentation in the header file, while for queuefile I put it in both the header file and the .c file (mostly because I wrote the two in two different ways). When working with a good IDE that gives contextual help, I find it better to only put function comments in the header file so there's only one copy of the comment. What do you think?
>
> Two things:
>
> * The creation of the symbol is out of the control of the test writer, and
> opaque to readers.
>

But the sympy audience will know that "this is ok".


> * You get tests that depend on a global state, and can thus influence each
> other in unpredictable ways.
>
>
You mean like how the symbols are created?


> Looking at abc.py, I see that the "arbitrary magic" isn't as bad as I
> thought, since it's only an exec statement (but still, you can't know that
> just by looking at the import statement).
>
>
Again, I think if we just agree that this is ok then we can use it. It's
only hiding the creation of the vanilla symbols.

/c
Why did you delete these two tests?
Is it adaptable? I am actually thinking that I need to write a custom key here (see my blog post for more details: in the crux, something like the integral of `log(x) + log(x**2)` can be expressed in terms of either `log(x)` or `log(x**2)`, but I think that the one using `log(x)` would be preferable).
"make" shouldn't be here.
You may want to clarify that `.` = dot product, I haven't seen this anywhere else.
I'm sorry, but I still seem to be behind.  I cannot see any doctest failures related to the different order of application of `expand` hints.  (Those in `hyperexpand` are related to the fact that `Add.args` is not sorted.)  On the other hand, with this fix, it is impossible to get different outputs, because hints are always applied in the same order.

I'm really sorry for not having understood your point yet.
OK. I will add them.
Yes I see. We include it into the definition of the legendre functions where `P_n^{-m} = (-1)^m * ... * P_n^m`.
Ah, so it was just plain wrong then.  In that case, +1.
I think the doctests also should be updated.
parse -> sparse
I think this reorganization plan sounds fine.  But as far as the naming goes, on reflection it should probably be `SphericalCoordinates` (or possibly `SphericalCoordinatesBase`, although I'm fine with just the former).  That's actually what we're talking about here.  Regarding `angle1`/`angle2`, that's why I was suggesting `lat` and `long` or similar.  There needs to be some way to know how to interpret each of those angles correctly (e.g. which is the one you multiply by the cosine of to get the jacobian when computing distances). You could also use `polar`/`azimuthal` if you want a more generic term than lat/long.  But `angle1` and `angle2` don't provide enough information to actually interpret the coordinates.
And "recursiv**e**ly"!
ret seems to always be 0 for me...
jshint: `[L409:C21] 'start' is not defined.`
Can you put the CSS part of this line into a class defined in the CSS file?
This seems like a fairly fundamental class - I think it would be worth documenting it briefly, including descriptions for the major functions it offers.
Yes, sorry. Wasn't sure whether to keep it a strict example output or mix in variable notation like <hostname> and <port>
there is no other form of authentication
I think these should all be `&&`'s ? If navigator.doNotTrack returns 'yes', then the second case will be true and it will track anyway.
ruby doesn't play named argument, this should be `client.save(true)`
IMO, there isn't a need for that. The table name already creates an namespace, adding a prefix to the columns only makes them longer for no real benefit.
https://github.com/phpbb/phpbb3/pull/865/files#r1050286
It's $_POST ;)
Повторение кода, отступы, отсутствие валидации и проверок. Ужасно
В Todo четко было написано требование поддержки нескольких сервисов. Этот код тковым не является. Да и вообще, при каждом запросе картинки писать в базу - бред и лишняя трата ресурсов
Does this have any (potential) use-cases outside of the type itself? If not then perhaps this should be turned into private as it is more of an implementation detail.
"inherits"
They both apply but they're compatible with each other.

The rules are:
output is int -> igrad is 0 or NaN
input is int->  ( igrad is same as if input was float) or ( igrad is NaN)

So when output is int, "igrad is same as if input was float" simplifies to "igrad is 0 or NaN".
Can you group them by int/float/complex in the doc. This make it more readable.

If the uint* are not supported, can you make a ticket for this. Do you know if scipy.sparse support them?
On linux, if you delete a file that is under use, the os mark it deleted, but keep the data until it is not used.

On windows, I don't know. We already take the lock a few times and this make the loading harder. I suppose Windows is not as smart then linux, but do you know? If you don't, I'll add the lock, but if we can get away without it, it would be good.
Okay, in a somewhat roundabout way. Removed the comment.
Actually, it looks like  the unique case can (usually?) use different boolean arguments (to match the multi case) because these arguments are effectively ignored in the unique case. So it's really not clear that m_index->isUniqueIndex() even needs to be exposed/checked at this level.
LicenseType
You always return for cfa_warn, so no need for "else"
Sorry for breaking this @elemoine saw that you fixed it with #53 thanks for that.
This is a mistake from when I was refactoring the rename functionality. I'll restore it and add a test.
I don't but I can imagine that someone has some fixtures in `spec/` or `test/` folder where will be `version.rb`.
If these are internal functions (not public API) then we don't need to check that parameters are valid, really. We know they're valid because we're only calling the functions internally.
Nevermind. I got confused. This is fine.
This is broken, it will fail immediately if it can't find a file in the first import path, without checking any of the others.

Also I just checked less.js. It seems the correct way to handle this is to ignore missing files with a `.css` extension but throw an error on any other not found file. If we don't that then we should not have a `notFoundFatal` option, and just always throw an error if a file isn't found.
Use cstring_to_text
Misses documenting comments.
Would it be possible to use 
url.contentEquals("return");
or in general some more strict comparison? I think it would be much safer.
This should be really fixed some day ...
``urlparse`` again, or at least a util helper we can use to go from uri to scheme.
Out of curiosity, why not do this with a test generator?
Technically, this converts a string to a datetime.
Under what circumstance will this print? Just to check, this won't leave CLT-only users (with an invalid `xcode-select` path) seeing this every time, right?
Wouldn't we want to say `brew link` here?

Also this output would potentially look like

```
brew link foo
bar
baz
qux
```
These caveats can just be removed if we're 64-bit builds now; this describes expected behavior.
This indicates that some part of the build is using the wrong compiler (`-march=native` is clang-only iirc). I think if you also pass `CC=#{ENV.cc}` on the make line down below, you won't need this.
You are right, although I never had such a situation. The problem: if "/Shared/" is somewhere in the path it is (almost) impossible to decide if it is _the_ Shared-folder. We could use OC_FIlesystem::getMountPoint() to check if it is the Shared-folder. But this only works if we stay in the root folder of the currently logged-in user, is this a valid assumption?
250 characters seems a bit much for the etag, the length of an md5 or sha1 hash seems better to me
Duh.  Yes will do :)

On Oct 6, 2012, at 9:44 AM, Dmitriy Kalinin <notifications@github.com> wrote:

> In Source/CDRDefaultReporter.m:
> 
> > @@ -186,6 +186,12 @@ - (void)reportOnExample:(CDRExample *)example {
> >  
> >      if (reporterOpts && strcmp(reporterOpts, "nested") == 0) {
> >          [self printNestedFullTextForExample:example stateToken:stateToken];
> > +    } else if (getenv("CEDAR_REPORT_FAILURES_IMMEDIATELY")) {
> > +        if (example.state == CDRExampleStateFailed || example.state == CDRExampleStateError) {
> > +            printf("%s\n%s", [stateToken cStringUsingEncoding:NSUTF8StringEncoding], [[failureMessages_ lastObject] cStringUsingEncoding:NSUTF8StringEncoding]);
> > +        } else {
> > +            printf("%s", [stateToken cStringUsingEncoding:NSUTF8StringEncoding]);
> > +        }
> >      } else {
> >          printf("%s", [stateToken cStringUsingEncoding:NSUTF8StringEncoding]);
> >      }
> what you think about adding another separate if statement after this line to check if CEDAR_REPORT_FAILURES_IMMEDIATELY is set and print out failure if there is one (instead of else if {)? that way stateToken will be printed in one place and nested format will also get fail fast output.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Why & what do you want to replace it with?
Does not necessarily only apply to comments (I know that was there previously).
This line is too long. The same with line 146.
1-var-rule
Lets do the assert since it must be an error - if you read too much.
It very well may be, though I can't see anywhere where `isEqual` is actually used in place of `hashKey`. Do you remember the original rationale for this line?
Same comment as before about limiting forEach. I'd prefer forEachSeries, just from a load perspective...but what do I know? :)
Seems like we could just return '[]' for the subsequent calls. But I agree that it's not necessarily simpler. It might be worth adding a comment explaining what's going on though (i.e., the fact that we create one promise for each character typed, but only the last one resolves).

Actually, I guess there might be some condition where the user types some query, backspaces, then types the same last character again. In that case, it seems like we'll end up doing the same search twice. I guess that's fairly harmless though. (To fix that, you'd probably have to go to some kind of serial number scheme.)
Yeah, I was hesitant to use "project" at first, but we *are* using it in the UI, and it does sound better (and is more accurate) than "all files". The problem with using the project name here is we will eventually want to search the working set, too, and that may contain files that aren't in the main project directory.

> My concern with putting the folder name on the left is it would make the horizontal position of the text field vary quite a bit, perhaps unpredictably so.

Good point. It wouldn't be a problem for shallow paths, but could be a problem with long document names and/or paths. How about using just "Find:" on the left and adding the path (or "project") on the right.
This should probably not be here.
Same bad folder check as before.
Did you mean to leave all these guys pending ?
Just a suggestion on doc style. I personally like to write my parameter docs like this:

<pre>
:param asset:
    The asset used to compute the loss ratios and losses.
:type asset:
    An :py:class:`openquake.db.model.ExposureData` instance.
:param losses:
    An array of loss values multiplied by the asset value.
:type losses:
    A 1-dimensional :py:class:`numpy.ndarray` instance.
</pre>

This is the style we use in nhlib as well. I think it makes the docs much easier to read, especially in the source body. What do you think?
Andrea, I did check that even Ubuntu 12.04 ships with mock 0.7.1, which means that you cannot use mock.call which is a feature of more recent versions of the mock module.
It would have been really nice to fix indentation problems from the beginning. As this is a file you're adding (and you've copied in a former version, I guess), it would have been harmless for history and useful for the view in IDE.
Pika na koncu. *Uporabnik s tem uporabniškim imenom že obstaja.*
One empty line to many.
Here i would keep it as it is... so we can distinguish them from posts.
Nit: s/bad release name/release name on change doesn't match URL/
I don't know the history of this, but is there a reason that this sleep has not been removed/replaced?
You've been making the styles for cornfield conform better so I'll nit here. Needs a space on closing bracket.
I think this stuff is really good. Perhaps you can use querySelectors to run the three `data-butter-*` tests that you run above, right?
We shouldn't use inlined CSS - it's a nightmare for version control as any change on that line will highlight as a change.

There are more 1 attribute per line CSS declarations in the file, so let us standardise on that.
So we change this directly? but if we test it in XAMPP, it will show error in our localhost.
I'd be curious to see the notBefore and notAfter dates if verification failed solely on those fronts.  

Something like,

case X509_V_ERR_CERT_NOT_YET_VALID:
{
  char buf[256];
  ASN1_TIME *notBefore, *notAfter;
  BIO *bbuf = BIO_new(BIO_s_mem());
  if (!bbuf)
    die("Out of memory during SSL certification error handling\n");
  BIO_reset(bbuf);
  notBefore = X509_get_notBefore(ssl);
  ASN1_TIME_print(bbuf, notBefore);
  len = BIO_gets(bbuf, buf, sizeof(buf)-1);  
  BIO_free(bbuf);
  verb ("V: SSL certificate not yet valid: %s\n", buf);
}  /* fallthrough */
/* if desirable -> case X509_V_ERR_CERT_HAS_EXPIRED: */
default:

Then it may also make sense to disallow weak pubKey sizes and signature schemes since even if CRLs were cached and ready to go, they are already pretty weak, much less without a good sense of time.   However, semi-frequent rebuilds should be enough to keep the min build time in sync with major ssl endpoints (or your own personal ones).