labofsahil/github-event-dataset-2012 huggingface dataset:
Yes, I know :-)

However, I specifically took this route because I suspect it will perform better. Here's my reasoning: 

- using a closure to access view and StateManager means that Google Closure Compiler cannot inline the function - see this GCC output: https://gist.github.com/1605809
- contrast it with the output when you use variable passing - then GCC can inline the calls, obviating the need for another function call: https://gist.github.com/1605803

Perhaps this only has marginal impact (even on mobile), but that's the reason I chose this route. 

That, by the way, is also why I specifically chose to do the Ember.$.isReady if/then logic instead of always $(document).ready(), since, as I understand, it is more performant. 

Feedback welcome!
The method $this->config->item() has only two parameters.
As I said on the Jira issue, this should not be need. The is no reason for the wiki syntax to be interpreted here is the velocity macro have wiki=false as it should. This should be reverted IMO.
this update is something that could prevent the need for a "routes" config. But well see.
Условие нельзя исправлять. Подставляй значения вместо __
If you disable the plugin, then onStop/onStart won't execute, so the de-registration should not cause any trouble (the assumption is that registration happens on onStart, de-registration on onStop but because you did not use the plugin to create the pool, the registration did not happen onStart, hence your issue). 

That said, we are working on making the DB plugin more abstract, so you will be able to plugin your implementation and use it as play.api.DB
Ahah! Perfect! Thank you, that detail is huge. Definitely will inform my usage of Faraday. :-)
What about isXWikiLdapAuthenticator ? This way it makes it clear it's about the XWiki bundled LDAP auth
nobody think that it's a shit... Do what u want to do
This diff is huge. What happened?
By the file, I think you imported version 0.78 and made your changes over it.
We are setting lang attribute here so CSS engine will know what selectors to use.
So maybe the only problem we've got is that the upload script in the tiddlywiki.com repo doesn't update http://tiddlywiki-releases.tiddlyspace.com/upgrade, and perhaps it should? Annoyingly, it would mean another set of credentials required for doing an upload.
I believe I was trying to mimic whatever content was put in the html output.
Initially -> initial.
is `exercise-loaded` anti-camel-cased because exercises aren't camelcased?
http is the preferred method of transport for public repositories on GitHub, see this article for reference. https://github.com/blog/642-smart-http-support
najoa anyway... sow eben eye of eternity fertig gemacht :P  und nochn raid weniger auffer liste
We only hear about the feature in the third paragraph. I'd put a short paragraph at the beginning of this section to explain what it is and then go into those lengthy discussions.

BTW shorter is better. A sentence longer than two lines is hard to read.
We could do that, but we would still need to do a null check for imagePath. I'll just add it in the makeMarker method.
hmm, just check if the first item in the split array is : instead of #!, insert /bin/sh after it, and remove the shebang chars
It seems that the original functionality of ```delayIn: 500```  is also not working, any fixes ?
About defines: can you list the core files where special defines are needed ? I have removed -DNGC in my current repository as it is redundant with -DGEKKO and I plan to replace #ifdef GEKKO in core files with more specific define (for example, #ifdef CUSTOM_CHEATS in sms_cart.c, #ifdef CUSTOM_BLITTER in vdp_render.c, sms_ntsc.c and md_ntsc.c) and remove unneeded ones (in system.c, remove the use of internal soundbuffer and let the caller of audio_update pass output buffer as parameter). Do you see other stuff you would need ?

About your comments:

1 - can you explain the reason why you can't detect system hardware in load_rom ? load_archive is supposed to update the filename in/out parameter with extracted filename if file is compressed, is that what cause a problem on PS3 ? can't you extract zipped file in load_archive ? I can also add another parameter returning file extension if that matters. Also, support for upper-case extension is unnecessary, nobody use .BIN or .SMS or whatever...

2 - it's gcc extension for 64-bit integers, I have removed them since they are unused by CPU cores, it's a left-over from MAME original files...
leeching i believe. Author is souler as far as i remember.
I just tested it with what you told me and the right order is the one I put there, really. Are you sure you are not confusing this opcode with one of the two others used for knockback?
There might be a generic ToStringTransformer class somewhere that we can use.
salaud!
One suggestion, maybe the APPLE specific set_target_properties that are all the same for each lib could be moved to
SCL_ADDLIB macro? 
I've been thinking some windows specific options might be moved there as well...
forgot to add in commit msg, removed the auth changes for 'os' ...
until someone can present why this change is needed... 
to me 
-    uint8   os[4]; 
+    uint32  os;
looks like its maken a single thread/string into a single one...
still looking for answers. plus atm this breaks using none warden realms with auth.
Just curious: why bother escaping a string we craft?
Hi, could you make me a .patch for this commit ? I tried myself but didn't succeed due to the fact that my kernel isn't on root folder of the repo...
So far I think your commenting enough, all I really require is method level and if you are doing something confusing a few sentences is helpful. Also variable names that say what they do is good, which you seem to be doing.
Thanks for the pull request Shay - we actually have an oustanding pull request that drops this ext install and defers to a warning on STDOUT when using Ruby 1.8 w/o system_timer.  I'll see about getting that merged today w/ a new release. ( The ext install method had some issues w/ bundle installs that were difficult to resolve correctly for all platforms )
@jbridson This should go into cms/scss/_AssetAdmin.scss (the AssetAdmin is not part of the sapphire/ module)
Did you add that to your config.yml ?

```
nelmio_solarium:
    adapter: ~
```
I add startManagingCursor method in Simple_NotepadActivity class. Now it should works properly
@lsmith77 i tend to not agree but as it will not harm anyone - let's specify all deps :-)
![face](http://www.fisheaters.com/holyfacejesus.jpg)
Oh gosh. core.autocrlf!
Remove this. line.
That's old code ignore plz
You're probably right. 
I was just thinking it would be better to change the model so that $credits could be init'd without direct knowledge of the [offsets] of the ->credits member.
Something like:
```echo $context->getDisplayCredits();```
saner parameter checking to prevent exceptions
А, я duracio. В первом случае i = i/3
What is "property instance name"?
Can the `HandlerResult` be extended to return the ldap query's `SearchResult`?
"Jacoby" again
why not use Future.failed?
needs to return an Iteratee
Thanks, I have to familiarize myself with more idiomatic test assertions.
You're right. I was overthinking. I did a quick benchmark for contains (10 entries)

Array : 776 Bytes : 1.3 ms
s.c.i.HashSet: 1088 Bytes:  0.28ms
s.c.m.HashSet: 896 Bytes: 0.30 ms 
j.u.HashSet: 1200 Bytes :  0.35 ms

Silly me, there is no reason not to use s.c.i.HashSet.
Yes, this is a good way to do it. We don’t even need to obey any order on the incoming requests, so it is fine to just send them via

    endpointFuture onSuccess { case ref => ref ! assoc }
looks better.  could this be in a Model module in a pack?  (note: #ENGLISH tags are there to label hard-coded english.)
`find -name '*.py' | xargs grep -r ' ::' ./* | wc -l` shows 271 occurrences of ':: ' **with** the space. As such, changing this might in fact add the column, but would be inconsistent with the rest of the documentation. ([example](http://kivy.org/docs/api-kivy.uix.scatter.html) doesn't show columns)

If you'd prefer that columns be shown, I think a separate pull request should take care of this.
It's supposed to be a shortcut when you type a query into your browser's location bar. Strings can be escaped with ".
maybe we should add a type='int' param to _get_or_bust()

default 'str'

or else have a _get_or_bust_int()

seems a good plan either way
Just making sure you are paying attention. Fixed.
Missing case for DoubleValue?
Ah right yeah didn't consider that possibility.
Yup, use avcodec_guess_channel_layout in that case. (in that statically linked case we don't need to care that that symbol is in a separate lib).
No toe-stepping bobo1on1 - it's open-source and team-work :) 

Until the DSP's and other enhancements get in, do you mind if I tweak a few things? The volume amplification can happily stay in the stream, but I do think the limiter should run on the final samples.

The streams already have a volume level per stream which can be any level not just 0.0f - 1.0f, so they can be amplified all you want. The limiter can then run if place of the hard clamp on a larger sample set. You still get your feature, the limiter will still kick in to give the poor-mans DRC and it won't become VolAmpire running all the time on top of the hard clamp on a small dataset.
why use compare(long,long)? seems like the gain in conciseness is minimal given it will force the conversion to long (though that is quite fast).
Changing 15_MINUTES to MINUTES_15 because protobuff does not accept to start with a number...
is this a debugging assertion or something you would want to enforce at runtime?
Shouldn't we replace file:make_dir with filelib:ensure instead?
the setTimeout is only there to mimic a DOMNodeInserted callback, isn't it?
maybe one of these links helps:
http://davidwalsh.name/detect-node-insertion
http://www.backalleycoder.com/2012/04/25/i-want-a-damnodeinserted/
http://stackoverflow.com/questions/3900151/is-there-a-jquery-event-that-fires-when-a-new-node-is-inserted-into-the-dom
Hum, I think it shouldn't happen, but it has bitten me.
IIUC, you swapped the checks order for autocomplete.conf/snippets.conf, is that wanted?
Actually, a new trick I've discovered: `!!object` qualifies the existence of `object` through the NOT-NOT: `!!`. Mike Ash has details on his blog: http://mikeash.com/pyblog/friday-qa-2012-12-14-objective-c-pitfalls.html
This should be prefixed, it's also a misleading name as it's a multiplier rather than an actual time.
in_array is better than array_search since we don't need the key of the found value
can't we just use a temp buf here before converting it to a Lua string?  Pushing a string into the Lua stack, then manipulating it one byte at a time seems kinda agressive.
It doesn't look like the `DECOMMISSIONED` state is used anywhere?
This is the check that I think goes wrong if `ndim == 0`. Overall this code would simpler (in the sense of not just being correct, but being obviously correct) if you just had a block up front that did
```
if (!PyTuple_Check(idx)) {
    idx = (idx,) # well, the C API equivalent
}
```
and then only dealt with the tuple case.
@morrisonlevi rape? It's perfectly valid in HTML5. We aren't dealing with XHTML, here.
пустые строчки не нужны
All done. New patch is at: https://github.com/anjshenoy/rails/commit/9f9fb6ea1c6586bde42dc8d50429a2e0454e5b00. Please have a look. thank you.
On Fri, Jul 20, 2012 at 4:46 PM, Josh Suereth
<reply@reply.github.com>
wrote:
>> @@ -13,7 +13,7 @@ object VerifyClass {
>>        Class.forName(name, true, cl)
>>        (name, None)
>>      } catch {
>> -      case x => (name, Some(x.toString))
>> +      case x: Throwable => (name, Some(x.toString))
>
> Note:  This one is my fault.  We just need something that captures Class VerifyError (and related) exceptions as well as ExceptionInInitializationErrors for static objects that bomb on classload.    Since this class is only used in our build, it's not critical for a release.
>
my criterion was: as long as there's no obvious control flow exception
going through the catch and the caught exception is processed further
I just put in the Throwable.

Cheers

 - Martin
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scala/scala/pull/955/files#r1205836



-- 
Martin Odersky
Prof., EPFL and Chairman, Typesafe
PSED, 1015 Lausanne, Switzerland
Tel. EPFL: +41 21 693 6863
Tel. Typesafe: +41 21 691 4967
This needs because `FlatHashTable#iterator` became protected
This error is confusing I agree. However, it's not a disaster, since the preceding error clearly indicates a problem.

Moreover trunk is susceptible to the very same problem when parsing `class` definitions as described in https://issues.scala-lang.org/browse/SI-6763. 

This patch is a slight regression in a sense that it exposes `trait` definitions to the issue at hand, but I'd argue we can live with that given:
1) This is not a major error.
2) Along with the problematic error message compiler also emits another error message that can be used to get rid of this one.
3) We have a JIRA issue for the underlying problem.
True, got confused by the rest.nonEmpty. Looks correct.
Are you going to get a different result for (x.encodedName == y.encodedName) than you would for (x == y)?
"Since reified trees can be compiled outside of the scope they've been created in," and the next one 
"special measures are taken to ensure that all members accessed in the reifee remain visible"
This part is not a hack --- look at get_func_type again.   It's just making calls to the ctypes module to identify what fcn is (a callable, a ctype-function with the right signature, or whatnot).  

It sounds like you might be talking about the _GET_FUNC macro which is assuming something about the structure of ctypes objects.   We could use ctypes.addressof via Python to get the function pointer, but that is a lot of C-code and reference count manipulation when it's a simple pointer de-reference in C-space.      It would be very surprising if ctypes ever changed it's ABI so that the pointer immediately following PyObject_HEAD is not the function pointer we are after.      

I just don't see it as a major problem in this case.
On Wed, Apr 11, 2012 at 11:21 PM, Tom Bachmann
<reply@reply.github.com>
wrote:
>>          if not series.has(O):
>>              # The series expansion is locally exact.
>>              return series
>>
>>          series = series.removeO()
>> -        if series:
>> -            if (not skip_abs) or series.has(x):
>> -                break
>> -    else:
>> -        raise ValueError('(%s).series(%s, n=16) gave no terms.' % (f, x))
>> -    return series
>> +        if series and ((not skip_abs) or series.has(x)):
>> +            return series
>> +        n *= 2
>> +        if n > 16:print n
>
> This is the "warning" I am referring to.

That was just a debug statement that has now been removed. I wanted to
make sure that the loop ran past n = 16.

/c
Yes...I need a little cheat sheet to remind me when I'm going to get burned by certain expressions. I had tried

```

>>> type(S.One) in (int, bool, Integer)
False
```

and so I suggested the more verbose form. What you have works, however. Does MatExpr use `as_int`? so a float doesn't slip through?
This test is irrelevant now.
I am not sure how to use the rst table, but I would try putting the if part on the same line:

```
    Imaginary**integer      -> Imaginary if integer % 2 == 1
    Imaginary**integer      -> real if integer % 2 == 0
```
That's great to hear. I'll apply isinstance fairly liberally to this whole module then :)
You could sort the args before calling Basic.__new__
@gdevanla, what's up with this? Should `updown2` be removed?
Need issue number here. In this case it's 1628.
Is it possible the field exists but is not a long? That would make this fail wouldn't it?
This class nesting is a little weird, if only for the long lines, but I don't care enough to block you on it.
This is a diff-leftover, please remove before final commit. :-)
Ahhh, didn't know Silex had lazy-loading for services. Nice!
Done.
Oops.  Typo in "Undlerline"
Err, good question. I'll resurrect it. Not sure how I managed to delete that line

On 25 Jul 2012, at 08:14, Ben Hood <reply@reply.github.com> wrote:

>> @@ -27,6 +27,6 @@
>> #contentviewer {
>>   .span-9;
>>   .last;
>> -  border: @dotted-border;
>> +  border: none;
> 
> Why did this border have to go?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lshift/diffa/pull/196/files#r1232703
Changing the name of this will break anyone who is currently running using this current main().  If you want to rename it, then do something similar to what has been done with ClientMain and ServerMain instead.

Or just don't rename :)
If we are adding a sub-type then the configurability of the type is meaningless and we should just set it to a hard-coded value based on the Main that the person is running.  The original thinking behind the types being configurable is that they would make a flat namespace that we should do this sort of thing for without having to introduce another type for.  

That said, the way the client ignores the realtime nodes for caching will be difficult if we allow the types to be truly free-form, so we should remove the configurability of the type and just have this subType be configurable.
You cannot delete directly from the modules table, left/right id is used and will not be correctly synced this way.
That makes rather little sense. You speak of managing extensions everywhere in the language file, so it should be Extensions Management. The extensions manager in the code is not something users need to deal with, and should not influence our decisions on language variables.
this ^.
If's should be broken down in an intelligent manner in order to be easily read and understood. This is one of the cases where I think it's correctly made. (I do prefer the boolean operators in the right, though.... but that's just a preference)
I think you added an extra line.
its a parameter of the function
phpbb prefix?
I like your version except it omits the fact that elements are style names as opposed to e.g. paths.
There are 3 promoted connections, one for each datacenter, so I'm selecting the first active one. If it goes away then the next datacenter is selected.
we should probably log the error that got us here for debugging.
It's wrong answer. Discard those changes
I think MultiHandler makes the most sense. I was thinking about renaming it to "Composite" handler though, since that sounds a bit better.
Yes, or NFS error, etc.  The practical effect is that the `mojito compile rollups` command fails with an uncaught exception from `writeFileSync()`.  Hopefully that exception will have details on why the write fails.  (It's my understanding that one should not catch exceptions unless one can reasonably act/recover from them.  In this case, the error/exception from libfs is likely to be more detailed than anything we could provide.)
probably want to kick changelog with a new version detail in here... 0.2.0
Good practice:

"To avoid problems with both validators and browsers, always use &amp; in place of & when writing URLs in HTML:

<a href="foo.cgi?chapter=1&amp;section=2&amp;copy=3&amp;lang=en">...</a>"
Lets wrap this line to keep the code 80 characters wide.
yes.. that wasnt merged when I had written this code. Adding it
What is 'MovieEdit'?
It's necessary to make the bug happen, as described on the referenced web page.
I suspect the reader may not know the CAR function from LISP (I did not). It's a quick web search away, true, but also wouldn't hurt to include here.
It doesn't make sense to test for null here but not test for it in the other loadFromJSONObject methods that load members.
They would crash if they really got a null.
Instead, "assert(jobj != null);".
How many times are you going to call values.get('uid') here?
return '/' + '/'.join(arg.replace('/', '') for arg in  args) + '/'
this plus the rm_f in clean could be a problem. I'd suggest setting it to nil instead.
Yeah I was really trying to avoid this method too. I think it's necessary unless we delay this feature until 2.0.
I know you didn't start it, but there's some serious copy-pasting going on in this file that looks like it could be easily refactored into a better MugType factory function. For example, the line `mType.typeName = formdesigner.util.QUESTIONS[mType.typeSlug];` shows up verbatim in this file 21 times, and `mug = that.createMugFromMugType(mType);` 17 times. Would be straightforward and already a huge improvement if each of these functions looked like

```javascript
function () {
    return MugType.from_spec({
        typeSlug: 'time',
        controlNodeAllowChildren: false,
        mug: {
             control: {
                 name: 'Time',
                 tagName: 'input'
             },
             bind: {
                 dataType: 'xsd:time'
             }
        }
    });
}
```

or something. Working off a static definition like that will almost certainly save us from ugly copy-paste changed-here-but-not-changed-there type bugs down the road.
is it really needed ? Looping over an empty array is possible without any issue (I simply haven't checked the code to be sire that the array is always passed)
And all of this should probably be pulled out into it's own function.
too many newlines here?
Dieser Notiz Stichworte zuweisen oder entfernen
oder
Dieser Notiz ein Stichwort zuweisen oder entfernen
?
Both forms work I think (I have no preference for either one):

    In [10]: _k = 'bc'

    In [11]: "a %s d" %  _k
    Out[11]: 'a bc d'

    In [12]: "a %s d" %  (_k,)
    Out[12]: 'a bc d'
Instead of this giant if block, I would prefer something like:
key = proto+":"+socket_type.lower()
funcs = {
  "imap:ssl": (imap_check_ssl, 993),
  "imap:starttls": (imap_check_starttls, 143),
  "imap:plain": (imap_check_plain, 143),
  "pop3:ssl": (pop3_check_ssl, 995),
  "pop3:starttls": (pop3_check_starttls, 110),
  "pop3:plain": (pop3_check_plain, 110),
  …
}
(func, default_port) = func[key]
if not port:
  port = default_port
func(hostname, port)

I find that moving the configs into a dictionary makes it more obvious what cases are being considered, and makes it harder to miss one.
I'm happy to just change this line back if that's the problem?
I suggest the following in order to work with system python:

```ruby
    if ARGV.include? '--python'
      # Avoid the .egg and use the python module right away, because
      # system python does not read .pth files from our site-packages.
      mv pydir/'VTK-5.10.0-py2.7.egg/vtk', pydir/'vtk'

      # Remove files with duplicates in /usr/local/lib/python2.7/site-packages
      %w(site.py site.pyc easy-install.pth VTK-5.10.0-py2.7.egg).each do |f|
        rmtree pydir/f
      end
    end
```

Note, I use `rmtree` because of the directory to remove.
Don't need a separate args array here.
Is the goal here just to ensure a trailing slash? Would something like this suffice.

```ruby
if @path
  %Q{data-path="#{ File.join(@path, ‘/') }/“} 
end
```

Would return...

```
> @path = ‘/foo/bar’
=> ‘/foo/bar/‘

> @path = ‘/‘
=> ‘/‘
```
Supprime donc les lignes de debug
discard it...
my browser trigger download on txt, so i change it ...
Accidental line removal?
I don't know if there is an equivalent to `index_lookup` for `mr_from_field_match` yet though.
The session module is written by our coding guidelines not the way connect does it.
this method does not add much value
主要是涉及更改指定BLAS/LAPACK或者GCC版本（比如Mac上gcc 4.2与gcc 4.6并存的奇葩情况）的时候貌似只能自己动手make.

On 2012-3-31, at 上午1:04, Yihui Xie wrote:

>> @@ -200,6 +200,13 @@ $ which R
>> $ echo $PATH
>> /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
>> ```
>> +当然,奇葩的make -j8可以不用安装(sudo make install)就能使用R,你只要在`~/.bashrc`后面加上PATH就可以了. 更改`YOU_R_PATH_Directory`为你的R目录,复制如下内容到你的Terminal中:
>> +
>> +```bash
>> +cat >>~/.bashrc<<EOF
>> +export PATH='YOU_R_PATH_Directory':$PATH
>> +EOF
>> +```
> 
> 其实我是觉得make既不适合新手也不适合高手，只适合介于二者之间的要摸索成为高手的人，摸索过一遍明白这里面的道理了就没必要再这样整了。
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/yihui/r-ninja/pull/2/files#r629504
Isn't this the same as `bindImmediately: true`
I would do away with the second check here
Yeah, I think it could definitely be just a function that returns a POJO. I originally had some other methods in the class, but now a POJO would be fine. Random aside: prototype chains get super optimized so it's usually ok to add another hop.
Not sure this is right, shouldn't the elapsed time be taken into account at some point ?
These static styles (i.e. right: 5px; display: inline-block;) should be in a style sheet.
this isn't called brackets.ready anymore.
added comment. this is to allow unit tests to modify which folders to load.
I'm not the first person to do this, but I'm also not terribly attached to it. It's interesting that this is the line that causes reaction, and not the more frequent "free(x), x = 0" pattern. Here, semicolons it is.
that was a leftover...thanks
This was Tim's method for restricting each row to only 3 results.  The results-display block is nested under a row-fluid div. I'll look into cycle
There is probably a more elegant way to write this function
It is my understanding that it is unnecessary to re-declare prototypes that are already defined in a protocol. I'll remove lines 5-19 as they are redundant.
The splitting of the string into lines over and over again is particularly problematic, I think.
I can upper_limit is instance of datetime.datetime.
Can you indent the whole block?
I put this into the same line as the rest (one line above).
This is not needed then.
Aha! Space!

Wait.. it's mixed throughout the file. Blast.
same as above. Also if this is similar enough to the top one can we turn it into a function?
I think this needs to be adjusted to be 0 or positive, it doesn't look right: http://dl.dropbox.com/u/4403845/Screenshots/45.png
Do you mind fixing the spacing for these brackets? Nothing else in our code bases uses this style.
File a ticket on lighthouse for this if you haven't already
I meant lines, not spaces, so I was thinking of just always using 1 space with appropriate top-level comments.
you probably don't need to say that it requires callback as the rest don't
@MrWerewolf ah right you are. I have this working on development but did not commit the change. Good catch! This [commit](https://github.com/ruhoh/ruhoh.rb/commit/8d4d477309e3c6e9072d0187d04ebb72174d8a62) should fix it.
Nice, Jack!

On Tue, Nov 13, 2012 at 8:42 AM, Jack Kuan <notifications@github.com> wrote:

> In salt/renderers/stateconf.py:
>
> >  }
> >
> >
> > +STATE_FUNC = STATE_NAME = ''
> > +
> > +STATE_FUNC = __opts__['stateconf_state_func']
> > +STATE_NAME = STATE_FUNC.split('.')[0]
>
> it's in *opts*_ to serve as a doc and provides a default value for the
> option. The option is there so that users will know and can override it by
> specifying it in their master/minion config.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/saltstack/salt/pull/2544/files#r2111027>.
>
>
if totalPages = 9, then pageNumber = 10 will be converted into pageNumber = 8 -- but what if pageNumber = 9? I'm guessing that either it should be "if($pageNumber >= $totalPages)" or "$pageNumber = $totalPages;"
would like to avoid 'activeByDefault' for any profile.

Instead propose we add this to 'it' profile
"Not pooling!" needs a more detailed comment IMO. IIUC the actual connection manager that is used is a pooling connection manager, but this Provider overrides the keepAlive setting so connections are closed immediately?
flag变成enable，意义更明确一点。
My fault--I misunderstood the spec. Not needed.
I'm not sure that these two are equivalent.  Feed is the upstream url, uri is the url to the pulp server serving the repo.  I've locally added a uri method that constructs this as pulp no longer provides it.
Can you change the class names to something more path specific.  We tried to make this generic and refer only to ''paths" not necessarily environments.
Can this namespace be tested?
Aside:

i think it's an antipattern to pass in true/false in methods like this and instead use differently named methods. Since this is a constructor, it may be worth creating factory methods to create Cats, soething like Cat.paused(), etc.
Typo "Seach", actually as we don't have search yet this should probably just say "Enter address"!
fixed - now it's ``'auto_colname'``.  I may not always like the terse variable names, but you're right consistency is more important here :)
Whoops - thanks for pointing this out!  @iguananaut fixed it in master in astropy/astropy@99712bfa
Why not? I've been testing this code now for 6 weeks without any problems.
If you (or someone else familiar with copyright / licensing stuff) can provide a trimmed down version for one of the files and I can give a shot at updating all.
hmmm that is a fair point lol.  Second try coming in a few mins.
I got the inspiration fromt the qt_application.py. The MockWidget also implements the registry of objects but we need a way to access the object by name. Is it available from the server side object?
Not yet but it should/will be. It's always going to be one though currently because of the other faked font functions return that there is only one font, which is wrong in itself as really there are no fonts, as I've not gotten as far working on them again yet. This at least stops games using the random values that are in the un-init'd struct or dividing by 0 or other fun things i've seen tonight :)
maybe add:

```python
self.bg_processes = [ p for p in self.bg_processes if p.poll() is None ]
```

here, so dead processes are filtered out.
I still think doing this is confusing the purpose of `LazyEvaluate`, but if I can't persuade you, I'll let it pass. I don't think the formatting code actually calls this method now, anyway - it should call `__format__`.
The sizes vary wildly, though I guess we can ask the function for the size if we pass `NULL`?
another note: in order to distinguish between the dust compiler created functions and the lambda's that can exist as part of the context , we have
the elem.isFunction check

see the tap method fyi
This is another old .org page where php_url breaks the link. I hope we can some day get all this stuff ported...
jQuery already has a trim function that uses a native trim if possible: `$.trim()`
Nit: `<strong>` is used below, but `<b>` here. I prefer strong, but also it's nice to be consistent.
I think using "kitsune" for everything is ambiguous. We really should use names that aren't ambiguous. That's the only reason I prefer the NAME/USER thing to kitsune/kitsune.

If you can solve my ambiguity issue, I'm game for changing things to be more like kitsune/kitsune and carrying that throughout the docs.
Is the "l" in "ltxt" for "localized"?
I'm pretty sure there aren't any falsey dates, but I'd change this to a ``if latest_metric is None`` anyhow.
there's an even better way - just populate the dictionary in the loop rather than a list that gets converted...
Weird but the list says this proc is also called ``update_signatures``.
I think we can just remove this file. Github should use README automatically.
I don't think that table has org info in it, though.
file* :)
I don't think this has been deployed anywhere yet, but I'll double check.
A callback for the other confused case, that returns void and takes no callback?
a method exist check make more sense here?
you should return the return value of ``PHPUnit_Util_ErrorHandler`` to let it choose the return value IMO
I'll open an issue for adding a comment. This has to be done for:

- the validator,
- the ORM,
- the ODM,
- Propel
The "placeholder" option should be removed here and added to `FormType` instead.
Changed in new commit
This is one time use variable, so it's not really useful, even for readability.
This can be problematic. I can make my requirement for a variable so that it also matches the empty string. So it's a valid value.
the first part of this check is useless: if it is higher than 5.4.4, it will also be higher than 5.4.0
Do we still need this method ? The tag could be updated to call the renderer directly as it is a public property
Maybe it's better to say, that RequestMatcherInterface only need to support Request and not necessarily a path string, so they don't need to deal with that case.
I don't think this is needed in the toolbar. It could make it become big and someone wanting to see all metadata can look in the profiler IMO.
The ```return``` line could be a part of the ```problem``` method.
will fix it on my next commit
Needs a better description, but I'm not sure what the format of these arguments really is! Please help!
It's not really the copying that I was questioning  - it's the caching of Downloader instances. It adds code and complexity without a tangible benefit.
I meant the closing parenthesis, but it's ok.
Yeah, maybe. It doesn’t help when there are no valid credentials, but making the user ctrl-C or switch to another command prompt to create the user isn’t any worse than this.
forgot this one in the last pull request, so the second phrase could actually be the first phrase again. now it will never come twice in a row.
Maybe reuse HttpServletResponse.SC_NOT_FOUND for 404?
(otherwise we don't really care if the module was null)
Is this still an issue against latest master branch? I saw a commit recently which was merged to upstream which I think should get you past that "Once a process is reloaded, always reloaded" issue. If you are still running into this issue, then IMO it's better to un-comment this line and instead use a @Ignore on the test so that it can be properly tracked in the test results.
Use single var, see also output of running `grunt`
WIN! Kind of, still talking about Android...
@since 1.2.0
sorry but i disagree. think of curl_multi_exec. this is connection specific.
You're right but we should leave it to a separate PR.
I think you can change this to

    adb_shell("rm ...", ignore_error=True)

which is a lot easier to understand.
On 20/07/2012 11:56, Germán Toro del Valle wrote:
>> @@ -212,15 +212,29 @@ var Recents = {
>>         Contacts.findByNumber(
>>           callLogItems[i].querySelector('.primary-info').textContent.trim(),
>>           function re_contactCallBack(itemLogEl, contact) {
> Do you mean "logItem"? I do not know what you mean with "llogIteml" :O

Yeah sorry. I have tried to had '|' pipe character before and after and 
it does not look good for this word :)
nit: `{}`
`nameElement.textContent`
Is a visual thing, not related, but realised that we have that extra margin, now all the labels for the icons are at the same level
I think if there is no other kind of content, like a heading or more metadata, we should use only `li` tag or `p` but not both nested.
But it happens the same to tel and email, doesn't it? tel = [{type, number}], email=[{type,address}]
Please shortand syntax in background:
`background: rgba(0, 0, 0, 0.8) no-repeat center top/cover`
oh yeah @steveck-chung that's sound perfect :)
I assume cache keys are based off of user input (not geocoder results) Do we need to do any other sanitizing here to make the cache better? Eg lowercase, strip punctuation, etc.
~~~
"Create New Job" フォーム内の右サイドにある "Upload Definition..." というボタンをクリックしてください。
~~~

→

~~~
"Create New Job" フォーム内の右サイドにある "Upload Definition..." というボタンをクリックして下さい。
~~~

"ください" と "下さい" は所々混ざってるけど、とりあえずここだけはすぐ上のに合わせて、"下さい" で :last_quarter_moon_with_face:
if -> when

(numberp nil) -> nil so you don't actually need the first condition
Perhaps checkFileExistence is not the best name for the method if the src is actually being changed here.
Don't include `__date__`, or if you do, keep it up to date.
Can you fix these? Check which one to use from looking at the original strings (here in Github)
This would fail if the user is running from sources (albeit not likely on Windows) - Might also want to check for python.exe
We try to fix the freeze problem when we move to a another chunk.
I'm not sure if the engine don't update the transform when slow to load chunk, or if the render slow because it receive chunk mesh.
Whith this PR, i haven't freeze when i move to a another chunk, but i don't have next chunk loading...

The fps don't decrease when i move to a another chunk (liitle but no enough to explain the lag), so i don't think it's a render issue.
I'd rather not add any more setter methods to Boomslang; having them in the first place was a mistake.

Ideally, what the caller should be doing is something like the following:

```python
plot.legend.title = "My Title"
```

You can make this work via a property (it's done several other places in the code), but I can always put that in later.

If it's not critical to have this method, I'd prefer that it be removed.
It's hard for me to see the whole code path here.

Is it possible to craft a request to this form that then redirects the user to a non-GOV.UK page? We have to be very careful to avoid creating an open redirect.
Yes - but what should the application do, when it detects, the target is not a valid url?
We could attempt to redirect error_logger output to a file and even make the log file a configuration option

```erlang
error_logger:logfile({open, "/tmp/riak_nagios.log"}).
```
Just `view:dispose` should be pretty OK.
Not at all. Defining without a name is the common best practise. When the name is not provided in the define statement, the name is by default taken from the file name, which allows more flexibility for module naming and mapping.
this comment is also useless :)
Hmm. I don't know. I'll have to look into this; I don't think I've actually
touched the conversation model.
On Jun 7, 2012 10:56 AM, "Maxwell Salzberg" <
reply@reply.github.com>
wrote:

> > @@ -107,8 +107,6 @@
> >      t.datetime "updated_at", :null => false
> >    end
> >
> > -  add_index "conversations", ["author_id"], :name =>
> "conversations_author_id_fk"
>
> why is it gone? :P
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/diaspora/diaspora/pull/3312/files#r945513
>
以下の事例紹介はその分量に関わらず包括的なものではありません。もし、Backboneを使ったアプリに関わった場合は[wikiのBackbone apps](https://github.com/documentcloud/backbone/wiki/Projects-and-Companies-using-Backbone)のページに追加してください。
Let's only update attributes once. Change the default branch line to just be `self.default_branch = discover_default_branch`, then change yours to `self.language = detect_repo_language`, then add a `save` call at the bottom.
just curious: is there no way to group those URL matchers so you just call `front.init()` once? If it always gets called the same way it might be nice to not have to duplicate it.
sbt cant compile and throws errors in windows.
I would be happier if the responsibility for knowing whether to start the FrontRefresher was in FrontRefresher itself. Do the `Play.isTest` inside `FrontRefresher.start()`?
This changes the previous default 'ignore fields'

* yours: [ "severity", "source_host", "source_path" ]
* previous: [ "facility", "full_message", "short_message", "host", "level", "line", "timestamp", "version", "file" ]

Thoughts?
than -> then?
TOS/PP info was only displayed to requiredEmail users who never signed in at this particular site.  Since requiredEmail is not needed, TOS/PP no longer needs to be displayed here.
privacy point: logging email addresses when not strictly necessary increases our chances of capturing where people are going on the web (because we can correlate to verifier logs).  it's a nit...
@callahad and I will be talking through all the changes in a couple hours.  I'm fine with `"enabled": false` if that strikes a balance between clarity and anti-double-negativedness
good to list the choices here - it would also help to have some clue what the names mean (i.e. what exactly is "small", "medium", or "large", and what effect does that have on how often they are run?)
it "resolves a type from the enclosing module"
don't need the trailing :Unit
i'm not sure what this is?
I'd prefer `-o, --options <file>` personally
Is the word break fix specific to IE7 or 8 as well? I took a look and you are completely right about the rest not really being needed
Unnecessary blank lines in docblock
> FormatterInterface's job is creating a single-line string from the event data
Totally wrong! Defining the role of the format is: "The formatters normalize and format incoming records so that they can be used by the handlers to output useful information".

Type-casting must be located in the formatter. Type-casting is format an information of the event. Does MongoDB can handle any type of variable (scalar, ressource, object, array, iterator, etc.)?

"single-line string" is only the role of SimpleFormatter. XmlFormatter is single-line too? The writer is only handle the event for a backend.
This class needs commenting
formatting :p
the end of copied trait ;)
Fixed in latest rev.
Please remove the unused use statements (btw, the PHP-CS-Fixer should be able to detect and remove most of them)
wrong indentaton here (it should be only 4 spaces for the additional level)
i guess in the mapping we could check if someone explicitly sets remove cascade.
Should we support both?
`call` should never be used as a method name in JS to avoid ambiguity with `Function.prototype.call`: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Function/call
btw, why checking for the length of the nodeList here and not in ``getLinkNodeHref`` ?
Swap JBoss AS 7 and EAP.
Yeah, it looks like I missed that whole file. Just re-running the tests.
Not sure the purpose of this. Appears unused?
I see the positive case here, is there a negative case? Everything is parametrized for positive and negative.
I quite like the ideal world idea that we'd have a fresh account everytime :) so I'll take this approach with this and add the assertion if the page is being watched already.
The random page is a good idea also so will look at this but might leave that for the next revision of this test.
@teodosia thanks for the suggestion :)
d'oh :P
@kellyredding - I like the simplicity of this, just one method to define. Having to call `run_tests` is not ideal, but I don't see anyway around it (for live results).
OK, I added in what I think works for this, on commit https://github.com/pccowboy/foreman/commit/ac40e558404baa9d884bb0f30790c0331197f1c6.  

It appears to be running fine for our EC2 instances, so far.
OK, thanks for clarifying:)
I'm not expecting them, I'm receiving them. Running the test suite from a fresh clone of master produces 8 failures. Most of which are a result of records already existing.
Regarding all package-related comments: That is what Eclipse' organize imports does for me. Are you using different IDE/custom configuration? Or are you always organizing imports manually?
The ENABLE_AREA_EVENTS !== 'false' on the end is deliberate, in a case where the definition is made, but set false by a developer to make it clear it isn't wanted. The extra condition will catch the mistaken define(ENABLE_AREA_EVENTS, 'false') where the developer should have written define(ENABLE_AREA_EVENTS, false).

Its my style of doing things, where possible to allow for others to make such mistakes (which are often difficult to spot), and accommodate what they really should have written. I am not particularly bothered either way, just explaining my original reason for doing it like that.
there is special instruction in JSP EL for such purpose -- ${not empty param.error}
http://en.wikibooks.org/wiki/Ruby_Programming/Syntax/Method_Calls#Return_Values
If there are no collections (because the delete has deleted the only one) then the locator for line 53 times out.
Same here (even though the first comment is below...), this could be `dasherize`. Then it's just `(mapkeys (comp keyword dasherize name) updated-obj)`. Or `(mapkeys #(-> (name %) dasherize keyword) updated-obj)` if you don't want to use `comp`. Or just make `dasherize` accepts keywords instead of or in addition to strings!
Right, I noticed and edited my comment after I placed it.
This grould probably be list.
Our it statements should begin with `verify`
I think this test can be consolidated in a better way.

```
var testCommentPermissions = function(contexts, contentVisibility, expectLoggedInComment, callback){
  // Create conent with specified visibility
  // Try to comment as manager --> check success
  // Try to comment as member --> check success
  // Try to comment as logged in user --> check success based on expectLoggedInComment
  // Try to comment as anonymous user --> check fail
}

it('test comment permissions public', function(callback) {
  testCommentPermissions(contexts, 'public', 'true');
}

it('test comment permissions public', function(callback) {
  testCommentPermissions(contexts, 'loggedin', 'true');
}

it('test comment permissions public', function(callback) {
  testCommentPermissions(contexts, 'private', 'false');
}
```

There's a few tests in here that do something very similar.
adLDAP.php should be moved into the plug-in folder
This should not include explicit/full URL. It should only include the channellogo/%d. HTSP will then serve this and the client will be able to request the file either via HTTP or HTSP.

We will probably have to add some code in HTSP to serve full URLs for clients <v7 as they will not understand how to handle the new (relative) URL.
@tsetimmy should you start the loop here instead in line#542 ?
Probably could be... but we may wish to change this to load the post-upload confirmation page instead, which'll need a handler.
Is it a good idea to add a python script to a html/js project. Maybe server side javascript might be better here as our developers may be more familiar with it..

Also are we really expecting it to change that often...?
@RSEvseev а почему в mutate ? Мы же сейчас находимся в инициализации. Можно как-то в эту инициализацию запихнуть возможность пользователю вручную ввести значение количества символов в ДНК и после этого сгенерировать эту ДНК ?
Дублирование кода. Можно было бы воспользоваться массивом из класса Cell, если задать его по другому.
да, согласен, не досмотрел.  такой метод есть и класса инстанса...
Извините, но я удалил это сообщение сразу после отправки.  Не правильно понял ваш код сначала, этот комментарий не актуален.
Consider adding this line to your test:
```coffeescript
assert.notEqual(error.lineNumber, undefined)
```
If you add line numbers to your errors it will pass.
Well, actually it works to remove the middle part. Have you tried it?
good catch.. this is wrong in nitime as well
I'm thinking that if self isn't preloaded new shouldn't be preloaded either. What we should do is:

    new = deepcopy(self)
    tmp = Raw(self.info['fnames'])
    new.fids = new.fids 

This will re-open the associated files but keep everything else the same.
s/dur/duration :)
no need for optional.
creating overloaded methods plus deprecate old API would be perfect.
Can you have the callback catch the response and put the assertions in the test method instead? I get very nervous when I see tests that have no assertions and a more generic callback would make it easier to write more tests in the future.
Ah you're right. I fixed this in the latest iteration. (I was trying to prevent an unnecessary AJAX call to get images for the sidebar if the sidebar didn't exist on the page, but right now all of the pages have the sidebar.)
This is not a phpcs issue - and this class is referenced in a few other places in this doc. I actually kind of like the verbose name (though maybe for phpcs it should be `WebServiceUser`) because it's easier to follow along with.
Good call! Changed.
use the logging formatting instead.
log.info("{} got normal shutdown", this.toString)
Idem acá, habría que quitar los estilos inline.
Me encantó el uso de `title`.
I realized now going through the tests now that it's intentional (catches names like "SAMPLE_6A").
Again, just curious: Are you philosophically opposed to requiring just the `app/models/github_url.rb` model file?
should update the contributor list in the docs
Yeah just a list should do. I don't think we want to think about public vs private for now.
I've added the more explicit assertion: "throw new IllegalStateException("Couldn't find cache for address : " + address);"