Acq: Use scope to constrain choice of lineitem alerts

This commit addresses this launchpad bug:
https://bugs.launchpad.net/evergreen/+bug/996033

The controlled vocabulary of acq lineitem alert text is set up in an
interface labeled "Line Item Alerts" in the staff client admin menu. In
the PO and selection list interfaces (where alerts can be applied), we
will limit the user to selecting alerts from those owned at the user's
workstation org unit (or its ancestors).

When we display applied alerts, we can also display the shortname of the
org unit at which the alert text is defined (the owning_lib column).
This should help clarify what's going on with alerts that have already
been applied using alert text from another org unit.

[Amended since original reference on Launchpad to also show the
owning_lib's shortname when confirming alerts at receive time.]

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Group acquisition OU settings in a new "Acquisitions" group

As seen in LP867465, the current grouping of acquisition OU settings
under the generic "lib" group leads to confusion about which
context "default shelf location" and the like apply to. Creating a new
"Acquisitions" group will help clarify that current ambiguity.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Stamping upgrade for ACQ org setting group

Signed-off-by: Bill Erickson <berick@esilibrary.com>
LP#856708 - Scrolling/div size issues in action trigger interface

The event definition content pane does not properly accommodate its contents.
In the Event Definitions tab, the list of event definitions exceeds the height of the
pane, but you can't scroll all the way down to the bottom of the list -- some of the
content gets cut off. Likewise, when editing an event definition, you can't scroll
all the way to the bottom of the page; the Cancel and Save buttons are cut off, and
you have to use the Tab key to move the focus down to those buttons, which forces
the pane to scroll to the bottom so that they're visible.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
TPAC bookbag CGI param changed to bbid

To avoid propagating a generic URL parameter like 'id', which can be
picked up by other pages and cause breakage, use 'bbid' instead.  Also,
clear the 'bbid' param from the my-account tabs.

While we're in there, silence an uninitialized string warning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
lp#1007248: tweak order in which pgt rows are renumbered

Need to renumber from highest to lowest.  Because the primary
key constraint is not deferred, doing the renumbering in a single
statement will fail if there is overlap between the set of
existing pgt.id values and the set of {pgt.id + 100}.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Fix broken menu entries under "Other -> Booking" in patron interface

This issue was reported to me by Steve Callender.  The menu entries
under "Other -> Booking" had all stopped working.

There's a catalog of URL constants under window.urls sometimes, and
formerly (or other times?) at xulG.urls for XUL-based staff client
interfaces.  There's a new-tab-opening method that needed to be more
flexible when looking for that catalog.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
ACQ guarantee no PO re-activation

Prevent the possibility of double PO activation by preventing it within
the API.  There have been reports in the wild of double-activation, even
though the UI is supposed to prevent it.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dan@coffeecode.net>
TPAC: Prevent unitialized variable warnings in My Account

Viewing a user's account preferences would trigger two uninitialized
variable warnings if the corresponding org unit settings were not set.

Signed-off-by: Dan Scott <dan@coffeecode.net>
TPAC: Prevent unitialized variable warnings in My Account (repair)

The logic in the second IF test was slightly altered by the fix.  An
undef value for username_unlimit should result in executing the block.
Since org setting values are stored as real boolean values, I simplified
the test to a simple if(!username_unlimit) test.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
LP975422 patron search from portal/splash page

make it consider the "Patron circulation summary is horizontal" library setting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Fix check for duplicate strings in i18n properties

We had the core of the check in place - just failed to check the
property we were iterating over. Doh.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Distinguish route-to-cataloging exception circ messages

It appears as though a copy-and-paste error introduced duplicate keys in
circ.properties, which in turn makes newer versions of the Translate
Toolkit unhappy and results in empty translated files. Tracing through
the pertinent code in xul/staff_client/server/circ/util.js, it looks
like the desired key was for "not_found" for the second "cataloging" key
- so change that accordingly.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Add the 2.0.10-2.0.11 upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Move 2.0.11 upgrade script into version_upgrade dir

Signed-off-by: Dan Scott <dan@coffeecode.net>
Address LP #983487: Avoid clobbering bib records at authority merge

If you've set up a relationship between bib record and authority records
based on arbitrary sets of controlling and controlled fields, but your
authority records don't have the right Subj fixed field value
corresponding to a control set that defines the controlling and
controlled fields you're using, authority merge operations may wipe out
lots of bib data.

Yamil Suarez encountered this bug in testing, and in his case what he
needed to do was set the Subj fixed field in his authority records to
'A' to match his Song Title Index (see the launchpad bug referened
above).

Previously, you could not actually save the Subj fixed field in the MARC
editor (which showed HeadSubj instead of Subj for authority records, and
didn't work).  Now you can.

Thanks to Mike Rylander for help in figuring out the above.

To provide additional protection against merging authority records when
they might not be linked with the right control set, the Manage
Authorities interface will now also show you the linked control set for
any given records.

The implementation of that last bit incidentally meant making sure flesh
and flesh_fields get passed through to PermaCrud for retrieve() calls via
the Javascript openils.PermaCrud wrapper.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Import updated translations from Launchpad

Lebbeous Fogle-Weekley originally imported these updated translations
from Launchpad. Dan Scott just weeded out a few metadata-only changes
to PO files that didn't need to be pushed to git.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Commit i18n POT file changes after 'make newpot'

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Add TPAC translations

We're still working out our translation update process; new PO files can
fairly easily slip through the net. Fix that for TPAC, which is a pretty
big deal for 2.2.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Update 2.1.2 DB schema upgrade script

As part of the march to 2.1.2, and in time for 2.2.0, update the
2.1.1-2.1.2 update script.

Signed-off-by: Dan Scott <dscott@laurentian.ca>