labofsahil/github-event-dataset-2012 huggingface dataset:
Another case of using long where we should use BigInteger.
Is then the whole method needed?
Good. You found this! ;-) (It was my feature request some time ago for Django and they made it.)
I've got no problems adding an index, that isn't strictly required to implement pagination though, is it? It just makes it faster?

The tools for editing releases are in https://github.com/mozilla/build-tools, and slightly tied to our infrastructure. Try this:
cd build-tools/scripts/updates
wget https://people.mozilla.com/~bhearsum/buildprops_balrog.json
wget -OBuildSlaves.py https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/BuildSlaves.py.template#L21
python balrog-client.py --build-properties buildprops_balrog.json --api-root http://localhost:9000 --verbose --credentials-file BuildSlaves.py

You'll need to edit BuildSlaves.py with the right balrog_username and balrog_password, and you can change buildprops_balrog.json to make whatever specific changes you want.
Wait, margin right is based on % of the parent or the actual element?

I'll see if I can make this percentage, but px is fairly harmless so I won't spend much time.
There is a bug filed, but its in .6 i think
Should be Layer2, not Track2, no?
What a weird keyword...
Is it really necessary to load html in here?
Technically no we haven't - but equally we're not going to get ANYTHING happening with that anytime soon. So we're kinda between a rock and a hard place.

Personally I think just go with it...
Isn't digest/sha1 still required for old-style hashes?
I think this line is quite useless
I'd take a patch for both. I think that that ssl isn't doing much under the covers at this point beyond read and write.
How about changing 'neglection' to 'ignore_file_error' as well?
session_sticku_header -> session_sticky_header
If Q isn't installed, just pass through so everything keeps working exactly as normal for people not using promises.
Is this code tested ? I think this can not work: hidden methods, like self.__taskName() can not be inherited
Personal taste thing, but I tend to think of these as `0 > x > 10` type expressions (and some languages support that directly in fact!), so I prefer to write them as `range[0] <= ip_i && ip_i <= range[1]`
Can you put this back? Seems should not be removed.
please restore - this option does nothing in the month view and confuses users
Is it correct to assume that find_subscriptions and setup_subs is being removed because it is either no longer needed or has been previously refactored in to another part of the codebase?  (I'm assuming it's cleanup that's not really related to the index change.)
Is there anyway we could put this logic in a more central place so that content_search and systems could reuse it (just specifying the desired permission?
This is the entrypoint taking in a list of XmlNodes that do not have have to be from the same document, so we set the XmlResolver in the existing loop over all nodes
There, I fixed the two cleanup-issues :) Sorry about the sloppyness!
No need to String.Format here
Please add docstrings for all the arguments.
These should probably be changed to relative imports (this one and the one two lines up)
Async is fine. Worst case we fail to publish our capabilities until the next ring transition and the cluster uses older information / defaults.
On Thu, Jul 05 2012, Oscar Rovira wrote:

> Can't be implemented in this way, `urlparse(...)` returns a valid
> `path` even for strings like `"thisisnotanurl"`

so what? your code and mine return exactly the same value in that case
too, no? (otherwise, you would have a problem too)... not that `and`
does not evaluate its second operand if the first is false.
Yeah that's fine... though officially it'd be better to return a datetime as that leaves formatting to the view instead of the model... in this case this is the same as we do for the other datetimes. It's only a minor thing anyway.
You seem to have the same issue for:
- cgxp.plugins.Measure.SegmentMeasureControl
- cgxp.plugins.Measure.Segment
There are two windows in the `handle_list` (disregarding a case where there might be more than 2 windows open but we haven't had this yet) so I remove the one that I know is the popup window and then I am left with the main window's handle.

I can't think of another way to do it aside from passing in the main window's handle before clicking the 'Personas' button on whatever the main site is. Which would certainly be a safer way to know exactly what the main window handle is but it would make the bidpom integration a bit painful.
Missing space around `.` at the last concatenation.
== True is superfluous
if you provide the default as above, you don't need to check for inited() since it won't fire a notification. hence, you can remove this clause.
Was used for the Unit test but no more...
Will be reset to 'throw NotImplemented" ;)
`retVal = initBranch.Run()`? I'm not sure if it should set retVal, but I was curious to hear what your thoughts are?
Your're right, Xcode did a good job there :) ... will be changed.
Fortunately my case class design happened before I added the serialisation.  However, changes to those objects become much harder.  My plan is to move away from salat completely and build my own serialisation, although another approach might well be to create a new set of classes just for serialisation to decouple the DB and in memory models.
The advantage of paste is that we don't need to add a dependency on `stringr`
Examples of this and `run_examples` would be helpful.
It would be good to add a little example of usage here.  You can copy-paste from an interactive session, and simply add the `@skip_doctest` decorator above the `@line_magic` one so the docstring doesn't get doctested automatically.  

You can get that decorator with: `from IPython.testing.skipdoctest import skip_doctest`.
Yes, this is how gevent works.  See here: http://www.gevent.org/intro.html#monkey-patching
I would prefer if we add all our DVR css to a new css file, will make it easier when we do the skin re-factor. You can just add it as a dependency to the 
modules/KalturaSupport/KalturaSupport.php  definition.
It is in preparation for `git_fetchhead_foreach`, or at least that's what I was thinking.  Basically, I wanted the FETCH_HEAD ref API to have a similar API to dealing with a normal ref.

Seeing as there's no public API around dealing with FETCH_HEAD, it probably makes sense to remove this.
Odd error. I wonder if we could catch it somehow and expose a more useful error, but I guess, that'd be wasted effort.
I think the `break_down` field would make for clearer code with this data structure:
```
{
    '2007': ['Initial support: $10,000', 'Support for full time work of James Teh: $80,000'],
    '2009': ['Expanding work: $25,000'],
    '2010': ['Growing influence: $20,000'],
}
```
Yeah, I'll create another one with a bunch of extra junk and stuff out of order and make sure it doesn't blow up.
This part is missing from the non-unifified version. Was the assumption that we always searched the wiki?
Well, not sure how the current assert behaves if the folder doesn't exist. So you are right. I will change that.
Hmm, this comment reveals that this code needs to be updated to account for the possibility that there might be multiple already-existing results for the given user/env combo, since I think your API code could create dupes. If I remember right from our conversation, at some point we wanted to update this code to always create a new result; and then we need to update the view-results code to handle that better too.
"ops_managed" though I'm open to other names.  I've corrected the reference in the readme file in .../config
Does a javascript Number Object have a clone function?? I don't think it does. Just setting the radius would be enough I think.
Files should begin with our license headers. run mvn license:format to have maven put the license there for you.
@adamfairholm Hey Adam, Have a look here : https://github.com/pyrocms/pyrocms/pull/2017 It's the same but clean PR :)
`1f *` is way cuter than (float) . . . fun
We don't add use statements for classes in the global namespace
Should be `Boolean`.
I don't think it's necessary - $this->data is protected, and all the data in it is called through getters anyway.
should be `\ReflectionClass[]`
I pushed a commit now that uses naming 1.
this file is missing
You are right. Your suggestion is much better. I've just rename it. Thanks.
no need to use preg_match for this
No need for a closing semicolon?
@JosephPeng  你的意思是应该把注释改为这句话么？
“使用这个命令是保证偶数页结束章节，若该章节在奇数页结束，则添加一张空白页。”
No, if there is an input image A or B, with number of channels different than 3 and 4, and it does not have alpha channel specified, we fail. 

The reason being, it makes no sense to guess alpha channel for images with number of channels 5,6,... or whatever.
That was my convoluted way of saying:
 
I think the crs should be passed to the factory on construction (or at least on ```add_image```) rather than at the ```on_draw``` stage. That way, we can get WMS images on top of random projections such as IGH...
Minor typo: `gest` => `gets`
might be related to this, which is more style than performance: http://stackoverflow.com/questions/971312/why-avoid-increment-and-decrement-operators-in-javascript
There is an extra newline that's needed here.
This needs to be turned into an issue, we dont have consultants in the datum state's render, we should start doing that when we can but it doesnt have to be intime for beta testing i think.
Resources should be in the src/main/java folder next to the tests. I know that not every test follows this yet, but they are slowly being fixed up.
The mod cluster subsystem should not have dependencies on the security subsystem. I assume this is an accident?
I think the reason extend converted those atoms to binaries was to avoid atom injection attacks. so we probably shouldn't simply convert to atom too.
The reason I added it was to correctly format error reporting for line numbers less than 10 (e.g. make them line up)
不明白，意思是他code不存在咧时候就取name和description？  

--  
zhoudi
已使用 Sparrow (http://www.sparrowmailapp.com/?sig)


在 2012年11月24日星期六，下午5:46，longhengyu 写道：

> In grails-app/domain/com/pkgplan/dream/Product.groovy:
> > + int pYear = 0 > + int pMonth = 0 > + int pDay = 0 > + int pHour = 0 > + int pMinute = 0 > + int pSecond = 0 > + String status > + > + // this code is the identification of each item which specified by the product owner (admin) > + // we can use this code for reference of i18n information. for example for i18n name and description > + // adding the translated description in i18n file, for example > + // product.description.10001=Some Product Description. > + // product.name.10001=SomeName > + // usage will be > + // <g:message code="product.description.${productInstance.code}"/> > + String code  
> 我增加哦一个code，这个是上个星期不得讨论到的。因为后来我想，只有description可能不够，我们还要多种语言的name和description。
> 增加code以后，在view里面就以code来显示对应的i18n name和description。
> 数据库里面存的name和description作为一个默认值。  
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/longhengyu/dream/pull/7/files#r2215046).  
>  
>  
>
line break, I love them <3
Please, if you only want to repeat in x axis use `repeat-x` instead of `repeat`
optionindex -> optionIndex
why the hidden attribute has changed?
Thanks, didn't realise, it looks ok to me, Mr @steveck-chung, you ok with this?
better if we move this resource to contacts/utilities and rename this file to image_loader.js
This code has the following error in this line:
E/GeckoConsole(  969): [JavaScript Error: "SyntaxError: missing } after property list" {file: "app://sms.gaiamobile.org/js/sms.js" line: 690 column: 2 source: "  init: function thui_init() {

Could you review it? Thanks!
while you’re at it, would you remove the tabs and trailing spaces in the #about-licensing section please? ;-)
Just followed the guidelines here: http://www.python.org/dev/peps/pep-0008/#imports
This line simply tests if the current MySQL region_flag table format is the updated one, or the old one, when the MySQLDatabase is instantiated. This automatically updates the table format to the new format which allows all flag types to be stored, given that the flag data is of a class that extends Serializable. (Most all of them should, to be honest.)
This includes all known flags in WorldGuard at the moment.
See above comment on the convertTables() method for details.
unix は "" つき
sollte nicht in production kommen :-D
please use lower case for instances: @playScreenNotificationsController
Maybe `invalid_raphael_paths` since it's an array of paths?
true  story :-D
Maybe rename sh to showHeaders and wh to writeHeaders?
no `sudo` required?
Table to delete keys from?
Use title-field module.
Careful with your file names, its pretty difficult to tell which is the executable to actually be run, JSONMake.py or JSONMaker.py
What if they want https? Or a relative path?
This hack can't be merged. I'm not sure what to suggest instead, though. One option would be to decode to UTF-8 first. Or implementing our shlex.split. Or depending on py2.7.3 for this.
This is only supported by the `MsBuild` step, so you should accept it there, rather than on the base class.
(It worked flawless with just "r", but yeah, it is binary.)

Done.
We should be explicit here about the type of maxlength, so it's clear we're comparing numbers and not strings in the if statement.

maxlength = parseInt($this.attr('maxlength'), 10);
This lines are toooooooooooo long
`milestone_id` is missed
We had duplicate error string and if was not trivial to guess correctly which part of the test has failed.
I'd rather it be named .release so that it doesn't clutter up the main directory, and/or to be moved into the topo/ subdirectory (preferably both).
Again this parameter doesn't make sense. What does it mean to display a Group as a link?
There are also scanners defined in the POMs, so that we can cut over to the Reflections.collect() method in the future.  Please make sure the maven plugin config was updated as well.
Nice, seperation of fromDomain, newDomain, and principalDomain makes this clearer.
A rebase off of dev should have this functionality built in now.
I don't like the workarounds we have to do here but better than nothing. Please make sure to add some documentation here and point the real issue so we know what has to be removed later.
Do a 'const {CircularBuffer} = ...' here
The logger shouldn't need the config, right?
You should use the 'a' prefix also for currentItem.
Same concern as above; these fact values will never be refreshed since `devicevendor` is not a local variable relative to the block passed to setcode.
The use of a global variable in these functions is pretty ugly.  It would be nice to pass state explicitly.
I don't particularly care either way, but it initially seemed odd to me that the scenario above demonstrates the constant is restored but not this.
There is a requirement to truncate the file -- the "w" mode does it and "r" does not.
Ah, I see your intention now.

Grouping together vars by sorting them seems not that ideal. I think we probably want to have the protocol functions within the protocol data structure itself.
Yes, i know, just i had to code it very quick, i'll redo it when i'll have
more time like in two weeks... after metacatalog interface

On Tue, Jun 12, 2012 at 2:02 PM, Adrià Casajús <
reply@reply.github.com
> wrote:

> > +    border:true,
> > +    collapsible:false,
> > +    constrain:true,
> > +    constrainHeader:true,
> > +    maximizable:false,
> > +    modal:true,
> > +    layout:'fit',
> > +    plain:true,
> > +    resizable:false,
> > +    shim:false,
> > +    title:'Proxy upload',
> > +    items:[panel]
> > +  });
> > +  window.show();
> > +  return
> > +}
>
> diracPage.js is a nightmare. Please refactor in a modular way.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/DIRACGrid/DIRACWeb/pull/83/files#r966251
>
how to make that notice or which is the standard way to let the devs know about this?
No idea :)
I think I have a [different solution](https://github.com/WebFilings/furious/blob/master/furious/async.py#L245) for this problem in the latest stuff.
content -> title
done -> completed

```js
var Todo = function( title, completed ) {
this.title = ko.observable( title );
this.completed = ko.observable( completed );
this.editing = ko.observable( false );
```
We must *not* return the command without scrubbing the database password!
Refactoring opportunity with a `before_filter` or `load_and_authorize_resource`.
Same argument for prefix as above. I know this is planned, but at least add a todo here :)
In that case I prefer `queryProcedure`.
A generic `each()` is something like this:

```javascript
function each(obj, callback) {
            var i, j;

            if (obj.length === undefined) {
                for (i in obj) {
                    if (obj.hasOwnProperty(i)) {
                        callback.call(null, i, obj[i]);
                    }
                }
            } else {
                for (i = 0, j = obj.length; i < j; i++) {
                    callback.call(null, i, obj[i]);
                }
            }
        }
```

I have this in my no-jQuery branch.
This should be just `return None`. Fix this and I'll merge and deploy.
Setting this to 'y' results in a hybrid approach by default (i.e. not to use MPI within a single node).

But it's basically only a configuration option that you can override, so not that important imho.
Java EE not JEE.
The markdown formatting of this list is wrong - take a look in any markdown renderer, or run dist/release-utils.sh -m and then try to fix it.
I'm not sure that the code is right exactly as I wrote it, however the code before your patch was done was effectivley

```python
def save(self):
    super(RegistrationForm, self).save()
```

Do you understand how [`super`/inheritance](http://docs.python.org/tutorial/classes.html#inheritance) works?
After chatting on IRC, let's take these noop changes.
Entire test is deprecated and OBE (it was a UNIT test)
I wanted a lightweight way to validate that audit_comment is required without tying to a specific version of rails. Not sure if this is the best way to do it. Any better ideas?
What's the point of returning a list?  It looks like the code that calls this only uses the first element.
Why is the removal moved outside of build_ossec? Anything needing perl-Time-HiRes??
you are right. @ohadlevy check the new commit pls.
Wouldnt this not allow us to manage via foreman other vms?
After changing to `directory` on lines 7 & 20, running the tests outputs:

````feature
8 scenarios (2 undefined, 6 passed)
34 steps (4 skipped, 2 undefined, 28 passed)
0m18.250s

You can implement step definitions for undefined steps with these snippets:

Then /^the following directory should exist:$/ do |table|
  # table is a Cucumber::Ast::Table
  pending # express the regexp above with the code you wish you had
end
````
Yes. I can change bindToRoute behavior back (since it's not used in load any more, it won't cause any issues there), but I think the old behavior is broken by design. With the old behavior, once you call bindToRoute you cannot cancel it. Failback will be executed on route change even if you don't want it to (like if you do ajax with success: bindToRoute(...) and ajax fails).
Looks like we have to leave it as it is just to circumvent possible SMTP server failures on localhost.
It seems better to avoid `liftIO .. shelly (put state)`, going down to IO and back to ShIO and instead figure out how to compose or monads proper or alternatively use an MVar as in runFoldLines.
直接class可以用getElementsByClassName() 方法
I recommend using pass-by-keyword (`maxworkers=2`), for readability.
php warning if $imageMagickThreadLimit is not defined here?
Candidate for another pull-request to the pull-request @emodric ? :)
@andrerom ? What do you suppose?
I would make these the same as the string constants used for the database, it wont really effect the program but will make variable names much easier to remember.
As mentioned in the previous test, you can define the property view_source_code more simply.  When you do that, instead of details_page.view_source_code_text you can have details_page.view_sorce_code.text.
I noted this in the commit:

- You cannot have a negative size QByteArray
- What's the motivation in having chunked reads -- it wasn't clear
- Pillow reads all the data https://github.com/acossette/pillow/blob/master/pillowcore/HttpConnection.cpp#L163

In general, it seems like you want to have an API that specifies how much to read at any point in time, but the problem with Qt is that it automatically expands the read buffer to fit any data in the socket.
See, I'd like these (octo)cats to say something slightly different
This or 

    custom_slug.presence || menu_title.presence || title
We do since it's not passed in when initializing a module. We'll only need it in a few places so adding it to the initialization of a module might be optimal.
The err parameter should be documented
The possible options should be mentioned/referenced here.
Definitely it would. Our current keyspace management in OAE.js didn't support this and I was trying to keep the commits self-contained due to high-activity in the code.
The getAllTenants method still has the 'err' parameter as the last one, while you're modifying this file, could you change it?
Wouldn't this assertion (erroneously) pass if the state is closing or closed?
was too lazy. added now.
no, i think there was some situations when having objects in the defaults led to problems with something rebuilding the requests. maybe it was on subrequests? can you try to run the tests on cmf sandbox with this change applied?

if all goes fine, i guess we just merge and see if and where it explodes and think of solutions then.

about the generate and such: your idea is that you can do 

    indexAction($route)

on a controller, right? if you have route aware content, you could do `indexAction($contentDocument)` and then `$contentDocument->getRoutes()` and pick one. or generate the route directly from contentDocument. how is this PR helping to solve #19?
These conflict with the built-in command `,` (which repeats the last character find backwards - very useful).
Simply changed the § to &.
Use lowerCamelCase variable names
Waarom is dit legacy? Is nogsteeds in gebruik zover als ik kan zien
Waarom heeft de healthBar maar 4 states? Kunnen we niet echt een hele bar doen die gewoon een % is?

Daarnaast is deze code erg inflexibel. Wat als iemand van 80 naar 60 health gaat in 1 hit? Dan verandert de healthBar niet. Je moet "ranges" gebruiken. E.g.:

```js
if (health <= 100 && health > 75) {
  //do something
} else if (health <= 75 && health > 50) {
  // do something else
}
.....
```
Even though all of those changes are obviously related to the Driver library, including checks about it in another class is a bad practice and shouldn't be done.

Also, the [style guide](http://codeigniter.com/user_guide/general/styleguide.html) says that you must use `OR` instead of `||` and line 958 should be further indented. Using `===` instead of `==` would also be nice. :)
oops sorry, I copied the code over from MY_Email class last night where I was doing all the testing.
never ever considered it.  Thanks!
В данном конкретном случае - да. Но это не значит, что при изменении количества символов в ДНК нужно переписывать метод мутирования - именно поэтому вам и сказали - "процент от общего количества". 

В ТЗ есть четкое указание, и его нужно исполнить - обрабатывать входной параметр как процентный показатель. 

--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
точно, просмотрел, все верно
Да, вы правы, я тоже придумал неплохой и удачный вариант как избежать лишних повторов. Может правда не такой как у вас
I don't think we want to show this so prominently. It's kindof an advanced-ish feature
I think that this is a mistake and putts too much complexity on the user as apposed to the devs; see latter comments for details.
The it won't `respond_to` to the methods actually defined in this instance xD
I don't see any reason to use top-level classes.
Hi Jamu. This branch is not changing the behaviour, which was exactly the same. It's just fixing a couple of bugs.
But it's not that the signals themselves need to be sequential, it's that the work in the subscribe does.
Passing a destructor function to `dispatch_queue_set_specific` should be sufficient. It's legal to release a queue that has asynchronous blocks on it, because the blocks retain the queue until they complete.
No. The real problem is that JDatabasePostgreSQL::insertid is not working for me. I had to manage to remove all calls to insertid when using postgresql.
Yes. A "there is not $key variable defined" error. This happen because there is no "key" variable in function body. If you look at body's function there is some other lines using $row->extension_id just like I did. So, I decided to let the function like in master branch (using $row->extension_id).
Yeah, I thought I saw something about removing this. I'll go ahead and do that.
any particular reason for this change?
I don't mind that too much, but it does lend for nice syntax when calling with more than two Commits:
```csharp
Commit mergeBase = GetMergeBase(first, second, third);
```
versus having to do
```csharp
Commit mergeBase = GetMergeBase(new[] { first, second, third });
```
but since the compiler converts the first line to
```csharp
Commit mergeBase = GetMergeBase(first, second, new[] { third });
```
the only benefit is syntactic so if you still prefer it gone I'll remove it.
self.n_ica_components can be a float that's why I had created the self.n_ica_components_. Now self.n_ica_components is not the same as the one passed in init which is to me really confusing.
use stc_dummy.data.fill(0.) it is faster
@christianmbrdobeck @agramfort @mluessi -- if the Epochs / copy crew
doesen't see any further serious issues I would suggest to refocus on the
bigger picture and finalize this PR.


On Thu, Dec 6, 2012 at 6:23 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> >
> >          if self.preload:
> > -            if isinstance(key, slice):
> > -                epochs._data = self._data[key]
> > -            else:
> > -                key = np.atleast_1d(key)
> > -                epochs._data = self._data[key]
> > +            self._data = data
> > +
> > +        if not isinstance(key, str):
>
> A suggestion to simplify this decision tree:
>
> if isinstance(key, str): convert key to slice/index
>
> procede like for slice/index keys
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337942>.
>
>
+1 I would fake the measurement info with a mock structure.

before merged we'll squash the commits to avoid storing the fif file in the history.
rather than using notEqual with undefined as the expected version use test.ok(result, ...)
Yes, but since the default is truthy it's an irrelevant part of an &&.  You could instead write:
```ruby
if params[:page].present?
  page = params[:page].to_i rescue 1
  page -= ...
```

This would lead to a much less confusing conditional since there's no need to set the page variable in it.
@weaverryan, thanks for reviewing!
Please look at https://github.com/symfony/symfony-docs/pull/1965/files#L1R128 - this is exactly what we do. I'd also prefer not to re-implement part of parent method, but unfortunately the way it is designed now, it either throws exceptions or renders them, not both. So we do `setCatchExceptions(false)`, but then we have to take care of the rendering ourselves. I see how we can extract exception handling into a separate method in core, but even if we do, it will go into 2.2 only.

As for overriding `doRun` - I think that for this particular case it's better to override `run()` method, because we use `setCatchExceptions(false)` in our override and parent `doRun` can also change that. So, if we set our setting and then call `parent::doRun()` we may still have `catchExceptions` set to `true`. Actually, current `doRun` in the FrameworkBundle changes that for shell mode (Shell.php contains `$this->application->setCatchExceptions(true);`). While logging exceptions when working with shell doesn't make much sense, it's still a valid example of how settings can be modified in parent `doRun`, and we want to avoid it for this cookbook.
maybe >=?
Thanks. Fixed by removing leftovers.

Anything else?
sort of but not really - remember that this is sort of a hack to make category attributes available to migrating modules. Only core modules would need to extend this further - Users, etc. Third party modules will do the (now) preferred way of using their own tables for attributes etc. This is merely an extension of existing 'temporary' category access.

So, I could see Zikula_Doctrine2_Entity_UserAttribute needing this or some other core mods as they are upgraded during the 1.3.x release cycle.
А, окей.
pointless, though, there's only one 'plugin' that it could refer to
Again, the user specified the changeset type when he created the changeset.  He shouldn't need to specify it again here.   All this function is doing is navigating to the changeset, and promoting it.  It shouldn't care what type it is at this point.
Good detail!
Should this whole method run on separate thread? It's called twice in code (onTabSelected & refreshList); wasn't sure how much of it and its callers to include in the AsyncTask.
Is it really used ? If not, this have to be removed
Yeah. I'll clean that up tomorrow
Yeah, true. This is one of those things about Python that I'm not a fan of.
They used to be one and the same but later I had to split them because In repl case I test ST during join and in dist case I test ST during leave. I have to rethink this.
I respectfully disagree! I have thought about all of these in details and they are not good for MapReduce! Here is why, a typical size of map reduce tasks is much much bigger than session replication. Guys we are talking BigData here, hundreds of GB of data if not terabytes. Take for example a classis word count problem [1] over 40GB of words. Intermediate result, the result of map phase is 9GB! If you want to store that on a single node as you would with AtomicHashMap it will blow out that node with OOM for sure, you'd have to have cacheloaders configured! If you use a tmp cache per task intermediate data will be spread across the entire cluster, all nodes will carry the intermediate keys, they will be nicely backed up (depending on N), and large size, BigData size problems become piece of cake to handle given enough nodes. The AtomicHashMap approach does not scale period! Using AtomicHAshMap is a wrong direction for map reduce BigData! 



[1] http://www.cloudera.com/blog/2009/12/7-tips-for-improving-mapreduce-performance/
the description is actually correct :-)
Please use Objective-C `YES` here instead of `true`.
nice clean formatting :100:
As a minor matter of style, I think this would nicer if you eliminated k by using
<pre>
        for dup in self._dupes:
</pre>
Change the class to TestBrowserWiFi?
You use two times resourceType with two var ... it's seem working but it difficult to understand, can you rename one of those variable ?
With this change, gettext (extractoin of messages for translation) will not pickup these strings, so it won't be able to translate them.
@arnodeclercq Can we remove the extra `ENTER` after `background:color` ?
In that case. Done.
@sonney2k thanks! CDyamicObjectArray seems to be a better choice, with automatic REF/UNREF. However, the problem is still there. How should this statement be re-written when we use CDynamicObjectArray for m_machines:

	m_parameters->add_vector((CSGObject***)&m_machines.vector,&m_machines.vlen, "m_machines");

this is in the register_parameters function of CMulticlassMachine.
Open bracket must go in a new line
Tiny typo here:  repsonse
yeah, so the middleware is not fired just before the route callback. It is fired just before the ``before`` event
Performance note: If it's a list, values.length will run over all elements and count them, every time you call getSize. Therefore you could use:

   (1) val getSize = values.length
   (2) lazy val getSize = values.length

The first one calculates the getSize value in the constructor and then stores it with the object for later requests.
The second one calculates the getSize value when it is requested the first time and then stores it with the object for later requests.
So the second one should be the best one.
I agree in case of  ```spoiler``` but maybe in the future a boolean param of the Trakt api may be null ? I think I use ```Boolean``` instead of ```boolean``` because of the ```addProperty(String property, Boolean value)``` prototype
I'm quite new to Java concurrency. Would you mind taking a look? My thought was that it doesn't matter if two threads call it at the same time since it looks up an object in a map, and mutes a long to represent the current time. No other changes are made, and if the long is updated twice so be it. (Unless it causes some concurrency error that I don't understand!)
hmm yeah.. we should track where this js object gets 'lost' b/c in theory it shouldn't be lost but it does seem to do that (i noticed it while playing around with channel listing on a separate branch). leave it as is for now until we can troubleshoot it i guess.
I'd prefer people not using instance variables in the service code.  But I'll fix this post-merge.
why did you commented this function ? actually it's the most important one !!
Не должно, simple_var_t работает со всем, для чего есть helper_t<x_t>::{parse, print}
It is used only by this unit test class. It was the fastest way to get results readers tests that hit the server.

Lines that exercise are in the format:
```
+        testReadMultivalue(
+                ResultsReaderXml.class, "splunk_search:blocking/xml/" + search);
```
This is weird, and will go away if you define `cursor = None` or something at the module level and get rid of the global statements. "except NameError" is a red flag IMHO.
If this is now the reason that everything stopped, I can do it. It is not a problem. I just like to tell what all can be done because students often complain that they don't know how to do enough for the project. :-) So such easy fixes around are also a great way to get points. :-) But I understand it is harder mental barrier so I can do it for you.
Ok. I figured out what was wrong. Now we use *EmbeddedListField*
And don't change the name of the variable passing. So if you pass `comment_url` in, it should be also argument in the called function named `comment_url`. Code is much more readable in this way.
No, but that it should be `''`. We are using `''` around constant strings. We use `" ... "` only for strings displayed to the user.
Unneeded semicolon at the end
depends on blizzard changing spell target dest on cast (SMSG_SPELL_GO). So even if it works its non-blizzlike
This should be added for consistency. Let the method **always** return 3-elements tuple. If GET does not have any post_params - what is obvious - it should return empty dict in that place.
It took me a little while to digest what you are saying, but I understand. Factory classes have been removed from revised pull request. (I still like the idea myself, the convienience is hard to look past, so the code has been moved to one of my own modules.)
Just alignment in these comments (yeah, you're gonna hate me :) )
What are the negatives? If the DIC can do it, and it makes code more straight forward, then why not. Lots of apps have at least some portion of the application config stored in a database - menu objects for example - and I would be very nice if these could be injected.
This concept is actually wrong. DIC is not meant to be used as a factory for entities... You're exploiting it too much here.
You probably don't need `mysqld_running` in the session but simply in the stash.
'fields'  is applied to all json levels. Controlling the load of json fields in all levels is the best way to achieve the fastest load and lowest memory usage.
Agree and Ihave added some docstring/comments.
I really think that you do not want to use word "automatically", but rather something like "uniformly".
Removed as this extension wasn't used anymore.
Micro-deoptimization: ngx_pnalloc() returns unaligned pointers which may slow down the memcpy below. It's probably imperceptible though. :-)
Do these formats exist p.m. and P.M.?
StarSystem::starLuminosities is a double[]
Also, you should use something other than ``s`` in the comprehension. I'm pretty sure I saw something a couple months ago about how those scopes can bleed into the parent scope, e.g., try something like:

```python
s = u''.join(u'    | {0}\n'.format(subj) for subj in book.subj)
```
I don't remember why I didn't use that command. Also `:A` might be too new. I think it was added recently.
cdf_y     cdf_endog instead of G_y

should this be a separate method, or available ? do we want to store them in the same class, or a user should create his own marginal and joint distributions.    (application mutual information, example in sandbox with scipy's gaussian_kde)
On Tue, Aug 14, 2012 at 3:01 PM, j-grana6 <notifications@github.com> wrote:

> In statsmodels/emplike/elregress.py:
>
> > +            beta_high = upper_bound
> > +        else:
> > +            beta_high = self.results.conf_int(.01)[self.param_nums][1]
> > +        if lower_bound is not None:
> > +            beta_low = lower_bound
> > +        else:
> > +            beta_low = self.results.conf_int(.01)[self.param_nums][0]
> > +        ll = optimize.brenth(self._ci_limits_beta, beta_low,
> > +                             self.results.params[self.param_nums])
> > +        ul = optimize.brenth(self._ci_limits_beta,
> > +                             self.results.params[self.param_nums], beta_high)
> > +        #  ^ Seems to be faster than brentq in most cases
> > +        return (ll, ul)
> > +
> > +
> > +class _ElOriginRegresssSetup(_ElRegOpts):
>
>  How is it different than OLS without a constant?
> Because when estimating en EL linear regression model without a constant,
> you still have an exogenous matrix with a column of 1s. However the maximum
> EL estimate restricts the coefficient on the constant to be 0. 3
> implications are (1) different parameters, (2) narrower confidence
> intervals, (3) the residuals still sum to 0.
>

I'll have to take a closer look at the code I guess. I just thought having
a zero restriction on the intercept is tantamount to not having an
intercept included since it doesn't affect the fitted values at all.

>
so now we can remove this class, right?
This does not work for me. It looks like `urlObject.search` override `urlObject.query`. One solution is to delete the `urlObject.search`. Or we can se if there is an `?` in the `urlString` and drop `url.parse` completely.

Somthing like this:
```js

var signature = signer.sign(privateKey, 'base64');
signature = signature.replace(/\+/g, '-').replace(/\//g, '~').replace(/=/g, '_');

var query = {
  Expires: expires,
  Signature: signature,
  'Key-Pair-Id': keyPairId
};

urlString += (~urlString.indexOf('?') ? '&' : '?') + querystring.stringify(query);

return urlString;
```


Is this a possible node.js bug or something that should have been documented in node.js documentation?
This is easily circumvented by using a set_timeout call in on_selection_modified which is what I've done in 498455. Of course that's cheating by moving the work outside of the on_selection_modified call to somewhere else in the main thread. However I've also done a few checks to see if any work actually needs to be done before doing it.

In any case I don't think the work done by the plugin is that bad. If you think it's really sluggish and creates a bad experience you could also set a boolean to true in on_selection_modified which is then set to false once checkSettings has been called. This way you know whether or not you need to call set_timeout in on_selection_modified or not.
I think the other lisp files support an "output to elisp" export option. Is that correct? @jwiegley 

I used el-get to install the recipe and opened a ledger .dat file and the major mode started without warnings or errors. I double checked that the ledger package does not install any extra list files.
This @see is now incorrect. (check others as well)
Minor style point - handler.handleMessage is more important than the if statement.  I'd prefer to see
````java
boolean handledSuccessfully = handler.handleMessage(...);
if (handledSuccessfully) { ... } ...
````
This feels like a trace-level statement.  Does this get called a lot?  If so, protect with if (LOG.isTraceEnabled())
A couple things here.  First, I think this will fail, since it doesn't set up the self.objects variable, so later if one tries to use it, then len(self.objects) will not work.  However, the model of starting with zero objects and successively adding them was actually removed from the code when we made SBProfiles immutable.  Apparently I left some vestiges of the old model in base.py, which you are trying to implement here.  But really, we should disallow 0 argument constructions.  And also probably the 1 argument construction that isn't a list as well, although I think the way you've implemented it here should actually work.  (The old way probably didn't.)  

And add also needs to be changed or removed.  The existing code below will fail (since there is no such add method for SBAdd anymore), but you could actually make it work by appending to the objects variable and invalidating any existing SBProfile object.  My guess it that this will be necessary for getting the config stuff to work correctly, but I'm not sure how that's going to go.

Likewise for Convolve.
Well then thank you for setting me right!  The new comment is very helpful, thanks.
\`\`\`
var dp=require("dependparser");
dp(process.cwd())
\`\`\`

把markdown格式应用起来。
Do we need $('#playerdiv').show()  in both places?
k performance hit point convinces me.
for now i vote let's leave this lightweight mechanism in place, with these script options, merge it in, then in a new branch switch over to the new set of options and use jopt-simple or apache-commons/cli (joptsimple btw is in the deps from whirr)
-1 if it's gstring we need to deserialize as gstring
il mio rake ha rimosso questi __:limit => nil__ più volte, non so perché onestamente... può dipendere da una versione diversa?
This should be indented to the same level as the beginning of the string on the line above.
Missing a self.instances for ralsh to work?
and this is a bad practice in scala. 

in case someone will create add a closure that will use reference to your parameter, scala compiler will nicely rename you parameter name to sorting$x.  (this is one of the cases I know when it comes to scala 2.9.x)
what is this easy_thumbnails module? if it's an external dependency, you should add it somewhere (in setup.py or somethin)
Hmmh.. So 'X' is now a PHP reserved replicaset name?
It's immutable otherwise, as it returns a tuple subclass.
Done. @shajith.
Im not sure other additions except QCheckBox widget is necessary?
I think should be bound to 1.3.2-rsmart
Shut up Farbod
check if datatype is the same. Not needed in this example.
This is redundant with what was taken out of checkNextMatch(). Instead use the pass() inside of the function, then you don't have to write it out so many times in code.
I get kind of scared modifying stuff passed in unless that's what the method is explicitly for.  I think I'd feel more safe with ```params = params.merge(default_params)```
Это некорректно. Пустые строки тоже должны участвовать в сортировке.
e.getMessage() будет отображаться в cause. Здесь надо написать, что могло случиться
r+ with:

```js
let ordinal = (typeof toolDefinition.ordinal == "number") ? toolDefinition.ordinal:99;
```
s/a/ann

s/filed/field
Isn't this redundant? Like, since it's only calling _super() it can just be removed? Or is it here for a particular reason?
Need Info: I think it would better to add an observer on the content property instead of using didInsertElement. Let's chat IRL.
We're running with timezone support turned on so you should use the `now()` method from django.utils.timezone to get the current time.
Yes, we need to ensure this.
I saw your comment in the commit message, but I don't think it's how things really are. The content type is checked against the **partition** of the document, and a template document has more than one partition type. Besides Scala, it can contain XML, which has its own partition type. So the condition can fail, and the other text hover is used for non-Scala partitions.
Indeed, can you rerun the benchmarks to check if this is not just the natural variance of executing stuff on your hardware + OS?
Adding some overloads for `Identifier *`, `Expression *`, ..., and wraping NULL check for given object is better.
This class doesn't seem to do anything and isn't used. It seems more of a placeholder. Maybe a TODO is appropriate?
Why that name?
FYI, the identifier is of type mixed (to be fixed in the open PR, use `{@inheritDoc}` here)
Also, add file and class comments (and you as `@author`).
pfui, pfui, pfui :-)
Pulling it in just for you. Still wrong though ;-)
lines and formulas (esp 2617) are too long.  Would be good to split up so it is clearer what the caluclation is.
Should you also call wu->resetWorkflow() ?
Well spotted, should be getLink
github viewer doesn't seem to show it but there seem to be tabs here btw
node has methods for all these, `path.extname()`, `path.basename()` etc
You don't need to fully qualify these; they will be resolved based on the current namespace and/or imports.
Just to explain - ASCII is not a supported encoding in htmlspecialchars() so it triggers one of the new exceptions - switched to something valid.
A predicate for what? I assume based on the getValidator this determines that it passes validation?
9行目に限れば不要です。
Great find! Good idea to document them like this. Would you please add a wiki page under the automation that keeps track of these sorts of limitations with the version we're using so that we have the ones that are affecting us collated in one place.
Tämäpä onkin sama kuin `(and (contains-point? outer x) (contains-point? outer y))`.
The surrounding `if` is not necessary, `(== (count a-seq) (count (set a-seq))))` already has the right boolean value.
i see your point but "continue on error" looks wrong. you should at least throw the exception after foreach. do not return errors.

maybe you want to use multi_exec for multiple hosts/ips...
You have pymongo.collection.Collection.count here twice.
ok, that was indeed true, I missed the result = result && found, but here's another case:

filter: "Robin R"
display label: "Robin Apple"

filter will match on the first part of the display label both times, instead of continuing through - so my point stands, you need to search forwards, not start at the beginning each time
maybe res can be nil at this point still
Are you sure? Because we made up the name "resize_in_place" we should be safe. 

Maybe we just need an explicit comment, or we could check to see if the driver has a "resize_in_place" attribute and raise an "UnsupportedDriver" exception if it doesn't.
This `if` will only fail if you zoom in too far, right?  It seems like you should instead zoom in as far as possible, instead of just ignoring the zoom.  But there's not really a limit, is there?  Also, it looks like 3D mode will let you zoom in past what you're looking at by calling `zoomIn` - or at least I don't see what would prevent that.  I guess I'm just wondering how much you've thought through these issues, and if you came to any particular conclusions.
WMS-C is sort of similar to WMS, but there are enough differences that it would probably not save you much time. I don't know how much WMS-C is used anymore. WMTS is the standard, so we would probably implement that. Again, its not similar enough to really save time, but its pretty simple to use so you could implement is pretty quick.
It doesn't look like this variable is ever initialized.
What was the type of the data argument if not HashMap?  Shouldn't we still have this check here in case the data argument passed in is not a map?