labofsahil/github-event-dataset-2012 huggingface dataset:
Hmm ... but on the second though, I think I'll make the `copy.avatar` to have a `@file` assigned to it first, and assert that `copy.avatar.file?` Then, I'd assign original.avatar to it, and `assert !copy.avatar.file?`
That 2nd test uses :force false.  So it should stay.  You can remove the {:force false} as it was not necessary (it defaulted to false).
The problem is if target is "0" then the memory_string_to_pages will return "1". I could have changed that function to handle the special case of 0->0. But since this is more a vms-specific treatment of "0" instead of a general page conversion I though it was best to have it in the main code line.

@amscanne I don't understand this comment? If target == "0" then we are done and can continue processing. Otherwise we need to perform a conversion on target.
i like this much better than before.
So this is a little wrong. So this is something that we just get from the config. Don't think this if block is needed here.
Doesn't this need `@Test` ?
Why this `parseInt(4)` and not 4 directly?
I've changed the metlog-py client to only ever send UTC timestamps, w/ the "Z" at the end per RFC3339, so I think we can do away w/ heka/time altogether for now.
Apologies I did not comment @johnshih. Are you going to be testing in Chinese soon? At the moment I would just say we won't worry about localization. We have not anywhere else. We can cross the hurdle when we get to it as there's sure to be more than just Chinese to code for.

If you really want to just make the wait wait for  `!= ""` :)
It's better to start a new line for the last parameter and put the .'...' on the same line.
This file still needs to extend the GLPI class of Porter's.
`getSafeProperty`?
Compile failure: there is no `LOGGER` defined in this class.
What happens if there is no QuestionSet with the given questionSetId?
what is .clang_complete?
Nit: should remove extra space before `6px`.
Sorry bout that, sped through writing the update and pull request while on a flight. Updated the readme in the repo. The reason I don't want to use the end(done()) syntax is because in my test cases, I will use expect(200, done) if I'm just validating the response code and end(function(err, res){}) when I want to check something in the response body or header AND validate the response code.

Thx,
~M


On Oct 6, 2012, at 12:39 PM, TJ Holowaychuk <notifications@github.com> wrote:

> In Readme.md:
> 
> > @@ -50,6 +50,26 @@ describe('GET /users', function(){
> >  })
> >  ```
> >  
> > +  If you are using the `.end()` syntax with mocha, `.expect()` assertions that fail will
> > +  not throw - they will return the assertion as an error to the `.end()` callback. In
> > +  order to fail the test case, you will need to rethrow or pass `err` to `done()`, as follows:
> > +
> > +```js
> > +describe('GET /users', function(){
> > +  it('respond with json', function(done){
> > +    request(app)
> > +      .get('/user')
> > +      .set('Accept', 'application/json')
> > +      .expect(200)
> > +      .end(function(err, res){
> > +        if (err)
> > +          done(err) // if response is 500 or 404, test case will fail
> this will call done() twice, it needs to be if (err) return done(err), though in this case it could just be.end(done)`
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Are there any CS for this project. If no we should set some (Those don't get my preference).
the checkbox only looks kind of odd.
Ok it seems, the genericity is not needed here
so this simplify the design, and that's good
Are you sure you want to override the parameter ``$buttonContent``? This often makes code less readable. Please also check line 131.
Yes I think it could be a bug but unless discussed I don't want to open a Jira ticket.
e.index most likely returns string.
And when using this value in switch statement - it is not working because switch uses === comparison (also type should match)
I don't have information on e - fired event properties. If it should be integer type or string. If there is a strict requirement for it to be integer than I will raise a bug if not than this workaround helps.
Your story doesn't have anything about elves. Aliens could have built this city. Indiana Jones could be having this dream in his nuclear blast induced coma.
Add only if title are different
Ich finde die Variablen hier etwas unnötig, checkstyle hin oder her...
I would keep these suffixes and prefixes in const epicSuffixes, const epicPrefixes global to the file
Would be more efficient to declare this within the outer else clause below (without setting to anything), and explicitly setting it to one or the other values in the inner if/else
Shouldn't it be `if (written === false) {` ?
Bad bad...you should've written some tests to the code above...
Can you remove the white space on this line?
I disagree. I think it's more readable to abstract away the request logic, especially since the function name of "assert_valid_url" is clear in what this is asserting. It's not hiding what it's doing.

If we keep the logic within the function, then the reader has to look over the request code and check specifically what we are asserting about the response. This is harder to process. With the function, they just see "Oh, they're asserting the URL is valid." It's actually more explicit about *why* we're testing than the other code.
So for now create an object manually. So don't send URI, but send data you need to display new post immediately. And add TODO to improve this part.
So is this way ok:

>  for node in station_nodes:
> info_data = urllib2.urlopen(BICIKELJ_INFO_URL % int(node.attributes['number'].value))
> data.append ({ fields... })
Hahaha, yeah I knew that :)
This way of translation does not work, I believe.
This is not really correct. Check the function above. When `n%100==1 -> 0` So `0` is for singular.
Use `prop` instead of `attr`. They say it is better.
Indentation! (Indent to the left, four spaces from the beginning of the line.)
Do we want to assert that a value for the group is actually set?
confirming again

replace
  _sr_path = False, target='_blank' if c.user.pref_newwindow else '_parent'
with
  _sr_path = False, target='_blank' if c.user.pref_newwindow else target
I'll try to look into it tomorrow or Friday
I think functions with "dance" in the name violate some obscure section of PEP 8.
Well, the tests fail if I change it, so I guess not.
at first tome i do it like u said. but on exit  not work. but i do without brackets like 
```
void EnableTransportEnter() { raw() = (raw() & ~TransportExit | SmoothGroundPath) | TransportEnter; }
```
i just do one test again and add comite if it will be work.
i am not good in levleling operators.
You can port the change from the 4.3.4 branch that includes level in CharacterNameData and use it here, would also spare you a sql query and make things faster.
I would just remove the lines in the README entirely, then....
interesting... i just updated my pg gem and it still passes for me so it
must have something to do with the postgresql version.  Anyway if you can
remove that logger i'll pull it in.

Thanks!

On Tue, Sep 25, 2012 at 12:40 PM, Bhavin <notifications@github.com> wrote:

> In lib/apartment/adapters/postgresql_adapter.rb:
>
> > @@ -88,7 +88,11 @@ def reset
> >        def connect_to_new(database = nil)
> >          return reset if database.nil?
> >
> > +        unless ActiveRecord::Base.connection.schema_exists? database
> > +          raise SchemaNotFound, "The schema #{database.inspect} cannot be found."
> > +        end
>
> I am using 0.14.1
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bradrobertson/apartment/pull/53/files#r1686271>.
>
>
is there a Symfony standard that everyone loves Yoda conditions?
Why can't it be collector.querycount > 0?
Align your name
also adding an openvz check here.
So many empty lines!
Probably because I added or deleted some lines above, otherwise I didn't change anything in this piece of code.
As above, `push` seems more efficient here.
All indentation should use tabs, not spaces, in this project.
This will need to be fixed throughout your changes.
Is there any reason not to have that discussion about FT vs. eigendecomposition methods in the actual docstring, so people know how this process is being done?
we tend to favor accessing attributes as if they were a hash to avoid confusion with people new to Chef

```
node[:nexus][:plugins].each do |plugin|
  nexus_plugin plugin
end
```
I think for now this is OK, but in the next version of the gem I will favour a default selector (e.g. xpath) unless otherwise passed in as first argument for the extract method.  e.g.

```
extract(:xpath, name, pattern, params)
```

It would be nice to be able to specify a default selector much like capybara does e.g.

```
.default_selector = :xpath
```
Since non mutable, why not just cache the data and return it if found?
I guess currently the search is specifically only for Activities and Investigation you don't need to fix it now. But in the future please keep this in mind. I hope to have the code working for projects that only have ExternalActivity objects in the near future.
Do you actually use exponential notation in your code?
Ouhwait. Got confused which comment this was to.. We did issue a warning here :P anyway. I still think we should fix it :)
oh man, have I done that? thanks for catching this :)
ah, sorry, read the PR description. this is the title editor...
How do you configure CA delegation?
I think these were merged by mistake... We already have the proper node_modules declared...
Those keys are to long. So the problem is that this makes HTTP data transferred longer. So we want keys to be as short as possible.

But OK, maybe we do not have to complicate here too much. This can be also solved by GZip content transport.
I personally believe that the avoidance of abbreviations is a significant factor in making code _less_ readable.  This is especially true in light of the asinine PEP8 rule on line length.  However, I'm tired of the argument and don't honestly think that it is worth bike shedding over.  I acquiesce to  assimilation.
zou 't niet beter zijn da ge INIT_PATH_LIBRARY hier dan zelf defined, als die config-file nie bestaat, ipv $libraryPath te gebruiken dan? Anders gaan we ooit mss problemen krijgen met code die INIT_PATH_LIBRARY gaat gebruiken, terwijl die niet altijd zal bestaan
如果是当前用户的话，应该显示“我”
If I understand your code right, you want a "break" here, not i=5. Also renaming hptoreg to something more readable, e.g. "health_to_regenerate" would be great.
somehow this makes the tests fail (when run with `mvn test`).
Eh - it's debugging code.  Delete happily.
sounds good to me. I am updating the branch for that now.
Idem, HAML.
ÔÁÍ ÖÅ ÎÁÐÉÓÁÎÏ ÄÌÑ byte[] ÒÁÂÏÔÁ Ó toString()

2012/11/14 Dmitriy Komanov <notifications@github.com>

> In
> src/ru/fizteh/fivt/students/fedyuninV/format/StringFormatterByteArrayExtension.java:
>
> > +import ru.fizteh.fivt.format.FormatterException;
> > +import ru.fizteh.fivt.format.StringFormatterExtension;
> > +
> > +
> > +/**
> > + * Fedyunin Valeriy
> > + * MIPT FIVT 195
> > + */
> > +public class StringFormatterByteArrayExtension extends StringFormatterExtension{
> > +    protected StringFormatterByteArrayExtension() {
> > +        super(byte[].class);
> > +    }
> > +
> > +    public void format(StringBuilder buffer, Object o, String pattern) {
> > +        try {
> > +            buffer.append(String.format("%" + pattern, o.toString()));
>
> ëÁÖÅÔÓÑ, ÞÔÏ ÜÔÏ ÎÅ ÐÏ ÚÁÄÁÎÉÀ ÒÅÁÌÉÚÏ×ÁÎÏ.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/dkomanov/fizteh-java-task/pull/153/files#r2125648>.
>
>



-- 
ó õ×ÁÖÅÎÉÅÍ
æÅÄÀÎÉÎ ÷ÁÌÅÒÉÊ
íæôé æé÷ô ÇÒ. 195
Any reason to use jQuery to fetch the container before calling initVideoPlayer?
project_type を返すメソッドが Project にあるとよさそうです！
そのように追加しました。
i was confused about what valid_vote? did for a bit; maybe rename it to allowable_vote? or something?

also, i think the logic disallowing a user to vote on their own links or multiple times on the same link should be moved to the model. then, wrap it in a thin helper method that also checks that the user is signed in.
I'd suggest a datamigration with South for this.
I now use ``proba`` (singular) and ``score`` instead of ``f``
looks buggy
The names are a bit terse. Can you find a better name than 'v0', 'w'.
Is this a copy/paste error?
IS it really necessary to have all these separate ratio's? IMHO a single ratio would be easier to use.
method has been removed because it is obsolete
Updated to QTime
This could be renamed to something more meaningful. What does source mean? Also, not a huge fan of introducing combined getter/setters in this style of code.
Filed as #11.
Not sure either, but this changes the semantics surely?
+ If you only remove entry, it's orphaning the physical parts.

Or am I confused?
It's probably much safer to write them as utf-8 characters in verbatim instead. 
E.g. 
```
form = forms.QueryForm({'query': u'some %^*@#)($# with \xe9&\xf9 chars'})
```

Then we can avoid having non-ascii characters in any of the source code. And we don't need the `# coding...` piece in the head.
et le subjonctif... ok je m'incline
Why not call it "ERROR_NO_ROUTE_MATCH"? Just a suggestion.
Can you set a comment here to remind us to replace these with juiceUI comments when we get time?
In this scenario, all the TD elements which are children to this TR (this is the first row) are having classes with specified height of 31px.
One thing we could do is inject different locking behaviors for 2.2 + 2.4, and warn if someone is running 2.2. We'd just need two implementations of `acquire_lock` and `check_if_locked`.
this will fail on any non-windows machine. and it will fail on all machines that don't have this file stored in this location including your ci server. 

Correct this by doing the following:
1. add this to your resources for your test 
2. use a relative path
Don't leave commented out code in the source.
Two questions here:
- Should we be writing functional tests? It seems integration tests could cover this functionality.
- In the `CourseMembership` test we are using `minitest/spec` but here we aren't. In the interest of having the same testing syntax across the suite I asked @jordanbyron which he would prefer, and he decided `minitest/spec`. What do you think?
You're not using greenlets in this module.
I don't even remember writing that TODO. Hah. I'll remove it.
May be rename the class to DataPoint or MetricData to be more explicit?
Hi Ido, this looks good in general, I'd like to only ask one more thing.
Could you please add which kind of audience would be interested in this talk? Is it web centric, systems centric, mobile, telephony, something else?
It just helps the readers focus and decide whether it's relevant to them
It is not. I need the full packet here. I generated the packets for all SID length and I just replace the SID in the packet.
I meant, in line 941, replace the `-3` by `-1` and remove line 946. Or add some line similar to 942 to initlaize var_byte before line 946.

Your code, when file ends with 11 22 33 44, will write 11 22 33 33 to the file. As most EXEs end with a bunch of null bytes, it might not matter in practice though.
Again, exploits must pop shells.
nitpick - should be indented
"subtracted by" -> "minus"
You should avoid declaring functions inside of functions unless there's a really good reason to do so.  It also looks like you have no need for a self pointer here because everything is happening inside your prototype method (unless I'm missing something here).  So you have two options:

1) Move createNewAtlas and addImageToNode to the top of the file so they can just be local functions and have them take a textureAtlas instance as their first parameter.

2) Rename createNewAtlas to _createNewAtlas and put it on the prototype, same for addImageToNode.  The underscore is common practice for "private" methods.

Either of these options is a matter of preferences, #1 is probably better because of local function scoping so let's do that.
Also to answer your question about the event parameter, onerror only gets what they call "a simple event" which is the most general interface, and has [no useful information whatsoever](http://www.w3.org/TR/DOM-Level-3-Events/#interface-Event).
typo, should be squared.  also in the return tag below.  Should it be "squared radii" or "radii squared"?
同上，已经被归并到其他类的Settings应该去掉。
Actually, it has everything to do with scoping, but it appears you don't understand JavaScripts scoping rules, especially variable lifting. To understand this better, run the following code:

```JavaScript
var foo = 10;
function test() {
    foo = 20;
    if (false) {
        var foo;
    }
    console.log(foo);
}
test();
console.log(foo);
```

There is no performance difference between declaring variables later versus earlier.
Same for i.
This should be:

    logger.error(__('Unknown SDK %s', value) + '\n');
the name 'create' suggests more control (eg create=True to always create the dir). better name would be 'temporarilyassumedontcreateinstalldir' ;)
view code in controller
Exception thrown when no result was found (for example findById with null return value)
`map` would fit better
Файловый «таб» также управляет кнопкой на виджете, поэтому это не совсем таб. Ну и у файлового таба и таба ссылки мало общего между собой и с табами социалок, создающими ифрейм (например, разные интерфейсы в окошке).

Я думал переделать адаптеры так же, как переделал аплодеры (убрать регистрацию и сложить где-то в объект), но пока решил повременить. В таком варианте они также будут менее pluggable, что ли?
копирование.
will be in placed -> will be placed
Dafuk



On Thu, Feb 16, 2012 at 11:31 AM, Bartzy <
reply@reply.github.com
> wrote:

> > @@ -1 +1,2 @@
> > -NICE
> > +NICA
> > +This is a nice feature
>
> Wrong! This is a horrible feature.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Bartzy/Test-Project/pull/2/files#r456500
>
At this point, I believe that it's generally considered better practice to just return rather than set a variable in order to have a single return point, so in general, I think that that's a far better solution, but given that this function's main purpose is speed, it would be best if you went with whichever style is the fastest. I wouldn't think that having a single return statement would be faster (if anything, I'd think that it would be slower because you have to set a variable rather than simply returning), but maybe it is faster.

As for `index += n;` being duplicated, I wouldn't consider that to be all that big a deal much as it might not be desirable (certainly not worth contorting things to have only one return statement like you currently have), but worst case, you end up putting it in each case statement once as opposed to putting it at every return statement, so there's duplication, but there's not a ton of it. If you didn't care about speed, you could even do fun stuff like use `scope(success)` so that you only have `index += n` in one place but still have multiple return statements, but that would probably harm efficiency given the fact that it involves adding at least one try-catch block to the code and doing who-knows-what to adjust the code to make that work.
(The point being that we need a »templates which return templates are PascalCased« rule anyway for things like `PApply`, `Compose`, etc. Why not just apply it here as well and call it a day?)
delegate and function may have some attributes. Furthermore, delegate may have qualifier as the function type.
For example:
```D
shared(immutable(Inner) delegate(double, string) const shared nothrow) dg;
```
Since when are we phasing it out? We've added an improved lambda syntax which in many cases is a better alternative to the string syntax, and in many cases, that's what's going to be used now, but when did we agree that we were effectively getting rid of the string syntax? I thought that we had agreed that it would stick around. I think that cases like this are a great example of where the string syntax is actually better than the new lambda syntax. And while checking the predicate like this is relatively rare, it's not the only place in Phobos which does it.
I miss API docs  from the following array of methods
LOL :) I've just done the hopefully final rebase. Good question though whether one can "unsubscribe" from an pull request.
I find the new names a bit irritating. "provider" and "source" seems more or less synonym to me. Maybe something like "XmlMetaDataSource"?
log lvl rather to trace here?
Interface::Array  may be too fine grain. If we have a sub namespace for array, how about other data types like function, scalar, structure, class, pointer, enumerate, complex, ..... and so on  and so forth. 
It may be too much.     The current organization in Doxygen section is organize them all under type handling without explicit sub namespace.
Try http://doc.silverstripe.org/framework/en/tutorials
should we replace headers here?
could you add the typehint for the array too ?
i think "There are at least 4 listeners." can be removed. maybe you can also link to the listener docs on symfony.com?
This seems incomplete. Am I missing something?
`$()`
So, in my testing, this doesn't quite do the right thing. The dialog shows up correctly the first time I click [remove]. When I click the Remove class button, the dialog closes, but nothing happens. However, the next time I click [remove], the link works as normal and removes the class.
Is there a reason why these are uppercase? I believe iptables uses lowercase values for these.
I like add_names.  going with that.
oops, I wasn't checking that there were no steps.  fixed.
It's an immutable struct, why not?
If a case has no name, I'm going to mark it skipped and move on.  And if a case has NO steps, I just add a warning as that's OK in the UI, even though you then can't mark it failed since no steps.  However, if a case has a step that is missing the instruction, I now use transaction savepoints and roll just the case back and mark it skipped with an explanation why.  then it continues to import the rest of the cases.
Put this user section above the actual creation of the `CaseVersion`, and then pass in the resulting user as the `user` kwarg to the `CaseVersion.objects.create(...)` call (`user` is kind of a magic kwarg you can pass to almost any model method and it'll "do the right thing", in this case since you are creating the object, that user will be assigned to `created_by` -- this is part of my code, not a normal django thing). Doing it in that order lets you avoid the additional save query.
Fixed and went through the inserterbar, inserter and contentauthoring widgets as well to straighten this out.
Need to change this to getTargetByType
delete it outright, don't leave it commented
Added second commit.
I'm confused. That link says 19?
I reckon some of this stuff may be `@trusted`, care to make a pass?
Since the other class already has 220 lines, would it be better to refactor class *SearchTerm* into its own file? Also should this class and the *SearchTermStrategy* interface go into the *support* package?
remove 'failed'
It was protected because it was extending from different class. This method is not even needed since we are now extending from AbstractMessageTransformer, i just kept it as a convenience.
It seems this line is incomplete.
Ок. заменил
Remove this extra newline to be consistent with the rest of your changes (and for the relevant `else` block)
Remove the extra spaces here
This is a direct quote from the software. Though likely not critically important either way.
@apex13 Is there a way we can use the current way of validation `WL.show_errors`
What is message? Trace?
Is that an upstream convention I'm (╯°□°）╯︵ ┻━┻ about? :)

Fody.\* feels more consistent with other naming conventions in .NET (Product-Name or Namespace-Class for example)
polling is additive when the scope is shared.
These are going to be made obsolete very soon when the tenant_id change gets merged in :C
this comment should be placed before the ``if`` check instead
it should be ``<2.5.-dev`` if you want to allow the 2.4.* releases. ``<=2.4-dev`` would only allow the ``2.4-dev`` tag, but not all higher version (which is the case for the master branch right now as it is aliased as ``2.4.x-dev`` which is the latest dev version for the 2.4 serie and is normalized as ``2.4.999999.999999-dev`` by composer
Please just remove unneeded lines of code, git will be there if we need to the old lines back.
Protected , added setter , getter , disabled health regen in bomb fully .
List->Lists
Maybe, better phrase it as "Our error handler defines two public functions"?
Not a fan of this implementation, since calling `next?` multiple times without consuming `next_time` will lose values. Can you use `Enumerator#peek` here instead?
Utilise des string et pas des symboles dans les traductions.
Yes, agreed.  Next branch at least has the URL updating in a function.
Forgot to ask to remove this from all files, and also configure idea not to create this
TalktoNotifier
I didn't know about Generators, that's much nicer then callbacks.
Are we not going to expose the pipeline so folks can add their own processing?  What if they want to add retry logic, etc.?
This seems a little odd. Can we not mock the manifest without changing the way we require it in (via loadModule)?
Ideally we shouldn't have to change our source code to be able to test it. This isn't always easy though.
By this comment I mean it recommends using this code to check

    Object.prototype.toString.call(arg) == '[object Array]'
Yes, those have been fixed.