labofsahil/github-event-dataset-2012 huggingface dataset:
https://gist.github.com/1678352 предположительно, робот чинильщик в инсте.
invalid classname. probably a result of a global search/replace
he makes a point.
I see 2 different things here: you are talking about entity in one place, and about mongodb in the other one. the ``entity`` key is for the ORM, and will work the way you wrote it as soon as you register DoctrineBundle. for mongodb, the same is available when using Symfony master, but using ``mongodb`` as key
The php script flips between read and write for these. Is that still worth doing?
have you tested this on webOS?  I don't want to pull anything that affects the scrolling experience there.
Fair enough...shall make the adjustments in my formatting.xml...fix Vanilla's codebase up and then publish it on the forums under a tutorial :).
I am so going to miss Kiln if we switch over.
This is not true :) both are independent DNS entries
code looks ok, dunno if suppose it work this way, but i guess you checked that it's working
кстати, да, я же ее и раскопал, только насколько это принципиально, ведь одну маленькую строчечку c `<% %>` можно?

я не вижу пока особого сильного profit-а, с другой стороны стараюсь не использовать`<% %>` как завещают django-разработчики
We will use mongodb for the distributed configuration, so I tought this one was a good idea :p
Midway commit - there's a bunch of things here that we need to clean up. Including Async/Push responses and response fragmenting, and the global template context (for instance, it has two ways to access ext libs).
Something is wrong there. The SNES has it sound more like a bounce noise, and in 1-1 when I hear it with Snes9x it sounds like the SNES. That grunt-like noise DOES sound more like a rhino, but it's not what I'm hearing at all on the real thing.
Yes, I believe so, that's certainly how I installed the syntax highlighter
you should be reversing this [URL](https://github.com/mozilla/zamboni/blob/master/apps/reviews/urls.py#L12) as `reverse('addons.reviews.delete', args=[addon])` where `addon` is a slug (what a bad variable name)
Ah thanks, that seemed to have solved the problem! Also, does the 2nd patch need to be updated? It had to be applied with ```qpush -v```, rather than just a regular ```qpush```:

```
applying 02-sage-show.patch
patching file sage/plot/plot3d/base.pyx
Hunk #3 FAILED at 1137
1 out of 3 hunks FAILED -- saving rejects to file sage/plot/plot3d/base.pyx.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 02-sage-show.patch
``
I'll fix the docs
note... the 2 strings are now merged
Same answer :D
@gavinking ?
should have noted for 64bit architecture
Ты так и не ответил зачем ты удалил линку эту?
Optimizing failure.
are we able to undo this commit? so i can actually do some dev, thx
Why is not $type = 'string'? saves one line and some opcodes.
my brain seems to be a sieve these days. you are right.

the issue at doctrine jira for migrations btw is http://www.doctrine-project.org/jira/browse/PHPCR-36 - i added document class name changes to the list of things that should be handled by migrations.
For the curious: http://newevolutiondesigns.com/50-fresh-hd-wallpapers
Wooops, I meant pull #58 :P
whoops...good catch.  This is the downside to having the old code so close.  I'll fix this.
This memcpy() copies 2 bytes from &ui16 to &rbuf[parsed].

But ui16 is not initialized and contains gargage. Why copy this value? Maybe you want to do the reverse and get the ui16 value from rbuf[parsed]?

I am afraid this construct will not work the same on little and big endian CPU. Same comment for the other memcpy() of this function.
Shall dynThrottleLImit be initialized only for read-only storage engine?
Why did you remove the Item init?
Festergut a similar problem, but his aggro also get proffesor in combat 2 from a high distance even before entering his chamber
i need this break, because without the gameobject is not in gameobjectstore
This was requested by some users who wished to have transmission-create & Co available from the command line.
com.htssoft.rts.presentation.fx.support.HemisphereSurfaceShape. It's imported here.
Could this be what broke reloads....
I'll find out later
I think we need to find better way to do this for both kernel and phpunit substitution.
In general you should use Javadoc comments for public methods.
Should PDoc for `Hash#toQueryString()` be updated?
コメントたくさんありがとうございます。
このファイルは後でcookbook/tools/autoloader.rstが場所を移動しただけだったということがわかり、
既に@ganchikuさんの翻訳されたものがあったため全面上書きしてあります。
せっかく直していただいても最終的にどこにも採用しない文章なので申し訳ないです。。。
いただいたコメントは今後翻訳をするときの参考にさせていただきます。ありがとうございます。
gracias, lei tu comentario del otro día y por eso he comentado estás líneas para verificar que el bug se produce por esa spell. Tienes alguna idea de cómo fixearlo?
`margin: 0;`
Okay,  dev is now merged to stable. Please do not commit anymore to /dev. Thank you.
What's the use-case for resolver not to be passed a callback?
why did you put a `-` in front of the name?
Try and avoid having to merge master with a commit. If you stash before you pull it should prevent this. I might be wrong. 

Everything else looks good.
Please leave the template variable name.
@kmike, I've documented and suggested before that all arguments other than `url` and the like are to be treated as positional. 

I'll add it to the HISTORY next time :)
Changes are described here: http://readthedocs.org/docs/deform/en/latest/changes.html#id1
Thanx Michael, that is certainly cleaner than futzing with macro expansion... and it'll help us at World Singles since we run multi deps there too.
need further improvement
You should remove the quote before ${
а вот из-за того, что виртуального деструктора в List нет, ничего у вас на самом деле не удалится вообще. так что надо еще и с утечками памяти разобраться
I wanted to fix this problem:
https://github.com/weyert/DC_Multilingual/commit/50636dd626e11ce76c5d6dbf1b1dc1a05478a872
maybe there is a more specific SPL exception to extend from that better expresses the semantics?
No, as they're statics they're only tied to the class they're declared in.
You don't need `begin`...`end` here. Sorry, didnt notice this earlier.
This is messy, it should be DRY`ied - make a method somewhere or work some way with IoC to check if resource exists.
Agreed with @joschiwald, it looks better so keep it that way. =)
Also you may think of changing

 if (opacity == null || opacity == 1) opacity = '';

to

if (opacity == null || opacity >= 1) opacity = '';
 
but it would not catch values that are rounded to 100.
Perhaps I need to improve the documentation in PubSubJS, so that it's clearer how doing stuff asynchronously improves stability of the system by making sure all subscribers are being called, even if there are exceptions.
Should this be?
    backend_setting(backend, 'SOCIAL_AUTH_LOGIN_REDIRECT_URL') or \
Probably just spacing. The method was changed in the previous commit as it had no try-catch clause.
You should submit a pull request to the upstream repo.
Still no crash log :) You guys are lazy
Why spawn him? he is summoned by item you get while doing the Ora/Frenzy chain
in time :)
"C, FORTRAN< Python". By the way, the original has a typo.
It is also called from line 614 - from a time critical piece of code.  (Every cycle matters there!)
Separating ThrowableCaught (the actual data object) and ThrowableCaughtEvent (the transient event object) might be a better way to design this. I believe it is good practice to separate the event object from the data object.
not sure about that one. but i would probably translate the rdoc documentation files to markdown anyway.
once @topfunky enables the travis post-commit hook, we can include the build status in the readme and i don't think
rdoc support images and links, right?
The idea I have been thinking about is allowing atomic effects to carry around other effects inside of them, for example the calculate function returns the eff table but with an additional variable, call it "_effects".  The PartTalents:useTalent code then add a "flattening" step after getting the  effects table from the "ab.effects" call, where it iterates through all effects looking for that "_effects" table and adding them to the list.  This means we wouldn't have to create a new type, although I do like the wordplay of Atomic and Molecular.

Either way I want to take a look at the overall AtomicEffects design to make sure it supports the thing that I was always interested in to begin with, which is getting the "effs" table from a talent without having to use it.  I think this is a modification for PartTalents, but I need to think about it more.
对于这种复杂的操作倒是可以都支持。不过对于像 `$.storageincr` 这样的操作，可以忽略 `number` 类型，比较 `a += 10` / `a-=10` 就可以实现了
This needs to be modified to check frames on vehicle teleportation, too.
connect, email, valid
This is never in a million years going to result in b times 2, a already contains the ASCII value for our selected character, why copy it to b?
our codestyling is as follows!
http://www.trinitycore.org/f/topic/6-trinitycore-developing-standards/
and
http://www.trinitycore.org/f/topic/5347-deprecated-methods-of-coding/
(reads the wall-o-text)
Any noticeable gain from this + that OpenBSD lib change commit? I've read about the strlcpy thing, but apart from the protection thingy does it provide any noticeable improvement?
Esto ya no lo se, aunque a mí me salían las llamas :S
Ah, %*s only specifies minimum field width, not maximum. D'oh. I'll fix it.
**getMessage()** may return null...
Here is what I get under 1.9.2 for the original version of the file:


> /home/jason/.rvm/gems/ruby-1.9.2-p290/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:456:in `load': /home/jason/repos/openstreetmap-website/app/models/spam_observer.rb:6: syntax error, unexpected ':', expecting keyword_then or ',' or ';' or '\n' (SyntaxError)
    when record.is_a?(User): user = record
Did you intend to comment this out?
Just another way to do it, you can also use ```List::Util```
then you can do
```sum 0, @digit;```
@stof: OrnicarMessageBundle's ParticipantInterface requires a `getId()` method on the User, but there's no reason that would conflict with another interface's `getId()` method unless the parameters were different.

Regarding performance, I think there are indexing hints for `usernameCanonical` fields. In MongoDB, that should entail as speedy a lookup as the id.

At Exercise.com, users don't have the ability to change their username. They can change their email, and our login form will let you use whichever you prefer. There are still cases where admins have had to go in and change usernames, though. I can understand that a UserInterface would not dictate an identifier field, but it doesn't make sense in practice. Trusting a field entered by the user to remain immutable during the lifetime of your application seems like asking for trouble.
On Tue, Jan 10, 2012 at 12:57 PM, Charles Parnot
<reply@reply.github.com>
wrote:
> Damn it! I thought that would be caught by the validator :-)

It definitely should catch that; it's basic XML. If it doesn't, maybe
you ought to use a different validator (RNV is superfast, compliant,
open source, etc.).

> It looks like we could use a meta-validator script… I'll probably cook one up one at some point and share it. So, to summarize:
>
> - it should validate using the online validator against CSL 1.0

See above.

> - make sure the id is unique
> - have the id follow the title, replacing & with and (and then diacritics etc…), all lowercase
> - name of the file should be the same as the id
> - <rights> section should be added and should be CC by-sa 3.0
> - check <isbn> element --> should be added
> - check rel="documentation" element --> should be added
> - check rel="self" element --> should be here and consistent
> - check the et-al-related attributes for consistency
> - check for unescaped characters
> - check that the 'citation-format' attribute is present only once and consistent with <citation>
> - check we have at least on 'field' attribute
>
> Some of these would be warnings, some can be considered errors.

I thought some of us started to work on such a script. Rintze, do you remember?

> Anything else?
>
> Charles
>
>
> On Jan 10, 2012, at 9:46 AM, Rintze M. Zelle wrote:
>
>> An unescaped ampersand. You were so close to committing a perfect style!
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/citation-style-language/styles/commit/e5e6e779e4a5d364eea0ac5eca279fea47cc031e#commitcomment-854055
>
> --
> Charles Parnot
> charles.parnot@gmail.com
> twitter: @cparnot
> http://mekentosj.com
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/citation-style-language/styles/commit/e5e6e779e4a5d364eea0ac5eca279fea47cc031e#commitcomment-854099
Overflow issues exist when using  td due to table elements  not supporting css overflow properties.  This  causes slight horizontal scrolling when wrapping with padding on the lines even with word-wrap set to break-word. Since it was  necessary to switch this to a block level element, might as well change the whole setup.  toolbar and collapse unaffected.  The textarea fallback for quick-code has not yet been tested. Necessary changes to themes involve floating .code and .gutter at the very least.  Once I am done with changes I will post an example theme with necessary jquery for resizing to gutter that works well with .syntaxhighlighter code set to have white-spacing: pre-wrap and word-wrap: break-word.  Changing other themes will be task for someone else as I have no interest in supporting anything that forces horizontal scrolling.
Why wouldn't we want to bubble personal channels? Or am I confusing this with the channel of the current user which is always on top indeed?
also, removed some old code
Re-added missing line from commit e890ca8b9a43cffdf7bdebd95cbe2f34f3ec4aaa
eu sei, cara, mas se liga, nem todo mundo aqui tem bom humor suficiente e compromisso de puxar conversa sobre algo assim aqui.. quando puxa, é com um outro com outro, parece que existem prediletismos de mais por aqui.. a coisa é parar com isso..
pra que internet se não souber usar nessas horas?
Duplicate function !!!
Не совсем понял этот кусок... Ниже ты выбрасываешь исключение OpenModuleException, а здесь ты его гасишь
> "extensive unit tests" -> "standalone unit tests"?

Perhaps it would be even clearer to call them "offline tests", as opposed to the "inline tests" of qtest ?
Yeah, I don't think that it is, at least for the usual computing analytics process. The only place I can see the info in eData being accessed is in the function process.atlas.nc , which is for writing to tab-delimited text files rather than to NetCDFs, and we don't know if that function is ever used anywhere. I've never used it.

Therefore, tempted to remove eData completely, plus the ```if ("SC" %in% names(netCDF$dim))``` statement (line 84) and other references to Characteristics.
I suspect the fact that is.finite() includes a check for NA is incidental to the logic intended behind 'tmp[!(is.finite(tmp) | is.na(x))] <- 0'. I think it is meant to replace with 0 just minus infinite values (resulting from log2(~0), and leave all NA's alone.
Are there any limitations on the units, or are they meant to be totally arbitrary?
given the points above I’d leave this method as it was.
great, I was missing that compared to old make script
I think most of them are references.  I was working on a way to just have to supply the ones that are not in the pattern: FooBarID => foo_bar as a codename.  In a lot of places, the card_id is more convenient to use than the name anyway, and this is a very fast way to do the referencing.
if it comes from the cache, it's always frozen.  that's the problem.
This could be split out to a sooner to merge branch too, and I think you should take a deeper look at what I've done.  I think I followed your advise and added it to the sets in code (Model, often Self sets on the individual setting cards).  Maybe I pull this out so you can look and it and tweak  it separately and we can merge it?
Required to be accessible from `classes/viewmodel.php`
`fs.existsSync` isn't available on Node 0.6, so use `utils.file.existsSync` it provides compatibility for 0.6 and 0.8. 

Also could you include the brackets on the statement? and ensure the statement is on it's own line. That way changes later can be seen easier.
This is not non-linear peak finding.  And I totally think we should re-use the existing peak finders here--it only requires removing the existing re-implementation in this specified model.
Thank you for doing this. Did you have some time to have a look at the examples?
import urllib.urlencode
This example would be a more useful if it showed a criteria that could match more than one consumer. Something like "lab.*" and have it return lab1, lab2, and lab3.
might consider keeping the line length here closer to the pep8 recommendation of 80 chars.
So far it is pretty neutral on test run speed, I want to develop some clear metrics we can instrument the code for and see where we are. Then we can remove the local caching changes if they don't make sense,  but merge all the metrics and instrumentation we might add here figuring that out.
The URI's sometime match but not in context, so we have to to a within context match.  This mode of testing won't be around long (obj_render).
Good that you used the standard option parser, and that you defined --help
can use the compare(long, long) below
This should probably be replaced with shell.setCurrentResource(...) instead. But... shouldn't execute be able to handle spaces?
The `@property` annotation is not used in `Behat`
I gotcha. I'm always yelling at people for that mistake though, I'd have some explaining to do if I'd done it ;).
`tracking` should be true by definition here.
Hey now, if we're going to copy the iOS documentation we need to do it correctly, eh? **`*TUIControl`**
Out of curiosity, why is my post the only one without a 'repo collab' sticker on it?
I don't think we need to publish twice?
Please remove the public getter..
remove // and add javadocs to the next methods...
can you please be more specific? what should i do with it? I can see it looks ugly, but other then ugliness is there a problem?
While we're at it.. do you think there might be rounding problems when saving then retrieving from database? Ruby's time has 7 decimals, but I'm unsure whether all databases keep all 7 time decimals upon insert.
I don't think that this case should return `true` for `changed?`
Indent = 4 spaces. Show be 2?
The filter option and routes are unnecessary for the web page. I'd rather
hit Cmd+F in my browser.

-- 
Sent from my iPhone
This method already exists in scala.tools.nsc.util.package.  Let's not duplicate it - if we want it more visible (I certainly do) then it should be moved.  "show" is much too generic a name for it (or for most anything unless it is the single method in a "Show" type class.) It's called "stackTraceString" in that package object.
Oh, I've read Martin's note on the mailing list.
Test-cases that these optimizations are applied should be added (performance regressions)
I think this needs some more jazz
`objects` fully depends on `premises` and I only store it with the goal of not rebuilding the list every time it is needed.  Actually, I'm not that sure whether it's a good idea to keep `objects` in `.args`.  Since I am using it for caching purposes, perhaps I should employ just a private attribute?

If we decide that `objects` stays in `.args`, I'll write the `__hash__` method.  Slipped by me back then :-(
Maybe.  This is one of many instances that I found in the tests and throughout where deep=False was being used even though the desired expansion was actually a deep one (below the top level).
Missing spaces around `+`.
This should probably be fixed.  The order of the args will be completely random and might not even be the same for two runs of the same expression.
I thought we were done with this module?
This is not going to work (please test with create camp):
- An exception in flush will close the em, so there is no sense to continue. Will throw other errors than PDOException.
- In my eyes it is sufficient to run flush only once at the base transaction (performance)
- If validation has failed, theres no sense to try flush (actually this is what we try to prevent, don't we?

What was wrong with the previous version? please explain.
I would just remove this paragraph about Symfony2 as it does not help the reader.
"to it" => "to"
Please choose a more reflecting `id`. I would go for `attend-event-button`
`{` should be on a new line
If sigterm did not work you probably did something wrong OR using broken software.
Add spaces?
Is this github messing up indentation for this block or is it actually messed up?
Why don't you directly write to classArray renamed to currentClasses?
> HTTP/1.1 clients and caches MUST treat other invalid date formats, especially including the value "0", as in the past (i.e., "already expired").

Стоит просто передавать 0
Как-то это смотрится неочень, особенно проверка на /. Может быть это лучше разрулить храня в базе тип картинки(локальная или нет)?
please clean-up the code, should be
```
docStore = Ext.create('Screener.store.Doctors');
```
(needs semi-colon, no extra junk)
Encounter is sent even before complain form (made by vishnu) is filled. So, no dependency on entering chief complain/ reg fee/ other concept .
could save a few lines by saying: ``` for (var i = 0; i < patientsTitles.length; i++) ```
These are not getting hard coded. As we are not sure of the order in which the observations are stored in an encounter, so m dynamically displaying the details. Which serve the purpose completely.
Is this updating the raxacore on the server automatically when we do github pulls? Where in github can I see this setting?
It's obvious! :-P `for cube in cube_4d` slices the 4-dimensional cube into 3-dimensional pieces. Then `cube[:2]` cuts each of these 3-dimensional cubes down to just the first two vertical levels. Then the final `[:4]` limits the overall result to just the first four of these cut-down 3-dimensional cubes. Simples.
OK.

Is there some way to detect local imports, so my theano_format.py could enforce this?
Right, I also changed the comments for isOrderDeterministic().
I have thought this over.   Let's leave it as is for Migrations, ie: Extensions can load it in.

We'll get to decoupling things after this gets merged.
Ah, so this is why we want it virtual. Would it be reasonable to instead have a wrapper function that performs this check/update *and* calls decay?
`debug` doesn't add an extra newline. Do we really want to add one here?
They are not really necessary, but with these specializations repr output is easier readable by human, and still "repr".

Code:

```
repr(String("aaa"))
repr(StringRef("bbb"))
```

with these specializations outputs:

```
String("aaa")
StringRef("bbb")
```

without:

```
Vector[Char]("aaa")
CoordinateRange[Char]("bbb")
```

Previously, ```printReprTo(stream, s: String)``` was overloaded instead of ```printReprTo(stream, #String)```.
After look at the code of float8ge. It seems the function doesn't set any margin for the equal comparison. I will change to >-=. Thanks.
This is not what I expected, but svec operator is not schema-qualified.

<pre>
haradh1=# alter extension madlib set schema madlib3;
ERROR:  extension "madlib" does not support SET SCHEMA
DETAIL:  operator <(madlib.svec,madlib.svec) is not in the extension's schema "madlib"
</pre>
As above, improve error message.
Was there __array_indexed_agg?
So you have to create this listener function for every new listener you add to the core listener, this could probably be fixed if you either have the core listener send all events to a single function on listeners and then the default impl. delegates to the methods below, done this way you could override a single method that does ``self._broadcast_event(event, data)``. Other way is to have each of the methods have a default impl. that calls a fallback, but personally I think the first one seems more favorable.
`imagemagick` has a reasonable test; doing something useful with the program that might coax it to e.g. segfault if compiled incorrectly.
This is addressed in 0943750.
@solnic do you think we can just do this here:

```ruby
@virtus_attributes_accessor_module = AttributesAccessor.new(object.class.inspect)
object.extend @virtus_attributes_accessor_module
```
(I'll say immutable - it's the effective meaning since we control the set privately)
sorry i didnt understand why you dont like popping, i thought it was because sounds not worked in my commit.
What should happen if the user accidentally assigns the same index to multiple fields, or doesn't have enough fields, or too many, etc.?
Also a comment here?  What is this doing?
try and catch blocks are indented one level to much
Actually, I think we're fine—I'm hacking around stuff from the body-text component so I can spoof child nodes' styling and push the link bars right to the edge of the screen. Treating captions as body text is still the desired behavior in most cases, and what I'm doing here is aberrant. (If we weren't working in the constraints of MAP it'd be a separate component and the issue wouldn't arise.)
Alright, will do!
There are a few jQuery selectors in this file that appear to be overqualified. A single ID selector should be sufficient I thought. ``#menu-custom > ul`` should work here.
These vars should be added to var statement above.
Very minor, but sometimes it's nice to explicitly call out the value of these.
Ex: once = 0, loop = 1, next = 2, etc. 
With only 3 options it's probably not going to help avoid much confusion, but as an enum grows it's nice to have the value there so you don't have to count down the list.
I would still suggest you check for both because then it is clear to the reader of the code (who might don't know about inheritance, as you didn't know) what you are allowing/expecting and what you don't. But comment the reason (code readability) so that later on somebody will not "optimize".

Or, you could add a comment explaining that `datetime.datetime` is a subclass of `datetime.date` so it is enough to check only for the later.
This should be in markup.
the javascript on this page is insane. waiting for things before clicking on them is done in self-defense.
I dunno `i = 0, l = projects.length; i < l;` is still pretty readable. Hot loop? If this is another case of you not writing this code then ignore it.
Actually, why do you need this here at all if `closeEditor` does it too?
Please indent this block of `p`'s `p`roperly.
Same as https://github.com/mozilla/butter/pull/983/files#L1R65
instead of doing this we could set the min/max values on the input element to limit this for us
Same as https://github.com/mozilla/butter/pull/808/files#L3R24
To illustrate the dependency tree a bit better, it's not a bad idea to include `util/shims` here. If, for some reason, this file needs to be used elsewhere, or `util/shims` isn't guaranteed to be included already, placing it in the `define` will ensure that it's loaded before continuing. Require will make sure it's only loaded once, so it's really just good practice as a software engineer.
I have to because it's in a `<pre>` tag
This is missing the default stuff stuff that I did in the default editor and checkboxes no longer work ( check one, change to a different trackevent, then change back and it doesn't keep its state ).

Also I get an error when changing the start end times to various numbers ( try deleting it completely, changing to a different field, and going back ).

I get
    Uncaught Error: Invalid time format
Yeah, I can remove that. Was thinking about doing that when writing the code, but felt lazy... :)
This spec needs to do setup in a before action and cleanup in an after action. It should probably be in its own describe block.
Why do you add the params at all of there is no javadoc?
I think the native english speaking guys should change it
I'd suggest adding some comments to this class. Maybe even describe the use and purpose of each endpoint?
The manifest file is never passed to this method. The method is simply to check the task status and return it in json format to the javascript.
Let's leave it as it is for now.
oh Good point brad!!!   Forgot about deletion changesets :)

Logic looks good as is.  Seems odd to get an error creating a changeset depending on which type you choose, but i guess that's maybe a discussion for another day.
Look below for answer to this. The self.promoting_to checks both promoting and deleting so we are covered there.
```csharp
Assert.Null
```
Here it sets the mask to the first plot, maybe it would be better if it was set to the closest owned plot or the last interacted with owned plot.
This is a leftover from the test case I model this one after. If testing
'union' functionality via the proc doesn't add any value I would remove it
for clarity.

On Fri, Sep 21, 2012 at 5:28 PM, Paul A Martel <notifications@github.com>wrote:

> In tests/frontend/org/voltdb/regressionsuites/TestUnionSuite.java:
>
> > +    private void load(Client client)
> > +    throws NoConnectionsException, IOException, InterruptedException {
> > +    }
> > +
> > +    static public junit.framework.Test suite() {
> > +        VoltServerConfig config = null;
> > +        MultiConfigSuiteBuilder builder = new MultiConfigSuiteBuilder(
> > +                TestUnionSuite.class);
> > +        VoltProjectBuilder project = new VoltProjectBuilder();
> > +
> > +        project.addSchema(TestUnionSuite.class.getResource("testunion-ddl.sql"));
> > +        project.addPartitionInfo("A", "PKEY");
> > +        project.addStmtProcedure("InsertA", "INSERT INTO A VALUES(?, ?);");
> > +        project.addStmtProcedure("InsertB", "INSERT INTO B VALUES(?, ?);");
> > +        project.addStmtProcedure("InsertC", "INSERT INTO C VALUES(?, ?);");
> > +        project.addStmtProcedure("UnionABC", "SELECT PKEY FROM A UNION SELECT I FROM B UNION SELECT I FROM C;");
>
> Should be testing this proc as well as ad-hoc?
> Though the distinction between proc and ad hoc only gets interesting when
> parameters come into play.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665965>.
>
>
This stops exceptions being reported to `QWebPage::javaScriptConsoleMessage`, as we are using the debugger to monitor the call stack and report exceptions separately.
This should accept any arbitrary iterable too, I would think.  Numpy should already handle that when converting to an ndarray.
There is generally an expectation that blank lines will be ignored, so I get a little scared about cutting lines 913-914.  But I see the possible issue with a blank line after a continuation line.  What about moving this code block to the point just before the return statement and applying it to `outlines`?
> It can also be called a "factory method". This is a very standard programming practice and and I think perfectly suited for this case.
> 
> http://en.wikipedia.org/wiki/Factory_method_pattern
> 
> They're sometimes called "factory classes", in fact Wikipedia redirects searches for that to the link above.

@demitri - this link and the one I provided earlier both use a *method* of a class instance  to create the subclass instances, vs. directly instantiating the subclass instances.  I don't think that is a trivial distinction.  I'd be interested if you know of any examples in the standard library or popular packages where a class instantiates an object via `__new__` which does not inherit from the class itself.
Do we care if this fails?
@laanwj means that if -socks=4 is specified, and -proxy, and no -proxy6 or -tor, outgoing tor and ipv6 connections should be disabled, instead of being unproxied. Sounds reasonable to me, but extra special cases...
Note that we could also do Comment.create!(params[:comment]) here since user_id is already contained in the form fields. But I left the `@user` part to minimize my changes.
If `$out` ends in `&` won't you get `&&`?
I don't think a ternary will make the code easier to read. The else however, is not doing anything right now.
Why full type name here?
you should use private properties here. Making them protected would mean that they are potential extension points, which would require taking care of changes done on them. For instance, if the PhpParser was using protected methods previously (and not be final), moving the methods to an external class would have been a BC break for some users whereas now it is fine to move them out of the parser
Cakal by som, ze tu bude vacsi prekryv so searchSuccess.php... preco su take rozne?
should be |=
Why is this not in externals?
this sort of thing should be inherited from superclass, as you've noted in the pull req desc
Fixed. The name has been added to the error message
Is it intended that the library do a "clean" as well? Neither `git reset --hard` nor `git checkout` remove untracked files. Am I misunderstanding?
`@global`?
Sure - just tell me if there are any HTML files for which I should _not_ use that style.
A good place for an hgroup around these headings, and the h3 should be an h2 (adjust the size in the CSS if an h2 is too big by default; we have some common classes for heading sizes in sandstone).
why the `new_email`?
triple `===`
Oh, this isn't even dynamic anymore. It can be a CONST at the top. Would that be even better?
I first tried to create a request from a random song but something went wrong but by trying this it worked and I stop for the moment but I change it
Indeed. I still think we should wrap this up for Chef 11. But it would be a good place to try out some alternate approaches which could then be factored into how bulk_get is implemented. Since the adhoc stuff is still new, I'd rather not have Chef 11 depend on it at this time.
This seems wrong in principle :) We aren't going to have a principal container, are we?
Modified the variables to support multiple filter instances.
This is how the topnavigation widget is doing it, I just did the same here. Is there something else I should be doing?
framework.IsExiting() check can also be used and simply return in the beginning of the function when exiting the application.
Is there code to check if these rects are valid in all places where they are used?
Erm, I misunderstood. It takes effect if the converter fails or if the handler.post throws. If the callback fails then we let the main thread's exception handler take care of it. Reasonable enough.
is this a new PSR-1/2 rule?
you should also restore the exception handler
The standard header is the copyright notice at the top of the file. The author information depends on the real author ;)
BTW, @stealth35's gist was actually based on my work in #2606 (which didn't have x-sendfile support) :)
does the `ui` var here mask the argument?
Does this regular expression work if I have ? within quotes? I also don't know why we are doing the replacement rather than leaving it to the server? This seems pretty dangerous.
I think it's *less* modular.  As long as we have users ``/users/{userId}`` will **always** be the URI of a specific user.  Using that in the links means that we can make all the changes we like to the controllers and never have to touch the links in the html.  We only have to change the controller in ``conf/routes``.  Whereas if we go from ``Application.about()`` to ``Users.about()`` we have to find all the links in the html and change them.  I had to grep the html to make sure I didn't miss any, but now that it's set to ``/users/{userId}`` we'll never have to worry about it again.
Refactored this class to not use a callback in 4abd24e62231f25f08e632ea4c1ce8acf3877c5c
test kardam nashod :?
@miah - I wrapped all of the offending config items in attributes already. They should be in the updated PR.  Or did you mean something else?
s/raises an/raises a/
my 2 cents: newln_pos isn't the newline position, it's the position after that, which is a reasonable thing to do except that sep_pos is the actual position of the separator and we add one to that later. I think the code would be clearer and more consistent of these two position variables had consistent meanings; probably the position-after works better
indentation is two spaces
Why have you added these tests in their own module? It looks like they should be able to go into integration/basic
Yeah, I can do that. I split it to two lines because it was breaking the line length but then decided that the way it was written was too hard to read, so I made the variable for if it was found but then didn't put it back. Will update shortly.
Is this really what is meant by !=?

As an alternate, what if instead of adding a dependency, the '!=' dependency adds a 'Conflicts' entry?
It's almost always better to catch the actual exception.
This looks like it's indented the wrong amount. What's going on here?
I think this is probably a bad idea to modify httpd.js directly. We don't maintain this so if we ever want to update we are going to need to patch the updated httpd.js. I don't know how common that is but ideally we can do this in loader.js. I know we hacked this initially for test_apps but hopefully we can remove all that so we can stick with standard httpd.js
Perhaps we should add the uid attribute prefixed?

fb_uid_123456, makes more sense than 123456, take into account that the category field could be edited by the user at any time (via custom category).
Yup, definitely, this is a lost sentence from a previous solution, removing it.
sorry If I am wrong: elParent.classList.contains(''evme-apps) ? instead of elParent.className && elParent.className.match(REGEX_CLICKED_APP)
I appreciate the credit, but it's unnecessary.  If we did this kind of thing in every file, our source would quickly become unreadable.
Bug fixed. Message goes to proper thread if is opened
To be consistent with the rest of your code you may want to create a this.importContactsFromSIM() method.
I don't think you need `transition-delay`. A visibility "transition" would just work, like this:

http://pastebin.mozilla.org/1745787

(this is what I recently learned also :) )
That's why! We talked about it that's right :)

The icon in the status bar should disappear but I see no harm is leaving an entry in the notification tray... what do you think?
I’m not sure at all we should include specific icons. I know we did it in the past but I don’t really see the point so far, and this implies using a lot of arbitrary class names.

/cc @etiennesegonzac @vingtetun any opinion?
Actually for the country code issue this is not helping.
Because usually (at least in france) the number will be 33699XXXXXX or 0699XXXXXX (33 -> 0) so none of them "contains" the other.

On the other hand using `contains` will create issues like https://github.com/etiennesegonzac/gaia/commit/416502514650f390048a5ac248a2523a59220151
Ajouter **à** l’écran d’accueil ?
Optomize this, we only need to load 1 imageObj for each image source we want to use; we can then pass that on to any Kinetic objects that need it. (Each {Kinetic.Image}  object doesn't need it's own {Image} object)

Having a precache table for images/files could be useful? (so we're not pulling in resources while we're doing logic)
jepp -> should be refactored so that the car is placed in start position at the beginning. But not in this PR :wink:
Because we can actually use an implicit ordering on a superclass of T do to the contravariance of Ordering (follows the scala standard library API)
This causes a problem when the screen is exactly 1040px. The close "button" is covering content.
Good point. That seems to work well. Do you want me to submit another pull with that code? or how to proceed?
It'll have to be an issue. Not enough time to port to 2.7.
Lets try something like the following format for the options. I think it'll make it more consistent.

config show > Lists available config ...
config show video > shows video config ...
config show video resolution > ...
config set video #
config set video resolution
config help set video > shows help for the video command
config help set video resolution  > shows help for change video resolution
Why to use foreach when we can use:

    $config = KunenaFactory::getConfig();
    
    $config->def('ksessiontimeout', $config->get('fbsessiontimeout', 1800));
    unset($config->fbsessiontimeout);
This string wasn't defined by purpose: we need to think what kind of warning we should display to the users. Probably nothing, so we should remove the string and prevent it from showing up.
That sounds good. I'll remove this function.
typo: `devie` -> `device`, `emulate` -> `emulational`
I think this drops a sourcestamp, right?  `[0]` is used to get the setid, but then not given to `add_sourcestamps`.
On 28 June 2012 17:01, Ian Darwin <
reply@reply.github.com
> wrote:

> >
> >      <para>Drools started life as a specific type of rule engine called a
> > -    production rule system (PRS) and was based around the Rete
> algorithm. The
> > +    production rule system (PRS) and was based around the Rete algorithm
> > +    (usually pronounced as two syllables, e.g., REH-te or RAY-tay). The
>
> On Wed, Jun 27, 2012 at 11:23:51PM -0700, laune wrote:
> > >
> > >      <para>Drools started life as a specific type of rule engine
> called a
> > > -    production rule system (PRS) and was based around the Rete
> algorithm. The
> > > +    production rule system (PRS) and was based around the Rete
> algorithm
> > > +    (usually pronounced as two syllables, e.g., REH-te or RAY-tay).
> The
> >
> > Why explain the pronounciation here? This is not a detailed discussion
> of the Rete algorithm, which can be found elsewhere.
>
> Because it's the first time we meet the term; readers tend to form a
> pronounciation the first time they see a new word, and it takes more
> mental effort to change it later. Not that it really matters how
> they pronounce it, I suppose, but it costs us nothing to get it right
> early on.
>

Most of the pronounciations cited in Wikipedia's article sound very
strange. Only "/rɛˈteɪ/ re-TAY" is close to what I think is commonly
accepted as what the Romans would (most likely) have uttered. But feel free
to do what you think is right.
-W


>
> Ian
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/droolsjbpm/drools/pull/125/files#r1068434
>
binding should be separated from functionality
we have it already in roles
good spot, fixed in e7345c5e888da90ceb5d406f263fb4984ae209e5
not getting tags anymore?
Not sure I like this syntax / approach - couldnt we handle this on __init__ ?

Also we should check the regex is valid / can be compiled
still have the allocator and deallocator
remove the bracket and change writing style
@erikvold would you be able to take a look at this and confirm that I implemented preferences correctly in JS?

Sure I'll take a look tonight.
I don't have enough registers in my head to follow this code.
It may help to rename ancestor to extends and sources to implements.
Previous two lines was just about setting default value for these attributes, I don't see why we should use different word for them?
Are we using `datamaps` for anything else than `DataMap(self.target_cfg)` ?
If not, we can do : `for datamap in DataMap(self.target_cfg):` instead.
I would find it easier to read & maintain if it was something like:

```js
commands[command] || commands.help(options)
```

Where `commands` is a dictionary of command functions that extract their options and do whatever they need to.
@salmonz - This is a Gnome specific command.
@lloyd - this re-uses the global sha variable.  If the sha's length is not 7, the error will be correctly thrown, but any functions that call module.exports after the incorrect sha is set will have the incorrect value returned.
Why const? After we return from the function it will be a normal variable or?
I suggest you to run the check_cs script. See the README for more information.


Le 31 mars 2012 à 00:33, Cristiano Cinotti<reply@reply.github.com> a écrit :

>> +<database name="bookstore-behavior">
>> +  <table name="validate_author" description="Author Table">
>> +     <column name="id" required="true" primaryKey="true" autoIncrement="true" type="INTEGER" description="Author Id" />
>> +     <column name="first_name" required="true" type="VARCHAR" size="128" description="First Name" />
>> +     <behavior name="validate">
>> +       <parameter name="rule1" value="{validator: NotNull}" />
>> +       <parameter name="rule2" value="{column: first_name, validator: MaxLength, options: {limit: 128}}" />
>> +      </behavior>
>> +  </table>
>> +  </database>
>> +EOF;
>> +        QuickBuilder::buildSchema($schema);
>> +    }
>> +    
>> +    /**
>> +     * @expectedException  InvalidArgumentException
> 
> Fixed
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/propelorm/Propel2/pull/156/files#r628937
Shouldn't that be the original exception, not the backtrace?
I know I'm not @alindeman, but ... much!
```js
var ok = 'Yynaqdh'.split('').some(function(valid) {
  return valid === answer;
});
```
I dont dont like u :-1:
It looks like the brace style changed in this file and it no longer matches our standard.  Is that controllable?
A comment like "Nuff said..." is fine in discussions on GitHub issues, but not appropriate in the source code.
consider using
for (var todoElement in todoElements) {
...
}
instead of forEach here and elsewhere.
french particle
Line space between assignment and control structure.
We probably need to check here that `start >= end`, no?
You're right. I used it to check for serverVersion but then started looking at PROTOCOL_41 flag. I'll remove it.
On 7 November 2012 01:42, Jawher Moussa <notifications@github.com> wrote:

> In pelican/generators.py:
>
> > @@ -156,10 +156,7 @@ def __init__(self, *args, **kwargs):
> >
> >      def generate_feeds(self, writer):
> >          """Generate the feeds from the current context, and output files."""
> > -        if self.settings.get('FEED_ATOM') is None \
> > -                and self.settings.get('FEED_RSS') is None:
> > -            return
> > -        elif self.settings.get('SITEURL') is '':
> > +        if self.settings.get('SITEURL') is '':
> >              logger.warning(
>
> I'm not sure I see the big picture, but I think that the feed generator
> needs both properties:
>
>    - feed_domain to generate the feed file url
>    - siteurl to generate the links to the posts
>
>
Ok, you're right, I now understand.

I'm also wondering what is the use case for having FEED_DOMAIN != SITEURL:
why would we want the feeds to be served at a different url than SITEURL?


>
>
> And these 2 properties could be different. So both need to be set for
> feeds to be generated correctly.
>
> So no, I *think* that this warning is required.
>
> We could move the check from generators.py to settings.py though to be
> more consistent.
>

Yes, +1.


>  —
> Reply to this email directly or view it on GitHub<https://github.com/getpelican/pelican/pull/551/files#r2050763>.
>
>
Don't we usually call this opts?
Mention version dependency issues.
Fix indentation (how can this ever work? tabs?).
Spaces after : and , and around =
We aren't committing the .html versions of files any more, could you remove this?
I'm confused, which line?  this.parseCallSignature is adding Argument nodes, as node.children.
Why not have the user_id field be the primary key?
Hi Owen, yip i understand how inheritance works it may be because i'm passing 2 arguments into my save method
My thinking here is this: we can't count on this, but if/when it does work, we want it.  I'm not counting on it, but I'm adding it for gravy.
We should not be using `SBE37_CDM_stream_definition` anywhere, it has been deprecated for almost six months as of October.
This can't be by reference. If there is no data an empty version is created in the function that then goes out of scope.
Yes, but that's why you can just override that method in the individual model. Like I did below in lib/spark_api/models/saved_search.rb
Copy from all syco plugins.
It's a variable used to highlight the active menu item - poorly named, actually, I'll fix that.
moovida this is where we have the problem; search state is not doing its job
I don't think that's necessary. The python 2 input() is not of practical usage and can be overridden by raw_input. Python 3 just really does this.