labofsahil/github-event-dataset-2012 huggingface dataset:
Also re: my earlier point, we can just hardcode a generic email address for this as the test is not dependent upon it. It also means they can filter out the automated test data by excluding this email address.
trackedConfigList is used outside of synchronized(this), but inside on a method above. Reasoning?
Not if it's an index?
This is a bitwise OR ... shouldn't this be a boolean OR (`||`)?
``it's`` -> ``its``
AFAIK this is not supported by libxml. You do quite a few checks there and even trim stuff..
oops. sorry. may have overlooked the web hosting plan
If it's an ID use By.ID
Also, no need to check for an error once that's done. Just doing the batch and passing in `callback` should work.
Yeah, I can't think of a better way to phrase it myself. I think I tripped up over the 'get' part of the method name.
It's probably fine to leave it as-is.
API should be capitalized on this variable, and the others as well please
Are we sure that the Twitter username will not collide with an existing user account? It might be best to prefix these so they are secure.
Spacing here is messed up.
thanks stof, sounds like the cleanest solution to me (delegate the problem :-)

updated the PR. @lsmith77, @crell ok if we merge that?
done (forgot to push those)
changed this because we use the same struct for both failures and passes
This should not be included once the RestSharp bits are obsoleted
А что вас смущает? Категория - это расширение функционала класса, конечно же, ему нужно пользоваться тем, что есть, чтобы расширить функционал. Тем более, если вам вздумается, например, написать категорию для класса NSObject, у вас совсем не получится не обращаться к уже имеющимся методам в классе. 

--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
зачем делать -i, а затем +i ? 
что это за магия? =)
Там просто перепутаны названия переменных. Типы на своих местах, поэтому Xcode не ругается.
Hamming Distance has to increment when the elements at the same index of two DNA are not equal. Instead of that you are assigning an element index to distance variable. So "distance = i; break;" has to be replaced with "distance++;"
Ну как же, вот в этому модуле рассказано про class member  - это и есть переменные, поля класса
https://u.hexlet.org/courses/4/wiki/klassy-mietody-primier-sozdaniia-i-primienieniia-obiekta?module_item_id=5
As with another review, this sorting should be done in the controller and not in the view. Thanks! It would be good to have a functional test asserting that assignments are sorted that way. Perhaps we could even adjust the find() query to return things sorted already.
crowdtastic is really just an extension of formtastic, overriding a bunch of methods
That's great. Looking forward to your patch :) I am trying to do line wrapping with help of this function.
Same question as above for `mUserid` and `mImageid` being `String`s and not `Integers`.
is there a way to clean up / reduce the factories here? it seems like overkill...
是没关系，加一个只是标明下。
should be n_components
Raw?
it doesn't need to have an http server. That's the whole point of using the express module.
Change this to no return object.  (void)
Scratch that, this doesn't need backported. only put 1.10.0. order.orderer is still a User in 1.9
s/with/will/ ?
<3 “they help you define your asynchronous API in terms of other asychronous APIs.”
Sounds like you get what I'm trying to do.  I found that the flag works for this, but if there is a better way, I'm all ears.
Pass the settings into the constructor instead
I think that the previous form is more clear, in general I don't think that putting things like `compact` or `flatten` after pretty long block is a good idea.
Examples
========
sympify(0) -> S.Zero
Sería `seniority`. No importa si no se corrige en este pull request, anotarlo me sirve para recordarlo.
If we have a default here, then perhaps we don't need a default language for WebRequest? Thoughts?
You should not need to actually hit `#run` to make the metadata accessible. Please remove this line.
Sometimes it returns a value, sometines not, see lines 481, 494 
If it returns nothing, please remove the ``$ret`` variable for confusion
use   .equals() to compare two strings instead of  ==.  It's a Java thing. == means "is this the same String object?".  Usually this isn't the question you want to be asking.  Instead, .equals asks "does this string have the same contents?".

For example:
String A = "a";
String B = "a";

A == B; // will be false, these are two different objects
A.equals(B);  // will be true, these have the same contents
This essentially returns the array of positional arguments.  That way you can either access them through the old ArgOptions intreface or just as you normally would.  My code using this looks like:

    public static void main(String[] vargs) {
      ArgOptions options = ...
      String[] args = options.parseOptions(vargs);
      String blah = args[0];
    }
Instead of holding directly the data, we hold the entire crunch result so we can keep track if it was crunchToOne or not
NGHUTPR
But I am wary of these if statements. It might be clearer if you passed in an object which could perform the functions for where a resize and migration differ.
we still need to be backwards compatible.
Could you move this to the previous line, ``} else {``?
This method still could use renaming like I mentioned in my previous comment.
PEP8: do not put spaces around these variables in a function call
Typo: determnine -> determine.
@akhmerov: Your suggestion sounds great, but sadly I don't agree that they are nearly identical in all the backends (I looked at qt4agg, wxagg and tkagg after reading your comment). That is not to say your inheritance suggestion does not deserve merit, it would be **nicer** to have ```new_figure_manager``` be a class method on a ```FigureManager``` class, but I'm not sure the benefit outweighs the cost of breaking backwards compatibility (it would be possible to put an alias to the class method in place of the current function, but that would mean there were two ways of doing the same thing...).
Correct, I meant "default', sorry for the confusion.

Tony, I have to read through their standard and see how comprehensive they are.  Maybe mpl's standard might have to be a superset of it?  I do have some minor issues with how they do things, but any standard is better than none!
Microtipografia trata sobre aspectos detalhistas da configuração do texto. Eu não sou expert no assunto, e por isso acho melhor indicar a fonte do setup usado: http://www.khirevich.com/latex/microtype/
Maybe the use of arrays in examples should not hint preference of PHP 5.4 only syntax?
Use `{PSU_JS ...}`
This replace does not take into account that there can be comments between two import statements which are then removed completely after this operation has been performed:

`java
import java.io.*;   // for io stuff
import java.net.*;  // for net stuff
import java.util.*; // for util stuff
`

Silly example, but I'm sure there are more valid comments out there in the wild for which a user wille be baffled as to where they went, especially as the focal point in the editor can be somewhere else completely as they are typing away and finding the need to import a new class they just used. Not entirely sure what the correct solution would be here.
This is one I'm seeing a lot in docstrings -- the phrase "tile covering region" doesn't mean anything to a coder. Can we talk about the data structure that gets returned? Returns a vector with two elements representing the corners... etc.
Yes, there's a ticket at https://github.com/sakaiproject/3akai-ux/issues/2529
Hmm, I don't know

* I don't like very short class names but...
* "exercise" doesn't convey any new information since it's in an exercise...
My guess is that the phpdoc of PHPUnit is wrong.
Das BeerModel hat kein Feld für Tags, die Tags werden aus der DB geholt um das DomainObject zu istanzieren. Das DomainObject braucht halt Tags und kann mit TagModels nichts anfangen.
doesn't look like the right way to do this check. what about "account/id"?
Factored out to a separate method in code I have yet to merge, which cuts down on the noise.
What about simply

   overlay.setPixel(this.previouslyHighlightedPixelCol , this.previouslyHighlightedPixelRow , Constants.TRANSPARENT_COLOR);
   overlay.setPixel(col, row, Constants.TOOL_TARGET_HIGHLIGHT_COLOR);

Also I would actually name the fields simply highlightedPixelCol, highlightedPixelRow, the "previously" state is not really relevant except in the scope of this method.
I will not even look further.
Very very interesting. I didn't know that this exist. But this is ugly. ;-)
Move all loading to one template tag (you can list multiple libraries to load) on the top.
Why use `data=`? Decide, are you POSTing JSON, or you want to POST it as a normal POST.
Why do we need this?  It seems to me you can always export them.
I tested out the death/resurrection code here, and most of it isn't working properly. All the buff ticks are hardcoded ticks from whatever dump it was based on. We have proper level-based character stats now and in this code there are several hardcoded character attributes being set like max hitpoints that absolutely shouldn't be being set like they are. Also the restart point coordinates look to be hardcoded to what the first quest in tristram town uses, so it totally breaks if you die in any other world.

In any case, I'm working on a good death/resurrection implementation based off some of the stuff here. So you should remove this code from your PR.
Made --password optional and provide an option to keep your own my.cnf file: https://github.com/bekoeppel/cdist/commit/df512162cba34bde910df33bd5338f7b636ed1c8


Am 20.02.2012 um 11:12 schrieb Nico Schottelius:

>> +
>> +# to the database without requiring a passwort input
>> +rootpassword="$(cat "$__object/parameter/password")"
>> +
>> +# set root password
>> +echo "mysqladmin -u root password $rootpassword"
>> +
>> +# store the root password in /root/.my.cnf so that processes can connect
>> +cat <<-EOFF
>> +cat <<-EOF > /root/.my.cnf
>> +	[client]
>> +	password=$rootpassword
>> +EOF
>> +EOFF
>> +
>> +# remove anonymous users
> 
> should this always be done? i.e. isn't this breaking stuff for people how would use __mysql_server in a generic situation?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/telmich/cdist/pull/38/files#r466719
maybe uint8?!
urrr, wrong commit fml. gonna update today
The attribute needs to be added to the XSD
`getProtobufClass` seems to be correct here-- it first attempts `PigContext.resolveClassName` then backs off to `Protobufs.getProtobufClass` on failure.
Looking over this change again, it effectively negates the if block two lines above and prevents any of the conditionals within the fieldset from displaying if the filter_field param is false.  That's obviously not something we want to do, i.e. if someone wants to display pagination without the filter fields.  It looks to me like I'm displaying the pagination box in the same container as the filters, which itself seems a little funny (which core file did I copy that mess from!?).  Looking at this block of code again, it makes more sense to display the pagination box in a separate element.

I also just realized that the show_headings param isn't used anywhere in this conditional...
You could send email for Molly and she could take care of that. Let me know if you want her contact
Yep, I agree. Currently though, I am only targeting F16 and RHEL6. We will need to fix quite a few other assumptions that have been made in the build scripts once we start looking at other distros.
We could use the Mathematical delta symbol.
http://www.fileformat.info/info/unicode/char/1d6ab/index.htm
Well actually I meant SharedMemLockManager in http://code.google.com/p/modpagespeed/source/browse/trunk/src/net/instaweb/util/shared_mem_lock_manager.cc
That ends up using mmap, so no problem there I guess. 

I think that the filesystem locks do need to be cleaned on shutdown though, and the filesystem cache probably likes to have shutdown called too :-) So having NgxRewriteDriverFactory::Terminate wired up seems like a good idea to me.
Also check my comment on the next line. If you don't call configureSession(), I don't believe you need to explicitly sync().
Please be careful when adding things to a commit. These are unnecessary.
also the same as in other models. inherit?
or currently not possible to inherit because SysSEM doesn't have it?
this shouldn't have the sum loglikeobs is for each observation, ``loglike`` is with sum
XHTML? Now *that* is disgusting.

`<!DOCTYPE html>`
I know that at some point we had discussed making N and ud more descriptive, like n_photons and uniform_deviate - was that only for the python?
I think I fixed this to remove the jargon and yet make the sentence no less clear
I feel like this is leaving out important information by omitting the optional parameters.  There usually aren't too many of them.  Often, just flux.  

So I think I'd rather say here "... with optional parameters listed with their default value".  

And then below, most of the `...`'s can become `flux=1`.  In the few cases where there really are a lot of optional parameters that we don't want to explain here, put the `...` and say "For information about the other parameters, see the documentation for this object."
Ouch, I thought about it, but missed.
getUsableConnectionOrFail doesn't necessarily return a usable connection.
It just guarantees to return a non-null connection, or throw an IllegalStateException.
The connection may have temporarily gone down, and hence the connection object will be permanently unusable - hence wrapping this in invokeWithReconnect.
So perhaps a better name is getConnectionOrFail.
It is very ugly indeed :)

But I understand why it is needed. So merge it.
This comment is an exact copy of the code. It doesn't add anything.
guava's Sets.difference could be a nice way of doing this.
It also has the nice benefit of not assuming the returned collection is modifiable.
I agree this is strange but AFAIK there is no other way and It should be safe if the constructor does only basic object initialisation. Alex would it be possible to make getConfigKeys() static?
Is BaseIntegrationTest ever used? I couldn't see any references to this new class in this pull request.
I've submitted a pull request for this: https://github.com/cbeust/testng/pull/269
je prefere dire le truc de maniere positive
sure, ping me back when you do have some time :-)
Awesome pull! Unfortunately, we're not dropping 1.8.6 support until 3.0, so if you remove the `tap` here I'll merge.
OK, good points, I'll just rename it then. Thanks!
I defer this discussion to a future date, you have valid points, but it is too late to make such a fundamental change.  We will revisit this issue at a time of more leisure.
Just use ``$request->get()`` instead.
That would make them appear on different positions in the various classes. Not very elegant from my point of view.
also, might change it in update.sql ?
I see my own commit! :D
This seems.. odd. I'm not sure this is what you want.

What happens here:
if holder == null, return true, since !istype(null,/datum) returns true
if holder is a /datum, return true because holder is not null
if holder is not null and not a /datum, return true because !istype(holder,/datum) returns true

So basically, this is the same as if(1)
Почему ты не свой код изменяешь?
А можно ли еще убрать private с clazz?
У тебя есть метод closeFile. Сделай параметр вместо BufferedReader -- Closeable -- используй его везде.
I'm also concerned to remove this line. Why do we want to remove this? Where this parameter will be used?
nit, remove spacing
IntelliJ for dummies lecture in order when you get to London
Let' discuss that tomorrow :) I wonder why you'd need such namespaced path. Why not just `api/reactions/<pk>` ?
It's not a user-visible URL after all.
so if you wanted to reset this file and focus on the hroleverify files for this pull that's fine by me.
Проверил: действительно – проблема. Исправил.
Great then. It might depend on the shape of the data though.
I would say "The objective (called the stress) is defined by"
should remove all of this rule as it is now empty.
put a comment with the unit
Moved to NativeObject class.
prototypes above is for helper functions, this one can be bunched with the others at merge time
This assumes the delegate ViewResolver is some sub-class of UrlBasedViewResolver configured with prefix "/WEB-INF/jsp" and suffix ".jsp". I think the table should show only how this ViewResolver adjusts the view name to be clear.
In english, provide an english language exemple
One advantage of using assertEqual is that if the two arguments differ, it will print what the actual rendering is, and what the expected rendering is, rather than just failing.

On using blaze to generate the expected tree, this would not test that blaze correctly generates SVG. So this comes down to functional vs unit tests, and I've opted for functional in this case, but there's nothing to stop us having unit tests too.
This does not work. Have you tested your code? A good starting point are the samples in samples/ directory.
Its really a matter of preference, but just like in Java, "foo += num" is the same as "foo = foo + num"
indentation looks wrong (and below)
Since there can't be multiple IDistributedSuperFile instances here for same logical file.
this could be :
if (NotFound == dflist.find(*sfile))

Slightly quicker and makes it clear can only be one.
Note: We're using a case insensitive lexer, so (b|B) can be expressed as either b or B.
The previous ``if`` returns, so we don't need an ``elseif``. ``if`` is enough.
indentation doesn't line up (pep8)
Have you benchmarked this, by any chance? I'm curious if this will add performance overhead (vs. doing a "$controller instanceof Dispatchable" check).
Hehe. Thanks! I'll push a commit to add that comment shortly!
I liked that space :P
I'm not sure a break is necessary here. We may as well just keep on trucking and let an exception propogate later if it happens
This is to get out of the annotation scanning rabbit hole.
Yes, this endpoint is for all notifications.  There's also a per-repository URL: "/repos/:owner/:name/mark".  Summaries have their own endpoint, `/notifications/summaries/:id/mark`.

I used POST instead of DELETE because you can still see the notifications if you pass `?all=1`.
this if statement would be the equivalent of ``if (!empty($controls['must_revalidate'])) {``
note this indeed means that if ``$controls['must_revalidate'] === 0`` then even with the current code it would not be set

the same applies to all following if statements
you should remove the extra ``\``
cool. Hard to tell from these github diffs.
How would you make that work?
FYI: refactored to use with_api.
Drop this extra indentation for private methods.
By handling saveChassis event in Router, we avoid the problem by avoiding binding two handlers to partAdded event. Not being able to bind multiple handlers to one event largely reduce the power of event driven architecture. This piece of code was introduced when I tried to add a local queue to the bindable, as the result of our first meeting yesterday. However, I found a local queue can not pass the second unit test of `BindableSpec.js`. So I stopped and asked you about the global queue. I should have revert this before committing. Sorry about that. I am going to revert this, and leave #32 to you.
Done. Thanks for pushing me towards making it more testable and adding more unit tests
This can be collapsed into  if (payloadSize === null && bytesReceived >= 32B_INT_SIZE) {
Never mind. Figured it out.
@sptramer sorry for typo, I meant 'resumed'
Trying to save bytes. I highly doubt we'll change these in the foreseeable future.
Can you add a blank line above this comment?
Use `grunt.file.mkdir` to create required directory structures: https://github.com/cowboy/grunt/blob/master/docs/api_file.md#grunt-file-mkdir
Removing this line causes a Notice, because the constants are not defined anymore.
@sehmaschine … And this is the default value for both M2MLookup and AutocompleteLookup.  I thought that would be correct to have an empty label, but if you say you experience a bug with this default value in AutocompleteLookup, this is what we have to change.
I took the example in here: https://github.com/symfony/symfony-docs/edit/master/book/http_fundamentals.rst
If you look at line 56, there is an absolute URL. I think this is what is breaking the image in the PDF...
Ну я говорил, что мы не определились с этим окончательно и решили пока везде по два ставить. Надо определиться, может быть, однажды.
А это пользователям уже собранного виджета нужно? Может через пайплайн пропустить и вставлять логгирование только до сборки?
Doesn't this need to return stuff?
Good catch. A half-solution would be:

```d
if (radix == 16 && s.startsWith("0x") && isHexDigit(s[2]))
```

But in reality the hex digit could be a random character as well. I don't think there's a way around this without breaking existing code, so I think I should close the pull and flag the bug as invalid.
Insert a comment explaining why having two node types is good.
We're using Prototype 1.7 now. Is this quick fix still needed?
This test description still uses the old name!
For these type of asserts you can use [ `assertInternalType`](http://www.phpunit.de/manual/3.6/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.assertions.assertInternalType) function like this

    $this->assertInternalType('string', ' a string value');
do we have this size text defined somewhere else?
As far as I know, the copyright of the library belongs to me, I don't see my name in chef's copyright because of my contributions. If removing this line means that this pull request cannot be applied I'll be glad to rewrite it on my own.
This code makes this routine safer
make this a parameter.
У тебя тут чо-то с табом.
Can we apply the style guide to this CSS?
import is private by default, mumble mumble
Wouldn't `D_LP64` also apply to Itanium?
That's why I changed it ;)
There is no help install - it does install
This should not have  been in the pull, but I get what you are saying. Add persist true to all of the things. JK
Hmm. This is hard-coded? Is this why it does not display anything to me when I start with fresh database one?
the code isnt aligned, you might be mixing tabs and spaces
I guess we're trusting redis' output enough that this is OK to log as verbose only. Seems like an OK change.
why did you remove the ``click()`` call ?
This is not an equivalent simplification.

With `BROWSERID_DISABLE_CERT_CHECK` set to `True`, `ca_certs` with be `True` which cause `requests` to verify the CA cert, instead of disable the cert check.

It should be something like

```python
if getattr(settings, 'BROWSERID_DISABLE_CERT_CHECK', False):
    ca_certs = False
else:
    ca_certs = getattr(settings, 'BROWSERID_CACERT_FILE', True)
```
those changes are not necessary...
I would add some text to the ImageFactoryException stating that the instance may still be running, just as you did in the log entry.  The exception is what will get passed back in the response, so it's good to have it there as well as the log.
These changes were included in a previous commit that has already been merged... 

I suspect some other changes here were too...

This is making the process of merging this change both painful and error-prone. I need a commit that contains JUST the changes for this fix. 

If it's not possible to create a single commit based on split-3.6 that fixes this issue (because it relies on other changes made since split-3.6) then:

1. If the changes in question have been merged into 3.6, you should base your branch for this change on that previous branch, and I should be able to merge cleanly into both 3.6 and master
2. If the changes in question have NOT been merged into 3.6, then you should STILL base your branch from that one, and we should take this change for master only. It's not vital that it goes to 3.6.2
The CTempActiveTransaction instance, had the semantics, that if lookupSuperFile failed/threw an exception it would revert cache state..

Shouldn't that still be the case, i.e. if there's an exception in lookupSuperFile, could cache be left active, or will it unravel anyway, as transaction goes away?
Er, and the reason I ask the bigger question is that for IMAP, as noted elsewhere and recently on IRC I have already loaded all the headers covered by the time-range I am synchronizing, so there is no need to do a database lookup.  And if you end up with a similar sync strategy, that will work for you.

But if we are compelled to have a different strategy, then it might make sense to maintain a separate IndexedDB mapping to this end.  Sometimes random-accesses to the database are simply required.
You don't need the maven assembly plugin anymore if you're using one-jar.
This is a typical application steps:

1. Closure needs start point for deps calculation thats why 'require_closure' directive was developed for.
2. Closurebuilder searching within all the '.js' files (download treescan.py from closure svn to check, string 28) and trying to find any with 'goog.provide' directive
3. Closurebuilder calculates proper order and then gem includes them all in right order to project by 'require_asset' function
4. Sprockets handle any .js.{erb,coffee, etc} postprocessing.

As you can see closurebuilder don't care about non '.js' files (step 2), and sprockets cannot handle js.erb files until that files included to page by 'require_asset' (step 3). So closurebuilder should search for 'goog.provide' directive even in .js.{erb,coffee, etc}. That why we need to change default regexp in treescan.py

If you could find better way it would be great. I couldn't. As I told erlier, new processor is inherited from unregistered one just to provide 'require_closure' directive for step 1.
We should be clearer in descriptions of these classes. In this case: `A type of proxy representing an animation to apply to a view` or similar.
what is this?  I think you need to see examples of our own use of this.
For iOS, they must be placed in the `Resources` directory or they may not be loaded. I believe the iOS font loader only checks the main bundle.
log where this used not here.
It's fixed.  Thanks!
Wrong indentation here.

```php
$defaultDocumentManagerName = isset($odmConfig['defaultDocumentManager'])
    ? $odmConfig['defaultDocumentManager'] 
    : $this->defaultDocumentManager;
```
It is just temporary name. To show you at least little bit of what I mean by hooks. It is not finished yet. Please, focus on logic, not on syntax.
Сейчас упрощу немного и отправлю пулл-реквест.
As for invoke success here does't return value but error does and user can receive error back in catch block.
Its definitely weird. Tech debt issue?
Reset batonHandle after handling it
@ychadwick the getters in the FormView are deprecated in favor of the public method. and btw, offsetGet is the ArrayAccess method :)
your delete in the after list should eliminate the need to do this.
this if can be merged with the if in line 134 ( should be in the beginning)
Powinien być określony kwalifikator dostępu (private).