labofsahil/github-event-dataset-2012 huggingface dataset:
An explanation: I really wanted to use inheritance, and super.read(), but while Eclipse's JDT compiles this fine, javac complains that I cannot invoke an abstract method, even though the immediate parent class has a concrete implementation. Verified with both Java 6 and 7
I guess this test needs a running MongoDB instance ? If so we either need a way to start/stop a MongoDB instance for the test in an autonomous fashion or the test should be disabled by default (maybe put it in a different group which can be enabled when an appropriate environment is present)
you could just call ``setResourcePaths`` here
I think the None case is handled by the next line, no?
IIRC, that `foo` folder is simply so that we're not in the source directory because then Python 3 will import modules from there which have not been transformed by `2to3`. Will definitely take ideas for better folder names or a better approach.
Sounds good to me! :)
you don't need `get_attribute('id')` here, you can just pass the iframe WebElement straight in!
@bp323 Ok
@arnodeclercq Instead of using `jqm` directly, can we use the Sakai api instead? `sakai.api.Util.Modal.setup`
One more remark: it seems that what we really need is a utility method somewhere that takes an `Authorizable` and tells you if it happens to be an admin `User`. Maybe on `SparseUtils`?

Then your code here would be: `if (! SparseUtils.isAdminUser(authorizable)) {`

Which is easy to understand.
Please be careful with indentation in SCSS, can get confusing really fast
It's unfortunate that we need to flip the state here just to read the transaction ID (since that's an atomic 32-bit read).  That said, it's certainly safe this way and I would need to think about how to make it safe without flipping the state.
That logic will be folded into test txn02, so I've removed it.
Okay, I'll get to fixing that.
A thorough thought! Kudos!
why don't you use `strippedRoot` ?
wrong tag name
This `0px` default is for browsers that support `backgroundPosition[XY]` and are returning an empty value on those properties (IE7 and 8 are on that group). Since those browsers get their `backgroundPosition` decomposed into the 2 sub-properties when it can't be retrieved directly, we need to return *something* or else the test against an element that has no set `backgroundPosition` style will return a space (that is, 2 empty strings concatenated by a space).  
  
For the second part, the regexp against top/right/bottom/left is simply to avoid running the normalization code if we already have a non-keyword based result (only IE7-8-9 enter on that part of the condition).

as for the replace, I think we can further reduce it to just `return namedPositions[value] || value;`. What's currently there seems to be a left-over of several iterations I did to fix this. The replace will only call the function if it finds something, so there's no chance that empty values reach that point.
Text is fine by me, though it sounds like this is something we can fix -- we can't, it's on the other side. But perhaps that doesn't matter to the user.
why title is now out of this div ?
I thought it was in the Symfony2's CS?
Perhaps simpler as:

```
while (!pathComponents[offset].equals("inputs")) {
    offset += 1
}
```
That's exactly what I did (at least I think so). :)
`user_connect` is probably not the right value here, too much copy-pasting. :-)
Depends what you need. If you want to get `None` if key does not exist, use `get`, otherwise `[]`. Here we are assuming (the API is such) that we will always have key there, so we want to use `[]` to get an error if the API is broken. If we would use `get`, we could hide some error.
Why you unindented everything for one level?
no, as it is comments are displayed (refreshed) only when post is appendedToTop or ToBottom

so it's not automatically because you need to refresh the page to see a new comment (and to see post move above other posts)
Шаблон?
Is there any reason to allow only positive numbers? While not the default, what if a client would like to generate numbers from -100 to 100? I don't know why anyone would want to do that, but it's conceivable. Shouldn't it be possible?
Here's another block of `ruby` code:

```ruby
def my_method
  puts "does something"
end
```
I'm happy to see units in the property names!
I changed this to catch all exeptions, because it always through an JSON exeption as i created a world.
please remove the word `with` and perhaps change `query` to something more indicative of what it is and does. Perhaps:

    +- (void)modallyPresent:(NSString*)route from:(UIViewController*)viewController parameters:(NSDictionary*)parameters;
I would vote for ``subtrees`` or ``subtree``. ``descendants`` also has the connotation of going down for me (I think of family trees as top-down).
Is this guaranteed to end? Shouldn't we define a maximum delay?
and how will that be handled in the liveusb creation process?
maybe we should limit quality value to be maximal 95. from PIL docs (http://www.pythonware.com/library/pil/handbook/format-jpeg.htm)

> The image quality, on a scale from 1 (worst) to 95 (best). The default is 75.
> Values above 95 should be avoided; 100 completely disables the JPEG
> quantization stage.
No setter function is needed here I believe. This is only called from inside qBtSession.
Hoptoad is no more - they got bought by Airbrake and we'd need to set up a new account and probably change the code... and Google Analytics we need a new account and it's duplicative and inferior to Flurry.  So yes, for now we just want to do Flurry.
production and develompent ;)
If you're going to be using attributes a lot in a method, it's probably best to go ahead and assign them to a variable. I think it's ever so slightly more performant, but really I just think it looks better. So

```python
endog = self.endog
nobs = self.nobs
```

Though some people might disagree that it's best practice, we try to stick to this.
not so nice, add some letters

what I like most of the time is to use ``low`` and ``upp`` because they both have 3 letters and we don't use them in other context than limits or bounds
same. do not inherit from TNTaggableEntity
PyYAML optional if not using config?
I think we should remove the `__iadd__` method on `GSObject`.  Python will still support the "+=" operator without it by delegating to `__add__`, and that allows the new GSObject to have the correct type, instead of being e.g. a `Sersic` that's actually an `Add` (which always makes me nervous).  Setting `__class__` makes me even more nervous (I'm not sure if that's even allowed by Python) so if there are any remaining places we do that, we should remove those somehow as well.
Done (and yes thank you for the raise/return error, fixed elsewhere too!)
well, there isn't a fixed release, and I've only got an unofficial fork, and Baardskeerder depends on it for its tests...
Any suggestions?  Or would a more specific grep expression be sufficient?
It's either sarcastic or it's the name of the course.  Kinda like how 
newspaper article titles have quotes around them.

On 9/25/12 10:29 PM, Sef Kloninger wrote:
>
> In main/courses/email_members/tasks.py:
>
> > @@ -170,7 +170,8 @@ def course_email_with_celery(hash_for_msg, to_list,  throttle=False, course_titl
> >      staff_email = 'noreply@class.stanford.edu'
> >      if course_handle:
> >          staff_email = re.sub(r'\--', r'-',course_handle) + '-staff@class.stanford.edu'
> > -    from_addr = course_title + " Staff <%s>" % staff_email
> > +    course_title_no_quotes = re.sub(r'"', '', course_title) # strip out all quotes
> > +    from_addr = '"%s" Course Staff <%s>' % (course_title_no_quotes, staff_email) #make certain that we quote the name part of the email address
>
> Surprised you didn't put the quotes around the whole email title, like 
> "Networking Course Staff" foo@bar <mailto:foo@bar>.
>
> The way you did it, "Networking" Course Staff seems strage, like the 
> name of the course is sarcastic or something. And did you test quotes 
> around only part of the name? I've only seen around the whole name.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/Stanford-Online/class2go/pull/830/files#r1692209>.
>
You must also ensure that `socket` is closed in the end.
il me semble que la SOPA a ete annulee? ils l'ont remise a l'ordre du jour ?
Nonon however peut etre utilise comme ca :)
Same thing here.
I'm confused what was the bug in this test you were fixing?
Whoops. Nice catch, that should not be part of this patch
Any particular reason to not use [override_settings](https://docs.djangoproject.com/en/dev/topics/testing/#django.test.utils.override_settings)?
why do the camelCase "downloadArchiveURL" and non-camelCase "download_archive_url" method different things? should the camelCase not be defined with an alias_methode like everywhere in open_tok_sdk.rb?
@sbrunner I was saying that Ext JS 4 doesn't monkeypatch core JavaScript classes. ```Ext.bind``` is an illustration of that.
Who else would you concur with? ;)
Yep, correct.. just an oversight that happened to work because of the global scope.
No, i'm still playing on blizz servers and I don't gain BOTH stealth AND vanish buff. There is no reapply stealth aura: there is an "Apply" stealth aura.
Should we use the builder pattern here too ? I'd say yes
wait....... according to @garylin these might be needed since they are class methods with no instance. Although have to ask why they are class methods
Generally speaking, a mass reformat of code is not cool.  Too hard to read the diff.  @dgillman can decide how best to proceed.  Thanks, L
Удали, пожалуйста, все такие комментарии.
Там ниже в catch есть ещё один try..catch, в котором закрываются стримы - зачем он?
can we get a mock object for this?
From @FransTwisk: 1%PROMOTERS should be on the same line as initiator, team and coach.
"""This is a Mock, rather than a regular object, because oh-bugimporters calls some methods on the object. Those method calls are not essential."""
It is actually a standard numpy function, just not in 1.3.0. I added the backport recently.

If you have any ideas how to make it more discoverable, that would be great :)
I myself am pro `sklearn.neural`. I certainly won't forget this.
I think we don't need setters here in the public API, but I'll refactor this later.
це єдина доступна версія 2.1
http://packagist.org/packages/symfony/symfony
Empty Spec file again - delete?
OptionParser doesn't support such format, it allows only options. In order not provide something like this --command before 'build' or 'run' commands we need to have them positional.
Change `fontSize value should be a Number.` to `fontSize value is a Number.`
Remove `String currently also work but only if not followed by unit specifier.` that was just a note i was telling you
Remove `BlackBerry ingores any unit specifier after the size value.` as it is not true, currently if the fontSize is a string with a unit specifier the conversion fails, it does not ignore the unit specifier
This sentence doesn't make sense.
You could use mergePTree(tgtTimings, pt);
Ok. Please, think about it and let me (us) know. So, i will change 'my' formats.

I will be travelling (i suppose internet is really bad). You are the master if you need or want to!
And lastly here. This doesn't work anymore because of https://github.com/mozilla/socorro-crashstats/commit/fbf41a38a6d72ae62f44517dbf8fe862280c2e71
The expected format is:

hg:hg.mozilla.org/repo:fname:rev

So I think 2 is actually wrong here anyway, probably want 1, or a guard in place here (I just stole this bit from the PHP code without thinking too much about it).

I think a guard probably makes the most sense, if the count is off we may as well throw it away, it's not going to parse.
Shouldn't this be `raise models.BadStatusCodeError('408')` ?
How am I going to keep my lines under 30 characters??? i kid :)
Ok. Can I remove it then?
What I found is that the hash for a username/password combination as  "user" "password" is the same as, e.g.  "us" "erpassword"  or "userpassword" "" due to the fact that the hash was calculated after concatenating the two strings.
In any case, each hash value in the database is bound to a specific valid user hence this collision cannot be exploited to mount an attack.
The patch prevents the collision to avoid possible confusion.
This is still a bit hackish. The EXEC forces the code above it to be executed before the code below is executed. That way, I can be sure that the $OUTPUT/sfs is already there when I run the ngramGenerator (which reads it into a HashSet to check if an ngram is a SF).
Unfortunately, this also means, that everything that the stuff below EXEC needs has to be re-created (e.g. articles). Maybe there is a better way to do this, but for me, even with running some some jobs twice, this version is much faster than counting all ngrams.
Or you could just check `(= (sort (vals (frequencies (map rank hand)))) [2 3])`.
Please use expand_path from the Post::File mixin. Using Post::File methods when available is preferred.
Or to be more precise the warp function.
I got this code from the Harris test code. Should I change it according to your suggestion?
If we remove the runtime related code, we can remove this as well.
Why did we add this?  We already have LICENSE.md.  Is this for concatenation with .js files?  If so, can we instead split LICENSE.md into LICENSE.md and THIRDPARTY.md, and then use LICENSE.md?

In general, I want the least amount of files as possible in the root directory, and we don't want people asking which copyright file is right.
If it's okay for `value` to be empty, then shouldn't we just equate `undefined` to an empty array?  If it's not okay for `value` to be empty, then we should probably check for that.  Also, minor nit, our error messages normally read `value is required.` but that's no big deal (especially if we remove the error completely).
Double checked with @kring to be sure.  zero is valid and is analogous to a Cartesian3 vector of zero magnitude.
Agreed, I'll get rid of it.  The terrainProvider parameter isn't useful right now, either, because terrain providers aren't really exposed in this branch.
Is it worth maintaining a separate array of glyphs that have only have defined billboards to clean up all these loops?  Performance aside (this is not a performance argument), is doing so cleaner overall?
We need to check whether nativeView is null here.
Can we actually dump the thread param (and change the callers)?
Cap. And wordy. Suggest:


"[DEBUG] Animation guard triggered, exceeded the timeout waiting for view to become ready."
Try it again...forgot to push.
No i ment why do we have two @propertey for KeyboardFocusedProxy. isn't there one already in RootViewController.h ?
"When a dom element is givin this attribute, context menus will be activated when the element is long pressed" -- Can we say "custom context menus"?
Судя по этой схеме JSDoc могут быть любые хэши. Конкретизируй если ты ожидаешь какие-то определенные параметры.
"with the `--vmrun vsphere`"?
ah ok .. i see your point. i can live with adding it to base transport .. or just adding it to the write interface (which would then of course mean we need to add the method to all transports).
We should put this at the beginning of the tests to be able to use it for future testing.
Interesting would this be hardcoded as static type info object?
I suppose it would be dynamic, can you check the resulting asm listing?
with a length
Well, one of the ideas of the "payload-less node" idiom (if we can call it an idiom), is that it is actually parameter-less, and a lot of operations can operate on the node directly, without ever having knowledge of the T type.

For example, "remove" could be implemented outside of DList entirelly, as a non-template. Because of this, DLNode was originally meant to be defined outside of DList (and as such "Node" was way too generic).

By the same token, all insert operations, and future splice operations, could be managed by non-template functions (or a non-template struct): The list would only allocate the nodes with the correct payload type, and then delegate.

--------
Then I realized I wanted this change to be "as low impact as possible", so I moved it back into DList, and changed as little other code as possible.

Since I figured that in this pull I changed the definition of what a "Node" is, the rename helps highlight what changed anyways. The plan is to move it back out again, so I'd rather (if that's OK), just leave it named as DLNode.
There are a few places in MC that assume the format of the 1st 3 values to be these dimensions, so, not adding them {even when they are null} would be bad.
Sure np. Out of interest, are you still using XML Editor?
Is there a good reason for these being module functions as opposed to class methods?
Let's always log at `INFO`, with a supplemental PII for URI. Otherwise we'll seem to drop messages when you're building with `L_P_I`.
Have you tested that your `PasswordRecord.equals` handles all permuations of deleted?  I know I needed to handle this case in forms -- if both were deleted, too much was tested.
whenever you use blank = True also include null = True.

Null pertains to the DB, blank the built in admin and form validations (if I remember correctly)
ok so how about h_freq, l_freq in band_pass and here freq ?
According to .NET framework design guideline, each summary should be a single sentence. The rest should go to remarks if appropriate.
It's the difference between []. and
[
].

The new code does the latter because it's easier to implement.
you should either add the leading ``\`` to have a FQCN or use the short class name relying on the use statements. Currently, this will confuse all IDEs resolving the name in the phpdoc with the same rules than in the code
Думаю здесь необходимы пояснения. Типа it "should not become new root", если я правильно тебя понял
Pushed fix. Would have normally used $.each, but used the hasOwnProperty fix for now to not cause any regressions.
There is a translation [layer](http://sourceware.org/git/?p=glibc.git;a=blob_plain;f=sysdeps/unix/sysv/linux/kernel_termios.h;hb=HEAD)in glibc which uses 32, please fix.
Do the "temp*Cache" maps really need to be ConcurrentHashMaps? It appears as though the key is always a thread ID, and you do not use putIfAbsent (which makes sense because you do not want to incur the overhead of actually creating a Queue or Consumer if it turns out to not be necessary). Basically, if the key is the thread ID, then by definition there can be no concurrent access by different threads, right?
I read your comment; if you intend that setting to null means to remove any existing, you don't have that logic below; it will explicitly set the header to null.
I was thinking about that, but decided no since its harmless. However, having said that it might create a confusion since this converter will not be used so. . .
do you think exception or warn?
Why is this here?? linear??
should be possible to just write ``/cms/simple``
(I don't that our API supports fractions of a second limits and float() allows this. So we should use int() to sanitize the input.)
By the way, I intentional left out mentioning <code>float: left</code> on images. It's needed to force the images to touch each other to overcome their natural inline flow behaviour. I could add a line about this.
Unexpected indent which caused [OMERO-docs-merge-4.4#62](http://hudson.openmicroscopy.org.uk/view/4.4/job/OMERO-docs-merge-4.4/62) to fail
In this case, I think it would be better to move it to another line. Multiple assignments in a single line without very strong reason makes me sad.
Delete some of the `res` data.
Was using ```nil?``` rather than ```blank?``` intentional here?
You are attempting something different from the intended purpose here.  Getting a list of locations for a given user is in another ticket.  This method's signature should be:

public UserLocation getUserLocation(Integer userLocationId);
MSDN says ColorTranslator.FromHtml works with HTML color _names_.  Are you sure it works with # color values, too, including ones that include alpha?  I could be wrong, but I don't think #colors in HTML usually support alpha.
They ought to have doc, but I agree it's probably not high enough priority right now.
To work with a security manager, the service loader and its iterator should be accessed using a privileged action.
Agree, the break should be at the comma, not at the assignment, and the next line should be indented at least as far as the `groups=` before it
lol, this is sorta painful :P
adding dateCreated and dateModified to sessions. this will be handy for doing data normalization later when we get to it.
i saw alans comments, but it is too difficult to let the use specify where they want to insert the column, i cant think of a quick way  to implement that. i dont care if the extra columns are confusing. we have far far more confusing things in the import than the extra columns. i dont really have time to make it  work too closely to a spread sheet, then users will ask for other things ... which they would really enjoy more doing  in a real spread sheet.
Start with upper case
Right now, the only difference between Mac and Windows is which configure script to run.  Maybe it's best to just have one set of instructions instead of two.  What do you think?
So we should implement the delete macro in Feb, right? It may be a good opportunity to quickly review the macros of the previous chapter.
you might `classify` the attribute name too -- that way you could pass things like `"acme_corp/my_plugin"` rather than `"AcmeCorp::MyPlugin"`, but both would still work.
Later on in the code he does ```cartService.save(cart, true)``` which is why it actually gets repriced.
The `build() ` is not necessary as I can see from `BasicWarpTest`m right?
This is more a matter for the main code review, but FWIW I believe our standard on event names follows the JavaScript convention of all lower case names.

Also, callback seems like a weird name for an event, but that's just me.

These comments are general and don't need to be addressed in the context of this PR.
In android, default value is "okid"
No need to pass in {}.
I don't think i can accept this either, we can't accept changes like this :/
np :-)

On 02/18/2012 05:40 PM, ChristophPrybila wrote:
>> +                    registry. The viewed sourcecode is now splitted (semantically) into
>> +                    modelobjects, each modelobject representing a single method within the
>> +                    sourcecode.</emphasis></para>
>> +</example>
>> +<para>Every tool offers different views on data but, as assumed, works on data with
>> +                related structure. Every tool organizes data it is working on in his own<emphasis
>> +                    role="bold">toolenviroment</emphasis>. To participate in crossprogram linking, a
>> +                tool is associated with an appropriate model. How modelobjects of ones tool´s
>> +                associated model are connected with the toolenviroment is in the concern of the tool
>> +                itself. Every tool must be able to open or retrieve modelobjects by their
>> +                identifiers.</para>
>> +<para>To enable distributed linking between semantically related datapoints, which may
>> +                also be viewed by different tools, a central component, called<emphasis role="bold"
>> +>registry</emphasis>, is needed. This registry manages the defined models, the
>> +                association of tools to models and the<emphasis role="bold">mapping</emphasis>
>> +                between modelobjects from different models. This mapping is achieved by<emphasis
> I got it now, sry for the confusion
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/639/files#r464887
This would be a problem with the CSS right?
Lacks description:

> Declaration for phpBB Social Network Profile module
**WHY? WHERE IS 0.7.2.dev1 VESION?**
**Else you could not use ```-``` in UMIL installation.**

Why Is added so SOON the 0.7.1 part of ```$versions```
Update that to Gradle version **1.2** and also re-run:

    $ gradle wrapper
Ищем потомка с определённым номером для узла node.
is it even necessary to take the baton and pass it along anymore since all you are doing is sync calls using wrench?
Can Jake deploy start a node server ?

Also will have to update the config.xml dynamically to add the ip.

Takes us closer to full automation.

~Nukul

From: Jeffrey Heifetz [mailto:notifications@github.com]
Sent: Wednesday, August 15, 2012 02:38 PM
To: blackberry-webworks/BB10-WebWorks-Framework <BB10-WebWorks-Framework@noreply.github.com>
Cc: Nukul Bhasin
Subject: Re: [BB10-WebWorks-Framework] Jeffheifetz/whitelisting rewrite (#127)


In test/functional/automatic/crossOrigin.js:

> -        xhr.open("GET", 'http://www.nba.com/', false);
> -        spyOn(window, "alert");
> -        xhr.send();
> -        expect(window.alert).toHaveBeenCalledWith('Access to "http://www.nba.com/" not allowed');
> +    it("should not allow cross origin xhr for a non-whitelisted domain", function () {
> +        var xhr = new XMLHttpRequest(),
> +            url = "http://www.nba.com/";
> +        //spyOn(console, "error").andCallThrough();
> +        spyOn(xhr, "send").andCallThrough();
> +        xhr.open("GET", url, false);
> +        expect(function () {
> +            xhr.send();
> +        }).toThrow({
> +            message: "NETWORK_ERR: XMLHttpRequest Exception 101"
> +        });
> +        //expect(console.error).toHaveBeenCalledWith('Access to "' + url + '" not allowed');


It is not possible to automate navigation / api tests without hosting a page. We are (rather appropriately) running into Cross Site scripting errors.

Can we host the pages on github, or is there another external server we could use?

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/127/files#r1385473>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
This looks un-used