labofsahil/github-event-dataset-2012 huggingface dataset:
It does not really feels like id should be part of the context. Do you?
Overall, I really like the idea. Could fix those minor things mentioned above?
,    .
07.03.2012 11:57  "ugnich" <
reply@reply.github.com>
:

> -,   ,  : formatTags(rs.getString(4))
> -,          
>  getString  .
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/alexandrdmitrievich/com.juick.http.www/commit/d72d429bb17c9540aefb79e450f70e16ced2b494#commitcomment-1052203
>
checkButton() now takes the clicked block instead of getting Target Block from player-- This fixes a bug where button clicks would sometimes be ignored if clicked through a block like fence
Yeah, it's a mistake, it can be reverted to @SB_APPNAME@
My mistake, looking at the object files it seems final functions that don't override anything indeed don't get a vtbl slot.  The error I found was just a problem c++ non-virtual member functions, which are not currently supported anyway.
Why was `matches` moved into the outer function?
You're right, it should be "error()". I'll change it.
Yes. It provides a `MetadataPopulator` implementation that captures the users credentials and keeps in the Map instance that is backed and persisted by ehcache.
Sure. Snapshots though available through sonatype could also be generated locally. I believe our CI could automatically generate and push the artifacts here as @battags pointed out:
http://developer.jasig.org/projects/cas/cas-server/cas-server/index.html

Not sure exactly how that's done though.
NO!

There /must/ be a way we can tell inline_with_numpy to use mpicc.  Hardcoding this is a recipe for disaster.
Why not change them to integers now?
Avoid combining default constructor parameter values with auxiliary constructors.
please reorder into triangle form ;-)
Wow, very nice job Björn!
I guess you might want to remove `val localGossip` to avoid confusion.
sorry for teasing: it’s not legal Scala :-( The closest you can get is `Σinterval2` (since the raised 2 is not a legal character for an identifier)
Just any node needs to be leaving? Can it be more deterministic?
BTW, the XXX comment was also removed in my branch, not sure why we're seeing it here.
The pulp-cr-2 pull request doesn't look right to me, we might want to drop it and re-create it and see if it gets it right.
browser sniffing? why not just do behavior detection?
What if I create a def uniqueKey by the side like in the class "Node" ?
If you're coming from the GUI, two situations can happen:
- you've used the resume button or the play part button, so the selectedFile should always be between 1 and movieList.Size()
- you've used the default play function, and the selectedFile is still 0 (or the default from the constructor, so now 1).
It's only this second case that needed fixing. 

If coming from other call origins (e.g. remote procedure call / HTTP ??)  your proposal does make a lot of sense. I would just maybe add a debug log line in case selectedFile > size, so we have a trace.
Ah the compiler just reminded me why the call to Open() has to be done in there and on the CVideoDatabase/CMusicDatabase object: CDatabase::Open() is protected and can therefore not be called from outside.
As long as the job is deleted afterwards, and assuming the job is setup in the same way I don't have a problem with new/delete.
Hrm...forgot about .Mid()... I figured the crazy .Right() would fit the rest of the scan/scrape code better :)

Will fix.
this is wrong. For PHPUnit, throwing your own exception will not mark the step as a failure but as an error
> The whole point of the roundabout way of fetching step definitions by running the script with --steps is to make it simple to write mrjob scripts in other languages.

And you can still do that. I didn't remove that ability. It works the same as it always did except some information is slipped in early when possible. `_steps()` even already accounted for it.

Anyway, I went the `MRTestingJob` route.
Missing license header. Check the other files as well
Or, more to the point:

~~~ruby
require 'tire'

Tire.index('articles').delete

class Article
  include Tire::Model::Persistence

  property :title
  property :mydate,     :as => proc { Time.now }
  property :created_at, :default => lambda { Time.now }
end

p "Current date: %s" % [ Time.now ]
sleep 5

Article.create
Article.index.refresh

p "My date:      %s" % [ Article.first.mydate ]
~~~
Please remove verbose, I've deliberately refactored it out. Try updating your packages if you are having problems.
This would be another change that can be integrated at any time.  It would be trivial to pull it onto a branch or directly onto develop.
Too many braces here. Also, you can replace `newTile->image().height()` etc. by just `image.height()` here.
can you keep the pattern of pulling the config data in here like `histogram = config.histogram` or is there a need to change this?
That's odd- `tui_init....`?
Please use `CGRectMake` or C's designated initializer syntax. Initializing structs based on member order is fragile.
Nifty! :+1:
But then the whole auto-scroll wouldn't work if it was within, say a
`TUITableViewCell` and it tried to shift the whole table view.
As above, some documentation here would be great.
@galaxas0 It's not so much a concern over the implementation (for me, at least) as it is over the over-abundance of properties and options in the header.
@galaxas0 ^
Is the version with hyphens the usual one for the English language (I'm not a native speaker, so I don't know).
Yeah, I kept the same check logic, assuming it was done for a reason (this wasn't my code but was added by mikeseven).  The spec IDL defines it as an unsigned long I think, I don't know what that generally translates into in terms of V8 type checking.
Why not base64? Also, I'd rather you leave out binary, that really needs to die.
Yeah, seems like it's always a bug.  I'd say we should throw, but at this point, it's kind of too late to even do anything about it; some internal API must be completely busted.
Please add a relativePath here...

    <relativePath>../pom.xml</relativePath>
Il me semble que c'est deprecated les find_by_... et qu'il faut faire un where(...).first
```callback``` shouldn't be used, use Nette\Callback directly.
Let's log at WARN level so that a user is notified on this incident.  Also, it will be useful for us to diagnose any possible false-positives.
Or, uh, actually, why *did* we FORCECAST it? When I read the call to `PyArray_FromAny` above it seemed like it made sense, but now that I'm looking at the calling code down here I can't tell if it was necessary.
Fair enough. Changing.
Would be nicer to use #[] semantics, but that's already implemented to take the oid. How about ```TypeMap#get```?
Got it. I think we should deprecate `remove_references` with options. Something like this:


```
if ref_names.last.is_a?(Hash)
  ActiveSupport::Deprecation.warn "remove_references with options is deprecated. These options will be discarded" 
  ref_names.pop
end

@base.remove_reference(@table_name, *ref_names)
```

WDYT?
Same `super` comment from previously.
is the value required. I think that if we don't have a value it should be blank.
s/$coll/`coll`/
These three lines of code are equivalent to

    loop(macroImpl.owner.enclClass)

I will leave why as an exercise to the reader. (But please ask if you can't deduce it.)
the advantage is that we could do similar monitoring for review requests as for tickets closed
scala.util.control.NonFatal here too?
Is this the right way around? It looks like the root of the deeper tree is being connected to the root of the shallower tree.
Something you have to be careful of is expressions that may not be zero but have no significance in their evaluation. It's been a while, but if you look at my work in round or int (and commits added around that time by me) you will see me returning None when the answer is calculated without precision. I think I put some notes in the commit messages about that. Have you used gitk to browse the commit log? It's really nice.
It's missing a test for "1e-100", which will fail.
It's sometimes difficult to test equality between unsorted collections of dicts. I've found a workaround for all cases though. fixed.
Use `.is_Mul` and `.is_Pow` here too.
On 17.04.2012 11:04, Christopher Smith wrote:
>> +    def _sympy_matrix(self):
>> +        """Helper function which returns a sympy matrix ``self.matrix``."""
>> +        from sympy.matrices import Matrix
>> +        c = lambda x: x
>> +        if isinstance(self.target, (QuotientModule, SubQuotientModule)):
>> +            c = lambda x: x.data
>> +        return Matrix([[self.ring.to_sympy(y) for y in c(x)] for x in self.matrix]).T
>> +
>> +    def __repr__(self):
>> +       lines = repr(self._sympy_matrix()).split('\n')
>> +       t = " : %s ->  %s" % (self.source, self.target)
>> +       s = ' '*len(t)
>> +       n = len(lines)
>> +       for i in range(n // 2):
>> +           lines[i] += s
>> +       lines[n // 2] += t
>
> is this suppose to be the middle line? Is the input always an even number of lines?
>

Yes this is supposed to be the middle line, or close to it. No it need 
not be an even number. Take a look at the tests, the output this 
generates looks reasonable for various matrix sizes.
hmmm....symbolic `count_ops`?
Not sure about the & redirection.
Fails with old code.
I read about firewall though. That's the only I know.
On Jul 18, 2012 9:33 AM, "k4ml" <
reply@reply.github.com>
wrote:

> > @@ -14,6 +14,8 @@ Environment
> >
> >  Then, install the gems with:
> >
> > +    git clone https://github.com/Sinar/Kratos.git
>
> Because that's what github give me by default. I don't like it too.
> On Jul 18, 2012 9:24 AM, "Yuen-Chi Lian" <
> reply@reply.github.com>
> wrote:
>
> > > @@ -14,6 +14,8 @@ Environment
> > >
> > >  Then, install the gems with:
> > >
> > > +    git clone https://github.com/Sinar/Kratos.git
> >
> > Am a better fan of git:// or ssh:// protocol, given the performance, and
> > you don't have to deal with cert matters. Can I have some links (tried)
> to
> > the actual reason why Git now recommends HTTPs by default?
> >
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/Sinar/Kratos/pull/1/files#r1184783
> >
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Sinar/Kratos/pull/1/files#r1184808
>
Hmm, the point of this is to avoid to always register the listener in boot(). Its not a lot of overhead but is seems cleaner this way. If that is not an issue then the flag can be just dropped, I guess.

The problem is that the value of the flag is not know until the Firewall is instantiated; this happens a few lines above registering it as event listener.

I could move the call to setHasRememberMe() into the listener factory. Around line 148 there is the same type check, so at least there would be only one.
IIrc, I moved it where it is right now, because it felt not right. Setting the flag should probably not be a side-effect of calling a authentication_listener factory.
What about moving this to the note below? I think most people (if not all) using Silex are using the URL generator and can name their routes.
Appears slightly crazy... We should think harder about the whole equals() etc. situation.
Is this import still needed?
I don't object to this, but was under the impression that some drivers use isMaster for the heartbeats and other drivers use another method?
The page title parameter of page_header() is optional. Same thing here.
Nevertheless should also have the type here.
Should be comma at the end of this line, having nothing but `);` on the next line.
This error is triggered when the start parameter for paging is not within the limits. The condition of the if block has changed ;)
phpBB 3.1 does not have ?>
Does $phpbb_root_path have to be appended to all paths here and below?
This isn't the first time I've seen this. Please put this into a function (can be a static method on the manager if you'd like).
Yep, fixed in 01b6e5e2204a2630846d8f6bc9e07f4a8bd8b455
nu înțeleg codul din acest while.

Ca să fie god-mode-on, din ce înțeleg eu din descrierea achievementului trebuie ca:
- să răspundă zilnic corect
- să nu refuze, piardă sau facă draw pe nicio challenge. 

Ar trebui să iasă fără iterații pe partea de challenge, doar cu `filter` și `count`.
> I hope this decision won't be a counter-evidence for using lambdas and std::function in the code.
We will see about that :)
can you use coffee in here?
```coffee
"/event/#{event._id}/edit"
```
X_NEW2 has the proposed implementation.  (Ignore X_NEW.)
"player" should be plural if you're going to correct the typo
The only reason why you cloned this file is a couple occurences of `Log.d(...)` that are not important there.
I suggest you remove these two log-s from the android-specific file and reuse it as others.
+1 In the future we will make sure to only merge code that already has a license header.
Watch your tabs/spacing here, run through jsbeautifier if you need to see where they should be
This is a "magic number" (well, string) in that you use it frequently in many places without explaining it . See "unnamed numerical constants" on the Wiki page for a justification of why not to do this. The UUID ```"68547121-1b70-465c-99ee-c9dfd95e7d34"``` appears on at least 4 lines. 
http://en.wikipedia.org/wiki/Magic_number_(programming)#Unnamed_numerical_constants

Instead, you should abstract it to a shared constant so you only have to update it in one place, and to clarify the functionality of the UUID.

above:
```string DRUG_INVENTORY_UUID = "68547121-1b70-465c-99ee-c9dfd95e7d34";```
here and elsewhere:
DrugInventory result = dao.getDrugInventoryByUuid(DRUG_INVENTORY_UUID);
I was wrong. This is good.
I think you mixed up ``borrow=True`` with ``borrow=False``.
What was your thinking behind calling this a "connection pattern" ?
Yes there are cases where it ends up null. The algorithm is not perfect when it comes to producing a layout Volt will accept. Volt sometimes expects a partition to be replicated more then the requested number of times.

That is why there is a try catch to fall back to the old strategy.
xoops_trust_path/uploads/xupdate/* が削除されたのはなんでだろう。
一見このコミットと関連なさそうですが…。
*never* put { on a separate line in JS, it may mean something else than you think!
This function will return a different string every time.
It returns a file path, not a file name.
Use os.path.join if this is really a file path, and not part of URL? If this is URL, don't call it "file name".
This whole "if" doesn't make sense now.
Cool, thnx, I'll flow this from now on.
you should add spaces around the ``=`` in the signature (same for all methods)
This would need to be `[ elem ]` instead of `elems`, but I'm pretty sure you can drastically simplify here anyway.
I think this was only necessary for an earlier iteration; I just removed it and all tests still pass.
Would it make sense to have cast operators to bytea?  

Or is the intent here that this is solely internal, in which case perhaps a name like "madlib.__internal_binary_state" would be preferable?
If the two classification resutls differ, there exists a bug.
Heyo, expecation_units is gone. It was ugly anyway.
The playdoh docs are interesting in that every time I skim them looking for one thing, I don't find it. But I do find something else. Turns out there's a better way to do INSTALLED_APPS: http://playdoh.readthedocs.org/en/latest/userguide/settings.html
I am +/-0 on this, but the original download should perhaps also be kotnet.org and the mirror gnu.org. But perhaps gnu.org is faster/more reliable. Just wanted to know if the url/mirror are assigned with intention.
Because `some` stops the loop on the first `true` value returned during iterations.
But I forgot the `return true` 2 lines below :-D

The advantage is to stop the loop as soon as the header is found.
\Ahaproxy in the regex
I added it. As I said no one should see this file ever beside developers
annotation.endpoint is not a thrift Endpoint
I'm not a fan of the fact that `_commit()` is being called while in the middle of a call to `_commit()`. Seems very prone to subtle bugs and the infinite looping you appear to have encountered. Seems like the reason for the commit call is due to the tracking of `listed_`; perhaps that could be revamped.

I'd also recommend (and this may even help solve the issue) just overriding `_commit()` here, instead of adding a hook.
I'm ok with failed imports breaking lots of things very loudly :wink: That said, this should be fine.
yeah, I can just match the two wiki locations, not a big deal.
change 'those allowed' to 'approved wiki editors'
Oh, sure. I don't, actually, feel strongly about this at all, can trivially change it (or you can).
This and the below can be more concisely written in the form `kwargs.get('start', 1)`
Should be `dea_check.py` not `dpe_check.py`.
Should probably just raise an exception if the metric type changes
Is there any way to do what this file does, only with ant?  I'm not a huge fan of ant, but it does have the advantage of working on popular OS's that do not have /bin/sh preinstalled (e.g. Windows)
Let's please do this lazily, not in a static initializer.
^^ therefore `s/Entity/Record` above...
I'm not sure of the sequence of events here... when does this happen?  I was thinking _handleFilter() gets called on every keystroke, and that method always ensures currentPlugin is set to a plugin that matches for the current query.
Give it a shot again. I tried to move it closer to the edge so it'd be easier to drag.
Talked to Garth about this on IRC--the other ones should be namespaced. I'll make the change and push it with my other fixes.
interaktiver Wegweiser
interaktive Anleitung
Do we really want to hard code these (often treehugger specific) names?
We should probably reset the size of each `$connectionAddresses` `SplFixedArray`
for future reference, if you use 
   
    with os.fdopen(fd, 'w')

you don't have to close the file descriptor after
This is in the report config modal which currently is just handled in this ad hoc form processing code.  We could return a JSON error object, but I have no clue how to integrate it into the modal.  What I'd like to do is just make the add/edit saved report be a separate page using a django form and have the validation and error messages be displayed there, but that would take a little more time than this.
Need to add here:

keys.remove(this);

Fixes the problem I was seeing. The boss executor shutdown is guarded by a two-minute timeout or until all selector keys are removed (and they weren't getting removed).
AFAIK, copy is PostgreSQL/psql only, but INSERT is plain SQL.
Thanks for the hint @elemoine. I gave it a try and it works. Changed it in eec5231.
So it doesn't need to appear in both locations? rugwidth will be passed to GeomRug$draw in the triple-dots, and there is no need for a default?  I was going off how geom_boxplot was written.
It would be preferable if you could use tabs when you modify this project.
Are they package public on purpose ? Shouldn't they be clearly public or private ?
Added fields.DateTimeField stub in fields.py.
This works? Because `Comment` is defined bellow?
I mean the log about regeneration.
Yes. We don't append it at all it's mainly used to load it from the system. It's never put into the DOM and doesn't need to be.
Not sure that we need that extra submit class? submit_row.submit seems a bit weird...
same.. update the other comments also :)
Oh, ok :) Will do!
imho, lint shall not throw. can this function have second parameter [e.g. `checkOfCarriageReturnIsPresent(string, throwOnError)`] to just output the warning.
So wouldn't `while (parent && parent.clientHeight == parent.scrollHeight)` be appropriate?
Hi  Max,
can you let the vendor to "pitpit" here
Spaces please, `for (i = 0; whitelist[...]`
How do you know this doesn't split a word in the middle.  Maybe I'm reading this wrong, but indexing into block text is a character index, right?
To have a visual feedback in IDE, that for change detection this field should not be used.

Change detection based on milliseconds are bad. Thats why we need to sleep in UTs, but also think concurrent config changes. Using millisecond based change detection omits to "detect" changes happened in same moment and/or concurrently.
add one more line above
Whoops! I have 404 and 500 templates in the pyvideo repository. I'll pull them into richard tonight. Thanks for pointing this out!
'not uncommon' is a double negative. It is better to say 'common'.
??
Write a specific README file.
I guess here you mean that:
min( len( cmd ), 512 )
Not sure this should be done in general--could you do a second dispatch for `hdfsWrite` instead?
@lzap fixed in 0dd0820
Can we instead of this change batch_add_columns, which would accept eg. 
batch_add_columns(self.printer, {'id': _("ID"), {'name: _("Name"))
?
No way, I think you should just ifdef this logic and write different code in each case. No reflection please.
Put the comment on top
nit: As discussed earlier, this could be <header><h1></h1></header> for better semantics
Do we want an implicit transform? I guess if someone wants b then they want l as well. How does work this with large lists? So I do c.galactic on millions of objects and then it goes away and makes another million with galactic coordinates? And stores them?
Just something to consider; maybe I'll add an issue for it.  For the purposes of this PR this implementation is perfectly fine.  If/when we include concurrent.futures, we can go back to this and swap this out for it.
How should it look?

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Mon, Nov 19, 2012 at 2:19 PM, Luke Steensen <notifications@github.com>wrote:

> In app/models/user.rb:
>
> > +  has_many :followers, through: :reverse_relationships, source: :follower
> > +
> > +  has_many :bookmarks
> > +  has_many :bookmarked_videos, :through => :bookmarks, :source => :video
> > +
> > +
> > +  def following?(other_user)
> > +    relationships.find_by_followed_id(other_user.id
> )
> > +  end
> > +
> > +  def follow!(other_user)
> > +    relationships.create!(followed_id: other_user.id)
> > +  end
> > +
> > +  def unfollow!(other_user)
> > +    relationships.find_by_followed_id(other_user.id).destroy
>
> This is not a very safe method.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/11/files#r2172140>.
>
>
I just took a quick look over this, is this the only changed translation string or did I miss one?
1) QString::size() returns an int, not an unsigned int: http://qt-project.org/doc/qt-4.8/qstring.html#size
2) IMO it is more readable this way. I don't like complex expressions in the third clause of a for
The replacement for this is much easier to read.  Nicely done.
I'm not getting it. The querystarts listener empties the vector layer, so how can the queryresults listener actually see features in the layer?
I really dislike not having real name nor contact info in copyright notices. Not sure about the legality of that, but I don't feel comfortable with merging this like that.

Since @embolalia is the maintainer of this fork, I'll leave this choice to him.
I may be missing somthing, but shouldn't there also be a setObject() signature?
Love what you did here.
Must be a Git issue.  The method has content locally.  That's wild.
I like this idea, but unfortunately you have not quite achieved functional signature parity between the two versions. If there is no `readdir_r`, maybe we should do something like:

```c
GIT_INLINE(int) p_readdir_r(DIR *dirp, struct dirent *entry, struct direct **result)
{
    GIT_UNUSED(entry);
    *result = readdir(dirp);
    return 0;
}
```

Then you don't need to change the places that use the `p_readdir_r` macro and keeps all the code simpler.
You should update the docstring on this function to reflect the changed behavior.
Another fear I have is lag: This blocks loading, so if the site hosting this is down or slow, the response will be blocked until that site responds.
nit-pick, you might want to use ``'<img src="{url}" {attrs}>...'.format(url=url, attrs=attrs)`` rather than old-style interpolation so you don't have to repeat yourself.
Honestly, right now I can't remember why I did this originally in other js files here. I can't think of a reason other than style/preference of having all the actual code below in the prototype object. But at this point it's just about being consistent with other files.
You should add a comment here about how you're doing a .update() to avoid triggering the post_save signal which triggers indexing.
I ought to consider calling this `stop` instead of the more obscure `signal_quit`
This is ok, but I think might be easier to read with a helper function and not as a many "exits". For example:


    delete_cookbook_version(#chef_cookbook_version{id=CookbookVersionId,
                                                   org_id=OrgId,
                                                   name=Name}) ->
        case delete_cookbook_version_checksums(OrgId, CookbookVersionId) of
            {ok, DeletedChecksums} ->
                CookbookDelete = case delete_object(delete_cookbook_version_by_id, CookbookVersionId) of
                                     {ok, 1} ->
                                         case delete_cookbook_if_last(OrgId, Name) of
                                             {ok, 0} -> false;
                                             {ok, 1} -> true;
                                             Error = {error, _} -> Error
                                         end;
                                     {error, Reason} ->
                                         {error, Reason}
                                 end,
                dcv_result_or_error(CookbookDelete, DeletedChecksums);
            {error, Reason} ->
                {error, Reason}
        end.
    
    dcv_result_or_error({error, Reason}, _) ->
        {error, Reason};
    dcv_result_or_error(CookbookDelete, DeletedChecksums) ->
        #chef_db_cb_version_delete{deleted_checksums = DeletedChecksums,
                                   cookbook_delete = CookbookDelete}.
It would do, though I'd think raising a more useful exception would be a better idea?

Is there a usecase for running the bot without any plugins?
In order to prevent someone passes {{ theme:lang lang="" }}.
Where is this guy going? Is he on holiday?!
Something more is needed here to make the test set `request.protocol` properly. Not sure what though.
This needs to be VLE8/16/32, related to issue #471.
maybe give foo a meaningful name like "receivedSignal"
I think it's better to keep this behavior, because even if Propel gets this feature, it will be only available for Propel 1.6.8 and upper.
may be it's worth adding a local variable `$parameterBag` as it is used quite a lot in the method
You should remove one blank line here.
What about `return`ing on first match - this would also remove the bitwise operator.
you could simplify this by using the ``update`` and the ``insert`` method of the DBAL connection
https://github.com/symfony/symfony/pull/3378/files#L11R23 here :)
I would not remove the PHP 5.3.2 compat layer yet as many people are still using it (even if there are known issues)
_PULL?
Statt der Links zum Login und Signup wird hier nun das Login-Form gerendert.
Not sure what you mean here. Can you provide an example?
Oops... I just realized this - let's switch every `messages = new Messages()`, by `messages.clear()`

The reason is that with `new Messages()` the actual warnings/errors get printed to STDOUT too. The mock `messages` object we created at the beginning of the file is set up differently and will help reduce the noise in STDOUT when running test/run.sh.
shouldn't really be here, should it?
why not set it to disabled instead of commenting the setting ? As mentioned by André earlier, making a setting optional forces us to check if it exists...
This is wrong ...
According to http://stackoverflow.com/questions/3936190/c-python-ctypes-shared-object-introspection-libraries-techniques the information doesn't exist in the object file, which ctypes works on.

The other option is to parse the header file. To do that in a generic way, you'll probably end up implementing a small C compiler. It would have to be custom parsing for libspotify, where the targeted header file is known.

I don't know if that's worth it, as it sounds fragile and is less obvious how stuff works. libspotify has about 18 enums, and I've already implemented 11 of them, so this approach won't grow out of hand.
We had to make all of them self-contained so there are no more, `menus.css` or `core.css`
So we had to append all the needed extra rules for getting work the button styles that the prompt needs (not all the button styles, only 3)
You can ask to @fabi1cazenave about it.
Is it really browserBrandShortName instead of brandShortName?
We are returning two contacts because the enrichedContact is readonly and we don't want when a Contact is edited to save FB data on the mozContacts DB.
Break this line in multiples lines
I'd still like to use the button's `disabled` property.
nit: remove this comment. WifiManager.init means as much as init Wifi Manager.
st -> setTime
Then it's not one line fix :smile: 
I am O.K. to do those.
I don't know anything about the status line, or how fullscreen is implemented, so I don't know how to review this line.

Is the query selector an old way of doing it? Does it not work anymore?

I'm actually sort of surprised that the system app can use document.mozFullScreen to detech whether a child app is in fullscreen mode...
The most performant and elegant solution would be to move the ID to the ```firstElementChild```.
How about also use "collapsed" instead of removing it?
I think we still need the debug menu for email backend.
We can just revert it by removing the "collapsed" class.
But I didn't find anyone calls the function? did I miss it?
Ok, no cheating no glory.

Looking good to me then, was my only question.
Also, I wonder if we can keep the fields from looking "invalid" when they're blank, and only showing up that way if you've entered something that makes no sense.
maybe even nicer / more Qt like to call this method 'void enableEllipsoidalMode(bool flag) ?
@filipewl, modified.
`tags`

``tags``
```scala
> def time(reps : Int) = {
     |   val start = System.currentTimeMillis
     |   (0 until reps).foreach  { long2Bytes(_) }
     |   println((System.currentTimeMillis - start)/(reps.toDouble))
     |   val start2 = System.currentTimeMillis
     |   (0 until reps).foreach  { long2StrBytes(_) }
     |   println((System.currentTimeMillis - start2)/(reps.toDouble))
     | }
```

```
scala> time(10000000)
5.05E-5
3.052E-4
```

Looks like .toString is about 6x slower way to serialize. That said, when you combine with the hyperloglog part, I'd be surprised if it adds up to anything, since the hashing and the updating the memory of the HLL are the expensive parts.

If you want to speed this up, find a 128-bit murmur hash in scala we can add to Algebird (to keep dependencies light). Right now we are doing md5, which is about 2-3x slower than murmur from what I've heard.
All of these event attachments are a little "dangerous" in that that does not check to see if `link.onclick` is already set. 

To ensure that we don't override other developers' functionality, we should check for and execute the original `onclick` (see http://stackoverflow.com/questions/891989/javascript-adding-an-onclick-handler-without-overwriting-the-existing-one) __OR__ by using the DOM event manger (`addEventListener`/`attachEvent`)
How could it break String::Quote? It's a special 'backup/include/functions.ycp' file where it's placed, moreover it's 'quote' vs 'Quote'.

The special case is 'df -P $dir' in the same file, you won't believe me but single-quoting doesn't work when used from YCP even if the same works on commandline.

Function quote follows the same crazy rules as Quote so even if I don't like how it "works", I'd rather keep it this way.
In Ruby, whatever the last statement returns is the return value of the method. Therefore, every method returns something. Therefore, please document what each of these methods returns.
These tests look like they're basically copy-pasted from each other. Why not reduce this duplication? That way, if you write one test, you can automatically run it on all the DBs.
This will be eliminated when app-manager is merged in.
How about renaming it to just `longPress` for simplicity?
I tried vorbisenc looks like flvmuxer is not compatible with vorbisenc. I decided to revert it back to faac, we'll have to live with this since it seems to be the only option.
Either case was resulting in unhelpful output, so I left the comments as notes to myself. Both sections are being replaced in the next two tasks (adding those test pieces in) anyway.
I'll refactor
Why not use SENSOR_DELAY_GAME as default? Because our engine is used for game development.
@dualface A static is never completely deleted.  It is preallocated storage, in this case of sizeof(CCDisplayLinkDirector *); just a pointer.
(bool) isn't even needed, if you do `a && b` you already get a boolean back.
no need to comment the old code. simply remove it
You mean in the docblock?
Specify length by second argument
Тогда чел в форме напишет "super_amazig_gist" или что-то в этом роде. Нужно чтобу рандомные private_key были
OptionParser accepts mixing Unix and Gnu styles command line options:
Unix:

    -f value
    -fvalue

Gnu:

    --format value
    --format=value

Not accepts:
    
    -f=value
ah, zone is now inherited from the <body> so I can remove that property
Whats wrong with document.body ?
Added more spam
If ensureDirectoryWriteable(File) signals failure by one method (Exception), then you could clean this up a little:

try {
    logDir = ensureDirectoryWriteable(new File(directory));
} catch(Exception e) {
    log.warn("Failed to get writeable directory: "+directory, e);
    continue;
}
// uf block at 408 can be removed.
After reading it even further I think you could make just return array of dir paths and file paths without creating these objects.
This is a pretty brittle selector, what about slapping ID or class on the p element in case it ever moves in the DOM?
uh oh, houston.  is that the introduction of a global variable?  we need a `var` here.
@jeffweiss I don't believe that we will never get an architecture. I could add 'unknown' or default to RbConfig::CONFIG['host_cpu'] as is done in <http://rubydoc.info/github/ffi/ffi/master/FFI/Platform>
I think we should stick with american spellings anyway. Giving these kinds of synonyms will probably just lead to confusion.
Yah, doh, that makes a lot more sense. I think the original was `class_eval`ed so I just copied it over without considering simplifications.
Good catch! Is it ok to rebase this branch or I have to create new pull request?
Added fix in commit c46ca1f
You should use single quotes in this file (http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards#CodingStandards-StringLiteralsContainingApostrophes)
No, actually nearly all constructors throughout the frameowrk do not return anything. No "@Return" is specified.
serial_string2 is deleted in stead of commented out
We should defend against it even if theoretically it can never be null.
Ok, changed this. But it does mean that we could get into negative when you start unlisting packages
Mrm. This is actually a darn good idea. Couldn't come up with a better workaround that having the user add `<prefix>/lib/gcc` to the `LIBRARY_PATH` when a C compiler is needed for the linking step---but this is a pretty slick.

I might add this the default environment set by `ENV.fortran.`
in Meteor, you don't reference external javascript in html at all, instead you use "smart packages".

in the definition of such a package, you configure whether this package should be made available on the client or server or both.

package definition for jquery looks like this:

Package.describe({
  summary: "Manipulate the DOM using CSS selectors"
});

Package.on_use(function (api) {
  api.add_files('jquery.js', 'client');
});
Years ago, but you don't need the `type` either, since it's defaulted to JS.
perlican → pelican
see https://github.com/dimagi/dimagi-utils/blob/bb6dd8e68094764f9accc795eba341c2200c04b7/dimagi/utils/indicators.py#L30
you have an extra line here
I was just talking about what you put as previous exception here. But anyway, throwing the common exception is a better idea IMO (or making the MappingException extend the common one) so that some code can catch the common one if it wants to work for any Doctrine project
We need to swap these, the API is `assert_equal(expected, actual)`. :)
There is no real use into adding a copyright header to an empty file,
since there is nothing to copyright anyway.

Git will ignore empty directories, but will add empty files as usual.
Also 
~~~~
' '.join(['F77="%s"' %  mpif77, 'NOOPT="%s"' % noopt', 'CCFLAGS="-O3"'])
Oups =]
I think this could do with some comments
Did you file a bug to clean up the `edit_profile`-specific CSS and move it to `users.css`? It's fine to call that out of scope of this bug, but we need a follow-up on file, in that case.
Ok, roughly 1 and a half. ;-)
Remove this debug printf.
Since this was only a placeholder not pointing to a "real" test, I removed it.
I'm missing the associated domains
This name seems a little cryptic for people who don't know what it means. Maybe we can use something like "generic item imported from RIS" or "RIS generic item"? But maybe those would be even more confusing, since they seem like real tags. Also, you might want to push

```javascript
{"name":"generic item imported from RIS", "type":1}
```

which should make the tag an automatic tag, so that it doesn't show up in the tag selector when automatic tags are disabled.
It would be nice if you'd test this, I put a check in so that it doesn't yell at me every time about there not being an AE checkbox :P
Remove this auto-fix
This will delete cache entry if no jobs running any more.
Ah. I didn't realize there was a means of using non ObjectId ids. Check out the commit I just added. It falls back to === if the id does not have an equals method.  


On Tuesday, June 19, 2012 at 5:15 PM, Aaron Heckmann wrote:

> > @@ -1251,7 +1251,7 @@ Document.prototype.inspect = function (options) {
> > */
> > 
> > Document.prototype.equals = function (doc) {
> > - return this.get('_id') === doc.get('_id');
> > + return this.get('_id').equals(doc.get('_id'));
> > 
> 
> 
> what about string/number etc _ids? this will fail.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/LearnBoost/mongoose/pull/974/files#r1014010
> 
>
Many of the config variables in our config are outdated and probably aren't used, no one has bothered to go through the codebase and find out which ones. I'll add a list of the ones you don't have in your list and you can take a look.
какими должны быть функции в заголовках?
I don't like the new Ruby 1.9 syntax of hashes using colons instead of hash rockets, and to be honest I would probably prefer that they be hashrocketed so that they are at least consistent with the rest of the application. Is that too nitpicky?
Unnecessary. Channels are unregistered on disable. Same reason why we don't unregister our events.
Yay tests! Doing it this way, though, requires that Vidscraper actually go to YouTube and grab some data, and you aren't actually looking at the data.  Can you test this by just making a plain `Video` instance?
Yeah... we're not actually going to do this as a daemon for this release though--flushing the queue can only be accomplished manually, so the user can deal with those errors for now.
I don't think that we need to check for JRuby because therubyracer won't be added to Gemfile if JRuby is used at the time when Rails app is generated.
fyi, if the UI ever needs a whole bunch of static files, the URL cannot exceed 8k as that is the default size of a buffer in nginx and the url gets stored in 1 buffer.
It feels like there should be a third function "getAllAllowed" that returns all of the roles (direct and indirect) that a user has.
This is the response I'm getting on the PR branch, after having cleared the index and all Cassandra data before starting it up:

```
{
    "total": 4,
    "results": [
        {
            "title": "Math 102",
            "joinable": "yes",
            "tenantAlias": "cambridge",
            "visibility": "public",
            "resourceType": "group",
            "extra": null,
            "id": "g:cambridge:math102"
        },
        {
            "resourceSubType": "link",
            "title": "Sakai",
            "tenantAlias": "cambridge",
            "visibility": "public",
            "resourceType": "content",
            "extra": null,
            "id": "c:cambridge:TTwTeubxOM"
        },
        {
            "resourceSubType": "link",
            "title": "Sakai",
            "tenantAlias": "cambridge",
            "visibility": "public",
            "resourceType": "content",
            "extra": null,
            "id": "c:cambridge:eVX6aKjvO5"
        },
        {
            "id": "u:cambridge:ePs_9KbRqf",
            "tenantAlias": "cambridge",
            "title": "Nicolaas Matthijs",
            "visibility": "public"
        }
    ]
}
```
I agree. Would something like ``loadFirstTime()`` better express the intent?

```scala
final def loadFirstTime(): Unit = project.doWithPresentationCompiler { compiler =>
  compiler.askToDoFirst(this)
  reload()
}

final def reload(): Unit = project.doWithPresentationCompiler { _.askReload(this, getContents) }
```
And I'll have a nice comment on the difference between ``reload`` and ``loadFirstTime``
I think it shouldn't affect the Thrift interface since `val` will never be `null` when using the Thrift interface? Or am I getting something wrong? If you can find a case where this change breaks stuff, I'm happy to look into it :)
Creating a session on behalf of the application when the application didn't explicitly ask for one is generally considered rude.  It has several side effects: (a) the application now has to worry about state management where previously it didn't, and (b) requests from the client to the server are now serialized, hampering performance.  Using a random GUID gives much of the same benefit without these drawbacks.

There is a downside: you're still open to XSRF attacks where your site is target.domain.com and I am running code under evil.domain.com.  But I think we're OK with this, since any mission-critical site will most certainly not allow potentially malicious code to run under the same domain.  Though unfortunately I keep needing to remind the Windows team of this fact.. :|

-----Original Message-----
From: Luan Nguyen 
Sent: Tuesday, May 15, 2012 6:13 AM
To: Andrew Arnott
Cc: Levi Broderick
Subject: Re: [dotnetopenid] Add protection against XSRF attacks (#145)

Levi recommends creating a new Guid instead of using the Asp.net session id.

Levi can explain the reason.



On May 15, 2012, at 6:09 AM, "Andrew Arnott" <reply@reply.github.com> wrote:

>> @@ -148,6 +159,20 @@ public OpenAuthSecurityManager(HttpContextBase requestContext)
>>            // attach the provider parameter so that we know which provider initiated 
>>            // the login when user is redirected back to this page
>>            uri = uri.AttachQueryStringParameter(ProviderQueryStringName, this.authenticationProvider.ProviderName);
>> +
>> +            // Guard against XSRF attack by injecting session id into the redirect url and response cookie.
>> +            // Upon returning from the external provider, we'll compare the session id value in the query 
>> +            // string and the cookie. If they don't match, we'll reject the request.
>> +            string sessionId = Guid.NewGuid().ToString();
>> +            uri = uri.AttachQueryStringParameter(SessionIdQueryStringName, sessionId);
>> +
>> +            var xsrfCookie = new HttpCookie(SessionIdCookieName, sessionId);
>> +            if (FormsAuthentication.RequireSSL) {
>> +                xsrfCookie.Secure = true;
>> +            }
>> +            this.requestContext.Response.Cookies.Add(xsrfCookie);
> 
> Does this really require a new GUID and cookie?  ASP.NET has already assigned a session cookie to the client, hasn't it?
> 
> For example, DotNetOpenAuth's OAuth 2 client class uses the preassigned session ID for this exact same XSRF protection.  [Check it out](https://github.com/AArnott/dotnetopenid/blob/master/src/DotNetOpenAuth.OAuth2.Client/OAuth2/WebServerClient.cs#L106)
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AArnott/dotnetopenid/pull/145/files#r823146
> 
> 
>
Why switching away from using CM's conventions?
trailing whitespace

there are some others on the file
It should, but even if it doesn't - that's another issue. `word_wrap()` replaces \r\n, \r with \n anyway.
Тем, что так будут сравниваться указатели на объекты, а не сами объекты.

См.: http://stackoverflow.com/questions/6969115/ios-how-to-compare-2-nsstrings
Да, вы правы, Я просто добавил вывод каждой ячейки после if, чтобы видеть какие числа там появлялись и тогда програма крашится.
почему максимальная длина 20?
No. The definition of those functions might change, which is why you should check for them before comparing sector types. Maybe we'll have an effect somehow that turns a room into watery or something.
ah I see, you mean something like following?
```lua
local ffi = require("ffi")
ffi.cdef[[
typedef unsigned short mode_t;
int mkfifo(const char *pathname, mode_t mode);
]]
ffi.C.mkfifo("emu_event", 0x1b0)
```
Whoops, my bad!  

I'll change the :write test back and add documentation for :read.
Ok, forget about it. Reference / pointer error.
is it really worth adding such a complexity to Epochs ? Dynamic cropping means that epochs.times need to be changed, we need to change tmin and tmax that have different values if cropped or not but we still need them to load from raw and apply baseline correction. It seems to me too likely to create bugs but maybe I need more self confidence :)

cc @joewalter @mluessi
Yes, but not your tests. I'm half right and half wrong because it's more complicated. The tests you wrote use `self.get_s()` which returns an S that has called `indexes` and `doctypes` which set the values to lists. If the S hasn't called those, then it uses the defaults which are strings.

So the defaults are wrong.

Sorry about that. You should leave your code as is.
Violation of DRY principle since this is in background.js as well. I would put the helper functions inside a module that can be used here and in background.js.
This probably shouldn't be here?
you can also use ``phpclass``, ``phpmethod`` and ``phpfunction`` too (linking to the PHP documentation)
I don't think the french word for `order` is `Order`...
``HttpKernel`` to match its naming. and this should be a link to the component doc, no ?
Is there an Issue filed for this?  I'd love to link it, if possible.
Here and below, import at the top (`from factor_ import factorint, trailing, totient`). It's only a last restort that we import in the function.
Потому что в контексте ЖЖ пост - event
Разрываешь определение services от точки использования, лучше так не делать. Иными словами, перенеси ближе к `if`.
Tuve problemas con los indices
Gracias, no estaba seguro. ¿Querés que lo arregle o es aceptable así?
mind resetting the file if there are no changes here?
Add constructors to take a reader and string.
Looks like github raw strips it, damn.
Take the changes to this file out. I'm starting to look at reducing shortcuts.
I wish I could, unfortunately Maven has no profile inheritance. I know this is unintuitive and contrary to widespread belief but the truth is here: http://www.dashbay.com/2011/03/maven-profile-inheritance/

But yes, we do partially achieve that by inheriting parent's plugin management section, which is augmented when the 'distribution' profile becomes active. But you still need to redeclare the plugin in the child otherwise plugin config inheritance is not triggered. Messy, but standard maven practice.
note that this is not new, but inherited logic.
Normally the operation should succeed, I think it makes sense to signal that in the logs.