labofsahil/github-event-dataset-2012 huggingface dataset:
@benhutton That's what I expected. :)

So page names can have special characters in them. We used "underscored_resource_name" because it contains a "sanitized" name. Looks like sanitized_name disappeared in this fix: #1461. Too bad... :-/
I wanted to limit the patch to this single method and the log.failedClearingJdbcCacheStore(ex) only accepts SQLExceptions. But there is always the chance for a RuntimeException, which should not be ignored when there is the need to release locks.
do we really need to differentiate between longs/ints ?
Don't be so fixated on doing whatever it takes to make a test pass.  This can lead to incorrect understanding of why things are done in the first place; keep in mind that a test may be incorrect as well.

This is what I gather from this case.

* The understanding of what activation is, seems wrong.  As such, the test is testing for an activation count increasing when an entry is removed.  This is not correct.
* I am fine with counters being stored in the eviction listener as you have done, but line 1731, a removal, should *not* increment this counter.
* As such, line 1731 should also not invoke a method called `onEntryActivated()`, which is confusing, leading to code smell - since the entry is not really activated at all.
* Maybe just add another method on the eviction listener called `removeEntryFromCacheStore()`, which does exactly what it says, and doesn't update any counters.
Yes -- I don't think we should be duplicating this information, and the developer docs were recently reorganized to (hopefully) make this easier to find.  @pierre-haessig : would you mind looking at the new developer docs (on matplotlib.org) and letting me know if you think things are more obvious?
What's the difference between this ```image_dpi``` and ```self.image_dpi```?
bad binary operator break here
Are there cases where `getTouchClientXY` receives an `Event` object instead of a touch object? Reading your code I don't see such cases.
If anything, you shouldn't nest `<h*>` tags in `<a>` tags.

BUT...the `<a>` tags aren't necessary.  In-page anchors work with `id` attributes as well!  So, rather than doing:

````
<h3><a name="new_reservation">Making a New Reservation</a></h3>
````

You can do:
````
<h3 id="new_reservation">Making a New Reservation</h3>
````

_Side note: Use dashes instead of underscores for your `#ids`.  Dashes look cleaner in URLs._
Tabbed in 1 too far.
nevermind I see the multiple arity below. if you provide only 5 arguments you're making a neighbor value for a single pixel. If you provide 10, the second form handles the avg, min, etc.
What does PrintDupSerializer:forma.schema.FireValue, etc. do for us? Why are only some of our specialized structs included here, and not DataChunk?
Yes, this is EMI-only code. The code path for GRIM is just _posX = _x; _posY = _y;
@dooremont make sure the indentation is correct.
@jsloane @bp323 For sure, I updated the code accordingly - also did a rebase to keep the history clean.
I did use the languagePacks property to check whether a language exists in tinyMCE.
Isn't that changing the test semantics?
This shouldn't use the $_GET global, because it makes testing/encapsulation etc harder. Use `$gridField->getForm()->getController()->getRequest()`. Yes, its a convoluted path, but technically more correct than `Controller::curr()`.

Depending where this component is used, the "ParentID" parameter name might conflict with form submissions. For example, you might want to show a file listing on an "edit page" view, where the "ParentID" parameter denotes a place in the `SiteTree` hierarchy, but the file listing parent points to a `Folder` record. Please add `setParameterName` accessors to override this naming convention.
There's a short syntax for that, which avoids hardcoding the API URL as well as the version - at the moment, we'd need to update this every time a new major SilverStripe version is released. See http://doc.silverstripe.org/framework/en/trunk/misc/ss-markdown
generally we like to put parentheses around method calls, unless they are declarative DSL-style calls like `attr_accessor` and such.
Are now.
+1 on a standard log format. Wrapping the low level logging module would be beneficial.
This is my first pull request so i do not know what the normal process is ? i do not understand your comment/note ??
in that case you could replace this line by

    $coptions['modulemode'] = 1;
why underscore instead of dot??
do you mean like this?

```diff
diff --git a/lib/show_for/content.rb b/lib/show_for/content.rb
index 4819292..6c44604 100644
--- a/lib/show_for/content.rb
+++ b/lib/show_for/content.rb
@@ -44,7 +44,7 @@ module ShowFor
     end
 
     def translate_blank_html
-      I18n.t(:'show_for.blank_html', :default => translate_blank_text)
+      template.t(:'show_for.blank_html', :default => translate_blank_text)
     end
 
     def translate_blank_text
@@ -52,7 +52,7 @@ module ShowFor
     end
 
     def blank_value(options)
-      options.delete(:if_blank) || translate_blank_html.html_safe
+      options.delete(:if_blank) || translate_blank_html
     end
   end
 end

```
Are you sure the parameter here is a `kind` and not a `relpath`? You are passing the "kind" to the "relpath" parameter of the InputKind constructor.

Nit: Document.
Checkout -> Checking out
This could be link. Before `trans` should be space.

Otherwise I am OK with design.
You do not have to use both type and action. You could have type `new_post` and then you will know that updates handler will be called only for new posts.
Don't hard-code URLs. You should dynamically construct it with `url` tag.
`data` argument to `createDOM` is not needed.
Our user document does not have `name`. Just `first_name` and `last_name`.
Empty string is a constant string, no? ;-) So it should be `''`.
I can't find any style for on link hover yet?
This code is similar to what I have in mind, but needs more improvement:
 * you want this code to be fast as it is called on every request, iterating over all backends in not a good idea, this is why we store backend in the session
 * so in the view above, you should mingle with session, not here, so in the view you trick the system to believe it is on that location you are mocking, and then leave this code here to blindly trust it
 * so I would just override stored nodes_id and backend to the chosen one, I would only have a session value which tells that mocking is in effect so that you can provide user feedback to the staff user (showing that mocking is in effect and which node it is mocked to (the one in `request.node`))
Agh, this should be `auth.login(self.request, new_user)`! This is what I meant when I said that you do not need that line. Because why would you authenticate and get user object, of you already have user object?
It didn't when I installed the latest package on my box...
Alright. Then, what should I write when a formula does not work with clang but needs gcc or llvm gcc?
After thinking about this some more, I think I'll just put the code in the constructor and rename the class name to _do_import_old_items, so running the code will be just like making a function call.
The following setup of a Stub seems to be repeated in most of the succeeding tests. What are the tests trying to tell us here?
This file and directory should be deleted. I deleted it in master this morning. Can you update your fork?
Actually there is no log, so we should remove this.
17682->11218
Do not remove theese lines or the knockback wont work
Any conclusion on this?
This will happen pretty commonly for static fields, won't it?
yea ... I spent an hour trying to figure out a better way ...
Does selectable not require these? Was this requirement deprecated?
I had a reason but it is pretty weak. I'll just change it :-)
Removing alias. Alias left in, just commened out. See below for reasoning.
You're attempting to shadow. It's discouraged, but certainly possible. You'll have to do it explicitly:

```
$ coffee -bsp
x = 4
do (x = undefined) ->
  x = 5
  console.log x
console.log x

var x;

x = 4;

(function(x) {
  x = 5;
  return console.log(x);
})(void 0);

console.log(x);
```
Its just git being silly... This class sticks around.
This is a breaking change to the API. Is there a specific reason you felt this was important to change.
if line is a shell line, you need to use shlex.split() here
What is "rel"?
Needs a file-comment.
Please use:
<img class="MyMenuIcon" src="theme/application-exit" width="16" height="16" onload="fixPNG(this)"/>

We already have an icon for application exit.
Is the `-d .` necessary?
This should be scale_est?
some plot methods would be nice
Looking at the definition in the docstring and ref [1], the ``abs`` calls in the two lines above are incorrect. It's ``abs(Xi-x)``, not ``abs(abs(Xi) - abs(x))``. Removing them in my speedup branch.
Yes, when NFD comes across compatibility mapping it skips it, while NFKD removes compatibility tag and goes further.
This doesn't really matter, but I prefer `File.open` instead.
Cool! I suspected there should be smth, but I must have been to lazy at the moment to find it :)
Please keep the empy line for clearity.
Are you sure, like, really really sure, you want JavaScript 1.2?
Killed the datastore props and now put all filters in a single collection with a flag for being default.
No clue. This file was just moved around between projects. Filed issue https://github.com/WindowsAzure/azure-sdk-tools/issues/326 to track this in a separate checkin.
I don't think it's either-or - a donor could be both a current user and a campaign friend. As in, someone may have emailed them to donate, AND they are registered on the site, so when they donate, it will both increase the campaign total AND go on their donation record.
By the time this returns, another thread could have claimed the newly created machine. So ensureUnclaimed will not necessarily return an unclaimed node.

If you really want an atomic operation for doing something like ensureUnclaimed, then you'd need sometime like claimWithCreationIfNecessary - or some nicer name.

Same goes for ensureExists. The nodes might not exist by the time the method returns.
append
"currently only supporting regex matches (if not supplied, will match all paths at the indicated domain)"
Hmm, `protected` in Java perhaps means accessible to subclasses and all classes in the package. Seems to be the case: http://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html
Rather than pointing out this one option, I would perhaps suggest using --help to see a full list of available options.
This is exactly what I was hoping you could help me with. Thanks, Fabio!
"for being" is a very odd way of saying this. Perhaps "to allow it to be" would be a better way?
I changed it to what it should be, and the name makes sense again.
Can you revert to what was done before and let's talk about improving this in another PR as this is not related to the main purpose of this PR anyway.
Good, we really don't need two different kinds of burning. :)
This all class could be refactored to use QT's native QPoint class.
I know... I don't really see another way of doing it better, though:

The connection manager does not know what sort of physical device we're talking to - which is normal. So far, it was passing a string reference that could be interpreted by each connection plugin any way they want. For instance, the USB plugin used the serial ID, and blindly tried opening all USB peripherals with the OP VID and checking their serial ID. _that_ was suboptimal. The idea of the update here is to add more details on device address so that the backend connection plugin will only open the relevant device, or at least have fewer tries. With USB, the only 'unique' way of detecting is to open all the devices that respond to a unique PID/VID couple - there can be several - and check the serial number.

Does this make sense?
I think this helps: http://surveying.wb.psu.edu/sur162/UTM/UTM.htm

So there was likely some confusion between the center of the zone and the limits of the zone. I have updated to -180 and 180.
Control structures shouldn't have the extra spaces inside the parenthesis before the first argument and after the last argument.
Вместо этого можно было бы сделать через конструктор. Зачем усложняешь?
Название исключения - достаточно бесполезная информация. Надо выводить toString()
Здесь будет NullPointerException, если classNames == null.
Кажется, Scanner не будет работать бинарных файлах.
В пакетном режиме надо завершать работу при неправильной команде.
В случае ошибки код должен быть 1
А если будет 100500?
What? No. Why this dependency?
There's already a TODO for this at #230
Yes, that commented out code is intentional. Its not needed right now, but I suspect I will need it in the near future.
>    does the seed need to be fixed?

Always, IMHO
sorry for my late reply: I think in the case of weighted samples its fine if ``export_graphviz`` only shows the total amount of "weight" that reaches a node.

It's difficult for me to judge whether it will be required in the near future (e.g. I'm not familiar with less traditional boosting approches such as brown boosting or online boosting).
Regarding the stopping criteria: we could simply use the local variable ``n_samples`` - but we don't need to store the ``n_samples`` value for each node.
Also, is there a better name than 'J'
This should go into ``fit``. Otherwise it is not possible to grid-search estimators properly.
please use

	 !noScroll
Would it be possible to call ```current_provider.flavors``` here to avoid defining @provider in provider_applications_controller?
I would prefer to have those shipping fields in a separate model where user can have multiple shipping addresses defined and choose between them. Those addresses would be set only through store, not already at registration time (to not scare users).

So when user registers, she just set those fields from before. And then when buying, she chooses shipping address among those defined. If none is defined, she can define some. One is default.

Each shipping address should also have its own country and phone number field (can be prepopulated from user object).
BTW there are some more things like "not needed" etc., but that's basically for this kind of changes - I keep more options coded. When the dust settles down, I'll remove the unused code.
Should use OOP rather than if-elseif
This action does not check if the citizen has signed the idea already. The check is not strictly necessary (an attacker can create multiple accounts anyway) but would be nice to have.
I talk for the github rendering of the org mode file.

This renders the display correctly (with the error ==).
Before, the ---- did render the display in chaos.
With my latest commit I am using <code>dirIter</code> to determine the paths that need to be monitored.  The paths are determined by a call to <code>directoryFiles</code> in <code>CFile::monitorDirectory</code> using the passed in paramters <code>mask</code>, <code>sub</code>, and <code> includedirs</code>. Using <code>dirIter</code> may results in a watch generated for each file in a directory, but there is no simple way for <code>useINotify</code> to determine if all the files will be watched, so as to replace individual watches with 1 for the entire directory. By using <code>dirIter</code> exclusively to determine the paths to add to the watch we avoid any confusion as to when and how far we need to recurse.
Does it need the serialization because it'll be stored/printed in a different format?
It only fails in `<SharingSCMTest>`
Please do this instead:

```
      report['date_processed'] = isodate.parse_datetime(
            report['date_processed']
        ).strftime('%b %d, %Y %H:%M')
```
Comma is in the wrong place. "In reality [comma] sizes of all projects have been accepted [no comma] from the large [...]"
This is a backwards compatible feature release, so I think this should be 0.2.0.
I don't see the point of these unit tests? Why don't you validate the AMQP message properties? You can potentially pass anything and send that as part of the message which I think it will actually fail since the encoder won't know how to encode your own properties
I agree window would be better.
Hi Matthew,
I know that @SpiffyJr removed the module property, but he does not remove the getter and setter. Also the unit tests have not been updated. So I was not quite sure.
If we do not need the module property, I will remove it and also the getter and setter. I will also update all related unit tests.

And what we do with the action property? Keep or kill?

Thanks for your feedback!
Lorsqu'il y a des pbms avec le serveur SMTP, on peut quand même créer des utilisateurs afin que le service pédagogique puisse continuer à bosser. Sauf que ces nouveaux utilisateurs n'ont pas reçu d'email d'invitation. 
Cette action permet donc d'envoyer ou même de ré-envoyer l'email d'invitation servant à l'activation de son compte Ingesup.
should this version be `0.6.7`?
Avec un ```margin-bottom```? Si le texte est long, il passe en dessous de l'image, et risque de lui coller.
Même remarque pour ```.picture-right```
Yeah, I will do that before this gets released

On Thu, Sep 20, 2012 at 8:38 PM, Ilya Braude <notifications@github.com>wrote:

> In pom.xml:
>
> > @@ -6,7 +6,7 @@
> >
> >      <groupId>com.cloudmine.api</groupId>
> >      <artifactId>cloudmine-javasdk</artifactId>
> > -    <version>0.3</version>
> > +    <version>0.3.1</version>
>
> bump v to 0.3.2?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cloudmine/cloudmine-javasdk/pull/21/files#r1657462>.
>
>
Please remove this -- it makes dummy mode the default. With behavioral parameters, we always want the defaults to be suitable for production machines. Otherwise we'll have to configure .build.cf everywhere and remember to enable real proxy mode. It's fine to leave it to developers to turn on dummy mode when they need a facsimile of bspace data.
do / end blocks are preferred over curly braces.
Should this be `image_c[y_c, x_c, c]`?
Already changed locally
Yes, this code was written outside of Cesium long ago before I realized the code would end up in Cesium itself.
Since you enumerate them below, I think you could just say, "using the following table view APIs:"

All the paragraphs that start "To..." are parallel; this would be clearer if they were in a bulleted list.
these constants should also be static
Со скобками мне больше нравится как то привычнее и поднятие  а ели захочется сахара то лучше сразу  писать все на кофе.  
Тесты писать не приходилось, задачи не такого порядка и времени на них столько не вылепляется.
В таком варианте легче чтить так как что сравниваешь обычно ты всегда держишь в голове, а вот с чем всегда разное.
Why do you need to wrap this stuff in a block?
I know that you found examples of us going this, but it actually isn't a good idea.

a relative require would be a little safer (b/c it does not have side effects)

require "File.join(File.dirname(__FILE__), '..', '..', '..', puppet/provider/glance")
(Yay for reversing changes after I've already made them.)
afaik we had to change all our internal links to relative to make it work in symfony.com as we are one level below.

@fabpot can you clarify how we should include images in the symfony-cmf docs so that it works on both web and pdf?
we don't use the `m_` convention anywhere. Either use `name` or use `_name`. In the latter case you'll need to also change `p` with `_p`.
`TypeTuple` is invaluable when you need to test something with a variety of types. I find it to be particularly useful when dealing with functions templated on character/string type given all of the possible string types.
FYI - comment is a bit outdated, but we can fix it later...
そう言われればそうですね。

なんで違和感があったかというと、このコメントがこのメソッドのためのものなのかわからなかったんです。
そういう仕様があるというのはわかったのですが「なのでこのメソッドはこうしている」というのがないなぁと。

それなら、このコメントはほんとにこのメソッドのためのものなのか、というのが疑問でした。

RDocとか、メソッド全体へのコメントなら空行は開けないでいいと思います！
So all calls to ``getXService()`` should now be outside of the main try/catch?
Just drop this straight into the line below. No need to set a variable I don't think.
the reason, in the doc header, it is said the value should be mixed, wherease here, we validate that it must be string, so there is inconsistency. I removed it to keep them in sync.
don't know if it's because i'm using `sha1sum` vs `sha1`, but when i generate "password", it has a space and dash on the end of it, which forces me to add quotes around $password when referencing it during the `openssl` command, e.g. 

`openssl aes-256-cbc -k "$password" -in config.xml -out config.xml.enc -a`
The transition property allows for multiple transition declarations:

    transition: transform 3s ease-out, opacity 2s ease-in;

Here I'm iterating through each transition and manipulating the first value in the list (transform, opacity, etc).
Thinking about this more, and experimenting with the UI, it DOES lead to a confusing result.  See bug: https://www.pivotaltracker.com/story/show/25401287
I'll handle this case by defaulting to using a global if it exists, and creating a product specific tag if a global one does not yet exist.
Does this need the `?_=` like it has below?
Idle observation, not sure if <code>empty()</code> check is required as <code>cache::load()</code> guarantees instantiated return even on failure. The additional guard makes this inconsistent with the other two getters. Other than this all three methods are identical except the  variable they return to, and the file name to load - maybe worth unifying?
Can we can get comment in here for what the purpose of this file is, and that people shouldn't actively use Ant.
It's no more artificial than a GF region name; it allows you to have > 1 MS-backed channel in the same app. I guess I can live with forcing them to define an external region just to get a unique name, but I really don't see an issue with David's commit allowing them to specify a name. So long as it's documented.
You should use ...(new MessageHandler[size]) instead of (new MessageHandler[]{}));
Issue died for almost three years... hah.

http://drupal.org/node/201876
インデントはスペース2つ。
Yes, works fine on 10.8 and ZFS
Yes, that is the plan.
@christianv Can we call this Quick Setup instead of Manual Setup?
That's a whole different project, most of the code doesn't follow psr-1 or psr-2 standards.
I was wondering the same thing. It doesn't seem like a good idea, but I guessed there might be some reason. And didn't want to break the usage. I'll gladly change this if that is wanted.
appendTo('body') is not necessary, jquery does this anyway
You can reuse the patient you just used ... if you want.  Not a big deal though to create a new patient here.
you should be able to use `Assert.assertNotNull("patient returned null", patient)` ... can you try that?  I just want to make sure the assertion is communicated properly, not that something wasn't true but that something was null.
+1 on going to strong parameters. 

Corey

On Nov 3, 2012, at 7:08 PM, Shane Emmons <notifications@github.com> wrote:

> In app/controllers/neighbors_controller.rb:
> 
> > @@ -40,5 +39,15 @@ def neighbor
> >    def neighbors
> >      @cache_neighbors ||= Neighbor.all
> >    end
> > +
> > +  def assign_attributes
> > +    neighbor.attributes = neighbor_params.except(:ssn)
> > +    neighbor.ssn = neighbor_params[:ssn]
> This might be a good time to introduce strong_parameters.
> 
> —
> Reply to this email directly or view it on GitHub.
>
is this pep8?
you'll just have to update this as well
I think we still have to move the annotation in beanvalidation-api.
remove lines that aren't being used
It is not worth it. All the tested code depends on Symfony anyway so it makes sense to require it IMO
Yep. You are absolutely right. Need to handle <code>.</code> and <code>..</code>
I'll fix it soon.
permissions ?

authorize! :read, @missing_translations if in the index method

this will use the :read permission of Translation (check in ability.rb)
I would add some text to the ImageFactoryException stating that the instance may still be running, just as you did in the log entry. The exception is what will get passed back in the response, so it's good to have it there as well as the log.
you should use ``if (null !== $this->configuration)`` instead. It is faster (it does not use a function call)
sorry but Read-me File of master branch was saying 2.4 :)
This should be calling ``order_by``.
One thing I'd like to do going forward, and this may be a premature optimization, is to give ourselves some wiggle room on contants that are read-only. If we only specify that "these are the constants, and only these constants can be used with these functions," that means we can change type under the hood with no negative impact. If we give them the type and let them hardwired copies elsewhere, however, we paint ourselves into a corner. Say, perhaps, we find a constant is heavily used and turning it into a number significantly increases performance. In the former, we can do that. In the latter, there would be regressions, just based on what the spec said we could and couldn't do.
- template preprocess cleanup
Definitely should replaced with routes. I tried to setup some, but failed to produce good. This is free range for refactoring!
it should be ``origin/symfony3.0`` as it is a branch, not a tag
Evaluates to the root of the framework folder I believe.
I think thats a good idea, I will move these into "blackberry.app.cover" instead of "blackberry.app"
Do not add qnx call extension method in the framework, please a dd a new webview API in web platform.js
experium.storage и все остальные провайдеры должна регаться по умолчанию. Но мы можем создать собственный сервис, который мы сами сможем конфигурить и положить в наш experium.storage. Он пойдет в секцию провайдерс, как и было описано в задаче:
``` yml
experium_file_storage:
    provider: my_custom_prodiver
    providers:
        my_custom_prodivder:
            service: @our_service // собсно этот сервис можно настроить как угодно
```