labofsahil/github-event-dataset-2012 huggingface dataset:
It worked in my test on models both with and without the parseBeforeLocalSave function.

From what I understand of backbone-coudb.. it creates a "couchdb server" on the client side and manages replication of data with the real server, is that correct? So in order to implement local storage, you just need to plug this library and point the database connection to this local server instead. Is that correct?
Unfortunately I can't afford to change all my server code to move to couchdb.

One question though, server code is often more than just a simple bridge between the data in the database and the view (client) : data has to be processed/re-organised when submitted or retrieved from the db.
Where does this process fit in this direct couchdb-to-web-client model? Does the client have to do all the hard work in this case? Or does couchdb allow some coding (much like relational database procedures)?
indents (spatie)
lol. that's good.

On 2012-02-27 20:48, Kai Hendry wrote:
> It's a trick for decoding http encoded strings.
>
> For example: Hopstock%20Gjestenett becomes Hopstock Gjestenett
>
> And we get to support essids with spaces in their names. http://webconverger.org/wireless/
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Webconverger/Debian-Live-config/commit/d7867dcfa25c0be7dd7406502848a4bbe2905da4#commitcomment-1018247
>
Closes #4, onto new UI
The above buttons were removed since we're pulling info from the sdcard
I've started to port the htc msm7227 stuff to msm-3.0 in a clean way with small patches. The plan is to be able to rebase on msm.git upstream. Maybe you're interested to join the fun.

http://git.cryptomilk.org/projects/marvel/kernel_htc_msm7227-3.0.git/

Uploading sources right now.
disabled code detected
You don't even have to implement anything here, this method is completely deprecated and will be removed.
I think it was already possible to blank out labels by passing false as the second argument. Since this change, labels seems to be hidden by default (at least on my server).
@Seldaek plans to write a blog post on it but he wants the handling of dev version to be fixed first
Might be a bit more efficient to make this a struct.Struct instance instead of passing the format as a string to struct.(un)pack.
"designElements -- renamed (used to be called 'de');" - this can go
@endJunction  @TomFischer  @wenqing  What should happen if sparsity is set null for solvers with sparse matrix?
@wenqing The const modifier is only needed if you give the values per reference or per pointer. In the case of getMatEntry() the values of the variables are copied. The copies are used in the method. The programmer is allowed to modify the copies. But it is not possible to change the values of the original variables within the method.
Good, split out in a separate merge request.
Use EventArgs.Empty here
This syntax is not compatible with Python versions prior to 2.6; in order to support all Python versions that pip supports, you unfortunately have to do a bare "except InstallationError:" and follow it inside the except block with `ex = sys.exc_info()[1]`
Agreed. If there's a policy to isolate dependencies on pkg_resources, that's fine, but I'm not aware of anything like that (and if there were, it should be documented). So why not just replace find_installed_packages with `get_installed_distributions(local_only=options.local)`?
Ditto re docstring.
So, I've done this investigation, I can explain the flow:

1. Widget's `render()`, this fires its `render` event.

2. Widget's `_defRenderFn()` is invoked, which itself invokes the [`renderer()` method](https://github.com/yui/yui3/blob/master/src/widget/js/Widget.js#L569-584).

3. Widget's `renderer()` method calls `syncUI()`, you have code here to AOP this method and calculate and sets the `total` attribute.

4. Widget's `_defRenderFn()` finishes its execution which causes the event system to call any `after('render')` listeners.

5. You registered an `after('render')` listener which will be executed and it calculates and sets the `total` attribute _again_.
But I note the function is clearly wrong anyway, it's returning v, not r.

And I'm not at all sure that it's going to be uniquely mapping a set of map values to an xored key.

If it's meant to be unique, why can't we just use:

hash = md5.md5(self._values).digest()

?
they snuck into the wrong branch somehow, hope you don’t mind
after the first await, should not the others be there already?
They are already refactored :)
love to see movement in this direction!!
Please wrap longer lines so they wouldn't be longer than 79 characters if possible. For coeffs table it is definitely not, but for comments shouldn't be problematic.
I would rephrase and call it a polygon upsampling step for longer edges, since we now measure the actual length of the segment instead of longitudinal and/or latitudinal extent.
"existing instance of the contextual" implies that what is destroyed is an instance of the Contextual class which is misleading. It would be clearer to say something like:

Destroy an existing contextual instance identified by the given parameter.
This entire file has either had all it's new line characters rewritten or all tabs have been converted spaces. Could you undo that part of the change so that it's easier to see what exactly has been added/removed?
How about:

```python
gradients[np.isnan(gradients)] = 0.
scaling = np.sqrt(bvals * 0.01506)
self.b_vector = gradients * scaling[:, np.newaxis]
```
All colours must come from less @footerTextColor
We really should make an extensions point for this so that extensions can register their subscription types.  

This can not really be here, as core should not have any hardcoded references to extensions.
Renderer and distributor_id shouldn't be optional; the command won't run without them.
Thanks. The static method would make it clearer that it doesn't actually modify internal state.
And yeah, I hesitated this morning to close out the unit test. I know it's getting called as a matter of cours as parts of a lot of other unit tests, but I need to figure out a way to simulate it actually getting something tangible back from the coordinator.
I prefer to use map(_.toBoolean) in theses cases, but this look good too! Maybe we should see with Felix if there is a way to prefer in theses cases.
ok, got your point. So we split extradata again but don't leave the stream without extradata.
Will try this.
Nice catch. Leftover from the evolved development :)
Made more understandable, by removing it.
i would define blue as an int, and convert it to hex in the same place as all of the others get converted.
Why don't we have loanOfficerId parameter in this method? I think we should have the same authorization configuration here as in the retrieveClientPersonalInfoForUpdate method.
Looks like guest_path and recursive don't make sense here.
bounds need to be preserved here as well i think
@henrikbjorn Right. At first, it was name "path name", and not "namespace". Fixed now.
Good point, I just copied it from twig_ensure_traversable. Fixed both now.
what about defining the method returning an empty array, so that people who don't need to register an extension can omit the method instead of having to implement the method to return an empty array ?
Finally, your function should just return a path, so this array is useless
I really do not like default arguments, it complicates code and doesn't fit C++ style used by node...

Can I ask you to use enum for this?
This was just changed to a FutureWarning --- doc needs to be updated...
AFAICT this doesn't serve much purpose -- it exposes the 'class' object, but no-one should be fiddling with that directly...
оно вроде и так int возвращает, нет?
use `assert_raise`
not sure what was the intention with this symlink, I guess you committed by accident
I still think we should have 2 separate annotations. deprecatedNonFinal is not as obvious as deprecatedInheritance/deprecatedOverriding but would work quite well if we really want one for both.
No, it's just a pseudorandom generator like a normal Java `Random`, but a separate instance is stored for each thread in the thread local.
When using a global one, writes to it end up causing a lot of contention.
Probably don't need to split this logic out into its own method, it could be as basic as:

elsif event[:action] == :flapping
  handler[:handle_flapping] || false
Can we be certain that promotions are only ever applied to *incomplete* orders? That's was the main concern around having this restriction in the first place.
Put imports at the top of the file.
comma after However
Usually imports go below the module docstring.
to what does the "u" refer?
I suppose _print_Diagram will come only later?
Heck that it equals True, not 1.
I think so, too, but I don't understand the reasons behind Poly's behavior and I suspect that it is easier to explain why Poly only works with integer gcd (which it says in the docstring in basics.rst) and Expr can work with Rational.
what is a custom query? this documentation is not so definitive.
Would you explain why this change was required?
A little JS might do the trick? Something we could push off to the Travis CI guys, maybe.
Yes
Per the comment here:
https://github.com/disqus/nydus/blob/master/nydus/db/routers/base.py#L21
Pro is that noise gets removed in case it was an error.

Con is that we're less flexible format wise, and it makes it harder
for clients to upgrade - they need to sync attribute changes precisely
with Diffa config changes. Though if they need to backfill  attributes
on existing data, it may be a moot point.

On 12/03/2012, at 18:10, Ben Hood
<reply@reply.github.com>
wrote:

>> @@ -59,11 +59,23 @@ object AttributesUtil {
>>     }
>>   }
>>
>> +  def detectAttributeIssues(categories:Map[String, CategoryDescriptor], constraints:Seq[ScanConstraint],
>> +                            attrs:Map[String, String]):Map[String, String] =
>> +    detectAttributeIssues(categories, constraints, attrs, toTypedMap(categories, attrs))
>> +
>> +
>> +  def detectAttributeIssues(categories:Map[String, CategoryDescriptor], constraints:Seq[ScanConstraint],
>> +                            attrs:Map[String, String], typedAttrs:Map[String, TypedAttribute]):Map[String, String] = {
>> +    detectMissingAttributes(categories, attrs) ++
>> +//      detectExcessAttributes(categories, attrs) ++      // TODO: Do we want to detect excess attributes?
>
> What are the pros and cons of detecting excess attributes?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lshift/diffa/pull/60/files#r544339
- ref: I'm not sure that this will work out to a resonable reference text, which might lead to a weird sentence.
- subdocument rather than a document.
- I'm not sure about the :program:`mongod`'s rendering. I think it probably ought to be "the mongod instance's.."
This is a "special" page, so to speak, so these are required manually.
With that you would only have to say:

    return render(request, 'public/projects.html', context)
There is a difference between an undefined variable and the result of an function call being undefined.
@p-scratch The default module used is set in this block of code.
Yes, it can go.
IMO we should always use singular for the names of the subsystems, so `phpbb_notification_*`.
It's the exact same mechanism used by avatar_salt. It doesn't need to be very random, it just needs to be unknowable by someone outside the system.
The space between ( and $user->data['user_id'] looks wong. Is that correct with the coding guidelines? IMO it should be removed.
What ```.value()``` function?
Default aspect ratio is 1.3333f for 4:3 viewports.
критично)
It should be the year of adding, so 2012, yes.
CS, you get the drift ;)
Please use the standard 2 spaces per indent level.
On reflection I don't think we should automate this. Can we add a version to our repo instead (as suggested by the docs)?
is $dbw always used?
Whould this memo dict still continue to keep reference to object after the compilation? If so, can we release them at least when we delete the Theano function? I think this is a global memodict, should we make one per compiled function? I don't think it is useful to share them between function compilation as we clone the graph. So there won't be sharing between compilation.
Start with inline doc. Use one line of summary. Next - blank line. 
Following by the rest of description of the class (more verbose). 

With the methods you can also describe keyword arguments as well.
yes, node_gets_total was a counter of the total, and node_gets was assembled from the histogram readings. Now this `spiral` type has 2 fields, a total and sliding 1 minute count. The rename reflects that.
I realize this code path isn't hit by AAE but should it instead default to using the `Index` as the segment path.
Cleaner to store return code and xmlFree only once:

int result = XmlNodesCompare(...);
xmlFree(copynode1);
xmlFree(copynode2);

return result;
Need to think about how this interacts with the working with forms doc. There should be a reference back to this document from the other one. Unsurprisingly, there is a substantial difference in tone/verbosity between this doc and the mixins doc. It would be good to get a more cohesive feeling here.
This is a place where Cabal and cabal-install are very inconsistent. If you run `./Setup build`, the default `BuildFlags` are [`defaultBuildFlags`](https://github.com/haskell/cabal/blob/master/Cabal/Distribution/Simple/Setup.hs#L1228). Prior to my patches, `cabal build` used `mempty` for the default `BuildFlags` because `buildCommand` was invoked using [`wrapperAction`](https://github.com/haskell/cabal/blob/master/cabal-install/Main.hs#L142), which overrides each command's default flags, using `mempty` [instead](https://github.com/haskell/cabal/blob/master/cabal-install/Main.hs#L172).

Here's the rub: on [L143](https://github.com/ttuegel/cabal/blob/automatic-configure/cabal-install/Main.hs#L143), I use `buildCommand` unmodified, which means that with my patches in their current state, `cabal build` uses `defaultBuildFlags`. However, `cabal test` and `cabal bench` use `mempty`. In summary,

Before:
* `./setup build` uses `defaultBuildFlags`
* `cabal build` uses `mempty`

After:
* `./Setup build` uses `defaultBuildFlags`
* `cabal build` uses `defaultBuildFlags`
* `cabal test` and `cabal bench` use `mempty`

I assume I should change the behaviour of my patch to respect the prior behaviour of `cabal build` and ignore the behaviour of `./Setup build` entirely?
cc @gnarf37
needs whitespace inside the parens
Is this exposed publicly?
`ret.push` can become just `core_push`. Also, I wonder if we might get a little bit out of moving the `.get()` down here, or having the for loop mirror [manipulation.js#L320](https://github.com/dmethvin/jquery/blob/a8f53ba89d827b7b0b90fdf9b2c323517908fcf1/src/manipulation.js#L320).
Sure we can. Do you guys have any other code review items to bring up? We
would rather fix all the  problems in a batch, not just  one by one

With many thanks,
Volodymyr

2012/8/7 Spike <notifications@github.com>

> In bobo-browse/src/main/java/com/browseengine/bobo/api/BoboSubBrowser.java:
>
> > @@ -230,7 +230,7 @@ public void browse(BrowseRequest req,
> >          }
> >          catch (IOException e)
> >          {
> > -          logger.error("error trying to set FacetHandler : " + facetName+":"+e.getMessage(),e);
> > +          throw new BrowseException("error trying to set FacetHandler : " + facetName+":"+e.getMessage(),e);
>
> Can we javadoc under what circumstances it throws exception?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/linkedin/bobo/pull/2/files#r1327871>.
>
>
Did you just agree with me? :smile:
Why do you need additional "dimension" argument, even though you know the dimension by array_length?
Also, can we shorten it to `clt_installed?`
The standard cmake invocation has changed since you submitted this; it's now `system "cmake", "..", *std_cmake_args`
Why do we need a lib/ directory?  Is that a requirement of the packager?  If yes, then why the requirement?
Done, although I don't have 2.5 handy to test.
I think the tests could be DRYed up but I have to read it completely so see where and how exactly.
similarly, this should be a comment
Yes, you are right about this method.I will remove it.
Seems to work without making it a string.
I think this should simply be:

``  if (!error.message)

Which will catch undefined, null, and empty string cases.
Enter is currently used to enter a new line into the selected file...Do we want to change that for mac?
This pipe call only specifies a done handler. If the promise fails, I think your length will get out of sync.
Believe me on this. We're not usig HTMLDocument yet. It is still in experimental stage and therefore we were not creating it before this change. If you create an HTML document, then it will interfere with DOMAgent which is currently in use.

Anyway, have you tried it out to see it fixed the unit tests?
This logic seems reversed. I think it's easier to understand if you break when you hit a divider ($listElem.find(".divider").length > 0) and then update $relativeElement in the final "else" clause.
That's what I first tried, but it doesn't work. It doesn't seem to qualify as an "element". I get:

TypeError: Object [object Object] has no method 'dispatchEvent'
lint.data()
converts object to array https://github.com/jshint/jshint/blob/master/jshint.js#L4456
and then we have to convert it back

maybe we should make `predefined` https://github.com/jshint/jshint/blob/master/jshint.js#L4208
public in our copy or ask jshint people to do that

https://github.com/nightwing/jshint/commit/bf0f71654100df9dd30ca9871d9d0e5ead61cda2
It's possible someone could find that useful, though they could just add that to the existing argument, e.g.:

$this->redirectToAction('someAction/some/other/data?' . http_build_query(array('queryStringName'=>'queryStringValue')));

I think the spirit of `redirectToAction()` was just to remove the need to specify the app base path & controller path each time a redirect is done from within a controller to somewhere else in that controller.  Maybe not the best name for the method.
I think you meant to modify the line below instead of just adding this duplicate line?
This looks pretty confusing to me actually. How about scala way?

```
/Users/paul/Development/test/thing/a.scala:2: error: a is already defined as value a
```
Of course you do not need to wrap everything with `with`. Just the part where you need it. :-)
These aren't the same, but it might still work because e.data === e.target. Check?
Don't use foo_bar in JS, use fooBar.  Same below.
Looks like some extraneous space.
default-config.json should include this property, with a default set (probably true).  That way you don't have to do this dance, since a config will always have an appendUID option.  Also, in the config, I'd rename the property, since this makes no sense unless you really understand our code.  Maybe use makeVideoURLsUnique or something else more descriptive.
If we are going to have whitespace on the left here we should in the right as well for all four of these, should we not?
When does this fail? Can we put a console.log in this catch statement to alert the user that something bad happened?
aha, this is the line I was supposed to comment on. 

"You check for existence on `popcornOptions` but use `_cachedValues` instead, doesn't seem right"
I spelled it wrong too :O
I feel like this explanation is a bit hard to grasp, especially the frequent use of `this` for different things at the end. "given by the creating flag" reads very oddly.

Ping me if you want some pointers, but maybe just take another crack at explaining this? Also, see my comments about the variable naming earlier. Using the present tense for the argument name seems weird to me.
@brendandahl , where we shall place the list from https://github.com/mozilla/pdf.js/blob/be8daec13f1faa2c3d7ad44e43f7bf0346e1ca8a/LICENSE
I definitely wouldn't create a dsl for stuff like this. I think it just makes it more confusing. The people who know bash will know how to write it in bash but not in the dsl and the people who don't know bash won't know either the dsl or bash.
Please remove the space before `:`, applies to the other examples as well.
Since the model isn't save a few methods weren't run that are required for save_iq_file. This is the the before_save of Deployment model:

    before_save :set_initial_status, :save_deployed_data, :save_iq_file
Actually the best solution might be to make sure that EnterModule() and AddScript() handle the empty string the same way the handle a NULL value. That way we can just use sModuleID everywhere.
? What's this?
Whyfor you remove the "." in front of "utils", Señor Steder?
Removed outputConfig line
Yes, but I believe that shootout submissions must be self-contained. I don't know about this.
As part of changes for orgswitcher, did we intend to make z-index change on env_select?  Same for dashboard.  I assume so, but confirming.
I had mixed feeling about this too. But all original calls generating message-level notices were asynchronous so I added this behavior as default for the message-level notices. I tried to keep original behavior of notices and clean up only source code.
if this error is going to the end user the path to the job dir shouldn't be displayed. Maybe reword it to be "could not access job directory for job $job"
Wrong doctype :)
shouldn't you use ``@expectedException`` instead ?
Yeah it doesn't gets triggered if the app is close (but no crash either).

Can't wait for the services!
Yes, that's a SOFA limitation.  I think nanoseconds are enough for astronomy, and anyway that is just the string datetime representation while the internal jd1 and jd2 are potentially more accurate.
有比meaning更通俗的名字吗？pluginConfig ？
This fails when emacs is installed without a GUI.

```
Invalid function: with-selected-frame
```
Because we want the focus in signFrom, so this is obsolete. Try it out, it works!
Thanks.. These lines now removed. I obviously didn't update something somewhere in git. :-s
Shouldn't this be setting fRun to false also? (laanwj/2012_04_consoleui removes the first try block entirely, letting this handle errors)
} elseif (strpos($this->_rule ,'::')) {

should be 

    } elseif (strpos($this->_rule,'::')) {

It's a good idea to run your code though phpcs using the cake code standard
Same about the translation.
The `FeaturesWindow` doesn't have an output so it seems to me that all this is unnecessary.
似乎应该定义在后面比较好，如果删掉我下面提到的函数
What about if the user is logged out? Then if it's new and no comments it will show up as read, correct? Whereas we still want it to show up as unread, even if the user is logged out.

Also, it's nice to avoid doing `(user && function_that_takes(user)` wherever possible. So, to kill two birds with one stone, why don't we just do `|| discussion.never_read_by(user)` and just modify discussion.never_read_by(user) to return true if user is nil.
- Please use `[]` instead of the `new Array()` constructor.
- Please do not use underscores in `Identifiers`
Zet daar maar je naam en het info@adres
no whitespace ? pfff
This smells like some fairly general styling, rather than specific to this page.
I wonder if `list2env(as.list(src), dest)` is a better idiom for this?
We don't use the 'main' section calling nose explicitly in IPython.  Instead, there's an 'iptest' script that is in charge of running the whole test suite.  I prefer that devs don't get into the habit of having a separate entry point for their tests, because it increases the chance that they don't notice a problem with their tests when run in the 'normal' fashion.  So the block below should be removed, and these tests can be run via

```
iptest -vv IPython.frontend.qt.console.test_console_widget
```
a bit verbose, but very descriptive: `_call_cached_cell_magic`.  You could also use `run` rather than `call` to be more consistent with the other method names.
Good idea, I'll put it back with a note for the future.
Inadvertent/accidental blank line here, or meant to group code for clarity?
Since sometimes we do ship dependencies in externals, I think it's worth adding a word here telling the user that they need to install oct2py themselves for this to work (and mention that it in turn needs h5py, and doesn't declare the dependency right, so if you don't have h5py the easy_install fails).
Thomas Kluyver skrev 2012-05-31 21:46:
>>  @@ -361,9 +373,8 @@ def format_stack_entry(self, frame_lineno, lprefix=': ', context = 3):
>>                         and tpl_line_em \
>>                         or tpl_line
>>               ret.append(self.__format_line(linetpl, filename,
>>  -                                          start + 1 + i, line,
>>  +                                          start + 1 + i, line.decode(encoding, errors="replace"),
>
> Are you sure about this? I expect in Python 3, line will already be `str`, so decoding it again will fail.
>
fixed in 98fd6f8
Hm, nevermind - the flicker does seem to be gone.  That means that I misunderstood what was causing the flicker, and also suggests that calls to `plot()` results in some IOPub message, possibly an empty sys.stdout.flush()?
this property name should be a constant
Do you know if this will ever be shown on the UI? If so, we probably want 'Disabled' to become 'Hidden' to go along with the Visible/Hidden lingo.
lol. I heart Java.
I wouldn't cache this in _breadcrumbs; if the parent node ever changes, breadcrumbs becomes invalid.
I don't see what this exception handling adds. Using the logger (and with it, exc_info=True) is a great way to leaking potentially swallowed errors but this is the main method and if it errors the error will be right there in your face on stderr.
The difference between logging and `warnings` is that `warnings.warn()` is smart in that it doesn't say it more than once. 

I see it more as a hint to developers. 

You'll only really see if when working with tests or running it locally on a local wsgi server.
Thanks Adam, 
how can i do that? Just re-edit the files and sent a new pull request?
For non-zero float constants, prefer an explicit float literal type to avoid compiler warnings: 1 -> '1.f'
At Square R will be the same as CE. For a few public REST APIs I've looked at CE and SE are the same. And for a few CE and SE are different.
I don't think this hurts as explained above.
After this PR, the code has no $context parameter so this doc line should be removed.
I think we need to break things here as the setting does not work anyway.
makes sense, need an entry in the changelog.
This is slightly faster. Extension methods only make sense when the logic has dependencies.
Either the type hint in https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Client.php#L43 is wrong.
Or this subclass must make sure that a `KernelInterface` is passed. Otherwise this code is wrong.

And you can remove a service from a container with `Container::set('profiler', null)`.
This way allows you to have properties with properties though (i.e. metadata with depth > 1). Maybe a naming issue?
Well, it can only occur when doing live update of the PRs according to the feedback, which is generally not the case :)
> So I guess ideally the config file should override these values if given, and command line options should override both.
This was the original behavior. All that is needed is a copy/paste
from the original code.
either original_post_id to match the reply casing or originalPostId
I have two thoughts when I look at this. 
1. Why is sender nil sometimes
2. Could we move this into the sender so we could tell rather than ask

The code would look like this if so
```ruby
def send_activity_message
  sender.do_whatever_an_activity_job_is unless sender.nil?
end
```
Or something like that.
Alternatively, you can break at the `.with` and do the `with` on a newline.
Quotes around 'me out' since it's the thing that's returned.
You are limited to VBScript, JScript, DLLs or an executable (see [here](http://wix.sourceforge.net/manual-wix2/wix_xsd_customaction.htm)). From what I found online, the executable or DLLs is the safest because there are some permissions issues with scripts in installers. It's annoying to have this extra program here, but it's tiny and may be useful if we want to do more config in the installer later on. 

I'm with you though - I'd *much* rather be using sed.
Even if its deleting blank spaces ?
Maybe have a single formatter instance in the object? Would make it easier for people to subclass MissingKeyFormatter and have it be used... (though its not clear *why* one would want to do that).
`@hand_cards`
Class name should be AppConfig
@wycats just those two lines or the entire block comment? I can drop which ever.
why prod is hardcoded here ? prod is just a kind of convention ...
FileReader is in Chrome, FF, Opera. Missing from stable Safari. Not sure why caniuse is reporting partial for FF/Op. I just pinged @fyrd to ask why. :)

Suggested:

> Supported in Chrome, Firefox, Opera. Safari is currently missing FileReader support.

also 

> FileReader pairs very well with Drag n Drop to allow for drag 'n drop file uploads, and if neither of those features are present, the fallback of providing an `<input type=file>` is rather easy.
I don't think this field should be required, not every has twitter accounts (or will want to share them with us)
Look forward for support to remove epoch without patching. Meanwhile I applied the patch manually.

Thanks.
What is the meaning of this? This is purposely using PHP instead of JSON for a reason. 

I'm happy to revisit that, but please tell me you read the README and have a use case for why this is a problem.
Since the keys are now different these should be updated as well so that it better makes sense to ua-parser developers. The keys are already restricted with `array_intersect_key`, I think it might be fine to just pass `$uaParser` as-is to `print_r`.
Can you restore the init_momentum docstring?
This change is not related right?
is a typo:

`var avaiableSpaceNormalMod`
`var availableSpaceNormalMod`
Refined.
Thanks for the reminding.
... (continued from above comment) this will work but only if the transaction has not yet been opened (which is possible).

We need to save a reference to the transaction created below and then call .abort (IDB method) on that transaction to ensure we really abort in all cases.
Cool! I think this was what I wanted originally ^^
Why some privates have the <tt>_</tt> prefix and other not? I don't care if you don't use them but try to use only one coding style unless you have good reasons mix them. :)
> Regarding the first question, my suggestion would be to place the Confirm BB HTML template both in the /apps/communications/contacts/index.html but also in /apps/communications/**dialer**/index.html and use ConfirmDialog to properly configure, to show and to hide it. Otherwise, we would end up having to inject code in either of those HTML files.

Sounds good!
Ditch the bug number ..... we don't want the *fixed* bug number pile up in the source code :-/
> so that when is in unlocked on initialization, the unlock event is dispatched:

@timdream, could you confirm the `unlock` event is always fired no matter the lockscreen is enabled or disabled?
everything controlling `#homescreen` should go to `system.css`
Does it still need to be on 2 lines?
You should not add spaces after and before parenthesis, and the `null` value should come first. It's better to write:

    if (null === \$parent) {
So are you mapping objects to tables in PostgreSQL here (using some sort of object-relational mapping) or are you using PostgreSQL as a key-value store (I know it supports this as an option)?  I guess I should have asked this earlier, but hadn't had time to pick my way through the new code in the level of detail that @daniel-pittman has...
better names than `obj` might be nice here. it looks like `obj` is the expected value or the answer? Maybe something like that.
Nothing special - I think there may have been an else on line 146
前後スペース消した！
直す。
他にもあるかも
These three translations are in english. Should be in Japanese.
Shouldn't we use here Sinons `FakeTimer`?
because u ask the following in line 171:

if match_include and isinstance(match_include, types.BooleanType):
* I would move this out of the media-query, just for the edge-case of some mobile browser less than 320px.
* I would remove the rather arbitrary `width: 88%` and instead use `.box-sizing(border-box);`
I think that ruby build scripts will just use -L dir/lib anyway, if you set --with-opt-dir=dir. But I could be wrong.

The thing is, it's really hard to detect whether libyaml is properly install. To be sure, you need to compile and link a program against libyaml.

Which is what ruby does.

I think the easiest would be to give up on automatic installation of libyaml and run a check on the ruby build log after ruby has been built and tell people that they need to install libyaml (and how that could possibly be achieved).

But that's somewhat inconvenient for the user.

What a mess.
Not sure why every line appears to have changed in diff; I only changed the few it took to fix the preventDefault error.
May want to sanitize this "app_name" otherwise you can have a security issue here. Check in the lib folder for functions that check to make sure the app_name is valid. I believe some other functions within this same file do so as well.
Why return zero? That seems like that could cause whatever data has id 0 to be overridden by the caller of this function. Maybe throw an exception instead?
OK, I will use it.
else前后也是有个空格
`type or= data and 'post' or 'get'`
will put it in if branch
That's what I did initially, but I was unable to figure out how to do that with RSpec. The instance variable I set didn't seem to be available in the context of the test.
This doesn't seem to be used anywhere now.
This should just be calling `botmaster.cleanShutdown`.
Since the view already owns the model, would it make more sense to call `@updateVisibleItems view.model` and avoid passing the extra model argument?
服务器的地址能否写在配置文件中？
I tried both `Keyword` and `Dict` https://gist.github.com/3a1b0a817a8cb2d04663 but they don't work in this case

/cc @josevalim
原文: If you have been writing a fair amount of $(view.el), there's now a cached reference for that jQuery object: $el.

監訳案: これまで`$(view.el)`を利用してきたなら、このjQueryオブジェクトに対するキャッシュされたリファレンスである`[$el](#View-$el)`が利用できるようになりました。
now removed (although post-launch we should revisit this: Anthony has lots of thoughts on "onward journeys" from final gallery slides)
One moment, I will make it only catch for certificate expired.
Can you please change it to `this.id % 2 === 1` and move else branch to the main `if`'s body?
Must be "--std=c++0x'
Should view-level code be poking into the internals of `DatazillaModel.sources` like this? I'd think rather that `DatazillaModel` should expose this directly as a method or property, giving us more flexibility in the future.
__whimboo__ wrote
> ... we should move away from a guid ...

Hmm. IMHO that will cause a new addon. How do You migrate 100k users?
CCing @jvillalobos to help count our possibilities about this move.
Pull the `unless` condition up into the `if` conditional. Having them nested in this way becomes confusing. The simple `if` with a boolean expression will be easier to follow.
perhaps add a hook for validation?
Hmm, what about this line? D owe still run it? Why?
@ralphschindler this one causes duplicate injections such as `->setEventManager($this->get('Zend\\EventManager\\EventManager'))` being called 2, 3, N times in the generated code. That seems to be a problem in `Zend\Di\Di` too. Ideas about how to get the duplicate calls removed? Can we somehow match the calls and strip the ones that are equal? The dumper does not need runtime performance, but a fix in `Zend\Di\Di` would be cool too :)
Same again, please remove this magic.
This is not true. A constructor always return an Object or throws an Exception
could be kibibytes :) or gibibytes :) 
http://en.wikipedia.org/wiki/Kibibyte
This doesn't follow the spec. Do you mind removing it?
CSS shouldn't be tied to the filters functionality.

Instead you should just hide/show the items directly.
What I did (for nearly all the changes to db_bench_wiredtiger.cc) was take the leveldb version on the Symas page (which I now have in doc/bench/db_bench_leveldb.cc) and diff'ed it against the version of the benchmark that is in the tree, db_bench.cc.  The ifdef'ed out tests are things that Symas did for their testing.  Their BDB version is like that as well.  So, I applied the diff to the wiredtiger version.
@anti LOCK TABLES lasku ois tässä hyvä
Could you assign the callback to a variable and align the ```=```

Something like : 

```php
<?php
/**
 * {@inheritdoc}
 */
public function getHash(array $identifier)
{
    $class      = $this->class;
    $em         = $this->entityManager;
    $callback   = function ($fieldName) use ($identifier, $class, $em)
    {
        if (is_object($identifier[$fieldName]) && ! $em->getMetadataFactory()->isTransient($identifier[$fieldName])) {
            $class  = $em->getClassMetadata(get_class($identifier[$fieldName]));
            $id     = $em->getUnitOfWork()->getEntityIdentifier($identifier[$fieldName]);

            return $em->getUnitOfWork()->getHashForEntityIdentifier($class, $id);
        }

        return $identifier[$fieldName];
    };

    return implode(' ', array_map($callback, $class->identifier));
}
```
I would vote for ``getResult``, to avoid breaking the contract of the interface (as it would make the class lying about the interface)
For maximum foolproofness, I'd suggest removing the link from here, and we can hardcode (!) it in via the admin translation interface when this goes live and we have an entry about it!
yes, of course!
Should be ictce-4.0.6 in example easyconfig
Sounds good! Will do a v3 and send another request. I'm off for a few days,
so it'll be provably next week.
`first_name` and `last_name` seems unused. Do we expect to use them? If not, we should not store them to prevent later usage of those fields that sometimes make no sense for some locales.
check for visibility not present as we want the user to see it!
I'm actually cool with setting it in the template (because views can reuse templates so it probably makes sense to set something here) -- it would be nice if we didn't have to call `super()` on the block. I thought there was some reasonable way to do this with template inheritance and stuff in Django. (It also might make more sense to have a `nav_active` var that you set to a string rather than a few `nav_foo = 'active'` variables you set, but that part matters less to me than the cruft in the templates).

I'll look it up in the docs.
What is base_url_ssl? Is it something specific to sumo?
Thanks Zac. I was actually going to do this next re the header region as going to write tests for the header links.

Will also look at the inconsistentcies. Cheers
Are we not limiting this to X decimal places?
Deve-se tratar o caso onde Schema não é instanciado passando um XSD. Deve ser levantada uma exceção tipo ``CannotValidade()``
what does the grouping adds here? (sorry if its obvious)
Is it perhaps safer to be case-iNsensitive?
Also, you don't need to do the `.count() == 0`. This should suffice:

```python
if not User.objects.filter(email__iexact=email):
    raise ...
```
also I guess if there's duplicates, some characters can be added, (monday-meeting-1398 for example), so maybe it would be safe to do slug field length = title field length + 10?
essentially we don't honor config changes since we are reusing the compressor that was created earlier. I commented about this in getCompressor() below. Alternative is not to use the codecPool when we can't pass in the conf (as we used to do before).
Filed http://bugzil.la/8014005
lockAcquired
If everything is fine, no need to tell anyone about it. Maybe it should be removed or a warning. "Coordinate already claimed by us, shouldn't be necessary" or something similar.
The word "staff" it's used in spanish as an anglicism. http://lema.rae.es/dpd/?key=staff
Good point, let me do this.
This is a very good point that will matter for any non-circular aperture/PSF. How do you think it should work?
>.> when your eating them duh
That's too aggressive. You must keep the `}`
there is an possible path, if "src" present but "dest" is NULL:
- put "src" at the end... no need for an exception
I worry that this allowed `null` before this change, but not after.  But I'm not looking in the full context - perhaps it's already been normalized by this point
* Remove the whitespace after the `icon-chat` inside the quotes
* Also as per [bootstrap documentation](http://twitter.github.com/bootstrap/base-css.html#icons), text following a icon should be preceded with a space
Don't forget to provide the non-vendor prefixed property as well. Also, no love for Opera or IE?
Please remove this logic/argument. We're simulating a user, and a user must click (tap) the submit button.
Oups It was updated in the previous commit (By mistake) :D
This code *is* duplicated between here and the blip suite, but I don't think that's enough to justify a class method, especially since in many cases, a VideoFile may be put together from an API or (theoretically) some sort of arcane page scrape.
Actually, there is already a method for that; in one sense, this is duplication, since we could use suite_for_feed_url and then get_feed from that - but since the suite_for_feed_url method calls suite.handles_feed_url, which calls suite.get_feed, implementing it this way is more direct... still, this could be a good place to refactor some more.
Each migration should be a standalone unit of atomic work, isolated in its own transaction (at least, that's my proposal). If you have 3 migrations, and there's a failure part-way through migration 2, then migration 1 will have been completed and committed and 2 will have been rolled back. 3 will have never taken place. 

At daemon startup, we do the migrations prior to starting up any other threads...so all of them have to succeed, or we bomb out.

So the next time the daemon starts up, it looks at the migrations table to determine what migrations have completed. It'll see that only #1 was done, thus it will pick up with #2.
This hunk seems useful enough to cherry-pick. Does `information_schema` exist on both PG and HSQLDB?
If that is going to be a problem you are (a) reaching back to pre-history, and (b) limited to either 14 characters, or 8.3 characters.  I wouldn't bother, though.
I realize that this function is gross.  :)  However, I didn't have much luck finding any clojure bindings for *configuring* log4j stuff.  Open to suggestions.
I guess this whole block can be now 'simplified'

result = ('success' if [Net::HTTPSuccess, Net::HTTPRedirection].include?(Net::HTTP.get_response(url)))
Namespace syntax, does this break < php 5.30?
`where` should be capitalized.
Please remove this console.log statement
It should be null. Fixed.
Yeah, I'm not a big fan of the Sage interface either. Sounds fine to me to not include it in this list.
A simple `if` is better, because if the first condition matched, the script will be stopped.
Which provider return a empty result? 

I don't found any provider which return a empty result.
Can `,` appear anywhere in the counter? If not, that `[.]` should be `[^,]`
just added the token that failed so we get the message that caused it to fail
Zelfde probleem met naam voor `my` en `r`
@pmkravets верно, макрос. Один неправильно выразился, другой подхватил. Но всё же.
По-моему в этом условии будет постоянно истина.
Он не завершится, он будет бесконечно уменьшаться, пока int не кончится, потом продолжится с верхней границы.
Ahh crap. Knew I must have missed something. Will do tomorrow.
this should be down w/ the other runtime files and have similar comments
dropped by the cache
Can you uncommit this?
This should look like this: ```<spaces>return $this;```
ご購読ありがとうございます。
And hope that `self.copy()` never crashes :)

Eventually it might be cleaner to have an Epochs class that can be initialized with its attributes... and that might also be useful for the result of data transformations such as time-frequency?
This line fortunately only executes in the case where it's not a list (the line above checks for that).
I don't see you can get rid of the line below and with this max you go over the data twice but maybe you see something I don't. I left the warning as the problem only occurs at the first iteration of the optimization but fine if you nitpick :)
forget what i said.
That should be `.linkapps`. :rage:
This is related to my note above. If we *don't* include the `:class`: links everywhere (which is my preference), then we probably should wrap these in double-ticks - \`\`Request\`\` - which I have not done here. I'm going to change to use the double-ticks right now.
Fixed in commit 2f73bd2
I used `alias` here as I noticed many other other aliases used it instead of `alias_method`. I was unsure of what the convention was, so I went with what I saw.
No worries. Fixed it in @02011fdd2fad0d3cf040c653435c90b9b00ce30c.
I'll pick it up.
I presume it's not ready to merge until we get the link.
Ок, тогда сделаю в else
Можно ж написать `if (auto profile = qobject_cast<...> (...)) ...`
Плохая идея, теперь на любой запрос аутентификации из любых кусков личкрафта будет реагировать GMail Notifier. Не думаю, что это лучшая идея.
Yo usaría `prefix` en lugar de `filemask`, para que se pueda utilizar el mismo que en el batch que hace el backup. De hecho, agregaría la llamada a `deleteOldBackup` desde el otro
If you could leave out csproj file changes out of your pull request that
would be helpful,

or make then an atomic commit that I can ignore

-Ryan

On Wed, Apr 25, 2012 at 10:49 AM, ilich <
reply@reply.github.com
> wrote:

> > +    <Target Name="CheckPrerequisites">
> > +        <!-- Raise an error if we're unable to locate nuget.exe  -->
> > +        <Error Condition="!Exists('$(NuGetExePath)')" Text="Unable to
> locate '$(NuGetExePath)'" />
> > +    </Target>
> > +
> > +    <Target Name="RestorePackages"
> DependsOnTargets="CheckPrerequisites">
> > +        <Exec Command="$(RestoreCommand)"
> > +              LogStandardErrorAsError="true"
> > +              Condition="Exists('$(PackagesConfig)')" />
> > +    </Target>
> > +
> > +    <Target Name="BuildPackage" DependsOnTargets="CheckPrerequisites">
> > +        <Exec Command="$(BuildCommand)"
> > +              LogStandardErrorAsError="true" />
> > +    </Target>
> > +</Project>
>
> This is the target file which is used by MSBuild and Visual Studio to run
> NuGet.exe to update referenced assemblies. I think you can leave it if
> ripple is able to download references.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/DarthFubuMVC/htmltags/pull/19/files#r733370
>
I think I have a stupid plugin that tries to format all my stuff for me....annoying
Seems to be working. Good catch.
Not strictly necessary, but one of the box tests in Veewee checks to see if Puppet is installed. I had to flip a coin to decide whether to remove the Puppet stuff and leave that test failing or not. If you have a strong opinion either way, it can certainly be changed.
Good Answer!
Thanks

-----Original Message-----
From: Yosef Dinerstein [mailto:reply@reply.github.com] 
Sent: Thursday, March 15, 2012 4:04 AM
To: Elad Ben-Israel
Subject: Re: [node-wintools] Parse XML output of WMIC. (#1)

> -            if (!e.cmd) delete e.cmd;
> -            if (!e.prog) delete e.prog;
> -
> -            if (e.pid) {
> -                output[e.pid] = e;
> -            }
> -        });
> -
> -        callback(null, output);
> -    });
> +* Returns all the system processes
> +* @param filter {function(p)->Boolean} A filter function executed on each process before pushing it to the list.
> +* @param callback {function(err, list)} Called with the list of all processes.
> +* @remarks Runs only on Windows (uses WMI) */ module.exports = 
> +function (filter, callback) {

Made this change

---
Reply to this email directly or view it on GitHub:
https://github.com/anodejs/node-wintools/pull/1/files#r562293
This line can be removed since it won't be clobbered.