labofsahil/github-event-dataset-2012 huggingface dataset:
I still get this when compiled with `CUSTOMER_HW`:

```bash
<7>[213, WifiService] [  102.595921] bcm_wlan_power_on: WL_REG_ON voltage level successed
<7>[213, WifiService] [  102.596984] bcm_wlan_power_on: EXT_POR_L successed to pull up
<4>[213, WifiService] [  102.749008]
<4>[213, WifiService] [  102.749028] Dongle Host Driver, version 4.218.248.23
<4>[213, WifiService] [  114.745393] dhd_module_init: sdio_register_driver timeout
<7>[213, WifiService] [  114.752838] bcm_wlan_power_on: WL_REG_ON level pull down
<6>[213, WifiService] [  114.754088] bcm_wlan_power_on: EXT_POR_Lsuccessed to  pull down```

Hmmm, and I just noticed that `bcm4329_wlan` is only defined at 223 in `drivers/net/wireless/bcm4329/dhd_linux.c` when `CUSTOMER_HW2` is defined (check out the ifdef)...  Lemme try with `CUSTOMER_HW2`.
OK, I'm going to drop this patch.  Entries on the unsafe list still need to
be protected by a spinlock *somewhere* because there are other
paths that allow them to be removed from whatever list they are on
and those are *not* protected by the inode mutex.

With respect to the other confusion about "ending up sleeping" I
neglected to update my patch summary--that was the original
motivation for this change but that particular problem has since
been fixed.
Thanks again!  I'm really happy that someone else has found this to be useful!!

I too was always taught to use "use strict," and initially had some thoughts about changing it myself when I first started working with the original author's code.  You stated it perfectly, though:  it works, not gonna fix it.

Enjoy!  Please feel free to continue to suggest any changes you see fit.
thanks. This reminds me that at some point I need to add php version compatibility checks to the plugin interface
This is outdated by now! ;)
**Part** | **Points**
------------- | -------------
base | 1
late | -1
**Total** | 0

I think thats how it works. Everything seems fine, Had some git issues on my end.
src/test/scala/com/twitter/zookeeper/TestConfig.scala
RE: XML vs xml - Visual Studio automatically did that for me when I changed the project.  Personally I would not fight the tools on that one, it will change each time the project is changed.  Meaning each merge you'll have to ignore it.
It won't be good looking Tubnail without Title but i don't know :)
this is wrong here. You will return a boolean (this is PHP, not JS ^^)
Guess I misunderstood then..

On 2012 2 11 15:20, "Stig Kleppe-Jrgensen" <
reply@reply.github.com>
wrote:
>
> Why should Jenkins have 2 formats for referencing variables inside
Jenkins? You know this has nothing to do with extracting environment
variables from the OS? That is, ${var} also works in Jenkins running on
Windows.
>
> ---
> Reply to this email directly or view it on GitHub:
>
https://github.com/kenglxn/repository-connector-plugin/commit/471a3ac5ea294825780fa2720583d377a94a2e77#commitcomment-956541
commit 3540e33e2a2646b8c14a04397682a0c4b839d870 from https://github.com/Unhelpful

"Allow loading of vendor-<class> hardware modules.
If the requested class for a module to be loaded is prefixed with
"vendor-", check that the module class matches the portion after
"vendor-" instead of comparing the full name of the requested class
to the module class. This allows easy use of the libhardware loader
in modules that wrap vendor binaries, which can directly use
hw_get_module to load the vendor binary."
But wait, I recall you argued to keep this as is for backwards compatibility. (I'm referring strictly to the doc changes.)
so, pip would end up supporting this new form of dependency link for local project dirs.
I'm wary of sanctioning pip-only syntax for a setuptools/distribute field.
and realize this would be a non-editable install of this project dir, which is probably not what would be wanted?
Wont this break current scripts that use RandomRClick?
A bit ad-hocy, and id happily overwrites the previous values if it receives more of these messages, is that intentional?
yes, they are included; I added this file so I could more quickly build the contrib docs by themselves, don’t know whether we want to keep this or not (contra: links to the “official” docs won’t work); if we want to keep it, then I agree that this file needs some cleanup
Remove this method and put "UTF-8" as the default value of encoding.
yes, it probably should
superfluous parentheses
Nice!  had to add this

 val settings = provider.remoteSettings   //have to do this to do the import or else err "stable identifier required"
 import settings.{NATFirewallAddresses, NATFirewall}
It's fine to use the full 80 chars, and it will render ok in the pdf.
@throws(classOf[Exception])
I don't see any scenario where we'd bump that number :/
Would it be possible to set self.status to removed and do away with isRunning?
I think that session and admin functions are just special cards by 2.0, any special handling in Self Model, Events and Views.
I think I fixed it, running tests now.
Write it out as  b0_threshold?
Unfortunately, in the scope of my extension, it feels very much within the scope. Especially, when it come to presenting that stuff in front of a scientific panel. They do not want to wait 5 minutes (because my laptop is quite old) just to see the search interface.

From what I can see, when adding a new Interface function:
before_view_context(package_dict, view_context)
  view_context = 'search'
should work quite well as it breaks no old code and remedies the performance issue.
New view_types could be added subsequently and step by step.
Agreed, I fixed to properly raise it.
It shouldn't, but scala throws an exception if there is no matching case ;) Better put that warning than an exception thrown in unknown direction!
This changes behaviour as well - you basically want to return false only if both are empty.
on_demand_usage?
on_demand_only_usage?
usage_without_reserved_instances?

the word default is a dangerous one.
Excuse my ignorance, but is this actually right? Do you have a link to documentation that says this is appropriate?
This class is not using the standard Forge code format
If it's on a CommonJS environment it will enter here
remove the require if it's not needed
Oh, you are right, of course )
Add this to make sure time is stopping after print, as this is the time you want to know after the print.
remove this added semi-colon
Hmm I  don't know how this got in. I don't even have this file in my branch. Anyway I am not sure how to remove this from this pull request. I will close the request and make another one. Sorry about that
yes, but if you look at "var readerId" in this PR it is a var to an Int, I think we should stay consistent.
I did just pull this code out of my ass without checking the docs, so I'm not sure if it'll compile perfectly. I hope it does, otherwise I'd be gravely confused as to why I don't know how the things I make work....
`def send_email(subject)`
Could you not directly implement it with our api without the need to pull in metrics dependency ?
Not really, it is because of an additional "if" statement in the code..
These methods need rdoc too, or at least a small doc that points the user to the cache helper docs.
This can be just:

```ruby
options.except!(:cache, :concat)
```
Please, use 1.9 hash syntax here.
@jonleighton goot catch, thanks! WDYT about this kind of implementation:

```ruby
    def respond_to?(method, include_private = false)
      delegated = false
      super_respond = false
      # We have to prevent a race condition here:
      # * thread A checks `@@compiled_delegators.include?(:foo)`, it returns `false`,
      # * thread B defines `:foo` method,
      # * thread A gets to to the `super` call, which now returns `true`, but
      #   this is incorrect since our `@klass` does not respond to `:foo`.
      @@compiled_delegators_mutex.synchronize do
        delegated = @@compiled_delegators.include?(method)
        super_respond = delegated ? false : super
      end

      if delegated
        # This method has been delegated to `@klass`, so just look for the method there.
        # (`super` will always return `true` here)
        @klass.respond_to?(method, include_private)
      else
        super_respond || Array.method_defined?(method) ||
          @klass.respond_to?(method, include_private) ||
          arel.respond_to?(method, include_private)
      end
    end
```
I can add a test, but I think the referenced code tests that case.
+1, especially with the new hash syntax, it makes even more sense to use symbols as keys.
Thanks for changing these :)
This would never fail because of the l415 above: create_site_structure(portal). If l418 does fail, something is wrong and the security check you suggested would only hide the subsequent errors.

Besides, which variable was created in spanish? I'd say the same for comments. English-only, please. This is a Simples guideline for some years now.
by saying "always" I mean that it's not the first time you advise me to change `zip` to `map2`
i'm not sure we should change this as part of this refactoring -- it seems unrelated
Given that this is the only place where auto_capture is used as a config setting, shouldn't it also be removed with this patch?
Yes, that's the intention, and I agree.  So, I see two options here, either change the ```valid``` boolean into an ```AtomicBoolean``` or remove the ```isValid()``` method.  Thoughts?
when saying  data points, do you mean pixels??? or in Frequency values? I suppose you mean Frequency because it's a float. Or does this works for the time axis too? (I know it does not, but by looking at the code, not to the docstring).
In that code `d` is supposed to be the sum of four terms, but `len(d.args) == 4` does not guarantee that, so `d.is_Add`
must be added.
If you have 27 variables, that failure is the least of your worries. The `for x in range(2 ** 27):` before is unlikely to go well...
Why is this here? It should either be removed or more explanation given.
This will do for now, but I would add a comment in the code saying something like

```py
# This is a temporary work around to make the extension entirely
# deterministic.  An ideal solution would sort the extensions in such a way
# that the result is in terms of the simplest functions possible.  For
# example, the integral of log(x) + log(x**2) should be in terms of log(x),
# not log(x**2).

# Also note that this won't produce the same result if one variable is
# replaced with another. 
```

Unfortunately, it seems that this particular algorithm already prefers `log(x)` over `log(x**2)`, and I also can't verify what I said in the last sentence.  So maybe that will be a little misleading, but I do think that a more directed algorithm is needed.
kinetic -> potential
I would choose a representation which more closely matched mathematics.  I would use  "commutes" rather than 0.
Fomatting issue. Should be no spaces near `=`.
Turn checktyle off and add an issue to add it back with a better level of check
Why are these parens doubled here?
"malloc.h" is a non-standard header.  Per POSIX, `malloc()` is defined in "stdlib.h".  Linux includes "malloc.h" but I don't think BSD does (and I know off-hand that OS X doesn't).

My suggestion is that you guard both the new includes with `#ifdef _WIN32`.
If #431 lands, this sentence is false!
I assume that's the "Undefined allocation of 0 bytes" warning? Not a bug as long as you don't actually dereference the pointer. The spec says this:

```
If the size of the space requested is 0, the behavior is implementation-defined:
the value returned shall be either a null pointer or a unique pointer.
```
What is the 1000 constant?
What happens if you say 

    .where{question_id == question_id}

Does that work?

I gotta say that I'm not loving all of the extra lines to rename a variable.  I'd probably be happier changing to 

    .where{question_id == self.question_id}

if the above doesn't work.  Even putting the ````.maximum```` call on the next line (indented to match ````.where```` would be better if you don't want a long line.
hmm I don't know about c# but any other language I know only processes the other parts of a set of ORed elements if all previous elements did not already make the whole thing true.
not an operator
This is too broad of a condition. All non-English pages are is_localizable = False. So this would hide the drop-down on /de/docs/Schnittstellen which should show the links to /en/docs/Interfaces , /fr/docs/Interfaces , /pl/docs/Interfejsy , etc.

Should probably do `{% if document.is_localizable or document.parent %}` ?

I.e., if the document is English, or the document has an English parent.
I agree with naderman.
"You musn't use trailing commas"
This mean that you can, you shouldn't and the phpBB dev team will not allow it.
It's a must!
I think better language for the second one is:
"You must enter your current password if you wish to change it, your email address, or your username." Something like that. \*shrug\*
This looks strange, what happens in this case?
We should use an exception here anyway.
Actually the only HTTP header we are using is `header('X-PHPBB-IS-BOT: yes');`
This appears to change asset links but not links to pages (ucp/viewtopic/index etc.), therefore if the rendered template actually has any links they won't be correct.
No, only the contents of a Response object. If you send an empty Response object (i.e. `new Response('', 200);`), it will not trigger an error. That is because you shuld not be relying on the Response to make the page; instead, you shuld be using the template system and page_header/page_footer().

Basically, this is no different than using trigger_error() within the controller, except that you are returning a Response object and, if it has content, that is sent to trigger_error().
can you just fix this now. path.join should be a quick fix.
the indentation here needs to be fixed up.
Well well well, looks like we have a '=' vs '-' battle here.
You can create executables in node too.

http://markmarkoh.com/nodejs-npm-and-executables/
Just '&'.....
aeeeooottthhhhhhh!
![I'll get you next time](https://dl.dropbox.com/u/6749025/imgs/nexttime.gif)

Now to look at this project I'm apparently involved in somehow.
Maybe a more robust alt. path system
We might want to log this to the console instead of silently ignoring it.
I don't think we are allowing "Guest" to login in our system.
Doesn't seem like the appropriate test... All could be zero since you are generating all as 0 and... then you are doing a numeric test. Since values could be 000000, 000001 etc. Thus should be from 0-999999 including those
does this variable already exist in a common file that is accessed by all modules? if not, it should (otherwise, we have to update each module individually whenever we want to change the server)
would be helpful to put a more specific error message, if possible :)
All of these timedelta constructor calls would be much better written using keywords, e.g.:
```
datetime.timedelta(hours=int(time_diff * 3))
```
I liked your ``for formula in queryset.filter(): return formula`` approach far better. Especially here when you need ObjectDoesNotExist otherwise.
This is spurious.
Spurious vertical whitespace.
Do ``fill_record()`` and ``create_record()`` have to be inlined in ``post()``?
原文

    You can configure Rundeck to retrieve and store resource model data from multiple sources,

日本語はよく主語を省くのに対して、英語は主語・述語は基本的には省かない気がする。
だから日本語に訳す時、より自然な文章にしようと思えば意味が通るなら主語を書かない方がいい。
つまり、

    You can configure Rundeck to retrieve and store resource model data from multiple sources,

修飾してる部分を除くと

    You can configure Rundeck
    -> あなたは Rundeck を設定できます
    -> Rundeck を設定できます

という感じ
Three wolves?

http://www.amazon.com/The-Mountain-Three-Short-Sleeve/dp/B002HJ377A
`require('winston')`
used bizstrap thumbnails here to show ad creatives
is `this` needed? Let's drop it like we're writing in a real code.
Could we link to DateQuerySet here?
What's the purpose of the extra () here?
I don't think this is right.
If your `AggregateResultWriterFactory` only has two methods (`create_mean_curve_writer` and `create_quantile_curve_writer`), and you have two `if` statements structured as follows...

<pre>
if should_compute_mean_curves:
  # create mean curve writer

if should_compute_quantile_curves:
  # create quantile curve writer
</pre>

... why not just instantiate the curve writers directly? You can just pass the `job`, `imt`, and `quantile` vars to the constructors and be done with it.

I don't think there is a need for a factory at all. If anything, it just obfuscates the code.
Before listing the hazard outputs, I would suggest adding another print statement, like:

`print 'Calculation results:'`

So instead of this http://pastebin.com/rMW6fuLB, the output looks like this http://pastebin.com/JUPKMT1e.

Same thing for risk outputs. What do you think?
So this change should cause more code to be inlined?

The reason I believe in eta-reducing code like this is because otherwise, "str" is in scope in the context of "go", which is most likely never supposed to use "str" but only its reference to some tail of "str".  So I think it is preferable to avoid putting irrelevant things of the correct type in lexical scope to make sure they're not used.
This is under the "Contributing to Rapns" section, and only applies to the rake tasks. Running the `bin/rapns` file does load the `config/database.yml` from the host rails application. This documentation is added for the benefit of other/future developers.
Any reason you went with netw_id?

There are longer variable names in use here than "network_id," like "transport_zone" :-)
Ich bin eher zufällig über diese Typos gefallen, als das ich danach gesucht hätte...
Indentation.

Make the style consistent, like brace positions after if.
Not sure whether this is just a personal preference: I like \f$ F(x) < p < F(x+1) \f$ better
Replaced by:


    // For almostEqual, we choose a precision of 3 units in the last place.
    // This is because we assume that value is the result of adding up to three
    // values (in the dependent paired test, value may be computed as
    // "first - second - mu_0").
    if (utils::almostEqual(std::fabs(state.last), std::fabs(value), 3) {
        [...]
The proper way to do this is to use a subformula, see the git formula for an example.
We already do this for Mountain Lion which is why I presume it's needed.
Sorry, a minute.
We use `prefix+'etc...` intentionally so that it is removed during uninstallation; `etc` itself expands to `HOMEBREW_PREFIX/etc`.
Should be done as a list:

```rb
system "make", "install", "PREFIX=#{prefix}"
```
Ah ok, now I understand it better ;)
I suggest renaming this function to apply_mask.

Also, the docstring doesn't match the signature. In this function, I think that I would prefer having Niimgs in.
current_pos is the position at the start of the event.  If we move the slider, we need to call get_slider_pos() again.
Maybe just `self.patch` the label `random` in the DevNullTransport module? Or loop until you get a reply? Alternatively I'd bump the 10 up to 20 so the failure rate becomes 1:10**14 rather than 1:10**7.
Does this also work with something like this:

```ruby
module Examples
  module Name
    include Virtus

    attribute :name, String
  end

  module Age
    include Virtus

    attribute :age, Integer
  end

  class User
    include Name, Age
  end
end
```

What about if you mix in a virtus module into a superclass, then mix in another module into a subclass? I just want to make sure stuff doesn't overwrite each other, and that there's no limitation to how things can be mixed in.
What about position:fixed elements that do not scroll?
Filed #1773
The highlightConfig values are used by DOM highlighting, which is disabled in our master branch, but can be enabled by setting the experimental flag. These values should stay here for now, but can be revisited when DOM highlighting becomes an official feature.
This is currently only used in a dialog, but it's not limited to dialogs.
It looks like this 3rd parameter can be deleted from documentation
The RiskLib people are telling me that there's a specific task related to improve docs.
Why is the exact same addition in this PR and https://github.com/hudl/hudl-win8/pull/28/files?

Seems like it should only be in one.
Nothing. I missed this view. :)
I would do:

```
from django.middleware import locale

class UserBasedLocaleMiddleware(locale.LocaleMiddleware):
    ...
```
Our style is 
```rgba( 255, 255, 255, 0.4 );```
This is just a const. Don't bother with `__`.
in IE9, if I do

`if( window.console) { ... }`

IE throws trying to check window.console for existence.  (which is nuts, imho)

storing a reference like that is the way I'm working around that quirk. thoughts?
Using string.lower is not recommended, could you just use name.lower() instead? http://docs.python.org/library/string.html#deprecated-string-functions
Not sure what you mean here. If we conditionally define the method, then won't we need to conditionally call it? Or do you mean have an init_socket method that is defined as either a NO-OP or with the TCP configuration?
Yes, we should consider a mode where we set the clock to be at least the build time.
@rvagg The first case could be shortened even more to `now = perf.now` (for performance gain)
Oh, cool, I think this is correct. If every access to self.pool is wrapped by `except AttributeError`, then there is no crash race, and there is also no race where a connection can be returned to an "abandoned" pool.

I applied this also to `_put_conn` here: [https://github.com/slingamn/urllib3/commits/close-disposed-connections]
Ddi you intend to attach a `blur` handler?
inline comment
this new line is lamed
yes, that makes sense.
ignore this file:

```
# Bootstrap
app/bootstrap*
```

For information: [Here](https://github.com/github/gitignore) is a good source of .gitignore template files
You're talking about the "url" variable?  It pulls config from the entry a couple of lines down (line 62).
The complete section 3.4.2.3 has been rewriten to this:
 //Section 3.4.2.3: Delete RRs based on name and (if provided) type, but never delete NS or SOA of the zone.
  if (rr->d_class == QClass::ANY) {
    di->backend->lookup(QType(QType::ANY), rLabel);
    while (di->backend->get(rec)) {
      if (rLabel == di->zone && (rec.qtype.getCode() == QType::SOA || rec.qtype.getCode() == QType::NS))
        continue;

      if (rr->d_type == QType::ANY || rr->d_type == rec.qtype.getCode())
        recordsToDelete.push_back(rec);
    }
  }


Much shorter and should be what section 3.4.2.3 says.
I could add id to both commands--that shouldn't be a problem. For publish, we take a 'definition' argument that is label but the name argument applies the name of the new view. For update, we already take name as you can change a content view's name but not its label. I could work around those limitations though if you think looking up via name is important on Publish/Update.
I'd probably use do instead of brackets since this is a multi-line block.
@iguananaut - I commented on PEP8 higher up, but I think for the purpose of not losing all the inline comments (or hiding them all) that @eteq runs autopep8 at the very end, when everything else is addressed.
I don't quite get this one. Of course I don't know what the code does exactly but why would you only create a virtual network when its mode is l2overlay?
you're thinking to far, the assertion works on a datatype level, not a application level, 
the characters 東京 are not within the range [a-zA-Z0-9] and therefore not a valid alnum. 

The translated string Tokyo is within the range and therefore valid.
This *replaces* the previous min fee if it was greater. I'm not sure we want to accept 10 kB transactions for only nBaseFee if they add data to it...
Need `{` and `}` as per the code conventions.
It's the opposite:

```php
if (
    $method->isConstructor() || 
    isset($skippedMethods[strtolower($name)]) || 
    isset($methodNames[$name]) || 
    $method->isFinal() || 
    $method->isStatic() || 
    ( ! $method->isPublic())
) {
```
Awesome to get tests with this.  We are at a critical time with introducing untested code nearing our public release.  This helps heaps.
You're correct. It is redundant and I'll remove it.
В чем сакральный смысл этого метода?
How about just `subprocess.call(args, stdout=devnull, stderr=devnull)`?
In the various handlers when you grab the template, you call the variable `nb` as in "notebook", but the templates are most often for non-notebook pages.  Can you rename these local variables to `t` or `temp` or `template` to not confuse future devs.
Well, it's `str()` that actually failed, even if that called the object's `__repr__` method. I'm conscious that the line length is limited, and I think it's sufficient information for someone who wants to fix it.
changed the name to mach the IETF draft (audience) also added an example and a link to the draft.
revert EOF change plz!
`msgpack::rpc::client c_;` must be declared.
This is an open-source library. Sorry, I was under the impression this stuff was for general use, not krux-specific. Was I wrong?
This originally came out of wanting to do modulus on idx and otherwise. We can down-scope this to have specific helpers - modulus, ceil, floor, random, etc. rather than a general method. 

Jimmy had a suggestion of using nth-child selectors for modulus, but I feel that is mixing metaphors. I would prefer to have a specific modulus helper if the math/eval helper is deemed a bad idea.
It is meant to be a simple hand rolled rss feed people would subscribe to, to get notified once a privacy policy is updated. In this case the Firefox policy.
as i ready through the html i realized all the moving parts this page has... i am scared to test it out :-P
these shouldn't be `rel="external"`?
Jo, tohle se mi teda taky nelíbí. Zkoušel jsem tam prdnout "then", jelikož by prej CoffeeScript měl umět if _ then _ else, ale to byl parse error, unexpected then. Stejně tak, i když jsem to zkoušel zabalit do složenic. Jablíčko měl s těma ifama taky nějaký potíže... Ach jo. :-)
Fixed in 2e965de
I would put this `$data = '';`before the if is_readable() in case the inner if returns false.
set it to nil here
ya space nade ya age midi dorost benevis
```css
div.desc	
  p
	padding : 20px 0px 40px 20px
	color   : #FFF
	float   : left;
	font-size      : 13px
	font-family    : Georgia, "Times New Roman", Times, serif
	text-transform : uppercase
	font-weight    : bold
	text-shadow    : 2px 2px 1px black
```
как не нужна? ты же сам писал

Вариант 1 (проще)
Создай контроллер dashboard, а уже этот контроллер будет работать с моделью user. Бекбон ничего об этом знать не будет.

Вариант 2 (правильнее)
Создать модель dashboard и прикрутить ее к пользователю через has_one :dashboard.
Nope, I dunno why git highlighted index.html as changed file. I've only
changed pivot.less and jquery.metro.js files. In 1st file I've added
overflow:hidden property and slightly changed pivot's behavior in js.

С уважением,
Данияр Карбаев



2012/5/29 Brendan Forster <
reply@reply.github.com
>

> > -                             selectedItemChanged: undefined
> > -                     };
> > -
> > -                     $(function () {
> > -                             $("div.metro-pivot").metroPivot(defaults);
> > -
> > -
> > -                             $(".tile").each(addTileTilt);
> > -
> > -                     });
> > -
> > -
> > -
> > -             </script>
> > -     </body>
> > +<!DOCTYPE html>
>
> The line endings seem to be different now.
>
> Is it just the <script> tag which has been updated?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Code52/metro.css/pull/27/files#r890622
>
nitpick: name it "load_check_directoy", something that tells you what it's doing (just to distinguish it from the two other types of checks we have :smile:)?
that comment that you're responding too is actually just copied from pubsub_filtered which Jehiah suggested you originally wrote...
Right. I'm really just not sure what all this effects. We really need some real-world integration tests :/
Is this result set sorted in any way? Should it be sorted by name, later?
Aren't exceptions a bit brutal here ?
Why not DeploymentUnitProcessingException ?
I grabbed new blocks in the assumption that we may need more as time goes on. Especially as some messages get deleted or replaced and a new id is required. I also was trying to avoid confusion with which id's go into which resource.
Either way is fine. Since we don't modify `value` inside `_setOption()` and we don't bail early in any case, we can just call `_super()` at the top. We generally just implement whatever makes the most sense for the particular widget. See tabs as an example of varying behavior.
No need to comment here. Supressing the patch.
我不是这个意思，我是压根就不想换算，要不然就直接算出汇率哦。我想想直接就两个价格，我们自己定义，日本人韩国人不了解，我自己买puff和买mac应用的时候也都是美元结算嘛。主要还是我想定两个价格，不是严格按汇率来。就像人民币100，美元我会定成10刀一样。  

这个不是技术问题  

--  
zhoudi
已使用 Sparrow (http://www.sparrowmailapp.com/?sig)


在 2012年12月16日星期日，下午3:46，longhengyu 写道：

> In data/dev/init-product.xml:
> > @@ -11,6 +11,7 @@ > description="Server Located in California, High Speed, No Access Limit for 1 month. (DO NOT support p2p)" > image_url="http://ww1.sinaimg.cn/mw690/ba2b4929gw1dz8xb9q489j.jpg" > price="26" > + dollar_price = "5"  
> 不麻烦。便于扩展。因为日本人和韩国人可能对美元价格也不敏感，如果能显示日元或者韩圆显然更好。
> 我觉得你应该去掉domain里面的美元价格，先在配置里面加一个常数，作为人民币到美元的换算，在form里面直接相乘算出美元价格作为post的参数。  
> 等我把汇率模块做好，就不读这个常数，而是读实时汇率。
> 其它部分等一哈我慢慢看代码，今天晚上开会，就把个部分合并。
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/longhengyu/dream/pull/12/files#r2429545).  
>  
>  
>
Could these be checked directly from a libspotify header file?
I remember status bar and lock screen rely on these information or the detail of the `volumechange` event to toggle the mute icon. Both scenario looks good to me provided that everything is fixed together in this one pull :)
Instead of adding the extra parameter, below we do:

var theContact = enrichedContact || contact

can we do this before calling the addToList method so we dont modify this function?
"What do you mean? All four links on that page should trigger popups, right? Do you mean, you clicked each of the links twice, and only got a second mozbrowseropenwindow for the fourth one?"

Exactly

@timdream awesome, thanks
Fair enough, at least until we find a simpler way.
I will change commentaries and names in order to clarify **there is no memory-share**.
`this.container.children` or `this.container.childNodes` would be enough.
I'll let you discuss this point with @vingtetun :-D
I thought new versions of Jingo did this to `render` automatically.
Well, you could unyodaize it and have `while ((line = reader.ReadLine() != null)`. Though personally, I like good old infinite for (;;) {} loops and then break from the inside :)
You can just do TrimStart('.')
Never seen this exception before, is it a custom one?
nice add
Good point, I think he might have copied an older version of `lib/mailman/receiver/pop3.rb`. Will do that
We have a murmur128 implementation now, I would prefer that (see src/main/java/...)
I have mixed feelings about the use of tabindex. Does the entire element need to be "focus-able" OR does it just need to be scrolled into view?

By adding tabindex, it also adds outline styles to the element (dotted line around, on focus). Having a element in focus, for me, means that I can immediately interact with it, but there is no interaction.
timer and requestAnim ids start from 0, so they're always truthy and you don't need to compare it strictly with null or set it to null in statics.
I don't see where to make the function globalmoderator
So, it's fail we don't show anything ?
wtf is up with that whole block?
In markdown, you want to manually wrap your lines at 80 characters, otherwise your diff looks really really nasty.
incompletes.destroy_all
Also, should this not be the part of the common.gypi file?
These should probably be constants.
Are you sure about this? why are you trying to allocate just this device, libvirt style? are all other devices allocated? it wouldn't make a lot of sense to specify the location if no other devices are presepecified (unless you use a prebuilt windows vm and don't want the device to move)
I've been thinking about it but I'm still not completely convinced this is right.  But go ahead with it and see how it feels.  It's going to break the API so bump the version number as well.  Make sure the it's still backwards compatible with the data you may have in the DB from using the old API.
We need to come up with a better API for this.  How can we protect access so that you can only make IPIs to brands you've been granted access to.  IPIs are too low-level a mechanism...perhaps we should rewrite `brand_upcall` for this.
static struct sched_base_per_core percpu(sched_base_state);  (changing name to something descriptive)  Would get expanded by percpu macro into

static struct sched_base_per_core sched_base_state[NUM_CPU] CACHE_ALIGNED;
We could use `with io.open(outfile, 'w', encoding=encoding):`. I don't think there's any reason to save HTML in anything other than UTF-8, though.
I agree with you. I wasn't pleased with that myself. I had to do that because I couldn't get _getAssetParentId() to work. I think sanderpotjer has contributed some code that will fix that and I will be able to remove it.
@Gozala `paths` seems fine to me, an alternate might be `mappings` but I have no preference either way.

Referring to other modules relatively seems fine, but it does seem odd to do the same for the main module, what is it relative to? I don't understand why you wouldn't use something like `addon/main` as the main module and then being able to use `./foo` inside main to require stuff relatively
I don't think there will be many optional settings..  when I was reading this page last night this is where I immediately looked for what is the `label` property, not seeing it there caused my to look harder which is why I made the bug.
… like this one. :)
That's how it used to be before as well.

The reason is that there are some globals that are created as own properties of each sandbox there for shadowing properties of the prototype. So for example our `globals.dump` that works around platform limitations and writes to file instead will be shadowed by normal `dump`. Also we can`t just use `override` instead of setting a prototype, because changes to globals won't propagate, which is what we depend upon. Globals like `console` are introduced later in the process.

I will make sure to add comments explaining all this!
@benadida - is desired to peg to a version of jwcrypto not published on npm?
Looks like, by special handling, we skip handling it here completely?  where would special handling happen?  Is that true that no handling is done here?  Maybe worth adding a comment to that effect.
Oh wow, a major version change. Do you know on which gecko branch this version is based on?
Let's change this file name (and module name) to "application" - it really has nothing to do with "engines".

Also, let's always load this file (I know I said not to in a previous comment). We can then override the writer method to raise an error if it's not supported:

```ruby
RSpec.configuration.add_setting :application, :default => ::Rails.application

unless rails_3_0?
  def Rails.configuration.application=(*)
    raise "Setting the application is only support on Rails 3.1 and above"
  end
end
```
If this is PG backups, I'd specify that.
Actually I RF'd this a bit now (see upcoming commit) where a debug function is defined even if 'not __debug__'. Maybe a very tiny speed penalty (but I'm not even sure of that) and it means that stuff keeps to run even with '-O'. Currently the RF only implements debug as a function, however (very lightweight), meaning that debug.register(...) would still fail - so such statements should still be guarded by 'if __debug__'. Another approach would be to define something like a BlackHoleLogger that, if 'not __debug__', acts like mvpa2.base.verbosity.DebugLogger but does absolutely nothing with the input.
@sindresorhus Does that mean remove whole blank line?
In fact, but it only supports 5.3.2 and 5.3.8 minor versions of 5.3.
Should be getSharedManager()
This should be analyzed too.
Zend\Acl\Role\RoleInterface
Yes, I plan on refactoring all the navigation helpers to accept strings. This is still a work in progress.
`Request` != `Response`. Those might be similar (or even equal) in implementation, but are definitely opposite in context.
Yep, something like `Zend\Form::SOME_CONSTANT_THAT_EXPLAINS_THE_PLACEHOLDER` will do ;)
Confused here. In the AnnotationManager, you're still using clone + initialize(). Since this constructor has required parameters that derive from the individual annotations' content, how would this work?
Yeah, first I passed count in parameter (so it was string) but then changed my mind. Will fix it.
it's removed in last commit
@unknown_value = opts[:unknown_value]
this is test comment
@anti Indeksi? Performoiko?
Can't you move the class initialization to after the if clause?
So I need pg and can't have sqlite3 for heroku.
However thin, unicorn, and rails server all need sqlite3 to even get started.
CS Nitpick: I would rather write:
```php
$kernel->runCallback(
    function () use( $signal )
    {
        // blabla
    },
    false
);

```
Also this and all others in this pull request fixed, please review and retry pull request.
About rename: I'll do that when adding the EasyBlock baseclass.
hmm, it is indeed not in a dedicated method in 2.0
it is strange to take a mutable parameter, mutate it and return it. I would say this return void.
Why is this necessary?  pixels should be allowed to be null.
not sure I understand the point of deleting the 'tri' kwarg...
Well, the question here is what to render into the page when a macro fails. This code renders `{{ FooTemplate }}` if executing `FooTemplate()` fails with an error. That doesn't provide any context.

I'm wondering if there's something more useful to render here - such as a big red MindTouch-like error placeholder with a link to the anchor of a log message (to be rendered in the implementation of [bug 733831](https://bugzilla.mozilla.org/show_bug.cgi?id=733831)). But, I'd want to make that inline error message configurable and localizable from kuma.
It's used on both mission.py and performance.py, so I figured it might also get used on other pages in the future. It seemed like a reasonable thing to add to base.py, but it could be moved back into each page object if you think that makes more sense.
Same question here.  Why not declare this above as its own variable?
This might be due to bitrot, but in master right now, after this line, we have a call to setup and a tracksetup event is fired.

Code looks like this:

      // Trigger _setup method if exists
      if ( track._natives._setup ) {

        track._natives._setup.call( obj, track );
        obj.emit( "tracksetup", Popcorn.extend( {}, track, {
          plugin: track._natives.type,
          type: "tracksetup"
        }));
      }
Can you use flask-specific style for tooltips, so if someone will want to use .icon-question-sign in their application, it won't mess with tooltips? (use data-role or something, like in form styling).
why password? arent we using key based login?
can you add a bit more description, e.g.


   param :search, String, :desc => "Filter results"
   param :order, String, :desc => "Sort results"

also, we did not made a final decision of if we should or should not include pagination in the api, but limiting the default results to page_size is not trivial?
Changing ```gs_fl``` to ```gs_rt``` here breaks saving PDFs for me.
why did you revert this?
this expression could be a private utility method
What's the point of the json here?
Yeah, it should be 18 or (4 nPr 2)*3.
No idea why we need to do this now... I'm just glad I didn't have to mess with the `var undo = "a big mess"` at the top...
These two statements need to return just the `self.status` and `self._status`
It looks like there is a file for omniauth in the generator to be copied but isn't creating it in a new app for some reason. I will investigate this and create a new issue for this problem.
Unless you think in CGS units, in which case, why did you just change my values to SI units? 

    quantity_in_cm + quantity_in_km = quantity_in_m

I stick by my initial proposal that  we take the units from the left object and just make this very clear in the documentation.
Only include this line when is IE browser
iep! This should be removed. There is no need to call it twice (see below)
!= false?
We should keep the name of the Interface.
can we have a better exception like "node type definition does not allow property with name $propertyName"?
Understood... but...

Let's say there is something wrong with our assumptions about migration 3.  Like, for example, let's say that it assumes a non-NULL value for a column that isn't explicitly defined as NOT-NULL, and that we wrote the query in a way that breaks if it hits a NULL.  (Or we have any other edge-case bug in our migration query--I know, it could never happen because we are awesome... but...)

So it's a bug in migration 3 that we never ran across in-house because there is some edge case in this user's data.  The user was up and running successfully with the previous version of puppetdb, even though their database contains some data that we didn't expect.

If we have a transaction around every migration, then this user is stuck at migration 2, which is likely incompatible with either their previously installed version of the puppetdb code *and* the new version of puppetdb that they are trying to install.  They can keep trying to start the daemon and it will keep trying and failing to apply migration 3.  So now they're stuck and they can't even downgrade... they can't run puppetdb at all unless they either:

1. blow away their db
2. dive in with some raw SQL to fix up the unexpected data, or
3. wait for us to release a new version with a fix

If the migrations are done in a single transaction, then at least we've "done no harm" with the migration failure, and they have the option of reverting back to the older version until we have a fix ready.

Does that make more sense?  Basically I think that we're talking about a slightly improved experience for folks who hit an intermittent, resolvable failure during migration, at the expense of introducing the possibility of a non-recoverable failure in the worst case scenario.
This will cache the signed URIs in Redis, which probably isn't a good idea as the signature could expire while cached. This should probably move up a level to sign URIs that come from both redis and cassandra.
I'm not a fan of counting down, we don't really do it anywhere else. Can we just keep track of how many we've done and check whether that is the same as the total we need to do ?
Hmm, I think this will read the package.json file from disk each and every time it needs to do a comparison for sorting (e.g., O(N*log(N)) reads of package.json). Probably fine for it's purpose though, I don't see it ever becoming a big problem.
I think this class is still needed, if we want to keep the current behavior, which is to display the diagnostic dialog by default.
I included an interface more out of habit than anything else. I always default to having an interface.  In this case, though, you're right that it may not be necessary, since the important parts of the interface are already defined by RequestMatcherInterface.  I'm fine with removing it.
without space was right
:+1: oki
if we have any funcs, add them into the context and unset them. Note that its very important that we CANT change the base template. that would be a bug causing us to lose blocks/funcs attached to the old one.
Good cleanup, did you added this into the mvp module?
@voleg то, как вы реализуете метод - всегда на вашей совести. Но от вашего метода будут ждать результат, в задании написано какой. Что будет изменено x% исходной последовательности.
У вас выключен ARC? Даже если выключен, то тогда полно других мест, где неверно инициализированы объекты. При ARC autorelease не нужен.
Added copyright notices to all files, will add file overviews
в руби есть такое соглашение, все что отвечает да/нет должно заканчиваться на знак вопроса, напр self.right?
а в базе может лежать просто right (true/false)
Question.new (name: nil, content: nil).should_not be_valid
```ruby
"#{self.class} is using ssl_strict=false, which is insecure"
```
I would suggest you introduce a slideIndex property on the element that stays in sync with whatever slide is the current one. You can then add a setter for this property, that when set, jogs the slideshow to the user-specified index.
I thought it was the other way around?
Proponuję osoby pull request, lub poprawkę podczas mergowania.
No real reason -- this was refactored out of the client as-is. I think using the accessor is a better plan, so will fix.
Yeah but I'd like to clean the example app up in the near-ish future anyways.
My original thought was that it makes more sense to talk about merging when given a bunch of different subscribables, but I guess flattening an array could also make sense.

I could go either way.
Do you prefer "user:password" exported in clear text to a shell variable ?
This function name doesn't make any sense. It updates the UI based on the current state. Could you change its name or pass in the current state. A comment explaining what it does would be nice too.
I haven’t checked, but isn’t there a space before this comma in the rendered result? ;-P
Hmm.. I saw the divide warning as well. I will look into it, but it may only happen for the test data where Im(CSD) is exactly zero. Maybe I should add some phase shift.
We currently recommend deleting master altogether since that what Astropy suggests. Makes some sense to me, although I probably won't bother switching.
no need for the public folder
If we decide we do, I made a gist with all of the known UAs in a tuple:

https://gist.github.com/2884333

I think in this case it might be worth it: in general I don't trust UA sniffing, so we want to be as comprehensive as possible.
Why are you removing the concept name
miscopypaste, not the PatientService
Rather than comparing this here, I think it would make more sense for there to be a #debug method on the ui object that would only produce output if TestKitchen::Debug was set.
While you're fixing code, you should add explicit exceptions for SystemExit and KeyboardInterrupt. Something like this:

```
    except (SystemExit, KeyboardInterrupt):
        raise
    except:
        ...
```
duplicated ``be``
`platform.faq.create.questionHint`
Maybe we should add an index including both `#{col}_id` and `#{col}_type`? I know It would work fine in MySQL because it can uses just part of the index, unsure how it would play with other databases.
we should definitively cache it here because once read php://input is empty.
We could remove the caching in getPutParams() and getDeleteParams() as they only call getRestParams() + checking if it is delete or put request.
Вообще-то я специально этот вопрос задавал. И сказали, что как данные
указаны в коннете - так они и передаются
просто по ссылке. Можно. Но зачем?
應該是 `.pic` ?
Recuerdo que ese null yo lo puse intencionalmente. Voy a revisar mejor esto.
This block of code could be spaced a bit to improve readability.
I can't cite the standard at the moment, but this suggest what I believe: http://stackoverflow.com/questions/8549659/c-namespace-and-static-variables
No, I just didn't realize real mode lacked it until I was running tests there, at which point I didn't quite need it... I might be able to fit that in but am a bit afraid at this point of botching these test runs.
NGHUTPR
Its a stylistic thing, but IMO reusing variables unless they're in a loop or something often gets confusing and can lead to bugs.
Tässä täytyisi itse asiassa vielä tarkistaa:
~~~clojure
;...
(and (empty? a-seq) (empty? b-seq)) true
(or (empty? a-seq) (empty? b-seq)) false
;...
~~~
sillä jos toinen lista on tyhjä ja toisessä on alkiona `nil`, palauttaa `first` molemmille listoille `nil`.
Thx Galder, I'll take it :)
Interesting… I assumed that returned another mutable array.