labofsahil/github-event-dataset-2012 huggingface dataset:
I would be tempted to move this back into the original line so that:

```
if 'antialiaseds' not in kwargs and ec.lower() == "none":
```

becomes:

```
if 'antialiaseds' not in kwargs and is_string_like(ec) and ec.lower() == "none":
```
It is used.
https://github.com/mozilla/Socorro-Tests/blob/master/tests/test_crash_reports.py#L150
please add a self here, this way the find will work.
s/*_delete_locator/*self._delete_locator
In the rest of our projects and our style guide we've kept this passing in the tuple as it's consistent with the way the WebDriver API works too.
тут специфичный примитив. по идее если есть массив, то у него обязательно есть 0-ой элемент. а вот raw может быть не так
Так это там архитектура меняется, а тут оно rules, PrimitiveRule и только вокруг них. Опять же никто не решил к какому общему названию приходить. И опять же это локальные переменные внутри функции - они по названию говорят что значат и это хорошо.
And follow the name convention. All-caps names are for constants.
This is redundant, I think, and not necessary -- you're calling vec on the arg, so it can really be any sequence. No need to place artificial limitations.
@christianv I don't think it can be combined, because ``selected`` could be set in it, and we'd still need to check for that.
Do any of Sam's design specify a default picture?
This would be a larger re-factoring of the code. Let's leave this for now, and address this issue later on
I am not sure pointers to SGMatrix would work for modular interfaces, did you test it with python modular or so?
We actually shouldn't track find-as-you-type events in the history, only actually submitted forms (through ENTER key or "search" button).
This will require adding a new `skipHistory` argument to loadPanel().
we can move this i think.
交え
(not search specialists) のところは (unfamiliar with search techniques) かなぁ.
Nit: you should probably cache `node.nodeName.toLowerCase()` since line 14 and 15 both compute it.
So this could be misunderstanding on my part. I used the random part because I thought if I open a table whose name is defined in "scenarios" then it could be possible that table was used in a previous test . And as tables are flushed to the disk, so in order to ensure that table was not created before I should add a timestamp to make sure table created wasn't created previously.

There could definitely be problems with my thinking. Also, I think we can drop a table from session so it doesn't exist any more and then recreate it.  So kindly let me know if this way of creating table name can be helpful while testing a an empty table. 

I'm sorry if I sound vague, I can try to rephrase this.
Please make this on() to follow TheatreScripts Actor on() function
Oh yeah, he's going to be miserable as shit. I'm actually tempted to rework this into a Nano just so I can show the world all the ways in which he is fucked, but I'm liable to say the same thing about next weeks prompt, and the one after that.
どうなのこれ？
Is this supposed to be part of the previous line? If not it should start with upper case. It seems like it might be a note actually and you may want a @note tag. Also, wouldn't it be best to have the option to clear or not clear if you are saying what is in the mysql manual doesn't apply any more?
I like this idea, we should probably merge this into webmaker styles or something -- like a UI block
That sounds good to me :)
Nested APIs? This work?
Anyway, space around `+`.
This can be some constant (top-level variable in some module) in the code.
But how do I know if a user already authorized our application? When I have to decide which link to use (authorize/authenticate), the only information I got is request token key, request token secret and confirmation callback from GET response. Tokens cannot help me as they are not permanent
I don't understand why you use two views here? Why you don't have one view, where on GET you return order. On POST you change it?
I have no idea how, I don't understand what this code does. Why do we need two default values?
Yep that is what I thought but it would not compile.  Left that there for later until I have time to look at it and test on iOS.
OK, ta.

On 19/02/12 20:03, Joe Groff wrote:
>> @@ -498,12 +517,21 @@ inline wrapDivide(a:A, b:A) : A = numericDivide(a, b);
>>   [A | Integer?(A)]
>>   inline wrapRemainder(a:A, b:A) : A = integerRemainder(a, b);
>>
>> -[A, ..AA | equalValues?(A, ..AA) and countValues(..AA) != 1]
> The `equalValues?` predicate is correct for the `wrap*` functions, since they don't do any type conversion.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jckarter/clay/pull/221/files#r465628
missing space before `'expression'`
I think we want to implement EventManagerAwareInterface if we have setEventManager and getEventManager
i think, is it hack..
use blizz not spell for Soul Shard create? like ID - 95810 Soul Shard Energize
how can this line even compile
I think we should also have a test for the ```direct_io``` option for both dense and sparse.
use a ``throw log.couldNotParseDate( string )`` so that message interpolation and internationalization are an option
What is this profile for?
It looks like it's running the tests for me by default. They succeed as I've installed Redis, so I guess it's using my local running instance.

Could we remove the profile?
Please fix the underline - should be the same length as the header.
line me up with open parenthesis, or possibly move up to previous line, if length is at most 79 characters.
Not sure I understand what you're asking here?
I'm taking into consideration what you are saying and this is the initial version on the test. I run the tests on the CI server and see what are results if it requires tweaking then i'll do it, But for now that's best estimation based on what I know now. Also we did that for other APIs as they sometimes fail because internal error which we don't have anything to do with
Can we get rid of this print and use logging instead?
It's been in the style guide for a long time, but I know we've discussed it since. On the next line keeps it consistent, but it's not lining up with the actual function which is a bit weird. I don't feel strongly, but maybe we should make a definitive decision.
Generally we don't commit commented-out code; is there a strong reason to keep this?
isn't this dangerous that the model.exog get's overwritten? (if we want to calculate margeff for it)
Can't you leave this 1.0-stable since `89d3f79b13c8a12dac5d1c9b71f6b42176102f7b` is just an update to that branch?
Wouldn't `config.timeouts[nil]` return nil, since the `nil` stage doesn't exist?
Just try it:

```ruby
block_data.fetch(code_point.to_sym) { get_range_start(code_point, block_data) }
```

Ruby blocks are [closures](http://en.wikipedia.org/wiki/Closure_%28computer_science%29) that means you can access from inside of them anything that was available in the context where they were created.
Maybe clarify that this is the linear dimension, not area.  I could see this being slightly ambiguous.
This is not your typo I think, but is the last `ymin` missing a `y`?
s/is/is not/
I already reintroduced the no arg constructor, but will make use in this location of that constructor as well.
You should not have template functions in the bindings module. Declare the function as it should be according to the [Objective-C runtime reference](https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/ObjCRuntimeRef/Reference/reference.html) and place a wrapper in `dwt.internal.objc.runtime`. Look at how it's done with the other `objc_msg` functions. It needs to be casted as well.
Yes, this was more for when I was debugging the output -- and although it appears in the proper line, I thought that the end result was nice, so, I left it in the pull review, but feel free to remove that if you want .
Why define `day` to be nil?
This is not the HTML5 syntax, this is a syntax HTML5 allows, just like short tags in PHP or just like javascript allows you to omit semi colons.
Adding a slash at the end of the tag has a meaning, and I think that semantic code is best than lazy code.
better to explain what the feature manager does, appears it is equivalent of registry.js in rpc
I've changed the registerSender method to throw an exception if the caller tries to register with itself.

I'll check if the other occurences will need to try catch this as well.
OK, so you're saying: create a method (say, of ctrl) that does the new trial doc construction/insert; and just accept that the bandit will have to use it, instead of something in the return value ... 

I don't mind that SO much, but it would requre the bandit to do something sort of funny ... e.g. return one of its values and insert the rest via control.  I find that a little odd.
Change the name of parameter
Script file deleted among other unnecessary files!
Ok added stuff into readme and extended phpdoc.
Why is this needed here? ^
Не закрыта IEFE; Events и все подобные не экспортируются. `exports.Events = Events`;
This function looks very similar to the above function?
А как еще можно? Я просто не нашел других вариантов
Программа должна возвращать код ошибки.
Кодировка должна быть UTF-8.
Sounds good, definitely more fitting to the Planner API. I'll see what I can do and then update the pull request.
Adding these acceptance tests was a mixed blessing. On the one hand, it is a very rigorous test because it verifies the ability to play through an entire game using the same inputs as a player would enter. On the other hand, it is extremely fragile code and even small problems can cause it to hang. This feels somewhat familiar to using something like Mechanize to test a Rails application: it gives you a very similar testing environment to the real world use case, but is very prone to false positives and false negatives.
Total hack. This is a sign I am trying too hard! I should instead be creating an Enumerator here, or storing and incrementing an index.
Like the api, bid.js (browserid interface module) is more abstract; doesn't need to look up any server config files.
PEP 8 issue: test_search.py:20:5: E301 expected 1 blank line, found 0
What is an appropriate <code>value</code>? Should this be changed to <code>text</code>?
why not: 
location = null;
Why both the XML AND the PO files for the language strings ?
Normally you only need the PO files. I suggest deleting the XMLs.
Thanks!
This has an effect on other code - is there a reason you can't use stub and mock here instead?

Generally including a module into the global scope is a no-no, only very specific use cases should do that.
there's no need for `self`, here in the other above.
if this last condition is true, you can get multiple computations of the same. e.g.

mode == 'amg' or 'lobpcg' and `n_nodes < 5 * n_components`

then the arpack branch will compute and then the amg/lobpcg branch will compute it again.
The object doesn't need to be listed as a parameter here
thanks - changed that.. my bad :)
if it's used only internally don't use an attribute but just a local variable
needs an `_` after the `>`
This already exists in the `#if STRUCTTHISREF` block above.  It might be best to remove this if block and move the syntaxCopy above the call to semantic, instead of moving semantic down.  I'm not sure what the effect of setting `isref` before vs after semantic would be.
As discussed, made type2variantCpu  public
Don't remove this TODO
change to
if (left_ != NULL)
because you would want to initialize your list of operator tokens from a common source.
Not exactly the same thing, since ```findFile``` normalises the name, which is an important part of the dedup.

Create a new private method that both ```findFile``` and ```addSuper``` would use, that would return the index of the file or NotFound, seems like a good idea, though.
With your branch, probably not.. 
I guess my commit should have change this to , GROUPED, even though in my commit it will not compile, as it depends on yours, but as it's a subtask and dependent on yours being merged 1st/same time I suppose that's ok..
I do need the ip address to build the RemoteFilename for retrieving the thor log file.
This shouldn't be a member.  It is used for two distinct uses, and should probably be split.

i) supports trim without casting via string.

ii) Should probably be checking isAsciiString()
It looks like one was moved, but one was accidentially copied.
Yes it is, but  each call to heap_push_up uses "heapsize" to know how many rows are already in the heap. 
So if I set it to numRows, it will crash on the first pass
liable to lead to KeyErrors unless input is carefully constructed. It could be a little more forgiving if one or more of the attributes is not specified. I'd also suggest going with a named tuple here rather than a map.
The code you have in ``conf.py`` is correct. This line is incorrect because ``appconf`` prefixes what you add in the conf with ``ACCOUNT``.
In hindsight, I should have taken a different approach.  I was thinking that we would have separate code for HA environments.  I'm on the line to develop HA for Folsom over the next several weeks.  I will make sure I take a different approach this time.  Should we have a variable like $ha_enable with an if $ha_enable that has all the ha-specific code? I can go back and make all the changes after Folsom HA if you think it makes sense.
can you change this to cinder::client. I just added that class to cinder.
Faudra (re)vérifier mais je pense que pborreli l'a changé partout déjà (j'ai tout "reviewé" sa PR hier... ;))
Have we decided to use `const` in documentation? I'm not really against it, I just want to ensure that it is expected.
Nope this is a regression, if you can send a PR to restore just that behavior it'd be great. Seems like the implementation was wrong, it should check all installed packages that will not be updated/uninstalled, and those that will be updated should be checked too, but then the install operation should contain the target package of the update operation, and the update should be removed.
Since the real `htmlpurifier` package has no hyphen, I think `htmlpurifier-bundle` would work better.
I think you're missing the "${}" on variables in this call... and the two others below :)
save as above. I think this method only tells you if one of the titles is matches. you want it to tell you if all of them match. There are a lot of way to do this. One way is to invert the logic so that it's set to fasle and exit if it ever doesn't match or you can keep the isTextPresent set to false and add an else cause that exits if it's ever reached.
@christianv An SO thread says "However in Rails you probably won't be using it directly. Usually you use hash.to_param, which will use CGI::escape under the hood." Any truth to that?
```self.server``` is a confusing name, perhaps ```self._process``` would be better.
you miss a call to invalidateFilter here, which means it won't re-search if you change the pattern
I think a reference to "tools/msftidy" would be super useful here
Fix, thanks todb-r7.
That's not a valid disclosure format.   Aux modules don't actually need this information if not available.
Are you sure about this change?  Can we really remove the check for `this._textureAtlas`?
If the horizontal and vertical origins are center, it will return the center.
It seems like this code will clone and recalculate the frustum on every frame while in 2D mode.  Can't we detect when we need to recalculate?
I have fixed feelings on putting files like this in the Cesium repo.  On the one hand, they're generated by MapTiler or gdal2tiles, so users of the TMS provider are likely to have them as well.  But on the other hand they're not needed, and it's a worthwhile goal to keep the repo as lightweight as possible.  Do you have a strong opinion one way or the other?
Spoke with Stephen about this and the logging level will be quiet, normal and verbose as implemented in a pending change.  Normal console log levels do not translate correctly to the intended purpose for the log-level argument.
Mobile Web has accessors.
Would a switch statement work here?
Always open braces in the following line
Any idea how to address this TODO? Otherwise we should just drop it.
ok, I can look at this on Friday. Since it is a backwards compat breakage we should get it in ASAP.
Darn. Jslint doesn't have an option to disable this specific error. Jshint does though.
дефолт - массив, строка - просто доп. фича. поэтому, мне кажется, стоит так
Не смущает, что потом она везде с сеттингами (в которых она же без суффикса) и передаётся?
А, круто
Yeah. Example code is inserted pretty much verbatim - including indentation. Don't indent examples at all. Also, be wary of how long example lines are, because they won't wrap, and long lines will cause issues when the browser window isn't wide - or when the PDF or kindle versions are generated. IIRC, at one point, Walter was looking for them to not exceed 40 characters (though I could remember incorrectly). Regardless, they definitely shouldn't approach 80 characters (let alone exceed 80), or it'll cause problems.
Bug 5625 is caused by using varargs. So new format function might not have the problem, because it uses template tuple parameter. But I'm not sure that...
with best i meant "recommended"
これは、数を返すメソッドにするか、せめて`print_task_status`かなぁ。`stdout`は「標準出力」という名詞です。
we discussed that on wednesday. And you said that this would be enough for the start : ) I will change that in a later pull request. This pull request is big enough for the start I think.
@ofZach would be great to have some line breaks here every 100 chars or so, that is one serious monster line! :-)
If you change to GetRow, you shouldn't have to do this...
second should be no_selectnth
Does this work without a setup.py? I think it should be clear from the comment that this macro expects a setup.py to do the lifting.
Don't forgot to include this in the base template as well so that it appears in the footer!
You're right! I'll patch it later and commit.
isn't this the same as:

```ruby
extend ::Chef::Mixin::ConvertToClassName
```
Why a space at the beginning and none at the end, unlike on the previous line?
bad whitespace change here
Also, maybe add a rule for string concatenation, e.g.

```
$string = 'Foo'
    . 'Bar'
    . 'Baz'
;
```

Probably looks a bit odd at first, but what are the alternatives? Align the dot with the `=` sign? This just wastes time.
Generally, new code in druntime and Phobos should follow the style conventions, i.e. braces on a separate line, and 4 space indentation.
"Thrown on null pointer dereferences."
>I had to remove the call to "runModuleUnitTests" in "rt_init".

Why?
the route definition is wrong, see http://guides.rubyonrails.org/routing.html
not so important from my POV
It implements ``Zend\Filter\FilterInterface``.
But that wouldn't make sense under the TOC:

```
Advanced Server Installation
   ...
   Installing OMERO.tables
```
Need to check the corner cases for both end of line and start of line.
Might be good to list the complete set of allowed content types somewhere.
Just use == instead of the Equals method.
imsplitbit: Lets talk about it at the dev meeting. It seems like a few people (including me) would be ok with defying the standards on this one.
We could just use `puppetlabs_spec_helper` as the gem name if we want something more generic
we should add a link to the prototype: 
https://play.google.com/store/apps/details?id=com.github.opensourcefieldlinguistics.android.lessons

@Kedersha  is there anything else you want to add to the white paper to document the module for other research teams?
This is being normalized in the ticket below:
https://jira.duraspace.org/browse/ISLANDORA-780

I'll change this pull request to handle the anonymous user rather than an empty user.
You used sign_in_page to abstract, new_user_session_path, why don't you use the same here?:

visit log_out_path

this make me think if we should change the convention landing_page, sign_out_page, ect. To landing_path, sign_out_path, etc. That way we could use the same pattern when following urls that don't have a corresponding page.
Plus this have the nice side effect that we could use semantic named routes so we don't have to write the helper methods.
This covers the case where the actor is adding an actee to the organization. At that time the actee may not have any organization associations. You're right though I will add a note to clarify this.
I think it would be useful to have a brief comment on the extent to which the server is allowed to mutate fields per the spec.  In IMAP, stuff is immutable and we are happy, but it's not clear we have that guarantee here.  Also a brief description of any mutations we know that servers/UIs afford could be useful, like if we know outlook lets you edit the subject.  (I forget if it does.)  No need to go trawling through bugzilla / that enhancement req on Thunderbird to let editing messages...
Unless there's a really super-good amazing reason, these (``get_es_type`` & ``get_type_and_id``) should be methods on the ``SearchBackend`` class, which would allow easier customization.
Phil notes that IndexPage should be in management not management-servlet-api. I've already got this change in a commit waiting. object becomes class of course.
Sure, didn't want to bring in another dependency, but it's no problem for me.
okay, well your choice, my vote is to move to the initialized, then remove that event all together. Then we can clean up the CCM as well.
I agree it is wrong, but I would prefer to just hit the WP show method since we have the object passed to us. I have no problem with you pushing your branch if you wish.
enforce that user can not change createdBy or ModifiedBy
this should be ``getDefaultOptions`` in 2.0
The outer bullet points are the demo script, and the inner ones are the startup script running in the instance.

Maybe: 
Waits for the startup script, which does the following:
Do we need to check type?  I think we can just always do the !!allowSubDomain