labofsahil/github-event-dataset-2012 huggingface dataset:
Didn't we want to get away from using these untyped sendMessage calls? If so then maybe new code should stop using them.

You already got this really nice OPSF interface, so why doesn't the action set implement this interface directly. Then all this unsafe squeezing calls through sendMessage goes away. You could safe a ton of code and make things much easier to understand.
Bunie, STOP THE SPAM
but the things you do for love are going to come back to you one by one.
The fact that there are no existing tests and that you presumably also won't have time to fix any new problems you might introduce makes it all the more important that some tests be written!

Speaking from a standpoint of idealism here and recognizing the reality of time constraints, of course. But consider yourself nagged. ;-)
Ach, ich sehe schon, die aktuelle Seite. Gut, das hätte man auch mit javascript/jquery machen können.
hmm how could you have this to say a file.
xd thank you
Aha, that explains why they weren't in here already (`relativenumber` is a 7.3 feature too). I'll update my patch to add the 7.3 conditions as soon as I can. :)
Already pushed.
@jbridson This should probably apply to all buttons in a gridfield row, right?
@richardkchapman You were correct about the wrap, I fixed and tested in 32/64 environments
Revert this !
I don't really think that's a good idea to limit the use of pax-logging to 4.3 as there's no real reason to do so.
At least, we should then override any computed range to make sure older versions can still be used.
It seems to me it goes a bit against https://github.com/ops4j/org.ops4j.pax.logging/commit/43acc4617d8e10c29121103e1ab286d83acf1816
@derekhiggins for redhat, you are replacing all of the various packages with a single nova package?
basically i got all the time so ready when you are
I dont see any other commit XD
I replaced these decorators with @needs_account somewhere in my code... thanks for pointing out that these should be accessible to non-admins.
Это не работает для N == 0. Если бы были тесты, то такой баг скорее всего был бы пойман.
was that right at the end? think that happened to me to and can be ignored. I'll look at this all again one day and finish it off.
bro, 
u are asking:
1) to fix a comment
2) telling me about libaudio-msm7x30, https://github.com/CyanogenMod/android_hardware_msm7k/commits/gingerbread
3) claim a fix for fc which have nothing to do with this commit

dont blame me if i'm trolling :D
Sounds great. This is the first practical example as I know which uses this conditional evaluation feature :)

One reminder is that you have to compile the two versions under different directories so their cache files will not clash with each other. See my first draft code.
This is not backwards compatible and is also somewhat inconsistent with other parts of fog.  In general I've opted to have named arguments for things that are required and left options for the grab-bag of things that are optional.  I think this is a good pattern and it would probably be best to continue following it, but I'm certainly up for discussing this further (the same feedback applies to some other files below, but I won't repeat myself).
`ierr` is used only under special circumstances and can be made local.

Consider `USE_MPI` defined and `_is_initialized = false`, then what is the reason to call `checkError(ierr)` in line 94?
The `|| false` is reundant here. But stepping back, the whole call is redundant because you're failing on `!checkNamespaces` so if that's the behaviour your want then the call to `matches()` could be avoided all together *where there are namespaces*.

**But** I'm not sure this is appropriate anyway. You're bypassing the dupe-check where there are namespaces but it's still invoked where there are no namespaces. Either we dupe-check or don't bother at all. I'll have to get back to you on this, perhaps we could/should remove dupe checking, it would certainly speed up `add()`. I guess you're telling me that jQuery doesn't dupe-check so that probably means it's not going to be a big deal for Bean users because they're mostly used to it working similar to jQuery.
What is the purpose of this function if it simply returns the value it is passed? The behavior does not seem to match the docstring at all.
Limit context of event to the contextBox of the chart.
I'm not a huge fan of putting in IDE specific stuff if we can avoid it (but that may be because I use Intellij :-))
is null not allowed any more, reason for change?
Always use vars-to-immutable-datastructure _unless_ you're using a Concurrent datastructure: why?
- You can freely share the data structure if it is immutable, and changing the value locally keeps mutability to the smallest possible scope.
No, I'm saying that it will _always_ throw the IllegalStateException?
out of general curiosity I wonder if it's not preferred to skip `private val` for non-public constructor parameters?

Without `private val`:

	scala> class Foo(bar: String) { def fooBar: String = bar }
	defined class Foo

	scala> :javap -c -p Foo
	Compiled from "<console>"
	public class Foo extends java.lang.Object{
	private final java.lang.String bar;

	public java.lang.String fooBar();
	  Code:
	   0:	aload_0
	   1:	getfield	#11; //Field bar:Ljava/lang/String;
	   4:	areturn

	public Foo(java.lang.String);
	  Code:
	   0:	aload_0
	   1:	aload_1
	   2:	putfield	#11; //Field bar:Ljava/lang/String;
	   5:	aload_0
	   6:	invokespecial	#18; //Method java/lang/Object."<init>":()V
	   9:	return

	}


With `private val`:

	scala> class Foo2(private val bar: String) { def fooBar: String = bar }
	defined class Foo2

	scala> :javap -c -p Foo2
	Compiled from "<console>"
	public class Foo2 extends java.lang.Object{
	private final java.lang.String bar;

	private java.lang.String bar();
	  Code:
	   0:	aload_0
	   1:	getfield	#10; //Field bar:Ljava/lang/String;
	   4:	areturn

	public java.lang.String fooBar();
	  Code:
	   0:	aload_0
	   1:	invokespecial	#15; //Method bar:()Ljava/lang/String;
	   4:	areturn

	public Foo2(java.lang.String);
	  Code:
	   0:	aload_0
	   1:	aload_1
	   2:	putfield	#10; //Field bar:Ljava/lang/String;
	   5:	aload_0
	   6:	invokespecial	#20; //Method java/lang/Object."<init>":()V
	   9:	return

	}
It isn't visible in public API docs since it isn't public ;-)
look on the line above, also checked when reading the config
oops? :P
Wherever possible use `System` Helper
If I'm reading this code correctly you're assuming that `abs(signal + noise)` is the same as `signal + abs(noise)`, which I believe isn't the case. To get a rician distribution I believe you need `abs(signal + noise)` (otherwise I believe it's a Rayleigh distribution).
No gripes with this PR, so I'll just comment in general on the dangers of floating point subtraction and losing precision:

```
s = np.ones((10))*1e10; n = np.random.random((10)) * 1e-5; sn = s+n
np.mean(sn - s), np.mean(n)
```

However, since this situation would only occur if you have very small noise levels, it really doesn't apply here :)
Why isn't it ready? You mean based on parsing? If it's based on parsing, it's a larger problem really. We always need to detect when extradata or info in a stream changes properly. So it has no relevance to the problem at hand really.
Yup will add.
Make i unsigned int and you don't need the cast to int to avoid the compiler warning ;-)
Waarom dubbele quotes? Spaties tussen argumenten (spatie na komma)
One final itsy bitsy tweak:
error should read "cannot be changed (has micro-injection attempts)"

Ignore what I said about capitals, I've seen all lower-cased wordings in other error messages.  My mistake, sorry.
Is this scoped to a user? Since we aren't using this functionality anywhere, should we just remove it?
OK, I'll revert the commit then.

On 29 Nov 2012 14:05, xeor wrote:
>    In README.rst:
> > @@ -74,7 +74,7 @@ usage
> >       - Description
> >     * - ./taggo help
> >       - Display help
> > -   * - ./taggo run_once
> 
>    init is a better wording if you want to initialize something. I would
>    use init to create a config set or something like that. run_once is
>    ment to be used to do exactly that, run it once. I dont think it is an
>    good idea to rename it.
> 
>    —
>    Reply to this email directly or [1]view it on GitHub.
>    [INLINE]
> 
> References
> 
>    1. https://github.com/xeor/taggo/pull/1/files#r2271684

-- 
Enric Caussa Morales
<me@enric.me>
Changed _host class variable, now it is called _url_base.
Would you find it useful to use the ObjectPoolHelper for reusing rhino instances? (@see http://code.google.com/p/wro4j/wiki/RhinoPerformanceImprovement)
Looks sensible (at first at least).
Hmm, then I guess just use the same font and size, but don't save as an ivar. That's not needed with `NSFont` caching.
Incorrect comment here.
I didn't know about that (I'm new to block-based notifications, too, if you hadn't noticed... :panda_face: ) so I'll go fix that. As to the `object` being `self`, it doesn't pose any threat according to documentation.
I like one line messages, because they are easy to copy&paste, but if you'll use multi lines, you should change text to something like:

"Removing the following Postgres versions installed by pgvm:"
The MySQL access is always necessary,  ISPConfig's mailuser.mailuser_id is numeric and ISPConfig internal, so nobody would like to login using it.

The best way to do it would be to add a function to ISPConfig's SOAP API to query the mailuser_id given the email address.  But I would like to get this into Ingo first, then modify ISPConfig and then simplify the ISPConfig support in Ingo, if you agree

I have set up my Horde installation to login using the email address and use example #2 transport_auth() hook to get the full email address in Ingo_Transport_Ispconfig:
https://github.com/horde/horde/blob/3375cf1e6e2bfe152c884c4a9eee50f5ca7bc2a6/ingo/config/hooks.php.dist#L43

Because I use an unmodified Ingo example hook, I don't provide another example.
that you can't use pointers then... as i tried to explain above.

fixed(byte* outBuff = buffer)
{
LibPD.Process(ticks, ref aFloat, ref ((float*)outBuff)[0]);
}

the fixed statement assigns the start of the raw byte buffer array to the byte* outBuff. but since i know its a 32bit ieee float buffer i can cast that to a float* and dereference it with the [] operator. with arrays this wouldn't be possible. but we could just provide two versions of it...?
the hash sounds like the simplest + a fast solution, and we also make sure to always keep the current class one
Yup, haven't seen anywhere anything about style on this, just did the way I do on my own code.
I'll rename.
Should be either:

``` ruby
memo[field] = (dir == :desc ? :desc : :asc )
```

or

``` ruby
memo[field] = (dir == :asc ? :asc : :desc )
```
Alright so to summarize I will make the following alterations/fixes:

* Change `fragment_name_with_digest` to private because `cached_key_name` accomplishes its functionality
* Switch away from deleting the option key in favor of merely checking the value of it
* Add a CHANGELOG entry

Would you like me to open a new PR? Thanks for all your feedback @carlosantoniodasilva @rafaelfranca
so overlapping.isEmpty  may still hold in that else, right? (and it would imply `currCase.guard != EmptyTree`)

good point re: naming, i'll refine that
Let's find a better name for this than Application. Maybe something like Decompose? Elsewhere (I could swear I'd checked it in, but maybe not) I have this approximately identically as "PolyCall" with "Call" as a no-type-args 2-tuple form. But I realize "Call" is not especially accurate.
Out of curiosity, why is `OptimizeWarning` in `__all__`?
It is not quite correct,
To convert pythonic types or strings to the SymPy objects, there is special `sympify` function ('S' is synonym) in core.
I guess that way's better.
did you mean `-oo`?
This function is *HUGE*. Do you see any way to split it up further?
just checking: is this error message suppose to be the same as for `poly_ring`?
Well then at least it tests auto-expansion. The new assert isn't any less useful than the previous "test".
Sorry, it's not the right one :) This is paraphrasing instead of fixing a typo :)
xmerl don't parse &quot; correctly, try this example: xmerl_scan:string("<ETag>&quot;FOOBAR&quot;</ETag>").
i suggest to inline it in mkdir
Any header #included from other headers should be available, so I guess installing it to glosm/ among the others is the right choice here.
> I don't think #include "asprintf.cc" should be conditional

I disagree. `#include`ing source (a/o/t headers) is pretty grotty, and I generally go pretty far to avoid it. I'm willing to give it a pass for Win32 compatibility, but I don't want it creeping into (what I think of as) the primary codebase. Sorry.
Would you change all function names and arguments to use underscores instead of camelCase, thanks!
You spell this word "writeable" half the time and "writable" the other half. Since you interface with catbox, I'm not sure if this is actually working or not. Regardless, "writable" seems to be more correct; let's standardize on it.
I went throught the trouble to find the officially supported versions, and found this: http://packages.python.org/Cheetah/users_guide/gettingStarted.html#requirements

Cheetah requires Python release 2.0 or greater, and has been tested with Python 2.0, 2.1 and 2.2.

... I think we should consider Cheetah to be unsupported.
Instead of doing this, I think it would be better to make `klass` optional and optionally take a block to create the metric instead of passing the constructor name.

That would let us do:

``` ruby
def add_or_get(name, klass = nil, &block)
  if !klass && !block
    raise ArgumentError, "Either klass or a block must be specified"
  end
```

...

``` ruby
  @metrics[name] = block ? block.call : klass.new
```
This breaks the Windows build.
it's purely required for benchmarking
This works fine, but just FYI if you just want to override the widget for a field, you can use the `widgets` property on the `Meta` class.

https://docs.djangoproject.com/en/1.4/topics/forms/modelforms/#overriding-the-default-field-types-or-widgets
I did some further research on this, because my tests where failing under some cases. So it appears that because the choices are calculated and are not hard coded for some reason django cannot handle this.

Moreover choices get calculated on the very first run, but we want them calculated every time we create a UserProfileForm object. I added a init function in the object to ensure that choices get calculated every time.
L'avantage d'une classe CSS c'est que tu peux l'ajouter (l'enlever) à un élément existant. Tu n'as pas à changer la structure du site. 

Aussi, le code HTML devrait représenter la structure d'un site et non pas son style. C'est le rôle du CSS de générer le style. Et comme ici, tu veux simplement ajouter une marge au bas d'un `div` et que ton `div` existe déjà, il va de soit d'utiliser l'attribut *margin* (ou *margin-bottom*) du CSS.
Default to 'list', remove the if(empty below
Sure, though it is called `revision_id` everywhere. In the constructor, in the database. The names should be kept uniform, doesn't really matter which way around.
This doesn't look right. What is this supposed to do?
There should be a transaction covering the entire function body.
That code inside that if
´if ($sort_days || !$auth->acl_get('f_read_other', $forum_id))´

is for the $sort_days and for when there's a possible limitation in the topics the user is able to see.
The work there is a 2 in 1. There was already the code for the $sort and I added the code for the f_read_other, that's all.
<a href="https://github.com/phpbb/phpbb3/pull/674">rounded corners via css</a> was implemented without prefix, I think should be removed all prefixs from CSS.
Yeah, I have a working jslinter too which complains about them.  I guess in general they are unsafe as you can trivially add to an object when you don't want to instead of getting a syntax error.  I'm deleting them as I see them now.
should the metric just be named "version"
Does this mean the output will look like?

```

{json chunk}
..time passes
{more json..}
{even more json}
```
I think it should be `:id_param` here not `:param_key`, right?
Initializers here
Doesn't work with splice.. neverminds.
See earlier note about metadata on arrays.
in axharo az too image pak kon
Yep, it looks like it doesn't exceed 100 chars (my preferred size :-))
Don't hardcode in user/pass here, get them from localstorage hash. (this applies multiple times)
style: should be tabbed equally... did you run jsbeautify?
http://jsbeautifier.org/
I really like it. It's safe and neat.
In fact, I wrote a praising comment but didn't post it.
I'd like to see this become the standard for module mocking in Iris.
node.outputs[0].dtype should have the same dtype as g_data, not x_data. This is what the make_node do.

I prefered to take node.outputs[0].dtype instead of g_data.dtype as this make it return what the op told it would. So it would work correctly even if the g_data it receive is not the right dtype.

Why do we have an g_data float64 when x_data is float32? It is the verify_grad projection that is always float64 that force the update of the g_data to float64.
Prefer a typedef to a #define for type aliases.
I would use `getTime()` here instead of `valueOf()`. They return the same thing but I feel `getTime()` returning milliseconds since epoch would make more sense to people than `valueOf()` returning the primitive value of a Date which also happens to be the milliseconds since epoch. I think it's just more expressive to someone reading the code.
Agreed with the code smell, but not sure I see a better option (other than not allowing command-line specification of non-username arguments). Suggestions welcome, but I can probably live with the code smell.
It looks like to me that you have changed much more then required to fix the #12531.

Is there a reason (I am not aware of) for not simply removing  `[^#<]*` from the expression?
all these global state ^^

isn't it possible to give the default texture path as a parameter?
or just delete it completly, the texture paths in the mdl file would just have to point to the full path
Much easier to read now!
And: the tests got several examples of this.
why use an index and a `while` loop instead of:

 ```
for user_agent in self.user_agents:
    ua = user_agent.ua_string

```
Using the tarball of the 3.0.1 version should be considered: 
https://github.com/jsdoc3/jsdoc/tarball/v3.0.1

    url 'https://github.com/jsdoc3/jsdoc/tarball/v3.0.1'
the ``cookie`` parameter is not documented
Ist hier "*.xy" gemeint? Eine Datei "xy" gibt es ja gar nicht, das ignoreFiles() hat also gar keine Auswirkung. Mit "*.xy" allerdings hätte es auch keine neue Auswirkung, da mit ignoreDirs('*3') die .xy datei sowieso schon rausfällt, da sie innerhalb von dir3 liegt.
1. Prepare LibraryWorkerAdapter, wrapping delegate by default
2,. rename LibraryWorker to something smarter
Yeah, this test covers what happens when you inject a MembersInjector<T>. Unrelated to ObjectGraph.inject().
base ? buildsOn ?  supplements ? augments ?
You don't need the extra function call here either.

```javascript
translate.setHandler("translators", function(translate, detected) {
    callback(translate, !!detected.length);
});
```

would suffice. (There's no need to check itemType either, since it has to evaluate to true for the item to be added to the list of available translators.)
@dharkness 

See #406, which says that casting long to int is an evil due to truncation in numbers.

new Timeout(  (int)  DateUtils.MILLIS_PER_MINUTE  *  5  )
This is (arguably) a bug in ProjectManager.openProject()/_loadProject()--it closes the current project before verifying that it can actually open the new project, so when that fails it just falls back to the default project. You probably can't hit this any other way currently, though. Recommend pushing this bug out of this sprint since it's a fairly low-hit case, and changing the order of operations there has some small risk. I'll file it.
Trailing '#' seems to be caught. Added check for trailing '?'. Need to search original string since PathUtils swallows it :)
Need to handle optional whitespace after `url(` and before `)`. http://www.w3.org/TR/CSS1/#url

(There are some other edge cases this won't handle, like nested quotes and backslashed quotes, but anyone using a filename with quotes in it needs their head examined.)
Will rename
Two questions:

1) Is it valuable to the user to auto-expand the selection to the full line(s)?  Eclipse does this, but the other editors I tested don't (they leave the user's original selection as-is).

2) The pair of replaceRange() calls here seems more complex than it needs to be: it's basically replacing the line above with the line below, then replacing the line below with the line above (and it gets especially tricky with multi-line selections, where the ranges start to overlap).  What if we just _remove_ the line above and then re-insert it below?  That would also make it easier to preserve the selection if we wanted to do that.

You'd still need a special case for the bottommost line, but I think you could handle it just by adjusting the deletion range.
You mentioned that error returned from the file system rename command is handled with sort/refresh, but I only see sort here. So where do you handle condition 2 that you said you also need the refresh?
Why the need for this ?
The previous matcher already includes it
Don't comment out stuff but rather remove it.
If you're deregistering a range of codes, it calls set_env once per code, unlike during registration, where it updates the dict once per code, but calls set_env just once for the range.
why the mass kill on searching?
You can use github type
It is usually better to use a boolean property. The view then binds to that property and uses the BooleanToVisibilityConverter. I would hope this is built in by now, if not I can find one for you.
Shouldn't just simply all `li`s in the form be inline? Do you really need a class for this?
Tom mentioned that he wanted to TomDoc everything that's in the repo right now – he just hasn't gotten to it, yet.
what about `font-weight: bold` instead? Kate, is there any functional difference?
I didn't change this one because pull request #319 is removing it.
Where can we get a woff version of this file?
`null + 's' === 'nulls'` -- it's better to make `chunk = '';` above
Check that parent actually exists - This function makes full screen unusable (in Chrome at least: `Uncaught TypeError: Cannot read property 'clientHeight' of null `)
```merge_iq_with_medistrano_pir``` is a field of the deployments table, which is set by the user in the view. ```merge_pir_with_iq``` is the actual method that makes the merging. Should i rename ```merge_iq_with_medistrano_pir``` to ```merge_iq_with_medistrano_pir_checkbox```?
Aligner les =.
Is the check for current_user needed on 19, since it is on 16?
sort of a weird name, does this need to mention express at all?
Move this to a private helper method:

```JavaScript
function HelperMethod() {
    return {
        ....
    };
}
```

Just want to keep the processMessages small
Well, not strictly, but I added it because without the correct malloc
and free, string stealing doesn't work.
Align this with the line above.
remove this lie break
No.  This was intentional to avoid API complications because the input data can have masks.  We might want to include this in a separate discussion on the Table constructor, which is also missing a way to pass column units, formats, and descriptions.  I think that keeps things simple and clean, but am open to discussion otherwise (after 0.2).
as discussed, we agreed that it should avoid circular class dependency: IP Scheduler <-> M::IpLease, M::Instance...

the change will be accepted as it is although the proper class design change is going to be performed later.
n/m, the first clause will match.
With the original code, there is no default, when doing a reset, as the detach DB checkbox always reflects the current state. This seemed like the easiest way to fix that. Have you got a better idea?
No idea, but I wanted to retain compatibility between pre and post-ultraprune block files, so I used the same format. That is: the files are a concatenation of {4 bytes magic, 4 bytes LE integer with the actual block size, block data itself).
I agree that more consistent punctuation is nice.

What we really need to make this kind of changes feasible is a script that
takes the old and new English message and updates all the translations on
Transifex.
wont this throw an error? 0, 10 is not an integer so if this.__padding[0] is not set it will not work i suppose
More specifically, `'corp':` not `corp = `.
ifModifiedSince -> ifNoneMatch
Now these can just be named type, delay, feedback etc - no need to prefix with "waveformEffect" now that it's wrapped in the struct
That logic is no longer legal in Python 3:

```python
In [1]: None > None
TypeError: unorderable types: NoneType() > NoneType()
In [2]: time.time() > None
TypeError: unorderable types: float() > NoneType()
```
`download()` hasn't been updated to show the progress output. But further than that, this code doesn't need to compile everywhere and adding `#ifdefs` makes the code more complex, which is bad for an example.
Updated and rebased to `development`.
We _might_ want to consider `ActiveRecord` here. I think that's what we want. It will make all the validations and updates easier. I know it's a bit heavy handed, but why re-invent the wheel right? I'll leave that decision in your hands.
Nah don't waste your time!
Do you have to duplicate this, or is there a base template this can/should be part of so you can just inherit it?
Also not sure if this needs a poster as it starts playing almost immediately.
This assertion depends on the order the caseversions are returned from the query, which is not guaranteed since you aren't using an ordered query. Better to use sets.
Can that not raise an error? For example if the connection to PG fails?
I'm not sure this is valid SQL, but I may be wrong. Should you not use a ``VALUES`` operator here instead of a ``SELECT``?
Sculpin is now ContainerAware rather than a ContainerBuilder: e99de50a7fb3c2ab09117c9586c1b065ab1646a4 . Thanks!
Use PixelFormat::createFormatCLUT8() instead
I think we could make use of `_.defaults()` here and reduce code
typo coockie => cookie
please don't revert the update to the PSR-2 CS : you should keep the public keyword
This constant should be renamed something like `NO_REPLY_ADDRESS`.

It's a bit vague as-is.
In this case it makes sense. I don't mind using the update attributes, but I would prefer an exception be thrown, which would fall in line with the rails bang convention. If we use update attributes the bang will be clear.

Dan suggested this rename and I knew what he meant by the bang.
I think that it would be better if the template parameter for CombinatorialDSS is a model of iterator (and from its nested types you can access to the type of the pointed elements).

By the way, I was expected an iterator on codes/letters instead of an iterator on points. What do you think of the following use case: 

    std::string chain; 
    //fill chain
    CombinatorialDSS<std::string::const_iterator > s; 
    s.init( chain.begin() );
    while ( (s.end() != chain.end()) && (s.extendForward()) ) {}
Yeah, really nice. They added it in [this bug](https://answers.launchpad.net/ubuntu-website/+question/79193), if you were curious.
Also, use $(...) instead of `...` if running with bash.
ca sert a quoi
It's positioning of the ```'os'``` argument on the first line.
```
# Arguments on first line forbidden when not using vertical alignment
foo = long_function_name(var_one, var_two,
    var_three, var_four)
```
http://www.python.org/dev/peps/pep-0008/#indentation
I had that, forgot why i took it out. I think it looked too dense to me w/ the .promise in there
Je proposais justement de l'annoter `@Enumerated(STRING)`pour que le nom de l'enum soit stocké en BDD. Je trouve ça beaucoup plus parlant.
class Mongo is deprecated as of version 1.3.0 http://php.net/manual/en/class.mongo.php
you can collapse $album here into item::root() and make this one line.
I think the coding standard defines you must have 3 exclamations and 2 "1"'s ...
blah, I hate ruby stdlib sometimes :(
I'm not sure why it's a span either. We can certainly change it to a div if it'll help with styling.
This button should only be displayed if the user is authorised for the current project (just like we do with the buttons).
+1! Added ;)
I'm not sure why those variable names are not camelCase?
Good luck! @pauladenot thanks again ;)
This may be a bug cause mp3 shows wrong duration in gecko's native audio player.
(Audio tag with default style)
I will keep this approach and find out it's a bug or not.
Added a comment on this, too.

By the way, use c to replace conversion is because I don't want my line to separate
due to the gjslint will warn a line more 80 characters :P
I ran into this on the desktop build, I'm not sure why startTone didn't exist, but it helped me with testing so :)
`turnOffFlightMode`.

It's a convention to use a verb as the beginning of a function name
Is the goal that this will go out to the performance database and you can see if someone regresses the implementation?
> I changed "capabilities" property to "security". So to write a code which can work on both APIs is impossible.

Please keep capabilities *and* security here, along with a comment like:

```
   *   capabilities      : array of strings (supported authentication methods)
                                     XXX to be removed when bug 790231 lands
```
Of course! Fernando is working on this part. Once we will add a Thread to ThreadList we will call async. to a ContactManager that will check cache (if is necessary Contacts API) and when It retrieves info requested we will callback "updateMsgWithContact", which will update "photo" and "name" in ThreadList. 
In Android/iPhone when you load SMS App fist time after switching on the device there is no contact info (only phone numbers), but gradually It starts to update this info. One of the main difference is that we are going to launch this call once we add a 'Thread' to 'ThreadList', in old code you have to wait until complete whole list to call ContactManager.
I thought that `network.capabilities` (as returned by mozWifiManager) was an array?
I'm still a little skeptical about this hard-coded precision of 25. It would be better to use the actual precision of the real value. Apart from that, good job!
Could we make the setter for this private?
You can always use `nosetests test_path` syntax, i.e. `nosetests overlord/test/core_test.py`
原文だと \-- だけど大丈夫かな（変換のとき
おなじく <code> タグ
Shouldn't RichPipe.assignName(pipe) be put here instead of joinWithSmaller?
We need ```insert[A:TupleSetter]``` otherwise, we are not threading through the TupleSetter correct

This is nice, but I do wonder if it is not better to just do:

```insert(f: Fields, value: A)```

What do you think about that?
the space had to be removed by accident, I have tested this fix with a space and it works fine.
what if we add a trim() to this just in case?
Should redo this so it saves in the same format as the copy-paste-text.

pass@host:port
Print some sort of error?
Need to maintain a margin right. This is because on hover of surrounding tabs the margin helps separate background color from the active tab.
>`\\`

why
`form` is ambiguous, at best - what about `dataToBeSentToServer` ?
I tried it both ways, and honestly I think it looks better with the <br/> instead of making it two paragraphs.
if value is string, why cast string to it?
Reads an InputStream into a String in one giant gulp.
Yes, I should have removed it, and missed it.
If you want to create a set of similar endpoints, such that they're implemented with the same class but different constructor parameters.  I'm not sure that will ever happen, but the method's documented anyway.
Good point. Given there is backwards compatibility I could revert the built in helpers to return tuples?
missing phpdoc for the interface, to know what the return type is
transparentes -> transparents non ? on dit bien un pixel et pas une pixel
Instead of adding another `$if` function why not overload `$if` and check if `typeof cond === 'function'`
"required: true" is useless as it's default value
1. code duplication. 
2. dont use variable names like `p`,  use `project` instead
I know, my mistake
We've been putting all our detection stuff in the _detect_ module.
can you make the default here match your default in the code? (copypaste ease)
can you use the Attach(I_OnPreMode, this); overload instead of an Implementation list?
why don't you call both torso joints:

e.g.:
[torso_tilt_joint, torso_pan_joint]
nit from coding style "If any branch requires braces, use them for all"
The (project) field in the uri should be removed for push log queries.
Doesn't set `document.title` and 

	window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
	      .getInterface(Components.interfaces.nsIWebNavigation)
	      .QueryInterface(Components.interfaces.nsIBaseWindow).title


See `updateTitlebar()` in [`suite/browser/tabbrowser.xml`][1]!

[1]: http://mxr.mozilla.org/comm-central/source/suite/browser/tabbrowser.xml?rev=2dead7fe49dd#867 "tabbrowser.updateTitlebar()"
The header that I pushed cannot be used?
Small typo/syntax error. Think you meant '[200, 201]' rather than a dict.
Either now, or in an immediately subsequent pull request, yes.  Please.
Can this file be limited to 80 chars wide?

https://github.com/jquery/jquery/blob/master/MIT-LICENSE.txt
What about "Verify mailer views" instead?
Ah, yes, since it's a function, not a method. (I'm actually fine with using CapWords for functions, but probably best to stick to the guide.)
Sorry, not a `ref`, but a `hash` :)
Watching the [tag entity](https://github.com/composer/packagist/blob/master/src/Packagist/WebBundle/Entity/Tag.php) each tag is a String so probably will be a varchar(255)
Pretty sure changes in this class are correct
The locator you are acting on here is a `Zend\Di\Locator`. You can't call `instanceManager()` on it...
Extract the above into a separate method, and then call and return from that method:
```php
protected static function createAdapterFromItems($items)
{
    // do the work from inside the conditional, and then:
    $adapter = static::getAdapterFromManager($adapter, $Items);
    return $adapter
}

protected static function getAdapterFromManager($adapter, $items)
{
    if ($adapter instanceof AdapterInterface || $adapter instanceof AdapterAggregateInterface) {
        return new Paginator($adapter);
    }
    $adapter = static::getAdapterPluginManager()->get($adapter, $items);
    return new Paginator($adapter);
}
```

This will help keep the method more readable. Also notice the use of "static" instead of "self"; this allows for better inheritance and extension.
Also, in looking at FirePHP, I wonder if we shouldn't compose an instance of FirePHP instead of using the procedural API. This would give developers the ability to alter behavior, such as max depth, toggling reporting of line numbers, etc. Thoughts?
Add @author and @since to all your functions. Except that it looks good
nit: can you change this to use consistent comment formatting throughout, i.e.:

/*
 * blah blah
 */
here need to add support for short badge type
This will throw if App_Data doesn't exist.
Oh yeah, right - I forgot that private variables use camel case. :)
Should just be "CraftingTable" the "Block" is redundant
what's this paged? do you mean paginated?
Missing line break between assignment statement and conditional statement.
or maybe a subnamespace for the 2 visitors if you really want to separate them from the persisters themselves.
one minor detail left .. please move the question mark to the beginning of the next line. makes it easier to scan the code
Lines should be sufficiently short. I think Toon's approach is better. Also allows to distinguish years?
This is wrong, as you do provide a web.xml.
I was under the impression that in `raise Exception, message` the "message" part was simply passed into Exception.new, so not sure what is happening to message on lines where this is raised now. Maybe I'm wrong?
And also the lines below?
ya hay un menu partido dentro de competicion
Specifically I meant, why is there a cvs and cvs-module?
You can make this `from base import BasePage`
Need to add check for empty URL, because it creates inconsistent behaviour if ``index_view`` and ``url`` is passed at the same time. If ``url`` is passed, should use ``url``. If not - fallback to index view base URL. If both are not set, use defaults.
I had profiled this test and saw that it basically doubled in time because of the setup, which isn't used, so I factored the test out into a new TestCase subclass.  I think we should still do that to save 10 seconds on every zipline test run.
Is this why 3d frames don't display script or mc data?
empty. do we need this?
I'm assuming this will be replaced later with a proper thumbnail. Either way, you should have an `alt` value.
Previously activated was top level only. This feels like a breaking change. How does a view note that it's a "top level" view now?
'Fetches' :tongue:
Oh, there's this PluginSystemLib project, why is this separate from the rest?
yeah I tried that originally, which is why there is TODO mentioning the context, seems the uri I was passing was dud so that was making it fail, i'll put it back
We can use Firebug for that one.  A couple of the devs listed work for Mozilla.
this line will give us all the file upload stuff you downloaded in the file-uploads folder (but still check to make sure it works)

`gem jquery-fileupload-rails`
idk i like keeping all my html code in one place. that way, if i want to change how it looks, i don't have to flip between different files and stuff. since its working and modular this way, do you mind if it stays like this?
Is 
 @equal json.error, null
equivalent, easier to read?
This change doesn't seem necessary?
Should be valid file "path", not "URL"
Do we need this python file? I would prefer to keep everything in one language. Any chance it can be converted to node?
if no callback is provided, the default functionality should log an error here:

```javascript
callback = callback || function(err) {
  if (err) {
    log().error(....);
  }
};
```
I think we need a more solid link between this number `32` and the number 32 up in _generateSizes. Either a constant would work, or maybe the `files` parameter could be a hash keyed by smallPictureUri / mediumPictureUri, so it doesn't have to be determined by the size alone.
This is more of general remark, but when I was playing with paging queries, I never got the row key to return. It might be worth checking this and simplifying if it's true.
I don't know.. we already depend on `org.eclipse.jdt.junit`, and that one depends on `org.eclipse.jdt.junit.core` and `runtime`. So I don't think we need to do anything.
Grammar Nazi: "Returns a list of regions at the specified location. If regions are found, an array of region names are returned, otherwise, an empty array is returned."
Is this in a GET function?
dit is voor nu alleen voor de edge ja. alleen heb hem passive genoemd omdat ik verwacht dat er meer code in komt. hij voert hier in alleen dingen uit als !this.spotted
Спасибо, перепутал=)
Про дядю ворно подмечено
Нашёл, в модели user метод current_game, он должен теперь действовать на основе статуса :closed, раз уж у нас и такой статус теперь появился)
Not true, and doesn't belong here.  List in the header descriptions which are mandatory and which are optional.
consistency mostly and some side effects.

http://benalman.com/news/2012/05/multiple-var-statements-javascript/
uma dica: sempre defina estas variaveis com o underscore no começo. porque as vezes pode conflitar com as variaveis de classe. 
$this->_mapper, $this->_page, etc.
This seems to be unused. Instead the value of 200dpi is hardcoded in `pdf.c`
@nulltoken ah, thanks for the context! I like the idea of exposing specific exception classes. But I didn't see such classes yet.
Why source_? it is not specific to source space..

Yes, I think having pass bands would make sense. What do you think is the best option for this? Maybe we could allow fmin and fmax to be tuples, e.g., fmin=(3, 20), fmax=(10, 30) would get the frequencies 3..10Hz and 10..30Hz. 

Also, I was thinking an option to decimate in frequency domain, i.e., freqs would be `freqs[::fskip]` where fskip is a decimation factor. What do you think of this? I am a bit worried that it could cause aliasing. Is there a better way than taking every fskip-th frequency?
I see. I find it strange, as I normally use master to run things when I'm not working on a new feature.
person.getDeathdateEstimated()
Can you refactor this logic into a private `parsetime` function? (similar to `_parsetime`)
Your suggestion looks better, so I just changed the code.
Why return ""; ?
It should be "./console ip port" not "sbt console"
self.gens_dict = dict(zip(self.ngens, xrange(len(self.ngens))))
Что ж ты лишние ньюлайны так любишь?
Would be nice to specify when ParseException may be thrown. Also, specify in javadocs the timezone and the format used/expected maybe?
in my un-professional opinion, this might be querying the database more than you'd want. Could do something like this
```ruby
def update_score(amount)
self.score += amount
self.save
end
```
See https://github.com/adhearsion/adhearsion/pull/224/files#r2385678
There's a space, not sure if it is important.
Good job for writing specs! However, since you no longer have a search page and controller action, you probably don't need these.
ok, great! Have you updated it already? I'm still seeing bullet
Best, Markus
Is this new way not required? See #35
did we have this in legacy? i dont remember for details.
System.err.println ???

I'm not sure of the context in which this is executed, but are you sure you don't need to use the logger here?
You are getting mixed up.  I want defaultdict and OrderedDict from the standard library's "collections" module, not matplotlib's.  But because axesbase.py is in the same directory as matplotlib's collections.py, pre-py3k import rules will accidentially grab matplotlib's collections module.  It is for this exact reason that implicit relative imports is being deprecated.
The filename is definitely out of date. This image represents the screen-shots on the front page. Perhaps call it ```screenshot_button.png``` (the exact name I don't really mind).
I am sorry about this... I accedently added it to the commit files... :(
`Renfoncement`? indentation ! Google translate again...
This is inside if (needsCenteringAnimation) { }
For some reason I read that as an added line.  thanks.
Just codestyle, dont wrap curly braces
@gsilver Remove the extra space
Agreed, we shouldn't scatter upgrade instructions into reference docs, they age too fast.
The docs are version-specific anyway, so if somebody still uses 2.4, they'll simply look at the 2.4 docs.
Hey Mike,

This is not directly related to "Product Bundles". But any hidden variable or simple product is still be bundle-able, and may end up in the cart. 

For example, someone might want to hide a product from the catalog, but only make it available as part of a bundle. In this case, its hyperlink should be disabled.

Let me explain the extra check part: 

If a variable product is hidden (we don't want it to appear in the catalog), but some (or all) of its variations are enabled, then: 
- any of the enabled variations will be selectable and may end up in the cart. 

In this case, the desired behavior would be to disable the cart hyperlink to the (hidden) product.

Checking for ( $_product->is_visible() ) is enough for simple products, but not for variable products, because, in the latter case, it refers to the VARIATION, not the product.

Hidden (disabled) variations should normally never end up in the cart, because their options are disabled. Even if they do somehow, the $_product->is_visible() check does the trick, indeed. 

But what I care about is the more obvious scenario: hidden product + enabled variation.

The first check alone will not disable the hyperlink to a variable product which is hidden. Try it :)
No, but that would be the most common case I guess.
the separator being in a test case... seems so bogus?  shouldn't we have a os.pathsep or something???
For once this wans't my fault :-P
Looking at ReST docs.  Here is what I found:

You can include files with ..include:: file.rst

and possibly replace:: 

http://stackoverflow.com/a/9785223

You could use :ref:`Header` http://sphinx.pocoo.org/markup/inline.html#role-ref

Or :doc: could also be used perhaps: http://sphinx.pocoo.org/markup/inline.html#role-doc

Based on experience last night, it seems the `make build` doesn't puke if you have additional/inaccurate links in the file, so it wouldn't be a problem in include links to *all* and only use what's necessary.  But it will still require surrounding the text with \` \`_ to designate a link/url.
Eine Consumtion braucht ja immer noch eine Verbindung zu einem User und einem Bier. Werden die in der Resource gemacht?
I see!  I suggest documenting the required structure of `relationship`.
I agree that we can't do it in 2.5. But throwing an exception will make it much easier for devs to even notice their error so I think that is preferable for 3.0.
That too since you use puente right above it.
Comment is of course not correct anymore then ... :-)
Of course you know that this is ugly?
`usernames` maybe?
`live`? Why? I would use `.on` or simply add event handler in createDOM.
So no trim here. Let server handle this.
where ?
i cant compile for these platforms and i dont know ES well.
Tell me and i will fix
We now have a block-style mkdir that changes directory as well:

```ruby
mkdir 'build' do
  ...
end
The gist should use a specific revision (i.e. with a sha1 in the URL), this is a moving target. Though it would be preferable to just inline the patch.
Ugh, I keep doing that. I thought I fixed it, but I guess not. I'll push an update when I get on my laptop.
Any specific reason why you're not subclassing `DispatcherTestCase` ?
Well. I find this sentences still to be truth. Sahi did replaced old Selenium and is better in many cases. Though, Selenium2 is better than they both :D
Thats the wrong name.
then I guess I have no choice :(
You can add Git library project dependence in tortoisemerge project,  needn't duplicate such code.
die 3 Zeilen ev. noch in eine "convenience" Methode im HttpHelper auslagern, brauchen wir vielleicht noch an anderen Orten.
are we upgrading EY to p290?
treure dup
`Zend\Authentication\Adapter\AdapterInterface`
Add another test. A requirement for an importer is that it is idempotent. If you try to import the same file twice, you should get the same catalogue.
fair enough to state 2012 ?
ipset is not available on centos 5, but i can add the sudo command for the iptables stuff
You don't need shadowing to prevent global interactions, and using it for that purpose just makes for really confusing code. If you need to redefine x, move your function outside of the scope where you already have an x defined.
I did it on first commit, but problem is that you can't filter files which are content of jar files => Manifest was a merged with lots of signatures and really bad headers. Possible improvement would be adding correct MANIFEST headers.
This is interesting: when I removed the absolute path, I got an error on my system but didn't get an error for that test in travis-ci - is pexpect installed on travis-ci?, because it would seem that if the test is flawed but is passing, then it must be skipping the test - which would happen if pexpect and paramiko are both missing.
Personal nit - feel free to ignore as it's not a functional nit. The use of <code>else</code> is incorrect in this instance as this isn't a true conditional statement. I think a code comment would be more informative.
I never changed things directly on `NetworkLoggerRequest` or `NetworkLoggerResponse` objects, but that's mostly because events on the entry are just passed on to them. I tried to keep that pattern, but I think I can change to setting properties directly for `logger_entry_*` properties to make it a bit shorter. Fixing.
Make this `const`. Where does 1.6 come from?