labofsahil/github-event-dataset-2012 huggingface dataset:
On 3 November 2012 00:54, Colomban Wendling <notifications@github.com>wrote:

> In tagmanager/ctags/asciidoc.c:
>
> > @@ -0,0 +1,205 @@
>
> Nah nah, you got me wrong. I just don't really like the copying of utility
> functions like utf8_strlen(), or maybe even issame(). But well, let's say
> they are small enough not to be a problem, although they still might be
> candidate for a common.[ch].
>

I have realised that I havn't been clear, asciidoc is not rest, it is
different and it has more than one way of identifying titles, not just
underlining, but I don't have the time ATM to implement support for those.
 issame() really should be named istitlemarkup() and will be different when
the alternate method is also implemented.  Similarly Asciidoc doesn't just
count code points in determining how long the underlines need to be, it
also takes into account the Unicode east_asian_width
(g_unichar_iswide_cjk()) so uft8_strlen() needs to be renamed
calculate_underline_length() and take account of that as well.
But as I said thats later (tm).

 —
> Reply to this email directly or view it on GitHub<https://github.com/geany/geany/pull/78/files#r2016254>.
>
>
It doesn't seem like it should matter. Why does it?
There's no `ViewController` in between `NSPopover` and `Behavior`.
The point is to add the synchronization on the same level as start/stop, so that a role switch will wait for transactions to fully commit, and a commit will not have a role switch in the middle. If it were only on the epoch check then this could happen:
  - T1 enters commit and the epoch check passes
  - T2 calls stop, does role switch and then start
  - T1 continues the commit unsuspecting of the change that just happened

Whether or not this add synchronization messes up something else I'm not fully aware of, but since committing transactions is serialized either way (albeit on a data source level) it should make all that much of a difference.
I don't think this has to be in this specific pullrequest. One of you could create new issue, or even pullrequest.
I know it is just the same as in 3 but this just is an anti-pattern as it will block the IO-Thread. Let us fix this.
Should be `gxp_picasasource`
It's not a good idea make Zend engine rely on php
If I wasn't casting to `size_t` for the internal operations, I wouldn't check for it. But with the cast, I felt that it would be prudent to at least check for it... I'll fix the error message (force of habit)...
разбить на кучу методов
isEmpty() кошернее
Legacy from Spree. I think you're right. We could probably get away with using `require_dependency` here?
Can we keep the `()` around the args? I know it's fine, but Rails uses this convention everywhere.
304 and 205 must not have response body too http://httpstatus.es/304 http://httpstatus.es/205.

Also I think is fine to not send to 100..199 too
This looks weird: `if options.key?(:id).blank?` did you mean `if options.key?(:id)` or `if options[:id].blank?`
I think these assertions should go to another test in `persistence_test` instead, they make more sense there where things like `save!` are already being tested, wdyt?
There's no need for all this space.
install the +debugger+ gem to run
It's a duplicate. See line 165.
Also it looks like `annClass` is only used once now. Maybe we can get rid of it?
Good call with early init.  That's a an issue.   Working on that and the other bugs now.
Excellent explanation.  I'll add something to that effect to the doc string.
Space after `//`, capitalize first letter, period at the end.
``Tr(A*B*A*C*B) == Tr(A*C*B*A*B)`` fails.
You have to have two lists by definition.  `self.args`, which is immutable (actually it's not a list, but a tuple), and the copy that you modify.
Where do properties come from? Are they just ad-hoc string names?
I understand your point, and in my opinion it would be the best way. But I don't see how to say at once to all unit what system should be used in priority if they don't come with "intrinsic" system (as it is the case when you get the unit from the system, which sould in principle be the preferred way).
Or rather `<string>n`, where `<string>` would default to `C`.
This should probably be subclasses from Basic.
We plan to start using AugeasWrapper for all augeas based agents
i was stuck wondering how to do this. what i really wanted was something like the INFO and TIP box but different from either of them. how should i go ahead?
Why the complete signature?
Which is correct depends on what getRelativeEffect() is used for, but I would prefer not to estimate a normal distribution based on the quantiles.
`CharlockHolmes` does use libicu4c, if that's what you're asking?
this is the crux of the 32 bit problem. 

I worry that calling it out might be unclear and sort of information overload because it's not operationally relevant to force people to contemplate virtual memory space limitations, when it's not a realistic problem, and one that is easily and commonly handled with other administrative solutions?)
There is no need for typeof as .attr() already returns undefined if it's not defined. Take a look at the jQuery documentation for that.
This is kind of confusing to me. Especially the word `ignoring` sounds like this function does anything special. How about `Gets user ids of currently banned registered users.`?
The brakets on this line are wrong!
All URL formats should be class constants.
Why is the file called helper if this is the only class in it?
In that case, can you help me doing that there? I can't really find a way of properly doing it if I do it using that method.
Done - 89140c66f00f772b72e269e81e12e5b362c6c5de
Is this supposed to be empty?
you mean you did not use a git client?
I was about to call it master-app-config but static-* sounds better.
Seems like this could be right after the split() call to be more efficient.
I was thinking to use the same at the server and client (eventually consolidate perf module since it does exactly the same), and at the client there is not just thing as YUI_config.mojito.<something>, maybe this is a good time to add it ;)
Wrong line :P
After further consideration, I agree it's better to sort purely on the keys, so ignore the above comment.
remove print and put the version.append in the for loop
Is this comment still up-to-date?
Is it worth adding a test for just the splitting that abuses it with nasty placement of quotes, backslashes, etc.?
Fix parameter name from "requestContext to requestFactory"
Make this os.path.join(get_cython_cache_dir(), 'inline') to allow for other, orthogonal data to be put into this same cache dir.
Adrian will fight you on this if he notices. :P
Why is the minor version changing to `2`? `8` is correct.
you shouldn't really be calling jQuery functions in support. Instead, you can do something like:

```
var offset = container.firstChild.getBoundingClientRect ? container.firstChild.getBoundingClientRect() : { top: 1, left: 1 };
```
You can't assume that user never uses semicolons if they use ASI. This code is completely safe and legal but will generate a warning with this patch:

```javascript
doSomething()
doSomething();
(function () {
  doSomething()
})()
```
Frontends no longer …
I think it's legacy from old time.
Is there no way to request any of these under superenv? Won't this break some things that absolutely need e.g. no_optimization or enable_warnings?
Formulae need a stable download in order to be considered for inclusion.
@jacknagel  The cmake patches don't help at all.  I tested with those patches against XCode-4.3.1.
Because CMake won't deal with the case where `xcode-select -print-path` only returns errors (CLT only)
we get a malformed:

`CMAKE_OSX_SYSROOT = /SDKs/MacOSX10.7.sdk`  in CMakeCache.txt.

When you combine that with `CMAKE_CXX_HAS_ISYSROOT "1"` being defined because llvm
supports that flag, then you have a recipe for problems.

The question has always been, does a bad -isysroot leak into CXX_FLAGS all the time.
Obviously not or all my brews would fail.

Then I have to find why this software gets that included into `CXX_FLAGS`
I have looked at the code till I'm blue, and it is not added explicitly.
I can trace the origin of every flag in `CXX_FLAGS` except these two:

`-arch x86_64 -isysroot /SDKs/MacOSX10.7.sdk`

I hypothesize that the devs set the arch, which I missed happening and that
the arch variable triggers CMake to also add the sysroot variable.

I've asked this question on the cmake mailing list, what can trigger the inclusion
of `-isysroot` into `flags.make` in the `CXX_FLAGS` variable if the devs do not
explicitly code it to be in those flags, but I get no reply.  I'm now at the point
where I just run full xcode.  I gave up on the CLT only because it's unsupported
by CMake.
Don't `cd` in the subshell, instead do

```rb
cd 'src' do
  system "make install"
end
```
That was poor style. Roger.
What about `binascii.unhexlify`?
Maybe make these sets of creds different and add a test for picking the right one?
$ pip install PyAIML
Downloading/unpacking PyAIML
  Could not find any downloads that satisfy the requirement PyAIML
No distributions at all found for PyAIML
note: also change docstring
Instead of just two Strings and three Ints, would it be possible to create an actual record type to name the fields? I'm normally opposed to adding records on sum types, but (1) it's not really such a problem here, and (2) if really wanted we could have a separate YamlLocation datatype.
I'm just surprised that `dbh.fetchone(...)` would return a dict `{'max_id': None}`.  I guess that what it does if the table is defined but with no rows?
Good catch here; I agree it would be better if they had the same ordering eventually.
`model` just unneeded?
trailing whitespace cleaning, in the future, it would be great to split these into a separate commit
I'm still seeing problems at the bottom. It's much better (still not perfect) if you change "renameInputOffset.top" to "renameInputOffset.top + $renameInput.height()".
Since we're using jQuery anyway, seems nicer to just do $("<style type='text/css'></style>").attr("id", styleId) or some such.
typo: "use file url"
This seems like quite the hack. Why isn't `require` sufficient for this?
Can you add the full namespace back in please?  The API doc generator I use requires the full namespace path when rendering these annotations if the class is in a different namespace
Is that even legal? Isn't `datetime.min` a datetime object? What does it mean to call it?
I would add a comment here, explaining that next(b, None) is used to avoid a StopIteration exception to be raised too early (the tricky case is when b is an empty iterator). Do we have a test for that case?
Oof, maybe we'll just switch it to `Any`
Isn't `next_url` defined in some other template?
You didn't technically add this code, but I'd be happy if you fixed the spacing here too.
actually, why not use the @gradient mixin for this and other changes you made? (look in globals.less) @k88hudson
They are expected to be strings, not objects. Should we set them to empty strings?

Going to try that and run it through the tests.
whitespace between i, + and equaled
that was done to speed up the type3 text indexing, now it will attempt to load the pdf-char when it's not needed. is it the intent?
Ja. self.board.sp.write is goed.

(Omdat dit deel erg veranderd is in part #2, en deze commits niet 100% functioneel gescheiden zijn/waren omdat ik snel dingen aan de praat moest krijgen, is dit niet verwerkt maar wel meegenomen in part #2
Oof. Right. I've added a Precondition there.
query script should be in `zipkin-server/config/query-prod.scala` still
Why you removed this line?
code duplication - The same function is defined in  katello-configure/lib/util/functions.rb
This seems like sort of a weird interface, downstream targets can't know if the data is incomplete or there was an error when they receive the data, right? Why not emit an error event along with the data it received?
I don't understand this change. Why do you get data from the query string on sends?
It *might* be, though probably not officially.  There have been some discussions on how to add backwards compatibility for setuptools-style entry points through packaging (it's actually not that hard).    Astropy itself doesn't provide or use any entry points, so I don't think it needs mentioning.
写个todo吧
This change would create another place that needs to be edited by hand for official releases, I'm not sure if core devs ACK this one.
Perhaps you could mention in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.txt#L6 that there are then 2 lines, which need to be edited.
Perhaps ``Keep debug.log file size below 10MB (default: opposite of -debug)``.
I just think "small" is too general.
Yes of course, documentation will follow.
This looks wrong. What about https and ftp etc?
*Ok, I have remove the comments.
*
typo on "description"
provide a default value via Any(default_value)
Can the docstring be a bit more descriptive? It should mention:

- It's for converting a bytes string ('string' is ambiguous)
- Unicode strings are passed through unchanged.
- It's looking for an encoding declaration in the string.
So... it's probably better not to hardcode the class here and instead do:

    from wiki.models import Document

    ...
    es_reindex_cmd(models=[Document.get_model_name()])

That way if we ever change the model names, we're not hoz3rd.
I am pretty sure most of the tests have expected first. I'll keep it consistent.
As you noted, we will only have a limited set of log in credentials. Using single character keeps the db footprint low, while giving a slightly better hint regarding the source when scanning the database. Numerics can be equally confusing because there's no additional information one could associate with "3", unless you were to create a mapping table, which could lead to an additional join which would slow the query. 

I'm fine being overruled on this, but in reality, we're simply swapping one arbitrary value for another.
Why is PruneEvaluator deleted?
Uncomment or remove and create ticket for this (or note it elsewhere)
Code duplication here (`'class' => 'span12'`). It might be solved using FormHelper::inputDefaults (Cake 2.2+ only) http://book.cakephp.org/2.0/en/core-libraries/helpers/form.html#setting-defaults-for-all-fields
there's no full page changes in the 3 commit
In the past I've just done `str_replace('://', ''` which is more than enough to destroy anything sneaky.  

--  
Phil Sturgeon


On Tuesday, 18 September 2012 at 14:24, Ryan Thompson wrote:

> In system/cms/controllers/admin.php:
> > @@ -62,12 +66,23 @@ public function login() > // If the validation worked, or the user is already logged in > if ($this->form_validation->run() OR $this->ion_auth->logged_in()) > { > - redirect('admin'); > + // Go to the redirect if any > + if ( $this->input->post('redirect') ) > + { > + redirect($this->input->post('redirect'));  
> Hmm - checking that would be bulky no? What about some logic to F up any attempt at it? Prepending a slash to the string starting after the first character. So /admin/blog would be /admin/blog but http://aiwebsystems.com would be /ttp://aiwebsystems.com (http://aiwebsystems.com) and fail.
> I can't imagine this would be anything but malicious so as long as it's stopped.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/pyrocms/pyrocms/pull/1864/files#r1628721).  
>  
>  
>
Gah ok, I can wait.  

--  
Phil Sturgeon


On Thursday, 6 December 2012 at 13:47, George Petsagourakis wrote:

> In installer/views/global.php:
> > > <title>PyroCMS Installer</title> > > - <link rel="stylesheet" href="<?= base_url(); ?>assets/css/style.css" type="text/css" /> > - > + <link rel="stylesheet" href="<?php echo base_url(); ?>assets/css/style.css" type="text/css" />  
> They don't work on my 5.3.18 install, docs say that they are fine and always there after 5.4 (see (http://php.net/manual/en/ini.core.php#ini.short-open-tag))
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/pyrocms/pyrocms/pull/2106/files#r2339227).  
>  
>  
>
@Baachi we are using ``implode`` everywhere in the codebase AFAIK
Please note that the toolbar didn't supported them before and I've just used the gradients as they were used in the ```.sf-toolbarreset``` since the last change on it.

If there's also a wish to standardize this then what are the minimum browser requirements and who can help me out testing this as I have only access to Linux based browsers (Opera, Firefox, Chrome) and I'm usually on the edge with the versions (read Opera-Next for example).
I think you should leave the extra ( and ), as they were added for readability
maybe this code cound be moved inside `orderClass`:

`$count = self::countParentClasses($reflectionClass) + count($reflectionClass->getInterfaces());`

Then it should be mergeable. Thanks.
Should it really be optional ? Omitting it will do the same than the ``container:debug`` command, no ?
I don't know if this is common in Symfony, but having a class that does something useful be its own event subscriber feels weird to me.  We've been largely avoiding that in Drupal so far.
This is always hidden; probably because of the `a` tag.
Actually, I placed a bid on this job and started working on it but gave up when I saw that the CPUserActionCell meant for a table needed to be used outside of a table.  There were two approaches 1. redo CPUserActionCell class to make not dependent on being used in a table 2. hack CPUserActionCell to force into working.  I see you went with #2 -- that is fine if all table related issues resolved.  I was seeing all sorts of crashes due to the table issue.  So, that was my main hesitation.

I will do a review.  I don't believe I have merge capabilities though.
All the numerics in the json are coming across as NSString. 

(lldb) po json
(NSDictionary *) $1 = 0x0895b7b0 {
    address = "";
    city = "";
    distance = "4218.12";
    "formatted_phone" = "<null>";
    "foursquare_id" = 4d4da76b80cb6dcb85041301;
    lat = "59.335152";
    lng = "18.001192";
    name = "Lidnersgatan 4";
    phone = "";
    "photo_url" = "";
    "posts_count" = 1;
    "special_venue_type" = "<null>";
    state = "";
    "venue_id" = 33;
}
(lldb) po [[json objectForKey:@"posts_count"] class]
(id) $3 = 0x022188bc __NSCFString
(lldb) po [[json objectForKey:@"venue_id"] class]
(id) $4 = 0x022188bc __NSCFString
(lldb)
I put warning because registering a directory to look for plugins that doesn't exist would probably happen in different environments, and info may not be something tracked in production.
- 这两行是从网上抄来的，我也不太懂具体实现，如果有错，还望尽管指出
- 刚刚试了一下，貌似不加@符号会有错，就是图形和表格混排的那个地方，表格用了tabcaption还是会显示成“图*.*”
This is the only method I added, the rest is auto-formatting.
For performance, I would sooner see this class moved out of ```transform_path_non_affine``` into the top level module preferably. Additionally, a simple docstring to explain its purpose would be helpful I think.
Why the need to handle this in a non-standard way?

If you need a different template, you can just pass in the skin to access it.  See the report-a-problem inserter or related items inserter for examples.
Признаться, никогда не понимал, зачем тут дополнительные отступы?
По-моему это всё от лукавого >:-0
Fixed - OK that's the ascii char in the driver-modminer.c - oops :)
If you put () around the expression you won't need the \ and you can put the "if" and "else" parts on separate lines. Another style note for an update later.
``@form_field_jq`` does not exist in the Prototype version (as it is about storing the jQuery object for the form field, which obviously does not exist there)
J'ai l'impression que tu as un problème de formattage, tu peux vérifier?
What compatibility are we worried about here?  This is only public to make it visible to the rest of AS it is not an API for clients to be using.
Are you okay with making button a required dependency of dialog? Currently its optional.
Whoa whoa whoa! The monitor tries to stop you from making the same channel twice for a reason! Don't just ignore the problem and raise a warning. This will result in things like the learning rate adjustors responding to the wrong quantity.
There was no condition about it. Tomorrow I will request any spec. regarding transition here (effect, duration...). Meanwhile we should apply this patch for avoiding CPU consumption, and then create a followup for applying the transition.
wouldn't be better to call it when the importing started, instead of waiting till it finishes?

Do we manage multiple clicks while the process is ongoing?
Can we add this as a single string?
create an event first and then just call window.dispatchEvent(contentEvent)
Same as above, we'll need cases for zero, one, two, few, many and others.
Sadly that is not an option. The mere existance of the 'disabled' attribute (even if set to false) is interpreted as if the button is disabled -> http://jsbin.com/ocefur/3/edit
Lint is going to complain about this if with no space before the "(" ;-)
bonus points to make the change to the sms app too :)
because `''` is a falsy value in javascript so it was redundant.
add an XXX and/or a console.error or a comment that something else handles the error...
Should be `%Y 年 %b %e 日 %a %H:%M:%S`
closing bracket should be on the same line as `else`
see prior note -- Sinatra won't build on Windows, so the rake run doesn't work, and you can't preview your changes.
If a heroku push will work, then that should be the standard Windows flow (wish I'd known a few months ago).  I got through a non-trivial part of my SaaS-RoR class by editing locally and then pushing to EC2 or Heroku to check my results.  It's a slow PITA but at least it works.
s/Rundeck は/Rundeck には/
Ah, yes. I can see how that wasn't entirely obvious, hehe.
your whitespace is off by 1 character n00b
Probably it could be useful to have a unit test for this class.
Filter out bad characters from `watch` before exec'ing with it.
Made an issue: https://github.com/AppScale/appscale/issues/111
Like for Cassandra, a lot of code is being duplicated here. Why can't you extract both copies into a superclass and eliminate the duplication?
When using dates it's good practice to use YYYYMMDD format. 

As a sidenote it's good in most cases when your dealing with filenames too as the computer will automatically sort on date easily when you do this.
We can't translate static variables.

Alternative is to declare this inside the init() function which will allow us to translate these strings but is translation worth it? I feel like this should be a static variable.

Unless we can find another way to do it. I'm open to ideas.
needs to be updated, this returns a boolean now.
oops. thx. will remove this line.
I did not (I'm on arch linux), however player.fm doesn't use a subdomain so my expectation is that this will match the same way that the unwild carded 'play.google.com' matches.
No the goal is to switch it to stable at some point, I think we will start issuing a warning first and then switch it a while later. Kind of a soft break with transition period.
On Thu, Oct 11, 2012, at 09:13 PM, Ask Bjørn Hansen wrote:

  In lib/DJabberd/IQ.pm:
> @@ -45,7 +46,17 @@ sub process {
>      # Trillian Jabber 3.1 is stupid and sends a lot of IQs (but non-important
 ones)
>      # without ids.  If we respond to them (also without ids, or with id='', r
ather),
>      # then Trillian crashes.  So let's just ignore them.
> -    return unless defined($self->id) && length($self->id);
> +    #
> +    # ... unless this is Miranda because, at least up until 0.78, it sends
> +    # roster updates without an id, oops.

  [1]http://www.miranda-im.org/download/ says the latest version is
  0.10.4, is this still relevant?

  —
  Reply to this email directly or [2]view it on GitHub.
  [J6T91GIPIyhU-8ti4GCGP5NqroswussYHXjwGAe6TA5tGDkGY_zFHhDlYCs5jmFL.gi
  f]


Probably not.  I guess nobody is running it any more :)
Bron.

References

1. http://www.miranda-im.org/download/
2. https://github.com/djabberd/DJabberd/pull/23/files#r1822466
-- 
  Bron Gondwana
  brong@fastmail.fm
This is actually the public interface of the ReteooRuleBuilder, which I need to be able to extend.....
Well, I thought that syntax was no longer supported. If it is I'll try it once more, but I guess the last time I tried it yielded to exceptions...
INOUT - TYPO?
SCReturn here or simply drop SCEnter();
merged yesterday. Still changes?
Ah! Sure! After the change, they become the same, so will remove it.

Anyway, as @garyamort said that need a bit more code. So if someone here know how com_finder should behave, I will prepare this pull for it.
as mentioned above, if ou remove the :default for the port config, you can just do:

```if @port.nil?```
First argument to `then` was supposed to be `null`.
Should or should not?
We should standardize on `browser` or `self`, but not both. Having two names is probably what caused this problem.
No, I just didn't think those options should be required, as there is a sensible default - use the same database host as the primary datazilla database. `SQLDataSource` already uses that as the default db host, so everything already works fine if you don't specify. Requiring the options just makes it a lot more verbose to use this command. Guess I should have mentioned that as a change in the pull request summary.
Same here for aData
Actually, turns out the only thing we're worried about is click through rate, unless Metrics wants both numbers but the only (time-)sensitive one is clicks. @fwenzel?
I believe you don't need this space here.
Also, if you like the idea about `pos` and `neg` kwargs, then what about migrating the following code in `dprime_from_confusion_matrix()` into `dprime()` as well?
```
TPR = TP / P
FPR = FP / N
dp = np.clip(norm.ppf(TPR) - norm.ppf(FPR), min_value, max_value)
```

After that, `dprime()` will have three different modes:
* `y_pred` and `y_true`
* `pos` and `neg`
* `TPR` and `FPR`

--- and of course, `dprime_from_confusion_matrix()` will be a small wrapper function if we do that.
It was passing because the Parser class was being stubbed, but the instance created by Muddle wasn't.  Fixed that and reverted to your output test..
you comment about your own stuffs, you're magic :p
Agreed, but not a blocker for getting this in place.  Greater good :)
this should probably go to a links.puppetlabs.com name so it can be moved around without source changes
Change to existence check for the file. Handle the missing case explicitly.
Would it be better to unify the ScopeDecorator and the behaviour of the parser scope, so that *all* scopes have the stringification behaviour available, in the DSL or outside it?  It seems like that would simplify the overall system.
Ah fixed mine, thanks for the tip. Is that a limitation you should be imposing on all your users though? And any libraries they might choose to use?

If mocha requires Errors, and someone throws a string, maybe it should wrap that string in an Error instead of the whole test runner randomly stopping?
Why should we then even trigger the SEND_HEADERS event? We can also register a listener on MVCs EVENT_FINISH and forget about SEND_HEADERS event. You can also remove there unneeded/ unwished headers.
RangeException and DomainException are basically the same except that RangeException is for Runtime (http://www.php.net/manual/en/spl.exceptions.php)
*use
Update the file and class level docblocks to conform to the recent changes in the repository, please. :) (Just take a look at any class for an example.)
The code convention is applicable to all PHP files
Is this a BC break, as it does not break existing code ! It just add some features to the interface that someone asked me on IRC. Creating a new interface ? How should I call it ? ElementInterface2 ? :p

I prefer not to include this feature rather than creating a new interface, what do you think ?
Also noting that this usage of `Escaper\AbstractHelper` instead of the FQCN or a complete import screws up some IDEs (netbeans specifically)
Please give it a correct name according to convention.
Heh, good catch =)
Doesn't look like there is a way to edit/delete existing CILs.  Probably should at least add delete so if there is a mistake they can start over.
May want to set $data to an empty array() to start with; not sure what $wpdb->get_results returns if it can't reach the DB; if it returns null that may throw php warning later when you try to loop through with foreach.
How come this isn't using jQuery?
Clarified things to make it a bit more agnostic.
they should share the same document. I think there is something else going on here.
One small note: this is not tail recursive, since we need to wait for the result and act on it. The easy rule on making some code tail recursive is to instead of inspecting something as return result, simply pass it as argument. I have made it tail recursive in this commit and added a quick check before we iterate the binary:

https://github.com/elixir-lang/elixir/commit/284093e3a6c3328ee95cc2ab423ca36b0781e037

The final implementation can be seen here:

https://github.com/elixir-lang/elixir/blob/284093e3a6c3328ee95cc2ab423ca36b0781e037/lib/elixir/lib/string.ex#L206
Yes but if ``FEED_DOMAIN`` is not set, it is initialized to ``SITEURL`` value:
https://github.com/jawher/pelican/blob/8cc3b84fbf964d08658392f612815b45946d2ca2/pelican/settings.py#L174
so I still think we should get rid of this warning (I think the feed generator should only rely on ``FEED_DOMAIN``).
inline comments preceded by two spaces and using a single hash
The synthetic ID shouldn't be part of the object equality. This is a long known anti-pattern.
line breaks please!
Put this into ngx.date module.. in ngxDate.parse. Could be useful elsewhere.
I should probably add a todo in there mentioning that this will be filled in later, as this is just the first PR of many for the Facebook app.
Why the link instead of submit button? The look? Don't want it to work w/o js?
font-weight:300;
I am not sure what you're trying to do here with the leading plus sign.

Are you converting it to a number? If so, you already did or broke that with the multiplication and division.

Might be better to do: ( +width ) / 16 * 9, assuming width is the one that needs to be turned into a number, but again, the multiplication and division will accomplish this too. Weird. I may be missing something.
Also, do a check for options.start and end existing. To check if they exist, check that they are 0 or greater, as a 0 would be false.

If one exists, check that it is the same as the start or end in trackEvent.
The context and identity variables can be retrieved and acted upon by serverside scripts. For this reason we decided to package up such information in json format and make it easily digestable.

For example there is a serverside script using the context/identity data transmitted by the bf2 plugin to dynamically move players into team/squad channels and adjust group memberships according to team roles on the game server (commander can talk to all etc.).
didn't want to change your interface, but this should probably be part of the ctor.
Now looks up the parameter dictionary from the bootstrap.
Oh wait, I'm guessing that wouldn't work for some reason with the complicated joins.
From the Renderer class docstring:
primitives should be called through the Renderer instance instead of through the class
Docstring formatting:

    """fooo
       dalej
should be :bool right?
Goal here was to have it be "type - value" in the title. 
For ForemanTrends type_name returns the model name (Environment, Model, etc). Currently for FactTrends type_name returns the name rather than the fact_name. This'd make the title the same thing twice. Maybe type_name should be different for FactTrends so the methods match.  I'll look into it.
I think TEMPLATE_CONTEXT_PROCESSORS is and should remain a tuple. You can create a new tuple like this:

```python
TEMPLATE_CONTEXT_PROCESSORS += (
    'airmozilla....
)
```
bindToRoute doesn't depend on the timing of route event anymore. It will only call callback of failback after its returned value is called. Failback will be called if at least one route event happened in between.
This will no longer be true with the new RIS translator. `itemID` is not a field supported by Zotero. See https://github.com/aurimasv/translators/blob/02364441cf8f2bfb612409acb60f6b0bc5c27853/APS.js for a better way to handle this.
Alternatively I think it should be safe to move this piece of code to PreInit() after m_pRenderer->PreInit(). The resolution is not changed in Configure() after all, so no need to set m_GlobalAudioDelay all the time here. It should be sufficient to initialize it and then only change in UpdateResolution().
The gardens/form partial refers to a `@garden` instance variable; if that variable isn't initialised then rendering breaks. So in order to embed the "new garden" form in the profile page, we had to initialise `@garden`. But it's OK, because the new garden isn't persisted until we call `Garden#save`.
`&gt;.&lt;`
Minor detail, but you might want to do something like `$(arc.point.mouseTarget[0]).css("cursor", "pointer")` here so the mouse cursor makes it look you should be clicking, not dragging.
remove `paused` and `resumed` lines. did you run these tests?
You're missing `irc_version`, a string that's sent on a CTCP VERSION command.
comment only duplicates the code - better describe why it's unsafe when it's begins with a `(`
Um, where did this whole file go? You were probably trying to keep top secret stuff out of the public repo, which is a good goal. However, I think we should talk about the best way to do that.
Did setting java formatting preferences help you with ceylon source formatting?
This is really long. Is there ever a case in the UI style-guides where you split the attribute assignments? onto new lines?
Is this checking if the user adding the members is a manager of the group? Also, the role in which they should be added should be passed in as well.
I think this logic can probably be part of the API itself.
I'm not sure, but for mirroring purposes this may need to be called ``eclipse-indigo`` (so that if we have a mirror for the id ``eclipse`` it doesn't cause troubles to the ``Juno`` build. WDYT?
I think so too. Then let's make the comment note "This class is thread-safe". Client code then can rely on it, while 'needs to be' sounds less clear whether it really is, or it's just a wish.
I guess the $_GET isnt in the right place, although I coudnt figure out as of now why that was placed here, it is gving me a fatal error. I will place it back when required in the process.
how about extending RequestMatcherInterface
Shouldn't need this function
Actually, you might want to define HicudaCopyinClauseInfo, which is almost identical to HicudaCopyoutClauseInfo.
Both HicudaGlobalAllocInfo and HicudaSharedAllocInfo can inherit from that.
This is generated as json, and is loaded as a js file simply to avoid extra async handling of an ajax request. Should be fine?
weird indentation of comments
забыли переменную передаваемую указать.
Можно было все гены из которых состоит ДНК сложить в один массив, а потом из него случайным образом получать элемент.
Это будет выглядеть более рационально и понятно.

Пример:

_types = [NSArray arrayWithObjects: @"A", @"T", @"G", @"C", nil];
for (i=0; i < 100; i++) {
  // получаем случайный ген
   [_DNA addObject: _types[arc4random() % 3]];
}
Остаток от деления на 3 может быть 0, 1, 2 но никак не 3. Т.е. в DNA никогда не будет @"C"
вынес в дефайн в последнем коммите
Давайте, пожалуйста, осмысленные названия переменным. В Objective-C это особенно поощряется.
Should return this for chaining
@dansilivestru Alas (:-s). Also, the main point me and @mdineen were discussing, is exactly _why_ FileReader gets clobbered in the top window, because it seems it is only when you include cordova.js (in your app) that things break... :-s. The plan is to discuss tomorrow in person at the hub, maybe see if the reason why can be figured out (cc @gtanner) and fixed. However if this is needed at any point, we can merge is in ASAP (we figure).
Yes, still failing.
Maybe make this a private method given that it's equivalent to `array.rac_sequence.flatten` (semantically at least).
Yeah, that's a good question. I'd again point to something like `-displayIfNeeded`. Just as there are times you might want to `-display` even if it isn't "needed", there might be times you'd want to execute without consulting the can execute policy.
These tests can be moved into the RACStreamExamples. No need to test them individually for each implementor.
As above, regarding the ordering of `@synchronized`.
`Configuration` sections are actually used for environment variables. `Notes` would be better for this.
We should have 1000ms timeout, not 1ms (in emulator I just see blink, on real device slowness of e-ink helps, but...)
title = 'Induce power - MNE sample data'
I wanted to verify `ostemp` was correct on Windows, could you test it?
As an exported function, this should have a type spec and some short doc.
Will we always only have one gem?
This import doesn't exist in current Sphinx. I tried to get this branch working, but this gave me an import error.
I'm not an English speaker, but when I read "Symfony2 does not come integrated with Propel but it's really easy to integrate Propel into Symfony2"  is seems to me that is a little redundant. Maybe something like this: "Unfortunately, Symfony2 does not come integrated with Propel by default, but the integration of both is quite easy". 
Is not a big deal, is just the way it sound, IMO looks strange...
You should put a `,` at the end of this line.
This should be `\`Composer\`_`
This is still not aligned correctly.
Also, why can it reply with None?
Да, дибаг-то убери :3
Хуй с тобой, сам запилю.
En realidad es calculada, pero ahora mismo la necesito porque no tengo una forma fácil de generar los links de forma automatizada. Uso esta propiedad como container en el frontend, cuando se persiste luego no tengo que generarla en el load.
Well, it might not be errors, per se. But I didn't really give it too much thought. console.log went to the place I expected (the console), so I didn't really give it too much thought. Over the years though, I've gotten in the habit of outputting mostly to stdout instead of stderr because I find it convenient to redirect through grep for filtering and searching and such. Just personal habit, I suppose. 


Curtis


On Dec 3, 2012, at 2:45 PM, faizkhan00 <notifications@github.com> wrote:

> In ldengine.js:
> 
> >  			// If your'e not logged in:
> >  			// TODO: If you're logged in, do all this:
> >  			// Draw loading spinner
> >  
> >  			// Get the last message element
> >  			$el = $(Gmail.selectors.message.container).last();
> > -			// console.log("name div", $el.find('gD'), "email div", $el.find('go'));
> > +			// log.log("name div", $el.find('gD'), "email div", $el.find('go'));
> Curious here, was there a specific reason you chose to output to the log versus stderr (.debug)?
> 
> —
> Reply to this email directly or view it on GitHub.
>
No. We need a seperator that is not / else it is _impossible_ to match.

Ex. `/combobot/bustingstring/path/to/a/file.js&/and/another/file.js&filewithoutsubdir.js`

The busting string is not required, so how do you know that 'bustingstring' is not part of the path?
Cool, this can be easily migrated to the task manager once we start using it! Can you put a comment to that nature so we know we should do this?
Here you actually also need to test if only one of the sequences is empty. This is because `first` will return `nil` for both `[]` and `[nil]`.
both places were updated and the pull request was reissued
Not sure about this addition. Obviously it has no impact at this stage, but do we really want the lower case version to be different to the upper case one?
Was this broken the whole time?
Even if it does lag, QGLWidget is not a solution. If the video can cause the rest of the application to lag *until restarted*, something is very wrong and QGLWidget isn't likely to fix it.
А почему-бы опционально в мете не укзать label и description ммм ?
Удобно
я надеюсь, что более опытные товарищи меня поправят, но если это планируется использовать формой, то после клонирования у каждого примитива окажется свой собсвенный клон формы.
Вызов до определения setForm или setExpression взможен?
Does including the ows readers take care of the TODO? Or is more needed?
@bp323 I need to check if _canView is explicitly set to false, because if it is undefined the user should still be able to see the page (eg my dashboard pages don't have this property).
No need to redefine that?
...pretty sure you wrote that. Though I changed it to active when we upgraded to the latest jquery ui. Perhaps the old jquery ui didn't allow this?
Can you please rewrite these examples to the new syntax rather than removing them?
the problem with just throwing 2 back out is if one disc is modified in any way, the copies disc will reflect the changes, even if in someone elses inventory. that to me is an undesirable effect. you should generate a whole new disc item with the same values as the disc its cloned from, so that it is its own item, so they can both have their own independant labels should they choose, and so that when data for one disc is removed, the other disc does not get corrupted.
I think it was safe, but this way is clearer, and now that I can use `session_cnt`, the loop will usually be fast anyway.
When I first read that line I didn't pick up on the equals and thought it was one long local declaration instead of an assignment. lgtm
This call is expensive and the domains should be given as parameter.
Just so you know, it's BlackBerry (second b is uppercase). No need to change it for this, but keep in mind for the future.
osname is all lowercase, though, so that's correct.
TODO is added - JIRA bug is not created yet - will do when access to JIRA with my credentials.
@ikasiuk he would change it to `#stefine` if he could.
Absolutely. I'm agreeing with you :-). Sorry, should have been clear that I think the solution is to go with `[NSData dataWithBytes:length:]` as there's then no need for the `__has_feature`.
Can you include something about the possible boolean values, i.e. that it'll only be 0 or 1? Some devs will probably think 'boolean' can mean 'true' / 'false', but we will only reply with ints. Thanks.
What would the default value be?
It's not clear what this may be useful for, or even what it means.
This will fail on Windows, and possible on Mac OSX. Currently wormgas will run on any platform, assuming the dependencies are available.

While I realize this isn't part of wormgas per se, and is only an optional dependency helper, I'd prefer to avoid introducing platform-specific scripts to the project. Especially since this script is only marginally beneficial -- it just runs `pip install lxml`.

That said, I added a bit of text to the readme instructing users that they can install lxml this way, as it's good to know!
and this would be the interface for content to implement and determine if itself is to be considered published, right? so you decided not to go through the repository by default.
That's the latest stable version.
@posts = Post.paginate(:page => params[:page],:per_page => 5) вот это лишнее тогда) Баловался с will_paginate, а потом понял, что лучше все посты)
`''`?
If I check other templates, we are always indenting. So the `registration.html` should be indented instead.
Where is this field defined in resource? You should define it in a similar manner as you have defined `content` above!
OK, I updated requirements.txt so that a newer version of billiard is there. It is written that it has some improvements for installation on Windows. Please try it (pull from main repository and run pip install on it).
What exactly? Textarea?
(You do not really need an additional function for this.)
Good point, I converted it to an error()
commited another switching back this.

Thiago Dias Pastor


On Thu, Mar 1, 2012 at 7:07 PM, espes <
reply@reply.github.com
> wrote:

> >  <Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="
> http://schemas.microsoft.com/developer/msbuild/2003">
> >    <PropertyGroup>
> >      <Configuration Condition=" '$(Configuration)' == ''
> ">Debug</Configuration>
> >      <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
> >      <ProductVersion>9.0.30729</ProductVersion>
> >      <SchemaVersion>2.0</SchemaVersion>
> > -    <ProjectGuid>{7DE47032-A904-4C29-BD22-2D235E8D91BA}</ProjectGuid>
> > +    <ProjectGuid>{10E726F7-7F99-4BDB-972E-E3ED440DEDA8}</ProjectGuid>
>
> Might, yes. Best to keep pull requests clean.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mono/MonoGame/pull/342/files#r509045
>
I'm still not sure you need this, but it doesn't hurt anything.
$resource, $privilege, $arg1 = null, $arg2 = null, $argN = null
Good idea - done.
Rename this struct to ```GuildNewsEntry```
why not just use dt_get_wtime() (will be a double in seconds), that seems to be less code?
Less code :D 
```php
if ($this->userIdentity) {
    // logged in
} else {
    // not logged in
}
Why are we committing to a JDBC-style driver?

We don't need to stay in the "SQL" area. Actually, we don't even need this overhead.

Anybody considered using _net.dataforte.cassandra.pool.DataSource_ as a client instead? Maintained by the Infinispan team ;-)
In general it's not a testing utility, but I'm using it in a test. We don't want to bundle it because people may not use it.
Am I missing something?
Please add a bit more info about how the "unknown fields" work, from a user perspective. An example describing what happens when data is read with one schema and written with another would be helpful. What's the performance impact of dealing with unknown fields?
Please include unit in method name to avoid wrong use.
Hmm, it still seems to me we can get by with rank checking. I'll have to think about this and do some testing. Stata may be a bit different because it isn't really designed to handle ANOVA well and has no concept of contrasts AFAIK.
There's no need to specify `nil` explicitly – `return` without a value will return `nil` anyway.
Couple of problems with this method:
- makes reference to MessageHandler that isn't present in the interface.
- why is the timing of handling messages left to the discretion of the caller of this class?  Shouldn't a message handler (if present) just get invoked each time there is a new message?
this dotted border won't work in IE6, could you use a background image instead?
Could be worth stating more explicitly that currently GalSim literally doesn't include the machinery to include radiation or w != -1 (i.e., it's not just an assumption for this example script).
2+1 != 2+3    

-_-
Your recommended wording makes sense--I'll change. 

Maybe I'll add a simple note on the page about losing work and/or a tooltip, rather than a popup confirmation, as warning popups can be pretty annoying.
FYI, keyword arguments can be used for repository creation:

    repository = Repository(
        name=hook_data['repo_name'],
        user=hook_data['repo_user'],
        # ...
    )
What is this for? Why are you doing the same thing twice?
Dito: yuck to auto-generated hashCode and equals methods!
I like
```
...
```
return Objects.equal(additionalOptions, other.additionalOptions) &&
        Objects.equal(commands, other.commands) &&
        ...;
```
I'd log the exception (at debug), rather than just the toString. Useful to have the stack-trace of who unsuccessfully tried to resolve it. But no strong feelings.
Do we really want the LocationDefinition to generate the id if null is passed in? That will hide some programming errors. If we really want it, better to overload the constructor to have a version without the id parameter.
Yes, cf notre discussion precedente !
A le lire je sais pas si c'est vriament courant de dire "tiens je travaille sur ça en ce moment", surtout dans la mesure ou c'est un pb enorme ca demanderait plus qu'un full time sur la question, limite un sujet de recherche
Certes, mais je ne pense que ca parle tout de meme. The Economist pare tjrs de Hadopi comme d'une "light SOPA".
Faut pas etre trop nitpicky, on fait pas une demonstration mathematique !