labofsahil/github-event-dataset-2012 huggingface dataset:
Hi @davehunt, just to be clear, this is my understanding:
- L2 of travis.yml downloads selenium so that it can be [started as a local server](https://github.com/davehunt/pytest-mozwebqa/blob/master/.travis.yml#L3) which all the tests that run using RC need
- [python setup.py install](https://github.com/davehunt/pytest-mozwebqa/blob/master/.travis.yml#L14) downloads the latest version of selenium from pip which is now 2.25 

So, this *is* related to the selenium change, but there's no need to change travis we just need to update the tests...does that sound right?
why don't you use IPEndPoint as the key in the transportCollection (vs using a string concatenation between the address and the port)
hah, you're right. The shame!

Though really we should work on making the whole code more modular, i've another bug to solve involving timestamps in filenames and the code is a little confusing at present.
Didn't seem to be used...
Oh, perhaps I didn't entirely understand:  Does it get exposed to users of the provider?
This should be a `ChoiceField` and not a `CharField` probably?
Ha! No.. totally missed that because I probably copied the return method syntax from the actual Jasmine library. My bad.
My understanding was originally muddied by the fact that the code directly returned the 'updateCount' directly, so it wasn't clear that it was always either 0 or 1: the case statement below this probably now makes it clear enough that the update statement should hit exactly 0 or 1, so we can remove the limit again.
is foreach really necessary here?
Makes it slower the farther you are from the breach.
it probably can't find the fortran compiler. Try adding `ENV.fortran` if this needs gfortran.
Methods are assigned as simple functions and not scripts, meaning that they won't serialize. This wouldn't matter if the TouchList objects would declare `isEpiMorph` but they don't. So either they should be epi morphs or they should be made serializable.
Forgot a `debugger` statement there
can you please move this to the corelib->Providers->Rackspace->Objects->Request folder and update the namespace accordingly.  Also, please make this an internal class instead of public.
А тут нет бага?
PEP8 issue: test_search.py:23:44: E201 whitespace after '('
Why are there two ways to provide fields for `$meta`, redundant options is just bad for maintenance later on
In general you should stick to the `+` operator over `array_merge`
Can you move this below the try-catch?
http://www.gevent.org/gevent.select.html

does not mention any blocking cases.  Can you elaborate?  Blocking the current greenlet is fine.
OK, cool.  As far as etiquette, no idea what's standard, but I've already made the changes and tested locally . . . so I got this one.
Hmm, I seem to have lost the ability to reply directly in github.
Hopefully you'll see this in an appropriate context anyway.

> the one thing i will say in favor of `import bar as baz`  is that since we're still using py2.5 and simplejson, we have a fair amount of our codebase that includes `import simplejson as json` which, since simplejson and json have the same effective api, will make *that* transition easier (assuming we remain using python and appengine! ha)

I have no problem with 'import bar as baz'!  (Though usually I'd just
use it for compatibility like in the example above, or to bypass
modules as in 'import foo.bar.baz as baz'.)  It's just 'from bar
import baz' that I don't like.

craig
Uhm, give me a few minutes.
I think the attribute 'num' is because XML does not guarantee order, so external programs could mess up the list and it'd still be correct.
While I'm all for using namespaces, does this interfere with using these from within a debugger?
It's a set() here because the value returned by queryChild() is not linked (as indicated by the fact it is called query.... not get....)

It's a setown above because the value returned by createConstant IS passing ownership (because it's a construction function)

The constant won' be leaked, it will be released when the new value of folded is set (if both conditions are true - though I don't think they can be since a constant would not have a child).
very very unlikely.. but lets remove the warning and use consistent type
Hm, yes, this was wrong in my release.
wuid_version was supposed to be a top-level attribute.
I'll change.
We cannot have a common interface between the MongoDB and the ORM queries. They are totally different.
Deprecation warning, please!
Almost everything else in this project is using ``require_once( ... );`` (with parentheses), why not keeping that style? Consistency for teh win! :)
Why `sudo`? The standard instructions for npms is without sudo.
This really needs a test in test_utils.py for me to pass. To me, a test describes what it does better than me having to read the code.
I agree it would be better but I think it is ok. 1) It would get logged here. 2) We don't edit the operational_timeout_in_seconds either or in general any paramaters in rest_connection so it wouldn't add a lot of overall value. 3) We are going to dump this code ASAP.
Good point, I should update the levels to match.
same as above explicit form is better.
Multiple versions of CS? node.js versions differs from CS versions, since CS compile to javascript.  But I know what you mean, I am thinking who we can handle CS code and node-versions. Thanks for point it out.
as a requirement, really ?
@gtanner - I can't get this test to pass, need some help figuring out what's going on here.
The expression `(> (author-count book) 1)` returns a boolean by it self.
For safety, 'count' should be initialized just above the while loop.  Unlikely, but it could avoid some weird bugs
Any idea why raspberry was removed from the list?  I would think the list would never shrink since old passwords would work against un-updated systems still.
You're only saving one port, right? So is this loop needed?

On the other hand, can't you forget ports if there are different instances listening on different ports?

I think you should report all the ports you find in the tnsnames.ora :)
Joel, we're trying to stick to a standard layout for the READMEs - if you look at e.g. numberguess or kitchensink you can see the headings we normally use. Would you mind updating?
Shouldn't the code be as follows?

```python
if vouched is not None:
    s = s.filter(is_vouched=vouched)

if photo is not None:
    s = s.filter(photo=photo)
```

It seems that the two conditions should be treated separate no?
Can you test this with `document.head` and see if it still passes all of your unit tests?
Am I misunderstanding something? This test is saying mods *can't* edit. Which behavior is intended?
There is no `autoconf` in the main repository so this won't work. Cross-repo dependencies are not implemented yet.
me no like
Or should these all be throwing UnsupportedOperationException?
Actually, strike that.  I'm still going to call it getUtcOffset, but it will return "the number of seconds this JulianDate is a ahead of UTC."
This requires creating an extra canvas and context, right?  How does that increase startup time?  Does it decrease robustness due to bugs in browsers/drivers when using multiple contexts?

We should really try to avoid this.
Why convert `positions` to `[]` if it is `undefined` here and above?  Why not just leave it as `undefined`?  Does that make code elsewhere nasty?

Is it better than:
```
p.setPosition(undefined);
p.getPosition(); // []
```
`1.0`, `2.0`, etc.  We intend these to be floats, right?
handleGetActiveTab just returns the selectTab class variable, which is the same as what we used in the removed code.
Check the default value of showStats...that makes it easy to enable and disable without having to hunt through code...I always leave it enabled.
Also, isn't it possible for the Item to have a null Proxy field based on how it is created?  In general, there is no guarantee that a Item object has to have a valid initialized proxy property.
This log is sort of confusing. Rephrase perhaps?
alright, did not know that .
But why? If there isn't a description then you're not adding any value to the Javadoc
I think best practice is to ignore packages (not /packages) to ignore the symlinks across the directories
I don't understand this, can we discuss this?
See https://github.com/jquery/jquery-ui/commit/f2854408cce7e4b7fc6bf8676761904af9c96bde
Trying with other languages should really be restricted to the few cases where we know that there is a chance that a retry will actually do something useful. I presume you were thinking about encoding exceptions here? It would make sense for them.
Entendi, acabei optando por essa forma por ter que escrever menos texto, mas o que você falou faz sentido mesmo.
More just DRY from my point of view. Both are full sentences if you concatenate the header-bullet with the sub-bullets.
`else` should be on a new line
s / header_firefox_logo_src / firefox_header_logo_src
This change is probably the result of a bad/sloppy merge. It's always wise to review the complete diff before submitting so spurious changes like this don't appear.
Why importing `std.file` is needed?
2^19937 is only the cycle length for `Mt19937`, not for `MersenneTwisterEngine`, right?
Looking at put in std.range it does take range by ref thus array or no array it will get modified.
Shouldn't this be `/**`?
This is wrong. You've put all of these changes in the section for 2.060. They need to go in the section for 2.061. I just added that section to the changelog, so you can put these items in there.
Wrong javadocs
Should probably slice it to sys.argv[1:] since sys.argv[0] is the name of the script you're running. Not that there should be a collision ever, but we don't need to be checking it anyway.
You could note that this is fixed in Java EE 7 :-)
d3.instance.warn_msg でアクセス出来そうです。
$log.warn @warn_msg したあとにnilをセットしてるのですが、それをやめれば良さそうです。
So this is the counterpart to startupInPluginMode? What's the difference in the requirement that this isn't another startup* method?
btw, if you have time to look at the PR and eventually test it in your own app, it would be fine (it works for my ORM-based application)
just a small point here: the inversed side of the OneToOne relation *always* load the owning side, because it needs to query the table anyway to find the id (which would be needed to create a proxy). The current mapping makes Invitation the owning side, meaning that each time you load a user, you will trigger an extra query for the OneToOne. I would revert the direction of the relation, making User the owning side as you will probably use users far more often than invitations in your app
I'm really sorry, but not only was I unable to figure out how to do this with a JSON call, I couldn't even make checking the version of the database work correctly, so, since this code is going to be rewritten for Frodo anyway, I settled with a really ugly try-except hack for now.

Sorry again! (I'll keep trying when I have time, also, I'll attempt to help rewrite some code to use the JSON API for Frodo.)
Not sure I follow, managercli is using classic_check.ClassicCheck() directly. It could stay in hwprobe, but it seemed to be out of place. Though the move was mostly to avoid having to mock all five places we imported ClassicCheck into the local scope for testing.

On second look, there is really no reason for that to be a class though.
If it points to nothing, the "if (val.get()..." clauses will stop any further damage (specifically, filling in the rest of the matrix with zero).
* 不要なファイルは削除してください。コミットする前に確認しましょう
Hmm, if I remove that line, then clicking "Remove class" does not close the dialog.

(I suspect it's actually closing it, and then immediately reopening it.)
this only works because i made the routeRepository not specify the document class so that on the findManyByUrl will accept anything implementing the right interface. i could (just ;-) live with that.

however, $this->routeRepository is just something implementing RouteRepositoryInterface, it is not defined to be a doctrine repository. the assumption to have a find() method is dangerous.
тогда нельзя будет пробегать циклом
Напрашиваются смартпоинтеры.
ahh, right.  docs updated.
Same comment regarding the use of `$` here
Since we use `tempDocData[item._ref][cell.id][cell.type]` so much, can we store it in a separate variable?
Can we chain these?
I don't have any strong feelings about this, so we can just remove the `@trusted` if you prefer.
What is Tango code even doing here?
store the filters in the object
If someone has an SLA for 5 seconds, they obviously should not set a -1 timeout to indicate "indefinite".

If someone does set -1, that's intentional, and right now we are not supporting it.
As i said I had 'not' there on purpose to give it a DSLish-like feel, but two beats one so I am changing it.
Fixed with commit 780d93c. Changed naming to `deleteInBatch` and it defaults to `false` after a discussion with @olivergierke. The same convention is used in Spring Data JPA.
@celibec IMO this change is fine...
Without your change, 'email' or 'username' or whatever is dupe in the query.
Is it the same table structure as `page__block` ? There's a `--table` option for the command.
how is this related to cucumber?
Yes we want! :)
I have tested the two still open pull requests:
https://github.com/mavlink/qgroundcontrol/pull/41 and https://github.com/mavlink/qgroundcontrol/pull/43 are based on aaf236a9ac7423262a41c6a203f163d6541df225, which is the current master.
What you mean is pull request 37, I think. I figured out that it was based on an older commit and closed it myself.
I think that they remaining two should apply without merge conflicts.
little bit diarrhea here.
Really?!?!?  Was this for the old library or ACE?
This does not need to be done in the code called by the compiler pass IMO. You could do it directly in the extension (checking the filesystem can be done even if services defined by other bundles are not accessible)
Une légère répétition sur "simple" (avant et après l'exemple).
We remove the docstring?
Add the reference link to getConfigurationClass in DeployableContainer
Клево, спасибо, Антон.  Сэкономил на операциях :)
Code should be marked up as ``literal``, not as *emphasis*.
What are the values? Are there constants for byte orders?
Need to add Ti/UI as a dep and use UI.SIZE.
This code block can be removed completely if it is obsoleted by SIZE behavior.
you should typehint the parameters as array
Yes, alignment could lull them into complacency.
Here too.


How did you arrive at these epsilon values?
Please, tell me how to describe `$p_master`.
Просто так понятнее, что скрипт делает.
can I get rotate method as well , even though spec doesn't have it I think its useful
led reference should not be there.
use return NULL instead, pthread_exit() does the same thing but takes longer
With this `builder.generator.Container.date_format` i thik you'll take the ` getDateFormat`  on the symfony container. I think just renaming `setListParams` into `setTwigParams` do the job

` $generator->setListParams($this->container->getParameter('admingenerator.twig'));` ->
` $generator->setTwigParams($this->container->getParameter('admingenerator.twig'));` 

So here you'll call `builder.generator.TwigParams.date_format`
`(= (mod n divisor) 0)` suffices as it returns a boolean