labofsahil/github-event-dataset-2012 huggingface dataset:
to is intended here: you can also give a path to a filename iirc
Pagination for the win..
Not a huge deal really, I was just curious. You've obviously done some good work on it. I'd say merge it all (if it hasn't been yet), and then do followup cleanups if deemed necessary.
Do you want to expose the actions serialize, deserialize and convert_value to the public? They should be - at least - protected.
It's probably better to have each locale on a separate line. Makes it easier to add items without having to change the line wrappings and makes it easier to verify that items were added since a single item added doesn't change the whole block.
First, full test available breaks all of linux environment (32, 64, 32/64, and 64/32bit), but after the fix, 64 and 32/64bit test succeeded.
I think current ProxyOf implementation uses many memory in compile time, and it may occurs memory corruption in building unittest.
Hahaha ugh. Ok, this is fine then.
Sounds good; I changed the code to use these three names. The QUDA_VERSION is redefined as 

#define QUDA_VERSION ((QUDA_VERSION_MAJOR<<16) | (QUDA_VERSION_MINOR<<8) | QUDA_VERSION_SUBMINOR)
@tomdale I think something is missing here: "... if youOne option ..."
I pushed the fix that remove all the optimizations_enabled mechanisme. We should use optimization tag for that.
I think my last commit will correct this bug, but I wasn't able to reproduce a crash.
Could just do this in `onLoad()`.
Improved in 7c2bbdf.
i guess this line should be smthng like

    until doc.files[filepath].tables[t.name .. i] == nil
This looks overly complicated. Let's assume that the logger apps are initialized with Logger instances.
@shigeki yup, that's correct
Oui la vérification est déjà fait.
Je vais rajouter le test de vérification de l'API ;)
you will need this to be global + please, don't call it U + please, stop using "this"
(on the other hand, i guess you'll have no problem with python -- there you have to say "self" all the time)
getnumber를 사용하여 재구성해야 할까요?
It's not a good idea to use irc.lfnet.org (our nodes may be banned by Bitcoin developers)
In general, some comments here would be very helpful.
Hmm. This is a bit of a dilemma. If it is not set, would it be better to ask the user to do this first, or should we try and detect where Xcode is and set the path as part of the script
cool! this will help let people know about TotalFinder, maybe we don't need to include non-Mac apps there - hints are pretty much Mac-centric
Sure I'll look at doing this "the right way".  When I originally wrote this, I was daunted by the idea that I'd have to lookup the right thing for rhino, jsc, node, etc, but if we're standardizing on node and the browser things get easier.
bad comment: should reference issue #1808 not 1 8 8 0.
There are some important comments here that have an effect on this release. http://blog.flameeyes.eu/2012/02/25/test-comprehensiveness-versus-replicability-a-ruby-rant

We'll have it out soon, but we care very much about the quality of the experience.
Nope :) It's bad idea to insert information about descendants into parent class. IDEA even has "'instanceof' check for 'this'" inspection for this case.
Also, the quick tests aren't that quick with boot time and all. Waiting for them to run every time you run make is really annoying.
Ah...sry...dachte es wäreGetBasePath ;)
jap...so kann mans einfacher ausdrücken;)

zumindestens ist das bei meinen render-Versuchen nicht der Fall gewesen
@rsa Когда-то включал - за день 4-5 гиг капало. 
@mosst ошибки эти никак кроме записи в лог не обрабатываются. В принципе, можно ради эксперимента сделать, чтобы лог файл вообще не писался...
http://pastebin.com/K1HHR6aB
не Y а Z
`params['sort'] = 'addon_name'` would suffice
Issue# should be #260.
no nos escondemos xD
In fact, I'm betting testing for rdma_verbs.h like you had changed it to would be sufficient, but I'll put an explicit version check.
And forget my emacs? Never :)  it took me years to learn the shortcuts, I
need at least 10 years to get back my investment time back :)


Jean

On Fri, Mar 9, 2012 at 9:49 AM, Andreas Karfusehr <
reply@reply.github.com
> wrote:

> I think you need Sublime Text and good music to find some kind of failures
> :D
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/naparuba/shinken/commit/131b678e799e23dca28b5a11ff6f6bef93f7b7fa#commitcomment-1064753
>
The error seems to happen when trying to copy "/tmp/homebrew-pgrouting-1.05-U4PJ/pgrouting-1.05/lib/librouting.so" to
"/usr/lib/postgresql/librouting.so".

Unfortunately I don't have Lion so I can't test it. Here are some stuff I would look into:

* Do you have a `/usr/lib/` folder? `/usr/lib/postgresql`?
* Maybe those files should be installed somewhere else because you do not have the rights to write to `/usr/lib/`. In that case, I would look into the pgrouting documentation to see if I can modify the folder in which those files are installed.

Hope that helps!
What I mean by moving the permissions into the groups would be instead of a function checking Addons:Review, Apps:Review, Personas:Review we have a group called "Review Reviewers" with those 3 permissions and we just do an is_in_group check, whatever that method is called.  Robhudson will know if that's a good idea or not.
I think I know what's happening. ctr is unsigned and it's being compared to an int which is cast implicitly to unsigned and therefore positive
Your right Matt. Actually this little detail caused IE8 to completely fail to load Crafty. I have changed it to ['continue']() instead. Hopefully this also solves the YUI problem. Well, that might actually me why YUI issues the warning in the first place :-)
Why they would introduce a new standard that breaks IE8 so badly is beyond me.
Read more about it @ http://wiki.eclipse.org/M2E_plugin_execution_not_covered
why do we need the `extra_tags`?
Thanks for the comments, Joel.
Thanks a lot for this bug fix!
Diego,

Thanks for the patch, I will accept it as soon as I have a chance to write a unit test to verify the functionality. I inherited this project without unit tests, so I am starting a test suite before I can verify this.
This breaks building bootstrap with less 1.2.2
Pretty sure it should be id >= quickMaterialLookup.length!
Diesen Commit können wir gut mergen, bloß müssen wir uns überlegen, wie wir die ``Reflections`` (bzw. den `Ìnstantiater, den ich darum gewickelt  habe), ins Reporting kriegen.
we seem to keep writing this code, i wish there was a way to deduplicate some of it
meeeeeeeeeeeeeeeeeeeeeh
factorys have a final statement: "public final class JgilityProjectFactory [...]" is right
aint nothing trailing about that totally valid end of sentence full stop!
@aostanin
Yes, they're needed.
In fact, I added them because, without them,
it didn't build on Windows.
sync; sync; sync; reboot
should the tip details be `loc()` then?
项目中应用到的一些开源解决方案
Does `mkdir` succeed if the folder already exist? Consider using [mkdirp](http://search.npmjs.org/#/mkdirp) instead to allow creation of the entire path.
It looks like the only SDL function that does alpha blending is
SDL_BlitSurface. Grepping the SDL source tree for "blend" leads to the
SDL_BlitSurface code; similarly, the SDL docs say that with
SDL_FillRect, "no blending takes place".

Unfortunately, as noted earlier, SDL_BlitSurface doesn't implement
stretching, which we need. Thus the only two solutions I foresee are:

a) writing stretched RGBA pixels to a temporary RGBA surface for each
Draw/vDraw call before SDL-blitting this temporary surface. The
surface would have to be cleared before each Draw/vDraw, and we would
actually be blitting twice, once RGBA->RGBA (stretched pixels ->
buffer), and once RGBA->RGB (buffer -> screen).

b) stretching and alpha-blending the pixels ourselves before calling
putpixel [which is what the code currently does].
Unfortunately, yes. Not my first choice but I could not figure out why, when the security class was loaded it was thinking it wasn't. I know HMVC and the form validation lib have some issues with the CI pointer belonging to another instance but I have implemented the recommended fix for that already. Definitely open to other ideas...
2 spaces before a comment
what I tried to implement was a very short interruption, just to allow for another events to intercept
my thinking was that the number of checks is limited and thus this chain of calls with the short interruption time will end relatively soon
my first try was to have no wait time at all but then the UI was unresponsive
Drop:

public function dontExposeVersion()

Otherwise it's cool. I'll have to write some unit-tests before it can make it in a release though.
Lets not have omzsh try to update itself
Why was this change needed? I would think it only makes sense to run the `post_install` hook of only those specs that are actually in the given target.
:+1: pending some confirmation from the reportee that this improved performance. Moreover, it'd be nice to see if this had a positive effect across the board.
那改成 `user.try(:admin?)`？
Ja, perdón, me equivoque
Ooops! Sorry, I didn't mean to do that. I'm not quite confident enough with git to recover the files :-(
Nicely noticed! It is Canvas.js for me when I committed, but for some reason it didn't reflect when I renamed it
Cross-ref: https://github.com/rabbitmq/rabbitmq-dotnet-client/issues/8
你描述的这种情况我没有处理，目前hash结构的value对象仅支持非范型的简单对象，需要加入重载函数才可以实现，只是这样应用redis的hash结构我个人觉得有些怪，按我的理解，redis的hash结构不该如此使用，或许我考虑的不够周到，我尽快添加支持范型对象的重载函数吧。
LGTM

I will merge this in now.
To fix that I will have to roll-back the whole repository and try again with uncertain chance of success. Everyone would have to clone their repositories again. Do you want me to do that?
If it comes Abstract , I wonder whether we can make the class as Abstract itself naming some method to abstract. Because we can resolve the confusion . What you think ?
Went ahead and cached the encoding since we're going to need it in just about every HunspellSpellChecker method.
We can do that with labview, I can show you how whenever you want
So does having plugin.manifest not make any sense anymore? or for that matter any methods that are a passthrough to popcorn ?
if we would name entries in enum:
CHEST_SAURFANG_CACHE,
CHEST_SAURFANG_CACHE_25,
CHEST_SAURFANG_CACHE,_10H,
CHEST_SAURFANG_CACHE,25H

and then use only CHEST_SAURFANG_CACHE for storing/getting the guid then it should be good.
But how will you see your train?!

:-(
I've noticed that .rotate doesn't seem to work on chrome and the above code fixes this issue. Will leave change in place in my project and test for a while.
rehash isnt implemented (i think...) so that cause error compiling
What about passing $this->User and $this too? Like for the save_callback :)
Then the alert command would need to be commented out so that the user can enter in a name and it gets stored in place of "NIck".
it seems your master doesn't include any of the changes needed to compile on mac.
Missing from the commit. Will add.
@maniksurtani when a remote get occurs, a remoteTransactions is created and added to the remote transaction table. With this fix, I don't think that the remote transaction is evert cleaned up. Besides being a bug, this might also drastically affect the performance, as the remote transaction table could grow huge. 
One way to fix this is by delaying building the RemoteTransaction on a remote node up to the first lock requiring operation: that is either a write, a lock control or an read with force write lock.
Jag ser att du tänker testa JQuery, vilket kan vara en idé. Jag har inte hittat problemet ännu.
@SkyFire, why u insult me and my nick? So tolerant...
The problem is str()'ing at all (or generally speaking: doing type conversions at all without need). The fact that your original data came from the web has nothing to do with it; the question is how the callers will use the data you return.

A pragmatic reason is: type conversions are just a source of trouble. So, a good rule of thumb could be: just avoid converting stuff and return the data in the format it is, unless the whole point of the method is to help to make a conversion to help other code.

examples:
- total_expenses() is using floats to make the calculation, so there's no problem at all in returning your float data back, just to avoid the trouble with conversions.
- exception to the rule: the point of prices() is to get the text from the web page and return numbers you can do useful work with, so a conversion from string to a number is helpful to the code that uses it.

A more abstract reason is: you are calculating a sum and you already have a numeric value, and the whole point of your method is to calculate a numeric value.

Returning a more restricted type also helps to make your caller understand exactly how your data will look like, and trust that your method won't do anything unexpected in the future. It's easier to say "this method always return a number" than "this method always return a string that looks like a number". It's like the Unicode stuff for textual data: instead of saying "this method returns text that is valid unicode, encoded in UTF-8", you can simply say "this text return unicode data" and let the caller encode it as str only if necessary.
Just a note about something that could be a bug later: `fn` here might be used at several places, leading `unbind` below to unbind all bindings of `fn`. Think about a "class method" for instance..

Two solutions:

* Wrap our own version: `cb = -> fn.apply this, arguments`
* Also save the context: `@bindings.push evt: event, fn: fn, src: src, ctx: this` and use it during `unbind` below..
Looking forward, it might be better to generalize combat.on_hit for any function, and call them more like a talent.  Or change it to an actual talent-on-hit method.  I'd like to see some really crazy effects (explosions or chain lightning on hit), which atomic effects may not handle without a lot of hacking.
Haven't worked on it in awhile.  I started to see if I could setup a thread
to receive the UDP stream from the HDHomeRun Prime and then re-transmit the
packets as an http stream.  I was getting data from the prime, but not
successful doing anything with it.  I'm going to try to pick up work on it
again soon.

On Fri, Jan 6, 2012 at 3:30 PM, Eric Work <
reply@reply.github.com
> wrote:

> How far did you get on this before you stopped working on it?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/drhill/libhdhomerun_java/commit/b061e9c5280fedf6ad828b26193e93f5c004cf3d#commitcomment-844850
>
Right; corrected in v3
Just made a [pull request](https://github.com/mongodb/mongo-ruby-driver/pull/93) which would fix the issue.  Did so before I saw the reply by @banker.  Thank you for being attentive to this!
Darling, why this change, I know that exist many currencies.
I know it doesnt, but where else would i post this? I put it in the bugs and it was just closed without reply. the issue exists, and crashing without saving is a big deal. stop ignoring me and look into it!
Should indicate `NULL` is a valid value if this information is not necessary, pointer object is set to YES/NO accordingly
@satra: I guess it would save a few lines of code but, like you, I'm fine with having two scalers, one for X and one for y.
whoops sorry forgot to set up git ...
diese doofen () :D
So why do we need this additional member variable for ? Based on the comment we should probably at minimal rename it if at all needed.
should return promise instead of deferred object
para que al castear el spray ese se ponga mirando hacia donde lo castea, y no lo tire por el culo. Lo has probado a este?
no problem, despues lo cambio, mi ingles no es el mejor :P
Failzor <--- bemac would say that.
1. On embedded Derby Competing Consumers can read the same message in separate transactions at the same time. That's why I concluded Derby doesn't support lock on FOR UPDATE. However as you see I've added additional check on null-return for **removeMessageFromGroup()**, so it was enough for Competing Consumers on Derby MessageStore.
2. I've tested it on Oracle. It support locks on FOR UPDATE. So, one of Competing Consumers doesn't get the same message at this point at the same time that one other.
All other repos have these functions separated.  Any reason not to do the same here?
Oh ok, weird. SVN FTW ;)
how did you fix mono??
The naming of this sub does not reflect the functionality, as far as I can see, this function doesn't do any calculation.
Not 100% about the version range here. What do the OSGi expert say? ;-)
1.0.x is definitely releasable, we're already used in production for small and big migrations. I think we just forgot to push the gem.
FYI, these model parts are supposed to be split out. How does this compare with the ones already present in this repository?
Hi,

I published a post on my blog where I explicitly had said that I won't
support any of VMware's EOF products (
http://radu.cotescu.com/vmware-server-linux-kernels/).

You can try to fork my project and continue the work, if you want to.

Regards,
Radu

On Mon, Mar 5, 2012 at 13:23, mirabilos <
reply@reply.github.com
> wrote:

> Will you add support for Linux 3.2 in Debian wheezy?
>
> I’ve managed to make a stand-alone version of the Console “plugin” as
> *.deb file, based on instructions from the Heise c’t/iX magazine. I think
> I’ll write that down and send to you.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/raducotescu/vmware-server-linux-2.6.3x-kernel/commit/bb26dcecbb1accfc946f543c711f09a8e82c479e#commitcomment-1042625
>
Кажется имеет смысл везде где принимается id проверять на тип этого параметра. У меня были случаи когда по ошибке я передавал саму ноду вместо ее id и терял какое-то время на выяснение что же не так.
No need to make a *new* pull request. If you just push your changes the pull request should update automatically.
This threw me off. I saw code after a `return` and I had to look at what it was actually doing to realize it wasn't a mistake. Can you make this a bit more clear by creating local `var`s for the arguments which are passed to `_serialize()`?
Javadoc is required on class header...
By doing this we have to make sure that we never delete these old docs. Can we ensure that?
keep an eye out for Java API: we generally do not use (partly) symbolic method names on interfaces which can reasonably be implemented by user code
This was posted before that was pushed. I need to merge it.
I can add a comment about it
Removed from interface.
Always put unlock in finally clause.
what do you think about using plain Try instead of this `wrap`
E.g.

    Try { 17 / 0 } getOrElse 5
Bah, I hate it when I make silly typos like that. Fixed.
I don't think this has to be hardcoded, but it was convenient a few times in debugging.  In any case, it shouldn't need to be hardcoded.
Mover to System Class Helper
See pull request #542 , which solves this. Requires the `requests` library (urllib2 was too much of a pain). It exits gracefully if requests isn't found
Ah, I see it now.  Thanks.
Did you have a look?
you do not have to delete the fork; there are many people who fork the repository without fixing anything

if you want to save some space, you can delete it after I merge this pull request
добавь тут текст, что код взят от туда-то
DO NOT UPLOAD this file, this was generated by your editor.....
never do it agagin
thanks
Add *_MINUTES types of schedules
http://wiki.obiba.org/display/CAG/Search+Service+and+Indices+Administration#SearchServiceandIndicesAdministration-ValueTableIndexResource
Then [`GetOne`](https://github.com/tent/tentd/blob/9aee6cfca3ae743efcf5e000b31ad6aee8fa2bd5/lib/tentd/api/followers.rb#L166) should 404 also?
If the artifact is synced in central, could you remove the repository configuration from pom.xml?
?
I think the +/- lines are not related, it's a diff viewer glitch. Or I don't understand the question.
Seems like this is missing a check for this.parent to exist before checking for this.parent.getParentNode.
I believe the `end` function gets an object like `{files: []}` with and 's' when there was no error, and `{err: ''}` if there was one.
Alright! :+1:
Oh, so THAT'S why we didn't have to include `@synthesize`. Where are these new features/additions to LLVM documented?
Aren't you requiring all ChannelFuture to be ChannelPromise here? Why not return ``this``?
Doh.. Thanks

Sent from my iPhone. Excuse any typos....

Am 18.09.2012 um 08:28 schrieb Trustin Lee <notifications@github.com>:

> In src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketPipelineSink.java:
> 
> > @@ -231,10 +246,16 @@ void register(NioClientSocketChannel channel) {
> >                  boolean offered = registerTaskQueue.offer(registerTask);
> >                  assert offered;
> >              }
> > -
> > +            if (channel.connectDeadlineNanos > 0) {
> > +                if (!channel.isConnected()) {
> > +                    channel.timoutTimer = TIMER.newTimeout(wakeupTask,
> > +                            channel.connectDeadlineNanos, TimeUnit.NANOSECONDS);
> newTimeout() accepts 'delay', not 'dead line'.
> 
> —
> Reply to this email directly or view it on GitHub.
>
why this is removed?
To the first point: no, we have to reindex if we want to populate the eppn_authnId field for users. We may be able to get away with only reindexing Authorizables if Solr can preserve the old Content indices - I'm not sure how it will react when we change the schema. Ultimately we will be reindexing everything as part of the 1.3 migration.

To the second point: ya, you're right. I was there working on the schema and thought that email being case insensitive was the "right thing". But truly it should be in another commit. I will re-issue the PR.
This has no relation with the pull request and shouldn't be included here.
This is internal implementation. Does it actually matter?
Don't we need to sanitize or mark as html safe to it work?
I prefer this:

```ruby
options = options.dup
length = options.delete(:length) { 30 }

text.truncate(length, options)
```

because if the truncate modify the options hash too it will not modify the original.
`lazy val`, I agree.
Relieved to be proven wrong, thanks Aleks!
Although, I still don't know how to use the templated external functions as what was already in scipy/linalg/flapack_user.pyf.src. I have no idea what the call signature here means or how to add an optional third parameter as would be needed.

    function <prefix>select(<_arg=arg1\,arg2,\0,arg,\2>)

I pinged the dev list, but no one replied.
Change "such returns" to "null values"
```

    if not A and not u:
        return A, u
```

Since, apparently, A and u can be null you have to test for this before you try to take the last (non-existent) column.
done.


On Fri, Nov 16, 2012 at 2:47 PM, Ronan Lamy <notifications@github.com>wrote:

> In sympy/unify/core.py:
>
> > +
> > +class CondVariable(object):
> > +    def __init__(self, arg, valid):
> > +        self.arg = arg
> > +        self.valid = valid
> > +
> > +    def __eq__(self, other):
> > +        return type(self) == type(other) and self.arg == other.arg and self.valid == other.valid
> > +
> > +    def __hash__(self):
> > +        return hash((type(self), self.arg, self.valid))
> > +
> > +    def __str__(self):
> > +        return "CondVar(%s)" % str(self.arg)
> > +
> > +def unify(x, y, s={}, **fns):
>
> Not using a mutable default. Just use the standard pattern instead, with
> None as default, and s = s or {} (or if s is None: s = {} or whatever).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sympy/sympy/pull/1633/files#r2156783>.
>
>
It describes what the algorithm of `canonicalize` does. I should add, as a warning,  that `canonicalize_naive` is much slower.
I plan to add a method to produce the minimal BSGS so that it would be never necessary to use canonicalize_naive`.
How about:
except (CalledProcessError, WindowsError):
    print("git was not found: make sure it is in your PATH environment variable. Exiting...")
    exit(1)
missing newlines between properties is convention and should stay as it is.
Great... done with - a40ac6423871fcbe95a70503662bbea81865379a
These shouldn't be in here - thought I double checked that these weren't committed....
check style will complain /** */
Is there any specific reason why this is inline instead of in kotti.js?
I think I like this but it feels a little weird.

Do you think it's worth adding a suite here? I feel like I want some way to force the catbox tests to run so that if I expect catbox to work I get some kind of failure instead of silence. Maybe I'm overthinking though.
Can we fail with a more helpful error message?  :) Like `"No host found for key?"`
That might be better. But if gcc or clang doesn't complain when compiling other files, I don't care.
replace with:
BBFS::Params['log_write_to_console'] = true
nit: removeEventListener
I suggest:

```ruby
sign_in @user
project = Project.default_for_user!(@user)
put :new_derivation, :question_id => @published_question.to_param,
                     :project => {project.id => project}
```
...and the record.getValue would be wrapped by Option()
no. remove.
c/which can take/which may take
This looks like it's part of `document_patterns`, which says:

    # These patterns inherit (?P<document_slug>[^\/]).
    document_patterns = patterns('wiki.views',

So, I think the hardcoded `/en-US/docs/preview` URL in the JS gets routed to the general document view, which doesn't accept POSTs. That's my best guess at the 405 error.
If worse comes to worse, if the root is "MDN", we simply count that as ""
apparntly in some IE browsers, this may not render expected results as it will return http://blah.com#test and not #test. can you try testing it in versions of IE that this app is being accessed by? you could always just do $(location).split('#')[1]
See: https://github.com/phpbb/phpbb3/pull/835/files#r959805
SEARCHED_TERMS -> SEARCHED_QUERY ?
Not sure I agree with this.
Actually what I said follows the guidelines you linked to Erik. I guess it needs a bit more clarification. But as an architectural change this falls under "Is the proposed feature a "major" feature (new features/architectural changes) " which it even states can be done in 3.1.x.

The kind of BC break meant in the last point is something like a new ACP which would render all ACP modules entirely unusable. That's not quite comparable to a function no longer used in phpBB core.
I think it's actually less messy this way. If set to a variable, then the command would look like:
$list = array(
	'topic',
	'quote',
	'bookmark',
	'post',
	'approve_topic',
	'approve_post',
);
$phpbb_notifications->mark_notifications_read($list, false, $user->data['user_id'], $post_time);
New code should contain php_ext instead of phpEx where it can (i.e. in new classes, etc.)
Missing unit?
A very clear example of poor variable names. $driver should be $avatar_type or $type. $avatar should be $avatar_driver or $driver.
I didn't know this existed!  I'll change over to use environment variables, but perhaps in a different branch.
INT?
looks good - just added some coffee cleanup.

```coffeescript
# UsersController
index: ->
  users = User.find({}).populate('team').asc('username').run (error, users) ->
    throw error if error
    users

  respond_to
    json: ->
      JSON.stringify(users)
    html: ->
      'users/index', { title: 'List of Users', users: users }
  
```
This is a private one-line method, that is only called in only one place. Do we really need it?
it's inconsistent, but the hybrid archetype is for both an app and a mojit and the mojit name was hard-coded (was a requirement)
Prefer:

if (typeof callback === 'function') { callback(err) } else { throw new Error(err) };
It would be far more useful if compound except the last call just created function that you can simply reuse instead of creating for each input what I mean is:

```js
var valueChanges = (compound)
  (events, "keypress")
  (filter, isEnter)
  (filter, Boolean)
  (map, function value(event) {
    var hash = {}
    var input = event.target
    hash[input.name] = input.value
    return hash
  })

function changes(inputs) {
  return expand(inputs, valueChanges)
}
```
It fails here when the Firefox untrusted connection page shows.
I'm currently downloading the regular download version. But it will take some time, it's really big.
Cool, I will put in more styling and then commit.
Please see above ;-)
env is the old name. It still work, but is deprecated. So can you change it back to fgraph?
We've stopped using no-brace style for control structures in new code.
Don't copy-paste docstrings without correcting them.
I'd rather use `if not templates` so an empty list also forces calculation of Zabbix templates.
Can we just name this BytesIO?
Cryptic error message. How about "Couldn't find single unique constraint for %s.%s (there are %d)"
Can you please document the `losses` parameter?
Johan Tibell <notifications@github.com> writes:

>>  
>>  withJobLimit :: JobLimit -> IO a -> IO a
>>  withJobLimit (JobLimit sem) =
>> -  bracket_ (waitQSem sem) (signalQSem sem)
>> +  bracket_ takeJob putJob
>> +  where
>> +    takeJob = do n <- takeMVar sem
>
> Shouldn't we be using `modifyMVar_`?
>
I'm actually don't think we can in take as the put is
conditional. Moreover, in put I don't see how we could possibly hit an
exception. I very well might be missing something, however.
Why we need such API change, which introduces incompatibility?
Do you think that import-package without version is better than require-bundle with version? I don't think so and IMO for Ant we should leave require-bundle.
The big problem is related with the error message's information. If I remove the code above and rely on the type checking of the system. The error message will be like below.

WARNING:  PL/Python: in PL/Python function "compute_mlogregr"
DETAIL:  <class 'plpy.SPIError'>: unrecognized error in PLy_spi_execute_query
CONTEXT:  SQL statement "SELECT  ( SELECT madlib.compute_mlogregr( $1 ,  $2 ,  $3 ,  $4 ,  $5 ,  $6 ,  $7 ) )"
PL/pgSQL function "mlogregr" line 32 at assignment
ERROR:  function madlib.mlogregr_irls_step(double precision, integer, double precision[], double precision[]) does not exist
LINE 6:             madlib.mlogregr_irls_step(
                    ^
HINT:  No function matches the given name and argument types. You may need to add explicit type casts.
QUERY:  
        INSERT INTO _madlib_iterative_alg
        SELECT
            1,
            
            madlib.mlogregr_irls_step(
                (y),
                (3),
                (x)::FLOAT8[],
                (st._madlib_state)
            )
            
        FROM
            _madlib_iterative_alg AS st,
            madlibtestdata.mlogr_incorrecty_decimal_observations AS src
        WHERE
            st._madlib_iteration = 1 - 1
        
CONTEXT:  SQL statement "SELECT  ( SELECT madlib.compute_mlogregr( $1 ,  $2 ,  $3 ,  $4 ,  $5 ,  $6 ,  $7 ) )"
PL/pgSQL function "mlogregr" line 32 at assignment

If we check with the code above, the error message will be much more helpful for users. If you think the first error message is good enough, I will remove the checking logic above.
Is there a reason you perform floating point equality here, but allow for an epsilon in wsr_test_transition?
¿Que te hace dudar?
If carts is empty you'll keep loading them.  Should be an unless nil?
add curly brackets to every if statement (even one-liners) to adhere to our code conventions
I think I could modify helpers._request to split the URL returned from Config.__getitem__ and rebuild it with the oauth domain when there's an access token involved. That'd allow us to keep the access token out of Config. Does that seem worth it?
Хм.. я прочитал так (упрощённо): «... относятся к хранимым данным как к набору изменений во времени». «Набор изменений во времени» – это понятно.
Если же считать «во времени» частью оборота, получается, что каждое отдельно взятое изменение сделано во времени. Это звучит непонятно: как можно сделать изменение во времени?
На мой взгляд, отдельное изменение мгновенно, а «во времени» может быть только их последовательность, набор изменений.

Это если придерживаться исходной формулировки. При перефразировании я бы предложил сделать акцент на ключевом отличии – отслеживание изменений во всём наборе файлов против отслеживания изменений в каждом отдельном файле набора. Уточнять, что отслеживаются изменения «во времени» или «с течением времени», в данном случае вовсе не обязательно, поскольку это не является отличием, все СУВ отслеживают изменения во времени. Попутно можно отказаться от категоричности («отличие от <i>любых</i> других систем») и от повторения одной и той же мысли в двух идущих подряд предложениях.

Предлагаю такой вариант:
> Главное отличие Git от многих других СУВ (таких как Subversion и ей подобных) – это то, как Git смотрит на данные. Большинство других систем (CVS, Subversion, Perforce, Bazaar и т.д.) относятся к данным как к отдельным файлам и хранят историю как список изменений каждого файла, как показано на рисунке 1-4.
What does the last parameter represent? `'cb'` isn't a very descriptive error code. We should be using integer constants for the error codes in RainError instances.
We don't want a picker, we want a combo box.
Don't need the else here
Let's tighten the text.

"Each test is run in a new thread.  If the specified timeout elapses before the test completes, its execution is interrupted via Thread#interrupt.  This happens in [etc]"
I guess I don't know what the wagon API is.  A comment in the code explaining it would be useful.
Description is wrong -- there are no quotes in this testcase
Other places in this function return a boolean value, so I think this needs to ``return false;``
Typo: "an" should be "a"
In addMeasurement() line 111.
Fixes pushed

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com] 
Sent: Friday, July 20, 2012 5:25 PM
To: Ty Voliter
Subject: Re: [brackets] Correctly handle focus changes between working set and file tree when activating document from find in filesfixes #1280 (#1290)

> @@ -355,6 +361,8 @@ define(function (require, exports, module) {
>              _handleDocumentSelectionChange();
>              _fireSelectionChanged();
>          });
> +
> +        $(FileViewController).on("fileViewFocusChange", _updateListSelection);

Another option is to move the call to _fireSelectionChanged() into the _handleDocumentSelectionChange() function to make the event binding cleaner,

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1290/files#r1210191
Using the universal selector as a descendent selector selects *every* element in the DOM sub-tree. Is that what you want? If you only meant to apply it to immediate children then use the child combinator:

#status-indent > *
ah thanks for the hint,
 so bug was in commands plugin, it wasn't finding ceEditor and editor commands were not working from commandline
That makes sense...I'll add that and commit...
You could also write a dynamic web server in assembly, but you shouldn't. When the framework offers you a way to reduce the complexity (number of unique paths in your code), you ought to want to use it.
Update the test name, since there's only one limit.
Ehm. Remove this. :-)
No, this is not good.
Don't comment out. Remove or leave. We have repository to take care of the rest.
These parts have to be loaded separately since they don't actually exist in the main layout, they are inserted as needed
Alright, it just seems to me like it's gonna be a pain to dig through this to find it if you ever have to change it
left = math.max( 0, left );
do we need to rely on www. being part of a url? Seems like a good source of errors for users. I'd just split on flickr.com instead
Non-unique test id, change it e.g. to ""arabiccidtruetype-text"
paintImageMaskXObject would be another case
I am VERY afraid of writing the architecture you need for your own use case. I am also very afraid of handing this off to incoming developers who do not have our tribal knowledge of Django. This can be an enormous time sink.

Therefore, I submit that we should have a warning of some sort here, suggesting that compositing something out of mixins is only for developers with serious Python experience.
strip_tags killt alle tag elemente, also auch < > etc. bessere wäre natürlich ne preg_replace
Very minor style point: it would be nice if these extra lines of arguments to ```attr_accessible``` were indented to make it obvious they're a continuation of the statement above and not a new statement.
Ok ! :)
https://github.com/wmoss/StatsWeb/pull/1/files#r1126153

Good points in getCounter

On Mon, Jul 9, 2012 at 2:20 PM, Will Moss <
reply@reply.github.com
> wrote:

> > +                                 "bump.matchd2.gc.bytes.copied" .=
> bytesCopied gcStats,
> > +                                 "bump.matchd2.gc.bytes.used.current"
> .= currentBytesUsed gcStats,
> > +                                 "bump.matchd2.gc.bytes.slop.current"
> .= currentBytesSlop gcStats,
> > +                                 "bump.matchd2.gc.bytes.slop.max" .=
> maxBytesSlop gcStats,
> > +
> "bump.matchd2.gc.peak.megabytes.allocated" .= peakMegabytesAllocated
> gcStats,
> > +                                 "bump.matchd2.gc.seconds.mutator.cpu"
> .= mutatorCpuSeconds gcStats,
> > +                                 "bump.matchd2.gc.seconds.mutator.wall"
> .= mutatorWallSeconds gcStats,
> > +                                 "bump.matchd2.gc.seconds.gc.cpu" .=
> gcCpuSeconds gcStats,
> > +                                 "bump.matchd2.gc.seconds.gc.wall" .=
> gcWallSeconds gcStats,
> > +                                 "bump.matchd2.gc.seconds.cpu" .=
> cpuSeconds gcStats,
> > +                                 "bump.matchd2.gc.seconds.wall" .=
> wallSeconds gcStats,
> > +                                 "bump.matchd2.gc.bytes.copied.par.avg"
> .= parAvgBytesCopied gcStats,
> > +                                 "bump.matchd2.gc.bytes.copied.par.max"
> .= parMaxBytesCopied gcStats]
> > +
> > +            stats <- liftIO $ flattenStats tvstats
> > +            let counters = foldl (\acc (k, v) -> (T.append
> "bump.matchd2.count." k .= v):acc) [] stats
>
> Why is this hard-coded in here?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wmoss/StatsWeb/pull/1/files#r1126247
>
This line should actually be `self.owner_name.downcase!`. I'll fix it after this is pulled in.
@dwins this is from the yet-to-be-removed XML upload stuff.  Having said this, the reason for this is to allow layers which have been uploaded with an XML upload to be provided with a LayerMetadataUploadForm, which _only_ provides the metadata_upload form input, in the case of updating the layer description (_not_uploading new data too).
Slicing a pointer of type `void*` will always give you a slice of type `void[]`
Yes, this was intentional. The method was used only once and I removed that.
I would probably write this line as:

```ruby
products_ids = params[:products].empty? ? [] : Product.readable(current_organization).
  where(:id => params[:products]).pluck(:id)
```
ONE MORE - Do not change this line
preserve
%dir %{_sysconfdir}/%{base_name}
oops, keep this private, my mistake
I think this should throw instead of raising on error. It's kinda like parameter validation.
nit: osk -> isnot
627ff96
Good call.  These comments also apply to convolve.py, since I copied from there.
I wonder if there are any interesting races with core stats.  Until the core stats are registered on https://github.com/basho/riak_core/pull/148/files#L2R94 they can't be reported, however gossip is up and running.

I think stats should be started pretty early in the initialization sequence.   

You could add an alternate version of start_link that takes a module name and does something like

```
start_link(App, Mod) ->
  case start_link() of
    {ok, Pid} = Res->
      ok = start_stats(App, Mod),
      Res;
    ER ->
      ER
  end.
```

Then remove the register call at https://github.com/basho/riak_core/pull/148/files#L2R94 and change the riak_core_sup call to pass arguments
```
-define(CHILD(I, Type, Args, Timeout), {I, {I, start_link, Args}, permanent, Timeout, Type, [I]}).

?CHILD(riak_core_metric_sup, supervisor, [riak_core, riak_core_stat]).
```

There may be better ways to structure it, but I think that would resolve the race.
ETOOMUCHWHITESPACE
So this is for people who don't want to wait 5 hours, and instead they can quit bitcoin-qt and run it again with this flag? First question that comes to my mind is: how frequent to resend txs is deemed too frequent?
thanks, ok
and no, it does not only assign values. It does all the logic of the parser
`skillpoints`
Yes, I find "rev" would be more logical in the child configuration, too. But there are two problems with that:

- the same child entity might be referenced in multiple collections, e.g. you could have sioc:person as collection child of sioc:group and of someNamespace:contactList. So all of the possible parents will have to agree on the same rev value

- vice versa, collections can have multiple child types, but they can have only one rev value (at least AFAIK), so all child configurations in one collection need to agree on the same rev value (and since they can be part of multiple collections, the other collections' parents have to agree, too)

Some of that is of course unavoidable, but maybe the safest approach would be to give types a possibleParents array, which holds the parent's type name and the rev value used. This could be populated by the drivers during type creation, sort of how the old ArrayLoader reference resolution worked.
see my other comment about the symfony dependency: It seems gratuitious and would pull in a lot of code into non-symfony projects just for some special runtime exception class. So this should go
The original comment regarding `file` would be wrong for Python 3, but it's in a docstring. I just sent a diff to the upstream owner, so I'll call that good and I'll let my current changes from `file` to `open` stand.
The default destination should be in a profile.  If you want to add an option to do system-wide install, that's fine, but it should not be default.
Just to say that I moved it to external and `git add` it (so it's duplicated and I should remove this one).
I should have make a `git mv` which would have told git not to track this particular file.
The url of the file gets inserted as text. 

The `e.mimeData().text()` is `file:///home/punchagan/work/ipython/IPython/frontend/qt/console/console_widget.py ` and `e.mimeData.urls()`is `[PySide.QtCore.QUrl('file:///home/punchagan/work/ipython/IPython/frontend/qt/console/console_widget.py')]`.  

The same thing happens when running under PyQt too.
I think if you switch to the following, it would be easier to understand what's going on..

Set<String> ids = resolveToBackendIds.apply(filter);

exectionsOnBackend = backingComputeService.runScriptOnNodesMatching(withIds(ids));

return Maps2.transformKeys(exectionsOnBackend, backendToFrontend);

where there's a field that extends Function<NodeMetadata, NodeMetadata> backendToFrontend;
skipexception
This hash code computation is dependent on the order of the edge set.  Shouldn't it be order-independent?
+1 : too many levels of imbrication : perhaps you can split this into several methods to ease test/debug
I'll have to try merging those two `get` routes again; I tried before when we were using `sinatra-respond_to` and it wasn't working.

I omitted the channel in the route so that a user would only need to know the name of the activity and not the channel to find it. I could go either way with requiring it.
Was not sure if I could simple 'inherit' that one
It is how the metric is defined. A user with 10+ replies in a month is a contributor.
Don't you want to encode ``+`` as well here?
Can we use the `isodate` python module for rendering the datetime instance?
For a value type, `eventData == null` will always be false, but it doesn't matter?
Damn, thought I got all that resolved - I'll get it resolved from home tonight and get you the screenshot over to you as well.
On Tue, Nov 06, 2012 at 03:14:16PM -0800, Simon wrote:
> >  
> >  app = Flask(__name__)
> >  app.config.from_object(__name__)
> >  app.config.from_envvar('C2CSTATS_SETTINGS', silent=True)
> >  
> > +Environment.directory = os.path.join(CACHE_DIR, 'assets')
> 
> ça ne fonctionne pas: dans la version actuelle de webassets il faut que
> le répertoire avec les fichiers générés soit dans le même répertoire que
> les sources (le répertoire `c2cstats/static/`)

Étonnant, ça fonctionne bien chez moi... Je me suis basé sur cette doc:
http://elsdoerfer.name/docs/webassets/environment.html#configuration

NB: le dossier "os.path.join(CACHE_DIR, 'assets')" doit être crée à la
main. C'est qqch que je fais faire à puppet.

C'est pour contourner des problèmes de permission sur lesquels je suis
tombé en voulant faire tourner la webapp sous un UID différent de celui
utilisé pour déployer le code (de façon générale, une bonne pratique de ne
pas permettre à une application d'écrire dans dans les fichiers qu'elle
exécute).
The latter two are deserialization types which get wrapped in exceptions (as `Object`s). I didn't know what GSON would back an `Object` with if that was specified. Maybe in this case the exception gets the raw `byte[]` and the instance of the `Converter`. Then you call a method `getBodyAs(Type type)` which does the deserialization upon call and it's the responsibility of the caller to declare the type. The only thing I don't like about that is that it further deviates the synchronous behavior from the asynchronous behavior and requires all exception blocks by the caller to know what the type should be.
Should include Guice's "Copyright 20xx Google Inc." header above the package name? I'd hate for Square's credit to get lost in a note.
btw, it looks weird to me that this part does not require changing any test
if I'm not wrong it was not available in 2.0
you could use `array_merge` here. `extraPatterns` could also be `patterns`. Otherwise this PR looks good to me.
I know, but where is that necessary? Which other class calls setParent on FormBuilder?
No, but I figured that since this is still in here, I  might as well update it.  Maybe it was kept around incase we ever need to fall back to it, or something similar?
Moved down to translated section.
sry i totally forgot
Good catch. I can ditch that function for now, it's not used anymore.

On Wednesday, September 19, 2012, Matt Perpick wrote:

> In dogstream/haproxy.py:
>
> > +        except:
> > +            # if we fail, log and don't tag anything
> > +            self._logger.warn("Cannot parse url patterns to tag URLs. Won't tag any URL.", exc_info = True)
> > +            self._tags = {}
> > +
> > +    @staticmethod
> > +    def parse_timestamp(timestamp):
> > +        return time.mktime(datetime.strptime(timestamp, '%d/%b/%Y:%H:%M:%S.%f').timetuple())
> > +
> > +    @staticmethod
> > +    def stem_url(url):
> > +        """Remove unneeded variability in URLs"""
> > +        try:
> > +            # First ditch parameters after ?
> > +            # Then remove all digits
> > +            return url.split("?")[0].translate(None, "0123456789")
>
> Does this work on older Pythons? Seems the None arg was added in 2.6.
>
> http://docs.python.org/library/stdtypes.html#str.translate
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/DataDog/dd-agent/pull/193/files#r1640318>.
>
>


-- 
*Alexis Lê-Quôc *+1-917-512-6452

*Try Datadog for free (http://goo.gl/swO1h) <http://goo.gl/swO1h> no cc
req'd*
And follow @datadoghq <https://twitter.com/#!/datadoghq> on twitter
unncessary self
Would it be better to test instead for ```_MSC_VER```? The test is for the compiler, not the platform.
there is a github repo for oiiio test images https://github.com/OpenImageIO/oiio-images - I think we abandoned svn version?
please drop this user_agent
You are right,I will make this function in next version of the patch and other patches I planned to do.
we might do this per request or in the upload method where we change it too. if we do it here, it may prevent future misuse in every test.
Looks like the same earlier issue. Not sure what's going on here.
Yep, I guess you're right and it makes no sense to keep that comment. It only disturbs there.