labofsahil/github-event-dataset-2012 huggingface dataset:
Is Javascript no longer the default or are you just being explicit? (The latter is fine, just wondering.)
Good thought. This is a place where my make-it-work coding for my app doesn't translate as well to everyone else. I'll make those attributes on the Flame.Panel with these numbers as defaults, so they can be tweaked by the user if needed.
IIRC this query will return the new UIDs, but also the most recent one. This isn't a problem per se - it just means that we'll skip the first UID returned since it's already been imported - but I wonder if you can confirm my memory?
Yes, I have that improved in my upcoming branch.
Is "http" more reasonable, since it actually exists in all the legacy configs that might have this problem?
Fixing all of them using rendezvous on a case by case basis is not a trivial task. How would we divide up the work.
We also have lots of waits in the unit tests and those never/rarely fail so such a JIRA should focus on the QA suite only.
@jtauber  `i is None` won't work, because in the mentioned case `i` is actually a string.
Same idea in JS edit mode. You can hide the button or only remove the event binding for this week.  If you already remove the button in HTML, there is no need to comment out the code in JS, right?
This is related with the first flaw and I hope to solve it soon.
I guess that return false is for preventing the default user action, but ... can we added within the pickImage  function? Just curious, if there is a specific need of that return there.
Not same here. replace `alarm.enable == true` with simply `alarm.enable`.
Always heard that the `defer` should not be seen as a guarantee that the dom will be ready at the moment of execution...

The renaming is indeed much needed, on it right now.
I have just  added the comment
Hi Christoph,

I think the following arguments here should be **display**Width & **display**Height to match the parameter naming of emScriptenCreateProximityInfo().
 > keyboardWidth,  keybaordHeight

Thanks.
Not the case because the phone type is a mandatory field. In fact, what could be deleted is the "if" (checking if contactPhoneType exists).
If the CSS file is generated from a tool like SASS, LESS (which is good), also commit that file if you intent to keep it for future development.

If the SASS/LESS file is intent for one time speedy development only, correct the CSS file indent to it's original form.

We have to avoid the case where CSS file gets fixed but the fix gets overwritten by SASS/LESS, or the time wasted copy/paste rule in CSS back to SASS/LESS.
I can't see anywhere that this file is used.  Remove it?
If this is constant, make it all capicalized, as `NO_SERVICE_ERRORS`.
If it is not, name it as `noServiceErrors`.
Can we have all lowercase, hyphen (or underscore) separated class names and ids? Just for consistency.
The script is edited, now it can handle spaces. So if you want to try what it does in Russian, it's possible now.
Well two things: if self.benchmark.name is never a string, this will break but using string formatting will convert it (even if it looks gross), but mostly just because I like the way string formatting looks :-). But feel free to just leave as is.
Ah, thanks.  I will file a ticket to audit the codebase for any other occurrences of this, since it could turn into a very nasty bug somewhere along the line.
Thoughts on this?  That is why I made the function return a bool so that we can return False if we don't like the idea of overriding the builtins.
Sketchy magic string is sketchy.
`` が原文と違う
I would prefer if request to the server just happen in the models. So the track could have a `loadHighscores` method and handle the conversation with the server. I think we shouldn´t mess up controllers with such stuff.
Done. I was using the wrong `SortedSet` import earlier, so it actually failed without the `toSet`.
This block would only be used to compute validated consistencies.
of the file.
Don't throw a generic Exception.
Also, is there any reason these need to be globals, instead of being contained within the InfrastructureManagerService?
This doesn't edit the string command, just the copy of the current word you got from the iterator
Add a comment explaining this is a phantom script that opens a page and logs the time it took to load to stdout.
Similarly, this should probably be a warning.
This could be biting you as well, when super is called is when networking parameters are parsed into the vm.virtnet instance.  It's the only time this happens outside of create().  However, if the vm already has a non-unique instance property, it will cause a cache collision in /tmp/address_cache.  vm.create() and vm.clone() should properly handle this.  But if a VM is duplicated via other means, there could be trouble.
No internal network details in public source pls.
Ah, I bet that has to do with source being defined at the class level as well as the instance level.  If you re-add the `del`, and remove `source = None` from the top of the class, things should work.
You are welcome to do that if you care about it. I've just removed the common trailing part.
So the makefile at the moment generates a version for node and a version for the browser and the browser version lacks alot of features and has some bugs - why would you want to run the browser.js file on the server?
On the server, 'window' does not exist. So attempting to use the variable straight will throw an error. 'typeof' allows us to check if it exists without throwing an error.
This isn't a great idea, if you throw a very specific exception and catch that ok, but as such it will basically prevent us from seeing the backtrace when a real exception occurs.
Should be `} else {`
Missing brackets
Ah I get what you mean. It needs to give out false if photos exist :)

Would something like
````
! post.photos.any?
````
do the trick? :P
No need for 8 empty lines :)
Well, jQuery does fix some inconsistencies in event bindings, and I find it very surprising that it wouldn't fix something as obvious as listening for changes to checkboxes and radio buttons. Now that I think about it, have you tried listening to the `click` event, as opposed to `change`? IIRC that might work better in IE.
ok, plz fix
I might change this one in advance of changes made in this change. What happens if I do?
prefer 'do' instead of '{' for multiline blocks:

```
aggregates.each do |namespace, data|
...
end
```
No. PageSelector is a view. This is the attribute value that PageSelector looks at.
Quality Value detection
don't find_by_id
remove to_i
remove new line
We have decided to no longer use short function syntax as it's confusing for newcomers, could you please full function syntax.
I'm not sure it's a good idea, mainly because it can get confusing pretty quickly. Mainly because this config almost never will be enough, you will still have to define additional `paths`, `console` here is too basic and these `modules`  is just for illustration purposes. Only thing that may make sense is to merge default `paths` with given `paths` but again if you don't want to expose toolkit modules for example it will no longer be easy. So considering all of that I thought it would make sense to keep it simple and don't imply default, just recommend them.
I would rather say:
`Due to the differences in how images could be stored in the clipboard, ...`
`be` seems to be useless here: `The clipboard could already provide`.
There is two spaces after `also`.
This has different behavior than original code. In original code if you resolve promise `a` with promise `b` and then attempted to resolve it with a value `5` a will still resolve with `b` no matter when `b` is resolved. Here it will resolve to `5` if `b` is not resolved already.
I'd say **add-on** (instead of **module**) that created them is unloaded.
(nitpick warning)  unfortunate that `iss`, `iat`, which are arguably illegible protocol details must be known by the user of the api.
I would change the id of the tree to something more descriptive and which is loosely bound to the type of object, like 'variables'. Also I wouldn't set a height but would it auto-adjust by the window size. It should be stored inside of localstore.rdf so it keeps the latest width/height across sessions.
So if we can get an array of CPUs from the WMI query, and we only care about the first one because they're symmetric, why are we doing `.each` instead of `.first`? Do we ever expect that we won't get a CPU model returned?
I don't know; I didn't touch that line... and if I'm reading this correctly my change shouldn't affect the existing behavior of that line, should it?
OK, thanks for clarifying that.
This setting is still mentioned in the documentation for ca_ttl and in a comment in ssl/certificate_factory.rb
still I don't think logging this way is suitable for web apps - logger.warn( "Security configuration has validation warnings" ); by itself has very little value.
`lastpow` assigned but never used.
`fetchend` assigned but never used.
`fetchstart` assigned but never used.
Ah, yeah, that DOES look nicer..:-)
That would leave the file open in case of an error, no? 

http://effbot.org/zone/python-with-statement.htm
This doesn't look like the correct fix at all. How would this not break _all_ attempts to route to a library?
I guess i could change that. But I was only adding the if statement.
They got added with a regular migration so I'm agnostic about where it lives. I think in a regular migration is fine.

I'm making the slug changes now.
I'd go with unicorn. It's a shame "rails server" doesn't pick up unicorn automatically...
This can be refactored into a [`before_filter`](http://guides.rubyonrails.org/action_controller_overview.html#filters) along with `show`.  If you are using cancan, the `load_and_authorize_resource` should do this automatically, I think (I don't use that library).
Well, nevermind. We need to stay consistent with the rest of the variables in this file, so that's okay.
As it uses transactions.
Oops. The link text will all have to change too. :-(
Remember to rename this to `q`.
Yeah, just spoke to @bobsilverberg about that, and he prefers that style, too -- in the method declarations and filenames, we should definitely keep the casing upper, since it's an acronym.
blank line required here.
We are asserting equal below, without the trailing slash the test will fail
We shouldn't include HTML in localized strings if we can possibly avoid it, and that's easy here:

```jinja
<h1 class="span12">{{ _('Group: {name}')|f(name=group.name) }}</h1>
```

This also reduces the L10n load because it reuses the same English string from above.
They should, but I wouldn't block this PR on that, since these are just copied over. I'll file a code-quality bug.
yeap, we default to just a number in the code so it looks like it's being done for us https://github.com/dseif/popcorn-js/blob/c657d12cfb0c01412f63675f3a5bb48b95c0b667/plugins/twitter/popcorn.twitter.js#L103
более подходящие заголовки будут отчеркнутые тильдами
~~~~~~~~~
It is called in Controller.show()

On Mar 27, 2012, at 10:33 AM, Tim Simpson wrote:

>> @@ -101,3 +105,15 @@ def test_root_restricted(self):
>> 
>>     def test_instances_index_restricted(self):
>>         self._test_path_restricted('instances')
>> +
>> +    def test_get_guest_info_success(self):
>> +        controller = reddwarf.api.management.Controller()
>> +        status = mox.MockAnything()
>> +        status.is_sql_running().AndReturn(True)
>> +        self.mox.StubOutWithMock(controller.guest_api, 'list_databases')
>> +        controller.guest_api.list_databases(FAKE_CONTEXT,
>> +                                            FAKE_INSTANCE['id']).AndReturn([])
>> +        self.mox.StubOutWithMock(controller.guest_api, 'list_users')
>> +        controller.guest_api.list_users(FAKE_CONTEXT,
>> +                                        FAKE_INSTANCE['id']).AndReturn([])
> 
> I might be missing something but where is Controller._get_guest_info called?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rackspace/reddwarf/pull/424/files#r609566
I actually use them but it's wrapped in the function
https://github.com/theforeman/foreman/pull/259/files#L0R52

Is it an issue? Would you prefer to see it unwrapped inplace?
on a side note, I'm not sure on which puppet version they stopped adding that to their report, so it might be an old version and we could not support that client version if requied.

another option, is to create a new class abstraction instead of reading the puppet code, ideally at one time I would like not to relay on puppet classes alltoghter.
You also don't need to call `File.basename` on the path to check what it ends with.
A nit, but this should be 2.1.9 since you're using ZU shortcut. Technically, it doesn't matter at this point, but might as well.
Basically as I dug around I with the ingest stuff I found that naming wasn't consistent and things could be more clearly laid out. I set to clean up the bits I came across.
Also, I'm assuming the data-ensure gets used even when FACTOR is appended to these vars?
Yes, good idea.  I was just being lazy so that I didn't have to update the images.  I'll do that.
This method takes a comma separated list of features. Ie it should be

includeFeatures("opennaas-router", "nexus-tests-helper")

Or rather, it should be

includeFeatures("opennaas-router"),
includeTestHelper()

This is because there is no guarantee that we will keep the test helper in a feature definition (there is no reason to expose it to our users). Calling the includeTestHelper() method means we can change this without having to update all the tests.
I thought I remembered that more of the existing code in this area used camelCase for method names, and I figured I should probably maintain that style instead.  Happy to adhere to PEP8!
OK, will change this. Thanks
я бы тут typedef обошелся 
тут теперь можно новейшие шаблонные typedefы использовать
Don't know why I made these static? Ignore
Thanks. That isn't strictly necessary but it's more consistent.
Yeah that'd be handy.
this is one case where i'd accept that stub behaviour is acceptable fwiw, since exceptional conditions like running out of disk aren't really possible to test in the wild

but, I'd do it by having a secret backdoor to set this property on the manager
[...].join() pattern
They don't contain them in the repo, but you also wouldn't want someone who is installing composer within the repository to accidentally push it up either, this ensures that it won't happen.
As mentioned above, check for `None` here. `0` is a valid value.
same, just moved it from the other namespace but i will change it.
There is a  Cassandra.getPagingParameters utility method now, which does this for you
Can we document where these codes come from? I can't find where they are being set.
As of the app-lifecycle PR, this will have moved to the oae-authentication's init.js module.
should be `userId` to be consistent with the rest of the tests.
Until we have the per-file encoding, is the current implementation better (more correct?) than just retrieving the workspace encoding? i.e., ``plugin.workspaceRoot.getDefaultCharset``.
should we say ... "this will be used /instead/ of the symfony core compatible route name and can contain any characters"?
Yeah think this got muddled up in the last round of updates, not sure why I moved it. But certainly wants to be post check for next version.
please add a qqq code to go with this
I don't think we have to deprecate this method. It can be useful for IP based providers.
There is no equivalent for local. The point is that you can put any timezone you want. If there is a need for a local timezone, it could be done, but is it necessary?
Чтобы не превращать гитхаб в чат, скажу: спасибо Вам за конструктивную критику, я исправил то, что Вы заметили. за что Вам огромное спасибо!
Да, все верно, но так можно любые сравнивать, а не только себя с кем-то
То же самое, что я писал выше.
Зачем? Эта переменная у вас используется только для посчёта не равных элементов, так зачем она должна присутствовать в классе?
Да все верно, добавил проверку.
It seems more natural to have _get_clusters_st carrying the logic if max_step == 1 etc.

also are these lines covered by a test as I don't see any test modified.
I'm testing this with input right now, so this might change. But so far it looks good.
Yep, when I changed the arg name, I didn't update it in the docstring. Fixed locally.
I see, arguments serializes to an associative array in JSON, so it doesn't have a length property after you reparse it (see http://stackoverflow.com/questions/5223/length-of-javascript-associative-array). An associative array is basically the same thing as an object.

The comment should say:
// arguments serializes to an associative array in JSON, so we convert to a normal array first.
I think it's an excellent version! I've updated it. Thanks! :)
This should be `'values' === $mergedOptions['some_default']`.
@jcredding  - uh, no real great reason.  Partly organization - those should go together, partly don't require until you need it.
Defintely but this freedom on the other hand gives you much more ways to express yourself.
Divné,  že komentuješ diff zahrnujici oba dva commity. Druhy commit prave opravuje nezavislost na velikosti pismen. velke tag je tam proto. ze jsem vybral data z tabulky pomociu ->select('Tag.id')
Что `tr` отдельно вынес — малаца, хорошо зделол.
s/group all/a group then all/

И точку на конце не забудь.
Good call to switch to RequestAttributeCacheKeyGeneratorImpl.
please use the ``rowCount`` method
The JOptionPane is not ever displayed.  I copied this code from somewhere else in Clooj.  It doesn't work there either I believe. I haven't taken the time yet to figure out why it is not ever rendering...
can you change that back?
Wait - what is the starting value for user created lists?
One thing I forgot - the symmetric operation to this get is the MapsforgeMapController.setZoom(), which you would need to address at the same time.
Hey!

Can the indexFile be an option?

```options["indexFile"] = "index.html"```
Will this be safe for multiple users?
Mircea, I'll likely close this pull request. I have no idea as of why his value objects inserted into cache where turned into MarshalledValue(s). I need to talk to Sandro before proceeding
Is it worth validating numVirtualNodes if we ignore it anyway?
I looked at .. vs ... The 2 dots is an arbitrary diff, where as the 3 dot version compares the 2 branches from a common point.  Given we are diffing branches I think ... makes more sense.  The git diff command being executed uses the 3 dot syntax - see https://github.com/klaussilveira/gitlist/pull/111/files#L1R408  Github uses ... - see https://github.com/skwashd/gitlist/compare/master...branch-diff for an example

From the man page:
>       git diff [--options] <commit> <commit> [--] [<path>...]
>           This is to view the changes between two arbitrary <commit>.
>
>       git diff [--options] <commit>..<commit> [--] [<path>...]
>           This is synonymous to the previous form. If <commit> on one side is
>           omitted, it will have the same effect as using HEAD instead.
>
>       git diff [--options] <commit>...<commit> [--] [<path>...]
>           This form is to view the changes on the branch containing and up to
>           the second <commit>, starting at a common ancestor of both
>           <commit>. "git diff A...B" is equivalent to "git diff
>           $(git-merge-base A B) B". You can omit any one of <commit>, which
>           has the same effect as using HEAD instead.
(git-diff(1))[http://www.kernel.org/pub/software/scm/git/docs/git-diff.html]
`inline` is almost superstitious. It does basically jack on modern compilers, and doesn't really matter for our unit tests anyways.
I know it's only aesthetic, but it wouldn't hurt to have all the data line up nicely.
Again, does it need to be this restrictive?
These conditions check for `nodata` values in the incoming `forma-val` and `neighbor-val`. If neither value is trustworthy (i.e. has `nodata` values), return an empty `neighbor-val` (all zeros). If `neighbor-val` is bad but `forma-val` is good, convert the latter into a `neighbor-val` and return it. If `forma-val` is bad but `neighbor-val` is good, return the `neighbor-val`.

Otherwise, combine the values as before using the weighted mean (see below)
Can we combine the two keydown handlers here and below?
@bp323 I left it out in the beginning as well but it doesn't seem to work in FF. I'm guessing YQL doesn't send the correct content type back.
Do you now.
Oops yeah, this is clearly wrong. Not sure how it compiled to begin with :) Will need to rethink this.
IIRC It is different in libocas and shogun so every data_y[*] should come with -1
Not IE 8 safe :(
``redirectUrl`` になにを入力すればよいか記載しておいたほうがよいのでは。
I think this is okay, because we are holding `lsm_tree->lock` for the whole time until the chunk becomes visible, and reading code, such as `__clsm_open_cursors`, grabs `lsm_tree->lock` before looking at the chunks.
다음과 같이 하시는 것이 좋습니다.
```
private HashMap<String, ListDataProvider<ContactInfo>> contactInfoDataProviderMap;
```
Can't we just use an array to determine the permissions, iterate through that and only have a single location for assignment?
Unfortuntately, this dos not scale. If there are 100000 categorized products, Thema query exceeds Thema MySQL limits for sure. Don habe to fetch and process the entries in chunks for both, categories and products.
same hurr
The cleaner way would be to keep the above and here do 
```js
if (isBlackberry)
{
        delete optionsDialogOpts.destructive;
        delete optionsDialogOpts.cancel;
}
```
so we can simply delete these lines once the functionality becomes available for BB
createModels from Nodes fehlt.
I've made a pull request on Twig CoreExtension to fix the DateTimeZone support : https://github.com/fabpot/Twig/pull/736
cs, в javascript "{" находится на одной строчке с названием метода
Well, we should catch it, and at very least log some sort of an error -- even if its to STDOUT. Obviously that's not a solution, but hiding the problem may land us in a much worse case with nearly impossible to track down behavior.
Does this work on Postgres?
Gotcha! Yup, that's not good. Will try to get those lines out of the commit a little later today, Andrew.
No, that shouldn't even be in there actually :$
bah. new pull request got created, as this one was closed
https://github.com/matschaffer/knife-solo/pull/71

@matschaffer do you know how i could have edited this PR, so that github does not create a "new" PR
Estamos todos queimados. :P
Yeah, I've tested it without `html_safe` and it was escaped. So I think we need it
`ForeignKey` is to link to relational-based objects.
Again, I was thinking the same thing, really :). But I am almost done with all the bling bling. I will use hover instead of accordion and maybe later someone should change it.
Why are you generating list here? It could just be an iterator.
`h2`?
(I prefer verbose names.)
I am not sure you need to define this?
Code of this function could be moved there, yes.
What is this? Why?
Could just have `messages` (default) here, no?
No need for empty line here.
I'm slightly concerned about the change in parameter order here since its a change in API.  However I do acknowledge that this is more consistent.

If we are going to include this then we should be sure to ultimately release note it, which leads me to think that we need a specific Jira on relating to the API change.
Your version will give a strict doubling; this version is a little less aggressive.
Does this actually work? You usually can't assert that two numpy arrays are equal, you need to use (x == y).all().
As we discussed via skype, a bit more documentation on the specifics of how to run this recipe (which attributes to put in which file, command line arguments for chef-solo) would be very useful.
What you're testing here it's unclear. Applying two different approaches generates two dictionaries which have the same number of measures so what? Clearly none of them reduces the number of measures.
If only part of a java array is valid (as in ByteWritable used in ProtobufDeseriazer.java), we don't need to make another copy just to create smaller byte array.
Space around the "+=".
The consequence of the table design is that prototypes don't look consistent any more with all other views of this model. Is there not a way to address the issue you are solving with this in a different way?
Style here is `ngx_event_t* wev`.  Also fix `ngx_resolver_ctx_t *ctx`, `ngx_event_t *rev`, and `ngx_event_t *tev`.
if (pool_) {
      ngx_destroy_pool(pool_);
    }
I would rename this to UseTextureCompression because a renderer might use whatever compressed format it prefers and not just DXT.
defensive programming, no big deal
я бы считал не `time_started` а `deadline`, так по-моему удобнее и проще все становится
can we open a story or file a task for this, and remove this TODO?
I made this change, but Barney, feel free to edit it.
(This could be most transparently fixed by making separately variable names for lens and source positions, to be used throughout this entire file.)
A few points here:
- I think it would be helpful to write `image = obj.draw(...)` to indicate that the drawn image is returned.  It might be worth adopting this syntax throughout, but at least here I think it would help.
- There are a lot of (optional) arguments to draw.  We probably don't need to mention all of them here, but it's probably worth mentioning a few.  In particular, `image` should definitely be listed (as you did for drawShoot).  But mention for both that the image will be constructed automatically if you don't provide one.  (This feature is new for drawShoot of course.)
- You refer to `dx` as the "sample scale".  I think "pixel scale" or "pixel size" would be clearer.
- Another argument that might be worth mentioning here, rather than just letting users check the doxygen docs is `add_to_image`.  And possibly `normalization` although that's maybe more of a niche market.
Asonwong - here you define 0 decimal places (P0) notive previously we were using (N2).
Q? F? what the heck were these?  Good to get them out of here if they're not needed, thanks.

- Sef
oooh fancy github stuff if you enter ":"
:+1: :-1: :100: :109: :1234:
Agree. Since dashboard only applies to user, admin or donor, it can be a subclass of user.
do we really want to continue stripping off any number of "jclouds:" prefixes? Perhaps log deprecated about this, so we can get to it being a more specific format for the spec?
이건 안드로이드에서 "피플" 앱으로 번역했습니다. 그렇게 바꾸는 게 좋아 보입니다.
On Tue, 25 Sep 2012, Hannes Magnusson wrote:

> > -    }
> > -    else {
> > -      mongo_cursor_throw(0, 14 TSRMLS_CC, Z_STRVAL_P(errmsg));
> > -    }
> > +	if (!cursor->connection && error_message) {
> > +		efree(buf.start);
> > +		zend_throw_exception(mongo_ce_ConnectionException, error_message, 71 TSRMLS_CC);
> > +		free(error_message);
> > +		return FAILURE;
> > +	}
> > +
> > +	/* Sets the wire protocol flag to allow reading from a secondary. The read
> > +	 * preference spec states: "slaveOk remains as a bit in the wire protocol
> > +	 * and drivers will set this bit to 1 for all reads except with PRIMARY
> > +	 * read preference." */
> > +	cursor->opts = link->servers->read_pref.type != MONGO_RP_PRIMARY ? CURSOR_FLAG_SLAVE_OKAY : 0;
> 
> This was fine when it was in the ctor, but now you are completely overriding all the options set on the cursor...

Could catch - do we have a test for this btw?

cheers,
Derick

-- 
{
  website: [ "http://mongodb.org", "http://derickrethans.nl" ],
  twitter: [ "@derickr", "@mongodb" ]
}
das war nichts! utf8 ist gesetz!
Does this work in Python 2.6.1?

```

Python 2.6.1 (r261:67515, Aug  2 2010, 20:10:18) 
[GCC 4.2.1 (Apple Inc. build 5646)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from collections import OrderedDict
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name OrderedDict
```
The reason for using ``get_class`` instead of ``get_model`` is that the ``receiver.py`` module is imported in ``models.py`` which means that the models are not yet available to be loaded using ``get_model``. At least that's the experience I had when implementing it. Is there a way to make ``get_model`` work in this situation? Or should I stick with ``get_class`` then?
Lets cache the scaled pixmap. Smooth scaling is expensive, and since the padding is constant, the size is not changing
You've designed this as sort of a Singleton class, using only class methods, but it might be easier on the user of the class if it were designed as an object that they can create an instance of, like this:

```ruby
walkabout = Walkabout.new
walkscore = walkabout.walkscore(some_address)
if walkscore.status == 'success'
  puts "Score: #{walkscore.walkscore} - #{walkscore.description}"
end
```
You don't need to check and then inject. The new webinos.js does that for you.
Same here - which files do you mean?
You can probably move this script on top and use 'defer' as an attribute for it.
Adding the type hint to date-to-window-start makes total sense, I can see the reflection warnings that are otherwise thrown.
Let the user() function be in in OBController. Don't move it to Users.
I don't see where this is ever updated... should there be a ZK watch somewhere to refresh it?
DNA and fingerprint hashes are not the same.
Change these back.
Love tests! :+1:
Should this be removed then?
Actually, the whole thing can be greatly simplified here too, since we don't track the response anymore.
`checked` ;-)
Might just be for convenience to clean up consumer-web calls
Also, if it's eager loaded this association is not needed as ActiveResource just builds the method anyways.
Для этого есть System.lineSeparator()
Я вроде при каждом исключении пытаюсь закрыть все открытые в данный момент потоки, это конечно может быть не лучшая практика, но ошибки вроде нет.
As mentioned in IRC, Function.apply() should be a more elegant solution for this line, rather than using Function.name.
<3 @m8ttyB 's comment :-)
Sure, it could be re-written as @@logger ||= setup!, as well.

This issue was never hit because setup! gets called during app bootup.
I think you can use just `"".html_safe` here
You can do `update = -1.0 * eta * (p[k] / p_sum) + y * eta` inside the for loop when `k == y`. This way, you get `K` updates.

Also if `(p[k] / p_sum)` is sufficiently small, you could decide to ignore the update.
Hm I guess it is connected to pseudolikelihood... hm...
I have ``np.c_['3,4,0', X, Y]`` somewhere in my code and I don't know a better way... sad but true (I think it is equivalent to a vstack, reshape and rollaxis)

usually ``np.r_`` can be replaced by ``np.hstack``, though...
I should specify: I believe defining numpy arrays as a *function argument* leads to fast indexing, but defining arrays as variables does not.
On Sun, Sep 30, 2012 at 04:57:49AM -0700, Wei LI wrote:
> Get it. Then I could alter all the parameters to be passed into the
> function by arguments rather than class attributes.

Thanks!

> But should I validate the input again, i.e. random_state should be
> checked both in fit as well as in the standalone spectral_embedding?

I think that validating random_state only in the function is fine.
As I alluded to above, this case is probably worthy of an error.
Actually, this is not a very good fix;  it really only applies if the incoming derivs are zero.  Perhaps I should test for that explicitly?
Could you please check if we really need that cast? I beleive it should in number and string cases with just getValue()
done (as was discussed offline , we can have only one combined fire(..) function)
No because it's supported, just NYI, returns undefined; because of the stubs
You can one-line the map, and use compact to remove nils?

```ruby
ary = address.map{ |key, value| [escape(LOOKUPS[:destination_address][key]), escape(value)] if value.length > 0 }
Hash[ary.compact]
```
Have you tried with $table->string('access_token', 255)->unsigned()->nullable();
Is this not covered now by <prerequisites>? Seems one is not necessary
You should not delete the line - it's there to ENSURE that no-one accidentally uses the assignment operator, because the default operator= would leak (at least I assume so, that's usually why we do such things).

Just removing the {} - and thus providing no implementation - should be sufficient to silence Clang.
This isn't quite the right function to check (although it probably works).  child(1) is a transform (not a transform list) .  transformContainsSkip() is correct.
I suppose the slow down on 32-bit machines (2x loads for this variable) is negligible...
Curious really - why does the minOccurs happen on a xs:element above and a sequence here.  

It might be worth having a comment (that outlined the different structures for the different cases).
E.g.,

 ````
name and row:
<element name=$name$ *optional*><complexType><sequence *repeated*><element name=$row$><complexType><sequence>
name, no row:
<element name=$name$ *optional/repeated*><complexType><sequence>
none: ??Is this legal?
<sequence *repeated*>
 ````
Then it would be easier to see if the code was matching that.
No, this pattern is temporary and (as the comment says) should go entirely when the transaction argument becomes compulsory.

All directory methods that deal with transactions will end up as two lines: create action + autoCommit().
I don't see this memory being freed up
What about -ve numbers and scientific format? Do those need to be considered?
I think `#ccc` should be `@grey` or something so that the colour is never defined more than once. That's sort of the point of less.
No, I don't think this is right. 
Raising a 400 error here implies that the client of socorro-crashstats did something wrong. 

I think this should be a perfectly good reason to raise a 500ish error. It is after all our (socorro + socorro-crashstats) fault. 
400 errors mean the client must revisit their request but in reality he just needs to re-try again a little later.
done, review the diff :)
This is unrelated to the strong/weak etag distinction, as etags should always be quoted, right?
Please don't use super. Instead replace this with `report.__init__(self, ...)`
We always left a blank line above the namespace statement
PR created (#851)
@yuhunglin Will do
Never mind, I see you did! Thanks!
The tag »stitanpadpreadsheet« seems weird, is it supposed to be there?
Rather than redirecting to root I think it's better to return a 404 error:

```ruby
raise ActionController::RoutingError.new('Not Found')
```
This probably isn't a good idea - better to rename the previous method, and call it, so that additional behaviour (which at least some versions do have) is also preserved.
Ridiculously long line.  100 columns, please
This is where the main fixes are.
I'm confused by these 3 lines of code - it's not immediately obvious what they do.
No need to account for `_borderWidthInPixels` because the node dimensions do not include the border.
We should use `BoundingRectangle`, right?  While your in `createRenderState`, can you change all relevant render state object literals to use our types, e.g., perhaps the scissor test, etc.
Put all the doc for the function here.  Users don't like having to jump around, and they will not construct the object directly.
Is this comment still valid?  Is it an additional technique that can be used in addition to your `VertexArrayFacade` changes?
"The maximum latitude, in radians, ..."
So viewing an extent in CV doesn't change the camera's look direction?
I would leave this block but comment out 'django_filepicker.context_processors.js' to leave as an example in the demo
I copied this code from another gateway, but I think this is right.

The creditcard is expected to be the ```ActiveMerchant::CreditCard``` class or a duck that quacks like that class. I'm not sure checking for that specific class is a good idea though since it wasn't being checked or enforced before.
If the response is supposed to contain the custom `options`, then maybe we want to verify it does.
Should we use something other than v for variable naming ?
Thanks, Blain. Could you check the information I've added about stacks of windows and how to switch between them?
If we remove this property, the docs need to be updated accordingly as well.  The state in the docs should be changed from 'deprecated' to 'removed'
... _the_ \`pause\` event
How do you protect against multiple invocations of the tool at the same time? They would compete in writing to the same log file, wouldn't they?
I think I'd still prefer to only attempt the `mkdir /tmp/cdrom` command if the `/tmp/cdrom` directory doesn't already exist, but I could be convinced otherwise
I've assumed that ${priority} would be the differentiating factor between vhosts.

Yours works fine for ${name}-80, ${name}-443.

But not if ${name}-80 is also used for an IPv6 host.
I think we decided on a fix, no?
Let's add here the constraint that sizeof(value) <= 4
OK. Added a commit.
Wait, I was wrong. Never mind.
I'm trying to remember if I did this too
we switched this to
> bind-attribute="dartAssignableValue"

hopefully more clear :)
Actually this is never ended since the user has no option to leave the screen :0
From my point of view I always thought that it would be better to give services which should not change during the runtime as arguments instead of through setters (at least because of the possible null pointers). I will take that topic to the ML
I will change that in a later issue, when I separate the components of the EKB into own bundles. Until now, the whole thing is quite a mess and when I put the list here in a blueprint file, the model registry is started before the list is set and I get errors. When I restructure the whole thing, it will be easier to put that list in a separate file.
I'd camelCase everything, personally. The $ isn't anything special, really. It's just another character, but then again you'd keep the first ASCII character in the name lower case.
I believe that's a typo.  "patient F" should be "patient B".  Will change.
Why does `receiverVersion` not increment when you get a notification you weren't expecting, but `receiverVersion` is older than `otherObjectVersion`? Doesn't this cause the bind to keep the second to last value if the `receiverKeyPath` is set after `otherKeyPath` is set, but before   `value` reaches the receiver?
s/length=40/length=6/
Need to include a serialization for dates and booleans too. See my sample code in #406:

    } else if (is_bool($value)) {
        return ($value ? 'true' : 'false');
    } else if ($value instanceof \DateTime) {
        $formatted = gmdate(Resources::AZURE_DATE_FORMAT, $value->getTimestamp());
        return '"' . $formatted . '"';
On Tue, Dec 4, 2012 at 10:08 PM, Jens Timmerman <notifications@github.com>wrote:

> Does runtest work? in this case, don't comment it out.
>
I suggest to give it a try on your side, esp. if you intend to try it with
the Intel compiler;
otherwise best is to leave it as-is, for now.

Otherwise, I am now stuck between upstream (you) and downstream contributor
(Josh)
and I really need to give priority on the bioinfo* packages... ;-)

(it's OK of this issue remains a bit orphan, we'll come back to it later on)

tia,
F.
Ah, yes. It will always been to be open unless puppetdb, postgres and puppet master run on the same box.  So, will people more often run all 3 together, or split postgres/puppetdb from the puppet master?
I'm going to update the code today then. =)
It should be doable to re-add the convenience methods. Maybe we need to allow people to configure several different serializers (in JMSSerializerBundle), and then add an annotation to the FOSRestBundle to tell it which serializer to retrieve.
It seems like you might want to pull this out of the savePage logic, so that savePage only handles the data saving, and have another function change back to view mode
It is currently running on the `invalidCallback`, should I be using another one?
There's no need for `version(unittest)` here. `version(unittest)` is used when you need to declare variables in module scope.
I don't think this test would pick up regressions from you fix.Can you verify that the header contains the right information? Perhaps by calling the methods directiony on the resultBuilder and verify the right things get added.
on Ubuntu 10.04 it seemed like the initdb had already been done as part of the package installation.  Is that no longer the case for 12.04?
Could you make so that running for demo would be only:

```
./manage.py dummydatastream 
```

Or maybe at least:

```
./manage.py dummydatastream --demo
```
Ehm, no cursing please.
Good point, fixed now.
вызываемый... это все что в голову приходит
инвокабля, еще как вариант :)
Ah ... solid point.  I'll fix this stuff up.  Thanks.
Add a @since 12.1
I'm cool with Handler in that case. 

So does that just need a change to the NuGet package name to Fody.AsyncErrorHandler?
I don't know what is the best name for this variable.
 
 * delegate
 * fallback
 * provider

What name do you prefer?
Move all of the string concatenation above outside of the Where clause, so that we aren't constantly recreating the same strings over and over.  Same for the namespace lookup.  Also (though probably not part of this pull request) we need to extract all of the strings in the converter into constants.  Having the same strings everywhere is error prone and makes the code less readable.
Sounds much better.
Too much copy-pasting. :-)
I think these are useful here, since the invocation shouldn't fail during regular testing, we would want to log it out and see what its doing when it actually does fail.
Thanks! and wow that was quick. I just pushed that!
I will do that now.
JL

On Fri, Mar 2, 2012 at 8:24 AM, Daniel Doubrovkine (dB.)
<reply@reply.github.com>
wrote:
>> @@ -2,4 +2,11 @@ class ApplicationController < ActionController::Base
>>    protect_from_forgery
>>    skip_before_filter :verify_authenticity_token, :if => Proc.new { |c|
>>    c.request.format == 'application/json' }
>> +
>> +  private
>> +  def get_auth_token
>> +     if auth_token = params[:auth_token].blank? && request.headers["X-API-KEY"]
>
> I would name this X-AUTH-TOKEN to be consistent with the URL parameter. This is not the API key, it's a token :)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/generalassembly/boardroom/pull/23/files#r511413
I think we should either clean up these 2 lines (they don't `urlescape` or anything) (and maybe make it more generic to be usable by other subs), or just take it out for now completely and add it to the TODO.  Thoughts?
```
scala> System.getenv.map { case (key, value) => key + "=" + value } ++ Some("asset_domain=" + "boom")
res2: scala.collection.mutable.Iterable[java.lang.String] = ArrayBuffer(TERM=xte
```

Looks like an `Iterable[String]` to me? Also, I'd use + and lose the `Option`.
initialize (spelling mistake)
Agree that it might be better to have it as an option to hide the close button. I'll update it.
I expect devs to check if a plugin they know about is in the list rather than doing something with plugins in the list they don't know about.
Doesn't `BasicRenderModelBackend` need to be instantiated before it is used? If so, we should do that in the `backends` module and reference the instance as the default backed here.
a comment that this is just for debugging purposes would be good for FILTER_TYPE_TO_STRING
Also probably shouldn't be public
давай это на три строчки разобьем
This is actually reversed.  SENT and FAILED used in android.  CANCELLED and SAVED are not used.  We will also want to remove the [iphone, ipad] tag from CANCELLED and SAVED properties
If the user can do:

    myVideoPlayer.media = mediaBlob;

I would like to leave in this property as write-only and remove the setMedia method, which will be generated automatically.
Many people prefer the property style access, so if we have both, we should probably document them.
need to call bps_free() on the connection type
maybe localize_date_format and  localize_datetime_format ?