labofsahil/github-event-dataset-2012 huggingface dataset:
I would do something like this:
```
return !!fluid.find(permissions, function (permission) {
    if (permission.length > 0) {
        return true;
    }
});
```
I used 1.9 hash syntax here as new Rails version won't support Ruby 1.8 and this is more prefferable way (syntax guidelines etc.)
replace with new raiseException
```python
except:
    self.log.raiseException("Could not load pickle data from %s" % (self.filename))
```
Missing `{@inheritDoc}` here.
`Czy jesteś pewny, że chcesz połączyć %service% '%name%' ze swoim kontem?`
don't leak implementation details in the api. Define your own exception here.
Lumping all of these is_present checks into one wrapped property doesn't give very good feedback when the test does fail. You know one has failed but you have to dig to see. The only failure message for this will be `true != false` which tells you nothing, which is why we prefer to have independent asserts for each check on the page.
Zacc, depending on  platform we show a different download link and hide the others that is why I am using an or and checking if they are present  not visible
Yes, it's necessary. Otherwise the screenshot folder and the .placeholder file are not in the archive.
extra space on this line... you can find it!
This should be named `SearchResult` because it refers to only one single result.
the results for "frfx" need to be exactly 0. maybe best to break this into two tests unfortunately.
Hi Elz! I was going to make both of the changes you suggested but you've already committed the changes. Should I make them at a later date?
/facepalm

Bad grammar ftw! Will twiddle with promptly.

On Wed, Jul 25, 2012 at 11:45 PM, mumble <
reply@reply.github.com
> wrote:

> > @@ -92,7 +92,7 @@
> >                :maximum_length => ArchiveConfig.COMMENT_MAX,
> >                :tooLongMessage => ts("must be less than %{count}
> characters long.", :count => ArchiveConfig.COMMENT_MAX)) %>
> >        <p class="submit actions">
> > -        <%= f.submit button_name, :id => "comment_submit_for_#{
> commentable.id}" %>
> > +        <%= f.submit button_name, :id => "comment_submit_for_#{
> commentable.id}", 'data-disable-with' => "Please wait.." %>
>
> peanut gallery: I believe C. is referring to "Please wait.." /peanut
> gallery.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/otwcode/otwarchive/pull/740/files#r1236013
>
Curious, any significance to this date range?
Why are we no longer adding '.' to the path?
you might be right, I'm just worried of any security related side effects ?
those tests are actually useful to the proxy too (I'm guessing that's where you took the which method).
Got it. I'll add the coffee script example in the docs, it was really confusing on how to do a simple transform.
Now I see your point :-)
There may be some hook for such a thing, but I haven't been able to find it yet. Just inserting data into the registry table isn't sufficient as it does get rebuild when modules are installed, etc. We'd need to be able to catch that case.
nit: just do != null
ПЕтяВАСИчкин и васяПетеЧкин
одинаково надо называть
Should probably be an if/else.
Just removed it.

I do like the simplicity of "gravatar_for" with one parameter, but its probably easier just to use what has been used.
I'm not a fan of logic in page objects. I feel that each of these page objects should have an appropriate search_for method.
Most "Share with Twitter/Facebook/Google+" buttons

^^ seems easier to read.
It does but I question if those should be used or not given that no reference has been added to the official documentation. Mind getting this information from Python folks?
RadOfDeg definitely won't work here...
Also since alt_unit is deg, it was correct before anyway...
I've been putting an extra line break before returns and if statements, also if / elseif would be on their own lines. I end up changing them when I go through the code but just wanted you to know so you knew why it was changing after your pull.
True, thats much cleaner
This trailing comma isn't legal JSON.
`# level.`
@simong : Can you work this into the cassandra module ?
*scratches head* I think I had that then moved it up here. Might have had something to do with custom handling of errors in different scenarios. Seems like it can be moved down, I'll revisit this when I implement the other searches.
Can this be formatted?
I'm not sure if I fully understand why this is part of the authz API and not the groups API.
The API should be able to return an error to the user when something went wrong.
I probably shouldn't, but the tests failed without those lines - do they pass on your machine?
I assume this is the AJDT version required to build with Juno. If that's true, could you add a comment? Or, maybe, we should have a ``${weaving.hook.plugin.version.indigo}`` and a ``${weaving.hook.plugin.version.juno}``?
I'm not sure the readability is that bad right now, and adding two more methods seems overkill.
Oh also, watch out -- if you're checking `typeof`, you want to use `assert.equal`, not `assert.ok`. (Tricky because `instanceof` is the opposite.) I'd love to move to expect.js or similar when moving to Mocha.
Even though the actual code here needs to change, we should still disable sessions, as it has a significant performance impact on microbenchmarks. Nowadays, it would be something like:

    makeSessionBackend _ = return Nothing
Так для того и добавлена глобальная переменная, чтобы поменть ее в одном месте, а не искать по коду. Прошу прощения если не правильно понял вопрос, такая же переменная объявлена в  класс Cell.m. Если количество элементов изменится, то необходимо изменить эти две глобальные переменные и не искать по коду число 100.
А почему бесконечный цикл должен считаться ошибкой? :)
I can't seem to find where the modal window happens in the UI. Where is it ?
The problem is that this all weakens the blocking semantics. As we saw, spinning the run loop can have nasty side effects, like `CATransactions` getting created and committed on a background thread. Furthermore, the code that's invoking this method may not be reentrant (since the method is documented to block), and callbacks from the run loop could put it into an invalid state.

Deadlocking is not ideal either, but maybe we could detect at runtime (some of) the cases where that would happen, and bail out with an error.
There should be some error checking to make sure these are set before making http calls. Otherwise, they will fail in spectacular ways when you hit the http call :)
Ok, pluginen vil ha en klasse ser jeg nå. Men jeg synes `.slide-out-div` mer presist kan være  `#feedback-content`.
I would call this `show_sharedfiles` both to be a little clearer what it does with sharedfiles, and in case we need to add a `sharedfiles` command later somewhy.

Then it would be clear enough to omit the descriptive comment above too.

Hmm, you might make it so the `api_responsekey` parameter is optional, and if not specified is the same as `api_endpoint`, since almost all the callers call it that way. You can give `api_responsekey` a default value like `None` so that it can be omitted.

Since it's pretty clear that the endpoint and responsekey are API related, I would call them just `endpoint` and `responsekey`.
It is not clear to me what "The indices can be re-used after saving the ICA." means.
I prefer N because it wraps more directly to scipy.signal's conventions (as well as ftype and btype), but I'm fine with changing it since it does make it clearer.
Why is this call here?  Doesn't this make it synchronous?
It doesn't support it for a precise architecture choice. Splitting
transmitter and receiver allows the use of an asymmetric load balancing.
For scenarios like televoting, mo messages are much more than mt, so
receiver can be configured to have more links (load balanced by a hardware)
than transmitter.


On Fri, Dec 7, 2012 at 5:55 PM, Ray Krueger <notifications@github.com>wrote:

> In lib/smpp/transmitter.rb:
>
> > @@ -3,6 +3,8 @@
> >
> >  class Smpp::Transmitter < Smpp::Base
> >
> > +  attr_reader :ack_ids
>
> Wow. Does your provider not support the transceiver bind?
> I definitely see your point the the ack_ids attr reader then.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/raykrueger/ruby-smpp/pull/11/files#r2350687>.
>
>



-- 

Quando hai fretta, l'unica cosa sensata da fare e' rallentare.
Ahh, I see. I think that we're having this discussion means it's non-obvious.
To find config file starting the search from the directory of the file opened in vim (instead of cwd):

```let l:local_conf = findfile(a:file, '.;')
```
@WouterJ ``AcmeArticleBundle`` is not a shortname. It is the bundle name.
link="/cn
I'm pretty sure it created a new TreeMap for every empty since it needs the Ordering. use a cached value for the empty.
Then it should be final?
Add a note about the decorator in this docstring.
Ну тут уже особенности реализации lmp. Я тут не шарю :-(
Пробел-то поставь после if.
Ну епт, весь цикл можно заменить на

    if (permission ["additionalRoles"].toList ().contains ("commenter"))
        driveItem.PermissionAdditionalRole_ |= DriveItem::ARCommenter;

Можно даже внешнюю проверку убрать — в пустом списке, очевидно, не будет комментаторов.
Fue mi primer intento, por alguna razón datepicker pone los cuatro dígitos del año con `yy`. Al poner `yyyy`, me duplicaba los años en la cadena resultante.
When I first read this, I got confused because the next item down said "Slides must have a set width"... after a minute I realized the above line is talking about the whole slider element, not the individual slides. Perhaps changing the term here will make it clearer upon first read?
If I remember the ldap extension does not return a 'count' key in this level. Could you tell me which Ldap server you have?
typo s/covert/convert/
its only used in rdl conf.
The intent is for logging stuff, so we should be fine. I'll add a space after the comma.
Sama kuin:
~~~clojure
(def split-into-monotonics get-monotonics)
~~~
For PEP8 compliance there should be a space after the comma.
Ah, so close! Will fix, thanks
On Wed, Jun 06, 2012 at 01:34:49PM -0700, Matt Basta wrote:
>Does this cover the whole bug? I.e.: is there more to do in terms of validating the structure/content of the new dictionary format?

The rest of the format is pretty much the same. I guess it would 
be good to make sure that there's a dictionary directory too, 
but it's more important right now to just make sure they can be 
uploaded.

-- 
Kris Maglione

The tragedy of modern war is not so much that young men die but that
they die fighting each other, instead of their real enemies back home
in the capitals.
	--Edward Abbey
Fair enough, then that's fine
Rather than include this logic, you should be able to set the initial wallpaper via the wallpaper.image setting. You could also include the initial wallpaper as a test resource and base64 encode it before setting it, to save including the full encoded string in the test. Optionally, you could include resetting to the initial wallpaper in the GaiaTestCase.cleanUp code.
Basically, this is the problem: open gallery in portrait mode, start a video and it will rotate the view to landscape. Then rotate the phone and put it in landscape mode. Now pop the video player, and you'll see the image underneath isn't aligned to the center of the screen
I’m just wondering why we don’t listen only on «window»? http://www.quirksmode.org/dom/events/resize.html
That would simplify a bit.
In the tests, you can add a script element before the vendoerPrefix.js file is included in the HTML file. And there you can override document.createElement.

    <script type="text/javascript" src="../../OLLoader.js"></script>
    <script type="text/javascript">
        var origDocumentCreateElement = document.createElement;
        document.createElement = function() {/* your override */};
    </script>
    <script type="text/javascript" src="../../lib/OpenLayers/Util/vendorPrefix"></script>
`size` attribute!
js to js file.  Looks like this is used in a LOT of places.  Consider placing this in behavior.js and have it run on every page.  The overhead will be minimal.
Actually I write it like this because I wanted to make the test only for the allowed types. Maybe it would be a good ideea to follow your comment but then test for undefined value before making actual test.
I've suggested this somewhere else, but what do you think about returning NA if their are no licenses?
@gsilver Can we remove the background images in this file?
I didn't get the purpose of this class - what is it?
why do you restrict the machines to libsvm? wouldn't any SVM work?
Agreed- got half way through this before realising I could do that :( this is a pretty ugly method. Next iteration..
Shouldn't this be values.data = bloom->bitstring + i;
?
See my comment above regarding session.close, I think I've fixed this now.
Are you sure the variable ``$sqlsrvResource`` exists, or did you maybe forget to declare it?
Should the type for parameter ``$httpResponse`` not be "HttpResponse|\Zend\Http\PhpEnvironment\Response" instead of "\Zend\Http\PhpEnvironment\Response"?
Is this a problem that has arisen that wasn't there before?
Unnecessary whitespace addition
gut, werde ich anpassen.
Sincerely, I want to hear an explanation!  Must be very interesting.
Yes, I know.

Which licence is used, MIT or LGPL?
Did you mean

    $tmpl   = $input->getCmd('tmpl');
Please break these up into two separate tests.
CS issue here. Should be

```php
<?php
if (null === $image) {
    throw new ...
}
```
Right. Add it to Element.storage and in the specs retrieve the filter
builder and check that things are set right.

Or.. use regexp to check the filter string.



On Mon, Aug 20, 2012 at 7:29 PM, gonchuki <notifications@github.com> wrote:

> In Source/Element/Element.Style.js:
>
> >  	if (!element.currentStyle || !element.currentStyle.hasLayout) style.zoom = 1;
> >  	if (opacity == null || opacity == 1) opacity = '';
> >  	else opacity = 'alpha(opacity=' + (opacity * 100).limit(0, 100).round() + ')';
> >  	var filter = style.filter || element.getComputedStyle('filter') || '';
> >  	style.filter = reAlpha.test(filter) ? filter.replace(reAlpha, opacity) : filter + opacity;
> >  	if (!style.filter) style.removeAttribute('filter');
> > +	if (requestedOpacity == 1 && getOpacity(element) != 1) style.filter = 'alpha(opacity=100)';
>
> definitely rethinking this, I wasn't taking into account the possibility
> of the element having other filters applied, and once that is added into
> the mix the tests aren't passing anymore. Making a helper seems to be a
> good idea.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mootools/mootools-core/pull/2411/files#r1420329>.
>
>
I agree that the phrasing is bad. What I want to say is how, in case of octree maps, to generate a point-cloud map that is compatible, from an application point of view, with point-cloud maps based on ICP registration. My idea was that for each face pointing to free space, there should be a point generated on this face with a normal in the direction of the free space. But feel free to propose another phrasing for this feature.
Yes, I didn't want to write that import. It came with too many strings attached for my taste, so I avoided it.
String 1: I wasn't sure it wouldn't have ramifications.
String 2: Checking for ramifications wouldn't have been worth it.
String 3: Using ```with``` without an import would make the test framework depend on 2.6+, and make it harder for 2.5 users to contribute.
I decided to keep the entry barrier low and avoid the with statement :-)
NOT GOOD!
That are two completely separate things. One is which tracking connections are opened from the browser. And the other is which walls user follows in real-time. Those are two separate things. And we are currently not yet doing the second one.
I am talking about CSS section name style. We have some `-------` and other stuff in CSS section names.
You can chain those together. Even if the check in if could be probably made into a selector case which would select only disabled subset of `panel_checkbox`, making set empty or leave it at `panel_checkbox`.
No, MongoDB supports rich schema, you can create an embedded document type for activation key and use this here. So then you would access it as `user.email_activation.token` and ``user.email_activation.created_time`. Use `token` instead of `key`, no? I think it is better.
I don't see why those temporary variables are necessary?
No. Because user will be able to link the account with Facebook also after registration. What if then fields to not match? I think we simply automatically populate fields if user logins first time through Facebook. But later on she can change values as she wants.

Better question is how we will give user an option to set username and password if initially she logged in through Facebook.
Why you changed file bits from 644 to 755, executable? Why is this file set as executable?
Yes, I think we'll eventually want full support for the Reach profile.  I'd be interested in seeing those changes and working with you to get them integrated.

I think they should be fully selectable at runtime, like XNA does with GraphicsDevice.GraphicsProfile.  Is it possible to do it that way, rather than with a compilation symbol?
I'm not a zsh user, but...

```
$ echo $ZSH_VERSION
4.3.9
$ echo "export FOO=bar" >/tmp/foo
$ echo $FOO

$ . /tmp/foo
$ echo $FOO
bar
$
```

am I missing something?
`getSchema` rename to `createSchema`
I think you still want to catch MapperException\RuntimeException here
run() which calls doRun() seems a little awkward, is there a reason to avoid putting the try/finally block around the original content of the run() method?
While the potential of Lucene queries is very high ...
Again, FileSystem seems better here.
Updated specs pushed, check it yo!
This block could be moved up and then return immediately if the target is behind. There's not much point doing `indvec` and `distToDest` or the block below if its not going to be used.
Looking good man. So these oauth queries might fail of course, and the only way to know is by looking at the response code in the body. So maybe the default behavior here should be returning the body? In that case, maybe we just simplify this function and have it return the body (so no `:return` needed). Callers can totally ignore it if they want. Maybe?
this is foo.
For this, I thought the print statements would be informative because if 
the user does not specify starting values for the nuisancce parameters, 
the EL confidence intervals are used.  However, it is possible that the 
function gets hung up when optimizing a nuisance parameter. Therefore if 
the function does get stuck, the user knows what parameter gave it 
trouble.  I suppose I can find a more elegant way to convey this 
information or just cut it out.
On 07/25/2012 12:14 PM, Skipper Seabold wrote:
>> +        else:
>> +            self.var_l = var_lims[0]
>> +        if var_max is not None:
>> +            self.var_u = var_max
>> +        else:
>> +            self.var_u = var_lims[1]
>> +        if mu_min is not None:
>> +            self.mu_l = mu_min
>> +        else:
>> +            self.mu_l = mu_lims[0]
>> +        if mu_max is not None:
>> +            self.mu_u = mu_max
>> +        else:
>> +            self.mu_u = mu_lims[1]
>> +        self.r0 = chi2.ppf(1 - sig, 1)
>> +        print 'Finding the lower bound for skewness'
> Need to get rid of the print statements.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/statsmodels/statsmodels/pull/326/files#r1236303
It's not actually abstract. :)
Please name it vmguest
Yeah, I'm familiar with the syntax, but personally I don't like it. I'm not opposed, but leaving a method body blank feels wrong. I'll get over it though.
Also, the first (correct) one could benefit from a single calculation of the scale as per getG1/getG2 above.
It's arguably no worse than performing a whole extra set of N^2 complex exponential calls across the whole array, which would be required for adding the 0.5 pixel centroid shift needed for the even size array shapes.  In any case, the generation of the lookup table via FFT is pretty far from being a rate determining step in the tests I ran: the later `draw()` call normally takes quite a bit longer.  

Of course, if someone wishes to demonstrate (it's possibly quick to do) that it is indeed more efficient to use an optionally even-shaped array and a apply a phase shift to fix the centroiding, they are welcome to change the current behaviour... But I will be working from this unmerged branch in the meantime for the central obscuration.
ok this is better.
Util.walkCells is not asynchronous, so there is no need for using a callback here.
Not sure it makes sense to have a default (e.g. could equally well be postgres on a different port).
Is it important that this php file is run in `/var/www`? Could make this a config key. Low priority?
The resources name is now replaced by defined variable. The default format is png now.
So, if developers want to keep *.pvr.gz, they can defined it in resources list.
Remove `.id`.
global $ ?
Was thinking this could be safer, leaving it until the end, since the properties could be edited directly, as opposed to calling this before send.
should be reverted to keep everything on one line.
@habibvirji Will this work with the installation that you have made?
pretty sure commits in this file are also not needed...
Shouldn't that be, return if (cur_alive_vermin >= max_vermin) ?
I agree with you, Alex.  The goal here was to consolidate common methods that could be used across all consumer projects.  I dislike monolithic classes as well, but think that one centralized monolithic class is better than 3 (one for every consumer web to date).  

This galaxy-client consolidation should lead to a decrease overall maintenance, and development time.  We would limit ourselves to one way to accomplish most tasks, and one set of specs to worry about.  Partner specific methods remain in their respective projects, but common methods should go here.  This PR does delete a lot of redundant spec and code. 

I also dislike the amount of aliasing done so far in the consumer projects, and perhaps these galaxy-client files could be modularized to be less monolithic.  These might be goals for another pit-stop day, but this PR I think does take us one step closer to a more orderly consumer web world.
Ну есть же у TimeZone метод getDisplayName
А вот такой fhellof будет валидным.
Тут, кажется, неправильный отступ,
Maybe it will be good to have some class method that returns either _default_manager or _base_manager depending on django version
It seems that Antranig was the one who added those comments. I need to talk to him about them. From what I read I'm not quiet sure what they mean.
while it helped me find the error, I don't understand why you are checking this file in if your tests ignore it.  The tests are a little circular right now in terms of using the underlying outputJoin from the code to check the output rather than hardcoding the string, or just using a check-in file like this for comparison.

From a comprehension perspective, I think I do prefer the idea of checking in this file and having the unit tests compare against it.  So put the file in expected-out/build.js and compare it will out/build.js.  Then someone scanning the repo can see what the tests are testing for.  You would, of course, need two specific expectation subtrees given your tests work in isolation and together.
Why is adding the themes to the config.assets.paths useful? (note: @ksheurs does this same thing in his fork)
Say there are two themes each with the same file in them:
assets/themes/xproject/stylesheet/styles.css
assets/themes/genigame/stylesheet/styles.css

If both assets/themes/xproject and assets/themes/genigame are added to the assets.paths then the app will only be able to access one of the styles.css files. It won't matter which theme is the current theme. All that will mater is the order that the themes were added.
So if this approach is followed, it means that every asset in a theme folder has to have a unique name.
There is a non-acsii character at https://github.com/bobsilverberg/marketplace-tests/blob/master/pages/desktop/developer_hub/edit_app.py#L54, which causes an error if that line is removed. I wasn't sure if there was a way to indicate that the value on line 54 is utf-8 encoded without adding that line, but if there is I agree that would be preferable.
We should add the '_locator' suffix to this name. https://wiki.mozilla.org/QA/Execution/Web_Testing/Docs/Automation/StyleGuide#Locators
I would remove this assert to make it easier to reach the delete step.
added priority sorting in compiler pass
why is this windows-only?
Use a proper numbered list.
additional "."
that's a bit against the scikit convention where all score functions want to be maximized
If I am not mistaken `svm.sparse.SVC` is deprecated, we should use `svm.SVC` only in the tests.
I wouldn't call "min_samples_split" pruning but I think think comparing these different regularization methods would be good.
I don't see `source` used anywhere. I don't understand this option. What is it supposed to do? What have I missed?
Like this:
public abstract class OsmandMapLayer {
...
	public boolean onScroll(MotionEvent e1, MotionEvent e2, float distanceX, float distanceY) {
		return false;
	}
...}

...
	private class MapTileViewOnGestureListener implements OnGestureListener {
....
		@Override
		public boolean onScroll(MotionEvent e1, MotionEvent e2, float distanceX, float distanceY) {
			for (int i = layers.size() - 1; i >= 0; i--) {
				if (layers.get(i).onScroll(e1, e2, distanceX, distanceY)) {
					return true;
				}
			}
			dragToAnimate(e2.getX() + distanceX, e2.getY() + distanceY, e2.getX(), e2.getY(), true)
			return true;
		}
...
}

public class PlanningLayer extends OsmandMapLayer{

...
     @Override

     public boolean onScroll(MotionEvent e1, MotionEvent e2, float distanceX, float distanceY) {
           getMeasurementActivity().dragMeasurementPoint(e1);
This only deletes the randomly generated folder for this specific build so it will leave the some empty folders around. Not sure if that's a big issue or not.
What does this mean?  Is that an extra step?  there should be no need for it.  Moc is to be run during the build.  Please fix this for this patch so we don't add building steps in the repo.
Moving this causes a compile error because NativeAbstractTextControlObject.cpp still references these.

After discussing this with David C, we came to the conclusion that we should have a new file named TiConstants.h to contain all the constants definitions that will be needed throughout the TI api.  This file will then be included in both places.  The Constants should also be declared in a Ti namespace to avoid name clashes.

There is a macro that we'll use to not have to write the .cpp manually.
What is that magic 2000.0f?
Consider `<$>` to be like `$` - it takes some sort of function on the left hand side (in this case `Bullet :: Point -> Point -> Bullet`), and then applies it to arguments on the right hand side. The twist is, `Applicative` lets these arguments *come from side effects*, in this case the `Gen` monad. So in this case we apply `Bullet`  to the result of calling `arbitrary` twice (in order), and automagically lift `Bullet` up into the `Gen` monad.

`Applicative` is da bomb, well worth getting to know!
This is the one line where there is an actual fix for the script.
It may be better to always create the `Logged404`, even for ignorable urls, so we know if we are ignoring something we shouldn't be.
offset_t pos = 0;
while (pos < sizeToRead)
{
    offset_t sz = io->read(pos, 0x100000, contents);
    if (0 == sz)
        throw MakeStringException(1, "File %s only read %llu of %llu bytes", file->queryFilename(), sizeToRead-pos, sizeToRead);
    pos += sz;
    md5_append(&context, (const unsigned char *)contents, sz);
}
Possibly for efficient random access / ease of use with XPath ? Pass....
this has been removed from the original code: https://github.com/videlalvaro/RabbitMqBundle/pull/35/files#L0L69
So we can remove it now, right?
Ooops. Your'e right.
Maybe, I don't necessary want to refactor bootstrap.js but my point was that this function is generic enough that it is already used in multiple places, so we'd be better of having it somewhere around other utility functions. Also, because while it feels primitive to implement there were some issues we had to fix later.
Sure.  I made it into a isOnShowPage method.
Why set this? O_o
iterating this way does not preserve the original ordering...the "generic objects" returned are in a different, indeterminate order, because you're storing things in a dictionary
Yeah, that would probably be clearer.
No need to convert back to ubyte
It appears that ``resize`` squeezes the output array (i.e. any dimension equal to 1 gets removed). This is apparently why the ``ndim`` stop condition (discussed below) works (when `rows = cols = 1`, the first two dimensions get squeezed out and you're left with a 1D array). This will fail, however, when the image shape is not square: One of the first 2 dimensions gets squeezed out such, that the color channel gets interpreted as the number of columns in the image.
Use an `if`.
Shouldn't there be an "and" here?
Rather than having `billboards.length = 0` above, why not just have `var length = billboards.length = text.length` here, and then use indexing rather than push in the loop below.  This would cause a single array resize rather than the multiple that currently occur.
If we are going to model `Cartesian3` and `Cartesian4` after `Cartesian2`, we should probably profile soon, right?
How about a test for this?
Points is a container of points, so it is not the best place to put this #isEqual method. This equal method seems to be better placed inside the Point object. This is a possible implementation (I guess the one I am foreseeing):

```Javascript
// this code is supposed to be inside the Point.js
self.equal = function(that, precision){ return Math.abs(this.x - that.x) < precision && Math.abs(this.y - that.y) < precision; }

// and this code goes outside the Point.js
Point.isEqual = function(a, b, precision) { return a.equal(b, precision); };
```
Parrot recommends not using this function anymore as it doesn't setup the drone properly for multiple user mode. The below lines are my rewrite of the initialization routine.
val is unused.
masksToBounds must be YES. Otherwise the background image will spill over outside the view bounds which will lead to undesirable UI artifacts.
Fixed in next update for TableView. Would you clarify whether this is also required for TableViewSection and/or TableViewRow?
When there is no state or when all the state is explicitly passed on the stack, I would agree. However, as soon as state gets into the mix, things get a little more complicated. When you have multiple callbacks operating on some state, you have two options, a class or a bunch of closures. A bunch of nested functions is very difficult to test since you don't have access to those inner functions. That's why you'll see that I've written a lot of callbacks that look like:

    button.on.click.add((e) => doSomething());

This has two advantages:

1. doSomething is available to the outside world for testing.
2. doSomething doesn't accept an event object since it doesn't use it. Hence, when you test it, you don't have to mock out an event object.

I was hoping that one day we'd be able to add unit tests to these samples and integrate them into a continuous integration system for Dart. I know the team would really like that. Hence, I'm purposely trying to write the code in a way that's easier to test.

However, I agree. In this case, using a class is not necessary.
To be consistent the slot should be named isFinished.
Didn't we decide on an xml2json fix for this issue?
This URL conversion was moved to Docs::content() library method
I believe the term is "uncountable". I kind of wrote that in jest, the same way one would talk about "internets".

I guess I lost the privilege to toy with the english language when I failed to deliver documentation with proper grammar and structure :/ (thanks for all your patient re-reads by the way)

I was stupid of me, in any case, to deliver that  comment in that form. Sorry.
I think it's OK - see:
http://www.google.co.uk/search?hl=en&q=%22or+failing+that%22

The original wording doesn't quite scan right for me, but I don't mind reverting back to it if preferred. Perhaps using a semi-colon instead of a comma to help the flow:
`Matches subexpression A; failing that matches B`
get these lists directly from the toolchain instance instead of splitting and all that
Sorry for the delay - only getting to this now.

@pmuir if we go ahead an do this, it requires adding a web.xml to every project to define the welcome-file list.  Are you ok with introducing a web.xml file for this?
Please don't declare functions in the middle of a scope. Use `let x = function () { ... }`; if it's not forbidden in strict mode already, it will be.
Would be handy, yep (since the translators will see this stuff out of context, it doesn't matter that the code is adjacent)
This, as well as `$_like_escape_str`, `$_like_escape_char`, `$_count_string` and `$_random_keyword` should be protected.
Fixed: https://github.com/imagin/FOSRestBundle/commit/eeeddfd61eeef2a539d7cb9aa3424932a7cbcfd8
this won't work...
basically same comments as for `-parallel` version apply here
i wonder why we have this assignment from $part = $url? we could just as well just work on $url and modify the url variable, as the substr thing is just shortening more and more. might be a bit more readable.
i think this is because for now the MultilangRouteDocument does not specify the locale as a route pattern but only as a default. which is probably also the reason for the ?_locale=en that we get. we should fix that as well.
This one is with dash, the others with underline?

Maybe a typo?
I can't tell if you fixed this or me atm...  :)
type is backwards.
If we're going to have to do this on every single ajax request, we should run `$.browser.msie` once out of this function, and just reference the value here. No need to add the overhead of checking for browser on every request
should it be butter-exclude=true or just butter-exclude ?
Change this to var; only Firefox and Chrome support const. See MDN's article on it: https://developer.mozilla.org/en/JavaScript/Reference/Statements/const
This would be better readable, I think:
```python
users.sort(key=lambda user: user['title'].lower())
```
;)
On linux pthread_attr_t is a value type while on FreeBSD it is a reference.
On linux pthread_getattr_np is said to initialize the complete struct
while FreeBSD's pthread_attr_init needs to be called to allocate the attribute struct.
Gunnar, I was going along nicely, making minor corrections (here https://github.com/garyrussell/spring-integration/commit/0b14fa17f2c04dbb5cb94ea9b69997f283c383a7) until I hit this section.

This just doesn't make sense to me (probably why I wrote up the JIRA in the first place). If this is truly how it works, we have to find a better way to describe it.

Maybe we should remove the first sentence (Assuming...), describe what happens if it's __not__ a String and then add a 

&lt;note&gt;
    If the incoming message's payload is of type String, the payload after the Xslt transformation will be a String as well. The  specified ResultTransformer will be ignored with String payloads.
&lt;/note&gt;

It think that's clearer than starting the section about the transformer with information about when it's ignored.

WDYT?
You could just say it will not perform as well as if ...

"degrade" means that it gradually gets worse over time - you should check the log message immediately preceding this one to make sure you really mean "degrade" there as well (I think in that case you do, although maybe only when the memory really does get strained?... based on my tests that can take a very long time since FWIW I have yet to actually see an OOM)
Sure, let's let users to edit their email addresses too. I'll add it to Trello also.

However, let's also add Devise confirmable, right after we've added mailling anyway. For confirmable it would be great to go first like: 1) register -> confirmation mail but immediate access to the site functionality, 2) confirmation email confirms email works, 3) change of email -> notification to earlier email and confirmation to new. 

Any changes should later be confirmed with a notification email.
Same as in ORM module, the driver chain should come from a different factory
Snasphot table already had the json field (if i not misunderstand.)
it filters on the names of the children, not the types.
Syntax error over here :c
correct, I forgot about this one ;)

@omissis can you revert back the change ?
Add a `200`also here.
is there a way to be less dependent of the Travis VM configuration ?
Is `options === undefined` really needed? I think options will hold only numbers, strings and objects/arrays, no functions. So we can use `!options` instead or i'm wrong with that?
+1 Right it is unnecessary and we are not using it in the other interfaced. I pushed an update
I think this file should be called buildingtoollogic.py instead, as it does not contain any logic of buildings but of the buildingtool.
Pls remove the debug output
@hisakonog what do you think about putting the datalist into a scrollable div too? it will make the page size more consistant, and they will find the Save button at the bottom more readily...
You can remove this comment, since it's in the commit message. Squash the commits when you do that.
The convention is usually to use `fooCount` for counting variables, rather than `numberOfFoos`.
other example, which is more straight forward? 

public IndexingOperationType onDelete(Blog entity) {
		return IndexingOperationType.DONT_INTERCEPT;
	}

public IndexingOperationType onDelete(Blog entity) {
		return IndexingOperationType.APPLY;
	}
don't maintain a contributor list. It will be a pain. Link to the github page instead
should be there as restart/ensurePlayer require UI thread.
`create`.
Вынеси скрипты в отдельнй файл
I would use `availHeight` and `availWidth` as per http://www.w3schools.com/jsref/obj_screen.asp
So do not forget about assigning this variable **after** language file is loaded ;)
If this file isn't exposed to developers, should we lazy load this map to improve intial load time?
btw, this even concerns some core types: ``country`` and ``locale`` extend ``choice``
You say, change this
```php
    {{ echo_trans("Display all <b>%count%</b> results") }}
```
by this

```php
    {{ echo_trans("Display all <b>%count%</b> results",null,"Admingenerator") }}
```

Is this what you mean?