labofsahil/github-event-dataset-2012 huggingface dataset:
My motivation in writting this change is to be able to create a source file foo.c and use "make foo" to build and link it correctly using the implicit rules. For that I need to change CFLAGS (and rename LIBS into LDFLAGS in another not yet committed change) so that the correct values are used by the implicit rules.

You can even compile a foo.c C file using "make foo" even without a Makefile file.

I don't want to add comments. I want to have less lines in the Makefile, not more.
No, that will never happen. How would a PHP core dev add a new constant in a previous version of PHP that is equivalent to one in a later version of PHP? That does not make sense.
yes, ported from TC comments. I tested it solutions, and working.
Overall, isn't the "^{}" equivalent to specifying one of the --verify, --symbolic, --symbolic-full-name, or --abbrev-ref options?
this line is also good
这个只是 partition 没有排序吧
lawl I planned on using this eventually! xD
I know, in class Finger there are prepared methods for this. T.finger was used just like a simulation of the finger in the background. I didn't want to do big changes with this, until I find out that it works well.
It makes no sense to create a log saying "logs cannot be written to database"  :-)
The mongodb module is still to be considered as work-in-progress, there will be more error handling and some kind of buffering.
I don't really see the ability to open up files on production and tracking versions like that to be very useful. And if someone needed to do that, comparing a single MD5 should be easier should be easier than going through multiple files. A single MD5 just seems simpler and less error-prone for what it's made for, letting the export tool detect updates.

The tool would have to read the whole tree at start-up, but then again we're basically stuck doing that either way. I wonder if we can get away with just using file modification times to make that faster on huge projects?
Nah. The purpose is only to report success or failure. If you want the reason for the failure you can dig it out of the 'exception' method. IIRC it was also not easy to predict what type of error I would receive, so I rescue all of them.

In any case, I've noticed there are failures with 1.9.x, so I need to fix those, too.
I agree with the comment made by @sadatrahman on the use of designated initializers
you should pass a `Collection` to the `obj` parameter.
Hey,
Was looking at the media pathnames in your JSON objects folder and noticed you are referencing the "filename" field. This was originally what we were using but instead we opted to rename all the files in lowercase using the media_id field from the objects.csv or the corresponding "id" field from the media.csv file ( via an SQL  JOIN ).

I also see you found our Cloudfront root URL. This will likely change later this week when I set a CNAME for it to data.cooperhewitt.org.

-micah
I am going so you can change it from default in the plugin.yml
Fine, fair enough.
Fixed: 60b6d9ca9f8b200a04ff551c4c534b4ed3ba191b
Do you have any idea how to avoid it?
I guess the mayavi check also needs updating in the setup.py
You should add a public interface for snagging microseconds.
Yeah it was, reverted and then re-applied in 1796a4b9f931a7ae06893c1f096e3607c4198722
This builds/installs against tip without the need for gb build tool, but does need the importpaths to be changed.

±! ganderson@excession [17:27:46] ../ngmoco/falcore (go_tip)
: tree ~/go/bin
/home/ganderson/go/bin

0 directories, 0 files
±! ganderson@excession [17:27:55] ../ngmoco/falcore (go_tip)
: tree ~/go/pkg
/home/ganderson/go/pkg

0 directories, 0 files
±! ganderson@excession [17:27:58] ../ngmoco/falcore (go_tip)
: go install -s -v github.com/ngmoco/falcore...
cmd/cgo
github.com/ngmoco/falcore
github.com/ngmoco/falcore/compression
github.com/ngmoco/falcore/etag
github.com/ngmoco/falcore/static_file
github.com/ngmoco/falcore/examples/blog_example
github.com/ngmoco/falcore/examples/hello_world
github.com/ngmoco/falcore/examples/hot_restart
github.com/ngmoco/falcore/upstream
github.com/ngmoco/falcore/examples/basic_file_server
±! ganderson@excession [17:28:41] ../ngmoco/falcore (go_tip)
: tree ~/go/bin
/home/ganderson/go/bin
├── basic_file_server
├── blog_example
├── hello_world
└── hot_restart

0 directories, 4 files
±! ganderson@excession [17:28:49] ../ngmoco/falcore (go_tip)
: tree ~/go/pkg
/home/ganderson/go/pkg
└── linux_amd64
    └── github.com
        └── ngmoco
            ├── falcore
            │   ├── compression.a
            │   ├── etag.a
            │   ├── static_file.a
            │   └── upstream.a
            └── falcore.a

4 directories, 5 files
lecks el aleman
avoid "PHP Notice:  Undefined offset: 0 ... klein.php on line 395" by checking that $args is not null
Heh, no worries! :) Glad it helped.
我也基本没有看了，既然能提速，就暂时注释掉，需要看的时候零时开一下。
ЧМОдство)
Creo que en este documento ya estaba el título de nivel 1, esta línea no sería necesaria.
sounds good, could you adjust your pull to just remove the sw, and I'll merge it in
oh ty=)

thx.
Where is OPENGL = Mesa defined
This is how the profile is defined: http://pastebin.com/SBpWmED4
There is absolutely no reason to have an "UNKNOWN1" and an "UNKNOWN2" type. Not even if we call them "GC_LIVE_MAP" and "UNKNOWN". So if something needs to be changed, then it should be the drawable for the UNKNOWN type. That will have the same effect but doesn't need those confusing two different types. Am I the only one, who thinks this way?
I can't believe I missed this.

It worked in testing as I updated the default (fallback) `pv` value to that currently expected by Google.
You forgot to insert `var ` at line 184:

```javascript
type = typeof value;
```
Maybe I'm too cautious here. As far as I know Github user always has an email and that means he should always have `gravatar_id`. Should I drop both email and zeros fallbacks here?
why is socket a setting?
Arrgh, I thought I had caught that one.
A few more notes before I forget:

The problem at the remote site APPEARED to be that it was rejecting the NewspaperRecord and ArchiveRecord 'fake' controllers.  What actually happened is that the links to BOTH pages were not properly formed.  In both cases I mistakenly used newspaperrecord and archiverecord instead of newspaper_record and archive_record.  Apparently, our local environments are more forgiving of this syntax error than is the remote site (possibly because of different PHP versions).  This is something to keep in mind as we move forward.

If only one or the other link had been broken it would have been easy to spot what was going on, but since both were broken at the same time it was logical (though wrong) to think the problem was with the controllers.  But the controllers were actually fine.  While I like the idea of adding new methods to existing controllers much better than creating 'fake' controllers, the latter is still an option if we need it down the road.
genau so hier
This is for the 2.3 release. Please commit final bug fixes for 2.3 onto the 2.3 branch. I am moving them now.
Passing the password on the command line means that another user of the system can discover it using `ps` or similar.
You don't need an explanation string here,` assert_operator` will print out the right stuff if the test fails. Explanation strings are most useful on bare asserts.
limitedOptions is also running on the main thread, it is called by prefscontroller in addAction - https://github.com/dustinrue/ControlPlane/blob/master/Source/PrefsWindowController.m#L593

Unless you think putting it on the main thread would solve that...I can check.
To be more clear: I definitely don't want to force members to join other networks than GitHub or the s9y forum.
So documentation of stuff should go to GitHub or the Forum. But for realtime conversation and emerncy help request _I_ would always use twitter (and many of us do, too), as it has a much faster response time in general.
I love how you used span here, and not div. Great!
@mattetti ok - thanks for the update and information.
Exodius: No.
а почему `aaadd`?
thanks uwe. i fixed the example to say name= instead of filter= and added the behaviour if name is omitted to the readme.
To be honest I don't know. It is implemented in the Zope2 batch where this code came from long ago. It is not used by Plone itself and I've never seen a 3rd party product using it. IMO this is no A prio to be fixed before merging plone.batching into the core.
Thanks for that, Bootz. Love you, man:3
Oops. Printing to stdout/stderr is bad. It is much better to use slf4j to log the exception.

Also, you should either recover or escalate the exception. As it is now the code below will throw a NullPointerException because list is still null.
but you have to say this bit of code makes it much more readable no?
Ma katmregch :)
Options fmask and dmask set the permission masks for files and directories separately. You probably currently use the umask option, which affects both files and directories.
If you're using UserTransaction, then you need to include the JTA API as well.
Yeah, but I'm okay reverting it if there's a better solution that's
just as easy for developers to use.
Falar de integração contínua síncrona e assíncrona (e discutir depois no contexto do kanban-roots).
Otherwise we want to throw our custom CellNotFoundException. I had to break this out into the multiline syntax because the compiler didn't like the throw with the lamda format. I didn't do any investigation... I'm too tired.
wait nvm I don't even know what the hell I'm talking about anymore
your name starts with a capitol letter, and you didn't use correct punctuation in your statement. As a result, an face palm is implied
I'm going to revert this then. I don't like the inconsistency between compilation SDKs.
I thought this wasn't the nicest spot for processing commands since it slows down the http request a bit. However I don't think shouldUpload() is a great spot either O_o so maybe I'll go with this
Thanks Balasz!
Do you still see this add-on completed one day?

Cheers,
Evert
Yeah, that's true. Now that I think about it, /that/ is what I actually do - remove the whole function. They all acheive the same result, but that's the cleanest. I always used to use it on EC05.
This one I actually did not fix in the code because I wanted developers to take care about having their TargetList variable properly set up...
This stemmed from a discussion with Ben here: https://github.com/benwatts/shopify-theme-radiance/commit/a9fef29bad5097ad1ccb6906451ab01dc6c553a0
I got half way through and realized that the alarm and axi screen policy were already both in place.  committed and reverted.  I am still considering doing the magic number stuff. there was something in there that COULD speed boot up by a good bit.

over and out.
Shit, still black screen:
http://wklej.to/WQyJ2
http://code.activestate.com/recipes/576676-how-to-detect-the-linux-distribution-from-an-initd/
http://linuxmafia.com/faq/Admin/release-files.html
TODO: a 'custom encoding' enabling a char field to enter the desired encoding (just like the 'other' value for extension field)
Explain please

Sent from my iPhone

On 2012-01-29, at 11:41 AM, "Aidan M."<reply@reply.github.com> wrote:

> Not needed
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/TheSocialNetwork/TheSocialNetwork/commit/659f25d94accc9a7c7a30aca931e75560a16e67f#commitcomment-912458
In the revision I am using, it does nothing.
yes its working fine....

no other files required...
Поправил ты в этом коммите: 3497c91d926db7066c7681ca07afe90d56c80aab
Да, так уже лучше
Yeah. That is a little bit slicker. I had used that a couple times. Now
that you made me rethink it. Storing the return method is probably better
for kostache.  haha.

from my android
On Feb 12, 2012 10:59 PM, "Isaiah DeRose-Wilson" <
reply@reply.github.com>
wrote:

> Yeah it can be handy for some things. I rarely use it though. I normally
> store the return variable from my function, that way if I use it multiple
> times in my template the I don't have to run the whole function again.
>
> Example:
>
>    public function example()
>    {
>        if ($this->_example)
>            return $this->_example;
>
>        // Do some heavy lifting here
>
>        return $this->_example = $my_return_data;
>    }
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/synapsestudios/kohana-projecttemplate/commit/a9a8c8180232a4009d85e5f93a100d5219d26431#commitcomment-958858
>
They know it's going to be US and to schools county matters (i think).
Shouldn't these all be fabs(d)?  I think like the following:

if (fabs(d) > max_first_derivative)
   max_first_derivative = fabs(d);
moving_variance_derivative.push_back(fabs(d));

Actually, the third one I could see as being OK for just d.  But if you set inside the if statement to just d then no negative derivatives will ever be counted (unless they happen to be the very last derivative).
This is counter to the expectations of fog.  I would expect that calling something like `ready?` would not make any api calls and instead simply rely on cached data.  Then `reload` busts the cache and gets the latest information.  `wait_for` relies on this behavior, for instance, to reload and check some value until it is true.  So changing these to the constants is good, but checking the api instead of a cached value is not desirable.
Yes, I'm not yet clear on this. I assume you have access to http://www.ebi.ac.uk/industry/private/Documents/workshop-materials/120530_Rbio/RBioC-WorkshopPresentation.pdf. Feel fre to put in the documentation you are confident with and leave out the detail you're not sure of. I'll need some time to get to the stage I feel I understand this well enough to comment authoritatively. Thanks.
Any reason not to use `std::string`?
Is it really necessary to specify type here as "Default" is already in "Netbooks"
What if a null is passed in here last?
Shouldn't we have a Queue that records all updates or similar?
Sounds like something we should avoid, creating brittle code to satisfy testability seems wrong.
could use

    node().isLeader must be(ifNode(a1)(true)(false))

if you are so inclined. Otherwise I might as well remove that method, so please comment.
seems inconsistent to have _latestStats and clusterMetrics, use _ or not, but consistently :-)
Why not delegate to parent?
Ok, let me take the names out, it was purely for logging.


On Sat, Nov 24, 2012 at 9:04 PM, Viktor Klang (√)
<notifications@github.com>wrote:

> In akka-camel/src/main/scala/akka/camel/internal/ActivationTracker.scala:
>
> > @@ -22,12 +23,13 @@ private[akka] final class ActivationTracker extends Actor with ActorLogging {
> >      type State = PartialFunction[ActivationMessage, Unit]
> >
> >      var receive: State = notActivated()
> > -
> > +    var state: StateName = NotActivated
>
> If we aren't making this an FSM Actor now, I think we should also omit the
> entire "state" thing, I don't like partial/ad-hoc solutions. Do you agree?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/akka/akka/pull/893/files#r2215629>.
>
>



-- 
Raymond Roestenburg

code: http://github.com/RayRoestenburg
blog: http://roestenburg.agilesquad.com
twtr: @RayRoestenburg
I think we shall use `with NoStackTrace` for this, since it is thrown a lot when Open
may *be* set
Why double underscore? Is there some Kivy convention I am missing?
Agreed. But @footerTextColor is a rgba value which isn't supported in IE7. I'll change @footerTextColor to it's computed hex value and that'll fix it
Weird list, the title of it is one of the actions performed.
Cool. This is actually just leftover from the old code, but I also didn't know about log.exception, so thanks for the heads up!
W dniu 26.07.2012 08:24, C Anthony Risinger pisze:
>> @@ -394,7 +396,9 @@ def drawNextYear(self):
>>   
>>   class DateField(Composite):
>>   
>> -    icon_img = "icon_calendar.gif"
>> +    img_base = pygwt.getImageBaseURL(False)
>> +    icon_img = img_base + "/icon_calendar.gif"
> remove the `/` as `pygwt.getImageBaseURL()` will always have a trailing slash (`/` also breaks relative urls)

Ok. I will fix it and then what ... how can I "fix" this pull request 
after I fix it in my clone repo?

-- 
pozdrawiam

Łukasz Mach - lukasz.mach@pagema.net
Remove options and checks (maybe)
How about
```
fromMode.Left(4).Equals("720")
```
then set the proper width and height and then use another comparison to check if it ends with "50Hz" or not? Would save some code duplication especially on all the 1080p/1080i/...
This method no longer calls `setText:nil` as of fce914a
Agreed, seems like this would lose track of the msg.pid if zygote was ever None.
10.8, with compatibility for 10.6. Not sure why it didn't work. However, a single synthesize statement couldn't hurt, right? It'll be removed later.
Do you want to merge my change for now or do you want me to fix all of the DNS documentation before you accept it?
`if (this._handle) this._handle.ref();`
If you read the issue linked to this pull request, you'll see that it actually gave a problem to someone.
Yes, ret is defined just before this. This code is exactly the same as the one for dot, but was missing in inner.
supňu -> stupňů
před respektive čárka
Because the json I have used has only 4 fields to select from. I would
need to add another field in the payload (e.g. : buyBoxPriceResponse)
There was no other check on the result returned. Hence I thought it would
be ok to select 4 instead of 5.

If you suggest adding another field, I can do that.

Thanks,

Madhura 

On 3/20/12 11:04 AM, "Subbu Allamaraju"
<reply+p-581438-b9deca60ea8e14cd092342b65aa8ffafef129a15-1316753@reply.gith
ub.com> wrote:

>> +        ],
>> +        script: 'create table first on select get from
>>"http://localhost:3000"'+
>> +            'create table second on select get from
>>"http://localhost:3026";'+
>> +            'products = select * from first ;'+
>> +            'prodstats = select * from second where productID in
>>("{products.ProductID}"); '+
>> +            'return select p.StockPhotoURL, p.Title, ps.productID,
>>ps.inventoryCountResponse from products as p, prodstats as ps where
>>ps.productID = p.ProductID;',
>> +
>> +        udf: {
>> +            test : function (test, err, result) {
>> +                if(err) {
>> +                    test.ok(false, err);
>> +                }
>> +                else {
>> +                    test.ok(result.body);
>> +                    test.ok(result.body[0]);
>> +                    test.equal(result.body[0].length, 4);
>
>Why is the length 4 and not 5?
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/ql-io/ql.io/pull/377/files#r581438
@jeremy, excuse me, are you sure it makes sense to allow non-strings for `fixture_table_names`?  This class attribute is not documented and internally it only gets strings.  Rails tests were passing with this revision.
Is better to change it to:

```
s.add_dependency 'bundler',         '>= 1.2.2', '< 2'
```
Please put a space after the `include?`. Also I think this is better

```ruby
conn_params.delete_if { |k, v| !white_listed_params.include?(k) || v.nil? }
```
ON PURPOSE unfortunately.  I need it to infer the correct return type, and it's not.  We have an issue with our trait hierarchy in mutable collections such that we loose type safety after a certain a mount of time.  I've opened a ticket for it: https://issues.scala-lang.org/browse/SI-6350

Once that's fixed, we can write the correct return type of `This` for all these, right now it's infering the wrong one.  I can be explicit about that if you think it's a good idea for posterity.
ah sorry I missed the bit where you are talking about a local branch
I guess I typically polish up my commit messages right before submitting and then add the "review by"
@smichr they are covered in the tests 1. ask(Q.real(I**3)) and 2. ask(@.real(I**2))
It was happening because the `_eval_expand_*` functions were calling expand() outright, often ignoring the hints.  This is why expand's hints were called dozens of times per expand call and why we always had the recursion errors with expand().
replace first comma with colon?
changed to "Symbol"
making not Q.integer to Q.rational will not solve the problem, according to your example we need to analyze the exponent also like if the exponent is some expression we need to check whether that expression make the power real or imaginary if the exponent is like x**(y/z) it can be easily identified but not all. 

even wolfram and other are not able to handle powers properly because of this like for example (-2)**(2/3) should be real but wolfram shows it as imaginary etc. so I thought it would be better to show none other than giving false result
please correct me if i am wrong
use `library(R2SWF)`
I think clone is needed by design. Check CActiveDataProvider.
Why do we need to use `mb_strlen($hash, '8bit')` here if `$hash` contains only ASCII characters?
some extra spaces here :)
We still need an autorelease pool, even if the format has changed. Use:

```
@autoreleasepool {
    int retVal = UIApplicationMain(argc, argv, nil, nil);
}
```
all functions in astropy should be `underscore_seperated_names`, not `camelCase` (to conform to PEP8). It's of course less crucial (although still preferred) for private functions, but definitely at the very least `parseDegrees` should change to `parse_degrees`.  

Also, why is it public at all?  Isn't this only useful internally in some of these classes?
Actually, this feature is used for trait in PHP 5.4. So, I'm going to add the app to the after filter too instead.
Maybe nevermind; I may have been reading the wrong line!
Yes. The two rules are actually still supported though. This is again a result of a growing disconnect between report and repair escalations. The only solutions I can come up with for this introduce significant UI complexity, so I'm open to suggestions.
Should be listReportsForPair
quotes inside italics?
let's rework this section. but in general I think this section adds little, and is poorly structured relative to the existing election section which covers most of the same content, in a more current way. 

secondly, I think it's a good plan to say "available" rather than "up"
is there a reason we're only doing this for templates? why not do it for all pages?
Not sure about the `limit > MAX_FEED_ITEMS` part - some people might want to *reduce* the limit, say for a blog widget powered by JSON that shows only 10.
Some methods have access modifiers, and some not.
In what case would you want the commit to go ahead? You would just have to amend anyway, it is far easier to abort the commit.

It also makes it harder for people to ignore the warning.
I'm not sure whether this should be done. It might be okay to just use the same driver for both caches when sql cache is not specified.
Let's update this code to use the upstream merged PR
fixed in 882d6e8
fixed in 0e4e4d8
`class represents object' is pretty cool explanation :) I'd suggest `Represents a First Person camera'.
This should do it:

```javascript
loader.require(required);
var out = loader.resolve(true); //This forces a calculate
```
I've commented all the `initializer` methods.
нет. мой крон обновляет баннеры и обновляет таблицу статистики, нода обновляет суммарные просмотры
твой крон обновляет баннеры и суммарные просмотры, а крон пишет таблицу статистики

по действиям, в обоих вариантах нода делает одинаковое количество запросов к таблице, но update немного быстрее insert .. update

по крону
мой: обновление статуса баннера и запись в таблицу статистики - 1 update по интервалу, и insert в конце дня
твой: обновление статуса баннера и обновление суммы предыдущих просмотров - не имея текущей суммы просмотров, 1 апдейтом статус баннеров не обновить, т.е. нужно для каждого баннера делать селект и сумму прошлых просмотров с текущими, т.е. вместо 1 простого update запроса у меня, получится довольно сложный запрос(я его сходу даже составить не могу). обновление суммы предыдущих показов тоже будет довольно большой запрос опять же с селектом по каждому баннеру и суммы
Resharper complains, as the propnames and param names are different (casing).

Anyway, done in commit: 650d1b0273827ca1e0175fdaf4852732620af9f4
Also, is the else{ Ext.emptyFn } part necessary? I think if you take it out it will run faster + be more legible
No. :-P

This is just a place-holder. The "what's new" PR will remove the need/desire for rst in this file.
Oh! Sweet! This gets rid of the horrible "I specified `start` without a catalog and since the discovered action was `create` instead of `recover`, I got an error for missing the catalog" bug.
Might we need also ROLE.equals(commandPrefix) case? (see regex suggestion above)
why null=True, is default='' not enough?
I think we might want to expand the message to be more indicative of what is being logged. When I look at the lager output of one of these messages it looks like this:
```
{kvget_map,0}: {trace,[error],[{ok,26270}]}
```
which doesn't really give a lot of context for gathering any meaning from it. If the only `Type` specified is `kv_get` it's not a problem, but if there a re a lot of other trace types enabled it could be difficult to understand. 

Something more like this example from the `riak_pipe_vnode` module would be useful I think:
```
?T(Worker#worker.details, [queue], {vnode, {dequeue, Partition}})
```

That statement results in the following lager output and give some better context:
```
{kvget_map,0}: {trace,[error],{vnode,{dequeue,1324485858831130769622089379649131486563188867072}}}
```
Okay,

we could retire _fixSequence when https://github.com/cakephp/cakephp/pull/852/ gets merged. \o/
generally not a fan of single letter variables - especially in a tutorial - a verbose variable name here will be more readable later

template_object
template_context
What is not in the terminology? Can you specify?
`get_format_modules` returns a native string, as `django/utils/formats.py` has no `unicode_literals` import. But I could also have done `str("%r")...`.
Silex?
:siren:ACTUAL QUESTION/COMMENT:siren: What happens here if the socket is continually timing out, i.e. the remote end has gone belly-up? If the ssh/paramiko layer doesn't itself raise a non-`socket.timeout` exception (e.g. an `SSHException`) I feel like this could leave a process in limbo. Will have to figure out how to test this if you haven't already.
Ahh, sorry. I messed up. This is correct since &amp; is outside of the italic node.
Prefer

```ruby
if value
```
nope, it's consequence of removing try... catch
typo: `'no` => `not`
What happens if you cache `cssExpand[ i ]` in the loop? Any size reduction?

what about storing "content", "padding" and "border" in vars?
This jump column is not related to the tree_table, it means which node the case will go in the next level. For example, the jump of all the cases is 1 (root node ID), then each case will go to different node with our level-by-level algorithm.

If you see the comments of c45_classify, we give the description of the classification result table. As we store the encoded values for class column (its type is INT), users need to join the table with encoded table to get the real class value. This maybe not convenient. Thus, in our latest code, the type of class column is the same as that of class column in training table. Furthermore, remove the prob column, since it's useless. Thanks. 

{code}
 * @return The columns of classified table:
 *  - <tt>id INT</tt>     - Record id.
 *  - <tt>class INT</tt>  - Predicted class.
 *  - <tt>prob FLOAT</tt> - Probability of the predicted class.
 */
DROP FUNCTION IF EXISTS MADLIB_SCHEMA.c45_classify

{code}
Would be nice to have access to the `no_minify` bundler option here.
Then nix it in the grant line and then we don't have to use it to grant for the test database, too.
Perhaps you mean MONGREL2_HEADERS.each here?
formatting...  I guesse we have a different style....
There's no checking being done here regarding the existence of the ``id`` and ``version`` properties. There's a risk that the channel might be: '/undefined/logging'. Is this the desired error "handling" in this case ? If so, then you can ignore this comment.
return early here too

```javascript
if (!matches) {
    continue;
}
// code here
```
The way I normally do is that I select some test parameters i.e. some fixed values. I tests for those, and then I also have some random data simply to tests for values I did not think about. You are right that you might have a hard time to reproduce the tests, but on the other hand you now know that an error exists, which you can then go hunting for. I think is is better to make the random testing random, and then also maybe have some fixed tests that examine some edge cases and some common values. What do you think?
余分なスペース・改行は、除去しましょう。
Ok. But that should be a fix for a later release. What I can do now is to
put let UPDATE and ADD both use the add(doc) method.

But the exception throwing if the action isn't set, instead of doing
nothing, isn't that bad, is it?


On Fri, Nov 2, 2012 at 2:53 PM, Joel Westberg <notifications@github.com>wrote:

> In
> stages/out/solr-out/src/main/java/com/findwise/hydra/output/solr/SolrOutputStage.java:
>
> > @@ -46,6 +46,10 @@ public void output(LocalDocument doc) {
> >  			add(doc);
> >  		} else if (action == Action.DELETE) {
> >  			delete(doc);
> > +		} else if (action == Action.UPDATE) {
>
> I think for Solr Action.UPDATE and Action.ADD should be the same. In
> fact, if you look at Solr, it only has UpdateRequestHandler, no
> AddRequestHandler, so Action.UPDATE should be the only supported
> operation, if any ;)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Findwise/Hydra/pull/115/files#r2016237>.
>
>
`canStartTransition`
Heh. It applies to _processData, really, not the whole adapter. But yes.
Looks like it's some kind of caption maybe? We don't currently show captions for images/thumbnails, right?
``root`` is the default for all languages. See http://requirejs.org/docs/api.html#i18n. Following the example in the docs is a little weird. 

This makes our development workflow easier when we're authoring the en-US string. If we had a root translation (maybe just placeholders) and an english one, we would need to update 2 files every time we add/remove a string key.

We could still define an en-GB folder that would fallback to root.
Using null throws an error "object is not a function" in `NativeFileSystem` when the folder does exist. Are we fine with that? I supposed it'd be better to avoid it...
.click() function call should be indented.
You could also just keep an auto incrementing id and return that from markStart() to pass to addMeasurement() instead of name.  name could then be stored as a property

```
activeTests[id] = {name: "", startTime: ...}
```
Is is a bug that sequentialMatches isn't getting squared here?  Everywhere else it seems to be...

In general, it might be worth summarizing the scoring heuristic in the docs somewhere.
Both versions need ace, not just release.
Do a simple `if (navigator.geolocation)` check.
These all should be `self.register` now.
Why not use `File::fnmatch`, which would give you finer control than just asterisk-wildcard?
`===` :)
Could you please try to avoid such javadoc ? It may be better to make a sentence, and to explain somewhere what this variable is used for.
以下兩個 modal 也一樣要加
*Poglej zadetke na*?
The originally code being broken is unrelated, but since you copied that broken section of code you ended up broken, too. The specific columns that are busted are: build_id (should be buildID), build_target (should be buildTarget), os_version (should be osVersion), dist_version (should be distVersion), header_arch (should be headerArchitecture).
Add brian chirls here
Chnage these single quotes to double quotes.
Depend on language and translator, this can be translated or not. In my case, every  translations of PDF Viewer I tried didn't work, so I kept it as is. But it does not mean there is a good one exists.

This is work in progress and I encourage translators seek independent feedback from their users.

@saebekassebil, if you find anything you want to change please submit correction at any time :)
Maybe capitalize the variable to indicate it's a constant.
2.5 is a magic number -- make a constant. why not just 2?
you're grabbing a lock in g_EpgContainer here while holding a lock in CEpg
looks like this needs a lock around m_bHasPendingUpdates too
From the acts_as_indexed docs it looks like if we used 

`paginate_search(params[:search], :page => 1, :per_page => 25)` 

instead of 

`with_query(params[:search]).paginate(:page => 1, :per_page => 25)`

then we'd get the most relevant results first.  The docs suggest that using with_query will get you everything that matches the query but not necessarily in order of how well it matches.
superfluous use of toString()
Huh, didn't know this would actually work. Kind of a cool idea that you have no ENV for a short period of time :)
I'm getting this now:
[error] /Users/johan/Dev/zipkin/zipkin-hadoop/src/main/scala/com/twitter/zipkin/hadoop/DependencyTree.scala:21: PrepSpanSource is not a member of sources
[error] import sources.{PreprocessedSpanSource, PrepSpanSource, Util}
Je ne suis pas encore sûr à 100% que ça sera un UserBan et pas un UserInterface. On verra à l'utilisation :).
Please specify the current commit with `:commit => '3fa3d82f8ff05a25d40b61592e1cf18115daf306'` and ask for a version tag with [this template](https://github.com/CocoaPods/Specs/wiki/%22Please-add-semantic-version-tags%22-issue-template).
Maybe change the string to 
_("Welcome back, %s!") % current_user.username

The exclamation may not be as important as giving the translators a chance to put the name first? (No idea if this is needed)
@jlsherrill, yeah, based on commit above, it no longer seems needed...
agreed, but im following convention from the rest of the file. not sure why its like that
"Each" used as a block should conform to do-end style.
Ok I guess I'll just do it after merging, rest is good thanks!
why not use regular function syntax here?
I think we should do:

    module.exports = ChunkEmitter;

I know I've done your version all over Haraka, but its just because I didn't know how to do the above before. Same for MessageStream.
main.h has hashBestBlock.
It doesn't matter which boost version's internals you use, this is *still* Windows-only... Isn't there a way to recover with documented methods?
I think it's fine to change it as you did. But I'd also be fine with removing the fallback and returning error. 

There are places where extensive recovery mechanisms for OS errors are warranted, but this isn't one of them. No need to spend much time on this.
It's not that easy to switch to *allOverlays: false* (this is not an authorized parameter in *gxp.Viewer*).

@sbrunner has suggested me the following change: [9a916b0](https://github.com/camptocamp/cgxp/commit/9a916b0698bffcc3f97d4188d7eedfe4614651dc)
=> it no more uses references to *map.baseLayer* but to *map.layers[0]* and updates the index of the selected base map.
 
It actually solves the problem (background layer is no more switched when one changes the order of layers in the layertree) but some other problems then show up because *baseLayer* is used elsewhere in the plugin. It seems also that the permalink no more works for the background layer restoration. To be discussed...
`initialized` is a boolean flag. You can call the `initialize()` method on `Object` as many times as you want. Only the first call will have an effect, the rest are ignored.
`corps`
ok, pushed an update with the separation between node and rdf concept in the interfaces. also tried to make the metadata loader handle the distinction. the tests still pass, so it should work with our implementation.

i suggest we do the cleanup of children / collections separatly. the current state there is not worse than before and i really start to lose the overview with this pull request. currently the entity is rendered with its collections and properties, so getChildDefinitions does not seem too wrong to me.
yes i like your style, just not my habit (i will fix my habit)
Can you change the control flow to this?

```Ruby
if request.env['HTTP_CONTENT_MD5']
  content_md5_pass?(request.env) or raise HTTPStatus::BadRequest.new('Content-MD5 mismatch')
end
```
Not that this has to be fixed now, but I wonder if there's a better way to handle this kind of thing...
File seems to inherit from EnitityType, which makes me think this has a unique id.  In this case, there's no reason for us to break mold and use Set.  If File doesn't have a unique id, then we should change its inheritance model
WHY ARE WE SCREAMING HERE IF THIS IS NOT A MACRO
Yeah, translations shouldn't have products set. This seems a little defensive here given that we will only hit this if we have a bug elsewhere. I guess a user could tamper with the form and try to get products saved on the translation and this would clean it out. Not that anything harmful can be done here.
you can also use isinstance(productversions, list) here.
looks good. It's what's done for plpgpsql too.
Fixed this ident.
It looks like this entire file has changed. Please be careful with line endings:

https://help.github.com/articles/dealing-with-line-endings
Why? Can't you just pass the correct one?
I agree with this change, but then we probably need to change the `getTotalTime()` to `getTotalDuration()`.
unused here too
Thanks for the valid comment, fixed in 45d0748 :)
@bamarni I guess it is because of the static property in the Request class. If you run them in the same process, the static property will be kept from the previous test
a mistake, fixed
For the sake of consistency, please use the same comment header that Xcode creates when creating a new file. (I am guessing you created this file first and then added it through xcode?) example follows:
//
//  CPSkill.h
//  candpiosapp
//
//  Created by Stephen Birarda on 5/24/12.
//  Copyright (c) 2012 Coffee and Power Inc. All rights reserved.
//
Note quite: it is called in the HTTP handler, and used in all calls: V6daemon.xmlrpc_handler.
I'm not sure this is doing the right thing:

```
>>> int(-1.5)
-1
```
ok, the problem is when a PDO throws an exception with code of string, or may be some other exception class with some string who knows 

    if ( is_int($e->getCode()) ) {
        throw new $class($e->getMessage(), (int)$e->getCode(), $e);
    } else {
        throw new $class($e->getMessage() + $e->getCode(), (int)$e->getCode(), $e);
    }

May be we can add a check whether the code is string and add that to the message?

or may be we can do something like http://php.net/manual/en/class.pdoexception.php#97908 as  in the post http://stackoverflow.com/questions/6001432/dealing-with-pdoexceptions-when-db-return-an-error-statement . I feel this way is better .

or may be add the `$connection->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);` as in  http://stackoverflow.com/questions/2104481/how-to-handle-pdo-exceptions ?
You need to determine why your linux only gets this problem and implement a fix that detects when it happens rather than affect the performance of everyone who doesn't use your linux driver.
No issues on openwrt or xubuntu 11.04
This can't work because it will return (127.0.0.1) rather than the actual ip of the machine. So the hostNameResolved is still needed.
Changing from Task to TaskInChild is not necessary, TaskInChild is implements Task. I will fix it later.
I'm a little confused why ``self.message_user`` is used here, but on line 830 ``messages.error`` is used.
Is it safe to have just one of these, or should the functions that need it instantiate their own?
There!! I spotted a tyop (transfromed). Also "8value" below.
Any idea why this diff shows a full replacement?  Is there some whitespace or line-ending difference here that I can't see?  It doesn't look like anything actually changed here (and I wouldn't expect it to).
Fixed in https://github.com/bradh/OWSLib/commit/c64a982248727a469de437c635f4a347faa46423.

It was indented OK if you use tabs == 8 spaces :-)
binding on title was causing on blur of editing the title, to re render the data list which made it seem like it had saved, btu infact it had not called updatePouch. using something the suer cant edit, like the datecreatd i a better way to detect a change of internal models
The TCCL operations should probably be done via the SecurityActions as well.
Yes, it would create an undesirable dependency.
Also, no need to explicitly call modelValidator, or anyother paramters, you should register validators directly on SimpleAttributeDefinition.
Thanks for doing that. Please don't regard my previous comments as critical; you've done a very nice job on this so I wanted to make sure you knew "correct" way. As you say there are lots of places where its incorrect. This is one big reason why in AS 8 or 9 we want auto-generate most of this kind of code.

The populateModel() method typically calls AttributeDefinition.validateAndSet(operation, model). And that call may make some changes to what's in operation before storing it to model. For example, say a param had a value of "${foo.size:1}" in a node of ModelType.STRING. AD.validateAndSet will detect that syntax and store a node of ModelType.EXPRESSION in the model. When performRuntime() does its part, it wants to work with ModelType.EXPRESSION, not the raw string in the operation.
This isn't actually testing anything, all functions have prototypes. The bridge does no copy the prototype of the constructor over to the plugin anyway.
No, there is no ticket, but a a comment in this CR, see:

I agree, this should be handled in Menu.
Nice language.
Can we rename the trustedDialogIsShown by isVisible and so the same for ModalDialog. It useless to have to repeat the name of the class in the method and isVisible is something much more common.
it seems that the operation is succesful regardless of what happens with phone storage
Oh... and there is a typo contorls -> controls
the function should be called getTotalUnselected
Yes, the classname is a composite, We've done this while playing with names and forgot about it
We're gonna fix the names thing, as we're changing the design (including class names), but for now I'd let it like that instead of making a bigger fix.
I know that tilde plus indexOf has worse performance that indexOf only, but we'll fix it soon ;)
`#screen > *:not([data-z-index-level])`
I think this is OK, since it is a webWorker?
Great tip! Now we are protected against script injection ;) Thanks Francisco!
Is correct phpDoc: http://manual.phpdoc.org/HTMLSmartyConverter/PHP/phpDocumentor/tutorial_tags.method.pkg.html
`helpers.ui` ?
`tap` might be a better fit
Couple things for ongreeting:

 - Im not generating a uuid or anything yet. I think this will work for now?
 - I tacked "_axon_id" so that when the socket disconnect, I can delete it from the map. See `Socket#removeSocket`. Bad?
 - Maybe there is a way not to have both, the "map" and the "socks" array?
Use "/etc/appscale" instead.
Needs more newline
Now there is no limit. so the setting is broken.  I use the same code  " max personal text". only with maxsig
why would you encodeURIComponent a number?
I don't believe 'inherit' is an optional available in node 0.6.  We're still working with the older version because of stability issues.   Can you set up the pipe manually.

```
var ps = spawn(...)
ps.stdout.pipe(process.stdout)
ps.stderr.pipe(process.stderr)
ps.on('exit', function (code) {
  process.exit(code)
})
```

Otherwise, looks great.
why not use this.AREA here?
Why did you remove the character variable? 

This is needed for textfields because I don't want to implement all different keyboard layouts ;)
Happy to tweak. Roll into the same commit?
query will be inside $jsonUrlParts['query'] not $jsonUrlParts['path']
I removed the `@dev` there because it was not necessary. Stability is controlled by the root package so your project can force @dev there as long as the version matches ~2.1 it's fine, but ew don't need to upgrade to ~2.1@dev for Finder yet.
Don't define the same describe block twice, just include both specs in the same one :)
Because sometimes (mostly for collections) nodes are inserted into the DOM via `insertAfter` and not `append`. `append` will never be called in that case.
Not jslint though...

To be honest it doesn't really bother me, but I'd probably write it:
    
    if (!isModern) { return false; }
Hah, hard coded line number. :)
You need a `<div class="row">` wrapping the `span12`. You do not need `.row > .span12` at all for `span12` -- not having them achieves the same result with lesser markup.
It would be better to check against a static value. It would allow to throw if something goes wrong with `decode`.
As we are using `decode` both internally and in test, we may have a bad base64 data without noticying it.
should get_claimed not take a limit then? (just select everything we claimed)? That way ghost objects don't languish and instead get processed next time?
Any reason to have this as an string that you split later vs just having an array of strings?
__whimboo__ commented:
> ... my request still stands.

Sorry, I don't know this code. [MDN][1] [doesn't][2] [say][3] anything for me. 
I could leave a TODO here, and ask some SeaMonkey coder to say something here as a followup.
I'm really sorry.


[1]: https://developer.mozilla.org/hu/docs/XPCOM_Interface_Reference/nsIContentViewer "nsIContentViewer"
[2]: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIDocShell#Attributes "nsIDocShell.contentViewer"
[3]: https://developer.mozilla.org/en-US/docs/Full_page_zoom "Full zoom example with contentViewer"
I feel like there's some confusion here. My comment refers to the range given on line 136 as opposed to the range on line 131, not the previous describe block. The tests say "when the start time is after the current time" and "when the end time is before the current time" but both of these conditions are true for both of those ranges. In fact it's necessary for both of those to be true in order for it not to match, since no day is specified, but having separate conditions in the test gives the impression that either condition is sufficient.
Not really sure why first sized_numerous is constructed and then @numerous is used.

How about something like this?


```
@numerous.should_receive(:size).and_return(5)
@numerous.count.should == 5
```

This way also an additional fixture isn't necessary and it explicitly describes the behavior of count calling size if it exists.
In IE8, `window.FormData` is `undefined`. This condition will be `true` in IE8 if the request is not cross-domain, and if there are no files to be uploaded, so if it is possible to use an XMLHttpRequest, it will use one.
No t if you want it to default to an explicit false. However if you want a null/undefined then yes, it is redundant.
My suggestion would be to change this to $applicatoinName, in order to denote a distinction from Zend_Application or Zend\Mvc\App. When the syslog writer was originally written there was no Zend_App yet.
Why you format timestamp in all formatters and in witer for MongoDB? MongoDB must have a formatter class to format data like the type of datetime field.
Here too, remove empty line.
why not using the latest version of the 1.3 serie ?
I don't think so, because (afaik) the analyzer doesn't know how to tokenize based on dots and dashes.
I hate nesting. For that reason I suggest a style change with the condition:

```javascript
if (Tome.typeOf(val) !== 'array') {
    return;
}
...
```
Only because the default settings do not include BOSH (the layer that allows XMPP to be run over HTTP). I can indeed just keep the config template and ask the user to overwrite ejabberd.cfg in her installation, but that does not necessary make it easy.
This is a BC standard to explain in the two files users read first what the extension is as clearly and briefly as possible at the top of the README.md and INSTALL.md

We think it helps the user to have a more well rounded set of documentation to use to remind and teach them.

We can remove this duplication but we think it's a better idea to leave it in. Besides the documentation changes so infrequently and you never really know which file the user will read first, README or INSTALL. This why we use this pattern