labofsahil/github-event-dataset-2012 huggingface dataset:
I was concerned about the log file size.  Will lines containing 100,000 characters cause issues?
I followed the pattern already used throughout this file and within this class
Yes, the new item is not allowed to be in the http response if the client is in 1.37 or old.
This is the optimisation you mention, right?
You shouldn't do this manually..

You should use getTargetClusterInfo(<clustername>) and getSize()
We normally use : ForEach(*iter)
shouldn't there be a `break` here?
No, I'm not sure. My goal here was to merge the two branches (sure would have been nice if you'd built off my branch previously!) I have to be pragmatic about the time I spend on this - there will be shortcomings.
This line will create a new transport client for every user and these clients are not going to be closed.
Franklin Hu: "You shouldn't have to make changes in the generated files, we just marked scrooge as intransitive() to prevent it from pulling in thrift 0.8.0." and later "You just have to make scrooge not pull in newer version of thrift by marking them intransitive since there have been API changes between 0.5.0 and 0.8.0." (That's what they're doing in the Zipkin build.)
`$value` should be passed to `escapeHtmlAttr()` and `$key` should be passed to `escapeHtml()`.
What if `url` points to the remote file 'http://...' blocking reads on such URL's is unreasonable.
Wrong indenting
> Given the condition that interfaces are better to use than concrete types I am not sure if IList is the best choice for GetUntrackedFiles. Maybe GitItemStatus[] is better (as in string[] GetRemotes in IGitModule)?

I think `IEnumerable<GitItemStatus>` would be the best choice.
Need a clear line above this method.
Right,

I wrote it yesterday, at 4am in my hotel room Jet lagging. I'll be
surprised if that the only typo that I have...

Thanks
On Dec 13, 2012 12:14 AM, "Ran Tavory" <notifications@github.com> wrote:

> In Building Network and Battery Efficient Apps.md:
>
> > @@ -0,0 +1,18 @@
> > +Title: Building Network and Battery Efficient Apps
> > +==================================================
> > +Would you like your mobile app to run faster, consume less data and conserve battery? Do you like getting 5 start reviews?
>
> There's a typo, but don't worry, i'll fix it (start)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rantav/reversim-summit-2013/pull/7/files#r2400376>.
>
>
Many of the post modules do this.  If you do a grep for "= store_loot", you'll see them.  But really, what I'm trying to say is just do this:

	p = store_loot(type, 'text/plain', host, "#{host}:#{user}", 'hosts_localadmin.txt', user)
	print_status("User data stored in: #{p}")
Wrap text here and elsewhere please.
I'll move it back then.
@stof Thanks for catching the missing `flush()`. Updated.
s/for/for all/
Hmm.  Should these `compute` functions be renamed to be consistent with the `from` functions elsewhere.  The convention is the constructor has the most common arguments, and then `from` functions essentially have overloads, right?  So what is better:
```
var m = Matrix4.computePerspectiveFieldOfView(CesiumMath.toRadians(60.0), 1.0, 0.01, 10.0);
```
or
```
var m = Matrix4.fromPerspectiveFieldOfView(CesiumMath.toRadians(60.0), 1.0, 0.01, 10.0);
```

If this were C++, I would not make a constructor overload that takes the field-of-view arguments; however, our `from` functions are perhaps more general creation and conversion that just constructor overloads.

Doesn't matter to me - whatever you guys want to do.
这里的空格有点乱啊……用自动格式化修正下吧
Could be shortened to [UIView setAnimationRepeatCount:repeatCount != 0.0 ? repeatCount : 1.0];
I don't know what these two lines do, but they look strange. If you're enabling two different arrays, please ignore this comment.
```new_pre_authorization_url = new_preauthorization_url``` should work
Again with the `toBeCloseTo`
i will remove the function
"Multiple @global tags are allowed in the function/method DocBlock, when there are multiple global variables used in the function/method code.  Note that the tags are interpreted _positionally_ and expected to match the positional occurrences of the global variables in the code, e.g. the last of three @global tags in a method docblock will belong with the third variable in the method body that is used with the "global" code keyword."
Isn't this exactly the same as on line 192? Do you have a failing test which proves this help?
I'd put a comment in here saying what the possible values of dispatchState are, and the expected order.

The logic in this section is a little opaque to me. Maybe either simplify it or comment?
Authors are never to be set. Git can handle who wrote this.
I kept it consistent with `test_that_checks_if_the_extensions_are_sorted_by_newest` https://github.com/mozilla/Addon-Tests/blob/master/tests/desktop/test_extensions.py#L103
Compromises do need to be made when working with a group rather than alone, but I still try and keep them to a minimum. I've worked both in groups with strict formatting guidelines and in groups with lax formatting guidelines, and I've always preferred the latter, so that's what I push for.
It's utility is for template programming to stop forcing developers to create branches or tail template recursion for static arrays when analyzing types. Consider `asFlatStaticArray` from #952 as an example.
Doesn't look like it... Do you want me to update?
Yes

On 11 Sep 2012, at 21:46, sgilda wrote:

> In wicket-war/README.md:
> 
> > @@ -4,6 +4,7 @@ Author: Ondrej Zizka <ozizka@redhat.com>
> >  Level: Intermediate
> >  Technologies: Apache Wicket, JPA
> >  Summary: Demonstrates how to use the Wicket Framework 1.5 with the JBoss server using the Wicket-Stuff Java EE integration packaged as a WAR
> > +Target Product: EAP
> 
> Pete, are you saying it should not have a target product?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
а, туплю))  но мотив опять тот же: backward compatibility: кому оно не надо, тот живёт постарому.
A shared nuspec file that all packages inherit from.
Yup, should be passing. How is it failing for you?
See my above comments about specifying default values in the Configuration class.
This doesn't take into account the number of hours of the class, contrary to your comment on line 80.
After discussion, we think that we should not impose any default language and let requirejs decide for us based on browser settings.
он для каждого хедера же создаст какой-то флаг в своей таблице типа?
Да и, кстати, похоже, очищать в любом случае при входе в эту функцию придется, а не только в случае, если играется не видео.
or more in line with mpl duck-typing:

    if cbook.is_numlike(density)

this is also True for complex, but in practice this is rarely a problem.
I didn't see this comment on the github site


----- Original Message -----
From: "Carl Meyer" <reply@reply.github.com>
To: "camd" <cdawson@mozilla.com>
Sent: Monday, February 27, 2012 10:58:39 PM
Subject: Re: [caseconductor] Json import (#2)

> +
> +        try:
> +            product = Product.objects.get(name=args[0])
> +
> +        except Product.DoesNotExist:
> +            raise CommandError('Product "{0}" does not exist'.format(
> +                args[0]))
> +
> +        try:
> +            product_version = ProductVersion.objects.get(
> +                product=product, version=args[1])
> +
> +        except ProductVersion.DoesNotExist:
> +            raise CommandError(
> +                'Product Version "{0}" does not exist'.format(
> +                product_version))

this should be `args[1]`; the `product_version` variable will not exist when this code is hit

--- 
Reply to this email directly or view it on GitHub:
https://github.com/mozilla/caseconductor/pull/2/files#r494782
Can we reformat this to the new style we use?
Displays correctly in the UI. Perhaps a github issue?
> all x86_64 CPUs out there implement SSE2.
Indeed they are, as SSE2 is included into the spec  of x86_64.
Now that super is never referenced, shouldn't this class now simply implement Set<E> and add the remaining methods?

````
	public boolean isEmpty() 
	public boolean contains(Object o)
	public Object[] toArray() 
	public boolean containsAll(Collection<?> c)
	public boolean retainAll(Collection<?> c)
	public void clear() 
````
I'm curious to find out why you think a language bug is highly likely...
In 5 years of working in PHP and ActionScript, I've never come across a language bug; but it's certainly possible that I just never happened to try anything that the language designers missed. Maybe we just say "somewhat likely" instead of "highly likely"?
Yeah, it allows creating and deleting keys.
@grebenshchikov ping
> we can use this control to control

Is this poetic construction intentional?
Context should describe what you're doing rather than what you're expecting.  I would use 'initialized with controller' and 'initialized without controller' instead of 'true' and 'false'.
Точно. Для поведений поправил, а аналогичные методы самой AR-модели мне кажется лучше оставить с доступом `protected`, т.к. в целом это ведь не самая стандартная операция — изменение уровня доступа у унаследованного метода.
`:ssn` has to be separated from the other params since it is no longer mass assignable.
Ah, OK. Well it can be something more generic. It just needed to be different from sampledb.
This should be `user.username`, not `self.user.username`.
Drop this line completly
typo in delete
you could avoid having to do this extra lookup if you allow questiongroups to be passed directly
De plus si jamais l'update foirait, ça updatait quand même toute les traductions. A eviter donc.
I thought I mentioned this - I added these such that we would make sure that the numbers we were getting were actually numbers, so that we didn't display things like NaN or infinity when comparing numbers to the users. I did this just by throwing an exception if it didn't meet certain conditions that we set. I'd like to keep these in so that we don't display things on the main page that don't make sense.
Please don't do if (condition) return true, else return false. It is equivalent to return condition, which is nicer.
better to use mongodb native driver, it's much faster
If CookbookSource is intended to replace Cookbook, MetaCookbook should be named MetaCookbookSource and make sure the API on the class is still adequate to serve as fake CookbookSource.
const Interval&
It should be documented that this is only called if the animation is a transition animation type.
I think both `date_sql` and `time_sql` can be removed. Once upon a time this project supported sqlite and MySQL, and those methods performed differently depending on the current database type. Now that the project only supports postgres these methods can be removed.
Makes sense. We can leave the version in.
spacing adjustments needed
In the context of HTTP components, there are two areas that have to be considered. ...
@Priyansh I understand why you put session.keepSource to false. I was the one that told you to do this lol. My issue was with your comment ("// if passing with -s etc"). It doesn't make sense. What does the command-line stuff have to do with this error? This error happens when the "XML" can't be parsed.

I think something like this makes more sense?

    //Error occurred remove source folder
    session.keepSource = false;

What do you think?
your delay seems really hight, do you need it?
just need a reminder, I understand now
no autowire for mocking tests
all this should not removed :)
Why? This I really don't understand. `const` is not a storage class, it's a type qualifier. Thus, it having any effect on naming (and in particular global variables (I assume??)) seems completely arbitrary and weird to me.

(I know you didn't add the rule, I'm just pointing out that I think it's fairly arbitrary.)
`related` is explicitly **not** a `QuerySet` or a `Manager`. You can't call `QuerySet`-like methods on it. Avoiding that impression is a plus for the dictionary syntax.