labofsahil/github-event-dataset-2012 huggingface dataset:
Move this up: } else if

Also, you need to check for 64-bitness first, or else this won't work if the os.arch property is "x86_64".
In what way is it not necessary or inconsistent?
в список инициализации его
таб съехал
а это лучше убрать в список инициализации
Please move this to the top of the changelog file.
:+1:, changing now
We should document the fact that `createNewEntry` is guaranteed to be called only once and in case that the entry will be added. In other words, that it is side-effecting.
This fact should be documented in `mutable.HashTable`.
From what I understood, if `tryTupleApply` returns true, then the subsequent logic in `tryNamesDefaults` will choose tuple application and won't go for named or default argument applications. Right?
Ouch, thanks for the attention. It's good I made my assumption explicit, and bad I couldn't check myself. I agree it's odd that `Double` (and `Float`, yes) give such results, although clearly documented, but AFAIK the equals contract doesn't require consistent results before and after boxing. To me, it's mostly odd that `-0d == 0d` in Java. I'm confused about Scala, where that same expression can ultimately invoke (depending on boxing) `-0d.equals(0d)`.
Fixed both. Thanks for spotting them! good to merge, you think?
That looks a lot nicer.
I think this should be formatted a little better.
If the two expressions are equally simple (here meaning that they have the same number of operations) we want to return the unexpanded one. Thus the unexpanded expression is positioned first in the call to `min()`, and no further tie breaking needs to happen.
No, don't worry about the other function...that can be corrected later (as could yours, but if you submit your own work correctly then that's one less thing to correct later).
`$wrongMimeTypes` → `$wrongMimeType`
and this
```php
t('yii','ImageMagick extension<br />or GD extension with<br />FreeType support '),
```
On 04/18/2012 02:53 PM, martijnberger wrote:
>> @@ -39,6 +39,7 @@
>>  #include <iostream>
>>  #include <limits>
>>  #include <sstream>
>> +#include <limits>
> I count down from max_int to 0 for assigning id's when they are not specified. (if the mesh has no id= in xml)
>
> This to make the change cf a collision smaller. Otherwise i would need to check against a list for every item to insert.
>
I guess the question is why adding it again, as it is already including
limits two lines above.

Cheers

Boiko
I think you've just changed someone's life forever ;) I mean it, in the end he'll love you or hate you for that...
Where does ConditionVariable come from? I guess it's defined in thread, but I can't see proper require...
is this: 

    <hostanme>-<timestamp>-<increment>?
nit: trailing ; ? I really don't know enough javascript to know if it's better or worse
Commit messages and code changes are very different.
Per the docblock is this for "metadata exceptions" so `phpbb_acp_exception_metadata` is a better class name. This indicates some sort of general acp exception.
let's move the constants to the top of the file.
nu e nevoie de spații la `data = request.POST`
yeah danke :)
Ditto here, this is also a filesystem path.
Is this even necessary?
Meh, i like to state the name "link" in a linker table.. Thats just taste i guess.
I've spent so much time in plyr that I now want to spell this word "summarise". :)
Whoops, I see this is a test. Will it work across all computers/servers despite the UUID thing I mentioned?
Opportunity to encourage use of context manager and binary input:
```python
with open('nimrod.dat', 'rb') as infile:
    field = NimrodField(infile)
```
Forked as #131.
It doesn't matter in this instance, but in general for quoting a string you're better off using `{!r}` to get the `repr` version - it automatically handles the different kinds of quotes and any necessary escaping (plus it's shorter and less "noisy"). i.e. `'Unexpected time unit string : {!r}'.format(units_string)`
tensor.matrix(dtype=self.dtype) as otherwise this will create a floatX matrix, this is not what you want.
TupleKeyEqualityChecker doesn't seem to exist, and I guess it's not needed?
Yes, Django forces pypy 1.8 into an endless loop somewhere, if you could test it with pypy 1.9 that would be awesome!
Also, using a namespace dict in this way keeps the query string free of format string tokens; instead, you can just specify the key for the namespace and the element name (`nrml:riskResult`, for example).
Get some rest, but there is no such thing as "places that didn't make sense" - `var` is misleading inside of an `IfStatement`
JSHint checks for double quotes. Please make sure to run grunt before submitting pull requests.
No it's not. It's duplicating the `name` attribute, with the same value. If it was copying the target element it would do this: `id='name' name='name'`
Oh!

I basically spent all day yesterday trying to get [HTML::Data::Parser](http://search.cpan.org/dist/HTML-Data-Parser/lib/HTML/Data/Parser.pm) to work. This is the third module (and you're the third author) I patched in order to do it. I didn't even notice this was supposed to be a class method. I'm also sympathetic to the hash deref thing—after ten solid hours I wasn't thinking that clearly.

Now that I've gotten a chance to sleep on it, [RDF::RDFa::Parser](http://search.cpan.org/dist/RDF-RDFa-Parser/lib/RDF/RDFa/Parser.pm), on which HTML::Data::Parser depends, is actually a little weird. In its constructor, it takes either a string, an XML::LibXML::Document object or an HTTP::Response (I think?) object. Then it has has a `consume` method that takes no arguments at all.

Anyway, the problem with that is you have to choose the DOM parser when the object is initialized, because that's when the document initially gets processed. So if I can't, say, switch from LibXML to HTML::HTML5::Parser at that time (by passing a parameter to the constructor), I get a croak if I try to process any real-world data.

One other odd thing: HTML::Data::Parser is a subclass of RDF::Trine::Parser and sets `$RDF::Trine::Parser::parser_names{htmldata}` to itself. So *really*, the way to use it would be, if I'm not mistaken, to call it like `RDF::Trine::Parser->new('htmldata');`—no?

OK, I see what I did now. I basically copied the synopsis of HTML::Data::Parser and changed `parse_into_model` to `parse_url_into_model`, assuming it fit the same pattern. `parse_url_into_model` is completely *inherited*, and performs the dispatch operation, so the code in HTML::Data::Parser isn't even being *run*—it goes straight to RDF::Trine::Parser::RDFa (which proceeds to invoke RDF::RDFa::Parser). I was so far down a rabbit hole I didn't even notice.

As for action items: For starters, I think we should bring @tobyink into the discussion, since he wrote both RDF::RDFa::Parser and HTML::Data::Parser. As for `parse_url_into_model`, I have an idea around how the dispatcher can be short-circuited if the method is inherited and called from a subclass (whether by class or instance). That way just the network code is run against the syntax-specific parser. Also I'm not sure how much interaction has gone on between you guys re RDF::Trine::Parser::RDFa and RDF::RDFa::Parser, but I wager some considerable optimization can be done in there.
We need the continuous value. If it's not continuous, then the svec maybe very large, since we use the IDs as the positions of the svec. Say, we only have two transactions, and the IDs are 1, 100 respectively. If we don't make them continuous, then the dimension of the svec is 100. If we do, then the dimension is only 2.
Sorry about that - I know, the commits are sloppy - I was ssh'd into the build machine and copy/pasted before I pushed and just didn't look into it much. The changes were so small I figured you could just apply them if you wanted, no need to merge.
For this, and the rest of the tests, I think we should also check that there was an error in the result.
Can't just naively call `make install` (ask yourself: \_where_ are these things being installed?); must pass the installation prefix in somehow (normally `prefix=#{prefix}` but it varies by project, of course).
You can inherit from `vumi.tests.utils.VumiWorkerTestCase` and avoid having to implement `mkmsg_*` these days (we should probably clean-up the remaining instances elsewhere in the Vumi tests).
I'd prefer this didn't 'hijack' anything. A confusing name makes code less readable.
Sorry I steered you wrong, Dan!

On Wed, Sep 5, 2012 at 1:32 PM, danjung <notifications@github.com> wrote:

> In Sakai/CLE-IT/.gitignore:
>
> > @@ -0,0 +1 @@
> > +*.yml
>
> I consulted with Abe on the name, he suggested .yml. I originally had
> .yaml. I am ok with going back to .yaml.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rSmart/sambal/pull/6/files#r1537867>.
>
>
Ok. Quickly looking at the authorize stuff, it looks like it could be these tests may be runnable without the paster environment (i.e., just running the file directly `python test_authorize.py`). That said, it should be fine as is for now (I can always poke around at it later when I need to start running tests from other contexts).
Could you add the short description to the list of other short descriptions in the comments above this line?
Gotcha- I'm used to squashing all commits in a PR, but I'll split this out once the variable naming issue above is resolved- I suppose that should be a separate commit as well if it is decided to make all ```l``` into ```link```?
Make this an inner interface in ModuleAdapter and name it 'Resolver'. It's not a ModuleResolver, it's a ModuleAdapter.Resolver.
lol you are right, sorry :)
Heya! I will review this as soon as I can :)
On Dec 23, 2012 10:36 AM, "Michaël Gallego" <notifications@github.com>
wrote:

> In src/ZfrRest/Mvc/HttpExceptionListener.php:
>
> > +    {
> > +        foreach ($this->listeners as $index => $listener) {
> > +            if ($events->detach($listener)) {
> > +                unset($this->listeners[$index]);
> > +            }
> > +        }
> > +    }
> > +
> > +    /**
> > +     * Get the exception and optionally set status code and reason message. Note that according to RFC 2617
> > +     * (http://www.ietf.org/rfc/rfc2617.txt), the 401 response message MUST contain a WWW-Authenticate header
> > +     *
> > +     * @param  MvcEvent $e
> > +     * @return array
> > +     */
> > +    public function onDispatchError(MvcEvent $e)
>
> Should be protected I suppose ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zf-fr/ZfrRest/pull/8/files#r2495757>.
>
>
Should be options=None
highly suggest using lutil.isTrue(req.query.auth) as that's what we use everywhere else :)
is there anything that this can wait for, rather than just waiting for a period of time? see [https://github.com/Toura/mulberry/blob/master/spec/app/toura/model_updateable_spec.js#L74] the updateable spec for an example of `watisFor`. Not sure if there's anything we can wait for in particular, but it's generally more reliable to wait for something than to just wait a period of time.
I'm not sure we should separate creation from insertion, as when we get to native menus it might be tricky to manage menu objects that don't actually live in a menu. It's been awhile since I've done Windows native menu stuff, and I've never done Cocoa, so maybe this isn't an issue, but I could imagine that depending on the API there might be no actual "object" representing a menu that you can get a handle to; or if there is, we'd have to then potentially deal with maintaining the lifetime of that object relative to the JS proxy object. It's probably safer to treat the JS proxy objects as loosely bound--i.e., they're just descriptors rather than actual handles to some underlying menu object. You could still do that with creation and insertion separated, but then you have to have a notion of whether this object actually refers to a real menu item or one that hasn't been created yet.

Anyway, a long-winded comment to basically say "let's not separate the two until we know we need to" :)
I was trying to make it explicit that the sprite sheet is based on an 18x18 grid system -- i.e. all offsets should be integer multiples of `@jstree-sprite-size`, although it so happens in this case that the only multiples used are 0 and 1.  I can remove if you think it's confusing though.
We probably don't want the _exact_ same text as `handleFileSave()` here.  Maybe something like this?
(based on the comment on `saveAll()`)

"a promise that is resolved once ALL the saves have been completed; or rejected after all operations completed if any ONE of them failed"
Seems like this shouldn't take an ID.
Currently, I think using "Cmd" in a shortcut will emit spurious console warnings.  We should probably wait for #1004 to be fixed and make this change all at once for all Mac-specific shortcuts.
Can you add a param comment for this?
Can't we pass the UI breakpoints to this one? It's quite imperative like this. See [dbg-node.js:541](https://github.com/ajaxorg/cloud9/blob/3b3532e38af5c2b22a672aa7b9e3684eb79d7c67/plugins-client/ext.dbg-node/dbg-node.js#L541).
so this is actually the wrong fix. 

the findbugs:annotations jar contains all the jsr305 annotations and the additional, findbugs specific annotations. As the duplicate checker will not allow both the jsr305 and the annotations jar (they have overlapping classes), the right jar to use is the annotations jar. In fact the facebook base pom bans the jsr305 jar.

I know that this goes against some "we always done it the other way", but that is because the other way is wrong. :-)
No, request.user != django_user. Here, the logged-in user wants to edit a staff user and that's not allowed.

I guess we should change the variable name to make it clearer. django_user is used to represent the Django auth contrib model in opposition with the app model. Do you have a suggestion?
`rugwidth` should be here, in the definition for `geom_rug`, instead of in `GeomRug$new`.
I generally don't like post-build events, because they tend to fail the build with funny error numbers from the process invocation. Can't the native binaries be copied with the references somehow?
Derp. It looks like this waits @duration before fading the element in for @fadeTime ms, if I'm not misreading?
Or we could use this backend only for Facebook authentication and the above one for everything else (permissions and so on). Anyway, we should test and see.
I have a weird problem, I cannot set up onclick attribute even if i don't use links in a loop (just if I use two links) as it cannot be overwritten.  Why would that be?
Don't need this png, right? tabzilla's css already includes one that matches the rest of the tabzilla design. Don't want to have our own if theirs changes slightly, right?
can you just make all of these stand-alone rules?
Well considering the amount of times a user will actually have a video that is longer than 24 hours is probably very, very low, would creating a variable for `timeArr` be worth it? Seems like creating a variable for something that will happen 1 in every 1000 vidoes or something would be more of a waste than just taking this approach.

Yes, the the hours:minutes:seconds make sense when the video is over 24 hours ( shows up like 48:12:44 ).
`getPhotoCmd` is misleading. Should probably be `getPhotoSizesCmd`.
indentation needed.
Yeah, it was just in case there've been any big fixes in any tiny versions. I'll revert tho, no big deal.
I think you can combine `should_run?` and `evaluate` into one function. If not, references to `only_if` within `evaluate` should be `code`.
"identifies an individual request"
a case class would be fine. It's just that there is no need of a trait here.
Please use the public repo link git://github.com/xissburg/XBImageFilters.git
I agree that adding a C function that returns the value is the only surefire to do this. Should we go ahead with that?
Not for this function I believe since this is only called for packages and errata which has a guaranteed repository as a parent.
Maybe `https://localhost/foreman/status` might be used for this, not that it changes anything, just that we use similar path for CP
FWIW, I don't think this sort of block tagging is useful and creates burden as the file evolves. Consistency and standards should already imply the order of things.
CanSeek is set to true.  If we use ReadToEnd the CanSeek turns to false, however if we read the stream piece by piece with Read it retains the CanSeek value.
Aha! Did it!


On 4 December 2012 16:42, Henry Hadlow <
henry.hadlow@digital.cabinet-office.gov.uk> wrote:

> Hey Alex, can I edit the existing request or should I start again?
> H
>
>
> On 4 December 2012 16:35, Alex Torrance <notifications@github.com> wrote:
>
>> In app/views/root/_base.html.erb:
>>
>> > @@ -106,7 +106,7 @@
>> >            </div>
>> >
>> >            <div class="footer-inside-government">
>> > -            <h2>Inside Government</h2>
>> > +            <h2><a href="/government/">Inside Government</a></h2>
>>
>> There shouldn't be a trailing slash here
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/alphagov/static/pull/143/files#r2308686>.
>>
>>
>
>
I think not because there's no `__all__` in this module.  However, @astrofrog, I think you want to move the ``del nm,val`` to *after* this for loop.  And probably also change it to ``del nm, val, c`` to get rid of the intermediate variable.
Are the changes in this file needed?
Firing off right after the version message is ideal when you want to fire off right after a new connection, but if you just dropped a connection and just want to fire off on any other random node right away, it shouldnt matter (because its very likely that you already have one or more connections that have already exchanged version messages).  If you move it to the disconnect handler, you can just chose a random node from vNodes (given that the selected node has already passed the version message exchange stuff).
I thought this was wrong in the tests, if the input has 'type' => 'textarea' it will get this class on the div. In this test it isnt specified, but it makes it type textarea magically, because rows and cols are specified, i dont understand why it shouldnt get the textarea class if it was set magically
no need to extend the other class
"I am on" sounds like a context, not an action. When statements are supposed to be user actions, so I'd rename this to "When I visit the settings page"
ups, forgot to delete the public. the bind methods always build a concrete instance from the type definition. it is the way to /get/ the CollectionInterface
I'm aware this is shonky as anything.  Is there a reason why Action isn't a case class based on package and actionName?
remove unused code directly, please
These can be called quite a bit, and I think the value returned by `getdefaultencoding()` isn't likely to change, so let's make it the default value when the functions are defined, i.e. `def decode(s, encoding=getdefaultencoding())`.
getpaths is used also in assert_match (please see below)
I was intending for them to be private, but don't have strong feelings on it. Let me know what you think.
Unsure I did the right thing with OSGi.
Just some formatting changes thanks to JSLint.
Assuming you're gettexting everything in case we ever add SMS to other countries, could you also add these asterisks using a CSS `:before`? Then for RTL languages or other languages that don't normally use asterisks, changing this is easy.
alll `import X` statements should come before `from X import Y` statements.
yeah i guess... will do this now...
If you left this in for debugging purposes it is ok. For the final patch we will have to remove that line.
because i ran into instructions for using filter first =)
Ok now I see why you did that. I find it really tricky but it seems to allow us to work around the POST params problem entirely. We will need clear documentation on that though, there's no chance anyone would figure it out without clear explanations imo.
Shouldn't this be if CONF['debug'] == true?
the pull request looks good sans one teeny nitpick: could you update it with the LOG->Debug() statements either removed or turned into Trace() calls?  Debug() was reserved for local dev usage as it forces messages into the console, adding these over time would pollute it .  this is something that we should've mentioned in the developer guide :(
Maybe use MockBuilder? I have no clue what is happening here right now.
Looks like MainThread can be moved out of retrofit, too, it is only used as an Executor inside.
на пам’ять лишив :)?
Oh geez, pardon my english - thanks for updating. The example was actually copied from the PHPDoc on top of the class - thanks for catching it :)
Do you really need an arg here ?
I moved it up to the users section
Thats how the profile photos for User are currently stored inside of Profile, so to keep the entities clean i just stored the id instead.
khosham miyad bare hich kodoom nemizari
Update this =)
This test has made it into v0.4.x
``transport`` won't always be a TSocket here.  I think instead of wrapping the TSaslClientTransport with a TFramedTransport inside openKerberosTransport(), you should defer that to this function and wrap based on ``cassandraHost.getUseThriftFramedTransport()``.
So did mine and I got it right ...
If you register the options with group="akanda" then the option names don't need to be prefixed in order to preserve the namespace. In the config file the deployer would create a new [akanda] section and then in code you access the value as cfg.CONF.akanda.option_name.
That's much, much better. Thank you
A minor nitpick: I think breaking up sentences with code blocks in between makes them hard to read. I always have to do a double take. How about using full sentences? E.g.

    Assume that you have the following route structure:

        ...

    Then loading the URL "#/" will result in the following console output:
default value should be 0.0 (will work with ``version_compare``)
"viewing *an* apartment" is a little weird here - the goal of specifying the address in the `Given` is to use it later on. But you don't actually need an address - you can create and view an apartment in one step!

I'd refactor this to something like

```
# create apartment and click through to it (via index, probably) in one step
Given I am viewing an apartment as a guest
When I favorite the apartment
Then I should be prompted to sign up
```
This will result in writing the element in a different order than is in the xsd. We need our standard configs to follow the xsd order, and our marshallers as well. That will prevent the annoying problem of some small config change resulting in our marshaller writing out a document significantly different from what it read in, different in areas unrelated to the config change.

If users edit their config file and put stuff in a different order from the xsd, we'll re-order when we write back. Nothing we can do about that. But at least if we carefully follow xsd order, the user can avoid re-ordering issues by doing the same.
What is this sleep here for?
Please don't create a thread pool without a ThreadFactory that provides meaningful names to its threads. Otherwise we end up with thread dumps full of unprofessional and unhelpful thread names like "pool-5-thread-1".

In this case a pool seems like overkill; it will create a thread in start, leave it around for 60 secs, then close it, and then create another one in stop. To be anal the whole pool should be created in start and shutdown in stop. Otherwise you're counting on the gc and ThreadPoolExecutor.finalize() to shut down the threads in your pool. Seems easier to just use new Thread(Runnable, String);
Because it would need a populateModel()
A nit. This (correctly) returns whether the ServiceController is installed in the ServiceContainer, not whether the service is up and running, which implies started.

I'll tweak this when I merge.
Yep, let's do that.
I like it too!
Below are my ideas.
Which one is more desirable?

```ruby
time_start = Time.now
sleep 1.0
time_end = Time.now
```

```ruby
time_start = Time.now
time_end = time_start + 1.0
```
Right, this was a mistake, sorry.
Yes, it will be the `Varien_Object`, but you need to realize that it will be instance of `Varien_Event_Observer`. And in the method body it is used incorrectly: the event data should be obtained through `Varien_Event_Observer::getEvent()`, so that's how you'd get transport:
```
$transport = $observer->getEvent()->getTransport();
```

Technically your solution would work though. If you inspect the `Mage_Core_Model_App::dispatchEvent()` implementation, you'll find this:
```
$observer->addData($args);
```
It is contradictory to the concept of event subscriber and potentially can lead to a logical error, if the `$args` happen to have the same key as something within `$observer`. We could not remove this in M1 because of backwards-compatibility requirements and actually this issue is not addressed yet.

The bottom line: use `$observer->getEvent()->getSomething()` instead of `$observer->getSomething()`. We should remove this legacy logic in M2 at some point. I have fixed this particular occurrence while applying the patch.
добавь optional к заголовку, это надо для танго
`save` ?
yeap, but who updates this settings parameter? System app?
You don't need to declare there variables here. Let's move them closer to where they are used.
if (e) {
   bla bla
}
Is a callback from the importSimContacts, depending in UX we can present a progress, so far we will leave it as it is.
nit: indent (align [ and .)
That's checking if we generate already the dom for the contacts list.

Comming from an activity we may not have created the dom for the contacts.

contactsList.load .... ejem .... got a nice bug: 

if (!contactsList.loaded)

should be the correct one, dont know how it worked :P
If you change the `onViewStatusChanged` function name to `handleEvent`, you can just use 

    document.body.addEventListener('DOMAttrModified', this);

!!

http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventListener
**no need to address in this pull request**: constants regarding layout should be better addressed with height detection.
First off, I think errors should always have an explanatory message (and not just a descriptive name, although that's important, too).  The message here should include some details about what HTTP interactions were not used.

Secondly, I think it's unnecessary (and complicates the code) to pass the `allow_episode_skipping` (or whatever we call it) option to the `HTTPInteractionList` and then read it here.  That option isn't really concerned with the main responsibility of this class: finding the matching HTTP interaction to play back for a particular request.

Instead, I'd prefer if this method simply raised the error (without checking `allow_episode_skipping`, since it won't be available in this context) here; then the cassette can call this method (or not) based on whether or not the option is set.
not sure, in the past I've had loads of issues using ``__import__`` directly that I didn't have with ``import_module`` (eg: having to specify extra parameters).
hmm, actually, the ``extend`` method has a different behavior than in Pimple. But all others are the same.
- Culture?
- Use const for max
Did you test this??

This is what I was commenting on before.

If a user sends an switch that does not expect an arg it can pass as a slice command which is very confusing. Example:

razor -d -w web_arg policy add

Will result in the Slice command parsing (parse_slice!) receiving ['web_arg', 'policy'].
And vice verse if it is expecting an argument (let's say -w ARG)

razor -d -w policy add

Will result in the Slice command parsing receiving ['add']

Both will error out with errors that don't match the issue. And IMHO are way sloppy when we don't even use ARG passing on the Razor CLI bin yet (if ever). Not worth it just to use #order!
needed ByteArrayOutput/Input, and ObjectStreamOutput/Input.
~~~
name がリストに表示され、value が実際の入力値として利用されます。
~~~

~~~
`name` がリストに表示され、`value` が実際の入力値として利用されます。
~~~
Would be nice to also match the test docstring style: `"""Should have api user key with a non-zoro length"""`. Same for some other tests below
Updated: 412bb0f0b0ff161f4a414cc4fe30bce0394f7d91
Where does this `filter_tweet()` function come from?
Maybe it shouldn't be set by default at all?
I don't see ```_initElements``` in ```Path.VML``` or ```Path``` so I copied the two lines into each of the ```_initPath``` functions.  Kinda made me feel dirty, but it's probably fine.
Hm, I would leave it as iterations ... it would be inconsistent now anyway...
What about:

```php
if (!isset($metadata['contents'])) {
    return array();
}
no comment to briefly describe what this is? i noticed some other ones in this file that also don't have comments but i'm not sure if this is something you guys let slide on this project or not :)
Yeah, I meant that if you want to add return, then you probably should change the order of error checking within ```- (void)handleUnsuccessfulTicket:(NSData *)data``` only.
Oh I see, that's just the tab bit at the top
I wonder if 'clean-shutdown' would be clearer here. 'clean' could potentially mean any number of things.
dispatchKeyboardWillHide was never actually called before - only the Show methods were called.
It also contains config, and soon more stuff, so please remove what it contains, it's bound to be outdated anyway :)
because in this case i can't override an existing key, instead of doing an isset I used `+` (which is fast and underestimated IMHO)
for the readability i can use 

```
$this->packages = $this->packages + array($package->getUniqueName() => $package);
```

What do you think ?
couldn't you loop only once over tags ?
` noteable_type = note.noteable_type.present? ? note.noteable_type : "Wall"`
this keeps happening automatically, no idea why it changes.
I don't think this is a correct place for this expansion. Checking for individual files should be in the calling function.
`:text` and `:index` seem sufficient to me.  I will revisit this as I use it more :-)
At the moment the menu types are stored in the assets table with a wrong parent id and level, to fix this add the following code over here to retrieve the correct information:
```
// This is a menutype that needs to parent with the extension.
		if ($assetId === null)
		{
			// Build the query to get the asset id of the parent component.
			$query = $this->_db->getQuery(true);
			$query->select($this->_db->quoteName('id'));
			$query->from($this->_db->quoteName('#__assets'));
			$query->where($this->_db->quoteName('name') . ' = ' . $this->_db->quote('com_menus'));

			// Get the asset id from the database.
			$this->_db->setQuery($query);
			if ($result = $this->_db->loadResult())
			{
				$assetId = (int) $result;
			}
		}
```
I think it reads better if you move "properties" to the end of the sentence.
If we replace `result.pop();` by `if (result[result.length-1] == "") result.pop();`
It would allow `resolve('bar.js', 'resource://modules')` 
to return `resource://modules/bar.js`
instead of `resource://bar.js`

If you decide to keep it as-is, put a comment there too.

Otherwise `base` argument name isn't obvious. It could be a good idea to rename it to `baseURI` or explain argument values in comment.
You should add similar check before calling `pop`: `if (result[result.length-1] == "")` 
Or document the fact that `base` has to end up with a `/`.
I've seen this several times. I think factoring it into own function would improve readability:
`getItemWorkerFor(item, window)`
note, @klrmn changed the signature of CompleteRegistration().  First, Timeouts are not specified everywhere in high level code.  Second, the caller provides the URL to redirect to, rather than the Callee redirecting before invoking CompleteRegistration.  Third, the values of 'expect' are widened to handle the various states of the landing page.

I agree with all of these changes.
this code works around issue #1054 which was manually fixed once, but keeps popping up and prevents our "debug locale" from working.  it's ugly, but it works and I cannot think of a better solution.
Also, we just renamed our team to James' Rifles since it's hard in the interface to easily distinguish team pages from project pages. So having a team and a project named the same thing was hard.
can you move this up to line 30?
We need to mark the test as pending if JSON isn't available, not skip defining the test entirely.
For me: not.
The use of self.error dates back to the first revision of this file, and I couldn't find a reference to this anywhere else.
same for here. `disconnect.call(null, client)
Using a hardcoded numerical index of column positions is not needed and is fragile.  We have updated the list of commanded states columns twice so far and it may happen again (with appropriate system regression testing).  While not absolutely required here, it would be really good to write all this code so it is robust to adding new commanded states columns.
this will break for node
AFAIK the goal is to keep vars out of quotes

$line . "\n"
Ok. I thought include was a control (it's always called as a function, so where do we draw that line).
I'm assuming this format is in line with the constants defined here? http://nl3.php.net/manual/en/function.date.php

Perhaps a reference to that (or to any other format used) would be in place?
Les nombre*s*
RSS checkbox should be turned on/off...
I'm not sure about this. Mainly about such big amount of data being serialized...
Aww. I liked that.  I won't push back though.
Why would I pass the event to getDrops when all I need to know is when the entity dies?
1. Only call this if PlayerHungerChangeEvent.getHandlerList().getRegisteredListeners().length > 0

2. You can condense this down to one line: PlayerHungeChangeEvent event = Spout.get....
that IS the enum...
Remove the end dot
Nopes. On me... that's the debug stuff. Must do a rollup.
Thanks for catching!
What's the reason for the ```if @file``` guard? The API doesn't allow you to create a cuesheet without specifying a file.
this is also a dead statement as the switch is returning in all cases
If you can, please refer to the protocol implementation directly, for example: `GenDict.Dict.extend`. This allows us to skip the protocol lookup and will be faster. :)
Oops, constants are what I wanted. I forgot that uppercase symbols are
interpreted as constants. I can update the pr accordingly.

--
Sent from my CyanogenMod-powered
Android device, an open platform for
carriers, developers and consumers.
On Dec 25, 2012 11:37 PM, "Ryan Waldron" <notifications@github.com> wrote:

> In lib/asciidoctor/attribute_list.rb:
>
> > +#
> > +#    attrlist.parse
> > +#    => {0 => 'astyle'}
> > +#
> > +#    attrlist.rekey(['style'])
> > +#    => {'style' => 'astyle'}
> > +#
> > +#    attrlist = Asciidoctor::AttributeList.new('quote, Famous Person, Famous Book (2001)')
> > +#
> > +#    attrlist.parse(['style', 'attribution', 'citetitle'])
> > +#    => {'style' => 'quote', 'attribution' => 'Famous Person', 'citetitle' => 'Famous Book (2001)'}
> > +#
> > +class Asciidoctor::AttributeList
> > +
> > +  # Public: Regular expressions for detecting the boundary of a value
> > +  @@BOUNDARY_PATTERNS = {
>
> I'm curious about the choice here of class variables instead of just
> constants. Is there some deep magic I'm missing?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/erebor/asciidoctor/pull/35/files#r2501936>.
>
>
Shouldn't this be done by the configured UrlHandler somehow? Might be a refactoring for later.
Pridam tam pomlcky, je to citatelnejsie. Casy zatial nepridavam, az ked bude zaujem:).
`Twitter::SearchResults` should be encased in square brackets (`[]`) not angle brackets (`<>`).
No need for ==, like before.
Yes this header will be global. It might be a bit overkill at the moment to create a region especially on this small project. Let's see how it goes, if we use the header a lot then it may be justified.
Should also probably add some newlines around media.src = url;
Yes + entry in the `.gitignore` Are you still using sparkeshare ?
I wonder if this would be better served by just incrementing the dt and checking if it exists in trading_day_map?

At worst the next_trading_day is 4 or 5 days away.

Whereas using the full history, which is currently 15816 days, the call to bisect_right will take on average around 13-14 checks to find us the next day.

I think increments of 1 and checking if it is a date makes for more legible code in this case.
Especially when the worst case number of checks is such a small size.

It's probably a negligible optimization in either direction, so I think we should favor readability.

Going down that route, we could do also do a prev_trading_day and use those methods to do the search for closest.
This is actually a feature, but I copied `maxIdleTime` variable name from the Python client which wasn't the best idea.

Basically, with my approach, the client guarantees that if any traces are queued and `numTraces` < `maxTraces` they will be sent after `lastMessageSentTs + _maxIdleTime` milliseconds.

I personally like this approach more, because under normal conditions traces will never be sent to the backend multiple times in a short interval which could potentially happen with other approach.

For example, if I go with other approach:

* maxIdleTime = 5000
* maxTraces = 5

* t0 - record gets called with one trace
* t4 - records gets called with 5 traces
 * numTraces > maxTraces so buffered traces get sent to the backend
* t4.5  - record gets called with 1 message
* t5 - maxIdleTime >= now so buffered traces get sent to the backend

In this scenario we will only have 1 buffered trace and we will send two batches to the backend in a very short interval.
Agree, done
can't we pull that out of rails? this will bite anyone using a non packaged deploy
If this is necessary, then the translator should return false from detectWeb and let the COinS translator pick up the page on its own.
Still missing a space...
Do you mean to have this one in here both ways?
This is the Infinispan configuration that RepositoryCache uses by default for the workspace caches. Using a file on the classpath is actually really nice:

# It is easy to see the configuration for the caches.
# It can easily be copied and changed, and then used by an application
# An application can use any/all of the Infinispan configuration options to define the workspace caches, and are not limited by a subset that ModeShape might put into it's configuration file
# It's possible to define workspace-specific configurations. For example, if you had a small workspace that was used frequently, you could maybe define the max entries to load almost everything into memory, while keeping the max entries on the other workspace caches a smaller value.
# It's possible to use replication or distribution, though I'm not sure that's necessarily beneficial for workspace caches.
ok I'll merge this in and make this small change
To get the XML elements to display nicely.
Put comments *above* the logic. Same applies below.
Hello David,
Yes LOOKUP will make this faster, I'll change it.

Regards
Victor

On Fri, Jun 1, 2012 at 6:18 PM, David Bayliss <
reply@reply.github.com
> wrote:

> > +                             AttValues.number;
> > +                             AttValues.class_number;
> > +                             AttValues.support;
> > +                     END;
> > +                     // Generating class x feature domain, initial
> support = 0
> > +                     AttrValue_per_Class_Rec form_cl_attr(CTots le,
> AttValues ri):= TRANSFORM
> > +                             SELF.c:= le.value;
> > +                             SELF:= ri;
> > +                     END;
> > +                     ATots:= JOIN(CTots, AttValues, LEFT.number =
> RIGHT.class_number, form_cl_attr(LEFT, RIGHT));
> > +                     // Counting feature value ocurrence per class x
> feature, remains 0 if combination not present in dataset
> > +                     ATots form_ACnts(ATots le, Cnts ri) := TRANSFORM
> > +                             SELF.support    := ri.support;
> > +                             SELF                    := le;
> > +                     END;
> > +                     ACnts := JOIN(ATots, Cnts, LEFT.c = RIGHT.c AND
> LEFT.f = RIGHT.f AND LEFT.number = RIGHT.number AND LEFT.class_number =
> RIGHT.class_number,
>
> ,LOOKUP?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hpcc-systems/ecl-ml/pull/120/files#r918023
>
nope, if you commit to this same branch then this pull request will automatically update :)
We should rename this to <code>test_that author_links_loads_user_profile_pages</code> or something similar for better readability.
fix import here also.
These two method definitions can be rewritten as

    class << self
      attr_reader :config
    end

You can just set `@config = <config>` rather than defining a private setter method.
Is this going to work if I'm a global admin and I want to override the config for a property that has tenantOverride set to false? tenantOverride=false should only apply to tenant admins and not global admins.
Yeah, I agree that it is a bit confusing, although it has been in the codebase for quite a while. I believe disabled means that the tenant has been stopped, and can be restarted at any time by the global admin or the tenant admin. Going to the tenant will just say that it is temporarily down. Inactive means that the tenant has been deleted, which will also remove the tenant from the list in the global admin UI and basically just keeps the tenant data around as a back-up. Definitely +1 on improving its naming though.
Saw the actor later down.. but the extractor idea could still apply :)
Mostly because I wanted to see how it all fit together.  If we don't want to include it in the final merge that's fine, but I thought it useful to make sure I wasn't forgetting anything.  Drupal's router class will probably look pretty much like that.
Also, consider that when a function is named (a constructor, for example), there is always a space after the `function` keyword. Otherwise, it wouldn't be valid. I like consistency when it makes things safer for little or no effort (this is the essence of Crockford).

/steps off soapbox
I'll fix that tonight and resubmit.
also style!
Yes you're right, it makes sense.
Да, я понимаю как это работает. Собственно вопрос был не в том можно ли так или иначе а в том как это принято в Objective C.
Я просто не знаю что такое @throw или NSAssert :) 
Как лучше написать, чтобы человек увидел сообщение об ошибке, которое он сможет понять, а не набор цифр ?
зачем проверять на <0, если перед этим явно задается значение 100?
А как же найти количество процентов от количества элементов массива? И проверить что массив от 0 до 100 процентов?
> # PROJECT=ION ARCH=x86_64 PVR=yes ./scripts/create_addon SABnzbd-Suite
>  CREATE ADDON  SABnzbd-Suite
> cp: cannot stat `build.OpenELEC_PVR-ION.x86_64-devel/CouchPotatoServer-*/*': No such file or directory

you have forgot to add CouchPotatoServer's build script ?
er, sure. added back in.
И да, можешь этим не заниматься, а можешь поправить заодно, если интересно (иначе я сам потом поправлю), но этот кусок следует отрефакторить. В частности, ```reload``` не должен быть спрятан внутри метода, а вызываться перед ним только там, где требуется, а сам метод ```current_game``` неплохо бы превратить в ```scope```. Типа такого:
```ruby
scope :current_game, games.where(:status != :closed).first
```
Ask the gem author :P
Yeah I was actually thinking that those property tags were erroneously placed because I tend to use the standard JSDoc syntax (in which property tags are defined within a main class comment)... I'll add them back in. Might also be worth noting that JSDuck has extensive auto-detection of these tags, and according to https://github.com/senchalabs/jsduck/wiki/@property we can cut these comments down to just the description (although I tend to like being explicit anyway). I'll add them back in and see about adding even more docs.
Das war schon richtig so, der Addon-Präfix kann in der package.yml weggelassen werden (siehe den Kommentar neben der Zeile ;)).
Gleiches gilt bei `$this->i18n()`..
should be done after 'verifyChecksum'. (in a finally clause, to be safe).
@dahlbyk I'm not completely sure yet how we're going to deal with toggles and features from an API perspective.
I'd like to know a little bit more about what will be required to be parameterized/injected.

As `WithoutThreadAffinity` looks like a sensible default, could you please drop this for now?
Should be caught by line 1300...
I know. I only did it on a subset of functions -- namely, those that it didn't seem like a daunting task for :)
aaaahhhh…

I'll let you on this and take a look tomorrow ok?
i think the clue is to add x-arg funcs to find sources and displace the order-bookkeeping.
but wait. the solution is almost obvious.
just dont sort anything and do everything with the scores:

return unsorted sources

get scores for those

reorder on plotting using scores (and assume sufficiently aware / informed / users, also tell them)

'the plot visualizes the score sort, component index relative to unsorted sources'

get args based on exploration, relative to the still unsorted sources...
... and all should be unmessy.

makes sense??

On 29.10.2012, at 18:58, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/artifacts/ica.py:
> 
> > +        Returns
> > +        -------
> > +        fig : instance of pyplot.Figure
> > +        """
> > +
> > +        sources = self.get_sources_epochs(epochs)
> > +        fig = plot_ica_panel(sources[epoch_idx], start=start, stop=stop,
> > +                             n_components=n_components, source_idx=source_idx,
> > +                             ncol=ncol, nrow=nrow)
> > +        if show:
> > +            fig.show()
> > +
> > +        return fig
> > +
> > +    def find_sources_raw(self, raw, target, sources=None, score_func=None,
> > +                         start=None, stop=None, sort_func=stats.skew):
> Yes, so I think making _find_sources a method, making it smarter so that it handles x-arg and x-y arg score funcs and making it update the .sorted_by attribute would do the trick. Shouldn't be too much of an effort. As a result we would drop sort_sources and we would get around ica.argsort_sources_epochs_very_long_method_name(epochs) ^^ Wdyt?
> sounds good. I would however see while coding how much lines it adds or better removes :) it is a bit hard to tell without a close inspection of the code
> —
> Reply to this email directly or view it on GitHub.
>
> That lead to bugs with raw gets modified between 2 sets of epochs but that can be considered bad practice

If you warn users doing that, the raw object could have an attribute that is True if an Epochs object has already been created from it, and could issue a warning when modifying its data?
... will result in an empty active set (no active sources)
a + (np.max(a) + 1)

would be more efficient
TestIndex* : REALLY hard to understand what it is and when it could be used. This could mean it is very specialized or simply  just not documented enough. Provide example use cases in Javadoc or something
Again, it is the same issue of optimizing space vs time. The above method takes O(v+e) time. But if we decide to skip it and add more information to the protobuf, our data structure won't be minimal, and will be bigger in size than present. I don't see any clear winner in either of the two approaches, why don't we discuss this today?
Have you tested that the test suite runs under pypy? I'm OK with adding it, but at this point I can't promise that we'll treat breakages under pypy with the same severity that we treat breakages under CPython.
you should use ``:class:`` for ``Event``
it is not a class but an interface
It's how to trigger the bug, actually. The user has to have updated the password successfully first.
Java doesn't respect Scala access control, so add comment/scaladoc on all such and write that they are for internal use only.
Why is this the string representation of the address?
согласен. Странно, что я их не вынес
There is already self.Sprites.append in addsprite function in main class.
See here.  If you undo this deletion I'd expect most of your problems will go away. :-)