labofsahil/github-event-dataset-2012 huggingface dataset:
Thanks for your comment! I've fixed this in https://github.com/basdenooijer/solarium/commit/2fb0fe4cf078ea6fa3a77f5d2962afc8c6a82f51
Not identical... the execute method does not take a ScenarioResult, because the StaticHook does not run within the context of a Scenario.  The bigger difference also comes in the Java implementation of the StaticHook because it does not need an instance of the StepDef to execute.. it invokes static methods.   At the level of a feature where this is to be executed.. the "worlds" have not been built.     Indeed there is much the same in processing StaticHooks,  but because of when they execute and how they execute I thought it was worth making them a distinct entity.   Maybe I could've overloaded the execute method... but I thought they were distinct enough.
Right, not sure what I'm smoking.
A real error message! Kudos.
All the projects do this for some reason. I'm not sure why.
There's also AbstractInfinispanTest.fork()
Forgot about it, I'll give it a try.
AssertJUnit is miles better than using plain assert or other assertion tools, because it prints out proper  error messages (Expecting x found y)
you should use a setter to pass the boolean IMO instead of only allowing to enable it
`stringByDeletingLastPathComponent` is just transformative, so it should be dot syntax'd.
Just fixed, it'll be in my next commit
Не догнал. То есть в процессе работы мы можем менять параметры подключения - хост, порт, таймаут?
И после того как мы установили соединение $this->instance->pconnect() или $this->instance->connect() мы _еще_ раз устанавливаем таймаут?
Зачем?
In hindsight, maybe your change does make sense and provides for more interoperability. I just wonder if there are situations where a minor release of OGC is not backwards compatible.
This doesn't actually get used, and will be removed in a future pull request dan's working on.
this is not necessary - we'll check using expownparams - see the end of the file
use:
      ['prop$',{name:'minlen$', rules:{type$:'number'}}],
see the comment on getDefaultValues(). The same is going on here. However, some of the QueryOptions had properties with multiple values. I've modelled that as String[] in the Map<String, String[]> return type.
please avoid any code in the .h file
makes me thnk we should change definition to something else, that's weird to have a definition which contains something else.
The functions in bt_cache.c are no longer called from anywhere other than the connection code, there's no reason for them to be here -- I suggest renaming conn_cache_pool.c to be conn_cache.c, moving all of this code there, and removing this file.
if(/(\.md|\.markdown)/i.test(path.extname(filelist[i]))) 会更好一点。
Ok, Thanks, further I will keep it on mind.
implemeneted was changed in controls folder every file.  (It's better to have fixed before commit)
They might have.  I'm running v4 with VS2010 for my testing on these examples.  If this is fixed in 5, then I'll remove the second example and mention foreach.
You should put spaces between this like we would normally have in properly formatted code.
I don't thing we need the `!!`
Implementation does not match documentation.

Should be returning an `int` and checking for "auto".
Right, didn't notice that. Still, I think your function is of general use. 
Just my two cents though …
Oui, sur PHP 5.4 ça ne compile pas du tout, j'ai l'erreur suivante :
PHP Fatal error:  Call-time pass-by-reference has been removed in [...]/inc/lib/checkValidHTML.php on line 82
Why not use DetailView?
Space after comma. `element` is not really meaningful name. Maybe `contributor`?
Fix this to be always and everywhere *Login* (one word).
Should be label lowercase and then we make first letter uppercase when displaying? How it is in Django?
So this task should be then changed so that it takes care both of new users and users who left. And inform (sync) this information with everybody. How do you propose to do that?
Lets talk about this one.
Any reason not to move these into the new DecisionTreeWorker module too and perhaps rename getVumiSession and delVumiSession (or make them methods on a class or make them use the SessionManager ?). Then vumi.session can disappear entirely.
The needsDrawTool  is not just a flag; it will hold the mouse event that gets passed to the active tool if the tool needs to redraw. Thus, I set the default value to null. If you feel strongly about this, I will make the change, but I prefer to keep the default value as null.
Yep. Another option is to redefine the instance value of `compute` within `__init__`:

    def __init__():
        ...
        def blocked(*args, **kwargs):
               raise AttributeError("Use Dendrogram.compute() instead")
        self.compute = blocked
Assuming the factories are stripped from the PR, no changes to `autoload_classmap.php` should be needed.
The complexity should be in `pf::SNMP` and not the burden of the callers. Looking in _deAuthMethod here is a violation of the abstraction.

Suggestion: The call should still be ->deauthenticateMac(...) and in pf::SNMP's deauthenticateMac then the lookup and calling the appropriate technique should be performed. This also applies to `sbin/pfsetvlan`.
use urllib.splituser and urllib.splitpasswd
Maybe this part code should be put in the construct function?
Use `m_targetShip->GetBoundingRadius()` or `MaxEffectRad(m_targetShip, m_ship)`?
Yes, NULL is a C thing, not C++ (a mistake that I made in some of the Lua code).
I think this will break the current code: it sets the logger to use `::Rails.logger`, but only when the logger is not already set:

```ruby
config.logger ||= ::Rails.logger
```

(this is in `lib/ratchetio/railtie.rb`)

Instead of having this be the default, could you initialize this yourself when using the gem outside of a Rails enviornment? You have to initialize it with an access token anyway, so you could do something like:

```ruby
Ratchetio.configure do |config|
  config.access_token = 'abcdefg'
  config.logger = Logger.new(STDERR)
end
```
There is no shortage of distros. Checking for the presence of a strictly GNU core utilities command, such as dircolors, is simpler.
Thank you for pointing out!

Considering multiple fingers, we need a little more adjustment for accidental edge detection.
I'll add this feature soon.
Yes I agree - it's better.  done.
Does this use of `sqrt()` come from some argument, such as considering the Taylor expansion of sin(x)/x for x<<1?
Former! I immediately thought of Peacock, which uses this notation, but that's for 3D power spectra...
Already tried it once , but it caused some weird problems ( nullpointer , out of bounds , ... ) . Still thanks for the idea . Will change it .
This should be `size_t`.
@paulmillr 

Thanks for the missed test case && working code.  Is it alright if I use to fix this pull request?
`42` is enough, since it is already an integer (the `int` part isn't needed)
It should also be possible to send notification emails using a cronjob and management command.  We should split this logic into a separate module so it can be called from a signal receiver or a management command.
This is funny. I have exactly the same line in a pull rquest at https://github.com/andreasgal/gaia/pull/494/files#L1R289 ! :)
interestedIn 
naming conventions
On Feb 15, 2012, at 11:07 PM, AlexJuarez wrote:

>>     response = redirect(worksheet_datafile.url_for(worksheet, name=name))
>> 
>> -    if url != '':
>> +    if url != '' and url[0:7] == 'file://':
>> +        f = file(dest, 'wb')
>> +        fin = url[7:]
>> +        if fin.startswith('localhost'):
> 
> can this check be done with regexp instead?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/sagemath/sagenb/pull/31/files#r455079

Done.  Now that the line is gone I don't know how to comment on it, so hopefully you get this. :-)

Thanks for taking the time to review this.

-Ivan
Could you please remove .project from your commit?
Also - AWESOME!
Horrible gooncode.
Why don't we use the ``Object.extend`` so that the System Code Browser works better?

```
Object.extend(Global, {Class: {}});
Object.extend(Class, {
    isValidIdentifier: function() { ...},
    ...
});
```
Вот тут короткое условие для проверки переполнения, а для плюса и минуса слишком длинные.
flush делается в close()
Ну так надо в этом разбираться.
good suggestion... I'll see if I can do that cleanly.
I guess this is for Tomcat? Shouldn't be deploying this on JBoss AS.
fixed, thank you for pointing out.
Ignore previous comment. Drop the 'get_' from the name as this is a property.
i am certainly fine with using something like
 $ret = array_flatten(array_map(function() {...}, array_chunk(..)));
but most people do not share my enthusiasm for functional programming patterns. also this would be less efficient (in php) and likely php5.3 only (or very ugly). i could also just write a comment on what the loop does.
if you test USE_EXTERNAL_FFMPEG in XBMC's configure and send the correct configure flag to the add-on's configure, then everyone will be happy.
This blows up if the project doesn't have a client.
Move to CONTRIBUTORS.txt, if that's ok.
Hey @satra , my last email was written yesterday evening, but didn't reach you due to poor internet connection. It doesn't take in account your last remarks, which I am reading right now.
Done
On Oct 13, 2012 10:57 AM, "Alexandre Gramfort" <notifications@github.com>
wrote:

> In sklearn/linear_model/isotonic_regression_.py:
>
> >          """
> >          X, y, weight = check_arrays(X, y, weight, sparse_format='dense')
> >          y = as_float_array(y)
> >          self.X_ = as_float_array(X, copy=True)
> >          self._check_fit_data(self.X_, y, weight)
> > -        self.y_ = isotonic_regression(y, weight, self.y_min, self.y_max)
> > +        order = np.argsort(X)
>
> why don't you store X sorted to avoid sorting again in transform? also
> as_float_array with copy=True + a sort can make an extra copy
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/1227/files#r1835682>.
>
>
Add a test for this exception & message.
``firt column``?
чому забрав \Application\Bundle\UserBundle\Document\Use з use і використовуєш довгі імена?
You"re right, i thought the CoreBundle was a required dependency for all cmf bundles.
we could get away with removing the safeMode option I think, since emitting these events wont really harm anything unless someone is listening on them. Also a small nitpick but I would prefer emitting "disconnect" and "reconnect", something like that
Well, it is just my suggestion and it is up to you, if you do it. It is your module :) . I just point to code that I think can be improved, but decision is up to you.
Noise. Retira isso por favor
The `if` should be on the same line as the else.
This should be done first.
can you rewrite the comment to add that we need the parent size to calculate percentage values and to use that value as max instead of g_height. Same yo be done for the comments in setWidth.
why addin a object ?
``$.extend(true, $.fn.notify.defaults, options, this.$element.data());``
Un tableau des devices
I see this is the same code as line 236. It'd be a little cleaner to have a helper in util.c that did this. Maybe something like `int is_symlink(dirent *d)`.
could we please avoid imports using * (star)
Maybe we should have a CATCH_IGNORE_ALL() which 
expands to
catch (IException * e) { e->Release; } catch(...) {}
possibly logging the exception.  Not sure if I prefer that or not.
Should this only happen if (!transaction)?
Needs to match what IDirectoryIterator over the filesystem does when asked to look for non-existent files (which is to return false).
Oh, I see. I'd argue that boolean does have ordering (even if it doesn't have it implemented here).

Nevertheless, if that's the meaning, I agree it should move to deftype. (I did that originally, but then reverted).
Why limited to six digits? (My own repo has >200,000 csets so this is not an idle concern.)
Perhaps better if that's `//localhost:8000`
@rhelmer I agree but, @AdrianGaudebert had trouble getting things to work today when installing lessc locally and reverted to installing it with sudo and -g, mine has always been installed using sudo -g, this is why the docs have been changed. If there is a way to install lessc locally and having django-compressor work, that is awesome.

I assume one can symlink the local node_modules install or simply add it to the PATH as this is what is causing the problem. If we go with installing locally and adding the resulting dir to the PATH manually, the we just need to update the docs to reflect this, either way is totally fine with me.
There is some code in https://github.com/nhibernate/nhibernate-core/pull/63 for more advanced SQL query parsing. I've not gotten around to review it. I just discovered there is actually an implementation for MSSQL 2012 in there as well.
At this point, we're getting errors commonly enough due to Julia's evolving build process that I have the build deparallelized to make debugging error logs easier.  It's much simpler to see what's going on when you don't have 2-3 programs outputting simultaneously.
Presumably this becomes <?php echo $this->content; ?> now that escape is gone.
Yeah. Looks better. Thanks
Зачем второй раз подключать класс парсера, если уже подключали в строке 38
Why is there a variable already in here. Shouldn't we leave that to the user?
copy the code I wrote for all your isElementPresent.
Here you are assuming that `getId` is always the getter for the unique identifier field. This is not necessarily true for all cases.

Also, if you have `n` uploadable fields for an entity where `n > 1` and the uploaded files have the same extension then you will end up with the files name conflicts when this namer is used for both fields.
@christianv Cool fix!
I didn't want to throw an exception because if can work on one IP for fail in another one. Let's see an example:
Given ip1, ip2, ..., ipN  as Varnish Servers and ip4 is the one and only one failing, then everything from ip4 to ipN will be unprocessed.
This function is not safe for platforms where char is unsigned, which may include ARM. Change 'c' to a uchar and use 0xff instead.
probably better to move this comment into the else block, instead, or break up the } else { into }, then comment, then else {
if res.code != 500 and res.code != 200

you are also not checking if res is null before evaluating res.code
No good reason. I will revise.
Yup, that definitely sounds better.
Testing How comments look
Can you call it `title` instead.
1.9.3. 

I'll test against a some different versions in a couple of hours and see if I can make sense of this.
I'm still confused.  convertUtcToTai takes a julianDate expressed in UTC and converts it to TAI, right?  So in convertUtcToTai, julianDate is UTC.  Then you call getTaiMinusUtc on it, and that method assumes its TAI not UTC.  Isn't that a bug?
extracted the script name to a constant.
Oh so it is! Thank you - fixed in next update.
Indentation looks to be off here from the rest of the code block.
UI is not threadsafe. THis MUST have an ENSURE_UI... etc to make sure this is set on the main thread. Also, since there is no accessabilityValue property getter, we should setValueForUndefinedKey regardless of if there is a view or not.
Mobile web does not support the ti.ui.defaultunit property and I'm not sure this is something we can easily accommodate.
Right, that's the definition of vertical. Sorry; I meant should each child have the same width? It seems like the natural answer is no, but we want to make sure that there's parity between platforms.
typeof это оператор, а не функция - можно скобки на ставить. Конечно дело твое, но почему такой странный порядок сравнения(`expected === actual`)? тесты часто пишешь?
I think it's smart to define `incr` in terms of `incrby`. However, when thinking of atomicity, I think it might be better to have a set of atomic operations: `get`, `set`, `incr`, and `decr` (there will be more later, I'm sure). When you define an `incr` in terms of `incrby`, you need to make sure `incrby` is atomic – which is much harder than the reverse. 

Hence, you should redefine `incr` to handle increments and non-existent keys.
This is a bad idea IMO. You should have the adder and the remover in the model instead to do it properly.
@boegel  my mistake, the constants can be removed (these are the values defined in compiler.py)

ready to merge after using the dummy toolchain somewhere to doublecheck functionality
will be in placed -> will be placed in?
So now I see `= T.init` has disappeared. Why?
I think it should.
Do take into account that GNU tar /= BSD (unix) tar.
Quick thought: since the contract is changing anyway, we should probably change the name of the Python method from "root_enabled_history" to "root_history" as well.
Use Joshua Hampp
this one sounds somehow dangerous... in the constructor above you allow the creation with a map and here you overwrite the complete map, although you've no idea what's in it? mhhhhmmm
we can take this out, with the risk of the expected behavior of pixelFormats not working.

Perhaps it should just throw an error that you aren't allowed to change the pixel format after the video is already set up?
Agreed, 
- moved the bin/pip uninstall before `rm -rf /tmp/homebrew` (9ab68c2)
- tested the install with OMERO-homebrew job (build 35)
Why wouldn't you just use a ```for(var key in serviceManager.map())```? (and below)
think it would be good to align this code with how versioning works. and please make sure to follow the CS
can you break this into three lines like we've got the rest of the file structured
Can you please add a space before this bullet, and a blank line after it? Otherwise, the "Expressions" section gets indented as if part of this line item.
Just `jQuery`.
Let's put in some brief comments about what the extra arguments newclass, action, and populateonly are for.
You can have a case where the application invokes tm.rollback(). In that case, the transaction was not prepared
Why this? All useful text editors can specify the number of spaces a tab equals. Everyone has their own preference - we use 2 spaces at work, and 4 in a particular codebase - and tabs allow you to visually specify which you prefer.

/holywar
Keep in mind that _index returns a string, so if === is used it should be === "0"
That's cool, I just wanted consistency. and data-butter-exclude is shorter!
Admin page menu path registration
Simplifying how some default parameters are added.
I can see why you optimized this, but I wonder if it might be considered a behavior change - right now, you can change the destination name mid-stream and messages will start using a different destination. With your change, any changes won't take effect.

Like I said; good optimization but... OTOH, the risk is probably low.
Nit: add header doc to explain the different between error and failure.
I think that pipes are better than spaces. If you want, surround the pipe with spaces. Pipes make predectible documentation because is similar to phpDoc syntax and almost all developers understand the pipe as logical operator OR
did the rc files really use symbols like exclamation points and question marks?  I'm starting to wonder if I should just make the regex's overridable, so that folks can define them however they need to without us having to make the default ones super permissive.
This needs to be descoped

```
rescue ::Tinder::AuthenticationFailed => e
```
`path.join options.input, 'index.coffee'`
Good point. Didn't consider the possible conflicts. I've added a example-data.json.
I did find it convenient, most Django apps lack an example making it hard to evaluate them.
Just having to do a download + runserver was a breeze to get a good preview.
extract to util class and test
may as well use your private method getUserProfile() here
might be a little cleaner to use min and max for your context substring calculations; setting the start value should be a single line:
sub_start = max(0, offset - context_padding)

also, a brief comment to explain that you're grabbing context around the recognized resource might be helpful
It is whitebox but shouldn't be, thus the comment. That said we won't address this until we add volume support, at which point we will change the code to grab the volume info from the REST API.
NGHUTPR
It would be clearer to decorate it and put "enabled=False".
Worth making this just go through any headers that are passed for this part?
splice also returns a new value...
on a -> nous avons (sinon ca fait la chanson des restos du coeur...). Deux fois un début de phrase avec 'Et' aussi.
Yup it could be.
aslan harf jquery ro nazan :D
kojash moshkel mikhore bego ta check konam
wait, that's not right. my bad!
I believe this `<execution>` block for manifest-updated is not needed, since there is an identical one in the non-profiled part of the pom.
I'd rather avoid creating the new class and keep it simpler.  What about doing this inline here?

    team_keys = ["frc" + team["number"] for team in team_list]
Define or delete.
MPL 2.0 license blocks.
I merged in your other POD changes and just did a release.  I think i Mucked up the 0.002 release somehow, so I released to 0.003 which should be good.  Thanks again.
Good job, Gunnar! My apologies: I am not very attentive. I just thought **value** attribute was here before...
So, if you don't have any free time I can take care of this issue and will make necessary changes in this paragraph of the manual when the time comes 2.2.M1.
Sure. I can work with Splunk team on this code refactor later.
Well its original purpose was so that we could more easily implement mocking, but since we found a way around this using GLOBAL and we then aren't modifying our production code for the purposes of testing any longer I'd love to remove it.