labofsahil/github-event-dataset-2012 huggingface dataset:
`get` ottaa kolmantena parametrina arvon, joka palautetaan, jos avainta ei löytynyt:
~~~clojure
(get freqs (first a-seq) 0)
~~~
You need a helper function to solve this with recursion. But using `count` in this is just fine.
IMO, we should register the timeouts for all sites and then return an exception with all the sites that failed, rather than jumping at the first one to timeout.
I think this first line should be extracted out of the loop too:
_getAdvancedCache()_ is very cheap as it returns self, but _withFlags_ is quite costly to repeat.
Sure, you can leave it in if you want. 

Personally, I find it much easier to debug through some code if I given a log message, I can go directly to the line that produces it, rather than having to go through this level of indirection, hence why I only use this mechanism when I have no other choice (INFO or higher).
It seems that new_figure_manager (and the corresponding new_figure_manager_given_figure) is nearly identical in all the backends. Wouldn't it be better to extend the __init__ of FigureManager, so that it may be inherited?
> Is it ok if it takes me around a month?

To base it on this branch yes. There is a freeze planned for the 20th of August and I would like to get this branch in in the next week or so.

Having said this, the change I am proposing here is additive and not a major rework, so I am comfortable in making this change even with the knowledge that a better (larger) rework is on the cards in the future.
@zacc brought up a good point - "the page title may or may not be related to the page." I'd be curious to see a different solution .. but this wfm.
yeah, logic was different in the past, will remove this, thanks ;)

implicitWidth/height should be replaced by something like originalWidth/Height once we decide how get those values
I guess it should be ``` $logger->log(LoggerInterface::INFO, ...) ``` or ``` $logger->info(...) ```
We should probably end up renaming ``timeout`` to something clearer. 
Can't find the right word though: ``keep_alive``, ``max_idle_time``, ``idle_death_countdown``, ``lifespan``...
remove useless protected please
I think leaving this `:::php` here means the code formatting looks nicer in the output of the md file. Could you re-instate this?
Agreed ;) I already updated the code!
"def" is here ok, because LinkedHashMap.size requests the size from the hash map which doesn't have to iterate over all elements.

The second comment from above still holds. It should be "def size = " instead of "def getSize" (we also do have LinkedHashMap.size or Seq.size or Seq.length in the Scala libraries)
We probably will have to rely on position always: We already have no possibility to distinguish the names true, false, null from these literals and all names given as strings from string literals. So I don't think it will hurt. On the other hand, there are use cases for that, e.g. a list of elements named 1, 2, 3, ... . Of course we could go the way most programming languages go, defining some character sequences like the above as restricted, but that still don't solves the problem with string names (we would probably have to forbid them) and can hardly be expanded later.
This will throw an exception unless `console` exists (e.g. IE 6 will crash)

    if(console) { console.log('FUCK YEEAAAHHH!!!'); }
Combined: $children is no longer created in an intermediary step.
what does |e do?
you can also look how github integrates their keyboard shortcut (in commit's page)
We can rename them back later. We need to keep old images around in case something goes wrong.
Yes I think it is okay, but that can easily be changed if necessary
Do we write colors with upper case or lower case?
No, don't send anything in signal handler. Do both subscribe and unsubscribe in the task. Signal handler should be as lightweight as possible. What if many many users will be opening and closing connections? This means load will increase with number of users active on the site. We want to keep that as constant as possible.

Furthermore, you cannot send for each opening something to all other users! This will explode! Because for each send, all users unsubscribe and subscribe immediately afterwards.
I know. That's where I have the problem. It doesn't work(fullurl). Sometin missing but can't figure out what.
I did not know that. Can I keep it this way?
What exactly are you doing here?
Well nothing it wrong with it. It was changed because I had a merge conflict with this file, it was 90% different from my version and just I decided to stay with mine. In the last commit I used the buttons from the main repository, I hope that fixes most of the commented problems.
Create plain text Django template and render this message as template. Do not hard-code.
Don't use spaces around `=`.
Nothing was actually setting this. I spent a long time trying to work out if there was some magic meant to be happening here.
Don't worry about it - will pull down and experiment with writing a test for it. Will do the breaking out then.
Now I've created pull request to esprima
http://code.google.com/p/esprima/issues/detail?id=346
So later, we should add ArrayPattern initializer.
why do you use uint32 in a for loop, when the counter can only be 10? this is senseless, isn't it?
```c++
-if (unitTarget->HasUnitState(UNIT_STAT_ROOT | UNIT_STAT_STUNNED))
+if (unitTarget->HasUnitState(UNIT_STATE_ROOT | UNIT_STATE_STUNNED))
```
The total amount that will be applied as a discount.
Not sure you saw that I had completed this change. I was a little surprised
to see that the bag of words features implementation in OpenNLP is case
sensitive. In my limited experience, feature comparison is usually compared
by converting text and training data to same case. This is fine as long as
the user knows to account for MANY case permutations in their training
data, but really this could be a feature enhancement. As I look at how
clojure-opennlp wraps the java code, I am also going to be investigating
how OpenNLP offers additional capabilities with more flexible features sets
than the default bag of words set.

On Tue, May 15, 2012 at 5:17 PM, David Park <daviddpark@gmail.com> wrote:

> Good call. Oops. Will remove and update.
> On May 15, 2012 5:04 PM, "Lee" <
> reply@reply.github.com>
> wrote:
>
>> > @@ -119,3 +122,13 @@
>> >                                      (SentenceSampleStream.))
>> >                                 true
>> >                                 nil)))
>> > +
>> > +(defn ^DoccatModel train-document-categorization
>> > +  "Returns a classification model based on a given training file"
>> > +  ([in] (train-document-categorization "en" in))
>> > +  ([lang in]
>> > +     (println (str "train-document-categorization lang: " lang))
>>
>> This println should probably be taken out.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/dakrone/clojure-opennlp/pull/12/files#r827211
>>
>


-- 
David Park
(m) +1.317.270.4287
daviddpark at gmail dot com
I don't see any bug report on the repo of the library, and no PR fixing the bug either. Please report it upstream (or even better provide a fix) to allow removing this hack
I need to get only that option on ContainerTypeCommandCompleter I can change all option names to CONSTANTS if you like but i'm affraid that it will be useless. WYT ?
BTW the `<url>` syntax works here too if you want. Just need stuff like:

```
* <https://wiki.jenkins-ci.org/display/JENKINS/Git+Plugin>
```
No more number before the time unit?
This doesn't actually affect the timeout of the cache entries, does it? It looks like it's used to set the default timeout on the `BaseCache` instance, which then isn't used. Could we pass an empty dict for `options` instead?
Ik zou de class alleen doen als je `$options['class']` als optie meegeeft
"I am an inline comment." :)
I usually avoid to put magic numbers like this one, and do `str.replace('hooks_', '')` or `opt[len('hooks_'):]`, which is easier to read IMO
Why use a task at all? Wouldn't just start the async receive loop be enough?
English... 
Creates a new SetBlobPropertiesOptions with a specified BlobProperties instance.
Move this to the hook_views_pre_render()
We should have a standard for it. I think I'm changing how I do it myself too often, we would save some time with deciding. There could be different cases or two styles to choose on depending and what you do.

Agree in this case, not much use for a line just for `[`.
@jeffkaufman 
Shouldn't  this be linked in through pagespeed_automatic.a?
i would add in setup.py "plone.namedfile >= 2.0.1" and uncomment this
@ppete I'm not sure what this means

> Only when the function is specifically written for a client

**Therefore**,

1. This bullet could benefit from **an example for each case** to clearly demonstrate which method of exception should be used and when.
2. I think it's fine to include `ROSE` specific items here, but we should probably make them "footnotes", delimited from the rest of the "Good API Design" items. That way, we can keep the *generic* items on one side and the `ROSE` items on another.

**Thanks** for adding this item, though. I had not thought about documenting `ROSE` specific API design guidelines just yet. I initially added this document to just guide us as we design the improved `SageInterface` and `SageBuilder`. (This is why this document is rather *ugly* at the moment.)

**Action Item**: if you can just elaborate on this, then I can take care of formatting issues. *Just give me the meat, and I'll pack it on the skeleton* =)

---

**Example**

---

## Exceptions

#### In General

* don't force client to use exceptions for control flow
* don't fail silently
* favor unchecked exceptions
* include failure-capture diagnostic information

#### In ROSE

* **In a library function**, fail hard, e.g. `ROSE_ASSERT(false)`

   ``` C++
     // Some example
   ```

* **In a function specifically written for a client (i.e., GUI)**, throwing an exception can be considered.

   ``` C++
     // Some example
   ```
Comment about the function should go inside the function, into docstring.
These 2 macros should be removed. There was here for debug purpose.

On Thu, Oct 25, 2012 at 2:04 PM, markdryan <notifications@github.com> wrote:

> In src/device.c:
>
> > @@ -564,11 +699,12 @@ static GUPnPServiceProxyAction *prv_subscribe(msu_chain_task_t *chain,
> >  {
> >  	msu_device_t *device;
> >
> > +MSU_LOG_DEBUG("Enter");
>
> Can you just add some whitepsace between the LOG macros and the code.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/01org/media-service-upnp/pull/87/files#r1939744>.
>
>



-- 
Ludovic Ferrandis
Open Source Technology Center

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
It doesn't matter what gets raised here.  It gets caught below and we emit a more informative error.
Yeah, the OpticalPSF is one that springs to mind.  I think the best way would be to add specific copy methods to those GSObject derived classes that need more attention, as I'm doing here.  I *think* that's nicer than having a set of case-switches in the base implementation, but happy to be argued against....
I agree, fixed and pushed.
Where does $40 come in here?  The initial conditions show that the monthly is only $30.  What am I missing here?
Nevermind, I change it
I also think we should have this test for replicasets - we should probably standardize on setups with 2 nodes and 1 arbiter then.
"pos - 1" — please do add the spaces.
`<h2>` and `<h3>`
I think you should declare your variable next to where there are used. In this case for example this will let you not created 'secure' if it is unused.
Really, when do `dump(evt.data)` it returns `[object Object]` instead of a string :-/
Split long ones into multiple lines.
cleaner as a case statement
This means if you exceed the bounds of the last page, it puts you on the first page. That's kind of weird. One thing this means is that in order to get to the last page, you have to cycle through _every_ page. 

I have no idea how people use this page, so I don't really know if there's a valid use case for going to the end quickly. But if it turns out there is a valid use case, I suggest adding First and Last buttons to the nav button list. The Last button could be a special case where it does the extra leg work required.
Just for styling coherence, please add a space before each ``{`` and after each ``if``. :)
thanks for splitting the files out to be custom, so we can try to get back to the upstream defaults.
Cool, removing.
Yeah, I copied and pasted from another pluginspec... We need to have a big
cleanup of all headers, so I did not focus too much on this this time...
On Dec 11, 2012 1:33 AM, "lilvinz" <notifications@github.com> wrote:

> In ground/openpilotgcs/src/plugins/boards_openpilot/OpenPilot.pluginspec:
>
> > @@ -0,0 +1,10 @@
> > +<plugin name="OpenPilot" version="1.0.0" compatVersion="1.0.0">
> > +    <vendor>The PhoenixPilot Project</vendor>
> > +    <copyright>(C) 2012 Edouard Lafargue</copyright>
>
> I would like to stick as near as possible to the LicenseTemplate because
> that eases possible refactoring.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/PhoenixPilot/PhoenixPilot/pull/79/files#r2375729>.
>
>
Я бы на твоём месте искал сеттеры, а потом с помощью getMethod("get" + name/"is" + name) искал пару. Код получится вроде как проще.
Да, только что еще раз попробовал.
А что вас смущает?
Ok, but in the call to the get the token you're not passing the scope string, you're passing the URI of the request, which is not the scope used to get the token. So either this is wrong, or the call to manager in the rest proxy is wrong.
You have to have a constructor anyway.
I remove this method and added the suggested MockApplication class
Yeah, that works. I was just over thinking things and missing the obvious. Thanks!
Probably not; I intended this is as insurance against an empty set causing an error, but from a coverage perspective it doesn't affect anything.
> Maybe you could use the center-of-mass calculation, and then iterate over coordinates based on the size of the labeled region (thus, choosing broader peaks).

I also thought about a solution like this, but with this you are likely to suppress lines that are actually divided by more than the angle/distance threshold. The question is here if we want to use the `min_*` parameters as strict thresholds or soft thresholds. I'm in favor of the soft variant...
@mkcor use ` instead of ' to markup a function or code.
Please also add a line here to say that this is also often referred to as "cosine similarity".
Maybe put ellipsis after 2 or 3 digits to avoid platform specific doctest failures.
>    use two. I feel it is the most common use case ;) (visualization), and is
>    the fastest non-trivial version.

+1
should be `rho` not `rho_`
s/correct/precomputed/
Test is also needed.
You can omit formal parameters in forward declarations:

bool in(T const &, V const &);
в репозиторій
Just a single retry?

No logging of the exception? Just swallowing it?
I think that you should add also array literal, as the element of TypeTuple.
When you perform scope->search, if no symbol is found an error is issued. That's why, since something a symbol won't be found in the global scope, I don't want the documentation phase to stop generating object files and so on due to silly documentation errors.
Oops, I lost track of this. I'll correct it in the PR now.
Please uncomment out this line.
need to check if length is >= 0 (maybe even do nothing if length == 0, depends what Qt supports) and offset needs to be >= 0 and < size, unless it's supposed to grow if offset >= size
I'm concerned about the following scenario (forgive the pseudo-ish code):
```
control = createControl()
control.setBackground(blue)
control.disable()
```
With the current code it seems that the background will not change. The other possibility would be that the background should go back to the default (ie transparent). This is something that needs to be checked with Android and iOS.

Also, for null checking, if you call any other function that uses container_ before setControl then it'll crash. Or is that a good thing because nothing should be doing that?
I know it looks peculiar but what I am doing is sorting them in place (in the same rowsToSort array).  When the algorithm decides it wants to insert a given row (the row at rowsToSort.query(i) ) it will add the pointer to the correct slot and swap the pointer in that slot to a different slot (note that I tell it the array is 'i' elements).  I don't see anything wrong with this, and yes I have tested the heck out of it !
this return isn't really needed
I think this is still missing the point. You should add the notify directories outside of the loop and monitor them inside the loop.

The way it is now, you're adding a watch on every loop, that could last a long time. (not sure about the impact of this in the kernel).

So up there, together with the init, you add the watch, and here you only select it for changed events.

You could split into two methods: ```initINotify```, which inits and adds the watch, and ```checkINotify``` which selects the events and update retVal.
This should throw an exception, and there should a unit test that ensures there are values defined for all cases.  Otherwise when an operator is added it might be missed.
@inmarelibero I updated the JS code, and refactored it as a tiny jQuery plugin loaded in the javascript_footer block. What do you think of it ?
You don't have a public gitignore?
actually, that's getting quite long and hard to maintain under 80. Keep the plain old if statement.
@rhelmer should the date_range_type variable not be replacing the 'report' and 'build' strings?
yes, you are right. But it looks like that is not problem because we don't store false values and we always can interpreter nil as false
или вобще вынести данные в отдельный дамп (для install в том числе) и запускать только его
you should urlencode the username according to the Twitter best practice (I know it was not done previously but let's take a chance to improve it)
I find this explication a bit complicated to understand. How about simplifying it to something like : "the prefix of a set of classes to report on (suffixed with "kept", "repaired" or "error")" ?
See my note on `django_tables2/tables.py`
can we parameterize the template option?
Agree. I felt the same itch last night, but scratched it by re-running the CanvasLoader task & checking the results. Doesn't give much security against regression, though.
Ha. Yeah. Stupid vi. I'll fix that and update the pull request.

John

On May 17, 2012, at 7:43 PM, Ted Naleid
<reply@reply.github.com>
wrote:

>>
>> -        "redisPool${key}"(JedisPool, ref(poolBean), host, port, timeout, password) { bean ->
>> +        "redisPool${key}"(JedisPool, ref(poolBean), host, port, timeout, passwordi, database) { bean ->
>
> I haven't tested this yet, but I think that "i" that got stuck on the end of password is a typo.  Can you fix that, test it and let me know if it works?  Otherwise I don't have a problem with the changes you've made.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/grails-plugins/grails-redis/pull/12/files#r843094
There are all things we're overriding? Why aren't we just using them as Bootstrap provides?
Mysterious `do`. Has no use.
I'm a little confused by the usage of binary here. I think it should be start.
small typo "Method"
@stefanv Did you get a chance to check whether this broadcasting assignment replaces `transpose` and `swapaxis`?
In every other test using json, this pattern is used. See https://github.com/toastdriven/django-tastypie/blob/master/tests/core/tests/resources.py#L30

Would you prefer those tests to use Django's simplejson as well?
@kring was complaining to me the other day about code that uses "private" properties on other objects. Maybe we should leave the method and make it "public".
The tests are not deleted, it simply got reordered due to how Visual Studio generates the vsmdi. All tests that were in the build is still there. For this particular test, look on line 126 of the new file.
what if the user put values that isn't in the range of [0-1] ? We should add a range check.
In cases like this, fail early takes priority.  There is no point in the assignment operations just in order to immediately throw an error.
Similar to the comment above, what happens when you call setShadowLayer() when 0 for some of these fields?
this JS should be consistent since it is part of the harness framework itself but it's a fair point and good practice
For the first comment:  The user can still technically set it to some JS falsy value though... like 0 or empty string.  In that case, we should still set it to false.
Much better - thanks. Updated.
This should be:

    logger.error(__('Template %s is not supported by platform %s', cli.argv.template, value[p]) + '\n');
This comment is a bit ambiguous. Perhaps "Key press events are only registered when the view has focus" is more clear.
The same behavior also needs to be implemented in the next block for `TiDimensionIsAuto`
Thanks, it was getting ugly
replace this with requestAnimationFrame. Don't use setInterval for driving animation loops
In the first case, I am querying the name of the button element that the click handler is attached to and in the next case I am querying the id of the canvas that I am going to manipulate.  They happen to share a common name.
This section is intended to be a list of resources for implementors of markdown libraries, not a list of implementations.
You're totally correct - I forgot about bundles. This can easily be added, though.
According to conventions in Spring's DefaultHandlerExceptionResolver, method's name should be `handleIllegalArgument`.
make build is just running lint
grunt.registerTask('default', 'lint min');
Separator must be a forward range because it's spanned multiple times.
Mkey
>(...not sure if I should be offended)

On the contrary, I wouldn't be surprised if the others arguing for "cannot" were offended by you insinuating their English ability is inherently inferior on the basis of nationality.

>That's just how language is! ;)

How many languages do you speak fluently? :)

Anyway, this is obviously not going anywhere, so I'll just add another vote for "cannot".
First line of comment here is `The element type of $(D R). $(D R) does not have to be a range`, so this looks valid to me.
LGTM
ロガーのコードみたけど、どうしたものかなー……。

https://github.com/fluent/fluentd/blob/master/lib/fluent/log.rb
Non non, pas pour le code :)
I think I see what you've changed with the two timestamps.  Is the idea your change will only persist the local client record upload timestamp after all retries and processing are completed?
You're right.  I added the `clear().commit()` and forgot to remove the old.
I don't know about this in performTransformation. Since this method gets called in drools rules and drools can't handle ... parameters, every user need to append an array of string ids, even though he doesn't need it (in that case the array would always be empty)

WDYT?
It would be appropriate to just leave this in $config['system']['disablebeep'] even if it is moved to the notifications tab.  Also, this commit is based on an older version of this change.  2 or 3 commits have made changes to it since the version from your previous pull request went in; among those changes, the setup_beep function was removed.
ino dg bayad berin be adobe jan begin ke tamplatesh ro radif kone
man be html esh kari nadashtam :D
I think so.  The representation we decided on for "no end time" is nil
but an empty base class is a hard requirement as PHP does not have multiple inheritance
yeah, but as you are prepending it to a noun, you should use an adjective here. And the name is confusing. Classes that are not in the list are not ignored when serializing. They are only serialized differently
That's clear to me. 
But for me it's strange why ```[,\\.]``` results in the same as ```[,.]```. Why isn't it necessary to excape the dot there?
actually, I decided to call them SuiteImporter and TagImporter since that's their primary function, rather than mapping.
I think that lower camel case is good to them too.
Can remove the `:visible` pseudo-selector here
indent four spaces, with both opening and closing braces on their own line, and final comma on every line
I think we can provide a simple @trusted interface for malloc and calloc that work with a category of types (e.g. numeric types) and return a T[]. Of course this is not the place...
This is old code. I fixed it:
dc9de63d242a6ff4bccccd2de4f35e3e6816c9d1
The fact that the parser is injecting by reference was at the root of the problem that triggers INT-2626. Yes that comment needs to be removed from the parser, but the fact that we are injecting name now is exactly what we do in other routers (look at AbstractRouterParser). The only difference here is that its not a Mapping router. 
A bit of history. . . Few years ago when we started refactoring of routers Mark and I had this conversation about resolving once or resolving every time and performance tests shown that its not really that much of an improvement to pre-cache the resolved channel (in fact that is how things are done in 1.0.x).
Also, after adding 'scope' attribute (I was agains it and still am) on 'channel' element pre-caching scoped channel would be wrong anyway and since we can't know if channel is scoped or what the scoop is resolving it in time is the safest option.
However if you feel different please raise a JIRA and we can revisit this, but keep in mind that that is what we had before.
These are needed for the JavaDocs
You can actually put a period at the end using that syntax.
Same question about the $class argument here...
Use four spaces for indent.
leave this as is (don't pass in the shortlink), since this uses the shortlink id from vidly to generate the video image. if we pass in the bitly url it will break the image. (embedCode is not used on this after my pull request is merged)
Was there a problem with the readlines method?
the php type is integer
So, just to make sure I understand, what you're saying is:

```
var MyView = Marionette.ItemView.extend({
  getItemView: function(item) {
    // override default getItemView handler
    // do work to return a view
  }
});
```
Думаю эти замечания нужно в каждом рецепте с поведениями вынести в отдельную рамку, жирным шрифтом
Why return? It's the end of the function anyway
Leave `"""` on its own line.
I prefer check the locale in Context before session because if the session is checked in first, each HTTP request start the session and it is a problem for the performance if the session is started.
je ne dirais pas "un ninja de la JVM". La formation est plus orientée développeur, mais sur des sujets plus avancé (multi-threading, etc.)
You can make the fact that ZumoLogUpdater implements the NSURLConnectionDelegate an implementation detail in the .m file instead of having it in the public .h file.
See above comment.  I believe this code is correct as is.
ye rotate o scal behesh bede khoshgel she
request.path instead?
I really tried to follow the formatting of the original code but "missed" this particular point. Yes, it's a matter of taste. I totally disagree about it "reducing readability" since I honestly think it "increases readability" by being consistent.

As a note, IMO it would be really nice if Qt based code would follow http://qt-project.org/wiki/Qt_Coding_Style so that (for example) Qt creator's default settings will do, but of course, this is again a matter of taste. IMHO 8 space indentation is a waste of screen estate though.
Your use of undefined and null is brittle. What if the user sets user agent to undefined but meant null, or vice versa? There should be no behavioral difference between null and undefined.
x & y should not be removed.  This still exists in android.
According to the source, this is always `NO`.
Perhaps a pointer here that this is "using Scala's 'native' [Seq.padTo](http://www.scala-lang.org/api/current/scala/collection/Seq.html) function"?
I'm missing the link template here
http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.return.pkg.html
... and I managed to introduce an error in two simple lines of code...

I shouldn't have written them using the online interface, sorry.
This works. Will change
We don't usually name files in the framework index.js. Perhaps just lib/dialog.js
When there is time it will be restructured, currently we just can't fit it in.
This section is wrapped in a `V1` block. It's only here at all, because when I removed it in the original pull request, Walter complained and said that the D1 stuff needed to stay in because the D1 documentation was generated from this as well (which I find really bizarre because D1 has nothing to do with dlang.org, but whatever). So, it's here, and you can ignore it, because it doesn't affect dlang.org.
Since ndb already fetch results in batches through query().iter interface, I would rather do only 1 query to get all the keys, as long as it fits within the 10 minutes task execution windows, I think it would be simpler:
https://developers.google.com/appengine/docs/python/ndb/queries#iterators