labofsahil/github-event-dataset-2012 huggingface dataset:
Your point is valid, there are however 3 problems with your solution that need to be fixed before we will merge:

* you are running empty() after the strlen() check, meaning that this code will trigger a PHP notice when the key 'value' doesn't exist in $attributes.
* you are using `&&`, but our code guidelines clearly state that `and` is preferred over it.
* the check in itself says `if 0 equals the length of $value` but in natural language and logic you'd put this the other way around, which is thus prefered: `if the lenght of $value equals 0` or in PHP: `strlen($attributes['value']) == 0`.
As ajc reported , this caused issues
- the reason was that in the constructor, 'unicode' is explicitly converted to codepoint (since the former was deprecated), and thus doesn't exist
- incidentally, this makes for cleaner (and probably faster without the comparison) code
Don't leave giant swaths of code commented out like this. If it's not used, delete it. If it's something we need, uncomment it and use it.
not seeing where above are used.
zero, not 32768 I think
> We want to use the string we get from Xutf8... but not the keysym

I only meant instead of doing "xkeysym = XLookupKeysym(&xevent.xkey,
0);" in multiple places always do it right after Xutf8...
переименуй в "Warehouse List"
Or write `MRTestingJob()` which does what the `mrjob.job` code above does, and have all the test case jobs inherit from it. That's not too bad.
Now that these side effects are no longer methods, I believe you can use `simple_patch` for them now?
Spurious ``ObjectDoesNotExist`` import. It's not used anywhere within the module.
If I use constructor-closure privacy, how do I access private members of a superclass from a subclass? (I'm not sure if I understood what you wanted to ask).
ni a la mienne
These are global objects and built-in classes of Javascript in browser. The coloring of these keywords is enabled the hack of setting the lexer_filetype=ActionScript below.

If possible, please enable the support for these keywords by default in the JavaScript Lexer. The more variety of keywords color, the easier the source to read.
Sometimes I just need a little coffee. Sorry about that! I'll tidy this up in a bit.
<samp>loc_dao</samp> isn't used - just for homogeneity between the other *process* methods?
can we use a config file as an xor with respect host/username/password? see XNATSource for an example
Oh, gah, I'm sorry! It turns out I had you confused with @jsalvatier, who has been working on very similar stuff. (@jsalvatier, you'll probably find this PR interesting). The comment about MapIterBind in particular was in reference to #2710, which does add a return code to MapIterBind, and which I just merged. As you say this probably doesn't matter for you since you'll switch to the simplified API anyway, but you may want to make sure you're working against the latest master, since #2710 may have affected your code.
I missed this change - why allow prefixes on default names?
обновил перевод. в коммите будет .qm
Sorry I didn't make it clear, by `lines` variable I meant this line :)
Yes, and so is "clazz.info.parents.nonEmpty" for that matter. (If they do happen to be empty, firstParent returns Object.)
Do we consider this v -> a change breaking since it means code like `hyp0f1(v=0.3,  z=0.3)` no longer works?
It would be extremely useful to give an example of how to use this functionality.  I remember you gave some examples last year.   for example, if I want to search for flares and CMEs at the same time, what call should I make?  Is it 

result = client.query( hek.attrs.Time(tstart,tend), ( hek.attrs.EventType('FL') & hek.attrs.EventType('CM') )

Do you have equivalence and comparison operators too.

Also, I don't know what the meaning of "a" and "b" are?  Can these be comparison statements of some kind?  For example, one might want to get all the active regions within a given time range that have a reprojected sunspot area of greater than 20 units.  What would be the syntax for that query?  Is it something like 

result = client.query( hek.attrs.Time(tstart,tend), ( hek.attrs.EventType('AR') & hek.attrs.AR_SpotAreaRepr > 20 ) )

? This ability would be extremely useful, as it would allow users to target their search very efficiently.  Thanks for your help!
when does this happen? why do we continue execution?
Remove the parentheses around `expr` and add a space to the right of the equals sign.  Remove the parentheses around `expr2` in line 26 as well.
What part of the code is this?
Why is using the `abc` module bad? It is indeed global (as much as `x=Symbol('x')` is), however I do not see the black magic (maybe I just do not know the implementation).

But even if it contains magic, isn't the idea of the docstrings to show actual usage?
This is the main part of this pull request :)

I oriented on the rest of this docstring, but think we can use LaTeX as sphinx can parse it.
In SymPy the op will be something like Add, Mul, MatMul, etc.... We could actually insert a wild/variable here as well as in the arguments. I.e.

    >>> unify(Compound(Variable("an_op"), (x, y)), Compound(Add, (x, y), {})
    {"an_op": Add}

I don't yet have a nice way to expose this to the SymPy interface though.
Eventually I have used `# doctest: +SKIP`; it's not really beautiful but at least doctest succed.
It was modified to make sure that **gcd** will operates only on Integers. I removed it in next commit.
Probably dicts and matrices should be "left alone", to the discretion of the committer.
If something else deletes our file out from under us, that is an exceptional condition so I think throwing an exception is desirable.

If we do catch it, what do we do in the except block: Try again? Swallow the error? Print a warning and move on?
no need; fixed in this pull

-------- Original Message --------
Subject: Re: [karaf] demos poms; karaf plugin (#6)
From: Andreas Pieber <notifications@github.com>
To: apache/karaf <karaf@noreply.github.com>
Cc: Andrei Pozolotin <Andrei.Pozolotin@gmail.com>
Date: Fri 17 Aug 2012 08:09:39 AM CDT
>
> In
> tooling/karaf-maven-plugin/src/test/java/org/apache/karaf/tooling/features/GenerateDescriptorMojoTest.java:
>
> > @@ -45,4 +51,25 @@ public void testReadXml() throws JAXBException, SAXException, ParserConfiguratio
> >          assert s.indexOf("repository") > -1;
> >          assert s.indexOf("http://karaf.apache.org/xmlns/features/v1.0.0") > -1;
> >      }
> > +    
> > +
> > +    /** FIXME xmlns 1.1.0 validation */
> > +    @Ignore
>
> or create it if it isn't available already :-)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/karaf/pull/6/files#r1402451>.
>
I've seen this like 6x now.  It should be a helper method.
Me too. There's still more refactoring to be done in `#prepare_all_metrics`.
Cool - could this be made clearer by a comment?
Alternatively, we can have any value < 0 mean unlimited and thereby do away with invalid values.
I would just state 'With the first insert, MongoDB also creates ...'
Pushed a new commit with the punctuation change.

On Fri, Sep 14, 2012 at 6:46 PM, Sam Kleinman <notifications@github.com>wrote:

> In source/tutorial/deploy-geographically-distributed-replica-set.txt:
>
> >  primary facility (hereafter, "Site A") and one member in a secondary
> > -facility (hereafter, "Site B".) Site A should be the same facility or
> > +facility (hereafter, "Site B"). Site A should be the same facility or
>
> prefer the alternate.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mongodb/docs/pull/232/files#r1612527>.
>
>
nice cleanup. :)
same here you could use a map
Can the service list be ordered by case?
Just because something has not been done properly in the past does not mean that it has to be the same way in the future.
user not account, phpbb doesnt have accounts
No, I cannot use echo here. There is a new line, and BSD and GNU handle them differently;

```bash
echo 'test\n'
echo -e 'test\n'
```

Output in BSD:
```
test

-e test


```

Output in GNU:
```
test\n
test

```
Probably just ignore it, doesn't make sense to continue if its wrongly formatted.
Potentially have it throw an error if the `DEBUG` constant is set so you can trace it in a development environment, but on production it should just continue.
Unless nothing ever used it before in which case it can be fixed in this PR.
You should also be declaring your variables at the top of the function
This function is needed in just one place, and coupling it with validate_data would be complex and requires more sub functions to execute, I suggest we make no change to it.
If this is a phpbb function it should have phpbb prefix?
As I mentioned before, don't abbreviate when you don't need to. Explain what _n and _u are.
but in 80 columns :)
I wonder if it'd be better/safer to xor in the two halves

```scala
(l>>32).toInt ^ l.toInt
```

masking seems a bit dangerous to me since we're throwing away information (?). eg. if for some reason the longs are purely working in the upper 32 bits, then everything will mask to zero.
It could mean that we're forcing the browser to load stuff that it doesn't need to yet.

I guess it'd make things simpler. We could add this to the Audio constructor, for example:

```js
this.on('addedToStage', this.prepareUserEvent);
```
I'm not very happy to have 3 anonymous boolean parameters here. Could you please add a label to them to make things clearer ?
Yes,right , this code would be override by the Raxa/Raxa-JSS#238 pull request , but then also i changed the value in this too .
Will be important to add the inlist and notinlist filters
This was a tiny margin difference so I just updated the tolerance to a suitably small number to allow that.
FYI. This looks to be a duplicate of @bblay's  CoordSystem <-> CRS conversion.
TODO: do this
Both *add_dim_coord()* and *add_aux_coord()* currently raise an exception:
```raise ValueError('Duplicate coordinates are not permitted.')```
Why do you ```break``` here? A ```continue``` (or equivalently nothing at all) seems like a better idea as you might be able to make other factories of the cube.
return value?
Do we throw if you pass in microsecond precision?
Now I document them well right now.
Is this code still meant to be here? Why doesn't crashVoltDB solve this problem? It seems if it doesn't do what we want, we could fix the crashVoltDB method rather than redo it here?
Split this method into smaller functions.
If this is the now the main jq.ui.js file, please move it into ui/jq.ui.js for this merge, so I can take a look at the diff...
Otherwise I'll be merging blindly and we might break some functionality :/
This method seems important to our new understanding of the lifecycle of entities and may be elaborated during our coming discussion - probably warrants more documentation at some point.
Actually, this should probably be unequivocally 'return None' in the transactional case.
summary of conversation: move this part to dataset.py
This is already covered by the default map ordering in droplet.lattice

``` clojure
user=> (lte? {:a (->Max 1) :b (->Max 2)} {:a (->Max 1) :b (->Max 3)})
true
user=> (lte? {:a (->Max 1) :b (->Max 2)} {:a (->Max 0) :b (->Max 3)})
false
```
hmm, that's interesting. The initial assumption was to go with the rule of exclusion trumps inclusion, so I followed that to the extreme, accidentally. What should happen if I do `build:*:-css:+effects`? I suppose explicit exclusion trumps inclusion. I mean, at the end of the day, you're saying that `build:*:+effects` means "include no optional components besides effects and whatever effects needs to work". 

rules are:
- `explicit exclusion trumps explicit inclusion`
- `implicit exclusion trumps explicit inclusion, unless an explicit inclusion requires an implicit exclusion`
Yea, the above regex is probably the way to go.
lmf_igd_transition is defined in the sql_in file as:
```
CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.lmf_igd_transition(
        state           DOUBLE PRECISION[],	
        row_num         INTEGER,	
        col_num         INTEGER,
        val             DOUBLE PRECISION,
        previous_state  DOUBLE PRECISION[],
        row_dim         INTEGER,
        col_dim         INTEGER,
        max_rank        INTEGER,
        stepsize        DOUBLE PRECISION,
        init_value      DOUBLE PRECISION)
...
```
Where ```m,n,r``` apparently map to row_dim, col_dim, max_rank.  But then the transition function is intended to be internal and only called via the aggregate, which is also internal.

Can we have this error message actually given feedback to the user in terms that they can recognize and act on?
I will add the comments.
I assume this one will be called by the application that uses nami, and not intended to be called automatically by nami, right? Just trying to grasp the whole idea
We made another change in the way this is used and it's been pushed to auth.
This isn't exactly a cache (which implies that it's also stored somewhere else). I'd say "A place to store request tokens..."
Hmm, see if it helps to use ``on_start`` and then only import gstreamer stuff inside that context. It might be that you are initializing gevent in the wrong thread via importing it.
You should return `[]` instead of `None`.
I don't understand what this function is doing in the grand scheme of things. What problem is this solving?
(Switching to commenting on the PR rather than a specific commit--sorry about that.)

Ditto here--retries can be None and that'll cause this to flip out.
Would it make sense to also test some less round numbers? Seems like we might be missing some coverage of some common edge cases?
Any reason you took out srid support (EWKT) ?
In this case, I think a comment should be placed in the test to state that we are aware of the bug and that it has been debugged to a server-side error. So people ( like me ) don't think it's a client-side problem and decide to fix it.
Ignoring sounded unfriendly to me at first (you may wonder why it does not work). Also eliminating the assertion gives a very misleading error.
Listing contracts sounds good to me maybe a "--list / -l" option?
id_or_name method is an easier way to make sure that the GAE key is correct
Should probs do an `unset` for completeness, which also might mean its time to dry up the `_argumentBinding` part there. Could do that with an accessible.
change property access to `renderer.view.get("yields").get(key)` to avoid coupling with dot-syntax
Woops, this needs to go away.
I don't think this is having any effect, so it could be deleted.
Ditto here -- I worry about a case where there is no title for an item, as that's going to break things display-wise.
If it's possible that `this.link` could be falsy, we should adapt the component and/or template to accommodate this case. However, I'm not clear how an RSS feed item could not have a link to the original article -- is it in another property or something?
I added a window variable _startupTime in brackets.js that captures the inital timestamp, which is then subtracted here.
Oops, sorry. I added unit tests for the other previously broken ones. All the other changes to the unit test file are just to accommodate the changes to the CodeHintManager.
Should be `createMenuItemFromJSON()`
[Copying previous comment to here]

The Menus code only calls PopUpManager.addPopUp() once during initialization, so I think we'd need to change that code to call PopUpManager.addPopUp() every time menu is displayed to make this change.

I believe everything is working with no memory leaks, but if we want to make changes like this, then I think we might want to push this issue to the next sprint.
Nit: we can use `i` here now that it's not a nested loop
Here we now create an implicit dependency on the run/debug plugin. Do we want that? Why don't we pass the config name in into this function?
Just out of curiosity, why is this not initialized with an options object?
Alright. But let's create a gh issue for the removal of that hack and let's make sure this does not stay in longer than say 4 weeks.
Ok, I missed that. So how does it fail?
I think you meant:

``` ruby
s.description = s.summary
```
And from which values can I select possible languages from?
The problem is, that you will probably do something like:

```
comment = Comment.objects.get(...)[0]
```

and it is really strange to do then:

```
comment.comment
```

No?
Oh yes of course. :)
We should put this function in a shared area.
Moved to `src/editor/base-editor.js`.
I set selected to true at the end of onTrackEventMouseDown.

I want to know, on the up, if it was selected before we went in here, if it was not, I apply different logic.
you might as well use your transition mixin here
This was a testing API call within Butter that's safe to remove
Oh, I wasn't aware that gitignore handled regular expressions. I'll be sure to use a more concise syntax from now on. Thanks!
Definitely necessary! Sometimes even in FF "Error: parent is null" stops the document from being loaded!
The condition allows symbols but the error says it "must be a string". I think these should be made to match, one way or the other. There's a bigger issue, which is that the `identiy_map` configuration accepts boolean or a class as its value and `middleware` accepts a `Faraday::Builder` object. This "validation" would prevent their configuration.
Perhaps this should be an option for reload, rather than its own command?
This breaks the linking of the futures. If you want to convert a `Future[A]` into `Future[Unit]` you can use `myFuture.unit`
Remove this file from this commit
Nope, just didn't do it yet. I noticed these were left out of Avik's initial work, made a note for myself, and never got around to fixing. Will do.
Do we need this given that something similar is available in ConvergeUI? Scroll to the bottom. 

https://github.com/Katello/converge-ui/blob/master/stylesheets/footer.scss
Previously the get_new action on the controller would mark the delivered notices as 'viewed'.  The intent is to deliver the notice to the user 1 time only.  That logic was replaced with a call to 'pop_notices' above.  Will this method ensure that the notice is marked as viewed?  If not, how do we handle that?
probably good candidate for add_index
Lesse, I think I mentioned these dependencies in the PR with a reference to
the config files in our S3 bucket. Good?


On Mon, Nov 26, 2012 at 7:57 AM, Robin Kraft <notifications@github.com>wrote:

> In src/clj/fossa/cdb.clj:
>
> > @@ -0,0 +1,40 @@
> > +(ns fossa.cdb
> > +  "This namespace provides CartoDB support."
> > +  (:use [cascalog.api]
> > +        [cartodb.core :as cdb]
> > +        [clojure.data.json :only (read-json)])
> > +  (:require [fossa.utils :as u]
> > +            [cascalog.ops :as c]
> > +            [clojure.java.io :as io]
> > +            [clojure.string :as s]))
> > +
> > +;; Slurps resources/creds.json for OAuth: {"key" "secret" "user" "password"}
> > +(def creds (read-json (slurp (io/resource "cdb-creds.json"))))
> > +
> > +;; Slurps resources/s3.json for Amazon S3: {"access-key" "secret-key"}
> > +(def s3-creds (read-json (slurp (io/resource "s3-creds.json"))))
>
> May want to include a note saying that these .json files must exist and
> contain valid json data structures if you want to compile the namespace. I
> just created them by hand locally and put {} in both, just to get
> uberjarring to work.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/MapofLife/fossa/pull/33/files#r2223452>.
>
>
Because it's not an exceptional scenario, but worth mentioning. A suggestion about configuration doesn't rank as a runtime-halting event.
please remove the ``@return void`` as `void`` does not make any sense in PHP
Nope I prefer this, not sure how what you suggest would help.
Uppercase S fr String.
NONUNION should be the default to make sure we are always explicitly setting the correct value wherever we need to instead of accidentally using UNION.
clearTimeout -> clearInterval
@astrofrog - I adjusted this to now say:
```
If you're looking for "J2000" coordinates, and aren't sure if you
    want to use this or `FK5Coordinates`, you probably want to use ICRS.
    It's more well-defined as a catalog coordinate and is an inertial
    system.
```

how's that?
I see you changed these to `ParseException`s.  I'm now confused just what I'm suposed to catch if I do ``Unit('aninvalidunit')``.  If I just do that now I still get a ValueError - shouldn't it be the same type of exception whenever the parsing fails? The `Unit` constructor still says its always a `ValueError`...
Should it also update `create_error` down here, if the call to `supervisor:start_child` fails?
Why 2 empty lines here and below again?
Yes.

I know it's nit picking, but this way it seems to indicate that "none" is also a flag, independent from the other two.
actually we are quite close to getting a log interface into fig.
Can you move commas to the end of the statement please?

Cheers,
Pavan
Can this now change to just `Rtools not in path`?
What happens if you call embed_kernel in one of the parallel computing engines?
Having a couple of one-line examples here would be useful.  Just paste them from an interactive session. 

In general, for magics we try to give examples so that people can see immediately how to use the tool, without having to figure it out from the documentation.
I decided to piggyback on the --options source since it seemed very convenient.  The only thing I am trying to distinguish is how the option got set.  If it was default, that it doen't need to exist and nonexistence should be silently ignored.  If it was explicitly set on the command line then it must exist.  If there is a better way to accomplish this I will be happy to reimplment.
change from `@see InjectCore#reset` to `@see InjectCore.reset`

We need the static ref since InjectCore is used statically. See http://usejsdoc.org/about-namepaths.html
(I have no idea why they made foo.bar static and foo#bar instance based, but there ya go)
This should be 1000px (940px grid + 30px left gutter + 30px right gutter). As it stands with 940px max-width, the site doesn't line up to the designed grid at all (see screenshot: http://labs.silverorange.com/files/mozilla/screenshots/responsive-grid-issue.png).

I might ping smartell about making that 30px left/right gutter only 20px, to match the other gutters and give us a touch more breathing room on 1024px-width displays).
Nit: ♦ is visually "heavy". Could we use a lighter language agnostic separator? If no, then go for it.
I'd prefer using existing bundles here. This centralizes the use of jQuery when we need to update it (and we should).
I beat you to landing a 148 migration.
bah "Please note that method generators are not supported in unittest.TestCase subclasses.". I will just DRY it up with a helper.
`return self.IGNORE`
If I understand this codem then you need to check if string begin with given locale. If so, then this method is too magic and can be written simplier like this
```
  if (it->code().compare(0,loc->size(),*loc))
```
or if you add it to own method, it will be even more readable
Not a problem. I admit, it is kind of straining to defend my code, but I knew about that before sending the pull request ;-)
It actually forces me to think even more about the design decisions I make, which is a good thing.

About `TryParseAndVerify`: To me it looks like there was some kind of misunderstanding. The `TryParseAndVerify` method I proposed as an alternative wouldn't have thrown *any* exception. There wouldn't have been any `HttpResponseException` in that code. But I still think it shouldn't be an extension method but a first class citizen in the form of a method on `ResourceLinkVerifier`. Why? Because ResourceLinkVerifier implements the two interfaces that the `TryParseAndVerify` method would further glue together.
What do you think?
I followd Node.js' `child_process.spawn` because interface of some components of React looks similar that of Node.js.
http://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options

Isn't similarities with Node.js needed?
Should I keep the 'Has session' part then? I'm thinking that could be useful if one would want to check if the page starts a session or not.
this is what I thought when talking about other helpers. Currently, using Twig in Silex is possible because most extensions are in the bridge. But if someone tries to use the PhpEngine with Silex (and someone did [at some point](https://github.com/litek/SilexPhpEngine/blob/master/src/SilexPhpEngine/PhpEngineServiceProvider.php)), he will not be able to access the same features as all helpers are in the FrameworkBundle. Moving them to the component would be logical when we look at the similar changes you did in 2.1 (for listeners and collectors for instance).
But anyway, it should probably be discussed elsewhere than on this Form PR
ah, you mean for the collection type with an empty collection ?
I would call it ``CacheItem``
This should not be in the Upgrade file. It is not a BC break
How do you "tell" people?
Not sure I understand what the purpose of using ~~ here is.
Is the Rakefile above run before webyast install? There is no check here whether this log dir exists, would it not be better to fail the rails app right here if the dir is missing?
custom view which means I don't get the ability to set font or other normal text view properties in storyboard
{c||c|c|c}应该为{l||c|r}
Ah ok. Cool.
There are 4 main cases here, depending on A and B having an alpha channel or not.

1. line 1370: ! has_alpha_A && ! has_alpha_B

If A and B both don't have alpha, then they must have number of channels 3 or 4. Because we allow only for such images not to have alpha specified. Look at line 1355. Now we can have 4 cases depending on A and B having 3 or 4 channels. (A,B) can be (3,3), (3,4), (4,3) and (4,4). If R is not initialized we initialize it by setting nchannels = 4 and alpha_channel = 3, because of the 4 cases we just mentioned. If R is initialized then it must have 3 non-alpha channels and an alpha channel at position 3: "if (non_alpha_R != 3 || alpha_R != 3) { return false; }", line 1378.

2. line 1371: has_alpha_A && ! has_alpha_B && alpha_A == channels_A - 1

If one image does not have an alpha it must have 3 or 4 channels. B does not have alpha so it has either 3 or 4 channels. But in either case it has 3 non-alpha channels. We know that A and B have the same number of non-alpha channels since we checked before:

line1353:if (non_alpha_A != non_alpha_B) { return false; }

So now we know A has 3 non-alpha channels, because B does too. But we also know has_alpha_A, that is A has alpha channel, so it has 4 channels in total.

Now we have two cases based on R being initialized or not. If not we initialize it, but if it is initialized then it better have 3 non-alpha channels as A and B, and an alpha channel at index 3. This is line 1378: if (non_alpha_R != 3 || alpha_R != 3) { return false; }

3. Line 1372, similar to case 2.

4. Line 1380: has_alpha_A && has_alpha_B && alpha_A == alpha_B

If A and B both have alpha specified, then they better be at the same position: "alpha_A == alpha_B". If R is not initialized we do it, but if it is then it better have the same number of non-alpha channels as A and B, and alpha channel at same position as A and B. 
That is line 1386: if (non_alpha_R != non_alpha_A || alpha_R != alpha_A) { return false; }
We use non_alpha_A and alpha_A but we could we have also used non_alpha_B and alpha_B, since we know they are equal.
That would be inclusive of 1.2.0 then, so I thought "<" was my only option to say "everything under 1.2.0".
This is where a get_stats() in the device_api structure should be used.
Within the get_stats() would be device specific sub functions such as get_temp(), get_freq() etc, which would place the results in the public structure cgpu_info. Any new metrics for a device should be added to that.
get_stats is called in the watchdog thread.
API accesses cgpu_info.

IMHO :)
This import is not actually used.

Would you mind removing it in this pull request, as well as 
    from cms.utils.page_resolver import get_page_from_request, get_page_from_path
and
    from django.contrib.auth.models import User 
?
This just makes it easier than to reopen another pull request :) Thanks
IDK. I tried to clear all that stuff up but I missed some. I will make another pass today.
Ah c'est ce que je pensais xD Beaucoup mieux ta version ;)
Same as above I just want to look at the logs once in production to see how much cache is used.
`getVisualizationsByTimeCreated`?
This should be Object.class. 

ManagedReference will likely not even be available to the deployment, and when is returned from the lookup will never be assignable to ManagedReference.
-1 for the outputting value, see https://issues.jboss.org/browse/AS7-5800?focusedCommentId=12728050&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12728050
Fixed. I've tried to get rid of all CGL issues in this file.
тьфу ты ошибка должно быть template.config :(
But this is not part of this pull request. Can be fixed in a followup.
The guideline for filename is to convert addAlarm to add_alarm
this won’t work. If the current time is 21:05:52:
* `%r` gives `09:05:52 PM`;
* `%R` gives `21:52` (seconds are omitted).

Unfortunately there’s no C mnemonic for the short time format (without seconds). I propose:
* to use `shortTimeFormat` rather than `timeFormat` in `shared/locales/date`, and make it either `%I:%M %p` (en-US) or `%H:%M` (all other locales, by default);
* to look for all l10n resources where I’ve defined an application-specific `timeFormat` and replace it by the shared `shortTimeFormat`.

@lissyx, would that be okay with you?
Also don't forget to run |make lint| :)
Ok let's wait for the UX people confirmation.
Thx!
It works too. Why should I use /shared/ directly and create an other copy of the files?
nit: we’re using single quotes by default on Gaia, mostly because we’re using `gjslint` as linter.
Remove this if we are not going to sync status with SoundManger
Hi @jmcanterafonseca,

can we somehow group both checkFbButtonsOnline and checkFbLinkOnline, seems pretty similar to me.

Thanks.
`getAllContactsSync`
I had no idea if you indent that second expression like that.
I hope that precedence is right, because the problem was that in the body of the closure assignments were surrounded with ( and )
When i Put the precendence lower than the closure itself would be bracketed.

But the closure cannot be used like
$result = (function () {
})('parameter');

did this change in 5.4?
Why create files on disk? Take a look at how the other tests work (the MockFileSystem). If that doesn't work for this test then I'd move this to the functional tests.
To be more clear we could introduce a variable `currentTrackId =  1` and use it here and in the first test.
Please add unit test if you can think of a relevant one :) I know this module isn't really covered yet. But I try to make a habit of at least covering all new additions
Changed ;)
Line 527 (the line you mentioned I modify in the previous comment) is within one of these functions, so I am confused whether you want me to modify them or remove them.  

Without these functions, how do you cbind an Array{DataFrame,1}?
You almost never want to use a bare except. At least do `except Exception` so that you don't catch KeyboardInterrupt's. Also, I don't quite get the purpose of returning a tuple here. Why not just re-raise a specific Exception and then handle that Exception in the view?
IMHO, use params as argument may not a good idea in base_utils module. Because client test hasn't a existed params variant for us, we must build a param by ourselves before init this class.
This means the directory must be writeable, right?  That will be important to mention!
Can this indentation be cleaned up?
trailing whitespaces need to be stripped
This only enqueues it in the workQueue. The first thing that happens when it is dequeued is to check if has already been added, see a few lines above.
According to your show action the view wouldn't be rendered if @photo is nil, so what's wrong with using it in the view?
It is a default options of choose. I'm not sure if you need a pre-prepared list of tags
anyways -- I do not see any evil intent in above two lines -- it is not even a known script which is tested -- just some innocent static content.  Although nice to have sample lines but they should be pointing to some filter to be matched
should we validate that the value is actually an IP?
This closing `</dd>` is unnecessary since you deleted the opening one at the top.
It looks better, but still there is two things I don't like:
1) it is not milestone, for me it is error, warning is also acceptable, but for me it is error due to 2)
2) It is not "xterm exited" because you run it on background. So return code is always 0, only exception is when system failed to run it ( e.g. fork failed), then it return -1. That is quite useless value if you read it from blog. So I think that if exitCode != 0 you should check what is in errno and properly translate message into log ( it makes us easier to recognize what happen there ). see man pages for error handling - http://linux.die.net/man/3/strerror
Ok, now I see that it's not really a module, but still not sure it's a good enough reason to don't follow conventions. Although I'm ok with having it as is if you feel very strongly about it (in that case probably .jsm would make more sense though)
Does adding something to `modules` mean it is automatically available with the `@` prefix, or do you have to include the prefix in the options below?
ah it looks like we throw errors when the worker is dead, so throwing errors seems inline :)
I find following a lot easier to follow:

```js
let node = item.context.reduce(function(node, context) context.adjustPopupNode(node), popupNode)
worker.fireClick(node, clickedItem.data)
```
this is representative of the change.  no more ad-hoc validation of parameters inside wsapi implementation.  the argument specification in exports.args expresses expected type.
@lloyd - I am trying hard to think of a case where this *should* return a "mustAuth" and the user needs to enter their password on the client, but so far I am not thinking of any.  Do you know of any?

What about this situation:
1) The user has an account with three addresses, one primary and 2 secondaries.
2) The user resets their password and verifies the first email address.
3) The user logs out of Persona
4) The user logs in to persona using their primary address.
5) The user selects the unverified secondary.
6) I *believe* at this point, the user should have to enter their password, but then it will ship them over to the "verify your address" screen.
7) I'm not sure how this really works currently.
Instead of passing a callback which handles interesting URLs to prettifyLine, I am letting aggregator.parseErrorLine handle them directly.
You should already be at 123done, does the `get` need to be done?
Cool cleanup, I like getting debug locale out of the `BIDI_RTL_LANGS`.
I get an error using this on OS X 10.7.
> Any observer we register we have to remove.

Yes, this is obvious. But when to remove? 
On startup of the observer code? On application shutdown? On entering PB mode .... :)
We should assign a variable to the locator at the beginning of the class:
<code>_results_locator = (By.CSS_SELECTOR, '#content-main > article') </code>
and use the variable here:
<code>return self.selenium.find_elements(*self._results_locator)</code>
I get your point. 
The fact is that I didn't yet find the good workflow to have a "patch" approach for this development.
combining the powers of `Array#take` and `Array#sample` you can shorten it and get rid of `max` and `rand` variables! :)

``` ruby
reply(results.images.take(8).sample['unescapedUrl'])
```
http://www.ruby-doc.org/core-1.9.3/Array.html#method-i-take
http://www.ruby-doc.org/core-1.9.3/Array.html#method-i-sample
This is a really, really generic name for a fairly specific function.  If you are going to export it as API from other classes (eg: compiler, resource) you should name it something more ... obvious.
it "raises a TypeError when passed true"
If the child process has already exited, Process.wait will raise it. Note that the ri docs for Process.wait say it will raise a SystemError but actually, Errno::ECHILD < SystemCallError < StandardError (tested under 1.9.3 and 1.8.7). You can verify this by simply calling Process.wait from irb.
`i--` is not an expression in Go, so it would make things more complicated..
I'll still prefering Yoda conditioning because:

a) Is only one character the difference to make a bug and may you can't see the difference in a visual review.

b) The project use asignements in conditions so enable that alert in the IDE may throw false positives
Hmm, this isn't what I was experiencing in my testing. The $input->getValue() runs the filters on the object that is being merged from, and then a few lines below filters are merged... So when this Input's getValue() is called, the filters are run yet again. 
Still seems to me that the actual raw value should be merged since the filters are always being run on getValue().
Please use `sha1`.
Why only null check here? What about empty string? Just not possible?
implemented b.): listening for click events on html a-elements and doing a preventDefault()...

will implement an example using backbone router example soon...
yes, well spotted, I put it in in case I missed something but I think we can remove it now the tests are passing.
Out of curiosity, in this route and the one for the 'down' command, why is the node name in the URL and not part of the POST?
shouldn't be a space before the () here
this is practically self explanatory, but maybe add a short library-level dart doc?
you should revert this, as it forbids copying the value by reference whereas public properties allow it
Is there a quicker more ruby-esque way to do this?
Damn, I forgot creating a Sniff for checking that ;-)
Seems like support for running in ezpublish5 context is removed here, as in before the change it would detect this and use composer files from ezpublish5 root, as that would be where these things are stored right?

So maybe this should be:
´´´´php
$baseDir = __DIR__;
if ( stripos( __DIR__, '/vendor/ezsystems/ezpublish' ) !== false )
    $baseDir = str_replace( '/vendor/ezsystems/ezpublish', '', __DIR__ );

$legacyDir = null;
if ( file_exists( "{$baseDir}/vendor/ezsystems/ezpublish-legacy" ) )
    $legacyDir = "{$baseDir}/vendor/ezsystems/ezpublish-legacy";
´´´´
You should enclose inline code with backticks e.g. `@PersistenceContext` or `web.xml`
The html based re-direct is gross, as it requires a 2nd request to originate from the client. With the RichFaces mobile approach, we've got to great pains to reduce the number of request made by the client in order to improve the responsiveness of the application.  It's a shame to have to introduce an additional request just to accommodate a spec problem.

Can we instead look at getting the other quickstarts to use a index.jsf welcome page?
If you indent each of these items by 4 spaces, it will properly format the list such the follow up paragraphs are indented with the list.
Sure can, after a tiny fix to the makefile.
i18n のファイルにまとめる、という手もいいかも！
Is this the right place for this method? I don't like the way it passes in the page object. 
If it were in `base.py` then it'd have selenium/the page already.
But I'm not really clear on what should be in `base_test.py` and what should not.
here is sufficient to use "/about/" without /en-US
Probably need a seeking event too? Does that exist?
Um, nope... no space between curlies and parens. Please review https://webmademovies.lighthouseapp.com/projects/63272/styleguide under "Exceptions"
Hm, I don't think that works either.
For this particular call we are resetting the documents position from (0,0) to where it was before we switched from another document.
Modifying MARC is fine with me. There is actually a subfield for [700 tags](http://www.loc.gov/marc/bibliographic/bd700.html) for a [relator code](http://www.loc.gov/marc/relators/relaterm.html) ($4) but it doesn't look like edited volumes ever use it.
Invalid href, needs a protocol. Also, you should be using MarkDown.
nah. don't do that!
Ok, but if I happen to have two files `foo.1.png` and `foo.png` in the same directory, with this 'blind' substitution I'll always get `foo.png`, even when I request `foo.1.png`.

The fun part is that we should also know where to check, but at the moment we don't; so in my opinion we should have the `options` object to accept a `static` key, which handles static files through `connect.static` or `express.static` (based on the server used).
In this way, we set up static file serving for the user, and also know where to check if files exists before rewriting URLs.

This, by the way, is the only place where we should check for file existence.
awesome, good to know. I've been giving the db more work than necessary
I don't agree, also a compound. Hyphened because _paginaopties_ is somewhat of a vowel clash.
Incorrect order here.
I added a `notEmpty` and `notContains('.')` check. The `moduleId` will never contain slashes, if it does it won't hit the REST endpoint and we should probably catch this 404 in the UI.

I implemented a lazy-loading cache where docs get cached the first time they are requested and then served from there. This is then using the same strategy as the configuration.
Actually, /api/configuration will be renamed to whatever the tenant is so it's using that.
Should be login ID.
I don't think we need to make an object for that. They are already private. I just don't like typing more for no obvious benefit. But feel free to leave it in.
missing parens: ``disable()`` and ``enable()`` :-)
Could you extract the selector into a constant?
Undocumented hack why not just called Monument or models.Monument ?
Waarom doen we dit hier?
This should probably be `SiteFilesMouseDoubleClick` to fit the existing code
Space after `(array)`.
I am in complete agreement, and regularly strip them. Unfortunately this is probably one of those areas where it would have to be done wholesale and would probably crop back up every time the license was updated. Besides, optional style rules that allow people to write less and fill more space have always been so popular that I doubt there's much chance of it going away.
а строгая типизация - это добро :)
Не вижу проверки на отрицательное значение. Или она тоже не нужна - всё равно вывалится с ошибкой при попытке иницализации indexes?
посмотри на описание arc4random_uniform(), оно в этой задаче лучше подходит
; лишняя, компилятор не ругался?
Так чем тогда это будет отличаться от самого простого варианта, в котором просто хранятся числа, которые уже меняли, и если новое число совпадает с тем что уже было — генерировать другое. 
Это фактически тот же самый вариант, так как при генерации массива с уникальными случайными значениями — будут повторы, которые надо будет пропускать и мы вернемся к тому с чего началось.
If it's really only in this view, I suggest creating another instance variable in the controller which retrieves the assignments in the desired order and use that variable only here. We may only need to do this if the current user is an admin too. Please also write a functional test for this and assert that this new variable is in the :assigns hash if and only if the user is admin. Thanks!
Are you sure this will work on desktop Linux?
There is a but of an issue here because while the API requires a feature ID, the context menu itself should work regardless. Perhaps we should make our code more like the framework and seperate the API from the display code
awesome, please disable it

On Mon, Oct 15, 2012 at 3:39 AM, sergue1 <notifications@github.com> wrote:

> In boilerplate/tests.py:
>
> > @@ -161,7 +185,7 @@ def read(self):
> >              self.assertTrue(urlopen.call_args_list[1][0][0].
> >                              startswith('https://api.twitter.com/oauth/access_token?'))
> >              self.assertTrue(urlopen.call_args_list[2][0][0].
> > -                            startswith('https://twitter.com/account/verify_credentials.json?'))
> > +                            startswith('https://api.twitter.com/1/account/verify_credentials.json?'))
>
> I would comment out or disable the account/verify_credentials.json call by
> default:
>
>    - This call is not necessary for login. Applications get Twitter User
>    Ids in the previous step as part of the OAuth workflow. One HTTP Request
>    less makes login really faster.
>    - OAuth calls are not rated <https://dev.twitter.com/discussions/1196>and allows thousands logins. However the account/verify_credentials.json
>    v1.1<https://dev.twitter.com/docs/api/1.1/get/account/verify_credentials>service has a limit of 15 calls in 15 minutes. This can break
>    gae-boilerplate twitter login unexpectedly.
>    - No need to maintain twitter API versioning.
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/coto/gae-boilerplate/pull/169/files#r1839313>.
>
>
I'm really not so sure about this default value. The package can include a default sound file or this value can be just empty so only the one who cares about the sound can activate it.
Per previous comment, something like `getAllUsernames()` is more self-documenting.
This should make updating to 3.2 / 4.0 much, much easier
Catching errors generated in other middleware :)
Shouldn't `concat` be spelled `append` like `++` is for haskell?
I followed the lead of jira.coffee that used 'latest' already. Reviewing the Atlassian docs it seems that using '2' as the version is correct now that it is out of alpha, so I'll adjust the patch.
ok perfect, .
Ok, I restored that.
The reason I did it like this is so the projectors computed last would be at the end of the list, i.e, if you do

mne_compute_proj_ecg.py -i test.fif
mne_compute_proj_eog.py -i test.fif --proj=test_ecg_proj.fif --no-proj

then you get a file test_eog_proj.fif, which contains the projectors (in order)
1) proj from test.fif
2) ecg proj
3) eog proj

Obviously, the order doesn't matter, but when loading it in mne_browse_raw, it is more logical to have them in the order they were computed.
The order doesn't matter
atleast_2d does not do what we want here (I think)
use an explicit
if x.ndim == 1:
    x_in = x[np.newaxis, :]
use assert_true and not assert

eg:

https://github.com/mne-tools/mne-python/blob/master/mne/tests/test_label.py#L27
I did, too. This was 15 minutes of me scratching my head thinking, "wait... why isn't this working the way I expect it to?"
This seems unnecessary since this user's properties are blank, you do realize that the test user property you added in the test dataset is for the user with id 5510, was it supposed to be 5511
yeah that was what I wondering, could you add "deactivate all the extensions that depends on the deactivated" code comment on top of it
I'll fix that in one second.
I prefer %q
the code block should not be indented here.
I agree Roland.
After that change things are good to go into master/release-2.0
it's used for tests only - let's move it there and mark private
El disclamer sigue estando en el pie de página
Nota para el futuro: esto quedó sobrando.
See note above. Referencing concrete classes makes extensions difficult to implement. If you're after the setter() it should possibly be moved up a level.
I see that by switching to 1.6 then back to 1.7 , these green lines happened
The entire implementation needs some cleanup. This PR is not at all ready to be merged. I'm just forwarding a PR that was opened against my fork. I asked him to clean up a lot of different things (including removing the build files) but I have yet to hear back from him.
At least this one should be 

```obj
if (mouseIsUp)
```
Space IV: A New Space
We should actually through an exception here.  The KL-divergence of A||B is undefined if the B distribution has 0 values where the A distribution does not.  This should properly generate an IllegalArgumentException.
We're moving away from explicitly returning wsgi.Results on errors. Instead, just let the exception fly and make sure that exception_map returns the appropriate status code.

In this case, the models code will raise NotFound which maps to "webob.exc.HTTPNotFound" which will be surfaced as a 404.
Juu, koskee permutations funktiota.
Why change to Int? It's not typesafe ;)