labofsahil/github-event-dataset-2012 huggingface dataset:
I found out about that bug too :)
Unfortunately, the fix you made causes the StartLocationText and EndLocationText to go stale.
The reason for trimming is mainly for the comparison part with "My Location". So the correct fix would be to not Trim the shown value (they will get trim automatically upon confirmation) and only do the trimming on the comparison for My Location.
BTW I think we have something flipped somewhere in MD2 pipeline - I noticed skins that have some letters look mirrored.
Currently the thinking is that to generate additional columns you'll have to use the custom builder. I could also add something to the makefile if that helps you out, probably a good idea anyways.

As you can see above, adding the extra 12 columns is a lot of extra output we'd like to avoid.
OK, that's our `new ASN1InputStream(new ByteArrayInputStream(obj.readObject()));`, right? :) It's the core of your stream parsing concept. Aside from those importance, I'm still not clear about 'Header' and 'value_io' are good names or not, but you can change later if you need.

OT: When I implemented OpenPGP and ASN1 as a firmware of HSM years ago, there's no IO in HSM so I wrapped heap memory as an IO-like class and implement methods as ptr operations without memcpy. Of course IO would fit krypt.
Could be synchronization issues with tile load/unload for sure, since dtNavMesh tile storage is pooled.
I think other dtNavMesh operations are safe, but need to look into it to make sure.

For the r2 multithreading implementation, I think option 2 (locking) is easiest.
Hello jerone,

I noticed what I believe to be a bug on line 253. You open a v:text tag and close a v:textbox tag. I did a little research and I could not find a v:text tag rather v:textbox and v:textpath. I tried both of these and I could not get the correct behavior when trying the code across browsers. Instead i stripped this out and applied the v:text styling to the <td> contained between the v:text tag. This seemed to provide consistent behavior across IE7+ and FF.

Thanks,

d
you can change this to say "Your app was disabled by a site administrator."
this covers the case where we have no TOTAL results, right?
It's required for proper branching. If in doubt, you could run "find usages" and debug the tests I've added along with this PR.
I would guess you didn't make a "pull request"?
Thinking more about this: why only if ```bounds.containsBounds(this.maxExtent)```? I think it makes sense to never go beyond a maxExtent corner, even if you're zoomed in so the map bounds don't contain the whole maxExtent of the layer.
Where are others? are they updated to latest core and with support?
Voisihan se. Muutan jossain vaiheessa
Pěkné řešení, ale UTF-16 kupodivu není kódování s pevnou délkou znaku.
Well... even with that "weird test" your code helped me a lot on my work to implement the space colonization algorithm (I have a repo on github). So thank you for your indirect help :)
this should be `process.returncode != 0`
Your clock is severely off, either that or three hours feels like about 5 minutes since I just talked to you. ;)
So small, but took a long time to find.
I think we need to be adding a file that bashrc loads, not overwrite bashrc itself :)
Just curious, why don't you update your patch version, with each release, why are you using the dash 3
Is there any reason for not using `attr_reader :attr`?
if you don't change the plugin name and packages you shouldn't manually be adding your own Vault implementation as Vault will still hook this by itself and still report it as iConomy5 - saves you re-writing the hook and maintaining it. 

It also can cause some confusion on which hook to use.
Awesome, thanks guys! I think including it either way would be great. So it sounds like jQM could be developing out a sort of plug-in framework for thinks like that (similar to jquery itself)? That would be great to keep the size of the core library down for optional features like this.
Might be nice to parameterize this so you pass in the data you wish to prepare this way.
Wieso PreLogin? Ich denke, wir wollten das erst beim Login machen?
> Does searchByCoords() work without captcha for basic members ? Is the captcha only needed for the coords ? Hm....
The search works and you get the list ordered by distance from search center and with direction images
There is a problem with the way I'm scoping things though. When creating a new client for example, a successful save is supposed to redirect to the show action for that client. Yet, because that client is not yet in the clients of the current_company for the current_user, the ClientsController#show action redirects to /clients, as expected.

Is there a way to circumvent that behavior? Should we consider that the new client should be automatically added to the list of clients for the current_company of the current_user?
On Fri, Feb 24, 2012 at 12:00 PM, Jani Monoses
<reply@reply.github.com>
wrote:
> So the main work in x86 is endianness-independence patches? I am mostly interested in ARM which is little-endian as well, so maybe a subset of these would do.

There are a few things that cause trouble on other processors than the
amd64/x86:
1. signedness of char
2. endianess
3. the need for data to be naturally aligned
4. sizeof(bool)
5. Wrong way of detecting some features of the compiler etc.

Assuming that the processor runs in little endian mode, older ARM:s
needs patches for 1,3 and 5, newer for 1 and 5.
PowerPC needs for 1, 2 and 5, SPARC for 2, 3 and 5 etc.

2 and 3 are taken care of by the same patch-set.
I like this new naming :)
Understood; we'll modify as needed and make a second release if we have to.
It would be worth adding support for executing a GridField action via JavaScript.  We'd need to consider what should be done with the response - it may not always be appropriate to refresh the GridField in its entirety.  New values of X-Get-Fragment might be useful here, e.g. 'X-Get-Fragment: Status-JSON-Pair' might just return things like:

    { "success" : 1 }
    { "success' : 0, "message" : "You can't delete that record" }
hehe, no, https://github.com/travis-ci/travis-ci

bastards done stole my moniker
I only started using the new system yesterday, as I've been doing more interesting things for the last few months. But it seems pretty decent, and a lot less bulky
:thumbsup: Thanks Paul!
Good find. Recommend 301 redirecting.
In this case if I added a getFlags() I would probably add flags for constant and distributed, and implement isConstant() in the base class using the flag from this function.
ok.

btw, let me know if i can provide any help with the remaining pull requests.
Got errors on sql should be :  
```sql DELETE FROM `spell_script_names` WHERE `spell_id` IN (48018, 48020);
INSERT INTO `spell_script_names` (`spell_id`,`ScriptName`) VALUES (48018,'spell_warl_demonic_circle_summon'), (48020,'spell_warl_demonic_circle_teleport');
```
Well, it's pretty much just these backgrounds:

https://github.com/classam/arkham_gameslab/blob/master/Phoenix/assets/combat.png

+

https://github.com/classam/arkham_gameslab/blob/master/Phoenix/assets/strategic_objective.png

On Thu, Mar 8, 2012 at 10:14 PM, rythos42 <
reply@reply.github.com
> wrote:

> Awesome dude! I can't wait to see it!
>
>
working dir should also be tested against env and file system. To make sure the program start in the real dir.
That is my plan for now. But Tommy is going to be working on the engine in Java using a different graphics library.
If you're really crazy about it, you can create extension methods on ILog that do the same thing, that's basically what's happening inside NLog, it's just wrapping your message generator function with an IsXxxxEnabled condition check.
Did you test a tiddler.title = "don't"  ?
H version does not work :( on TC from date 10.12.2011
fuuuuu! at least it looks kinda tidy.. 
this is just needed to trick the window and keep it happy, while calling `tile()` later will reposition/size the window 
not doing that could cause windows crashing and disappearing and throwing errors. 
ah well..
i am not sure about calculation and values
Yes I got it now :-) Was overlooking this. Also got the simplemedia draft finally visible. And got the packer working as well.
Um, about the harvester text, you can pick up the harvester to get the coins, instead of destroying it. (unless that was changed? haven't checked out the most recent release)
http://dl.dropbox.com/u/518733/AutoAnnouncer.jar
You will need to convert your config file though - I renamed a few things as you can probably see from the diffs.
We're already inside a <html> tag at this point so we don't need this tag.
Not sure on the try/except - what exceptions do you think might be raised?  I think this has to be a valid uploaded file to get to this point.
Certainly can! It's a 1978 Citroen GS Turbo, the 9th engine to run under FreeEMS control. http://forum.diyefi.org/viewtopic.php?f=55&t=1508
Ugh... Time for me to get some sleep... Sorry :(
``unquote`` doesn't seem to have been imported anywhere, and (if it's ``urllib.unquote``) won't strip the query string:

    >>> import urllib
    >>> urllib.unquote('http://foo.com/bar/?baz=quux')
    'http://foo.com/bar/?baz=quux'

You probably want something like ``urlparse.urlparse(request.REQUEST['return_url'])._replace(query='', fragment='').geturl()`` (which will need tweaking for Py<2.6).
Actually reading DTS via lavf, right?

BTW, libav and ffmpeg changed their API of audio encoding from avcodec_encode_audio to avcodec_encode_audio2, so linking latest libav in x264-audio will make lavc's audio codecs not work correctly.
I would wrap all of test.js with a function closure:  (function() { ...existing code here.. })();

This will prevent the variable declarations from being global.
Instead of adding more code, just modify the regex to cover both cases. Looks like the only difference is the lack of "syntax error," in the second case.
maybe Eclipse does not update the AndroidManifest.xml to add android:versionName ? That could trigger a fatal error while building the settings menu :(
It worked for me with jenkins build #51 http://imgur.com/qac2q . Changing font size works too.
do we really need it is loading in the top?
Si si. Esta hecho para que no se bugee. Lo unico que hace es que si no esta el encuentro en progreso despawneen xD
Y lo de abajo es para que no se puedan controlar mentalmente y se puedan stunear, poli, etc.
You are most certainly right.. Could you do a PR?
Hi Janet and Paul,

   These docs were accurate when I wrote them and the overall build structure is correct.  Every time I do a build, i.e. update ffmpeg, and run the build script, though, something comes up, which usually leads me to think - well, I guess it's not going to work this time, and then three hours later discover some way around or through the problem - most recently had to switch C compilers due to some kind of stand-off between the gcc developers and the ffmpeg developers.  If you look in the build scripts in each directory you will see some instructions, if necessary about things I had to do for that library.  In some cases it is editing Makefiles and extreme cases (maybe not necessary any more) editing source code.
 Obviously whenever anyone updates ffmpeg or a 3rd party library there is the potential for something to change, and since ffmpeg developers are usually not thinking about compiling on i386, x86_64, and ppc on a Mac, that adds further complications.  Unfortuntately, I just don't have time to keep the build docs up to date right now as I have another full time job.  Even so, the process of doing an up-to-date build is slow and painstaking - just trust me on this.  If you want to do it yourself, or maintain a set of docs yourself, I recommend going through the process - there are online guides out there, reading the old docs, and I'd be happy to answer questions if you run into obstacles.  One thing I am doing, as you'll see in the docs is compiling a version for each mac architecture separately and then combining them at the end, in order for the machine language bits to run as fast as possible.  It is easier to compile for the native architecture of your machine only.  In fact, I would say the only exceptional thing about the way I'm doing it is the fact that I keep the architectures separate.

-Colin


On Jan 31, 2012, at 4:01 AM, jed jed wrote:

> Hi Colin -
> 
> Can you please be sure to respond to Paul's questions regarding the
> ffmpeg build docs, he wants to pull your stuff into Miro.
> 
> 
> Thanks,
> 
> Janet
> 
> 
> ---------- Forwarded message ----------
> From: Paul Swartz
> <reply@reply.github.com>
> Date: Mon, Jan 30, 2012 at 5:48 PM
> Subject: Re: [mirovideoconverter] Add new commands for xoom, fire, and
> galaxy. Bring in new ffmpeg build 1/26/2012 (f50392a)
> To: Janet Dragojevic <jed@pculture.org>
> 
> 
> Are the FFmpeg builds made from the same code/scripts that are in
> https://github.com/pculture/mirovideoconverter/tree/master/Mac/FfmpegCompile?
> If not (and it doesn't appear that they are) can you update those
> instructions to reflect the build you made?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/pculture/mirovideoconverter/commit/f50392aec44ab3dceaed7ebfb9e024fd0da69e80#commitcomment-914771
>
Why don't use the let() ? and do and avoid using let to do a request ?
Hey  Adam, is there a reason this was not merged back to develop?
I dont expect it that it throw a exception, I know it. Because its happened to me. :)

But yes, your null check is a better way. Was only a fast fix, dont think long about it.
This is quite a bit of code duplication.
Personally I would do something like this instead:

```javascript
output.push({
  date: new Date( (config.type === "history" ? item.dateloved : item.dateloved) * 1000 ),
  config: config,
  html: $.tmpl( (config.type === "history" ? template.loved : template.history) , item )
});
```

That's a personal preference though and I didn't test whether it actually works.
What about moving this into a normal closure with instand invocation? That way one does not have to wait until the dom is fully loaded.
url en dur, du mauvais bootstrap :(
Yes, that's right. I must have forgotten to add the include directory.
since the apache_request_headers function will work only if php was installed as apache mod ( http://php.net/manual/en/function.apache-request-headers.php check the change log ), i had a problem on the live server 
so i have change it a bit to check if its exist or not ..
if its not found use the getenv() function instead ..

am not sure if my code is right, but it solved my problem ..
есть, и была тут даже, сам переделал. вот только новому moreores именно этот мод нужен
Why deciding between https and http here? Since the remote image will be downloaded and embedded by the PDF creation backend anyway, there's no reason to worry about mixed content here. So always using http should be okay.
NOT IN THIS COMMIT ! please stop putting your comments everywhere
Please help me with cooper with it: https://github.com/GalaxyTeam/android_device_samsung_cooper/blob/gingerbread/init.gt-s5830.rc
I have a question about performance. What is better? SQLCache ou FileCache?
Then I guess the piggie needs more feeding???
Totally agree. I was just trying not to take too much liberty in diverging from the AWS implementation.
Yeah, good point. On the face of it, it looks as if only colnames(dec) are only ever used? We could do with some more research on this - and remove it if not used. Otherwise calling decideTests just clouds the issue. Perhaps in the past the differential expression call was meant o come from with R, whereas now we make that decision outside of R. 
We'll just need to think of how to pass colnames to tab$t and tab$p.value.adj in computeAnalytics without having to call decideTests()
Misagh made the same suggestion.  Again, didn't touch that code but it's a good suggestion nonetheless.
This was the usage pattern I saw in OpenSAML test cases, but I would think it doesn't hold any state that would make it not thread safe.  I'll do some code review.
so pass allow_none=True here, I think
false. Because we could have been watching a RemoteActorRef that had never resolved before the other node went down.
Vector.fill(nrOfInstances) {
latestGossip :+= collector.sample
they’re fine, I think
otherwise... what?  this one doesn't have a get.
The indentation is also weird for the [Category] attributes and some of the new tests
during compilation
No, not really. Will fix.
This should be: `$keyVal = $valueVal = false;` or `$valueVal` should be in next line.
It doesn't seem like this flag should depend on whether the control is tracking.
Don't purge if  $use_vtrash == true
Still missing a whitespace. :-) Also, it should wrap at 80 characters.
RuntimeExceptions seems like the wrong choice here.  UnsatisfiedLinkError might do, or if you want to be fancy, you can create subclass of LinkageError for this purpose.
I think we don't need that anymore as the readable(..) flag is now per ChannelHandlerContext and so it should be enough to just use this method...
Yes, I think the None case could be removed.  The only argument I can think against doing so is if trace_data_allocations() was changed to return the previous values for the callbacks (to allow chained callbacks to be implemented in a general way).  I was considering doing this.

Having them be NULL or callable would add a bit of extra code to handle incoming None (convert to NULL), and returning previous values (convert NULL to None).  

Perhaps the best approach is:
- initialize the values to NULL (remove the code in initmultiarray())
- leave the NULL or None test in the actual callbacks (most common case is NULL, also fastest).
- in trace_data_allocations() preamble, if callbacks are NULL replace with None.
- add code to return the previous callbacks from trace_data_allocations().
I think this should be #ifdef'd for affected versions of OS X. Technically, it's possible to create users and groups with blank names (I've just done it on my Ubuntu workstation), and `getpwnam("")` and `getgrnam("")` do return valid records at that point.
You are right this is supported too, but I don't think this test is asserting the behavior since it only doesn't stringify the keys when the html_options is not there. But in this case it is there.
Remove additional parentheses?

    # => SELECT a.title FROM (SELECT * FROM topics WHERE approved = 't') a
@rafaelfranca @carlosantoniodasilva OK, I've updated PR.
we need to remove the brackets from the `coder` argument.
I''m not using minitest, so I'm not sure, but won't this never fail? I thought `assert` checks if the first argument evaluates to `false` (and this case a string never would).
I think it should not be mixed, if someone is adding/updating stuff in new format, he can update the whole file.
Thanks for fixing this, I ran into it during my flight and #facepalmed
Making these private[this] would improve the performance of fromNanos. This is s.c.u, after all. :)
I think `name` here should be typed as `termName`.
Good wording!  Thanks.
[[scala.reflect.base.Annotations#Annotations Annotations]]
that is where everything is going so far.

Steven Christe, Ph.D.
Solar Physics Laboratory, Code 671
NASA Goddard Space Flight Center
Greenbelt, MD 20771-0001, USA
Telephone: 301-286-7999

On Mar 30, 2012, at 11:04 AM, Keith Hughitt wrote:

>> @@ -0,0 +1,53 @@
>> +"""PROBA2 Map subclass definitions"""
> 
> I was also thinking along the same lines. The only disadvantage is that things won't be centralized anymore (you won't be able to just do sources.* to refer to all the map subclasses), but that is not that big of a deal.
> 
> Did we ever agree on inst as the location for mission-specific code?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/sunpy/sunpy/pull/134/files#r626415
I think that's part of what helps xreplace be fast. It's a pretty cheap way to avoid a rebuild.
Yes, it looks ok on my machine and doesn't produce a warning. It also magically adds a colon. I suspect that the See Also section is special cased.
The original formulation is in correspondence with what Wikipedia says and with my rememberings from geometry.  Is there a specific reason you wish to transition to a different definition?
okay! one int, one rational, one irrational and one float .

how about this ?
Why was this part of the docstring removed?
Yeah don't worry, I caught that soon enough (it is a SyntaxError :-)
That's right. At the moment, the master fails due to this, so it needs to be fixed. Here is a pull request that probably fixes that: #1364
Code is not new (copied from constructor). Will check it.
This is testing the uploading of files, for which the title is not required.  If it's missing, it's constructed from the name of the file that's uploaded.

I don't think 'Kotti is not prepared to handle incorrect forms' is true.  Form validation works fine for me.  Is what you're seeing maybe related to this particular test only?  Because try and see how uploading files without a title works fine, and how leaving out the title for a document gives an error.
"not callable" is more analogous to "not bark" than to "quack".
I think we need to enforce this. Can we add a test and ensure that it can't happen?
This doesn't work because POConverter uses generics for the type of PO. You'd need to cast to the proper PO, which I couldn't do without refection. We could change POCOnverter to be less typed, but then they'll all need to cast, which is a drag.
No worries. I will update the pull request.

On Mon, May 7, 2012 at 1:43 PM, Richard Carlsson
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,2 @@
>> +_build
>> +*.beam
>
> Yeah, I prefer to put .gitignores in the respective subdirectories as needed.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/etnt/gettext/pull/9/files#r783163
this note is wrong as you added the Security component as a requirement in the composer.json, not only as a dev requirement
"became" is past-tense
I like that!  get_descendants would avoid confusion.
Oh, you're correct. I though it remained when it was rewritten.
Could add a comment however.
To allow the usage of mock classes in the tests, I removed the type hinting in the constructor signature.
Should the class names be removed here aswell?
"Independent breakage" means it was/is broken before this PR, and therefore should be fixed in a separate PR.
Nevermind this, @return null is correct per http://area51.phpbb.com/phpBB/viewtopic.php?p=225147#p225147.
I looked at the other file while adding this:
https://github.com/phpbb/phpbb3/blob/develop/phpBB/includes/cron/task/base.php#L31
I misunderstood them. $l* variables store language text or language keys, which makes sense. You are using the variable to store a boolean and it therefore should have no l prefix. Fixed it thanks!
You mean for tests? If I initialize $phpbb_notifications as needed, I need to put $phpbb_container->get('notification_manager'); in the functions that use it.

That means anything that runs tests that contains any notifications code will require setting up the container rather than just setting up $phpbb_notifications as a class.
GetTempPath ?
On Sep 20, 2012 8:03 AM, "Alex Eftimie" <notifications@github.com> wrote:
>
> In wouso/games/challenge/views.py:
>
> > @@ -231,3 +231,83 @@ def challenge_random(request):
> >
> >      return launch(request, players[i].id)
> >
> > +@login_required
> > +def detailed_challenge_stats(request, target_id):
> > +
>
> Why the empty row after definition?
>

To add doc strings? :P

> —
> Reply to this email directly or view it on GitHub.
需要 confirmable，注册成功后要给用户发邮件激活。以后发邮件给用户不容易进垃圾箱。
Class variables should generally be avoided due to weirdness with how they interact with inheritance.  Instead, you can almost always just use instance variables (on the class object, rather than on an instance of the class).

Also, if you target this at ruby 1.9 only (which I would recommend), there is a UUID generator built in to the standard library:

``` ruby
require 'securerandom'
SecureRandom.uuid
```

No need for the class var then :).
```coffee
"/event/#{event._id}/edit"
```
What is the case where the parsing fails?
Why this namespace?  Are we using it in a similar way that others might use it?  Might it be better to use a "mojito" namespace to avoid collision?
Seems you broke formatting here.
Oh, OK. The code as written actually fails with NAs. I've made the change to treat NAs as a separate group, at least for now. We can revisit...

I'm going to pull your work into my branch!
Yes, this sounds logical.  Will try to get around to this asap.
I made a new commit that check any file in the directory when the .so file don't exist. Don't forget that the key,pkl file don't exist, so this is only for unversionned compiled directory.
-1 does not work as expected here
Both of these could be private final -- I don't know why so much VoltDB code uses "protected" for private members --

The code would be slightly simpler if m_shouldComputeCRC was eliminated and m_inputCRC set null when not computing a CRC.
Ditto here, don't think this is ever called on the MPI.
Warning reduction.
Well maybe the people were wrong, i don't know i just read stuff ^^. Chillax.
not sure if we need the initials, git blame can do that
I think you should rename this class to ApplicationConstraintValidatorFactory or maybe JobExConstraintValidatorFactory, but not this "My" there is no my or you !
the path is wrong
Indeed, right you are. Another benefit of modifying our implementation to using the PostgreSQL PDO driver would be we could get rid of the need for this method entirely.
Yes, I agree. This needs to better tested. I'll see if I can come up with some direct test cases for it.
This should probably initialize the array, right?
no, thank _you_ for so thoroughly reviewing my mistake-ridden code and suggesting all these changes.

Although, looking at how slim the diff is now, and considering we are able to get rid of (what I was calling) `getOffsetSlow`, why wouldn't you merge this in?
Not a big deal but this adds perl to our build dependencies (it currently is not).
fisher -> Fisher
I may have suggested something else before, and apologies if that is the case; If there a reason this isn't part of accounts-oauth1-helper? Do you imagine people using this code for other purposes?
Mhm, when you use start you are just spawning a greenlet to handle the server, you still need to have your main thread block on gevent code so it ends up switching to the greenlet. Thus the need to have the code in #166 in our main thread and the gobject loop on the side so that GStreamer works.
Maybe add a ``To see the WS in action go to...`` type sentence instead then?
Changed parse_ua so it returns a Browser rather than a dict. That's better API, I think. It should simplify the caller code.
You're essentially implementing the Input version of this:

https://github.com/mozilla/kitsune/blob/master/apps/search/tasks.py#L80

It's probably worth following the structure there.
Разумеется. Заменю на двоеточие.
Не ставил цели устранить все ошибки, исправлял только там, где взгляд спотыкался при чтении. На эту запятую внимания, видимо, не обратил.
We should also update description for --relative-url in the usage of pulp-admin rpm repo create and update as a part of this bugfix. Something like "relative path the repository will be served from; only alphanumeric, -, and _ allowed; defaults to relative path of the feed URL"
The choice of the word play, doesn't really seem that fortunate here (it sounds friendly and fun but kind of unprofessional), I'd go for something like *control*
Extract the ``self._components[component]`` outside of the filter method because it is invariant.
Ahh wird spaster geprueft, sehs grad..
nit: dead line
Period at end. Also see above comment about wrapping.
I don't like getOnce. Can we do something like, getNew or getFromBytes.
今回の件と関係なし
Likewise, please move this to the top of the test, or a @Before method.
Not needed in this scope.
We may have discussed this previously, but if so, I cannot recall what the outcome of such a discussion was. So I'll just throw this out there, and hope not to get attacked: you should null out _batman[key] before calling delete.
Just hollerin about this once more. @nciagra @jamesmacaulay @terraflubb got any good ideas for making this better? The issue is that `Model.load`'s existing API takes one options argument which is assumed to be data ending up in the query params. Instead, these guys need access to the options object passed to `_doStorageOperation` so they can muck with the URL property which hangs out at that level, instead of down one level at the `data` key where it would be if you did `load({url: 'foo'})`. Hence the need for `loadWithOptions`, which passes along the passed options directly to `_doStorageOperation` achieving the desired effect.  Should we break the existing `load` API to give more flexibility? Should we make some sort of identifier so `load` can accept both styles of options?
Good catch :smile:
I don't know if the redirection "&>/dev/null" can be problematic here or in lines 295 to 297.
Do all of these methods apply equally to video as well as audio? I can imagine they might for the html5 <video> version, but not for the phonegap version.
foo? :)
Could we check the numeric values instead, and use <=? It's conceivable someone might set a font size like 1.25em.
What do you think about making text a px or 2 smaller? Seems a bit too big to me.
Should this block execute while the agents are loading or afterwards?
This chainability is kind of neat, but I wonder if it would just be better to have people use the JSON form if they want to create multiple menus at once, as that's going to be less cumbersome anyway. Also, the chaining might get confusing with submenus (since at the point in the chain where you want to create a submenu, you'd probably want the next set of menu items in the chain to go in that submenu, and then you'd need a way to "pop out", like `endSubMenu()`....which is kind of jQueryish, but seems like overkill).
Since you're fixing one, you might as well fix them all :-)
`type=.error` was dropped
doc.ignore
Clarify to say that it's the erlang code that will wait for the response
This should not go to production extconf
No. Order is OK. Just `'settings'` is not. :-)

I thought that you would do:

```
MONGODB_DATABASE = 'PiplMesh'

import mongo
mongoengine.connect(MONGODB_DATABASE)
```

But this is still not the best (we would like a way to override the setting before the connection is made), but for now it will be OK.
Um, ugly. Not fixing.
why remove default?
to MAX_INTEGER and beyond!
Just return, there's no harm if it already exists, right?
Your manifest defaults use px and here you use numbers.  You should standardize.  I'd suggest you drop all the px and just add it if you need it.
"Here's the details" --> "Here are the details"
This should probably have a max-width.
hmm would prefer if this was set above in a var, with each part on a new line, then that var added in this return
yaya. i will update the file.
Why concatenate all the parameters every time? Why not calculate a base URL which includes the query string with `baseParams` already encoded, and then just add `&BBOX=...` to that?
Gonnna fix this
也挪到least_conn下面
The code is actually in the root of the repo, so this should be:

```ruby
s.source_files = '*.{h,m}'
```
""" is not the same as in Python, using <<DOC instead is probably better choice
actually that doesn't need to be commented as it is disabled.

enabled: false

All of these are 'defaults' from the newest beta.



On Wed, Nov 14, 2012 at 11:32 AM, Justin Sherrill <jlsherrill@gmail.com>wrote:

> you know, those options should actually be commented out.  let me fix that
>
>
>
> On Wed, Nov 14, 2012 at 11:21 AM, Brad Buckingham <
> notifications@github.com> wrote:
>
>> In katello-configure/modules/pulp/templates/etc/pulp/server.conf.erb:
>>
>> > +# the system relay through a local MTA on the machine. Pulp does not retry in
>> > +# case of error, so it is important to have a real MTA available locally.
>> > +#
>> > +# If there is a need to test email sending, it is recommended to run this:
>> > +#   $ python -m smtpd -n -c DebuggingServer localhost:1025
>> > +# which will write each message to stdout.
>> > +#
>> > +# host: (str) host name of the MTA pulp should relay through
>> > +# port: (str) destination port to connect on
>> > +# from: (str) the "From" address of each email the system sends
>> > +# enabled: (bool) either "true" or "false", controls whether emails will be sent.
>> > +
>> > +[email]
>> > +host: localhost
>> > +port: 25
>> > +from: no-repy@your.domain
>>
>> should 'your.domain' be filled in with the actual domain using the fqdn
>> variable?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/Katello/katello/pull/1064/files#r2126014>.
>>
>>
>
>
Are you sure it's always fail, if it comes here? what about a situation, when $test_success = "F"
I would add a parent context to hold common steps for the last two contexts `context "with all repositories" do` and `context "without all repositories" do`.
you need to update the phpdoc too
Revert this change for now and file an issue on the edit button layout.

I should have use flexbox or inline-box or other CSS technique to expand the size of the button as the text gets longer.

CCing @jcarpenter
Does `console.warn` exists on device or there are just `console.log`?
Well, I also thought that adding the calls to the ``disable_*`` methods in ``setup_function`` would work - the issue is that the way I restore defaults between each test is that I have to reset the system hooks to their default values, but the following lines are no longer effective if the logging is turned on by default:

    # Save original values of hooks. These are not the system values, but the
    # already overwritten values since the logger already gets imported before
    # this file gets executed.
    _excepthook = sys.excepthook
    _showwarning = warnings.showwarning

because when astropy is imported, the logger then overrides the system values by default, so by the time the test is executed, there is no longer any trace of the 'original' values (note that this happens even if I put these lines over the ``from .. import log``, suggesting py.test is importing the whole package before running these tests.
Great.  I missed that on the first read-through.
Why not just do it all in one case to cut done on number of lines:

```erlang
case dict:find(...) of
    {ok, _} ->
        VClock = ...,
        State?CH....
    error ->
        State
end
```
It looks like `kill_xfer` is implicitly assumed to only ever be used on outgoing transfers. What happens if it was used on an inbound transfer? Related fact, inbound transfers don't set `#handoff_status.type`, so when `handle_call(kill_xfer...)` prints the type to the console, it would print undefined.
Do you really need the `break;` if there is a return?
See how we test other things that use shared parsing functionality.
Well if fox cannot handle extremely basic conditions, I don't see much value in it.

In that case, I would just skip the readline install and tell OS X users to make sure they have it.
This depends on #2269.  They are separate because this one should be backported and that one should not.  This will not be in the diff once #2269 is merged.
If we are setting a background image, we should add the image as a fixed image view in the background. Creating a pattern image may lead to confusion when the developer sees a tiled image rather than just the image itself. This will require a bit more work, but as it stands this method is simply short form for `launcherView.backgroundColor = [UIColor colorWithPatternImage:backgroundImage];` anyway.
I believe this case is impossible? but I wanted to preserve the original behavior if it was intentional but did not cover the case where the param is an object... I admit I didn't dig into it very deeply.
I don't know if it helps, but you can continue a . on a new line if the expression is in parentheses. For example:

    qs = (Answer.objects.exclude(creator=...)
                        .filter(created...)
                        .extra(
                           select={....
                        .values('year', 'month', 'creator'))

It doesn't get auto-indented in emacs (which bums me out), but it's pretty easy to read. It's the format that Fudge uses for mocking. http://farmdev.com/projects/fudge/using-fudge.html#a-simple-test-case
Yeah... so this is something Erik did and while it's kind of neat, I kind of think it does too much and does some of it in magic ways. But I haven't thought of a better way that's as succinct, but more legible and less magic.
missing the `_()` for l10n
Sorry, I don't understand the question. Could you rephrase?
it's a good thing you like it, because otherwise there was gonna be an unresolvable include loop =)
did the same as above with catching both KeyError and exception
I don't get this. I thought with 9.2 we don't have to create the extension because it's already there. Or something like that.
Much safer generally to use `os.path.splitext()`
Why send in the whole config? It only needs the logger right? Then maybe we should:

```
new_thread = TaskThread(config.logger, self)
```

Also, is there a memory concern about making these many fat thread? If so, would putting `__slots__` on the TaskThread class solve that problem?
No, this is re-instating a setting as it was in 1.7, and then deprecating it.
It doesn't seem to hurt anything, but I can isolate it to only be in the flicker-fix case.
Ah! And coincientally I'm an emacs user ;-). Belive me I didn't delete it to start another emacs vim flamewar :-D :+1:
Hey! You messed my colors man!
I don't see why you need to put it in a property of the HttpCache kernel as it never uses it directly
Reverted my commit again. We need the  method, since UnmodifiableFormConfig accesses it and is hinted to FormConfigInterface.
you can now remove this one i think
Useless blank line.
Should be "init:prng" I think
You need to use: `null === $time`.
id issue again.
What the original author's intent was I'm not sure. If nothing else it confirms we're not sending multiple messages for the same request. Kind of an odd thing to test, but it would also be bad if it happened. That's all I can come up with.
Please use explicit type names in the Doc (R-> Range)
Well I used extensions because it includes methods from both. Easier to test this way in my opinion.
For compactness, you can collapse all these checks into a single if statement.
Good idea. Have done.
El current user que escribe el usuario es el de la aplicación de dummy. No hay necesidad de sobreescribir este.
this is just messy.  now that things on are source control you don't have to worry about deleting commented out lines since you can always get them back.
Good question. My hope is: no

The Facebook SDK can only be initialised once so it kinda has to work for
everyone. I guess we'll see if this causes any issues.

There isn't a publicly available constructor as such - just a getInstance
method. I don't want clients having their own instances of the authorizer,
otherwise they don't get the fun of piggy packing on events coming through
the FB API.
`typeof null === "object"` ...
I moved server start to the particular test and only do a cleanup in AfterClass, if you like it better.
Is there a reason to prefer `simulate` to `trigger`?
https://github.com/hizel/lorsource/blob/spring-security-2/src/main/java/ru/org/linux/auth/SecurityFilter.java#L48
имхо оповещение по [user] должно быть "сильнее" оповещения по тегу, т.е. когда они есть оба то должно оставаться оповещение по [user]
BTW, I am not sure if it's suitable that somebody leave his name in the comment.
You could `git blame apps/system/js/sound_manager.js` to find who had added this line, couldn't you?
can we avoid doing this on the window?
My mistake, I didn't even take a look before writing it.
I'll fix it
Yes, this is just in case that input_parser.js is not loaded, which should not occur.
`ring()`
I'm afraid to blame this file because I probably introduced the issue...
The index checking modified. I also modified the index checking in other part.
We are using the data-theme for being more contextual and dont mess with any other classnames that the developers could have in their applications
Could you explain why is this like that?
Ok, we can wait for the l10n code. Could you create an issue and reference to this PR?
We will fix it as soon as @fabi1cazenave code lands.
we took the number from page.js, and measured it to make sure it's the same as the rest of the grid icons
nit: metadata.title = tags.title || file.name;
Use class name to toggle visibility or use `document.getElementById('nosongs').hidden`.

Try not to write CSS in Javascript.
l10n? i'm starting to suspect tabzilla isn't supporting l10n yet?
This chunk was deleted, that's why it's red
I prefer `getInstance` instead of just `get` ... it´s a matter of taste
it seems the whole point of the Max[T] class is so that you can implicitly get the MaxSemigroup. The downside is that if you want to use the MaxSemigroup you must box your type inside a Max object. Why not just let client code explicitly instantiate MaxSemigroup objects?
On Dec 4, 2012, at 1:35 PM, Martin Hurton <notifications@github.com> wrote:
> Please set errno before returning -1.
> 
parse_uri and check_protocol already set errno and term_endpoint does not set errno in line 618 either. I guess if I am to set errno before line 606, we have to do so before line 618 as well (would explain the unqualified EAGAIN I have seen). What would be a descriptive errno? ENOENT? ENODEV? ENOTCONN?

Best regards
Stefan
I think this should be stringToNumber
Will fix.

I haven't found a good way to edit cython code yet... I use Emacs, but since it doesn't recognize cython as python code, all my python habits (such as tab whitespace indentation) go astray. Any suggestions?
do we really need 10 threads?!
yep, so we need to bound chaplin to versions. on this case we should even do `>= 0.4.6 < 0.7` to match all 0.4.x and 0.6.x versions.
This line needs to vanish now
Hmm should I hold off on the merge until that's fixed?
@smoeding, Yes, please remove the *maxheld* value from being handled. The failures might be interesting in a way. What do you think about creating a generic `total_failures` type and use it for them?
type is missing
According to code style convention methods' names must start with lower-case letter, so rename method to "readMUtf8String"
Fixed https://github.com/zzet/gitlabhq/commit/8ec9be82c9166516a73d2e9974b002b411ced6f4
even now it won't work. Please make sure that new directory have appropriate mode.
Does your patch introduce new `activate` event?
Or what it somehow broken?
Oh I see now.
Had a quick chat in IRC with @ochameau, where basically he explained to me the security issues given by the use of that approach.
@lloyd - If resources on static.login.* have far future cache headers the relay is updated, changes will not be automatically downloaded by clients.  Relay is a simple file that likely will not change - so it should be safe to do here.
Ah, I see. Awesome.
Yes, please revert. Sorry for the noise.
Makes sense to me! At the time, I was trying to keep as much of the "does this method need to be stashed?" knowledge in one place (as it got more complicated with the fix I was implementing); this new feature seems like a good reason to change things around though.
Would throwing Cancellation cause the ThreadLocal connection to leak?
But in the debug module it is checked whether 'NIML' is actively in debug, almost immediately:

mpva2/base/verbosity:
"        def __call__(self, setid, msg, *args, **kwargs):

            if setid not in self.registered:
                raise ValueError, "Not registered debug ID %s" % setid

            if not setid in self.active:
                # don't even compute the metrics, since they might
                # be statefull as RelativeTime
                return"

So this would only lead to a very minor speed improvement at the expensive of "if __debug__:" guards all over the place, no?
unittest would be nice... e.g.

 _partial_string("0123456789", 2, 8)

would produce somewhat undesired

234...56789

suggesting an additional condition
I think we need a default implementation of this interface available -- and perhaps two (one for FirePHP 1.0, one for the pre-1.0 version). That way, developers will not need to create it themselves, and it can be a drop-in solution.
public function testExcludeWithString()
{
    $validator = new RecordExists('users', 'field1', 'id != 1', $this->getMockHasResult());
    $this->assertTrue($validator->isValid('value3'));
}

public function testExcludeConstructor()
{
    //AbstractTable::setDefaultAdapter($this->_adapterHasResult); // remove this
    $validator = new RecordExists('users', 'field1', 'id != 1', $this->_adapterHasResult); // move the adapter here
    $this->assertTrue($validator->isValid('value3'));
}

we get 2 identical functions
Actually, it's not anymore. Maks3w and prolix removed most if not all such
instances.

On Friday, August 10, 2012, Michael Kliewe wrote:

> In library/Zend/Log/Writer/MongoDB.php:
>
> >       * @param string $collection
> > -     * @param array  $saveOptions
> > -     * @return Zend\Log\Writer\MongoDB
> > +     * @param array $saveOptions
> > +     * @return void
>
> Normally I also don't use "@return <https://github.com/return> void" in
> constructors, but it is in place everywhere in the framework, so I didn't
> want to break that "convention".
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendframework/zf2/pull/2144/files#r1349541>.
>
>


-- 
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
Shouldn't it be ```Zend\I18n\Translator\Translator```?
Empty lines at beginning and end of the class
Please vote to fix this bug in NuGet 2.3! http://nuget.codeplex.com/workitem/1511?PendingVoteId=1511
With the suggested classOf() method, you would no longer need this switch
Tu peux écrire ```@pass.create``` tout court.
you should remove SecurityExtra and DIExtra as they are not used by packagist
can you also add a find() call and run the same assertions to ensure that the modified state is also persisted correctly?
I think we should remove it and include relevant instructions in the upgrade notes.
you don't need to create a local variable for the container IMO
It looks like you're wanting this to be called for all function calls. It'd be nice to somehow throw an error if they are calling a normal js function in the context. Looking at the compiler, seems like it will just ignore the keyword args if a user tries to do that. I think that's fine for now. It's impossible to statically detect if it's a macro since macro's can be imported from other templates.
Just realized this could be improved by adding #expected_items_found? and #unexpected_items_found?
I was trying to explain why the `in` check was there in the first place. Indeed an array filled with `undefined` values is not sparse, as per specs, but it appears that IE8- treats `undefined` as an elision, creating a sparse array. It's an IE8- bug.
Copying and pasting their code is a very bad idea; what's the point of using their library if you're duplicating it's code? I *strongly* recommend you change this soon, it's prone to bugs and not maintainable.

Also, I noticed that you added a similar hard limit to `get_limit` above, which could also benefit from using `super`. Also, the latest master from tastypie has a new `max_limit` attribute: https://github.com/toastdriven/django-tastypie/blob/master/tastypie/paginator.py

You might consider updating to the latest alpha if you feel it's stable enough for Mozillians.
I'll do that! Good catch.
I get what's happening with the empty `puts` lines, but is there a cleaner way to write this? Looks really odd to my eyes.
Ok. I'll take a look at moving the thread into the manager... It'll for sure reduce the code for the Trade class.
Yeah, _login.scss is special case, where we need to include footer vars - login uses $footer_height. Maybe we could include whole _footer.scss as long as it is used there. Does we even use the same footer for login and app itself? Because they look little bit differently. We should do that.