labofsahil/github-event-dataset-2012 huggingface dataset:
Ok, Already merged the pull request and fixed the commented changes. You can pull to keep on working :)

Sent on the walk

On Jul 24, 2012, at 12:56, Ian Maffett<reply@reply.github.com> wrote:

>> @@ -807,8 +819,9 @@ select[disabled]~div {
>> 
>>    
>> .hasMenu{
>> +-webkit-transition: all 300ms;
> 
> That can be removed.  -webkit-transform:translate3d is generally what causes the blurryness on iOS though.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/badoo/jQ.Mobi/pull/2/files#r1224003
These are just for flake3 (http://pypi.python.org/pypi/flake8/) which I use run pyflakes, pep8 and some other style checks.  I've dropped them in fe5221c
This list should be alphabetized, if you can put your name in the right place I'll go ahead an merge it in.
to dry it up maybe reuse PRERELEASE -> `#{PRERELEASE.compact.join("|")}`
I havent done any changes to this file so im not sure why it would appear to have any
No, see the ticket.
Don't get me wrong, most of those renames make the code easier to read/understand but they just hide what's being done to gain size.
This should be a plain SQL function, not PL/pgSQL.
A workaround that is commented out is confusing. :)
why can you remove this? well i think the gender is always set right so it wont be unitinialized...
Where does 'ou812' come from?
Thank you for the tip.  Formula updated.
No need to modify ivars here.

We don't install anything directly into `HOMEBREW_PREFIX`, it is installed into `prefix` and then things in `bin`, `lib`, etc. are symlinked into HOMEBREW_PREFIX automatically.
I tried doing this, but ran into some problems that I don't recall offhand. We'd need to send appropriate NAKs for bad messages, though.
It's purely style-related change for internal consistency. It's done that way in other regexes in the file.
Actually, `&&` is how you specify that two regex groups must both apply for it to pass, which is what the spec implies.
Can we avoid checking for " xmlns " in every loop iteration? it is an invariant check. move it to the top of the function.
Spaces around `=` here and on next lines.
Cool, thanks. The compiler in my head was throwing errors.
Use `Batman.typeOf` instead of `instanceof Array`.
Use `[options.with]` instead of the Array constructor.
Nor should you. This is kinda rude of you, you know that right?
There are times when we might want to exclude suites from the full set, so I think an explicit list is the best way to go.
Add a comment here that ``global.brackets`` would be defined by the brackets-shell V8 extension.
Comment is out of date should only reference remove/close. Also conflicts with usage in CodeHintManager. CodeHintManager explicitly handles add/remove of the DOM element, so I still think CodeHintManager should be passing false. Am I reading this wrong?
The name of this function is a bit misleading now. How about ``_fsErrorToDOMErrorName``?
Seems like this one should probably be finalizeMeasurement() too?  I'm not sure about the case above (no matches found)... could go either way on that one.  What do you think?
Like the other files, we should put this in a separate `var` block from the modules list.
Typo: repace -> replace
@giannis Why was this code (and the stuff I remove below) here? It is changing the tree is an update event of a file. Do you understand how wrong this is? Please call me if you don't.
You can just delete the function, right?
Wouldn't it be better to use eZURLOperator::eZImage() to get the path of the file, thus allowing overriding images in custom designs? There would be no need for WatermarkExtensions setting at all, just put the images in watermarks directory in any of designs in any of extensions?
Since the function incgamma_nint_c does not work for negative integers and produces wrong results for n=0 I put the NotImplementedError right on top.
We don't really care. I just thought it was required.
This will declare `exports`, so exports will always be `undefined` and always re-assigned to `{}`. It is now useless as a node module. The proper way to do this is `somethingElse = exports ? this`. @gkz: I would probably just revert this ASAP.
I think we should also password protect this site with basic auth:

* http://stackoverflow.com/questions/4287019/stuck-with-python-http-server-with-basic-authentication-using-basehttp
* http://www.whitemiceconsulting.com/2009/07/service-basic-http-authentication-with.html

I have not analyzed them, pasting for reference.

This can also be done in future pull request.
OK, I expanded the description in commit afda6e94. Let me know if the text is OK.

(I also committed the .Rd file this time, while I forgot on the previous commit)
Changed supports_inactive_user to True. I am not quite sure where else shall we change those things.
I would organize this differently. I would put logic into User class. So User class can have some method which returns necessary data for avatar (like URL to the image, size). And then a generic template tag (inclusion tag) renders this into HTML.
Should you validate this at all?
can we just take all of this out and instead of having container-fluid and row-fluid, just have something like this?
```
.container {
width: 960px;
}
.video-background {
width: 640px;
margin-right: 20px;
}
.side {
width: 280px;
}
```

or something?
Can't we just use `*` directly in `install.rdf`?
Nope, shouldn't be any empty elements. The <li> elements for person.twitter_username and person.github_username are only on the page if we actually have data in those fields from the Source CMS. So with no js enhancement, or if the APIs are unavailable, you get this:

    http://cl.ly/233D3y0o0t1V0K2E420L

All the js does is create a couple new elements and insert them, so if we *can* hit the API the page then looks like:

    http://cl.ly/241T3a1a0w2H052L0T3x
Please bump version.
A lot has changed
`ackShouldSendAckFrame`
Not sure what is the advantage of using ```persisted?``` method but if i change it it breaks my tests
Could we change this to  have generic method of providing individual branding by however is hosting the REPL (a gitignored js file would probably work best here)? I
Parenthesis around that type is not need and is quite confusing -albeit it works.
The same for tuple and for dict bellow.
Jobs and tasks are essentially inherited from pulp.  Prior to system groups, we had support for tasks which represent individual requests to pulp for things like package actions, repo sync..etc.  As we begin using system groups (consumer groups in pulp), when we perform an action on the group (e.g. install pkg) pulp will return a job.  That job has points to N tasks (1 for each system/consumer the action is being performed on).   There are similarities between jobs and tasks; however, they are 2 separate entities.
these variables will be missing in katello/manifests/config.pp
ok, I've replaced it with an iterator that gives you the index of the collection we're iterating through. hope that's better security-wise? :)
If pingServer fails over 5 seconds after this test started, the `ok(false, ...);` will cause a subsequent test to fail. It might be smart to guard against making any assertions in an asynchronous callback after the cleanup function has been called.

Basically
```JavaScript
var cleanedUp = false;

//...

if (!cleanedUp) {
    // QUnit assertion
}

//...

// Cleanup
return function () {
    cleanedUp = true;
    connection.stop();
};```

Not exactly pretty, but that way you're sure that assertion failures won't leak over into other tests leading to confusion later.
Considering this blocks until ready by default, a note should probably be included here. Also maybe adding an option not to block?
Can you remove the console.info call. I try to not pollute too much the log, this is useful for debugging for useless for the rest of the world :)
You are not showing error UI (yet) right? Please remove useless CSS.
Why not write it like this?

event.unsubscribe("ovs/network_added/#{network.id}", '#') unless network.virtual
I simply didn't understand what you wanted me to do ^^, now it's clear @laanwj.
I'll update tomorrow!
No, it's a way for the if statement's elses so continue working. i.e. without the re-if, the unknown command code would become true. Strictly speaking this code, now that it's no longer strictly part of ProcessMessages() could be moved now to just after the line that calls that. I guess I wanted to keep the change minimal, by keeping the lines as close to their original location as possible.
Yes but people that pass in properly formatted queryStrings get buggy output now.

the RFC spec says that proper queryStrings should not end on an &.

We can also add a check in this function but that seems like a useless check for supporting non supported queryStrings
I have no idea why this thinks everything changed... My VS is setup for spaces, github for windows shows only my addition. Github website shows everything changed....
Use context.Request not HttpContext.Current.
All validators *must* have a server side instance, because you *cannot* rely on client-side validation since it's not safe:
http://stackoverflow.com/questions/162159/javascript-client-side-vs-server-side-validation

I think this whole class can just be discarded. Have the validators below inherit from `Validator` and implement the `validate` method.
Oh whoops, I decided not to implement this method and forgot to delete it. Removing now.
Since you're not storing the nick directly, you can probably dispense with this and just use `line.Nick` on L38 below, to avoid the awkward string cast.
Kan dit niet vermeden worden? As in installer aanpassen?
Why the change here? Shouldn't a duff request should earn a BadRequest response code?
I've found it useful. It lets you type this:

```R
ns_env('.')
pkg_env('.')
```

Instead of this:

```R
asNamespace('ggplot2')
as.environment('package:ggplot2')
```

But maybe I'm using them in a different way than originally intended -- I often use them as accessor functions, but they also serve as creation functions. Maybe it would be good to separate out this functionality.
需要在进入 green 逻辑之前检查 g_wait_callback 是否已经设置
Actually It works: `None > None` (case during first check) is `False` and `time.time() > None` (case for all other cases) is `True`. So in case the code is triggered before a first ping, the "ping received" code is run and during the second check the "ping missed" code gets run.
we shouldn't use the print function here here, there's a logger attached to instances of InteractiveShellApp, please use that
In these cases, it's nice to use `self.assertEqual(len(open_called_with), 1)` - then if the assertion ever fails, we get a more descriptive error.
A typo to test that I had the import right, certainly shouldn't be there. Fixed.
probably just remove testName as it is easy to make typos
can you change the return type to Optional<Map<String, String>> and use Optional.of(parser.apply(response)) here..
Strict warning: Function doesn't always return a value
This is what I extracted from the attributes code. I agree it should be cleaned up some more... Let's hold off on merging this for a day and I can think about better naming.
please add another text case

for list3[$idx].biz

is this part of another PR?
(nit) This should probably be:

    d['document_product'] = [p.slug for p in obj.get_products(True)]
Perhaps I'm missing the big picture discussion, but...
`'psql: socorro.external.postgresql, hbase: socorro.external.hbase, es: socorro.external.elasticsearch'`
we're going to need to figure out how to solve the problem with `make virtualenv` where this doesn't get upgraded even though the hash is different.
如果队列里面还有任务未被处理完，而进程在这个时候被重启了，会怎样？数据丢失了？我先合并这个pull request，但是这个问题还是要考虑的。
Try to see if it is not possible to use View blocks instead of the $content variable
Valid for other views too
You seem to be deleting quite a lot of language items. Are these just no longer used, or what?
Hi Christian,

We'll need this pull request without the deletion of this .gitignore file (ie just the language updates).

Thanks!

Adam
Much of this code is lifted from GsonResponseHandler, isn't it?  We really shouldn't duplicate code like this.  Furthermore, you probably can just pass an internal callback to GsonResponseHandler and continue to let it do its work.
NPE is a strange choice. I think you want `IllegalStateException`, since this object doesn't support this call. (In theory you could have a method like `createNewThreadForEachCall` that would also avoid the problem, but omitting that shouldn't be an NPE).
If you only rely on the autoload file from Composer, it means that running composer is mandatory, not optional (which is not what you say in the README). I would keep an autoloader in this file for the classes in the component, and if the autoloader is present in the vendor dir, then also load it (which means that you never die ;)).
Others agree on this too? I'll refactor it (including removing the `security.` prefix from all keys).
why the dispatcher here ?
The modification was made because method modify_post_params may add more files to the POST request. In this way it closes the file handles that were created in the for loop above but also in modify_post_params.
What will the Cancel do? Have you tested it?
I didn't realize that.  It does look a bit messy.  

The other change looks good.  The CR is finished.  You will need to merge because I don't have that capability.

Thanks,

-Kevin
On Nov 12, 2012, at 7:19 PM, stojce <notifications@github.com> wrote:

> In candpiosapp/Checkin/CPCheckinHandler.m:
> 
> >      UILocalNotification *localNotif = [[UILocalNotification alloc] init];
> >      NSDictionary *venueDataDict;
> > +
> > +    // don't queue notification if fireDate has expired
> > +    if ([fireDate compare:[NSDate date]] == NSOrderedAscending) {
> earlierDate returns NSDate which has to be compared again to some date in order to decide which date is earlier. e.g. 
> if ([[fireDate earlierDate:[NSDate date]] isEqualToDate:fireDate]) {
> which looks messy to me
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
this is discouraged in iOS 4.0 and later
http://developer.apple.com/library/ios/#documentation/uikit/reference/uiview_class/uiview/uiview.html

Can you switch to the new style?
You could pull the changes into a helper and `if (animated)` call the helper from inside an animate with duration block otherwise just call it.
You can drop the `.id`s from this. Objects should compare nicely with each other.
I agree. I updated this, but for some reason this guy didn't disappear from the feedback.
Can you limit this to "Unauthorized" exceptions so it won't rescue all exceptions?
Good one. Followed this route:
https://help.github.com/articles/ignoring-files
I am going add also to add the OFS format (from Benjamin code ;) ), perhaps we can change the class name by MeshReader?
Trailing whitespace. Its a PEP8 thing... :wink:
Where do these numbers come from? They are incorrect.
Any assumption of 380 is of course incorrect since it isn't exactly 380MH/s
Also, read my Icarus thread comment for a correctly calculated value of the single hash rate (at 2 decimal places I got 5.26ns)
Apparently 5.2631579ns is the exact time that the hashing core uses though
So if you're not getting very close to that value, your method of estimation is incorrect.
(my guess is you've included the software overhead into the calculation)
the model is stil comment, that migth be part of why it doesnt work?
Roger, will change.
Add a message as the third parameter, so that the failure output is clear. Same for assertion below
I'm one for very strict standards and coding style. I do not accept E_NOTICE warnings in released code. However at this point it is in alpha, plus, notices are hardly a major issue.

So I focus on fixing important bugs and more pressing features for the 1.0 milestone, instead of spending time on work-arounds here for a minor flaw upstream  (I'll update the submodule as soon as the fix is merged upstream). If it doesn't get merged soon, I'll cover for it locally here.
Enumerable#min, Enumerable#max ?
Gaia have a new policy to move all `init()` into module's own file. I don't blame you here coz we have not fix others yet.
Agree :), will modify it
You're recreating the regexp over and over. You should only do it once, when you start the enumeration, and pass the regexp to this function.
Nit: regi*s*ter (typo)
I didn't know about that.  Cool!
var detail = evt.detail;
This code in JS... Is it impossible with CSS only? Because performance is not the best with this method, due to we are `computing` a lot of styles in JS and even the transition is not working properly...

@basiclines Any help on this?
@jmcanterafonseca sure, I'll do that.

@albertopq Ah, thanks for that hint. Makes sense, I think we should really just clear the textFields cache then.
Done! Thanks ;) And also the rest of "0rem" appearances... ;-)
what about the following counterproposal for this method

if(!devContact.photo) {
    devContact.photo = [];
  }
  devContact.photo.push(fbContact.photo[0]);

  if(!devContact.tel) {
    devContact.tel = [];
  }

  if(Array.isArray(fbContact.tel)) {
    fbContact.tel.forEach(function(atel) {
      devContact.tel.push(atel);
    });
  }

  return devContact;
Please open another bug for that.
What is `children`?
This is broken. Hint: if fragment_position == -1, then `href` ==> `''`
it depends...
我没看到妳人物的性格设定啊。
写出来，我看看。然后能更好地帮你把握作品走向。
Please rename these parameters to `:api_id` and `:api_key`.
Every other service binds to the private IP on the box - `HelperFunctions.local_ip()` in Ruby-land, and explicitly not `127.0.0.1`.
Same as before w.r.t. the security problem here.
I think the recent connection list would be better if it reacted on _double click_ and not every time an item selection has changed.

Also with the redesigned recent connection list appearing in a separate tab in the toolbox we should make it so when the user double clicks it automatically switches back to the connection tab.
I would also return just the list in here (API change I mentioned from).
Reach (2005 - http://arxiv.org/pdf/astro-ph/0507139v2.pdf) list three different contributions to the uncertainty for aperture fluxes, so we may want to check whether we should include all three here.
This is a little hard to understand, and it's critical math stuffs to get right.  It would be a bit clear if the nested referencing was broken down more, and/or a comment was added describing why.  This would also help with future maintenance, since it would be less obscure.
I like that you added an explicit setting for this instead of it being inferred from another property.
can we keep the code style consistent? that is to say:

- space between `if` and first `(`
- camel-case variables.
What will happen if "usr/share/fonts/truetype/" doesn't exist?
Sorry for that, I'm not used to this CS...
you use spaces instead of tabs for indentation - or so it seems
[Spin](http://spin.com/)はBackboneのModelsとCollections、それとカスタマイズした`sync`メソッドを利用し、サイト内部のAPIから[新着ニュース](http://www.spin.com/news)を取得しています。他の「ページ」にクリックして遷移したとしても音楽の再生を停止することがないように、Spinはサイト内ナビゲーションでBackboneのRouterを利用しています。
dont think we should do something with it atm
this appears to need the current logstash/time renamed to time_addon, yes? I'll do that.
is this correct condition?
You should move this on top, before it is used.
Could you simplify to something like this instead ?

```js
function getFrames(window)
  return Array.slice(window.frames).reduce(function(frames, frame) {
    return frames.concat(frame, getFrames(frame))
  }, [])
}
```
This index.php unlike other pages. The content only displayed specifically on homepage only. There will no be second time display on other pages. So, I not sure whether it should be put below or not.
Do you know why we need more ttys ?
Space betwee i=0 ?
yes. What would that be?
It would be much easier to read a positive assertion here.
I don't know the parser well enough to easily determine whether these tests are useful... but it seems like it would be worth double-checking it and possibly porting some of this to spec or acceptance tests if you didn't already do so.
Maybe add a link to the website of Notepad++?
Ouch! You just dropped some knowledge on me.

You're right; as far as I can tell the one-line rescue's argument is
merely a return value, not a specifier. I'll make a new PR to fix that
(since in the rare case Process.wait raises a *different* exception
it'd be nice not to swallow it).


On Sat, Jul 7, 2012 at 9:41 AM, Brian Henderson
<reply@reply.github.com>
wrote:
>> @@ -304,6 +304,8 @@ def test_execute_rdoc
>>        assert_equal 0, e.exit_code
>>      end
>>
>> +    Process.wait rescue Errno::ECHILD if Process.respond_to?(:fork)
>
> thanks @alexch for getting back to me. What I mean is that when you rescue like that, you're describing the return value, not the Exception class to rescue.
>
> ```ruby
>>> Process.wait rescue Errno::ECHILD
> => Errno::ECHILD
>>> Process.wait rescue 'return value'
> => "return value"
> ```
> also,
> ```ruby
>>> begin Process.wait; rescue; Errno::ECHILD end
> => Errno::ECHILD
>>> begin Process.wait; rescue Errno::ECHILD; end
> => nil
> ```
> (I only have 1.8.7 in front of me to test, but I'm pretty sure 1.9.x does the same)
>
> I realize this is a very minor issue. I do think it would be nice if ruby allowed for specifying the exception class in this way.
>
> thanks for your time.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rubygems/rubygems/pull/352/files#r1118440



-- 
Alex Chaffee - alex@stinky.com
http://alexchaffee.com
http://twitter.com/alexch
yeah, I'm not sure whats up with that, but it's showing up in the middleware stack when I remove that line.

```sh
rake middleware |grep Lock

use Rack::Lock
```

I've been starting with `puma`
Maybe clone the exception and set the previous one to `$e`
This must be undo, is JS
Removing this appears to break a number of tests -- particularly testSetGetHasAndRemoveItemWithNamespace and testSetGetHasAndRemoveItemsWithNamespace. Seeing if I can safely re-introduce it.
Disagree. `a` is small good name and if you are following conversions everything is clear.

**This** looks unreadable for me (just like a mess):
```D
return modules.map!(modName => modName.splitter('.').array())
	.map!(splittedName => Module(
		null, splittedName.join("/") ~ ".d",
		splittedName.length > 1 ? splittedName[0] : null,
		splittedName.length > 1 ? splittedName[0 .. $-1].join(".") : null,
		splittedName[$-1]
	 ))().array();
```
I'd much rather have this be a LINQ query rather than a T-SQL string.
why not just `var obj = {}`, we just need to be able to test object identity and for that object literal is good enough.
`201` this mofo.
you could require ``2.1.*`` for the symfony bundles as they have the branch alias
Missing line break between control structure and assignment
```php
<?php

if ($found) {
    $dest = $name;
    break;
}

if ($name == $target) {
    $found = true;
}
```

and this avoids the use of else (with the same result)
typo Verbinden missing 'r'
This was more like preparation for `Buzz\Browser` mocking, but I gave up =)
Is it necessary the `!`? I think it suffices with `redir >>`.
It seems that 'bring-windows-to-current-workspace' is not referenced in files/usr/share/cinnamon/applets/window-list@cinnamon.org/applet.js, right?
Let's be consistent and use hex for all colours (`#fff` is shorter and more in-line with the other CSS).
Not sure if we need this anymore.

If we don't fire a ready event until we have a duration, as per the HTML5 video spec, a video will never have a duration before the ready events. So, there is no need to get a duration from a getter if calling the getter when we don't have duration would mean before we fire ready events, which means it is incorrect usage of the API.

Instead just fire the
This should probably still be url, as input elements support it as a type https://developer.mozilla.org/en/HTML/Element/Input
The switch is fine, remove the TODO.
push -f したくてもいいんじゃない?
I'm ok with this, Kevin?
this is only called from within the camel callback/. moved the defs there to prevent confusion.
By default, all ChildReference implementations will say they support (efficiently) finding a ChildReference given a child's node key.
CS: space inside parenthesis
> This regexp isn't used at all. The name wasn't the problem, it's removal was.
the regexp is used here.
same with dest, we need to throw the exception somewhere. if there is no failing test, it probably means that we miss a test for that situation.
Remove that in the test app otherwise it is nearly impossible to debug the app (or is there a trick?)
not used, weird
^c ^v error
Why require :type-fns at all? Seems like it would be more generic to just let the user supply those functions directly. I think that would make it more generally usable, and we'd be able to support arbitrarily complex validators (which are just predicates).
My preference would be that we didn't shadow the name of the actual `jdbc` function here. The logging has a side-effect, so I think we should explicitly require people to use it. But that's a minor point...handling naming issues is what namespaces are for, after all.
I think the default should be much lower for HSQLDB...like maybe 7 days or something. Otherwise I'm worries people will blow out their RAM. :(
This should instead behave like Refinery's Guardfile:

```ruby
:cli => (['~/.rspec', '.rspec'].map{|f| File.read(File.expand_path(f)).split("\n").join(' ') if File.exists?(File.expand_path(f))}.join(' '))
```

From https://github.com/resolve/refinerycms/blob/master/Guardfile#L24
And the groups API does as well? Isn't that a bit confusing for other modules that want to modify membership (if there were any)?
I think this should be Content, as the entire content object is returned upon creation.
and the "copyin" in Constant and Texture is also different, so I don't want to make it confused.
I was wondering about that. I included the :tag_name since it was included in the Element#generate_ruby_code method.

I assume the :tag_name could/should be removed from both places (assuming all tests still pass)?
You are sending this "move" operation to self.target(), which is the world, so the operation is trying to move the world, instead of moving the inventory item.

Change this line to say ...., to=tar) at the end, and it should work. I have confirmed this works on my machine.

In the case of "create" operations, it doesn't matter as much which entity they are sent to, as the thing to be created still works either way. WIth "move" it is vital that the move op is sent to the entity being moved, or the wrong thing happens.
Cool. The more you know... :)
А почему сразу не писать:
```objective-c
NSLog(@"Hamming distance: %d", [cellOne hammingDistance:cellTwo]);
```

Лишняя переменная
Вы не поняли - я про проценты. Вы хотите передавать методу проценты больше 100?
Use the 'type' field I talked about csslint_via_node.js comments to determine which underlines/messages to use. It should not all be dumped into errors if you actually know it's a warning.
It is used by devise
It should! Weird, I've verified it actually included the files in tarball :-)
yeah, I'll buy that, updating
no need for commented out code
Thanks - is this something we would like included in the current pull request? I am fine going ahead and including this as well (in fact, might be good as we are discussing the fetch API) if you feel that is appropriate, I just don't want to make this pull request too much of  moving target as far as feedback, revisions, etc.
Is this sleep necessary?
ahh I'm sorry... jumped the gun on that one.
Could you add the spaces around the `=` in this assignment?
I don't know why you changed the API.

why not keep the init as it was?

the only change I see in that the whitener should be computed in the decompose use RandomizePCA.

using class method you duplicate all the parameter definition that is common between raw and epochs
I think this may need to be `self.info['lowpass'] = min(h_freq, self.info['lowpass'])`.
add style: "query" property
This is different than `values_dict`. Is it possible to return a list of tuples, where each item in the tuple is each field in the index? Similar to django models?
In python mutable parameters are modified in place. It is saner to set them after, more about this: http://effbot.org/zone/default-values.htm
I'd put this in normal code "ticks" instead of the "bold"

    `web/.htaccess`
@WouterJ ok i'll fix it. But i think that should be said in the guide as well. Also it feels like a double standard.
you should use the ``:method`` syntax to link to the phpdoc of the method
typo: `system`
Could we get a comment on this function saying what it does and why it's necessary?
This only removes the key out of the index, but doesn't remove it from the cart.  I like where you're going with this, but I'll have to think about how to implement it a bit more...
I actually wrote this line of code before we had a discussion about it.

I'd like to see if the server (and the client, who obviously isn't) is ready to handle the case of a file that gets removed while another user is editing it.
Not recommended. Have a look at the uses of akka.util.NonFatal
I think this is overly strict. For example:

```js
var a = {foo: 42};
var b = Object.create(a);
b.foo; // 42
b.propertyIsEnumerable("foo"); // false
"foo" in b; // true
for (var key in b) console.log(key); // "foo"
```

Philosophically, I want to iterate over inherited properties here; if you want to derive a new object from a prototype object, that should be transparent.
Разница в порядке цифр, например. Американцы сначала месяц, потом день
показывают.


12 декабря 2012 г., 13:44 пользователь Maledictus
<notifications@github.com>написал:

> In src/plugins/blogique/blogiquewidget.cpp:
>
> >  	{
> > -		S_ParentMultiTabs_ = tab;
> > +		QStandardItem *dateItem = new QStandardItem (entry.Date_
> > +				.toString ("dd-MM-yyyy hh:mm"));
>
> Я не понимаю все равно. Какая разница буду я выводить формат локальный,
> или свой, если там только цифры, плюс short формат уебищен чуть более чем
> полностью
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/0xd34df00d/leechcraft/pull/153/files#r2390505>.
>
>



-- 
  Georg Rudoy
  LeechCraft — http://leechcraft.org
Как-то странно control flow выглядит. Я бы, опять же, написал бы что-то типа

    if (...isEmpty ())
    {
        emit profileUpdated (data);
        return;
    }

    а тут уже обработка ошибок.
Старый код в новом пулле, ок :3
Пробел между `){`
No lo genera


2012/12/6 Alpha <notifications@github.com>

> In source/CommonJobs/CommonJobs.Mvc.UI/Views/MyMenu/Order.cshtml:
>
> > @@ -11,32 +12,38 @@
> >
> >      <div class="alert alert-error alert-block" data-bind="visible: isOrdered">
> >          <div class="row">
> > -        @using (Html.BeginForm("GenerateOrder", "MyMenu"))
> > -        {
> > -            <div class="span3">
> > -                <strong>Pedido ya realizado.</strong>
> > -            </div>
> > -            <div class="pull-right">
> > -                <a href="#" data-bind="click: toggleProcessButton" style="color: #B94A48;">
> > -                    <small>En casos excepcionales, es posible volver generar el pedido teniendo en cuenta los últimos cambios<span data-bind="visible: !isProcessButtonVisible()">...</span></small>
> > -                </a> <input type="submit" class="btn btn-danger btn-mini" style="font-size: 85%;" value="¡Generar ahora!" data-bind="visible: isProcessButtonVisible()" />
> > -            </div>
> > -        }
> > +            @Html.HasActionPermission("GenerateOrder", @<text>
>
> Mi idea era simplificar la escritura de HTML dentro del método, en este
> caso parecería que estarías envolviendo un form (seguramente esta función
> sería un wrapper de BeginForm), y si bien soluciona ese problema, ¿aplica a
> las situaciones que necesitás? Por otro lado, ¿qué pasa si no tiene
> permisos y por tanto no querés generar un form?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/241/files#r2335389>.
>
>
I suspect you're right that we can get a big speedup here. I'll work on that right now.
You should possibly prepare and collection of statically compiled patterns and use that before the match() call. That will improve the performance quite a bit. The matches() call is going to compile the pattern for you every time on every request.
As @tolmasky said this should be

```objj

if (WHATEVER_BROWSER_CAUSING_PROBLEM)
{
    [resizeTimer invalidate];
    resizeTimer = [CPTimer scheduledTimerWithTimeInterval:0.2 target:self selector:@selector(actualResizeEvent) userInfo:nil repeats:NO];
}
else
    [self _actualResizeEvent:aDOMEvent];  // maybe we need this in the processing method
```
Blank line above `if` please.
@addisonj Right, only on nodes which have the arbiter attribute set. But there's nothing preventing you from setting that on a node with the replicaset or default recipe.

@lackac Thanks, I figured that (or something like it) was your intention with this change.

It's still something of an open question how to manage multiple pieces of MongoDB infrastructure on a given node. In #41 I make a proposal for removing many of the node attributes and recipes -- the mongodb cookbook would primarily provide examples and LWRPs.
oh duh... details details
this 512 should be the flavor itself right? i know u didnt create this but i just noticed it.
This is the same as:
~~~clojure
[(my-take pivot a-seq) (my-drop pivot a-seq)]
~~~
Since it's an exception, use the Log class
Do properties still make sense with the new cache store configuration?
To avoid this kind of diff where the last line `cache.properties` is marked as modified while it's not.
We can't move that into the `beforeEach` as we want to be using a different diff in each of the `it` blocks. 

:+1: on the copy though, how come Specta will call it after the method returns?
Yes, I wanted to get across the point that newly plotted lines increment a colour cycle. I don't think I accomplished that very well. Your suggestion would be much clearer.

Sorry about the spelling.
This seems to me like an odd, and not very readable, way to break up this chunk.  I would break it after the comma, not
the parenthesis,
and probably put the "for xmin..." part on a separate line.
remove this one as well
I don't know if we need these line docs -- I'd prefer that the code document itself, and that we include a high-level description of the logic above the function (or in the docstring if appropriate).
I see.  Well, I'd still change it, maybe, since it's easier to understand.
 Your call.

On Tue, Aug 21, 2012 at 9:30 AM, David Petrovics
<notifications@github.com>wrote:

> In src/clj/forma/hadoop/jobs/preprocess.clj:
>
> >    [dataset ascii-path pail-path s-res & countries]
> > -  {:pre [(#{"hansen" "vcf"} dataset)
> > -         (string? s-res)]}
> > +  {:pre [(string? s-res)
> > +         (#{"hansen" "vcf"} dataset)]}
>
> Hey-- not sure if I'm missing something here -- , but preconditions dont
> need to be have a value of 'true' , they just need to be truthy. If you do
> (#{"vcf" "hansen"} "vcf"), it will return "vcf" since its in the set
> (otherwise nil). It doesn't actually have to be 'true' to pass the
> precondition. The function true?, on the other hand, requires a value of
> true.
> user> (defn foo
> [dataset]
> {:pre [(#{"hansen" "vcf"} dataset)]}
> "it passed.")
> #'user/foo
> user> (foo "vcf")
> "it passed."
> user> (foo "somethingelse")
> ; Evaluation aborted.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/reddmetrics/forma-clj/pull/203/files#r1426240>.
>
>
@gsilver Can you check all the files and change the double spaces to a single one, before the `role`?
This method hands any useful objects from the IndexingHandler so that a plugin can do what it wants. The AuthorizableIndexingHandler is expected to add fields to the indexDoc and exit, or to throw an AuthorizableIndexingException if it cannot preform its work.
Use instance of SGMatrix - it is pretty lightweight
Same for `what_is_a` and the variables used in there, not following coding conventions. In addition, that's a really confusing name, and not very common for our APIs to use natural language like this. I don't see a name for this token mentioned in the PHP security release, how about `getCorrectnessLevel()`?
you could delete this file entirely by using the composer autoload file as phpunit bootstrap as you don't do anything else than requiring it
yeah redis stores everything as a string.  if you use rails caching, it stores serialized type information too, so you can pull things out and cast them to their appropriate type.
I have no idea :-) The reason I was using ticks before was that it sounded grammatically incorrect otherwise, but I say as long as the sentence reads fine, leave the backticks out?
A similar filter already exists for the unit price, a few lines above, I think 'woocommerce_cart_item_price_html'.
is there a situation where userList ends up not existing since it is initiated in app.js?
you should compile it to ``if (null === $twigExtensionCacheValue) {`` to follow the Twig CS
cs,  добавить пустую строку в конце файла
Yeah, I actually have that already in my local repo's amended commit :)
It's not clear where result is being set.
This can also be written as:

    counter++
I allways keep in mind to ease developers work. Why don't save us the folder creation when we need it? If we cover the noSave requirement the method will remain really simple to use but flexible to any needs.
Same issue with the translation of queue discussion as noted in one of the other files.
As I was simplifying the inheritance chain for tickets in the now closed
remember me pull request I removed the empty Base class. Although I think
the Ticket class is gone now too (it's a module) and this isn't covered by
tests so if it's broken again my running them wouldn't  have caught it.
On Nov 21, 2012 9:29 AM, "Robert Mitwicki" <notifications@github.com> wrote:

> In tasks/db/migrate.rake:
>
> > @@ -5,8 +5,8 @@ namespace :db do
> >
> >      require 'casserver/server'
> >
> > -    CASServer::Model::Base.logger = Logger.new(STDOUT)
> > +    CASServer::Model::Ticket.logger = Logger.new(STDOUT)
>
> Why did you replace Base.logger by Ticket.logger?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rubycas/rubycas-server/pull/123/files#r2195119>.
>
>
I don't know what to tell you. You do see it in pull request diff?
Looks good. But there is unnecessary space around.
You are not doing any verification here on the value POST. This is bad.

You should really be using Django forms.
I thought so but then I found this in django.po file. So I should fix this too I guess. 

`msgstr[0] "Potrditvena koda bo veljavna %(CONFIRMATION_TOKEN_VALIDITY)s dni."
msgstr[1] "Potrditvena koda bo veljavna %(CONFIRMATION_TOKEN_VALIDITY)s dan."`
I rather see my approach of adding to the context if the value should be there. So not setting it to None, but not even being in the dictionary if the value should not be there.
I would not hard-code this!

I would extend our backend classes with a method which returns a tuple for the image for that backend (or None, if not supported). And then I would iterate over all authentication backends here and construct this choices.
If I understand correctly, you want to have password fields in the same form for other account changes? I would make a separate view/form for password changing. A form which would also require old password to type in. You will probably have to reuse that form also for password recovery.
I suggest you use `window.console.log` when developing. Also, always add TODO comment to remove it. So that we do not forget.
Just asking to have the function "run_instance" documented.
It does work. That's why I abstracted it out that way. However, your solution is much better. I'll have a patch in a minute.
`modelid1`=11686, `modelid2`=169

\*cough\*
no dreamweaver javascript allowed. remove the menu and I can show you how to apply the same thing in jquery.
You're right. I'll update that.
Do you mean something like this :
```php
foreach ($this->_availableTokeninputOptions as $option) {
    if (null !== $options[$option]) {
        $view->vars[$option] = $options[$option];
    }
}
```
maybe a quick comment could help on the localtime stuff :)
unused, to be removed
"if `value` is a promise"
@cfirth1005 Maybe we can use PURL's API to give us the VSite? something along

```
  foreach (array_keys(_purl_options()) as $method) {
    $processor = purl_get_processor($method);
    $value = $processor->detect($url);
    $elements = purl_parse($processor, $value);
  }
```
Also this is only displayed if the resourceInfo is erroneous according to its responsecode.
docstring, It's not obvious to me what the difference to 2 steps of SysGLS is.
Oh. I see.

On Mon, Aug 13, 2012 at 5:29 PM, Hunter Haugen <notifications@github.com>wrote:

> In templates/server.conf.erb:
>
> > @@ -158,8 +161,13 @@ comp-lzo
> >  #
> >  # You can uncomment this out on
> >  # non-Windows systems.
> > -user nobody
> > -group nobody
> > +<% if openvpn_user != '' -%>
> > +user  <%= openvpn_user %>
> > +<% end -%>
> > +
> > +<% if openvpn_group != '' -%>
> > +group <%= openvpn_group %>
> > +<% end -%>
>
> Even if with nobody:nogroup, openvpn_group will still not be an empty
> string. Do you need this conditional here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xaque208/puppet-openvpn/pull/1/files#r1368374>.
>
>



-- 
Spencer Krum
(619)-980-7820
As @iigorr states - please make this return something meaningful
Our typical pattern is to avoid switch/case, and instead have an object containing key-value pairs, where the key is the type of media, and the value is a function to be run. So:

```
var handlers = {
      'video/mp4' : function() {
        // ...
      }
    }, 
    media = this.baseObj.media;

if (media && handlers[media.type]) {
  dojo.hitch(this, handlers[media.type])();
} else {
  this.page.showScreen('index');
}
```
should these be here?
Also: I pushed this change.
Haha yes, thank you!
bootom -> bottom :)
I think the main new things in this script are doing the tiled image, so dealing with referencing subimages with bounds and such, and the uses of UniformDeviate and GaussianDeviate.  I can put that in the comment here.
in general, try to rename the labels that you create to help avoid merge issues
done, using Double.MAX_VALUE as im asigning it to a double :)
seems like you're now ignoring the filename and just using problemset_to_exercise_id as matching-- I wonder if this will cause problems when we're scoring rather than just counting completion.
I think that it would be clearer with :
Assert that the actual object is lenient equals to given one by only comparing actual and other fields unless the given "ignored" fields.

We should add an example here because it is not easy to understand what method does.
Did not realize this was the source all along. Good riddance!
it was duplicate, my friend.
Do we need to invalidate the previous scan at all (e.g. isLoaded = false).
this code will likely useful -- currently location definitions don't show inherited properties (e.g. if identity is declared in a referenced location there is no indication); however with this code we see way too much (everything in brooklyn.properties and System.getProperties() !!).  we need a halfway-house at some point (but location details is not high priority.)
how about change the check below from app.isDeployed to mgmtsupport.hasEverBeenManaged or similar?  is that tidier?
Does it fail without this line? The "page.should have_link..." line below should automatically wait until the link is visislbe, so a manual wait for 2 seconds shouldn't be required.
onStart, onFinish are declared in the parent, we can remove them here
Shouldn't the body of the try/catch be indented for CS?
miss the header
`js` -> `scripts` for consistency with other demos.
I actually found the use of standard lib methods quite confusing at first. I'd probably have found it easier to read if you've defined a few methods in a Background then used them as the test victims.

Otherwise, great work. I love the detailed explanation in the feature description.
Повернути як було чи перейменувати параметер?
Was using it for debugging the distributed process and forgot removing the
import. Fixed and pushed.
/Pontus


On Fri, Mar 9, 2012 at 2:26 PM, Valentine Svensson <
reply@reply.github.com
> wrote:

> > @@ -3,22 +3,31 @@
> >  import os
> >  import copy
> >  import glob
> > +import socket
>
> What is socket used for?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/SciLifeLab/bcbb/pull/114/files#r538813
>



-- 
--------------------------------------------------------
Pontus Larsson, PhD
Science For Life Laboratory
www.scilifelab.se

Email: Pontus.Larsson@scilifelab.se
Phone: +46 8 5248 1440
Mobile: +46 76 946 9788
--------------------------------------------------------
Not required, but could you wrap the ternary in parenthesis to make this easier to read?
Compare:
```php
$user->gender = ($wannabe->gender == 'male' ? 'Male' : 'Female');
```
I'm referring to that. It has nothing to do there. I'll shove it into human/Life.
Te informo: Esta pequeña parte es un vestigio del sistema anterior. Ahora está movido todo e MySQL tabla "config". Falta rematar este asunto y así poder quitarlo.
I'll admit that this may be a bit nit-picky given that it's a private method.  The update I had made locally, as you point out, was to move the cast to the calling method purely for the sake of API clarity.  It just feels dirty to me to have a method say it needs a Job when it really needs a StepLocator and if I pass it just a Job, I get an exception thrown back at me.
Кажется, что создание-копирование массива - совершенно лишнее.
Надо одинаковый код выносить в отдельный метод, а не делать copy-paste.
Ah, gotcha. Well, if you -- or anybody reading this -- is interested in something like that I'd be more than happy to merge in a pull request.
This cursor should be in a try/finally block with an explicit close. If you are able to successfully iterate through all of the documents in the cursor, it is automatically closed. However, if there is an exception while iterating, you will leak a cursor.
ドメインクラスとして「の」
I think `the Google Group` should link to the group itself, without forcing people to hunt it down themselves - wdyt @justinfrench ?
I'm a bit worried that allowing such images might break existing code which also depends on conventions such as ``M, N = image.shape()``.
Skipping the `LabelEncoder` entirely is fine with me.
To me it doesn't look that big. It's like adding a feature to `X`. Not sure what the others think though? @pprett @bdholt1 @amueller
+1 for `intercept_{visible,hidden}_`.
A feature importance nosetest fails after removing this line. Will investigate later.
test comment from SG
Also, this is not enough. If MX record does not exist, SMTP fails back to A (or AAAA) records. So check `socket.getaddrinfo` is also need. So four checks should be done:

* `dns.resolver.query(hostname_part, 'MX')`
* IDNA version of `dns.resolver.query` check
* `socket.getaddrinfo(hostname_part, None)`
* IDNA version of `socket.getaddrinfo` check
Absolutely, great
I disagree :tea:
does this happen if the review was made, but also failed for some reason? is it possible for _make_review to return a non-None value on failure? seems like a kiln api bug if so
Because it's defined as both a class and a struct in different places. Should be the same in all definitions.
It has methods, so I changed it to class.
I would rather this was $reset than $no_reset and it used a boolean value. So it was initialised to true and set to false if the option exists. This then fits better with the comments below about avoiding the double negative of !$no_reset
Please also make sure there are `\0` in setLength. I'm thinking something like this:
```
int oldSize = internalData_.size();
if (lengthValue > oldSize)
{
    internalData_.append(QByteArray(lengthValue - oldSize, '\0'));
}
else
{
    internalData_.truncate(lengthValue);
}
```
do we really need this forward declaration?
We need to throw exception here.
ok. got it. I was used to (-pi, +pi]