better error-reporting when the user's admin settings
are blocking browser channel

R=dbk
DELTA=78  (73 added, 0 deleted, 5 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4607


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1774 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Fix serverchart_test to no longer depend on ordering of query
param from Uri#toString().

R=gboyer
DELTA=7  (4 added, 0 deleted, 3 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4608


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1775 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Fixing location of the js_locale_data build file in locale.js comments.

R=nicksantos
DELTA=4  (0 added, 0 deleted, 4 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4609


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1776 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Add 'scope' parameter to the static 'wait' functions.

R=nnaze
DELTA=53  (40 added, 0 deleted, 13 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4610


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1777 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Add example usage of primitives in the respective javascript files.

R=nnaze
DELTA=106  (106 added, 0 deleted, 0 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4611


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1778 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Fixes goog.ui.Textarea.decorate

a previous cl made Textarea call the superclass's enterDocument method. While
this worked fine for the render() code path, the decorate() code path
was broken because TextareaRenderer wasn't changing the supported states,
causing goog.ui.Control to register additional key event handlers that
caused <ENTER> to be ignored, which prevented new lines from being entered in.

R=nnaze
DELTA=1  (1 added, 0 deleted, 0 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4612


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1779 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Fix bug in goog.ui.Component where enterDocument was called on
components that weren't in the DOM yet.

This used to cause "already rendered" exceptions when you would
addChild(child, false) for a child whose DOM has already been created
(for example, if the child itself had a child).

The original code is kind of looney. I'm not sure why people would rely
this behavior, but perhaps it was to hack around a bug in the unit
tests; I fixed the unit tests.

This will probably break things, but this fixes a big hole that people
constantly run into.

R=nicksantos
DELTA=66  (55 added, 0 deleted, 11 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4613


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1780 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Make jsunit compiles in JsLibTest. externs w3c_dom1.js defines
Window.prototype.onload to be ?function(Event). Thus
JsCompiler complains that we are calling onload with no
parameter.

Also make benchmark.js assigned window.unload to function(e).

R=nnaze
DELTA=4  (1 added, 0 deleted, 3 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4626


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1781 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Adds map_perf.js to run benchmark of goog.labs.structs.Map
against goog.structs.Map. This perf test needs to be compiled
because the assertions, access to multi-level deep object
(BrowserFeature) are taking a significant chunk of
compilation.

The result is that goog.labs.structs.Map is slightly slower
than goog.structs.Map. The reason is that it does string
comparison check for '__proto__', while the original Map
doesn't. (The old map doesn't support key = '__proto__'.)
Removing the check makes the labs version slightly faster
in all tests. This is for latest Chrome/FF -- I have not
run this on other browsers.

R=nicksantos
DELTA=225  (225 added, 0 deleted, 0 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4627


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1782 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Remove @protected from getBackgroundIframe() function. The main purpose is so
that the caller can add a classname to the iframe.

R=chrishenry
DELTA=2  (0 added, 0 deleted, 2 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4628


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1783 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Allow passing a custom MenuItemRender to goog.ui.ComboBoxItem.

R=vbhasin
DELTA=4  (2 added, 0 deleted, 2 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4629


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1784 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Adjust getComputedStyle to not return null.

It appears getPropertyValue can return null- which results in this method
breaking its contract of being non-null [transitive effect is getBox can
result in a bunch of NaN's]

R=nnaze
DELTA=1  (0 added, 0 deleted, 1 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4630


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1785 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Rename namespace goog.ui.AutoComplete to goog.ui.ac.
The goog.ui.AutoComplete class was renamed into goog.ui.ac.AutoComplete.
Aliases from new goog.ui.ac to goog.ui.AutoComplete classes were also added.

Also replaced the goog.ui.AutoComplete.Basic class with a factory function goog.ui.ac.createSimpleAutoComplete.
I left the old class, though, because it needs to be replaced in existing codebase first.

I verified that this works using the old and new namespaces by patching this onto some code that uses autocomplete. I also ran all tests and SQs I could think of.

The next step that I forsee is making a pass through existing codebase to find usages and changing them to use the new namespace.
After this is done, I'd like to add a deprecation notice to the aliased classes/enums and/or finally remove them (I'll leave that in your discretion).

R=chrishenry


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4631


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1786 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Allow for transparent SolidFill instances.

Transparent fills are useful because they will receive mouse events, whereas
if there is no fill, mouse events are ignored.

R=arv
DELTA=57  (54 added, 0 deleted, 3 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4632


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1787 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Swap in goog.async.AnimationDelay for goog.fx.anim
the tests that this broke last time were fixed
in separate cls

R=steineldar
DELTA=230  (8 added, 173 deleted, 49 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4636


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1788 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Fix stack trace capturing
R=skobes
DELTA=25  (25 added, 0 deleted, 0 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4645


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1789 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Fix a listener leak in field.js.

Ensure the field load listener is cleared on dispose.

Don't use the event register, because the event register may be cleared
more frequently.

R=nicksantos
DELTA=1  (1 added, 0 deleted, 0 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4646


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1790 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Fixed positioning logic for menubutton in RTL.

R=ssaviano
DELTA=6  (5 added, 1 deleted, 0 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4647


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1791 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Automated g4 rollback

*** Reason for rollback ***

Broke positioning

*** Original change description ***

Fixed positioning logic for menubutton in RTL.

R=ssaviano
DELTA=6  (1 added, 5 deleted, 0 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4648


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1792 0b95b8e8-c90f-11de-9d4f-f947ee5921c8

Fix a tiny typo.

R=azzie,nicksantos
DELTA=1  (0 added, 0 deleted, 1 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=4649


git-svn-id: http://closure-library.googlecode.com/svn/trunk@1793 0b95b8e8-c90f-11de-9d4f-f947ee5921c8