labofsahil/github-event-dataset-2012 huggingface dataset:
Could you test that? I don't think the technique of `deepMerge`-ing data will work with collections.

Which leads me to: why do you access `data`, or explicitly call `parse` at all? Could you not call `updateWithApiData` on the instance with the data in the sideloaded JSON?
can you please reduce the number of blank lines in this method? only do a blank line if something is really a separate step.
In case features.json is not present or broken (for example the first time you run it) the .bak file is used... Should I rename it?
What formatting are you referring to?
I think your editor may be off by +1 char (or maybe mine is -1)? At any rate, this is +1 char limit over the rest of Enaml.
utils pacakge uses 
```
if(tools:::.OStype() == "windows") {
  export(readRegistry)
}
```
But I'm an aware how to add system dependent NAMESPACE declarations through roxygen2, might be useful.

see <http://svn.r-project.org/R/trunk/src/library/utils/NAMESPACE>
This removes articles in categories 30, 40 and 50 from the All Knowledge Base Articles total.
That sounds like... overkill.
To make this work on F3 i would propose to have 3 uint16_t to represent either STATE_ERASED (all 0xeeee) or STATE_RESERVED, STATE_ACTIVE, STATE_OBSOLETE (0x0000 each). There are other ways to do this though.
When using `===` everywhere in js code is considered very great practice, `== null` compare is the only good use case of the operator. For example, it's used in coffeescript as `variable?` operator.

It doesn't break stuff, but it's just a brunch convention.

I don't know why jslint don't like it. I know it's became shitty recently, but even its neat brother jshint thinks the same way.
This is a clever tagging trick which facilitates easy lookup of points via the `PointSet` object that `World` wraps its points in. it's a bit of a kludge but works surprisingly well.
This is an example of why I think validating the passed Uri is something important. So users don't get their service created and then when they try to use it errors appear.
It's a way to isolate the mixpanel IO thread, and limit access to thread-internal stuff- I wanted to be sure I could tell what was running in which thread.
i don't see any comments on the discussion page that explain why you've made this global...
Why not just id? It's the primary key so uniqueness is garanteed.
wrong indentation here. It should use 4 spaces to be consistent
Please replace with the correct copyright notice and for attribution why dont you include a doc-block for the class and supply the `@author` field.
The TiledTextureRegion doesn't necessarily have two tiles, does it? I'd rather remove both of these methods and let the individual developer decide what to do.
Need info: Can't you just do something like mf.set_value(0)?
Required: You need a `%}` instead of `}` to end the trans template tag.
Ok, I'll push through code with this change.
Thanks for the tips, Tony!  I'll make these changes once I get home from work.
"w in the fomulation formula" -> "w in the cost function formula"
Should just be a dictionary, IMHO.
I was not aware of that, thanks Peter! It's now changed.
I guess this class could also reimplement `score` to take sample weights into account. Since a fair number of estimators already appear to handle sample weights, it might be a good idea to go for @pprett 's idea.  (See the discussion.)
Macht es wirklich so viel Sinn hier einen Observer zu verwenden? Ich würd eine private Methode _updateTrackLength machen die von setTrackPath aufgerufen wird.
the buildScreen creates the buildScreenView and tells it to append itself to the DOM - what exactly would you like to see instead of the current code/test to make it more understable?
shouldn't use time_t, as spec says it must be 4 bytes.
Change the other two uses of TiProxy (initializeTiObject and onCreateStaticMembers)
Updated. Some of functionlity not implemented yet, but will be in next patches.
Apidoc needs to be updated to specify which ones we support from these.

Additionally i don't think we should define the ones that we don't support
It can always call it (the implementation is inline and  efficient if not enabled).  It is dyanmically enabled by setting a bit in the allocator id - call
createCrcRoxieRowAllocator() instead of createRoxieRowAllocator() - see roxierow.cpp
should be shortfall >= UNSIGNED_BITS
I'm not sure there is any benefit being derived from a QuickTransformer.
one more 0 here than above.

perhaps a define / const int value would be wise....
I'm being picky, but shouldn't this be called ```abortSoon```, too? Just to keep consistent variable names...
> Not sure you really need a roxie-specific version of the ecl (the #option etc may not be needed except on Roxie, but it should be harmless).

Maybe that'll work... let me see...

> If you DO have a roxie-specific version of the ecl, you should be adding a //noroxie on the generic one, I think?

No, the regression script will choose the correct one and use it regardless.
It's been 4 months since I pushed this, so I will try to sum up the whole idea again in a single additional comment in this review. It's not that easy to analyze it by looking at some lines on isolation, as basically the change from the single lock scheme to a double one changes many parts of the affected method.
This portion is not really needed and shouldn't be executed in case of non-json logging. Maybe we should split it into two different Loggers after all.
thanks! I removed the puts in commit 9cbf7d2
If we are going to keep this in per @weierophinney's use-cases, then I'm +1 to @Thinkscape's latest suggestion for the `Zend\Stdlib\ArrayTest` class. The `isList()` method name clears up the ambiguity in the definition which was my primary concern in the first place. The other methods I'd probably still classify as YAGNI stuff; @weierophinney only mentioned needing a test for sequential-keyed "lists". We could easily add the other assertions as use-cases arise.
即是 -> 既是
Thanks -- I do intend to pull it out once we have more realistic links to test with. :)
github mangled that, but ah well, not relevant now.
@yuhunglin The reason for using an array is so we receive a sorted list back.
By adding an icon to the Resources.resx Visual Studio automatically adds a reference to the icon in the folder Resources/Icons. So it was added by the VS designer.
> But harder to find all class usages in this code.

I'm curious: Is "right click on 'var'" --> "Find all references" not satisfactory to find all class usages?
yeah that was originally jsut a debugging statement, but it would be sueful to have there.
I don't quite get what you mean by this. I copied this from the scipy doc strings and it works perfectly well for me.
If that's the case, then my documentation comment is even more valid because I clearly have no idea what's going on ;)
Good catch, I'll add the default (I assume I can do [values=[0.0, 0.0, 0.0, 0.0]], we will see what JSDoc thinks of it.
I think it was, I just missed that.  Reverted my change.
This is the check I am talking about above.
Ok. Then what should we use ?
Did you test if here can throw NPE here? If yes, maybe we could check (roles != null && !roles.isEmpty()). Wdty?
Hmm... OK, I'm going to take another crack at this based on your list and see if that's easier to follow.
Do you think there's a value in having the ``spacing-`` classes in here still?
replace with getBounds()
Fix import order?
Before any miscommunication happens; I'd also like to say that these contributions are awesome. Even if not perfect in the first try it helps big time.
Haha mas esta no spec_helper
Is it necessary to uncomment this? These services should be passed as arguments during engine creation.
s/_logo_image_src_locator/_logo_image_locator
Yah, I meant keep everything as it is but demote the case labels. That's in keep with what happens. At any rate it's just a nit.
remove empty line, unless you think this looks superb as it is.
This means null or more input values. I want to explain that in the 
documentation, but maybe this should also be added to javadoc I suppose

Am 2012-12-11 05:46, schrieb Andreas Pieber:
>> @@ -68,10 +68,11 @@ protected DescriptionStringBuilder theOperation() {
>>       protected void checkInputSize(List<Object> input) throws TransformationOperationException {
>>           int inputCount = getOperationInputCount();
>>           int inputSize = input.size();
>> -        if (inputCount == -1 && input.size() < 1) {
>> +        if (inputCount == -2) {
>> +            return;
> what does this mean? No input/output params?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/800/files#r2374074
>
try to use some more specific name; which version should match what?
How about,

```ruby
if node['chef_packages']['chef']['version'].to_f  >= 10.14
```
In my MVC2 project, it was failing because it thought the methods had the wrong number of arguments; it appears that optional parameters were not working, so I had to add non-optional parameter methods.

I thought this was better than requiring 3.5 users to do `Bundles.Reference("foo", null)` or `Bundles.RenderStylesheets(null)` all over.
annotation classes should be value objects only. They should not contain logic IMO. Otherwise, you would have to duplicate many logic if you give the possibility to map it in yaml or xml later.
please don't introduce a dependency to SensioFrameworkExtrabundle.
So should not be commented.
Commenter ?



Le 7 mars 2012 à 12:28, Fabien BROSSIER<reply@reply.github.com> a écrit :

>> @@ -77,6 +83,14 @@ import info.bliki.wiki.model.WikiModel;
>>        relationsMap.put("syn", Relation.SYNONYM);
>>        relationsMap.put("ant", Relation.ANTONYM);
>>        relationsMap.put("tropo", Relation.TROPONYM);
>> +        relationsMap.put("hypo", Relation.HYPONYM);
>> +        relationsMap.put("hyper", Relation.HYPONYM);
>> +        relationsMap.put("méro", Relation.MERONYM);
>> +        relationsMap.put("holo", Relation.MERONYM);
>> +        
>> +        complexNyms = new Vector<Word>(8);
>> +        complexNyms.setSize(8); // The size is force : if a user has made an error, the case is put at null and the algorithm ignores it
> 
> Le constructeur spécifie la capacité de la liste, mais pas sa taille. La différence est que tu peux avoir une capacité de 8, si tu fais un get(4) tu auras une indexoutofbounds exception, alors que le setSize(8) initialise bien une liste avec 8 objets placés à null.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/MattiSG/SemWiktionary/pull/13/files#r527965
Rats. I got this from the numpy doc standard quickly last night. Any idea what the proper way to include a code snippet is?
Can you use double-quotes for the attribute value here so you don't have to escape the '? Here and throughout this file where this occurs
Can these be removed? Since we're describing them in the config.json.
Actually, my first implementation used decorators. At the time, I called the decorator `callback` and applied it to every callback event. But then I noticed that you want to be more careful with a handful of cases (for example, you want to be able to release `SpanSelector` even if you deactivate the widget in-between press and release events---not really sure how likely this is, but the code checked for it). When I realized that the `callback` decorator wouldn't be called on *all* the callbacks, I thought it might get confusing.

I guess renaming the decorator to `check_ignore` (or similar) might make the functionality a bit clearer. My other hesitation was that it may be weird for a decorator to call a class method---seems somewhat magical. I'd be fine with it though.
restore -> restores
Grab all the url parameters now
Up to this point, the runnerConfig.runBeforeRunningSuite and runnerConfig.runAfterRunningSuite seem to be performing the same operations in each of the performance tests.

Maybe we can extract, in the API module, a base class which has this code and use a template method for adding custom stuff. wdyt ?
Wasn't this going to be moved upwards out of this if block?
should remove debugger statements from committed code.
empty line after importing builtins
This would better be written as
```
XNamespace xnamespace = null;
if(document.NamespaceDeclarations.TryGetValue(Utility.GxPrefix, out xnamespace))
{
    if (element.Name == xnamespace + "MultiTrack")
        return new GxMultiTrack(element, document, placemark);
    if (element.Name == xnamespace + "Track")
        return new GxTrack(element, document, placemark);
}
```

This way you only do the look-up once and it's clearer as to what is going on.
crot在调用doc2text时，为何还html_entity_decode()了一下呢？
this link should have the version and account here i believe unless there is some magic happening else where.
Just some thoughts. The json is different from the xml representation... In Json there's a "instance_links" attribute that contains the links and in xml it's just the links. I know nova has done it this way, and we should change it to align with the json/xml. But if aligning with nova is the way we want to go, we'll probably want to push that change into nova. It's not consistent.
Noticed this seems like a pretty common pattern in this class now. Thoughts on splitting this out so there is a common base class and then oauth1/2 classes that extend it?
Both versions are ok'd by pychecker. My patches here remove 9 linter complaints (with respect to the current HEAD) without adding any new ones. Some of the linter warnings I've removed are due to my old code, some were introduced when it got merged in.
I agree, it's not pretty. I'll spend some time staring at it later, but I think you'll still see more than just 8 one-liners.
Seria melhor utilizarmos termos genéricos para reutilização nas demais listagens, tipo: Active, Inactive/Removed. Esta mensagem é só para registrar, não vai impactar no aceite deste pull request.
Maybe info would be better. I decided for the tip/info approach, because I think the behavior is quite obvious. As someone said on the mailing list, there is method overriding, but no constructor overriding. I just see this a clarification side note.
You can do:

    from operator import attrgetter

And then do:

    j['items'].sort(key=attrgetter('getVersions'))

which reads a little nicer.
it is the class 'inner' part of the building blocks? is it really necessary?
try / catch, close in finally?
That might work. I think in that case, I'd like the FolderStorage to be responsible for asking for the headers once the sync is complete. Does that sound like the right way?
this workflow should have inputnodes and outputnodes and can eventually go into nipype.workflows.misc
we have to rewrite this config for a public dataset. it's fine now while we get the sad preprocessing finished. but the point of this repo is a general set of workflows not tied to any project.
This file is really big.  It could probably be split into 4 files.
Can you add just a short description of each of these constants?

DEFAULT: The default Titanium layout arrangement
VERTICAL: The layout arrangement for Views and Windows that set layout: "vertical"
HORIZONTAL: The layout arrangement for Views and Windows that set layout: "horizontal"
This would be very useful, I'm definitely in favor of it...
"blocks"?
Maybe you can add some documentation here. Even if it is just one sentence stating what the class does.
You can see the line #235-236.
This normalize shouldn't be needed. You're already normalizing `file`.
Put a comment to remind people about being above the childWebView
Thanks @pagey
Let's revert
I'll try to find that latest on the day after tomorrow; thx for the reminder

On Tue, Feb 28, 2012 at 16:04, pgrm
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,121 @@
>> +﻿activemq:browse
>
> because of the strange console which is loaded - i can send commands to the openengsb process, but i don't get any response, and i'm also not 100% sure if the commands are accepted - you told me about a parameter to turn this off, we should find it and use it, afterwards it should work smoothly
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/loom-csharp-visualstudio/pull/9/files#r496405
Add CompetitionBackup and SubmissionBackup aliases to createXstream()
Why not use `is_null` instead of `empty`?
I think that's not the case anymore, with the advent of `stdc`.
`public function getEchoTrans($str, array $parameters=array(), $catalog = 'Admingenerator')`

The problem with the fact that the param is in the second position it's that we have to rewrite all template can we find someting better ?
Is the last | normal ?