labofsahil/github-event-dataset-2012 huggingface dataset:
wow. hopefully this won’t create any harm. Can it capture events that were supposed to go to an element behind the container?
Does jslint complain about this double assignment?
yani chi nafahmidam ?
Should it not include interacting e.g. Flint and Steel?
what was it ambiguous with without changing it to formal_?
It's not dirty, but redundant as the directory is already installed using http://unixhelp.ed.ac.uk/CGI/man-cgi?install which copies and sets permissions.
well -- headers are also defining emacs/vim consistent editing besides the codepage.  Also referring to the project's license would be of use to complement original terms since I bet we might introduce changes
need to check for undefined here, too, as in other cases?
You call Util.startDateTime however you don't define this in Util
yes, okay. I am getting it slowly but surely.
This plot looks far less interesting now. Can the number of levels be increased slightly to see any improvement?
Yes - very useful!
Is this really `[{atom(), timestamp()}]` ([erlang:timestamp/0](http://www.erlang.org/doc/man/erlang.html#type-timestamp))?
will fix this, thx
So I assume that whomever has defined their function has done so with as they prefer. For instance, if you want a line with slope m and intercept b, you have defined it as such.
can't see the use of the data argument here
Should this be named `begin`, since you're using SQL terminology elsewhere anyways.
you can use local variable here, not instance.
you added a test case!!  this is revolutionary!
It seems viterbi_mtbl doesn't clear at all, so if you call this function twice, then the table will have two rows.  Is that an intended behavior?
this not static?
This was moved up to buy quite some time. :)
Support for command prompt! Made sure it ran the Node executable that was bundled along, to avoid incompatible versions.
Nice comment--that's perfect!
Even if everything is ok, this cannot go like that.
On Jul 28, 2012, at 12:57 AM, Jack Nagel wrote:
> Not quite this simple; needs to be something like
> 
> ```rb
> system "make", "prefix=#{prefix}", "install"
> ```

Hi Jack,

Thank you for the suggestion. I've committed the change already but let me know if anything else is needed. 

-e
--
Ed Porras
ed@moto-research.com
still some things to make up :)
It will be. We just hadn't decided on a naming scheme/location, so it was a quick solution ;)
This entire function can be removed, it's the same as the one in the Storage_Streamwrapper parent class
We should. I keep forgetting this.
Good point. I knew there was a good reason not to build it out of strings.
Hmm das ist vermutlich das gleiche problem..der filter schein nur auf root ebene zu greifen
Could you move it to its own line and add documentation to it ?
I didn't do it for `request` because I didn't want it to be detailed in the doc.

`use session_stack` is a configuration option so I think it should appear in the doc :)
(and in the README once the feature is complete)
nit: toString() is unnecessary with %s
You just spent the entire 2012 newline budget !
I had implemted that null-safe already. I will re-introduce that.
I think at least up to 1000 I prefer the plain arabic notation.  Thanks.
I think we should get rid of the duplication by extracting this line into a private method. For symmetry, I would extract the assignment to `startNanos` in `starting()` as well.
I like this, I was doing similar but just creating the jobs within the job processor haha
This method is used like a pure function, but it has this side effect of setting the `hasContainer` property. Best to put the `hasContainer` assignment in the same place as the `@set 'node', @_generateNode()` call, to keep the mutations in one place.
so what's so negative about it? I need that value several times and I didn't always wanted to write server.getBanManager().isBanned(playerName) instead.
If the checkbox is changed to an `<input type=checkbox>` you might be able to watch for an 'onchange' event on the element and simplify some of this.
Typo. base -> based
Why did you use `Tower`?
Does `height: 100%` even do anything?
Thinking about it now, do you know how these `el` types work? I know some videos can't be embedded, or viewed on mobile. What about `el=detailpage`? Do you think that would work for every video? If so, then this whole issue could be solved by appending that to every info url, and with just one request.
+1 ; we should figure out a way not to get rid of those. I don't like the way it used to be done in OrbisGIS either (putting them in the test scope).
why the full path to ```PropertyVetoException```? It is already imported in this file.
Never catch all exceptions because this could hide possible programming errors.
I just tried changing the header architecture on a rule and it succeeded, but didn't get saved (ie, a page refresh showed it empty again). So, these need to match the column names in db.py. Don't worry about fixing the other broken one if you don't want to, I can fix that later.
Please add docstrings.
zoomIn does not have this comment.
not really sure why we are killing shadow call here.
I like to have this piece of code in its own class
Returns data from all running jobs in the *proc* directory.
revision is a method in this file...
I think it would be more consistent to swap the two input parameters
yeah, there is a local Set class for the redis Set command, so if I want it
to have the right return type, I need immutable.

On Thu, Aug 9, 2012 at 1:13 PM, Bennett Andrews <notifications@github.com>wrote:

> In finagle-redis/src/main/scala/com/twitter/finagle/redis/Client.scala:
>
> > @@ -5,7 +5,7 @@ import com.twitter.finagle.redis.protocol._
> >  import com.twitter.finagle.redis.util.{BytesToString, NumberFormat}
> >  import com.twitter.finagle.Service
> >  import com.twitter.util.Future
> > -
> > +import scala.collection.immutable
>
> Is this import needed? That's the default I thought
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/tumblr/finagle/pull/1/files#r1344438>.
>
>
You should be able to use find here instead of foreach.
directly copied find_organization method from systems_controller
more pluralization which doesn't really match the convention of other API.  infos isnt really even a word :)
these can probably all reference not_ldap_mode now
There is no rush.

On Sat, Nov 3, 2012 at 3:16 PM, Balassa Máté <notifications@github.com>wrote:

> In src/com/rfo/basic/Run.java:
>
> > @@ -15301,6 +15309,33 @@ private boolean executeMYIP(){
> >  			
> >  		return true;
> >  	}
> > +
> > +///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
>
> I don't have access to my PC (for about 9 hours). I may be able to do it
> on my phone though.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/RFO-BASIC/Basic/pull/1/files#r2024209>.
>
>
Check if CanSeek is true on the source.
commit指定路径
The very first line states:

> Follow this order where possible: display, positioning, dimensions/box model, text & font styles, colours & decoration.
To see if you were paying attention ;)
It's intentional - the top-level sections are ASCII, HDF5, VO, and Other, and the ``+`` headers are sub-sections of ``ASCII``. Do you think this is confusing?
Sure -- this keyword can be renamed.
https://github.com/axsh/wakame-vdc/commit/92e5df53b43c737bfba59ae82cc2a5fd207452b0
另外建议把方法前缀的valid都拿掉，如果每个方法都有的话显得很累赘。
yes, that is a bug
Will revert so this can be merged!
> also I dont understand what you mean by "This also must be taken into account in the control. This doesn't seem to be the case currently." can you explain ?

You should use this:

```
box: {
    keyMask: Ext.isMac ? OpenLayers.Handler.MOD_META :
        OpenLayers.Handler.MOD_CTRL
}
```

in the `handlerOptions` passed to the `GetFeature` control.
which relationship are you talking about? As far as I can tell these are exactly the same as in the old OnModelCreating method, no?

 * A `Room` has many `User`s that are allowed to be in it
 * A `User` has many `Room`s they are allowed to be in

 * A `Room` has many owners
 * A `User` can be owner in many `Room`s

 * A `User` can be chatting in many `Room`s
 * A `Room` can have many `User`s chatting in it

 * A `Room` may have a `User` that created it
Can you keep the old constant as well for BC?
Useless comment?
Put a blank line above this. Reasonable blocks of code are good.
I wonder if this class map is really needed. I mean, each type has a mandatory "typeof" attribute that already holds the rdf name. So if this function is called with e.g. "sioc:post", wouldn't it be enough if the driver iterates over all types and returns the first one where typeof == 'sioc:post'?
Nit: This does an unnecessary allocation on each loop iteration. You could simply do:

mc.incUses(prev, sentence[i], tag)
prev = sentence[i]
Funny message because it should never happened!
But I will change the message.
>Can we push this down into HashAndInsertObject? 

Maybe I should push it upward, into `TfsChangeset` - it appears that my code is taking a stream from a  `TemporaryFile` and writing it to a _new_ temporary file. Perhaps I should just pass a `TemporaryFile` into `HashAndInsertObject` and skip the duplication.
Nore sure what you said there but I'll reaffirm my idea:

Pygments::Lexer does case-insensitive lookups in its index. We should do the same. Right now yes, the default alias is downcased language name, so that's kinda covered, but still. Can't hurt, right
I'd recommend using lists and then use `modifyList`
What's the motivation behind having two DjangoRole's? I think that it would be nice if we can avoid it, and keep only one, in order to avoid confusion. Even if that is a big API change, we could announce this changes for 0.6.0, so that you could make your implementation as the only one. How does it sound to you?
I believe we patch 2.6 to allow `assertIn` here, do you want to make that change while you are at it?

Also, just noting that this will conflict with your own #2089, so it will need a tiny rebase after that goes in.
this should be a set of distinct images in the available nodes
I'd put a code comment above about what this is resolving, just in case someone deregisters this image.
Твои настройки в репозитории и не нужны, для этого файл dist сделан, как написано внизу в README

https://github.com/lblsa/showstaff
ah right. forgot to rename.
no, probably a bad copy /paste (or cut/paste in this case)
this will break only the config file.  the logging options will have to be moved to a section.  I did this because it makes the ini file much neater and more organized.  the logging object itself is created by an aggregator at the same level as before, so it won't break the code.
Is there any gain in duplicating getRequiredBits code for all types? is mast&value cheaper for a short then a long?
Change `server_version` to `api_info`
I get the desire to use `if`, but the fact that the default case has to be `true` rubs me the wrong way... it just reads oddly to me.
Indeed, would be better :)
через ParamConvertor ти можеш на вході отримати одразу потрібний об’єкт Ticket. є купа прикладів як на проекті так і в наших бандлах
I mean, setting a hostname on a collection should also set that hostname on all routes. I don't see why you included `if ('' === $pattern) return;`. If pattern is empty, $this->hostnamePattern === '' but the routes still have their previous hostname.
There is no need to copy/paste the phpdoc. Can you just replace it with 

```
/**
 * {@inheritdoc}
 */
```
What is the reason for the `__NAMESPACE__` constant here?
What do you think, Bernhard?
This too should be removed.
btw ... there also was once a patch to support commands as services.
This isn't very clear to me.  For example, what should I add to the config file to make a profile for testing the docs?
先留着吧，不是大问题。因为我一般要编译测试的时候都是在一个文件里改，所以本科生的信息到最后再删也没有关系。
有用到这些“颜色”么？虽然加上是可以，但在文档中不作说明也不太好的样子。
Are these IDs significant? Do we need to do some sort of code signing?
Fixed in b93138ad3a2273a4a92c337c5338e68346f31625
Why this change to use log.debug instead of log.exception?
For next update, let's put some dummy value here and check for it in test.  e.g. local_ip=123.456.789.012.  In test module, raise error.ErrorTestNA("Default local_ip setting used, not testing").  Good idea?
I have big leaks in knowledge about taking care about exceptions. I know the syntax, but I never really tried it - now I'll try ; )
Good point, but you can still screw up the resulting img tag by including ' or " in your url.  I'm talking about the `+ url + ` business, it should be ` + encodeAttribute(url) +` or something.
Chef already has a jetty cookbook that is based on an old version of jetty and hasn't gotten any love in a long time. I looked at the code and could see why. So I named this intu_jetty to differentiate us from that one.
Running locally here with the test reintroduced still passes
Many thanks Brian, I will give this a go!
а ну это вроде не очень страшно, наверное для конфигурации это вполне нормальное решение
Oki doki.
I'm not sure I understand the comment?
Yup they should be localised, ∞ might help for the case of infinity :)
The name of the method seems strange.
okay, I will file one to record this.
Damn it! It is kind of confusing in my opinion the "finalize()" name... I'll go for closeUI() in correspondence with the openUI() function... ;-)
`SoundPickerView`?
sorry, old habits :)
We need it because the users add apps to homescreen from wrappers without asking the user in the home. We could implement this behavior with other param to indicate without asking the user?
Gaia issue number plz.
I assume it's intentional to decrease the threshold to 6 from 7, but just in case it's not, I point it out here.
Basic comments about the semantic of these 3 things would be nice. It's pretty confusing when you don't know the code well.
add curly brackets, **all* the time
I prefer separate methods.
No need for the extra set of parenthesis, just need a space after the `if`. Also, rename the header to `X-XHR-Current-Location`.
I'd consider the fact that ivars are assigned to be an implementation detail that shouldn't leak into the API docs here.  Looking at the top of the class, it looks like there are `attr_reader` definitions for each ivar here, so maybe this can read something like `Each parameter is assigned to a corresponding attribute.` ?  That would encourage folks to use the attributes rather than the ivars (which are definitely a private implementation detail).
```
/Users/soulcutter/Projects/rspec-core/Rakefile:15: warning: multiple values for a block parameter (2 for 1)
	from /Users/soulcutter/Projects/rspec-core/lib/rspec/core/rake_task.rb:118
rake aborted!
undefined method `ruby_opts=' for #<Array:0x102083128>
```
`eql` > `==` > `eq` :wink:
But as Dave is our code nazi I subordinate. :wink2:
Why do you need to do the deep copy both here and in line 236? I thought that doing it just here would be enough, right?
if (left.isEmpty) {
 right
}
else if (right.isEmpty) {
  left
}
else {
  // Both are not empty:
  Some(monoid.plus(left.get, right.get))
}
add ``, which regularly triggers the boss to delete  stale mock servers``
Like before, add in your @appscale e-mail for consistency.
On Sat, Oct 13, 2012 at 1:25 PM, Matias Griese <notifications@github.com>wrote:

> In administrator/components/com_kunena/libraries/forum/category/helper.php:
>
> > @@ -393,10 +393,22 @@ static public function recount($categories = '') {
> >  		// Update category post count and last post info on categories which have published topics
> >  		$query = "UPDATE #__kunena_categories AS c
> >  			INNER JOIN (
> > -				SELECT category_id AS id, COUNT(*) AS numTopics, SUM(posts) AS numPosts, MAX(id) AS last_topic_id
> > -				FROM #__kunena_topics
> > -				WHERE hold=0 AND moved_id=0 {$categories}
> > -				GROUP BY category_id
> > +					SELECT t.category_id AS id, COUNT( * ) AS numTopics, SUM( t.posts ) AS numPosts, t2.id as last_topic_id
> > +					FROM #__kunena_topics AS t INNER JOIN (SELECT t.id, t.category_id, t.last_post_time
>
> Did you check the performance of the INNER JOIN? It looks fast, but did
> you test the performance in your forum?
>

Yes I did extensivelly (thats why I changed it three times). The speed and
the load is similar to before, but now it produces the right results.


>  —
> Reply to this email directly or view it on GitHub<https://github.com/Kunena/Kunena-2.0/pull/1136/files#r1835757>.
>
>
I would clean up dead code (or improve the code) as it affects readability.
Should this text be only visible when the check fails?
Yeah, there wasn't a submenu for archive links before.
nice catch, yes that was the idea, should it be block in this case still or Location? I think that block is more intuitive.
Yes, good point. As a matter of fact we're pretty much limited to --verbose (DEBUG) or the absence of it (INFO). Having --quiet doesn't add up anything here. @clebergnu, any comments on that?
Why not `@container = $(@container)`?
I took that into account in `registerRegion` -- it ensures the region doesn't exist in the array before adding it.
PSR0 just needs the namespaces to be reserve ordered, so that more specific ones get hit first, but within a namespace if two packages provide the same namespace it shold follow the same as classmap (i.e. first package wins, and root package should always beat the others). files autoload needs packages ordered by requirements, which shouldn't affect the other sortings (as long as the root is kept on top no matter if it's required by some of its dependencies)
shouldn't this be 64K?
i think BUTTON_DEBOUNCE_TIME and BUTTON_LONG_PRESS_TIME should be configurable in menuconfig
See comment on line 24.
Just thinking out loud here:  but would it be possible to also pass a options hash into the module which can override these defaults?
In issue 64, `Venue page should include a website link`, misinterpreted it.
TLS/SSL certificate
Can you change this to `i18n_getf ('This page forwards members of the %s group to the following link', $user_type),`? That way other languages can rearrange the wording if needed and the type isn't hard-coded.
Oops, deleted my previous comment on accident.

How about just doing the work in `validate!` instead of calling another method?
Nice catch Olek :)
ditto re: truth values. Also, this line can be written "all([c in str for c in set])"
Came from copying a same change I made to your collection/list :D 
That's why I had to write tests!!! Will do and add tests now!
Thanks for catching that.
I'm bit scared by such change that is doing too many things at the same time:
 - refactor in order to stop using deprecated API,
 - change the way worker works!

By doing so, you are increasing the regression factor of one given landing a lot.

I won't have time to debug this code before the release of FxOS on 15th of January,
especially since we are having a complex discussion with boris and gabor about platforms features related to content scripts.

But by just reading the code, I've seen these two issues:
* I was using two sandboxes on purpose, and it doesn't seems to be addressed here.
Content script can eventually modify globals and break our code.
I don't think that can be considered as a security threat, but more like a stability issue.
We can still be safe without having two sandboxes by hardening the code, by ensuring that the code will still works if the content script change standard classes prototypes. (Like Array.prototype.push = function () {})

* Using DOM looks nice but is really unsafe. The event name can be brute forced. We can't ship this.
I was passing functions between chrome and content in order to safely communicate with content.
I got approved by platform guys about this practice. The most important thing is to be asynchronous.
This practice can still be used in e10s with the message manager framescript that are evaluated in content process with chrome priviledges.

* Is there any particular reason to have the definition of `Content` in script.js file? Wouldn't it be easily to move it in its own file and avoid the line number hack?
IMO: Fallback in `catch` would be more intuitive, but I'm fine with that as well.
I thought we said `.jsm` / `.js` was enough distinction. But if that's not a case let me know and I'll update docs and implementation.
We should do this effort, but we can do this later. MemShrink team may even patch that when we are going to land in m-c!
So it generates a JS file with a .json extension? That's less than good.
we can never get a requiredEmail option from the frontend now, this is no longer needed.
These tests will always fail if the datazilla environment does not have TEST_DB_PREFIX set to 'cam'. Use ptm.project instead.
Should this return a DeleteKey page object? The page that appears after clicking the delete history button does appear to be a different page from the Keys page.
No need to use the 'a' prefix for a property of options. aOptions.dir would be fine.
this import is obsolete
2012 now, no? :) or did you write this in 2010?
@joshcooper Should we also `5` for ARM for the upcoming Windows 8/RT? and `11` for neutral? http://msdn.microsoft.com/en-us/library/windows/desktop/windows.system.processorarchitecture.aspx#Y168
Your code looks much cleaner, but it looks like the original code allowed for the possibility of multiple retries, while your code will never retry more than once.  Do your changes guarantee that the environment won't change more than once?  If so, some comments here explaining how you guarantee that would be helpful.
The problem with Forwardable is that, if we really want our error checking
to occur, we need to tweak all of the methods to funnel through our main
"request" method.  So we would really only  be forwarding one method.
 (It's not currently implemented to funnel everything through the way that
it probably should...)

In any case my main concern here is just getting the API down and making it
accessible outside the indirector... it can be easily changed to use
forwardable in the future.

I'll have another submission shortly that adds tests.

On Wed, Aug 22, 2012 at 9:52 AM, Andrew Parker <notifications@github.com>wrote:

> In lib/puppet/network/http/connection.rb:
>
> >      end
> >
> > -    def request_head(*args)
> > -      connection.request_head(*args)
> > +    def request_head(*args, &block)
> > +      connection.request_head(*args, &block)
> >      end
> >
> >      def request_post(*args)
>
> Can all of this be covered by using Forwardable? It seems like that
> should handle this pretty well.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/puppetlabs/puppet/pull/1062/files#r1437143>.
>
>
Why is that necessary? The line that I removed seems to suggest that the return value from the function is used for exit, which it is not.
i think the style should remain constant. first brace in with the first line with a space in front.
In principle I don't mind auto-generating the category list, but it's probably best to keep it as is since the current order is deliberate and the list of categories has been stable for years.
I printed the validation warning as they are also printed in other spots such as while model validation.
Agreed, please ensure that you use your twitter email as the author too (e.g., git commit --amend --author="abc <abc@twitter.com>"
what's being passed that's undefined?

also style-wise maybe include null too:

```js
if (null == str) return '';
```
I think that this should be always Headers|null.
1. assert?
2. != ""?
I like this pattern (here and in AdminInterface), should probably standardize the config key ('prefix' vs 'basePath'), perhaps "baseUrl" ?
yes true is Configuration.php sorry about that.
None of those above is from Mink =P
Fix the spelling error while you're at it: "Unknown" rather than "Unkown"
> you sure crossroads.js is the right tool for achieving what we want?

I did, but I'm beginning to think it's not. Can you add your opinion here: https://github.com/addyosmani/todomvc/issues/229


> unfortunately, crossroads doesn't catch the route... even if i remove the '#', it's not working...

You must manually parse it:

```js
window.onhashchange = function() {
		crossroads.parse( location.hash.replace('#', '') );
	};

	crossroads.parse( location.hash.replace('#', '') );
```

But hold on, until we can get the above issue sorted out ;)
Yup, sorry, my mistake, drop the innerHTML
Sam here: `<input class="toggle" type="checkbox" {{#if todo_completed}}checked{{/if}}>`
Would probably be good to have some comments here and in the controller to make it clear that statsd works over UDP. If that's not clear I'd worry people would get thrown by this when debugging and/or worry that it wouldn't run for them unless statsd is running for them locally.
We could ignore this change if that static env variable is defined
somewhere else e.g. Puppet, not sure that it is at the moment

sent from my sg2
On 13 Dec 2012 15:40, "Matthew Ford" <matt@bitzesty.com> wrote:

> Well, I see what you're saying, now without the configuration it breaks
> outside the vm.
>
> This way is more in line with other apps on the platform, so there is less
> ambiguity switching projects, where in the development vm uses the local
> static version.
>
> sent from my sg2
> On 13 Dec 2012 15:35, "Matthew Ford" <matt@bitzesty.com> wrote:
>
>> You'll need to specify the preview url as an environment variable, thinks
>> it's better that it works by default in the vm and you configure it outside
>> (not the other way round) but this is up for discussion.
>>
>> sent from my sg2
>> On 13 Dec 2012 15:29, "Chris Parsons" <notifications@github.com> wrote:
>>
>>> In config/environments/development.rb:
>>>
>>> > @@ -28,7 +28,7 @@
>>> >    # Expands the lines which load the assets
>>> >    config.assets.debug = true
>>> >
>>> > -  config.slimmer.asset_host = ENV["STATIC_DEV"] || "https://static.preview.alphagov.co.uk"
>>> > +  config.slimmer.asset_host = ENV["STATIC_DEV"] || "http://static.dev.gov.uk"
>>>
>>> Not sure I understand this correctly, but won't this break the app in
>>> development outside of a VM?
>>>
>>> —
>>> Reply to this email directly or view it on GitHub<https://github.com/alphagov/whitehall/pull/98/files#r2407585>.
>>>
>>>
>>
I'm sorry I didn't say this earlier in the process. I thought I had managed to say that I wanted *either* the URL solution or the disallowing solution (not both at the same time), but looking back on the discussion, I can see I wasn't clear at all! 

So this is belated, but -- I don't agree that we need to disallow future tags with ""+". Yes it's currently awkward, but I think that it's not to the point where we need to obsolete the plus sign completely, especially without any kinds of warning.
My only concern with completely removing the info to another file is it requires users to click or navigate, which for a lazy user, may be too much.
lost `;` here
Possibly worth indicating explicitly that that website relates to a very much older version of ldc than master/HEAD in the Git repository?
so this is just an error reading the file?
We can take out "which"; its bad english.
newlint => newline
Kind of unrelated to your changes but we could totally just change this line to

<code>
track._id = id || Popcorn.guid( track._natives.type );
</code>
Can you please make this function just read from sys.stdin and add a note to HACKING.txt with the psql command? Not everybody has access to the database and most people will use different host/username/name to access it, so having it separate seems like the best idea.
Can you move the colon outside the label tag to match the others? (It's pretty inconsistent from form to form throughout the site, but fixing it site-wide is low priority.)
maybe just check that `errors[:audit_comment]` gets set?
would use single quotes here
Looks like nothing uses this file. Remove??
e.g. you can get that via the log file location for example
Originally that was because I was using drupal_not_found() within the function and it doesn't work in all contexts. I'm leaving that comment in place until we have sorted out what to do when the repository is not accessible, for example this function may trigger a drupal_goto in the future, a potential nasty side effect for calling code. Also this function needs to cache information as it gets called many times during a single request, if the calling code were to use it once for a given pid then create an object with the same pid, it would still return false.

Users can use the islandora_get_object_by_id() function.
Seems like overrides are all or nothing, here; can't use config for 4 of them and just override 1. Is that by design, or did I read it wrong?
adduser wants backticks.
This is not a good sample, because at the very least, a nested bundle should be used here to avoid duplicating code.
Nit: s/we currently not/we are currently not/
This `start_if_empty` is pretty hard to understand. Would it be better if the caller just used `start` for this.

e.g., Caller would specify:

`getPagingParameters(start || columnPrefix, 100);`

instead of:

`getPagingParameters(null, 100, columnPrefix);`
Do you need to call the getGroup function first to check if it exists? I'm assuming getGroup would have the access check?
This will probably conflict with https://github.com/sakaiproject/Hilary/pull/205, I'll make a comment in there or fix it here if it gets merged first.
Slow stepping is likely due to the work which is done every time a step over is done. There's some improvements to be done to cache requests between invocations.
In this case, the stack frame searched for is likely to be in the first elements. Right now, it is always the first element.
So bossy! jk.. coming right up sir!
typo: "hounbot" => "houndbot"

also, what happens if someone names themselves "dj" ? is that even allowed?

Same thing as above about splitting words instead of text length numbers
not sure if the name is a good choice. its inside the CMF sub-namespace, so it feels redundant, yet not accurate enough to really clarify that its basically an implementation around the conventions used in the Symfony2 CMF initiative. then again a lot of it is based around interfaces + some conventions for parameter keys (though i think the logic there might even be out of sync with master).
Not sure this is ever used, so it can be excised.
`if ('function' == typeof fn)` is enough, the toString stuff can go
why are you removing all these conditionals? they're in place so `make test-acceptance` doesn't have a bunch of logs etc
inherit from application controller (see above comment)
is self needed? should it be instance?
Invert the order of those, `empty()` first makes more sense.
NSString адаптирует некий протокол "сравниваемых объектов", и там есть функции для сравнения, что-то вроде [someString isEqualTo: someOtherString]. Если тут мы сравниваем указатели на объекты и если это работает, то в функции генерации рандомного белка возвращает укзатели на константные объекты (иначе бы не работало), если же здесь компил развёртывает сравнение объектов по указателям сам, то всё в порядке изначально. вот и интересно выяснить. У себя в проекте я совершенно точно генерил новые(!) объекты названий белков  и такое сравнение естественно не работало, но проверял на gcc+gnustep.
Всего 100 элементов в массиве, соответственно 1 элемент == 1%
Ошибаюсь?
ну если ячейка уже изменялась, нужно понизить индекс иначе после инкремента у нас получится потерянный шаг вроде бы итерация прошла но ничего не сделала.
Т.е. алгоритм за "рандомное время" - это ок, и лучше не сделаешь?
@wiifit с ним всё так. Но его наличие, как такового, обязывает сделать более гибким метод мутации, с чем не согласился @mvmn, привёл работу, оценённую преподавателем, в котором проценты считаются.
Foundation мы уже затрагивали, и 3 лекция уже прошла. Я изначально давал себе отчёт в том, что на данном курсе не смогу получить все знания, поэтому занимаюсь самообразованием. Пока я не вышел за рамки преподаваемого на курсе.
странно я же перед пулом создал категорию, это предыдущая версия, хм
That's very good to remove these checks. As we do explicit routing in routes.rb, these lines are not useful anymore :)
This shouldn't have a return value once we implement the callback.
The step definitions you added are not doing anything apart from calling back. I think you are missing something here :)
@jmikola I noticed that not saved fields weren't being skipped as early as possible, so I moved it up to make execution a little faster.
i would rewrite this code later to make it execute start/stop for both sam, cfse
no, its in activesupport. will remove
@tclem @Haacked As previously discussed, I'm really not willing to make the `GitErrorCode` and `GitErrorCategory` types publicly exposed, nor to expose such properties. Indeed, I don't feel the grain is fine enough (yet?) to safely build a stable/long lasting error handling strategy. 

Therefore, for now, I'd prefer to only expose `int` typed values in the `Data` dictionary. 
This makes the libgit2 native error codes available for logging purpose. 

In order to reduce the pain, we'll indeed have to add proper exceptions to LibGit2Sharp. Which one would you see fit?
@carlosmn recently added `git_remote_set_autotag()`. This should allow you to add an override to fetch in order to replicate the behavior of `git fetch --tags` and eventually fetch the `nearly-dangling` tag.

```
$ git init .
Initialized empty Git repository in d:/New folder/.git/

$ git remote add origin https://github.com/libgit2/TestGitRepository

$ git fetch
remote: Counting objects: 69, done.
remote: Compressing objects: 100% (45/45), done.
remote: Total 69 (delta 3), reused 69 (delta 3)
Unpacking objects: 100% (69/69), done.
From https://github.com/libgit2/TestGitRepository
 * [new branch]      first-merge -> origin/first-merge
 * [new branch]      master     -> origin/master
 * [new branch]      no-parent  -> origin/no-parent
From https://github.com/libgit2/TestGitRepository
 * [new tag]         annotated_tag -> annotated_tag
 * [new tag]         blob       -> blob
 * [new tag]         commit_tree -> commit_tree

$ git fetch --tags
remote: Counting objects: 1, done.
remote: Total 1 (delta 0), reused 1 (delta 0)
Unpacking objects: 100% (1/1), done.
From https://github.com/libgit2/TestGitRepository
 * [new tag]         nearly-dangling -> nearly-dangling
```
As it says later, it suggests doing `git branch my-new-feature upstream/master`. I don't develop this way, but they seem insistent it's a good idea, and I could understand why.
right, would mix up things with stc.. 

On 05.12.2012, at 21:53, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/epochs.py:
> 
> > @@ -105,6 +108,9 @@ class Epochs(object):
> >      info: dict
> >          Measurement info
> >  
> > +    event_ids : dict
> > +        Labels mapped to event_ids.
> Names of conditions corresponding to event_ids.
> 
> Labels as a particular meaning.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Q doesn't have pipes. The difference in jQuery was then returned the current promise and pipe returned a result of the current and any promise you returned from the pipe itself.
For one, why not just make it a private attr_reader? A class having to read its attributes out of a hash seems weird to me.

Second, allowing customizability of the specific tag that gets used seems of little utility. I'd replace line 33 with a method that rendered the list item to allow a subclass of MenuPresenter to customize list items if it were so desired.
官方现在所有文件前面加了一个版权。为了尊重nginx原版，请在您的版权信息前面加上
  Copyright (C) Igor Sysoev
  Copyright (C) Nginx, Inc.
Ooh, nice. I'll do that now.
Its only 190 pages!
Indentation for whole file (align `=`s).
Will anything look different if there's only one dl? Normally, since it's a list, it doesn't make sense to create many lists each with only one item...
'is works' looks like typo
Пробел после двоеточия.
@jduff I removed the terminal notifier thing, I couldn't test it at the moment, will test it somewhere next week and do a new pull-request than.
easily build your back end of your mobile app using right from Titanium...
either remove "right from" or "using" or reword
It's better to do this in application
There is some code here:

```ruby
def hello
  puts "world"
end
```
I'm not too keen on calling this method delete_server_or_raise... sounds like we'll have to name all methods that raises as such.
I'd prefer 'Management' or 'Mgmt' here, either since we've got the room to be verbose or we've got reason to stay consistent.
I thought we agreed to _not_ put this in the instance service. when did this change?
Any plans for dealing with this?
I vigorously protest against this dictatorial behavior. You should be open to our concerns day and night. I am going to write a blog post about this story and submit it to hacker news.

This said, you are contradicting yourself. In your previous comment you proudly state that the code only supports semicolon or sharp characters, *or* you are deliberately checking for \n. I suspect you have bigger plans about the code and that you already started working on our suggestions, with the goal of delivering a proprietary product and selling it to facebook.
Hmm, you make a valid point, @prototype. It would probably be safer to perform a DSE optimization pass (dollar sign elimination) on the js code before submitting it to Amazon. I believe there was a paper recently published in The Journal of Machine Learning Research about this technique. 

I would recommend writing the optimization pass using LLVM, since it provides all the necessary foundations.
Ah yes. Ignore me, I misread.
Either make these comments line up, or shift them all to the left. I don't really have a preference.
Er, I think I meant the `Figure`'s constructor method, not the backend.
It might be good to illustrate the density option here, with hatches=['/', '\\', '//']
This indentation looks a little funny. Have tabs been used here?
You need to import cm in this example
Looks like we're switching styles to doing the full, inline @pytest.mark.xfail -- mind updating this, while you're here?
Hmm...can we pull this out out of the test into a separate file and have each test include it?
I found from the WiFi testing that these `return` won't be returned, for whatever reason that is. You'll need to return something outside of the callback.
@soloweb вот тут прям не понял, простите, совсем. Label нужон форме чтобы вывести возле инпута в тэг label (в больш. случ.).
И вот его в LightMetaProperty? А get_text? У нас на сайте планируется _('все тексты в последствии "мультиязычить" ');
Хотя может кому и будет полезным. Ну и виджеты видимо без этого не взлетят?
Hey, I think they get cast on serialization-- check out my int-struct etc wrappers and the to-struct code I added to schema. 

-- 
Sam Ritchie
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Monday, May 21, 2012 at 8:50 PM, Aaron Steele wrote:

> > + ArrayValue DataChunk DataValue DoubleArray FireArray
> > + FireValue FormaValue IntArray LocationProperty
> > + LocationPropertyValue LongArray ModisChunkLocation
> > + ModisPixelLocation ShortArray TimeSeries FormaArray
> > + NeighborValue]
> > + [org.apache.thrift TBase TUnion]))
> > +
> > +;; ## DataValue Generation
> > +
> > +;; TODO:
> > +;;
> > +;; Fix this up
> > +;; Add mk-data-value to chunkify
> > +;;
> > +(defmulti mk-array-value class)
> > +(defmethod mk-array-value IntArray [x] (ArrayValue/ints x))
> > 
> 
> 
> So this looks perfect:
> 
> ```clojure
> > (mk-array-value (IntArray. [1 2 3 4]))
> 
> #<ArrayValue <ArrayValue ints:IntArray(ints:[1 2 3 4])>>
> ```
> 
> But here we're able to create an `IntArray` of floats:
> 
> ```clojure
> > (mk-array-value (IntArray. [1.5 2.5 3.5 4.5]))
> 
> #<ArrayValue <ArrayValue ints:IntArray(ints:[1.5 2.5 3.5 4.5])>>
> ```
> 
> Wondering if we need something like this instead for all these multimethods:
> 
> ```clojure
> (defmethod mk-array-value
> IntArray
> [x]
> (ArrayValue/ints (vec (apply vector-of (cons :int x)))))
> ```
> 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/26/files#r857995
> 
>
Updated the pull request with a fix.
@dooremont Can you fix this merge conflict?
Can you use the triple equality operator here?
Also, could you change around the order to `item["sakai:permissions"] === "private"` to be consistent with the rest of the system?
In IRC, you rightly pointed out that this boilerplate of mine was ugly and probably unnecessary. Feel free to clean my mess up. :)
@param int $order A numerical index to control the order that joins are added to the query; lower order values will cause the query to appear first.  The default is 20, and joins created automatically by the ORM have a value of 10.
nu e primul, e cel mai folosit :smile:
Adjusted the Main Icon
you should probably name the folder link to something like deploy or something - built.jar makes me think of a extracted jar contents
Here, the functional way is shorter too.
ack, sorry to hear that. i threw a terabyte at ours so disk space isn't an issue, but the load we're seeing is causing a lot of nodejs restarts
Tweaked in 678bdd0.
This won't work if `pred` returns `true` for falsey values, like `nil?` does:
~~~clojure
(first (filter identity (map nil? [1 nil 2])))
;=> (first (filter identity [nil]))
;=> (first [])
;=> nil
~~~
To fix this, you should filter, not map, with `pred` and call `pred` on the first element, if it exists:
~~~clojure
(let [f-seq (filter pred a-seq)]
  (and (not-empty f-seq)
       (pred (first f-seq))))
~~~
footer is a good idea, and we need a footer to indicate that it's PMSIpilot's product
I found [this](https://code.djangoproject.com/ticket/6864) but it is long fixed.
OK. I understand. Because you are storing comment as index. OK. So, there are some problems here. First, you are not calling parent dehydrate!
Of course you will have to learn how to pass URLs from `url` into the blocktrans context.
Spaces around `(index, key)`. See how we have other anonymous functions.
The only reason I can see why this is needed to be done on the UI thread is for access to DataContext, correct? And then, its only for `Settings.SetWindowInFront`. Is there any cases where we *don't* want to set it in front? Thats the entire point of the app!
That's valid, I was just wondering.

John Duff
Software Developer @ Shopify

Sent from my iPhone

On 2012-10-02, at 12:43 PM, Nathaniel Talbott <notifications@github.com> wrote:

> In Gemfile_rails23:
> 
> > @@ -0,0 +1,24 @@
> > +source :rubygems
> > +gemspec
> > +
> > +gem 'activesupport', '2.3.14'
> > +gem 'rails', '2.3.14'
> I see no way to reference, though I could be missing something. I suppose they're just Ruby files, so maybe we could use require? Seems like a refactoring that could be done after this gets merged, though.
> 
> —
> Reply to this email directly or view it on GitHub.
>
For added safety, we can check if user is connected with a given provider by doing:
`if( adapter->isUserConnected() ) { ... }` after line 44
warum ohne trim?
Exception weiter geben statt null zurück geben (wie besprochen).
Is there a reason not to set this to a property named `leaves`?
this must be removed, and the license header must be added
this should not be documented here. The boot method can do other things too (and it used to do more)
This can be an `ObjectManager` based storage (`Db` is not a concept of Doctrine. Persistence may be an array)
SNMP is used to clear the 802.1X session this is misleading and should be removed I guess.

I think there's another limitation we discussed that should be listed here though.
I was approaching this more from what feels intuitive to write (for the caller), ignoring implementation complexity.  Trade-offs.  :smiley_cat:
The values in `allocated_res_ids` are not resource ids, but (my own) entry ids. The keys are resource ids. So it's more a dict of resource ids for the context, within the service the value may as well always just be `true`.  The value I put in now is only relevant to the crafter (in the next step, not now actually).

I think I like it better as it is now, IMO it expresses that dict character better, and the code doesn't assume what is actually kept in there, it just copies it over so the redirect will have the right context associated.
This would obviously be nicer with a replace function, but I followed the old format to mitigate the risk of messing up something deep down in the tokenizer.
Use constants, not `#define`: `const double startAngle = 0.3;`
isn't this already done by a previous commit ? I already saw a PR with it
https://github.com/sonatype/nexus/pull/321/files#L3R305

it does try to change the configuration, 
so either we expose add/remove/update like operation on CRepositoryTargetConfiguration....
or does like this.
I just want to point out that I feel wholly unqualified to comment on this!
You've got me there Rachel... It's not currently possible as I never wrapped those methods, but needless to say it was part of the grand plan.

Jim: it wouldn't be radius things that get set up front, but (in the only case I can think of) sersic indices.  However, the lookup tables for these only actually get constructed at draw time, so there is no appreciable penalty to setting even this and changing it later, so long as you never wish to draw the default object.

If there's strong opposition to default initialization so be it, but as I said it would make the implementation of (e.g., in #101) the super-early-prototype `build_galaxy_image()` in `galsim/frontend.py` dependent on us having some sort of global dictionary of object types and their expected parameters, and require us to keep this updated with any new param names in the base classes themselves as they change.  Is there an easy/elegant way of doing this in Python, or would it be case of keeping a central dictionary up-to-date and writing unit tests to ensure that we don't forget?


On 9 May 2012, at 10:12, Rachel Mandelbaum wrote:

>> @@ -11,6 +11,14 @@
>> 
>> typedef bp::return_value_policy<bp::manage_new_object> ManageNew;
>> 
>> +// Used by multiple profile classes to ensure at most one radius is given.
>> +void checkRadii(const bp::object & r1, const bp::object & r2, const bp::object & r3) {
>> +    if (!r1.is_none() + !r2.is_none() + !r3.is_none() > 1) {
>> +        PyErr_SetString(PyExc_TypeError, "Multiple radius parameters given");
>> +        bp::throw_error_already_set();
>> +    }
> 
> Hold on, is that even possible within SBProfile right now?  I mean, instantiating an SBProfile and setting params later?  They all have setFlux() methods and I see that SBMoffat allows you to set FWHM or scale radius, but otherwise you'd have to write setSigma(), setHLR(), setFWHM() for the various other SBProfiles, yes?  (Not that that would be too hard, I guess.  But my point is more that what you're proposing doesn't just require that we don't throw an exception when no radius is given, but also that we change the guts of SBProfile to allow it to initialize to some default size and then get changed later.)
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/140/files#r796300

--
Barnaby Rowe

Jet Propulsion Laboratory
California Institute of Technology
MS 169-237
4800 Oak Grove Drive
Pasadena CA 91109
United States of America

Department of Physics & Astronomy
University College London
Gower Street
London WC1E 6BT
United Kingdom
This is not a comment on this file, but it's convenient to write it here. 

I think we need a second interface to the child items than buttons.  See bug #1456.  Need a way to display details, especially when we have "Exam" variations for DB class.
If we can't use `cp._v`, then let's use `cc._p` (which is the same as `cp._v`).

`cc._p` does not create new objects.
Can't, as the startTracing method is injected into the page outside of the scope. There's a note in the jsdoc but it's not noticeable - adding another.
"additional" should not be there, they haven't actually done anything!
OK agreed.
same here w/ `!= nil`
`## Template source:  'MODULESroot/modules/./puppet/templates/puppet.conf.erb` is the output of this line right now. Seems like the root value isn't correct if apply is used?
Uhm, I generated this with the package.php - were you maintaining it differently?