labofsahil/github-event-dataset-2012 huggingface dataset:
On 06/03/2012 23:28, Fabien Cazenave [:kazé] wrote:
>> +<small>Notify me when an open network is available</small>
>> +<label class="checkbox">
>> +<input type="checkbox" name="wifi.notification"/>
>> +<span class="checkbox-inner"></span>
>> +</label>
>> +</li>
>> +</ul>
>> +<h2>  Wi-Fi networks</h2>
>> +<ul class="tableView" id="wifi-networks">
>> +<li>
>> +<span>Scanning…</span><br />
>> +<small></small>
>> +<span class="wifi">
>> +<span class="wifi-signal3"></span>
>> +<span class="wifi-secure"></span>
>> +</span>
> We need a way to show a wifi scan is being performed. I agree it's still a temporary hack until I come up with a proper UI.

Makes sense. I was just wondering.
And we'd need to handle failures eventually.
drop me a note after you fixed it.
"export" is a terrible name. I'd love to come up with something better.
The test tasks can be removed.
Not sure, but isn't that just registering a default port for the 'http' scheme?
Вот так вот писать нельзя. В 23:59:59 31 декабря твоя программа может вывести текущий календарь за декабрь следующего года.
That's a good change, though ideally, it would also be a separate commit.
We don't use 'next_report' anywhere in the test and after we remove the 'return' in click_next_button(), we can keep just 'statistics_page.click_next_button()' here.
this `/resources` directory doesn't seem to exist.
Required: `with as request.sentry.id` should be  `with request.sentry.id`.
I actually think we shouldn't expose the general wallposts API now because 1) we're not using it and 2) we probably need a content type api as well. If we expose it as is, we have that problem where content_type ids might be hard coded in clients. Just commenting out the urls with a comment explain why it's commented out should be good.
I'm a little concerned about using `-m` and `-M` for these options — it isn't overly obvious to me (because both "min" and "max" start with "m") and it will prevent us from using it for anything else in the future.

Would you be okay with not having a short option for these and just the long ones?
Same comments as above (regarding loops) apply here.
Could you please put a short one liner and then give more details in a paragraph?

```
"""Short one line description.

Paragraph explaining

Parameters
----------------
...
"""
```

In particular I don't understand what is a "discrete solution".
You know the drill ;-)
Seen it. This is not relevant. README.markdown will be next step (and not only for this module)
Should this block the merge?
That seems wrong to delete the entire temp but I don't really have a problem.
I'm surprised this member variable can be @Autowired this way.  Is it safe to make includeJQuery a top-level bean, and to rely on it being the only top-level Boolean bean?
You actually need to catch Throwable here, due to a codemodel bug. Basically, at some point `com.sun.codemodel.JCodeModel.ref(String)` may be called by `codeModel.parseType(fullyQualifiedClassName);`. This methods tries to load the class, and loading the class may actually throw some Exception and / or Error.
The loop should always be adding matchLen to cur.  As this stands cur will again be incremented, possibly leading to weird situations with multi byte quote characters. It does "accidently" mean that quoted quotes don't get removed, but that isn't clear from the logic.
JenkinsRule is supposed to set up the Jenkins instance (https://wiki.jenkins-ci.org/display/JENKINS/Unit+Test+JUnit4). I commented out the assumeThat calls to force it to try to run even on the Mac - and I get an NPE in JenkinsRule.after.

Oops - when I override JenkinsRule.before to add the assumeThat - I can't forget to call super.before to set up the Jenkins instance. After I did that - I get the same ugly failures testing on the Mac as it tries to set up the instance. So I think that will fix it. Pull request to come shortly.
I agree about the diff, increased size. I guess that should be pushed as a separate, dedicated commit for style updates :-p Code style & readability matters as well as a readable diff.
i agree. i'm gonna change it.
it's not CS
Why not use `port` from `socket.js` instead of determining `isSSL` and `port` here again?
maybe you should use ::eoval and ::key here
feel free to send me a PR to add this information :)
Look at the source code of [2012 MSC](http://www2.usfirst.org/2012comp/Events/gl/awards.html)
And you'll find some names have ```<span class=SpellE></span>``` around some words but not others.
I changed the selectors cause they are now in global file
this solves error 500 on products page
Missing docstring and please use ```"""``` for docstrings.
this should be `is_next_button_enabled` because it's returning `True` for it being visible.
This only counts the first 19 elements on each page
why a second check if the target is the same for both?
No general url's pls, references to the technique used in the module
Separate indices for `x` and `y` equations, as suggested for `_make_polynomial`.
What is `args[4]` here? Can you assign to a descriptive variable?
oh, actually they are here. So no need to add default for them, you can to settings['ARTICLE_URL'] directly.
Hmm missed that. Not very faimiliar with CDI though. I will change it than.
please use ``||`` instead of ``or``
Should we throw if `index < 0`?
Why use `buffersUsage[k]` here instead of `BufferUsage.STATIC_DRAW` as is done in the billboard collection?  The idea is that if an attribute stops changing over x frames (well x is one in our simple implementation) that we should change the usage hint back to static since it is no longer changing.  This makes a big difference on some drivers.  I'm told that other drivers ignore the hint completely.
Probably white space.
If possible, add the javadoc comments at the methods below, please.
Please add `since`.  Though it will be odd in this case since you should say 1.8.3 technically (because of other pull request), though you are jumping over the 2.0.X branch to master. :)  fun stuff.
This method will be unnecessary if the constants are defined in the UI Module or if we reuse the existing constants for the label verticalAlign property.
This doesn't apply to mobile web since we support the swipe gesture.
createView seems a little generic for the context of the table view, maybe we can use something like createControls() so it aligns with terminology in this class?
Be nice to finally get rid of these magic numbers.  I seriously don't even know what this 2 is, which is a bad sign.
also, if you do this, you will need to make sure there are no changes that will need to be applied to the translation files...
Don't be sorry. It's good for the code :)
We shouls see what says the specification on this corner case instead of just catch the exception... This way would let the websockets open... :-)
do you want to do host.defaults['amisize'] or host['amisize'] ?
Может всё же как функцию назвать? Это же функция.
can we add some newlines here?
Can you provide a cmake check script?
If you think so. I probably prefer conditionals to early exits, but I don't feel too strongly about it. Also, that's the wrong way round, I think you mean "return if is_hidden", but based on the comments above it could either be "return if hidden?" or "return unless visible?"
```
[1 2 3
 4 5 6
 7 8 9]
```
Even so, new additions can be done properly right away, no ? ;)
I'm not sure about this point. Should it remove the player from the arena if _OPTS_DURM_KICKONDISC_ is set?
Oh god, sorry, will remove that.
Isn't this comment attached to the wrong branch of the condition?
Should the comparision value be replaced with self.EPSILON?
when you call video settings it actually pops up a dialog box explaining the situation. so i think it will be clear
This should default to false for backwards compat. In the example in my comment below: non-binary equality for a string is case-insensitive.
Nit: extra space after open paren
and by 'whoever' i mean @releod
Please https://developer.mozilla.org/en/Components.isSuccessCode on aStatusCode and only attempt to parse then
yes, definitely :)
Can you run a pep8 checker and fix problem? Giving as example something that don't respect pep8 and asking people to respect it seam contradictory.

Here, there should be no space next to = in funtion declaration or call.
Please use single quotes here per our style guide
Look... it doesn't matter where pointers come from. The point here is that this module's behavior is inconsistent.

Suppose I access some field inside a null object. The object's layout is small, so I get a `NullPointerError`. Now suppose I have an object with a very large (several megabytes) static array inside it. I access the last element of this array. Now I get an `InvalidMemoryError`.

Can you not see why this is a can of worms?
MINOR: Quick comment to explain whats happening here would be good.
*sets* up the servlet response
Why not make it final?
Why using the password to authenticate:

    user = authenticate(username=user.username, password=request.POST['password1'])

instead of:

   user = authenticate(identification=user.username, check_password=False)

like in `activate` view?
Always use https links please.
Again, this can go into the compat module
Why not use urllib.urlencode:

```
params = {self.page_field: page}
if request:
    params.update([(field, value) for (field, value) in d.iteritems() if field != self.page_field])
relative_url = '?' + urllib.urlencode(params)
if request:
    return request.build_absolute_uri(relative_url)
return relative_url
```
Je mettrais pas 'en ce moment', soit rien soit 'depuis que je l'ai découvert'
tabs vs spaces?
Just if(o.onManualCall) should do the trick
It's also okay with me to just leave the checkbox there if we're not *
positive* we can do it safely.

On Mon, Oct 1, 2012 at 9:33 PM, Jeff Hemphill <notifications@github.com>wrote:

> In DjangoProject/HvZ/views.py:
>
> > -			# Either we haven't defined any missions or
> > -			# all the missions are over. Either way, we
> > -			# don't have a mission to display.
> > -                        return render_to_response(
> > -                                'homepage.html', {
> > -                                        "user": ui,
> > -                                        "humans":h_count,
> > -                                        "zombies": z_count,
> > -                                        "onduty":get_on_duty(),
> > -                                        },
> > -                                context_instance=RequestContext(request))
> > +			# This code is all kinds of placeholder! We're
> > +			# returning a mission that happens to not be
> > +			# over yet. What we really need is a dummy
> > +			# mission to return.
> > +			mission = Mission.objects.filter(result!="N")[0]
>
> Hmm... i think you reset too far back or something. This is going to bork
> the site if we let it go through.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Claremont-HvZ-Web-Team/claremontHvZ/pull/50/files#r1735618>.
>
>
Once again, the difference is a prime number. :-P
Given that we're changing the text of this, so that it will need retranslating, it's probably worth moving it to the more correct `layouts.browse_map_data` or something - quite why it's currently in the `browse.start_rjs` scope is not entirely clear to me...
Okay, let's do it. Especially since our API could change drastically at this point.
I'll add that version, too.
Así como:
unidad_tiempo = models.TimeField() # unidad_tiempo * duracion_maxima = tiempo_duracion_maxima

después veo la implem.
At some point, we'll need to support specifying the width only, then calculating the height based on the video's aspect ratio.
ditto re what type is
"since the creation of sessionB must have failed."
Removing since there is no clear need
`var i_uid = $sn.getAttr(ui.draggable, 'uid');`
What exactly do you mean by that? I'm not really sure if I understand. If it's registered as remote (as it's currently done) it will be part of 'in-container' extension, so all kinds will be supported, right?
Shouldn't we be getting the ids from the webivews themselves. i.e. ````overlayWebView.id````