labofsahil/github-event-dataset-2012 huggingface dataset:
Add these attributes into an array of singletons -- that way we can add to this list easily. Each index will have 3 fields such as:

attributeuuids[0] = { 'concept', 'height', 'HEIGHT (CM)' }
Reference this ticket here: https://raxaemr.atlassian.net/browse/RAXAJSS-206 so the next person can find easily
Why ```GraphicsTest``` and not ```IrisTest```?
This is too fragile. It relies on config being a ".py" file. It could easily be installed as a ".pyc".
I forget that the graph was maybe not cloned yet. So using the ancestor suggestion that limit the seach up to the input is a good fix to that (potential as I don't know if it was cloned) problem.

Yes you did read the code to understand it. But if someone don't know it exist and/or don't know what it do, how it can help him, how can he go read that part?

My response is more about the tone of you suggested comment. I think Ian didn't think that FGraph Feature could help him. Maybe he even don't know about it. So how can he think that this can help him and then only he can go see the code to understand it, In fact, I didn't think of the feature myself, but I would not expect him to do so.  So if you suggested that as a better way to implement it and ask him to go read about it would have been better I think.
Yeah, it works correctly because csc format will add up the items with duplicate coordinates.
It's hard to move because it only applies if the if statement is met.
I'd rather have `[value for (value,) in values if value]` so it's obvious you're flattening a list of tuples.
Avoid global state.
did you just add a */ in a comment?
```
@param {Object} o
@param {Object} o.path
```
querySelectorAll('script[src]')?
You could move this initialization to the presenter. and call a methods of the view that implement it. like driver.edit( ... , ... ) you could add a method to the view called edit( .. , .. ) and the workflow goes like this presenter.initialize(){
view.edit( ... , ... ) 
}

and now you can test that the view.edit is invoked. Finally implement the edit in the view like this view.edit( ... , ... ) {
driver.edit( ... , ... ); }
text_type(self) would not call __unicode__ on Python 3, but would instead recurse indefinitely on __repr__.
Rofl, shouldn't we just change get_field to get_field_by_name('bla')[0] then? Using ugly API to be more performent smells bad if you ask me.
It is possible to use the PDO driver but there is PostgreSQL functionality that the PDO driver uses which Akiban does not support.

For example, the DEALLOCATE statement is used to free prepared statements ([relevant source](https://github.com/php/php-src/blob/master/ext/pdo_pgsql/pgsql_statement.c#L64)).

Another example of something we don't support is [server-side cursors](http://www.postgresql.org/docs/9.1/static/plpgsql-cursors.html). These are used in a [few](https://github.com/php/php-src/blob/master/ext/pdo_pgsql/pgsql_statement.c#L141) [places](https://github.com/php/php-src/blob/master/ext/pdo_pgsql/pgsql_statement.c#L380) by the PDO driver.

That said, it might still be beneficial to see how far I could get using the PDO driver. What I might do is get this branch cleaned up with all your feedback applied and once that is done, try creating another implementation that uses PDO instead of pg_* and see how far I can get.
There's a bug with this variable. The second line of the string is cut off. (You need ( ) after the =.)
`a && x` => `if (a) x`, also please spread code across multiple lines.
Why `_`? It's cruft.
Even though I wrote this, I'm soooooo happy to see this go away :)
This is wrong, we still that it's `!rposition`. Safari 5.1.7 freaks out on a wider set of values than just margin-right. I know it's rare, but 5.1.7 specifically regressed on Windows, not 5.1.5.
I wonder why you need extra arguments.
I think we should still use tab in the beginning of a line. Otherwise, there are too many changes. It is hard for the reviewer to review.
this whitespace is wrong here
I like to try to keep the scope of a try/catch as small as possible, so I'd just wrap the "contents = " line in the try/catch, or in fact even just the "coffee.compile" call and move new Buffer to its own line. That way, an exception through during "new Buffer" or "bundle.add_resource" won't confusingly be described as a Coffeescript compiler error. I realize that you are using the "less" package as inspiration, but that call uses an asynchronous callback, so in fact even though it physically looks similar to what you've written here, the try/catch really is only surrounding the less.render call.

That said, taking a peek at the coffeescript source, it looks like if you add a "filename" key to the "options" object, coffeescript itself will include the filename in all errors.
No need to duplicate this code several times, refactor this into its own method and have all 3 SpawnMonster* funcs use it.
Use a list here

```rb
system "#{bin}/hardlink", "--version"
```
No need for this---we already have a formula for CouchDB. Just use call `Formula.factory 'couchdb'` during installation.
:options_metadata is no better than just using :options - the metadata is redundant.  Switch this

If this is the only place options_metadata is called, one-line this:

    (opts[:options] || []).each{ |o| c.option *o }

Much easier to read.
Suggest renaming bound to bound? and making this

    forwarding_specs.select(&:bound?)
Unrelated to this PR but there's a bunch of places where 'ESME_ROK' isn't returned which gets dropped on the floor. I've seen 'ESME_RINVSRCADR'  and `ESME_RINVDSTADR` get returned for `submit_sm`s that were dropped silently.
Committed patch for this to branch.
Там ещё и "команда" в конце написана с двумя "м" :P
Same thing here as above, may want to skip the relative-url argument since it's not required.
Are the outer parens (grouping) necessary on the right side of the `|`?
For the record, the reason for having a class named `Error` that other things subclass is so that if you want to just catch any exception specific to that module, you can catch `modulename.Error` and get all of them easily.
Yeah - go ahead and assume that the Meetup venue name will be correct and use that.

Let's start with defaulting to UCSD and standard map to anywhere else. If it's not good enough, we can go from there.
what about this console.log? :)
This would be an example of something I would want perltidy to *not* fix. :-(
I was just teasing out whether the type parameter made sense.  I'm convinced.
Test Indicated Commit to be faster. Suggest file cache every 10 days?
Right, the second call of updateRender shouldn't be.
It seems like here we're relying on talking to the Editor's `_codeMirror` directly, but in other cases we're still proxying through Editor methods like `Editor._getText()`. I think we should just remove the latter and consistently talk to `_codeMirror` everywhere in Document. (We could choose to do the reverse in order to localize our dependencies on CodeMirror, but that seems like adding a bunch of needless proxying methods to Editor which just confuse the issue, and in the future these calls to CodeMirror from Document really should be different in that they're model calls rather than view calls.)
Switching to ``filtered`` is ok for your ``if`` block, but it's _not_ ok for other ``if`` blocks. Make sure you also adjust others.
This is handled in ``FileUtils.convertToNativePath()``
Suggested refactoring. @jbalsas Don't worry about making these changes. We'll refactor this ourselves later.

We should factor out a ``StatusIndicator`` class here and replace ``addIndicator`` with ``createIndicator``. ``StatusIndicator`` will define methods to update visibility, style, etc.
Same question as above -- I think using $() is more canonical
Why only one argument? Many node.js callbacks have two, right? (one for `err` and one for the actual result, in case `err` === null).
Why not just set getcwd() in place of null here? Nested ternaries are easy to misinterpret.
assume you did fulltext search for any functions that were deleted or renamed?
Check in official repository. :-)
This does not really work, because you have to have unique link names in the document. :-) Now you have three MongoDB. I will pull it now and correct it, but next time please really check the output.
Thanks. I'm glad you know how to solve.
I remove it.
note-to-self: this is where I got it from: https://github.com/peterbe/balrog/blob/e7a3962acda27d4de52107ea9887c7df6e110d81/auslib/admin/views/rules.py#L137-L151
type being provided for select?

Is there supposed to be a bunch of options in a drop down? Or, if this is just something that isn't supposed to appear in the editor then add a <pre>hidden: true</pre> attribute since that stuff will be brought back into the fray in the editors soon enough.
That's overpowered, thank you for showing me this.
Don't use "autosave"
We can probably remove this `if` block by starting the drag inside a mousemove on the actual element, yes?
Can we make this multi-lined?
take out the `src/` it's causing a script error
why doesn't it update? the email is different?
haven't tested this yet, but will tvheadend version that don't support this feature just ignore it or bug out because the message is invalid?

also, we need some method to determine whether the backend supports this, or we'll get questions from users who set up these options, but still get the recording in the original format.
:) I'm definitely open to any suggestions here. I know it's not the most elegant looking code.
Does the UI lock up, wait, throw error dialog on any http error doing this refresh? Sounds like it was only tested when server was running?

Expecting that nothing noticeable in the UI if Nexus is unreachable or connection is slow.
This should probably have a placeholder text that says "Auto" when this value isn't filled out.  You can look at how that is done in promotions with the blank placeholder word of "Unlimited"
Please treat the case `jedi:max-summary-length` is `nil` (no truncate).
A javadoc that describes what this does. A return type would also be nice.
ino khoob oomadi :D
khob goftam bejash ye span bezar ke display block bashe
age bekhaym baraye 2khat enghadr be ham message bedim ke ...
Ah, sorry.  Made my patch against 1.0.1, then tried to match the code movement and missed that change.  Added back and pushed an updated branch.  (not sure if the pull request will update or not, but I'd hope so).
I'd accept license in this file with the note where it was taken from, its a bit of code rather than a library ;-)
Another place where ternary operator may be cleaner implementation.
XXXXX ???
I believe you can do `args.concat(options.additionalArguments, files)` to avoid the extra array allocation.
Removing the dependency seems weird to me
oh i didn't see that. addVisit seems appropriate in this case.
But don't you want an updateVisit method too?
nit: no need for this line break
Ah -- ok then.  It still may make sense to be handled at the up a level.  What if the user is writing a VOTable file to an output stream (quite possible in, for example, a web server).  It looks like the code in `connect.py` may fail.  It should probably just silently ignore `overwrite` in that case.  It would be great not to duplicate that logic everywhere that that applies.
FYI, blank files don't have to include the license boilerplate.  It doesn't hurt to have it there, but next time you can save yourself the 10 seconds of effort until you actually add some code to the file :)
(Well, up to the 78 line character limit at least)
Oops my bad.
Does mapFileUseCount need to remain global?
I was thinking to expand this class to also handle loading of wallets from config parameters.
itostr() does ``strprintf("%d", n)``, which is for signed integers, so should we better use ``strprintf("%u", GetDefaultRPCPort())`` instead, as we have an unsigned short as port number?
Personally I'd use this syntax to spread the message over multiple lines:

    tr("Bitcoin will close now to finish the encryption process. "
    "Remember that encrypting your wallet cannot fully protect"
    "..."
    ...)

With the current way, all the indentation whitespace ends up in the translation string.
Perhaps there's a cleaner way to avoid this class of warning?  Hopefully the following might work:

```C++
static void invoke(std::ostream& /*out*/, const T& /*value*/) { assert(0); }
```
Inline comment at the end of line
I'd prefer `static::NAMESPACE_CACHE_KEY` here to allow overriding the namespace key. May be interesting to be able to set it.
this will be needed when we create new entities as well, otherwise we would have the chicken-and-egg problem
Ah, got it.  Then yes, leave it.
It seems to me these nested function declarations would be more readable if they were broken up across lines.  Right now these lines (above and below this comment) are really hard to read.
But LazyEvaluate only ever gives str/unicode...

If we use str/unicode, we have to add extra logic to be safe from unicode errors, because they don't cast.
Please don't use names like `sharedStart`.  Even in JavaScript we are trying to use the PEP8 style `shared_start`.
Woudl you mind making this only one blank line instead of three?
probably the Entry suffix can be assumed
確かに`try`は全然いりませんね。
`if`節の中では述語の`present?`の方がしっくりくるのですがどうでしょう。
wrong error code; also you need to set a message
It looks like the intent here is just to increase the refcount of the input object. Should we make a `git_object_dup` utility for this? It would be less expensive than doing a full lookup, and more semantic.

I'm also inspired by the use of `git_object_owner`; we might be able to avoid passing a `git_repository *` in a lot of places.
How about using the `enum git_btype` as the type for the argument. That'll make sure that the passed branch type is always valid, and you can skip `ensure_branch_type`.
I like the use of tree.getParent() that is a very clean way to get the calling module's ID.
Explicitly declaring a 24px line-height isn't proportional to the text, and I tend to avoid fixed values for line-height in general (http://meyerweb.com/eric/thoughts/2006/02/08/unitless-line-heights/). We could make @baseLine proportional (@baseLine: @baseFontSize * 1.5) but that variable gets used a lot as a vertical measurement, often assuming a fixed 24px unit. So the variable has become an arbitrary unit that doesn't necessarily relate to the text size, and I wanted to avoid changing all of those instances so I left @baseLine as a fixed unit and used a proportional line-height for actual text.
Having said that, maybe that's a bad idea since clean_excerpt allows <b> and <i> tags.
That's an really interesting bug. I have tested now and can't really say right now what's broken of if that is expected. I would say lets load frame inside the screenshot method for now and lets get a follow-up bug filed so that we can move it up to the top of the file.
@peterbe If you mean that we should use a better ``try except`` structure here, that's done already and will land after this PR as part of https://bugzilla.mozilla.org/show_bug.cgi?id=778744
I am not convinced that this is the correct decision as `TryParseAndVerify` doesn't point in any particular direction.  
However, I am out of arguments, we obviously simply disagree here. I will remove it from this pull request so you can accept it. It will now become part of the contrib project.
Is this new URL part of the ticket? I would have thought this would have gone somewhere else.
Sorry, also can be put like this: <target>Ez da aldi baterako karpetarik konfiguratu php.ini fitxategian</target>
you may add ``twig_ensure_traversable`` to avoid issues with non-traversable elements
When this is resolved, I think we're good to merge.
very nice.  FOR LATER: i think we could improve this a bit further by embedding expectOK and defragDecoder into the state as well; but let’s leave it as-is for now.
This can be `setup` (no parens / params).
I definitely think if more than one thing is invalid we should inform the user. Otherwise they're going to fix the first issue resubmit the form then get another error. If they got informed of both they would just fix them both. It saves the end user a submit.
This is not a good path for this file, as it is inside the code. When a new deployment takes place we may temporarily "lose" the file.
This function below storeCurrentDashboardIdsToLocalStorage was renamed to saveAndInterConnectInApp, like all other saveAndInterConnectInApp on models it attempts to save the model, and interconnect it where it shoudl go in the app.

In this case, all the code taht was here, was refactored and moved into the saveAndInterConnectInApp function of the models and this function simply sequentially calls the saveAndInterConnectInApp of the session, datalist and corpus in that order.

NOTE: what does this mean for debugging? If the Corpus or teh datalist fail to save properly, it could be due to the session failing to save properly, because the later ones are only called upon the sucess of the previous ones.
i dont know if this is the right help text or the other one is the right one. @mecathcart can you take a look and remove one of the two and make the final one locale_Help_Text, not locale_locale_Help_Text
Why are you not using ObjectTypeAttributeDefinition instead of declaring your own AttributeDefinition?
This will revert my spelling correction.
Better to use dot notation and stay consistent with the other code.
unprefix here and in the cases below: https://developer.mozilla.org/en-US/docs/CSS/linear-gradient
Thank you for adding this check.
The forEach function does nothing with the contacts passed as items.
if (!bluetooth || !('getDefaultAdapter' in bluetooth))
        return;
The comment about "add contact" doesn't make sense here since this is the call button.  Looks like a cut-and-paste error from some other time.
You don't need to turn on Wifi again if it's already on
should we check just for the input type text?
This highlight effect style is not only for tool bar button activate, it also used for representing message status if message is read or starred. Hi @caseyyee, do we need highlight effect(or replacing the icon image) in toolbar button to represent different status?
Sweet

Sent from my Windows 8 PC <http://windows.microsoft.com/consumer-preview>

 *From:* Suwat Ch <
reply@reply.github.com
>
*Sent:* Saturday, March 31, 2012 10:50:20 AM
*To:* David Fowler <davidfowl@gmail.com>
*Subject:* Re: [kudu] fix filter excludeFail (#85)

> @@ -52,7 +52,7 @@ public Task<IEnumerable<DeployResult>>
GetResultsAsync(int? maxItems = null, boo
>              }
>              if (excludeFailed)
>              {
> -                url += String.Format("&$filter=Status ne {0}",
(int)DeployStatus.Failed);
> +                url += "&$filter=LastSuccessEndTime ne null";

I did it before sending this pull request.  And it did pass.   The test
simulates the actual failure on first push.   Hence, it worked as is - no
change in test.

---
Reply to this email directly or view it on GitHub:
https://github.com/projectkudu/kudu/pull/85/files#r629992
No 'var' when type is not explicit. Makes it hard to know it's a List of what
Minor typo (missing ')')
Good call.  I'll remove that
Should this also extend Function1[Long,Int] ?
I agree.  It was a difficult choice. Here is the issue: It is faster to build a list in reverse order if you use immutable data-structures (push into a stack).  Then at the end, if you care about order, you need to reverse this list. If you don't care about order, don't bother. Here are the solutions I see:

1) Always reverse so we are correct but slightly slower.
2) Use a Java ArrayList to build the list and convert at the end (probably slower than the above, so I wouldn't go this route).
3) override this toList/mkString in FoldOperations to get the order right.

I'm leaning towards option 1.  Since the use case here is that the lists should fit in memory, I guess we expect them to be small enough that one more run through won't matter.
move to ``maintainer`` module and just call it run
Like before, this code is almost identical to your other prime scripts. Extract these and reduce the duplication.
And in that case we should toss exceptions.
Mumble, mumble, not thread safe :p.
```value``` should be an array at this point so you could just iterate over that rather than revisit @errors.

Might be better to make this:

```<% @errors.each do |key, values| %>
<% values.each do |error| %>```
this should refer to line 78
or `findTagIds`, that is.
You can checkout the implementation of CCNode::cleanup().
Why can not just use CCAssert?
And again fix spaces!
Yes. That would be clearer.
Probably better if you use bean.fire() method for this as discussed.
We always add a flow to UDP "flows" as this allows us to set flowbits, etc. In this case it could be useful when there is some vuln in Teredo itself sigs want to match on.
Works fine for me, but it seems like line 99 still references `self.highlight`.
Am I seeing this wrong or is this line identical to line 98? If so we could save some code.
houve de fato alguma mudança aqui?
if you are complain about the "return include $classFile;", this is not really part of the commit, as it is not changed.
But i understand your complain and would suggest, we add a ticket for it, or discuss it on the mailinglist.
The 'magic' classes are provided by compass's sprites. Using their classes also makes sure we use the sprite rather than loading the particular icon onto the page.
the same like before
I looked at runtime values and `isBuiltin` is never really used. Actually it is used only for require(chrome).
I looked at runtime values because `isBuiltin(path) ? resolveID(normalize(path), requirer, baseURI)`
doesn't make much sense as require(panel) would be mapped to baseURI + "sdk"/ + path = resources://modules/sdk/panel.
isBuiltin returns always false because the manifest normalize all `requirement.path` to absolute path.
So even if we have require(panel) in code, `path` will be `addon-kit/lib/panel.js`.

It looks like we can simplify to only use one form with our current manifest: `uri = prefixURI + path`.
A note in general about this module.  I am converting it to be a PageModule - primarily for unit testing.  Having items as a page module means we get to start them several times in sequence, each with different options, as well as eventually allowing us to simulate how redirection to/from an IdP would work.
Same here. If dir is null/undefined the constructor of the logger should set it to the profile dir by default. That one we could even hard-code. There will never be another default directory.
nit: new line please.
This kind of handling of setting the terminus seems to be often done in the `:hook` part of the setting as defined in `defaults.rb`. An example is the code for the `:storeconfigs` setting.
#1103 fixed the test failures, so this code should be able to go away. :)
You're right, I didn't think of that ...
Why pass `this` in here? It's not used inside, and it's just `window` anyway, right?
Since you're not using the alpha here, can we convert them all to #RRGGBB and use that? The rgb stuff doesn't play nice in IE7 100% of the time.
Since the configuration array is flat, you can use simply iterator_to_array() here, and avoid the dependency. (I'll likely make this change during merge.)
You don't need import this because you are in a parent namespace
and this part.
I did this to be consistent with the MongoDB writer. If no exception should be thrown, the MongoDB writer shouldn't do this too.
Ah, great! That seems like a good change we'll want.
Would you mind rebasing with master?
Multiple var statements.

var statements should always be at the top of the function.

This applies everywhere.
Just making sure that you actually want to test that q unifies with a list that contains 2 numbers and 1 symbols. Clojure doesn't have pairs like Scheme. `lcons` exists so that you can construct sequence like things with an improper tail - in the case of core.logic only logic vars are truly allowed - though we don't do any explicit validation now - we may do so in the future. A closer translation of this test would be:

```clojure
(= (run* [q] 
      (nom/fresh [a b] 
        (== q (lcons 1  1))
        (nom/hash a q)))
      (lcons 1 1))
```
how about if typeof config !== 'object' ?
I like this :-) (replacing toxml for outerHTML)
@stof this issue seems fixable: when setting up the proxy one could unset the public properties of the instance and provide __get/__set so that lazy loading can be triggered. Little bit hackish but it should work.
Why bothering about XML in the YAML driver ?
yep, the more i look at the ORM `Query` (which i did not find before because its not in the Query namespace...) i think we should mimick ORM AbstractQuery / Query signatures.
why use NSString here? NSDate might make more sense.
Nevermind, I'll use the demos that come with DOLFIN. One of will probably crash if DOLFIN is built with ictce but without packed groups.

I'll run the demos in the test function after the build step.
If supported in Python 2.4, yes.
As the test now extends AbstractSubsystemBaseTest all that is already done there, and there is no need to do that extra work.
But i agree, there should be additional test skeletons in place for people to see what all is possible. will add them back in extra class.
In addition, whenever I use `spread`, `then`, or `fail`, I always move it to a newline with one tab, like so:

```
q.ncall(fs.readFile, fs, "example.txt")
  .then(function() {
    // callback here 
  })    
  .then(function() {
    // next callback here
  })
  .end();
```
only for development, really?
I don't think the password is needed: https://github.com/mozilla/mozillians/blob/master/apps/common/backends.py#L46
Could this check be removed? why not just aways get the currentTime at load. If you make this change, add a comment noting that it's used for videos that start at a non-zero time.
Missing curly braces here
we don't need the ";", so please delete it.
There's got to be a better name than Helper and help.
I don't think we should - I didn't do this, did I? In other
translators we first check wether an author is in all caps (by testing
whether it's equivalent to author.toUpperCase())

On Thu, Mar 22, 2012 at 9:09 PM, Simon Kornblith
<reply@reply.github.com>
wrote:
>> @@ -550,7 +550,13 @@ function addHighwireMetadata(doc, newItem) {
>>               }
>>               for(var j=0, m=authors.length; j<m; j++) {
>>                       var author = authors[j];
>> -                     newItem.creators.push(ZU.cleanAuthor(author, "author", author.indexOf(",") !== -1));
>> +                     author = ZU.cleanAuthor(author, "author", author.indexOf(",") !== -1);
>> +                     if(author.firstName) {
>> +                             //fix case for personal names
>> +                             author.firstName = ZU.capitalizeTitle(author.firstName, true);
>> +                             author.lastName = ZU.capitalizeTitle(author.lastName, true);
>
> Not sure if we actually want to do this. What about names like McDermott?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zotero/translators/pull/242/files#r594617



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
ok. i see. moved the logic here.... right on
I'd prefer we follow the convention of attaching our JS to a single global namespace similar to login.js

`CUI.closeFlashMessage = ....`
It feels weird to me that this isn't a square. (Also, you could do this with a single `path` call.)
Do we really want to use a store with the workspace cache? It certainly is a nice feature to have (for sessions with very large state), but not sure we really want to encourage people to use it.
This class doesn't suppose to be here lol
I forgot about that discussion! There were good points on both sides... I didn't mean to restart that discussion here. Regardless, we can define a standard place in `NDData` or `Image`, where the gain should be defined. Either in a `gain` property or in the metadata.
Lets use new shell syntax: `cd $(dirname $0)`
I appreciate both templates (setVlanIdInLT.vm and setVlanIdInETH.vm) are equals. I suppose the reason is to follow the same 
nomenclature as the other templates, or maybe we can fuse them in a setVlanID.vm
``else if`` should be on the same line than the closing curly brace
What's the purpose of the `_wait` here?  Can this be left out?
If you change this migration to use:

``` ruby
t.references :player
t.references :badge
```

Then is both makes the migration simpler, and saves you from having to manually specify the indexes
Note that the motivation for this is both security and flexibility. Using an abstracted URI scheme allows us to expose less of the file-system to the REST end-point (we could limit to only the `ui` directory and the individual widget npm directories).

For flexibility, it would allow us to load widget resources in different ways, and abstract the fact that we're just reading widgets off of a file-system. e.g., accessing and caching widget resources from a remote repository.
It outputs results per dataload, so I think this is fine?
We've been using _.keys everywhere. I'll leave this one in until we decide to do a big find and replace.
Should be optional as well.
You'll be able to get rid of this as require is synchronous.
Hmm, shouldn't this be outside of the method? Now it is called twice (after the change I asked for ...).
I'm not a big fan of how this paragraph sounds. I know we haven't been very consistent with our versioning rules in the past, but this seems as if we didn't have any rules at all, which sounds quite bad. I think we should just focus on the present and future and start the paragraph saying "Liferay's release process follows a prescribed structure that ...."
you mentioned that you also wanted to support ``/foo/bar`` .. however with this change these types of routes will still be passed to the core router. so maybe we need to make the check smarter?
Fair 'nuff! I'll clean it up when I clean up the branch.
I don't agree on this change.
:+1: for `OIORest` .
Should that be `if (!e.Request.Url......`?
Unless it would be used elsewhere - yes, otherwise it doesn't make sense (functionally). Just leave a comment above it to describe what it does.
Ну судя по комментариям в других решениях — все-таки выносить это общая практика. Тем более я думаю — чем раньше будут использоваться "правильные практики" языка, тем лучше. Опять же — это ничего не стоит :)
@lilumi
```myCell.DNA = [[NSMutableArray alloc] init]; // не скомпилируется, потому что проперти readonly```
Если вы импортируете Категорию, то нет необходимости импортировать заголовочный файл основного класса. В категории заголовочный файл уже был подключен. Это не ошибка, так как импорт делает всю работу за вас и проверяет чтобы никакой файл не был подключен дважды, но все же это хорошая практика не импортировать файлы, которые уже были импортированы.
Изменил алгоритм.
Замечания: 
1 кол-во процентов надо вычислять - для данного задания так счастливо совпало что кол-во элементов 100, но если эту константу изменить, то этот алгоритм не будет работать
2 алгоритм лучше делать через цикл for смотрите решение https://github.com/Hexlet/osx-project-1/pull/17 или мой вариант https://github.com/Hexlet/osx-project-1/pull/343
Обязательно надо исправить момент с процентом изменений. Исключить случаи когда процент задан меньше 0 и больше 100.
Остальное все работает
nesting?
It just struck me that the localItem here, if present, is never even used. Needs to be fixed before we merge, stupid mistake on my behalf.
I'm saying that from _within_ a subscription, `+deferredScheduler` will behave the same regardless of whether the subscription was dispatched to this `+subscriptionScheduler`.
Right, I mean, I know it binds to it. Seems like that same capability should be available to third-party subclasses – maybe we can just mention in the property's main documentation that it supports writable bindings?
This seems like something I'd do in a seed file.  I don't see anything wrong with this tho.
what do you think for : read_bad_channels_from_file?
for a user in ipython figuring out an object with tab it's better to have very explicit name.
good, I will use that then
add:

import pylab as pl
pl.show()

otherwise people won't know why they don't see anything
upload media url should have an http:// just in case
We only have one in _core_ but there could be more in modules. So in a test, I think this is fine.
Why spy here? It's not a context sensitive test so Context is not properly setup and usable.
Fixed in 85ffc31
Fixed in https://github.com/srikanthlogic/jquery.ime/commit/fa0467406ee9569a462a02199572852973eec418
I don't know.  Cleaned up.
just a honest mistake with vim sorry about that
This was just completely wrong, I'm talking about the use of address.toString both to set as Node value AND to do comparisons between nodes, don't understand why toString should be used
This probably doesn't work if `fun` is a class method, and `hess` is not, or vice versa. `inspect.ismethod` may help.
> Can't we just use S() and read the variables and coefficients from it?

It would be slower.
И оно.
Do we have the download URL do maven?
So just to clarify, does that mean things like tick spacing, coordinate system etc. get set in ``grid_param``?
On Wed, Mar 21, 2012 at 01:05:10AM -0700, Christian Kaenzig wrote:
> > @@ -0,0 +1,5 @@
> > +// file managed by puppet
> > +Unattended-Upgrade::Allowed-Origins {
> > +  "Debian testing";
> 
> Doesn't the use of "Debian testing" risk breaking (or force upgrading)
> wheezy installs once it becomes stable ? Wheezy installs (that do refer
> to "wheezy" and not "testing" in the apt config) will become stable, but
> it seems this will pull upgrades from the new testing.

I spent some time trying to see if there was a better way of doing, but
from what I figured out, the problem is that the release file on Debian
mirrors contains:

Label: Debian
Suite: stable
Version: 6.0.4
Codename: squeeze

... and the filtering is done on the "suite" field. There seem to be more
fine-grained options in newer unattended-upgrade versions, but I was unable
to make this work as it's described in the docs :-(

To answer your question, when stable switched from lenny to squeeze,
unattended-upgrades didn't automatically upgrade everything. I'm still not
sure I understand why...

One thing I would like to suggest, is to add
"APT::Default-Release=$codename" ($codename being squeeze/lenny/wheezy) on
every *debian* machine we manage. This slightly changes how apt-preferences
work and would even allow to mix backports/stable/testing/unstable/etc in
the sources-lists without risking accidentally upgrading half the system
(possibly in an unattended/automated way).

From apt_preferences(5):
  If the target release has not been specified then APT simply assigns
  priority 100 to all installed package versions and priority 500 to all
  uninstalled package versions, except versions coming from archives which
  in their Release files are marked as "NotAutomatic: yes" - these versions
  get the priority 1 or priority 100 if it is additionally marked as
  "ButAutomaticUpgrades: yes".

Any thoughts ?
I don't think that would help, as the NPE only happens when the cache == null and thus line 42 assigns waypoint to logable, so that dereferencing logable.getGeocode() produces the NPE.
It might be simple to implement, but a cache is definitely a heavyweight construct. So this makes map-reduce tasks rather heavyweight as well.

I like the idea of allowing one node to start a cache on all the other nodes. Users have been asking for this for quite some time: https://issues.jboss.org/browse/ISPN-1147. But I think you need a way to stop the cache on all the nodes as well, especially if you want to create a cache for each task, and I haven't seen anything like that.
I don't think it's worth optimizing a _loadAllEntries_ making it more complex, this is going to very slow anyway. Also, I need uniqueness and the size of collection is unknown.

> Recently the memory cost of java collections has been demostrated in presentations such as

yes it was me removing most of them from Infinispan core (and sharing that link)
"multipart/form-encoded" -> "multipart/form-data"
Correct. I don't know how I could have missed it... I've deleted the FIXME
What about the undefined case (not a scalar, nor len in [2, n])?
Would you mind opening a bug for this one?
Ok thanks @WeatherGod & @mdboom. I appreciate you taking the time to explain the problems that we are facing in the codebase. Obviously we encounter other problems by making None mean "the default" (for instance ```'none' != None``` with many colour keywords) but maybe we should spark up a thread in mpl-devel mailing list to get the ball really moving on improving the rc system (as there is more to this than is being proposed in some of the outstanding rc related pull requests).

@epeisach apologies for giving you an action which was ill-advised.
Removed use of pyplot.
I won't insist, but this is a case where the PEP8 injunction against using extra space to line things up is silly and counterproductive.  I can't imagine anyone thinking that removing that space makes the block more readable.  I'm glad to see that at least the other alignment was not removed.
Machine specific configuration.
When using parseInt, you "must" use the second parameter which defines the base (http://www.w3schools.com/jsref/jsref_parseint.asp)
Using ECMAScript 5, the second parameter is 10, whereas it was 8 before ^^
Missing the int(i) in range(0, 10) check you had before
.has_key() is deprecated, use 'in'
Does this mean we need to add the tazdem.tiff to the openlayers/examples/data dir as well?
Ha nice!
Yes we'll need to map it to the correct key, I'm assuming we'll need to think about this at the same time when thinking about mimetypes.
why are kernel factories still there now that you use shallow_copy() ?
Do you mean just do    CDenseFeatures* features=new CDenseFeatures(); ?
This is what it effects https://www.evernote.com/shard/s24/sh/036096ff-c223-4b29-85a2-6010e6b49edc/d0211d16e889e44e8a65bde83932e248, I've simplified it as I couldn't see why I had styles in the first .fieldgroup when those styles are exactly the same as .field . 

have updated to 
.field {
 ...
.fieldgroup { /* This is used on page/settings/visibility and removes a double border when a fieldgroup appears inside a field */
    	border-bottom: none;
    	box-shadow: none;
    	padding-bottom: 0;
    	margin-bottom: 0;
    	fieldgroup-field.last {
    		padding-bottom: 8px; /* replicates li item spacing */
    	}
    }
}
Jo jo, zkouknu, ale chystám se na to vlítnout zítra (vlastně dneska, prostě v neděli :)) Teď už není úplně kapacita.
Thanks for the catch, I forgot to update when I had copied the test over.
a future version will let this be tweakable?
有可能不改這裡的 haml 直接就他原本的去調整嗎?
How about using ``$packages[$secondPackage->getUniqueName()]->name`` instead of ``$packages[$secondPackage...niqueName()]->getName()``. There are some issues with ``getName()`` and APC-enabled PHP versions (see https://bugs.php.net/bug.php?id=61384).
Are you sure ``$mockStatement`` has the correct type as ``object<PHPUnit_Framework_MockObject_MockObject>`` is not a sub-type of ``object<Zend\Db\Adapter\Driver\Sqlsrv\Result>``?
This seems wrong, if this line is commented, then our change shouldn't revert the commenting out, but rather do `if (Ti.Platform.osname !== 'blackberry')`
"the number iteration" => "the number of iterations"
You should line-break at about 79 characters: http://www.python.org/dev/peps/pep-0008/
However if you want, it's not needed but personally I don't mind it.
This is the title of a contrib category. "Estilos" is fine alone.
I am not sure if use of this class is really the best approach. You probably decided for this because you had problems when one class overridden messages from the other class.

This is why it is not really good to declare fields, but it is much better to declare methods, because methods are all called in a chain (if you use `super`). And each method can add to the list of messages its own messages.

But even that I don't like. I am not sure why are you really using `error_messages` to begin with? Those are used inside fields, as I see in Django, not forms. But I do see they are used in user forms.

Anyway, much better way is to define validators for fields. Or just put those strings directly where you raise `ValidationError`. The trick is, call it like:

```
raise ValidationError(_("A user with that username already exists."), code='username_exists')
```

Then later on some post-processing can be done based on that code.
No need for user resource.
One more thing. The Query class could be simplified simply to:

```
class Query(object):
    query_terms = constants.QUERY_TERMS
```
You can combine those two lines into one line. Just check that the order is the same as elsewhere (Django built-in are first, then libraries, then ours).
In general, you don't want for users to be able to create notifications over REST. You should disallow this.
Case is obviously wrong. Fix.
I may be wrong here, as I can't say that I hold every detail about that proxy generation algorithm in my head, but as far as I can see, what it currently does is that it uses this heuristic to pick a *single* 'compatible' constructor. So far, that has worked because the rules used to pick that compatible constructor have guaranteed that the proxy generator can subsequently invoke that constructor.

AFAICT, the change proposed here changes that selection algorithm from a guarantee to a good guess. However, that guess may be wrong.

If there's only a single constructor on the type in question, this is likely not a problem, apart from perhaps a misleading exception message, but what if there are several constructor overloads? What if a second constructor overload was *also* compatible? Will that be picked if it turned out that the first one didn't work after all?

If you consider the implementation of *Ploeh.AutoFixture.Kernel.ConstructorInvoker.Create* you will see that what it does is that it iterates over *all* constructors, and for each constructor it attempts to check whether all the generated arguments are valid. It invokes the first constructor where this is the case, and returns the result.

In this context, if we are to take the route where we attempt to downcast objects, wouldn't it be more appropriate to try out all possible combinations?
I removed the rouding to the nearest 10s of meters, but stayed away from using doubles.
Fix your indentation.
This is one stat call less, not really worth it, while it could be (later) abstracted into a service. This is micro-optimization right now, and introduces too much complication.
I'm not sure what you're referring to...the snippet you've included has a case statement and the first 3 lines of a method...the Builder::XmlMarkup usage?  If you would like it to be some other way please let me know
Can this commented out code be deleted?
Your change looks reasonable to me.

Since the mapping of AVS response codes was done in AVSResult, I wanted to mirror that pattern. That's why I created a subclass of AVSResult instead of putting all the mapping logic into the gateway itself.  I'm not thrilled with it, but it seemed like the least inelegant solution.
Please remove the space after the negation operator.
you serious????
ok. I will correct that.
Rewrite this sentence to eliminate "etc."
thanks I'll use that.
"is" instead of "if", I guess
A general note, applies to all comments on bools: I strongly prefer when documenting boolean values to explicitly state what the values of true and false do. So instead of "indicates whether to..." I'd rather this say "If true, package validation warnings are treated as errors. If false, warnings are treated as warnings."

Repeat this for all bool fields/parameters/etc.
again, $arr is not a good variable name, it should be something like parentArray.
Can't find that classname referenced anywhere. Isn't it always `.resource-detail-container` being scrolled?
Not sure if this belongs in the templates.
ngx_http_clear_etag() appears after Nginx-1.3.3. It's not in the latest stable version Nginx-1.2.4 yet.
Should be on the same line as the if
also, wont wehave to backdate the RDF file, as it will still technically point to the etext and not the numtype?
Yeah I would return a results class from fit. The Model should at least have a fit and a predict method.
when shuffle button pressed, set the autoreplay value removed
这句好像跟英文的不一样，就如翻译HTML页面一样，里面的tag是不能改变的。
I like project, but is there potential overloading with builder/project_templates?
Removed that import since it was redundant.
This is the funky unwrapping to go between the return types.
Oooh, actually that's a bit of a typo I think. Doesn't seem to have stopped it working, but it wasn't what I meant to do!  Will fix...
just a safety precaution--i know our send rates have been bumped up a lot
StudentExamStart -- this is a model change that @jbau made on fall2012-master, and is in our database of course, but I guess hasn't made it onto master yet.  So this *should* be fine, but a little bit surprising to see in your PR @jrbl.
check response code.
This changes needs to be splitted up. The code that changes the return type should go to a separate PR (see my other comment).
Why did you force the same email?

This will prevent to create more than one `:admin` factory in the same test
Looking further, I infer that create_user can also be a function. So then the first if block covers falsey things (False, None, empty string) and this covers True explicitly. So that makes sense.
We can compact these if statements.

Also, you don't need to check that a hash has a key before attempting to access it, so `rules.has_key?(:sign_before_symbol)` isn't necessary, it will just return `nil` if it isn't set. `nil` will be 'falsey' so you don't need to explicitly check for `true`. At this point we can probably make this a one line assignment:

`sign = (rules[:sign_before_symbol] && self < 0) ? "-" : ""`
I thought we decided that:

a. We need to keep all the examples working for now.
b. They should be tested.
Just Jabber ID here. You can put a different Google id in the Google-specific wrapper (GoogleWrapperSip)
@andreasbotsikas  sounds good.. we can do this namespace changes later
We tend to stick the return-by-reference argument first, by convention.
Well yeah. Sorry for confusion. Have a good weekend!

KEY

On Jun 29, 2012, at 4:26 PM, David Welch
<reply@reply.github.com>
wrote:

>> @@ -199,9 +199,9 @@
>> BRAINSCutTrainModel
>> ::printANNTrainInformation( neuralNetType& myTrainer, unsigned int No )
>> {
>> -  std::cout << " Error, " << myTrainer.get_MSE()
>> -            << " Iteration, " << No
>> -            << std::endl;
>> +  //std::cout << " Error, " << myTrainer.get_MSE()
>
> It's in the git history, so there's really no need to keep dead (or dying) code around.  If this code may come back, then it may indicate the merge isn't ready for the master branch.
>
> What you could do if you're really sure about merging, is remove all the commented code and after I've merged it in, you can revert your private branch back to the version with commented code.  That way the dead code isn't around to confuse others and you will have it at hand to reactivate when you want it.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/BRAINSia/BRAINSStandAlone/pull/90/files#r1079100
That looks like it'll screw up something.

On top of that, what the hell happened to this file to add the .git files?
I'm fine with it for F4 targets since we're lighting up all clocks during early init on those boards now.

Removing clock control from each device driver isn't ideal though if we ever decided to try to save power by disabling clocks to unused peripherals.  On a quad/plane, the F4's power consumption isn't worth measuring.  It becomes more important when trying to use these boards for telemetry collection boards with small batteries.