labofsahil/github-event-dataset-2012 huggingface dataset:
This is a small thing, but maybe we should agree on a consistent indentation style? I don't like this style of indentation (leave initial line intact and indent next line a large amount to match) because it causes large jumps in indentation that ends up requiring a lot more line continuations than would otherwise be necessary. Instead, I'd do this:

```
self.stdout.write(
    "You must supply a project name to POST data to: --project project\n")
```

Where the first linebreak always comes immediately after an open paren/brace, and no relative indent other than 4 spaces is ever used.

More detail and examples of the style I prefer: http://moztrap.readthedocs.org/en/latest/standards.html#line-continuations

If you have arguments in favor of a different style, I'm open, but I think it'd be good to establish a standard style for datazilla and use it consistently.
Nit: Bugzilla should be capitalized. "specifing" is spelled wrong.
This is to make the gradient color for the box.
Let's just remove this implementation. This is redundant.
This has been changed in the updated commit.
Er... why doesn't the first line work, and why does the second line fix it!?
I imagine that the biggest use case of constant stubbing will be to replace `Class`es.

What if `stub_const` defaulted to replacing the constant with `Class.new` (`value=Class.new`) and returned the new stubbed constant? That would allow things like:

```ruby
stub_const("MyModel").stub(:find_by_foo).and_return(bar)
```

Like @dchelimsky, I am having trouble finding a use case for doing something with the original constant.
Ohh no the first vim nerd battle. I really don't like ```,``` as leader :). 

I think we should be able to use:

```
:nmap \ ,
```

So that we can use the default leader and ```\```
Maybe move the line number logic to `errorDiff` along the lines of `errorDiff(err, type, escape, lineNumbers)`
I personally don't like much else without brackets
That's in contradiction to your first comment as I would have to "use
Barcode\Object\ObjectInterface"
already did this.
@anti UNLOCK tähän
it is merged
does this code support namespace alias (``MyBundle:ValueObject``) like in the from clause for entities ?
uow remove translation just returns silently for non-translatable documents.
Change to one line:

if (!view.hideNavBackButton) this.$backButtonElement.addClass('pop active');
No need to do this way since the legacy kernel closure holds the legacy kernel in a static variable. Following code is sufficient:

```php
protected function getLegacyKernel()
{
    $legacyKernelClosure = $this->legacyKernelClosure;
    return $legacyKernelClosure();
}
```
No it only adds one method and changes `$root` visibility. Extending the class could indeed be the best way to go but this is not possible here because of *private* visibility. I'll make a PR on the Symfony repository soon.
This class represents a boost (multiplier) for matches occurring in the given field.
It's object in this case. So it is correct, actually. Afaik.
I'll try and come up with a sanity check command that checks whether the build was done correctly.

Suggestions are welcome, @JensTimmerman you've been playing more with DOLFIN than I have.
Hehe, mocking is always fun. ;) I was wondering why you need the `Browser` though. I'm wondering why you need the browser though. The `submit` call you use could be replaced by `this->httpRequest($url, $parameters)` like in `GenericResourceOwner`.
I think this should refer back to the root README which describes how to add a user in more detail.
This might be a bit confusing, as it's covered above in "What is it".
Please re-add the omitted ending period, here.
I've been hitting my head over this. I was thinking about updating the search index once the UserProfile object has been created (actually inside the if statement) and then updating the IRCname because at the moment if I try to add the IRC name in from the instance it just output the instance ID (rather than any field within it)
You aren't using this.
So you could just do `PageProvider().provide_kb_new_article()`
Well, yes - but you never want to save tags in the non-copied file (in case you're copying) => save the tags to `new_filename`.

 In case you're not copying the file it doesn't matter if you save the tags (to `old_filename`)and move the file or move the file and then save the tags (to `new_filename`)- the file will be the same, only with a different name.

So independent of `copy_files` you can always save the tags to `new_filename`.
As before, the space/tab combination is wierd. We recommend using 4 spaces as indent, and no \ts. Most code editors (notepad++, etc) have the option which auto-converts any tab to spaces.
the next 3 `function` blocks should have their content, including closing brace, indented by 3, the commas should be hanging out on the left on their own.
i think you can wait for vm.ready?
I believe you want `item.abstractNote` here
The tests are valid now.
No need to redo the ZU.cleanAuthor call here. `item.creators.push(newAuthor)` should work just fine.
Can I also ask the point of this?
Is this function expected to be called on each keypress? Are we certain that there are no performance/invariance assumptions here that we are breaking?
I think all the pluggins inside manticore should have it at least.

This is how it is going to end once we collapse bundles anyhow.
yes, just was for a quick test and forgot to change it
Is `get_media_url` used anywhere here? It doesn't seem to be.
yeah i would just go with truthiness. toss this whole block!
No, it doesn't work. Just try it yourself.
ok...not sure!!
comnet jus above
Excellent. Thanks for the clarification!
Doh.  Need to fix this.
Matter of taste perhaps.. but I think this is not 1 word..
You'll need to specify radix 10 as the second argument
Actually I think I should be selecting first 2.
I switched it to just passing `tenantAlias` in anticipation of the merge.
Why was this moved? It looks like `currentModule++;` should still work.
I know you can do these kind of truthy evaluations in JS, but can we be explicit?
Something like this:
```javascript
assert.ok(!err);
numComments--;
if (numComments > 0) {
    postComment();
} else {
   callback();
}
```
It might actually be good to add the download URL to getContent (it's fine for this just to be the /download link), I think it makes the API easier to use.
Yes, do this for the other mobs, as I commented above.
Метод работает, но он как мне кажется не практичный. А если у Вас будет ДНК размером с 10000000 элементов и процент мутации равен 99%? Ближе к 100% мутации код будет буквально пробегать снова и снова всю ДНК.... Кстати, размер ДНК можно было бы задать в #define...
No the test should be:
  Given I am a valid user
  Then I should be able to login.


Here's the thing, these tests are PROBABLY going to go away once you have other tests in place so make them slim!  You will have these are like step 1 once you build the rest of the app so to do it just by itself, won't make sense.
Master always needs to have release as true.
Any reason to not just use the actual method?
Why is knowing the current scheduler valuable during subscription?
Not entirely sure about this change...
What are the expected values for `mStatus`? Maybe an `enum` would be a better choice? or defined constants in this class?
don't use absolute import

from .baseline import rescale
Ok, great! I wasn't sure about that one. So we could drop the assert or think about two conditional asserts for both cases.


On 27.09.2012, at 23:22, Alexandre Gramfort <notifications@github.com> wrote
> In mne/artifacts/ica.py:
> 
> > +        data = np.dot(whitener, data[picks])
> > +
> > +    elif noise_cov == None:
> > +        data = _zscore_channels(data, info, picks, exclude)
> > +        # data = data[picks]  # bypass
> > +
> > +    data = data.T  # sklearn expects column vectors / matrixes
> > +
> > +    print ('\nCalculating signal decomposition.'
> > +           '\n    Please be patient. This may take some time')
> > +
> > +    ica = FastICA(n_components=n_components, whiten=True, *args, **kwargs)
> > +    S = ica.fit(data).transform(data)
> > +    A = ica.get_mixing_matrix()
> > +
> > +    assert np.allclose(data, np.dot(S, A.T))
> this will only work if you don't do any dimensionality reduction with n_components < n_channels
> 
> otherwise you loose data on purpose which can be good eg. maxfilter keeps only 64 PCA like components on purpose
> 
> —
> Reply to this email directly or view it on GitHub.
>
I think it should be blind to the type Epochs/Raw and store a mixing that applies to all types
this is not important here but you can apply sqrt to an array inplace whitout any allocation

data = np.sqrt(data, out=data)
It's not correct. If any of the inner methods fails, all changes must be rolled back.
the request seems like a weird case. A common case for the object is using the AclVoter which will check the ACL associated with the object
I prefer to add this in a tip/caution block.
I think I'll add another file for instruction on how to running the test.
You should probably use the `java.io.tmpdir` system property here.
I’ll change the objective to just include `system.settings` in DispatcherPrerequisites, which fixes your complaint.
Or rather, how can a LocalActorRefProvider have an external form with a protocol?
No estoy de acuerdo en este punto. Si bien un postulante puede quedar o no seleccionado para una búsqueda en particular, no por eso se descarta completamente, sino que debería quedar en la bar de datos para futura búsquedas en las que se le podría ofrecer un puesto. ¿Está considerado esto en esta funcionalidad?
Not off the top of my head, no. You can try http://rogerdudler.github.com/git-guide/ or http://git.or.cz/course/svn.html to see if they are helpful.
What would you like me to change to that? "Status" or "I love chocolate." ?

When I change "Status" to that, I get a syntax error because the process used to determine the controller names chokes.
Can't the class be parameterized with K,V of the cache?
Assetic is using the Symfony2 coding standards, described in the Symfony2 doc.
As you probably guessed, I would prefer the filename to be lower case for the same reason that the spaces have been removed. Having said that, I'm not overly fussed if you would prefer to keep  mixed case.
I tried that but it wouldn't work. Seems a nuance of the assertRaises.
Ca change le message affiché quand le joueur n'a pas la permission d'utiliser la commande (le message automatique pour la permission defini dans le plugin.yml.
У нас много где есть create который должно совпадать по аргументам с construct. Тут просто отступил от правила и назвал метод begin, для наглядности, т.к. хорошо ложиться. Но так или иначе при существующем create мы конструктор приватным не делаем.
oh woops my bad I overlooked this
No, unfortunately the standard says that <when>s and <gx:coord>s must be
the same in number, but they can appear grouped or interspeded. So, this is
valid:
```
<when>
<when>
<when>
<coord>
<coord>
<coord>
```

But is is also valid:
```
<when>
<coord>
<when>
<when>
<coord>
<coord>
```

So the code needs to keep track of how many pairs it's found to avoid
having to wait until the end of the track to update the UI.
El 03/05/2012 23:24, "Robert Bruce Park" <
reply@reply.github.com>
va escriure:

> > +    def element_end(self, name, state):
> > +        """Keep parallel arrays of whens and gx:coords. When we have a
> complete
> > +        pair, add it to out tracks.
> > +        """
> > +        if name == "when":
> > +            try:
> > +                timestamp = dateutil.parser.parse(state['when'])
> > +            except Exception as error:
> > +                print error
> > +                return
> > +            self.whens.append(mktime(timestamp.timetuple()))
> > +        if name == "gx:coord":
> > +            self.coords.append(state['gx:coord'].split())
> > +
> > +        complete = min(len(self.whens), len(self.coords))
> > +        if complete > 0:
>
> Will the `complete` variable ever be anything other than 0 or 1? It seems
> to me that element_end will get called many times where `complete` will be
> 0 after the first `</when>` (or whatever other tags might appear in the
> KML), and then it will be 1 after the first `</gx:coord>` rounds it off,
> resulting in the arrays being slashed and `complete` going back to 0.
>
> If this is the case then the following for loop is a bit wasteful, as it
> will only run the one time.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/robru/gottengeography/pull/48/files#r770991
>
SG_ERROR makes more sense there
is there a better way to indicate the default option than (*)? it doesn't explicitly say anywhere that (*) = default

maybe like 'Option A (default):'
(I imagine the 'default:' would go on the next line in the table but clarity is more important than aesthetics here I think)
Things come in by order now not by id.
As per the PHP manual, the umask is restored when each request is finished. Does it need to be reset then?
Yes. They appear in their original location within the document. See below.

Text 1   ||  Text 2
********************
       figure
********************
Text 3  ||  Text 4


On Tue, Nov 13, 2012 at 4:08 PM, Philip Schatz <notifications@github.com>wrote:

> In css/ccap-biology.css:
>
> > @@ -1690,7 +1703,7 @@ div.book > div.appendix > div.titlepage > div > div:not(:first-child) {
> >  .span-all {
> >    column-span: all !important;
> >    -webkit-column-span: all !important;
> > -  float: prince-snap;
>
> So what happens to .span-all elements without the snap? Do they just show
> up in the middle of text?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Connexions/oer.exports/pull/28/files#r2117070>.
>
>
A leading slash should not be causing problems. If it is, this is a bug in Elgg core. In fact I think I prefer leading slashes because it makes it clear that it's a URL being passed in.
- Are you sure the method ``lock`` can be called on ``$this->store`` (of type ``object<Symfony\Component...l\HttpCache\Store>|null``)?
- Are you sure ``$this->request`` has the correct type as ``object<Symfony\Component...oundation\Request>|null`` is not a sub-type of ``object<Symfony\Component\HttpFoundation\Request>``? I also found this on lines 66, and 71.
if (sum > 500) {
This was from a discussion with @daibach, where we came to the conclusion that it's better to stick to a baseline of 30 minutes and adjust as we understand load better post-release.
Like this:

<algorithm id="de" class="ec.EC">
            <iterationStrategy class="ec.iterationstrategies.DifferentialEvolutionIterationStrategy">
                <trialVectorCreationStrategy class="entity.operators.creation.SaDECreationStrategy"/>
            </iterationStrategy>
</algorithm>

Just to show how the trial vector fits in...
I think they fixed this in C# 5?

might be worth pointing out that "foreach" had proper closure semantics for the iteration variable.
I think this is the reason the build is failing... Maybe just `TestNorwegianBokmalInflections` without the å?
Must be: JHtml::getJSObject($opt);
Found this because an error in 3.0beta in Extensions->Warnings
We (sadly) don't use logging in this app, so is it really necessary to do this for this case ? And if yes, we should use a specific logger
Just noticed this is commented out. Let's use it?
Why have this variable? Why not just for loop over the result of the function call?
Do you mean like that: 

if user.birthdate == None or user.language not in horoscope.get_supported_languages():
horoscope_error = True

or

if user.birthdate == None or user.language not in horoscope.get_supported_languages():
            return context # nothing to set
Can you please describe in the comment what all fields are in `google_user` and what they mean? Like for each field in its line. So that later on other developers can know what is provided if it will be needed.
This and next line belongs together. I'll fix it.
Forget that. It should be.
Why are you calling tasks from `get_context`?
A comment describing what are you doing here would be useful.
You are really careless. `alt` should be translatable string.
Move this to the end of this variables. It is the least important, or it is a special value.
Yeah, I went back and forth about that.  I went with a method name because writing the double parens in _DoImportOldItems()() seemed weird.
put the comment on the next line
not work for me, the group doesn't receive the reward
why? There are lots of accessor functions that aren't const.
All calls to X_url() should be api_X_url()
Bitte wieder auf brauhaus ändern.
added elgg_register_menu_item
https://github.com/lianglee/elgg-questions/blob/1.8.5b1/start.php#L53
I've tried so hard to like mini-test ... 

Sent from my timemachine!

On 22 Nov 2012, at 18:04, Ben McRedmond <notifications@github.com> wrote:

> In test/intercom-rails/script_tag_helper_test.rb:
> 
> >  
> > -  def test_strips_out_nil_entries_for_standard_attributes
> > -    %w(name email user_id).each do |standard_attribute|
> > -      assert_match(/.#{standard_attribute}.\s*:\s*"value"/, intercom_script_tag({standard_attribute => 'value'}))
> > -      assert(!intercom_script_tag({standard_attribute.to_sym => nil}).include?("\"#{standard_attribute}\":"), "should strip #{standard_attribute} when nil")
> > -      assert(!intercom_script_tag({standard_attribute => nil}).include?("\"#{standard_attribute}\":"), "should strip #{standard_attribute} when nil")
> > -    end
> > -  end
> > +  def test_delegates_to_script_tag_generate
> > +    delegated = false
> > +    IntercomRails::ScriptTag.stub(:generate) {
> this doesn't work because the test cases are MiniTest not RSpec. I did try it.
> 
> —
> Reply to this email directly or view it on GitHub.
>
I had considered removing the flag and just requiring that logic to be done in the PathFilter, what do you think?
We should either have two flags, or none.
I don't know if this documentation should go here or in the code of the plugin. thoughts? maybe we should get this doc from the docstring somehow?
If these are for messages, why not use the enums from the generated classes?
Style errors: type*
is \*in\* the main config
You can omit quotes quotes in such cases and use `:@decomposition_map` instead.
IMO, the "file" entries are not about artifacts ("artifacts" implied here as "maven artifacts"), hence this GAV check makes the content almost the same as the artifacts feed (class above).

Here, IMO, no GAV check should happen and should just pour _all files_ it has.

Again, the main distinction about *artifact and *files feeds (those that are doubled) is that former shows only _files obeying maven2 layout_ while latter shows all (obviously, latter is superset of former).

Still, "general" filtering rules do apply (ie. content generated items are not shown, but that is handled in EventInspector, and are not even recorded)
Well maybe.
but it doesn't work if machine has no default gateway (VERY unlikely in production or even testing environment), so i guess in those rare occasions we need to switch back to gethostbyname(), i guess it should be 
try gateway_interface 
except: gethostbyname 
in archipelcore
i think this needs to be:
```
try { 
  super.close();
} finally {
  file.delete();
}
```
effficient -> efficient
I'm pretty sure I've not done any #ifdefs for images in Python wrappers, so that's one place where not defining that would already cause problems.  I also vote to remove them, though it may be cleaner to not do that on this branch.
rename groupbox5 and 6
If someone asks you to write useless code, you shouldn't listen to him....
If we were maintaining this, I'd say we could use a polymorphic donor class or subclass campaign_friend for user or something but this is perfectly fine for now... just thought I should mention that
k maybe MoreStrings ?
Will have that in the next pull request.
Would be good to include a TODO or a FIXME with comments like this.
Unfortunately, non-material whitespace differences are also reflected in this commit's 'diff'.  The lines below are the key change made to resolve the infinite loop issue when updating authority reference display names, described in CSPACE-5359.
Chrome prevents previewing the home page because it finds script tags for the preview content.
You can look at the screenshot of the error [here](https://dl.dropbox.com/u/43385510/Chrome%20-%20XSS%20protection%20requirement.png "Chrome - XSS protection requirement.png") and the stackoverflow discussion [here](http://stackoverflow.com/a/9539592 "Stackoverflow answers").
Haha, no, not at all. I am taking a different approach to the compilation process in my project. It'll be a lot more versatile/extensible/configurable, and hopefully a little cleaner, too. Check out my "manifesto" on the kickstarter page, it's going to be pretty awesome.
```
$ node
> 'toString' in {}
true
```
just use the fresh one returned by click_create_profile_button()
crap, left a `console.log` in here.
Viimeisen kappaleen "limited space" ei aukea sellaiselle lukijalle, joka ei kohdannut ilmoittautumislomakkeen 80 merkin rajaa.
Introducing `skip_refresh` introduces a lot of new code paths that you might not have realized.

Before, an `Entity` object was always in a loaded state after its constructor completed. Now it is possible to create an unloaded entity by using the `skip_refresh` argument. This is similar to the notion of an "entity reference" in the PHP SDK. Ideally there should be new tests for these unloaded entities.
Same i18n issue
Yes. Each plugin takes a config argument. This one only needs the timeout length in seconds.
Hmm. OK, what about using `for` instead, so as to return a lazy sequence of lines? Good compromise?

I prefer that this function return a value because this code is intended to be used as a library as well as a tool. When it’s used as a library, someone might want to transform or “channel” the CSV somewhere other than *out*. I know they could re-bind *out* but that seems a little inconvenient.
`readRegistry` only exists on Windows adding a namespace declaration creates build fail on linux and mac systems.  In this case I think that It is better to use the explicit `utils::readRegistry`.
All I changed with the change log was adding little blurb. Not sure why it's all changed.
No point in making it complex yet but one day the USB driver configuration should check if vsense is defined and use that otherwise fall back to this.
Is that relevant? I see valid points for either way like:
Have the most recent editor first as it is most "important"
or
Have the most recent editor second as you can read it like a history of editors

I think its beyond scope of relevance. "Dont sweat the small stuff"
Look at how all the FSM code in the project is written (e.g. I2C), methods are called on state transitions (in this case changing the active waypoint).

If the planner needs to be called periodically with certain timings it needs to ensure those constraints.  You are implying that the path calculation needs to called repeatedly but without knowing what the requirements of when (or how often) it should be computed this would be a bad design since we abstracted it out of the module.
Does it require it?
These UI string values should be translatable
If I were to add `find(:one, :from....` has_one and has_many are essentially the same thing
Здесь всё ещё беда с indent
Command с двумя m
@shacker can you check the tabs?
All the Console.jsm changed will need a review from someone else.
Nit: set up
i do not value symmetry very highly in that case, because bulk operations are kind of different. my consumer usually has very many different types per bulk, so it is more convenient to easily specify it for the index operation, but i do not really care.

but if symmetry is important for you, what about delete?
public function delete($id=false, array $options = array()) vs
public function delete($id, $type='', $index='') 

imo public delete ($meta=array()) does not make sense but is imo consistent with the signature of index.
Yeah. That's a sensible plan. It's better to have it there.  
I figured you had something better planned, that's why I made it into a separate branch to keep it out. ;-)
and `return True` here.
Shouldn't we have logistic sigmoid in `sklearn.utils.extmath`?
because the default is 10, which is larger than ``n_features``. I should add a comment.
This idea here is to show the learned variance (that's line 63 -- line 67), which pPCA can't dot.. But it is a lot of duplicated code.
Finalement l'héritage marche ?
True, I will push a commit to fix this.
perhaps have a keyword arg which says `dB=False`

and then later have instead of the comment:

```
if dB: 
    data = log10...
...
wrong space indentation. If you follow symfony rules you should indent with 4 spaces.
I dont see validates_confirmation_of :password
I'm not convinced by the logic of this function.

For the first round you only know the record size in a single case (fixed size no child records), and have no idea of the number of duplicates.  I suspect picking a sensible (prime) default would be a better approach - with the option to override it with a hint.

For the second (or subsequent) round you have an upper limit on the number of duplicates (the number of spill files), but you still don't know how those rows will distribute between your buckets.  The most important issue is to ensure that the new number of buckets shares no common factors with the previous number of buckets.  (Or modify the hash function to ensure it is independent).  Again picking another prime (with option to override) might be the simplest and best approach.

Hopefully there would be no need to spill, but a better guess as whether it will might be to compare the spill file size with the estimated memory

Also, the number of buckets shouldn't be a factor of the number of nodes in the system, otherwise a local hash dedup which spills, followed by a global hash dedup would end up being serial since all rows from a single bucket would only go to a subset of the target nodes.
It would be much better if we could move this JavaScript out of the PHP file and into the JS file. I know you need access to WordPress PHP variables to determine the login status. Perhaps look into the trick of using wp_enqueue_script() and wp_localize_script() to pass PHP variables into the JS? It's a little bit hacky, but I imagine it would work and would likely result in cleaner code than this.
Fixed, int works fine, must be silently coerced somewhere.
How is config used?
Sorry, in the perror message
I think that's a possibility.  We've used this pattern elsewhere, so I went with it.

I believe the reply in progress logic was added for multi-window sync.  However, it probably makes more sense to check whether there are any windows loading instead of any replies, since the pageLoading signal is more reliable.  This would probably resolve the other deadlocks as well.
```py
class InvalidSlugError(ValueError):
    pass

raise InvalidSlugError('Spam eggs')
```
you could save the local variable here
Ma byt asi "Prijimacky"
remove message from teh assert
Ah got it, missed the commented out part.

On Sun, Aug 5, 2012 at 2:53 PM, Eugene Fang <
reply@reply.github.com
> wrote:

> >       $(".fancybox").fancybox();
> > +
> > +     // Typeahead for search
> > +     // Currently does a one-time JSON get that returns
> > +     // the entire list of teams and events.
> > +     // Can be optimized.
> > +     $('.search-query').focus(function() {
> > +             $.getJSON('/_/typeahead', function(data) {
> > +                     $('.search-query').typeahead({
> > +                             // Used for when we implement a better
> typeahead solution
> > +                     /*ajax: {
> > +                                 url: '/typeahead',
>
> Yeah, but it's all commented out at the moment anyways. Right now it does
> an ajax call for all the events and teams (about 150KB) once you click on
> the search bar instead of using the first few letters typed to return a
> limited set.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gregmarra/the-blue-alliance/pull/149/files#r1308670
>



-- 
http://grgmrr.com
860.263.9018
Given you're iterating, collect all the futures that result from .get_by_id_async into a list, then call .get_result on each future in the list. You'll do 1 db call instead of N.
please fix the indentation level
Use of strip() and string comparison might be better than bringing the weight of regex.
Not sure if we should reference the login implementation. Possibly just 'Timed out waiting for logging to complete'.
I'm a bit confused. 
You say that Defensive Programming isn't Secure Programming, yet in the link you provide for [secure programming] you link to what seems to be an article about Defensive Programming, not Secure... (perhaps you left out the hash: http://en.wikipedia.org/wiki/Defensive_programming#Secure_programming)
["-","%2d","%2D"][rand(3)] would work too....  I'll get that on a future comit
I kind of think this should be

if n and s

Not a biggie though.
Replace `tform` with updated name.
Descriptions of the workings of different methods needed.
`retryDelay`, `minRetryThreshold`, and `maxRetryThreshold` look like constants. If so, it would be better to express them as closure-locale variables. Once ES6 becomes widely adopted, we can switch them from `var` to `const`.
This needs to be enclosed in the "// CraftBukkit" comments
The old implementation, outline width's default was 1 meaning there was always an outline width. Now the default is an outlinewidth of 0. I'll have to look at the old code, but I think it didn't work as expected originally. like a user would set 5 as the width and 1 as the outlineWidth and the pick would just use 1 as the total width
Just talk to @shunter and he did some jsperf tests that show simply calling normalize every time is probably the best performance.
Sounds like it could get verbose depending on the function name.  I agree that this variable name is probably too generic, and could be renamed, but I'm not sure that we want to enforce a naming scheme for scratch variables project-wide.  In general, we shouldn't be too hard on names for private identifiers; however, I am guilty several times in this pull request, perhaps because I expect to maintain the code.
Remember our discussion when you proposed this style of mixin? The second object of `$.extend` will override the first one if they have the same method/property names.

This was what I wanted to talk to you this morning. This style is the one I came up with minimal modification to the style of other classes. I am happy to see other more elegant solutions.
Seems misnamed. You're dispatching the exception not the handler
If there is an invalid language key, the request will simply return no data. This is checked in line 177 and then it will retry with the next key/value pair.

To my understanding, exceptions are triggered only if something really bad happens. 404s or server not found or whatnot. In that case it would be impolite to retry with the same request.
Now that I'm thinking about it, if we stringified everything (currently we only stringify non-strings), then JSON parsing would work for all cases – removing the need for the empty `catch` and the `finally` clause.

The tradeoff is that we're wrapping strings in an extra pair of double quotes which amounts to 4 wasted bytes of storage per string. 

Thoughts?
You mean [ angle ]. That would be interesting to find out. I just followed what I saw in the exercise examples.
same concern here, wouldn't applying this kill rails2 support? are we fine with that? @jgkite, @rsanheim
Actually, I'm not 100% comfortable on changing the range unit tests. I'll just take your "Reference" tip for now. I'll see about moving them later
Why are you adding these? Within a template, you can simply use the template's name without the `!`. Please remove these.
Well, it's not exactly truly defined if you're guaranteeing anything about debug mode or safety. But regardless, (a) is satisfied with an assertion, which is generally a good idea anyway, but I don't know how we'd sanely require (b). That's not guaranteed to be safe for _arrays_.
Blitting zeros with memset doesn't look right. 
T.init is accessable with `@disable this`.
To which variables? Do you want the `MPICH_IGNORE_CXX_SEEK` preprocessor flag defined as a constant in `toolchains/mpi/mpich2.py`?
That's a fair point, a custom recipe could do that configuration, of course.
whats the syntax for that?
Indentation is off again
For efficiency, I wanted the common case (equivalent types) to be tested first. That means that the two rarer conversion cases are adjusted to then look like the case that's already been handled, so there were two choices: either structure the whole function as a loop (which for most cases didn't really need to iterate), or express it as a recursive calls with a type conversion.  The latter seemed more natural to me at the time, and didn't clutter the function with looping or worry about temporary storage for the converted values being in the right scope levels.

I can rewrite it if you want, it was an arbitrary choice.
Is this name correct? We do not have a proxy here, do we?
I think that the xsi namespace should be added here ... `xmlns:xsi...`
Firmen ohne Adresse wird es nicht geben...
Why do you have set the storePath here? It should already be set to the correct value.
Or better, create a named constant for the value and also use it here.
newline after }
No, good point, removing
Same thing here; this is why I put the advice chain logic after the earl exit for nested components.
Okay, although not all destructive tests write data. :)
my fault, that happens when you work with 2 different pc's...fixed!
This test is testing `add` action
I guess that this is a old method from Zend_Date
Missing the last underscore
When moving these methods into a plugin, can we make them take just a node?  This way we can have a uniform plugin api and pass around a single type of object.
Is there a reason why we don't just send the entire set of arguments through POST, rather then sending the user/key combo as GET params?

(http://docs.sendgrid.com/documentation/api/web-api/mail/ would indicate that they support it)
At first I didn't have it, but I added it after running into an encoding bug @rpicard was running into. I was thinking that the script was reading in utf8 characters from the HTML pages and needed to be handled as utf8 characters -- I wasn't sure, so I added it to see if it would changing anything.
Probably meant to reference ```action``` here.
Since "mvn clean package jboss-as:deploy" is not the only way this will run you may want to explain that it executes in the maven xxx phase, and so any standard build command like package, install, etc... will trigger this.  For example:
the signature for this method should be:

public void purgeUserLocation(UserLocation userLocation);
I'm not sure there is a need to expose `center` due to the nature of CZML, so we weren't planning on it.  We use the `position` and `orientation` properties defined on the CZML object instead and compute the modelMatrix client side from that.  This is the same strategy we use for sensors.  If we can come up with a good use case for exposing `center`, however, I have no objections.
Also I see that the code uses `2012-03-01` specific feature, making the default version `2011-08-18` would introduce empty elements which will look wired for users.
I think in Ruby < 1.9 this check could potentially cause a case where the queue is empty, but the worker thread hasn't arrived at the data submit yet.  Was this an essential part of this fix?
the new auth service is return ing json with quotes instead of booleans. it seemed more robust to make them always strings so that the string match is more exact. without this we were getting transparent dashboards every time we successfully authenticated!
2 space Indentation please
https://github.com/koosha--/jquery-validation/commit/9720e38067c374ed8b6294bf93759df44198b015

On Fri, Oct 19, 2012 at 12:51 AM, Behrooz Shabani
<notifications@github.com>wrote:

> In client/js/jquery.validate.js:
>
> > @@ -273,6 +282,7 @@ $.extend($.validator, {
> >  		digits: "Please enter only digits.",
> >  		creditcard: "Please enter a valid credit card number.",
> >  		equalTo: "Please enter the same value again.",
> > +		regexp: "Please enter a value with a proper pattern.",
>
> I can't find it on upstream version of jquery-validation
> https://github.com/jzaefferer/jquery-validation/blob/master/jquery.validate.js#L285.
> where does it come from? I mean how you get regex support in
> "jquery-validation"?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/XaminProject/agavi-form-models-set/pull/6/files#r1883778>.
>
>



-- 
Koosha
ye space baste
This if statement looks wrong. If the response is not a gradable response, grade_response will never be called.
I would call this just "Indexing interceptors" and qualify what it means in the actual section. 

> Indexing interceptors: to index or not based on entity state

is a little too prose for me and I don't think it reads so well in the table of contents. It does not fit the overall style of titles.
Deletion is rare enough that iterating over the set of all folders to find the folder is pretty reasonable.  And since all folder-sync stuff happens at once, that could be optimized.  (Or a dictionary based on GUIDs could also be populated at startup, etc.)
new_list should not convert to string
or changes will not be exact

```ruby
o.tag_list = "a,b,c"
o.save
o.tag_list = "a,b,c"
o.changes
# {"tag_list"=>["a, b, c", ["a", "b", "c"]]}
```
Can you also add a link to our Composite Layout Spec here?
https://wiki.appcelerator.org/display/guides2/UI+Composite+Layout+Behavior+Spec
No side-effects has be observed during project sheet modifications.
That would make sense, and in fact that was my preferred way...except that if you check the initialization. The Parsing takes place before the validation. So the error showing up was being triggered during the initial parsing ie: processWidgetData() is what get's called at the beginning and was causing the failure. To accomplish this behaviour we would have to refactor a larger portion of this file.
Does the entire <viewport> need to be removed, or just target density dpi?
Yea this would. I believe the motivation behind this was to make sure the sharing screen slides in above the context menu, hence the +10 jump in z-Index (from 100 -> 110). I would imagine we want to keep it this way and maybe adjust the dialog z-index to always be greater?
Tu chyba trzeba rzucić wyjątkiem ArgumentException. W ogóle nie powinno dojść do takiej sytuacji, że dodajemy towar element, który jest już na liście.
Numbering would make things clearer: statement1/comment1, statement2/comment2.
**centimètres** à la place de **cm**