labofsahil/github-event-dataset-2012 huggingface dataset:
should this string be localized?
Sinngemäß In Line 4: X rannte nach hause um die besiegten  Pokemon vor weiteren Schaden zu schützen
Sinngemäß In Line 3: X rannte in das nächstgelegene Pkmncntr um die besiegten  Pokemon vor weiteren Schaden zu schützen
requestDecorator()
this is a useless timestamp ofcourse
Yes, `textContent` is way better :)
Should also check for `\`.
That is, so that when the release manager changes, they can access the previous private keys
it should be in a new line then right?
seems a bit like too much for just avoiding a variable
Well, you can still Check for null, so it's totally valid. This null checking for getter/setters is used throughout the whole framework.
This is a valid use for setExpectedException
This change should have been made upstream.
@pgiraud certainly has an opinion about this. I doubt he just made up this name. But I also agree we should trust @twpayne :-)
@Ocramius hmm could you explain me the use case with var_dumping?
Strange selector name
If this class can be written in Scala, let's move this to StringHelper.
You forgot to add `utile`
This doesn't seem to work for named vectors:

```
d> c(if (F) "a"=1, if (T) "b"=2)
[1] 2
```
why do you need to use reflection to create these?
Make a "struct WaveformEffect" for these.
At first I wanted to do regexp as key, mode as value but it is not possible. 
if we want someday, multiple regexp for one mode (who knows ?)  the only way I saw was list of regexp.
Fair enough, though if a user goes offline, makes some edits then comes online again, its possible that their changes can't be automatically merged.

The other database code doesn't keep any snapshots before the most recent one because historical snapshots can be reconstructed from a log of all the operations anyway.
killed! I think the "lazy" normalization is what people always want (think JS Date object)
I assume this is owned by the library and free'd when the iterator disappears. Can we document it?
Funnily, comments should end with a period like sentences. But carry on ;)
Might be nice to give this some padding and margin at the top and add a `border-top: 1px dotted @borderLightGrey`.
ah, so this is what you meant by not abstracted enough. yes, you're right, i missed this one.
oops, thanks.  fixed.
I'm surprised. Isn't this now a connection string? E.g. `'dbname=postgres'`
Too many spaces after `=`
Indentation problem here, the "url" should go on a nw line
I can verify that this is a tabbing issue.

The main code changes are about a variable renaming as well as some non major logic adjustments (like introducing a variable to eliminate some function calls). If the 4 spaces are turned to tabs as per documentation this would look like good to merge.
How do regions work here? I see no mention of regions in the code... doesn't it just pick the first that something can be extracted from? 

Will this mean that we may get false positives where previously we had none?
the proper type is ``callable``, not ``callback`` (it is even a valid typehint in 5.4)
This is actually fixed in PR #4522, my bad for creating multiple PR, I just found out how to add commits to existing PR.
Is checks below not enough?
The client might not be a browser, but could be any machine requesting data from the server (search engine, another server, etc.). best to stick with a generic "client" terminology alone IMO.
for this service, you should add the tag conditionally in the DI extension according to a configuration, to allow disabling it.

and it should have a negative priority rather that a high priority IMO, so that custom normalizers registered with the default priority can be checked first (the GetSetNormalizer will accept any input)
i'm sure the protocol has something to say about this, right?  probably it's even configurable? :-(
I will be back after consulting with one of my teachers.
I'm pretty sure you can just do `python -m "from config import get_version; print get_version()" instead of having to write it out to a file.
You don't need an apostrophe here.
Yeah. I was tired because It was originally like that :). I'll change that

-- 
Antoine Mercadal


On 13 juin 2012, at 03:51, Alexander Ljungberg<reply@reply.github.com> wrote:

>> +        userAgent=<navigator userAgent>
>> +        description=<user description>
>> +        stackTrace=<the stacktrace>
>> +        version=<version>
>> +        ```
>> +
>> +    Then your server can return a string as HTTP response body. This body will be shown to the user.
>> +
>> +
>> +    You can manage custom behavior in crash handling by setting a delegate
>> +
>> +        [[LPCrashReporter sharedErrorLogger] setDelegate:myObject];
>> +
>> +    And implementing
>> +
>> +        - (void)didCrashReporter:(LPCrashReporter)aCrashReported catchException:(CPDictionary)someInfo
> 
> Wouldn't `crashReporter:didCatchException:` be a more standard name for the delegate method? Most delegate methods start with the sender, like `tableView:didClickTableColumn:`.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/aljungberg/LPKit/pull/1/files#r975038
If I understand correctly, this means that the sessions are stored in memory in each Rails process. So that means I'll need to login (or at least go through the OAuth redirect dance) for every Rails process that I hit whilst using the app? That'll break POST requests - you can't redirect to a POST.

I think we have a default of 4 unicorn slaves, and given that we avoid any single points of failure, that'll be on multiple boxes...

It'll also mean that the sessions won't be in sync across the processes, so if eg my permissions are updated, they'll only be updated in one process (unless I sign in and out until they're all done).

http://guides.rubyonrails.org/caching_with_rails.html#activesupport-cache-memorystore

I know @jystewart has reservations, but I think it might make sense to use MySQL for session storage, unless we can add memcached (or similar) to the stack? It could always be a stop-gap (famous last words).
Before, before, before...  I would prefer 2 fewer of these.
I don't see why the `strncmp` needs to be changes.  Right now, it uses `strlen(fw_key)` as the length of the string to check, but the previous condition guarantees that `strlen(fw_key) < strlen(key)`, we we are good as golden!
Sounds good! I am bit confused on mocks vs ... :(

Sent from my iPhone

On Aug 9, 2012, at 8:58 PM, Duncan McGreggor <notifications@github.com> wrote:

> In akanda/routerapi/tests/test_router_api.py:
> 
> > +LOG = logging.getLogger(__name__)
> > +
> > +
> > +class TestRouterAPI(unittest.TestCase):
> > +
> > +    def setUp(self):
> > +        self.if_mock_patch = mock.patch('akanda.routerapi.drivers.ifconfig.InterfaceManager')
> > +        self.if_mock = self.if_mock_patch.start()
> > +        self.app = flask.Flask('test')
> > +        self.app.register_blueprint(v1.blueprint)
> > +        self.test_app = self.app.test_client()
> > +
> > +    def tearDown(self):
> > +        self.if_mock_patch.stop()
> > +
> > +    def test_root(self):
> Perhaps my celebration was premature ... these aren't really unit tests.
> 
> Let's pair on these tomorrow, and get you fully indoctrinated ;-)
> 
> —
> Reply to this email directly or view it on GitHub.
>
"else False", right? by default, it does not consume the event
3b2db74
Thanks Brian,

Great point about not naming the threads.  I don't really need my own pool, I just need one that can grow bigger than 2*NumberOfCPUCores.  

I'm not sure about favoring a new thread versus sharing a pool of short lived threads.  Seems like the pool should be shared, good catch (I'll make it static final ;)
This double escapes it. `html_tag_open` takes care of escaping.
I defined a general class "table-view" for div table, it defines table-row. Localizable is the thing i missed, thanks.
Even awesomer, once you have @crdlc's `Applications.isDownloading(origin)` you can inline `getDefaultIcon()` and `getDownloadingIcon()` in the `getIcon()` function.

Less public functions, cleaner code, I think the change is definitely worth it :)
I'm fine to do that in a separate PR.
The "-moz-" prefix is removed.
shortDateTimeFormat ?
spelling 'removed'
document.mozL10n is wrong, this should be navigator.mozL10n and the code should move to the platform!
Create something like, SpecialPhrases.getLanguageLocal(osmandSettings) : Locale, or osmandSettings.getSpecialPhrasesLanguage(), this will reduce this duplication and it will made it more readable.
Might as well remove the try catch.
Should use google-guavas ImmutableSet since we don't want it modified
Could you change the name of this? Very easy to confuse it with something that eunit generates, especially in this context :)
this should be lazy if you want to regain the ability to only fail if date is present AND we actually touch dateRange, which is a nice feature.  So, can we add lazy back here?
Could we perhaps rename isApplied with annotationsApplied? Otherwise the two columns together are a bit confusing.
fixed. Same reason as before, taken from Google's SDK.
Count => Calculate
PHPdocs style.
it's a difference when a child class overrides just `Importer.lookup`.
Does 'the menu' sound better?
Yep, agree, but I still don't see a clear way of keeping things separate while having near zero code duplication. This will have to be addressed eventually, but I don't think it needs to be done now (it's about tens or few hundreds of LOCs anyway).
My reasoning is, we want people to convert their code to use epoch (and will enforce this in nine?) so we want to deprecate interfaces where we accept other things.
I am using jshint in my emacs flymake configuration. I was planning to add tests for enforcing  jshint. not sure what you mean by interCaps, but jshint enforce first letter is Captital on object instanciation. e.g:

    a = new MyClass()  # -> good
    a = new myClass()  # -> bad
    
    a = MyFunc()  # -> bad
    a = myFunc()  # -> good
But i think it would be better to use SKIP_DOTS flag.
There is a missing blank line above this one.
Checked that, does a fatal error even of not string-able. Removed it.
There is a CS rule for empty line before return ("Add a blank line before return statements, unless the return is alone inside a statement-group (like an if statement);" -- http://symfony.com/doc/current/contributing/code/standards.html).

This is not the case of this line, but the CS is not respected on other lines of the file...
Sorry, I got it now. The diff context is small, so the other lines that were not changed are not visible in this hunk.
Why do you have it at the same time as hmac module?
Take some statistics here.  The raw values aren't that useful.  Average and Stddev.
Will have a look at this. It doesn't do *everything* that `advanceGallery()` does but will look at the shared properties.
`Front` used to just be the `Seq[Trailblock]`s and the `MetaData` here so just pulling it up to `FrontPage`.
Not that horrible, as long the image always ends with that url fragment, and, more importantly, valid ads never return an image that could match
This should be done in an after block, in case the example fails before we get here!
I don't like naming modules in verbs, seems kind of strange. also install.install / install.disable is strange. Could you follow same convention as we did with loader ? addon/runner addon/installer
We should be able to remove these 3 lines that handle `packages` folder, as we should be able to delete it.
`internals(this).contentWorker.emitSync("click", popupNode, clickedItemData);` ??
In fact it still uses `import` under the hood, module wrapper just exposes it as a `require`. Should I change it to something like:

"Note `require` here in this context is just an alias for `Cu.import` which is used since regular `require` is not available at loader bootstrap."
This should have some tests in resources/static/test/cases/common/js/network.js between lines 601 and 617 to make sure this is operating as expected and somebody else doesn't break those expectations in the future.
Tests work hard, they need sleep too!
Yea, `substitute` is defined just a few lines above. I just want to be sure that I won't be double-escaping.
like it.  fix coming
Would you mind to move the getter down so it comes after the constructor?

Also please make it a real function. Those short declarations are hard to read.
if (null !== $params) {
Replaced with replace_file in 24d0af7
You're right this is a backup file from vim.
Idea: Let's not block on landing crashstorage due to the ugly setUp() code. 
Let's accept this ugliness for now, and once the infrastructure is in place (by Rob) to rely on tables being created before integration tests are run, then we can improve this code. 

After all, the code ran and worked!
I have to test it anyway though I'll pull it down and make the change(s)
Will do. BTW, What is 'globber' ?
Yes, sorry, my fault! Good job! ;-)
why? I have this directory and I don't want to check it in even accidentaly
HACKKKKKKKKK
Should be .push(), oldest todos should be at the top.
moot, just use `String.trim()`
missing a space here ..
controlled by cancan, not in this pull request but in a more recent commit
Use time number helpers instead of these (i.e. 1.day.ago)
`Time.now - 5*60` could be `5.minutes.ago`
add a line of commentary to describe what this patch does
I agree. But the alternative is to copy and paste everything into each file and maintain it everywhere. Should I do that? And if so, should all the sections be copied back into the individual quickstart READMEs (start the server, build and deploy, etc.)?
If this is a note, I don't think it belongs in the list.
I'm really not sure how to create a js function for this; never done it before. Any suggestions or examples to pick from when it concerns buttons and js functions?
whitespace needed in this function
I'm starting to like @davehunt  solution anyway  this method doesn't belong here
Does this need to be a closure?
順番気にしていませんでした・・・
直します
Maybe it's fixed need to check this https://github.com/cowboyd/therubyrhino/issues/19
Not sure how `updated_at` is serialized, so this is risky as is (Memcache doesn't accept spaces in key).
I suggest `build.updated_at.to_i`.
This line was also updated with some of the recent changes in the master branch
You can chain the jQuery calls here:

    $(protractorImg.node)
        .css("cursor", "move")
        .bind("vmousedown", function() {
I need to use this in the search as well to deal with the pmhId search functionality. Therefor, this was the most appropriate place of this functionality

--
Sjoerd Siebinga
Delving B.V., Rotterdam
http://www.delving.eu (http://www.delving.eu/)
skype: sjoerdsiebinga
mobile: +31681926731


On Wednesday, November 7, 2012 at 9:14 AM, Manuel Bernhardt wrote:

> In web-core/app/models/MetadataCache.scala:
> > @@ -30,6 +30,11 @@ case class MetadataItem(modified: Date = new Date(), > systemFields.get(field.tag).getOrElse(new BasicDBList).asInstanceOf[BasicDBList].asScala.map(_.toString).toSeq > } > > + def asPmhId: String = {  
> The MetadataCache is by design meant to be agnostic to whatever it is used for. So this method should be part of the OaiPmhService, not the record itself.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/delving/culture-hub/pull/733/files#r2052597).  
>  
>  
>
use emtpy() instead:

```php
<?php
$userRedirectURI = trim( $http->postVariable( 'RedirectURI', '' ) );
if ( empty( $userRedirectURI ) )
{
    // ...
}
```
See, here there is no line change!
Should be "Date and Time Formats for SQLite".
I still don't follow. As far as I can see the message is the `a` and not the parent `li`. Everything is within the `a`. Do you have an example where this is not the case?
I thinks we can make a partial for both footer layouts to keep it DRY
Please no trailing whitespaces... you can configure your editor/ide to highlight and remove trailing whitespaces. (at least emacs, vim, eclipse, etc..)
You can also use ```make cleanspaces``` which will remove the trailing whitespaces from all *.[ch] files
For better backward compatibility, what do you think of using:

    try:
        # Django 1.4 timzone support
        from django.utils.timezone import now
    except ImportError:
        # Backward compatibility
        from datetime.datetime import now
On second thought, is `canManage` better?
This is not completely accurate actually. I'll change this so it can be merged.
Same thing can be accomplished with
```
  case res: Either[Exception, Value] => res
```
(you'd get an unchecked warning anyway).
It would work fine. But it would mean that if we want to create a `scala-2.9.2` profile, we would have to copy all these properties, instead of only overwriting `scala.version`.
Let's formalize this. Instead of simply doing a .contains, let's use "mobtype:subtype1-subtype2" This way, you can split on dashes. Additionally, make the valid subtypes an enum (a new enum for each subtype class) so we can more easily enforce correct documentation (SubtypeEnum.values(), instead of having to remember to list them all manually).
* Nit: Align.
* While this is correct, shouldn't you divide by ```_stream->codec->time_base.den``` later on, when calculating the frame number?
I like adding a note about the dependencies being attached later.
Sadly, no such guarantee exists. I would prefer the direct access method myself, but once you add a length or non-empty check to go with it, I'm thinking strncmp() is actually the faster approach.
Эмм, это я написал, да? Звиняйте =)
Я бы вам уточнил, что не больше 100 **%**. У вас на вход получается только число.
Возможна ситуация, когда элемент на самом деле не заменится. Например, C на такой же элемент C.
ну даже не это проблема. Многие вызывают метод containsObject: грубо говоря это тот же проход по массиву, ну может примерно раза в 2 меньше итераций прохода.
Вот проблема, двойной смены это да, а еще вероятная "бесконечность" этой операции, при большем числе элементов и мутации 100% это просто будет  схоже с подвисанием. 
Было бы просто интересно ~расчет посмотреть сколько раз алгоритм заходит в while :)

@slebedev  что интересно, сколько людей, столько и реализаций алгоритма и уже казалось бы, ну почти нечем удивить, и все равно удивляешься)) вы довольно много работ просмотрели, не находили рекурсии в реализациях?
Так в любом случае нужна привязка, так как вы передаёте процентный показатель. Опять же, 50% от 200 - 100.
OK, but it should be without the $ everywhere, if you'd like to make it consistent. I was aware that this is in the comments.
oh.. seems like i have misread sth on the coding standards. will fix this immediately.
Good catch, I had just copied over powers.txt and forgot to change the frame sizes. I'll fix that.
I would like to add your library to SMS Background Services for notifications, but first of all I need to know which info I should show in the notification (Name of contact, carrier, number...). So Im gonna ask to UX people and I will add it in a next PR!
Ops. Is it also ok to use the `^(id<RACSubscriber> subscriber)` signature like other methods do?
I think this behavior makes sense to me now, but this is another case where I feel like the documentation isn't telling the full story. It explains _what_ happens, but not why that would ever be useful.
We should verify that `values` is still empty here.
Det er noe med bruken av px-verdier som skurrer litt for meg her. `topPos` kan kanskje settes til `'50%'` for å bli mindre resolusjonsuavhengig, og `leftPos` kan utelates helt (evt settes til en tom streng).
This should suffice:

     if current_user
this try catch won't help when there is an exception in the parser. Please add a "try catch" within the code that handles the parsing.
moved this up here
you should use ``===`` here (we use the strict comparison everywhere, unless ``==`` is really needed)
那么这一段直接删除么
The prior code was very clever. How about using a bunch of private helper methods instead? For example:

    "#{@attachment_name} expected:\n #{allowed_types_failure_message}#{types_message_separators}#{rejected_types_failure_message}"

    ...

    def types_message_separators
      if @alowed_types.present? && @rejected_types.present?
        "\n\n"
      else
        ""
      end
    end
If we follow what scala collections are doing I am happy to have minusHeaders.
What is wrong with it?


On 25 Feb 2012, at 10:20, viktorklang wrote:

>>    */
>> -  def setBodyAs[T](implicit m: Manifest[T]): Message = setBodyAs(m.erasure.asInstanceOf[Class[T]])
>> +  def plusHeaders[A](headers: Map[String, A]): Message = copy(this.body, this.headers ++ headers)
> 
> In this case one could argue that the only thing that's needed is "withHeaders" and then you can do:
> 
> msg.withHeaders(msg.headers ++ newHeaders)
> 
> Because otherwise you'll have to add minusHeaders(), etc etc
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jboner/akka/pull/344/files#r488547
also, why match on the ref if you don't use it?

case msg: EndpointDeActivated => ...
Зачем же его в паблик-секцию-то. Это приватный член.
И звездочка к имени приклеивается, да, а не к типу.
Эмм, разве номер выдается? Вполне себе текст. Или ты о чем?
El formulario era un ejemplo, yo me refiero a la sintaxis que usa para pasar el template, en lugar de encerrarlo en un parámetro.
Que vista de lince!
If I comment out this line, my mentioned bug doesn't exist. I believe this is why I removed this line in my fix back then.
Ok, I'll edit it both :)

2012/5/18 campbeb <
reply@reply.github.com
>

> > @@ -587,10 +588,13 @@
> >    <string name="cache_location">Location</string>
> >    <string name="cache_coordinates">Coordinates</string>
> >    <string name="cache_coordinates_original">Original
> Coordinates</string>
> > +  <string name="cache_coordinates_modified_on_gc_com">Modified on
> GC.com</string>
>
> Geocaching.com here too
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cgeo/c-geo-opensource/pull/1597/files#r845194
>



-- 
Ondøej Kunc
Yeah. Need space after ":".

Regards,
Jishnu
On Aug 13, 2012 9:03 PM, "Vasudev Kamath" <notifications@github.com> wrote:

> In core/jsonrpchandler.py:
>
> > @@ -37,14 +41,15 @@ def translate_result(self, result, error, id_):
> >              result = None
> >
> >          try:
> > -            data = dumps({"result": result, "id":id_, "error":error})
> > -        except :
> > -            error = {"name":"JSONEncodeException", "message": "Result object is not serializable"}
> > -            data = dumps({"result":None, "id": id_, "error": error})
> > +            data = dumps({"result": result, "id": id_, "error": error})
>
> What is the difference? Spaces introduced?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/copyninja/Silpa-Flask/pull/5/files#r1362963>.
>
>
I still think this is prone to misconfiguration. These 3 commands should not be part of the config, but run always.
*Much* better than the previous value...
I mean: the tests do do posting, so it "should work" but worth trying with actual code.
ah, nice to see you did the same I was doing. But I really needed your opinion about it as I was feeling very uncomfortable with it :-)
Yeah, double check the configuration of metadata cache in the constructor :)
this to enable it?
Pretty sure this has been fixed by another PR in a different place (```ns``` became ```bins```). Will look for the PR #.
A nice example, but doesn't illustrate the principal change which is to support calls like the following: `ax.plot_trisurf(triangulation, z)`
There is a danger that new users will simply modify this code without understanding the sublety of the triangulation occurring in parameter space so that the triangulation cannot be used directly in the `plot_trisurf` function call.  How about producing 2 plots in this example, this being the second one and the first a simpler one such as a 3d version of the first `tripcolor` example?  This will also demonstrate that masked triangulations are rendered correctly.
I also think the plot looks better if you use `ax.plot_trisurf( ...  , cmap=plt.cm.jet)`
@verbit made a comment on this line on the commit 8bd1d57d5c563c1e65a2f2eeb41e68b47953d541. @verbit : Would you mind re-iterating your comments here?

Thanks
Adding strings.
My comments above wrt multiple calls to hist() goes here.
Would it not make more sense to raise an exception immediately if subplot args are not integer values (though perhaps not necessarily integer dtypes)?  I don't see how a value like 5.5 can be anything but a programming error.
for backwards compatibility, would it make sense to add that as a kwarg with a sensible default?
missing line break in comment?
This looks like a lot of code duplication :(
I will probably merge this but give a go at un-duplicating the common parts.
Hey, this is strange to me -- why would it produce a nested vector?
`dateutil` is a new dependency that I didn't even have installed on my system. Can you tell me a little about this? Was it necessary? Is it faster than it's alternatives?
@nicolaasmatthijs Can we cache this & `$('body')` above the `$.each`?
Shouldn't be initialized yet as it's in a template now.
`"` -> `'`
Esta fixture é super útil, será usada na montagem do `Book acquisition feed`
The above "for" loop looks like a candidate for a utility function :)
Added two more lines. Let me know if you want more. ;)
Can we parenthesize this?  (X - Y - Z is a confusing construct).
This is fine -- if the application actually passes in "source=", that's arguably an error, but we might as well just make it work.
Changed in a818f8cb31c91e0df8d0157937ac40379b516efa.
should the default names be handled by a method overload?
Is it possible to add a ``@param`` annotation for parameter ``$directory`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
Are you sure the method ``get`` can be called on ``$this->container`` (of type ``null|object<Symfony\Comp...ion\ContainerInterface>``)?
Are you sure ``$kernel->getRootDir()`` has the correct type as ``*`` is not a sub-type of ``string``?
That doesn't seem right, where does that information come from?
Is this change really needed? This affects all platforms.

It seems to me that the original value should be fine, it's just a timeout
It would be an API change since at the moment, coef_path_ is being fit.
To what? Help what is going on?
nit: I would just use the predefined "Action" for this. Unlike Dart you rarely need to define your own delegate type in C# nowadays with all the Action/Func variants...
TODO: Também devemos fazer verificação se o startDate não é posterior ao endDate.
For foodcritic tests, we need to copy the necessary files into a temporary directory so they will run on Travis (since you need to run it on the folder)
я просто делал так, не все выводятся.
забыл убрать после эксперимента.
I think we should move all of this, except `debugger` I guess, into the gemspec. For platform specific stuff it makes sense in be here, but I think it's generally best practice to put gem dependencies in the gemspec.
*Active* -> *Online*
*Login*
`user.email = email or None`

Not really possible otherwise, but still, it is important that it is always `None` and not empty string.
Yes, or manage.py doesnt find dommand
Ignore this one.
Change this structure to:

```
{
    'type': 'userlist',
    'action': 'JOIN',
    'user': {
        'username': user.username,
        'profile_url': urlresolvers.reverse('user', kwargs={'username': user.username}),
        'image': '',
    }
}
Ah, some empty lines would be so great. :-) And spaces after `()`.
Or `input[type="checkbox"]:disabled`?
Also use it like that. So that after `connections` list becomes empty, you do not mark user as offline unless some time has gone since `connection_last_unsubscribe`.
s/HOMEBREW_PREFIX/prefix/, but this can just be passed to `make`, i.e.

```ruby
system "make", "PREFIX=#{prefix}", "install"
```
No longer support for checking notifications for test mode? By default this method will return `false` from the superclass
You can use an event and use events.ScheduleEvent here, instead of a raw timer.
mhm, I have trained you well young padawan
The return type should be the `#pikachu{}` record.
Yes, it could also be done with `object_repository` - users would have to write their own factory/closure to return the repository, which is why I didn't put it in first off.

It's a simple change if you want to say a solid 'yes'. I'm indifferent myself.
Should be $filterBy.
What's an Arcanist comment?
Here is another comment
Done in f5fa849
yes because when we will add commands to add/remove sockets dynamically, this function will be dynamic
As you wish. As mentioned, these was minor stuff.
"embed detail flag" instead of "embed detail value";
`window.tag_manager`.
But that's what we typically use extend for, no? For what else would we have extend then?
The name `logger_service` is a bit confusing here, i think. A service is basically a dynamically created scope interface of one of the existing services, like e.g. ResourceManager, exposed as `window.services["resource-manager"]`. Is it really that?
It is the same I commented on line 944. Here, we identify the problematic situation with high gravity before it happens, which saves player's time - (s)he immediately knows (s)he won't be able to land.
No, unless I missed something obvious.  The filtering parameter is simply a `CFDictionaryRef` with key/value pairs.  I don't think it can express the logic "or" in L122.
We should escape filter too

```ruby
/\A#{Regexp.escape(filter)}\(\di\)\z/
```
Added Authors section in b1cdccc32e338b5073665c2c3676e41ccea0dbfd.
Right, I updated tailoring resources. I'll also create an issue for converting resources to symbols usage, so it's easier to see what we have in our plans.
This hash should look nicer as a constant, don't you think?
Can you move style into individual css file? then add new css file into project.
This logic needs to be pulled up.
This API is too permissive.  We just want clients to read, yes?  Expose (at most) an ImmutableMap
Added a couple of lines here (and added the 32-bit clause in the comments paragraph above) with some more info about this weird behaviour in numpy.
Small edit pushed, please edit/revert as desired.
get_or_create() might save you a few lines of code, but I wouldn't change it now.  Just pointing it out for future reference.
In the remote case, resize and kelvination work fine. Local resize works, but I'm having some weird behavior for local kelvination with this branch, and I'm not sure whether it's this change or not. It would be good to put our heads together on it.
OK. Thanks for clarification!

I've asked wim where this issue appeared...
at some point should be a Function and call apply here
I love `this.mgmt = checkNotNull(mgmt, "managementContext")`, so that if you later see an NPE you can quickly track down where it was caused by and where it was not caused by,
Very strange. I think the consequences of commenting this out though is that jclouds will default to using four (ish) hard-coded ami owners, so if you ask for an image that is owned by someone else then it won't find it.
since 1.3.0 ? :)
Play 스토어가 맞습니다. 미국 캐리어로 들어갔을 때 Google Play라면 그렇게 가는게 낫겠네요. 그럼 다른 앱에서도 Google Play라 다시 변경하겠습니다.
E se eu disparar um request contendo ítens no attributo ``action`` que não fazem parte das coleções onde eu tenho permissão de agir sobre os registros? Devemos adicionar algumas verificações de autorização antes de efetuar as ações.
The keys are now used only for queries as GET parameters. They are not in the response and do not scale with the number of returned points.

On 24. 09. 12, at 03:00, Mitar <notifications@github.com> wrote:

> So
Sounds like a good idea. Kept the original for consistency, but happy
to improve.

Sent from my iPhone

On Feb 20, 2012, at 1:25 PM, Jonas Nicklas
<reply@reply.github.com>
wrote:

>>     def rows_hash
>> -      return @rows_hash if @rows_hash
>> -      verify_table_width(2)
>> -      @rows_hash = self.class.new(raw.transpose).hashes[0]
>> +      raise %{The table must have exactly #{width} columns} unless width == 2
>
> Arg, nitpicking, I know, but can we have this raise a more specific error? I don't like RuntimeErrors.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jnicklas/turnip/pull/38/files#r468438
This is a comment on your removed comment.  Fix this and make it BETTER.
Is `top_groups` updated in schema.sql?
Dave:  In general I agree with all your comments.  In this particular case, though, I know a bit of the history about that commented out line.  The reason for it being commented out is that Regina needs to re-implement that feature.  In a perfect world your suggestion is spot on perfect, but in this case we either need to wait for a few weeks to get that seldom used feature included, or submit 90% of the completed work and come back to finish of the last 10% as time permits.

Thanks for reviewing and commenting on these issues.

I'm going to merge, because I've been waiting for this patch set since January!
This has not been defined yet
Сложная логика. Подозреваю, что комбинацией ключей можно будет заставить изменить mode == ERR на корректный.
The contents of `behat.yml.dist` aren't supposed to provide a template for new projects, at this point, they are geared towards testing the Drupal Extension itself.
you should add the login step here
Single line comments should use <code>#</code> also s/sandboc/sandbox/
<code># logging in to paypal sandbox</code>
I'll push some of this logic to the JS side of things. Putting lots of stuff in the templates just makes it easier when make generic Views but it's also not hard to make a base class and keep the template more about presentation. Good call.
Need Info: Why are you putting the html in the model? Can't it go in the template? It feels a little strange to me that it's here.
We may want to clone base_clf to keep the original object unchanged. Other than that, looks good :)
haha I believe so :)
why  not `n_samples`?
Thanks for the insight. I'm at work now so just a short reply. Will think about your post more later.

To the "wisely choosen API": I think the original ``fit_pairwise`` attribute was going in this direction. But that didn't seem to work, as you then need ``predict_pairwise``, ``fit_predict_pairwise``, ``decision_function_pairwise``, ``predict_proba_pairwise``, ``predict_log_proba_pairwise`` and that seemed to clutter the API to much.

I'm not sure separating the classes would be good. Do you want two WARD classes? Would that make things more clear?
Also, internally we still need the attribute: cross validation needs to know how to process the training data.
Please add a link to the face completion example here.
Yes, you are right. We need to improve this part.
Now we only support MADlib. If R, MAHOUT are used here, program will exit with error message.
I don't like this much... this creates dependency on the MapActivity.
This could be probably changed to similar behaviour like other events, onSingleTapUp, to first travers the layers
and if nobody handles it, than do some default action.
Don't do this. connect() needs to be async
Can't set byte order (see https://github.com/Macadamian/titanium_mobile/pull/125/files#r1315466 ). Same with some of the others.
Can you confirm that the jira issue has been updated with the information above?
The above comment point to an issue that we used to have and that is likely the reason the project name was used in the first place.  Is that not an issue anymore?
Put a TODO saying that we need to throw exceptions as specified in the docs. Same for close()
Can you refactor this to use a service instead? Suggesting people to use `EntityManager` in controllers is not really the coolest thing :)
different versions of Maven need different checks :-/
>CSlaveActivity &inputAct = * (CSlaveActivity *)input->queryFromActivity();

this line was redundant, queryTotalCycles implementations perform equivalent.
This is remarkably similar to the code above, not sure they can be commoned up, though.
This should be implemented (as a separate pull request)
The `is_null` is no longer needed. And neither is the `if (!$userAgent)` below.
Correct, I see that. I need to make sure of that.
I like this.  And I like that it's general to Category.  I feel like this should be a part of Control.Category or even Prelude.  But I also feel like there's quite a few things missing from Prelude.  I was going to write my own Prelude2 of things I commonly use.  I wonder if we could get another little project going there.
Ah ok makes sense now, yeah that seems to work fine.
Do we have other projects from Mozilla on travis? Could we even create a mozilla wide account?
This should still be "function", not "methodname" ("funcname" was obviously wrong).
If it's just these 3 parameters, then maybe we should validate them?
ça fait plusieurs fois que je vois cette div passer. Il n'y a pas moyen de faire un snippet?
Gotcha, thx for the explanation. Merging now.
i'd like to use the `paginate` keyword here: `RequestConfig(self.request, paginate=self.get_table_pagination()).configure(table)`
It should probably warn/fail if `poll_sleep_amount` is greater than the `lock_timeout`. Otherwise, you'll probably get processes bouncing back and forth between each other, which is not really the desired behavior (even if there are no side effects).
what is the reason that we are updating the header here?
@makrohn For equipping, a `powers->activate` line could probably be added to the part of MenuInventory you linked. But I'm not sure yet how to go about removing passive effects when unequipping. Possibly when changing equipment, remove all effects that are marked as passive and are not in the powers_list.
Acutally, the Select(...) method returns IEnumerable, therefore the return type (lowest possible type) should be IEnumerable.
I just noticed that the function is not referenced anywhere. Can it be deleted?
Can this be random? 0xbadc0ded is cute and all but it's an instant IPS/AV signature.
Might allow for an option to specify which payload you want.
I finally painfully setup another.... it appears this is a prob.  I've only used up no more than 50% of ram, 1% CPU usage during exploitation, yet the mof file just sits there.
Maybe add a comment explaining why this is necessary.
used in subsequent commit. I renamed it to dtype, and it sets the dtype of the return value
This is _not_ `-aggregator`. Aggregator POMs are a bit flawed concept (POM that is not a parent actually), so to clear up things this has to be `-parent` rather.
Same comment as above.  I also would only assign to `boundingVolume` once, and not assign the initial `undefined`.
I fixed it, simply because you never know how long "temporary" code will last :)
Good point, and I agree.  We do this in DynamicObjectCollection as well.  The memory trade off is well worth it.
These should be under the changes for b11.
I think there were cmdlets that needed this not to happen. Are we fixing those ? example.. import i believe
Good question. Looks like this can be safely removed as dead code.
I'll do that for 'username', but for 'service' that if statement also checks for unsupported protocol. So if you enter a random service name that we don't support, processProtocol would return -2.
Okay, I reviewed all Titanium controls/views and didn't find any that would draw outside of its bounds.
Any custom controls can draw outside, but if so, they could also set clipsToBounds=NO.
So I'm willing to accept this PR.
Is there any particular reason you are using a composite layout with manually calculated tops, vs just using a vertical layout?
that's a syntax error, don't as me why.
nit: One advantage to using the `\color{}` syntax and putting everything in a single `<code>` tag is that MathJax will automatically space everything nicely.  Notice here how the operators seem a bit crowded:

![Imgur](http://i.imgur.com/4UbeM.png)

If you rewrote it like this, it would get formatted a little more nicely:

    <p><code>\color{<var>PINK</var>}{5\%} \times \$<var>BILL_FORMAT</var> = \color{purple}{\$<var>TIP_TEN_PERCENT</var>} \div 2 = \color{<var>PINK</var>}{\$<var>TIP_FIVE_PERCENT</var>}</code>.</p>`


Note that for some colors you have to do this since they're custom colors we've defined:

    \color{<var>PINK</var>}{ ... }
    \color{<var>BLUE</var>}{ ... }
    \color{<var>GREEN</var>}{ ... }
    \color{<var>ORANGE</var>}{ ... }

But for others that are built into MathJax you can just do this:

    \color{purple}{ ... }

(I'm thinking about a better/easier way to do this)
With current compiler, we cannot use `$` in slice expression...
return _a + i < _b;
The test was useless, since narrow strings don't have length anyways. If anything, this was problematic, since non-narrow dstrings are perfectly length-able
You haven't written a comment saying that these methods must be called from only one thread at a time, which means you're permitting concurrent access to `jwTokenFactory`.

If the token factory is thread-safe, make it a singleton and have these be static methods.

If it's not, you need to `synchronize` these methods, at which point you should consider stuffing more state into the object if it makes sense.
This is clearly correct and should be merged ASAP, but it's hard to say that it will fix Bug 755576.
all those objects don't need to be known publicly. They could just be
local; I just think it might be a better place.

On Mon, Oct 8, 2012 at 9:49 AM, Felix Mayerhuber
<notifications@github.com>wrote:

> In
> components/ekb/common/src/main/java/org/openengsb/core/ekb/common/EDBConverterUtils.java:
>
> > @@ -30,6 +39,7 @@
> >   */
> >  public final class EDBConverterUtils {
> >      public static final String FILEWRAPPER_FILENAME_SUFFIX = ".filename";
> > +    public static final String REFERENCE_PREFIX = "refersTo_";
> >
> >      private EDBConverterUtils() {
>
> Because the OpenEngSBForeignKey is an annotation and there are no methods
> for annotations AFAIK. And filterEngineeringObjectInformation is something
> only model related, in fact only Engineering Object related, which is
> placed in the EKB because of that. You can built up a solution where you
> use EDBObjects and never ever need this functionality.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/776/files#r1782433>.
>
>
well you could always have made another commit to your branch deleting that line, when you wrote this. now it's too late, it's merged...IDK why @ofTheo merged it though, with this in, he probably overlooked it.
Check for WMV, then MPEGTSAC3; if it's neither of those, use the default profile: MPEGPSAC3. There's nothing wrong with validating the value, but, if needed, it should be done in RendererConfiguration, not  here.
Provide access to the current User object so User.isAdmin() is accessible.
Cool. Some of this (including the CMS one) isn't actually used anywhere yet. What do we do about things that don't really have a context...?
Can you please conditionally add the message, rather than remove it later on? We've got an `insertBefore` param on `addFieldToTab()` for that.
Just doing this now and then will push.
We're going to want to loop over this and encode each record individually, otherwise you can't use `IncludeEncoder`, `ExcludeEncoder`, etc. Matt Robenolt just added in some great additions to the encoder stuff that will help speed up things in the serialization process.
How about low_freq and high_freq instead of fp1 and fp2? It is more explicit
``UserResponseEvent`` allows to access the user and the response (after the response has been created in the controller). ``GetResponseUserEvent`` allows to access the user and to set the response in the listener instead of letting the controller generate it (allowing to use a different redirection url for instance)
Should be invariant ?
Because PHP is such a weakly typed programming language, enforcing a live instance can prevent typos in the class name passed for validation. This helps to make the validation logic more robust and less error prone.
trailing coma should be removed
Looks good. Keep in mind that even an empty RequiredFields() instance is changing bevahiour, as its the only way that FormField->validate() is actually called on the server. Which is not good API design, but alas...
use a space on each side of the `+=`
```ruby
if not dump_header and not verbose
```

don't use bang (!) when you can use `not` - reads better.
Please remove it altogether
IMO we should introduce some `MongoDbMessageHandlerFactoryBean` and configure `MongoTemplate` there and inject it here. 
Let's share the responsibility!
I agree we need *something* in the documentation here (we should consider documenting XSD attributes, even if very concise, a requirement).

One thing that might be worth clarifying is that the hash* serializers are only relevant when using a hash as the collection type.
Fine. Closing this one for now then.
Anyway, if you got time/will we can discuss tomorrow evening (now that I think of it, I won't be here this evening) about some internals rewrite. The problem is trying not to de-stabilize the API too much. The last two weeks have already been chaos for end users :)
I have no idea what happened here... some sort of weird git anomaly?
I would assume every ZF user knows this url. Perhaps it should be made a little more specific?
s/\. With/, with a/

Current verbiage is not grammatically correct.
Are these metadata values for ostype, tested, and  cfengine_version supposed to be valid cfengine classes?
Which ones are required? 

Should there be a comma between the name and email address?

I ask because I am thinking ahead to what the not yet finished tooling is going to want to expect and it would be nice to have a tool that could be used to validate a submission
So it's there for future purposes?
I removed it for now
if you try to Response(data=data,headers={Location': {url} } this will raise an error 
because of  {'Location': URL } [ : ]

if you want to keep this line, i dont understand the headers kwarg. Because its limited to be a list. And used just in One Test. 

If I'm wrong please correct me.
Let's change this to `self.failed = self.errors = 0` as I believe that was my original intention.
I want to try the code you have, not a select. i think the code you have will be fine.

yes - add class to each option
no -differnet classes for each option, each option will call a different function (the exact import funciton, not the guess import function)
_isParameterConstrained_ !?
Nope, only need it for head, since it has a different directory structure.  :-)  I tested install with -HEAD and -devel and both work.
> it can return the element itself

Just like `querySelector` and `querySelectorAll`. Therefore why not go for `Element.prototype.querySelectorUp( selector )` and `Element.prototype.querySelectorAllUp( selector )` ?
removed in bf6a4e25fa7c95fd61b13a2541697eaead9eb225.
ммм. смысл этой переменной и этой логики? статистика должна всегда считаться
Yep, what I was thinking is that if a next possible file was above the first ones content folder then we would get into trouble?
@aslakknutsen , @mojavelinux I've incorporated this particular feedback in a different way, seeing that we're referring to test enricher enhancement which is done by the individual archive appenders in the enricher projects. So, the text no longer states that container adapter enhances the deployment.

We still have the ToC and the conclusion to fix.

And to hijack this thread for discussion (instead of discussing it in the messy pull request), all other changes are incorporated in the original pull request against arquillian.github.com: https://github.com/arquillian/arquillian.github.com/pull/71 .  The specific changeset with the modifications is: https://github.com/VineetReynolds/arquillian.github.com/commit/4397795dc14df2adc158b2c33d30695adef15ee4

All changes have been rebased against develop to make merging against develop easier. But again, I must warn that rebasing has messed the history of that pull request, since the upstream branch for merging is "issue-70" and not "develop".