labofsahil/github-event-dataset-2012 huggingface dataset:
I would argue that we should change that in `core.py` before it is too late. 95 % of all derived classes will probably not notice because the empty lines will be removed later on anyway. And even if we break something, we break astropy 0.1, which is not officially publicly released and is probably used by 1-2 dozen python-savy developers, who will quickly contact you (or me if they see this discussion) if things fail.
On the other hand, if the do not change the `core.py` now then we publicly release a package with two Inputter classes where the one contradicts the documentation of the other making it harder for anyone who will later read to code to understand what going one.
Should we use a ``Quantity`` - like API for these conversions? I.e. ``Distance.to(u.Mpc)``. Then all the separate methods aren't needed.
This would be fixed by implementing `__radd__`, `__rsub__`, and so on.
I wrote a RPCTypeCheck(object,...) method for the raw transactions API that would save you a few lines of code and should give slightly nicer error messages.

Would be:
RPCTypeCheck(o, boost::assign::map_list_of("txid", str_type)("vout", int_type));
Of course - you always want to check whether the created block is valid.
Don't you want to transtate `dpis` here as well?
While you're at it,  it's now continually tested on Linux, Apple OSX, Illumos, FreeBSD, and OpenBSD
should it be 

```php
0 == $method->getNumberOfParameters()
```
?
nice so this is PSR-0?
Yeah, I don't have a good picture of what you want to do on the level up. That said, populating the names here is completely self-contained, doesn't require any additional calls, which is why I think it does make sense down here.
Couldn't we use $className here instead of hardcoded 'lucky' value? It might be considered an information leak, but otoh, having the same typeof for what is in fact different types complicates things for the create.js configuration (e.g. there's this mechanism where you can configure it to use a specific editor configuration per type, and with the hardcoded "lucky" value, you can effectively only have one for all)
Agreed.  Reverting.
If `system.file` is inserted into the namespace of each package loaded with `load_all` (or into the imports environment for the package), then if anything in the package's namespace calls `system.file`, it'll get the substitute version.  But if `system.file` is called from any of the base packages, it'll be the original version.
F4 was already Save State.  I don't really mind if it changes but you've got two VK_F4's.

-[Unknown]
That's the problem of whatever it's wrapped around - e.g. if I do

```
a = LazyEvaluate(int)
unicode(a)
```

That's equivalent to doing `unicode(int())`. It's up to whatever the function returns to provide a useful `__unicode__` method.
But wait , it has to be str, not bytes

Sent from my iPad

On May 31, 2012, at 8:08 AM, Fernando Perez<reply@reply.github.com> wrote:

>> +
>> +        The contents of the cell are written to a `.pyx` file in the
>> +        directory `IPYTHONDIR/cython` using a filename with the hash of the code.
>> +        This file is then cythonized and compiled. The resulting module
>> +        is imported and all of its symbols are injected into the user's
>> +        namespace. The usage is similar to that of `%%cython_pyximport` but
>> +        you don't have to pass a module name::
>> +
>> +        %%cython
>> +        def f(x):
>> +            return 2.0*x
>> +        """
>> +        args = parse_argstring(self.cython, line)
>> +        code = cell if cell.endswith('\n') else cell+'\n'
>> +        # distutils.Extension cannot handle sources that a unicode
>> +        lib_dir=str(os.path.join(self.shell.ipython_dir,'cython'))
> 
> @takluyver, thanks!  We actually looked at the py3compat utilities, but since we don't know them too well, we didn't quite pick the right approach.  Why don't you just go ahead and apply this fix straight up into master?  Things like that are OK in my mind to do post-review without needing the overhead of a full-blown PR, they're just minor polish that would have happened during review with a bit more time.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1770/files#r908331
There's a `skip_if_not_win32` decorator we could use.
@tanoku Fixed this. Hope you don't mind separate asserts instead of all in one. It just seemed easier to read to me.
But you probably want to set `idx->have_stream` to 0 here, right?
Stop dupping the `strlen`, just stick it in a variable.
We already ran with something like this for a while, and we ended up dropping it in favor of `realpath`; this doesn't work for existing paths, but as it turns out, the logic behind resolving relative paths has too many corner cases to be implemented locally.

What's stopping us from using `realpath` in submodules this time?
This failed a compile test (at least with VS compiler). Since you are not including `animation.h`, it can't call the destructor.
So what contains 'frame.persisted['screenshotPath']' or frame.persisted or frame itself in the saveScreenshot method?
nit: no need to capitalize `FIRST`.
Are we not using commas as a separator in the UI? Or is that generating a middleware URL? Or am I missing something?
Requiring ``plone.app.testing`` while enabling **Use virtualenv** in ReadTheDocs will cause warnings / errors and extra load while executing RTD-builds. That's why.
You can use `count_all_results()` instead of `num_rows()` here, it's more performanct and respects the like() criteria.
Same as above: protected static
should be `Returns ...`
amend please
Fixed. 

But, is this rule documented somewhere?
There are other places where short syntax is used https://gist.github.com/4352487.

Does this means that cast is done with:
```php
(integer) $var;
```
as well?

Again, there are many short syntax casts in rest of the code.
the ``static`` keyword should be placed before the visibility
Although this is documented as "have we started the progress bar?", it's only ever used for subtracting from `time()`. Renaming it to `$startTime` makes sense, as does changing the doc block. I don't think there's anything in the code that requires a boolean to infer whether the progress bar has started.

Leaving the default value as `null` also makes sense, as zero could imply the epoch timestamp.
Why putting a getter for the logger ? This class is not meant to provide a way to access the logger for others. It does not make sense to have this getter
yeah, I think the safer way is to keep the caching for scalars only (the caching for arrays is simply useless as escaping an array is wrong: casting it to a string throws a notice as of PHP 5.4)
Would this be problematic if we recurse too deeply as above?
@huxuan 我在这儿加入这一section，你怎么看？
This is no longer necessary, right?
This blows up because "e" doesn't exist.
Do we need all these usings?
Please, remove this model
Cool.
Thanks. I added a new test (see below) with a different testing strategy with the assert you suggested.
I overlooked the context var
this initialized the save and sync status bars
I have added the code to use a module instead a jar file.
I think this actually needs to be smarter than the existing implementation. If the widget is disabled or cancelSearch is set, then we shouldn't announce anything.
Generally you don't want console.log in tests except for debugging (which I expect is why this is here).
Again if you plan to define all the vars at once, you can save bytes by removing the 'var' per line
Clave is correct anyway :)
oh, I didn't think about reboot in the middle of FTU use case. Then it might read the saved wifi if connected on the first launch. But it should respond to 'onstatuschange' anyway, since we pass through the different states ['scanning', 'associated', 'connected']. Frankly, no idea why is ignoring it in that build. I'm still unable to reproduce it
I pushed a new revision that does that for both named and `_blank` windows.
Oh, this means that it should be part of a `teardown` function (in the parent scope) which is called after each test rather than the `suiteTeardown` function (called after the suite)
OK --- worth understanding what's not working.  File gaia issue please.  Some of it may be intentionally same-process.
Running `postError()` I got

    Error: this.mm[msg.id] is undefined
    Source File: resource://gre/modules/ActivitiesService.jsm
    Line: 285

But I will kept the button anyway.
Use the new `compositekey` handling for this character.
`-runapp` works, but [Using the B2G desktop client](https://developer.mozilla.org/en-US/docs/Mozilla/Boot_to_Gecko/Using_the_B2G_desktop_client) documents `--runapp` (two hyphens), which also works and seems like the Unix convention these days for multi-character options, so I would use that instead.
I thought it fixed some problems during launch that I had, but after testing I couldn't actually reproduce them. I'll remove it.
In this case the URL is [guaranteed to redirect][downloads-url]. We have to build the S3 URL on the fly, and for private repos, it has expiring tokens in it. We want Octokit to handle the ultimate resolution of that URL and pass that off to whatever process is downloading the archive and not require them to in turn handle redirects. Make sense?

[downloads-url]: http://developer.github.com/v3/repos/contents/#get-archive-link
You should use normal array notation - `['', null, undefined]` otherwise LGTM, +1.
your right, whoops!
Is this looping over an array?  IIRC, the decision was to not use for...in loops for arrays.
Operation types should be an object literal/enum/something that is not magical.
Wouldn´t `swipeStartX` or `swipeStartPosition` more clear?
I'd forgotten about java's MessageDigest. We could also use SHA512. It'll be a performance hit but probably not really worth worrying about. I'll make that change on the weekend.
Comment what this is doing.
Also the 's' should be outside parens: Interpolate("%(prop:JAVACs")
I have in mind that if you don't pass an object for params, you should get back a jsonrpc -32602, not -32603 (internal error) which is what the ValueError exception will become.
Turns out we can also accomplish it with PHP, I lean towards the bash solution though...

    #!/usr/bin/env php
    <?php
    
    // Only process Composer if composer.json exists.
    if (file_exists('composer.json')) {
        // Make sure Composer is available.
        if (!file_exists('composer.phar')) {
            $composer = file_get_contents('http://getcomposer.org/composer.phar');
            file_put_contents('composer.phar', $composer);
        }
    
        if (include('phar://composer.phar/vendor/.composer/autoload.php')) {
            $_SERVER['argv'] = array('composer.phar', 'install');
            $app = new Composer\Console\Application();
            $app->run();
        }
    }
Just out of curiosity, why do you need that?
We've added a new font (for better or worse) with a heavier weight than the bold one.  It's defined as 800 in the font-face rule.
Do you mean have the call to uname separate and then assign the result 
to the returned list?
Or put this call into a dedicated function to be used elsewhere?

On 20/06/2012 03:41, hadley wickham wrote:
>>     if (!is.null(out$`authors@r`)) {
>> -    out$authors<- eval(parse(text = out$`authors@r`))
>> +    authors<- eval(parse(text = out$`authors@r`))
>> +	format(authors)
>> +  }else if (!is.null(out$author)) {
>> +	str_trim(str_split(out$author, ",")[[1]])
>> +  }
>> +  if( !is.null(authors) ){
>> +	  m<- str_match(authors, "([^<]+)\\s*(<([^>]+)>)?")
>> +	  authors<- str_c(m[,2], ifelse( m[,4] != '', str_c('(', cloak_email(m[,4]), ')'), ''))
>> +	  out$authors<- list(author=unname(apply(cbind(name=authors), 1, as.list)))
> The whole `unname(...)` probably should be its own function
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/24/files#r1015023
Whoops, should this be

```ruby
FileUtils.cp_r "#{TMP_OCTO}/.themes/classic", "#{Dir.pwd}/.themes"
```
I was unsure about the standard in Ruby? I actually do `spool = options[:spool].nil? ? true : options[:spool]` in `send_message`
an elements
Well if we don't specify `api-utils/loader` it won't be stripped out. If don't specify `chrome` cfx will complain when it sees `Components`.
Yes, I really like this generic approach.
+1 on addition of comments like this
why all the extra space around it? it's a builtin
CamelCase instead of underscore variable name.
Don't add indentation before opening phpTags, or else the generated code will be messy.
The `.conf` version should also live down in upsteart - though the `.sh` extension is reasonable to add in the base provider, I think.
Same as the comment on agent.rb. Should change this to use `Puppet.warning`.
Let's link to the BlockingRouter section of topics/router.
if not self.data['show_date']:
I update pull request. And spec about "should not raise and exception" can be good: https://github.com/LTe/rubinius/commit/a16eeac790527589e862b03d0aab95ae927137b3#L0R272 :)
Is ArrayAccess imported? If not, make sure you add an import statement to this classfile.
@weierophinney You also want the requested name before. Especially in the Di case. Because the service requested name is canonicalized. Which means, that in the case of class names, that backslashes are removed. Thus, if the Di doesn't have any aliases setup for the canonicalized name, it cannot resolve the canonicalized name. Thus, you definitely need the requested name in this scenario.

@Ocramius I'll update the PR to also include the ServiceLocatorInterface for the canCreateServiceWithName.
Typo - "Resposne"  = Response
Wait, i will propose you a use case :)
`con i moduli` -> `a sviluppare moduli`
Please document that kind of changes in the commit comment and PR description, will be useful for people looking for the old name.
Was genau ist dein Problem?
forgot about that. It was conflicting with the sendmail recipe on my test box.    Let's just back on my change here and go back to installing postfix.
we are a team :)
Please fix code formatting here. Thanks.
`return window.location.hash.replace('#/', '') || 'all';`
It's a naming convention and open to question.  I find it easier to distinguish between things that KO should interpret as bindings and those that are namespaces if I use quotes.
yeah. Or saying: "refer to the install section for installing pelican" is maybe enough?
Just decided to follow convention, like 'slug'. Unfortunately use None returns the string "None" for the author
ah, I just assumed you were okay with it since you're using `$.each`
Apparently, the following can be done easily:

~~~~
from paycheck import orange, with_checker


# snip
    @with_checker(range(1,30), irange(1,12), irange(1970, 2038))
    def test_date_parser(self, d, m, y):
        testdate = datetime.date(y, m, d)  # ?
        self.assertEqual(date_parser("%s-%s-%s" % (y,m,d)) , testdate)
~~~~
if you want to use examples in your docstrings, please adhere to the doctest format
http://docs.python.org/library/doctest.html
No, it was probably dragged through versions of the original archetype. Removed.
This is new. src is being passed into error exceptions now, in order to build the source context lines in the message where the ASCII art arrow appears
Yeah, I used the object in the config specifically because this line made me cringe. I really wanted to just say user.attributes.email in adminUsers (you know, like python) but was foiled.
The extra vertical space after each if/elseif is not needed.  Please remove in all three blocks below.
CoverageCraft is completely deprecated now and will be removed soon.
I think we want to encode < and > like in the previous examples, just to be on the safe side.
This line is just condensing the logic from 2 lines into 1 line.
Add howitzer. Also we need to review other gems, may be we need to move it to howitzer instead, for instance sexy_settings, or capybara
this apparently isn't even used, so I took it out.
Because at that point there is no ip, and the foreman database should reflect reality, if possible.  Since the instance is down, there are no facts to update foreman with, so a forced update was required.
I ran tests ok earlier under 1.9 without the pinning, using mocha 0.13.1 and minitest 4.3.3.
I guess the thing that is confusing me here is that we're pushing and unshifting callback functions onto the resources array. I'm not sure how / when we would combine the resources into a single compiled string that could then be passed to template. If you can point me at the right technique I'll take a stab at it.
This logic is a little hard to follow. What's going on here? Does the server send back multiple responses?

Also is this saying `invoices` may be an array of arrays? `invoices.first.length`?
does this sort of construct work for ajax?
What is qtip?
Will do -- I can't see colors on my Windows command-line so I hope *you* enjoy it ;)
Check the code style, use brackets for the if statement
Any advice on how to add it back? (Github won't let me edit from here)
Use feature branches...
на это я могу сказать только, что любую вещь можно сделать через одно место :)
Can you be more specific?  Do you mean line 136?
it's in a pull i haven't submitted yet that implements Base.wait_for_page_to_load().
i unfortunately didn't separate the code from the code in my hover_menu branch.
Same here.  Seems like we're only testing a subset of what this endpoint should now be providing.
Perhaps auto-tagging could be removed as we don't have tagging yet, although tagging is planned to be added.
It seems we accept "1" and "0" as well as true and false, the docs should be updated.

Also, I don't think we should just return the value as-is, I feel we should be throwing an exception if `value` is not an acceptable input here.
Would be good to add a test for the empty package, as it sometimes turns out to be a source of bugs :-)
Will this keep stop after exhaustively trying all the services, or keep looping? (just need clarification, no fixes)
i wonder if we should not extend RequestMatcherInterface for simplicity sake. if the matcher only cares about the pathinfo, he can get it from the request. would simplify things a bit and have less options to confuse.
We will do like this from now :)
Nieuw level?
krijg een undifined error. ben er bezig mee om de oplossing te zoeken.
"Создайте имплементацию (реализацию) метода mutate. Метод должен заменить X процентов символов в массиве DNA в случайном порядке; Х – значение переданной переменной типа int. Нужно заменить строго Х процентов, то есть заменять одну ячейку можно максимум один раз." - я пока не умею читать мысли, извините :) Но где в этом тексте написано, что А не может меняться на А? Здесь только сказано, что ячейка может меняться максимум один раз. Собственно это и реализовано.
Я понял о чем вы, просто я не увидел в ТЗ явной указки, что в mutate нужно передать именно процент, а не кол-во элементов.Если укажете в ТЗ четкое на это указание, переделаю. 
Если бы вы посмотрели мой код в main.m, то у вас не было вопросов по моей реализации. 
int distance1 = [cell2 hammingDistance:cell1];
 NSLog(@"HAMMING DISTANCE1 %d",distance1);
 [cell1 mutate:distance1];
 [cell2 mutate:distance1];
изящнее было бы в этом месте выбирать случайный индекс из массива с предопределёнными значениями ATGC.
В обсуждении проекта есть рекомендация выносить объявление и реализацию категории в отдельные файлы
Не согласен с необходимостью дополнительной проверки. Нужно делать именно то, что просят. Сам с собой очень много времени боролся по этому поводу.
Проверять нужно только вводимые пользователем данные (0 < процент мутации <= 100)
will it work in the raw in preloaded in a memmap file?
what is prop_unused???
typo: relevant
I don't find `#<<` and `#tap` to be more clear than string interpolation, and I say this as someone who loves `#tap` and is lukewarm for string interpolation.

Basically I look at this diff and I see a giant block of code. My proposal would improve that, but I'm open to hearing others.
Uncool to do blocking here, just return a Future[ActorRef]
Ja, este había sido yo en https://github.com/CommonJobs/CommonJobs/commit/8cf9de6f14824a341e6a88cc8b111addc5926f2c por hacer cambios y no probarlos.

Muchas gracias
Fixed in: c21af97
Note: using `upper` helps keep your DB queries database-agnostic... but to use Postgres indexes, I you could:

```
.where("title ILIKE ? or characters.name ILIKE ?", "%#{query}%", "%#{query}%").uniq
```
please do not rename gettext strings, please rever it to "Fichier uploade, en attente"
Oh, no: code was added by me just to use as a generator, but the fact is it didn't worked, so i commented it just to try again later. It never worked as a generator, but it should do.
Will merge and modify myself...
To be consistent with other strings, this should say `Geocaching.com`
Also, 'this' should be 'waypoint' so user knows exactly what is being uploaded.
Same like in LocalStorage ... btw. thanks for helping with that.
I'm assuming there isn't some edge case with `Double` where `e < s` and `ceiling (s - e) == 0`.
Shoud use java.io.tmpdir system property.
Why partition?
ah sorry :)
No need to move it, I think it fits better here (in the code) as it's referring to the queue instance, and strongly related to the implementation anyway.
Seems reasonable. Would be nice to document the args clearly at this point (for devs rather than users).
Line width is probably longer than 80 chars. Please wrap the line.
so, you replaced simple example with one that is slightly longer and has a couple extra oddities (i.e., "1.0+0.1")?
What I have not figured out is why it did not work the way it was; it would seem that check_gc already stores rgbFace in gc._fillcolor, and that gc.filp() checks that for None.  So it seems odd to need this extra block of code here.  It might be worth putting in a comment to explain it.
Micro-optimization: the part on the right is a bit quicker and perhaps more readable as 
tuple(np.round(np.asarray(rgb[:3]) * 255)).
you can remove `os_name` and `os_folder` from here seeing as they are all the same and then hardcode them into the test.

We'll refactor the parametrize part later if we need to test over other OS too.
If it's not necessary we can remove it
You can use `frequency_indicator.text` here as the text property returns the innerHTML excluding any text that is not visible to the user.
That's fine. I was more making a side comment on this that this is something to consider at some point. Probably should file a gaia issue.
This statement is a real doozy. I suggest breaking it up to make it clearer what you're doing. 

'd also add in a comment somewhere mentioning that `nameMap` corresponds short canonical forms to date methods.
со своими бранчами можно делать что хочешь, github почти всегда подцепляет
What sort of array?

```
array('Content-Type: text/html');
array('Content-Type' => 'text/html');
array('Content-Type' => array('text/html'));
```
Spacing here and 2 above
need to try that - I guess blackburn would be excited too

On Wed, 2012-05-09 at 01:45 -0700, Chiyuan Zhang wrote:
> > @@ -45,6 +45,7 @@ configure.log
> >  /src/interfaces/r/Makefile
> >  /src/interfaces/r_modular/Makefile
> >  /src/examples
> > +/src/shogun/.clang_complete
> 
> It's the config file for a vim plugin clang_complete. I added it to .gitignore to ignore it from git status. If you don't like it, I can remove this.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/shogun-toolbox/shogun/pull/509/files#r793833
>
On Thu, Nov 29, 2012 at 5:55 PM, Michael Cahill <notifications@github.com>wrote:

> This is fine -- if the application actually passes in "source=", that's
> arguably an error, but we might as well just make it work.


This is what I get if I dump a table, though.  For example, if I run
examples/c/ex_call_center, then do:

% wt dump file:customers_main.wt
WiredTiger Dump (WiredTiger Version 1.3.8)
Format=print
Header
file:customers_main.wt
allocation_size=512B,block_compressor=,cache_resident=0,checksum=on,colgroups=,collator=,columns=(name,phone),dictionary=0,exclusive=0,format=btree,huffman_key=,huffman_value=,internal_item_max=0,internal_key_truncate=,internal_page_max=2KB,key_format=r,key_gap=10,leaf_item_max=0,leaf_page_max=1MB,lsm_bloom=,lsm_bloom_bit_count=8,lsm_bloom_config=,lsm_bloom_hash_count=4,lsm_bloom_newest=0,lsm_bloom_oldest=0,lsm_chunk_size=2MB,lsm_merge_max=15,lsm_merge_threads=1,prefix_compression=,
source=,split_pct=75,type=file,value_format=SS
Data
1
Professor Oak\00123-456-7890\00
2
Lorelei\00098-765-4321\00


Notice the "source=" value.   Maybe it's an artifact of dump, I could look,
but I doubt it.

--keith

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Keith Bostic
keith.bostic@wiredtiger.com
This actually needs to replace / with _, see extension manager line 111.
Agreed. The problem is that most of the time what you want to do is operate ON the indexes, not create or delete them - those are rather uncommon use cases as far as I can see (you don't need to create an index to start using it, you only need to use the create method if you want to do custom config).
I'm pretty sure this is already done in autobahn.js before the subscription callback is made to us.
Repeating "declare" in this sentence is repetitive. Maybe something like:

> If you define an **options** hash when declaring your view...
Accept header should work as well here. Either `Accept: text/plain+diff` or using the `.diff` extension should work equally well. We don't only use `Accept` because there's no way to link to a content negotiated resource.
I get what you are saying, and that method has been suggested to me as well, and I certainly use it and deliberately ignore to fit the occasion.  The tests here were so trivial it's not worth breaking them up.  Whatever the case, the test case is valid in it's own right anyway (assert an initial condition; do some incremental work; assert; do final work; assert).  If the initial set is not empty, no point in proceeding.  The second assertion is more or less redundant.
renamed + fix small bug fix + PR merge
Removing unused files is generally not considered the job of a django app, which is why the ImageField doesn't delete its image when its instance is deleted. Since having those extra files doesn't cause any problems for the app, there's no pressing need to remove them. Even if there were, it isn't data or schema, so a South migration wouldn't really be the place to do it.
Terminology. A local variable that takes an input value for a function is a "parameter" and an actual value is an "argument". (However I suspect some developers may not bother with this distinction.)

Therefore the class name `ModularInputKindParameter` would be my preference.

Do the REST API docs use the term "argument" already?
I had to increase this value to get the script to work. One offending module that exceeded the 1500 number was Plack-Middleware-RequestHeaders
Still changes all around the file.
Maybe split this into two/multiple blocks (each paragraph into one).
No, it is still not right. You should not hard-code final URL in. Then you have not done anything. :-)
Why relative position here?
Chenged.
It looks like this was being explicitly tested and expecting the previous behaviour, was that an oversight or do we depend on it behaving this way somewhere? Bringing @ssoroka into the loop in case he knows anything about this.
Whole-sale disabling of pylint messages for a module like this is bad practice. I do agree, however, that pylint's complaining about "* and ** magic" (`W0142`) is annoying. I propose we use a custom `pylint.rc` file to remedy this situation.
this is kind of confusing isn't it?
The problem is that `contact` isn't guaranteed to exist. It's not set when we create the document.
This could probably be simplified to:
current_total += sum((get_active_hours(entry) for entry in my_active_entries))

However, if only one active entry is allowed at one time, this could probably be simplified to just adding the currently open time if there is one, to the weekly total
shoudln't
I bow to Raghu's wisdom :)
Not your code I believe, but we don't usually have whitespace before the first and after the last value in an object literal.
Pretty crazy style, `(` should go on the same line, why indent `register_shortcut_listener`?
Reason is: the less choice is left to the compiler, the less stupid decisions it can make. And compilers sometimes do!
This change is minor for sure - I won't be offended if rejected! :)
We always use the user data that's why it returned an empty string for this item. currentIndex() always returns the user data (which is the path with the "/" separator that qt uses internally.)
Why not calling this method `c_step`? I think that only users that read Rousseeuw and Van Driessen's paper would browse that code and they would probably look for the c_step method as a starting point to understand it. At least, this is what I did ;)
given the not really informative names j, y, star, ..., (without the book at hand), a basic summary of the names used in the class would be very helpful. Could be added to the docstring as notes for what's going on.
Yes, this PR includes that commit - otherwise it wouldn't work ...
Let's bump it right before we put it up on npm
Trailing `/`.
Should the afterReturningBuilder be also changed to RegistryResponseTypeHolderBuilder.class?
Recommend eliminating this method (it's only called at line 141).  Move store.connect() into the try block of getInbox().  Removes the duplicated exception code.
I think this person forgot what the tab button is meant for
Какое-то смешение стилей.
В некоторых местах лямбда функции написано в одну строчку.
В других в несколько.
Надо выработать какое-то правило и ему придерживаться.
All this is, as ever, only my opinion.  Everyone please feel free to tell me to shut up! :)
No problem.  I'll handle it, so you can just check that you're ok with my changes in the morning.
Here, for example, 4-6 and 6-9 are missing
If it is provided.
This should be `User`.
did you remove the '\' on purpose?
Hmm. This means when `tools == null`, there is no matching state, so it'll use the default, which looks effectively identical to this state (excluding transitions). Does that work the same as before (is it meant to be visible)? In particular, will there be an animation if you change tools from null to non-null while otherwise visible?
if this was the assertion you needed, please use

    Pet.find('Pierre').weight.must_be_close_to 4.4.pounds.to.kilograms
I hope this doesn't disrupt the normal npm install which also build the native modules, right?
Should be `server = api_image.get('server', {})`.
Path planners should not be called from a callback. As a general rule, callbacks should be kept as short and sweet as practical. There are easy ways to move this function out of the callback and into the main while(1).
You know what I'm going to say....
Don't need this function any more because of inheritance.
The cookbooks could be in a [separate YAML file](https://gist.github.com/3826861)

With it, instead of `cookbooks = [ lots of lines ]` we'll have `cookbooks = YAML.load_file("cookbooks.yml")` or so, and we don't need to edit the `Rakefile` to modify the cookbook set.
Переменные со строчной буквы.
Ошибки надо в System.err выводить
А зачем ты предыдущий тест удалил? Эти два теста тестируют разные строки кода.
Если передаётся несколько файлов - то закрывается только самый последний.
стэк трейс сдвинется (см tabExceptionTest)
@shacker Can you make `cc-alert` conditional?
manage_status.py:14:1: E302 expected 2 blank lines, found 1
please also normalize the white-space in this class. (oops, the other files too). we typically use 4 space tabs rather than 2 or 8.
so, i only see you using get_text_from_location in one place, and you do not appear to be checking for False before proceeding.
options include a) check for false wherever you use it, b) return an empty string instead, c) do not create specialized function
datetime.now() this could be generated in https://github.com/mozilla/marketplace-tests/blob/master/tests/base_test.py

I'm sure we will use it in some other place
typo `element`
again, this doesn't seem to be used.
Why are you copying an array that you just constructed?
not sure if it is any better.
I'd rather not do an enumerate loop here.  The same can be accomplished without iteration:

    flag = (dist == 0)
    dist[flag] = 1
    retval = 1. / dist
    retval[flag] = np.inf

I believe this would be much faster, especially when the arrays are large.
accumulate or pool sounds better to me
Oh great, I'll use that then.
and rho ?
> > +        _, _det = np.linalg.slogdet(inv_cov_x)

> can you test the fast_logdet from utils.extmath ?

Indeed, we cannot use slogdet, as it is present only in recent numpy
versions.
There's a doctest example in the docstring. I'd have to make up data as well as features for this to work, and the result isn't very well-inspectable anyway...
I intentionally left out a label for two reasons:

1. I firmly believe we should only provide the basic functionality and leave the presentation up the the end user.
2. It removes any handlebars dependency. Ember controls should work with any templating solution.
PLEASE NO!
@fzaninotto Thank you for spotting this. I should remember that I need to use CS, accepted for that project, despite of my company's standard.
Ah well I thought there was only 1 csf mask/subject since it came from the mprage. But I'm wrong! If we feed getmask >1 mean functional images we get >1 reg files and >1 masks! Will change now.
Thanks David for the information.

So long as the user doesn't need to reference assets in the path to resources then that's all good.  In fact judging from the doc you referenced the user should never need to reference the resources folder.  We may need to implement that but that is likely outside the scope of this patch.
Can you still give the answer as to should it or should it not be absolute?  To be addressed in a later patch is fine, but doesn't help passing the knowledge around.
Sure, that renaming sounds good.
You can do this in one call (spaces and other characters are allowed in strftime)

```ruby
self.end_time.strftime("%l:%M %p")
```
Code in motion... don't pay too much attention to details as I'm still testing...
The number of references to owner indicates most of this function should probably be implemented there.
If the queue is invalid, there's no queue to flush. This doesn't look like an exceptional error to me... I'd just return.
This is a case where I think you might be better off with a switch statement with a case for each type, since the output is essentially per-type.
why not loop read until there's nothing to read? Then you just need a small buffer...
scope creep. file it for a later fix.
I don't like it. It's too broad. What you're "expecting" is a `KeyError` on the `data['totals'][...]` getter but this might accidentally swallow nasty `KeyError`s in `append_row_blob()`.

In fact, there are 3 places where `KeyError`s could happen. 

1. `data['totals'][...]`
2. `platform['code']`
3. `append_row_blob(blob, totals_labels)`
Let's invert this and remove the else.
Maybe managing rubygems should be a separate class? On systems which don't have totally ancient versions updating to bleeding-edge isn't necessary and is probably not the ideal behavior.
The indentation looks weird here compared to the rest of lines.  I expect you'll want to reinvent this method.
Most of our classes are prefixed by sagecell_ so that we don't pollute the host webpage's CSS namespace.  Can we make the poweredBy class sagecell_poweredBy instead?
nm, was reading the diff wrong.
Oh yes there is a bug. Some of the cmd need not be freed because they are not allocated. We should only free the allocated cmd. Originally the allocated cmds are of regular pattern, but now after we add more options it's kind of a mess. We might want to consider free them manually one by one. If you are not sure how to do that, leave it to me and I can fix it later.
@yuhunglin All transforms and merges will be back-end if possible. We're doing a straight read of the json. Please stick to array.
Let's see if this command runs :)
`(== (- x2 x1) (- y2 y1))` palauttaa ittessään booleanin.
i think you can now remove this as you create a new handler for each request, right?
Again, resp may return nil, and you're not catching that.
Ok, but... This should be code templated from a pull request that was just merged. I'll double check I modified the right version.

On 20 Nov 2012, at 23:16, Brandon Perry <notifications@github.com> wrote:

> In modules/auxiliary/scanner/sap/sap_soap_rfc_dbmcli_sxpg_command_exec.rb:
> 
> > +					else
> > +						temp = output[i].gsub("&#62",">")
> > +						temp_ = temp.gsub("&#34","\"")
> > +						temp__ = temp_.gsub("&#39","'")
> > +						result << temp__ + "\n"
> > +					end
> > +				end
> > +				saptbl = Msf::Ui::Console::Table.new(
> > +					Msf::Ui::Console::Table::Style::Default,
> > +					'Header'  => "[SAP] SXPG_COMMAND_EXEC dbmcli Command Injection",
> > +					'Prefix'  => "\n",
> > +					'Postfix' => "\n",
> > +					'Indent'  => 1,
> > +					'Columns' =>["Output"]
> > +					)
> > +				for i in 0..result.length/2-1
> 0.upto(result.length/2-1) do |i|
> 
> —
> Reply to this email directly or view it on GitHub.
>
You're using spaces instead of tabs.  Looks like your editor is using 8-space tabs.
Is this an IP address or a netmask? Maybe put a comment explaining what's going on more.
I think ``out = img_as_float(...)`` may be enough, but you should double-check (I'm not very familiar with this function).
What about:

```ruby
def item_outside_array
  @array.detect do |item|
    if @array.include?(item.next)
      item.next
    end
   end
end
```
On 22/02/2012, at 3:02 AM, Pete Muir wrote:

>> 
>> -        $JBOSS_HOME/bin/standalone.sh
>> +   This will compile and package the EJB JAR and client interfaces JAR
>> +   (`jboss-as-ejb-remote-app.jar` and `jboss-as-ejb-remote-app-client.jar`) and copy them to 
>> +   `~.m2/repository/org/jboss/as/quickstarts/jboss-as-ejb-remote-server-side/7.0.2-SNAPSHOT/`.
> 
> I would probably avoid this discussion of copying, I had to read it three times, as I thought it was something I had to do…

Yes, that is confusing to read.  I can update to "This will build the EJB and client interfaces JARs, and install them in your local Maven repository."

Should I do that and send another pull request?  

Also I merged my working branch into master before I pushed last time.  I should have pushed the branch and sent the pull request from it?


> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/113/files#r472037
We actually want to render here rather than using redirect because it lets us hold on to the form data and display any validation errors.
man alan header ro bara hame gozashtam
yani ba parent address dehi kardam
aya bardaram ya na?
Is `instanceof ` fast?  Or should we have an explicit property for this?  Other commands, e.g., post-processing effects, will also not have a bounding volume.  Right now, overlays also don't have bounding volumes, but they are handled outside of the frustums; this won't be possible for all post-processing effects.
I did a grep and found a similar mistake in DynamicBillboardVisualizer.  Want to fix that too?
Interesting... We don't have to use glow though. You can use other style to indicate the chassis is selected
Can we have a RouteDescriptor without a path? Maybe this setPath is not needed here.
That was my plan, but I was not able to find a way to get that to work. 
The JSP page would have to be accessible from the web application that is using aerogear-controller. But the error JSP page in question would be in the aerogear-controller.jar inside of the lib directory.  That was the reason for using a template error page that is currently being served from a servlet in aerogear-controller.  Do you know away round this or a better solution?
I'm fine with it in this case because of the iPhone class's name.  I love it when our names match up across platforms (when I need to dig through our iPhone code to see how they do something ... it's a big help.)
The comment looks good, but can we put this in a block comment? Something like:

/**
 * IMPORTANT NOTE
 *
*/
indentation here is fucked up
Hey @sergiogonzalez ,

Wouldn't be better to add this method to the Category Service instead of creating this helper method? This seems like the simplest method possible for creating a category which seems to be useful for everybody using the API.
Use empty lines to group the variables. This makes it easier to read.
I'm not 100% sure, but I think you might technically need a `require => Class['postgresql::version']` here in order to make sure that everything gets done in the right order.  Which is the reason I'm interested in exploring to see if there's a way that I can move your `version` bit from being a separate class to being a parameter that you pass to `postgresql::server`.
epsilon, 2 pi - epsilon.
It's not length but somehow it seems illogical to me. Anyway I agreee with Jonathan.
y u no implement insertAfter?
I think there should be a customary `break` here at the end of a `switch` label.
Well I've been speaking English all my live, and I don't know that I've ever noticed cannot written before. Looks very strange to me.
I'll go with can't, cannot makes me uncomfortable ;)
ça ressemble à la mauvaise solution à un problème de path.
Comment se fait-il que ça fonctionnait jusqu'à maintenant ? Quel est le contexte ?
So this will crash whenever coffee script is not installed?
This needs to stay the same. Add an "update_date" instead.
Is there an advantage to nested prefs?  I'd much rather just a JSON object.
This should be placed in a JS file rather than existing inline.
same as with get_file
Can we change this to a Text also?
Same comment as my previous comment.
public function createCsv($name, $data){
    $fp = fopen($name . ".csv", 'w');
    foreach ($data as $row) {
       fputcsv($fp, $row);
    }    
    fclose($fp);
}
Animating the UI without a small timeout doesn't work. It looks like the validation styles haven't been applied yet when animating and a very small timeout solves this issue.
Can we use single quotes here?
Can you change `.click` to `.on` above?
I'd rather not. Even though it saves a couple of lines, it becomes a lot harder to read.
since it is commented out - should it be removed?
This module is not even used in the tests, you'll notice the tests still pass if you remove it :) This is because you are adding the :enum option which is calling `classy_enum_attr` directly on the model.

```ruby
field :breed, type: Breed, :enum => {:allow_blank => true}
```
is equivalent to

```ruby
field :breed, type: String, :enum => {:allow_blank => true}
```

You can get it to use the module if you just do:

```ruby
field :breed, type: Breed
```

The problem I have with that is then you break the expected behavior because the owner back reference no longer works without the enum option. This inconsistency isn't something I want in the gem, so I would prefer not to support it.
Nie podoba mi się, że tworzone są tutaj obiekty TradeGood. Powinny być wyciągane ze statycznej metody, która jest w klasie TradeGood.
ext-curl
Documented the assumption.
is this really the right thing to do?
snort-compat/ will need to be created by our package if it doesn't exist already
Yes, we can do this (have the non-pretty-printed version also avoid sorting the keys). I wasn't sure whether we wanted keys sorted all the time or not, I kind of assumed we did because I didn't see anything proving that we did indeed want them non-sorted in the "compact representation".

For that, we would need a 2nd mapper in JsonUtils: one that is created with the regular MapSerializer.

The "regular" map serializer is almost 4 times faster than the "sorting" one I introduced here - it's blazing fast! :)
this commented chunk should go in a constructor
You are calling concat and ToArray (which are very slow operations) and then calling Parse on the string you just created.  Why now just create the correct cartographics in the if statement.  This will be cleaner and faster; while speed may not be an issue for offline conversions, when we move to network links, speed will be an important factor.  Also we should be using if/else instead of two ifs here, no need for the second if if they first if hits.
How much based?
The version extracted should be as close as possible as the version we expect later on as final version. In the final Version any appendix like "-alpha-123", "RC-2", "MS-5" are not expected to appear later on. From that point of view the current strategy seems to be OK.

e.g.

2.4.6-alpha-123 => 2.4.6 and not 2.4.6.123
I'm sorry, I now see that this part slipped in for me in the commit and is unconnected to porting to ARC, but I think this is a better default because you want to be able to record as well.
-> "or ~~if~~ there is a cyclic dependency."
I included your original snippet, it looks simple to understand IMHO.
s/Ouput/Output
BAI PARENS!
relevant_phrase should be plural as this returns an ActiveRecord::Collection => relevant_phrases

Then, for relevant_phrase_text you don't check if relevant_phrases.first is null or not.  In case it equals nil, nil.text will raise an error.
this will not work if the smoothing value is 0. check the fsl.preprocess workflow
Dropping in a comment here just to show it is possible.

**WOW** it is!

* List
  * item 1
  * item *n*
I don't really have anything to say here. I just really like the phrase, "return the native looper," which sounds like an ecological manifesto.

When I hear native looper, this is what I think of: http://www.padil.gov.au/maf-border/Pest/Main/141464
Here and below: I'm not sure what's meant by "this is done via the main thread".  The blocking is done on the main thread?  Or the call to this is made while on the main thread?
since; values need to be quoted: 

since:  "2.0.0"
Yes, actually this was a bug cause that same code path should still run for backupType == none , so I've already removed it locally.
Ah yes of course, Limit the include scope as appose to exclude everything you don't want. Not sure where my head was last night. ;)

Tests to prove the feature would be nice.
We need to agree on this style stuff, I had broken this line purposely to keep it shorter (as with the other change I saw earlier)
Yes, and it doesn't even work
OK, but we talk about that by deleting status should be comments also displayed.
Why do you use `clone()` and than `html()`.
`clone()` clones current HTML DOM element
`html()` return you the content HTML of current DOM element
I understand what you meant. It's not being used. Won't introduce it until it's really neded.
I don't think this is really the right way here.  I'll come back to it.
oh did you try what i put in the readme?  `sudo pip install -U pyyaml nltk`
I have a commit coming to fix this
enforce logic: does user have permission to connect activity to id
because there is no way to do a findBy() without a class name. and the current code was totally broken as it was using an undefined variable ``$id``
How to keep the compatibility with old version?
OK, I'll add the complementary `MIPS32`.

The `X86` approach is equally flawed. One third of the `version =` statements in druntime join X86_64 and X86. Keeping the current approach doesn't scale, think of this [module](https://github.com/D-Programming-Language/druntime/blob/master/src/core/sys/osx/mach/port.d) with 10 more architectures.

We also need orthogonal subsets rather than specialized sets (`MIPS_N32_SoftFP`) because nesting version blocks performs an intersection where the latter requires a join.
added as #226