labofsahil/github-event-dataset-2012 huggingface dataset:
@WouterJ this is the recommendation in the "contributing page": *The :: shorthand is preferred over .. code-block:: php to begin a PHP code block;*

http://symfony.com/doc/master/contributing/documentation/overview.html
What about using `jsonlint` as the link text instead of `lint`?
why toList?
I will think about it; I have also to put examples in the docstring.
Las imágenes que se usa para los botones están preparadas para 300px, creo que habría que modificar las imágenes o modificar este valor. Dado que los botones de login ya no van a estar creo que no es tan grave que ocupe 300px.

![200px](https://trello-attachments.s3.amazonaws.com/4fc295f15637b3ca0f262d77/4f6dbd7b075b78a220cb439a/dIYSG9oEyoSaEqAJMbmMZRlxxVsx/width200px.jpg "200px")

![300px](https://trello-attachments.s3.amazonaws.com/4fc295f15637b3ca0f262d77/4f6dbd7b075b78a220cb439a/KrRGjHnlEIkcA7jWW8Y4CRAFgGQx/width300px.jpg "300px")
does this fail on none-osx systems? This gem should work on *unix and even windows systems
I just re-used the `Importer` module. Thinking of it - there should probably be a STL module to contain the PATH constants.

How is the structure planned? We have one project that contains an importer and exporter. The exporter currently is in global space - while the importer is under `CommunityExtensions::STLImporter`.

Should it be:

```ruby
module CommunityExtensions
  module STL

    # Shared code here...
    PATH = '...'

    class Importer
    end

    module Exporter
    end

  end
end
```

?
I wouldn't have thought to use concat, quite interesting!
typo here `index.php`
Do you confirm @ygresil  ?
When you use same patterns over and over, please refactor
These lines probably need escaping and some `--`'s, just in case...
That won't quite do the trick, consider this script:

```js
var client = require('ar-drone').createClient();
client.takeoff();
```

Since `takeoff` is executed before any navdata messages can be received, this will never execute.

Also: I think this should emit an `'error'` event rather than throwing. (`'error'` events will throw implicitly if there is no listener in node)
@vblagoje I agree, you have a point. Let's discuss on IRC :)
Will javadoc those members so synchronization needs become clearer. It is essential that transferBySource and transferBySegment are kept in sync, so I chose to synchronize on *this* when accessing them. Then topologyId and isTopologyUpdate (and even rCh and wCh - I realised now) should be updated together atomically and the update should also wait until updates to transferBySource and transferBySegment from another thread that entered onTopologyUpdate() are complete, hence the lock is common: this. I know you feel the lock granularity seems coarse. ReadWriteLock to the rescue! :) Will ping you when the new version is ready. Thanks!
Um... "Future enhancements"?
I wonder why this comment was left in...
You are right to raise the issue.  I'll go with the first option of sharing the `j_unique` array.
So exactly what happens in this flow if we never find a match for the ssid given?
What is the advantage in this? A file containing a class/interface doesn't produce any output nor execute any logic anyway, except for the case when the PHP interpreter is not available.
Good spot. I remember this was a response to forcing something to work which was being ambiguously handled, but it definitely needs to be cleaned up.
noted.  I'll think about the balance between explaining the algorithm in the docs and keeping it short.  this is a good candidate for a change.
oh, unpack-neighbors etc? these are schema functions. I'm sure they're already in there and these have been duplicated.
should be [:timestamp][0..7], think this is backwards
@gsilver Here, above and beneath, can you convert it to the styleguide?

e.g. above I see double spaces

```css
,  #d9e9f1 0%
```

color should be

```css
color: #fff;
```

And sometimes there are 2 spaces after a colon: `:`

```css
padding:  10px;
```
Thanks. My apologies - I have no idea how I missed that.
character encoding clash
Thanks. I have not thought about modular interfaces yet.
Why are we doing this with CSS instead of JS? I understand that CSS "can do this" but it's a bitch to debug CSS transitions, whereas it's really easy to debug a jQuery transition. We're not doing framerate critical animation here, so I don't see the benefit of using what is basically a hack-turned-spec for this >_> (you may notice I hate the idea of doing animation in what is supposed to be styling information, not behaviour information...)
I feel like the name `hasBug_` is a little too generic. There are many bugs that browsers might have relating to web fonts. Can we call this property `hasWebkitFallbackBug_` and the associated method `checkWebkitFallbackBug` so that we keep the way we refer to the bug in code consistent? (All of these long names get renamed by the compiler anyway.)
Apidoc, inheritdoc, see or something for the IDEs.
Ok, now I understand what you mean.
Let's keep the original design.
Anyway, this PR is useful to see how to traverse the filter chain.
I used to think so as well, but if I understand things correctly, the AS3 compiler goes through the function and "pulls out" all local variable declarations. I don't think it actually "moves them to the beginning" of the function, I think it just treats variable declarations differently (and separately) than other statements (i.e. the "executable" kind).

This is why you have access to a variable even on the lines before you define it.

I did a quick test and got no more than +/-10 ms difference (which swings both ways) between the results for 2,000,000 iterations, which is statistically insignificant to me.
https://gist.github.com/3822331
Initialisiere den Array Parameter mit new Beer[beerList.size()]
Sonst werden 2 Arrays erzeugt. Das mit der länge 0 braucht es nicht.
Better minification? Can you explain how?
Should be able to just use `function(resp) {`.

And even `options.error = function(xhr) {` on line 1449.
This is the only part of this patch that looks fishy. What part of this wasn't unchanged in IE8?
в ранних версиях работает только encoding. Поменяй пожалуйста
core.js should not use MooTools (at this moment) to prevent recursive calls of framework and core each other. In future, extensions should call directly ::core() method when they needs Joomla object, so we will remove ::core() call from framework method, and we will get possibility to use mootools in core.js
not sure, want me to add it?
To release and set to null all the short live object
isnt that supposed to be => array()
Instead of `[:call, :attrasgn].include?(out.node_type)` you can do `out.node_type? :call, :attrasgn`
Same with this. Comma first style is BAD.
Просто у меня метод имена тегов для поста определен в модели поста, поэтому я делаю такой цикл.
It is not consistent - it is the same. I would not groan if you would make things more consistent.
Yes I always do, just waiting if any other fix is necessary.
Probably enough just *Celerybeat*?
For constant strings, we use `'`.
Why is this stored in the database? This is a property of the horoscope provider, not of the content of the daily horoscope.
I already fixed this just didn't pushed it yet. I decided to remove `PATCH` because updating read field will be done in new pull request. I have problem with serializing notification using tastypie as i mentioned in another comment. I wrote all details to you in a mail because this hidden comments are hard to find.
Yes, you are right, even if I am not shure that every equipment is used, maybe only up to Neck (= 13)
https://github.com/TrinityCore/TrinityCore/pull/6075
we can't add seasonal bosses to instance_encounters because of missing encounter id in DungeonEncounters.dbc ;)
Should be header elelment
```["posts"]=>
    array(1) {
      [0]=>
      array(3) {
        ["categories"]=>
        string(0) ""
        ["body"]=>
        string(6) "sdfsdf"
        ["contact"]=>
        array(1) {
          ["contactid"]=>
          int(64)
        }
      }
    }
```

Our use case is a form field that is left empty by the user (as it's not required), so an empty string is posted and then passed to the hydrator.
You can have whitespaces after the parenthesis.
(I'm making these changes myself - no need to waste your time, just so you know for the next time:)
`if (result == null) {`
should be
`if ( result == null ) {`
Hi lukasz,

I submitted new pull-request 
https://github.com/hibernate/hibernate-orm/pull/349
which is able to handle subselects. Also aliases without preceeding "AS" are recognized now.
review marker for later: I'm at this point in the review but I need to context switch now.
To clarify, the main point of the existing test that you've already written is to ensure that the "full stack" of the feature work without errors, rather than to test what `page.sendEvent('click', ...)` does.
The reason I don't think it's necessary is because the co-ordinates are already visible in the "request", so this is just echoing them back in the response. The reason they're in the response for `click` is because the co-ordinates are actually computed by the implementation of `click` so it's useful to have them easily accessible for debugging. But, it really doesn't matter, leave them if you like. No need for a test though.
Damn you auto-formatter!
The destionation should be the current location in my opinion. 

```ruby
system("cp #{ARGV[0]} .")
```
there's an entry for clinicaltrials.gov

http://www.ebi.ac.uk/miriam/main/collections/MIR:00000137


m.

On Sun, Sep 16, 2012 at 9:14 PM, Peter Ansell <notifications@github.com>wrote:

> In ns.php:
>
> > @@ -72,6 +72,7 @@ class CNamespace
> >  	'dip'       => array('name' => 'Database of Interacting Proteins','url'=>'http://dip.doe-mbi.ucla.edu/dip/Main.cgi'),
> >  	'ddbj'      => array('name' => 'DDBJ sequence database'),
> >  	'dpd'		=> array('name' => 'Health Canada Drug Product Database','url'=>'http://www.hc-sc.gc.ca/dhp-mps/prodpharma/databasdon/index-eng.php'),
> > +	'dbpedia'	=> array('name' => 'DBPedia', 'url'=>'http://dbpedia.org'),
>
> Yes, that was another case I had been thinking of. I am in favour of
> renaming linkedct to clinicaltrials or something similar for consistency
> with the principle. Does Miriam/Identifiers.org have a namespace assigned
> for either clinicaltrials.gov or linkedct.org?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/micheldumontier/php-lib/pull/14/files#r1615543>.
>
>



-- 
Michel Dumontier
Associate Professor of Bioinformatics, Carleton University
Chair, W3C Semantic Web for Health Care and the Life Sciences Interest Group
http://dumontierlab.com
setting the metric as null sets the metric and sets it to null.  If you don't want the metric to come back at all, you skip the set.

if(!ci->timed_out) noit_stats_set_metric(...)
But that will happen with any other empty resource? The special casing is good then, one case less where things will go wrong. That rough fallback is  kind of temporary too.

Ok about the const.
Here too, not possible to shorten via CSS? Also why would you choose .filename over .short_distinguisher? Also the function name should not claim to just `get_short_distinguisher` then.
Also seeing how this is used eq should definitely cache the returned functions.
I have started to move such thing to the init call of the according view, makes IMO more sense.
They are not needed the when we end up here, no, but they need when _update_view() is called. There is no reason to re-created them on every _update_view() though, which is why I only create them on createView().
In this context `inline` is a hint to the compiler, which it is free to take or ignore as it sees fit. Modern optimising compilers pretty much ignore it and follow their own heuristics.
Does not appear to be used?
well, there's a lot of 'app' references everywhere. It caused a bug because we missed one. :) In the least, perhaps 'app' should be a constant
I think that's broadly true at the moment... But I'm certainly not ruling it out it becoming a tall pole later!  Would be easy enough to adopt Gary's getFFTsize helper function to scale in the same way.
BTW, How did this line note get moved here? This used to be on the getHalfLightRadius function.  Must be a bug in GitHub moving the line notes when there are commits to the file.  I think we had similar issues in reverse when you were reviewing my code last time.
you can remove that file completely as you are not using it in the opam file.
I prefer my HTML in lowercase. Regardless though, you should stick to 1 variation. Either uppercase, OR lowercase, not both
Too clever by half. I just realized I wanted self.file.name.split('.') I'm going to cancel this PR and try again in the morning.
I would prefer the test to named : `should_create_error_message_with_single_field_difference()`
Alright. I'll remove that.
I think during testing we should use smtp, because that will actually send emails to people every time we run our test suite
i guess this is needed if we manage something immediately then configure it, to defer warnings until we've invoked an effector?
but feels messy
Good point about service-up. Will look at that.

For ConfigSensorAdapter.apply, I wondered about that but deliberately didn't. The *cluster* doesn't have a port etc (despite having config for it), so it shouldn't have an attribute set for it. Instead, the config is just there to be inherited by the child load-balancers so that they can figure out which port they should use.

I've removed the getCustomChildFlags section. It purely relies on inheriting the config rather than setting values in the customChildFlags.

I'll check again that this approach really does work, so that child nginx instances do get sensible port attributes etc.
The testCreatesNginxInstancesAndResizes does this a bit (by ensuring each nginx instance has different url and gives back default 404), but I'll think about some more explicit assertions...
`alias` instead of `super` for these two lines.
I suspect this is related to [this revision](http://code.google.com/p/selenium/source/detail?r=17004) in Selenium. If so, you may find that the Travis-CI tests will fail with this change as they are currently [configured to use Selenium 2.22.0](https://github.com/davehunt/pytest-mozwebqa/blob/master/.travis.yml#L2). Could you check this, and update the version used to the latest in a separate commit?
So.... The realm for v2.1 of the API is different from the one for v3. I don't think they will ever change per version which is why I don't think it should be a setting. But we need a way to switch it based on the API version being called.
or `$ schematic -v migrations`
"This interface is a stub for the PHP 5.4 interface." is better, yes :-)
small typo "places" --> "placed"
@arturo-c BTW, static functions can access protected properties if you still need raw access.
I'm not keen on any randomized chance for something to gib someone. Even if it's a very low chance, it's still present, and can end up to be /really/ annoying when it comes up.
For this one, I could but for some of the others I can't.  The main reason I'm using wget for the installs is that it properly supports using the HTTP HEAD query (-N) to get the size and last-modified time of the server file, and comparing it against the one you have locally.  That lets it avoid re-downloading the 400MB Qt binaries when you already have the right one locally.

Google Code doesn't support the HEAD query at all (which I think is quite broken) so flipping to curl for this one would be fine.

I'm not sure what the best way to go on this is.  Do I standardize on wget since it supports -N or do I mix/match wget and curl or do I flip to using curl but lose the -N feature?

I could change all of the rules to never download the file if you have a matching file in your ./downloads dir.  That might be sufficient for most cases where I want to avoid re-downloading 400MB.

I think Kenn also mentioned that curl was available on Mac but wget needed some extra install or something.  Maybe that should be part of the consideration.

Suggestions as to what direction you guys would prefer?
If you are actually going to use rspec (which I hope you are, but there are no tests right now), this should probably just go into the gemspec with the other development deps.
Эээ... Не знаю :) А это плохо?
Да, это копипаста из проекта Calendar т к в нем я задолбался перед каждым полем писать java.util.Calendar из-за конфликта имен...
needs to get fixed.
A comment about what this is doing would be nice.  I mean I know is checking the boxes for mobile, tablet or desktop but that's because I'm already familiar with the submission process.
We should be able to use [isinstance](http://docs.python.org/library/functions.html#isinstance) to check if we're a `PageRegion` object.
このコマンドはGroovyコードを実行可能なインタラクティブなGUIを起動し、GroovyコードからSpring ApplicationContextやGORMなどを使用できます。

だと文章が不自然だと感じたので２つに分けています。
私は、モックの生成に失敗したときでも、例外をにぎりつぶすとか、methodMissing() をoverrideしているときのことを
さしているのかと思いました。
一般に英語では may の発生確率は50%くらいらしくて、結構な可能性ですね。
Maybe also move the `is_in_mask` condition to the `histogram_*` function?
well, the wrappers as used internally; I will try to simplify that
Hey why not, who doesn't love pointers?  Stefan's Segmentation Fault really drove home the point.
I used to have them in there, but @GaelVaroquaux thought it's not necessary. You prefer them in?
Replace user and hostnames with something generic for submission to opensource.
s/PUREstring/PUREstrong ?
This conditional logic is a little odd. Are you just checking that the row_dict contains at least one of the values we're looking for?
> if (id == 0)

But the only way to get the id is via ```assignName``` and that creates if not there (even on your recommendation).

I need a way to check if the annotation is there or not without creating it...
Right, no real reason to flush here anyway.
What is the difference and when should one be used over the other?  I see that rtlmalloc currently just does an unchecked malloc, and it was like this in my original commit request?
Not for this commit.  You could consider simplifying conditions like this by setting local to true if number of slaves = 1.
btw, it break things for boolean field if the user maps ``on="change" value=false``
Actually, not needed here. Using Hamcrest has messed my brain up for this stuff. Will update pull request :-)
did you manage to reproduce it ?
I already added a newline here.
This is really the most important part of this whole change set; moving these steps out of application.rb and into command_line.rb
did these just happen to get bundled in to this review?
Not a merge blocker, but this cache_key logic is getting copied all over the place. Let's think about how to DRY that up with inheritance or (preferably) a Ruby mixin.
The "retrieve-git-authors" is async with a callback (it has to be due to using grunt's spawn function), so I moved some fo the code into the callback.  It looks odd on the diff, but no code was actually moved just moved into the callback handler for the helper.
Yes also works for me, I guess the machine is registered in the domain and has its own ID so is able to read from the domain controller.

May get more results from trusted domains running as domain admin perhaps. 

I'll remove this from description and code.
Please keep address line 2

------------------

Gregor Melhorn
Plattlinger Str. 2
81479 München

0163 83 1010 7
089 95405381
gregor.melhorn@googlemail.com

Am 14.09.2012 um 16:54 schrieb Mateusz Juraszek <notifications@github.com>:

> In sections/direct_orders.md:
> 
> > +* `external_id` - an optional param with custom id that enables connecting
> > +  tiramizoo orders with your internal infrastructure. This id does not need
> > +  to be unique and can have variable length.
> > +* `items` - an array containing measurements of at least one item.
> > +  `width`, `height`, `length` are required dimensions of your package
> > +  in cm and `weight` in kg. Optional `quantity` parameter contains a
> > +  number of items to deliver (default is 1).
> > +* `pickup`, `delivery` are required parameters cointaining addresses
> > +   from where to pick your items up and where to deliver them and information
> > +   about people responsible for sending and receiving the delivery.
> > +  * `name` - required string containing name
> > +  * `phone_number` - optional string containing phone number
> > +  * `email` - optional string containing email address
> > +  * `address_line_1` - required string containing street name and
> > +    building number.
> > +  * `address_line_2` - may contain some additional information for
> we probably dont use address_line_2 anymore, if we use, would be nice to have that in users dashboard as well
> 
> —
> Reply to this email directly or view it on GitHub.
>
Also add a period because it's a sentence.
I don't see the point of "expect_fail."

How about instead split this function into two:
<pre><code>
def check_database_for_user(self, user, password, dbs, expect_fail=False):
        dblist = self.show_databases(user, password)
        for db in dbs:
                default_db = re.compile("[\w\n]*%s[\w\n]*" % db)
                if not default_db.match(dblist):
                        fail("No match for db %s in dblist. %s :(" % (db, dblist))


def show_databases(self, user, password):
        cmd = "sudo mysql -h %s -u '%s' -p'%s' -e 'show databases;'" \
              % (instance_info.user_ip, user, password)
        print("Running cmd: %s" % cmd)
        dblist, err = process(cmd)
        print("returned: %s" % dblist)
        if err:
            assert_false(True, err)
        return dblist
</code></pre>

Then just call "show_databases" for the functions that currently use "expect_fail=True".
If we wait for the filter the locator used here is not found
I think so.  What are you concerned about?  An implementation that supports a high-ish value but has really lousy performance if you actually use it?
Did you see my reply to your comment [here](https://github.com/linzhp/botprint2/commit/d5efe3f0bbbfb8818a83738a9f7472d930859a9e#commitcomment-1535619)?
[newUrl fragment] can be one of two things: nil (NULL refers to (void *)0, nil refers to (id)0) or an empty string (@""). So use [[newUrl fragment] length] == 0. In the event of nil, the return of length will be 0 ([nil foo] always returns 0 for small datatypes). Given that the compiler knows to optimize out ==0, the readability is useful with no CPU cost.
It doesn't need to know that information.  That information is reported as part of test results that are displayed and stored to log but the purpose of finishTestPass is basically to either finish the full pass and display results or start a new pass with the next config if needed.
Could you elaborate on moving the code outside the check for validating?  Don't we only want to set the keymanager/trustmanager only when we are doing validation?  Otherwise, we would just use the non-validating sslsocketfactory.

Also how would we terminate the connection from this part of the code.  I would return null, but that would just cause an npe later on.
what does it do that starter-kit / emacs-live don't do ? 

because they both activate paredit for clojure code, is the +1 something with more functionnalities?
That is a lot better, yes.
Shouldn't we use grunt file APIs?
Was there a reason removing the `__dirname` here? The front-generator depends on the manifest, so this module needs to be pwd-independent, too.
It's good suggestion I'll do this
s/stetement/statement
Personally, I'd use `overload` here instead of `version`, and I'd say `will not accept infinite ranges for $(D haystack)`, but arguably that's getting a bit nitpicky.
FYI: `filler` was undeclared
Remove empty line above `pass`
"Produce a ContentValues instance that represents this Record".
needs
String
delete the just
We should move this to `lib/assets`: http://guides.rubyonrails.org/asset_pipeline.html
Indeed, what I meant is that if you disable the view response listener, the view handler would never be called, except manually, so to make things clearer I thought we may enable it in the same way in the listener. 

On 4 oct. 2012, at 20:31, Christophe Coevoet <notifications@github.com> wrote:

> In EventListener/AccessDeniedListener.php:
> 
> > @@ -48,7 +60,14 @@ public function onKernelException(GetResponseForExceptionEvent $event)
> >  
> >          $request = $event->getRequest();
> >          if (!empty($this->formats[$request->getRequestFormat()])) {
> > -            $response = new Response('You dont have the necessary permissions', 403);
> > +            $message = "You don't have the necessary permissions";
> > +            if ($this->viewHandler) {
> You are not relying on the view response listener here as you are using the ViewHandler explicitly (you cannot rely on the ViewResponseListener btw)
> 
> —
> Reply to this email directly or view it on GitHub.
>
Зачем эти два, если можно просто `avatar.loadFromData (reply->readAll ())`?
@complexmath is the one you have to convince, though, not me. ;)
simply because this method should never return anything with prefix. . . they are only used internally
Need to fix indentation here; when rendered  <int-jpa:inbound-channel-adapter  is indented; remove the tab before  <int-jpa:inbound-channel-adapter  (or start it right after the CDATA tag)
Tweak error message to "expecting " + operatorChar + " but instead got " + currentChar + " at position " + this._pos.toString()

Or something like that. Please give more information about what's wrong and where it's wrong.
And you call it with `urlTemplate('/api/v1/{metric_id}/', {'metric_id': metric_id})`.
Maybe better name the route "logout", so it's a bit clearer?
This is a little more aggressive than the old code, but as long as we aren't clearing the rejected duplicates all the time it's probably okay.
But is a non existent collection really an empty collection? I guess it's more of a philosophical question.

I think not actually.
There are times you might want to use a collection view with an array for example. Since marionette assumes that `this.collection` should be a backbone collection you need to rename it.
There's a lot of repetition here that can be put into a `before` block.  Remember that `let` definitions aren't evaluated until they are called, so you can define differing context in later context blocks (`let!` on the other hand are evaluated right away).

```ruby
let(:options) { nil }
before do
  @user.class.acts_as_google_authenticated options
  @user.set_google_secret
end
subject { @user.google_qr_uri }

it { should == "https://chart.googleapis.com/chart?cht=qr&chl=otpauth%3A%2F%2Ftotp%2Ftest%40example.com%3Fsecret%3D5qlcip7azyjuwm36&chs=200x200" }

context 'custom column name' do
  let(:options) { { :column_name => :user_name } }
  it { should == ... }
end

context 'custom proc' do
  let(:options) { { :method => Proc.new ... } }
  it { should == ... }
end

# etc.
```
@bp323 Extra space here and we should probably use 2 spaces everywhere here.
you need to add a <?php statement before any php code
Yes: PHP Fatal error:  Cannot redeclare static Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$kernel as non static
Remove external URL dependency
pop up error message notifying that preview failed
should the connection (conn) be closed?
Dunno. Ask @pmuir he might know where.
Don't throw an error, call fail.
Comment tags were a lot easier on the eyes greyed  out, why can't <key>0</key> be comment.block.ic ?
```git push origin --delete branch``` is an easier-to-understand way to remotely delete a branch IMO
The format of yourCallbackFunction.region is the same as blackberry.system.region property.
Android actually has all of these constants, although only SENT and FAILED are used.
I have seen in the past api's like:

     var thing = factory.getOrCreate();

to be explicit with the behaviour of the method
Minor thing - let's follow current convention of test method naming , so something like should_convert_integer_to_dbunit_bigint.
Another thing is to leverage fest-assert assertions (as they are used across the whole project) in favor of built-in junit assertions.
I'm not sure you need this?
They help with readability imho, why remove them?
I think this is the only withstanding issue. How about just "the hackathon platforms listed in the submissions section" and linking to the relevant section.
I see this is a new variable but it is never used so I'm not sure how this changed the result.
No, connection caching is strongly discouraged with Cloud SQL. See: https://developers.google.com/cloud-sql/faq#connections