labofsahil/github-event-dataset-2012 huggingface dataset:
Damn.  Thanks for making this excellent plugin for the time it lasted.  Sounds like Google wants to force us to either use Chrome or go through their site.
i dont see your point here, really.

your patch sets the default locale to en_us ONLY. afterwards hdpi is getting added.
instead, only += hdpi (PLUS - equals) should be set in order to build with hdpi assets and on first boot the locale gets set by the os anyway.

again, pls have a look at the other device repos.
oei, volgens mij help je ondeath weer omzeep met deze changes. als je doodgaat gaat de gamestate namelijk naar watching en worden dus jouw pencil inputs genegeerd. dus moet ff gamestate op watching zetten enkel als je doodgaat en pencilmode == off. klopt technisch gezien ook wel, want je speelt eigenlijk nog steeds ook al ben je dood.
and from i hear on rmnet, the data arrows still work on magldr probably due to cotullas builtin nature of rmnet
ya un souci là.. Il faudrait pas plutôt le passer en param de la fonction?..
this line is causing rails assets:precompile to fail! (nice plugin!)
Formatting with Eclipse... 
Ctrl + Shift + F
since its using my TLD its part of my account. I am just using how many
people are using the site. The next metric is to see how many points are
being added to the DB and when they are happening.



On Mon, Feb 6, 2012 at 1:00 PM, Henrik Skupin <
reply@reply.github.com
> wrote:

> David, may I asked which user account we are using here?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/AutomatedTester/powerball-platform/commit/c6fdedb3eb77f06d3e49b0975e63bc4aa1ab81f9#commitcomment-936423
>
No need for this. You only use msg_text anyway
do you need the outer most $function{   in this case?
Another thing, to improve performance, the php.ini must be modified to load phar in cache. Use phar.cache_list directive.
That's usually the way we should use phar package, otherwise performance are really degraded and the bench is not fair.
По идее, строгое сравнение выполняется быстрее, так как при ентом сравнении не выполняются каждый раз преобразования типов.
Should be `Dictator`.
@wenqing To the first point in your first comment, if it should be highlighted that this class is interface to linear solvers, I'd suggest ILinearSystemSolver. BTW, according to our coding style guide, interface class names should have prefix "I".
The above lines looks similar to those in page.js. Is it possible to extract a function for these lines?
All “Thumbnails" should be replaced with "Thumbnail"
As I've said elsewhere, not a fan of new global functions. Let's get this put elsewhere.
You probably forgot about "?"  to let this part match "group" and "groups"
Why a nested object? (binary compat issues?)

Needs docs
I'm not a huge fan of option.get even if it is guarded by isDefined, how about a middle ground?

value match {
  case s @ Some(v) if defined(v) => s
  case _ => None
}
It’s part of the illusion that there might be a different implementation of `ExtendedActorSystem`. But I suppose I should change the guardians’ type.
yes, did not realize the lack of full import. thx
Oh, not here yet, sorry.  How important is it to fix all the little bugs if we are fixing it downstream?
wondering if accessors could help with this?
http://sphinx.pocoo.org/domains.html#cross-referencing-syntax

It makes the link shorter in a resulting compiled docs.
`^i-[0-9a-f]{8}$"

Just curious why you didn't use a range for both, I guess.
It is often easier to make new commits using the old code as a guide to the changes you wish to make.  Although that may sound like more work it is a actually quite effective and generally leads to nicer commits as the rough thinking has already been done.

On this point though I'm not sure if refactoring the IPackageController should be part of this branch.

Existing code may depend on this behaviour even if it is not very efficient
spelling: "distribution"
The pattern so far for managers has been for each to provide instance methods instead of class methods.  The factory ensures they are singletons.
y, I wondered about that.  probably an argument for a new request, no?


On Wed, Nov 28, 2012 at 12:31 PM, Gerry Gleason <notifications@github.com>wrote:

> In lib/wagn/model/fetch.rb:
>
> > @@ -139,6 +147,21 @@ def set_members set_names, key
> >
> >    end
> >
> > +  # ~~~~~~~~~~ Instance ~~~~~~~~~~~~~
> > +
> > +  def fetch opts={}
> > +    #warn "fetch_new #{cardname.inspect}, #{opts.inspect}"
> > +    if traits = opts.delete(:trait)
> > +       traits = [traits] unless Array===traits
> > +       traits.inject(self) { |card, trait| Card.fetch( card.cardname.trait(trait), opts ) }
> > +    end
> > +  end
> > +
> > +  def fetch_new opts={}
> > +    #warn "fetch_new #{cardname.inspect}, #{opts.inspect}"
> > +    opts = opts[:new] and Card.new opts.merge(:name=>cardname)
> > +  end
>
> May be intentional.
>
> I wonder if it is related to having closed the ticket?
>
> Makes sense the closed tickets would modify the view of the diffs.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wagn/wagn/pull/28/files#r2255594>.
>
>



-- 
Ethan McCutchen
One of the Wagneers, Wagn.org

Wagn. How pioneers roll.

s: ethan.mccutchen
t: @intogreater
This last one needs to have a condition, right?  only the ones where present is null?
Not sure how we can make this simpler to understand...maybe an example SQL that this generates with an explanation?! I must admit I would not be able to easily maintain this code.
Format? We put { at end of line ;) (I know, I'm fatiguant!)
I left this as it was in mainline because I couldn't decide that either.

Imo windowing is the wrong place for this to begin with.
Unrelated? I remember adding that CStdString because CVariant didn't understand wchar_t back then but it does now IIRC. But "sortLabel" isn't really used anywhere else anyway.
and what if another thread accesses it between the two locks? just put it two lines up
One difference is that enyo.job results in storing data about the call so the job can be rescheduled, so it's a bit heavier.  I'll fix this in the merging.
couldn't these be consistent too ?
Though the syntax there is the same, the meaning is actually different. The dot in there is accessing a struct member, which is always a primitive operation (inherited from C). When used on an Objective-C object, it translates to a message send.
That would be waaayyy too many constants.... how do you suppose I go about adding 50 constants for colors! :laughing: But yeah, I don't like constants when there's too many (or they're for complex drawing). Another benefit of leaving things like this, is that unlike `UIButton`, `TUIButton` is *subclass-safe*! :yum:
Done (unfortunately passing actorSystem to the BlockManager constructor in a bunch places); I didn't do it originally because I wasn't very familiar with Akka.
ano ta pomlčka je vpodstatě $VERBOSE = isset($VERBOSE) ? $VERBOSE : 'false';
This will be changed in Modger 1.0.0.0-RC :)

I hadn't thought to check to see if throwables would be needed in debug or info messages; I'd only implemented it for warning and error messages
Why not final ?
The numpy.diagonal patch added a discussion of this to the docs for numpy.diagonal, that's what this note is referring to. Just telling people to check the structured array docs isn't useful unless there's actually some explanation of this there... and honestly I'm not even sure where the "structured array docs" are, that's pretty vague. People who get this warning message will want a much more specific explanation of what they need to do.
`npy_intp`? In Python2.4 we needed to typedef Py_ssize_t as an int for the CPython API, but it isn't the same as npy_intp on 64 bit linux systems. I'll be glad when we drop 2.4 ;)
я вроде понял проблему - это случается, наверно, когда только 4 точки присоединения линка. у роботов это контейнеры. у вас тоже контейнер?
Yes. Make `remove_reference` reversible passing the same options
Idea is that you can query records from remote database, using different connection. Once the Relation was loaded (hence, connection is defined), connection variable should not be overwritten.
[TYPO] `@twz.inspect`
They still work for me, after dropping that sneaky extra 'l'.

I'll submit a new pullreq with the following test:

```
class Contra[-T]
trait A
trait B extends A
trait C extends B

object Test {
  def contraLBUB[a >: C <: A](): Contra[a] = null
  def contraLB[a >: C](): Contra[a] = null
  
{
  val x = contraLBUB() //inferred Contra[C] instead of Contra[A]
  val x1: Contra[A] = x
}

{
  val x = contraLB() //inferred Contra[C] instead of Contra[Any]
  val x1: Contra[Any] = x
}

{
  val x = contraLBUB
  val x1: Contra[A] = x
}

{
  val x = contraLB
  val x1: Contra[Any] = x
}
}
```
It's commonly perceived to be good style to avoid "return".
You're right. It works in the 1-d case, but I didn't test the 2-d case. Will fix.
I agree with the "Amanda Rocks!" portion.
nit: 4 space indent?
Rather y was used but it was assumed complex while it should have been assumed real.
The error handling is essentially done by Point.  Maybe like if there are two ReferenceFrames R1 and R2, it will give the "no link between R1 and R2" error (ValueError). I will make the name changes in a short while.
It is impossible to be an Add with only 1 argument, I believe, so this is a do-nothing test.
move `else` to the end of last line

no need to escape `"` here because you are using `'` outside
Is it a good idea to rename `password` to `hash`?
@Guite @espaan Do you think this is the correct solution of #262?
You're right. Don't know how to "fix" this. `streamView` won't work as `renderView` does something different.
I see, added a simple guard.
this is not needed as there is a ``::`` at the end of the previous paragraph, meaning to insert a code-block for the default language (obivously set to PHP for the Silex doc)
This probably won't work. Did you test all those?
Or is this because you're using -1 to avoid having to make the limit column nullable?
Should also close any associated readers.
It's unclear what requirement is being verified here.  It appears to be a few requirements tied up in one test, or maybe there's a range of inputs that need to be specified to verify the requirements?
Presumably this materializes the contents of the CSV file into memory at once - would it not be an idea to use an iterable so that the Changes frontend can pull the submission from the underlying input stream?
this is confusing?
can a value be empty?
If this is the case, we have bigger problems.  If I look up docs that start with that slug, I see this:

http://www.google.com/#q=site%3Adeveloper.mozilla.org%2Fen-US%2Fdocs%2Fen&fp=d05be940d9a219c4

When I wrote tests for this case, going to "/en-US/docs/en" works, but even after creating "/en-US/docs/en/child", and seeing it appear within admin, going to "/en-US/docs/en/child" forward to "/en-US/docs/new?slug=child".  

I've been searching for where the errant "en" is coming from but haven't found it yet.  It's a separate bug, and related, so I'll keep looking
I'm guessing this applies to the current user, is the code meant to retrieve user from the global? Probably not something we should be encouraging.
We don't have a index for user and author-folder but user-folder and author. So its still a table scan for the AND-query?
Should these files have new lines at the end of the files?
get rid of the quotes
There is but it doesn't seem to be showing on github for some reason...
On multiple lines please.
disregard, I see your logic now.
Such SRC definition means that whenever we add some cpp file to repo we also need to update CMakeLists.txt, thats not desired at all. Any filename patterns are suggested here?
Delegating ctors can be used here:
```cpp
ImageTexture::ImageTexture(int anisotropyLevel) : anisotroppyLevel(anisotropyLevel) {
    ${initialize_text}
}

ImageTexture::ImageTexture() : ImageTexture(0) {}
That Func is used in the GetLoadAuthenticationHook method of the StatelessAuthentication class. I used internal instead of public just to keep the API cleaner.
We could, I hadn't thought of that.  
However, it will introduce an extra "knowledge dependency", as we need to (know how to) **make** one so we can raise it in the faking code (below).
No actual behaviour seems to be used, though, so it is terribly easy to 'fake'
  -- and then that is **also** a statement of precisely how much interface we think is required (!), which I quite like.
return this.getFormatName(name, 'city');
For the record, when `collections.OrderedDict` exist, `python25.OrderedDict is collections.OrderedDict` (the class is not redefined).
typo: Explan for Explain -- two places.
Also, need an assert to automate the validation of the presence/absence of the pushed down limit in the 2 cases.
Maybe test the result of a String.matches(".*LIMIT.*") on the final value returned by nd.toExplainPlanString() in each test case.
Instead of importing Device, this method should call an api method from discovery.
I think `s?` works too (and may be faster, since it's capturing here)
Is there no cheaper way to find out if the field has a column?
shouldn't it be done the other way ? With your change, the global headers win over the headers set for this particular request as you are adding them after. This is a different behavior than previously
The wiki link above describes the property, I can link also to the wiki page for homomorphism if that helps?
fwiw, I was following the lead of `append()` which is currently used in `replaceWith()` although I missed the fact that it was also checking for 11, so I've fixed that in f698ccb, *however*, `before()` doesn't do such a check. I'm not sure what the reasoning with these is, if there's a good reason to restrict to 1 and 11 in `appendChild()` cases but not in `insertBefore()` then perhaps the 1 & 11 check should be moved to the `else` above the `appendChild()` call?
Just curious as to the reasoning for not comparing to the empty string. If `trim` was to return an empty array when it encounters a BOM character, these tests would still pass.

Also, it would probably be nice to have tests against strings that would not end up empty, like `"\xA0hello"` and some other variations.
Should this be `.animate({ opacity: to }, speed, easing, callback )` ?
This follows the practice of using C++ abstraction layer, see the comment for the LMFModel::rebind() function, see also the same use from the regress module: https://github.com/madlib/madlib/blob/master/src/modules/regress/logistic.cpp#L127
Same comment regarding user supplied parameters.
Currently, C++ AL doesn't support a function returns SETOF. We add this function here to support this feature.
Keepalive not necessary and didn't work well on Windows.
Need error handling for !matched (should throw?).
I would replace this with a ``self._unwrap_result(result)`` that you always call. Gets you one step close to being pykka independent. If you want to take it further you make it into ``def unwrap_result(self, result): return result`` and create a pykka aware subclass.
You wouldn't even need to filter, assuming Gst.init() ignores stuff it doesn't know about, filtering would then only be required for our flag handling.
Sometimes when test cases get ornery like this, I toss them into a test data file or a directory of files in JSON format or something. It makes it easier to add new test cases and reduces the PEP-8 issues because test data doesn't always conform to PEP-8 happiness.
Turns out the return value is only used in a unit test
Could do that; though I'd like to get this set of pull requests in and make sure everything is hunky dory before doing so.
...you can just do

```rb
system "cmake", ".", *args
```

here.
Do we have any templating libraries included? Would it be worth adding hogan.js and constructing all the html using mustache && js? 

That way we can reuse our templates in our js and we can move our “templating" out of our js?
I like this update the most!
j'ai juste oublié le offScreenExtra, je le remet dsl.
Maybe use the word "anstelle" as a translation for "instead" ?
Added :default option check to get_level.
Under what circumstances can `dbh.fetchone(..)['max_id']` return `None` so as to fall through to the `or 0`?
确定这一句不需要换行？
Agreed. Changes pushed
No, I think leaving it deprecated makes sense.  I've probably reused it, as well.  :-)
Please don't change the import order.
`|| false` looks a little funny, though I understand that it's because we want to coerce `undefined`. I seem to recall that there are other more "standard" idioms for doing this in JS, like `!!foo`. Might be worth doing a little research to see which is preferred, if any.
I think that the actual versus internal/nodeJS encoding conversion going on here will be more clear if a new variable (e.g. "internalEncoding") is used instead of reusing the parameter that's passed in. This should also make debugging easier.
Offset is overridden in ``checkInfoAtOffests``
Doesn't appear that this ``NEED_BASEURL`` constant is ever used.
Should the code be returning here? If not, it seems like we'll fall into the "Window may have been resized since last time editor was visible, so kick it now" block below, and get set back to visible.
Explained in before.jstree handler that the parent gets auto-selected when toggling closed.
This last rule ("ins.jstree-icon") isn't really removed -- it's just been moved to jsTreeTheme.less, below, where all the related rules live.
O thanks I needed that tip for something i am working  on :+1:
The thing is that these completions show up anywhere: e.g., CSS properties show up in completions in the middle of a string, or outside of definitions. That little icon gives a certain safety guarantee for JavaScript that it doesn't do for these completions. However, once https://github.com/ajaxorg/cloud9infra/issues/2966 is implemented, we can make sure that they only show up in the right context. Until then, I'm not sure if they should be shown like this. Why don't you give it a try and compare how it looks without the icons? If the icons are disabled, it also no longer grays out the other suggestions.
The note above is referencing this line here. I don't know how to handle assumptions about ownership of references in objective-c without ARC. Should we assume if a user provided their own encoder that they're responsible for releasing it?
Yeah my fault I forgot to take out b when I figured out how to make the auth. 
This should be better.
Oh, I misunderstood your comment; there are \n's in the literal strings, too.  I'll patch.
I kept SingleOptionValidator there to clearly separate the foundation classes and the real validators but I can move it too if you prefer.
This intermediate variable is not necessary
This is not a refspec. A refspec is what tells `fetch` where to store the refs it downloads. The documentation calls this an "extended SHA1 syntax", but you can call it whatever you want as long as it's not refspec.
Otherwise known as `if no h.allow_user_registration()`
Probably this should be indented? :-)
I do not know what exactly you mean. :-) Just remove those magical things.
This was exposed by all of this.

validateHexColor assumes fontColor is always defined. It is not always defined.

I'll take a closer look as to why it is undefined when it probably shouldn't be.
Remove this extra new line :)
Is this necessary/better? If the output is always going to be the same anyway, disregard this comment.
It would still be beneficial to run the checkFn here instead of calling `callback` right away on success. Perhaps, if a `checkFn` exists, setup a `setInterval` to run it and wait for success after the script is loaded.
Let's file a ticket to make sure that we make bi-directional change possible. Right now, if you go from <video> -> <div>, it doesn't let you go back, you always have a new div in your page.

No need to pile it into this ticket though. Just file a new one.
So this line'll be prepare = ready;
Don't want this to happen for every event in the loop.
For lines 83 and 88, can you use
```javascript
var params = goog.object.extend({'BBOX': bboxValue}, baseParams);
```
instead?
При таком `require()` в coverage report код модулей не попадёт. Сделай как в `apw` или `bem-tools`.
If stdin is a tty pass phrase shouldn't be shown.
 
@ted-gould this wasn't merge too long ago. Removing this reopens an issue.
Is this print required?
No. It's still needed because the other files are generated from it:

```
~/dev/git-repos/julia/test/unicode$ make
make: *** No rule to make target `UTF-32BE.txt', needed by `UTF-32LE.txt'.  Stop.
```
This was an action that was added prior to adding system group remote actions; however, I can definitely split it out.  Will push a commit to this pull request.
The 'render' call here was incorrect as there is another call to 'render' at the bottom of the method.
I think the latest cljts might be 0.2.0.
might want to factor in case-insensitivity
well, @Seldaek suggested to use the channel as type when the type is not explicitly passed in the context.
用事件events吧
Same here, I presume the label should be "back"?
understood, thank your for explanation.
Ok! Do you think I should this suggestion in "Coding Standards"?
Whitelist is the model property, which will remain untouched, it will only
modify the fieldlist in the options
Op 17 sep. 2012 18:39 schreef "Mark Story" <notifications@github.com> het
volgende:

> In lib/Cake/Model/Model.php:
>
> > @@ -2299,6 +2302,29 @@ public function saveAssociated($data = null, $options = array()) {
> >  	}
> >
> >  /**
> > + * Helper method for saveAll() and friends, to add foreign key to fieldlist
> > + *
> > + * @param string $key fieldname to be added to list
> > + * @param array $options
> > + * @return array $options
> > + */
> > +	public function addToFieldList($key, $options) {
>
> fieldList == whiteList though.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cakephp/cakephp/pull/851/files#r1620325>.
>
>
wacky tabbing...
should this worker have a node set to node()  ?
Please add visibility explicitly to all methods
And you should use ``assertCount``
you may want a uuid here for the session name, to prevent warnings when adding sessions of the same name to an application instance.
Het zou idd mss beter zijn om de rechten toe te passen vanuit getNavigationHTML(...). Dan mag de parameter weg.
Could you please start each title with a capital letter and end with a full stop and empty roxygen line?
if you know it to be wrong, try to fix it? I totally believe that there may be an issue here, it's very possible that that isn't how 64-bit parameters work in the MIPS ABI.
right - the check needs to be later, then.

Note that there is only case where there is a problem:

Creating a *new* div, with no content, so that's the situation to avoid. If it enters the 'append to latest ouput' block, the problem is already avoided.
True: that's something different for svg: it requires sizing.  So maybe we should not attempt to merge these.
HideMyAss gives you a list. With current gem you can only get the proxy list or make a request but there is no way to control connection properties.

In my use case I have to get a page trying to use up to 10 different proxies with a timeout of 5 second. This because I use it in a concurrent environment (using Celluloid) and manage retry this way is faster.

If there isn't a way to get a random proxy (or a new connection which use this random proxy) I have to replicate data structure for each actor in order to manage connection properties as I want.

If you think is not a "core feature" I can wrap into another gem but I think is a good feature, don't you?
Dear lord, this is one ugly piece of code.

Do we really need to attempt to find the binary in all the paths? Quite frankly, I'd rather have an API call that lets the user specify the location of the `git.exe` executable -- that way this could work even with bundled/portable Git installations.
It shouldn't raise though. Calling both of those requires should work, but we shouldn't hit the cache twice.

If you rewrite bug_118 to contain

```js
export.url = module.url
```

The URL should come back to the same resolved path (meaning it's hitting cache)
nice hack :-)
Well, I mean they don't have to be a collection anyways (from what I see). It could just be scalar values.
This is an odd place to break this line, I'd either keep it all on one line or put the `{% block %}` and `{% endblock %}` each on their one line, and if you want to go one step further the `<strong>` and `</strong>` too.
The docstring here could be clarified to say "Get a list of existing productversions with full environment data" or something like that
Wait what? If date_range_type is not "build" then we look for tcbs by build? This doesn't make sense, unless I missed something.
I don't like this to be honest. 
`config` available as `self.config` thanks to the crashstorage_base base class.

By replicating it here one might expect it to become different or overwritten for some reason. But it's not, right?
not yet, I'm not convinced that it might be necessary again in the future.  I want it to be around if I find it necessary to bring back.
Yeah since this gets turned into an exit code to the shell that called it, let's make it 1 instead.
what's this comment doing here?
Эта опция позволяет показывать страницу в браузере сразу из фичи. Так удобнее смотреть результат, чем в консоле
should be `isset($matches[2]) && !empty($matches[2])`
@stof  Seems Mozilla is implementing the same thing as W3C but they are just lazy to implement it for the background property as opposed to Opera who implemented it for the background property but they considered that it's stupid to have angles starting from top and going clockwise (I consider it as well stupid but it's W3C.... ) so they started with angles from left side going down.

Since IE 10 is supposed to be the first browser to support the official gradient I've added support for that and moved Opera on its own.
Because I need to store the password in the User.
What will you do on this exception? How come it is not handled?
Fixed and committed
While clever, the `if` in the middle there makes me uneasy.

Also, there are some global variables hanging around which you can use for these endpoints. Look in `config/application.rb`
这里做这样的逻辑，目的是为了后续方法改变options值更加的容易。因为options值，不仅仅在初始化的时候可以改变，在后续通过函数调用也可改变。
Повторяются, в` dashboard.js` уже есть
dieses bundle brauchen wir, um den apc cache beim deployen leeren zu koennen. der apc cache, baut aus den php files eine art bytecode und macht die ausfuehrung so deutlich schneller. das habe ich gleich aktiviert gehabt. bei jedem deploy benutzt der cache nun die alten files, er muss also geloescht werden. dieses bundle bietet dafuer einen command.
didn't know how that'd work w/ node modules and all
You still have to do a similar copy over to the ruby code's lib directory. Without this the jruby gem won't work.
You can verify that everything works properly by running `rake` in the root directory, making sure your shell's ruby interpreter is jruby. (See the README's instructions on RVM/JRuby).

Right now I'm getting:

```
/Users/ahellesoy/.rvm/rubies/jruby-1.6.7.2/bin/jruby -S rspec ./spec/gherkin/c_lexer_spec.rb ./spec/gherkin/i18n_spec.rb ./spec/gherkin/java_lexer_spec.rb ./spec/gherkin/json_parser_spec.rb ./spec/gherkin/native_lexer_spec.rb ./spec/gherkin/tag_expression_spec.rb ./spec/gherkin/formatter/ansi_escapes_spec.rb ./spec/gherkin/formatter/filter_formatter_spec.rb ./spec/gherkin/formatter/json_formatter_spec.rb ./spec/gherkin/formatter/model_spec.rb ./spec/gherkin/formatter/pretty_formatter_spec.rb ./spec/gherkin/formatter/step_printer_spec.rb ./spec/gherkin/formatter/tag_count_formatter_spec.rb ./spec/gherkin/lexer/i18n_lexer_spec.rb ./spec/gherkin/parser/parser_spec.rb
LoadError: no such file to load -- gherkin
          require at org/jruby/RubyKernel.java:1033
      native_impl at /Users/ahellesoy/github/gherkin/lib/gherkin/native/java.rb:25
             I18n at /Users/ahellesoy/github/gherkin/lib/gherkin/i18n.rb:9
          Gherkin at /Users/ahellesoy/github/gherkin/lib/gherkin/i18n.rb:6
           (root) at /Users/ahellesoy/github/gherkin/lib/gherkin/i18n.rb:5
          require at org/jruby/RubyKernel.java:1033
           (root) at /Users/ahellesoy/github/gherkin/lib/gherkin/i18n.rb:1
          require at org/jruby/RubyKernel.java:1033
           (root) at /Users/ahellesoy/github/gherkin/lib/gherkin/lexer/i18n_lexer.rb:1
          require at org/jruby/RubyKernel.java:1033
           (root) at /Users/ahellesoy/github/gherkin/lib/gherkin.rb:11
          require at org/jruby/RubyKernel.java:1033
          require at /Users/ahellesoy/.rvm/rubies/jruby-1.6.7.2/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36
           (root) at /Users/ahellesoy/github/gherkin/spec/spec_helper.rb:2
             load at org/jruby/RubyKernel.java:1058
  load_spec_files at /Users/ahellesoy/github/gherkin/spec/gherkin/i18n_spec.rb:746
          collect at org/jruby/RubyArray.java:2331
  load_spec_files at /Users/ahellesoy/.rvm/gems/jruby-1.6.7.2@cucumber/gems/rspec-core-2.10.1/lib/rspec/core/configuration.rb:746
              run at /Users/ahellesoy/.rvm/gems/jruby-1.6.7.2@cucumber/gems/rspec-core-2.10.1/lib/rspec/core/command_line.rb:22
              run at /Users/ahellesoy/.rvm/gems/jruby-1.6.7.2@cucumber/gems/rspec-core-2.10.1/lib/rspec/core/runner.rb:69
          autorun at /Users/ahellesoy/.rvm/gems/jruby-1.6.7.2@cucumber/gems/rspec-core-2.10.1/lib/rspec/core/runner.rb:10
             call at org/jruby/RubyProc.java:270
             call at org/jruby/RubyProc.java:224
org.jruby.exceptions.RaiseException: (SystemExit) exit
rake aborted!
```
This isn't a unicode string.
其实`assitCell.hidden = +resultTotal < 0;`就可以了
2012, innit?
That's what I get for reading only the diff.
This was added by Robert. I'm not quite sure why this was added.
This is the kind of thing that will complexify or just disallow working with gaia/b2g without make.
(Yes, we can https://github.com/ochameau/b2g-addons)
same here (see repeat)
Do you need to set `audio.volume.master` to avoid regression too?
non-blocking: consider put those two lines (`pause()` and `setWakeLockEnabled(false)`) to a method instead of repeating it 3 times.
1. 

        this.view.addEventListener('click', this);

2. Code in `onListItemClicked` can then live in `handleEvent` as the `'click'` `switch ... case`.

Same thing apply to L134 and L135, but that's optional.
Guess we can remove this comment, or move it above :) cause it's what we are doing in the previous lines.
This unnamed span element has lots of styles associated with it.  But from looking at the HTML and the CSS I have no idea what it is for. If you give it an id in the HTML that will give me a hint. Then then you can use simpler, more efficient selectors for it here.
Do you need the start() -> getAccessToken() -> startOAuth() indirections or can you directly map the content of startOAuth to start?
shouldn't we have the same check in the other loop?
+1 for moving this out.
I think `prepend_urls` is the newer way, right? Perhaps switch these so later we can just delete the `override_urls` one?
Ok, I'm not sure how do I do that.

Can you give me some hints?
This comment is not true, the phpDoc is wrong, too.
I'll have an update that address this.
By putting the event on the "capture" / bubble event stack I can manipulate the non capture event stack and still allow those listeners to capture the current event we are on
also for source feature: https://github.com/skyluc/scalatest/commit/afcc72e1a73b799920006e0608db7b6f435d77a6
@devilcoders я не очень силен в русской грамматике. Создавал украинскую локаль - параллельно увидел недоработку.
Но думаю что вы прави, ваш вариант звучить лучше
Typo: +uses+
changing them all and not comparing w/ original value.  boundaries missed that way.
Why does this validation and path changing need to be done?
Got ya. Thanks for the clarification. Fixing.
I don't get what "the v2" is.
I'm afraid I still don't agree with you. That would make sense with `This action calls a trigger` but not with `If you want this action to call a trigger`. There's a missing `to` before `call` but I think that's not the main verb.

I know an English teacher and I might have her position about this topic tomorrow. If you can wait till then...
I remember I said that binders should return binding objects, but we need to revisit that issue. Binders need to be able to indicate that they will handle bindings in the view's subtree, and that HotDrink should not recurse.
These empty strings will go away in the next commit.
use process provider
Oh, good. I assumed @ZNickq just removed it because he wasn't sure about it, but I guess he rebased.
yeah, it's my right meaning.
Are you certain no one internal or external to Basho ever sets the config value to the ETS backend? Even just for testing? I'm fine with no capability system, but unless you update the ETS backend, it will be impossible to use with this change. It will crash on every fold request.
From my test (/var/log/cassandra/system.log) , I found that column families are repaired sequentially for each keyspace. Would love to discuss this with you.

From: Shawn Smith <notifications@github.com<mailto:notifications@github.com>>
Reply-To: bazaarvoice/Priam <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tuesday, October 23, 2012 11:01 AM
To: bazaarvoice/Priam <Priam@noreply.github.com<mailto:Priam@noreply.github.com>>
Cc: Ahaduzzaman Munna <ahaduzzaman.munna@bazaarvoice.com<mailto:ahaduzzaman.munna@bazaarvoice.com>>
Subject: Re: [Priam] [EMO-237] Implemented scheduled repair of Cassandra nodes. (#3)


In core/src/main/java/com/netflix/priam/noderepair/NodeRepair.java:

> +    private AmazonConfiguration amazonConfiguration;
> +
> +    public NodeRepair(CassandraConfiguration cassandraConfig, Optional<ZooKeeperConnection> zooKeeperConnection, AmazonConfiguration amazonConfiguration){
> +        this.cassandraConfig = cassandraConfig;
> +        this.zooKeeperConnection = zooKeeperConnection;
> +        this.amazonConfiguration = amazonConfiguration;
> +        this.lockAcquireTimeOut = Duration.standardMinutes(cassandraConfig.getLockAcquireTimeOut());
> +    }
> +
> +    public void execute()  {
> +        try {
> +            if (!zooKeeperConnection.isPresent()) {
> +                return;
> +            }
> +            JMXNodeTool jmxNodeTool = getJMXNodeTool();
> +            jmxNodeTool.repair(true);


FWIW, I tried a sequential nodetool repair a couple of weeks ago to bootstrap a new Cassandra node and it didn't look like it worked. After several hours, the new server still had not streamed any content from other servers. A regular (non-sequential) bootstrap worked just fine.

—
Reply to this email directly or view it on GitHub<https://github.com/bazaarvoice/Priam/pull/3/files#r1917878>.
But that fault exists in shipping code, so we must live with it - this pickle change needs to stay as-is, and the code needs to work around that.
I actually initially wrote this as a separate update method, but then the master code had two timers to call two different update methods.  It seemed over-wrought, particularly since the timing for the expired-master check isn't particularly important.
`assertRaises`?
Ah yes, because the `.panel-content-data` is *not* the height of the panel, but the height of its content, without the margin.
You still have the scrollbar, and must add the top and bottom margin to the height of the panel.
Thank you, a call to unzGetCurrentFileInfo at ZipFile::getFileData is removed, uncompressed_size is cached at ZipFile::setFilter together with file pos info.
Ah, hadn't spotted that. Just walked through the code and realised `strtolower()` is redundant too.
It isn't used anywhere. Should I add it anyhow?
```string|array``` instead of ```string|string[]```?
My knowledge is limited in these areas so Jon if you can provide a better alternative feel free.  Quentin what this does is
ssh's into our gateway, then ssh's into our util server in just one step
The idea was to align the params vertically.
It looks messier than it should, because of the nested hashes.
this is calibration, right? why not moving it to cob_calibration_data?
Remove the </div> just before </form> in this file to fix the layout of this view.
That's because it doesn't make sense for the component wide access control we have now. However with the item level access you're adding it does make sense.
I forget exactly how rotating works. These seem right, but we should really unit test them.
This should document why the backslash is escaped too. A backslash is not a quote to me.
See #1171
If you don't need to refer to these namespaces from more then one place, let's don't export them.
96c69fb01fc481d60e4a1778aac84ee0d796e022
Is this enforcement okay with Soup or other non-shim usage of include.js ?
two new wsapis have been added to support this change.
I think you created a separate bugzilla module. Why put the bugmail stuff here instead of there?
I <3 that!
@joshcooper removed pkg refresh
Removing these lines isn't wise because the exit status of the init script will now be the exit status of a plain `echo` command (always 0?) which will mislead Puppet managing this service init script.
Choose one way to bind. Goddamit. (See other Loaders)
No, but this is just a copy and paste from the previous location.

Does Rubinius have a style preference for explicit vs. implicit `return`?
In general, I'm very particular about coding style (I already know I'm a little bit crazy). Preferably I'd like spaces around operators (so 'dom.prop.tagName.toUpperCase() == "BODY"' instead of what is above. I'll go ahead and pull these changes and fix them as I see them, but in the future if you could put spaces, I would be super happy.
We have not forced code convention for the unit tests. but i can update them as well.
This comment is not necessary
Good question. However, I'd argue it's irrelevant to this particular PR.
null|array|ParameterContainer
Does "accept_nested_attributes_for :dictionary_descriptions" implies attr_accessible :dictionary_descriptions_attributes?
The same for label_attributes.
If this is a one-line change, you should just have a // CraftBukkit comment after the line you add
even beta4 now
you probably don't want to receive mails on error as you will have a mail for each 404. It should probably be on critical only
Could you define this as const DEFAULT_RANGE = 'A1:A1' / self::DEFAULT_RANGE
Needs to be `0` as default
-> `} else {`
I know this is perfectly valid coffee code, but it isn't that readable IMHO. What about a simple "this" ?
A vector is not necessary. Please remove it.

This code converts the data twice. First, the incoming string is converted to a std::vector (which only requires a std::list, btw), and then the vector is converted to JSON format (back to a string). Please update code to convert from incoming string to JSON format in a single loop.
this is useless because `return undefined` is the same thing as `return`.
Document the "raw" parameter
Oh crap, that's ugly. :)

You could make your terminal 10 characters wide, does that mean the whole of EasyBuild should not use lines longer than 10 chars?

We shouldn't overdo it imho.

Once we get to extending the info on https://github.com/hpcugent/easybuild/wiki/Code-style, we should agree on a limit and enforce that. Now we're just stabbing in the dark.
This isn't my Makefile, I just patched it.

Let's not enforce PEP8 style in Makefiles that are not our own, please. :)
Doh, I changed the file name to jta-crash-rec-quickstart-ds.xml. I'll fix on merge.
Since the "host" parsing is now really parsing full-fledged RFC2396 authorities, maybe we should rename these states and the other symbols that reference host parsing.
Please format your code according to the style that is already in the file. )  ){ ??

Consistent code formatting is important. There should be a space after } and a space before {.
Might be more concise but exceptions might be more clear:
```python
if hasattr(self, 'api_key'):
    return self.api_key.key

ApiKey.objects.create(user_profile=self)
return self.api_key.key
```
Ohh ok. Either way, the style sheet should be updated so that the `h2` tags have the same styling as the `legend` test.
That doesn't work for me, and I'm not clear why it should.  I could move the HTML fragment into the view, then just get the class name from the helper though.
Small whitespace while I was here
At the moment I've got:

    o Virtual Network
        Name: [ list of networks ]
    o Bridge
        Interface: [ list of bridges ]

Would you suggest just hiding the select that isn't in use (so it appears to fold each section)?  Or I could have just one select for both types and drop it down below the radio buttons.
Same here. Not liking the exception handling in the tests.
haha, sorry about that, maybe early signs of dyslexia ;-)
Ah sorry, we have different indentation habits :)
Well, in the glorious dawn of a fully RESTful future, the uri could change all the time, as long as it's always included in a consistent part of any appropriate response(s).  I agree that, for now, ```/card/random``` is a better idea.
Why do you think it is useless?
этот самый
Это все тесты?
may be it is going to be more obvious to have dedicated variable for that?
'boolean predefinedSamplesCount' instead of 'totalSamplesRequested != -1' ?
Good job actually cleaning up the discussion here! We also need to clean up choices and votes. However, we could probably take care of all of these with attributes on the models.
Sounds sensible. No point trying to cover every possible use case, that's what custom tasks are for.
Actually nevermind -  Because all of the string parsers actually return full tuples, you could never have a null... rgba.join seems safe...
@kellyredding - With the `Dir.pwd` stuff, basically you have to run tests from the the repo's directory? I can't do something like: `rake -f /path/to/Rakefile test` unless I pass an absolute path to the `for` method. Is there a way to override the test root with an environment variable?

The case I'm thinking of is a CI server. In the case we couldn't run the commands from a repo's directory, it'd be nice to override this with an environment variable or something.

```
TEST_ROOT=/path/to/repo rake -f /path/to/repo/Rakefile test
```

This may not be something assert should worry about though. I could set that logic up in my own Rakefile if needed, just use `Assert::RakeTasks.for(ENV['TEST_ROOT'] || 'test')`. This might be an issue we run into later, I'd let it be for now.
Essentially, all "modifies paths" manipulators *must* go after all "adds pages to the list" manipulators.
Where is this X coming from? Shouldn't it be A1, A2?
Commented out code should be removed from a feature branch before merging.
Is this for future-proofing? It doesn't look like a resource will ever *not* have a `content` key?
@simong : We can probably abstract this into your cassandra file.
Should use `RestUtil.encodeURIComponent`
These methods are general purpose, that way you can re-use them in unit tests.
ie:

```javascript
var cassandraAPI = require('oae-util/lib/cassandra');

var KEYSPACE;

module.exports.setUp = function(cb) {
    KEYSPACE = "keyspace" + Math.floor(Math.random()*10000000);
     cassandraAPI.createKeyspace(KEYSPACE, function() {
         // Use the newly created keyspace for running tests.
        cassandraAPI.configure({'keyspace': KEYSPACE});
        cb();
     });
};

module.exports.tearDown = function(cb) {
    cassandraUtil.dropKeyspace(KEYSPACE, cb);
};

// unit tests can do whatever they want.

```
Please default to logging an error.
My understanding was that the keyword is `macro` (https://github.com/scala/scala/blob/master/src/compiler/scala/reflect/internal/StdNames.scala#L162), and that the package `scala.reflect.makro` is so-called precisely because they didn't want to use a keyword ;-)
In notify() this parameter is used with the value ``mailtext``.
same as above (truth)?
I think think needs putting into a thread, again I'll come to this later.
Consider generalizing the class hierarchy, e.g. CardGame as the (abstract?) base class with Poker, and other card games, inheriting from CardGame.

Consider sub-classing Poker with the various types of Poker, e.g. FiveCardStud(Poker).
This was very old code that I wrote far before the that method was available, will change.
On Feb 23, 2012, at 5:59 PM, Steve Johnson wrote:

>> @@ -88,6 +91,7 @@
>> 
>> log = logging.getLogger('mrjob.emr')
>> 
>> +S3_URI_RE = re.compile(r'^s3://([A-Za-z0-9-\.]+)/(.*)$')
> 
> I was wrong, you look up to date enough. You shouldn't use a regex though, use `mrjob.parse.is_s3_uri()` instead.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Yelp/mrjob/pull/378/files#r483533
Thanks I'll pull this tomorrow but will revert one change unless you wanna do that before the pull: the `if os_is_windows()` these unicode issues are a problem with networking as well so I wouldn't be surprised if someone comes along with a non-Windows system that chokes on it as well.. so I'd like to just do the filtering regardless of OS
@narfbg The majority of databases use double quotes as an escape character. I would rather go with the majority here, and replace the few that don't use double quotes (mysql and mssql).
OK, I've rechecked and I'm not sure it's really a bug. It seems that Dscanner ignores the carriage returns when calculating the character position in the file, while Vim doesn't. In other words - Dscanner uses character position while Vim uses byte position.

I'm don't know what other text editors do, so I'm not sure you need to change it. Anyways, since my plugin writes the buffer to a temporary file anyways, it's very easy to write that temp file in Unix format and avoid this problem altogether.
Что если мы хотим 100% мутацию?
да, про это забыл!
Стоит проверять, не передали ли чего некорректного? Например, отрицательное число, или число больше 100
проще было бы всем ответам сначала сделать is_right = false, и потом нужному true если надо

то есть весть метод:

    Answer.update_all("is_right = 0", "question_id = #{question_id}")
    update_attributes(is_right: true) unless is_right?
Comment needs to be updated to reflect code changes.
Why contacthandler extends from LoginBaseHandler ???
this will blowup if a ul doesn't exist in a drop down
I'm kind of on the fence about this one. It's true that it's not a `BOOL`, but that's for technical reasons – it's treated exactly like a boolean and won't be used as anything but true/false.

Maybe we should update our conventions to say "booleans" instead of specifically the `BOOL` type.
Gotcha!

On Tue, Jul 10, 2012 at 11:33 PM, Jari Bakken <
reply@reply.github.com
> wrote:

> > @@ -7,6 +7,13 @@ class Category < ActiveRecord::Base
> >
> >    validates_uniqueness_of :name
> >
> > +  extend FriendlyId
>
> It's common to have extend/include calls as the very first statements in
> the class body. So these should be moved up. The friendly_id call is fine
> where it is.
>
> Ditto for the other models.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/holderdeord/hdo-site/pull/54/files#r1135850
>



-- 
Jonathan Ronen
+47 99373640
So the commands are only loaded once
1 more indent
Yep! Missed a couple in this file and mixed_norm, fixing now.
The sample data doesn't have the labels included. You could use `labels_from _parc` (on of the reasons why I added this).
I think you mean Pairwise Phase Consistency instead of Correlation...
by default, we wouldn't want the SVG renderer to be included in the library though. We should probably create a new build target for it.
This method can't be public static...it defeats the whole point! :-)

I think we have to generate these tokens in ModuleFactory, and Daemon needs to do something like ModuleFactory,isValidToken(DaemonToken).
Granted. I will modify flush() to act on individual stanzas.
How about

```clojure
(loop [n n]
    (or (try (thunk)
             (catch Exception e
               (when (zero? n)
                 (throw e))))
        (recur (dec n))))
```
This line is really dense - I can only understand it because of the example in the comment (which is great), but I wonder if we can just expand it out onto a couple more lines to make the code clearer.
Ah, I see. Fixed.