labofsahil/github-event-dataset-2012 huggingface dataset:
Hey Matt! :) I found it today:
@line 57: "# I found this regex elsewhere, showing how to manually strip package URI's you may need...thanks to whoever wrote it"
It's me! :D You're welcome! ;)
1. 创建 Node 和 Section 这个是留着初始化数据的。
2. SiteConfig.save_default 放 seed 里面确实会好一些，但是和以后其他的 seed 动作混起来不好处理。
3. find_or_create_guest 我不确定那个地方有在使用，隐隐记得好像是 Device 还是 OmniAuth 要用到，没有比较尽量不要删除，带来不必要的 Bug；
@alexluana, almost all bugs you reported here are related to DB issues or custom stuff in your fork, or because I didnt test icc on clean r2 :p
I will check on clean mangosR2 core those bugs.
Murading isnt spawned on my db (ytdb).

ice bolt cant spell block? what does it mean?;p P.S. it should be interrupted (shield bash, kick etc.)

PLEASE REPORT BUGS IN ISSUES thank you.
Done.

On Feb 28, 2012, at 11:49 AM, Jason Stajich wrote:

> haven't yet, do you want to do it? I'm not sure when I'll get to it.
> 
> On Feb 28, 2012, at 8:46 AM, bosborne wrote:
> 
>> Jason,
>> 
>> Yes, this was a mistake. You reverted back to the original code?
>> 
>> BIO
>> 
>> 
>> On Feb 28, 2012, at 11:35 AM, Jason Stajich wrote:
>> 
>>> Brian - this is an interface, why does it need a new method?
>>> 
>>> --- 
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/bioperl/bioperl-live/commit/60b1388f71daf978f18b41b48f66c079e80eea13#commitcomment-1021683
>> 
>> --- 
>> Reply to this email directly or view it on GitHub:
>> https://github.com/bioperl/bioperl-live/commit/60b1388f71daf978f18b41b48f66c079e80eea13#commitcomment-1021732
> 
> Jason Stajich
> jason.stajich@gmail.com
> jason@bioperl.org
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/bioperl/bioperl-live/commit/60b1388f71daf978f18b41b48f66c079e80eea13#commitcomment-1021748
Overall: I am not too happy with the change. I changes from a really simple loop (a few lines, three statements) into a 40+ lines beast, while introducing several potential performance-issues and a lot of complexity overhead. 

I would think that by moving to Drupals core API's we would at least cut out on the amount of logic; which is clearly not the case here. 

Also; the changes in the SQL probably need to be backed with benchmarks. And by lack of actual unit and integration tests at least tested on several databases: large taxo-sets, small-taxo sets, hierarchical sets and so on. But that latter can be done by pushing it into the -dev release and have the userbase test it :)
The command
Frankly speaking I don't think and I don't hope that there will be more examples like SP Pangde or Anjiang
change this to time
We will cut a new gem release tomorrow. Good job.
I think we should split dependencies into 3 packages:

- voldemort dependencies 
- voldemort-contrib dependencies
- your module specific dependencies

Do you know which one is which? I am asking because I think I will need to create a pom.xml with the proper dependencies and push that to the JBoss repo.
`si:*performance-counter-frequency*` じゃだめなんでしょうか？
That could work if we were very careful that the class was never been used before duping it. If, however, any test runs that uses the class its design document will get cached and `#dup` will happily duplicated that cached document into the test fixture class, there by invalidating the test. I am not sure exactly how you would ensure that the class was never used before it was duplicated.
the XX man may be a copyright issue.
This is not strictly true for the SVR, is it?
I'm not quite sure how the outcome of this could be any different from "predict" for the SVR.
Reinier, is dit al in de productieversie opgenomen?
Required DB update:

REPLACE INTO `gossip_menu` (`entry`, `text_id`, `script_id`, `cond_1`, `cond_1_val_1`, `cond_1_val_2`, `cond_2`, `cond_2_val_1`, `cond_2_val_2`) VALUES
(2187, 2820, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO `gossip_menu_option` (`menu_id`, `id`, `option_icon`, `option_text`, `option_id`, `npc_option_npcflag`, `action_menu_id`, `action_poi_id`, `action_script_id`, `box_coded`, `box_money`, `box_text`, `cond_1`, `cond_1_val_1`, `cond_1_val_2`, `cond_2`, `cond_2_val_1`, `cond_2_val_2`, `cond_3`, `cond_3_val_1`, `cond_3_val_2`) VALUES
(2187, 0, 0, 'Transcript the Tablet', 1, 1, -1, 0, 2187, 0, 0, NULL, 9, 4296, 0, 24, 11470, 1, 0, 0, 0);
DELETE FROM `gossip_scripts` WHERE `id` in (2187);
INSERT INTO `gossip_scripts` (`id`, `delay`, `command`, `datalong`, `datalong2`, `datalong3`, `datalong4`, `data_flags`, `dataint`, `dataint2`, `dataint3`, `dataint4`, `x`, `y`, `z`, `o`, `comments`) VALUES
(2187, 0, 15, 15065, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 'Create Tablet Transcript');
The root check was developed in order to avoid nasty issues like http://issues.ez.no/15823 where if you configured your caches wrongly, and ran cache clearing as root, it would delete the whole server. I think this patch resolves the issue the wrong way. Instead of having CacheDir code here in the eZFile class, you should set $rootCheck = false when you call recursiveDelete() for the cache dir - presumably in the eZCache class.
Shouldn't this be a bug in the way we're indexing? Shouldn't this update happen when the authors/categories get added?
@outsideris 걍 노드로 메세징 허브 같은 녀석 하나 만들려구요. ㅋㅋ 
프로젝트 세팅하는데 10분 정도면 되지 않을까요 ?ㅋㅋ
No problem, I made it for my own need on this project : https://github.com/hooktstudios/revengeanceduchesses

http://revengeanceduchesses.com/

Nice day'
Two thinks. First, we put on build at the comman level only things that are common to all builds. Msbuild targets do not fit that description. 

Second, I was suggesting that if you pass -name value, this gets turned into an msbuild property, no parsing involved there. We already do that with the unknown headers in the build line, and most of the code in the command system for I parsed input parameter is already there. 

--
Sebastien Lambla


On 2 Feb 2012, at 15:51, "chriseldredge" <reply@reply.github.com> wrote:

> Can you elaborate on #199? The issue is open with zero comments and no related commits that I can see.  Additionally, I think passing unparsed inputs into the PackageBuilder is not the right design. The PackageBuilder's job is to build packages, not to parse commands.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/chriseldredge/openwrap/commit/9186f49dfdde64ad84995279cedeb106532c8540#commitcomment-926704
It's not converting it to a word though. I thought `to_something` was only reserved for conversions. I only made this method because it was used elsewhere (in `+`, `-`, etc., in BigNum).
Minor thing, this breaks when using Mysql. Need to use limit 1 at the end of the subquery instead.
The same error is being raised now that was being raised before. You're right, though, that it will cause stray errors on import (as it would have before). There should be a try/except around the from_vidscraper_video call in tasks.py specifically to catch and log InvalidVideo. I'll go add that straight away.
Ahn!!!! Now it makes sense. It was clearing the token, now I can access it. ;)
Needs Fixing

(@ENTRY,0,1,0,0,0,100,0,7,@ENTRY,0,0,80,@ENTRY*100+1,0,2,0,0,0,1,0,0,0,0,0,0,0,"Bath'rah the Windwatcher - On WP 7 - Run Script"),
is wrong, and  the second set of waypoints shouldn't be there.
codeztylez
I think I've seen comments by others that they weren't a fan of arbitrary scoping.  One of those personal preference things I guess.  I agree in cases like this I can prevent accidental misuse.
@zwerg 
Yes, all best slot items the one owns, but you have to the level for the item have.
d'uh! nice catch.
> » pry                                                                                                    ruby-1.9.3-p0
> [1] pry(main)> '1.5'.match(/(\d\.)*(\d)/)[0]
> => "1.5"
> ```
>
> I don't see any problems.

for real :) my bad. i forgot to use bundle exec for git source
scala の versionが 2.9.1で、 scala time の version が 2.8.1 になってますけど変えたほうがいいんじゃないですかね？
keeping the location as a field is probably clearer and faster.
`selected_ratings = Movie.all_ratings if @ratings.nil? or @ratings.empty?` korvaa molemmat yllä. Myös hashilla on metodi `empty?`, ja luonnollisesti `hash.keys` on tyhjä jos ja vain jos hash itse on tyhjä.

`@all_ratings` vaikuttaa myös hieman turhalta, jos sen ainoa tehtävä on toimia placeholderina Movie.all_ratingsille tässä. Tämän idiomaattisuudesta mulla ei tosin ole niin vahvaa kuvaa suuntaan tai toiseen.
your calculations show that 

if the number is positive than 
    use floor 
if negative 
    use ceil. 

this should be switched to the opposite in my eyes... so ">" should be "<" on this line
yep, added new comment lines and deleted lines on the top of file
See here where I just changed the UA-7477439-17
I've just noticed this might be done by setting javascript variable window.tinyMCEPreInit before calling javascript_include_tag 'application' in your main template file. I leave decisision about this pull request to you. IMHO it should be at least commented somewhere. Cheers!
пипетс
это значит у вас там такая куча разных картинок? :)
на самом деле такая тема - не очень крутая, ибо нужно картинки "еррор" и "фейс" чтобы были png, и их соответственно вешать цсс-ом на страницу
Yes, whatever. But why? How about:
return response unless response.success?
@audit = response.audit

OK, 2 lines of code instead of one. Hmm...., I have to re-think it.
wifi uses sdio, sdc2. the sd card is sdc1. it should only stop your sd card from working if you change sdc1. it's been in my rom for a month & nobody complained.
Is there a reason you reverted this back to `uri.query = Rack::Utils.build_query request.GET.merge(:authorization => auth_request.id.to_s)` ?
Yeah I know you don't include translations in Grappelli.
But the problem is that all the translations above are not included in the django nor the contrib.admin french translation files.

Do you know a more appropriate place to publish missing translations ?
Patch updated - see new branch at

  https://github.com/mcnewton/freeradius-server/commits/patch-tls-option-1

Much tidier with the conf parsing function.
F*** forgot to remove
Zła liczba. Powinno być 6 jeśli już. Znak o indeksie 7 znajduje się poza stringiem i metoda powinna wyrzucać wtedy `PositionOutOfBordersException`. Dla 6 powinna zwracać true.
Ah I see you used browserify... it really does seem like nice stuff indeed, but as I said - is the amount of work required to convert the large amount of code in JSTS feasible?
This is some serious weirdness.  Cleaning crew called.
Not sure why your message doesn't show up here but, no, I don't think there is any advantage to ftp protocol, @klickverbot .  It's probably a disadvantage these days, actually.  I did notice after I made this change that the download page was already using http for most of the ftp.dignitalmars.com links so this can be switched back.
Repo from: https://github.com/arnau/Nutils
Doing so with SQL/Django would defeat any caching on meeting_times, if it's a QuerySet that has already been evaluated.

Doing so with Python would work but would be slower if meeting_times isn't cached.  But really, who's going to pass in so many meeting times to this function that sorting them is a nonnegligible cost?  So perhaps that would be reasonable.  Then it's no longer a QuerySet, though; not sure if that would break anything?
GLUSTER_VOLUME_OPTION_**SET**
GLUSTER_VOLUME_OPTION_**SET**_FAILED
k, sometime its hard to keep track if there is an extra line, space somewhere u know. But i'll keep it as clean as possible
That's in a different place. Also,` /tiny` will now also send the url to all people.
Yes, and I only ever had a problem running commands through the as_user command when I wasn't running the script as the user specified in the $USERNAME variable. 

Seeing as the script is supposed to be run as root (it's a service script), not the user specified in the $USERNAME variable, I changed that part of the script so that it would work properly.

I'll do some more testing to double confirm this, but that's what I remember having trouble with in the past.
Not saving assistantid anymore? Doesn't that defeat the purpose of having a client list? Having the Assistant id in the database would be usefull for plugins, or cross reference. Since the client info isn't in each siri session, and assistantid is. Also, saving the IP address for where it was created could be usefull too..
I know I was working on something and didn't finish it last night

kaijura <reply@reply.github.com> wrote:

>Just a note, had to remove the following temporarily for vivo compile or it would not build:
>RomCustomSettings.java
>Statusbar.java
>rom_custom_settings.xml
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/IceColdSandwich/android_packages_apps_Settings/commit/eb23cfad4fb29bffaac87d14ccf252e23b92f20f#commitcomment-999171
contextでした
The docstring style we use in nrml requires the opening """ to be on a line by itself.

<pre>
"""
Parse the source XML content and generate a rupture model in object
...
"""
</pre>
Maybe. I'm open to it, if you think it's important.  To me, "progress" implies something has happened, which isn't necessarily the case.  "unfulfilled" would be more appropriate, but is an odd word and would be typoed.
data-theme in navbar has not effect. It only inherits the swatch of its container.
It's a good idea not get the user language?
When Elgg uses a language other than the default, if the user change the language to English and system cache is enabled, it is not possible for the user to return to the language set in the admin panel. Removing the requirement to get the user's language and get the language from the global variable $CONFIG, users can always switch between English language and the language setted as default in the admin panel.
Maybe, but you'd think that we'd have that problem during an application request as well, wouldn't you?
I suggest to just wrap in a RemoteTransportException and rethrow and let the layer above decide if it should be logged or not
Same here WRT dispatcher id. Why isn't it in the ProducerRequest?
Also, this method is only used in one place, so there's no reuse to be had, so just inline the logic here.
Because of the arrow notation. The arrow indicates the direction of the  
connection. At least that was the idea.
I snuck it in when I needed it, planned on discussing it and then forgot about it. Problem right now is that it runs all tests twice, so we should decide on how we want it to be and then do it.
Should we cache all messages that are broadcasted?
Just continuing the tradition
that's a nice trick
I've updated this branch with these changes.  Tests pass for python2.6/2.7.
If you're fixing coding style, maybe also move the position of the `*` :-)
Should indicate that step three is skipped if force is specified.
Very minor typo: "Unbind from", not "to".
I'm not sure I remember correctly but I think I had that first but then changed it to this for some reason (which I obviously can't remember anymore).
Who cares if it's a for loop or not, just because you think it looks "nice"
Mooi dat het vertaald is, maar voor het vervolg: alles mag in 't Engels ;)
the idea was to minimize the public methods in SchemaTuple. I suppose the gain is minimal, it can just be public?
Testing multiple url-patterns
Shouldn't we replace ``file:make_dir(TargetDir)`` with ``filelib:ensure_dir(filename:join(TargetDir, "dummy"))`` instead?
Not too enthusiastic about having parameters dumped into the global namespace, especially with generic names like 'rho' and 'theta'. Can't they be localized withing integrate_omf4? Or, barring that, at least be declared static?
I'll try to check this night and to update this, Thx Stof
Yeah, you're right. It was just shuffled around, but I'll fix it up.
Along with the transition to no ivars in the header, Github's [coding conventions](https://github.com/github/objective-c-conventions) try to limit the use of ivars, unless explicitly needed (such as in -dealloc or -init). So in this conditional (as well as the ones below), could you use the property instead of the backing ivar?

I realize that not all the rest of the code does this, but this is just a practice put in place on new code. :+1:
Fix the steps, and you can enable this :)
lpDB是哪里的变量？你确定它不是一个字符串？
Instead of isDefinedAt, you can use contains.
"from numeric import ..." already invokes "import numeric", that's how Python imports work. Does this actually make a difference, and if so, why?
need some doxygen docs
такие штуки надо как-то документировать. а то нажмет юзер случайно и получит что-то неизведанное :)
заменить на qMin/qMax, свернуть в 2 строки каждую
`An object with the method #include? or a proc, lambda or symbol is required`
I think we don't need these comments.
I'm wondering whether this should be call `namespaced_path` or `namespaced_root_path` - @josevalim, @drogus wdyt?
I still prefer explicit returns here, it also gives us a `true` return instead of a truthy return. If you prefer a different style I can change it up.
Woops! My bad. Doing it.
nope, as I saw this gets called with nil (in a test case).
This breaks the tests, because if `options[:sanitize]`

However, this works and is quite readable:

```ruby
highlighter = options.fetch(:highlighter, '<mark>\1</mark>')
sanitize    = options.fetch(:sanitize, true)        

text = sanitize(text) if sanitize
```
The implementation detail of choosing binary vs linear search based on the collection type is pretty important to document.
Also `LabelDef`: `class X(val x: Any) extends AnyVal { while (true) ??? }`
the title of the commit is misleading. For me it suggests that we should have new interactive.Global(....)..... or am I missing something?
from scipy import fftpack
fourier = fftpack.rfft(sig)
Is this object immutable? If it inherits from Basic then it should be.
I included it because I couldn't find a nice reference for this basic result, but yes, you're really really right about removing it.
`constrain`?
That's a cool way to address the reader :-D

I do think you can remove the hash symbol though, unless you put it there on purpose.
You'll need to fix this.
On Fri, Aug 10, 2012 at 8:49 PM, Sean Vig <notifications@github.com> wrote:

> In sympy/core/basic.py:
>
> > -           you can use string or a destination function instance (in
> > -           this case rewrite() will use the str() function).
> > -
> > -           There is also possibility to pass hints on how to rewrite
> > -           the given expressions. For now there is only one such hint
> > -           defined called 'deep'. When 'deep' is set to False it will
> > -           forbid functions to rewrite their contents.
> > -
> > -           >>> from sympy import sin, exp, I
> > -           >>> from sympy.abc import x, y
> > +        """ Rewrite functions in terms of other functions.
> > +
> > +        Rewrites expression containing applications of functions
> > +        of one kind in terms of functions of different kind. For
> > +        example you can rewrite trigonometric functions as complex
> > +        exponentials or combinatorial functions as gamma function.
>
> gamma function -> gamma functions
>
>
> I made this change and changed single quotes to double and rewrote the
sentence a bit. I committed on top of the pull request I made to this
branch.
Add a space after the comma.
Alternatively, should I break it into a source/header pair?
(and link in the source in bindings.gyp)
since this is shortened to 144 chars it would be great to have a shortened url to where to look like an automated pastie perhaps, private :D
no static binary, as FreeBSD has port binaries in a different location
Newline here, no braces in do/while block.
Hah, really? It doesn't auto-create the m4 directory? Old autotools?
Everything that is private here, should probably be protected instead.
Should use the $user->lang() method instead of the $user->lang array.
This should use the $config->set() method.
`is_dir` would be more readable though
Error checking, use error collector and write any errors to error log. Delete var_dupm below.
Why is it pointless to change the statistics to be correct in the event of overriding the user's selected style? I'm sure there is some support ticket asking about the statistics when they do not appear correctly in this case.
Remove it completely if this is the end of the function.
I think cron errors only appear in the ACP.
You mean just have the magic call function check for sql_, remove that prefix, then call the sql cache service for those calls?
See http://travis-ci.org/#!/phpbb/phpbb3/jobs/2259193
Extremely minor nitpick: the lines after var are indented too much.
fișierul nu e necesar dacă nu vor fi view-uri. Poate fi șters
Really C99 ?
I think that's fair. Would Ruby allow me to say, make the `key` parameter to `[]` optional? Or the `value` parameter to `[]=`? If not, then I'm going to have to go with `get`/`set`
hmm yeah, didn't think of that
make sure to run jsbeautify.org
Rather, I'm talking about the username/password here --- you can change the HOST to emrjss.jelastic.dogado.eu
Did you have to edit these files at all, or are they the exact same as: https://github.com/Raxa/Ext.ux.touch.grid? 

I'd like to figure out the best practice for including some files from another project into our project, but I'm not yet sure how to handle it. My primary goals are to be able to pull changes from the initial project when they improve it, while also allowing us to make changes if needed. Some options:
1) Git Subresource
2) Git subtree 
3) Git remote
4) (non-ideal) just include the files directly, as we're doing now, and not have access to the original project's history and updates

Some context: http://stackoverflow.com/questions/720669/projects-within-projects-using-git , http://git-scm.com/book/en/Git-Tools-Submodules
unclear why this is better than explode()
同上。需要支持格式化
Does this cover the replicated read case (which can be partitioned)? Maybe that'll be more clear as I read more...
Is this likely to have a performance impact in the naive case? I'm not sure it matters here in the catch-all key; just thinking.
helpLoadFromJSONObject should be protected.
loadFromJSONObject should be the public one, but if protected works, keep it protected.
Narrower scope is better.
That's why i changed it.
If we want bitcask explicitly we should make a migration to fix those tests. As it stands, there is no backend specified in the current matrix.
That was actually the merge from master. It was decided in some discussion. @ashbb mentioned it in [this issue](https://github.com/shoes/shoes4/issues/58) and was referring to this [discussion](https://github.com/shoes/shoes4/pull/47) so I think it should be fine :-)
FYI - the deprecated sphinx directive automatically inserts a "see release notes" link
There's no stylistic reason to capitalize blog, I don't think.
Double spaces?
Same question for `realizations` as with `sites`.
This is an awesome simplification, nice catch.
How about

    var getBoundingClientRect = "getBoundingClientRect";
    offsetSupport.zeroOffset = false;
    if ( getBoundingClientRect in documentElement ) {
      container.innerHTML = "<span style='margin-right:-1px'></span>";
      var offset = container.firstChild[getBoundingClientRect]();
      offsetSupport.zeroOffset = offset.top | offset.left === 0;
    }

?
That ungood grammar still is
I'll ignore changes in this file and instead use pull request #183, OK?
We need more description.
Might be better to do the validation here. Maybe create a `smart_date()` function so then you could do:

```
    search_date_start = smart_date(request.GET.get('date_start'), None)
```

and then you wouldn't have to worry about validation later. Ditto for search_date_end and selected.
The Django ORM code does a bunch of metaclass things. As long as it doesn't interfere with those, that's probably fine.
> этот коммит не является родителем коммита C2 (является потомком).

Хорошо. Всё зависит от направления стрелок. 

> что такое «прямой» родитель (потомок) коммита и какие ещё бывают родители

Я не вижу тут особой проблемы. Фраза вполне однозначна, и к тому же опять же есть иллюстрация и ещё последующее разъяснение что к чему.

> разве можно говорить о слиянии коммитов? В оригинале, справедливости ради, тоже так

Дело в том, что ветка -- это по сути и есть просто sha1 некоторого коммита. Опять же никто не мешает вам слить в свою ветку произвольный коммит, на который ни одна из веток не указывает. Мне кажется, что вполне понятно, что, когда автор пишет про слияние коммитов, он имеет в виду слияние двух историй, соответствующих указанным коммитам.

> Как насчёт такого 

Честно говоря, мне кажется, что стало менее понятно.
In fact, looking at the code in PR #952, I think it will *only* affect Python 3.
The license headers are missing.
What about pep8?
Sorry to be a pain, but the space is missing after the second `ByteVectorMirror`. Same thing (here)[https://github.com/taglib/taglib/pull/35/files#L14R117].
I'm not sure what anyone would do with it if we did pass it in.  It's being stored in `TweepError.response`, and any code that is catching a `TweepError` in an `except` clause can access it.

If it's passed to the `Exception.__init__()` constructor, it's accessible via `Exception.args` but what kind of client code would be looking for that (outside of an `except TweepError as e:` handler?)
Needs a space after the comma.
we should not actually bother setting up the scroller when there's just one image, as it's unnecessary overhead.
I think that is too much to take on for now.
p.s. I did a quick test of the first change (removing the focus/blur parts) and everything seemed to work fine.
It would be nice to have either help text or more descriptive text in the label/prompt. Unfortunately, I don't have any great suggestions for text here...
Any reason to use `ch: 1` instead of 0?  If you leave it at 1, please change the comment to reflect that this is the _end_ of the line, not the beginning.
I don't understand what happened here. Is this even working anymore? In my suggestion I was referring strictly to removing lines 13, 17 from your previous PR. Now switching into insert mode does...nothing?
Isn't it better to patch up the callbacks to accept Error objects instead? You're throwing useful information away now (the stack trace) and it's not idiomatic node (but perhaps it's idiomatic c9).
It doesn't have to be but it avoids some classes of bugs when the file contains multiple tests.
There can be multiple connections to the same workspace. As far as I can see smith agents only can connect to exactly one transport <https://github.com/c9/smith/blob/master/smith.js#L306>.

I don't see how this can work if you open the same workspace twice in different browser windows.
Ops, I have just removed it
Oh, obviously, why didn't I think of that... the ```StyleList``` always exist now. Anyway, thanks :-)
The next line, you expect ds not to be null. Consequently, it may be both more efficient and clearer to call ds.getDataSourceFactory.
Array.copy is needed here.
It takes exactly 1.854 seconds to check this in the code.
Changed `self.error(self.error_messages['bounds'])` to `self.error(u"Value is out of bounds.")`.
And all types of posts can have comments.
Same as above. Probably don't really need these, do we?
Could break if you ever add another button
Use `Popcorn.guid( "googlemap" )` and it will give you a better id
Does anything use this function?
`for( var i=0, l=_orderedTracks.length; i<l; ++i ){` -> `for ( var i = 0, l = _orderedTracks.length; i < l; ++i ) {`
This is because a newline at the end of the controls.html causes a text node, which is not ideal.

We contain this in a wrapper and just grab it.

This is a known issue and is on Bobby. For now we're doing it this way.
I don't think we want to send csrf tokens to unauthorized users... but now that I think about it, this call cause logging in to not work, right?
Change empty string to `null` or keep undefined. (You can modify this test case or create a new one to have both with null and empty string)
Good catch, that was a mistyped.
@thatch45 it's fixed :)
This block actually solves the problem I was having. The graceful handling of ```/etc/lsb-release``` followed by the use of that information as ```'osrelease'``` and ```'oscodename'``` with sensible fallbacks means this will work on Ubuntu without Ubuntu's custom patches.
Is that the convention for other ZFS code? If not, that style is, at least in my opinion, really a pain to work with.
can't we define this by using the listeners config in view.html for the plugin?
三个类型都是相关知识啦。所以不要这样一个分类。直接列为一项就好。
I think this has to be - git://github.com/ui-alchemy/alchemy.git
please add the visibility (public for test methods)
Not sure I understand this one. It is (

 bestPlan.resetPlanNodeIds(), right?)

done once for the final plan. bestPlan is the final plan for both union and
select statements.

On Fri, Sep 21, 2012 at 5:28 PM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/planner/QueryPlanner.java:
>
> > @@ -368,23 +456,10 @@ private CompiledPlan compileFromXML(VoltXMLElement xmlSQL) {
> >              }
> >          }
> >
> > -        // make sure we got a winner
> > -        if (bestPlan == null) {
> > -            m_recentErrorMsg = "Unable to plan for statement. Error unknown.";
> > -            return null;
> > -        }
> > -
> > -        // reset all the plan node ids for a given plan
> > -        // this makes the ids deterministic
> > -        bestPlan.resetPlanNodeIds();
>
> I think this only needs to be done once for the top/final plan.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665951>.
>
>
Agreed, maybe you can include this in the other `ConfiguratonItem` PR?
I'm still not fond of having two ways to do it: Rather than having both a getter+setter and a property, I would rather just the property.
Maybe another 4 arity version

```erlang
handle_work(Worker, Pool, Work, From) ->
    handle_worker(Worker, Pool, Work, From, self()).
```
I don't understand your question.  The 'catch' statement immediately follows 'try'; scroll down a bit in the diff.
How about something the first sentence from wikipedia?

https://en.wikipedia.org/wiki/Bitcoin
"Client for Bitcoin, a decentralized electronic cash system"
Return type is boolean not array.
Also I personally would prefer the method name to be `_isUUIDField()` as it more clearly conveys that we are checking the field not the actual value.
We're getting rid of the greedymarket too?
`\Callable`
TODO: change to `[[:alnum:]]+` regular expression
maybe we even should push expanding namespaces out to the rdf drivers (so the xml driver would expand them while parsing xml, and the array parser would process the passed-in array).

in #29 i propose the topic of improving the rendering, i think this is related. but for now i think the approach would be to expand everything and then make sure the entity has its namespace mapping so it can declare them and map back url to prefix back when rendering.
Perhaps change the title to 'Simple animations, progress bars and output area cleaning'?  I'd also suggest renaming the file to something slightly more descriptive, say animations_progress_bars or similar (casing up to you).  'Progress' by itself as filename is a bit cryptic.
On Thu, May 31, 2012 at 8:32 PM, Min RK
<reply@reply.github.com>
wrote:
> ...grudgingly ;)

No, I'm happy to go with it: I just want to make sure it won't cause
us headaches later on, based on the recent problems I had precisely
with a similarly named notebook with LaTeX conversion...  So if it
turns out that we can make the pipeline for managing them happy with
spaces, I'm happy to go along :)
ClaimSet is the "domain" name for the object as oauth docs refer to it as such. I kept emissionTimes and expirationTimes out of the map so that we could have typed access to these properties (they are mandatory and we can use these values for cacheing).
I misunderstood this -- please ignore.
Seems like this goes in the `if __name__` block too.
I really like the detail in this comment, but it makes me wonder whether this API call is needed at all. The whole point of an iterator is yielding object until it's exhausted -- there is no notion of the size of the iterator itself.

I don't know of any dynamic languages (certainly not Ruby nor Python) where Iterators have a size property that can be accessed. I'd be :+1: on axing this altogether.
On Thu, Jul 26, 2012 at 10:08:05AM -0700, Vicent Martí wrote:

> The `define` with the defaults makes my spider sense tingle. Instead:
> set the default automatically when any of the options is 0.

Yeah, we try to do it with all-zeroes initialization in git-core, as it
catches both static initialization and
`memset(&some_struct_containing_your_option, 0, ...).
Documentation.
The relevance model is a very important (and relatively public) part of the library. Along with the queries should be the part more carefully described.
this will be adjacent to the boost
I couldn't figure out why returning `undefined` wouldn't unset it completely. I think it worked when reading, but not saving. `""` should work fine though.
This line needs a colon, to make it "case COBBLE_WALL:"
We don't really, but I added it as I think it's the appropriate place for the real installation after we (hopefully) fix tower. You're right that it's superfluous for now. I could just leave a comment here.
Why is this taller than it is wide? The image seems square to me.
fixed exports + removed 1 unused require
Scroll down to "Formats"
http://www.w3.org/TR/NOTE-datetime

That's ISO 8601 and according to that the default format is **with** the `T`
You can merge this block and the line above it so the connection isn't checked out twice.
"Readium<sup>TM</sup>는 EPUB&reg;컨텐츠의 출판을 위한 국제디지털출판포럼(IDPF, International Digital Publishing Forum)과 지원 기업들의 오픈소스 시스템과 렌더링 엔진 프로젝트입니다.  자세한 내용은 <a href=\"http://readium.org/\">프로젝트 폼페이지</a>를 참조하세요. 지금까지, 프로젝트 개발은 <a href=\"http://evidentpoint.com/\">Evident Point</a>와 <a href=\"http://www.bluefirereader.com/\">Bluefire Productions</a>에 의해서 주도 되었다. 프로젝트에 기여하시기 위해서는 <a href=\"https://github.com/readium/readium\">github 저장소</a>를 확인하시기 바랍니다."

should be

"Readium<sup>TM</sup>는 EPUB&reg;컨텐츠의 출판을 위한 국제디지털출판포럼(IDPF, International Digital Publishing Forum)과 지원 기업들의 오픈소스 시스템 및 렌더링 엔진 프로젝트입니다.  자세한 내용은 <a href=\"http://readium.org/\">프로젝트 홈페이지</a>를 참조하세요. 지금까지, 프로젝트 개발은 <a href=\"http://evidentpoint.com/\">Evident Point</a>와 <a href=\"http://www.bluefirereader.com/\">Bluefire Productions</a>에 의해서 주도 되었습니다. 프로젝트에 기여하시기 위해서는 <a href=\"https://github.com/readium/readium\">github 저장소</a>를 확인하시기 바랍니다."
The whole deal with the "NEW" scene name looks like a code smell. Do we really need a temp scene name with a "NEW" and this kind of rename-biz? What is required to remove this logic?
Shouldn't this class be moved to the Translation component ? It depends on the Translation for the interface, but not on the Validator at all
I see your point, I didn't want to overwrite the $iterator variable so I had to use another name... the 'l' stands for 'local' I know it's unusual, I learned to use 'l_' at school and it's coming back from time to time... I will change it if you want :+1:
why using ``javascript:`` in the ref instead of using ``onclick`` like in other places in the profiler ?
`return $this;` ? - fluid interface
i can reformulate it when fabpot changed his mind about this pr
It does not. It is either an EngineInterface or Twig directly (to allow using it with Twig without the Templating component and the bridge)
I'll do that.

--
William Durand | http://www.williamdurand.fr



On Wed, Dec 5, 2012 at 9:41 PM, Christophe Coevoet <notifications@github.com
> wrote:

> In src/Symfony/Bridge/Propel1/Tests/Fixtures/ColumnMap.php:
>
> > @@ -0,0 +1,61 @@
> > +<?php
>
> @woodspire <https://github.com/woodspire> If what your class is accessing
> is only the TableMap, you won't need to mock other stuff. The goal of using
> mocks is to avoid having to build the full dependency graph. You only mock
> the direct deps.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony/symfony/pull/6150/files#r2326592>.
>
>
Well, augmenting artificially the code coverage is a bad idea IMO
Can revert this hunk? I think you can do this like:

    git checkout -p -- src/Symfony/Component/Form/Tests/FormFactoryTest.php

and then only select this hunk.
symbol で書くのが推奨されてます
I've implemented your suggestions. Removing the noise caused by wrapping the sets in Option[...] and not passing around the decoder in the Defragging class cleaned up the code a lot.

The changes actually reduced the amount of cases by 1, but I think it did result in more understandable code.
Looks like this could be double quotes.
I've moved toward named parameters(when more than one) to avoid dependence on parameter sequence.

See this pull for examples: https://github.com/yammer/sched.do/pull/208
There is still a conflict here.
TODO info should be removed/overlaped.
One particular example I can think of off the top of my head would be the case where the user wants to check whether the split view is horizontal or vertical. Know what I mean? Lots of possibilities.
Why is Main.h needed here?
I don't think this test is actually triggering the new code.

I commented this line out and didn't get a warning. So then I explicitly checked if the TopologicalError error was getting raised and it wasn't.
I suspect we can yes. That would definitely be preferable.
Suggest *_Img_attribute_names* for clarity, but this is non-essential.
How about "nonce range" vs "full work"?
Sorry to nit-pick again. But it would be nice if this file could be changed to adhere our published style for documentation:

http://docs.django-cms.org/en/2.3.3/contribution.html#contributing-documentation
What about about avoiding function body and finding process from outside?

This could work but a bit hacky :godmode: 

First you do `super` call to create, then you inspect functions local vars:
```
values = super(KitchenDot, self).create.func_code.co_consts
```
Then you need to find process..
one class per file, please
I'd rename this to just `ROLES`. `User::USER_ROLES` is like `Car::CAR_ENGINE`: redundant.
j'ai extrait la création du keyspace dans un builder externe
We need to also add CACHE_LOADER_STORES (from the CacheStoreInterceptor)
For stateless and singleton beans yes. For stateful beans and EE managed beans, I don't really think so.
Like this? https://gist.github.com/c5faba40bb09b2b30f3a
@ukanga we're keeping all our urls in /urls.py
general comment about caching elements
Right, that's because of the header... but I don't see why others can't have the same for consistency :) Adding that
* please keep the full application name, `homescreen.en-US.properties`
* do not copy the en-US strings to other locales
* do not add `[language]` sections for locales that aren’t already translated
nit: inverse the logic
I think botio will let you put this in one line without he extra `+`
Shouldn't we be recursive ?
It looks like we won't translate `apps/communications/dialer/index.html`.
`ls()` accepts a second boolean argument that makes it recursive.
useless variable? there is no localized string assignment.
Remove this if you are using a new id
This is invalid: the label’s `for` attribute doesn’t match the input’s `name` attribute.
Can you use l10n for the strings?
@basiclines Thanks!
Please, indent this element properly.
As I already asked in #5766: please replace `...` with `…` (ellipsis character instead of three dots).
Indentation seems wrong
This isn't right. This needs to be refactored in the same way that MemoryMapState is.
Yes there is: http://www.openstreetmap.org/browse/relation/47798 (contains outers inside an inner) As multipolygons are also used for boundaries, this needs to work to.

Or look at the boundary between India and Bangladesh. A lot if nesting with inners and outers there.

or for a non boundary see http://www.openstreetmap.org/browse/relation/1312591
Should this also appear in the platform config file? It looks like this was the only place we had this directive.
It is stored as string from the CLI/API input and in the DB. I should have never compared to the int in the first place.

Only reason I did was because the new method was setting an int. But that is always overridden by the Slice.

Since the vast majority of the time this will be a string in the key/val to_s is only needed should it somehow get set to int before object persistence. I could have set just @maximum_count == "0" but the to_s is a safety net.



-- 
Nicholas Weaver
EMC Corporation


On Wednesday, June 20, 2012 at 10:38 AM, Nan Liu wrote:

> > @@ -56,7 +56,7 @@ def current_count
> > end
> > 
> > def is_under_maximum?
> > - return true if @maximum_count == 0
> > 
> 
> 
> Should we compare .to_i or is there some reason for compare .to_s ?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/Razor/pull/81/files#r1018668
> 
>
另外，可以考虑为某些特定的功能加独立的 api。比如：
rs.cropAs(key, url, opts)
其中 opts 可能包含这些参数：x, y, w, h, gravity。比如：
rs.cropAs("foo-crop.jpg", source_image_file_url, {w: 64, h: 64, gravity: "center"}, function(resp) { ... })，这表示要在原图的中心裁剪出64x64的图片，并保存到 foo-crop.jpg 中。
这个函数内部实现通过调用 rs.saveAs 实现，是 imageMogr 的特例。
I find it incredibly confusing to have nested conditionals inside this conditional...it's an `if` with an `unless`, and `or` and another `if`.  I can't parse it in my head :(.

Can you pull this out into more explicit, readable logic?
Do we have a specific use case at the moment? Or can we do this change separately as soon as we identified how the API should look like for a user.
Headers, multiple paragraphs, extension blocks inside listItem. Need some comment on this testcase!
I added in an example. This requires some investigation, discussion, and an agreed upon convention for cross process communication.
Not sure actually. It was code taken from previous implementations.
We need to handle this cached value.
Ah cool, maybe something relatively recent.
Sorry that was copied from SHKiOS5Twitter. I just realized Sina Weibo use #hashtag# this way (prefix and suffix with '#'). I have updated it.

Since Weibo allows spaces, Chinese characters and other characters I removed the character set check. Guess it would work fine.

I have tried posting to Weibo with this change and the result was correct.

Thanks,
Man this @Sleaker guy can't ever get things right...sheesh.
Should now be fixed with commit cbe5579
<pre>
          File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/status/web/base.py", line 56, in <module>
            FAILURE-AGAIN: "failure-again",
        exceptions.NameError: name 'AGAIN' is not defined
</pre>

You would need to use an underscore (`_`) to make that a single Python symbol.

But this particular dictionary is for mapping build status codes to CSS classes.  `FAILURE_AGAIN` is not one of those codes - nor should it be.  It's entirely invented by the console, so the diff in `console.py` should be sufficient.  So you can just remove this line.
Hm, I think if I place all the open delimiters (`(`, `[`, `{`, etc) in an "or" expression, then the open and close delimiters won't necessarily match up. For instance `%r(regex]` is a match.
This test needs a
`mediator.unsubscribe 'matchRoute', spy`
at the end.
Why should use hard code of .ttc file path here ?
Will using 'pFontName' cause some issues?
Just to make it clear, have you already experienced some real life issues with `class_exists()` and APC (or you _think_ there could be some issues) ?

I have used `class_exists` because:
- the changes were simpler and I had to work fast,
- `class_exists()` is [already used](https://github.com/vicb/composer/blob/963fedc9a5b30bbc5c08e1ad8dc2c7b64f02ec48/tests/Composer/Test/Autoload/Fixtures/autoload_target_dir.php#L4) in the same file
PHP manual tells me that "On seriously malformed URLs, parse_url() may return FALSE."
Huh ? First casting to array and then telling user you expected string or array ?
You're right. I can't replicate the issue I was having before; it must have been something else. My mistake, I'll cut 'em.
Maybe instead of USE_INSTRUCTION here and in the lock code, FORCE_32BIT_INSTRUCTIONS or something similarly generic sounding?  I don't like the instruction name being used in the define as it doesn't tell much information as to the reason you might be using that instruction.
I don't think the regex in sasl picked up on my errors and (showing my ignorance) I don't know sasl wasn't different from smtp. Consider it an OSX version for sasl.conf regex.
make <a> a <span>
followon from previous comment.  is assertion.sign() guaranteed to invoke its callback argument after it returns?  if not, then this is a regression that could cause the "javascript is taking too long" errors we've seen on slow browsers (read: IE8).  Given our reduction of key length, this might no longer be an issue, worth the comment tho.

my preference is to have all apis in jwcrypto guarantee that callbacks are not invoked before the function that they're passed to returns.
It's part of the logger code and shouldn't exist in main. Also with a setter we can avoid code duplication of creating the directory.
Nit: It's easier to diff changes when the text hard wraps around 80 characters, but that's just for future knowledge. This is fine to merge ^_^
wow?I think yes, we should remove these lines.
no need for this extra line
As before, these should be improved.
As much as I dislike comments, this might warrant one about why master and agent need to be excluded.
Does this mean that CheckDependencies() -> check_dependencies()? Am I reading that style guide correctly?
debug function is not even defined in -O mode, so would crash without if __debug__...  how much of speed up it is -- not sure, and to say the truth even I myself rarely run in -O mode since quite often want at least some output. 

but that is how all code is now so we better follow it until we decide not to and RF it
@param device matched with item[ "hwinfo", "dev_name"]
@return index in Items or -1 if not found
If each Issue has an attribute indicating the level then I think I'd prefer the Profile#check method to just return an array of issues.

Any user that cares about levels can filter the array to get the issues they need.
On my branch the 1.8.7 didn't pass, and 1.8.7 is end-of-life. That's why I thought to disable this
Hm, I googled for about 2 mins and didn't find anything relevant for accessing environment variables (like `$HOME`) in nginx config file... I guess we'll have to settle with `sed` then.
Why does the oldVersion include "4.0.0.0" too?
Do you mean they're dangerous if the database is currently being actively used, or in some other sense?

Well, these execs complete the MMM setup; if we have to complete it manually, this kinda defeats the purpose of using Puppet to me :) What do you think?
This line should be indented to align with `$title`. Also, you don't have to wrap the lines until you get to 100 characters.
@mehlah is correct here.
Only if a logical split between the base model and actual models. I can remove it, if you want.
We've been standardising elsewhere on the environment variable GOVUK_ASSET_HOST. Might make sense to use that here too as it should be correctly set in VMs if apps are started with govuk_spinup
Indeed, I only tested this one on native platform.
I suppose we should add a posixish time() call instead for RTC time.
Any platform with an RTC should be able to provide the required info, but I don't have any plan yet.
Maybe when I or someone else finish the ORIC port...
Didn't remember, just tested : it only shows the seconds dot, others are not implemented, and I should probably check the calculations too.
This is pretty magical. Would it be better to have:

CACHE_ID = getattr(settings, 'COUCHEXPORT_CACHE', 'default')
just had a look at orm, and there its called HYDRATE_OBJECT - i think we should use the same name here to be as consistent as possible. also i wonder if we should use numbers instead of strings, and the same where applicable and distinct for non-applicable like PHPCR_NODE. /cc @beberlei, @stof
See comments re: `Article.voted_on_by(user)`.
Nie je toto dead code?
Why is a version > 1.5.0 needed? Would it be future proof to do some feature detection instead?
Fixed. And pushed.
If we make this method `public` we can remove code from `ConnectController`.
@michaelficarra You're right; that was an unnecessarily sardonic comment on my part. I apologize.
s/s/so, s/mark/marks, s/Bedroc/the Bedrock