labofsahil/github-event-dataset-2012 huggingface dataset:
I tried without *.present?*, I had the above failure, and @stale_state was an empty string.
And If I tried with *.prensent?*, some another testcase were a failure. In all cases, @stale_state was an empty string.

```
  1) Failure:
test_setting_foreign_key_after_nil_target_loaded(BelongsToAssociationsTest) [/home/kennyj/rails/activerecord/test/cases/associations/belongs_to_associations_test.rb:344]:
--- expected
+++ actual
@@ -1 +1 @@
-#<Firm id: 1, type: "Firm", ruby_type: "Firm", firm_id: 1, firm_name: nil, name: "37signals", client_of: nil, rating: 1, account_id: nil>
+nil


  2) Failure:
test_has_one_through_belongs_to_setting_belongs_to_foreign_key_after_nil_target_loaded(HasOneThroughAssociationsTest) [/home/kennyj/rails/activerecord/test/cases/associations/has_one_through_associations_test.rb:300]:
Failed assertion, no message given.

  3) Failure:
test_validation_does_not_validate_stale_association_target(TestDefaultAutosaveAssociationOnABelongsToAssociation) [/home/kennyj/rails/activerecord/test/cases/autosave_association_test.rb:359]:
Failed assertion, no message given.

3366 tests, 10247 assertions, 3 failures, 0 errors, 10 skips
```
Also `value && value.change(:usec => 0)`, thought it might be more clear to just do:

```ruby
return unless value
value.change(:usec => 0)
```
Okay, sorry once again. ;)
Not it's not: `save` is a local variable.


2012/11/9 Carlos Antonio da Silva <notifications@github.com>

> In activerecord/lib/active_record/associations/has_one_association.rb:
>
> > @@ -28,7 +28,7 @@ def replace(record, save = true)
> >          # If target and record are nil, or target is equal to record,
> >          # we don't need to have transaction.
> >          if (target || record) && target != record
> > -          reflection.klass.transaction do
> > +          transaction_if(save) do
>
> Isn't that triggering an extra save call here, that might be unwanted? Not
> sure it will affect anything, haven't looked further.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rails/rails/pull/8154/files#r2081853>.
>
>



-- 
Bogdan Gusiev.
agresso@gmail.com
I think we need a migration for this? `IntegrityError: (IntegrityError) status.project_id may not be NULL u'INSERT INTO status (created, user_id, project_id, content, content_html) VALUES (?, ?, ?, ?, ?)' ('2012-09-27 10:07:49.539522', 1, None, u'woot', u'woot')`
Dropping the braces doesn't have anything to do with it; it is about indentation.
Ok, I'll do that. I was a bit reluctant to claim this "straightforward" name.
Sorry, it was later commit, maybe the pull request has added it automatically.
If this block is commented why is it still here?
I have elected in this case to define a matrix M which is the needed 4x4 matrix and then insert M in place of the matrix define. This makes one new line above and a shorter line in the raises(....).
As the `__mul__` in `CurvedRefraction` class was changed and `ThinLens` 
is only two of `CurvedRefraction`, thus it is logical inheritence like this.
`typed` is imported but not used.
that's interesting...using simplify gets close.

```
>>> simplify(eq)
-log(-12*sqrt(2) + 17)/24 - log(-2*sqrt(2) + 3)/12 + sqrt(2)/3
```
I'll use igcdex for now, and wrap it to do the multi-argument version.  I can use standard-like names (migcdex and ipartfrac) so if somebody else has the idea in the future, they won't have a hard time finding these?
On 10.04.2012 22:24, Sergiu Ivanov wrote:
>> +        remove = set()
>> +        for (a, b, c) in permutations(S, 3):
>> +            A = sdm_LM(a)
>> +            B = sdm_LM(b)
>> +            C = sdm_LM(c)
>> +            if len(set([A[0], B[0], C[0]])) != 1 or not h in [a, b, c]:
>> +                continue
>> +            if monomial_divides(B[1:], monomial_lcm(A[1:], C[1:])):
>> +                remove.add((tuple(a), tuple(c)))
>> +        return [(f, g) for (f, g) in P if (h not in [f, g]) or \
>> +                    ((tuple(f), tuple(g)) not in remove and \
>> +                     (tuple(g), tuple(f)) not in remove)]
>> +
>> +    while P:
>> +        # TODO better data structures!!!
>> +        #print len(P), len(S)
>
> All right, I wasn't aware of that :-)
>

One thing to keep in mind is that I am by no ways an authority on sympy 
code. I can tell you things I know, but you will notice that seldom I 
claim to know how things *should be*.
If the base is I/-I, it's not imaginary. The only time you can say anything about imaginary**imaginary is when the base ``== I``.
these are not valid. please run your code through gjslint --strict.
The first "git" tells Maven SCM which SCM implementation to use, the second one tells the Git implementation to use the Git smart protocol. See https://maven.apache.org/scm/git.html.
According to PSR-2, there should be a blank line before a return statement if it follows another line of code. So just insert a blank line after the CookieUtil call.
I might want to implement both, I need to make sure they are organized in some cases.
It actually seems like none of this serializer code belongs in the serializer.
I disagree with changing the name to `AngularCoordinates`. Instead, as you say, this function should later be enhanced to generalize the concept.  In that case, users should still use the same function.  Having a variety of factory functions is rather silly, because if we do that we may as well drop the factory entirely and just tell everyone to use the classes entirely (which I agree is awkward in some contexts).
> Calling `start` directly from the `begin` callback will not work as at that point neither `init` nor `load` has completed (`config.semaphore` will still be undefined), but the next tick after the `begin` event, both `init` and `load` are finished.

Registering a `begin` on `begin` actually `start`ing works fine - http://jsbin.com/apodor/1/edit (might not be intended, but this currently works, at least in Firefox 17). And yes, it will run the test before init completed. Translating that to your proposal: http://jsbin.com/apodor/2/edit - everything looks fine.

So again, the question, should I make the changes?
Removed. No needed.
I think this should be demoted to TRACE level logging and protected with an

```
if(logger.isTraceEnabled()) {
  ...
}
```

block.
I think this validator class might need a line or two of comments to say what it does.
I would just say "ensure that the journal directory is on a different system."
Same here, better test would be without the space (or a mix of both)
p/phpbb3#20
Use `$style_id` instead of `$temp` or something like that. Cast to integer.
This looks dangerous. I would prefer an error or an exception instead.
"you wish to data" => "you wish to **delete**"

"files and clear its data" => "files and data"
This naming needs to be improved. It does not give the paths back to the caller, so maybe it should be called `import_finder` or something in that direction.
Should probably also have a return statement here.
@p it would help if you explain what you would see as "sufficiently clear". To me it is more then clear what is going on here.
Please keep the upper sentence:

> This one is a bit of a holy war,

I still think that by stating that, ppl can understand better that this is just something that was decided for phpBB and that it has already been discussed. Talking 'bout myself, reading like that makes me think that it's useless fighting that it was decided by preference because there's no standard defined.
we are not going to add the collector modules to monitoring.zip
Guess that can be removed :)
FWIW, Rubyists generally don't put parens on method defs that take no arguments.
Although it may be slower with larger `char_count` values you could try something like the following to avoid 0-padding:

```ruby
min = 36 ** (char_count - 1)
max = 36 ** char_count
(rand(max - min) + min).to_s(36)
```
StatisticDao - camelCase, должно быть statisticDao
should be wrapped in curly-braces
I think it boils down to the question whether we want to assimilate 3rd-party code, or whether we want to keep it as pristine as possible. The files in mvpa2/support/bayes are pretty much in their original form -- just stripped off the bits we do not need. The name collision is a none-issue IMHO as this code doesn't get imported in mvpa2.suite. I don't mind changing names, but at the same time I also don't see the need -- same for encodings.
As male/female/other is already in registration, let's keep this for now so all code is uniform.
Here In Util file I added vishnus code so might due to that it got removed,
I write it back agin..
把 type="text/javascript" 全部去掉。
The indentation of the comma seems off.
Thanks for the report. You can report problem like this when they are related to some lines. You can also use the mailing list.

I just made a new PR that fix this problem as this PR was merged.

Until it get merged, you can just use device=gpu0 instead of device=gpu and the trunk should work.
You need to add the __hash__ and __eq__ fct. Otherwise duplicate equivalent apply node with this op won't be merged during optimization.
Maybe call this `decode_vc` to be more consistent with other changes?  (and `pbify_rpbvc` to `encode_vc`)
Ничего магического, просто эти значения используются для раскрашивания нод.
Yes, these are safe defaults - having them set like this will, at worst, make migrations a bit slower on a new backend, but having them set to the other values will cause syntax errors. Given that the pattern currently involves defaults being set for everything, I think this is a good match.
no need to use ``else`` here as the ``if`` returns.
Ok I'll remove...
Same thing here; please change this to a comment.
On 08/29/2012 05:41 PM, Luigi Panzeri wrote:
> In openquake/calculators/hazard/classical/core.py:
> 
>> @@ -35,6 +35,10 @@
>>  from openquake.utils import stats
>>  from openquake.utils import tasks as utils_tasks
>>  
>> +from openquake.utils.task_handlers import CeleryTaskHandler
>> +from openquake.db.aggregate_result_writer import AggregateResultWriterFactory
> 
> I know that paper very well. Factory are not considered a code "smell", but they are just not so common as proposed in the GoF book. In python they can be implemented in several ways, because classes are callables and can be passed as argument. If you prefer another approach to implement a factory in python, I can do that change (e.g. by using a dictionary, or just by passing as argument from the caller).
> 
> Factories are used in several python projects, e.g. Django and Celery, two big projects we are relying on.
Not quite.

    usc4 tmp $ apt-get source python-celery
    Reading package lists... Done
    Building dependency tree
    Reading state information... Done
    Picking 'celery' as source package instead of 'python-celery'
    NOTICE: 'celery' packaging is maintained in the 'Svn' version control system at:
    svn://svn.debian.org/python-modules/packages/celery/trunk/
    Need to get 903 kB of source archives.
    Get:1 http://ch.archive.ubuntu.com/ubuntu/ precise/universe celery 2.4.6-1 (dsc) [1,812 B]
    Get:2 http://ch.archive.ubuntu.com/ubuntu/ precise/universe celery 2.4.6-1 (tar) [892 kB]
    Get:3 http://ch.archive.ubuntu.com/ubuntu/ precise/universe celery 2.4.6-1 (diff) [9,229 B]
    Fetched 903 kB in 0s (10.5 MB/s)
    gpgv: Signature made Tue 03 Jan 2012 07:15:56 AM CET using DSA key ID C5E95333
    gpgv: Can't check signature: public key not found
    dpkg-source: warning: failed to verify signature on ./celery_2.4.6-1.dsc
    dpkg-source: info: extracting celery in celery-2.4.6
    dpkg-source: info: unpacking celery_2.4.6.orig.tar.gz
    dpkg-source: info: unpacking celery_2.4.6-1.debian.tar.gz
    dpkg-source: info: applying fix_dependencies.patch
    dpkg-source: info: applying intersphinx.patch
    usc4 tmp $ grep -ir factory celery-2.4.6/
    celery-2.4.6/contrib/supervisord/supervisord.conf:supervisor.rpcinterface_factory = supervisor.rpcinterface:make_main_rpcinterface
I agree. I've never fiddled with the SSL version myself -- this is a holdover from the CurlSslPlugin idea, whose goal was to allow a plugin to adjust all the SSL-related settings.

The most common need is around CA, verify peer and verify host. I'll update this now.
If gtable has vp, then it does not have a chance to create layout.
This need an equivalent in `down`.
Calling a text representation of the sparse vector a hash_key seems somewhat misleading.
Where do these 8 + 2 come from?
It is only

```sql
ret = string_to_array(lower(csv_str, ',');
IF array_upper(ret, 1) IS NULL THEN
    RETURN NULL;
END IF;
```
s/open source/open-source/
Maybe the second one with some default lambdas for the mapper and reducer function?
Only use one checksum. Also, don't use MD5 as an arbitrary tarball with the same sum and different contents can be forged in a matter of hours.
You should keep data_object(obj) around here and check the class of that. Same with below.
I think it would be better to also use `executor` here. It would be more regular to always complete promise `p` on the same EC. And I don't see a reason not to use `executor`. If `executor` is good enough to run `f(v)` and `p complete resolver(t)` on, then it should be OK to also just complete `p` on it.
That stuff should go into python-smpp eventually, but making it clean is more work than we have capacity for. See dmaclay/python-smpp#6.
Слишком много "вы", давайте напишем второе преложение так:
"Вы можете слить (merge) её в одну из своих веток или вы можете перейти на эту ветку, если хотите её проверить."
This isn't actually the cookie, it's the cookie configuration object
Curious why you are using `Hash#delete` here and throughout.
Does the API definitely return a string here?
If this fails then it looks like processing will continue with no warnings or indication that the RADMON history file was missing.  It's a little hard to tell since the whitespace is still messed up in the github diff.
_rendered (?)
Is an empty string appropriate or should this be `null` or `false`?
I think likewise here, simply doing `this.mediaHandlers[this.item.media.type](this.item)` will be sufficient.
Checking for "this.closeOnSelect === false" is dangerous. It only works because no other type defaults to false. If someone were to add some other kind of hinting (which is what we encourage) then this cold break.

We need to check for something reliable like (attrInfo.type === "url").
``{!function(*,*)}``
Oops. I didn't realize this was equivalent to `preventDefault()`. I'll reinstate them.
I think the "same name" part of this message is out of date.  Looks like it's only checking the id (which makes sense to me).
Following the call to this function in LiveDevelopment.js are chained .done() and .fail() calls.
Since we have this simulateKeyEvent() utility now, would it be cleaner / more consistent to use it here too?
Some of these calculations seem a little fragile: the format might not always be a number plus 2-char unit (could also be "normal" or a percentage), and 1em is not always == 10px.

Although CodeMirror's textHeight() isn't public, I wonder if it might be safer to borrow from that approach (or even just make it public? -- but that's trickier since it requires a separate patch to CodeMirror).
please add `|| "Untitled"`
there's some pretty odd coupling here between this function and the functions that on the surface just look like getters. i don't think it's a big deal since this is likely only used in one place, but a bit of renaming (or docs/comments) would probably make it more clear how this works.
I changed (and rebased) the implementation according to my previous comment.
Actually, the best thing is if `coaster.app` provides a derivative of the `Flask` class that has `init_for` as an internal method. That's far cleaner.
Move this above the model imports. Those *always* come last in an `__init__.py`.
Well in Netbeans Format works on the current selection as well ;-)

As for the GitHub diff, protip: if you add ?w=1 to any diff url (eg the current one https://github.com/irstv/orbisgis/pull/8/files?w=1) you see the diff with all withespace changes ignored :-)
This does fuzz testing, setting random fields on events and checking the results.  It compares MapEvent and ArrayEvent implementations, and also tests [de]serialization.
sl?
options.style = options.style || "";
Why make this a function? Why not just put the code in this block?
Does `shims` need to be here anymore?
Can we move this out to be some consts? Magic numbers are bad.
The comments shouldn't be inline
No space in ...`spinner"></span>`
why not just none
Depending on whether lighthouse 1082 lands before this or not, we should nuke this new config file
Line 944 in the viewer is ``//    },`` and has no extra space
This file actually depends on layer.exports, which is a problem;
@jcredding its because I'm using a string as the second arg to `gsub` and backslashes have special handling there.  See this for a rough explanation:
http://notetoself.vrensk.com/2008/08/escaping-single-quotes-in-ruby-harder-than-expected/
It's an imul and xor of a difference, but I can add default `hash` implementations if you wish.
This should be config.getNode("perms.officer"), no?
Is adding a ```<BR/><BR/> ``` a good idea in 18n text ?
Changed to

  def self.index_settings
    {
        "index" => {
            "analysis" => {
                "filter" => Katello:Search::custom_filters,
                "analyzer" => Katello::Search::custom_analyzers
            }
        }
    }
  end
so, in this case this is an intentional shift of the hash ...
Is your convention to use camel casing on method names, but underscores on variable names?
C: 38,0: Operator not preceded by a space
```
REPO_FILE="/etc/yum.repos.d/katello-local.repo"
         ^
```
Given the recent changes in notices, are there any that may be created as a result of an API action?  (e.g. changesets, repo syncs...etc.).  If so, will organization be set properly?
I agree. Will test and verify that it still works later. 

But what's the best way to proceed? accept this and another pull request, or reject this and another complete pull request?
We never get in the LockScreen.update callback on the desktop build.
Sadly I have not found the cause.
whoops, yes, you're absolutely right!  I'll fix that now.
Question: I wrote this so that the extension ".xml" isn't enough to have the Table code automatically write out a VOTable file -- that is, the format needs to be explicitly set -- because "xml" is so generic.  We could have this trigger on `votable.xml` (though I'm totally making that up) or `vot` (which I've seen in the wild), but most of the time people use `xml` for VOTable files.
In the riak_core.app file, and in default_choose_params/1 this is target_n_val is 4 (https://github.com/basho/riak_core/blob/a73fcfda4a819c19eac2f93d3d71f0aa8b60158e/src/riak_core_claim.erl#L247) though the docs at the top of the file do say default target_n_val is 3…
You should also update app/Config/core.php.
Also, take a look at this  comment
https://github.com/cakephp/cakephp/commit/b75a6b440abfbaf7af3ef82dd19eb4aff4be5847#commitcomment-1773097

and the _outdated diff_ from this very same PR
Ok, good way :-)
That's left over from an experimental change earlier on, feel free to fix it at the source.
Added new named key to the Keys literal
I don't understand why you have a test skipped conditionally here
Use "null" (lowercased) here
Yes. I thought about this point in a subject of ORM QUeryBuilder::addCriteria(). Same is with ordering and maxResult i guess. But for each value there are different  use cases:
$firstResult = null can be used for "undefined"
$maxResults = null is for "no-limit", so it is  still a problem how to overwrite with merging
$orderings = null can be used as "undefined" but it's realy annoing to always test that it is not null when working with it.

It all depends on what we want to say with criteria properties and the way of "merging": overwrite or combine.

I will revert this defaults for now. But i think this points should be cleared.
the naming is crappy. According to the implementation, it will be set to ``false`` to ignore them, and to ``true`` to **disable** the feature.
I do not get this. You can pass `'vendor/Symfony'` or `'vendor/Doctrine'` or whatever else. That's why `$includePath` is an `argument`.
This should be changed to "Then the proposal close date should change"
A search engine crawler uses the default language for crawling the page. This is the only time the search engine wil redirect, but that way you have duplicate content. (fork.dev/en and fork.dev) The other languages could never be the duplicate content of fork.dev in the search engine. A normal browser doesn't care about duplicate content, so there it is not a problem.
This is checked with an SEO expert.
This should be `LaTeXTool.instance(config=...)`
rename(id, name) would help people understand what this is doing.
AFAIK, we no longer have a community programme asking for mirrors
There's an extra dash in bg-sand.png
Everything in this file is good.
so here's the idea:  these values configuration values get called thousands of times in loops.  While dictionary lookups are fast, why do more than necessary?

By saving the value in the instance, referencing it involves looking up 'self' in the local scope, then '__dict__' in the instance of the object and then finally 'dump_suffix' in the instance dict.

By leaving it in situ, I have the additional lookup of the 'config' object in the instance dict.  i'll take any optimizations I can.  

Or is this just silly?
Oops! Right I forgot (this is only used by vagrant and for reference, but I still want it to be right!)

I reverted this change and noticed a couple other out-of-date things in here, now fixed.
In the `__init__` in the super class (`TransactionExecutor`) the parameter `abandonment_callback` is **optional** so when called here it should be: ``abandonment_callback=abandonment_callback`` instead.
… corresponding to the ontology notions of ExactMapping, WeaklyExactMapping, … – anything else?
No, but it will take some time to create new OBS repo for gloves, as renaming is not possible there (AFAIK).
I believe this file is not even used any more. Let me double check this.
This has been moved down a dozen of lines, where its need is apparent. (happened in the initial set of commits put on 2.2)
The initial default router is for blog name of "blog" .. this can be changed to any name or left blank in which case new routing is created dynamically
these lists are raw  . . . I think you want a List<String> or something
indeed that's not needed
Your default case is broken: it will not respect the contract of the method as it will not return a CacheContainerInterface
shouldn't you need to return false if not loaded?
Three lines above seems to be invalid result of rebasing =)
Please remove this extra empty line
... is called `without` a matching call ... ?
In regards to the dependency: If it's not used in a core class but only in an Interface, it doesn't make HttpFoundation required.
Ah, now I remember-- so the details pane displays info for "current" job. Definition of "current" job is somewhat fuzzy. Here's a partial list of desired rules:

- On `JOB_STARTED`, select started job, unless a job has been selected explicitly by user within last N seconds.
- On `JOB_FINISHED`, select "next" job if "current" job is the job which just finished. Definition of "next" perhaps should be "job with smallest index which is currently running".

The commented out code might have been an attempt to get the second criteria working, but it's not quite right. I'll try and fix.
[Fixed](https://github.com/umpirsky/wisdom/commit/a1e90815a9e1b0ae189ca8bc49344b8d305772eb), thaks.
There should be no need to add new imports to this file - if nothing else is changed in this file.
resources :dashboards должно быть достаточно
I suggest precomputing the "constant" 1/(sigma sqrt(2pi)) and 1/(2sigma) in the constructors.
The link the ref looks empty on my doc
This has the possibility of raising a KeyError. For instance, if you have two expired E:lines, upon the removing the first one it'll check E:lines again and remove the second one (causing some nasty cascading), and when the recursion ends, the second E:line will no longer exist in xlines, but it'll still be in the expired list. So we go to remove it and BOOM - KeyError.

Basically, should remove all the expired masks FIRST, then call removemethod.
Should throw javax.persistence.PersistenceException instead
Will do, just have to find the commit.
These should map to class instances (some codes will have specific parameters).
no - that can come out ... thanks.
I'm curious, what happened to `requires`, was it redundant?
Note: This test is incorrect! It should be "south".
Didn't mean for this to be here!
 - Remove it
When I mentioned it to ngzhang, he said it was a known issue in the USB-UART chip, affecting only some USB hosts.

There is no evidence the workaround has any performance impact. With #175, it's almost guaranteed not to, since the Icarus is busy scanning hashes during the reopen.
not necessary, default action
Manifest is a resource root level attachment. You have to make sure that the new exploded resource root preserves this and any other attachment that may have been added before the re-mount
do it the OOP way. use polymorphy:

you should here call an abstract method of GraphView with all parameters you need.
In BarGraphView you implement that method the one way and in LineGraphView the other way round.
Wow, that's annoying that we have to deal with this even after removing the role.
Due to `Desktop` is not working properly, please add the following:

Line 7:
`prepolulated : false,`

Line 23: 
`if(!navigator.mozTelephony && !self.prepopulated){
    self.prepopulateDB();
}`

And you will have Desktop again! (Better for testing & reviewing)
mouseup/mouseup/mouseup/mouseup indent on the second line sounds broken
I think we can remove `break;` here.
Use l10n-id.
Um, it looks like you're re-implementing window names here.

Do things not work if you don't do this?  It should Just Work, and if it doesn't, that's a platform bug.

You can't really do this correctly as-is.  For example, if I submit a form with a named target, this code will drop the POST data.
you're right, I took the wrong one when fixing rebase conflicts, fixing
I'm not entering reviewing this because the file needs a complete review and it is only there to hold the First Time Experience. There is a lot of code repetition that will be removed as soon as implementation of FTE begins.
oops I see you added TESTS= below
This is BTW another example I was just requested to implement using ConfirmDialog where action1 and action2 are note Cancel and Confirm but Cancel and Settings: https://www.dropbox.com/s/9r1iwp8ud2huj2i/OWD_00_airplanemode.png
Hmm. I think that for blobs, PlayerView.play() doesn't actually start playing the song.  Its a UX decision, but I would have thought that the user's tap to open the file should be enough to know that they want to hear the song, and that you should start playing automatically.
Yeah, I would say I included it in the latest version plus some other refactoring... ;-) Thanks!
Agreed. I copied this line from an old commit without thinking.
by 'CompositeMetric' I mean a Metric who's .update(new-val) method expotrs multiple <name, value> stats in the __metrics stream.
ideally, the qbrowser target should set the app bundle name.  It is possible to change the OUTPUT_NAME, but this changes both the executable name and the bundle name. I'll have dig around to see if it's possible to have a separate executable name and bundle name.  If not, then the CFBundleExecutable in the plist will have to match the OUTPUT_NAME used.
This should not return window.history.state but rather increment state.
Did you choose to remove the $tieBreaker parameter? If so, why?
I don't think so. A pattern matcher where all patterns are `_`  with a guard are not my thing.
We should leave it for now and change it in a separate chore.
If this isn't used, then erase this argument.
I added in user_passes_test decorators to ensure that only superusers can access superuser views.
You don't need to make this a list, in general set() walk, talks, and sounds enough like a list.
isWebkit?
Comment then?
Oh well, the thing is that this script needs a major overhaul anyway, for now it is just issue solving, and keeping the variables out of global scope :)
:presence => true 
must be removed. What if i want create short issue? I don`t want fill field description in this case.
If we only parse options for ret == 3, shouldn't we just update the above error check to if (ret != 3) ?
PEP8 says 2 lines between top-level functions. Please run `pep8 -r` on the file and fix anything.
Nit: Quoting in Markdown is done with backticks rather than equals signs.
I would rename to `isRecognizedDirectory` or `isSupportedDirectory`. Acceptable feels to harsh to me.
Is `and` expected here?
this is just a sanity check, and it's not strictly necc.  it's an attempt to die loudly if it appears that strings weren't properly extracted
The function, get_distinct_test_run_revisions, is not found in PerformanceTestModel.  Did you forget to commit some changes to base.py?
Do we have a distinction between a fact resolving to a nil value and a fact not having a resolution?  Do we need such a distinction?
Here you could just do:

# @return [Facter::Util::Collection] the collection of facts

and skip the "# Retrieve the collection of facts" (Which should be "Retrieves the collection of facts" (3rd person declarative) if you want to keep it.
You already have one of these elsewhere; why can't you reuse that?
Good call on the "const_defined?"-- I had just copied that from the old code, but you are right.

As for the load one-liner, I'd really like the backwards compatibility hack to be very clearly isolated and easy to delete, so some of this code is structured that way intentionally.
yep, removed!
`identificator` => `identifier`. Also: how this is different from `id`? I mean, `User` has `id` field and `identificator` field - names are the same, this is confusing.
I'm also using 0.2, and using the syntax with "fix" doesn't work at all for me -- I consistently get a "Too many arguments" RuntimeException.
This block of code is redundant, please use MWWorld::Class::get(iter).getName(iter)
yeah, agreed.  basePath sounds good.
cosmetics: tab != 2 spaces
This method should just return ```true``` if we get  to this point. Returning a specialized string (i.e. ```"ok"```) is probably just asking for bugs later.
@samiluukkonen Kommentissa virhe.
@param null|object|array $entity

or

    @param mixed $entity
Same thing as bellow about commented out lines.
Can probably reduce this if statement down to one line. I won't block on this though.
Same as above => `storage_engines.yml`
actually, I'm not quite sure what splatting the parameters to a splatted arg list would do...
Get unsigned values as mentioned above, with `, null, true`.
Sounds reasonable.  It's force of habit for me to include the version, but I guess the actual "version" is ECMAScript 5.  Of course, this raises the question of whether the YUI module should be named simply 'ecmascript' with a version number of 5, allowing for update to a es6-shim in the future?

Or should I just drop the version number altogether and let it be.  (Probably best since it's *highly* unlikely you'd want multiple versions of this running at the same time.)
It seems that 'bring-windows-to-current-workspace' is not referenced in this file, right?
I think ```$extra_variables``` is a string here @see _omniture_format_variables() and this foreach won't work as intended.
I like this comment.

One day it would be nice to remove this entirely :D
I think exec can go... all exec/cue trackevents are named "cue" now
Perhaps something like "..and downloads album metadata" or "...and downloads release information"?
It would be cool if this config page gave a list of the variables that are passed from PHP to the XSLT so that people creating XSLTs know what they can use. I believe PID etc is passed in, but maybe not.
This should be a period at the end, not a comma. Will fix
That's good feedback, thanks!
The same syntax would be more readable on multiple lines, imho :)

```php
$compoundValues = array_map(
     function($val){ 
          return strtr($val, array('\,' => ',', '\;' => ';')) 
     }
), $compoundValues);

```
Explicitely specify the unit (bytes)
I just made a patch that does the exact same thing, fwiw.  So, I would support this fix.

Thanks,
Tom
What if other extensions had run before this one and populated `@sitemap.pages` a bit? This is another reason I think the `inject` approach is cleaner.
Nice, I was going to make a ticket for this.  Now I don't have to.
Heh... oops.
Good to know.  That should work for the deserialize side.  What are your
thoughts on the serialize side (from ClojureCascadingBase/initialize)?

thanks,
Marc

On Tue, Mar 27, 2012 at 3:21 AM, Sam Ritchie <
reply@reply.github.com
> wrote:

> >
> >  /** User: sritchie Date: 12/16/11 Time: 8:34 PM */
> >  public class KryoService {
> >      public static final Logger LOG =
> Logger.getLogger(KryoService.class);
> >      static ObjectBuffer kryoBuf;
> > +    static Var require = RT.var("clojure.core", "require");
>
> Yup, we can definitely be confident -- Cascalog's going to need a bit of
> work before it supports local mode.
>
> ```java
> JobConf jc = ((HadoopFlowProcess) flowProcess).getJobConf();
> ```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nathanmarz/cascalog/pull/63/files#r607412
>
thankyou, hun
 



Date: Thu, 11 Oct 2012 20:07:34 -0700
From: notifications@github.com
To: Hello-World@noreply.github.com
Subject: Re: [Hello-World] try to test be social (#63)


In README:> @@ -1 +1,2 @@
>  Hello World!
> +test

try
—
Reply to this email directly or view it on GitHub.
Any reason why sendProfile has been factored out into a private function? It feels like putting it inline will help its readability
I added a custom POST handler.
We should get a comment by commentId, not contentId. There's always a chance that 2 comments would have the same timestamp, at which point they'd become indistinguishable.
If the user for the test database has a password, the script will exit so the schema setup script will not be executed
You're right. I just copied the way YahooProvider did.
as you never use the parameters, you could remove the constructor entirely
Ooh, nice
Change to "and anything you have implanted will be destroyed.".  Carried implants will dropped as usual.
i am jealous of monitors big enough to display two 80 column windows side-by-side...but then i work sitting on my couch...
This should be Hello World
Can you restore the leading `*` here? I don't think the comment block needs to change.
This is cool. It's prompted a few ideas in my head which I'm going to braindump here...

Would be cool to be able to set a default hostname / port for entire program to avoid the need to provide it for each request. Also perhaps the method should just be the name of the function, a la Express?

```javascript

var myProg = function(prog('localhost', 9000)) {
    prog.get('/team/xyz');
    prog.post('/stream/abc')
        .body({...})
        .headers({...});
}

```
yay h1
These variable names should be updated so they are actually meaningful.
本文データが無いときにbodyが作られないのでこちらなどいかがでしょうか
``` ruby
      data["body"] = File.exist?(text_path) ? File.read(text_path) : nil
```
并且加上:doc
``addDefaultsIfNotSet()``
Hey, even in Python we have a boolean type! ;-)  Why not use it?
I would use `!=`
Dang it, I meant to change this to force the user to input a subject. Fixing now...
do you really have a use case for bad_file is None?

I'd like the user to be able to do :

raw.info['bads'] = []

it requires a minimum of python syntax
usage should give the form used to call the feed. In this case something similar to:
/jobs[?filter=<filter>]

this form is used usually to descripe the usage of commands.
I use WeakHashMap not to worry about unused tokens or uninstalled modules so that they can be GCed.
@schisamo Actually, nightly builds would be sorted _after_ proper releases, so that `1.0.0+build.123` is "more recent" than `1.0.0`.  A typical ordering might look like this:

```
"1.0.0-alpha", 
"1.0.0-alpha.1",
"1.0.0-beta.2",
"1.0.0-beta.11",                                                  
"1.0.0-rc.1",
"1.0.0-rc.1+build.1",
"1.0.0",
"1.0.0+0.3.7",
"1.3.7+build",
"1.3.7+build.2.b8f12d7",
"1.3.7+build.11.e0f985a"
```

@seth I've got the beginnings of a small library that handles all this stuff for us (ordering, filtering, etc.) and am in the process of adding it to Omnitruck.  As long as we create the versions like @schisamo is doing, everything will Just Work.
Utils.Resolved?
We may need to be able to pass FORCE here for mcollective, as it won't have rc in the version string. Also, shouldn't this be passing COW=1 until cows is the default?
Logging uncaught exceptions
I'm not in favor of adding any more complexity to the interpolations system.  If anything, we should be reducing what it does rather than adding more abstractions.
I'm asking again...why not just use if `head.is_Add` and if `head.is_Mul`?
"Versión" en lugar de "visión".
Description for `@return` is missing.
:-D

Gotta keep it light. haha

--------------------------------------
John C Bland II
http://www.johncblandii.com
http://www.johnandseason.com

On May 8, 2012, at 11:41 AM, Jesse Wolgamott wrote:

>> +if match.winner == fighter_a
>> +	rounds = fighter_a_rounds_won
>> +else
>> +	rounds = match.turns.count - fighter_a_rounds_won
>> +end
>> +
>> +print "The winner of match with #{rounds} rounds won is......."
>> +
>> +sleep 1.5
>> +
>> +print "#{match.winner.name}!!" if match.winner == fighter_b
>> +print "YOU!!" if match.winner == fighter_a
>> +
>> +sleep 2
>> +puts "\n\n"
>> +puts ["Thank you for joining us. The gift shop is open!", "Don't forget to tip your waitress!", "No refunds."]
> 
> LOL
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/RubyoffRails/Episode2/pull/9/files#r789206
I think the name for "lets run this and check if anything exploded" is a smoke test. If you name the function test_smoke, you can reduce the amount of detail in the docstring
I've been using `$base-rhythm-unit` as a useful part of the public API. Is there a reason not to keep it available?
```
>> git rev-list --count --left-right '@{upstream}'...HEAD
error: No upstream configured for branch 'master'
error: No upstream configured for branch 'master'
error: No upstream configured for branch 'master'
fatal: ambiguous argument '@{upstream}...HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions
```

Passing `-u` to `git push` solved the problem! Thanks
thanks for being awesome and submitting this and putting up with my requests ;)
I would vote for that! Lets see what @mmarkus and the others say!
Good question. I think it does not work. PutMapCommandTest does not seem to test with write skew check enabled so there is no proof this actually works. Will investigate and create a separate jira to enhance PutMapCommandTest.
Right, but think about it from a code readability perspective.  You're calling a method which implies "do something because this entry has been activated" on a codepath that means "do something, this entry has been removed!".

Why should an entry removal increment an activation counter anyway?  That's incorrect.
IIRC creating an object of the class, properties get copied for each object.
As these don't change, keeping them static reduces memory usage.
Running autoupdate advised this change.
isn't the if statement inverted? also why not move the logic to decide into getPrimaryLanguage?
I am under windows and i am not able to build mpl, so i can't run the test suite to generate the image. I could run the code 
with an old mpl, but i am afraid that the result is not right.
It was deprecated before: the only "problem" is that it was mention in the documentation, but no deprecation warning was raised. I'm not sure how to use this documentation tag: should I put the version were it was tag as being deprecated, or the version were we target the removal of the option ?
Wait.  All this is incorrect.  We shouldn't be checking to see if the output is a string -- that distracts from the point of the conditional in the first place.  There are much better ways to do this, given that we know exactly what sort of issue will arise at this step.  We can revert back to the old code with the `singular?` function, and then return two `nil` values.  This need not check for general errors.
for me it's just fine, minor magic numbers
Please use the `TEMP_FOLDER` constant here. `/tmp` will not always be available, plus we support Windows.
Please add this to the other dimension vars at the top of this file
Line indented incorrectly; expected at least 12 spaces, found 10
+2 more lines
This should be elseif not else if
https://wiki.ushahidi.com/display/WIKI/Coding+Style+Guide
ups, thanks!
Are you sure that the method "setUsername()" exists?
Should the type for parameter ``$entityLoader`` not be ``null|EntityLoaderInterface``?
Wenn gemerged durch NodeUtil ersetzen.
Lassen wir mal bis mans braucht. Ist überall bisschen anders...
I think this is more than a note, it should go up at the top of this section, imo.
in references to this, should we just move it to <title> and not apply to the body html?
Comparing sequencies is costly. But you could do `(empty? (filter (complement pred) a-seq))`.
The formatting is messed up here :)
agreed, will check if we do this consistently.
Resolved in 196790e.
will add some phpdoc comments.

the interface leaves it up to the implementation. as you can see with the above implementation it currently just checks if the document has implemented the interface and if the current user does not have the role .. in that case it will check the publish flag/date:
https://github.com/symfony-cmf/CoreBundle/pull/13/files#L2R34

another implementation could also check ACLs etc
thanks for looking into it. and ack for the ACL, sounds ok to me.
ok. fixed permissions on all files.
Hm, you know that there exists `scrollintoView`? Or you want a nice easing effect. :-)))
Move `30` to some top-level constant(`CHECK_ONLINE_USERS_RECONNECT_TIMEOUT`?), value based on `settings.CHECK_ONLINE_USERS_INTERVAL` (like `2 * settings.CHECK_ONLINE_USERS_INTERVAL`).
Use FireBug and use "Net" panel there. You will see output Django throws at you. Safari/WebKit even renders that output so you get nice Django debugging page on error. :-)
OK. I moved this to django-tastypie-mongoengine. It is in initial stage but probably can be used. Check tests there to see how to define such polymorphic documents.
Yes sorry, I started translating but than saw another pull request and reversed back(unsuccessfully).
Why another function call on the stack?
`title_tag` -> `title`?
Please add a comment, what line 17-18 are doing.
subv is just trolling me, because i didn't wrote a description :D
i thought the diff says more as any description
Das Handling ist aber jeweils unterschiedlich. Wie du in diesem Beispiel siehst, wird eine IOException anders behandelt als eine JSONException, da unterschiedlich tragisch.
I put my previous comment in a commit, which is probably a less helpful place.

So I think we want people to be able to reject their timesheet but not another's unless they have view_payroll_summary correct?

I think we'll need to remove @permission_required because it isn't granular enough for us and we'll need something like:

if not user.has_perm('timepiece.view_payroll_summary') and user entry.user != user:
    return HttpResponseForbidden('....')

This would require that we query the entry before making the check though so we can associate it with a user.
Sure, I like `subtrees`.
is this 9999999999 completely arbitrary ?
usually when we talk about 'all' or everything, we use 0
this was a mistake.
yeah, that's our intention from this change
`n = 0` with spaces.
Yes, subclassing object is not written down as standard, but it is. and capitalized names for classes (pep-8) "ProbabilityPlot" "ProbPlot" ?
Yes open a shell in the docs directory and do ``make html`` which does the sphinx build of the docs. Depending on the setup, there should be none or a few warnings.
Thanks, don't know how this happened...


On Fri, Nov 16, 2012 at 3:14 PM, Skipper Seabold
<notifications@github.com>wrote:

> In statsmodels/graphics/factorplots.py:
>
> > @@ -4,10 +4,9 @@
> >  import utils
> >
> >
> > -def interaction_plot(x, trace, response, func=np.mean, ax=None, plottype='b',
> > -                     xlabel=None, ylabel=None, colors=[], markers=[],
> > -                     linestyles=[], legendloc='best', legendtitle=None,
> > -                     **kwargs):
> > +def interaction_plot(x, trace, response, func=np.mean, ax=None, plottype='b', xlabel=None,
> > +                     ylabel=None, colors=[], markers=[], linestyles=[], legendtitle=None,
> > +                     legendloc='best', **kwargs):
>
> It looks like the last two keyword arguments have been reversed here.
> Picky: the signature is no longer pep-8 compliant. Need to keep line
> lengths to 79 characters or less.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/statsmodels/statsmodels/pull/569/files#r2151900>.
>
>
No; it's probably safe to remove it entirely. The main difference between toura.log and console.log is that console.log gets stripped out of builds, and toura.log does not.
I use tabs, which should be mapped to four spaces
No objection here.
Would you suggest making that an additional optional parameter (which, if not provided, means the code makes its own uniform deviate)?  Or a required one?
Hi Jun. The right way to do this is to create `files/ocamlspot.install` containing:
```
lib: [ "ocamlspot.vim"]
```
Could you change your pull request to do this? Thanks!
Misspelled on purpose :)
This shouldn't be needed, Apt::Repository handles this
i'd prefer it not to have an intermediate non-null value, is user calls setPoolName.  have cleaned up getPoolName however.
xDDDDDDDDDDDDDDDD
I think we should name this differently. What about getConnections()? "available" makes little sense here - as they are merely established connections. Alternative connections could also be available.
What tests are using <code>requests</code>? I grepped and didn't find any.
thanks was not aware.
This is the first time I see |req|. Has it been declared before or is it a leftover?
What is the license of this data file?

(It should be BSD compatible)
Instead of disconnecting when we see a version that's less than 209, shouldn't we just force it do v. 209?  This would keep the same behavior we currently have and in the remote possibility that someone is running a pre-209 version that they have patched to include the checksum in version and verack, it will continue to work.
Might be nicer to keep this on a single line.
That was something I corrected but got lost in one of the multiple merge conflict I had with that file. Good cath
In the past, were we trying to make it so that UAVOs are never written inside a library function?
Usually when code like that is written, it is written for a specific reason. Looks like there was no such reason :-)
Закрывать System.in - плохо.
А обратный слеш?
I mean, port over the code from PHP that handles combining the container and blob name:

    /**
     * Creates URI path for blob.
     * 
     * @param string $container The container name.
     * @param string $blob      The blob name.
     * 
     * @return string
     */
    private function _createPath($container, $blob)
    {
        $encodedBlob = urlencode($blob);
        // Unencode the forward slashes to match what the server expects.
        $encodedBlob = str_replace('%2F', '/', $encodedBlob);
        // Unencode the backward slashes to match what the server expects.
        $encodedBlob = str_replace('%5C', '/', $encodedBlob);
        // Re-encode the spaces (encoded as space) to the % encoding.
        $encodedBlob = str_replace('+', '%20', $encodedBlob);

        // Empty container means accessing default container
        if (empty($container)) {
            return $encodedBlob;
        } else {
            return $container . '/' . $encodedBlob;
        }
    }
    ...

    $path = $this->_createPath($container, $blob);
    WebResource webResource = getResource(options).path(path);