labofsahil/github-event-dataset-2012 huggingface dataset:
(Whoa, this page tages ages to load so that I can enter a comment)

Ian, I do get your point and I kind of see it similarly. For me personally, the ONLY place where I want to give s9y support is on the s9y forums. Not here, not on the SF.net issuetracker, not via twitter and MOST certainly not via e-mail.

However, I need to acommodate to other peoples oppinions. People like Grischa feel comfortable on twitter, so to me the choice is not to force Grischa or others on "official" support channels, but try to be appreciative of their input, so I can take their input on their preferred channels and try to document or forward it to more "official" channels.

In this specific case, I was also under the impression that since it got up and fixed quickly on the channel that the involved people most often use, I didn't see the need to forward this matter to another place. If it were something more serious or something that really could have had a larger impact, I'd have definitely posted in on the forums. Actually I do agree with you that the documentaiton on what happened helps people not so familiar with git (like myself), so it's quite good that you asked here.

We are a small team, so I think we can work this out having different channels, if everybody dips his toes into unfamiliar waters from time to time so that the circle is closed.

Hm. Reading through this again, I don't think I made some sense, did I? ;)
@acrmp No problem, glad you just forged ahead.  Sorry for the delay, Snow in Seattle and other business threw people's schedules into a bit of a mess last week.  I'm sure I'll have a chance to contribute in the future. :)
Great that you remembered to clear the float like this :)
J'm'amusais juste avec l'engine, mais j'ai repéré deux trois trucs, test ce build, revert le après si y'a des trucs qui t'ennuie, ce sont juste des tests.
 Pourquoi collision Entity hérite elle de FloatRect ? Sprite a déjà GetGlobalBounds() (qui de plus prend en compte les rotations, même si je sais qu'on ne les gère pas "pour l'instant")
 Essaye d'atterir sur le haut de la colonne de droite, perso. je n'y arrive pas ! Petit point à revoir au niveau des collisions je pense.
 Bonus : Essaye de rebondir sur un seul mur, c'pas très dur :p
Oh ! Sorry i meant to coment on LearnBoost repo !
Anyway thank you, and did you ask Guillermo to fix this ?
He's responded quite fast to a lot of pull requests lately.
I see. Please add that as a short comment & leave the code as it is. Good work, David!
Components registered using IContainer.Configure() should also be named, right?
nub to infinity and beyond, i was talking about hard drive bytes.
Stop fucking spaming commit with your stupid mesage,
Yes,

Actually the project where I use ST is built with maven, so I had to
use maven to build ST, so I know it works. A couple of comments
though:

- The maven build is still in version 4.0.4-SNAPSHOT, where the ant
build is in version 4.0.5.
- 2 tests are failing on my machine [1], however they also failed
without any changes to the source, so I had to compile skipping the
tests. I haven't yet investigated on why they are failing.

Irving Cordova
http://irvingc.com


[1] Tests in error:
  testBugArrayIndexOutOfBoundsExceptionInSTRuntimeMessage_getSourceLocation(org.stringtemplate.v4.test.TestEarlyEvaluation):
17
  testIndirectCallWithPassThru(org.stringtemplate.v4.test.TestIndirectionAndEarlyEval)


On Fri, Feb 10, 2012 at 12:12 PM, Terence Parr
<reply@reply.github.com>
wrote:
> hooray! thanks. sorry. i'm swamped with info at moment. Will accept. Are you sure it doesn't hose the normal mvn build?
> Ter
> On Feb 10, 2012, at 12:10 PM, irvingc wrote:
>
>> Hi
>>
>> I actually did that at the same time as the pull request :-)
>>
>> However I didn't put any reference to the pull request, do you need me
>> to resubmit again? I guess I forgot to put the pull request as ID 3.
>>
>> Irving Cordova
>> http://irvingc.com
>>
>> On Fri, Feb 10, 2012 at 10:50 AM, Terence Parr
>> <reply@reply.github.com>
>> wrote:
>>> Hi!  Heh, could i ask you to submit also through click wrap license http://www.antlr.org/misc/feedback to keep license clean? then i can integrate.
>>> Ter
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/irvingc/stringtemplate4/commit/7f6bb59859fea868343b8e410243ee7d8a4b1559#commitcomment-954851
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/irvingc/stringtemplate4/commit/7f6bb59859fea868343b8e410243ee7d8a4b1559#commitcomment-955093
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/irvingc/stringtemplate4/commit/7f6bb59859fea868343b8e410243ee7d8a4b1559#commitcomment-955100
quite a few lines > 120 characters which don't display well in git hub.
The comment could be clearer (I didn't understand it)
Ah.  Yeah, I don't have that.
it's changed foo'! But am changing it to js at some point anyway so doesn't matter :P
unfortunately i will not be at clojurewest. i was lucky enough to have a job that paid for me to go to clojure conj two years in a row. i'll try not to push them too much, so i can keep up with that tradition.
would you suggest that "pull" should not specify any revision for better efficiency ?
Still wont for me. =/
Btw bootz rewrite whole power system to int from uint if you want not hacky eclipse
おおお！！
さっそくの↑は一般向けに公開する時便利ですし。
↓はお手軽に実行する時便利ですね！！
ありがとうございます！！！使ってみます。
hi mataki!

i am using this plugin in redmine and when i execute 
rake gems:install (my current directory is redmine/vendor/plugins/authlogic_openid)

i get following error:

Hoe.new {...} deprecated. Switch to Hoe.spec.
WARNING: HOE DEPRECATION: Add '>= 0' to the 'authlogic' dependency.
rake aborted!
Don't know how to build task 'gems:install'
Yes, this was only failing in sklearn.test(). Nosetest is able to implicit import the function.
Nevermind, it's fixed, [notch and his lame coding are to blame](https://github.com/Afforess/CraftBukkitPlusPlus/pull/15)
This still violates the meaning of `timeout`. Either the behavior needs to be changed, or the property needs to be renamed. Even the documentation for this method is conflicting and confusing: It gives equal weight to all of the halting conditions (empty, timeout, continuation) and then goes on to describe how one of them takes precedence in a way that is not standard or even desirable. The block condition should allow for _early_ exits but not control _all_ exits. This is in line with both the meaning of `timeout` and the way in which iOS SDK methods take a continuation block.
Ich hatte mir quasi die Kurzform gegeben: https://dev.twitter.com/docs/auth/oauth/single-user-with-examples.  ;)

Okay, belassen wir's dabei - ich hab's wie gesagt übernommen.
My only thoughts are that if you install this plugin without setting up any defaults, it appears that the links won't be properly be setup. I'm going to merge it, but also add defaults so that it will work "out of the box" in case nothing is configured.
Not sure if you're still using this fork but just a heads-up:

    $(function() {

is exactly equivalent to

    $(document).ready(function() {

If you had problems with the image appearing in odd places before, feel free to try the current version. Those problems should be fixed now.
this is very cheeky!
I don't think this should need to be here.
If "load" event's target only shows load "tabscene" view, but "tabscene" view has defaultView, the defaultView should be loaded. 
So set subIds to defaultView.
This is in the "HTTP request is done, and we've parsed the whole body" spot — no better place. The HTTP request is done. You're right that it does delay re-upload, but then if we fall over processing the command, do we want to reupload?

(And X-If-Unmodified-Since resolves that problem, anyway.)
Gosh, Java is awful, isn't it?
_player->GetGuidLow()
Just checking if this comes as an email
Squadzone, I merged this changes to Gio device correctly?
braga como vc disse, nem todos vo as aulas, e como todos tem internet,
acho suficiente pra discutir esses assuntos, mas se as pessoas no leem as
issues e comentam, acho q no tem o direito de reclamar.

Discordo de vc em uma parte, a instalao de coisas novas, se elas no
afetarem o projeto como um todo e nem quebrarem testes de outras pessoas,
no vejo o problema de serem instaladas.


Em 29 de fevereiro de 2012 21:54, Eduardo Braga Ferreira Junior <
reply@reply.github.com
> escreveu:

> por enquanto a coisa t entre aspas mesmo.. tenho feito nada no projeto,
> assim como outros nem deram as caras, ok!
> mas mesmo assim, sinto-me no direito de reclamar sobre isso, embora eu no
> ponha a mo como vocs esto fazendo, estou acompanhando o que est sendo
> feito e leio essa bagaa toda aqui..
>
> acho que as aulas servem pra isso (alguns faltam alguns dias, mas o lugar
> de fazer isso  l), tem nada que sair instalando coisas, mudando coisas
> que talvez faam outros testes quebrarem no..
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/douglascamata/Rick-Rocks-Academics/commit/2051dac6f31a7ab08c1a971e3de99f092a05f7c5#commitcomment-1028914
>



-- 
Pedro Henrique Passalini Soares
Graduando em Cincia da Computao e Informatica - UENF
Maybe the solution to your issue is a bit simpler: you're using the kernel base address of 0x00200000, but the U8160 uses 0x00208000.

When I first released the ROM, some people tested it on Ideos phones. Apart from the obvious issues such as non-functional wifi and BT, the kernel booted, so perhaps this address also suits your phone.
we no need this module, because our driver is ar6000 :)
Missing the FlickrPublicSetBackend class
yes. Pauses for a minute via reopen.sh and then restarts. The amount of time can be changed though....
Wouldn't this cause openstack-keystone to be installed (and started) on the glance node? Ideally we should only need the python-keystone packages installed right?

The question is why isn't that happening? See line line 14 in glance/manifests/init.pp: https://github.com/derekhiggins/puppetlabs-openstack-nosubmodules/blob/master/modules/glance/manifests/init.pp#L15
OK so should we roll this in as is?
Debugging stuff I would imagine
Will this function be called outside? If not, define it as private function is better.
It is a bit off topic. We strong name everything because it is required for Clickonce deployment.
I believe this is missing a step.  The fully constructed config still needs to be validated to ensure that the node names used in the job/services actually exist in the config.

I just realized that this will also require a change to validate_node_names(). It will need to check the node names in each named config as well.
"This is realized by having the system guardian watch the guardian"

Which one? The User Guardian? It is not completely clear for me.
ok, I'll revert linebreaks in this and similar dependency lines
Ignore my previous self, I must have written that in some euphoric dilirium: since `receive()` and `select()` block until it’s “too late”, this cannot be done without sleeping.
not needed, use `roles` instead (it is in MultiNodeSpec)
Yes, OSI terminology also used by IEEE. I will add comment to explain.
I left that change for another day.
might just say `this(_ => null)` …
The path is not always available at this point?
The first condition is a just in case things go very wrong. Sure it should never happen.

Why would toSet == Set(myself) be better? Creating a set in a tight loop just to check for a condition?
about french?
my primary complaint is the "type" -- this code has nothing to do with type per se.

as far as I can tell, typecode_from_name isn't used at all.  so scrap that one.

my suggestion would be that we add a #fetch_id(mark) to the fetch module. 

as a goofy but semi-relevant aside, I'd also like to cut down on the absolute references to Card and Card:: from within the card namespace.
Actually, if $columns is not null, the behavior remains the same as before. Just making sure that we expose the same problem.
Thats Perfect.
for classes, put { on the same line as the decl
Perhaps toss a ..note in here about how on first launch Mongo has a tendency to take a few minutes to initialize journal files? Or maybe mention it in a FAQ. Your call.
I really recommend using Python's builtin configuration parsing module. It provides all this stuff for you.
Get rid of  `PDS_DOMAIN_TRUSTS` entirely and use DS_DOMAIN_TRUSTS.  Do the `Structure.toArray()` call explicitly instead of `domains.getTrusts(count)`, which is a little misleading.
Not sure I get the question.  The old code used this helper, but it really wasn't very useful as you can see from the refactored statements.
This may be moved from test/* space, but it helps for the longer project of 'coverage assessment'
I think this is the final structure update as you wanted it.  Still easy to update now, but soon, not so much.
This doesn't build.  Please split up the conditionals onto separate lines so that it's easier to read for next time.
Lets make this a little less harsh.

"Here are some examples blah blah"
can remove that
Yes, it's less to type. If there's both `foo_test` and `foo_test_`, should rebar run both the test and the generator?
Any other potential ambiguity? Otherwise, ok.
Looks like that will have funny effects for maps with non-square tiles. But those are so uncommon and I won't ask you to care. :-)
You are right! I can make this more symmetric and use the Message type to  
construct things.
I assume you are referring to the change of `flushInt` to `flushInterval`?

The `flushInterval` stores the integer value of the timeout interval, whereas the `flushInt` (and other variables named *Int) actually store the result of `setInterval`. So, in this case the purpose of these variables actually changed so I kept current naming scheme consistent by using a different name.
You probably want `CC.split() + ...` here (note that no arguments are given to split).
It means that it's a Universal Binary. It's an Apple thing. See: http://en.wikipedia.org/wiki/Universal_binary
ok, now it isn't superfluous too much as before :-)
Move this line out of the try block.
Thanks for a good catch!
I fixed them in commit 7fb77bf
maybe "common syntax" instead
TYPO: and/or *be* overidden
let's fix this whenever we spot one!!! this will allow settings "myname.nii" in the out[put]_file input and reduce use of renames.

```
return os.path.abspath(self.inputs.out_file)
```
не очень понятное имя. лучше переименовать, например, в insertedNodeId
лучше обозвать эту переменную по-понятнее
Булев тип. Переименовать во что-то вроде isLogicalCopy (п. 4.11 стайлгайда)
just following the format above that uses several before statements for one test. i will fix this
@spastorino De rien, my pleasure!
I test that the request.format.html? is equal to false
Actually this comment was added in @9e4461438f8ce584b635aca35579c36537a340ca, I do not think we need it anymore.
nah, this is fine.  We can refactor later to something more appropriate.
I think we could leave it to a separate pull request, since it's adding a new feature rather than fixing a bug (which is all the other code related to, right?)
I didn't get why you removed the "explicitly render the parts in a different order" it still works if you don't set the `:parts_order` option
beucause? (Sorry for commenting on typos, but this one actually gets printed)
Adding these deductions for integer polynomials might be a fun project. You just need to evaluate using 0 and 1 mod 2. Or see if there's some more general algorithm either already implement or that can be implemented (in the polys probably), which would be able to tell things like "`n**2*(n + 1)**2/4` is always an integer".
Why are these and following deleted?
See https://github.com/sympy/sympy/commit/a95db89887f63e28ac3b39ed9c62d22c0749d9e8

That's part of the branch 0.7.2 and it hasn't been merged into master yet.
@moorepants I will take care of that in another PR that I am going to open soon.
This line adds trailing whitespace.
> PEP8 is the standard we use. 

Then I guess I would like to revisit this decision, at least for this experimental module. The whole module deviates a bit from standard SymPy style.

Can I assume that you're -1 on this PR without this change Ronan? I didn't realized you cared so strongly about this issue. I haven't seen that many caps or exclamation points in a PR in a long while.
> That recursive step is the place where oo recursion can occur because
in the unlikely case (for expansion, but not "simplification") that an
expansion of one expression leads back to an already seen expression
you would hit a loop. But I'm not sure this can happen with expansion
that makes expressions longer in terms of op count.That recursive step is the place where oo recursion can occur because
in the unlikely case (for expansion, but not "simplification") that an
expansion of one expression leads back to an already seen expression
you would hit a loop. But I'm not sure this can happen with expansion
that makes expressions longer in terms of op count.

I'd like to hold off on testing things like this for now at least until we can get the rest cleaned up.
what about two body potentials (e.g. Coulomb potential) ? Your implementation only support one body potentials, right ?
Would you prefer that SymPy uses the name `groupby` or the name `sift`? I personally prefer the name `groupby`. I think it's more consistent with common programming. I agree that It is odd that there is also an `itertools.groupby` but this function doesn't match the common definition (at least not the definition I've seen in other languages [C#](http://msdn.microsoft.com/en-us/library/bb534501.aspx) [Clojure](http://clojuredocs.org/clojure_core/1.2.0/clojure.core/group-by)). 

SymPy has a history of reproducing common functions (consider `take`). I think that it's ok that we overlap with `itertools`. Thoughts?
I think this should be called is_identity.
I guess it doesn't matter that it's not adding the `'='` any more.
this seems strange to me ;-)
@phpnode your name is missing ;-)
I'm not sure I understand.  If you're asking why I catch OSError and raise TestRunnerException, TestProgram would either have to catch Exception or would have to know more about TestRunner then it should, both of which I feel are bad design.
Short of hacking the sample's instance variables, injecting the time was the best way I knew to get in there and expose the bug.
Ah I guess I understand it.  Man that `setup` method is a beast.
Is there anything in here that's not covered by the install instructions in the readme?
need to remove 
Params['log_debug_level'] = 1
it's an artefact from development
also in the last two sentences, the word chunks 6 times. This is distracting, and unneccessary.
Wouldn't this be a better test as:  Parser("REG.James.Kirk.10/12/44.0788383381", '.')
J'ai enleve les isActive mais il va falloir arranger ca eventuellement pour generer le code specifique a chaque page pour qu'un bouton du navbar soit mis en valeur selon la page ou on se situe.
Sure, it may seem convenient at first. But the problem is that it creates tight coupling, and also obscures the dependencies a class has.

If you inject the container, you have no clue which services the class depends on. This means that you cannot really unit test the class, because you need to potentially mock each and every service. Or make assumptions about which ones are requested.

I agree, setting up all those dependencies is a bit of a pain. In many (not all) cases, having many dependencies means that your class is trying to do too much, and should be split up into smaller classes.
What is "sreg data"?
jQuery should always be spelled jQuery in global scope.
Could also put this into a base class instead.
Error checking, code execution, chdir, etc. Same for all remaining exec calls I'm assuming.
Would you consider returning ` array('num_total' => ..., 'logs' => ...) ` cleaner too?
Create an instance in common.php
Yes. The path is passed into the file loader construct. The loader prepends the path to the filename given to the load() method.
Agree with p.
Deci trunchezi la today ora 00:00 și ceva activ după asta, nu? Pare ok.
Yes I agree.

However, since in `expandInstanceForEnv()` we're using the results as part of a `blend3()` the extra copy doesn't do anything, and removing it lead to a very noticeable performance gain.

One option is to add a "dontCopy" paramater, which defaults to `false`.  That way only callers to declare that they'll be careful can skip the copy.
I've updated the event handlers to on{eventName}.
commitesh karde boodam faghat chon dargire passwordetoon boodam faramish kardam push konam
sry :(
Are these changes part of Dynamic configurations? If not, I can merge them separately. I assume they're for some IDE-generated files.
run jsbeautifier.org
In addition, if the uuid's change but still are in localstorage, send one GET call for any of the concepts/encounterTypes -- if you receive a 404 not found, then clear localStorage.

NOTE: this must be done in the very beginning of app launch so we don't clear any login data
create ticket. combine with one about screenerUuidlocation
Lines 116 - 147 have lots of repeated logic. Suggest abstracting the shared code to a helper method and pass the panel and button type as args (e.g. RaxaEmr.Outpatient.view.patient.labresulthistorypanel, ConfirmLabResultHistoryButton), instead of repeating all the lines.
Again, I don't see why we have a app.js file for logout. 

Normally, an app folder with included app.js file means it's a standalone application. Logout is not an application, rather, it is something done inside of other apps (logout when using outpatient, logout when using registration...). My thought is that you would just include the controller in other apps.
A result of the now sorted attributes in _xml_id().
Master:
```
$  py test_pickling.py TestPickle.test_cubelist_pickle
('altitude', 'm', (('positive', 'up'),))
('forecast_period', 'hours', ())
('grid_latitude', 'degrees', ())
('grid_longitude', 'degrees', ())
(0, 'm', (('positive', 'up'),))
('model_level_number', '1', (('positive', 'up'),))
(0, '1', ())
('surface_altitude', 'm', (('source', 'Data from Met Office Unified Model 7.04'), ('STASH', STASH(model=1, section=0, item=33))))
('time', 'hours since 1970-01-01 00:00:00', ())
('forecast_period', 'hours', ())
('grid_latitude', 'degrees', ())
('grid_longitude', 'degrees', ())
('time', 'hours since 1970-01-01 00:00:00', ())
...repeating...
```
Branch:
```
$  py test_pickling.py TestPickle.test_cubelist_pickle
('altitude', 'm', (('positive', 'up'),))
('forecast_period', 'hours', ())
('grid_latitude', 'degrees', ())
('grid_longitude', 'degrees', ())
(0, 'm', (('positive', 'up'),))
('model_level_number', '1', (('positive', 'up'),))
(0, '1', ())
('surface_altitude', 'm', (('STASH', STASH(model=1, section=0, item=33)), ('source', 'Data from Met Office Unified Model 7.04')))
('time', 'hours since 1970-01-01 00:00:00', ())
('forecast_period', 'hours', ())
('grid_latitude', 'degrees', ())
('grid_longitude', 'degrees', ())
('time', 'hours since 1970-01-01 00:00:00', ())
```
Yes - it's a duplicate. I'll delete it in my PR to @esc24's branch.
Remove the TODO.
How about trying ```numpy.ma.isMaskedArray(array) and numpy.ma.any(array)```?
Inconsistent indentation in this file (spaces/tabs)
Not for those version of the kernel as this kernel don't work in that case. But I test all shape with the version -1 that let the heuristic determine witch version to test.
Declare/calculate this later, when it is needed, and avoid the need for cryptic and misleading explanation "// for logging later" (logging? really?)
You are absolutely correct.

Do you have an opinion on whether this setting should also disable the null
origin check?

From:  Reid Draper <notifications@github.com>
Reply-To:  basho/riak_kv
<reply+p-1982303-111c05b11fe8a0c214f316f022fc9c9db5c411f7-1626320@reply.gith
ub.com>
Date:  Tuesday, October 30, 2012 1:56 PM
To:  basho/riak_kv <riak_kv@noreply.github.com>
Cc:  Joe Caswell <jcaswell@basho.com>
Subject:  Re: [riak_kv] add knob to disable referer check (#419)


In src/riak_kv_wm_utils.erl:
> @@ -235,7 +235,8 @@ any_to_bool(V) when is_boolean(V) ->
>      V.
>  
>  is_forbidden(RD) ->
> -    is_null_origin(RD) or not is_valid_referer(RD).
> +    is_null_origin(RD) or
> +    (app_helper:get_env(riak_kv,secure_referer_check,true) and not
is_valid_referer(RD)).
pretty sure you mean orelse and andalso here and not or and and
 

 ‹
 Reply to this email directly or view it on GitHub
<https://github.com/basho/riak_kv/pull/419/files#r1982303> .
Ты или не дописал, или просто я не понимаю. Не вижу как вынос createNodePrefix помогает.
for some reason I though `postgis_topology` was the extension equivalent of `spatial_ref_sys.sql`, but now I see they don't actually have anything to do with each other.
Here was empty Tab, so I erased it.
Seems like something named `nice_list` should be the one that passes the assert.
I prefer keeping them in the Gemfile, it's easier to edit / more flexible (:git / :path etc) and there is afaik no useful advantage of keeping them here
According to http://oauth.net/core/1.0/#nonce, it should be unique per timestamp, so being based on time would seem to increase the likelihood of collision (though it is theoretically 1/1,000,000 with microtime())

`uniqid('', true)` seems like it's designed for this or `mt_rand()`.  Probably not a huge deal regardless.
See, e.g., LinearRegressionAccumulator::operator=()
Meh, it's a plain typo mistake. I'll fix that before pushing. Thanks for poiting out.
Should be `% (_k,)` I think.
You forgot "mox".  But I think it might be better to remove this section, and just get people to use the requirements.txt.
Don't repeat yourself, right?  ;)
I see no good reason to retain any of the doc strings as we are trying to improve upon the documentation. The old documentation has served its purpose until now as it has helped us get to this point.
I like this. There were multiple times in this pull request that I saw a reference back into the Pulp User Guide, which I think is going to significantly help users figure out what's going on.
Oh crap, you're right. It's in the main doc. Forget I said anything. :)
Could you please rename this to `disable_wiki` and move it adjacent  to the other `disable_` config params?
adaptors --> adapters
Yes I realized that. Just chating with Arie he said it's better. Please revert this if you want, I don't use english, I'm just following orders :D
indice -> index
You could just open this file for writing, iterate over the two scss files, and fw.write the result of File.read-ing each of them. That would eliminate the need for the settings_scss array.
Done. Also, in pull 1392.
There seems to be a naming convention of capitalizing module names, so maybe rename this to Strings.
Now that I look at this, I think my comment on the constructor about the value of `activeSuite` is wrong. I think it's "all" if all tests are being run, and null if no tests are being run. If that seems right to you, could you update it?
JSLint error--need semicolon after this brace.
At this point, we should logically be in the same state as we were in the previous loop when we were looking backwards and hit a "{". Could we factor this inner loop into a function like `scanSelectorBackwards()` that we can use in both places? That would clarify the logic.
I think `moment` can do all of this as you mentioned in your email.
I think you want the default value to be cfg.log_level here. Otherwise you're going to break everyone's script that sets the log level using logging.LEVEL names already.
Removed grobtree in 574e38c.
The map context will call setBoundingBox with null then the method onMapContextBoundingBoxChange will be called. Why this command is necessary ?
Right good idea. :D
it also creates less objects, and calls less methods. But, that's just me being picky
use `abort` rather than `exit(1)` when it's possible. You can pass it an string an it's way nicer:

```ruby
abort 'FasterCSV gem is not installed. Please do `[sudo] gem install fastercsv`'
```
i retract my statement.
I'm ... faaaairly certain returning anything here has no effect. Right?
s/Stylud/Stylus
Yeah, I deserve the shame
Fix in new commit. Thank you!
This does not look like it's still generated source. Needs a license header.
Why add `"[...]"`?  Even without jedi:max-summary-length, too long summary is chopped off.  So I think `(substring description 0 jedi:max-summary-length)` is fine.  What do you think?
I just figured for every 3 ignores, we give them the option to turn it off. I'd be happy to just give the option at == 3 instead. 

On Apr 30, 2012, at 10:15 PM, Tim Su<reply@reply.github.com> wrote:

>> +
>> +    private final OnClickListener dismissListener = new OnClickListener() {
>> +        @Override
>> +        public void onClick(View v) {
>> +            finish();
>> +            AndroidUtilities.callOverridePendingTransition(MissedCallActivity.this, 0, android.R.anim.fade_out);
>> +        }
>> +    };
>> +
>> +    private final OnClickListener ignoreListener = new OnClickListener() {
>> +        @Override
>> +        public void onClick(final View v) {
>> +            // Check for number of ignore presses
>> +            int ignorePresses = Preferences.getInt(PREF_IGNORE_PRESSES, 0);
>> +            ignorePresses++;
>> +            if (ignorePresses % 3 == 0) {
> 
> sam, what is going on with ignorePresses % 3 == 0?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/todoroo/astrid/pull/178/files#r754760
renamed via imports
Ok that sounds alright. For clarity you should `import scala.collection.mutable` and construct the object with `mutable.HashMap`
Is the documentation right? I don't see such parameters
interesting that this line does not need 'static'. I probably learned something about C++ here :)
This does not support l18n.
I suggest to match even against _("yes") and _("y"), which would allow you to enter "ano" in cs_CZ locale.
+1 to removing the \n.  Definitely the wrong place for that
On Tue, Nov 06, 2012 at 01:47:28AM -0800, Miroslav Suchý wrote:
> > @@ -34,10 +34,11 @@ type -P subscription-manager >/dev/null || exit
> >  test -f $CFG_BACKUP || cp $CFG $CFG_BACKUP
> >  
> >  # configure rhsm
> > -sed -i "s/^hostname\s*=.*/hostname = $KATELLO_SERVER/g" $CFG
> > -sed -i "s/^port\s*=.*/port = $PORT/g" $CFG
> > -sed -i 's/^repo_ca_cert\s*=.*/repo_ca_cert = %%(ca_cert_dir)scandlepin-local.pem/g' $CFG
> > -sed -i "s|^baseurl\s*=.*|baseurl=$BASEURL|g" $CFG
> > +subscription-manager config \
> > +    --server.hostname="$KATELLO_SERVER" \
> > +    --server.port=$PORT \
> > +    --rhsm.repo_ca_cert="%%(ca_cert_dir)scandlepin-local.pem" \
> > +    --rhsm.baseurl="$BASEURL"
> >  
> 
> config command is available since rhel 6.2, I'm all for using "subscription-manager config" if available. Something like
> ```
> if  subscription-manager >= 0.96.6; then
>    subscription-manager config...
> else
>   sed
> fi
> ```
> But the question is how to formulate the if-condition to work on minimal RHEL6.0?

Guys, this is what I call overengineering :-)

Just leave my sed lines there. It just works (TM).

-- 
Later,

 Lukas "lzap" Zapletal
 #katello #systemengine
See 7a76cea for curly brace. The `if` statement turned out to be not needed after changes to that context/exception stuff in dd169e3.
why skipping it there ? Doctrine is not required here
Change this method name to ResolveParameters
I wound up making the necessary changes in https://github.com/SignalR/SignalR/pull/1163
Storage -> this

nit: add a name to your anonymous function. Basically :
  
      function umsChanged(val) {
      }

Some people found that too much but it offers 3 advantages depending on the situation
 - Having a name on your function make it possible to remove it easily if you are in an event listener (not your case)
 - If you have a console.[log|warn|...], in the body of the function the name will appear in the message, making it easier to know where it come from.
 - When profiling/debugging the function is called anonymous if it doesn't have a name
Probably I was not clear enough.

If you want to use code from different file, you separate it into function, put it into table, and then call from both places, ensuring that old code still passes tests. Don't copy, it's harmful.
Be careful with this.  It can play hell with alignment and cover other elements.
@iguananaut: I think Euler angles are more for describing the rotation of a body in three dimensional space than for what we want to use here. I think it's best to have one class that sticks with spherical coordinate systems (ra, dec - lat, long - alt, az, ...). So in that spirit I would restrict it to two angles. 

But the question remains: two individual angles or tuples. 
Pros for individual angles:
 * The function always requires two, no need for checking. 
 * no need to type extra parentheses

Pros for tuples:
 * coordinates probably come often in tuples already
 

We also should think about how this affects instantiation of 3D and 4D coordinates, as it would be nice to have them the same.

`Coordinate3D((x,y,z), format=(xfmt, yfmt, zfmt))` or `Coordinate3D(x, y, z, formatx, formaty, formatz)`
`CoordinateSpaceTime( (t, x,y,z), format=(t, xfmt, yfmt, zfmt))` ....

Ah and (time-)derivatives of Coordinates:
`ProperMotion(ra, dec, pm_ra, pm_dec, ....)` or `ProperMotion((ra, dec), (pm_ra, pm_dec), ....) `

Any thoughts?
I think custom default outputs are just as dangerous for the same reason, assuming the default can be changed programatically and persists beyond the scope of the user module or function.  We can't make assumptions about how users will use defaults or output functionality within their code.
I'm guessing this is cased `setColor` for symmetry with `setLevel`. But that raises a question: Should we also make all the other methods on here `camelCase` for consistency with the rest of the logging module?

Personally, I'm fine with this as is. Just wondered if it was worth bringing up.
"Unchecked" sounds scary.  Maybe SetBestChainInner().
And an assert(pindexNew->pprev == pindexBest) would be good.
I'll update this pull :), thanks Gavin.
there's a gender incompatibility problem here. This should be either "cet URL est trop long" or "cette URL est trop longue".
It's actually technically possible to combine the `try` and `case` into a single statement using the `try .. of` syntax.  The `after` clause is still invoked even when you `throw` in the body of the matching clause.
I'm aware of that. I'm missing PHPCR and CouchDB ODM currently. MongoDB ODM has an open PR for this at doctrine/mongodb-odm#445
You should be ensure that the deletion of the id was successful
You left a puts here.
The reason for the name is that it matches the key in the JSON message prototype in validator_format.js.  Having the names match allows client validator code be efficient.  Since the name is yours, I'll happily take suggestions for a shorter name.
Except that I'm setting ack_str as well in one of the cases
Zie het nut niet van die parameter. Die rechten moeten altijd applied zijn.
Could this return a new, updated CheckinOptions? I know CheckinOptions is marked as a singleton, but I don't think it's used like one, and this class will be simpler to test if it just returns a new checkinoptions.
Drop `#region`s around namespaces. Just make sure that all the namespaces are used.
`if (os_type == "unix") "git" else "git.exe"` would be more idiomatic
I'm pretty sure this is no longer necessary. I have tried all sorts of unicode characters, including the strings from the four google-code tickets, and they all work.

The problems came from attempts to convert the gcal API byte strings to unicode, which isn't being done any more. As long as we don't try to decode the bytes, the terminal will handle it.
So, it looks like we need MAX or MIN if we want predictable numbers for `session` and `line`.

> If the SELECT statement is **an aggregate query with a GROUP BY** clause, then each of the expressions specified as part of the GROUP BY clause is evaluated for each row of the dataset.
> [...]
> Each expression in the result-set is then evaluated once for each group of rows. If the expression is an aggregate expression, it is evaluated across all rows in the group. **Otherwise, it is evaluated against a single arbitrarily chosen row from within the group.** If there is more than one non-aggregate expression in the result-set, then all such expressions are evaluated for the same row.

-- [SQLite Query Language: SELECT](http://www.sqlite.org/lang_select.html#resultset)
this is char[] not byte[] so charset isn't needed, right?
isDVR should check mediaProxy directly instead of embedPlayer wrapper.
there is no uiConf representation for live streams? .. its only in the entry?
What does this span here do? For me it just seems to make the DOM a tiny bit deeper, but maybe I'm missing something subtle.
Is that the right permission name? I was expecting something like `announcements.add_announcement`.
a little more info here, or an example would help
ahh, I copied that from the superclass.  I had to add support for PATCH, and I explain it in the new comment.
Why `OSError`? Normally, if you try to read a file that doesn't exist you get a `IOError`. 

Or instead, can we use that CrashIDNotfound error?
Seems like this method duplicates the work in parseResponseType.
Jog my memory:  Does this have to be constructed on the main thread?  If so, we should document that.
I agree with stof. Another example in Symfony is the Finder.
Makes sense. Pushed.
Better do an `isset( $this->dispatcher )` ?
why ? it is a mandatory constructor argument so initializing it here would be useless
Whether
this one should be removed entirely as it was added previously for 2.1. It is not part of the 2.0 codebase
because we don't need to show photos from an arbitrary user?
What happens when you replace `[first compare:second]` with `[second compare:first]`? Don't you get flipped order?
Probably not necessary, since the other two assertions would fail if `zone2` were nil.  But it's fine as is, too.
Please refer to libdgtal.org (seems to be related to your git revert ;))
> failing silently and telling me something that isn't really true. 

Failing *with a warning*. As it is, you cannot currently depend on the result of ```get_extent``` *without* doing this ```try..except```.
OTB? I assume it means Omitting The Brackets or something , I've added them locally now
And I strongly feel we could not keep dsn as null for this is a special case and we are making it possible for people to use a pdo if they already have. And as there is a setPdo they can make use of this without any problem .
*the* optimizer
This doesn't need to be a #view block, right?
somethign is funky with the  tag closures here, are you sure it works?
Does that mean that a 64 bit machine couldn't send the data to a 32 bit machine?
Instead of checking for `'.'`, check

    var code = evt.charCode;
    if (code !== 0 && code < 0x30 && code > 0x39)
      return;

where `0x30` and `0x39` is the Unicode codepoint of character `'0'` and `'9'`.
Check if we can use the window.confirm ;)
Oops, just forget it, my mistake.
If you save the alarm object during `load` then you don't need this function.
Remove this code.
I think we need a `height:64px` here, the permission icon is being cut at the bottom.
It miss a data-l10n-id
damn! I missed this one. Thanks!

(/cc @albertopq )
Did I mention I dislike arbitrary class names? ;-)

Obviously we need:
* to separate “Accept” and “Dismiss” actions — I’d be tempted to suggest both “accept” / “dismiss” class names and submit/reset “type” attribute values (rather than affirmative/negative);
* to emphasize the default button (which might *not* be the “Accept” one) — which could be done with a “default” class name.
Un, merged already, PR coming...
@stasm  Why '2' at the end? Why dont we use 'deleteThreads-confirmation' directly? Thanks!
@albertopq Here you have the code ready for calling Contacts' App! ;)
need `{` and `}`
If `window.navigator.mozSettings` is unavailable we should just go ahead and try to make the call, not "throw" and error.

So we won't need the `throwGeneralError` :)
`function al_handleEvent(evt)`
I usually don't check for those before clearing but I'm a lazy guy
I think `disabled` is a boolean attribute (i.e. using it implies a "true" value by default), so this selector should be refined.
pathetic detail but should be
`for (var k = 0, len = link.length; k < len; k++) {`
Ukazoval jsi, jak autofocus rozbíjí načítání slajdů -- readonly je tu zakomentované, protože s tím byla taky taková potíž, nebo je jen potřeba dodělat logiku pro rozhodnutí, jestli právě probíhá přednáška, nebo cvičení?
Agreed, you'd need to have the inner one.
Usually what I would do in this case is have something like [this](https://github.com/dkubb/veritas/blob/master/lib/veritas.rb#L189).

So this could become:

```ruby
def self.model(model = Undefined)
  if model.equal?(Undefined)
    @model
  else
    @model = model
  end
end
```
'all' isn't a valid recipient. Bear in mind that agent99 think sshe's talking irc.
Naming is python in google for 2.5 and python27 for 2.7. I think we should stick to how they name it.
Whoever it was, he spotted a fail of mine. For cubic buffers it doesn't matter. But if sizeX would be 20 and sizeZ 16 I am saying here that if you increment and index by 16 you have incremented z by one. If index % 20 == 3 then adding 16 does not result in increasing z.

Yinc = sizeZ * (Zinc = sizeX * (Xinc = 1)); is therefor correct
It was an fault to include the sourcestampsetids in a pickle. Therefore I removed them from the pickle and so changed the test.
This is handled now by descriptionSuffix; see below, where if descriptionSuffix is None, the codebase will be used instead.
I don't think we want editor specific ignores in the repo.
This was in @vsevik changeset, I will take a closer look at it.
If we can't identify a version in this case I'd `continue`, because knowing that the library is present without knowing the version is pretty much no use. We already have the ext- packages that indicate the presence of something.
i think, the number of buttons should also go to the pinning config
Все апи будет отдавать json,  а один метод html? как-то странно.. это типа json api :)
just inattention :)
This should probably live in a module somewhere. It's just so simple i did not bother to add that.
I would expect the valid values here to be "toggle" or "checkbox". How does "button" or "link" map onto those concepts?
add new DB column  (video_views)
remove this method
add # TODO use Delayed jobs to update video_views
comma space convension
Could you give some more information about these unwanted exceptions ?
@lloyd - I made this timeout configurable primarily for testing.  I didn't want to slow the tests down for 5 seconds when I didn't need to, but it does give us extra flexibility to remove the timeout.

As to the second part of your concern - I have started that bit in a separate branch to address issue #1734 (verification screen flash) and would prefer to continue this suggestion in that branch.
@seanmonstar - https://github.com/mozilla/browserid/blob/71341882496bf4573335a0f96693b40e15bc2ee9/resources/static/dialog/js/modules/dialog.js#L228
Should we `~>` these in, rather than lock on one? Seems potentially restrictive and I think gems should be as open as they can afford to be.
curlies are a bit off :)
This changes the value returned from a boolean to a value. Please revert.
Very minor note, but maybe line this up a bit? and the group above?
Method ordering, this one goes before the package private.
return unless ...
Above line is already set on line 26 so this can be removed
Crap, that was supposed to be removed. I'll fix.
It took me a while to parse this line to figure out what it does and it's not very extensible if you want to add other machines later. I think something like this would be more readable and extensible:

    if "machine" in test_entry:
      if machine == test_entry["machine"]:
        self.addTest(Test(test_entry, self))
    else:
      self.addTest(Test(test_entry, self))
We don't want events like these, instead we use EntityDamageEvent and then see the DamageCause enum in org.spout.vanilla.controller.source.DamageCause
Hmmm. Interesting. This env var is *not* set by the settings include file. I guess it probably should be. I'll submit a Jira ticket.
raising within a template is, I think, unprecedented in this codebase, so it'd be good to understand a bit more about what's going on. Is this to defend against `render partial:` calls which forget to set it in their `locals` options?
this will throw if config is null.
This doesn't fall within the same pattern as how the table view handles selection events for "child" table views. There should not be a separate event for the same thing with the only difference being to specify that it is for a child table view. In the case of DidSelectRowAtIndex, there is no "DidSelectRowAtIndexOnChildTableView". It simply fires DidSelectRowAtIndex and the data that gets passed with the event can be used to determine which table view this event originated from.
line to long, remove comment?
I always did that :-/ It's not too long in my Vim :-p
Inline comment: single has, preceded by two spaces.
rename tmpattropl to res_attrs ?
Link brackets  needed :-)
This change will break non-worker file access I believe. Try test_files for example
In the old config the `CONTENT_TYPE` directive would always be set even if it was empty. In the test case you adapted you checked with `assertArrayNotHasKey()`, which would fail because fastcgi would always set this param. Starting from nginx 1.1.1 the `if_not_empty` directive was added.

The default nginx install that ships with ubuntu is 1.0.5, that's why I add the nginx ppa and install from that source instead (@ `.travis.yml`).

Hope it is more clear now! :)
Middleware isn't run during tests, so the anonymous CSRF stuff isn't enforced. 

Django-cache machine, on the other hand, DOES run during tests, and causes issues with returning cached data within the tests.
s/Sms/SMS
Nit: can this be lined up with the `reverse()` argument?
See previous comment about IDs.
I think this comment doesn't mean what it says.
I missed this!. What's this?
only used inside the first block. Declared here it seems more important.
And I'm not sure I see the need for OCD declaration of params to compensate for ugly 3rd party APIs.
This method should probably be `synchronized`.
Changed to double quotes and the message is one line now.
I did almost exactly that in this branch: https://github.com/njay/tutor/tree/mocha.  In spec/fixtures/cards.coffee, you see stuff like

````
exports.recall =
    params: ['1496', null]
    response:
        name: 'Recall'
        mana_cost: '[X][X][U]'
        converted_mana_cost: 1
        type: 'Sorcery'
# etc, etc
````

By the way, I'm also ready to give you a pull request off that branch, but it's based on the master branch in this pull request, sooo... ;)

(I expect the fixtures directory will eventually store copies of gatherer pages, for parser unit tests and mocked responses in integration tests.)
Do you keep the non-phpdoc ?
2 things here. 
1. This action/page is only so that I have a blank html page to pretend to be an external site for developing the codemarklet. I probably should have deleted it
2. render :layout => nil means that it doesn't use any layout. Whatever is in the views/codemarklet/codemarklet_test.html.haml is what it sent out
if and only if? however that may have honestly been a typo
I assume also a python3 issue.  Any chance you could also fix the fact that I inconsistently used double quotes here?  Everywhere else I use single quotes.  If not I can do it.
I don't think I commented that out, I think it already was.
This explicit wait overrides an identical implicit wait, so not sure why this fixes whatever issue you're seeing...
we talked about this in person, and you're good, np.
we transmit to pages.mobile.regions.message.Message  the li tag not data inside it
There's a logical merge conflict here. You'll want to structure this with the `cassandra` and `redis` values now.
value should probably be defaultValue.
`tenantOverride` on a config option is now available.
I think 'only' is out of place here.