labofsahil/github-event-dataset-2012 huggingface dataset:
I thought isInstanceOf was bad, bad, bad?
How about instead of doing one call with a merged list of requests, doing 1 calls for each list, using an extra enabled parameter, with true for the class prepared requests and breakpoint.isEnabled() for the breakpoint requests.
don't we want to define that getRouteKey must return a string? might be easier. having objects in $defaults is a problem in some situations i think because they get serialized in some situations.
Maybe we don't. Removing them for now.
I like this check against the down block.

ap
On Sep 15, 2012 12:02 PM, "Dan Croak" <notifications@github.com> wrote:

> In aliases:
>
> > @@ -30,12 +28,10 @@ alias gi="gem install"
> >  alias giv="gem install -v"
> >
> >  # Rails
> > -alias migrate="bundle exec rake db:migrate db:test:prepare"
> > -alias remigrate="bundle exec rake db:migrate db:migrate:redo db:schema:dump db:test:prepare"
> > -alias remongrate="bundle exec rake mongoid:migrate mongoid:migrate:redo"
> > +alias migrate="rake db:migrate && rake db:rollback && rake db:migrate && rake db:test:prepare"
>
> Make sure that the "down" migration works. Make sure the test db gets
> migrated.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/thoughtbot/dotfiles/pull/47/files#r1613899>.
>
>
Carlos, if register() throws ClosedChannelException, then that channel won't be registered right? I am not sure how it will give you a leak of clientRequestExecutor objects, on the sockets already registered with the selector.
I've gone ahead and split it out to a separate function in utils.js, also fixed soem bugs in it. :)
Will fix and recommit
Fair. This is the downside to using string comparisons, this should probably be changed to just check if its an array.

@narbg I'll leave this vote to you.
Ну и тем более он у вас используется еще ниже — в конструкторе. Если вдруг надо будет поменять буквы — придется по всему коду бегать, искать.
В общем — такие вещи надо собирать в одном месте
Как же он повторится, если alet проверяет уникальность полученного случайного числа в 38-ой строке?
The type should not be encoded in the message, but should be used to determine which outlines/underlines are set in parse_errors. So I would add another 'type' field here which you check in parse_errors. Don't prefix it to the message.
Looks like we're missing a slash? As is, you'd get ``<lib path>/GroupBrackets/cef_data``. I think you wanted ``<lib path>/Group/Brackets/cef_data``.
The change is really just this line and its matching "}" - the others are just tabbed in 1 more level.
Nice so we will have all parameters available later!
Sass, nie SASS;)
I find that to be rather silly, sir.
`append` it also clearer in it's intent than `concat`, and it's not an abbreviation, so it fits better with the cocoa naming scheme.
Why have you add this block ?
Revert this - keep the `desc` call so it shows up in the `rake -T` output.
No need for this comment, you can delete it.
if sort_method == 'kurtosis':
Are there RFC docs that go with these specs? We can link to them like so:

    :rfc:`6592`

If they exist.
Didn't this happen in the "Get Dependencies" section?
less -> more no?
I think it would be great but i couldn't figure where are set the configuration for proxy[:user] and proxy[:password]. How it should be the configured for it to work?
This is all nice, but Camel won't survive this serialize/deserialize events especially if users add there own custom routes.
In my opinion doing this would be unnecessary complexity.

I think Viktor is picky on this point by principle :)
In this context it doesn't make sense to preserve the state. 
Also, if the actor system dies, everything needs to be re-registered.
can you do this (and the line below) in a different commit? This needs to go into 3-2-stable as well and it will be easier to cherry pick from a different commit?
You should explain this in the commit message, then.
Список аргументов лучше не переносить на отдельную строчку, а оставить с capture list на предыдущей.
я лучше не нашел.
Тут бы, кстати, больше угловые скобки подошли.
hum ok, but with the FQCN this voter will be more complicated to use...

Should I try to handle the conversion locally or just remove it?
The following foreach block needs to be checked if this can be refactored with the main code. Under no circumstances we want duplicate code in RC and the main controller/helper.
Better English translation is
"Cache coordinates can\'t be uploaded. This cache type doesn\'t support user modified coordinates."

I haven't looked at the code yet, but could the upload option be disabled if we know the cache type doesn't support user modified coords? Or are you leaving it enabled and using this message so the user doesn't wonder why it isn't available?
Which local modules rely on this configuration?  Can they be loaded with respect to the smart_sample_apps base, or can the appropriate path be established in `mod_py` config?
This is a bit borderline, as the point of the exercises in this chapter was to practice recursion. I'm going to give you the point from this one, but not from the `max-element` function. You are free to submit an answer using recursion to the `max-element` function if you want the point.
shall we change this message?
BTW I wonder if any log is needed at all, we're going to send the WriteSkewException to the user app
Also, this type of refactoring is more suited for a major release, i.e. 6.0, than a minor.
Should create cache be a cluster wide operation?

Or is the client gonna call this on each of the servers?

Otherwise user has to execute this in each server (PITA), and you don't want to promote asymmetric clusters.
Instead of this large patch, it would probably be simpler to add the connection closing in both if() statements which contain a return
This should be fixed in the Symfony Locale component (strtolower($primary) != strtolower($region)) since the symfony locale component doesn't return all available locales, just the array keys from the displayLanguages
Actually,... I didn't clean out my build, so I had a leftover `nxutils.so`. I just converted to use `Path.contains_point`. Thanks for the tip!
Well, since we all seem to be in a moment of discovery, here is a link to
why hypot() even exists in the first place.

http://en.wikipedia.org/wiki/Hypot
p.s. we already have
```python
@image_comparison(baseline_images=['interp_nearest_vs_none'],
                  extensions=['pdf', 'svg'], remove_text=True)
def test_interp_nearest_vs_none():
    'Test the effect of "nearest" and "none" interpolation'
    # Setting dpi to something really small makes the difference very
    # visible. This works fine with pdf, since the dpi setting doesn't
    # affect anything but images, but the agg output becomes unusably
    # small.
    rcParams['savefig.dpi'] = 3
    X = np.array([[[218, 165, 32], [122, 103, 238]],
                  [[127, 255, 0], [255, 99, 71]]], dtype=np.uint8)
    fig = plt.figure()
    ax1 = fig.add_subplot(121)
    ax1.imshow(X, interpolation='none')
    ax1.set_title('interpolation none')
    ax2 = fig.add_subplot(122)
    ax2.imshow(X, interpolation='nearest')
    ax2.set_title('interpolation nearest')
```
So everything is hopefully alright.
Will you will need to add a `manager` to each backend's constructor method? It works well in `pyplot`, but when using the object-oriented interface:

```python
import pickle as p
from matplotlib.backends.backend_pdf import FigureCanvasPdf as fc
from matplotlib.figure import Figure

fig = Figure()
can = fc(fig)
ax = fig.add_subplot(1, 1, 1)
ax.plot([1, 2, 3], [1, 2, 3])
fig.savefig('plot.pdf')

fout = open('pickled_fig.pkl, 'wb')
p.dump(fig, fout)
fout.close()
```

Throws an error: `AttributeError: 'FigureCanvasPdf' object has no attribute 'manager'`

Knowing the `manager` at construct-time means probing for the current backend, which fits in nicely with #1125.
#1448 would provide this.
I'm not sure where this file comes from, but I'd rather have it as a submodule if possible.
Did you fix this when you merged my stuff into yours then? I think it's something I got from Josh a few days ago.
IMO it shouldn't be possible to get a cache entry that expired.
Case-insensitivity of keys is also an important consideration if we use header names as keys. `Set-Cookie: asdf` and `set-cookie: asdfasdf` should go under the same key.
[Issue](https://github.com/reddmetrics/forma-clj/issues/92)
This seems to be true for all widgets touched in this PR. I think in the short term it might be easier to do 2 separate infinite scrolls for regular list view and search.
Spacing before and after `=`
please add whitespaces between casts everywhere ... this is hardly readable.
True, `from()` to get and from('something') to set would make the API a bit cleaner than it currently is.
I already talked to @stojg about this, and he didn't like the `itemisedFrom()` etc either. @sminnee What do you think?
Losing the "site" suffix is fine, but changing "Published" to "Live" breaks the symmetry to the "Save to Draft" and "Publish" buttons.
Is it possible to define the element type for the array of parameter ``$doctrineTypeMappings`` (using ``array<SomeType>``, or ``SomeType[]``)?
I was just looking around here: http://sindresorhus.com/bower-components/ - There doesn't seem to be a central location to register bower components?
I could expand this out to a non-map, or port map from a code library.
I think we should throw an UnexpectedValueException here.
The things we have to do to "restart" CSS animations always confuse me. Thanks for the comment on this line.
Sorry I was too quick you can reduce the `if` statement to:

``` js
if (hasBackgroundPositionXY && /^backgroundPosition[XY]?$/.test(property)){
```

Since adding the `?` is the same as `property == 'backgroundPosition'`
200-250ms is usually a fine check time, but if you tried it with 300ms and it felt good -- great.
It seems like you are mixing checking for `\A|\z` and checking for their absence? I agree it seems simpler to check for presence   with the regex instead of matching anything and then doing a string check.
Can you add a blank line here please?
Did that, thanks for the suggestion :)
No English texts please. Something like "[...]" or only "..." is fine.
std::greater<instance_size_t>, ага
I don't know what `Array(nil)` returns and don't think many people know. It just does not matter.
`DummyTestPanel` -> `DummyDependencyPanel`
I would do it like this:
* run one check if both fields are equal only if they are both unempty, and I would do this on blur (so when users goes somewhere else)
* if previous check fails, I would redo the check on every change, to remove the error as soon as it is possible
* also if password is changed further, i would check again immediately and immediately display the error
Please name functions according to our [style guidelines](https://github.com/wlanslovenija/PiplMesh/pull/199#commitcomment-1707793).
Why would we have non-alphabetical order? I would remove this, and always sort.
(But you have to understand why is necessary to have your own signal. Not because of the location. But because of missing other objects.)
I must say that I don't understand from function names what are they doing.
Can you leave roadmap as default map?
I don't understand how this helps?
And then you could simply call:

```
horoscope.get_horoscope_provider(language).fetch_data()
```
Can you maybe make into a code comment a part of what I wrote above? So this could be useful when we will wonder in two years why we order like this.
Oh my lord what the hell. It looks right on my end but now it looks messed up.
Title should be "403 - Permission Denied"
It's the directory of the source files you want to run coverage on.
Could we use a different row separator?
empty placeholder divs/elements are not a good practice. Use margin on either the content or footer div
I really like Sneaky Pete.
Can do but you're also missing ConfigProviderInterface. Do you want me to add that even though it's nothing to do with this branch?
Nit - please fix spacing.
that's coding convention, it has to be aligned with the above line
Hm, `window.tag_manager` is not that much longer, to store it makes it loom like it might be something else.
I think you can rely on Tooltips here. Also, you can drop the `window.` for classes.
These are only whitespace changes. Git seems to be much more sensitive towards the type of new lines. Our files are not consistent in this regard. Will fix that with a script fore all files, both line breaks and trailing whitespace. But will convert the const anyway.
This check seems wrong. We shouldn't go in the "else" case if randomPort setting is still enabled.
I believe you need cascaded ifs here:
```c++
 if (pref.useRandomPort()) {
   if (!m_randomPortSet) {
     // .. do something.
   }
 }
```

Also notice the space between if and the parenthesis.
I think there is no need to constraint to < 2.2-dev
Yes it does make sense.  To try and answer your question, est_vect are 
the estimating equations.  It does get changed whenever the optimizer 
has nuisance parameters to optimize over.  Nevertheless, it is of no use 
to the end user and the only reason it was an attribute is because it 
was easier to work with.  That said, I will change it around, shouldn't 
be too incredibly complicated.

On 07/25/2012 06:01 PM, Skipper Seabold wrote:
>> +            Value of a nuisance mean parameter.
>> +
>> +        Returns
>> +        -------
>> +
>> +        llr: float:
>> +            Log likelihood of a pre-specified variance holding the nuisance
>> +            parameter constant.
>> +
>> +
>> +        """
>> +
>> +        sig_data = ((self.endog - nuisance_mu) ** 2 \
>> +                    - self.sig2_0)
>> +        mu_data = (self.endog - nuisance_mu)
>> +        self.est_vect = np.concatenate((mu_data, sig_data), axis=1)
> I'm not really sure because I don't follow the code well enough yet. If it's a derived estimate then it should just be changed in the objective function and then attached after fitting. I just don't like that there's an attribute set in a method that's changed by other methods. When is it what? It should only be attached when it's set. If it's something that the optimizer is changing then pass it in. If it's derived, attach it after it's done deriving.
>
> Does that make sense?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/statsmodels/statsmodels/pull/326/files#r1239659
this doesn't work with my version of pandas.

should we use urlopen to stay compatible with older versions of pandas?
ll or 11,   if short names, then ub and lb is better, but I like longer names.

Also my impression is that names and abbreviations change from method to method
add comment to what rwendog is
maybe better name, is moment matrix X'y stacked with constraint  (not a nobs array)

#uses normal equations
please don't remove the authorship. Igor is still the main author of this code
I wonder, should we just supply the brackets ourselves?  That is, should the above read

    @Parameters(name= "{index}: fib({0})={1}")

, but the test would be otherwise unchanged?
Thanks :-)

In general I think there'd be more opportunities to let users tune the graphing using CSS instead of adding more options, though that's of course an entirely separate issue.
L'indentation n'est pas correct pour ce block. Il faut utiliser des espaces et non des tabulations.
As per comment above, I think these might be considered worth moving to the header file.
I originally thought about doing that, but I decided against it on the philosophy that I wanted to reduce the number of bits of SBProfile code that get effectively tested in this one test, so I went for direct calculation instead.
Huh, that is pretty weird.  I have no ideas, but I'll think about it...
I've added a new comment on this file.
Should this be ec2? I see it's the same as was there before but...
This seems like a fundamental change, you're not adding the footer view at all? Why not provide no footerView?
depuis quand on n'aime pas les produits?
I [simplified it](https://github.com/bestiejs/lodash/blob/a3278172ed2dac8729fb794a77b380871da65c6d/lodash.js#L3608-3610):

~~~ js
function escape(string) {
  return string == null ? '' : (string + '').replace(reUnescapedHtml, escapeHtmlChar);
}
~~~
This is craziness!!!
Really not a fan of how this markup is being built in Ruby. Is there a chance that some of it could be moved into a partial? Particularly the state stuff at the bottom.
I can just remove it from the script and leave it on the config file.
I'mma hit you with a trout for this one too.  Revert.
stray line break?
Странный какой-то отступ у JSDoc
cool thanks for the helper
А чем он плох, вполне себе формат, в нем же выведется 3.1415926hellof
У меня ругается на System.lineSeparator(). Вроде бы System.lineSeparator() поддерживается с версии 1.7, а у меня 1.6.
Используй String.CASE_INSENSITIVE_ORDER.
И вывод не должен модифицироваться.
@shacker do we actually need all these commands when we have an rvmrc file?
I'll be closing this for now but feel free to reopen.
this is acs Uri, if acs URI is invalid, the get token request will fail. it doesn't use media service Uri as the scope, strangely!
translators won't like this. please use %s and format it in code
Does this stay monkeypatched for the duration of the runtime of the Python process?

I prefer to use @mock.patch() to do these, as decorators on the test method, to ensure previous state is restored
I added a comment to make it a bit clearer. Don't know it this helps? :s
I'll look into that tomorrow - actually, I was looking for a numpy on-liner that was able to do the one-hot encoding
do you understand what I mean by memory jumps?
This is due to the sign flip actually. As external eigen solvers are called, I just use the absolute values... Maybe I just check it row by row.
Must do len+1, so the 0 is included.
Use QString functions for these manipulations, it will make the code easier to read and easier to maintain in the future.

These has to be a way that doesn't require to do `sizeof(g_unitTypes) / sizeof(*g_unitTypes)` calculation

As a general observation, we should always prefer to use the lib functions over managing and manipulating memory and pointers ourselves.
fix order (sorry I missed this one)
Just to add here – when you added `$cloud` to the `__construct()`, use `setCloud()` from the `__construct` to use its validation.
Replace with `ok_(not info)`
What's the point? Why not just run:

```
setSelectedByHash();
drawGraph(buildAjaxURL());
```
...right here. The init() function doesn't add any value.
It would be more consistent if you didn't have the braces for this if.
Maybe you wanted to say `on the Zend Framework <a>getting started quide</a>`
trace? In this case, we do not need to specify additional subsection.
get_current_site() requires a Request object, which we don't always have access to when code is running in a background task.
i'm sketchy about the ! versions of a lot of methods. Superstitious, probably.
Hmmm, no "," at the end??
Why is the user 'tomcat7'.  This cookbook currently supports tomcat6.
Ah, I see now. You want another describe block, outside of the current one, with this:

```ruby
describe Shoulda::Matchers::ActiveModel::AllowMassAssignmentOfMatcher, "#description" do
  # tests for the describe method
end
```

Is that right?
Nevermind, this approach will also have side effects, I will think of alternatives.
can you refactor this into smaller submethods? its much to large imho.
Why assign to `_positions` at all?
Agreed.  Users love to be able to create objects without actually giving them anything useful.
Good eye @emackey  with ||.  I'm not sure about < 1.  Will the width/height ever not be an integer?  If so, we probably have code that will break elsewhere.
When building this error message, you can just use double quotes inside without any escaping needed.
A declare() example should be in the guides, not the example app. I agree could be misleading, but we really need documentation around mobile web in general so devs know how to extend Ti in their modules.
Discussed with Ping regarding 'androidback' event. The complete fix for it would require substantial rewrite - merging both implementations of 'androidback' and 'android:back'. Therefore I will open a new ticket to address this
.off?

Let's forget the on open here. It's just not anything you'd ever do.

Instead, how about adding a button to the red window, and on click, opening the blue window.  This is a much more realistic use of nav group (and probably easier to follow).
Fixed in b6f59f11fd5f341c4a000222c97776842b4bf148
This will be removed since I don't want users to have to download/compile/install the mysql package if they're not using mysql.
Well, if I interpret this condition correctly then any time a File validator does not have a @package tag that error 50021 will be thrown.
That might have been valid once but would cause headaches for ppl using templates nowadays :)
I think an interface is limited to methods only.  If so, then this can be reworded to say it can only be used with *class* docblocks.
Ah I wasn't aware of the difference. Will fix.
I belive it's much better to return a valid value than to fail in this case. If it doesn't work, it's not a big issue and another case can be explicitly added -- so there's never anything lost from "guessing".
в ие работает `.attr 'type', 'file'`?
Works fine on 5.3+. I've tested it on 5.4.3.

Or you mean we should change it to the real lambda? :-)
As discussed F2F, we need to have something in the cache before having it passed in later will work.
Don't commit this line if you didn't like it ;-)
You are asking it again? Seriously?
Query: should the variables be likethis or likeThis? Just for clarity :-)
Why? There are not any other std Phobos modules following such a pattern.
Your change doesn't just fix `isSafe`, it changes its semantics (as requested by Andrei, but that doesn't make it less of a breaking change). This is why I think we should be clear what we are doing…
Ah, I think what you're implying here is that the overall timestamp of a collection is not the same as the timestamp of the last modified record?

performing an HTTP GET will actually update the collection's overall last modified timestamp but no changes are made to the individual records' timestamps? (wish server documentation was more specific...)
Ah, sure then +1
marshaled only has one l
If we're moving middleware pieces out of core into contrib than then deps (including test libs) should be referenced here (in one place max). 

I don't think we need nokogiri, etc, here.. unless we're explicitly using these libs in the contrib middleware.
These 3 lines look a bit odd ... see if you use tabs in all of them and separate each pseudo-column with just one.
I have some distant aversion to for-in, no idea why, it's prob better! If you don't fix this stuff before I land I'll do it later, but feel free anytime you see it or no array type defensive check :)

On Feb 21, 2012, at 9:58 AM, Simon Murtha-Smith<reply@reply.github.com> wrote:

>> @@ -157,6 +98,51 @@ exports.app = function (app) {
>>     app.get('/deauth/:id', deauthIsAwesomer);
>> };
>> 
>> +function getConnectors(req, res) {
>> +    var connectors = {};
>> +    // get all connectors from the registry
>> +    var url = burrowBase + "/registry/_design/connectors/_view/Connectors";
>> +    request.get({uri:url, json:true}, function(err, ret, js){
>> +        if(js && js.rows) js.rows.forEach(function(conn){
>> +            // if api key
>> +            if(apiKeys[conn.id]) connectors[conn.id] = conn.value;
>> +            // if no key required
>> +            if(conn.value.keys === false || conn.value.keys == "false") connectors[conn.id] = conn.value;
>> +        });
>> +        // annoyingly, some might be local only
>> +        Object.keys(serviceManager.map()).forEach(function(key) {
> 
> Why wouldn't you just use a ```for(var key in serviceManager.map())```? (and below)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/LockerProject/Locker/pull/849/files#r472024
default is ``fos_user_registration`` in order to reflect more FOSUserBundle standard, shouldn't it be ``acme_user_registration`` (changes should also be done in services.xml)
Yes, its something to figure out in the testing story. This is test code.
please don't do this as a migration!  - just add it to Node.  We are building the DB each time - there's no need to add more migrations at this point.
Same as above. Why allow null?
http://stackoverflow.com/questions/1143936/pragma-once-vs-include-guards

ПРАГМА ОНСЕ БЫСТРЕЕ. Я лососнул
это слот. для ввода ключа от пользователя. в фигурных скобках - реализация.
you should be consistent with other filters by using ``throw FilterException::fromProcess($proc)->setInput($asset->getContent());``
@andralex,
sorry again as this time it really sounds offensive, do you understand that you can't show me (and, probably, even imagine) any example of templated function using `destroy` for arbitrary types and still trying to make it work for more and more types?
Do we have to duplicate the implementation here? From what I can tell, just having it in `object.di` should be enough for the compiler to instantiate and use it, no?
we could use Spring's ThreadPoolTaskExecutor as the default, and it extends ExecutorConfigurationSupport which provides a shutdown() method

alternatively (bigger refactoring), we could require injection of an Executor and let the parser handle passing a default, which could itself be registered as a bean in the context so that its lifecycle is managed automatically
It appears as though we should add a null-check here for safety. Ideally, we would actually prevent doStop() from progressing if not in an actively running state, but I don't think that is the case currently.
Not sure I am following. There is an assert after the loop assertEquals(3, counter); If group is empty the test will fail
I use `"` for user displayed strings.
DTO に toJson みたいなメソッドをつけたらスマートだと思います。

Response.ok(searchResultDto.toJson).build() みたいな。
Validate UAtoken
Dave says: test contents of snapshot group record display
Convert to TreeMap
k, last method I created I did request/response.
The later is fixed: smoothing bug was the culprit. The COO conversion issue is a bug / limitation in scipy though.
you can be more precise than `{Object}``. It is a ``{fos.Router.Route}``
двойной указатель... странное название переменной. лучше указать на что
Going to wait on second reviewer before changing this.  FWIW I know a lot of places in the code where we use contains()...get() pattern
This does not actually copy the block since you're not using self.callBack = block. Also, you need to release the callBack in the dealloc, either by calling self.callBack = nil or simply [callBack release];
There is U_SEARCH_USER in root/profile.php , we can use that.
So much cleaner!
Could use a unit test though. :)
Anything relating to the "dragging" variable can do now, e.g. the three lines above, and wherever is it set to true