labofsahil/github-event-dataset-2012 huggingface dataset:
I'm not sure I understand what do you suggest here ? Do you want me to write:

```js
...
'chrome' === 'path' ? 'chrome' :
...
```

instead of generic `isBuiltin(path)` ?
> Please use function form of typeof as suggested by style guide.

https://github.com/mozilla/addon-sdk/wiki/Coding-style-guide
There isn't anything about typeof?
Sorry if it wasn't clear enough, but yes, that's just about that.
This should not be here either, this module should work only with raw dom tabs / windows.
Should this return a CreateKey page object? The page that appears after clicking the create new key button does appear to be a different page from the Keys page.
The comment is not fully true for Firefox 14 and 15 because we also use the GC observer notifications. I think we can make both a single line comment like "Preference to enable GC/CC observer and console messages".
As talked with Bill on IRC we will keep it that way. So nothing to change but good to know.
Do we really need this._length or can we get routed everything through this._buffer?
This method should still not be part of the config module. You probably missed to move it to the logger module.
Makes sense. Thanks for the proposal. Will also be fixed.
Oh, I thought you were supposed to be restrictive in libraries to ensure they worked as expected.  You're right though - if this is going into a gemfile with 50 other things we probably don't want to lock in the version of nokogiri we're using and conflict with something else...
Do we have to bring this in globally, as part of loading the root Puppet module?
Yep, i din't intend to upload this file, i added to the .gitignore file when it was already staged and committed.
It's not very useful to try coercion after we already established it's a Hash. Did you check how MRI handles this case? Does it for example check responds_to? :to_hash, or does it first check whether it's an integer type? We probably need to verify that to ensure we have proper fallback here. 

There is also Rubinius::Type.check_convert_type which basically does what rb_check_convert_type does in MRI. It tries a coercion and returns nil if it fails, so you can retry another coercion.
I was the one, yes.
I guess it can be done that way also. Is there any reason tho?
It introduces additional object property lookups In most cases(AND other cases, when you don't need the stats and the test list, saves you few).
Forces you to add another listener to the end event in your code if you could do everything with "one line".
Also for me personally it somehow degrades the trustworthiness of the stats and tests if you'll have to access them separately, it feels like you shouldn't do that if the callback doesn't give you them to use.
For me, the callback isn't just for the acknowledgement that "it have finished the work", the end event is for that, but "hey, it finished and these are the results".

Again, just my personal opinions. I really understand your point if you see the usual usecase of JSapi not needing the stats and testList in the callback in most of the cases.
So just say it and I'll change it up I guess.
There's nothing wrong doing assignments like this with a direct equation.
That is package was submitted by RobLoach and the sources are retrieved from his fork.
I think that this check is not longer necessary and can be suppressed.
add this param to the doc block
I copied that if statement from the onLoad method. I figured anytime you want to be able to bind an address you will also want to map a port for it.
Path stuff _should_ be in `CPPFLAGS` because `#include` is a statement that is handled by the preprocessor and not the compiler. This is an acceptable workaround, but if Julia buildsystem is relying on `CFLAGS` for header include paths they are Doing it Wrong™ and the issue should be reported upstream.
Add a test for in with empty list, also add a test for nin
I would revert this code to the previous version, and have the dsl decide what options to pass along. Also I would put the default in the construction part of the dsl and not in the definition itself.
|If you are going to put spaces in front, then put the , on the next line - Haskell style. Or remove the space in front. Now it looks like two styles mixed together.
Yes.

Requiring to specify a .eb file also requires you to pick a toolkit and toolkit version already. Leave that open, make it flexible.
Maybe we should just return an array with names here now? Since you can now generate the login url with the other function. Maybe this is more convenient.
Sorry, not ``addHeader``, this method must accept two strings only.
This URL should probably be a setting in case the URL changes and we need to update prod quickly.
if you need to do this it should be in the __init__.py file
So this is basically testing that the root user we create won't have be able to GRANT ALL PRIVILEGES to new users that the root user creates. We revoke the FILE privs now.
これだと「munoh_idsをselectする」という意味になるので、optionsとか使ったぐあいの良い名前に変えてください。
Can we move this content into the RST files in the help plugin. Trying not to maintain raw HTML files if possible.
Is this verified? I'm cool with it, but I thought it was coming back as `doc`
page info like : 112 p. : col. ill. ; 15 cm..   
It is included in  the Description field.
It also contains other information, the information on the site and it completely separated
Does video not require a stream of bytes ready for a video codec to playback? Interesting.
I'm awaiting for Arnaud ( http://share.ez.no/forums/setup-design/no-more-image-variations ) to give me permission to re-access to his server for re-testing my new code change and will commit it.

In the mean time here is the entry in image.ini
# Some shared hosting providers apply memory/threads restrictions that prevents ImageMagick
# from running properly. For example if your shared hosting server restricts the number of spawned
# threads then ImageMagick will crash at runtime or if your virtual host has 8 processors
# but only 2 are assigned to your server instance, the default value of 8 threads might cause
# performance problems.
# Setting the value of MagickThreadLimit to a low value (1 or sometimes 0) might solve the problem.
# For more info, see http://www.imagemagick.org/script/architecture.php
MagickThreadLimit=
are we sure that Dockets should swallow this, not the consuming code?
их можно было обобщить для всех stl контейнеров
Use `https` here, since GitHub will redirect everything to `https` anyway
Hahaha which version is acceptable? Here's mine:

```
PHP 5.3.10 with Suhosin-Patch (cli) (built: Feb 20 2012 22:55:53) 
Copyright (c) 1997-2012 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2012 Zend Technologies
```
requestAnimationFrame here?
Is using ehcache a requirement of PuppetDB? AFAICT its just a Java lib
implementing a cache without any real abstractions to other backends.
On 17 Sep 2012 23:25, "Chris Price" <notifications@github.com> wrote:

> In src/com/puppetlabs/puppetdb/scf/storage.clj:
>
> > -(def resource-identity-hash* (memo-lru resource-identity-hash* 40000))
> > -
> > -(defn resource-identity-hash
> > -  "Compute a hash for a given resource that will uniquely identify it
> > -  _for storage deduplication only_.
> > -
> > -  See `resource-identity-hash*`. This variant takes a full resource as
> > -  a parameter, whereas `resource-identity-hash*` takes specific
> > -  attribute of the resource as parameters."
> > -  [{:keys [type title parameters] :as resource}]
> > +(defn resource-hash*
> > +  [& things]
> > +  (if-let [result (@hash-cache things)]
> > +    result
> > +    (let [result (apply utils/sha1 things)]
> > +      (swap! hash-cache assoc things result)
>
> Right. I think we're just talking about the possibility of a clojure
> wrapper for ehcache... ideally one using the core.cache API.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/puppetlabs/puppetdb/pull/277/files#r1622671>.
>
>
Removed, although this could still happen if there is inconsistency between AuthenticationLoginId and AuthenticationUserLoginId.
Renaming the functions to make that distinction might help as well.
the method ``getHostnameTokens()`` is also not available in 2.1
whitespace around curMonument
Waarom deze veranderingen? Niet blij met:

```js
if (foo) {
} else if (bar) {
} else {
}
```
`$str` here
@dmitrykh покажите, где? Я вижу два разных метода: class method **numberWithInt:(int)** и instance method **initWithInt:(int)**
В задании говорится "В классе создайте переменную DNA типа NSMutableArray". У вас вместо переменной свойство.
Тут точно так же — лучше вместо просто 4 использовать [charsDNA count]
) Я просто учил немецкий. Исправлю.
в задании сказано только "Нужно заменить строго Х процентов", про то, что нельзя заменять значение само на себя - не сказаною Формально условия не нарушены. Ошибка только в выстригании символа из строки "ATGC".
Да, но не всегда. Данный конкретный случай позволяет сделать нам такой "финт". 

Давайте рассмотрим пример. У нас есть два класса:

первый - класс, описывающий абстрактного человека:

`@interface Person : NSObject {
    NSString *name; // имя человека
    NSUInteger age; // возраст человека
}
@end;`

а второй - класс, описывающий человека-работника:

`@interface Worker : Person {
    NSString *job; // должность
    NSUInteger tabId; // табельный номер работника.
}
@end;`

И делаем мы класс, который будет визитной карточкой для какого-нибудь работника в фирме:

`@interface Company : NSObject {
    Worker *man; // работник
    NSString *companyName; // название фирмы
    NSString *phoneNumber; // телефон
}
-(Worker *)man; // геттер для man
@end;`

Допустим, имплементация геттера банальная:

`-(Worker *)man {
    return man;
}`

Возвращаемое значение будет типа Worker, а значит, у объекта будут следующие переменные: name, tabId, age, job. Но мы можем переделать наш метод, пусть он будет возвращать объект типа класса-родителя:

`-(Person *)man { // не забыть также изменить в интерфейсе класса.
    return man;
}`

Ничего плохого не случится, никакой ошибки не будет! Но вместо типа Worker мы возвращаем тип Person, а значит, у нас будет объект только с полями name и age.

Понятно?
As with the comment above, the name of this could than change to clearTrackedResources().
If you don't defer anything, I don't want to hook mongoid.
The Chrome extension intercepts the clicks and makes them open the link in the current tab.  That's what a normal link on a web page does (and at least in the case of the Chrome extension the sidebar really is just part of the current page).
Can't. Have to wait until I've checked if any subscribable has completed that pass before I forward the error.
Also, if two subscribables error and none complete, `zip:reduce:` will forward the latter's error, regardless of which of the two errors was sent first. I think this is a bit different from the usual error forwarding semantics.
I considered using `NSDetailedError` to wrap multiple errors as needed, but then I found out it's part of CoreData and not of Foundation, so I let it be.
I figured if there is more than one error, any error is fine if the caller isn't interested in all the errors. If the caller is interested in all the errors, it's to retry the operation, in which case the other errors will pop up the next try.
It used to read "every `interval` ± `leeway`" but then I found out the leeway is only added to the interval, never subtracted so I changed it, but it doesn't really make sense now.
uri is only used once, so probably can change this to:

    command msg, "http://www.commandlinefu.com/commands/#{query}", (cmd) ->
yeah, thats part of the mega refactoring we just did. ill repost a fresh PR in one second
This is following Zinc's own guidelines, right? And I guess it makes sense to keep it consistent there.
this line seems too long. Avoid lines longer than 80 characters.
I think this is also an option, right @mluessi?
also here it should be enough just to say when(pss.getPatientAttributes(any(Cohor.class), "Person", "birthdate", anyBoolean()).thenReturn(birthdates);
The scenario I was referring to is when a user adds a new module, forgets to register it in the build file and would not necessary notice that it's not optimized in production since it's going to work in dev mode (through client side resolving).  Could not we have both? ie. enable it for the whole folder (or a specific sub folder only) but allowing users to explicitly list modules as well?
Can you please remove the space after the `...`? Also in the other examples?
I think 'throwing' here is not the best word.  "triggering" or "dispatching" are more in theme, and "dispatching" would be better aligned to how we say it in Symfony.
的存在
是否存在
Would it be wrong to remove Cucumber altogether? I can't remember many Cucumber-specific pull requests or issues over the years. Not sure how many people actually used them other than us.
It seems as you say. this style is copy from istanbul.
ok, i fix this style.
done override def get(system: ActorSystem): Camel = super.get(system)
And of course, you need to make sure that the tests are skipped when numpy/scipy are not installed.  Search the code base for test files with `import_module` to see how this is done.
You might have missed [this discussion](https://github.com/cebe/yii/commit/f3bfa1e72c32b0842a336d8d5bfa5a86026a648c#framework/zii/widgets/CDetailView.php-P36).
I named it itemRow since there is itemTemplate and itemCssClass, so it would be consistent with other namings.
Naming of the other properties should be rowTemplate or attributeTemplate but we cannot change API here.
А, я ошибся. Вот какое говно  у меня:  VOL 1.44107 MАX VOL 1
Are you sure you want to delete <em>%1</em>? This action cannot be undone.<br />
Note: if you delete a directory then all files in it will also be deleted.
you should never edit this file yourslef. It is auto-generated by Composer
to be consistent it should be 

```php
setStemming($boolean)
some methods of this class are not documented
should be filtered
Sure, I can do this formatting. I also like the deep-link-to-docs idea. I will do for all response types.
can't we just run the "isTransactional cache" check on the node that requests the txs? if that node is not transactional then no point in making this RPC (small optimisation for non-tx caches)
I don't think so, "-l" is a linker flag in gdc.
Please, use camelCase for variable names: $gitPath.
This part wasn't necessary, but is out of date and redundant. I would be willing to put it back in if requested.
Note the "from future import division" at the top of the file.  That means dividing by 2 gives a floating point result if necessary, so there is no rounding down.
I thought that too. But then if you go to my repository (https://github.com/montefra/matplotlib/blob/plotfile_grid/lib/matplotlib/pyplot.py) ax.grid(gridon) has the right indentation. 
Can be a problem with tabs. I use vim with some selfindent and it seems that it converts spaces to tabs when they are many.
I've tested the code before submitting and didn't get any indent error. I can substitute the tab with spaces and recommit if it's a problem.
Flag and prism might be used as alternatives for ordinary line contours, primarily giving a sense of shapes and gradients; but I suspect they are rarely used at all.  Matlab has them, so we do too, for better or worse.
Good thinking, yes it says number but it's acutally a string!
На всякий случай добавлю для примера что оно скорее всего будет /tmp/onPHP-www-data/ в случае использования веб сервера.
yes, so it appears in the API docs
+1 for one space and using full type names.
For initialisation properties, I started using this pattern of late:

```python
self.__dict__.update({
    'start': start.
    ...
})
```

Which later allows to use ``self.start`` without having to use ``__getattr__`` tricks. It works quite well.
I think there's a typo.  Should be:

```clojure
(contains? #{"hansen" "vcf"} dataset)
```
Not sure what this means. Do you want to make this a precondition?
You can tighten this chunk of code by using String.valueOf(parentFilenameObj). That way you don't need to allocate a separate String parentFilename. String.valueOf() is always safer with sparse Content properties since some strings may be LongString and not be castable to String. 

Also, you can move line 151 into this block and eliminate one if statement.
Os testes existentes do renderer `opds` foram excluídos.
why the spurious whitespace?
This cleans out the old values, so the cache array doesnt include the already set entries as well.
"using for" -> "using"
Like the comment says, this block doesnt work yet - same reason there is stuff commented out in the annotations, i'm not sure how (short of reflection) to read out the value()s of the annotations. This hit isnt a big deal, since we can do it once when we set up the view, and never again.
Not sure how careful we want to be about the wording here, since we don't know for sure these prefs were changed by an add-on.

And I think the second sentence should sound less technical, something more like "Do you want to use the original Firefox settings?"
This may just be for debugging, but if not please use `Brakeman.notify`
"Blog" instead of "Blob"
Ha ha. I just now noticed. `True if request.POST['collapsed'] == 'true' else False` is same as `request.POST['collapsed'] == 'true'`.
OK. Then out `/` at the end.
This. This is unnecessary to do inline.
*Potrdi svoj e-mail naslov*
I don't understand what you don't know. Read documentation. Check examples. See how we have this.
But with my approach you already have this in `request.node`!
Maybe return it from `get_success_url`?

It is very very rare that you have to do anything in `dispatch`.
This is a moving target, `url` should point at a stable tarball.
Just replied on IRC.  Not sure what happened on the line ending change.  It was when I fixed the merge conflict I had and it seems the opendiff tool did that as well.
This is not an issue at all, because Visual Studio 2010 is able to open such solutions - proven, I've tried it.
remove the todo?
brauhaus :)
Can you use directly the constructor?
the utility of this method is simply hiding the need to catch an exception (by rethrowing as an RTE).

This should be documented.

"quietGetProtobufDescriptor" ?
Using an object instead of an array is, indeed, nicer. I assumed you used an array for performance reasons, didn't you?
How come this is removed now?
On 2012-11-2 22:46, Jeff Kaufman wrote:
>
> In src/ngx_pagespeed.cc:
>
> >      // Pass the optimized content along to later body filters.
> > +    // This function should be called mutiple times, send the file only one
>
> We definitely don't want to wait for the whole file before sending out 
> anything: not only is that going to use extra memory but it's slower.
>
> CollectAccumulatedWrites() should still pull into nginx all content 
> that pagespeed has buffered. There aren't memory savings in calling 
> CollectAccumulatedWrites() one buffer at a time.
>
OK. Now I know the "Collect Accumulated" really means.

-- 
Thanks,
-Weibin Yao
Do you know where 855 comes from?
Or maybe it should be returning `allowKey` alone? Not sure what its purpose is. But if aren't going to look at it in `canBecomeKeyWindow`, it can probably be removed. It isn't used for anything else, is it?
my guess (not verified yet)
this should work generically if df_model = nnz_params  
(or because of the current treatment of constant
df_model = nnz_params - 1
df_modelwc = nnz_params  in GenericLikelihoodModel)

Is df_model set somewhere with fit_regularized?
I have not much idea about the fft in the multivariate kde case, but ``O(N^D log(n^D))``  might not be correct for product kernels.  my guess would be that the terms are also ``N*D`` instead of ``N**D`` for product kernels.

I think we should have the work on speed improvements later on, so we can get the current work merged, and the discussion where it might not get lost with a git rebase.
Hmm, ok, looking elsewhere I guess I misunderstood the notation here. I guess it makes sense intuitively, but I'll need to work with this a bit more.
As for me listBodyToInfo only complicates the stuff. If you want - you can rewrite it
Since we symbolize keys whenever a resource is loaded, there's no need to export these files with symbol keys.
Why not make this function a method of the color picker?
@mattpardee I know about the linkify script in util and it's very good. It's just not applicable here, except for project url.
Is this documentation wrong?
This should be more explicit. please tell in the message what you are actually displaying
we don't need glassfish for the weblogic profile.
should be ```image.getScale()```?
This is Gary's code, so I guess it's just an old typo, I'll update it.

On a related point, maybe it might be worth a discussion to retire SBParse?  It does require a bit of maintenance to keep track with other changes, and I think that the Python front end supersedes it.
Which function? They all return values, which one can you not understand?
This lines checks for truth of account.homePage *before* checking that it is an object and that it is defined. The latter check should occur first.
But too minor to worry about here; just for future reference.
Perhaps instead overload the TomcatServer constructor to have a no-arg version, as there was before?
Can we:
this.error = checkNotNull(error, "error")
Annoying duplication in the two deploy methods (particularly with subtle differences in impl such as using `MutableMap.of("backup", true)`.
But that was in the groovy so not going to block the pull request for it...
Any reason for this? I know in c++ `--foo` is more efficient than `foo--` for objects. I could see adopting this as a standard so Node code is consistant. In general, though, I think `foo--` is much more frequently used and as a result easier to read. 

Also, it's more natural for the assigned variable to be on the left of the operator.
@karlcow I'll put the comment when the demo is up and the person can see where it's being used. If they don't like it I can change the image :)
It is not mandated to split anything. It only is said that you can not have more than one statement per line if anything is split.

The only specification is given [here](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#44-method-arguments). Following CodeSniffer that applies for any method call too.

So either it is all-in-one-line, `array('127.0.0.1', '::1', )` or the one in the pull-request.
But whom would this assert help? If it gets triggered, then ScummVM crashes and a user got pissed. If, on the other hand, we just return false, then nothing bad at all will happen...

In a sense, if there was an assert in there, then the whole point of this pull request would be moot (which is to explicitly *avoid* undesired crashes).
I don't know if we have visibility on anything yet.  You might talk to Taylor Keeler about it.
Should the top level group be included here?
Readd these two lines, so it does something.
"at tthe" should be "at the"
It's a little further down, but there's a spot in manualcontrol.c where we have an #ifdef. Line 697 or so. It would be nice to remove that #ifdef and make two version of manualcontrol.c, one for CC, one for Revo (or other names of your choosing).
I think you should remove the lock-file.
Не должно. Но у тебя некорректный расширенный вывод (см. задание)
I'm not sure if it matters, but we might want to consider plugging in random numbers for the coordinates, and then do the comparison (might still have issues with floating point comparisons not being quite equal).  All the comparisons problem stem from trig expressions not simplifying, so we can circumvent that by doing part numerical comparison.
When a component is 'Idle' it means that it doesn't want to receive 'tick' messages.
But if its message queue is not empty, it will be activated by the simulator regardless, meaning it's active.

I guess 'Running' and 'Idle' are not the correct names... maybe it should be: 'ReadyToRun' and 'ReadyToIdle'

On May 4, 2012, at 4:32 PM, Ivan Perez wrote:

>>   case s' of
>>     S.Running           -> return Active
>>     S.WaitingForMsg _ _ -> return Waiting
>> -    S.Idle              -> return Idle
>> +    S.Idle              -> if (null mb')
> 
> Why?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/ivanperez-keera/SoOSiM-ui/pull/1/files#r774431
Did this file need to get committed? :)
You can use `find_by_index(0)` instead which is the same as in @davehunt's example where it just picks the first email out.
私の作業範囲内では「クエリ」と「クエリー」は「クエリー」側で統一してます。
末尾長音の有無は(他の章まで含めた)全体で見ると統一感がないので、次回の打ち合わせ時にでも意識統一しましょう。
単語レベルでの統一感は訳語集を参照するようにしています。
what's this method supposed to be doing?
8.04 support is removed, so we need to update this.
instead of writing ![code].empty?, how about just [code].any? avoids the double negative.
That is not the right format for see also, should be
``thing: description`` I think (don't know which pep).
But we use the wrong format often :-/
I wasn't using this dataset, so I deleted it. I'll get rid of that
This should go into the `fit` method, as well as any other parameter checks.
> Is that a +1 on neural, or on handling this later?

Sorry: +1 on neural
I have changed it as well :p
How does a blank line between if/else make code more readable? It's completely bizarre.
Suggestion: you could combine both as they will always be related

```python
_type2variantCpu = {'simulator' : ('o-g', 'x86') ,
 	 'device' : ('o.le-v7-g', 'arm'),
 	 'deploy' : ('o.le-v7', 'arm')}
```

which then lets you do `(self.variant, self.cpu) = Builder._type2variantCpu[type]`
I looked into it and you need to use `QHostAddress::Any` is hostname is empty and 0 for the port if it's not set
comment should read: `# Check if tiapp.xml changed since last run`
This is only for controls that contain other controls such as Windows that can contain other controls. This doesn't apply to non-UI objects.
Please add the default value of name as a comment for documentation purposes, such as :

void TiObject::addMember(TiObject* object, const char* name/*=NULL*/)
Added as member
Something for another commit, but it might be cleaner wrapping the pos=x, size = ... ;writeDirect into a class that you can use instead.

   DelayedSizeMarker x(msg);
   ...
   x.setSize();
I don't get this...
@richardkchapman should this be documented as the cluster name? queuename?  The term eclserver is confusing.
Comment isn't really right. Either side can use dali....
The `action` attribute is still hardcoded. It should either be just `action="."` if it's the current page or something like `action="{{ url(...) }}"`.

Also, break it onto multiple lines.
Since it's the default value, it might make sense to omit it and verify it uses false by default.
which one do you propose?
at least one case I see, It will be used in `ChainManager` in FpBadaBoomBundle. Each added chainNode will be wrapped depends on `debug` parameter.
We still need to inject the locator, once we know we have a valid controller.
You know, if something works don't touch ;-)
So I do not want to make anything dependent on approved=True since the method has approved as an arg, and not a kwarg. From what I understand, the has_user_perm is supposed to check if a permission exists in a certain state (does not matter if that state is approved True/False)
That doesn't look like a typo to me -- how can `entity_value` be and instance of `datetime.datetime`, `datetime.date` or`datetime.time` if it's `None`?

Is it triggering any issue?
@shacker small indentation fix here.
I believe that was a hold-over from a previous incarnation. Standby.
My DC is Windows Server 2003.  Sounds like our setup is similar... spooky.
This was for svn purposes, can be deleted
Strange... maybe the Cython type inferencing is getting better!
Sorry, this one slipped through. I tried to avoid all of these matrix-indentation things.
I will have a closer look again.

Also, I would not mind at all if you say that you don't like this PR.
Then I'll just add 3 lines of unused variables that I removed ;)
Actually `_make_similarity(dst, src)` is the same as `inv(_make_similarity(src, dst))` but the latter is in general faster.

One problem with the nested functions you suggested is that you cannot access the transformation matrix - this might solve it: 

     def transformation_similarity(src, dst):
        matrix = _make_similarity(src, dst)
        def warp_map(coords):
            return _transform(coords, matrix)
        warp_map.matrix = matrix
        return warp_map

But I don't see a big difference with this implementation except you have different functions for each transformation rather than passing the transformation type as a string. On the one hand you only return the forward transformation as a function object and on the other hand you return both the forward and inverse transformation wrapped in an instantiated class object. Not that much of a difference?

Just to clarify things, I really appreciate your comments and suggestions - I hope my comments don't read "offensive". I am not a native speaker, so some things may sound a bit harsh - at least I am not quite sure if they do.
We don't use nested `describe/describe` anywhere else - it's always `describe/context`.
Did you ever find a better way up/out of this? I presume ``resolve`` didn't help...
Doh. I'm an idiot, went to write a code sample to test this out and realized i had this completely backwards. 

I thought CGFloat forced it to be a double always, instead its either a float or double based on whether its a 32-bit or 64-bit system. So float will be potentially smaller memory footprint but also potentially less performant. To avoid the implicit 64-bit to 32-bit conversion error when you need to use the math functions is to use `tgmath.h` rather than `math.h` (http://stackoverflow.com/questions/7694948/cgfloat-round-floor-abs-and-32-64-bit-precision)
TODO add language string
Yeap.  We will also be able to just allocate one bounding volume and avoid GC pressure.
I actually usually do make these changes as well, but I coped this code over from imagery_layers and just didn't notice it.
Okay, I'm fine with disallowing `undefined`, but that means we should either treat `undefined` in `setText` as `''` or throw an error.
ok removed!
The point is why are we checking this or calling addDialog here at all? (see above comment)

IE:  why isn't TiUIDialog.show() the only place where addDialog and Dialog.show() called?  If it is then nothing other than setting the property is needed here.
you should set (TiBlob) url to a variable so you won't have to cast this twice.
Hm, right :)
Hi Arthur,

Sounds good to me.
Good point. Will do this.
Also, the code was pasted twice :/  I will correct this in the next update.
I'm not sure what's going on here...
I think it makes more sense to use `storage.getItem(key)` to avoid the dependency on `get`. If `get` fails, then `incr` will also fail which makes it hard to deduce that `get` is the source of the failed tests.
With the proposed class design this would become:

    m_backend->install();
typo here: ``wich`` => ``which``
I should have noticed this before, but shouldn't this be a property, or even simply an enum? I'd have expected this to be simply

    enum initCRC32 = uint.max;

Or even better,

    enum crc32Init = uint.max;

(since `initCRC32` is more of a function name, whereas `crc32Init` looks more like the `init` property). It seems really odd to make this a function when all it does is return `uint.max`. I assume that that's what the original did, but if we're improving upon it, it seems rather silly to leave it this way.
How about we change this to something like

> The current implementations of std.string.format and std.string.sformat are scheduled to be replaced in January 2013. They are going to be given improved implementations which conform to writef's behavior. This change will not break code in most cases, but they will then accept only $(I one) format string, which will break any code which which currently uses multiple - e.g. format("%s", value1, ": %s", value2). So, this is a warning that you must change your code so that you do not use format or sformat with multiple format strings, or it $(I will) break when we fix format and sformat. In the interim, std.string.xformat and std.string.xsformat have been temporarily added, and they include the new implementation for those who need it immediately. They will be scheduled for deprecation after format and sformat have been updated in January.

And put it _first_ in the changelog so that it's less likely to be missed. It's a bit verbose that way, but I think that the issue needs to be made very clear or it's going to be too easy to miss or misunderstand.
Technically, array ops will trigger an opAssign, whereas the mem[move|copy] will bypass it.

Hum... well, if we cast to ubyte[] or something first, it could work I guess. I'll keep this change in mind for a later commit.
AFAIK, this is included in OSX by default.  It will still be the old version, unless they sudo brew installed the newer version.
No need to make this request scoped...
i don't know why it says "deleted", its definitely in my list
Ok, I think I've got it now for this pull request. I move the SImpleModel and EOModel to ekb common. Then I can work with them on the ekb level and make the code much more readable I suppose. But I will add an issue to do that also on api level, so that we can remove the ModelUtils completely. WDYT?
we don't use param, throws, return, ... tags. Instead try to formulate the jdoc of the method in plain sentences. In addition pls use the openengsb formatter...
The above two if()'s can simply be `if ($this->id)` and `if (!$this->id)` respectively.
Please remove this line, which is redundant. If your GitHub repo’s name is what you want for your package name, you don’t need to add a package name mapping.
Nitpick: Missing whitespace after `#` ;-)
Yep, done by mistake ;-)
misses type check, so will fail with class cast exception.
did you consider using users/:id/lock w/ POST (lock) and DELETE (unlock)?  That would be more RESTful and keep the routes simpler
Please construct a new HashCollection instead of manipulating the old one using _-prefix properties.
Неа, у нас другой стиль именования приватных членов. ID_, Text_, Author_, etc.
И оно идет до public, сразу после `Q_OBJECT` через пустую строку, вот.
The compass `compact` function will remove false values from a list.
What do we use this timeout for?
Use block syntax to be safe towards exceptions (like above)
skip the parenthesis - it's optional in ruby anyways unless it's used for operator precedence
Gunnar, take a look into `LiteralExpression#getValue`
So, if you're getting just `destinationDirectoryExpression.getExpressionString()` there is no a lot of differents with staying on 'destinationDirectory' property...
And also I think we still should `validateDestinationDirectory` on each message. How do you think: can directory be changed during application work time?
IMO:
1. Just use `this.destinationDirectoryExpression.getValue(this.evaluationContext, message);`
2. `validateDestinationDirectory` on each Message: it may be removed from FS at runtime; its premisions may be changed at runtime

I haven't tested it, but it's make sense on logic
You probably should union them with `xsd:string` as otherwise `PropertyPlaceholder`s cannot be used, e.g. `persist-mode="${myPersistMode}"`.
That is a good point, I need to look. We clearly don't have test for that. The only time it could be null if you dealing with tempReply and we definitely missing a test for that. Good catch!
Include information about why the string is invalid - this should probably read "unterminated string starting at position..." instead of just "invalid"
Correct the name here as well.
Here we have thousands of points and .each can be much slower than for. Google it.

On 29. 09. 12, at 12:48, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/js/datastream.js:
> 
> > +                        if (debug) {
> > +                            debug.find('#debugTable tr:last').after(
> > +                                '<tr><td>' + $.datastream.metricName(data) + '</td>' +
> > +                                    '<td>' + granularity + '</td>' +
> > +                                    '<td>' + toDebugTime(from) + '</td>' +
> > +                                    '<td>' + toDebugTime(to) + '</td>' +
> > +                                    '<td>' + data.datapoints.length + '</td></tr>'
> > +                            );
> > +                        }
> > +
> > +                        if (data.datapoints.length === 0) {
> > +                            return;
> > +                        }
> > +
> > +                        // format data points
> > +                        for (j = 0; j < data.datapoints.length; j += 1) {
> Use jQuery .each.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
This needs to be cut, it just tests that FutureTask.run() only ever runs once.
(Grammar Nazi warning) should this be "we want to fire a propertyReferenced event" or something similar?
It is not what I have in mind. By doing so you are changing a state inside the Admin class (wihch we try to avoid)


```
        return $this->render($this->admin->getTemplate($this->isPreviewRequest() : 'preview'  ? 'edit'), array(
            'action' => 'create',
            'form'   => $view,
            'object' => $object,
        ));
```
you might want to add an assertion or two here about the patient's names.
We are probably going to need this code to support polygons with holes for other converters so I suggest making these functions generic, public, and unit tested so when we need them we can just move the file to a new assembly and make both converters depend on it.
Ok with me either way.
On Aug 6, 2012 11:40 AM, "Kevin Ring" <
reply@reply.github.com>
wrote:

> > @@ -0,0 +1,341 @@
> > +﻿using System;
> > +using System.Collections.Generic;
> > +using System.Linq;
> > +using CesiumLanguageWriter;
> > +
> > +namespace GeometricComputations
> > +{
> > +    public static class PolygonAlgorithms
>
> Agreed, but it looks like Kristian already did the vast majority of the
> work, and the maintenance cost will be low for these fairly simple methods.
>  It would likely to more work to set up the InternalsVisibleTo thing.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AnalyticalGraphicsInc/czml-writer/pull/16/files#r1314410
>
Changes already implemented in branch check_for_empty_target_states_addstatemanager
I'm thinking let's put these in a separate module, make a "lib" directory with a builtins.js. It can be a simple module.exports = { reduceSortByAttribute: fun }, no need for objecty type stuff. I think the index is already getting a little too big for its britches.
This line seems useless ? :P
the idea is good although I think we should write iterableToLookForIsNull
Same as the previous comment: [[self loginView] setToolbarPosition:toolbarPosition];
@nukulb see https://github.com/blackberry/BB10-WebWorks-Framework/pull/456/files#L2R31 for what I mean by custom matcher, it's documented in jasmine here: https://github.com/pivotal/jasmine/wiki/Matchers
Thought this might be simpler but will replace the List with a Memory Stream

On 25 Sep 2012, at 22:03, Tatham Oddie <notifications@github.com> wrote:

In TestingHelpers/MockStreamReader.cs:

> +            else
> +            {
> +                return string.Empty;
> +            }
> +        }
> +
> +        public string ReadLine()
> +        {
> +            throw new NotImplementedException();
> +        }
> +
> +        public Encoding CurrentEncoding { get; private set; }
> +        public Stream BaseStream { get; private set; }
> +        public bool EndOfStream { get; private set; }
> +
> +        public List<string> PreviouslyWrittenData { get; set; }

Instead of writing your own buffer, you probably just wrap a MemoryStream.

—
Reply to this email directly or view it on
GitHub<https://github.com/tathamoddie/System.IO.Abstractions/pull/8/files#r1689649>.
Not sure what you mean. You mean upper casing the user input for mac addresses?
Camel case it is. I did too much python lately where camelcase seems to be an aesthetic faux-pas.
What does `this.toString()` return in this case?

Anyway, LGTM, +1
You are setting a grant extension here, not adding it. So you should rename the method (in the Symfony convention, ``addX`` means you can add several ones).

And once you follow the ``setX`` convention, it becomes clear that it replaces the existing one when reusing the same key so it should probably be allowed.
On the other hand, does it really make sense to limit it to 1 extension per uri or should it be possible to have several ones ?
не очень объясняет
This is indicated in the platforms key.
I  updates the doc that these methods are being called by Ti platform. But really no idea when they are called. The only used method I found is startup.
bad naming, this extension is not a sample
We should be asking info/collections whether we need to do this. Add a TODO referring to Bug 726055.
It will only reach the addEventListener or removeEventListener if your actionMap has added that string.
Then what is the point of the switch statement in the addEventListener and removeEventListener.

If you remove this switch then its one less thing people have to do when they add a new application event :)
This logic is for the controller webview.  It previously lived in the webview.create() function, which would setup the controller, and then init the visible client webview.  We could move this to a controllerWebview.js.

Now that you mention it, chromeWebview is a confusing name.  I'd like to call it overlayWebview.  What do you think?
what should once be renamed to?

----- Original Message -----
From: Jeffrey Heifetz [mailto:reply@reply.github.com]
Sent: Friday, May 18, 2012 12:56 PM
To: Rosa Tse
Subject: Re: [BB10-WebWorks-Framework] Pull Req: Refactor event code (#37)

> @@ -40,12 +40,12 @@ function _on(featureId, name, cb, success, fail, once) {
>  }
>  
>  module.exports = {
> -    on: function (featureId, name, cb, success, fail) {
> -        _on(featureId, name, cb, success, fail, false);
> +    add: function (featureId, name, cb, success, fail) {
> +        _add(featureId, name, cb, success, fail, false);
>      },
>      
>      once: function (featureId, name, cb, success, fail) {

If we're going with add/remove do we want to keep once?

---
Reply to this email directly or view it on GitHub:
https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/37/files#r846409

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
would be nice if the default parameters (localhost / 347882319) would be exposed in the signature, so they also appear in the generated documentation.
-Incorrect indentation for this block and most other comment blocks below
-This file does not comply to the code convention
from ...?