labofsahil/github-event-dataset-2012 huggingface dataset:
If I got the old code correctly, we only tried to add options which are usable for the specified target here. Now we always add the KQ6 specific cursor setting for example. This seems like a step backwards from a usability point of view.

Maybe it would make more sense to only store the GUI options as a nested array, but still only return an Array of options which actually apply? Note that this could still be done with the suggestion to use IDs to account for this problem. The benefit of returning an Array with all available options is just that we can easily decouple the client code implementation from the details on how we store the available options internally.
I suppose this should be self.hdop = hdop
Could this be used for use to set the ```PKG_PATH``` environmental variable in the freebsd pkg module before running it in a state?
hum i thinks that we need some spawn :S
Why I don't have any errors when applying to the base (using SQLlog) ?//Damn, can't understand. Thank u for the fixes
The test unit test the case where there is no TaskRun in the DB and it is working so far :), so I do not fully understand you, sorry.

The starting point for every application will be a DB with some tasks but with no TaskRuns at all. Thus, the newtask should provide one task at least, even though there is no TaskRun.

When you ask about left outer join, do you mean this?

from sqlalchemy.orm import joinedload
q = Session.query(Task).options(joinedload(Task.task_runs)).filter(Task.app_id == app_id)
I think thats a good way
Very minimal I see
If you still get this error, can you try disabling -static-libgfortran from Make.inc?

-viral



On Jan 29, 2012, at 1:30 AM, JeffBezanson wrote:

> Now I get this during configure:
> 
> ```
> config.status: creating PARPACK/UTIL/MPI/Makefile
> config.status: executing depfiles commands
> config.status: executing libtool commands
> /usr/bin/ld: /usr/lib/gcc/x86_64-unknown-linux-gnu/4.6.2/../../../../lib/libgfortran.a(stop.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
> /usr/lib/gcc/x86_64-unknown-linux-gnu/4.6.2/../../../../lib/libgfortran.a: could not read symbols: Bad value
> ```
> 
> This looks similar to the static libgfortran linking issue.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/JuliaLang/julia/commit/ca87935a7d50d7e63527ab2bbe408608d4fbe642#commitcomment-911171
The intention with this commit was to allow the GUI to adjust the time.

Then I thought that the GUI can already adjust the time. This commit makes no difference for the GUI.
what exactly was the problem with 0.13 kaminari version?
rails 3.2.1 isn't compatible with 0.12.4,
patching kaminari would be much better solution than introducing your own pagination, but what exactly was the problem? I'll try to fix it.
I test it and work properly :)
it's true, but in current place logic changed
from a || b || (c) && d
to     a || (b || c) && d 
need see on result more accurate
These can be combined into one anonymous function argument, to pass to `dojo.addOnUnload()`.
Of course, I would expect so, it's pretty cool but might not be the best solution.  I'd love to hear your feedback.

Thanks, Amro.

-=Scott

On 1/8/12 4:54 PM, Amro Mousa wrote:
> Sorry for the delay. The only part of this I'm immediately timid about is the tagging. I'll look at it more tomorrow.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scottley/uakari/commit/19897ffb23a7d350cb0a4220365d78e01bfe6e49#commitcomment-848293
On *nix boxes I'm not sure what the discrepancy is. Works fine in Windows.
Fixes gma/nesta:#101.
I look forward to your PR.

On Mar 7, 2012, at 3:01, Nick Minkler <reply@reply.github.com 
 > wrote:

> with the new EntityType class shouldn't all of these || statements  
> be cased away?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sk89q/worldguard/commit/7fd424cf65611c992e386cb21ff803b5ff6890b2#commitcomment-1052219
pourquoi ne pas utiliser ta propre API pour les asserts plutot que de passer par redis (détail d'implementation) ?
j'ai l'impression que tu testes l'API de redis.
The taskbarItem also shows up in for example Tint2, this means its not a problem of the extension. Most likely its the windowmanager that registers it wrongly, or the application registering itself wrongly to the window manager, i expect this issue to resolv itself overtime.
For clarity this could be renamed as insert() and finish_sync could be renamed as save()
I'd use `false` instead of `0` here. It makes for a bit more code in `copy_move`, but that way `copy` and `move` doesn't have to know about `copy_move`'s implementation.
Se agrego el id y la persona propietaria de la Agenda
belirli düzen derken?  bak orada kritik olan `File.mtime`.  yani?  dizinler en son değiştirilme zamanına göre sıralanıyor.  en tepede (1 numara) son değiştirilen (erişilen) oluyor.  düzenle/bak çevrimleri için ideal.
Sure--but for that use case, you can specialize to the (much easier) non-Windows case for now.
yay code dupe
Size is a string, passing a 0 means doom. :(
you can replace this whole thing by

return objectType == typeof(TimeSpan)
Actually you can disable mmaps only in problematic tile.Far from optimal, but better than nothing.
たぶん`@input_terminals`
yeah~~ thought of doing this something ago too :)
"boolean returnObject" is probably the same as "boolean out", we should remove it, but add it in the protocol handlers for backwards compatibility. I 'll look into this.
Why do we need this type of chain nodes?
don't we need to filter by application? https://github.com/robhudson/zamboni/commit/bff22583f6#commitcomment-828588
I have done this one by an <add-resource>  in the device tree to keep config.xml AOSP.
Nevar!

http://alltheragefaces.com/img/faces/large/okay-okay-l.png
i just tested, now its fixed and doesnt show the not authorized message
Is there a reason you have to refire the click event?
Sure, but jsut be aware that the mini_dump there is flawed. At least back when I tested it against the original service impl I got a lot more issues with it then I got with this variant of the full dump.  But at some point creating a new mini dump to reduce test time would be beneficial, and also somehow reusing this stuff across the tests as well.
very nice initiative !

would be great to have a python module too to load the data like with do with the scikit-learn

>>> from bcidata import load_foobar
>>> data = load_foobard()

just suggesting :)
hm, now i am confused. should we rely on the document having an id field? is it mandatory? why does it need to be mandatory? if i have the name and parent, its enough to define the location.

in 30def91811bd9e310bde1c62cddae970f444b103 you call $class->setIdentifierValue($document, $id); does that mean now we should ask parentCm->getIdentifierValue($parent); and this will work even if the $parent has no id field? does the metadata store its own map or ask the uow again?
Er sagt an der Stelle "And just something that Windows does for me." und meint damit die "Taste drücken um Fortzufahren"-zeile.
Oh, sorry about that. I guess I should be a little more up to speed before submitting stuff. Thanks for getting that set up Jay.
Concat is pretty darn fast http://swingpants.com/2009/03/12/fastest-way-to-copy-an-array-concat-or-slice0/

Also, these arrays are always tiny. Thirdly, I did this specifically because formatMessage() modifies the array. I suppose I could iterate over _targets twice and notify the Preformat targets before formatting, but that seems worse than this.
Yes, it's because while the typechecker depends on `.src` extensions, the compiler accepts either `.car` or `.jar` so both must be tried in this order.
Right, I'm reasonably confident that this fixes it: https://github.com/CocoaPods/CocoaPods/commit/fde621d0173429a5fce7c69fb11aaf8ea1d3c787

Please sanity check it for me if you can!
Yup, looks good to me. I’ll try to work on the Xcodeproj integration a bit more later today, but not sure if I will have time.
Can we lose all the es5-shim comments? Just for fun.
Congratulations for ICC ;-)
Du brauchst eine gültige E-Mail Adresse um das zu tun.
Can you use the <progress> tag instead?
@parndt thoughts?
The function shouldn't be called "bookmarks_notify_message" as it will now crash the site when both the blog plugin and bookmarks plugin are enabled. Also the 'blog:via' language string is not defined. Make sure you test your code before making a pull request! Thanks.
how / where does AutoComplete come in to the picture ?
Need a `class` attribute here to describe what this templated link does (i.e. what kind of results will it return when submitted).
The only code-level thing I have on this series is pretty minor, but: 
as I look at these macros I foresee a lot of stupid bugs because we accidentally change the wrong value when calling ENCODE_START, and because ENCODE_START and DECODE_START have the parameters in different orders we're going to get those wrong.
Perhaps the macros should just assume that struct_v and last_compat_v are defined before they're invoked, rather than being passed in?
Не меняй условие
To be honest I can't remember if this fixed it. I can just say that Oozie works fine for us now with the configuration we have online here.
Scott,
I did get several xml parsing errors by simply including org.hibernate initially due to which I was forced to debug and add these dependencies one after other for the tests to run successfully.However it is really weird that I tried removing them and re-running the tests after your last comment and surprisingly they run fine with simply inclusion of org.hibernate.envers and org.hibernate in manifest!!
I do not have any good explanation to this apart from the vague fact that I must be having a stale maven repo on my local which was not refreshing.Maybe you have a better explanation why this should happen as I am using the nexus public repo in my settings.
I will update the tests .
This is a bad idea; most of the merges happen on non-macs where the xcode project can not be sanity checked which is why that is there.

To get around this in `.git/info/attributes` you should add the following:

    *.pbxproj -crlf !merge
    *.xcworkspacedata -crlf !merge
    *.xcscheme -crlf !merge
please use elif
Oh thank you! Must have overlooked that somehow :-/
Reverted commit in 10dffd3, see notes on pull request.
Thanks again; did I mention this was quick and dirty?
Very cool! I tried to do, but I ended up failing. Where can I find material to explain these settings in Vim?
Can be made a list, yes?
Me imagine que era por algo así =)
Neeeiiin :-) Hoffentlich implementiert Blizz ne neue verschlüsselung wo dann die priv server vorerst am ende sind un cata noch gaaanz groß auf priv servern rauskommt.
does this fix Live Wallpaper?
Basic and static playlist should be working, not done much testing yet, pushed so I can continue working on this at work.
Pour clarifier mon commentaire :
Pour ajouter une dispersion d'énergie globale (par exemple, résistance de l'air), il suffit d'éditer cette line :
+  myPosition += ((myPosition - myOldPosition)*(dt/prevdt)) + myAcceleration*dt*dt;
Par :
+  myPosition += 0.99f*((myPosition - myOldPosition)*(dt/prevdt)) + myAcceleration*dt*dt;
en remplaçant 0.99f par une constante définie dans le jeu bien sur.
Mais ce qui m'ennuie c'est dans le cas d'une liaison très peu élastique, le mouvement devrait s'arrêter rapidement, au point que cette constante devient négligeable, je ne sais pas comment implémenter ça... Spring ne fait qu'accélerer ou ralentir l'oscillation...
please really fix compile. And maybe need test it before scribe "test broken compile" ?
Fantastic. Using the fluid layout is something I should have done from the start. Well done.
Hi,

I was wondering what issue this commit fixes. (I'm not at all versed in vim syntax highlighting)
This commit has broken some of the syntax highlighting for my html files.

I use underscore.js templates within my html files and they are usually wrapped within a script tag.
For example,

```html
<script id="widget_template" type="text/template">
blah blah blah
</script>
```

This commit has broken that highlighting and I was wondering if there was perhaps a way I could fix it?

Cheers,
Xianyi
Why do we need this change and can't still handle it with shutil.move? It's nothing recursive we have to take care of. Also moving is way faster than a copy and delete command.
je n'ai pas du tout compris pourquoi SoundEmitter et Playable héritent de collision entity, c'est assez etrange, a la limite Payable, mais pourquoi soundemitter?
Has he decided on a library yet?
"> organização ": extra space between "> " and "organização"
well, actually. the port for the web api is 55672. http://hg.rabbitmq.com/rabbitmq-management/raw-file/rabbitmq_v2_7_1/priv/www/api/index.html
I think a 0 too many in the netaddr3 test
Followed the instructions to run ./rpm SPEC/<spec file> on CentOS6.2 and I get the following error: 
/SPECS is not a regular file

Looks like the .spec file isn't being included into the spec variable.
Rova: can you name the file appropriately  : new_questionnaire_wizard.js (the questionnaire wizard was old UI and now there is no wizard)
That is to say $pkgid/$compiler based directories to keep packages and compiler apart to support multiple compiler versions in sandbox.
That's a "trick" I think you shouldn't play. Why not add the directory only when it contains content? I've deliberately removed all the skeleton directories from the repository before (the ones for the legacy Makefile build).
Looks good to me. I'll merge tomorrow morning. Big thanks!
Ebenfalls nur ein Hinweis ;)

Alternativ kann man auch das schreiben, falls man es schöner findet:

```php
<?php
$gm->setQuery('select * from '. rex::getTable('module') .' where output LIKE "%'.$searchtext.'%"');
```
Maybe this should be part of refinerycms ?
Deffo

(yes)
there is syntax error in this commit for if(..) block in ChildBrowser.js  . My Application didnt work with childbrowser after pulling this commit.
Remove { in line 50 and 65 .
OK, thanks for pointing me to those functions. Makes sense.
This can be removed completely
Some minor comments above.  In general, it looks very good.  I like it.
The new build is up now and working for me: http://travis-ci.org/#!/jonleighton/poltergeist/builds/512154
use "Deferred" instead of "deferred" by follow cjolif's suggestion -- keep the capital letter for "class" type
No, pero no es bueno nada que salga del culo. Asi que esta tarde lo meto.
I thought about that one, the property has been part of the class (trough inheritance) since the big bang. I mainly see the use that tags to tell devs since what versions this will work.
В старых версиях скрипта был именно ентот регексп, довольно популярный в интернетах.
Но потом аз нактунлся на статью с бенчмарком, где любопытныя программисты нашли самый быстрый из всех вариант - тот, що вы сейчас выкинули.
Again, I would be much happier if this was in TestClientsDatabase (parallel structure to Test...).
The script should always provide message how to use it. And, the script should be stored in bin/ directory.
@stof: well, crap.

``` php
<?php

interface A { function getId(); }
interface B { function getId(); }
class C implements A, B { function getId() { return 1; } }
```

```
PHP Fatal error:  Can't inherit abstract function B::getId() (previously declared abstract in A) in /home/jmikola/foo.php on line 5
```
That's the thing with showoff, it adds its own margin from top to center content, but in normal cases like the agenda and title+text slides, we want a fixed 120px padding from top.
With this change, the agenda and title+text templates look wrong. Why do you need it at 0 ?
AchievementMgrBase dosen't exit delete this for fix build in linux
@gunnarmorling @hferentschik the question then is how should this flag look like?

- global per `ValidatorFactory` / `Validator`
- local per getter

It seems the latter is more appropriate and once we find the vehicule for the group that will be validated, we could use the same approach for this flag?

What are your ideas in the area?

PS: I'm neutral on validating getters when methods are intercepted.
Personally I don't really like the approach of storing the class name as string and instantiating it via reflection. While it does remove the hard coupling via the import statement the type of the implementation would still be known in the API class, thus actually leaving the dependency, at least from a semantical perspective.

Regarding the service loader approach, I wasn't aware of any problems under OSGi, as long as the resources to be loaded and the client using the loader are contained in the same bundle. Do you have a link or some other information regarding the META-INF issue? I'll try to found out more on that.

I'm starting to wish that we could base HV on CDI which would solve that kind of issues for us ;-)

Another idea might be to demand Java 6 as runtime for HV which would give us the service loader for free from the JDK (without the qualifier functionality, though).
@douglascamata don't repeat yourself!!! todas as primeiras 3 linhas dos cenarios, crie um "background do" e coloque logar, e a instancia dentro dele ;)
Hi,

The Computer Guys is inviting you to join Facebook.

Once you join, you'll be able to connect with the The Computer Guys Page, along with people you care about and other things that interest you.

Thanks,
The Computer Guys

To sign up for Facebook, follow the link below:
http://www.facebook.com/p.php?i=1363206074&k=AQB5VaBvikWSKMWfajwXJFyaVsS6ldsljWRr9gheEb6x4hySZvY80UqXG2fVqR8zRxE7H3tePEncJHwE&r&oid=154595704566248

You are receiving this email from The Computer Guys. The Computer Guys has sent you this message through Facebook. If you no longer want to receive messages through Facebook, click the link below.
http://www.facebook.com/o.php?k=09386b&u=100003504049952&mid=5ad3f16G5af3e155cf20G91fddG7c
 Facebook, Inc. Attention: Department 415 P.O Box 10005 Palo Alto CA 94303
ah, except to mention that you can load that appcache template via the require('text!./tools/manifest.appcache') at least I think that should work. Otherwise a straight file read from v. can do it.
Either way is fine with me. Just wanted to say that if you wrote the code
you should get credit for it. Feel free to add your name to any new code
that you are modifying in a way other than trivially.

Chris


On Fri, Jan 13, 2012 at 2:16 PM, alanrushforth <
reply@reply.github.com
> wrote:

> Hi Chris,
>
> I am not really sure how copyright works on this sort of project. I didn't
> write the original MacFrame class so I didn't want to change anything to do
> with the copyright notice. If it seems reasonable to you I will leave your
> name on all the classes that existed when I started work on the project and
> will add my own name to any classes that I have actually created.
>
> Cheers,
> Alan.
>
>
>
> On 13 Jan 2012, at 01:10, chmorgan wrote:
>
> > Copyright should reflect who wrote the file
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/alanrushforth/Add-802.11-to-Packt.Net/commit/2db9193f897617e200c920d3ca11421a251c44c1#commitcomment-863165
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/alanrushforth/Add-802.11-to-Packt.Net/commit/2db9193f897617e200c920d3ca11421a251c44c1#commitcomment-865858
>
Regarding the brakets: well, it doesn't change anything. I prefer the brackets because I like to think include as a function. It's all about preferences. Thanks for the suggestion about is_readable() but it was not me that added that line. Anyway I'll change this later.
Thanks.
Yes. I had it where the connection was first established... And if it dropped, I guess it was causing problems (Like a bad cert?). With it in this position, the proxy has to actually receive data before we get the ip. So it should never return nil, because there is already data transmitted, and the connection is active at this point.
This feels to me like the logic is perhaps in the wrong place, and we should be handling this in the class not as a module level method.

I'm also not sure if this is not RFC breaking http://tools.ietf.org/html/rfc1808.html

```
 <scheme>://<net_loc>/<path>;<params>?<query>#<fragment>
```
mw.loader.load doesn't return deffered object. $.getResources should be used instead
where are you delegating to the parent class?
This shouldn't return Any. It's Unit
That is plain wrong. Thanks!
and that wasn't caught by tests? scary
Actually, I just thought of one - it is possible to have the jar on the classpath but not have the os-specific lib installed properly or the jar if you don't know what you're doing. The differences may be helpful to a user during setup.

I'll log it.
this is incorrect, if Member already exists in localGossip.members it will not be replaced by the new member (LEAVING)

test coverage?
There's no check here whether reader is already non-null or not.
have you tested that this actually works? wasn’t there a problem when mixing different netty stacks in the same thread pool?
This looks really useful, would be interesting to see some test cases using it (I mean in TestTransportSpec for simulating complex series of events).
Add an empty line between all of these, for readability
Make into Try
a) same method defined twice
b) hard to read (esp second version)
@domoritz Aha! Many sorries. This is backbone and not jQuery. Continue as you were.
backslashes in quotes make me feel sick better to use
("..."
 "...")
```
if kwargs.get('note') is not None:
```
Remove commented code. Or handle this gracefully.
Doesn't seem threadsafe...maybe we don't care. Is it the best way of handling zk client hickups
thank you will change this asap
Hm I'll have to look into it. I'm getting confused in CGUIMediaWindow as I have multiple branches with changes in this area (advanced library filtering e.g.). It should filter the unfiltered list but maybe I messed this up.
as above - this check should be unnecessary
well, the syntax is correct now, but you have changed the meaning of the code; for example, what is the value of `i` here? and what is `i+1:34`?
is .txt the right extension? (it might be, im just weary)
I suppose we could, but why would that matter?
Why is this added here? It seems unrelated to the pull request.
This frame overlaps the text in the cell pretty bad, especially when tick marks are on.  Also, 32-5?
That's very true... I'll remove that "abstraction". :dash:
Oops, forgot this one, sorry.

You can use `baseURL` in place of the string `analytics.bluepyth.fr`.

Sorry for the trouble x)
This needs to be cast to float - Python can sometimes give funny comparisons with number-like strings.
Is it intentional to drop V in `IP4Word`?
Doubtful, because calling a function just to add two integers or floats together would be exceptionally slow.
Here is a better way to deprecate until removal, i think.
I think I'd rather use `full_messages.to_sentence` instead, which creates a nicer sentence.
Typo `multipart`
Would it be better if `ActionController::Parameters` wrapped a `Hash` rather than inherited from `ActiveSupport::HashWithIndifferentAccess`? For example `CookieJar` used to inherit from `Hash` but was changed in 0ca69ca. @tenderlove, what do you think?
Thanks for your feedback. 

- Will change to the new hash style. Should I change also the other occurences  of the old hash syntax?
- I'm pretty sure it is the only use case, yes. https://github.com/rails/rails/blob/master/activerecord/lib/active_record/reflection.rb#L529
Ah yeah, it was using a class variable before.. great, thanks :)
How about:

```ruby
controller.respond_to?(:request) && controller.request.env["HTTP_REFERER"]
```
Ok, I'll ping you when it's done. Thanks <3!
Looking at the usage of isParamAccessor in Symbols it seems that my assumption was wrong. So leave it as it is.
EVE likely does not belong here :)
(and that no test failed might just mean that this is an uncovered case for which a test should be added)
Why not `False`?
Shouldn't this remove all zeroes?
I agree but … why? [It's 77 characters ^^]
Again, I don't think the added brevity in `f in d` over `f in d.morphisms` is worth the decrease in clarity.
Why are objects and commutative treated differently. (My guess would be that `FiniteSet(commutative)` raises an exception if it is not a finite set. If so, please add a short comment. Also I hope this is tested ;).)
Which versions of Zikula were version 1.04 and 1.1 of this module shipped for? I think possibly this line needs to say, and the one on line 90 should go.
You can either use UseProxyName("my.pacakge.Test") or @UseProxy(Test.class) (see Person.java). I have added UseProxyName equivalent to ProxyFor/ProxyForName just in case if the proxy class is not available to the server-side.
Thanks for catching that.  I'll push the fix ASAP after re-testing.
I agree, we can remove the code.
So then just `$this->Form->create('Post')`? I guess the 1.2 way of specifying everything is ingrained.
I can see both sides, are there precedents around this we can lean on to help make the call?
Ah yeah I forgot about that... ;)
I don't think proper is the right word here. The results are accurate or they're not, and although the meaning is clear, it seems to imply that MongoDB can determine the difference between propper/improper, when really it can just test for correctness.
What's a "record document"?  I've never heard that term.
I thought so, yes, so I wont touch this.
Get rid of the changes in this file: `git checkout master app/controllers/pandora/base_controller.rb`
Oui, c'est vrai dans les deux cas c'est *responsive*. J'étais mêlé.

Par contre, mon commentaire demeure: mélanger les deux (*fluid* et *non-fluid*) n'est pas recommendé. Voir par exemple cette [réponse](http://stackoverflow.com/a/9897227).
Probably cast $config value to int to avoid type conversion in expression.
Yes, "abused" is the right word. Abuse should be prevented.
`</option><option value="retain"` also isn't closed.
Well that's a problem with your editor, not a reason to duplicate the comments all over the place. This will just result in someone changing the implementation & documentation but forgetting the interface or vice versa.
double space?
Functions like unique_id() use the $config variable so I was under the impression that I needed to declare it global here and modify it appropriately so that unique_id() and others would work as expected.
this whole lbock makes no sense? you get 1 block that has basename = 'ucp_pm' and and update it's basename to 'ucp_pm' ?!!
Space after cast.
phpBB does not use camelcase ;)
Oops, was this on purpose?
Okay, almost there :) So, shared key `enableOutput` or specific keys since there are only two (`enableHtml` and `enablePdf`)?

    enablePdf in Sphinx := true

    enableOutput in generatePdf in Sphinx := true
Noted. There's nothing in the style guide about variables so I took a stab in the dark.
When this pops up in valgrind, that'll be the first thing I do   ;)
punting, as problem not introduced by RS redesign
Delete a line, then add it! What.
Dit mag helemaal weg. Heb ik inmiddels volledig in ZF2 zitten ;)
You should really learn writing comments, I have no idea what are you trying to do here o_0, not that I understand other code :confused:
Why did you remove this? Seems to be unrelated to AI development. It might be essential for the single-player campaign (not sure though).
Two variables changed from Float to Int.
if possible, prefer more meaningful names rather than prescriptionfill1 and prescriptionfill2. The only advantage of #s is that it suggests a clear flow. Otherwise, they are not too helpful.
The result file could do with being renamed.
Consider yourself demoted from demi-god to mortal.

Welcome to the club!
Perhaps the `GeogCS` could have an `earth_radius` attribute? I'm not convinced.
I think this TODO is not needed anymore. Otherwise, I don't understand it.
Nope, I purposely added tabs and brought this into inner loop of if OK. Same as with above, not doing anything extra if we know error condition already exists.
weird construction, please verify
Anything that is a constructor for an object should be uppercase. Otherwise, lowercase it is.
Please add param doc.
Yes, I was in a different coding standards context.
This should have an error right?
This line has no whitespace padding between pre compiler directive and hash, while the next line does. Am I seeing things?
It would be helpful, if you get a moment. -> http://www.opera.com/browser/next/
Mmmm, good idea.
Class name should match file name
No, because it's called from here: https://github.com/bjorn/manaserv/blob/4ae1d70bcd25b7344ad666e236c4aac2add3e1da/src/game-server/accountconnection.cpp#L233
As mentioned earlier, wouldn't it be more natural to only care about URIs here, and if possible make the name issue a MPD frontend problem.
The responsibility of core is to …
I was thinking about making these two calls decorators. Thoughts?
As a side note, this is a totally lame syntactic lame thing in Python for exactly this reason.
Can you write a function to create the tests for you?
Is this also a raw string?  I don't think it is, so either you can get rid of the "r" at the start of the previous string, or add it to the other three.
(You're not using backslashes, so I don't think it matters much either way.)
You can just omit the test.

Sucks that it has to be run as root just to dump the help text (I assume thats what `-h` means).
@mistydemeo Perhaps I got you wrong, but to make it clear: Our `MacOS.locate` uses the `/urs/bin/xcrun`, so it is not using the `/usr/bin/locate` binary or something.
Having said that, the `MacOS.dev_tools_path` does not calls `/usr/bin/xcrun` itself to avoid any chance of an infinite recursion in the future.
Cool. Seems reasonable. A simple "another Homebrew process is using this formula, try again later" or something might work.
sorry I just realised my previous comment was completely lacking social skills.
early morning no coffee and zombie style playing with pySurfer, anyhow,

I installed pySurfer this morning using easy_install and the nested try except that you just mentioned being in the master was not there yet.

but yes, this seems good. I changed my local copy of viz.py.

Thanks for making pySurfer by the way. I like it. 

best

ian
Lo digo porque en otra parte de la traducción lo has traducido como crear: https://github.com/revington/api/commit/2b20d6dbe2a2a5cdaf9d2b9a741f82bcdc3582ad#L0L88
I'm happy for us to potentially skip Riak tests if Riak isn't running but I think that needs to be done more carefully in a separate branch and probably doesn't have anything to do with txredis?
> started with `tag/`

Is it a typo? Shouldn't it be  `tags/` here?
Doing that requires an additional (K, A) => B for the elements not in
the intersection.

On Wed, Aug 1, 2012 at 3:45 PM, Jason Zaugg
<reply@reply.github.com>
wrote:
>> -object map extends MapInstances
>> +trait MapFunctions {
>> +  final def intersectWithKey[K,A,B,C](m1: Map[K, A], m2: Map[K, B])(f: (K, A, B) => C): Map[K, C] = m1 collect {
>> +    case (k, v) if m2 contains k => k -> f(k, v, m2(k))
>> +  }
>> +
>> +  final def intersectWith[K,A,B,C](m1: Map[K, A], m2: Map[K, B])(f: (A, B) => C): Map[K, C] =
>> +    intersectWithKey(m1, m2)((_, x, y) => f(x, y))
>> +
>> +  final def unionWithKey[K,A](m1: Map[K, A], m2: Map[K, A])(f: (K, A, A) => A): Map[K, A] = {
>> +    val diff = m2 -- m1.keySet
>> +    val aug = m1 map {
>> +      case (k, v) => if (m2 contains k) k -> f(k, v, m2(k)) else (k, v)
>> +    }
>> +    aug ++ diff
>> +  }
>
> Perhaps generalize this to `(K, A, A) => B` ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scalaz/scalaz/pull/116/files#r1286263
please don't bump versions in PRs.
And, even if the same `register_post_type()` call runs twice for some weird reason, it's not a big deal.
Replace this line and the next with:

    MultipleFailureException.assertEmpty(errors);
may need to write a whitespace or something out to the res as a keepalive, since the stupid elb cuts off idle sockets at 2min and that would suck here a lot
req.cookies may not exist, and even if it does, callback can be undefined and urllib.parse will asplode... (can use if(redir) as that's set at the start too
Oh, that's true.
jslint error. perfTimerName was used before it was defined.
This assumes base URL is at the root (per the instructions in the wiki). Could we be a little more flexible? Maybe one of the steps in the smokes could be to change this line to prove live development works. If my setup is like this on my mac:

``http://localhost/~jasonsj/brackets/test/smokes/server-tests/server.shtml``

Then the step in the smokes would be to change this line to

``<link href="/~jasonsj/brackets/test/smokes/server-tests/css/citrus_mq.css" rel="stylesheet" type="text/css">``

It's a little more work, but it helps to be more flexible with the URL and sort of sanity checks that live development works with the server path.
This was originally added for the earlier menu implementation. I was about to remove it, but thought of two use cases:
	- a feature that shows the user all the shortcuts (like Eclipse) in a window
	- a feature that provides a UI for editing shortcuts

Do you think it's worth leaving the API in for this? I could add a comment that installKeymap and getKeymap are meant for complete swaps of the bindings and that addBinding()/removeBinding() in most cases.

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 2:34 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

> +     * @param {string} platform - the intended OS of the key.
> +     */
> +    function removeBinding(key, platform) {
> +        if (!key || key === undefined || !_keymap ||
> +                (platform !== undefined && platform !== brackets.platform)) {
> +            return;
> +        }
> +
> +        var normalizedKey = KeyMap.normalizeKeyDescriptorString(key);
> +        if (!normalizedKey) {
> +            console.log("Fail to nomalize " + key);
> +        } else if (_isKeyAssigned(normalizedKey)) {
> +            delete _keymap.map[normalizedKey];
> +        }
> +    }
> +
>      // Define public API
>      exports.installKeymap = installKeymap;
>      exports.getKeymap = getKeymap;

I think getKeymap() is unneeded now that Menus doesn't use it.  We should probably remove it, since it's temping to get the map and add/remove entries directly instead of going through addBinding()/removeBinding().

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r878301
I am not sure it's worth copying variables that we do not change, because if we update any of these underlying frameworks and they change a value, then we'll unknowingly override it.
When selected project cannot be found, the sample project is loaded. It's not critical at this point, but I was expecting it to revert back to the previously opened project.
Should statistic recording come before reconnection logic?
Suggest including a link to http://dygraphs.com/per-axis.html in the warning.
You also don't need to pass the callback to these, since all of these functions will use the same one.
What? All lists you want to make non-list? Why?
Put mongoengine imports into a separate import group (after Django). Order alphabetically my module names (so first go import mongoengine and then django support).
This is not used anywhere?
to avoid the styles being applied to the last <li> in the group, which is used for hiding and showing the editor.
none of the other ifs in the file follow that spacing style, so leaving as is.
no butteruid
I think there should be an extra space for padding here at the beginning brace since you're trying to conform styles here.
No reason at all. I like your suggestion. It's much more legible and makes sense
why measure?
Maybe we need a table with julia/MATLAB/R equivalence. There's already a "differences from MATLAB" section in the manual, but it's all bullet points and prosy. A more cheat sheet-like layout would be nice.
Minor thing, but similar to function calls with parameters in other sections of code, this should be wrapped in parenthesis.
I get your point, shouldn't have - will fix.
I'm saving user whenever created it or not. 
30.08.2012, â 23:50, Mike Yumatov <notifications@github.com> íàïèñàë(à):

> In alfred/helpers.py:
> 
> > +def get_user_by_token(access_token):
> > +    api = Github(access_token)
> > +    github_user = api.get_user()
> > +    user = db.session.query(User).filter_by(github_id=github_user.id).first()
> > +    if user is None:
> > +        user = User(
> > +            github_access_token=access_token,
> > +            github_id=github_user.id,
> > +            name=github_user.name,
> > +            email=github_user.email,
> > +            login=github_user.login,
> > +        )
> > +    else:
> > +        user.github_access_token = access_token
> > +        user.login = github_user.login
> > +    db.session.add(user)
> Place this right after user creation, please.
> 
> —
> Reply to this email directly or view it on GitHub.
>
goIsRefresh seems fragile. Why don't you compare the current url and the url to load?
Untranslated string: identifier
Right, I’ve done that in another commit before I read your comment. :-s
Alright @taldcroft @wkerzendorf @demitri @astrofrog - I've changed it so that vicenty is always used, and there's no option in `AngularSeparation` to do anything else. That makes it effectively the "one and only one", and if it later becomes a performance issue for some people we can put it back in.  I've left the functions in `angle_utilities`, though (although I've tried to clarify better that they aren't generally used except for vicenty).   `angle_utilities` is definitely *not* intended to be part of the public API, though, so I think this is ok.  Does that seem fine to you, as well?
I now only changed the code in ClientModel to return a QString, to not rely on RPCConsole object persistence.
rpcpassword=$(xxd -l 16 -p /dev/urandom) > ...etc  would be better to create a random 16-hex-character password.
I'm fine with removing it everywhere and usw while (1), but it was in and so I used it ^^.
Good point, will change that behaviour.
This `<p>` element is not closed by a `</p>
This else is all wrong, try running this change through the [code sniffer](https://github.com/cakephp/cakephp-codesniffer).
This is now done for the frontend, backend will follow suit later. 

See [this commit](https://github.com/davelens/forkcms/commit/065973aba1dde0a8cddb92fc154c5738d61dcf59)
This allows this links to point to the file location in the IPython HTML notebook. We definitely don't want the users to have to provide that information. One thing we could do would make this default to the empty string, and have a wrapper class (NBFileLink or something) that defaults to 'files/'. Let me know how you want to handle this.
OK I would say this is merge ready.  Great work!

On Thu, Aug 9, 2012 at 4:03 PM, Min RK <notifications@github.com> wrote:

> In IPython/core/history.py:
>
> >      """return an empty list in the absence of sqlite"""
> > -    if sqlite3 is None:
> > +    if sqlite3 is None or self.disabled:
>
> Nope, just a typo and already fixed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ipython/ipython/pull/2278/files#r1347855>.
>
>



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
could you bring this to it's initial indentation point ?
I think it will need a check for a filename no matter what. At the moment nothing happens when there is no filename (ie a loop run 0 times) but to take stdin in this case there will need to be a branch.

Agree there is cleanup to be done, though to keep this function similar may require a change in the parameters of lower functions (e.g. code into generateDocumentation rather than a filename)

Thoughts?
I have heard that testng groups now work in surefire.  I'd prefer to run these as opposed to a very long and different pom than other projects.  Moreover, other projects conditionally skip tests based on the credentials available.  Ex. if it is an admin test and they are not available, admin tests are skipped.  I know that you are trying to organize tests, but this is a lot of change to current methodology to absorb at once.  It seems better to me to first merge, then refactor into different group launch configs, esp as you can control this with testng.xml externally as necessary.  Overloading first commit with a lot of process change will undoubtedly just make this take forever to merge.
Adding this method seems perfectly reasonable to me, but I question its need (see above).  It's great to see someone diving into the C++ code, though!
Does giving this a different class name have any negative implications .. like things like "seeking" status updates do we need those in DVR mode?
These two docstrings should be one. Sorry for the confusion.
This `git_repository_open()` could be merged with the no-reinit case, couldn't it? If it doesn't break the flow too much, I'd rather see just one call (we had a large leak on reinit because we were opening the repo twice). More nice-to-have, but should be useful.
why not call it regex? I think it would be more declarative when reading a schema.
Actually, if it's not gonna be translated, don't bother putting the `_()`. We don't want to burden our L10N team.
Lonnen mentioned this in channel but this probably should come out.
@stof I think not only deprecations/fatals should be logged but other too. What channels can I use for warnings/notices?
@stof removed and rebased.

FYI, I couldn't see anywhere that it says not to add docblocks to private member variables and there's plenty of code in the library that does so. It allows autocomplete for IDEs, so I don't see why it should be omitted. Anyway, each to their own I've fixed it.
why do you need this `ksort` ?
Sorry but IMO this is still not perfect from what I experienced in fabpot/Twig#878.
Numeric is would also allow a float which when saved in an array is treated as int. But if you later decide to treat float as strings, it will break.
And having passing a float probably as name is probably not intended. Then you could also allow Boolean which is also treated as int.

Long story short, it should probably be `if (!is_string($child) && !is_int($child))`.
Hi, think you did a typo here :-P
But then, shouln’t I rewrite it to `.*foo.*` ?
Ok, thanks for the remark!
Do you mean it shouldn't remove parent routes? That is an BC break but without it, the public method is not useful at all.
Or should is not support arrays? Which is not a break because the old behavior still works and the array version would have raised a PHP error before.
Making a new buffer, and a new writer per parameter seems pretty expensive. Can we refactor this to use a single buffer?
I was seconding @ProCynic idea. But yours sounds good too.
NB for myself: test rendering image is in correct position
@joemiller probably an excellent idea.

@miah thoughts?
I-> Iterator
F -> Functor
...
Minor stylistic note: we don't add an extra indentation for things just  because they are within namespaces.
I can't make these decisions, so whatever you guys agree let me know and I will do it.
Possible race condition. If the routine you're testing can write to an existing (albeit closed) file, it'd probably be better to use mkstemp, close the file, do the test, then delete it after.
Ah, I see what you mean now. Fixing...
fixed in b3b1ff5ddd352261b2d931970f17738d8e5d4eb6. Thanks.
Thanks  Peter, I update this. In fact I'm still quite a JavaScript beginner, so I programmed this through imitation.
Transition to preRender state to match the comment on inDOM:destroyElement
Right, because it's a classmethod, and because it takes the file path, rather than the response body. I'll change the name.
Yeah. I think I was premature on numbering those with the new id's. I can fix that if we want.
this import seems unused?
thanks, that looks better now :-)
cosmetics... use one line for the global?
这里不需要国际化？
ha, sweet, misread, thanks
I’d much prefer to rely on a CSS selector instead.
Thank you for fix this
This will break some CI builds. Do you need this particular change?
this line isn't needed, it probably comes from a git conflict, might be good to remove it in the next pr
You could create a closure that wraps the entire `SettingsListener.observe` call here to preserve the value of `channel` variable ... that's cleaner IMHO.
done & rebased :)
because there is nothing async happening so we want to stay on the same thread.
See https://github.com/fnichol/Razor/commit/bf7524e4d584e99e05f25d9a2707c65de494fc3b
Remove extra comments below?
http://blog.golang.org/2012/08/organizing-go-code.html

"Keep your packages go-gettable"

'../' isn't very gettable
Can you please switch to positive code? "if (inLocalMetadata())"
I'm pretty sure it makes no difference. If you think it does, prove it
@Wolftein


On Sat, Dec 29, 2012 at 9:16 AM, Wolftein <notifications@github.com> wrote:

> In src/main/java/org/spout/api/gui/component/CheckBoxComponent.java:
>
> > @@ -58,10 +58,7 @@ public CheckBoxComponent() {
> >  	}
> >
> >  	public void onClicked() {
> > -		boolean checked = isChecked();
> > -		checked = !checked;
> > -		setChecked(checked);
> > -
> > +		setChecked(!isChecked());
>
> Wrong James :P
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/SpoutDev/SpoutAPI/pull/483/files#r2520203>.
>
>
"basically like" sounds kinda weird to me
Yeah, the original logical is if 'pool_target' is a path name and doesn't exist then create it, but in fact, os.path.isdir() will judge whether the 'pool_target' directory indeed exists, so it's incorrect in here. thanks.
Use lowercase boolean instead of Boolean.  The null value doesn't appear to be used or tested for.
I thought we had selected a way to encode the revisions as properties?  We'll need to find some way to make this work even for multi-repo builds, at any rate.
This probably belongs at the data API level, actually, since we'll want to send messages about the removed links..
@tomprince, jsonrpc only adds a little bit more there -- basically a wrapper dict with some context, plus a dict wrapper for the return that handles error reporting in a consistent format.  So, it's easy enough to hand-roll if you don't have a jsonrpc library handy, but there are jsonrpc libraries for lots of languages, and those will be even easier to use.

I'm not sure how common it is for jsonrpc to be used with multiple endpoints like this, though -- the context of the method call is specified by the URL (the arg to `jsonrpclib.Server` in @tardyp 's example).

That, too, is easy to fix later, though, if users complain:  Add handling of jsonrpc calls to the API root, extract a 'path' argument from the params, and use that to find the appropriate endpoint.
`prop of this` would always returns `true` since it’s set to `null` on the prototype.
So we would need a `hasOwnProperty` check here, but that seemed to be overkill to me, so I just used `this[prop]?`.
these should be removed too IMO
A good solution would be to extend the `Team` module and add a method to provide a user project access to projects in group projects?
padding top also @gutter
I think that this is not correct. You return false if key_press callback don't process key, but this is not true. You process it, just invoking it failed.
So you should check return code and log it with error if starting xterm failed.
And always return TRUE, as you process this key and catch global shortcut.
Were we not properly parsing the content as html?  If you did find a problem with the way we are parsing HTML, please make sure you grep for all places this is done.  search/src/main/java/com/meltmedia/cadmium/search/SearchContentPreprocessor.java has code related to this.
It is smart, but is this really usefull? Would it be easy to understand in real life code? Do we really want to maintain this feature?
It seems easy, but It is out of the specification and brings not so easy questions: why returned promises would inherit from this prototype?
You should rename this to `requirerPath` (for ex.) as it collide with module path defined on line 67.