labofsahil/github-event-dataset-2012 huggingface dataset:
hm I'm actually trying to think of how that would be accomplished.. we'd have to break the standard REST model...
I've tested with dab's query, that originally highlighted the problem and it now fixed and matches hthor results.
Just caught that ...short open tags not enabled.
I'd like lots more to extend a common base template shared between edit and list view, but Sonata puts a common ancestor too high in the hierarchy.
Any idea to keep duplication away and still improve the templating structure?
Having multiple gems inside the same repo is as simple as putting each of your gems inside it's own folder and define their .gemspec accordingly. I agree it would be a much cleaner solution, unless you have something else in mind.
This change seems to be the cause for #674
Hola tu eres administrador de wow adictos ? dime dejame tu skype aver si conversamos ^^
Added two spaces after each line to force line breaks.
I get an WARNING: ScreenShot.m:77:30:{77:30-77:56}: warning: instance method '-base64Encoding' not found (return type defaults to 'id')
You're definitely right.

I have even had a look at them – the other tests that target Archetypes fields – but it's fairly arcane, and very forms processing oriented. I'll try and get around to just adding a simple unit test for the image field class.
Changed the method to `stored_model` and its argument to `column_values`. Better? I was also considering something like `determine_model` or `serialized_model`.
カッコ悪い28行目あたりを修正する。
ეს მეთოდი მთლიანად წაშალეთ. ნაგავს ნუ ტოვებთ კოდში.
could we change the URL here to http://jquery.com?
See [Global .gitignore](http://help.github.com/ignore-files/)
are we really sure we want tweening in the core of OF ?

I know there's been 6 addons, but I think this speaks to how common the tween code is, and how before ofxAddons we didn't have great ways of seeing what other had done.  

It doesn't really feel to me like an essential part of the core (extremely useful functions or elements that can be extended on to make other things) and seems potentially more suited for a core addon?
Was working OK for me before this, now it breaks (thumbnails and playback both don't work)
Could we remove IList.cs?
I think we need to .gitignore this file, because it's specific to each machine. For example, on this line, I have

id="cdt.managedbuild.target.gnu.builder.macosx.exe.debug.935025599"

which is different from what you have:

id="cdt.managedbuild.config.gnu.exe.debug.617250424"
Okay, one really great potential improvement here is to store this in a spring bean instead of the servlet context.  If we do that, then developers can inject that bean into their classes to make deterministic decisions on features controlled at the controller/action level.  Not something that would prevent me from moving forward as everything else looks pretty good, but just keeping a map in the servlet context is probably a "done before perfect" scenario, which is fine.
as eric sink say,dont just write trivial changes...try mentioning what they are
μια χαρά μου φαίνεται, βέβαια το Hello World σε vhdl δεν έχει πολύ νόημα, αλλά anyway :P
But I'll merge your pull to update 2.0.1.
Hahaha nice commit log :)
Can you point out the issues with this approach? Travis CI uses it to checkout the whole code and provide repeatable and fast builds.
= =我估计也得几十分钟来着
Do we need these default comments in the code?
Hi, @selwin, I just refactored the code a bit internally. You can now use your proposed (more explicit) method. I've named it `.enqueue_call()`. The `.enqueue()` API hasn't changed, but it doesn't accept a `timeout` argument anymore. Hope this helps.

Thanks for the suggestion.
@juandopazo Here's what I ended up with: https://github.com/yui/yui3/pull/214
Why a method? Why not just reference `deferred.promise`?

If this remains a method, should `getPromise()` be used?
"Check if the element has ID property"
match against `implode('/', $page)`. Easy enough :)
Please use spaces in `foreach` like the existing code: `$key => $node`
The reason is names starting with `__` get name mangled so the `__solve` call in line 565 wouldn't work.
apart from that `super` is an ActorCell while `p.recipient` is an ActorRef, and unfortunately the “real” method is `!` in one case and `tell` in the other. Hmm.
Isn't it sort of weird not to camel case this method?
Oops, residue from refactoring, thanks.

/Patrik

4 okt 2012 kl. 17:07 skrev drewhk <notifications@github.com>:

> In akka-samples/akka-sample-cluster/src/main/java/sample/cluster/stats/japi/StatsMessages.java:
> 
> > @@ -0,0 +1,55 @@
> > +package sample.cluster.stats.japi;
> > +
> > +import java.io.Serializable;
> > +
> > +//#messages
> > +public interface StatsMessages {
> Why is there a StatsMessages and Messages interface that looks like the same? The same question for TransformationMessages. Is this something specific to Java usage? I do not see Messages imported, or linked from docs.
> 
> —
> Reply to this email directly or view it on GitHub.
>
please use `extendedSystem.dynamicAccess`
If you know what the 'reaper does, what 'reaping' is and 'unreachable node set' is then I think it is very clear. 
If you don't read up on the config option and code.
Why was this completely removed?
This is not about unhandled stuff. It's about filtering out things that should only be published on convergence v.s. the ones that should be published for every gossip.
Might want to document that this does a busy-wait
if I use unicode I get this exception when I try to upload a binary file:

```
Traceback (most recent call last):
  File "test.py", line 23, in <module>
    glacier_vault.upload_archive('testfile.tgz')
  File "/Users/miguel/Projects/github/boto/boto/glacier/vault.py", line 72, in upload_archive
    return self.upload_archive_single_operation(filename)
  File "/Users/miguel/Projects/github/boto/boto/glacier/vault.py", line 90, in upload_archive_single_operation
    hex_tree_hash)
  File "/Users/miguel/Projects/github/boto/boto/glacier/layer1.py", line 436, in upload_archive
    response_headers=response_headers)
  File "/Users/miguel/Projects/github/boto/boto/glacier/layer1.py", line 81, in make_request
    data=data)
  File "/Users/miguel/Projects/github/boto/boto/connection.py", line 913, in make_request
    return self._mexe(http_request, sender, override_num_retries)
  File "/Users/miguel/Projects/github/boto/boto/connection.py", line 793, in _mexe
    request.body, request.headers)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 941, in request
    self._send_request(method, url, body, headers)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 975, in _send_request
    self.endheaders(body)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 937, in endheaders
    self._send_output(message_body)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 795, in _send_output
    msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0x8b in position 1: ordinal not in range(128)
```
should be "save!". migrations need to fail loudly.
You can't do exactly that in Python, AFAIK.

On Sep 19, 2012, at 8:41 AM, Matthew Rocklin wrote:

> In test/hits/web_test.clj:
> 
> > @@ -3,8 +3,9 @@
> >    (:require [datomic.api :only [q db] :as d])
> >    (:use hits.models.datomic)
> >    (:require [hiccup.core :as hicc])
> > -  (:require [hits.models.git-schema :only [schema] :as git] )
> > -  (:require [hiccup.page-helpers :as page])
> > +  (:require [hiccup.form-helpers :as form])
> > +  (:require [hits.models.git-schema :only [schema] :as git])
> > +  (:require [hiccup.page-helpers :only [link-to] :as page])
> What would the equivalent to this line be in python?
> I can't decide if it's
> 
> from hiccup.page-helpers import link-to
> or
> 
> import hiccup.page-helpers as page
> —
> Reply to this email directly or view it on GitHub.
> 
>
At line 158 the BubbleContent's parent  is being set to self. which prevents the addition of the content to the bubble itself because the parent already exists.
Just debugging code not commented out, it will be cleaned up at some point, probably added back and changed several times ...
Sure. And a second to remove the hard-clamp as this can replace it. That will reduce CPU usage compared to running both, especially as it runs for every stream regardless of player.
Just pass a stream pointer instead. then den/num isn't needed either.
where would you put it?
Some of this was in the transaction in save_card too
NP, took me a few minutes to figure out what was going on there, but I got it worked out.
@jspahrsummers Alright, I'll do so. :panda_face:
This doesn't fix what I was describing. This variable should be of type `id<TUIBridgedScrollView>`, and no `TUIScrollView`-specific methods should be invoked upon it.
Because, by default, the `unsigned` keyword alone signifies an `unsigned int`. It's redundant. It's documented in this ages old IBM page: http://publib.boulder.ibm.com/infocenter/comphelp/v7v91/index.jsp?topic=%2Fcom.ibm.vacpp7a.doc%2Flanguage%2Fref%2Fclrc03defbitf.htm
I just duplicated the test code from json_test.go (as you can see in the commit history).

Do you want to switch to httptest in the same pull request?
An idea here would be to have a public parameter that designates the base directory for these temporary files.  Then emacs could query it (to know when it's safe to delete a file) and also customize it, so that the user has full control over where their image cache is stored (and then i'd perhaps use something like "~/.emacs.d/geiser-cache" instead of the system-wide dir by default).
@bnoordhuis I assumed the case of false when both --with-dtrace and --without-dtrace options are set.
But either is fine. I don't care it. I add one commit and please squash it as your choice.
`CURLOPT_CUSTOMREQUEST` is ok for things like "GET", "POST","PUT", "DELETE", "CONNECT" and so on
Turn this into an error and throw an exception here; it's too risky to continue running IMO.
Probably good to remove these timing messages while you're at it
@hrach Tohle jsme řešili, že je zbytečné... ale tryDelimite() volá delimite driveru, takže pro každý driver jiný výsledek.
Here again the last arg should be 2 (as the algo is required too).
Директивы #include, подключающие заголовочные файлы Qt, должны содержать имя модуля Qt, в котором находится нужный заголовочный файл
elementId по константной ссылке
Закомментированного кода не должно быть в мастере
Yes, I think it can be done similar to this #5939
put this line in an `ensure` block.
@josevalim thoughts?
But you can set fixture_table_names to symbols already. Then it breaks.
I tried that, and it gives very different results (all the tests using orbits fail).  Should I just update the tests to the given results?
Yeah, I wasn't sure about it.  I want `-----` because it's a subheading of `API`.  But if Sphinx doesn't like it I'll change it.
Again, why? Shouldn't sessions be independent of client authorization?
I know but maybe we can add a default for com.gwtplatform.mvp.client.ClientGinjector or something? That way if you want to automatically generate the injector you don't have to specify it, would make it much simpler to use.
Should these be in a message lookup file rather than in-line?
dammit, that is a mistake. All changes to meter are a mistake. Will roll those back at once. Dunno how I missed that.
I'm hesitant to move it into its own method since the code isn't used anywhere else
I like the flow of this better... especially with using if-not vs if.
Thanks for pointing that out.  I see what you changed, much better.
the dot perhaps ? .. 'module_basename'   => ''.
Why not change Style to Customise?
			$sql = 'UPDATE ' . MODULES_TABLE . "
				SET module_langname = 'ACP_CAT_CUSTOMISE'
				WHERE module_langname = 'ACP_CAT_STYLES'";
Use unset on `$extensions` if you never need this key instead of checking it for it over and over again.
Not that it is hugely significants, but shouldn't this be "Topic approval"?
According to http://php.net/manual/en/function.sqlite-single-query.php this sqlite_single_query does not exist in php 5.4. It also looks like this is an sqlite2 function.
To not throw errors if the directory is not empty
Updated as you suggested imkingdavid :)

On Fri, Mar 23, 2012 at 11:52 PM, David King
<reply@reply.github.com>
wrote:
>> @@ -4524,6 +4524,10 @@ function page_header($page_title = '', $display_online_list = true, $item_id = 0
>>       // Last visit date/time
>>       $s_last_visit = ($user->data['user_id'] != ANONYMOUS) ? $user->format_date($user->data['session_last_visit']) : '';
>>
>> +     //Select editor
>> +     $s_select_editor = ($user->data['user_selecteditor'] == 1) ? 1 : 0;
>> +    $template->assign_var('S_VISUAL_EDITOR', $s_select_editor);
>
> Indentation is incorrect here.
>
> Also, because this information isn't needed on every page, you can probably just add it in posting.php and in the ucp/ucp_pm_compose.php files.
>
> Lastly, since you don't seem to be using $s_select_editor anywhere else, you can condense the lines like this:
> `$template->assign_var('S_VISUAL_EDITOR', ($user->data['user_selecteditor']));`
> Note that you don't need the == 1 or the ? 1 : 0 because in its usage here it is treated as true or false.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/651/files#r598014
I can do what bantu suggested.
Let's add support for the `phpbb_` prefix to the validate framework.
Will fix ASAP
The idea is a user can "soft-delete" himself, which is simply deactivating their account. If they're able to choose when to delete their account, they should be able to choose to reactivate their account (i.e. by logging in). Facebook does the same thing.

I have not yet made it different depending on whether they were deleted on their own or by an admin, but I plan to do so; if an admin deletes a user account, that user should not be able to undo that.
Pass it so extensions can use the name in the event....
This line is not  good to read. Probably there's a better name for the method. Consider hasShadow or smth.
зачудих се дали това не може да се изнесе в общ модул като responds_to_rss или нещо подобно, .. но така и не го доизмислих.
I thought your terminator was ``\r\n``. Would it make a difference?
Parameter assignment.
Removed, as mappend wasn't being used in this module.
nitpick: for consistency, we should always have both title and text for all our message boxes. ```Ext.Msg.alert(title, text)```. Don't leave blank
when you are frequently calling the same lengthy code, e.g.
```drugs.items[i1].data```
suggest that you just save it as a var the first time you access it
```var drugData = drugs.items[i1].data```
to make it less verbose, easier to read, and easier to maintain.
I know, but for slightly different reasons and the earlier check could change. Strictly speaking you are correct, and this is redundant, but I see little harm and some benefit from not coupling these two.
fixed. Interestingly, it still worked.
Same as the comment above. The code looks great otherwise. Thanks.
``get_next_free_hostname``
more gray => well
Do you mean "const char" instead?
Remove log from the code
If they're continuous, yoffset is set such that it is equal to the previous function evaluated at that coordinate.
you could also simply use array_replace
Because this value is set on a client in the client's constructor, setting it here as well will make it very difficult (if not impossible?) to use the cacert bundle shipped with their system.
What do you mean undefined? http://www.ruby-doc.org/stdlib-1.9.3/libdoc/uri/rdoc/URI/Generic.html#method-i-hostname
Yeah it only adds them if it's not there already. Do the configs get installed after the guest or before? If not settings the perms fails cos it can't find the nova user.
Cool, please add a comment above to indicate this.
It's being severely curtailed. All the junk in pushStack will go away and only the `$()` constructor will set .selector. That lets `$(selector).live( ... )` still work but saves us a bunch of bytes in manipulation.js
http://english.stackexchange.com/questions/62067/is-iff-considered-a-real-word-or-just-an-abbreviation
Yup, that's the one I commented on. Only need the newest. Don't want to waste Travis resources and all.
Both is probably preferential, though at the time I thought clang inferred
llvm.

With :llvm the warning does not show however the issue is present (lion,
xcode 4.3)
On Apr 17, 2012 6:21 PM, "Jack Nagel" <
reply@reply.github.com>
wrote:

> > @@ -6,11 +6,15 @@ class Chicken < Formula
> >    homepage 'http://www.call-cc.org/'
> >    head 'git://code.call-cc.org/chicken-core'
> >
> > -  fails_with :llvm do
> > -    cause "Compilation hangs; see
> http://lists.gnu.org/archive/html/chicken-users/2010-12/msg00158.html"
> > +  fails_with :clang do
>
> This also does s/:llvm/:clang/, is that intentional? Or do we want both?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mxcl/homebrew/pull/11696/files#r693490
>
`system` doesn't return the program output; it returns success or failure. You want backticks to capture the output.
Would `extract_path` be a more descriptive name?
i would call it grey then :)
Reflowing doesn't actually end up with fewer lines in this case but done so
the next person to add one won't have to do the re-arranging.
Good point. I should look at the coverage numbers.
The `config` parameter has not been documented
wird ne Extension _nach_ nem EP registriert kommt sie zu spät.. und wird nicht mehr ausgeführt -> daher late.. da das ein fieser catch is grad wenn man nocht nicht viel mit EPs gemacht hat ist das imho ganz sinnvoll.
Stimmt, macht so wenig Sinn :D
Was ist mit `getFullPath`? Soll die Methode dann vielleicht in `getUrl` umbenannt werden?
> Under what circumstances can `dbh.fetchone(..)['max_id']` return `None` so as to fall through to the `or 0`?

Testing or recreating the table.  I can add an error if 'None' but not 
testing as a sanity check.
(I added this 'cause we're relying on non-local behavior, and if this broke the problem would be very non-obvious!)
哎哟喂，别给这世界添乱啦，我最怕这个了。按默认的安装就好了，安装在自定义的位置就涉及到将来维护的问题，各种忧心头大。最好就是`apt-get install r-base-dev`，然后啥都不管了。
Is that still required, now that you have your own manage.py?
I feel like we tend to use `profile` here instead of `contact`, did you look at more than one `map.js` file?
I'd have to use ConcurrentDictionary in that case (Dictionary isn't thread-safe). To me, the explicit locking is easier to understand (but I might just be weird...).
There should probably be a brief comment to explain the reason for this wackiness.
I think it's fine for now. I'd hate to put up a blocking dialog each time we run into a problem, especially since there are probably other cases where you could run into this (e.g. you open a local server-code file that isn't exposed by the server via http). Eventually it might be nice to have some little modeless notifier for this, but let's worry about that later.
The only difference between the code here and in `getLiveDocForPath()` is in the callback, so it seems worthwhile to refactor it out into a separate function that takes the callback as an arg.

Alternatively, could you just call `getLiveDocForPath(editor.document.file.fullPath)`?
Moved to make JSLint happy
Is this code block needed? The error message seems to show up fine without it.

(if it _is_ needed, JSLint is complaining about a space between `!` and `global.brackets.app`)
If only we controlled what features treehugger had...
How can you be sure `nt0*n_stacks` will be the correct dimension for the combined datasets for relocated events ??  You will have lots of small, discontinuous stacks, whose final end point will almost certainly be more than nt0*n_stacks points after the initial start point.  Maybe we should be more intelligent here:

    # get start time
    f_stack = h5py.File(stack_files[0],'r')
    max_val = f_stack['max_val']
    first_start_time = utcdatetime.UTCDateTime(max_val.attrs['start_time'])
    dt = max_val.attrs['dt']
    f_stack.close()
    
    # get end time
    f_stack = h5py.File(stack_files[-1],'r')
    max_val = f_stack['max_val']
    last_end_time = utcdatetime.UTCDateTime(max_val.attrs['start_time'])+dt*len(max_val)
    f_stack.close()

    nt_full=int((last_end_time-first_start_time)/dt)

and then use `nt_full` to create the datasets.  This will also allow us to remove the resizing at the end...

What do you think?
this shouldn't actually be commented should it?
Implemented so far only as cpdef because I think I has some problems doing the checks
and then the right callls in C. But it should be easy to write the corresponding cdef function.
umm, one is getting the value, the other the average?
You don't need `|e`. It's automatic in Flask.
Yes I was also glad when I found that, nice shortcut.
This is the introspection of BeanShell interpreter that require all theses parameters, I couldn't find an interface.
Yes, this seems to come from orbisgis-ui, which makes sense since WMS was there before. I have no idea what throwing an exception here might do. Let's do that, better fail early.
You can generate the files  by running ```make```
Import order. Built-in modules are first (in a separate group).
Doesn't this go to `post` method?
One empty line too much. ;-)
A race condition is between you trying to get an user object (you check the database) and then if the object does not exist, you create it. But what if in some other request just in that moment (for example in another tab) the user has been created? Then `auth_models.User.objects.create_user` will fail.

For that you should probably do one of three:
* configure database so that transactions are really isolated (they are different levels of isolation, you should pick one which assures that race condition cannot happen)
* or lock the user table
* insert new user in the ignore errors mode: if user already exists, nothing is done; and then get the user

Problem is that all three things are database dependent. And that Django does not already provide some abstraction here. In development version there exist [select_for_update](https://docs.djangoproject.com/en/dev/ref/models/querysets/#django.db.models.query.QuerySet.select_for_update), more about it [here](https://coderanger.net/2011/01/select-for-update/), but I am not sure if it helps for this situation.

For sites with very big traffic race conditions are more and more possible to happen.

If you do not want to play with this now (sometimes developers have to meet deadlines) it is at least to add a comment (or even TODO comment) so that once there will be an error displayed to the user (one request will fail because of this) and somebody after you will go and check the code, will know what is probably wrong. This is not really a good practice to learn (you should always code in a way without race conditions) but sometimes bug will happen very very rarely and code for proper solution is really complex, long, or time consuming to write.
One empty line before this import. Group imports together.
This needs a comment so users know how to wait on the map being ready, as you did in the editor.
ah, my bad
ah ok. alright.. go ahead and merge :)
`2` needs to be a named constant here (to avoid comment )
Both fixed in new commit.
Or take advantage of boolean evaluation in Python: if project.releases
Should be 2.3 no?
We have some duplication here, I think we should try to move that into a 'RelatedVideosMixin' or something. However, this can wait until this lands of course.

I'm wondering if we could use related fields, as shown here: http://django-tastypie.readthedocs.org/en/latest/fields.html#tomanyfield

```subjects = fields.ToManyField(SubjectResource, 
            attribute=lambda bundle: Subject.objects.filter(notes=bundle.obj, name__startswith='Personal'))```

The one problem I see with this approach is that we need to check the user, which might become ugly inside a lambda. If we were to move the code into a common class, this may not be a problem though - we could just use a function.
I've created a new tag 0.2 too because the first tag was 0.1 without the "v" :)
This should be https://github.com/adamhowardprice/DDMenuController.
couldn't downcast from the void * back to the delegate type

eg. 

			auto writer = cast(bool delegate(void[])) ud;
			return writer(cast(void[])p[0..sz]) ? 0 : 1;

error: luad/lfunction.d(115): Error: e2ir: cannot cast ud of type void* to type bool delegate(void[])
Intentional :). I'll remove the comment completely.
Recommend adding TODO to to the comment, to help ensure that we revisit it.  Also, if need enhancement to pulp, please create BZ and recommend referencing it.
This seems to be my fault, but why use `self.__call__(a)` instead of `self(a)`?
this extra whitespace violates our style guide (or should IMO). :)

no real point in keeping things lined up this way...
Need to use one from `libcloud.utils.py3`.
I had the same in my mind and came to the conclusion it should never happen ... I don't decide it, but I guess there are several places in the code where are theoretical chances that something bad happens, you could surround nearly everything with try - catch. But let's discuss it :).
Please use an inline function, not a macro
Please don't use a magic string "(no label)" here. Why not simply use an empty string for "no label"?
Why cant we use these namespaces?
This line might cause problems with api generators. Probably best to remove it and the blank line above it.
not sure what you mean.

```
  isset($this->fieldset[$this->_modelScope]['fields'][$parts[0]]['type']) &&
- $this->fieldset[$this->_modelScope]['fields'][$parts[0]]['type'] === 'multiple' &&
- $count == 1
+ $this->fieldset[$this->_modelScope]['fields'][$parts[0]]['type'] === 'multiple'
```

The count was checked twice here, and the only other change is the removal of the `&&` after `== 'multiple'`
I am fine with `_requirePresent`. I will wait a while to hear @lorenzo 's opinion on this or if someone else have one and then update the name.
Don't like String.Join?
Move all of these strings to a javascript type like the other constants.
Only one exclamation mark?
This will only work on your pc I think
That's not what I meant.

I was thinking again along the lines of the above comments regarding serialization. The pipe may well be the right place to handle this, i'm just worried about a potential explosion of methods on that class for specific use cases.
`type_id`
Oops, my bad, then... even being a contributor, there are some parts of provy I still have to learn about. Thanks! :-)
It would be tempting to make this return a `size_t` of `(scan - str)` (i.e. the strlen of the unescaped string). It is essentially free at the end of this function and would be useful to almost 100% of the callers of the function.
Chris,
Looks like promptType was introduced in Firefox 4. Mozilla ended support for Firefox 3.6 as of April 24, 2012. How long do you intend to keep supporting it?
Sorry, when tobbi or anybody not in sumo-dev talks about forums, they really mean questions :-).
oh wow. is this even working in prod then?
Typo. s/amd/and/
ahh, sorry.  I was just commenting for my own understanding.  I used the word "session" in more of an abstract sense, rather than a real session object.  but, I updated the comment.  hope this is better.  thanks for clarifying!  :)
No need for parens. We're not in JavaScript anymore.
Let's change `version` to `api_info` to match the final header name.
Boolean arguments are evil. Maybe `getConnection` and `getSecureConnection`?
Yes adding this would be great. However it makes Request a little more complex so I postponed this a bit. But will do.
I don't know what to think of this file, since Core is a module and this is in the Sphenic main library.
why using a classmap instead of the psr-0 autoloader ? I don't see why it would be better.
you should skip the test when the Translation component is not available
I have created a new issue as this PR is closed
An exception is also fine.
you should use the stub directly here IMO
looks like whitespace removal
+ (BOOL)hasFeedVenues
As far as I can tell, we don't use this module anywhere apart from database_test_main.ml so we shouldn't ever hit this exception :)
Let's delete code instead of commenting it out.
Also I'm guessing this goes away when you allow the placeholder to be shown.
No real reason. I'm just trying to expand these shorthand rules into their longhand counterparts so I can detect similarities easier.

For example:

```css
body {
  background-color: black;
}

p {
  background: black url("...");
}
hame ro yejor bezaram manzooretoon ine ke mese index bayad bezaram???
ehsas mikonam stylus az nazare select kardan zaeefe ya shayad beshedat herfee
va vase in harfam dalil daram :D
stylus mikhad tamame chizayi ke sass va less support mikonan ro support kone ke hamin dalil baes shode alaki pichide beshe va 4 speace ba 1 tab fargh kone ya moghe hover hamoon tag 1 tab bedi bara select childesh 2 ta speace bar css hash 2 space ba ye tab va kholase ....
man nazaram ine ke less az nazare select kardan va hamchenin hover kheili rahat tare
There's too much going on in this method. Can we split this into multiple methods:

* one that returns a list of connection strings from the config (old and new styles)
* one that returns a list of jmx connections (then they can be cached, pooled, whatever)
* one that actually performs metrics checks and kills connections if necessary.
"your" => "you're"
Last thing @aPunch and I swear I will shutup...

TallGrass is a child of DeadBush? That doesn't sound right...

TallGrass should be a child of Grass or you could make the hierarchy....

Fauna
- TallGrass
- DeadBush
- etc.
buf can be non zero if self.buf.getvalue() return more than size bytes. I agree naming can be improved, I will fix.

as for self.reader.read(), it can return fewer bytes than we asked but then we should still return what we have if we don't want to block.
указывай версию только в крайних случаях
Yep but that's what we care about here, we want whatever value it has been cached as previously, 0, false, undefined, empty string etc... Ultimately it ends up making no difference whatsoever in this bit of code as if it was cached as undefined we end up returning undefined as a side effect of returning nothing.

All academic in the end as I've gone with the !== undefined version!
you seem to like wx a lot :)
not necessary yum idempotent
Turns out the resource description metadata already says it allows null.
It miss a space before the else
There is only one "Singleton" that stores state and that is Calendar.App. I try to avoid directly referencing it so we can simulate more conditions in tests by passing in a different "app" that has different conditions (for example in all tests the db name is swapped out with another so tests never conflict with the real calendar app, etc.." I will add better docs here.
This will come back and bite us.
Smses sent by "short numbers" (google, operators, spams) will be able to match real contacts.

for example:
a sms from my operator in `688` will match a friend with a numer like `0688089078`
What's all the ".scope" business in this file? What does this method do, and aren't there going to be reflection warnings? Also, you're calling this on a string
Let's make the default 7 days.
I usually expect methods that start with "get_" to return something -- maybe call this one print_info?
I did it before sending this pull request.  And it did pass.   The test simulates the actual failure on first push.   Hence, it worked as is - no change in test.
@fltiago Did you read the article? Item 2.3
Change to use ScalaProject's javaProject in this commit:-

https://github.com/skyluc/scalatest/commit/9e97833efc669be224babe32c4f941487ef4f65d
「」じゃなくて ""
空のタグ、はバッククオートでかこって原文通りに
Вы же видите, что для 1 ошибки там стоит one, для других случаев - other, а остальное пропущено. В англ версии это не нужно, а в русской стоит перевести. В остальном все отлично, большое спасибо за проделанную работу! 

3 дек. 2012, в 11:15, Maxim Kulkin <notifications@github.com> написал(а):

> In config/locales/ru.yml:
> 
> >        no_shipping_methods_available: "Для указанного местоположения отсутствуют способы доставки, пожалуйста, смените адрес и попробуйте снова."
> >    errors_prohibited_this_record_from_being_saved:
> >      one: "1 ошибка не позволяет сохранить запись в базе"
> > -    other: "%{count} errors prohibited this record from being saved"
> > +    other: "%{count} ошибок не позволяет сохранить запись в базе"
> Что "это" ? Пишите развернутые ответы.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
what does K mean?
I think a Binding class should go in the bindings module, not the model.
looks fine but let's use `process.stdout.write(css)` instead because console.log will attempt to translate `%` etc so for general purpose stdout
it's not so great.
I dont think it would be a good idea to store it till 6 decimal places if it doesn't hold any meaning for real. There should not be any transactions of the value 1234.5678 in USD. Why should we not store its value as we present it?
Ask yourself if ALL games would have hunger?

No?

Doesn't go into SpoutAPI...simply make a VanillaProtectionService with the extra methods.
I've done a lot of testing, and I am unable to find a circumstance in which optionList is **not** null.  Does anybody know when this code is used, or is the optionList stuff just dead code?
On the other hand, it isn't clear that you do want to inherit the behaviour of `VC10`.
Okay, I managed to get on a mac and install the extension: it does work in safari 5.1.5 as-is.
Shouldn't this be `inherit`?
So I just had a look and now I'm not sure whether the other project is a component, really... Need to check again later....
more details in this thread: https://github.com/gitlabhq/gitlabhq/pull/1023
I actually tested it although in IRB, and not in Gitlab environment. And thought the tests would cover its funcitonality. But what you are saying is that supplying the mode to `FileUtils.mkdir` doesn't work?
should we exclude the private ranges like 10.0.0.0/8 and such? safes lookups
Got it. I don't really have a strong preference, though others might. I'm pretty sure that in the case of positional arguments you don't need an `nargs` argument at all.
Not sure why this doco is in this pull. Is it related?
Yes, i see that this pull-request is not a perfect solution. Then let me briefly explain what this is trying to fix: 

A user with just the overall READ permission can add a description in the top-section of his "all view" via the URL:
$JENKINS_URL/me/my-views/view/$ALL_VIEW_NAME/

This description can then be seen and not be edited by all other users which i think is not a good behavior when having a multi-tenant setup (different users not knowing of each other and accessing the same jenkins instance).

I agree that it'd be best to file this in JIRA.
you can probably just use event.sprintf to get whatever time format you need instead of implementing this method.
There are a few whitespace only changes in this commit.  In this case, two spaces have been inserted at the end of this line.  Those should be avoided.
some kind of moseba sodah...
current_user.videos.find
Maybe it's because I'm not native, but this sounds very confusing to me. I would expect to have some property missing. I would rather prefer different phrasing here.  Like Only difference between html5 indexedDB and this one is in [database naming](...) also maybe worth pointing out that this may get fixed with a [Bug 786688](https://bugzilla.mozilla.org/show_bug.cgi?id=786688)
> Should I file a separete issue about that or a just a commit here would be enough?

If you can please fix it right away.
I18n.with_locale(locale) do
  recor.sen..
end
Maybe we should just add a link to `features/stubbing_constants/README.md` since they are identical.
I don't understand why you've wrapped the value with {}. Could you explain?
This is not as big a change as the diff makes it seem at first glance.  The existing code was just wrapped in if(_item){}
Great point - Swoop is in that situation currently, so I omitted the role from the file name. Interested in other peoples' thoughts on this.
these changes need reverting
Why this is not only AbstractExplicit?
Well, that's really micro optimization, and I'm not even sure, if it makes a difference. PHP would have to allocate space for two variables then, instead of doing this simple math.
My changes in the validators are reverted
I see :D Thanks for the explanation
I would move these `is_string` checks to the `suppressEolIssues method`.
no it don't! shhh.
Can you do?

```
Todo todo = new Todo({
  completed = complete,
  title = content
});
```
Could you remove them?
Don't you mean `any?` :)
Yep, is better
Much better - thanks. Will fix shortly.
Btw, running the existing tests shows it. See the travis build.
Can you make this code nicer?

1. you don't need the else here
2. you can delegate the PostgreSQL generation of $sql into a helper method instead of inlining the code.
use ``new static`` instead of ``get_called_class()`` for the late static binding.

And your patch does not respect the coding standards.
where does the type come from when we have yml/xml mapping? we could do it the same way, maybe?
the reason i changed it is that this simplified the logic, ie. "return early".
I'd recommend "Field type that be queried without analyzing. An example of this would be a multi-value field or a whitespace tokenized field where search terms are always for a specific token". What do you think?
Two spaces before inline comments
"dedent"
`> 0` is superfluous.
comma behind HMAC_KEY
Good point. Will add.
Ahh, I suppose it's fine.
I'm guessing this forces the topic to finish before running the other contexts? If so, I think throwing a comment into the empty function body to say so would be appropriate where this technique is used.
Is this ever going to be an object? The manifest says it's text.
а зачем эти кавычки? просто делаешь
`Request::
     
    POST ....
`
This seems to be a whitespace only addition - could you remove it from the pull request, please? :) The same goes for the preference.rb file below.
The compiler complained without it.  Said it couldn't find net but found
net/http.

Corey
On Dec 9, 2012 11:41 PM, "Ohad Levy" <notifications@github.com> wrote:

> In lib/proxy_api.rb:
>
> > @@ -1,18 +1,21 @@
> >  require "rest_client"
> >  require "json"
> >  require "uri"
> > -require 'net'
>
> hmm.. why?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/theforeman/foreman/pull/292/files#r2360984>.
>
>
为啥要交换两个error的位置呢？
I notice that if you load the feedback app again then it remembers your email address. Thus this step sends the email keys a second time appended to the original email address!

You can use the clear() method to clear the field before entering it.
wow. now these are some muthafukin tests. damn
- The `!` negation should be inside the block.
- Style is wrong (missing spaces around curly braces; probably use `do ... end` here).
Can this be renamed? It'll be exposed to `fab -l` and may be called independently of a deployment, so `run_script` is a bit ambiguous.
Check the code style
The code is fine, but just do a check first -- `if current_user.present?`, then run your block.
looks like there is a missed indent here
Can you make the call in one line:

``` php
return $this->getStringTypesPrefix($length).parent::getBlobSQLDeclaration($options);
```
For consistency, this message should be translated as well.
Suggestion:

"Use the payment ID you received when the payment was created."
Yeah, I think this is ok now.
is this path relative? Will it look for it in `test/local.json`, or up a directory?
I think this can be rewritten `(is (.. broker (getPersistenceAdapter) (isCheckForCorruptJournalFiles)))`?
I'm not 100% that this is a prerequisite.  It might be better as a NOTE:

```
NOTE: If you are using S3 in combination with Heroku please refer to the "Heroku guide":/guides/heroku for more information.
```
Eww. Oops.
Today, rspec-puppet should not reach directly into Puppet to obtain a scope instance.  Instead, it should use the `puppetlabs_spec_helper` to obtain a scope instance in Puppet version-agnostic manner.  As a concrete example, this line:

    scope = Puppet::Parser::Scope.new(:compiler => @compiler)

should be:

    scope = PuppetlabsSpec::PuppetInternals.scope

This is important because if we change the behavior of the scope object again we will also change `PuppetlabsSpec::PuppetInternals.scope` to work correctly.  rspec-puppet will then "just work" instead of breaking again.

It's very likely that the method signature of the scope object will change as we inject more dependencies through the initializer rather than relying on global process state.
Changed it so it just returns the userId. Not necessary anymore since we don't have to pull in the full user object to check the password.
I updated the references which are in core.debug.
The var statements should be in-line with the `for` loop. Not doing so risks setting a global variable, and generally variables should be as narrowly-defined as possible (even if scopes are only defined on a function call, it still helps readability).
Check the other files for the style convention on class declarations.h
я предполагаю что мы можем использовать 100% -ную мутацию. Как вариант, тогда да в эксцепшине нужно указать что значение которые можно передать должны быть от 0 до 100 включительно.
Кстати, да, @pingvin4eg прав. На вход mutate передаются именно проценты. Если DNALength будет больше ста, то можно дать неправильное количество. Сейчас исправлю.
Тут стоит использовать операции с вещественными числами, а потом округление, так как возможна потеря единицы
Ну вот я придумал два решения. Первое — не оптимально по итерациям, типа предложенного тобою. Второе — не делает лишних итераций, но требует доп. массива. Я решил что небольшой перерасход памяти — лучше чем непредсказуемое число итераций, так как в первом случае на ДНК в 100K букв необходимость мутации около 100% требует уже заметного количества итераций
Эти методы можно было ситезировать использовав директиву @propety при объявлении переменных, и директиву @synthesize если xcode старой версии. Тоже самое справедливо и для getDna;
Проверьте пожалуйста еще раз. Я там вижу xib, main и пустой делегат. Логики нет. При запуске всегда одна и та же картинка.
Nope, I am wrong but we need to also add that
Just the "Number of objects considered".  This includes the number processed via the cache and not touched by the filter code at all.
it's totally fine to `return callback(err);` here, I do believe
Shouldn’t this rather be `saveLRStats(obj, DELETE_STAT, request)`? A resource which is marked as deleted can currently not be restored anymore from the UI.
heh right we can't currently use @Autowired in OpenmrsServices, but I still prefer injecting with a constructor from a setter.
style: wrap httpchk in double backticks
Or redirect_if_refinery_user_required!
I wonder if we could use chrome.tabs.getCurrent here. I guess it must work from content scripts, otherwise it's seems pretty useless. Anyway, please give it a try. The solution with ("tabs" in chrome) is really horrible.
Looks like there's 2 too many `=` here
This does not delegate to super, is this intentional?
Форматирование поехало.
En Markdown no deberían, pero con ese _coso_ que usan ustedes, quien sabe...
¿Está bien que esto quede fuera de cualquier elemento? ¿Cómo lo procesa LESS esto?
How could I show the name of the fighter that wins the turn?
yes, that's right.
It depends. In this implementation starting a new transaction without commit will effectively wipe out the backlog without applying it. In theory we can commit here as there is no way to rollback now yet it's not the normal semantics.
http://api.rubyonrails.org/classes/Object.html#method-i-try
Thx. I need to go now. I'll look at it, later this day.
From what I remember about this, it resolved some issues with logging in.
I dont recall what errors, Ill check if its actually needed later tonight
i see this code repeated... i think we should make a private method for it.
Normally in my application code, I catch exceptions, propagate them up the chain, but call tm.setRollbackOnly() and check the tx status in the finally block, where I commit or rollback.  

But I want to be consistent with what your standards are.  So I can commit in the main try block and rollback in the exception block.

(Yeah, I missed the 2PC case)

So it would look something like in the finally block:

if( 1PC ) {
  if( status == ACTIVE ) 
    // commit
  else
    // rollback
 else
    // put in map

tm.suspend()
No, it makes no sense to have an async cache. Compromise: Remove forces and create a warning log in case of async cache configuration used at GridFS c'tor?
If the entry is missing from DataContainer but we need to lock it we put a K->null entry in the looked up entries map.  And this can later cause NPE.
Yes, see JIRA, this was the last resource and Pete's recommendation.
I'm not actually sure what the future return value will look like. A two-item list sounds a bit like what I implemented in PR #803, but @efiring suggested a different approach---possibly using the Container class. Based on the subclasses in [matplotlib.container](https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/container.py#L87), it seems a Container-based return value may look (to the user) like a one-element tuple. Is that correct?
Yes, I wanted to catch both so didn't specify -- perhaps catching `Exception` also catches some magical python ponies that I am unaware of?
No there is no 'standard' message. But a user could easily run into this error by, for example, making a typo in the baseline method name. Perhaps something more informative would be:

`'Unknown baseline method %s' % baseline`

Or:

`'Baseline method %s not recognised. Expected 'zero', 'sym', 'wiggle' or 'weighted_wiggle'`

Note, I am not necessarily suggesting the accepted baseline methods are hard-coded into the exception message. There's probably a better way to do it.
Please check with Michael, Stephen or Tim that this is the correct link. It seems to me we dont want both ( a link to ActorIdentity and a link to UserInfo).
Reverted. Same for the above one.
Submit an issue? I'm merging this in in the meantime. Thanks for comments!
@bp323 Will do
As per conversation with @raydavis, failure to escape the _userId by any query processors should be looked at as a bug in those processors. Presently this passes integration tests and a review of code does not show any errant uses of this _userId param.
although i guess @sonney2k will only take the patch if you remove STL based implementation, you could use here ::const_iterator instead of ::iterator
I... didn't change that.
Careful with indentation
No, not sure. With "fromWindow" it should be doing direct bindings to the window object anyway. I think this is OK to get the beta out the door, but we should really fix entwine - possibly mark with a \@todo comment?
will look into using apache_get_version to detect the apache version number
@hellochar just noticed this when you mentioned it in the discussion.  you should probably make this called `enabled=`.  methods called `set_`something are generally discouraged in ruby.
Nah, it's fine. If you introduce bundler to your branch the pull reuest should automatically update. Librarian sounds like what we want, I think.
Thanks for the tip.  I didn't know that.  I will use isArray from now on.
Good catch. I think I originally went with `return undefined;` because it's the most explicit. Removing the else statement altogether sounds good to me.
Agreed, went with application fits in with the [art.sy](http://art.sy) website aesthetic
Hmm, lets keep it on for now. I added it for consistency with the way node.relate is an index of rel.create. That way, you can really get away most of the time with only using the functions on the root object. Unless you're doing something fancy, you never really need to step down into `rel` or `index`.

We can definitely re-evaluate both of these aliases later on, it could be that they're just confusing. We won't really begin to know until I'm using it in production on Sahti.
I'll install node now so I can run the tests...
@FroMage you closed primary issue #691, but not merged this(are you satisfied with refactored code?)