labofsahil/github-event-dataset-2012 huggingface dataset:
You're using `false` as the error value here. In another branch, I'm changing `false` to `null` in some areas. I prefer `null` myself since the error is an Object, not a Boolean. But it's best if we choose one.
mrvisser created #250 for this.
Ah, **this** is the PR where you used JSON.stringify(JSON.parse(..)) to clone. I see it's been changed to clone module explicitly now, that's fine.
Ok I will have to take a closer look at it when the newer version comes
out. All we want to be able to do is to serve different content based on
the expectation of the client in a REST application fashion.

This article by IBM explains it pretty well:
http://publib.boulder.ibm.com/infocenter/wasinfo/v8r0/index.jsp?topic=%2Fcom.ibm.websphere.base.doc%2Finfo%2Faes%2Fae%2Ftwbs_jaxrs_contentnegotiation.html


On Sun, Apr 15, 2012 at 12:50 PM, TJ Holowaychuk <
reply@reply.github.com
> wrote:

> > @@ -135,8 +135,8 @@ req.accepts = function(type){
> >    // normalize extensions ".json" -> "json"
> >    if (type && '.' == type[0]) type = type.substr(1);
> >
> > -  // when Accept does not exist, or is '*/*' return true
> > -  if (!accept || '*/*' == accept) {
> > +  // when Accept does not exist, or contains '*/*' return true
> > +  if (!accept || ~accept.indexOf('*/*')) {
>
> oh no sorry, it does return the _first_ for "*/*"
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/visionmedia/express/pull/1020/files#r686131
>



-- 
*Michael Yagudaev
Software/Web Developer
Phone: 204-891-2491
Email: michael@yagudaev.com
Website: www.yagudaev.com
Twitter: @yagudaev <http://twitter.com/#!/yagudaev>

"Think like a man of action, act like a man of thought" --  Henri Louis
Bergson
*
Alignment seems to be broken in here - make it to match other columns, with spaces.
Shouldn't you assign this to something?
@alony оказывается я их вобще убрал в новом апдейте :)
Very nicely done Roland!

:+1:
This does not seem like php code, no?
Sure the original version is not ideal either and it was just meant as a suggestion how to improve it as it makes it easier and more flexible for a translator without having to look at the code.

    echo '<p/>' . sprintf(gettext('<a href="%1$s">Delete all</a> <b>%2$d</b> entries in this table.'), 'diag_tables.php?deleteall=true&amp;type='.htmlspecialchars($tablename), $count);

Or one could even use ngettext to also handle the plural forms.
This looks like a place where some cool list comprehension stuff might make the code simpler.  Perhaps something like this?
        productversions = []
        for product in products:
            pvs = [x for x in product["productversions"]
                if (version and x["version"] == version)
                or (version_id and x["id"] == str(version_id))
                or (not version and not version_id)]
            productversions.extend(pvs)

that's not a TON simpler.  but somewhat.  I added in a cast to str for the version_id, because that's how it's returned.  this catches if the user passes it in as a number.
Are there limits to the number of rows you can insert at once with a multi-row INSERT statement?  I wonder how many an --extended-insert from a mysqldump gets.  Probably is fine for the data sets we're talking about.
Just edit it directly from Github ;-)
questo è un commento
count = len(self.events)

no?
yes, indexing with an array of ints or booleans
Unnecessary change. you can revert this file
@rkorytkowski , didn't we say that this leads to slow startup, and we need to get rid of @Autowired and use a plain old setter?
Does this mean we don't get notified by email in case the build and tests pass but still do in case of failures?
This should be done in the manual flush mode, similarly  to AdministrationService.validate
Update `this.colCount
> Not really, it's duplicating ruby-info functionality found in the Ruby module.

It's a plugin for the theme, it gets shown properly and it's made only
for rvm, if someone doesn't want it he can disable it.

The ruby-info module doesn't work as the rvm plugin is supposed to.
It might be easier to have these just add(T x1, T x2)
This is duplicated from above
选择一个
=>
任选一个
Is this still an RC for 1.0.0? This seems like it could be a huge breaking change. I understand that pre-1.0.0 is susceptible to anything changing at any time, but Clearance has been around for years and it's got a big enough userbase (I'd think/hope) that this would screw a lot of people over. How about grabbing values from either (while preferring `params[:password_reset][:password]`) and introducing a deprecation warning if it finds a value in `params[:user][:password]`?
"To browse the trails"
Again, I'm not super experienced with chai-expect, so please correct me if I'm wrong.

There are two equals:

* `equal`, which uses `===` (in jasmine `toBe`)
* `deep.equal` or `eql`, which does deep comparies of the object or `==` (in jasmine `toEqual`)

Let's use `equal` and `deep.equal`, so in this case, it should be `to.equal true`.
http://www.aftonbladet.se/nojesbladet/klick/article14451923.ab
thanasis' last two PRs did not include anything more that a generic heading of 'getters and setters'. I'm happy to put in one line but will not docblock each getter and setter. If it is part of the standard (where is that published btw) then that specific part of the standard should be changed.
it is threadsafe in implementation (of DefaultCamelContext) when it comes to registration of endpoints and components.
I count 39 synchronized statements in that code........

http://www.jarvana.com/jarvana/view/org/apache/camel/camel-core/2.9.0/camel-core-2.9.0-sources.jar!/org/apache/camel/impl/DefaultCamelContext.java?format=ok

(That could change of course, it is not documented on the CamelContext interface, but the intent seems for it to be threadsafe)
¿Levanta sola la aplicación o hay que esperar al primer request? Si hay que esperar al primer request puede que esto no te sirva.
Another use of `final`. Also, you should close the `InputStream` in `finally` block.
Does it matter? Should I change that?
I prefer to use `#fetch` here ... otherwise if color is sent in with nil, then your car will have nils propagating throughout the system.
Most of these arguments are not used.
Nice, I like the narration :)
Yup, you answered it in 3. :)
Please remove these deprecated doc blocks
Create **s**
Since this method can return `null`, this should be documented.
and it was merged :)
Matches a special regex that novaclient uses to find extensions.
One thing I don't have it fully clear (which could be added as javadoc) is: what happens when the master goes down?

A node going down might, or might not result in state transfer. In replication, it does not. In distribution, it does depending of which data is gonna need to be transfered to other nodes to keep N copies.

So, how is the master index regenerated when a master of an index goes down? You might need a view change, or cache view change listener?

I see you have a test to cover this, so might be missing how this works in the commit, or the code might be in a previous commit.
We should specify exit(1). By default exit is status 0

Or we can use abort instead.
Style: `BOOL (^)`
The cast was already in the code, but in fact it is not necessary because xy is passed to the Path initializer, which performs the cast.  I can take it out.
It's more than nine and less than eleven.

No, for real though, I figured it would be a good threshold. Kind of an arbitrary number, but I doubt you'll see a JAR file with 10+ `.class`es and have it not be a Java archive. Anything less than that and it could probably go either way.
This otherwise comment suggests an else statement, but pure is modified either way, isn't it?
PSR-0/1/2 don't specify a namespace case I think. I don't really mind which it is, but I would find PSR more natural since that's how it's always written. I will take the issue to the ML.
I think this radius is defined somewhere else in the code.
It definitely will never execute in Windows ... not a bad idea about adding it to Platform, but this is the only place we do a wall broadcast -- I'm not really adding it, I'm just untangling MOTD update from wall broadcast, because currently we broadcast "You're operational!" every time the instance starts up (because that's when we update the MOTD). The historical behavior is that we only broadcast thusly when the instance transitions to operational.
We should use oae-hidden now for these instead of `display: none`
Should we make this part of the shared groups api?
@dooremont shouldn't this go down be down in the list? + can you fix the whitespaces?
this is a little bit unfortunate as well, as it reduces a large part of the benefit of moving that function out. The top navigation will not render until the request has completed. We should try to do all the top nav stuff that uses the templates after the navigation has already rendered
No, it looks like Savitha's commit removed the "TagRefined" property provider, which is intended to be there, and which works with the previous line.
Can we change this template name to `PreviewSwitch.ss`? Its lacking context otherwise.
Instead of WT_EVICT_CLEAN and WT_EVICT_DIRTY flags, I'm passing down a single flag, whether or not we're going to discard clean pages as well as dirty ones.
This line does nothing, I used it to have a breakpoint for debugging. You can delete it.
@schmittjoh it looks like @JMSBot does not know about superglobals
I personally dont like this syntax sugar things. It regular in this library tough.
curious if you also need to tell travis to boot up an x server in order to run phantom... I recently wired up travis-grunt-qunit tests for [underscore.deferred](https://github.com/wookiehangover/underscore.deferred) and had to add the following config to get everything to work properly.

    before_script:
      - "export DISPLAY=:99.0"
      - "sh -e /etc/init.d/xvfb start"
No date or font attributes for the system message? :)
There exists a built-in predicate `false?`.
changed to counter++
minor, but prob. cleaner to test 'me', i.e. if (me)  
and do MakeMultiException, if not set in first catch..
Can we rename this as putSingle?
What is this? Some stale code. Clean!
I've decided for number. Fixed.
Oh, ignore. I cannot decide. ;-)
Ehm. No block here. You are not doing a parent template you are extending, but just a smaller piece of the template, you are including.
*Tvoj*
> I did check and they use male and female.

So same as we do?

> But when user registers with facebook, gender is already set so all users get the default value of female and they have no way of reverting it.

Yes, and this is a mistake which should we fix. So in general it should not be set if user has not set it explicitly.

> For connecting exsiting users with facebook acount we shouldn't use registration I think but just get the facebook link and token and things like that, that enable user to login with facebook.

We have just a concept of linking, if user has not registered with us but just used Facebook, his lazy user gets linked with Facebook. If he registered with us, his lazy user is converted to real user. If he links then with Facebook, his real user is linked with Facebook.
I will, as soon as I figure it out how :) Then I will change the whole form. But for now, is it ok ??
Without `:`.
I would log just all three values. :-)
Do we want to expose internal ID to public?
Allright, I'm with you now and acknowledge the possibility that this code is slower in dealing with top-level script elements (noting, however, that avoiding double-checks against `nodeName` and `type` for descendant script elements could easily tip the scales the other way).

The variety of inputs that this section is required to process (varying by script count/type/depth) make performance testing it a pretty big challenge, but I suspect that at worst it will be within the margin of error against real-world scenarios. And if I had to take a crack at identifying those, I'd offer this:

* single non-script element; depth 1 (no children)
* single non-script element; depth 3; 8 total elements
* single script element
* 3 non-script elements; all depth 1
* 3 non-script elements; depth varying from 1 to 4; 20+ total elements; no scripts
* 3 non-script elements; depth varying from 1 to 4; 20+ total elements; 1 script (non-executable)
* 3 non-script elements; depth varying from 1 to 4; 20+ total elements; 2 scripts (1 executable)

Each *could* be duplicated for array vs. undefined `scripts`, but the latter case is only used for detached `.before` and `.after` so could probably be ignored.
Aquí tengo una duda, el guión lo va ejecutar el usuario **root** o un grupo de usuarios privilegiados?, de ser así tal vez se podría comparar `/usr/bin/id -g` con cero, pero esto dependiendo de quien(_es_) lo valla(_n_) a ejecutar.
What about just `*` ?
Can we not use `!!`? It shouldn't be needed.
Ya, they're named based on the certification tests.
You should move these variables to private:
you don't need this check, you can only absorb dark dmg if you have dark essence, same with light
Smaller diff, rather than indent all that content.

I added a todo which will be a refactor into a few separate methods for
doRun() - for now it's an awkward placeholder for a future refactor.
On Nov 11, 2012 3:46 PM, "Moxie Marlinspike" <notifications@github.com>
wrote:

> In src/org/thoughtcrime/redphone/audio/CallAudioManager.java:
>
> > @@ -77,7 +78,16 @@ public CallAudioManager( SecureRtpSocket socket, String codecID, Context context
> >      simDrops = ApplicationPreferencesActivity.isSimulateDroppedPackets(context);
> >    }
> >
> > -  public void run() throws AudioException {
> > +  public void run() throws AudioException, IOException {
> > +    try {
> > +      doRun();
> > +    } finally {
> > +      doTerminate();
> > +    }
> > +  }
> > +
> > +  //TODO(Stuart Anderson): Split this up
> > +  private void doRun() throws AudioException, IOException {
>
> run() which calls doRun() seems a little awkward, is there a reason to
> avoid putting the try/finally block around the original content of the
> run() method?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/58/files#r2093178>.
>
>
not related to DBAL ? The profiler collector is related to DBAL
Reuse the adapter factory?
It seems that cassandra-jdbc is recommended by datastax and that stack based on thrift will be put in background. 
Moreover, @emmanuelbernard began with this stack so perhaps will he be more suitable to choose the stack to use...?
I do not have opinion about that. Tell me and I will do as you wish ;-)
No, scope test is inherited from parent pom.xml dependencyManagement section.
can you provide an example, I'm not sure how you see this.
what is "cid"?
"into _a_ simplified promise"
I think something like `var type` would be a better name, since it's also used in the classname.
What required changing this?
I originally did that (way back, over a year ago), but it was suggested that we break hard. I'd like to just return the token.
i thing that for production this log(.. ) fuction must be override in order to void the console print
show a few lines of sample data
This line breaks other urls.

TemplateSyntaxError at /
Caught SyntaxError while rendering: invalid syntax (urls.py, line 7)
In template d:\mmiha\piplmesh\piplmesh\frontend\templates\header.html, error at line 23

No idea why it says invalid syntax.
If you don't include gfish builds from the top level fail embedded testing.

Brian Humphrey <notifications@github.com> wrote:



In Product/Production/Deploy/pom.xml:

> @@ -39,5 +39,14 @@
>                  <module>websphere</module>
>              </modules>
>          </profile>
> +        <profile>
> +            <id>weblogic</id>
> +            <modules>
> +                <module>ear</module>
> +                <module>glassfish</module>


we don't need glassfish for the weblogic profile.

—
Reply to this email directly or view it on GitHub<https://github.com/CONNECT-Solution/CONNECT/pull/118/files#r1927518>.
Dangling question - is there a tracker issue to address?  How will this get answered?
What is the point of a function whose only purpose is to call exactly one other function? You might as well take out `initialize` and set `window.onload = startit;`.
Confirmed only 2 column additions
This came up when I was meeting with Vidya, the HCI student who's going to be working with us on this, and she found the checkbox icon confusing, and strongly preferred the pencil icon, for all exam types (I asked her about the comment-alt icon I had previously suggested for surveys, and she thought  that one was too widely known as a "make a comment now" icon, and would e confusing).  So let's stick with the pencil for all 3 for now.   Easy enough to revisit later.
Can the demo not be part of the normal boilerplate index.html? Would be better not needing to have multiple pages that you have to test.
Don't use tables, use .row
it is to allow calling setLocations(...) then start().
i agree longer term want a better way.
in the short term i don't feel strongly about this so happy to revert it.

longer term i am leaning towards not  start(LOCATIONS)   but rather  start()  preceded by  addRelationship(LOCATION, XXX)   or something ?
We are going to convert it to Java. So I'm already writing Java like code if possible so we don't need to spend as much time converting it.
if you're going to do this then you don't need the "< 1" case. But - in that case I would still keep the same number of levels: toFixed(3) for under 10ms and toFixed(2) for under, say, 100ms.  Otherwise you get 9.997, 9.999, 10, 11, ... which seems really ... uneven.
This was fine when it was in the ctor, but now you are completely overriding all the options set on the cursor...
In refreshing the page, I now see your reply. I thought Github was flaunting that they fixed this "feature" of pull request review. Lame.
um.. do you even need this variable if it is an empty string?
we need a note here that you need to run `app/console cmf:create:init-hallo-devel` now to get the hallo source code

maybe you can be explicit that when doing this, the hallo-min.js from create is no longer used
you don't need this call as the composer class loader is able to autoload the ApcClassLoader as it is already registered at this point (and will be unregistered by the ApcClassLoader wrapping it)
Consider moving all the above code to the CSVFile class. GUI  should not have to figure out the data for a file. Consider adding methods to CSVFile class that adds/removes CSVDataHeaders to and from the header list.
i did NOT mean to DO THIS!
it is, of course, actually a simple dict.  In the future, it is likely to be a DoctDict.  In the past, you've objected to tagging variable with the expected type, a practice that I find very useful.  The variable name in the processor has been 'json_doc' since the earliest iterations.  It refers to the dict that contains information that was originally in json format.  Would you object to 'json_dict'?

I think the problem here is in name overloading.  We've gotten into the habit over the years of using term "the json" to mean the crash meta-data.  It's not technically meta-data, either, but that's a discussion for another time.  Neither of these terms is correct nor particularly descriptive.  We've got this same naming problem in the api for the CrashStorage class methods.  It would be difficult to change the terminology in Socorro culture. Until such time as we do change the vernacular, I'm leaving it as json_doc.
Remove the empty comment or make some comments.
Please don't remove this link.    You've now idolated the /dev.html page instead of fixing it.

Your Who/What/How probably belongs on /dev.html, and the "contribute" page could use more plain english descriptions of the ways people can contribute to perl.
If there's a simple way to twig this, that would be awesome, let me know if it's possible.  Since I don't have the $app variable here, I'm not sure if there's a way to do it
ah, maybe there is no `make install` target. But the normal `make` perhaps?
Should the scenario where a DefaultJobLoader is created with only a StepRegistry also be tested?
I feel like data.java should be in helper because it is just a simple pojo which won't throw exceptions.
Крайне не желательный способ записи if.

```javascript
var isSome = event.parties.some(function (party) {
    return !party.name;
});

if (isSome) {

}
```
yay, just ruby convention, really
Thank you Miles for the refactor ideas.  I'm not too concerned here about collisions as the default_params is a 2-d hash with the current class as the outer hash key.  default_params is a horrible name, you are right.  I'll experiment with class instance variables in this case, but I still think that this is one of the few valid uses cases for class variable.
result можно просто возвращать
maaaaaaabiiiiiii
by using Rails.application.config.assets.digests here this code doesn't handle the case where an asset isn't precompiled. If asset_path or asset_paths.digest_for is used instead, then that case is handled.
You can ignore this commit. It's a quick fix for my 30 000 pages. I bet this style it's usefull for something else, but didn't figured it out yet ...
Would be better to assert.equal here and check against the actual title string of 'All categories'. It might seem to be a bit more frail but also it is more relevant to the test as we're verifying the categories section.
Yes please just remove this method entirely and use a page object specific property for getting the text.
Yep there is an issue with Composer that makes impossible to add FOSRestBundle as part of the dev packages. Look at the `.travis.yml` file to see which commands to run to run the testsuite.
While debugging, I was talking with Steve who pointed out the list was redundant and not sorted, so I performed a unique sort on it ahead of the list.  Note in the code around like 2086:

        for x in sorted(expected_events):
            log.debug(str(x) + " ?in (raw_events) = " + str(x in raw_events))
            self.assertTrue(x in raw_events)

It was unique sorted any way.

On Dec 19, 2012, at 5:26 PM, Bill French wrote:

> In mi/idk/unit_test.py:
> 
> > @@ -1923,51 +1919,28 @@ def test_driver_notification_messages(self, timeout=GO_ACTIVE_TIMEOUT):
> >          self.event_subscribers.events_received = []
> >  
> >          expected_events = [
> > -            'AgentState=RESOURCE_AGENT_STATE_INACTIVE',
> Why did this change??
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
No worries, I already fixed it. Thanks!
>    for one fit / one target not much but for dict learning it was critical
>    and you fit many

So, you are saying that if n_targets==1 it is not important, but for
n_targets big, it becomes important? If so, I think that a note on this
in the docstrings would be useful.
Looks like there is some missing content here.
the purpose of this _ever_active_set is unclear. Can you clarify the usecase?
you can use the "for else" idiom to catch failing convergence  see for example:

https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/cluster/affinity_propagation_.py#L157
if X and y already have the proper types a copy should be avoided
думаю лучше задавать конкретную категорию из фикстур. с current потом может получится непонятка.
и можно сразу несколько т.к. мы сделали множественную привязку
Would that be accurate, though?  Or do you think I should move this method into mock_provider_application.rb?
Same as the previous comment. Does this message looks good? "'l' is not a valid suffix, did you mean 'L'"?
@sorenh  good catch. and so you know, I will open a bug against keystone for this (it should be supported with the client tools)
Single line between methods.
I'm puzzled to why we are re-defining the basic shapes.
Did you see the types from lucene-spatial ? They are on classpath as well; see for example
`org.apache.lucene.spatial.geometry.shape.Rectangle`
You want this output to be concise.   unsigned<n> instead of unsigned integer<n> would be more compact.
This is probably more of a pain than it's worth right now ^

It just requires a tiny change to the install script, so let's forget about it for now. We'll likely change this substantially soon anyway.
yes we can and must ;) can this be in another iteration though? I am waiting for this to be merged before moving on.
It's Apple's version of HTTP.

On Tue, Sep 4, 2012 at 4:34 PM, Max Goodman <notifications@github.com>wrote:

> In reddit_about/data/timeline.json:
>
> > @@ -20,5 +20,6 @@
> >      {"date": "2011-10-18", "class": "org important", "title": "/r/reddit.com archived", "url": "http://blog.reddit.com/2011/10/saying-goodbye-to-old-friend-and.html"},
> >      {"date": "2012-01-18", "class": "culture important", "title": "SOPA blackout", "url": "http://blog.reddit.com/2012/01/stopped-they-must-be-on-this-all.html"},
> >      {"date": "2012-03-08", "class": "org important", "title": "CEO announced", "url": "http://blog.reddit.com/2012/03/new-reddit-ceo-reporting-for-duty.html"},
> > -    {"date": "2012-04-01", "class": "culture", "title": "reddit timeline", "url": "http://blog.reddit.com/2012/03/introducing-reddit-timeline.html"}
> > +    {"date": "2012-04-01", "class": "culture", "title": "reddit timeline", "url": "http://blog.reddit.com/2012/03/introducing-reddit-timeline.html"},
> > +    {"date": "2012-08-29", "class": "culture important", "title": "First Presidential AMA", "url": "ihttp://www.reddit.com/r/blog/comments/z5ftg/potus_iama_stats/"}
>
> "ihttp"? ;)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/reddit/reddit-plugin-about/pull/12/files#r1529122>.
>
>
I have never had problems with parallel builds either; It was just because when having troubles installed dependencies (like I did earlier on) it made it very difficult for other users to figure out what was going wrong.  Having it as `if build.debug?` is a wonderful idea, thanks!
вернуть 2
You can do `handlers = [logger]` instead. So we have that code in a single line.
Also indentation issue.
empty test method?
just noticed this... what does ```value == u'[]'``` mean? wouldn't an empty list look more like this: ```len(value) == 0```?
as above, there were glitches observed with it
This code will break in Ruby 1.8.  Could you please try Rex::Text.to_utf8() and see that works ok for you?
Some apps want "\r\n", some don't. If you favor one over the other, you probably risk breaking existing modules.
I dont think you need a Tempfile and file operations to save id's found in the main loop. Using an array should be sufficient to store usernames, right?
yes, of course - changed.
This is also just a copy of the original 'openActiveSessionWithPermissions' method. There needs to be a better way to pass along the session delegate.
This feels hacky, doesn't it?  Position size isn't a property so why it is grouped with properties.  This loop also implicitly expects that  `POSITION_SIZE_INDEX` is greater than or equal to `NUMBER_OF_PROPERTIES - 1`.

How can we reorganize?
We should be using the Color object here and in all Color examples.  Internally, you should also be using the Color object.  There are only two ways I can think of to get around the getter/setter, either have a manual "I changed stuff" function the user calls or use shadow copies of the values and compare every update.  Neither of these are good solutions in my opinion, so getter/setter is probably the best we can do (I don't know how I coded all of those years without properties).
In Columbus View the mouse buttons change. The left button translates the camera in a plane parallel to the map, middle button rotates around the intersection of the ray in the direction of the view vector and the camera position and the plane the map is in. However, if you want to follow an object, you want the mouse to feel like it would in 3D mode. I couldn't think a better way. Do you have any ideas, @kring ?
Why `null`?  Why not `undefined`?
If mobileweb is going to support this, it should be included here.
Why dead code?  At least add a reason for the dead code on the line above.
I think what JensTimmerman is saying is that the idea of a constant is that it doesn't change. One could argue that whatever constants are defined in Compiler should remain the same in all children, but you view it as being constant for any instances of the class and basically anything goes w.r.t. redefining 'constants' when subclasses from `Compiler` or any subclasses of it. I agree with you on that: a constant is defined for a class, and your just reusing the same constant name across classes (of the same class tree branch).

Do you ever reference these without having an instance? E.g. do you ever use `GNUCompilerCollection.COMPILER_CC` directly?
If not, these could just be class variables that you set in the class constructor (`self.compiler_cc = 'gcc'` in `__init__`).
I'm not saying this should be changed like this, because then you would be able/allowed to change this at runtime, which doesn't really make sense.
+1 for sticking with `<!DOCTYPE html>`.
I wonder if we shouldn't have this pitch calc in these equations and just force the user to supply the pitch, because we calculate this for the same dataset in many of the equations in this file. There isn't much reason to recalculate it every time.
Сработает. Компилируется в проверку, является ли элемент функцией.
Please add an assert for the featured extensions page title, "Featured Extensions :: Add-ons for Mobile"
This isn't true right now. I haven't updated the readme.
These ones were also already implemented. Also, line 759 has a type so you probably didn't test that function.
I think it would read a bit nicer if you reduced the nesting like so:

```
def wrapped_html(allowed_to_use_fallback)
  return unless is_hidden

  content = content_html(allowed_to_use_fallback)
  # ...
end
```
Yep, you were right. I've added a fix now that creates a new `sepArr` when working with narrow strings. I've also added a `version(unittest)` check that will ensure the reserved amount was correct.
Then perhaps it should use r.save...
uncommented public function
`assertThrown!VariantException(variant.tryVisit!((int i) { which = 0; })());` is better.
Strange, I think I misplaced my above comment. It was meant for here. Got angry when my browser lost it and had to re-type everything >:(

#8902 is indeed strange. How about something like this then?
```D

    static if (is(typeof((inout int _dummy=0){static T i;})))
    {
        static T i;
        memcpy(chunk, &i, T.sizeof);
    }
    else //@@@BUG@@@ 8902
    {
        if(auto p = typeid(T).init().ptr)
            memcpy(chunk, p, T.sizeof);
        else
            memset(chunk, 0, T.sizeof);
    }
```

It avoids paying for the general case, while still supporting the odd case. I would have wished I was able to test `static T i = T.init`, but as you can see in the bug report, that doesn't work either...
Added 7134b603f8c9a2e9124247ff250c9b48ea697998.
Not sure if UFCS is better: `a.destroy()` or `destroy(a)`?
IMHO, this would just make code more complicated.
Why are you dislike `asFlatStaticArray` so much? It makes code simpler, isn't it? If you are sure it's not, why you can't accept it as `package` and than remove it and change code to work without it and show me that I was wrong and your way is simpler?
Actually, the zero was a good test, because it would skip the loop entirely in the cases with a loop. I'm not sure why you would have removed it. I'd advise re-adding it and and then testing the same for the others. It probably doesn't matter all that much, but it's a nice corner case to test.
Yeah, that's a good point actually. In particular, I'm not sure what the use case this fills is anyways.

Besides, the splice I plan to add would mean that if you want to keep the removed range, you could just specifically splice it into another DList, so the functionality is not lost.

I'll change the doc.
It should, I'll add that in the next commit.
But for now, these points are not yet implemented.
Hi!

Just wanted to let you know that I've tried running this on Mac OS now, and there are two errors:

    err: /Stage[main]/Midcom/File[midgard_config]/ensure: change from absent to file failed: Failed to set owner to '1000': Operation not permitted - /midcom/config/midgard2.ini

    err: /Stage[main]/Midcom/File[copy_sharedir]/ensure: change from absent to directory failed: Failed to set owner to '1000': Operation not permitted - /midcom/config/share

After it finishes, I get a blank page in the browser, will try debugging with ssh later on
В этой функции лучше бы оставить только 1 ветку условия, чтоб был 1 способ хранения данных, а не 2. Но я точно не уверен. @kirov ?

ну и + pep8 :)
what about OSX, Linux?
So why is just the order of the middleware execution not sufficient to match this case? Still trying to wrap my head around the use case.. Is it parameter name collisions with other upstream proxies, so you're trying to work around that?
could you use ::operatingsystem instead of lsbdistid. This will make it a little more consistent with how the other modules are coded and not introduce a dependency on lsb
lstatSync and checking modified dates is a very cheap operation. It would need to be a considerably large project before it became noticable. The time saved in being able to do incremental builds outweighs it by an enormous margin.

Again though, if it's out of scope it should be possible to push that back into the end script.
or how about `jsonValue`!
Nice catch! Will update that.
Are there any chances that LLVM will have a symbol that includes the letters "osl" ? (I guess none yet since you manually verified the output of `nm`)

Just wondering if it would be better to use `OSL*` and `osl*` (and update namespacing accordingly if there's anywhere another prefix could occur).
packet_seqack
I think you're right that this should default to false now, but I think that if we default "open_ssl_port" and "open_postgres_port" (wherever we end up keeping this one around) to "true" then we are preserving the old default behavior... right?
Плюс на предыдущую стрчоку.
If from and to dates are the same, adjust formatting
Well, than let's discuss that as part of a separate issue. This current one modified the existing functionality but doesn't change the design. Adding @Tx does so I don't want to bundle it with this PR regardless.
We can open another JIRA sub-task under INT-2544
Does it make sance to say a not in the manual about JIRAs, if they will be fixed a month or two?
Null checks are done where they are used (signals whether the feature is enabled or not), but I can add asserts here too, if you think they're really needed.
Is there a reason to use System.out rather than using a proper Logger?
When you say - parser rejected "" - you mean our code I assume. If so we can change it.
We already have something like that for  remote-file-separator where we provide "" for cases when dealing with Mainframes, so it is consistent. 
I have no problem with the new attribute, and the new requirement, and in the perfect world I would go the route where 'use-temporary-file-name' wold be a sub-element of the ftp adapter containing 'temporaryFileSuffix' attribute, thus avoiding mutual exclusivity. Of course we can make an exception, and we do have cases with mutual exclusivity but do you guys think that this corner case is important enough to justify it especially in the point release? OR, can we still work with temporaryFileSuffix == "" and possibly raise a JIRA for 3.0
All methods sent to OriginalConsole need to be wrapped in a try/catch, or otherwise protected.  In some/many/all cases, the native platforms don't implement all/any of the console methods, and blindly calling a null will cause exceptions in the user's code.  

Nothing special to do when an exception occurs in these cases, just march on.  But they do need protection.
remove second condition
I am not so sure I agree with making the default bios set disable virt bits for just allocating a node.
We must have the article (the) in the translation string as part of the substitutded variable to be able to translate it correctly i.e.:

    __d('crud', '{name} was successfully created'), __d('crud', 'the ' . $name));
Actually, it's used on the next line, I should have taken a closer look.
Is it really needed to indicate this as this function is executed when the data is loaded successfully ?
Good idea. I've changed all instances of /home/$USERNAME to $HOME.
yeah, I forgot to remove it when I copied the functionality. Fortunately we're factoring this out of puppet_spec_helper anyway, as it's module-specific stuff.
you should put a default value set to the empty string here too
Yeah will definitely add that.
This is sharing a field that was created in the CreateText method? Aren't they totally separate?
making things PSR-1 + PSR-2 compatible
I can't see a situation where a CustomError will be thrown? your list comprehension might fail, but that wont raise a CustomError, it will be some other  kind of Exception.
If we're localizing all this (and I'm not 100% sure that's the right thing to do), shouldn't we use `new Date(date).toLocaleString()` here? Or does B2G do something silly and assume everyone's in the C locale (I vaguely recall kaze saying something like that). In that case, what *should* we use for localized date formatting?
To make this work with the alias you'll need class CookbookDepsInit < CookbookDependenciesInit; banner ' ... '
"upwards touch gesture" here is confusing wording.
La t_queue (salvo por queue_peek) se está comportando como una pila no como una cola. Una cola debería tener dos punteros y poder obtener elementos y recorrerlos desde el principio y desde el final de la misma.

Me parece que deberíamos llamar a este tad "stack" y hacemos otra implementación de queue. O bien directamente cambiemos la implementación.
`from it`
This should be `[actionSheet dismissWithClickedButtonIndex:-2 animated:animated];` See the `actionSheet:clickedButtonAtIndex` for an explanation.
Change to match idempotent request above
The "and" was simply for alignment with e.g. [#2](http://scalapuzzlers.com/#pzzlr-002) and [#3](http://scalapuzzlers.com/#pzzlr-003)
Ok, i didn't saw the import. :/
So you suggest to use always:
from facebook import fb

and then something like:
class Model(models.Model):
  facebook_user = models.ForeignKey(fb.User)

that makes sense for me
Using the GerritTriggeredEvent as the key sounds good, just need to make sure that all event types returns a different hashCode for the same change and patch set combination, but the same for different instances of the same event type;
Like the autogenerated hashCode today returns 83 * hash + xxx, each event type should have something different than 83 for example.

And that would probably play well with refUpdated that doesn't have a change associated but is still an object that can generate a hashCode.
Ok i know this is nitpicking - but search or create an issue should be 'search for or create an issue'
``2.1.*`` is exactly the same than ``>=2.1, <2.2``
Use window.webworks.defineReadOnlyField to define read only fields
Why 5?  should this be numberOfMenuItems?
Should we be making constants enumerable? It seems related to whether we want it to show up when developers uses  ````Attendee.keys````  or ````for ... in```` . I think not but I thought its worth bringing up
{ should be on the previous line this happens a lot, so i'm not going to comment on them all but they should be fixed before this is merged
Verified with Chase.
Since this is required (more or less), let's try to add it automatically, rather than hoping that it is already in the template.
strange indent. aligne parent_project with language_code
Are you sure that en_US is required here? It should be first in the list by default.