labofsahil/github-event-dataset-2012 huggingface dataset:
I change the testing case with the following code.

      // Click on second item
      clickAt(jq("@listitem .z-listcell-cnt"), "5,15");
      
      // Record the selected item text
      val itemText = jq(".z-listitem-seld").text();
      
      verifyFalse("The selection cannot be empty", itemText.isEmpty());
      
      // Press enter key
      sendKeys(jq("@listbox").toWidget().$n("a"), Keys.ENTER);
      
      waitResponse(true)
      // Verify that the messagebox is visible
      verifyTrue("The Messagebox should be visible", jq(".z-messagebox-window").exists());
      
      // Press enter key again
      sendKeys(jq("@button").toWidget().$n("btn"), Keys.ENTER);
      
      // Verify that the selected item is the same as before
      verifyTrue("The selected item changed", itemText.equals(jq(".z-listitem-seld").text()));

the sendKey() method of Selenium API in some browsers can only fire to the focused target where the element can support with, like Button, A(anchor), Input, and etc. So we must specify the focused target for that API, like __jq("@listbox").toWidget().$n("a")__

By the way, I will change it after merged your commitment.
That's left over from when I was including the file. I wasn't sure if we were still wanting to send a 404 status. But in any case, it does error out with the trigger_error() under the send_status_line() function.
I'm excited about this feature. (Some time ago I considered adding it as a wish-issue, but then I decided not to do so, I create too many issues anyway :) ) Thanks.
Changing the lines below, yes they are bad, but I they dont seem to be directly related with this issue.

I will take a look of them, but I dont want to mix.
Simplest feature ever:

I dont know why, but in every messenger, I always look for the email this way too.
Committed this by mistake, oops.
I have tried @Sbte considerations, and ConversationManager is catching "button-press-event" signals, don't allowing child widgets to receive it. 

I have just read gtknotebook.c in order to see how was treating "button-press-event" signal, and is comparing x,y coords too.
If you click in a place corresponding to tab coordinates, will focus the tab.
Oh okay, I see.

Maybe we can change this so that it reads from a configuration file somewhere in the environment?  I think that the IP addresses of the different instances are available (somehow?) from some kind of configuration file?
I opened a ticket for this: we should be able to quote these names in the schema.
https://github.com/yesodweb/persistent/issues/61
Well... I used "???" as summary to encourage you to write a summary not because I think it is a good summary.
> what's the reason of loading script in the top of the page?

Fixed. Moved under the form
As does this one.
results in a _minus_ of 70 lines of code ;-)
Looks good.  The new ability to modify `app_categories` from config is a nice touch.
http://www.w3schools.com/browsers/browsers_explorer.asp
1% (other sources cite 2-3% as well) seems like a low enough margin to begin accepting less-than-ideal ie6 solutions that improve performance for the higher-margin bases (Chrome 16 and 17 together hold ~32.4%). I'd say Firefox 3.6 is the browser to really worry about (fortunately not in this case, though.)

I don't think there's anything wrong with writing "shiny" code as long as it's valid or all browsers work with it. There's a good reason why "0/0 a" is used here; it is the shortest version of code, and if it becomes a standard, people will recognize it for what it does, not what it semantically means.

IE6 users shouldn't be ignored, true; however, there is a hierarchy of importance in these decisions.
Hm. That's funny. I've occasionally thought of asking you to make your commit messages more verbose. ;-) I find that I often can't tell what your commits do without actually looking at them. In particular, I have the network view in mind, where only the first line of the commit is displayed on hover.
Some mirrors didn't work at all (for `git` non worked, all `gnu` ones timeouted out all the time, etc). 
The gnu mirrors are located in America iirc, and that could be one reason they didn't work for me.
I will get them back again, if you want
*shrug* They're just files, once made you hardly ever have to look at them. But if you want to take a look at generating them be my guest ^^
Yeah I keep switching back and forth from Linux to Windows and vice-versa, I never know which line break style is the current one.  I plan to convert all files to LF after you finish your changes.
@rudwjd1212 아뇨. 제대로 공헌해보세요.
@Vincent-Michael that code you pasted affects ONLY Raise Dead spell
D'oh, I mean world-specific.
This code review tool kicks ass.
Heu... There is a lost bracket!

   $r = \new ReflectionClass($all[0]->name);

instead of 

    $r = \new ReflectionClass($all[0]->name]);
Minor change: I think this would qualify as a warning message rather than just an informational message.
If you make minTxViewId a volatile, it might be slightly faster to only update it if the value changed.
мне кажется что ты уже добавил абилити can :access, :rails_admin  так используй его.
Допустим появится еще одна роль (менеджер) которая также должна иметь доступ в админскую часть, тогда (при условии что все прописано через абилити) тебе надо будет добавить одну строчку :access, :rails_admin для новой роли и все. Иначе ты будешь вынужден искать в коде где ты проверял роль вручную, еще хуже когда это должен будет делать другой разработчик который не знает хорошо логику приложения - очень большая вероятность напортачить.
el core bastante aceptable (eso si, no llevan hecho nada de arenas aun), pero la DB una mierda aún xDD
The url may often be blank, so it has to be unique only when not empty.  There's some javascript in GeoExplorer that tries to enforce this when saving a map but there should probably also be some django code to check uniqueness again before saving.
Reviewed, corrects earlier rejection
Congratulations to everybody!  seems like we have a head group here and a group of pursuers... looking forward to the next race!
Oops. Copied from CliRemoteListProjects.class.php and forgot to update this. Daniel clearly deserves all the credit.
Yes, I'm just wondering what was they idea behind checking for :to_ary.
Sorry to annoy you again, but this is also not valid, in a branch (as in the master one) either you need to specify the upcoming version number (1.0.0 - then it uses 1.0.0-dev until it's tagged) or you delete it and it will use the branch name (as 1.x-dev).
Will do. I was thinking it may have caused the problem with initialization, so I was testing it out.
Hmm, seems to not clean out the obj directory correctly for 'mixed' projects (project is of type apk but also contains native code), will fix that.  In any case, I removed the obj manually and it builds fine for me.

Hugo/Manfred, could you remove the obj folder manually and re-run a build?
A huge THANK YOU for finally doing the build system right. I got it up and running in under two hours on AgiliaLinux. Lots of <3 to you.
O JavaScript é uma linguagem de programação simples criada para dar mais interatividade e maior funcionalidade às páginas da Web. Tendo sido inicialmente desenvolvida pela Netscape, a linguagem JavaScript acabou por dar origem à especificação técnica ECMAScript, que é um padrão oficial reconhecido pela indústria. Apesar desta linguagem ser mais conhecida pelo nome de JavaScript, e de a versão produzida pela Microsoft ter recebido o nome de JScript, a verdade é que se tratam de implementações que sendo fiéis à norma ECMAScript lhe acrescentaram novas funcionalidades úteis, mas respeitando sempre as especificações oficiais.
You can probably lose some whitespace here :)
and here

V4L2_CID_CAMERA_FINISH_AUTO_FOCUS
Ohh....yes
Sorry, I should have been a little more careful when I merged. This breaks Python 2.5 which doesn't have `collections.Mapping`. #8 has been opened to track this.
Good point - on reflection, now I see why the core jms parser allows both to be set and simply uses the containerClass as the class (if provided) and then uses the containerType for the other attributes.

Unless I see objections, I will change the channel parser to work the same way as core.
Err... *Minor* change? ;)
I assume that this was just a trivial bit of test cruft.  That being the case, looks okay.
I'm curious to try this... we seem to have strange luck with audio on the U8150.  btw, where did you get this code?  I find CAF's website hard to navigate...
I think you meant non-indexed column, not row
Did we ever issue a pull request for this? Would be good to rebase and then do so if not.
Tested this and now preview doesn't work when camera app is started
On Mon Mar  5 12:43:58 2012, BaptisteMeynier wrote:
> Salut David,
>
> Le projet Thunderbird est reparti sur de meilleurs bases, tu pourras 
> télécharger cette nouvelle version à partir de la branche 
> AddressBookOverlay. Un entretien via skype serait il possible mercredi 
> ou jeudi en fin d'aprem pour te faire un compte-rendu de l'avancement 
> des deux projets ?
>
> Baptiste
>
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/BaptisteMeynier/ThunderBird-Multi-Accounts-Manager/commit/a9446992d0db04412387b2002052a4d255c06e4d#commitcomment-1042690

Bonjour,
Je serai disponible en fin d'après-midi aujourd'hui ou demain. Que 
diriez-vous de 18h ?

Cordialement,
 David
this didn't just fix completion, it changed it's behavior.
e.g for "pip install --" completion, it used to give install options and general options (excluding those marked as SUPPRESS_HELP)
now it shows everything, 
"pip --" completion is still the same in that it still excludes the suppressed ones.

how about let's just fix completion and not change it.
if you want to change it, lets include that in your plans for your next pull.
Should the above constants be in the `OAuthConstants` interface along with the rest?
Readability trumps premature optimization in my book...  :)

"premature optimization is the root of all evil."  -http://c2.com/cgi/wiki?PrematureOptimization
Would it be possible to make this less specific to ScalaVersion and make it something like "dealias" or something that takes a key-value map for things to be replaces with something else
true, will remove
rename inResponseToFailure to causeOfFailure
also, what happens if the member doesn't exist in localGossip.members, for example moved to unreachable, then you get it a two places
you don’t really need to wrap things inside an object like this
certainly; got it
Isn't the initial value always null?
Care to take a stab at it?
I have created a ticket for this: https://www.assembla.com/spaces/akka/tickets/2744
We can release 2.1 without fixing it.
Why change to JVM?
the tasks are `multi-jvm`
classOf[JavaLogging].getName didn't work?
Okay, I'll take care of it tonight.  Is there documentation on the doc
build system/syntax?

Ipython becomes very useful for learning the API with a running App object.
 Is it appropriate to include an example explicitly using Ipython?

Also, I would like to make a unit test.  Since the test would launch an
application, I'm not sure if this would be annoying to test runners.  What
do you think?

On Mon, May 14, 2012 at 11:55 AM, Mathieu Virbel <
reply@reply.github.com
> wrote:

> > +    def run(self):
> > +        self.thread.start()
> > +        #Proxy behavior starts after this is set.  Before this point,
> attaching
> > +        #widgets etc can only be done through the Launcher's app
> attribute
> > +        self.__subject__ = self.app
> > +
> > +    def stop(self):
> > +        EventLoop.quit = True
> > +        self.thread.join()
> > +
> > +    #Act like the app instance before __subject__ is set
> > +    def __repr__(self):
> > +        return self.app.__repr__()
> > +
> > +
> > +#Here's some testing code.
>
> Before pulling, can you remove (or include in the module docstring as an
> example) this part?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/kivy/kivy/pull/484/files#r817581
>
hm server side there is support for discontinues ids. But i guess that is for a new commit.
Looks like a good idea. Will give it a go asap.
Agree, I don't think we do this elsewhere in CKAN, e.g. with groups, datasets, users
That's fair. I wrote that comment before getting to that part of it.
This one is interesting. The binding is the resource, but I wouldn't mind seeing more information in the tags to identify what is actually being unbound. Maybe I'm viewing tags wrong, but they are kinda my go to when trying to figure out what a task is actually doing.
Missed this one, thanks. Fixed.
Hmm.. wouldn't this always stop?
why the check for minor version here?
Seems to me that GetReplaceString() should just return a std::string and handle the memory cleanup itself.
```py
msg = '%s returned HTTP %d: %s\nResponse\nHeaders: %s\nBody: %s'
logging.error(msg, url, response.status_code, kwargs,
              response.headers, response.text)
```
Pretty much all that was left of the chunk manager was these requires, so it didn't seem useful anymore
Wrap the creation of the endpoint inside the watch call
This should be an `NSUInteger`.

This should be declared in `TUITextRenderer+Private` so the implementation doesn't have to declare it.

This method is always used in the same way – to scroll to the selection. Why not just make it into a method for doing exactly that?
Good question. From what I understand, the idea is that this allows node.exe to run on Windows XP when some of these APIs aren't available. I'll do the legwork to make sure we actually have that problem here.

For the ETW code, we did; less sure for perf counters which existed even in the very early WinNT days.
hmm... I have no clue!
In my implementation I wait for all deferreds to be complete before rejecting `allDone`. jQuery doesn't wait, but I think it's probably a good idea to do so. What do you think the user's expectation is?
Do we also want deletion of a file:foo/bar directory when the get_value(["content"]) is None?
It looks like only difference between `PyBUF_C_CONTIGUOUS` and `PyBUF_F_CONTIGUOUS` is what ends up in stride? If so, this section could be simplified.
This should be a check against a constant, like NPY_CHECK_UNKNOWN_AXIS (#def'd to -1).  That might also allow some future extensions like NPY_CHECK_FLATTENED_AXIS, to allow more informative reports in the case of indexing an implicitly flattened array.
I didn't check the value for being valid because the [email field](https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/tags/email_field.rb) also needs to be a valid email address and we don't check if the value passed is valid or not.

So, the question is, should Rails start checking the correctness of these fields or not?

http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#e-mail-state-(type=email)
This doesn't make sense. Why check `debug?` if we are using `info`?
Oh, whoops--I see you doing that later on. Nevermind.
`atPhase` --> `enteringPhase` or whatever it will be renamed to :)
Could we test the Comment itself instead of the html output? Matching html is more or less banned after the last scaldoc-breaking-trunk incident.
Sure thing, sounds good.
By the definition that it's safe to continue executing the VM after a control throwable or a `NotImplementedError`, those should probably not be considered fatal.
No-op, remove
This hack can be replaced with a call to `ctypes.addressof` via Python space -- I'd like to avoid mucking around with CPython internals.
Should we require that a date range be specified, as supposed a single date? We could always have end_date default to being the same as start_date (so a single day), or default to "today"?
The typical argument name is `expr`, not `function`.
This sometimes fails for me and sometimes doesn't. I don't understand what's going on. I suspect it has something to do with Lambdas and Dummys.
On Wed, Apr 25, 2012 at 9:06 PM, Tom Bachmann
<reply@reply.github.com>
wrote:
>> @@ -1974,10 +1974,11 @@ def carryout_plan(f, ops):
>>      # Now try polynomial cases
>>      res = try_polynomial(nip, z0)
>>      if res is not None:
>> +        from sympy import unpolarify
>
> Doesn't work. But here really doesn't make sense. I put it at the top of the function.

ok
Is this duplicated elsewhere? Why is this being deleted?
>
> We'd have to compute the hash somehow, e.g. with
> `hash(frozenset(dic.iteritems()))`, and either put the calculation in
> _hashable_content or create a subclass of dict.
>
>
http://code.activestate.com/recipes/414283-frozen-dictionaries/
The exception is a fall back. Presently there is no case where it reaches the exception branch. As the plotting module has not been tested completely, I have included the exception catching.
Yeah, I will do that and address your other remarks.
It looks like you've really reduced this down. Nice work!
Well, I hate Prolog, basically because it's a mess and because it's older than the time itself :-) But yeah, the `append` predicate is very impressive.  (Thank you for the link!)  I'm more into functional languages, and, namely, it's Haskell that dominates my soul at the moment.
Please move this to `grunt.utils.reallyExit` to make it more consistent with `grunt.exit`.
How can this work? Don't they all have the same name (i.e. the category name)?
An example would be great here.
Kolman,

I need your help to resolve this.
Please add tests:
1) When defining a parameter twice raise exception.

Bad:
Params.parameter('ku', 1, 'ku desk')
Params.parameter('ku', 2, 'ku desk2')

Good:
Params.parameter('ku', 1, 'ku desk')
Parameter.ku = 4  # change the default value.
These items all need to more closely resemble complete sentences, which means: 

- beginning with capital letters.
- ending with periods.
https://github.com/a-leung/mongodb-docs/blob/c2fda9f17af49cd182e4420fa2d2e276d4fdd5db/draft/applications/geospatial-indexes.txt#L239

That says circle. I'm not sure if the other geo documents make this mistake, but we should check...
I would pick a more representative name like `calculate_attendance_button_text`
yo ricky, care to elaborate?
What is all this markup from?  It is a bit ugly. :)
Just cause a battle has been won doesn't mean the war is over ;-)
IMO we should inject it. It costs nothing to do so, and potentially allows mocking for cleaner unit testing.
I'm not sure what the right solution would be but this looks very wrong to me.
Should be `$this->path` instead of `$path`
Use enabled rather than disabled.
These are not just any objects. Please check other files for correct types to use.
Yeah... Basically it does not make a big of a difference, anyway, just to make it clear. If I didn't set it manually, it does make more sense to test it using the isset(). Anyway that's only my opinion.
sbteclipse or any other IDE related plugins must not be part of a project's plugins definition. The proper place is your local plugins definition at `~/.sbt/plugins/plugins.sbt`. Please remove this line.
Is this comment valid given that we have paramIndex ?
Using-statements should be places inside namespace declaration
why do you get the ```value``` here, but not in any of the other if blocks?
For all your permissions, you will want to add "Add Drug Info" "Edit Drug Info" "Delete Drug Info" "View Drug Info" or similar permissions for drug group. These permissions will go into the config.xml
Fixed by SciTools/cartopy#58. Iris workaround will be removed in my PR.
As above, extract this out to cartopy or matplotlib.
symmetric
takes
remove "the op"
here too repetitions of the same role? r1,r1,r1
Didn't you miss a ! here?
ref, sink, and sender are all included in mrc_ctx{}.
The `state.built` in this msg is redundant since it starts with `Not built...`.
Agreed. Let's leave it out, until we have a better (less expensive) way to do the computation.
`var BEM = require('bem');`
At first glance I would worry that this doesn't clear out whatever gets set previously when you close/open it multiple times. Assume that it does and that was tested and I'm just missing something?
Hmm, that's an interesting idea, but tricky to do, especially since in the PostgreSQL backend I use arrays during the query to reduce the number of queries.
any particular reason you've switched from title to capfirst for the filter?
"Whether matches the" -- missing "instance" there.
It doesn't matter, the semantics are that the changes you make aren't visible to other tests.  Remove these lines and try running all the tests, you'll see!
Still waiting for the removal of this file from the commit. ;)
instead of removing it entirely, it should probably be added first, so that the user can overwrite it if he wants
Comment should be a few lines below?
fixed'd
Ok, I'll will change the letter size.
TimeDelay - used only by new function: protected TickTimer PowerDelay(float time)
This stuff is shared among all games running on the server, which means multiple threads are using them in parallel. This is alright for the 4 existing fields cause they're read-only after init, but your instance-ref and cache dictionaries are mutated all the time while running so it's not threadsafe. There's a fair number of ways to do this (like having dictionaries for each Game), but make sure whatever you do doesn't have any big bottlenecks like a single lock all games have to wait on.

Also, how unique is the key used for CachedItems? Is it unique accross the whole server? Otherwise I could see that being a problem too.
Nice! This will hide legitimate `ImportError`s, though. You might want to look at something like what [Jingo](https://github.com/jbalogh/jingo/blob/master/jingo/__init__.py#L96) does for autodiscovery, so that it ignores missing modules but bubbles up `ImportError`s that occur for any other reason.
The password is set by the grant line, having it here is redundant.
errrr okay nm it wasn't a misnaming but we have a content type function so I simply added a field to our item :D fixed!
we can grep through the whole homebrew and replace the `osx_10_5` with `macosxsdk "10.5"` though.
Preferred organization for this is:

```rb
homepage ...
url ..
md5 ..

head ...

depends_on ...
```
Use a list: `"make", "MACHTYPE=darwin", "BINDIR=#{bin}"`
Take a look at this and the other comments. `brew create` works from a template and includes some placeholder items and comments.
The `transport_name` field exists to let us route replies back to the right transport. This is the first time we've needed to do something similar for routing to an application.

We have some vague plans to figure out some more flexible routing mechanism (perhaps similar to how email works), but we haven't really had to do that yet.

There might be a way to hook into the message consumer at a lower level and extract the routing key from the txAMQP message.
I can't see any setting in `praw.ini` name `ratelimit` or anything like that. If there is such a setting, it should definately be referred to.
John added a constants file for tracking IDs. It's under pulp.common.ids and in there you can use TYPE_ID_DISTRO rather than hardcoding it.
are these backwards?
c.is_mod is set  https://github.com/reddit/reddit/pull/510/files#L10R212 here
Has a sense. Should we cache hash proxy classes? Or create them dynamically for every new instance of hash?
```
setInterval(runloop, my.interval)
```
A here document (cat <<  eof) is more appropriate here instead of calling echo several times
We need to keep this Bash 3 for compat reasons.
You can then do `if ( hasDataMain ) {`
Can we at least avoid including this third copy of the CPL?
FilterMode.RELAXED was used before refactoring JUnitCore. it is not required at the moment, but since it was already implemented I thought I can as well keep it.
+1 for `> 0`, exactly what @hornairs said
Should this be `before`?
I actually meant a getter not a delegated method :)
Why do we need the underscore before Help and after Folder?
The name of the tabSelect parameter is too implementation specific. This makes it hard to add support for any other keys.

Actually, I don't think we need that parameter at all. When hinting urls, your code is smart enough to know whether a folder or file is selected when Tab key is pressed. So, if a folder is selected, then IP is left inside the quotes and hinting continues. But, if a file is selected, then IP is moved outside of quotes and hints are dismissed. Awesome job!

Since code now recognizes the distinction between a url folder and a file, then we don’t need Tab key support at all. This can all be done to work with Enter key (and probably mouse). Is that correct?

If so, then this seems like the best of both worlds to me:
•	url hinting works as desired using Enter key (even with mouse?)
•	user does not need to discover Tab key support
•	user does not need to remember when to hit Tab vs. Enter
•	user can enter Tabs in doc while hints are displayed

What do you think?
Jasmine will call reportSpecResults() even for specs that didn't pass the specFilter and were never ran. Not intuitive. I'll add a comment.
My mistake, "once" shouldn't be in there. I now apply a heuristic for detecting these handlers, which can obviously never be perfect. Direct ways to improve it are either using a white list or a black list, and a white list doesn't seem like a good option. The treehugger ones are simply cases that I encountered. Treehugger is especially annoying since *some* calls to the API show up as events (args of the form (string, function)) and some don't (string, function, string, function). It simply seems to work better at least on our own code base with this blacklist in place. And in the end, library-specific support only seems pragmatic in JavaScript.
On 13/09/12 21:15, Cesy wrote:
>> +    it "should have an unlock link" do
>
> Missing an actual test here?

D'oh! Good spot.

Miles
This was the magic incantation indeed!!
my guess is that that would be the opposite of what we want: you need to keep the file open for it to be read from. I'd think FileWrapper's responsible for closing.
Thank you for writing a test!
I'll had a short glance at `Utility.Retry`, but it relies on a thrown exception, not a boolean condition. May I add such an implementation?
Do you think its better to patch Element for IE7 or to use a different shim for fallback?  Example

```javascript
if (el.addEventListener) {
  el.addEventListener('click', modifyText, false); 
} else if (el.attachEvent)  {
  el.attachEvent('onclick', modifyText);
}
```
OK, you will also have to sync form fields with model fields (like default value, limits, and so on).

What is `current_date` doing in this file? Useless.
Hmmmm. That ... is odd.

This is worth talking about. Not here though.
These `popcornOptions` don't make sense, and I think they crash your tests :(.
these two var blocks can become one
I think this should be 2
In this case, checking for truthiness will work fine, but I was making this consistent with how I checked for row/column. Since I generally use a truthiness check in other places, though, I'll alter this to `!type`.
de-DE here
Nop diff
Add a different counter for this, so we can see how many times it's called
the tag is v1.0 not 1.0.

BTW you may consider to use 1.0.0 instead of 1.0, please refer to semantic version: http://semver.org/
Thanks, done. PTAL

Still not sure why Sprinter has two separate definitions for 646 and 1286/7,
and why lincomatic had to change it to make Printrboard work.
The solution with permission is nice. Maybe if you could replace `uname -a` with RUBY_PLATFORM (if it contains what you expect - my wild guess is it does), but that is minor issue. ACK
this line is mega-long, this should be fine `this.connection.encrypted || forwardedstuffhere`, break it into two vars so it's not so crazy.
`var fwd = req.headers && req....` `this.connection.encrypted || fwd == 'https'`
Another thing - can we also add an extension method for listing lingering multipart uploads (e.g. `ex_list_multipart_uploads)?
This will [perhaps change in the future](https://bugreports.qt-project.org/browse/QTBUG-25083). Since the DPI is variable from platform to platform, I think the safest solution is to either allow phantom to set the dpi of the environment with some sort of configuration, or use a different zoom factor for each platform to get consistent rendering.
My first reaction would be to say to have a simpler method `setBinaryEncoding()`, but I guess this method, later on, could be enriched with support for actual char encoding, so that we could select `UTF-8` or `LATIN-1` or `ASCII` or (as now) `binary`.
This could make the method more flexible and useful.

What do you think?
That's not a bad idea--including the table itself.

The `setup.py sdist` command could check for updates to it whenever building an sdist, to make sure we always include the latest version when doing a release.
Is this a left-over or a to-do?
Bitcoin is the core technology and the client is using this ... that's how I think about it.
Could this perhaps go into bootstrap.php instead?
This entire bit needs to be indented one more level (see the assert below it)
Does our style guide not require a space after the comma there?
QueryRootBranches was added to the api for vs 2010 onwards. is that a problem?
Okey, I'll add the changes.
```
A casting compiled regular expression trait.

Accepts both strings and compiled regular expressions. The resulting
attribute will be a compiled regular expression.
```
Indeed, I should have seen that.
Is there a way to  make `env` maybe more gloal ? Maybe by making it an attribute of self.application.notebook_manager ?
@ellisonbg might have an opinion on that.
Maybe even using traits for configurability ?
Yes/No/Not-really.
I found [this](http://www.webreference.com/programming/javascript/rg32/2.html)
But you basically can't catch only some type or exception, or you need to use a switch case each time and re-raise them.
In the other hand, you can throw anything, a string, an object an int so it's all about conventions.

Also none of the basic type seem to be the correct here :

  * `EvalError:` Occurs within the eval() function.
  * `RangeError:`Occurs when a numeric variable or parameter is outside of its valid range.
  * `ReferenceError:`Occurs when de-referencing an invalid reference.
  * `SyntaxError:`Occurs while parsing code.
  * `TypeError:`Occurs when a variable or parameter is not of a valid type.
  * `URIError:`Occurs when encodeURI() or decodeURI() are passed invalid parameters.
outch...
is there not a more readable way to get the worksheets ?
the naming convention of toString here is (or should be) consistent for all predicates.  can you switch it back?
Consul should still stay Rails 2 compatible, so we have so stick with `scoped`.
There's not really a point in changing that; you'll want to override that everywhere anyway. The setting isn't even active by default because of the `ZeroShippingProcessor`
I *think* this backslash isn't needed because you are within parens. I think it would look better if the or is on the top line too.
just curious why you chose to use filter rather than get here.  seems like you'll always be getting exactly one item back, if you're passing in the id.
When is this ever not None in this app?
What he means is something like [this](https://github.com/jrconlin/zamboni/blob/0be3d73550ee47d2188b83b591e48ac26eeca901/requirements/prod.txt#L51) that specifies a commit so we are exactly pinned. Otherwise we may end up with a different commit on live than what is on our local systems, which can lead to all sorts of badness.
On Fri, Aug 24, 2012 at 09:24:09AM -0700, Rob Hudson wrote:
>This one and the test above it are exactly the same?

Urgh. Sorry, I forgot to change the filename.
You need to use the name of the switch that you're trying to mock, not `switch_is_active`
It looks like this function is just required for testing, and isn't used in the actual operating code, right?

In that case, it would be a good idea to pull it into the itests file or (better) pull out a separate testing helper module and stick it there (since the itest file is getting ridiculously large).  You can add the prepared statement into Sqerl when the tests are set up (see what I did with the cookbook test setup)
This is all very injectable.
Is this a controller? If so, it's not one that exists in core pyro.
No debug, this breaks browsers with no idea what "console" is.
http://stackoverflow.com/questions/1580596/how-do-i-make-git-ignore-mode-changes-chmod
This happens most times on Windows.
Sorry, I can't think of a good example right now on how/why such a thing would exist in a template. Can you help me out with an idea/example? Thanks!
don't use ``elseif`` as the ``if`` returns.
I've tried to come up with a name starting with `is` but did not find one.
Fixed already. I was faster than you hehehe ;)
this is wrong. It will fail because of the target-dir
> Moreover, at the moment it is actually impossible to use this option, because your code overrides it.
Thanks for testing! I reproduced this problem http://pastebin.com/xBBhjaCX so you're right. I'll fix this problem tomorrow.
That's an interesting solution, however I'm not sure about using one argument for two different things. In cases such as this one, I tend to favor the flexibility of list arguments.
So, what was wrong with the previous indentation here?
Ok, thanks for this info, I'll fix it as recommended.
I agree. I'm working on one now.
是否可以在这里就可以取得初始值并且合并好用户的传入值，比如：
baidu.extend({
    //这是是初始值
}, options); 这样后面就不用再合并用户的值。
注：并未看代码逻辑
если честно, я не смог определить почему это происходит. Не вызывались колбэки after_destroy
Lets do an early return here instead of wrapping the rest in an `else` statement.
This change was made because the tests were forcing an exit here and it was getting caught by the `except:`.
Before we do this. Is there value in having 3 log files? Seems like it's 3 places to look for users when things go wrong, and 3 pieces of data to send to us. And more config. And more stuff to rotate / cull. What are the plusses?
Ditto here perhaps.
Думаю, что надо подобные функции унести в класс в качестве методов, чтобы их тоже можно было переопределять
Test failure on this case:


Tests in error: 
  testFirstFlushOnCompletionEvent(org.apache.hadoop.realtime.jobhistory.JobHistoryEventHandlerTest): 
Argument passed to verify() should be a mock but is null!
Examples of correct verifications:
    verify(mock).someMethod();
    verify(mock, times(10)).someMethod();
    verify(mock, atLeastOnce()).someMethod();
Also, if you use @Mock annotation don't miss initMocks()
  testMaxUnflushedCompletionEvents(org.apache.hadoop.realtime.jobhistory.JobHistoryEventHandlerTest): 
Argument passed to verify() should be a mock but is null!
Examples of correct verifications:
    verify(mock).someMethod();
    verify(mock, times(10)).someMethod();
    verify(mock, atLeastOnce()).someMethod();
Also, if you use @Mock annotation don't miss initMocks()
  testUnflushedTimer(org.apache.hadoop.realtime.jobhistory.JobHistoryEventHandlerTest): 
Argument passed to verify() should be a mock but is null!
Examples of correct verifications:
    verify(mock).someMethod();
    verify(mock, times(10)).someMethod();
    verify(mock, atLeastOnce()).someMethod();
Also, if you use @Mock annotation don't miss initMocks()
  testBatchedFlushJobEndMultiplier(org.apache.hadoop.realtime.jobhistory.JobHistoryEventHandlerTest): 
Argument passed to verify() should be a mock but is null!
Examples of correct verifications:
    verify(mock).someMethod();
    verify(mock, times(10)).someMethod();
    verify(mock, atLeastOnce()).someMethod();
Also, if you use @Mock annotation don't miss initMocks()
  testCommandLine(org.apache.hadoop.realtime.child.TestDragonChildJVM): java.io.FileNotFoundException: File file:/dragon-history/min does not exist
in places like this we need to use full syntax. e.g.

if (condition) {
    // do something;
}
Yes, displaying the context menu on right click up not recommended on Qt. The contextMenuEvent() should be overridden for that or using CustomContextMenuPolicy. (ContextMenuEvents are not something that go through the event loop, so can't be eventFilter'ed). It is hard to believe how what you described would happen, unless the right click up event is not accept()ed, or it is on a platform which emits context menu event on right-click down, so context menu event is already emitted before you receive the right click up event. Because of the way mouse/key events bubble up in Qt, the child should be receiving it first, and should accept() is if it has handled it so that it wont propagate to parent. If there is some code somewhere maybe i can also have a look at it.
This is the save success function will fire anytime something publishes to the "savedDatumToPouch" channel. In this context, it augments the count of savedcount, and if the datum index (arg.d) is less than or equal to zero it stops looping  by callign importCompleted. otherwise it decreses the datum index (arg.d)  by one, and calls saveADatumAndLoop again.
You could just do 
super(PathElement.pathElement(ModelDescriptionConstants.SUBSYSTEM, JPAExtension.SUBSYSTEM_NAME),
JPAExtension.getResourceDescriptionResolver(null),
JPASubSystemAdd.INSTANCE,
JPASubSystemRemove.INSTANCE
);
Seems like we don't really have enough data at this point to justify a container option like `aria`, so I'll implement the simple `role` on menu. We can handle that as experimental, just as we do with the autocomplete changes itself.
The `-sample` is an example. Users are instructed to copy it as a start and fill in to your needs. The fact that it defaults to /testswarm means nothing. Users should, at least:
* Fill in the MySQL host and user information
* Set contextpath to where you have installed it

I am assuming NGINX does support serving content from directories other than the root, right ? So this guide should not enforce any particular install directory. The user can set it to wherever they need. e.g. I should be able to set it up at `http://localhost/dev/jquery/testswarm`.
Is it possible to add the code now to save the blob for videos as well?  When we're able to convert the open activity for videos to use blobs instead of filenames, it will make it easier if the blob is already saved.  That's not critical, though.
You don't eve need to test callbacks.length
Same here, anonymous function, our friend @etiennesegonzac will kick our asses if we merge an anonymous function ;)
Wow, maybe I misunderstand the resend flow here. I thought that if user click ok (result  == true) means resend the message and click cancel (result == false) means we will cancel the resend action and leave the message in pending DB for resend in the next time. If you don't want to store the pending message while cancel, we can move the delete pending message action right after message send callback and we still don't need to do anything about cancel, so I only handle the resend confirm (result  == true) situation here. But what if we send a message in no signal area? In this flow we can only cancel the resend but the message could not store in DB. I can make the change for the flow you said if you confirm(original logic is still not the correct).
Remove this in order to not pollute the log
The naming of your method is good, don't need the comment.
Is not 'isContact' instead of 'is-Contact' ?
per other files and the apparent rationale here, typeof(window.Calendar).  (or an 'in' check if you're trying to avoid SpiderMonkey's strict mode (the one that is not "use strict").
eww, long filenames.
`if (!wifiManager || wifiManager.enabled == value) {`
We probably don't want to land debug code:).
Aha.  Try escaping the backticks?
Why not 1, even if Firefox decides to up it to 10 itself? :)
No crazy toString stuff it will simply map to the constant table. I could just use hard-coded strings for store names.
A smiley face? Let me tell you...
It's not printing color with -nc, but it's still printing the error. 

Should it not print the error at all?
Nope, just here is fine.
違うのは、コマンドの実行方法について、より多くのコントロールがきくということと、Rundeck の Web アプリでよりよいトラッキングができるという点です。

→

    違うのは、コマンドの実行方法について、より多くのコントロールが効くということと、Rundeck の Web アプリでよりよいトラッキングができるという点です。

効く
I think this could extend Function2[V,V,Double], and use it some other places.
We need to renable this.  I think we disabled it when joinWithTiny was broken due to cascading HashJoin was broken.  Since it (mostly) works now, I think it should be turned back on, otherwise we won't ever get bug reports.
More like that, yes. Maybe the RESTful way would be: POST to /preset creates a new preset. POST to /preset/<n> appends a new response to an existing preset. But in practical behaviour this won't be any different than POSTing the same info twice to /preset...
Add a comment indicating why you throw away the second argument.
move that two lines down
use nlog.
That's where these media queries came from; the core-14 mixin from the toolkit.
Also, ChangesConnectorComponent doesn't have a resolveTags method -- so this code is rather untested!

I think what you want is `self.master.db.tags.resolveTags(tags)`
use the constant BASE32_BITS instead of 5.
I know how to fix, will merge then fix. Thanks!
No need to copy the variable name there AFAIK. I'd rather have it removed because it's the kind of stuff that easily gets forgotten when one renames a variable.
is it an editor giving a mistreat here and warping lines or there was a purpose to split the line here?

btw -- you could simply update previous pull request (usually it is just a matter of pushing into the same branch with changes on top of existing pull request)
Its so we can override the Front for testing purposes, cannot override a Singleton object
This should be defined only in scope where it is needed.
Fair enough. I just mindlessly copied from another plugin (sns I think).
I will fix it.
Can this just be called :context, not :applicationContext ? Maybe include a sample of what the web.xml part should should match?
is this ack the only difference between hot_bunnies and the "else" code?  If so, maybe we can just wrap this line in an if?
- change access modifier to protected
- move to application controller
Nor `manifest`?
So we use `owns` in other modules, let's keep this name to be consistent & if we decide to change it we can do so in all places at once in a separate bug.
I would remove the entire ```tag_results_page``` method. One would not normally access this page directly via a url, but would always get here by clicking a link (I believe).
In your tests, but if they get used elsewhere it might be helpful to have at least a basic HTML structure. 

or yeah, move them to `interceptor_spec.rb`
yeah I think either way has merits, I don't really care which if failing her is preferred that's fine.
@daniel-pittman so fired up windows vm, and it interprets the 'c' as a relative path and raises:

<pre>
irb(main):004:0> Pathname('c').realpath
Errno::ENOENT: No such file or directory - C:/work/puppet/c
</pre>

Which would  give the wrong results if I had a 'c' directory.

Alternatively, you could use `rpartition` (though it's not available on 1.8.5):

<pre>
irb(main):006:0> 'c:\foo\bar:17'.rpartition(':')
=> ["c:\\foo\\bar", ":", "17"]
</pre>

Or greedy regex:

<pre>
irb(main):007:0> 'c:\foo\bar:17'.match(/(.*):(\d+)/)
=> #<MatchData "c:\\foo\\bar:17" 1:"c:\\foo\\bar" 2:"17">
</pre>
should do this above or at a higher describe block
Aww, I <3 you too.
Good idea, I will implement it like that and get back to you when ready. Thanks !!
The use of underscores for express visibility is discouraged
I'm not really happy with this one and am trying to figure out how to restore it. What came up while working with it is that the parent service manager gets checked for instances anyway, and that is kind of weird (probably depends on the weird hierachy within all these Di proxies), since peering service locators should not be checked. That basically means rewriting some methods of `Zend\ServiceManager\Di\DiServiceFactory`.

I will probably end up using composition and losing a bit of performance, but at least it shouldn't be so messy.
I think this could be an issue. See my notes on createServiceWithName().
There should be an upgrade step installing this index.
It should be installed using ftw.upgrade's ``catalog_add_index`` (see https://github.com/4teamwork/ftw.upgrade#upgradestep-helper-methods ) and the document_date of the file objects should be reindexed.
Oh, hey.
Also, we might just want to call it EntityType or something like that, since it's not the actual id itself. Doesn't `EntityType.BAT.getId()` make more sense then `EntityProtocolID.BAT.getId();`?
This will set the wrong directory.
OK guys.. i'll change it
just checked the translation strategy implementation - we will get a PHPCR\ItemNotFoundException when trying to delete a non-existing locale.
This was messed up when I rebased, this is the comment counter beginning to trickle up though.
Nitpick: `if ( !empty( $result ) )` instead ? :wink:
Nitpick : "with array settings" maybe ? :smiley:
s/Too/To
It should be noted that many of these flags are not guaranteed to work. SSL / Compression / etc. is not implemented right now.
Suhlasim, ze takto ako momentalne je, nema zmysel tuto triedu mat, lebo nic rozumne nerobi.

Podla nazvu predpokladam, ze majak tu chcel tie videa filtrovat podla tych podmienok na cas?
Na druhu stranu som si vsimol, ze parsovanie toho suboru je ako metoda `infoboard._parse_schedule`, to by sa tiez mozno dalo presunut sem?

Ale mozno by fakt bolo dobre keby sa tato trieda zrusila uplne a `get_playlist` by bola metoda infoboard
use monoid=None and choose a reasonable default (eg dict of lists) ?
import statement order should be alphabetical.
"Custom sanity check for LAPACK (only run when not testing)"
This relies on window being the global object (so the next var will set it)? This won't work in the shell version, better to use

````
if (typeof SearchArgs == 'undefined') {
````
In case someone wants to create a banner without releasing it in any locales at first. Without it, the form won't submit unless the banner is available in at least one locale.
Unnecessary extra space.

Or, keep it in, and add a TODO that this should be removed once you update to the latest `django-tastypie`, which seems to support `cache_control` on the resource's META
hmm. i think the line changed after the rebase. nevermind!
Well isn't that just much more sane? Cool beans. 

Matthew Riley MacPherson | http://lonelyvegan.com
(Sent from mobile)


On Sunday, 8 April, 2012 at 11:49, Owen Coutts wrote:

> > )
> > +STATIC_ROOT = path('media')
> > +
> > +
> > +MEDIA_URL = '/uploads/'
> > +
> > +# Deprecated with django 1.4
> > 
> 
> 
> No - when you run the `collectstatic` command django collects it all and puts it in your `STATIC_ROOT``. This includes admin stuff. Django then looks for your admin media at `<STATIC_URL>/admin`. So as long as our other static files are served fine, we're good to go.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/mozillians/pull/206/files#r658564
> 
>
This is a config option that must remain '100x100xCR' for the time being, as the Activity API doesn't return bigger sizes except "base" and "original".
Any reason to use @commentable rather than commentable at this point?

(I want this feature lots! :D But I want to make sure it's bulletproof. ;) )
should we mark the spinner differently? so we should not need to handle it differently in JS ?
When you get a variable you don't need it's common practice to use `__`. Ie.:

```
t, __ = Tag.objects.get_or_create(name=tag_name)
```

I think pyflake would have complained about `created` not being used.
Oh. I'm just going off of what I'm seeing in the diff. If this is expected, then no worries.
Might make sense to have some
Imma add a comment that explains why I couldn't get Nexus to give me JSON or anything nice. The next best thing is to look for the Server's 400 response + the error being "Hey where is your staging profile that matches what you are trying to upload?!"
This feels like a lot of duplication but I don't see an obvious fix
Do we need to check for the permission twice?
точно порядок не перепутал?
если использовать size_t, то проверка Б 0 будет не нужна
ey dude
It silently ignores dups. Sets rule.
It would be nice to accept either a JSON string or a map here, as we now do with catalogs. Or even just a map, foregoing the silly stringification.
Changed here and in `init.js`